ruby-trello 2.3.1 → 3.2.0

data/spec/cassettes/webhook_delete.yml

@@ -0,0 +1,286 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://api.trello.com/1/webhooks/5fa8a1e0009b2a6a669e6efa?key=DEVELOPER_PUBLIC_KEY&token=MEMBER_TOKEN
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - "*/*"
+      User-Agent:
+      - rest-client/2.1.0 (linux-gnu x86_64) ruby/2.6.6p146
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Host:
+      - api.trello.com
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      X-Dns-Prefetch-Control:
+      - 'off'
+      X-Frame-Options:
+      - DENY
+      X-Download-Options:
+      - noopen
+      X-Permitted-Cross-Domain-Policies:
+      - none
+      Referrer-Policy:
+      - strict-origin-when-cross-origin
+      Surrogate-Control:
+      - no-store
+      Cache-Control:
+      - max-age=0, must-revalidate, no-cache, no-store
+      Pragma:
+      - no-cache
+      Expires:
+      - Thu, 01 Jan 1970 00:00:00
+      X-Trello-Version:
+      - 1.2278.0
+      X-Trello-Environment:
+      - Production
+      Set-Cookie:
+      - dsc=set_cookie_dsc; Path=/; Expires=Thu, 12 Nov 2020 02:08:29 GMT; Secure
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Methods:
+      - GET, PUT, POST, DELETE
+      Access-Control-Allow-Headers:
+      - Authorization, Accept, Content-Type
+      Access-Control-Expose-Headers:
+      - x-rate-limit-api-key-interval-ms, x-rate-limit-api-key-max, x-rate-limit-api-key-remaining,
+        x-rate-limit-api-token-interval-ms, x-rate-limit-api-token-max, x-rate-limit-api-token-remaining
+      X-Rate-Limit-Api-Key-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Key-Max:
+      - '300'
+      X-Rate-Limit-Api-Key-Remaining:
+      - '299'
+      X-Rate-Limit-Api-Token-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Token-Max:
+      - '100'
+      X-Rate-Limit-Api-Token-Remaining:
+      - '99'
+      X-Rate-Limit-Member-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Member-Max:
+      - '200'
+      X-Rate-Limit-Member-Remaining:
+      - '199'
+      X-Server-Time:
+      - '1604887709725'
+      Content-Type:
+      - application/json; charset=utf-8
+      Date:
+      - Mon, 09 Nov 2020 02:08:29 GMT
+      X-Envoy-Upstream-Service-Time:
+      - '83'
+      Expect-Ct:
+      - report-uri="https://web-security-reports.services.atlassian.com/expect-ct-report/trello-edge",
+        max-age=86400
+      Strict-Transport-Security:
+      - max-age=63072000; preload
+      X-Content-Type-Options:
+      - nosniff
+      X-Xss-Protection:
+      - 1; mode=block
+      Server:
+      - globaledge-envoy
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: ASCII-8BIT
+      string: '{"id":"5fa8a1e0009b2a6a669e6efa","description":"Test - Changed","idModel":"5fa759f1564c6e5bb803c61e","callbackURL":"https://example.com/webhook/trello_callbacks","active":true,"consecutiveFailures":0,"firstConsecutiveFailDate":null}'
+    http_version: null
+  recorded_at: Mon, 09 Nov 2020 02:08:29 GMT
+- request:
+    method: delete
+    uri: https://api.trello.com/1/webhooks/5fa8a1e0009b2a6a669e6efa?key=DEVELOPER_PUBLIC_KEY&token=MEMBER_TOKEN
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - "*/*"
+      User-Agent:
+      - rest-client/2.1.0 (linux-gnu x86_64) ruby/2.6.6p146
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Host:
+      - api.trello.com
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      X-Dns-Prefetch-Control:
+      - 'off'
+      X-Frame-Options:
+      - DENY
+      X-Download-Options:
+      - noopen
+      X-Permitted-Cross-Domain-Policies:
+      - none
+      Referrer-Policy:
+      - strict-origin-when-cross-origin
+      Surrogate-Control:
+      - no-store
+      Cache-Control:
+      - max-age=0, must-revalidate, no-cache, no-store
+      Pragma:
+      - no-cache
+      Expires:
+      - Thu, 01 Jan 1970 00:00:00
+      X-Trello-Version:
+      - 1.2278.0
+      X-Trello-Environment:
+      - Production
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Methods:
+      - GET, PUT, POST, DELETE
+      Access-Control-Allow-Headers:
+      - Authorization, Accept, Content-Type
+      Access-Control-Expose-Headers:
+      - x-rate-limit-api-key-interval-ms, x-rate-limit-api-key-max, x-rate-limit-api-key-remaining,
+        x-rate-limit-api-token-interval-ms, x-rate-limit-api-token-max, x-rate-limit-api-token-remaining
+      X-Rate-Limit-Api-Key-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Key-Max:
+      - '300'
+      X-Rate-Limit-Api-Key-Remaining:
+      - '299'
+      X-Rate-Limit-Api-Token-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Token-Max:
+      - '100'
+      X-Rate-Limit-Api-Token-Remaining:
+      - '99'
+      X-Rate-Limit-Member-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Member-Max:
+      - '200'
+      X-Rate-Limit-Member-Remaining:
+      - '199'
+      X-Server-Time:
+      - '1604887710401'
+      Content-Type:
+      - application/json; charset=utf-8
+      Date:
+      - Mon, 09 Nov 2020 02:08:30 GMT
+      X-Envoy-Upstream-Service-Time:
+      - '80'
+      Expect-Ct:
+      - report-uri="https://web-security-reports.services.atlassian.com/expect-ct-report/trello-edge",
+        max-age=86400
+      Strict-Transport-Security:
+      - max-age=63072000; preload
+      X-Content-Type-Options:
+      - nosniff
+      X-Xss-Protection:
+      - 1; mode=block
+      Server:
+      - globaledge-envoy
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: ASCII-8BIT
+      string: '{"_value":null}
+
+'
+    http_version: null
+  recorded_at: Mon, 09 Nov 2020 02:08:30 GMT
+- request:
+    method: get
+    uri: https://api.trello.com/1/webhooks/5fa8a1e0009b2a6a669e6efa?key=DEVELOPER_PUBLIC_KEY&token=MEMBER_TOKEN
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - "*/*"
+      User-Agent:
+      - rest-client/2.1.0 (linux-gnu x86_64) ruby/2.6.6p146
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Host:
+      - api.trello.com
+  response:
+    status:
+      code: 404
+      message: Not Found
+    headers:
+      X-Dns-Prefetch-Control:
+      - 'off'
+      X-Frame-Options:
+      - DENY
+      X-Download-Options:
+      - noopen
+      X-Permitted-Cross-Domain-Policies:
+      - none
+      Referrer-Policy:
+      - strict-origin-when-cross-origin
+      Surrogate-Control:
+      - no-store
+      Cache-Control:
+      - no-store, no-cache, must-revalidate, proxy-revalidate
+      Pragma:
+      - no-cache
+      Expires:
+      - '0'
+      X-Trello-Version:
+      - 1.2278.0
+      X-Trello-Environment:
+      - Production
+      Set-Cookie:
+      - dsc=set_cookie_dsc; Path=/; Expires=Thu, 12 Nov 2020 02:08:31 GMT; Secure
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Methods:
+      - GET, PUT, POST, DELETE
+      Access-Control-Allow-Headers:
+      - Authorization, Accept, Content-Type
+      Access-Control-Expose-Headers:
+      - x-rate-limit-api-key-interval-ms, x-rate-limit-api-key-max, x-rate-limit-api-key-remaining,
+        x-rate-limit-api-token-interval-ms, x-rate-limit-api-token-max, x-rate-limit-api-token-remaining
+      X-Rate-Limit-Api-Key-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Key-Max:
+      - '300'
+      X-Rate-Limit-Api-Key-Remaining:
+      - '298'
+      X-Rate-Limit-Api-Token-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Token-Max:
+      - '100'
+      X-Rate-Limit-Api-Token-Remaining:
+      - '98'
+      Content-Type:
+      - text/plain; charset=utf-8
+      Content-Length:
+      - '37'
+      Date:
+      - Mon, 09 Nov 2020 02:08:31 GMT
+      X-Envoy-Upstream-Service-Time:
+      - '78'
+      Expect-Ct:
+      - report-uri="https://web-security-reports.services.atlassian.com/expect-ct-report/trello-edge",
+        max-age=86400
+      Strict-Transport-Security:
+      - max-age=63072000; preload
+      X-Content-Type-Options:
+      - nosniff
+      X-Xss-Protection:
+      - 1; mode=block
+      Server:
+      - globaledge-envoy
+    body:
+      encoding: UTF-8
+      string: The requested resource was not found.
+    http_version: null
+  recorded_at: Mon, 09 Nov 2020 02:08:31 GMT
+recorded_with: VCR 5.1.0

data/spec/cassettes/webhook_find_with_id.yml

@@ -0,0 +1,100 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://api.trello.com/1/webhooks/5fa8a1e0009b2a6a669e6efa?key=DEVELOPER_PUBLIC_KEY&token=MEMBER_TOKEN
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept:
+      - "*/*"
+      User-Agent:
+      - rest-client/2.1.0 (linux-gnu x86_64) ruby/2.6.6p146
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Host:
+      - api.trello.com
+  response:
+    status:
+      code: 200
+      message: OK
+    headers:
+      X-Dns-Prefetch-Control:
+      - 'off'
+      X-Frame-Options:
+      - DENY
+      X-Download-Options:
+      - noopen
+      X-Permitted-Cross-Domain-Policies:
+      - none
+      Referrer-Policy:
+      - strict-origin-when-cross-origin
+      Surrogate-Control:
+      - no-store
+      Cache-Control:
+      - max-age=0, must-revalidate, no-cache, no-store
+      Pragma:
+      - no-cache
+      Expires:
+      - Thu, 01 Jan 1970 00:00:00
+      X-Trello-Version:
+      - 1.2278.0
+      X-Trello-Environment:
+      - Production
+      Set-Cookie:
+      - dsc=set_cookie_dsc; Path=/; Expires=Thu, 12 Nov 2020 02:02:32 GMT; Secure
+      Access-Control-Allow-Origin:
+      - "*"
+      Access-Control-Allow-Methods:
+      - GET, PUT, POST, DELETE
+      Access-Control-Allow-Headers:
+      - Authorization, Accept, Content-Type
+      Access-Control-Expose-Headers:
+      - x-rate-limit-api-key-interval-ms, x-rate-limit-api-key-max, x-rate-limit-api-key-remaining,
+        x-rate-limit-api-token-interval-ms, x-rate-limit-api-token-max, x-rate-limit-api-token-remaining
+      X-Rate-Limit-Api-Key-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Key-Max:
+      - '300'
+      X-Rate-Limit-Api-Key-Remaining:
+      - '299'
+      X-Rate-Limit-Api-Token-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Api-Token-Max:
+      - '100'
+      X-Rate-Limit-Api-Token-Remaining:
+      - '99'
+      X-Rate-Limit-Member-Interval-Ms:
+      - '10000'
+      X-Rate-Limit-Member-Max:
+      - '200'
+      X-Rate-Limit-Member-Remaining:
+      - '199'
+      X-Server-Time:
+      - '1604887352812'
+      Content-Type:
+      - application/json; charset=utf-8
+      Date:
+      - Mon, 09 Nov 2020 02:02:32 GMT
+      X-Envoy-Upstream-Service-Time:
+      - '80'
+      Expect-Ct:
+      - report-uri="https://web-security-reports.services.atlassian.com/expect-ct-report/trello-edge",
+        max-age=86400
+      Strict-Transport-Security:
+      - max-age=63072000; preload
+      X-Content-Type-Options:
+      - nosniff
+      X-Xss-Protection:
+      - 1; mode=block
+      Server:
+      - globaledge-envoy
+      Transfer-Encoding:
+      - chunked
+    body:
+      encoding: ASCII-8BIT
+      string: '{"id":"5fa8a1e0009b2a6a669e6efa","description":"test","idModel":"5fa759f1564c6e5bb803c61e","callbackURL":"https://example.com/webhook/trello_callbacks","active":true,"consecutiveFailures":0,"firstConsecutiveFailDate":null}'
+    http_version: null
+  recorded_at: Mon, 09 Nov 2020 02:02:33 GMT
+recorded_with: VCR 5.1.0

data/spec/checklist_spec.rb

@@ -20,7 +20,7 @@ module Trello
       it "delegates to Trello.client#find" do
         expect(client)
           .to receive(:find)
-          .with(:checklist, 'abcdef123456789123456789', {})
+          .with('checklist', 'abcdef123456789123456789', {})
 
         Checklist.find('abcdef123456789123456789')
       end
@@ -35,41 +35,43 @@ module Trello
 
       it 'creates a new record and saves it on Trello', refactor: true do
         payload = {
-            name: 'Test Checklist',
-            desc: '',
-            card_id: cards_details.first['id']
+          name: 'Test Checklist',
+          card_id: '5e94fd9443f25a7263b165d0'
         }
 
-        attributes = checklists_details.first.merge(payload).except("idBoard")
-        result = JSON.generate(attributes)
+        result = JSON.generate(payload)
 
-
-        expected_payload = {name: "Test Checklist", idCard: cards_details.first['id']}
+        expected_payload = {
+          'name' => 'Test Checklist',
+          'idCard' => '5e94fd9443f25a7263b165d0'
+        }
 
         expect(client)
           .to receive(:post)
           .with("/checklists", expected_payload)
           .and_return result
 
-        checklist = Checklist.create(attributes)
+        checklist = Checklist.create(payload)
 
         expect(checklist).to be_a Checklist
       end
 
       it 'initializes all fields from response-like hash' do
-        checklist_details = checklists_details.first
-        checklist = Checklist.new(checklist_details)
-        expect(checklist.id).to          eq checklist_details['id']
-        expect(checklist.name).to        eq checklist_details['name']
-        expect(checklist.description).to eq checklist_details['desc']
-        expect(checklist.closed).to      eq checklist_details['closed']
-        expect(checklist.position).to    eq checklist_details['pos']
-        expect(checklist.url).to         eq checklist_details['url']
-        expect(checklist.board_id).to    eq checklist_details['idBoard']
-        expect(checklist.card_id).to     eq checklist_details['idCard']
-        expect(checklist.list_id).to     eq checklist_details['idList']
-        expect(checklist.member_ids).to  eq checklist_details['idMembers']
-        expect(checklist.check_items).to eq checklist_details['checkItems']
+        checklist = Checklist.new(
+          'id'         => 'abcdef123456789123456789',
+          'name'       => 'Test Checklist',
+          'pos'        => 16384,
+          'idBoard'    => 'abcdef123456789123456789',
+          'idCard'     => 'abccardid',
+          'checkItems' => { 'id' => 'ghijk987654321' }
+        )
+
+        expect(checklist.id).to          eq 'abcdef123456789123456789'
+        expect(checklist.name).to        eq 'Test Checklist'
+        expect(checklist.position).to    eq 16384
+        expect(checklist.board_id).to    eq 'abcdef123456789123456789'
+        expect(checklist.card_id).to     eq 'abccardid'
+        expect(checklist.check_items).to eq({ 'id' => 'ghijk987654321' })
       end
 
       it 'initializes required fields from options-like hash' do
@@ -113,7 +115,7 @@ module Trello
         result = JSON.generate(checklists_details.first)
         expect(client)
           .to receive(:put)
-          .once.with(expected_resource, payload)
+          .once.with(expected_resource, {'name' => expected_new_name})
           .and_return result
 
         checklist.name = expected_new_name
@@ -132,7 +134,7 @@ module Trello
         expect(client)
           .to receive(:put)
           .once
-          .with(expected_resource, payload)
+          .with(expected_resource, {'pos' => expected_new_position})
           .and_return result
 
         checklist.position = expected_new_position
@@ -197,19 +199,6 @@ module Trello
       end
     end
 
-    context "list" do
-      before do
-        allow(client)
-          .to receive(:get)
-          .with("/lists/abcdef123456789123456789", {})
-          .and_return JSON.generate(lists_details.first)
-      end
-
-      it 'has a list' do
-        expect(checklist.list).to_not be_nil
-      end
-    end
-
     context "making a copy" do
       let(:client) { Trello.client }
       let(:copy_options) { { :name => checklist.name, :idCard => checklist.card_id } }
@@ -218,7 +207,7 @@ module Trello
       before(:each) do
         allow(client)
           .to receive(:post)
-          .with("/checklists", copy_options)
+          .with("/checklists", copy_options.stringify_keys)
           .and_return JSON.generate(copied_checklists_details.first)
 
         allow(checklist)
@@ -271,15 +260,10 @@ module Trello
         expected = {
           'id' => 'id',
           'name' => 'name',
-          'desc' => 'description',
-          'closed' => 'closed',
-          'url' => 'url',
           'checkItems' => 'check_items',
           'pos' => 'position',
           'idBoard' => 'board_id',
           'idCard' => 'card_id',
-          'idList' => 'list_id',
-          'idMembers' => 'member_ids'
         }
 
         checklist = Checklist.new(expected)

data/spec/client_spec.rb

@@ -1,4 +1,6 @@
 require "spec_helper"
+require "rest-client"
+require "faraday"
 
 include Trello
 include Trello::Authorization
@@ -18,11 +20,16 @@ describe Client do
   end
 
   describe "and how it handles RestClient exceptions" do
+
+    before do
+      Trello.http_client = 'rest-client'
+    end
+
     context "with RestClient::Exception sans HTTP code" do
       let(:rc_exception_without_http_code) { RestClient::Exception.new }
 
       before do
-        allow(TInternet)
+        allow(Trello::TRestClient::TInternet)
           .to receive(:execute_core)
           .and_raise(rc_exception_without_http_code)
       end
@@ -39,14 +46,61 @@ describe Client do
       let(:rc_exception_with_http_code) { RestClient::Exception.new(double("404 error response", {:code => 404, :body => "404 error response"}))}
 
       before do
-        allow(TInternet)
+        allow(Trello::TRestClient::TInternet)
           .to receive(:execute_core)
           .and_raise(rc_exception_with_http_code)
       end
 
       it "raises Error" do
 
-        expect(TInternet)
+        expect(Trello::TRestClient::TInternet)
+          .to receive(:try_execute)
+          .and_return(response_with_non_200_status)
+
+        expect { client.get "/xxx" }.to raise_error do |error|
+          expect(error).to be_a(Error)
+          expect(error.message).to eq("404 error response")
+          expect(error.status_code).to eq(404)
+        end
+      end
+    end
+  end
+
+  describe "and how it handles Faraday errors" do
+
+    before do
+      Trello.http_client = 'faraday'
+    end
+
+    context "with Faraday::Error sans HTTP code" do
+      let(:faraday_error_without_http_code) { Faraday::Error.new("Test error") }
+
+      before do
+        allow(Trello::TFaraday::TInternet)
+          .to receive(:execute_core)
+          .and_raise(faraday_error_without_http_code)
+      end
+
+      it "bubbles up Faraday::Error errors that don't contain an HTTP code" do
+        expect { client.get "/xxx" }.to raise_error faraday_error_without_http_code
+      end
+    end
+
+    context "with Faraday::Error that contains HTTP code" do
+      let(:response_with_non_200_status) { double "A fake 404 response",
+                                              code: 404,
+                                              body: "404 error response"}
+      let(:faraday_error_with_http_code) { Faraday::Error.new(double("404 error response", {:code => 404, :body => "404 error response"}))}
+
+      before do
+        allow(Trello::TFaraday::TInternet)
+          .to receive(:execute_core)
+          .and_raise(faraday_error_with_http_code)
+      end
+
+      it "raises Error" do
+
+        expect(Trello::TFaraday::TInternet)
           .to receive(:try_execute)
           .and_return(response_with_non_200_status)
 

data/spec/configuration_spec.rb

@@ -19,6 +19,19 @@ describe Trello::Configuration do
     end
   end
 
+  it "only allows http_client to be set to one of Trello::HTTP_CLIENTS" do
+    Trello::HTTP_CLIENTS.each do |key, _client|
+      configuration.http_client = key
+      expect(configuration.http_client).to eq key
+    end
+  end
+
+  it "raises an error if an invalid http_client is set" do
+    expect {
+      configuration.http_client = :invalid_http_client
+    }.to raise_error(ArgumentError)
+  end
+
   it 'has a callback (for oauth)' do
     callback = -> { 'foobar' }
     configuration.callback = callback

data/spec/custom_field_item_spec.rb

@@ -140,7 +140,7 @@ module Trello
           it 'custom field item does set the changed fields' do
             text_item.update_fields(fields)
 
-            expect(text_item.value).to eq( { number: '42' } )
+            expect(text_item.value).to eq( { 'number' => '42' } )
           end
 
           it 'card has been mark as changed' do
@@ -159,7 +159,7 @@ module Trello
             expect(text_item.value).to eq(text_field_details['value'])
           end
 
-          it "custom field item hasn't been mark as changed", pending: true do
+          it "custom field item hasn't been mark as changed" do
             text_item.update_fields(fields)
 
             expect(text_item.changed?).to be_falsy

data/spec/custom_field_option_spec.rb

@@ -27,8 +27,8 @@ module Trello
         expect(option.value).to eq custom_field_option_details['value']
       end
 
-      it 'gets its pos' do
-        expect(option.pos).to eq custom_field_option_details['pos']
+      it 'gets its position' do
+        expect(option.position).to eq custom_field_option_details['pos']
       end
     end