ruby-trello 2.0.1 → 3.0.0

data/lib/trello/webhook.rb

@@ -5,86 +5,33 @@ module Trello
   #   @return [String]
   # @!attribute [r] description
   #   @return [String]
-  # @!attribute [r] id_model
+  # @!attribute [r] model_id
   #   @return [String] A 24-character hex string
   # @!attribute [r] callback_url
   #   @return [String]
   # @!attribute [r] active
   #   @return [Boolean]
+  # @!attribute [r] consecutive_failures
+  #   @return [Integer]
+  # @!attribute [r] first_consecutive_fail_date
+  #   @return [Datetime]
   class Webhook < BasicData
-    register_attributes :id, :description, :id_model, :callback_url, :active,
-      readonly: [ :id ]
-    validates_presence_of :id, :id_model, :callback_url
-    validates_length_of   :description,  in: 1..16384
 
-    class << self
-      # Find a specific webhook by its ID.
-      #
-      # @raise [Trello::Error] if a Webhook with the given ID can't be found.
-      # @return [Trello::Webhook] the Webhook with the given ID.
-      def find(id, params = {})
-        client.find(:webhook, id, params)
-      end
-
-      # Create a new webhook and save it to Trello.
-      #
-      # @param [Hash] options
-      #
-      # @option options [String] :description (optional) A string with a length from 0 to 16384
-      # @option options [String] :callback_url (required) A valid URL that is
-      #    reachable with a HEAD request
-      # @option options [String] :id_model (required) id of the model that should be hooked
-      #
-      # @raise [Trello::Error] if the Webhook could not be created.
-      #
-      # @return [Trello::Webhook]
-      def create(options)
-        client.create(:webhook,
-            'description' => options[:description],
-            'idModel'     => options[:id_model],
-            'callbackURL' => options[:callback_url])
-      end
-    end
-
-    # @return [Trello::Webhook] self
-    def update_fields(fields)
-      attributes[:id]              = fields['id'] || attributes[:id]
-      attributes[:description]     = fields['description'] || fields[:description] || attributes[:description]
-      attributes[:id_model]        = fields['idModel'] || fields[:id_model] || attributes[:id_model]
-      attributes[:callback_url]    = fields['callbackURL'] || fields[:callback_url] || attributes[:callback_url]
-      attributes[:active]          = fields['active'] if fields.has_key?('active')
-      self
+    schema do
+      # Readonly
+      attribute :id, readonly: true, primary_key: true
+      attribute :consecutive_failures, readonly: true, remote_key: 'consecutiveFailures'
+      attribute :first_consecutive_fail_date, readonly: true, remote_key: 'firstConsecutiveFailDate', serializer: 'Time'
+
+      # Writable
+      attribute :description
+      attribute :model_id, remote_key: 'idModel'
+      attribute :callback_url, remote_key: 'callbackURL'
+      attribute :active
     end
 
-    # Save the webhook.
-    #
-    # @raise  [Trello::Error] if the Webhook could not be saved.
-    #
-    # @return [String] the JSON representation of the saved webhook.
-    def save
-      # If we have an id, just update our fields.
-      return update! if id
-
-      from_response client.post("/webhooks", {
-        description: description,
-        idModel: id_model,
-        callbackURL: callback_url
-      })
-    end
-
-    # Update the webhook.
-    #
-    # @raise  [Trello::Error] if the Webhook could not be saved.
-    #
-    # @return [String] the JSON representation of the updated webhook.
-    def update!
-      client.put("/webhooks/#{id}", {
-        description: description,
-        idModel: id_model,
-        callbackURL: callback_url,
-        active: active
-      })
-    end
+    validates_presence_of :id, :model_id, :callback_url
+    validates_length_of :description, in: 1..16384
 
     # Delete this webhook
     #

data/spec/action_spec.rb

@@ -116,7 +116,7 @@ module Trello
       before do
         allow(client)
           .to receive(:get)
-          .with('/members/abcdef123456789123456789', {})
+          .with('/actions/4ee2482134a81a757a08af47/memberCreator')
           .and_return user_payload
       end
 
@@ -131,8 +131,7 @@ module Trello
           'id' => 'id',
           'type' => 'type',
           'data' => 'data',
-          'idMemberCreator' => 'member_creator_id',
-          'member' => 'member_participant'
+          'idMemberCreator' => 'creator_id'
         }
 
         action = Action.new(expected)

data/spec/basic_data_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+
+module Trello
+  describe BasicData do
+    describe "equality" do
+      specify "two objects of the same type are equal if their id values are equal" do
+        data_object = Card.new('id' => 'abc123')
+        other_data_object = Card.new('id' => 'abc123')
+
+        expect(data_object).to eq(other_data_object)
+      end
+
+      specify "two object of the samy type are not equal if their id values are different" do
+        data_object = Card.new('id' => 'abc123')
+        other_data_object = Card.new('id' => 'def456')
+
+        expect(data_object).not_to eq(other_data_object)
+      end
+
+      specify "two object of different types are not equal even if their id values are equal" do
+        card = Card.new('id' => 'abc123')
+        list = List.new('id' => 'abc123')
+
+        expect(card.id).to eq(list.id)
+        expect(card).to_not eq(list)
+      end
+    end
+
+    describe "hash equality" do
+      specify "two objects of the same type point to the same hash key" do
+        data_object = Card.new('id' => 'abc123')
+        other_data_object = Card.new('id' => 'abc123')
+
+        hash = {data_object => 'one'}
+
+        expect(hash[other_data_object]).to eq('one')
+      end
+
+      specify "two object of the same type with different ids do not point to the same hash key" do
+        data_object = Card.new('id' => 'abc123')
+        other_data_object = Card.new('id' => 'def456')
+
+        hash = {data_object => 'one'}
+
+        expect(hash[other_data_object]).to be_nil
+      end
+
+      specify "two object of different types with same ids do not point to the same hash key" do
+        card = Card.new('id' => 'abc123')
+        list = List.new('id' => 'abc123')
+
+        hash = {card => 'one'}
+
+        expect(hash[list]).to be_nil
+      end
+    end
+  end
+end

data/spec/board_spec.rb

@@ -6,7 +6,7 @@ module Trello
 
     let(:board) { client.find(:board, 'abcdef123456789123456789') }
     let(:client) { Client.new }
-    let(:member) { Member.new(user_payload) }
+    let(:member) { Member.new(JSON.parse(user_payload)) }
 
     before do
       allow(client)
@@ -21,7 +21,7 @@ module Trello
       it "delegates to client#find" do
         expect(client)
           .to receive(:find)
-          .with(:board, 'abcdef123456789123456789', {})
+          .with('board', 'abcdef123456789123456789', {})
 
         Board.find('abcdef123456789123456789')
       end
@@ -31,6 +31,35 @@ module Trello
       end
     end
 
+    describe '.create' do
+      before { allow(Board).to receive(:client).and_return(client) }
+
+      it 'will call create on client with correct parameters' do
+        params = {
+          name: 'Board Name',
+          use_default_labels: true,
+          use_default_lists: true,
+          description: 'description...',
+          organization_id: 11111,
+          source_board_id: 22222,
+          keep_cards_from_source: true,
+          power_ups: 'all',
+          visibility_level: 'org',
+          voting_permission_level: 'org',
+          comment_permission_level: 'org',
+          invitation_permission_level: 'admins',
+          enable_self_join: true,
+          enable_card_covers: true,
+          background_color: 'orange',
+          card_aging_type: 'pirate'
+        }
+
+        expect(client).to receive(:create).with('board', params)
+
+        Board.create(params)
+      end
+    end
+
     context "self.all" do
       let(:client) { Trello.client }
 
@@ -133,12 +162,10 @@ module Trello
         expect(labels[2].id).to  eq('cbcdef123456789123456789')
         expect(labels[2].board_id).to  eq('abcdef123456789123456789')
         expect(labels[2].name).to  eq('deploy')
-        expect(labels[2].uses).to  eq(2)
         expect(labels[3].color).to  eq('blue')
         expect(labels[3].id).to  eq('dbcdef123456789123456789')
         expect(labels[3].board_id).to  eq('abcdef123456789123456789')
         expect(labels[3].name).to  eq('on hold')
-        expect(labels[3].uses).to  eq(6)
       end
 
       it "passes the label limit" do
@@ -170,7 +197,7 @@ module Trello
       it "adds a member to the board as a normal user (default)" do
         expect(client)
           .to receive(:put)
-          .with("/boards/abcdef123456789123456789/members/id", type: :normal)
+          .with("/boards/abcdef123456789123456789/members/#{member.id}", type: :normal)
 
         board.add_member(member)
       end
@@ -178,7 +205,7 @@ module Trello
       it "adds a member to the board as an admin" do
         expect(client)
           .to receive(:put)
-          .with("/boards/abcdef123456789123456789/members/id", type: :admin)
+          .with("/boards/abcdef123456789123456789/members/#{member.id}", type: :admin)
 
         board.add_member(member, :admin)
       end
@@ -193,7 +220,7 @@ module Trello
       it "removes a member from the board" do
         expect(client)
           .to receive(:delete)
-          .with("/boards/abcdef123456789123456789/members/id")
+          .with("/boards/abcdef123456789123456789/members/#{member.id}")
 
         board.remove_member(member)
       end
@@ -251,62 +278,28 @@ module Trello
       end
     end
 
-    it "is not closed" do
-      expect(board).not_to be_closed
-    end
-
-    it "is not starred" do
-      expect(board).not_to be_starred
-    end
-
-    describe "#update_fields" do
-      it "does not set any fields when the fields argument is empty" do
-        expected = {
-         'id' => "id",
-         'name' => "name",
-         'desc' => "desc",
-         'closed' => false,
-         'starred' => false,
-         'url' => "url",
-         'idOrganization' => "org_id"
-        }
-
-        board = Board.new(expected)
-        board.client = client
-
-        board.update_fields({})
-
-        expected.each_pair do |key, value|
-          if board.respond_to?(key)
-            expect(board.send(key)).to eq value
-          end
-        end
+    context "custom fields" do
+      before do
+        allow(client)
+          .to receive(:get)
+          .with("/boards/abcdef123456789123456789/customFields", {})
+          .and_return JSON.generate([custom_fields_details.first])
+      end
 
-        expect(board.description).to eq expected['desc']
-        expect(board.organization_id).to eq expected['idOrganization']
+      it "has custom fields" do
+        expect(board.custom_fields.count).to be > 0
       end
+    end
 
-      it "initializes all fields from response-like formatted hash" do
-        board_details = boards_details.first
-        board = Board.new(board_details)
-        expect(board.id).to                 eq board_details['id']
-        expect(board.name).to               eq board_details['name']
-        expect(board.description).to        eq board_details['desc']
-        expect(board.closed).to             eq board_details['closed']
-        expect(board.starred).to            eq board_details['starred']
-        expect(board.organization_id).to    eq board_details['idOrganization']
-        expect(board.url).to                eq board_details['url']
-        expect(board.last_activity_date).to eq board_details['dateLastActivity']
+    describe '#closed?' do
+      it "returns the closed attribute" do
+        expect(board.closed?).to be_falsy
       end
+    end
 
-      it "initializes all fields from options-like formatted hash" do
-        board_details = boards_details[1]
-        board = Board.new(board_details)
-        expect(board.name).to            eq board_details[:name]
-        expect(board.description).to     eq board_details[:desc]
-        expect(board.closed).to          eq board_details[:closed]
-        expect(board.starred).to         eq board_details[:starred]
-        expect(board.organization_id).to eq board_details[:organization_id]
+    describe '#starred?' do
+      it "returns the starred attribute" do
+        expect(board.starred?).to be_falsy
       end
     end
 
@@ -329,17 +322,6 @@ module Trello
         }.to raise_error(Trello::ConfigurationError)
       end
 
-      it "puts all fields except id" do
-        expected_fields = %w{ name description closed starred idOrganization}.map { |s| s.to_sym }
-
-        expect(client).to receive(:put) do |anything, body|
-          expect(body.keys).to match expected_fields
-          any_board_json
-        end
-
-        Board.new('id' => "xxx").save
-      end
-
       it "mutates the current instance" do
         allow(client)
           .to receive(:put)
@@ -353,7 +335,7 @@ module Trello
         expected_resource_id = "xxx_board_id_xxx"
 
         expect(client).to receive(:put) do |path, anything|
-          expect(path).to match(/#{expected_resource_id}\/\z/)
+          expect(path).to match(/#{expected_resource_id}\z/)
           any_board_json
         end
 
@@ -363,35 +345,6 @@ module Trello
       it "saves OR updates depending on whether or not it has an id set"
     end
 
-    describe '#update!' do
-      let(:client) { Trello.client }
-
-      let(:any_board_json) do
-        JSON.generate(boards_details.first)
-      end
-
-      it "puts basic attributes" do
-        board = Board.new 'id' => "board_id"
-
-        board.name        = "new name"
-        board.description = "new description"
-        board.closed      = true
-        board.starred     = true
-
-        expect(client)
-          .to receive(:put)
-          .with("/boards/#{board.id}/", {
-            name: "new name",
-            description: "new description",
-            closed: true,
-            starred: true,
-            idOrganization: nil })
-          .and_return any_board_json
-
-        board.update!
-      end
-    end
-
     describe "Repository" do
       include Helpers
 
@@ -408,7 +361,7 @@ module Trello
 
       it "creates a new board with whatever attributes are supplied " do
         expected_attributes = { name: "Any new board name", description: "Any new board desription" }
-        sent_attributes = { name: expected_attributes[:name], desc: expected_attributes[:description] }
+        sent_attributes = { 'name' => expected_attributes[:name], 'desc' => expected_attributes[:description] }
 
         expect(client)
           .to receive(:post)

data/spec/card_spec.rb

@@ -25,7 +25,7 @@ module Trello
       it "delegates to Trello.client#find" do
         expect(client)
           .to receive(:find)
-          .with(:card, 'abcdef123456789123456789', {})
+          .with('card', 'abcdef123456789123456789', {})
 
         Card.find('abcdef123456789123456789')
       end
@@ -62,7 +62,8 @@ module Trello
         expect(card.url).to                eq(card_details['url'])
         expect(card.short_url).to          eq(card_details['shortUrl'])
         expect(card.pos).to                eq(card_details['pos'])
-        expect(card.last_activity_date).to eq(card_details['dateLastActivity'])
+        expect(card.last_activity_date).to be_a(Time)
+        expect(card.last_activity_date).to eq(Time.iso8601(card_details['dateLastActivity']))
       end
 
       it 'properly initializes all fields from options-like formatted hash' do
@@ -73,7 +74,7 @@ module Trello
         expect(card.desc).to                   eq(card_details[:desc])
         expect(card.member_ids).to             eq(card_details[:member_ids])
         expect(card.card_labels).to            eq(card_details[:card_labels])
-        expect(card.due).to                    eq(card_details[:due])
+        expect(card.due).to                    eq(card_details[:due].to_time)
         expect(card.pos).to                    eq(card_details[:pos])
         expect(card.source_card_id).to         eq(card_details[:source_card_id])
         expect(card.source_card_properties).to eq(card_details[:source_card_properties])
@@ -96,17 +97,18 @@ module Trello
           card_labels: "abcdef123456789123456789"
         }
 
-        result = JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
-
-        expected_payload = {name: "Test Card", desc: nil, idList: "abcdef123456789123456789",
-                            idMembers: nil, idLabels: "abcdef123456789123456789", pos: nil, due: nil, dueComplete: false, idCardSource: nil, keepFromSource: 'all'}
+        expected_payload = {
+          'name' => "Test Card",
+          'idList' => "abcdef123456789123456789",
+          'idLabels' => "abcdef123456789123456789",
+        }
 
         expect(client)
           .to receive(:post)
           .with("/cards", expected_payload)
-          .and_return result
+          .and_return JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
 
-        card = Card.create(cards_details.first.merge(payload.merge(list_id: lists_details.first['id'])))
+        card = Card.create(payload.merge(list_id: lists_details.first['id']))
 
         expect(card).to be_a Card
       end
@@ -118,15 +120,17 @@ module Trello
 
         result = JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
 
-        expected_payload = {name: nil, desc: nil, idList: "abcdef123456789123456789",
-                            idMembers: nil, idLabels: nil, pos: nil, due: nil, dueComplete: false, idCardSource: cards_details.first['id'], keepFromSource: 'all'}
+        expected_payload = {
+          'idList' => "abcdef123456789123456789",
+          'idCardSource' => cards_details.first['id'],
+        }
 
         expect(client)
           .to receive(:post)
           .with("/cards", expected_payload)
           .and_return result
 
-        card = Card.create(cards_details.first.merge(payload.merge(list_id: lists_details.first['id'])))
+        card = Card.create(payload.merge(list_id: lists_details.first['id']))
 
         expect(card).to be_a Card
       end
@@ -139,15 +143,18 @@ module Trello
 
         result = JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
 
-        expected_payload = {name: nil, desc: nil, idList: "abcdef123456789123456789",
-                            idMembers: nil, idLabels: nil, pos: nil, due: nil, dueComplete: false, idCardSource: cards_details.first['id'], keepFromSource: ['due', 'checklists']}
+        expected_payload = {
+          'idList' => "abcdef123456789123456789",
+          'idCardSource' => cards_details.first['id'],
+          'keepFromSource' => ['due', 'checklists']
+        }
 
         expect(client)
           .to receive(:post)
           .with("/cards", expected_payload)
           .and_return result
 
-        card = Card.create(cards_details.first.merge(payload.merge(list_id: lists_details.first['id'])))
+        card = Card.create(payload.merge(list_id: lists_details.first['id']))
 
         expect(card).to be_a Card
       end
@@ -160,15 +167,17 @@ module Trello
 
         result = JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
 
-        expected_payload = {name: nil, desc: nil, idList: "abcdef123456789123456789",
-                            idMembers: nil, idLabels: nil, pos: nil, due: nil, dueComplete: false, idCardSource: cards_details.first['id'], keepFromSource: nil}
+        expected_payload = {
+          'idList' => "abcdef123456789123456789",
+          'idCardSource' => cards_details.first['id'],
+        }
 
         expect(client)
           .to receive(:post)
           .with("/cards", expected_payload)
           .and_return result
 
-        card = Card.create(cards_details.first.merge(payload.merge(list_id: lists_details.first['id'])))
+        card = Card.create(payload.merge(list_id: lists_details.first['id']))
 
         expect(card).to be_a Card
       end
@@ -180,13 +189,14 @@ module Trello
         expected_new_name = "xxx"
 
         payload = {
-          name: expected_new_name,
+          'name' => expected_new_name,
         }
 
         expect(client)
           .to receive(:put)
           .once
           .with("/cards/abcdef123456789123456789", payload)
+          .and_return(payload.to_json)
 
         card.name = expected_new_name
         card.save
@@ -196,10 +206,13 @@ module Trello
         expected_new_desc = "xxx"
 
         payload = {
-          desc: expected_new_desc,
+          'desc' => expected_new_desc,
         }
 
-        expect(client).to receive(:put).once.with("/cards/abcdef123456789123456789", payload)
+        expect(client)
+          .to receive(:put).once
+          .with("/cards/abcdef123456789123456789", payload)
+          .and_return(payload.to_json)
 
         card.desc = expected_new_desc
         card.save
@@ -257,7 +270,6 @@ module Trello
         expect(card.pos).to_not be_nil
       end
 
-
       it 'gets its creation time' do
         expect(card.created_at).to be_kind_of Time
       end
@@ -308,7 +320,7 @@ module Trello
       before do
         allow(client)
           .to receive(:get)
-          .with("/attachments/abcdef123456789123456789", {})
+          .with("/cards/#{card.id}/attachments/abcdef123456789123456789", {})
           .and_return JSON.generate(attachments_details.first)
       end
 
@@ -338,6 +350,50 @@ module Trello
       end
     end
 
+    context "custom field items" do
+      before do
+        allow(client)
+          .to receive(:get)
+          .with("/cards/abcdef123456789123456789/customFieldItems", {})
+          .and_return JSON.generate([custom_field_item_details])
+      end
+
+      it "has a list of custom field items" do
+        expect(card.custom_field_items.count).to be > 0
+      end
+
+      it "clears the custom field value on a card" do
+        params = { value: {} }
+
+        expect(client)
+          .to receive(:put)
+          .with("/cards/abcdef123456789123456789/customField/abcdef123456789123456789/item", params)
+
+        card.custom_field_items.last.remove
+      end
+
+      it "updates a custom field value" do
+        payload = { 'value' => { 'text' => 'Test Text' } }
+
+        expect(client)
+          .to receive(:put)
+          .with("/cards/abcdef123456789123456789/customField/abcdef123456789123456789/item", payload)
+          .and_return(JSON.generate({
+            "id" => "5e68e885e4baf545ec8ce7ba",
+            "value" => {
+              "text" => "Test Text"
+            },
+            "idCustomField" => "abcdef123456789123456789",
+            "idModel" => "abcdef123456789123456789",
+            "modelType" => "card"
+          }))
+
+        text_custom_field = card.custom_field_items.last
+        text_custom_field.value = { text: 'Test Text' }
+        text_custom_field.save
+      end
+    end
+
     context "list" do
       before do
         allow(client)
@@ -345,6 +401,7 @@ module Trello
           .with("/lists/abcdef123456789123456789", {})
           .and_return JSON.generate(lists_details.first)
       end
+
       it 'has a list' do
         expect(card.list).to_not be_nil
       end
@@ -438,7 +495,7 @@ module Trello
         card.move_to_list_on_any_board(other_list.id)
       end
 
-      it 'should not be moved if new board is identical with old board', focus: true do
+      it 'should not be moved if new board is identical with old board' do
         other_board = double(id: 'abcdef123456789123456789')
         expect(client).to_not receive(:put)
         card.move_to_board(other_board)
@@ -454,7 +511,7 @@ module Trello
 
         allow(client)
           .to receive(:get)
-          .with("/members/abcdef123456789123456789")
+          .with("/cards/abcdef123456789123456789/members")
           .and_return user_payload
       end
 
@@ -471,7 +528,7 @@ module Trello
 
         expect(client)
           .to receive(:post)
-          .with("/cards/abcdef123456789123456789/members", payload)
+          .with("/cards/abcdef123456789123456789/idMembers", payload)
 
         card.add_member(new_member)
       end
@@ -481,7 +538,7 @@ module Trello
 
         expect(client)
           .to receive(:delete)
-          .with("/cards/abcdef123456789123456789/members/#{existing_member.id}")
+          .with("/cards/abcdef123456789123456789/idMembers/#{existing_member.id}")
 
         card.remove_member(existing_member)
       end
@@ -556,7 +613,6 @@ module Trello
       end
     end
 
-
     context "comments" do
       it "posts a comment" do
         expect(client)
@@ -588,12 +644,10 @@ module Trello
         expect(labels[0].id).to       eq('abcdef123456789123456789')
         expect(labels[0].board_id).to eq('abcdef123456789123456789')
         expect(labels[0].name).to     eq('iOS')
-        expect(labels[0].uses).to     eq(3)
         expect(labels[1].color).to    eq('purple')
         expect(labels[1].id).to       eq('bbcdef123456789123456789')
         expect(labels[1].board_id).to eq('abcdef123456789123456789')
         expect(labels[1].name).to     eq('Issue or bug')
-        expect(labels[1].uses).to     eq(1)
       end
 
       it "includes label ids list" do
@@ -653,18 +707,18 @@ module Trello
 
         first_plugin = card.plugin_data.first
         expect(first_plugin.id).to eq plugin_data_details[0]["id"]
-        expect(first_plugin.idPlugin).to eq plugin_data_details[0]["idPlugin"]
+        expect(first_plugin.plugin_id).to eq plugin_data_details[0]["idPlugin"]
         expect(first_plugin.scope).to eq plugin_data_details[0]["scope"]
-        expect(first_plugin.idModel).to eq plugin_data_details[0]["idModel"]
-        expect(first_plugin.value).to eq JSON.parse plugin_data_details[0]["value"]
+        expect(first_plugin.model_id).to eq plugin_data_details[0]["idModel"]
+        expect(first_plugin.value).to eq plugin_data_details[0]["value"]
         expect(first_plugin.access).to eq plugin_data_details[0]["access"]
 
         second_plugin = card.plugin_data[1]
         expect(second_plugin.id).to eq plugin_data_details[1]["id"]
-        expect(second_plugin.idPlugin).to eq plugin_data_details[1]["idPlugin"]
+        expect(second_plugin.plugin_id).to eq plugin_data_details[1]["idPlugin"]
         expect(second_plugin.scope).to eq plugin_data_details[1]["scope"]
-        expect(second_plugin.idModel).to eq plugin_data_details[1]["idModel"]
-        expect(second_plugin.value).to eq JSON.parse plugin_data_details[1]["value"]
+        expect(second_plugin.model_id).to eq plugin_data_details[1]["idModel"]
+        expect(second_plugin.value).to eq plugin_data_details[1]["value"]
         expect(second_plugin.access).to eq plugin_data_details[1]["access"]
 
       end
@@ -748,12 +802,13 @@ module Trello
 
     describe "#close!" do
       it "updates the close attribute to true and saves the list" do
-        payload = { closed: true }
+        payload = { 'closed' => true }
 
         expect(client)
           .to receive(:put)
           .once
           .with("/cards/abcdef123456789123456789", payload)
+          .and_return(payload.to_json)
 
         card.close!
       end
@@ -764,57 +819,113 @@ module Trello
         due_date = Time.now
 
         payload = {
-          due: due_date,
+          'due' => due_date.strftime('%FT%T.%LZ'),
         }
 
         expect(client)
           .to receive(:put)
           .once
           .with("/cards/abcdef123456789123456789", payload)
+          .and_return(payload.to_json)
 
         card.due = due_date
         card.save
 
         expect(card.due).to_not be_nil
+      end
+    end
 
-        payload = {
-          dueComplete: true
-        }
+    describe '#update_fields' do
+      context 'when the fields argument is empty' do
+        let(:fields) { {} }
 
-        expect(client)
-          .to receive(:put)
-          .once
-          .with("/cards/abcdef123456789123456789", payload)
+        it 'card does not set any fields' do
+          expected = cards_details.first
 
-        card.due_complete = true
-        card.save
+          card = Card.new(expected)
+          card.client = client
+
+          card.update_fields(fields)
 
-        expect(card.due_complete).to be true
+          expected.each do |key, value|
+            if card.respond_to?(key) && key != 'labels'
+              expect(card.send(key)).to eq value
+            end
+
+            expect(card.labels).to eq expected['labels'].map { |lbl| Trello::Label.new(lbl) }
+            expect(card.short_id).to eq expected['idShort']
+            expect(card.short_url).to eq expected['shortUrl']
+            expect(card.board_id).to eq expected['idBoard']
+            expect(card.member_ids).to eq expected['idMembers']
+            expect(card.cover_image_id).to eq expected['idAttachmentCover']
+            expect(card.list_id).to eq expected['idList']
+            expect(card.card_labels).to eq expected['idLabels']
+          end
+        end
       end
-    end
 
-    describe "#update_fields" do
-      it "does not set any fields when the fields argument is empty" do
-        expected = cards_details.first
+      context 'when the fields argument has at least one field' do
+        let(:expected) { cards_details.first }
+        let(:card) {
+          card = Card.new(expected)
+          card.client = client
+          card
+        }
 
-        card = Card.new(expected)
-        card.client = client
+        context 'and the field does changed' do
+          let(:fields) { { desc: 'Awesome things have changed.' } }
 
-        card.update_fields({})
+          it 'card does set the changed fields' do
+            card.update_fields(fields)
 
-        expected.each do |key, value|
-          if card.respond_to?(key) && key != 'labels'
-            expect(card.send(key)).to eq value
+            expect(card.desc).to eq('Awesome things have changed.')
           end
 
-          expect(card.labels).to eq expected['labels'].map { |lbl| Trello::Label.new(lbl) }
-          expect(card.short_id).to eq expected['idShort']
-          expect(card.short_url).to eq expected['shortUrl']
-          expect(card.board_id).to eq expected['idBoard']
-          expect(card.member_ids).to eq expected['idMembers']
-          expect(card.cover_image_id).to eq expected['idAttachmentCover']
-          expect(card.list_id).to eq expected['idList']
-          expect(card.card_labels).to eq expected['idLabels']
+          it 'card has been mark as changed' do
+            card.update_fields(fields)
+
+            expect(card.changed?).to be_truthy
+          end
+        end
+
+        context "and the field doesn't changed" do
+          let(:fields) { { desc: expected['desc'] } }
+
+          it "card attributes doesn't changed" do
+            card.update_fields(fields)
+
+            expect(card.desc).to eq(expected['desc'])
+          end
+
+          it "card hasn't been mark as changed" do
+            card.update_fields(fields)
+
+            expect(card.changed?).to be_falsy
+          end
+        end
+
+        context "and the field isn't a correct attributes of the card" do
+          let(:fields) { { abc: 'abc' } }
+
+          it "card attributes doesn't changed" do
+            card.update_fields(fields)
+
+            expect(card.labels).to eq expected['labels'].map { |lbl| Trello::Label.new(lbl) }
+            expect(card.short_id).to eq expected['idShort']
+            expect(card.short_url).to eq expected['shortUrl']
+            expect(card.board_id).to eq expected['idBoard']
+            expect(card.member_ids).to eq expected['idMembers']
+            expect(card.cover_image_id).to eq expected['idAttachmentCover']
+            expect(card.list_id).to eq expected['idList']
+            expect(card.card_labels).to eq expected['idLabels']
+            expect(card.desc).to eq expected['desc']
+          end
+
+          it "card hasn't been mark as changed" do
+            card.update_fields(fields)
+
+            expect(card.changed?).to be_falsy
+          end
         end
       end
     end