ruby-trello 2.0.1 → 3.0.0

data/spec/unit/trello/board/update_spec.rb

@@ -0,0 +1,197 @@
+require 'spec_helper'
+
+RSpec.describe 'Trello::Board#update!' do
+
+  let(:client) { Trello.client }
+  let(:board) { Trello::Board.new(id: 'abc123') }
+
+  before { allow(board).to receive(:from_response) }
+
+  it 'can update name through client' do
+    board.name = 'Board 1'
+
+    expect(client)
+      .to receive(:put)
+      .with('/boards/abc123', {
+        'name' => 'Board 1'
+      })
+
+    board.update!
+  end
+
+  it 'can update description through client' do
+    board.description = 'description ...'
+
+    expect(client)
+      .to receive(:put)
+      .with('/boards/abc123', {
+        'desc' => 'description ...'
+      })
+
+    board.update!
+  end
+
+  it 'can update closed through client' do
+    board.closed = true
+
+    expect(client)
+      .to receive(:put)
+      .with('/boards/abc123', {
+        'closed' => true
+      })
+
+    board.update!
+  end
+
+  # it 'can update subscribed through client' do
+  # end
+
+  it 'can update organization_id through client' do
+    board.organization_id = 123
+
+    expect(client)
+      .to receive(:put)
+      .with('/boards/abc123', {
+        'idOrganization' => 123
+      })
+
+    board.update!
+  end
+
+  it 'can update visibility_level through client' do
+    board.visibility_level = 'org'
+
+    expect(client)
+      .to receive(:put)
+      .with('/boards/abc123', {
+        'prefs/permissionLevel' => 'org'
+      })
+
+    board.update!
+  end
+
+  it 'can update enable_self_join through client' do
+    board.enable_self_join = true
+
+    expect(client)
+      .to receive(:put)
+      .with('/boards/abc123', {
+        'prefs/selfJoin' => true
+      })
+
+    board.update!
+  end
+
+  it 'can update enable_card_covers through client' do
+    board.enable_card_covers = true
+
+    expect(client)
+      .to receive(:put)
+      .with('/boards/abc123', {
+        'prefs/cardCovers' => true
+      })
+
+    board.update!
+  end
+
+  # it 'can update hide_votes through client' do
+  # end
+
+  it 'can update invitation_permission_level through client' do
+    board.invitation_permission_level = 'org'
+
+    expect(client)
+      .to receive(:put)
+      .with('/boards/abc123', {
+        'prefs/invitations' => 'org'
+      })
+
+    board.update!
+  end
+
+  it 'can update voting_permission_level through client' do
+    board.voting_permission_level = 'org'
+
+    expect(client)
+      .to receive(:put)
+      .with('/boards/abc123', {
+        'prefs/voting' => 'org'
+      })
+
+    board.update!
+  end
+
+  it 'can update comment_permission_level through client' do
+    board.comment_permission_level = 'org'
+
+    expect(client)
+      .to receive(:put)
+      .with('/boards/abc123', {
+        'prefs/comments' => 'org'
+      })
+
+    board.update!
+  end
+
+  it 'can update background_color through client' do
+    board.background_color = 'blue'
+
+    expect(client)
+      .to receive(:put)
+      .with('/boards/abc123', {
+        'prefs/background' => 'blue'
+      })
+
+    board.update!
+  end
+
+  it 'can update card_aging_type through client' do
+    board.card_aging_type = 'pirate'
+
+    expect(client)
+      .to receive(:put)
+      .with('/boards/abc123', {
+        'prefs/cardAging' => 'pirate'
+      })
+
+    board.update!
+  end
+
+  # it 'can update enable_calendar_feed through client' do
+  # end
+
+  it 'can update all through client' do
+    board.name = 'Board 1'
+    board.description = 'description ...'
+    board.closed = true
+    board.organization_id = 123
+    board.visibility_level = 'org'
+    board.enable_self_join = true
+    board.enable_card_covers = true
+    board.invitation_permission_level = 'org'
+    board.voting_permission_level = 'org'
+    board.comment_permission_level = 'org'
+    board.background_color = 'blue'
+    board.card_aging_type = 'pirate'
+
+    expect(client)
+      .to receive(:put)
+      .with('/boards/abc123', {
+        'name' => 'Board 1',
+        'desc' => 'description ...',
+        'closed' => true,
+        'idOrganization' => 123,
+        'prefs/permissionLevel' => 'org',
+        'prefs/selfJoin' => true,
+        'prefs/cardCovers' => true,
+        'prefs/invitations' => 'org',
+        'prefs/voting' => 'org',
+        'prefs/comments' => 'org',
+        'prefs/background' => 'blue',
+        'prefs/cardAging' => 'pirate'
+      })
+
+    board.update!
+  end
+
+end

data/spec/unit/trello/card_spec.rb

@@ -0,0 +1,103 @@
+require 'spec_helper'
+
+RSpec.describe Trello::Card do
+
+  describe '.path_name' do
+    specify { expect(Trello::Card.path_name).to eq('card') }
+  end
+
+  describe '#closed?' do
+    specify { expect(Trello::Card.new('closed' => true).closed?).to eq(true) }
+    specify { expect(Trello::Card.new('closed' => false).closed?).to eq(false) }
+  end
+
+  describe '#close' do
+    let(:card) { Trello::Card.new('closed' => false) }
+
+    it 'can mark card as closed' do
+      card.close
+      expect(card.closed).to eq(true)
+    end
+  end
+
+  describe 'close!' do
+    let(:card) { Trello::Card.new('closed' => false) }
+
+    it 'will call save' do
+      expect(card).to receive(:save)
+      card.close!
+    end
+  end
+
+  describe 'valid?' do
+    let(:card) { Trello::Card.new('name' => name, 'idList' => list_id) }
+
+    context 'when name is nil' do
+      let(:name) { nil }
+      let(:list_id) { 1 }
+
+      specify { expect(card.valid?).to eq(false) }
+    end
+
+    context 'when list_id is nil' do
+      let(:name) { 'Card Name' }
+      let(:list_id) { nil }
+
+      specify { expect(card.valid?).to eq(false) }
+    end
+
+    context "when name and list_id both aren't nil" do
+      let(:name) { 'Card' }
+      let(:list_id) { 1 }
+
+      specify { expect(card.valid?).to eq(true) }
+    end
+  end
+
+  describe '#move_to_list_on_any_board' do
+    let(:card) { Trello::Card.new(board_id: 'board-aaa') }
+    let(:move_to_list_on_any_board) { card.move_to_list_on_any_board('listid') }
+
+    let(:board) { Trello::Board.new(id: 'board-aaa') }
+    let(:target_list) { Trello::List.new(board_id: target_board_id) }
+
+    before do
+      allow(Trello::List).to receive(:find).with('listid').and_return(target_list)
+      allow(card).to receive(:board).and_return(board)
+    end
+
+    context 'when target list is in the same board' do
+      let(:target_board_id) { 'board-aaa' }
+
+      it 'call #move_to_list on card' do
+        expect(card).to receive(:move_to_list).with('listid')
+
+        move_to_list_on_any_board
+      end
+    end
+
+    context 'when target list is in a different board' do
+      let(:target_board_id) { 'board-bbb' }
+      let(:target_board) { Trello::Board.new(id: 'board-bbb') }
+
+      before { allow(Trello::Board).to receive(:find).with('board-bbb').and_return(target_board) }
+
+      it 'call #move_to_board on card' do
+        expect(card).to receive(:move_to_board).with(target_board, target_list)
+
+        move_to_list_on_any_board
+      end
+    end
+  end
+
+  describe '#created_at' do
+    it 'can get created_at from card id' do
+      card = Trello::Card.new('id' => '5e95d1b4f43f9a06497f17f7')
+      expect(card.created_at).to eq(Time.new(2020, 4, 14, 15, 7, 32, '+00:00'))
+
+      card = Trello::Card.new('id' => '5e94ee7df8784d61ee48319e')
+      expect(card.created_at).to eq(Time.new(2020, 4, 13, 22, 58, 05, '+00:00'))
+    end
+  end
+
+end

data/spec/unit/trello/member/new_spec.rb

@@ -0,0 +1,62 @@
+
+require 'spec_helper'
+
+RSpec.describe 'Trello::Member#new' do
+
+  let(:member) { Trello::Member.new(data) }
+
+  describe 'parse #id (readonly primary_key)' do
+    context 'with Trello API respone data' do
+      let(:data) { { 'id' => '5e93ba98614ac22d22f085c4' } }
+
+      it "parse from data['id']" do
+        expect(member.id).to eq('5e93ba98614ac22d22f085c4')
+      end
+    end
+
+    context 'with Ruby-like data' do
+      let(:data) { { id: '5e93ba98614ac22d22f085c4' } }
+
+      it 'parse from data[:id]' do
+        expect(member.id).to eq('5e93ba98614ac22d22f085c4')
+      end
+    end
+  end
+
+  describe 'parse #username (writable)' do
+    context 'with Trello API respone data' do
+      let(:data) { { 'username' => 'hoppertest' } }
+
+      it "parse from data['username']" do
+        expect(member.username).to eq('hoppertest')
+      end
+    end
+
+    context 'with Ruby-like data' do
+      let(:data) { { username: 'hoppertest' } }
+
+      it 'parse from data[:id]' do
+        expect(member.username).to eq('hoppertest')
+      end
+    end
+  end
+
+  describe 'parse #full_name (writable)' do
+    context 'with Trello API respone data' do
+      let(:data) { { 'fullName' => 'hoppertest' } }
+
+      it "parse from data['fullName']" do
+        expect(member.full_name).to eq('hoppertest')
+      end
+    end
+
+    context 'with Ruby-like data' do
+      let(:data) { { full_name: 'hoppertest' } }
+
+      it 'parse from data[:full_name]' do
+        expect(member.full_name).to eq('hoppertest')
+      end
+    end
+  end
+
+end

data/spec/unit/trello/member/update_fields_spec.rb

@@ -0,0 +1,80 @@
+require 'spec_helper'
+
+RSpec.describe 'Trello::Member#update_fields' do
+
+  let(:member_params) { {
+    'id' => '5e93ba403f1ab3603ba81a09',
+    'bio' => 'test',
+    'username' => 'hoppertest',
+    'email' => 'test@test.com'
+   } }
+
+  let(:member) { Trello::Member.new(member_params) }
+
+  context 'when the fields argument is empty' do
+    let(:fields) { {} }
+
+    it 'member does not set any fields' do
+      member.update_fields(fields)
+
+      expect(member.changed?).to be_falsy
+      expect(member.id).to eq(member_params['id'])
+      expect(member.username).to eq(member_params['username'])
+      expect(member.email).to eq(member_params['email'])
+    end
+  end
+
+  context 'when the fields argument has at least one field' do
+
+    context 'and the field does changed' do
+      let(:fields) { { username: 'hopperchange' } }
+
+      it 'member does set the changed fields' do
+        member.update_fields(fields)
+
+        expect(member.username).to eq('hopperchange')
+      end
+
+      it 'member has been mark as changed' do
+        member.update_fields(fields)
+
+        expect(member.changed?).to be_truthy
+      end
+    end
+
+    context "and the field doesn't changed" do
+      let(:fields) { { username: member_params['username'] } }
+
+      it "member attributes doesn't changed" do
+        member.update_fields(fields)
+
+        expect(member.username).to eq(member_params['username'])
+      end
+
+      it "member hasn't been mark as changed" do
+        member.update_fields(fields)
+
+        expect(member.changed?).to be_falsy
+      end
+    end
+
+    context "and the field isn't a correct attributes of the card" do
+      let(:fields) { { abc: 'abc' } }
+
+      it "card attributes doesn't changed" do
+        member.update_fields(fields)
+
+        expect(member.id).to eq(member_params['id'])
+        expect(member.username).to eq(member_params['username'])
+        expect(member.email).to eq(member_params['email'])
+      end
+
+      it "card hasn't been mark as changed" do
+        member.update_fields(fields)
+
+        expect(member.changed?).to be_falsy
+      end
+    end
+  end
+
+end

data/spec/unit/trello/schema/attribute/base_spec.rb

@@ -0,0 +1,349 @@
+require 'spec_helper'
+
+RSpec.describe 'Trello::Schema::Attribute::Base' do
+
+  let(:attribute) { Trello::Schema::Attribute::Base.new(name: name, options: options, serializer: serializer) }
+
+  describe '#name' do
+    let(:options) { nil }
+    let(:serializer) { Trello::Schema::Serializer::Default }
+
+    context 'when name is a symbol' do
+      let(:name) { :name }
+
+      it 'directly return the name' do
+        expect(attribute.name).to eq(:name)
+      end
+    end
+
+    context 'when name is a string' do
+      let(:name) { 'name' }
+
+      it 'directly return the symbolize name' do
+        expect(attribute.name).to eq(:name)
+      end
+    end
+  end
+
+  describe '#primary_key?' do
+    let(:name) { :name }
+    let(:serializer) { Trello::Schema::Serializer::Default }
+
+    context 'when explict pass primary_key' do
+      let(:options) { { primary_key: true } }
+
+      it 'direct return the primary_key value' do
+        expect(attribute.primary_key?).to eq(true)
+      end
+    end
+
+    context 'when does not explict pass primary_key' do
+      let(:options) { nil }
+
+      it 'return false' do
+        expect(attribute.primary_key?).to eq(false)
+      end
+    end
+  end
+
+  describe '#readlonly?' do
+    let(:name) { :name }
+    let(:serializer) { Trello::Schema::Serializer::Default }
+
+    context 'when does not explict pass readonly parameter' do
+      let(:options) { nil }
+
+      it 'return false' do
+        expect(attribute.readonly?).to eq(false)
+      end
+    end
+
+    context 'when does explict pass readonly parameter' do
+      context 'and readonly is true' do
+        let(:options) { { readonly: true } }
+
+        it 'return true' do
+          expect(attribute.readonly?).to eq(true)
+        end
+      end
+
+      context 'and readonly is false' do
+        let(:options) { { readonly: false } }
+
+        it 'return false' do
+          expect(attribute.readonly?).to eq(false)
+        end
+      end
+
+      context 'and readonly is not a boolean' do
+        let(:options) { { readonly: 'other' } }
+
+        it 'return false' do
+          expect(attribute.readonly?).to eq(false)
+        end
+      end
+    end
+  end
+
+  describe '#update_only?' do
+    let(:name) { :name }
+    let(:serializer) { Trello::Schema::Serializer::Default }
+
+    context 'when does not explict pass update_only parameter' do
+      let(:options) { nil }
+
+      it 'return false' do
+        expect(attribute.update_only?).to eq(false)
+      end
+    end
+
+    context 'when does explict pass update_only parameter' do
+      context 'and update_only is true' do
+        let(:options) { { update_only: true } }
+
+        it 'return true' do
+          expect(attribute.update_only?).to eq(true)
+        end
+      end
+
+      context 'and update_only is false' do
+        let(:options) { { update_only: false } }
+
+        it 'return false' do
+          expect(attribute.update_only?).to eq(false)
+        end
+      end
+
+      context 'and update_only is not a boolean' do
+        let(:options) { { update_only: 'other' } }
+
+        it 'return false' do
+          expect(attribute.update_only?).to eq(false)
+        end
+      end
+    end
+  end
+
+  describe '#create_only?' do
+    let(:name) { :name }
+    let(:serializer) { Trello::Schema::Serializer::Default }
+
+    context 'when does not explict pass create_only parameter' do
+      let(:options) { nil }
+
+      it 'return false' do
+        expect(attribute.create_only?).to eq(false)
+      end
+    end
+
+    context 'when does explict pass create_only parameter' do
+      context 'and create_only is true' do
+        let(:options) { { create_only: true } }
+
+        it 'return true' do
+          expect(attribute.create_only?).to eq(true)
+        end
+      end
+
+      context 'and create_only is false' do
+        let(:options) { { create_only: false } }
+
+        it 'return false' do
+          expect(attribute.create_only?).to eq(false)
+        end
+      end
+
+      context 'and create_only is not a boolean' do
+        let(:options) { { create_only: 'other' } }
+
+        it 'return false' do
+          expect(attribute.create_only?).to eq(false)
+        end
+      end
+    end
+  end
+
+  describe '#for_action?' do
+    let(:name) { :name }
+    let(:serializer) { Trello::Schema::Serializer::Default }
+
+    context 'when it is a primary_key' do
+      let(:options) { { primary_key: true } }
+
+      context 'pass in :create' do
+        it 'return false' do
+          expect(attribute.for_action?(:create)).to eq(false)
+        end
+      end
+
+      context 'pass in :update' do
+        it 'return true' do
+          expect(attribute.for_action?(:update)).to eq(true)
+        end
+      end
+    end
+
+    context 'when it is a update_only attribute' do
+      let(:options) { { update_only: true } }
+
+      context 'pass in :create' do
+        it 'return false' do
+          expect(attribute.for_action?(:create)).to eq(false)
+        end
+      end
+
+      context 'pass in :update' do
+        it 'return true' do
+          expect(attribute.for_action?(:update)).to eq(true)
+        end
+      end
+    end
+
+    context 'when it is a create_only attribute' do
+      let(:options) { { create_only: true } }
+
+      context 'pass in :create' do
+        it 'return true' do
+          expect(attribute.for_action?(:create)).to eq(true)
+        end
+      end
+
+      context 'pass in :update' do
+        it 'return false' do
+          expect(attribute.for_action?(:update)).to eq(false)
+        end
+      end
+    end
+
+    context 'when it is a readonly attribute' do
+      context 'and it is a primary_key' do
+        let(:options) { { readonly: true, primary_key: true } }
+
+        context 'pass in :create' do
+          it 'return false' do
+            expect(attribute.for_action?(:create)).to eq(false)
+          end
+        end
+
+        context 'pass in :update' do
+          it 'return true' do
+            expect(attribute.for_action?(:update)).to eq(true)
+          end
+        end
+      end
+
+      context 'and it is not a primary_key' do
+        let(:options) { { readonly: true } }
+
+        context 'pass in :create' do
+          it 'return false' do
+            expect(attribute.for_action?(:create)).to eq(false)
+          end
+        end
+
+        context 'pass in :update' do
+          it 'return false' do
+            expect(attribute.for_action?(:update)).to eq(false)
+          end
+        end
+      end
+    end
+  end
+
+  describe '#remote_key' do
+    let(:name) { :date_create_utc }
+    let(:serializer) { double('serializer') }
+
+    context 'when explict pass in remote_key' do
+      context 'and remote_key is a string' do
+        let(:options) { { remote_key: 'dateCreateUTC' } }
+
+        it 'directly return the stringify remote_key' do
+          expect(attribute.remote_key).to eq('dateCreateUTC')
+        end
+      end
+
+      context 'and remote_key is a symbol' do
+        let(:options) { { remote_key: :dateCreateUTC } }
+
+        it 'directly return the stringify remote_key' do
+          expect(attribute.remote_key).to eq('dateCreateUTC')
+        end
+      end
+    end
+
+    context 'when does not explict pass in remote_key' do
+      let(:options) { {} }
+
+      it 'return the stringify name' do
+        expect(attribute.remote_key).to eq('date_create_utc')
+      end
+    end
+  end
+
+  describe '#default' do
+    let(:name) { :closed }
+    let(:serializer) { double('serializer') }
+
+    context 'when explicit pass in default' do
+      let(:options) { { default: false } }
+
+      it 'directly return the default value' do
+        expect(attribute.default).to eq(false)
+      end
+    end
+
+    context 'when does not explict pass in default' do
+      let(:options) { {} }
+
+      it 'return nil' do
+        expect(attribute.default).to eq(nil)
+      end
+    end
+  end
+
+  describe '#build_attributes' do
+    let(:name) { :date_create_utc }
+    let(:serializer) { double('serializer') }
+    let(:options) { nil }
+
+    it 'will raise exception' do
+      expect{ attribute.build_attributes({}, {}) }.to raise_error('Need override')
+    end
+  end
+
+  describe '#build_payload_for_create' do
+    let(:name) { :date_create_utc }
+    let(:serializer) { double('serializer') }
+    let(:options) { nil }
+
+    it 'will raise exception' do
+      expect{ attribute.build_payload_for_create({}, {}) }.to raise_error('Need override')
+    end
+  end
+
+  describe '#build_payload_for_update' do
+    let(:name) { :date_create_utc }
+    let(:serializer) { double('serializer') }
+    let(:options) { nil }
+
+    it 'will raise exception' do
+      expect{ attribute.build_payload_for_update({}, {}) }.to raise_error('Need override')
+    end
+  end
+
+  describe '#register' do
+    let(:name) { :date_create_utc }
+    let(:serializer) { double('serializer') }
+    let(:options) { nil }
+
+    let(:board_klass) { double('Trello::Board') }
+
+    it 'call register on AttributeRegistration' do
+      expect(Trello::Schema::AttributeRegistration).to receive(:register).with(board_klass, attribute)
+
+      attribute.register(board_klass)
+    end
+  end
+
+end