ruby-trello 1.1.3 → 1.2.0

data/spec/configuration_spec.rb

@@ -47,10 +47,10 @@ describe Trello::Configuration do
   describe 'initialize' do
     it 'sets key attributes provided as a hash' do
       configuration = Trello::Configuration.new(
-        :consumer_key => 'consumer_key',
-        :consumer_secret => 'consumer_secret',
-        :oauth_token => 'oauth_token',
-        :oauth_token_secret => 'oauth_token_secret'
+        consumer_key: 'consumer_key',
+        consumer_secret: 'consumer_secret',
+        oauth_token: 'oauth_token',
+        oauth_token_secret: 'oauth_token_secret'
       )
       configuration.consumer_key.should eq('consumer_key')
       configuration.consumer_secret.should eq('consumer_secret')
@@ -67,47 +67,47 @@ describe Trello::Configuration do
     end
 
     it 'returns an empty if attributes incomplete' do
-      Trello::Configuration.new(:consumer_key => 'consumer_key').credentials.should eq({})
+      Trello::Configuration.new(consumer_key: 'consumer_key').credentials.should eq({})
     end
 
     it 'returns a hash of oauth attributes' do
       configuration = Trello::Configuration.new(
-        :consumer_key => 'consumer_key',
-        :consumer_secret => 'consumer_secret',
-        :oauth_token => 'oauth_token',
-        :oauth_token_secret => 'oauth_token_secret'
+        consumer_key: 'consumer_key',
+        consumer_secret: 'consumer_secret',
+        oauth_token: 'oauth_token',
+        oauth_token_secret: 'oauth_token_secret'
       )
       configuration.credentials.should eq(
-        :consumer_key => 'consumer_key',
-        :consumer_secret => 'consumer_secret',
-        :oauth_token => 'oauth_token',
-        :oauth_token_secret => 'oauth_token_secret'
+        consumer_key: 'consumer_key',
+        consumer_secret: 'consumer_secret',
+        oauth_token: 'oauth_token',
+        oauth_token_secret: 'oauth_token_secret'
       )
     end
 
     it 'includes callback and return url if given' do
       configuration = Trello::Configuration.new(
-        :consumer_key => 'consumer_key',
-        :consumer_secret => 'consumer_secret',
-        :return_url => 'http://example.com',
-        :callback => 'callback'
+        consumer_key: 'consumer_key',
+        consumer_secret: 'consumer_secret',
+        return_url: 'http://example.com',
+        callback: 'callback'
       )
       configuration.credentials.should eq(
-        :consumer_key => 'consumer_key',
-        :consumer_secret => 'consumer_secret',
-        :return_url => 'http://example.com',
-        :callback => 'callback'
+        consumer_key: 'consumer_key',
+        consumer_secret: 'consumer_secret',
+        return_url: 'http://example.com',
+        callback: 'callback'
       )
     end
 
     it 'returns a hash of basic auth policy attributes' do
       configuration = Trello::Configuration.new(
-        :developer_public_key => 'developer_public_key',
-        :member_token => 'member_token'
+        developer_public_key: 'developer_public_key',
+        member_token: 'member_token'
       )
       configuration.credentials.should eq(
-        :developer_public_key => 'developer_public_key',
-        :member_token => 'member_token'
+        developer_public_key: 'developer_public_key',
+        member_token: 'member_token'
       )
     end
   end

data/spec/integration/how_to_authorize_spec.rb

@@ -1,13 +1,13 @@
 require 'spec_helper'
 require 'integration/integration_test'
 
-describe "Authorizing read-only requests", :broken => true do
+describe "Authorizing read-only requests", broken: true do
   include IntegrationTest
 
   it "Reading public resources requires just a developer public key" do
     uri = Addressable::URI.parse("https://api.trello.com/1/boards/4ed7e27fe6abb2517a21383d")
     uri.query_values = {
-      :key => @developer_public_key
+      key: @developer_public_key
     }
 
     get(uri).code.should === 200
@@ -16,8 +16,8 @@ describe "Authorizing read-only requests", :broken => true do
   it "Reading private resources requires developer public key AND a member token" do
     uri = Addressable::URI.parse("https://api.trello.com/1/boards/#{@welcome_board}")
     uri.query_values = {
-      :key => @developer_public_key,
-      :token => @member_token
+      key: @developer_public_key,
+      token: @member_token
     }
 
     get(uri).code.should === 200
@@ -35,7 +35,7 @@ describe "Authorizing read-only requests", :broken => true do
   end
 end
 
-describe "OAuth", :broken => true do
+describe "OAuth", broken: true do
   include IntegrationTest
 
   before do

data/spec/integration/how_to_use_boards_spec.rb

@@ -1,7 +1,7 @@
 require 'spec_helper'
 require 'integration/integration_test'
 
-describe "how to use boards", :broken => true do
+describe "how to use boards", broken: true do
   include IntegrationTest
 
   context "given a valid access token" do
@@ -12,14 +12,14 @@ describe "how to use boards", :broken => true do
     end
 
     after do
-      if @new_board and false == @new_board.closed? 
+      if @new_board and false == @new_board.closed?
         @new_board.update_fields 'closed' => true
         @new_board.save
       end
     end
 
     it "can add a board" do
-      @new_board = Board.create(:name => "An example")
+      @new_board = Board.create(name: "An example")
       @new_board.should_not be_nil
       @new_board.id.should_not be_nil
       @new_board.name.should == "An example"
@@ -33,11 +33,11 @@ describe "how to use boards", :broken => true do
     end
 
     it "can close a board" do
-      @new_board = Board.create(:name => "[#{Time.now}, CLOSED] An example")
+      @new_board = Board.create(name: "[#{Time.now}, CLOSED] An example")
 
       @new_board.update_fields 'closed' => true
       @new_board.save
-      
+
       Board.find(@new_board.id).should be_closed
     end
 

data/spec/list_spec.rb

@@ -43,15 +43,15 @@ module Trello
         list.should_not be_valid
       end
 
-      it 'creates a new record and saves it on Trello', :refactor => true do
+      it 'creates a new record and saves it on Trello', refactor: true do
         payload = {
-          :name       => 'Test List',
-          :board_id   => 'abcdef123456789123456789'
+          name: 'Test List',
+          board_id: 'abcdef123456789123456789'
         }
 
         result = JSON.generate(payload)
 
-        expected_payload = {:name => 'Test List', :closed => false, :idBoard => 'abcdef123456789123456789'}
+        expected_payload = {name: 'Test List', closed: false, idBoard: 'abcdef123456789123456789'}
 
         client.should_receive(:post).with('/lists', expected_payload).and_return result
 
@@ -66,8 +66,8 @@ module Trello
         expected_new_name = 'xxx'
 
         payload = {
-          :name      => expected_new_name,
-          :closed    => false
+          name: expected_new_name,
+          closed: false
         }
 
         client.should_receive(:put).once.with('/lists/abcdef123456789123456789', payload)
@@ -100,14 +100,14 @@ module Trello
 
     context 'actions' do
       it 'has a list of actions' do
-        client.stub(:get).with('/lists/abcdef123456789123456789/actions', { :filter => :all }).and_return actions_payload
+        client.stub(:get).with('/lists/abcdef123456789123456789/actions', { filter: :all }).and_return actions_payload
         list.actions.count.should be > 0
       end
     end
 
     context 'cards' do
       it 'has a list of cards' do
-        client.stub(:get).with('/lists/abcdef123456789123456789/cards', { :filter => :open }).and_return cards_payload
+        client.stub(:get).with('/lists/abcdef123456789123456789/cards', { filter: :open }).and_return cards_payload
         list.cards.count.should be > 0
       end
     end
@@ -128,8 +128,8 @@ module Trello
     describe '#close!' do
       it 'updates the close attribute to true and saves the list' do
         client.should_receive(:put).once.with('/lists/abcdef123456789123456789', {
-          :name   => list.name,
-          :closed => true
+          name: list.name,
+          closed: true
         })
 
         list.close!

data/spec/member_spec.rb

@@ -27,15 +27,15 @@ module Trello
     end
 
     context 'actions' do
-      it 'retrieves a list of actions', :refactor => true do
-        client.stub(:get).with('/members/abcdef123456789012345678/actions', { :filter => :all }).and_return actions_payload
+      it 'retrieves a list of actions', refactor: true do
+        client.stub(:get).with('/members/abcdef123456789012345678/actions', { filter: :all }).and_return actions_payload
         member.actions.count.should be > 0
       end
     end
 
     context 'boards' do
       it 'has a list of boards' do
-        client.stub(:get).with('/members/abcdef123456789012345678/boards', { :filter => :all }).and_return boards_payload
+        client.stub(:get).with('/members/abcdef123456789012345678/boards', { filter: :all }).and_return boards_payload
         boards = member.boards
         boards.count.should be > 0
       end
@@ -43,7 +43,7 @@ module Trello
 
     context 'cards' do
       it 'has a list of cards' do
-        client.stub(:get).with('/members/abcdef123456789012345678/cards', { :filter => :open }).and_return cards_payload
+        client.stub(:get).with('/members/abcdef123456789012345678/cards', { filter: :open }).and_return cards_payload
         cards = member.cards
         cards.count.should be > 0
       end
@@ -51,7 +51,7 @@ module Trello
 
     context 'organizations' do
       it 'has a list of organizations' do
-        client.stub(:get).with('/members/abcdef123456789012345678/organizations', { :filter => :all }).and_return orgs_payload
+        client.stub(:get).with('/members/abcdef123456789012345678/organizations', { filter: :all }).and_return orgs_payload
         orgs = member.organizations
         orgs.count.should be > 0
       end
@@ -78,8 +78,8 @@ module Trello
       end
 
       it 'returns a valid url for the avatar' do
-        member.avatar_url(:size => :large).should == 'https://trello-avatars.s3.amazonaws.com/abcdef1234567890abcdef1234567890/170.png'
-        member.avatar_url(:size => :small).should == 'https://trello-avatars.s3.amazonaws.com/abcdef1234567890abcdef1234567890/30.png'
+        member.avatar_url(size: :large).should == 'https://trello-avatars.s3.amazonaws.com/abcdef1234567890abcdef1234567890/170.png'
+        member.avatar_url(size: :small).should == 'https://trello-avatars.s3.amazonaws.com/abcdef1234567890abcdef1234567890/30.png'
       end
 
       it 'gets the url' do

data/spec/oauth_policy_spec.rb

@@ -18,8 +18,8 @@ describe OAuthPolicy do
 
     it 'is built from given consumer_key and consumer_secret' do
       policy = OAuthPolicy.new(
-        :consumer_key => 'consumer_key',
-        :consumer_secret => 'consumer_secret'
+        consumer_key: 'consumer_key',
+        consumer_secret: 'consumer_secret'
       )
       policy.consumer_credential.key.should eq('consumer_key')
       policy.consumer_credential.secret.should eq('consumer_secret')
@@ -42,8 +42,8 @@ describe OAuthPolicy do
 
     it 'is built from given oauth_token and oauth_token_secret' do
       policy = OAuthPolicy.new(
-        :oauth_token => 'oauth_token',
-        :oauth_token_secret => 'oauth_token_secret'
+        oauth_token: 'oauth_token',
+        oauth_token_secret: 'oauth_token_secret'
       )
       policy.token.key.should eq('oauth_token')
       policy.token.secret.should eq('oauth_token_secret')

data/spec/organization_spec.rb

@@ -28,7 +28,7 @@ module Trello
 
     context 'actions' do
       it 'retrieves actions' do
-        client.stub(:get).with('/organizations/4ee7e59ae582acdec8000291/actions', { :filter => :all }).and_return actions_payload
+        client.stub(:get).with('/organizations/4ee7e59ae582acdec8000291/actions', { filter: :all }).and_return actions_payload
         organization.actions.count.should be > 0
       end
     end

data/spec/spec_helper.rb

@@ -24,7 +24,7 @@ require 'stringio'
 Trello.logger = Logger.new(StringIO.new)
 
 RSpec.configure do |c|
-  c.filter_run_excluding :broken => true
+  c.filter_run_excluding broken: true
 
   c.before :each do
     Trello.reset!
@@ -55,6 +55,7 @@ module Helpers
       'name'           => 'Test',
       'desc'           => 'This is a test board',
       'closed'         => false,
+      'starred'         => false,
       'idOrganization' => 'abcdef123456789123456789',
       'url'            => 'https://trello.com/board/test/abcdef123456789123456789'
     }]

data/spec/token_spec.rb

@@ -15,7 +15,7 @@ module Trello
       let(:client) { Trello.client }
 
       it 'delegates to Trello.client#find' do
-        client.should_receive(:find).with(:token, '1234', {:webhooks => true})
+        client.should_receive(:find).with(:token, '1234', {webhooks: true})
         Token.find('1234')
       end
 

data/spec/webhook_spec.rb

@@ -32,13 +32,13 @@ module Trello
         webhook.should be_valid
       end
 
-      it 'creates a new webhook and saves it on Trello', :refactor => true do
-        payload = { :name => 'Test Card', :desc => nil }
+      it 'creates a new webhook and saves it on Trello', refactor: true do
+        payload = { name: 'Test Card', desc: nil }
 
         webhook = webhooks_details.first
         result = JSON.generate(webhook)
 
-        expected_payload = {:description => webhook[:description], :idModel => webhook[:idModel], :callbackURL => webhook[:callbackURL]}
+        expected_payload = {description: webhook[:description], idModel: webhook[:idModel], callbackURL: webhook[:callbackURL]}
 
         client.should_receive(:post).with("/webhooks", expected_payload).and_return result
 
@@ -52,7 +52,7 @@ module Trello
       it "updating description does a put on the correct resource with the correct value" do
         expected_new_description = "xxx"
 
-        expected_payload = {:description => expected_new_description, :idModel => webhook.id_model, :callbackURL => webhook.callback_url, :active => webhook.active}
+        expected_payload = {description: expected_new_description, idModel: webhook.id_model, callbackURL: webhook.callback_url, active: webhook.active}
 
         client.should_receive(:put).once.with("/webhooks/#{webhook.id}", expected_payload)
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ruby-trello
 version: !ruby/object:Gem::Version
-  version: 1.1.3
+  version: 1.2.0
 platform: ruby
 authors:
 - Jeremy Tregunna
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-12 00:00:00.000000000 Z
+date: 2015-03-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel