ruby-trello 1.1.3 → 1.2.0

data/spec/association_spec.rb

@@ -3,20 +3,20 @@ require 'spec_helper'
 module Trello
   describe Association do
     include Helpers
-    
+
     let(:organization) { client.find(:organization, '4ee7e59ae582acdec8000291') }
-    let(:client) { Client.new(:consumer_key => 'xxx') }
+    let(:client) { Client.new(consumer_key: 'xxx') }
 
     before(:each) do
       client.stub(:get).with('/organizations/4ee7e59ae582acdec8000291', {}).
         and_return organization_payload
       client.stub(:get).with('/organizations/4ee7e59ae582acdec8000291/boards/all').
-        and_return boards_payload        
+        and_return boards_payload
     end
-    
+
     it 'should set the proper client for all associated boards of the organization' do
       organization.boards.first.client.consumer_key.should == 'xxx'
     end
-    
+
   end
 end

data/spec/basic_auth_policy_spec.rb

@@ -28,7 +28,7 @@ describe BasicAuthPolicy do
   it 'preserves other query parameters' do
     uri = Addressable::URI.parse('https://xxx/?name=Phil')
 
-    request = Request.new :get, uri, {:example_header => 'example_value'}
+    request = Request.new :get, uri, {example_header: 'example_value'}
 
     authorized_request = BasicAuthPolicy.authorize request
 
@@ -40,7 +40,7 @@ describe BasicAuthPolicy do
   it 'preserves headers' do
     uri = Addressable::URI.parse('https://xxx/')
 
-    request = Request.new :get, uri, {:example_header => 'example_value'}
+    request = Request.new :get, uri, {example_header: 'example_value'}
 
     authorized_request = BasicAuthPolicy.authorize request
 

data/spec/board_spec.rb

@@ -6,6 +6,7 @@ module Trello
 
     let(:board) { client.find(:board, 'abcdef123456789123456789') }
     let(:client) { Client.new }
+    let(:member) { Member.new(user_payload) }
 
     before(:each) do
       client.stub(:get).with("/boards/abcdef123456789123456789", {}).
@@ -53,6 +54,10 @@ module Trello
       it "knows if it is closed or open" do
         board.closed?.should_not be_nil
       end
+      
+      it "knows if it is starred or not" do
+        board.starred?.should_not be_nil
+      end
 
       it "gets its url" do
         board.url.should_not be_nil
@@ -61,7 +66,7 @@ module Trello
 
     context "actions" do
       it "has a list of actions" do
-        client.stub(:get).with("/boards/abcdef123456789123456789/actions", {:filter => :all}).
+        client.stub(:get).with("/boards/abcdef123456789123456789/actions", {filter: :all}).
           and_return actions_payload
 
         board.actions.count.should be > 0
@@ -70,7 +75,7 @@ module Trello
 
     context "cards" do
       it "gets its list of cards" do
-        client.stub(:get).with("/boards/abcdef123456789123456789/cards", { :filter => :open }).
+        client.stub(:get).with("/boards/abcdef123456789123456789/cards", { filter: :open }).
           and_return cards_payload
 
         board.cards.count.should be > 0
@@ -82,7 +87,7 @@ module Trello
         client.stub(:get).with("/boards/abcdef123456789123456789/labelnames").
           and_return label_name_payload
 
-        board.labels.count.should eq(6)
+        board.labels.count.should eq(10)
       end
     end
 
@@ -94,9 +99,28 @@ module Trello
       end
     end
 
+    context "add_member" do
+      it "adds a member to the board as a normal user (default)" do
+        client.stub(:put).with("/boards/abcdef123456789123456789/members/id", type: :normal)
+        board.add_member(member)
+      end
+
+      it "adds a member to the board as an admin" do
+        client.stub(:put).with("/boards/abcdef123456789123456789/members/id", type: :admin)
+        board.add_member(member, :admin)
+      end
+    end
+
+    context "remove_member" do
+      it "removes a member from the board" do
+        client.stub(:delete).with("/boards/abcdef123456789123456789/members/id")
+        board.remove_member(member)
+      end
+    end
+
     context "lists" do
       it "has a list of lists" do
-        client.stub(:get).with("/boards/abcdef123456789123456789/lists", hash_including(:filter => :open)).
+        client.stub(:get).with("/boards/abcdef123456789123456789/lists", hash_including(filter: :open)).
           and_return lists_payload
 
         board.has_lists?.should be true
@@ -105,7 +129,7 @@ module Trello
 
     context "members" do
       it "has a list of members" do
-        client.stub(:get).with("/boards/abcdef123456789123456789/members", hash_including(:filter => :all)).
+        client.stub(:get).with("/boards/abcdef123456789123456789/members", hash_including(filter: :all)).
           and_return JSON.generate([user_details])
 
         board.members.count.should be > 0
@@ -124,6 +148,10 @@ module Trello
     it "is not closed" do
       expect(board.closed?).not_to be(true)
     end
+    
+     it "is not starred" do
+      expect(board.starred?).not_to be(true)
+    end
 
     describe "#update_fields" do
       it "does not set any fields when the fields argument is empty" do
@@ -132,6 +160,7 @@ module Trello
          'name' => "name",
          'desc' => "desc",
          'closed' => false,
+         'starred' => false,
          'url' => "url",
          'idOrganization' => "org_id"
         }
@@ -169,7 +198,7 @@ module Trello
       end
 
       it "puts all fields except id" do
-        expected_fields = %w{ name description closed idOrganization}.map { |s| s.to_sym }
+        expected_fields = %w{ name description closed starred idOrganization}.map { |s| s.to_sym }
 
         client.should_receive(:put) do |anything, body|
           body.keys.should =~ expected_fields
@@ -218,12 +247,14 @@ module Trello
         board.name        = "new name"
         board.description = "new description"
         board.closed      = true
+        board.starred      = true
 
         client.should_receive(:put).with("/boards/#{board.id}/", {
-          :name => "new name",
-          :description => "new description",
-          :closed => true,
-          :idOrganization => nil
+          name: "new name",
+          description: "new description",
+          closed: true,
+          starred: true,
+          idOrganization: nil
         }).and_return any_board_json
         board.update!
       end
@@ -239,8 +270,8 @@ module Trello
       end
 
       it "creates a new board with whatever attributes are supplied " do
-        expected_attributes = { :name => "Any new board name", :description => "Any new board desription" }
-        sent_attributes = { :name => expected_attributes[:name], :desc => expected_attributes[:description] }
+        expected_attributes = { name: "Any new board name", description: "Any new board desription" }
+        sent_attributes = { name: expected_attributes[:name], desc: expected_attributes[:description] }
 
         client.should_receive(:post).with("/boards", sent_attributes).and_return any_board_json
 
@@ -250,13 +281,13 @@ module Trello
       it "posts to the boards collection" do
         client.should_receive(:post).with("/boards", anything).and_return any_board_json
 
-        Board.create :xxx => ""
+        Board.create xxx: ""
       end
 
       it "returns a board" do
         client.stub(:post).with("/boards", anything).and_return any_board_json
 
-        the_new_board = Board.create :xxx => ""
+        the_new_board = Board.create xxx: ""
         the_new_board.should be_a Board
       end
 

data/spec/card_spec.rb

@@ -43,20 +43,20 @@ module Trello
         card.should_not be_valid
       end
 
-      it 'creates a new record and saves it on Trello', :refactor => true do
+      it 'creates a new record and saves it on Trello', refactor: true do
         payload = {
-          :name    => 'Test Card',
-          :desc    => nil,
+          name: 'Test Card',
+          desc: nil,
         }
 
-        result = JSON.generate(cards_details.first.merge(payload.merge(:idList => lists_details.first['id'])))
+        result = JSON.generate(cards_details.first.merge(payload.merge(idList: lists_details.first['id'])))
 
         expected_payload = {name: "Test Card", desc: nil, idList: "abcdef123456789123456789",
                             idMembers: nil, labels: nil, pos: nil }
 
         client.should_receive(:post).with("/cards", expected_payload).and_return result
 
-        card = Card.create(cards_details.first.merge(payload.merge(:list_id => lists_details.first['id'])))
+        card = Card.create(cards_details.first.merge(payload.merge(list_id: lists_details.first['id'])))
 
         card.class.should be Card
       end
@@ -67,7 +67,7 @@ module Trello
         expected_new_name = "xxx"
 
         payload = {
-          :name      => expected_new_name,
+          name: expected_new_name,
         }
 
         client.should_receive(:put).once.with("/cards/abcdef123456789123456789", payload)
@@ -128,13 +128,13 @@ module Trello
 
     context "actions" do
       it "asks for all actions by default" do
-        client.stub(:get).with("/cards/abcdef123456789123456789/actions", { :filter => :all }).and_return actions_payload
+        client.stub(:get).with("/cards/abcdef123456789123456789/actions", { filter: :all }).and_return actions_payload
         card.actions.count.should be > 0
       end
 
       it "allows overriding the filter" do
-        client.stub(:get).with("/cards/abcdef123456789123456789/actions", { :filter => :updateCard }).and_return actions_payload
-        card.actions(:filter => :updateCard).count.should be > 0
+        client.stub(:get).with("/cards/abcdef123456789123456789/actions", { filter: :updateCard }).and_return actions_payload
+        card.actions(filter: :updateCard).count.should be > 0
       end
     end
 
@@ -154,7 +154,7 @@ module Trello
 
     context "checklists" do
       before(:each) do
-        client.stub(:get).with("/cards/abcdef123456789123456789/checklists", { :filter => :all }).and_return checklists_payload
+        client.stub(:get).with("/cards/abcdef123456789123456789/checklists", { filter: :all }).and_return checklists_payload
       end
 
       it "has a list of checklists" do
@@ -174,15 +174,15 @@ module Trello
       end
 
       it 'can be moved to another list' do
-        other_list = double(:id => '987654321987654321fedcba')
-        payload = {:value => other_list.id}
+        other_list = double(id: '987654321987654321fedcba')
+        payload = {value: other_list.id}
         client.should_receive(:put).with("/cards/abcdef123456789123456789/idList", payload)
         card.move_to_list(other_list)
       end
 
       it 'should not be moved if new list is identical to old list' do
-        other_list = double(:id => 'abcdef123456789123456789')
-        payload = { :value => other_list.id }
+        other_list = double(id: 'abcdef123456789123456789')
+        payload = { value: other_list.id }
         client.should_not_receive(:put)
         card.move_to_list(other_list)
       end
@@ -194,22 +194,22 @@ module Trello
       end
 
       it 'can be moved to another board' do
-        other_board = double(:id => '987654321987654321fedcba')
-        payload = {:value => other_board.id}
+        other_board = double(id: '987654321987654321fedcba')
+        payload = {value: other_board.id}
         client.should_receive(:put).with("/cards/abcdef123456789123456789/idBoard", payload)
         card.move_to_board(other_board)
       end
 
       it 'can be moved to a list on another board' do
-        other_board = double(:id => '987654321987654321fedcba')
-        other_list = double(:id => '987654321987654321aalist')
-        payload = {:value => other_board.id, :idList => other_list.id}
+        other_board = double(id: '987654321987654321fedcba')
+        other_list = double(id: '987654321987654321aalist')
+        payload = {value: other_board.id, idList: other_list.id}
         client.should_receive(:put).with("/cards/abcdef123456789123456789/idBoard", payload)
         card.move_to_board(other_board, other_list)
       end
 
-      it 'should not be moved if new board is identical with old board', :focus => true do
-        other_board = double(:id => 'abcdef123456789123456789')
+      it 'should not be moved if new board is identical with old board', focus: true do
+        other_board = double(id: 'abcdef123456789123456789')
         client.should_not_receive(:put)
         card.move_to_board(other_board)
       end
@@ -225,16 +225,16 @@ module Trello
       end
 
       it "allows a member to be added to a card" do
-        new_member = double(:id => '4ee7df3ce582acdec80000b2')
+        new_member = double(id: '4ee7df3ce582acdec80000b2')
         payload = {
-          :value => new_member.id
+          value: new_member.id
         }
         client.should_receive(:post).with("/cards/abcdef123456789123456789/members", payload)
         card.add_member(new_member)
       end
 
       it "allows a member to be removed from a card" do
-        existing_member = double(:id => '4ee7df3ce582acdec80000b2')
+        existing_member = double(id: '4ee7df3ce582acdec80000b2')
         client.should_receive(:delete).with("/cards/abcdef123456789123456789/members/#{existing_member.id}")
         card.remove_member(existing_member)
       end
@@ -243,7 +243,7 @@ module Trello
     context "comments" do
       it "posts a comment" do
         client.should_receive(:post).
-          with("/cards/abcdef123456789123456789/actions/comments", { :text => 'testing' }).
+          with("/cards/abcdef123456789123456789/actions/comments", { text: 'testing' }).
           and_return JSON.generate(boards_details.first)
 
         card.add_comment "testing"
@@ -265,7 +265,7 @@ module Trello
       end
 
       it "can add a label" do
-        client.stub(:post).with("/cards/abcdef123456789123456789/labels", { :value => 'green' }).
+        client.stub(:post).with("/cards/abcdef123456789123456789/labels", { value: 'green' }).
           and_return "not important"
         card.add_label('green')
         expect(card.errors).to be_empty
@@ -288,7 +288,7 @@ module Trello
       end
 
       it "throws an error when trying to add a label with an unknown colour" do
-        client.stub(:post).with("/cards/abcdef123456789123456789/labels", { :value => 'green' }).
+        client.stub(:post).with("/cards/abcdef123456789123456789/labels", { value: 'green' }).
           and_return "not important"
         card.add_label('mauve')
         expect(card.errors.full_messages.to_sentence).to eq("Label colour 'mauve' does not exist")
@@ -307,7 +307,7 @@ module Trello
         f = File.new('spec/list_spec.rb', 'r')
         client.stub(:get).with("/cards/abcdef123456789123456789/attachments").and_return attachments_payload
         client.stub(:post).with("/cards/abcdef123456789123456789/attachments",
-              { :file => f, :name => ''  }).
+              { file: f, name: ''  }).
               and_return "not important"
 
         card.add_attachment(f)
@@ -358,7 +358,7 @@ module Trello
     describe "#close!" do
       it "updates the close attribute to true and saves the list" do
         payload = {
-          :closed    => true,
+          closed: true,
         }
 
         client.should_receive(:put).once.with("/cards/abcdef123456789123456789", payload)

data/spec/checklist_spec.rb

@@ -28,19 +28,19 @@ module Trello
     context "creating" do
       let(:client) { Trello.client }
 
-      it 'creates a new record and saves it on Trello', :refactor => true do
+      it 'creates a new record and saves it on Trello', refactor: true do
         payload = {
-            :name => 'Test Checklist',
-            :desc => '',
+            name: 'Test Checklist',
+            desc: '',
         }
 
-        result = JSON.generate(checklists_details.first.merge(payload.merge(:idBoard => boards_details.first['id'])))
+        result = JSON.generate(checklists_details.first.merge(payload.merge(idBoard: boards_details.first['id'])))
 
-        expected_payload = {:name => "Test Checklist", :idBoard => "abcdef123456789123456789"}
+        expected_payload = {name: "Test Checklist", idBoard: "abcdef123456789123456789"}
 
         client.should_receive(:post).with("/checklists", expected_payload).and_return result
 
-        checklist = Checklist.create(checklists_details.first.merge(payload.merge(:board_id => boards_details.first['id'])))
+        checklist = Checklist.create(checklists_details.first.merge(payload.merge(board_id: boards_details.first['id'])))
 
         checklist.class.should be Checklist
       end
@@ -66,8 +66,8 @@ module Trello
         expected_new_name = "xxx"
         expected_resource = "/checklists/abcdef123456789123456789"
         payload = {
-            :name => expected_new_name,
-            :pos => checklist.position
+            name: expected_new_name,
+            pos: checklist.position
         }
 
         result = JSON.generate(checklists_details.first)
@@ -81,8 +81,8 @@ module Trello
         expected_new_position = 33
         expected_resource = "/checklists/abcdef123456789123456789"
         payload = {
-            :name => checklist.name,
-            :pos => expected_new_position
+            name: checklist.name,
+            pos: expected_new_position
         }
 
         result = JSON.generate(checklists_details.first)
@@ -97,14 +97,14 @@ module Trello
         expected_checked = true
         expected_pos = 9999
         payload = {
-            :name => expected_item_name,
-            :checked => expected_checked,
-            :pos => expected_pos
+            name: expected_item_name,
+            checked: expected_checked,
+            pos: expected_pos
         }
         result_hash = {
-            :name => expected_item_name,
-            :state => expected_checked ? 'complete' : 'incomplete',
-            :pos => expected_pos
+            name: expected_item_name,
+            state: expected_checked ? 'complete' : 'incomplete',
+            pos: expected_pos
         }
         result = JSON.generate(result_hash)
         client.should_receive(:post).once.with("/checklists/abcdef123456789123456789/checkItems", payload).and_return result

data/spec/client_spec.rb

@@ -6,8 +6,8 @@ include Trello::Authorization
 describe Client, "and how it handles authorization" do
   let (:fake_ok_response) do
     double "A fake OK response",
-      :code => 200,
-      :body => "A fake response body"
+      code: 200,
+      body: "A fake response body"
   end
   let(:client) { Client.new }
   let(:auth_policy) { double }
@@ -33,7 +33,7 @@ describe Client, "and how it handles authorization" do
 
     TInternet.should_receive(:execute).once.with expected_request
 
-    client.get "/xxx", :a => "1", :b => "2"
+    client.get "/xxx", a: "1", b: "2"
   end
 
   it "encodes parameters" do
@@ -42,14 +42,14 @@ describe Client, "and how it handles authorization" do
 
     TInternet.should_receive(:execute).once.with expected_request
 
-    client.get "/xxx", :name => "Jazz Kang"
+    client.get "/xxx", name: "Jazz Kang"
   end
 
   it "raises an error when response has non-200 status" do
     expected_error_message = "An error response"
     response_with_non_200_status = double "A fake OK response",
-      :code => 404,
-      :body => expected_error_message
+      code: 404,
+      body: expected_error_message
 
     TInternet.stub(:execute).and_return response_with_non_200_status
 
@@ -77,11 +77,11 @@ describe Client, "and how it handles authorization" do
   it "supports post" do
     TInternet.should_receive(:execute).once.and_return fake_ok_response
 
-    client.post "/xxx", { :phil => "T' north" }
+    client.post "/xxx", { phil: "T' north" }
   end
 
   it "supplies the body for a post" do
-    expected_body = { :name => "Phil", :nickname => "The Crack Fox" }
+    expected_body = { name: "Phil", nickname: "The Crack Fox" }
 
     TInternet.should_receive(:execute).once do |request|
       request.body.should == expected_body
@@ -105,11 +105,11 @@ describe Client, "and how it handles authorization" do
   it "supports put" do
     TInternet.should_receive(:execute).once.and_return fake_ok_response
 
-    client.put "/xxx", { :phil => "T' north" }
+    client.put "/xxx", { phil: "T' north" }
   end
 
   it "supplies the body for a put" do
-    expected_body = { :name => "Phil", :nickname => "The Crack Fox" }
+    expected_body = { name: "Phil", nickname: "The Crack Fox" }
 
     TInternet.should_receive(:execute).once do |request|
       request.body.should == expected_body
@@ -133,10 +133,10 @@ describe Client, "and how it handles authorization" do
   context "initialize" do
     let(:client) do
       Client.new(
-        :consumer_key => 'consumer_key',
-        :consumer_secret => 'consumer_secret',
-        :oauth_token => 'oauth_token',
-        :oauth_token_secret => 'oauth_token_secret'
+        consumer_key: 'consumer_key',
+        consumer_secret: 'consumer_secret',
+        oauth_token: 'oauth_token',
+        oauth_token_secret: 'oauth_token_secret'
       )
     end