ruby-lint 1.1.0 → 2.0.0

data/spec/ruby-lint/analysis/undefined_variables_spec.rb

@@ -1,138 +0,0 @@
-require 'spec_helper'
-
-describe RubyLint::Analysis::UndefinedVariables do
-  example 'add an error for using an undefined instance variable' do
-    report = build_report('@number', RubyLint::Analysis::UndefinedVariables)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 1
-    entry.column.should  == 1
-    entry.message.should == 'undefined instance variable @number'
-  end
-
-  example 'add an error for using an undefined class variable' do
-    report = build_report('@@number', RubyLint::Analysis::UndefinedVariables)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 1
-    entry.column.should  == 1
-    entry.message.should == 'undefined class variable @@number'
-  end
-
-  example 'add an error for using an undefined global variable' do
-    report = build_report('$number', RubyLint::Analysis::UndefinedVariables)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 1
-    entry.column.should  == 1
-    entry.message.should == 'undefined global variable $number'
-  end
-
-  example 'add an error for using an undefined constant' do
-    report = build_report('NUMBER', RubyLint::Analysis::UndefinedVariables)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 1
-    entry.column.should  == 1
-    entry.message.should == 'undefined constant NUMBER'
-  end
-
-  example 'add an error for using an undefined constant path' do
-    code = <<-CODE
-# This is to ensure that the on_const() callback isn't used to check for "B"
-# in the global scope.
-B = 10
-
-module A
-end
-
-A::B
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedVariables)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 8
-    entry.column.should  == 1
-    entry.message.should == 'undefined constant A::B'
-  end
-
-  example 'do not depend on the order of variable definitions' do
-    code = <<-CODE
-class Person
-  def first
-    @number = 10
-  end
-
-  def second
-    return @number
-  end
-end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedVariables)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'do not add errors when autoloading constants' do
-    code   = 'Encoding::BIG5'
-    report = build_report(code, RubyLint::Analysis::UndefinedVariables)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'do not error when inheriting data in a block' do
-    code = <<-CODE
-NUMBER = 10
-
-example_method do
-  NUMBER
-end
-CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedVariables)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'do not add errors for variable references in string interpolation' do
-    code   = 'number = 10; "#{number}"'
-    report = build_report(code, RubyLint::Analysis::UndefinedVariables)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'do not add errors for class names' do
-    code = <<-CODE
-class Foo
-end
-
-module Namespace
-  class Bar
-  end
-end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedVariables)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'do not add errors when aliasing global variables' do
-    code   = 'alias $ARGV $*'
-    report = build_report(code, RubyLint::Analysis::UndefinedVariables)
-
-    report.entries.empty?.should == true
-  end
-end

data/spec/ruby-lint/analysis/unused_variables_spec.rb

@@ -1,270 +0,0 @@
-require 'spec_helper'
-
-describe RubyLint::Analysis::UnusedVariables do
-  example 'warn for unused local variables' do
-    report = build_report('number = 1', RubyLint::Analysis::UnusedVariables)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 1
-    entry.column.should  == 1
-    entry.message.should == 'unused local variable number'
-  end
-
-  example 'warn for unused instance variables' do
-    report = build_report('@number = 1', RubyLint::Analysis::UnusedVariables)
-    entry = report.entries[0]
-
-    entry.line.should    == 1
-    entry.column.should  == 1
-    entry.message.should == 'unused instance variable @number'
-  end
-
-  example 'do not warn for used variables' do
-    code = <<-CODE
-number = 1
-
-number
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UnusedVariables)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'warn for unused constants' do
-    report = build_report('NUMBER = 10', RubyLint::Analysis::UnusedVariables)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 1
-    entry.column.should  == 1
-    entry.message.should == 'unused constant NUMBER'
-  end
-
-  example 'do not warn for used constants' do
-    code = <<-CODE
-A = 10
-
-A
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UnusedVariables)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'warn for unused constant paths' do
-    code = <<-CODE
-module A
-end
-
-A::B = 10
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UnusedVariables)
-
-    report.entries.length.should == 1
-
-    entry = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 4
-    entry.column.should  == 1
-    entry.message.should == 'unused constant A::B'
-  end
-
-  example 'warn for unused variables in a method scope' do
-    code = <<-CODE
-def some_method
-  number = 10
-end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UnusedVariables)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 2
-    entry.column.should  == 3
-    entry.message.should == 'unused local variable number'
-  end
-
-  example 'do not add a warning when assigning a variable to another variable' do
-    code = <<-CODE
-first  = 10
-second = first
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UnusedVariables)
-
-    report.entries.length.should == 1
-
-    entry = report.entries[0]
-
-    entry.line.should    == 2
-    entry.column.should  == 1
-    entry.message.should == 'unused local variable second'
-  end
-
-  example 'do not add warnings when defining classes and modules' do
-    code = <<-CODE
-module A
-end
-
-class B
-end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UnusedVariables)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'ignore ivars if there is a corresponding method' do
-    code = <<-CODE
-@number = 10
-
-def number; end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UnusedVariables)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'ignore local variables that start with an underscore' do
-    report = build_report('_number = 10', RubyLint::Analysis::UnusedVariables)
-
-    report.entries.empty?.should == true
-  end
-
-  context 'method arguments' do
-    example 'warn for a unused argument' do
-      code = <<-CODE
-def multiply(number)
-end
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UnusedVariables)
-      entry  = report.entries[0]
-
-      entry.message.should == 'unused argument number'
-      entry.line.should    == 1
-      entry.column.should  == 14
-    end
-
-    example 'warn for a unused optional argument' do
-      code = <<-CODE
-def multiply(amount = 2)
-end
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UnusedVariables)
-      entry  = report.entries[0]
-
-      entry.message.should == 'unused argument amount'
-      entry.line.should    == 1
-      entry.column.should  == 14
-    end
-
-    example 'warn for a unused rest argument' do
-      code = <<-CODE
-def multiply(*args)
-end
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UnusedVariables)
-      entry  = report.entries[0]
-
-      entry.message.should == 'unused argument args'
-      entry.line.should    == 1
-      entry.column.should  == 14
-    end
-
-    example 'warn for a unused block argument' do
-      code = <<-CODE
-def multiply(&block)
-end
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UnusedVariables)
-      entry  = report.entries[0]
-
-      entry.message.should == 'unused argument block'
-      entry.line.should    == 1
-      entry.column.should  == 14
-    end
-
-    specific_ruby_version '2.0' do
-      example 'warn for a unused keyword argument' do
-        code = <<-CODE
-def multiply(amount: 10)
-end
-        CODE
-
-        report = build_report(code, RubyLint::Analysis::UnusedVariables)
-        entry  = report.entries[0]
-
-        entry.message.should == 'unused argument amount'
-        entry.line.should    == 1
-        entry.column.should  == 14
-      end
-    end
-
-    example 'do not warn for a used argument' do
-      code = <<-CODE
-def multiply(number)
-  return number * 2
-end
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UnusedVariables)
-
-      report.entries.empty?.should == true
-    end
-
-    example 'do not warn for unused anonymous splat arguments' do
-      code = <<-CODE
-def example(*)
-end
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UnusedVariables)
-
-      report.entries.empty?.should == true
-    end
-  end
-
-  context 'block arguments' do
-    example 'warn for a unused argument' do
-      code = <<-CODE
-[10, 20].each do |number|
-end
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UnusedVariables)
-      entry  = report.entries[0]
-
-      entry.message.should == 'unused argument number'
-      entry.line.should    == 1
-      entry.column.should  == 19
-    end
-
-    example 'do not warn for a used argument' do
-      code = <<-CODE
-[10, 20].each do |number|
-  number
-end
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UnusedVariables)
-
-      report.entries.empty?.should == true
-    end
-  end
-end

data/spec/ruby-lint/analysis/useless_equality_checks_spec.rb

@@ -1,107 +0,0 @@
-require 'spec_helper'
-
-describe RubyLint::Analysis::UselessEqualityChecks do
-  example 'compare a String literal with a Fixnum literal' do
-    code   = "'foo' == 10"
-    report = build_report(code, RubyLint::Analysis::UselessEqualityChecks)
-    entry  = report.entries[0]
-
-    entry.line.should    == 1
-    entry.column.should  == 1
-    entry.message.should == 'Comparing String with Fixnum evaluates to false'
-  end
-
-  example 'compare a variable with a Fixnum literal' do
-    code = <<-EOF
-string = 'foo'
-
-string == 10
-    EOF
-
-    report = build_report(code, RubyLint::Analysis::UselessEqualityChecks)
-    entry  = report.entries[0]
-
-    entry.message.should == 'Comparing String with Fixnum evaluates to false'
-  end
-
-  example 'compare two variables' do
-    code = <<-EOF
-string = 'foo'
-number = 10
-
-string == number
-    EOF
-
-    report = build_report(code, RubyLint::Analysis::UselessEqualityChecks)
-    entry  = report.entries[0]
-
-    entry.message.should == 'Comparing String with Fixnum evaluates to false'
-  end
-
-  example 'compare a String literal with a method call' do
-    code = <<-EOF
-# @return [Fixnum]
-def number
-  return 10
-end
-
-'foo' == number
-    EOF
-
-    report = build_report(code, RubyLint::Analysis::UselessEqualityChecks)
-    entry  = report.entries[0]
-
-    entry.message.should == 'Comparing String with Fixnum evaluates to false'
-  end
-
-  example 'ignore values that are unknown' do
-    code = <<-EOF
-def foo
-end
-
-10 == foo
-    EOF
-
-    report = build_report(code, RubyLint::Analysis::UselessEqualityChecks)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'calling methods on objects that return unknown values' do
-    code = <<-CODE
-def example(number)
-  return '10' == number.to_s
-end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UselessEqualityChecks)
-
-    report.entries.empty?.should == true
-  end
-
-  context 'ignoring variables with unknown values' do
-    example 'ignore a local variable without a value' do
-      code = <<-CODE
-[10, 20].each do |number|
-  number == false
-end
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UselessEqualityChecks)
-
-      report.entries.empty?.should == true
-    end
-
-    example 'ignore an instance variable without a value' do
-      code = <<-CODE
-[10, 20].each do |@number|
-  @number == false
-end
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UselessEqualityChecks)
-
-      report.entries.empty?.should == true
-    end
-  end
-end