ruby-lint 1.1.0 → 2.0.0

data/spec/fixtures/config.yml

@@ -1,8 +0,0 @@
----
-report_levels:
-  - info
-
-analysis_classes:
-  - undefined_methods
-
-presenter: json

data/spec/fixtures/deeply/nested/file.rb

@@ -1 +0,0 @@
-foobar

data/spec/fixtures/file_scanner/lib/example/recursive/source.rb

@@ -1,6 +0,0 @@
-module Example
-  module Recursive
-    class Source < Target
-    end # Source
-  end # Recursive
-end # Example

data/spec/fixtures/file_scanner/lib/example/recursive/target.rb

@@ -1,8 +0,0 @@
-module Example
-  module Recursive
-    class Target
-      def example_method
-      end
-    end # Target
-  end # Recursive
-end # Example

data/spec/fixtures/file_scanner/lib/example/user.rb

@@ -1,6 +0,0 @@
-module Example
-  class User
-    def example_method
-    end
-  end
-end

data/spec/fixtures/file_scanner/lib/ruby-lint/definition/constant_proxy.rb

@@ -1,6 +0,0 @@
-module Definition
-  class ConstantProxy
-    def initialize(definitions, name)
-    end
-  end # ConstantProxy
-end # Definition

data/spec/fixtures/file_scanner/lib/ruby-lint/global_scope.rb

@@ -1,6 +0,0 @@
-module RubyLint
-  module GlobalScope
-    def self.definitions
-    end
-  end # GlobalScope
-end # RubyLint

data/spec/fixtures/file_scanner/lib/test-dashes/foo.rb

@@ -1,4 +0,0 @@
-module TestDashes
-  module Foo
-  end # Foo
-end # TestDashes

data/spec/fixtures/file_scanner/rails/app/models/example/user.rb

@@ -1,6 +0,0 @@
-module Example
-  class User
-    def example_method
-    end
-  end
-end

data/spec/fixtures/file_scanner/rails/app/models/user.rb

@@ -1,4 +0,0 @@
-class User
-  def example_method
-  end
-end

data/spec/fixtures/invalid.rb

@@ -1,3 +0,0 @@
-name = 'Ruby'
-
-name.foobar

data/spec/fixtures/invalid_2.rb

@@ -1,3 +0,0 @@
-name = 'Ruby'
-
-name.derp

data/spec/fixtures/syntax_error.rb

@@ -1 +0,0 @@
-module Foo

data/spec/fixtures/uses_external.rb

@@ -1 +0,0 @@
-User.new

data/spec/fixtures/uses_external_invalid.rb

@@ -1,3 +0,0 @@
-user = User.new
-
-user.foobar

data/spec/fixtures/uses_external_namespace.rb

@@ -1 +0,0 @@
-Example::User.new

data/spec/fixtures/valid.rb

@@ -1,3 +0,0 @@
-name = 'Ruby'
-
-name.upcase

data/spec/ruby-lint/analysis/argument_amount_spec.rb

@@ -1,131 +0,0 @@
-require 'spec_helper'
-
-describe RubyLint::Analysis::ArgumentAmount do
-  example 'validate the amount of required arguments' do
-    code = <<-CODE
-def example(first, second)
-end
-
-example
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 4
-    entry.column.should  == 1
-    entry.message.should == 'wrong number of arguments (expected 2 but got 0)'
-  end
-
-  example 'validate argument amounts when using optional arguments' do
-    code = <<-CODE
-def example(first, second, third = nil)
-end
-
-example
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 4
-    entry.column.should  == 1
-    entry.message.should == 'wrong number of arguments ' \
-      '(expected 2..3 but got 0)'
-  end
-
-  example 'validate argument amounts when using rest arguments' do
-    code = <<-CODE
-def example(first, second, *args)
-end
-
-example
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 4
-    entry.column.should  == 1
-    entry.message.should == 'wrong number of arguments ' \
-      '(expected 2 but got 0)'
-  end
-
-  example 'validate argument amounts when using a required and rest argument' do
-    code = <<-CODE
-def example(required, *numbers)
-end
-
-example(10, 20, 30)
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
-
-    report.entries.length.should == 0
-  end
-
-  example 'take variable assignments into account' do
-    code = <<-CODE
-name = 'Ruby'
-
-name.downcase
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'not validate methods called on undefined receivers' do
-    code   = 'A.example_method'
-    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'use #initialize for arguments when processing .new' do
-    code = <<-CODE
-class Person
-  def initialize(name)
-  end
-end
-
-Person.new
-Person.new(10, 20)
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
-
-    report.entries.length.should == 2
-
-    first, second = report.entries
-
-    first.line.should    == 6
-    first.column.should  == 1
-    first.message.should == 'wrong number of arguments (expected 1 but got 0)'
-
-    second.line.should    == 7
-    second.column.should  == 1
-    second.message.should == 'wrong number of arguments (expected 1 but got 2)'
-  end
-
-  example 'ignore block arguments' do
-    code = <<-CODE
-def example; end
-
-block = proc {}
-
-example(&block)
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
-
-    report.entries.empty?.should == true
-  end
-end

data/spec/ruby-lint/analysis/base_spec.rb

@@ -1,24 +0,0 @@
-require 'spec_helper'
-
-describe RubyLint::Analysis::Base do
-  example 'require a VM' do
-    lambda { RubyLint::Analysis::Base.new }.should raise_error(ArgumentError)
-
-    vm  = RubyLint::VirtualMachine.new
-    blk = lambda { RubyLint::Analysis::Base.new(:vm => vm) }
-
-    blk.should_not raise_error
-  end
-
-  example 'allow config objects to be passed in' do
-    vm     = RubyLint::VirtualMachine.new
-    config = RubyLint::Configuration.new
-    base   = RubyLint::Analysis::Base.new(:vm => vm, :config => config)
-
-    base.config.should == config
-  end
-
-  example 'enable analysis by default' do
-    RubyLint::Analysis::Base.analyze?(double(:ast), double(:vm)).should == true
-  end
-end

data/spec/ruby-lint/analysis/pedantics_spec.rb

@@ -1,63 +0,0 @@
-require 'spec_helper'
-
-describe RubyLint::Analysis::Pedantics do
-  example 'warn when using do/then in various statements' do
-    code = <<-CODE
-if true then; end
-unless true then; end
-while true do; end
-    CODE
-
-    report  = build_report(code, RubyLint::Analysis::Pedantics)
-    entries = report.entries
-
-    entries.length.should == 3
-
-    entries[0].line.should    == 1
-    entries[0].message.should == 'the use of then/do is not needed here'
-
-    entries[1].line.should    == 2
-    entries[1].message.should == 'the use of then/do is not needed here'
-
-    entries[2].line.should    == 3
-    entries[2].message.should == 'the use of then/do is not needed here'
-  end
-
-  # See https://github.com/YorickPeterse/ruby-lint/issues/32 for the motivation
-  # behind this test.
-  example 'not warn when no do/then identifier is used in a statement' do
-    code = <<-CODE.strip
-if true; end
-
-if foo && bar
-  true
-else
-  false
-end
-
-foo ? true : false
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::Pedantics)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'warn for the use of BEGIN/END' do
-    code = <<-CODE
-BEGIN {}
-END {}
-    CODE
-
-    report  = build_report(code, RubyLint::Analysis::Pedantics)
-    entries = report.entries
-
-    entries.length.should == 2
-
-    entries[0].line.should    == 1
-    entries[0].message.should == 'BEGIN/END is useless'
-
-    entries[1].line.should    == 2
-    entries[1].message.should == 'BEGIN/END is useless'
-  end
-end

data/spec/ruby-lint/analysis/shadowing_variables_spec.rb

@@ -1,85 +0,0 @@
-require 'spec_helper'
-
-describe RubyLint::Analysis::ShadowingVariables do
-  example 'warn for shadowing outer variables' do
-    code = <<-CODE
-number = 10
-
-[10, 20].each do |number|
-  puts number
-end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::ShadowingVariables)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 3
-    entry.column.should  == 19
-    entry.message.should == 'shadowing outer local variable number'
-  end
-
-  example 'not warn for shadowed variables in a new scope' do
-    code = <<-CODE
-number = 10
-
-def example
-  [10, 20].each do |number|
-    puts number
-  end
-end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::ShadowingVariables)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'warn when shadowing variables after a new scope' do
-    code = <<-CODE
-number = 10
-
-def example; end
-
-[10, 20].each do |number|
-  puts number
-end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::ShadowingVariables)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 5
-    entry.column.should  == 19
-    entry.message.should == 'shadowing outer local variable number'
-  end
-
-  example 'not fail when re-using the same block' do
-    code = <<-CODE
-number = 10
-
-A::B.example do |number|
-  number
-end
-
-A::B.example do |number|
-  number
-end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::ShadowingVariables)
-
-    report.entries.length.should == 2
-
-    first, second = report.entries
-
-    first.line.should    == 3
-    first.column.should  == 18
-
-    second.line.should    == 7
-    second.column.should  == 18
-  end
-end

data/spec/ruby-lint/analysis/undefined_methods_spec.rb

@@ -1,337 +0,0 @@
-require 'spec_helper'
-
-describe RubyLint::Analysis::UndefinedMethods do
-  example 'add an error for calling an undefined method' do
-    report = build_report('example_method', RubyLint::Analysis::UndefinedMethods)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 1
-    entry.column.should  == 1
-    entry.message.should == 'undefined method example_method'
-  end
-
-  example 'add an error for calling an undefined method with a receiver' do
-    code = <<-CODE
-class << self
-  def example_method
-  end
-end
-
-String.example_method
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 6
-    entry.column.should  == 1
-    entry.message.should == 'undefined method example_method on String'
-  end
-
-  example 'add an error for calling an undefined method on a receiver instance' do
-    code   = '"hello".example_method'
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-    entry  = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 1
-    entry.column.should  == 1
-    entry.message.should == 'undefined method example_method ' \
-      'on an instance of String'
-  end
-
-  example 'add an error when calling a method defined in a different scope' do
-    code = <<-CODE
-class Person
-  def person_name
-    return 'name'
-  end
-
-  def greet
-    name
-  end
-end
-
-person_name
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-    report.entries.length.should == 1
-
-    entry = report.entries[0]
-
-    entry.is_a?(RubyLint::Report::Entry).should == true
-
-    entry.line.should    == 11
-    entry.column.should  == 1
-    entry.message.should == 'undefined method person_name'
-  end
-
-  describe 'core Ruby types' do
-    example 'do not add errors for calling defined methods on a Fixnum' do
-      report = build_report('10.to_s', RubyLint::Analysis::UndefinedMethods)
-
-      report.entries.empty?.should == true
-    end
-
-    example 'do not add errors for calling defined methods on a Float' do
-      report = build_report('(10.0).to_s', RubyLint::Analysis::UndefinedMethods)
-
-      report.entries.empty?.should == true
-    end
-
-    example 'do not add errors for calling defined methods on a String' do
-      report = build_report('"10".to_s', RubyLint::Analysis::UndefinedMethods)
-
-      report.entries.empty?.should == true
-    end
-
-    example 'do not add errors for calling defined methods on a Hash' do
-      report = build_report('{}.to_s', RubyLint::Analysis::UndefinedMethods)
-
-      report.entries.empty?.should == true
-    end
-
-    example 'do not add errors for calling defined methods on an Array' do
-      report = build_report('[].to_s', RubyLint::Analysis::UndefinedMethods)
-
-      report.entries.empty?.should == true
-    end
-  end
-
-  example 'do not add errors for variables created using blocks' do
-    code = <<-CODE
-[10, 20].each do |number|
-  number.to_s
-end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'take variable assignments into account' do
-    code = <<-CODE
-name = 'Ruby'
-
-name.downcase
-name.downcasex
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-    report.entries.length.should == 1
-
-    entry = report.entries[0]
-
-    entry.line.should    == 4
-    entry.column.should  == 1
-    entry.message.should == 'undefined method downcasex on an instance of String'
-  end
-
-  example 'take variable assignments and custom classes into account' do
-    code = <<-CODE
-class User
-  def example
-  end
-end
-
-user = User.new
-
-user.example
-user.invalid
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-    report.entries.length.should == 1
-
-    entry = report.entries[0]
-
-    entry.line.should    == 9
-    entry.column.should  == 1
-    entry.message.should == 'undefined method invalid on an instance of User'
-  end
-
-  example 'do not add errors when calling a method on an undefined constant' do
-    code = 'A.example_method'
-
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'do not add errors for methods called on variables without values' do
-    code = <<-CODE
-def example(number)
-  number.to_s
-end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'report the right receiver name in multiple variable assignments' do
-    code = <<-CODE
-number = 10
-
-first = second = number.foobar
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-    report.entries.length.should == 1
-
-    entry = report.entries[0]
-
-    entry.message.should == 'undefined method foobar on an instance of Fixnum'
-  end
-
-  example 'ignore methods calls on other non existing methods' do
-    code   = 'foo.bar'
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-    report.entries.length.should == 1
-
-    report.entries[0].message.should == 'undefined method foo'
-  end
-
-  example 'ignore methods calls with arguments on other non existing methods' do
-    code   = 'foo.bar(:baz)'
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-    report.entries.length.should == 1
-
-    report.entries[0].message.should == 'undefined method foo'
-  end
-
-  context 'Kernel methods' do
-    example 'do not add errors for methods defined in Kernel' do
-      code   = 'puts "hello"'
-      report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-      report.entries.empty?.should == true
-    end
-
-    example 'do not add errors for Kernel methods in an sclass in a module' do
-      code = <<-CODE
-module Foo
-  def self.foo
-  end
-
-  class << self
-    alias_method :foo, :bar
-  end
-end
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-      report.entries.empty?.should == true
-    end
-  end
-
-  context 'core Ruby methods' do
-    example 'do not add errors for #include' do
-      code = <<-CODE
-module Foo
-end
-
-class Bar
-  include Foo
-end
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-      report.entries.empty?.should == true
-    end
-
-    example 'do not add errors for #attr_reader' do
-      code = <<-CODE
-class Bar
-  attr_reader :foobar
-end
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-      report.entries.empty?.should == true
-    end
-  end
-
-  example 'properly handle method lookups in blocks' do
-    code = <<-CODE
-class Foo
-  def baz
-  end
-
-  [10, 20].each do
-    define_method(:example) do
-      baz
-    end
-  end
-end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'do not add errors for private/protected/public' do
-    code = <<-CODE
-private
-protected
-public
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-    report.entries.empty?.should == true
-  end
-
-  example 'use the correct error message for YARD documented arguments' do
-    code = <<-CODE
-##
-# @param [Fixnum|Bignum|Numeric] number
-#
-def double(number)
-  return number.to_foo
-end
-    CODE
-
-    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-    entry  = report.entries[0]
-
-    entry.line.should    == 5
-    entry.message.should == 'undefined method to_foo on an instance of ' \
-      'Fixnum, Bignum or Numeric'
-  end
-
-  context 'method missing' do
-    example 'do not add errors when method_missing is defined' do
-      code = <<-CODE
-class Foo
-  def method_missing; end
-end
-
-foo = Foo.new
-foo.bar
-      CODE
-
-      report = build_report(code, RubyLint::Analysis::UndefinedMethods)
-
-      report.entries.empty?.should == true
-    end
-  end
-end