ruby-lint 0.0.4 → 0.0.5

data/spec/ruby-lint/virtual_machine/assignments/{optional.rb → optional_spec.rb}

@@ -1,14 +1,14 @@
-require File.expand_path('../../../../helper', __FILE__)
+require 'spec_helper'
 
 describe 'Building variable definitions' do
   describe 'OR assignments' do
-    should 'assign a non existing local variable' do
+    example 'assign a non existing local variable' do
       defs = build_definitions('number ||= 10')
 
       defs.lookup(:lvar, 'number').value.value.should == 10
     end
 
-    should 'not overwrite an existing variable' do
+    example 'not overwrite an existing variable' do
       code = <<-CODE
 number   = 10
 number ||= 20
@@ -21,13 +21,13 @@ number ||= 20
   end
 
   describe 'AND assignments' do
-    should 'not assign a non existing local variable' do
+    example 'not assign a non existing local variable' do
       defs = build_definitions('number &&= 10')
 
       defs.lookup(:lvar, 'number').nil?.should == true
     end
 
-    should 'overwrite an existing variable' do
+    example 'overwrite an existing variable' do
       code = <<-CODE
 number   = 10
 number &&= 20
@@ -38,4 +38,4 @@ number &&= 20
       defs.lookup(:lvar, 'number').value.value.should == 20
     end
   end
-end
+end

data/spec/ruby-lint/virtual_machine/assignments/{return_values.rb → return_values_spec.rb}

@@ -1,7 +1,7 @@
-require File.expand_path('../../../../helper', __FILE__)
+require 'spec_helper'
 
 describe 'Using return values in assignments' do
-  it 'should assign a return value' do
+  example 'assign a return value' do
     code  = 'word = String.new'
     defs  = build_definitions(code)
     value = defs.lookup(:lvar, 'word').value
@@ -13,7 +13,7 @@ describe 'Using return values in assignments' do
     value.instance?.should == true
   end
 
-  it 'should assign a nil value for a missing return value' do
+  example 'assign a nil value for a missing return value' do
     code = <<-CODE
 def example
 end
@@ -23,10 +23,10 @@ number = example
 
     defs = build_definitions(code)
 
-    defs.lookup(:lvar, 'number').value.nil?.should == true
+    defs.lookup(:lvar, 'number').value.type.should == :unknown
   end
 
-  it 'should assign return values when chaining method calls' do
+  example 'assign return values when chaining method calls' do
     code  = 'word = String.new.initialize.initialize'
     defs  = build_definitions(code)
     value = defs.lookup(:lvar, 'word').value
@@ -39,37 +39,37 @@ number = example
   end
 
   describe 'setting instance types for core Ruby types' do
-    should 'create a new String instance' do
+    example 'create a new String instance' do
       defs = build_definitions('number = "10"')
 
       defs.lookup(:lvar, 'number').value.instance?.should == true
     end
 
-    should 'create a new Symbol instance' do
+    example 'create a new Symbol instance' do
       defs = build_definitions('number = :"10"')
 
       defs.lookup(:lvar, 'number').value.instance?.should == true
     end
 
-    should 'create a new Fixnum instance' do
+    example 'create a new Fixnum instance' do
       defs = build_definitions('number = 10')
 
       defs.lookup(:lvar, 'number').value.instance?.should == true
     end
 
-    should 'create a new Float instance' do
+    example 'create a new Float instance' do
       defs = build_definitions('number = 10.0')
 
       defs.lookup(:lvar, 'number').value.instance?.should == true
     end
 
-    should 'create a new Array instance' do
+    example 'create a new Array instance' do
       defs = build_definitions('number = [10]')
 
       defs.lookup(:lvar, 'number').value.instance?.should == true
     end
 
-    should 'create a new Hash instance' do
+    example 'create a new Hash instance' do
       defs = build_definitions('number = {:a => 10}')
 
       defs.lookup(:lvar, 'number').value.instance?.should == true

data/spec/ruby-lint/virtual_machine/assignments/{variables.rb → variables_spec.rb}

@@ -1,8 +1,8 @@
-require File.expand_path('../../../../helper', __FILE__)
+require 'spec_helper'
 
 describe RubyLint::VirtualMachine do
-  describe 'variable assignments' do
-    should 'assign different types of variables' do
+  context 'variable assignments' do
+    example 'assign different types of variables' do
       types = {
         'number'   => :lvar,
         '@number'  => :ivar,
@@ -19,7 +19,7 @@ describe RubyLint::VirtualMachine do
       end
     end
 
-    should 'assign multiple values to multiple variables' do
+    example 'assign multiple values to multiple variables' do
       defs    = build_definitions('number, numberx = 10, 20')
       number  = defs.lookup(:lvar, 'number')
       numberx = defs.lookup(:lvar, 'numberx')
@@ -35,7 +35,7 @@ describe RubyLint::VirtualMachine do
       numberx.value.value.should == 20
     end
 
-    should 'assign a value to a constant path' do
+    example 'assign a value to a constant path' do
       defs = build_definitions('Kernel::FOO = 10')
       foo  = defs.lookup(:const, 'Kernel').lookup(:const, 'FOO')
 
@@ -45,7 +45,7 @@ describe RubyLint::VirtualMachine do
       foo.value.value.should == 10
     end
 
-    should 'assign a single value to multiple variables' do
+    example 'assign a single value to multiple variables' do
       code = 'first = second = third = 10'
       defs = build_definitions(code)
 
@@ -59,7 +59,7 @@ describe RubyLint::VirtualMachine do
       end
     end
 
-    should 'resolve variables in assignments' do
+    example 'resolve variables in assignments' do
       code = <<-CODE
 a = 1
 b = a
@@ -81,5 +81,36 @@ d = c
 
       defs.lookup(:lvar, 'foo').value.value.should == 100
     end
+
+    example 'assign nil to a value' do
+      defs  = build_definitions('variable = nil')
+      value = defs.lookup(:lvar, 'variable').value
+
+      value.type.should            == :nil
+      value.parents[0].name.should == 'NilClass'
+    end
+
+    example 'assign true to a value' do
+      defs  = build_definitions('variable = true')
+      value = defs.lookup(:lvar, 'variable').value
+
+      value.type.should            == :true
+      value.parents[0].name.should == 'TrueClass'
+    end
+
+    example 'assign false to a value' do
+      defs  = build_definitions('variable = false')
+      value = defs.lookup(:lvar, 'variable').value
+
+      value.type.should            == :false
+      value.parents[0].name.should == 'FalseClass'
+    end
+
+    example 'assigning a magic global variable to a variable' do
+      defs  = build_definitions('variable = $1')
+      value = defs.lookup(:lvar, 'variable').value
+
+      value.type.should == :unknown
+    end
   end
 end

data/spec/ruby-lint/virtual_machine/associate_nodes_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe RubyLint::VirtualMachine do
+  example 'associate AST nodes and their definitions' do
+    tokens = parse('def foobar; end', false)
+    vm     = RubyLint::VirtualMachine.new
+
+    vm.iterate(tokens)
+
+    defs   = vm.definitions
+    assoc  = vm.associations
+    method = tokens.children[0]
+
+    assoc.key?(method).should == true
+    assoc[method].should      == defs.lookup(:instance_method, 'foobar')
+  end
+
+  describe 'method calls' do
+    example 'should not add associations' do
+      associations = build_associations('foo')
+      nodes        = associations.keys
+
+      nodes.length.should  == 1
+      nodes[0].type.should == :root
+    end
+
+    example 'should not add associations for methods with arguments' do
+      associations = build_associations('foo(:bar)')
+      nodes        = associations.keys
+
+      nodes.length.should  == 1
+      nodes[0].type.should == :root
+    end
+
+    example 'should not add associations for methods called on methods' do
+      associations = build_associations('foo.bar')
+      nodes        = associations.keys
+      values       = associations.values
+
+      nodes.length.should  == 2
+      nodes[0].type.should == :root
+      nodes[1].type.should == :send
+
+      values[1].type.should == :unknown
+    end
+
+    example 'should not add associations for stacked methods with arguments' do
+      associations = build_associations('foo.bar(:baz)')
+      nodes        = associations.keys
+      values       = associations.values
+
+      nodes.length.should  == 2
+      nodes[0].type.should == :root
+      nodes[1].type.should == :send
+
+      values[1].type.should == :unknown
+    end
+  end
+end

data/spec/ruby-lint/virtual_machine/{autoloading.rb → autoloading_spec.rb}

@@ -1,21 +1,21 @@
-require File.expand_path('../../../helper', __FILE__)
+require 'spec_helper'
 
 describe RubyLint::VirtualMachine do
   after do
-    RubyLint::VirtualMachine.global_scope.definitions[:const].delete('ERB')
+    RubyLint::GlobalScope.definitions.definitions[:const].delete('ERB')
   end
 
-  should 'automatically load constants' do
+  example 'automatically load constants' do
     definitions = build_definitions('ERB')
 
     definitions.lookup(:const, 'ERB').is_a?(ruby_object).should == true
 
-    RubyLint::VirtualMachine.global_scope.lookup(:const, 'ERB') \
+    RubyLint::GlobalScope.definitions.lookup(:const, 'ERB') \
       .is_a?(ruby_object) \
       .should == true
   end
 
-  should 'automatically load constant paths' do
+  example 'automatically load constant paths' do
     definitions = build_definitions('Enumerable::Enumerator')
 
     definitions.lookup(:const, 'Enumerable') \
@@ -23,7 +23,7 @@ describe RubyLint::VirtualMachine do
       .is_a?(ruby_object) \
       .should == true
 
-    RubyLint::VirtualMachine.global_scope.lookup(:const, 'Enumerable') \
+    RubyLint::GlobalScope.definitions.lookup(:const, 'Enumerable') \
       .lookup(:const, 'Enumerator') \
       .is_a?(ruby_object) \
       .should == true

data/spec/ruby-lint/virtual_machine/{blocks.rb → blocks_spec.rb}

@@ -1,7 +1,7 @@
-require File.expand_path('../../../helper', __FILE__)
+require 'spec_helper'
 
 describe RubyLint::VirtualMachine do
-  should 'make variables available in a block' do
+  example 'make variables available in a block' do
     code = <<-CODE
 number = 10
 
@@ -17,7 +17,7 @@ end
     number.value.value.should        == 10
   end
 
-  should 'make block arguments available as variables inside the block only' do
+  example 'make block arguments available as variables inside the block only' do
     code = <<-CODE
 example do
   number = 10
@@ -33,7 +33,33 @@ end
     block_def.lookup(:lvar, 'number').value.value.should == 10
   end
 
-  should 'update outer variables modified in the block' do
+  example 'blocks should be instances by default' do
+    code = <<-CODE
+example do
+end
+    CODE
+
+    block = build_associations(code).to_a.last.last
+
+    block.type.should          == :block
+    block.instance_type.should == :instance
+  end
+
+  example 'blocks should inherit the instance type from the outer scope' do
+    code = <<-CODE
+class A
+  example do
+  end
+end
+    CODE
+
+    block = build_associations(code).to_a.last.last
+
+    block.type.should          == :block
+    block.instance_type.should == :class
+  end
+
+  example 'update outer variables modified in the block' do
     code = <<-CODE
 number   = 10
 @number  = 10

data/spec/ruby-lint/virtual_machine/classes/{class_methods.rb → class_methods_spec.rb}

@@ -1,8 +1,8 @@
-require File.expand_path('../../../../helper', __FILE__)
+require 'spec_helper'
 
 describe RubyLint::VirtualMachine do
   describe 'defining class methods' do
-    should 'define a single class method using `self`' do
+    example 'define a single class method using `self`' do
       code = <<-CODE
 class Example
   def self.class_method
@@ -18,4 +18,4 @@ end
         .should == true
     end
   end
-end
+end

data/spec/ruby-lint/virtual_machine/classes/{extending.rb → extending_spec.rb}

@@ -1,8 +1,8 @@
-require File.expand_path('../../../../helper', __FILE__)
+require 'spec_helper'
 
 describe RubyLint::VirtualMachine do
   describe 'extending classes' do
-    should 'set the default parent class' do
+    example 'set the default parent class' do
       defs = build_definitions('class First; end')
 
       defs.lookup(:const, 'First') \
@@ -11,7 +11,7 @@ describe RubyLint::VirtualMachine do
         .should == true
     end
 
-    should 'extend a class using a parent' do
+    example 'extend a class using a parent' do
       code = <<-CODE
 class First
   def example
@@ -35,7 +35,7 @@ end
         .should == true
     end
 
-    should 'extend a class using a constant path as the parent class' do
+    example 'extend a class using a constant path as the parent class' do
       code = <<-CODE
 class First
   class Second
@@ -61,7 +61,7 @@ end
         .should == true
     end
 
-    should 'extend a class using a variable' do
+    example 'extend a class using a variable' do
       code = <<-CODE
 parent = String
 
@@ -77,22 +77,27 @@ end
       parents.include?(defs.lookup(:const, 'String')).should == true
     end
 
-    # Ruby only allows classes to inherit from constants.
-    should 'not be able to inherit non constant values' do
+    # This is to ensure that ruby-lint doesn't blow itself up when trying to
+    # use a constant as a parent class that can't be found (e.g. a user defined
+    # class).
+    #
+    # See https://github.com/YorickPeterse/ruby-lint/issues/32 for the
+    # motivation behind this fix/test.
+    example 'inherit Object as a fallback when the parent can not be found' do
       code = <<-CODE
-class MyString < 'foo'
-
+class Foo < Bar
 end
       CODE
 
-      error = should.raise?(TypeError) do
-        build_definitions(code)
-      end
+      defs    = build_definitions(code)
+      parents = defs.lookup(:const, 'Foo').parents
+
+      parents.length.should == 2
 
-      error.message.should == 'classes can only inherit another class'
+      parents.include?(defs.lookup(:const, 'Object')).should == true
     end
 
-    should 'inherit from Object when importing String' do
+    example 'inherit from Object when importing String' do
       defs = build_definitions('String')
 
       defs.lookup(:const, 'String') \
@@ -101,4 +106,4 @@ end
         .should == true
     end
   end
-end
+end

data/spec/ruby-lint/virtual_machine/classes/{redefining.rb → redefining_spec.rb}

@@ -1,8 +1,8 @@
-require File.expand_path('../../../../helper', __FILE__)
+require 'spec_helper'
 
 describe RubyLint::VirtualMachine do
   describe 'redefining classes' do
-    should 'update a class when it is redefined' do
+    example 'update a class when it is redefined' do
       code = <<-CODE
 class First
 end
@@ -21,4 +21,4 @@ end
         .should == true
     end
   end
-end
+end