ruby-lint 0.0.4 → 0.0.5

data/spec/ruby-lint/{nested_stack.rb → nested_stack_spec.rb}

@@ -1,11 +1,11 @@
-require File.expand_path('../../helper', __FILE__)
+require 'spec_helper'
 
 describe RubyLint::NestedStack do
   before do
     @stack = RubyLint::NestedStack.new
   end
 
-  should 'add a new stack' do
+  example 'add a new stack' do
     @stack.empty?.should == true
 
     @stack.add_stack
@@ -13,11 +13,11 @@ describe RubyLint::NestedStack do
     @stack.empty?.should == false
   end
 
-  should 'push and pop values from the stack' do
+  example 'push and pop values from the stack' do
     @stack.add_stack
     @stack.push(10)
 
     @stack.pop.should    == [10]
     @stack.empty?.should == true
   end
-end
+end

data/spec/ruby-lint/parser_spec.rb

@@ -0,0 +1,31 @@
+require 'spec_helper'
+
+describe RubyLint::Parser do
+  example 'parse a block of Ruby code' do
+    ast = parse('10', false)
+
+    ast.type.should            == :root
+    ast.children.length.should == 1
+  end
+
+  example 'use a custom node class' do
+    parse('10').class.should == RubyLint::AST::Node
+  end
+
+  example 'parse and return the comments mapping' do
+    code = <<-CODE
+# Hello world
+def foobar
+end
+    CODE
+
+    ast, comments = parse_with_comments(code)
+    def_node      = ast.children[0]
+    comment       = comments[def_node][0]
+
+    comment.is_a?(Parser::Source::Comment).should == true
+
+    comment.text.should          == '# Hello world'
+    comment.location.line.should == 1
+  end
+end

data/spec/ruby-lint/presenter/json_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+require 'json'
+
+describe RubyLint::Presenter::JSON do
+  example 'format a set of entries' do
+    report    = RubyLint::Report.new
+    presenter = RubyLint::Presenter::JSON.new
+
+    report.add(
+      :level   => :error,
+      :message => 'error message',
+      :line    => 1,
+      :column  => 1,
+      :file    => 'a.rb'
+    )
+
+    report.add(
+      :level   => :error,
+      :message => 'error message 2',
+      :line    => 2,
+      :column  => 1,
+      :file    => 'a.rb'
+    )
+
+    report.add(
+      :level   => :warning,
+      :message => 'warning message',
+      :line    => 1,
+      :column  => 1,
+      :file    => 'b.rb'
+    )
+
+    report.add(
+      :level   => :info,
+      :message => 'info message',
+      :line    => 1,
+      :column  => 1,
+      :file    => 'c.rb'
+    )
+
+    output  = presenter.present(report)
+    decoded = JSON(output)
+
+    decoded.length.should == 4
+
+    decoded[0]['file'].should  == 'a.rb'
+    decoded[0]['level'].should == 'error'
+
+    decoded[1]['file'].should  == 'a.rb'
+    decoded[1]['level'].should == 'error'
+
+    decoded[2]['file'].should  == 'b.rb'
+    decoded[2]['level'].should == 'warning'
+
+    decoded[3]['file'].should  == 'c.rb'
+    decoded[3]['level'].should == 'info'
+  end
+end

data/spec/ruby-lint/presenter/text_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe RubyLint::Presenter::Text do
+  example 'format a set of entries' do
+    report    = RubyLint::Report.new
+    presenter = RubyLint::Presenter::Text.new
+
+    report.add(
+      :level   => :error,
+      :message => 'error message',
+      :line    => 1,
+      :column  => 1,
+      :file    => '/foo/a.rb'
+    )
+
+    report.add(
+      :level   => :error,
+      :message => 'error message 2',
+      :line    => 2,
+      :column  => 1,
+      :file    => '/foo/a.rb'
+    )
+
+    report.add(
+      :level   => :warning,
+      :message => 'warning message',
+      :line    => 1,
+      :column  => 1,
+      :file    => '/foo/b.rb'
+    )
+
+    report.add(
+      :level   => :info,
+      :message => 'info message',
+      :line    => 1,
+      :column  => 1,
+      :file    => '/foo/c.rb'
+    )
+
+    output = presenter.present(report)
+
+    output.should == <<-EOF.strip
+a.rb: error: line 1, column 1: error message
+a.rb: error: line 2, column 1: error message 2
+b.rb: warning: line 1, column 1: warning message
+c.rb: info: line 1, column 1: info message
+    EOF
+  end
+end

data/spec/ruby-lint/report/entry_spec.rb

@@ -0,0 +1,58 @@
+require 'spec_helper'
+
+describe RubyLint::Report::Entry do
+  example 'sort a list of entries' do
+    entries = [
+      RubyLint::Report::Entry.new(
+        :level   => :info,
+        :message => 'info',
+        :line    => 2,
+        :column  => 1,
+        :file    => 'a.rb'
+      ),
+      RubyLint::Report::Entry.new(
+        :level   => :error,
+        :message => 'error',
+        :line    => 1,
+        :column  => 1,
+        :file    => 'a.rb'
+      ),
+      RubyLint::Report::Entry.new(
+        :level   => :warning,
+        :message => 'warning',
+        :line    => 3,
+        :column  => 1,
+        :file    => 'a.rb'
+      ),
+      RubyLint::Report::Entry.new(
+        :level   => :warning,
+        :message => 'warning',
+        :line    => 1,
+        :column  => 1,
+        :file    => 'b.rb'
+      ),
+      RubyLint::Report::Entry.new(
+        :level   => :error,
+        :message => 'error',
+        :line    => 1,
+        :column  => 1,
+        :file    => 'c.rb'
+      ),
+    ].sort
+
+    entries[0].file.should  == 'a.rb'
+    entries[0].level.should == :error
+
+    entries[1].file.should  == 'a.rb'
+    entries[1].level.should == :info
+
+    entries[2].file.should  == 'a.rb'
+    entries[2].level.should == :warning
+
+    entries[3].file.should  == 'b.rb'
+    entries[3].level.should == :warning
+
+    entries[4].file.should  == 'c.rb'
+    entries[4].level.should == :error
+  end
+end

data/spec/ruby-lint/report_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+
+describe 'RubyLint::Report' do
+  example 'add a message using #add' do
+    report = RubyLint::Report.new
+
+    report.add(
+      :level   => :info,
+      :message => 'info message',
+      :line    => 1,
+      :column  => 1,
+      :file    => 'file.rb'
+    )
+
+    report.entries.length.should == 1
+
+    entry = report.entries[0]
+
+    entry.level.should   == :info
+    entry.message.should == 'info message'
+    entry.line.should    == 1
+    entry.column.should  == 1
+    entry.file.should    == 'file.rb'
+  end
+
+  example 'ignore invalid reporting levels' do
+    report = RubyLint::Report.new
+
+    report.add(
+      :level   => :test,
+      :message => 'invalid message',
+      :line    => 1,
+      :column  => 1,
+      :file    => 'file.rb'
+    )
+
+    report.entries.empty?.should == true
+  end
+end

data/spec/ruby-lint/runner_spec.rb

@@ -0,0 +1,52 @@
+require 'spec_helper'
+
+describe RubyLint::Runner do
+  before do
+    @configuration = RubyLint::Configuration.new
+  end
+
+  example 'run analysis on a single file' do
+    files  = [fixture_path('invalid.rb')]
+    runner = RubyLint::Runner.new(@configuration)
+    output = runner.analyze(files)
+
+    output.should =~ /undefined method foobar on an instance of String/
+  end
+
+  example 'run analysis on multiple files' do
+    files  = [fixture_path('invalid.rb'), fixture_path('invalid_2.rb')]
+    runner = RubyLint::Runner.new(@configuration)
+    output = runner.analyze(files)
+
+    output.should =~ /undefined method foobar on an instance of String/
+    output.should =~ /undefined method derp on an instance of String/
+  end
+
+  example 'add syntax errors to the report' do
+    files  = [fixture_path('syntax_error.rb')]
+    runner = RubyLint::Runner.new(@configuration)
+    output = runner.analyze(files)
+
+    output.should =~ /unexpected token \$end/
+  end
+
+  example 'add errors when using externally defined constants' do
+    files  = [fixture_path('uses_external_invalid.rb')]
+    dirs   = [fixture_path('file_scanner/rails')]
+    config = RubyLint::Configuration.new(:directories => dirs)
+    runner = RubyLint::Runner.new(config)
+    output = runner.analyze(files)
+
+    output.should =~ /undefined method foobar on an instance of User/
+  end
+
+  example 'associating nodes with external definitions' do
+    files  = [fixture_path('associating.rb')]
+    dirs   = [fixture_path('../../lib')]
+    config = RubyLint::Configuration.new(:directories => dirs)
+    runner = RubyLint::Runner.new(config)
+    output = runner.analyze(files)
+
+    output.empty?.should == true
+  end
+end

data/spec/ruby-lint/virtual_machine/alias_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+describe RubyLint::VirtualMachine do
+  describe 'alias' do
+    example 'alias methods' do
+      code = <<-CODE
+def bar
+end
+
+alias foo bar
+      CODE
+
+      defs = build_definitions(code)
+
+      defs.lookup(:instance_method, 'bar').is_a?(ruby_method).should == true
+      defs.lookup(:instance_method, 'foo').is_a?(ruby_method).should == true
+    end
+
+    example 'alias methods using symbols' do
+      code = <<-CODE
+def bar
+end
+
+alias :foo :bar
+      CODE
+
+      defs = build_definitions(code)
+
+      defs.lookup(:instance_method, 'bar').is_a?(ruby_method).should == true
+      defs.lookup(:instance_method, 'foo').is_a?(ruby_method).should == true
+    end
+
+    example 'alias methods using alias_method' do
+      code = <<-CODE
+def bar
+end
+
+alias_method :foo, :bar
+      CODE
+
+      defs = build_definitions(code)
+
+      defs.lookup(:instance_method, 'bar').is_a?(ruby_method).should == true
+      defs.lookup(:instance_method, 'foo').is_a?(ruby_method).should == true
+    end
+
+    example 'alias global variables' do
+      code = 'alias $ARGV $*'
+      defs = build_definitions(code)
+
+      defs.lookup(:gvar, '$*').is_a?(ruby_object).should    == true
+      defs.lookup(:gvar, '$ARGV').is_a?(ruby_object).should == true
+    end
+  end
+end

data/spec/ruby-lint/virtual_machine/assignments/{arrays.rb → arrays_spec.rb}

@@ -1,8 +1,8 @@
-require File.expand_path('../../../../helper', __FILE__)
+require 'spec_helper'
 
 describe RubyLint::VirtualMachine do
   describe 'array assignments' do
-    should 'assign an empty array' do
+    example 'assign an empty array' do
       defs  = build_definitions('numbers = []')
       value = defs.lookup(:lvar, 'numbers').value
 
@@ -12,7 +12,7 @@ describe RubyLint::VirtualMachine do
       value.has_definition?(:instance_method, 'each').should == true
     end
 
-    should 'assign an array with values' do
+    example 'assign an array with values' do
       defs    = build_definitions('numbers = [10, 20]')
       array   = defs.lookup(:lvar, 'numbers').value
       members = [10, 20]
@@ -27,7 +27,7 @@ describe RubyLint::VirtualMachine do
       end
     end
 
-    should 'process single index assignments' do
+    example 'process single index assignments' do
       code = <<-CODE
   numbers    = []
   numbers[0] = 10
@@ -50,7 +50,7 @@ describe RubyLint::VirtualMachine do
       first.value.value.should              == 10
     end
 
-    should 'process multiple index assignments' do
+    example 'process multiple index assignments' do
       code = <<-CODE
 numbers        = []
 numbers[0,1]   = 10
@@ -70,7 +70,7 @@ numbers[4,5,6] = 40, 50
       numbers.lookup(:member, '6').value.should       == nil
     end
 
-    should 'process index assignments using variables' do
+    example 'process index assignments using variables' do
       code = <<-CODE
 index          = 1
 numbers        = [10]
@@ -84,4 +84,4 @@ numbers[index] = 20
       numbers.lookup(:member, '1').value.value.should == 20
     end
   end
-end
+end

data/spec/ruby-lint/virtual_machine/assignments/{hashes.rb → hashes_spec.rb}

@@ -1,8 +1,8 @@
-require File.expand_path('../../../../helper', __FILE__)
+require 'spec_helper'
 
 describe RubyLint::VirtualMachine do
   describe 'hash assignments' do
-    should 'assign an empty hash' do
+    example 'assign an empty hash' do
       defs  = build_definitions('numbers = {}')
       value = defs.lookup(:lvar, 'numbers').value
 
@@ -12,7 +12,7 @@ describe RubyLint::VirtualMachine do
       value.has_definition?(:instance_method, 'each').should == true
     end
 
-    should 'assign a hash with values' do
+    example 'assign a hash with values' do
       defs    = build_definitions('numbers = {:one => 1, :two => 2}')
       hash    = defs.lookup(:lvar, 'numbers').value
       members = {'one' => 1, 'two' => 2}
@@ -26,7 +26,7 @@ describe RubyLint::VirtualMachine do
       end
     end
 
-    should 'process single key assignments' do
+    example 'process single key assignments' do
       defs   = build_definitions('numbers = {}; numbers[:one] = 1')
       hash   = defs.lookup(:lvar, 'numbers').value
       member = hash.lookup(:member, 'one')
@@ -35,7 +35,7 @@ describe RubyLint::VirtualMachine do
       member.value.value.should == 1
     end
 
-    should 'process key assignments using variables' do
+    example 'process key assignments using variables' do
       code = <<-CODE
 key          = :two
 numbers      = {:one => 1}
@@ -49,4 +49,4 @@ numbers[key] = 2
       hash.lookup(:member, 'two').value.value.should == 2
     end
   end
-end
+end