ruby-lint 0.0.3 → 0.0.4

data/spec/ruby-lint/definition_builder/ruby_module.rb

@@ -0,0 +1,50 @@
+require File.expand_path('../../../helper', __FILE__)
+
+describe RubyLint::DefinitionBuilder::RubyModule do
+  describe 'building a simple module' do
+    before do
+      node     = s(:module, s(:const, nil, :A), s(:nil))
+      @root    = ruby_object.new(:name => 'root')
+      @builder = RubyLint::DefinitionBuilder::RubyModule.new(node, @root)
+    end
+
+    should 'return the name of the module' do
+      @builder.build.name.should == 'A'
+    end
+
+    should 'return the parent definitions' do
+      @builder.build.parents.should == [@root]
+    end
+
+    should 'return the reference amount' do
+      @builder.build.reference_amount.should == 1
+    end
+
+    should 'return the scope to define the module in' do
+      @builder.scope.should == @root
+    end
+  end
+
+  describe 'using constant paths' do
+    before do
+      node  = s(:module, s(:const, s(:const, nil, :A), :B), s(:nil))
+      @root = ruby_object.new(:name => 'root')
+
+      @root.define_constant('A')
+
+      @builder = RubyLint::DefinitionBuilder::RubyModule.new(node, @root)
+    end
+
+    should 'return the name of the module' do
+      @builder.build.name.should == 'B'
+    end
+
+    should 'return the parent definitions' do
+      @builder.build.parents.should == [@root]
+    end
+
+    should 'return the scope to define the module in' do
+      @builder.scope.should == @root.lookup(:const, 'A')
+    end
+  end
+end

data/spec/ruby-lint/iterator.rb

@@ -1,10 +1,28 @@
 require File.expand_path('../../helper', __FILE__)
 
 describe 'RubyLint::Iterator' do
+  should 'call after_initialize if it is defined' do
+    iterator = Class.new(RubyLint::Iterator) do
+      attr_reader :number
+
+      def after_initialize
+        @number = 10
+      end
+    end
+
+    iterator.new.number.should == 10
+  end
+
   should 'iterate over a simple AST' do
     ast = parse('10; 20; 30', false)
 
     iterator = Class.new(RubyLint::Iterator) do
+      attr_reader :options
+
+      def after_initialize
+        @options = {:events => [], :numbers => []}
+      end
+
       def on_root(node)
         @options[:events] << :on_root
       end
@@ -13,17 +31,17 @@ describe 'RubyLint::Iterator' do
         @options[:events] << :after_root
       end
 
-      def on_integer(node)
-        unless @options[:events].include?(:on_integer)
-          @options[:events] << :on_integer
+      def on_int(node)
+        unless @options[:events].include?(:on_int)
+          @options[:events] << :on_int
         end
 
         @options[:numbers] << node.children[0]
       end
 
-      def after_integer(node)
-        unless @options[:events].include?(:after_integer)
-          @options[:events] << :after_integer
+      def after_int(node)
+        unless @options[:events].include?(:after_int)
+          @options[:events] << :after_int
         end
       end
     end
@@ -32,11 +50,11 @@ describe 'RubyLint::Iterator' do
 
     iterator.iterate(ast)
 
-    iterator.options[:numbers].should == ['10', '20', '30']
+    iterator.options[:numbers].should == [10, 20, 30]
     iterator.options[:events].should  == [
       :on_root,
-      :on_integer,
-      :after_integer,
+      :on_int,
+      :after_int,
       :after_root
     ]
   end
@@ -53,16 +71,22 @@ end
     ast = parse(code, false)
 
     iterator = Class.new(RubyLint::Iterator) do
+      attr_reader :options
+
+      def after_initialize
+        @options = {}
+      end
+
       def on_class(node)
-        @options[:class] = node.children[0].children[0]
+        @options[:class] = node.children[0].children[1]
       end
 
-      def on_method_definition(node)
+      def on_def(node)
         @options[:method] = node.children[0]
       end
 
-      def on_method(node)
-        @options[:call] = node.children[0]
+      def on_send(node)
+        @options[:call] = node.children[1]
       end
     end
 
@@ -70,8 +94,8 @@ end
 
     iterator.iterate(ast)
 
-    iterator.options[:class].should  == 'Example'
-    iterator.options[:method].should == 'some_method'
-    iterator.options[:call].should   == 'puts'
+    iterator.options[:class].should  == :Example
+    iterator.options[:method].should == :some_method
+    iterator.options[:call].should   == :puts
   end
 end

data/spec/ruby-lint/nested_stack.rb

@@ -0,0 +1,23 @@
+require File.expand_path('../../helper', __FILE__)
+
+describe RubyLint::NestedStack do
+  before do
+    @stack = RubyLint::NestedStack.new
+  end
+
+  should 'add a new stack' do
+    @stack.empty?.should == true
+
+    @stack.add_stack
+
+    @stack.empty?.should == false
+  end
+
+  should 'push and pop values from the stack' do
+    @stack.add_stack
+    @stack.push(10)
+
+    @stack.pop.should    == [10]
+    @stack.empty?.should == true
+  end
+end

data/spec/ruby-lint/parser.rb

@@ -0,0 +1,14 @@
+require File.expand_path('../../helper', __FILE__)
+
+describe RubyLint::Parser do
+  should 'parse a block of Ruby code' do
+    ast = parse('10', false)
+
+    ast.type.should            == :root
+    ast.children.length.should == 1
+  end
+
+  should 'use a custom node class' do
+    parse('10').class.should == RubyLint::AST::Node
+  end
+end

data/spec/ruby-lint/report.rb

@@ -1,16 +1,6 @@
 require File.expand_path('../../helper', __FILE__)
 
 describe 'RubyLint::Report' do
-  should 'register a custom level' do
-    RubyLint::Report.add_level(:test)
-
-    RubyLint::Report.levels.include?(:test).should == true
-
-    RubyLint::Report.delete_level(:test)
-
-    RubyLint::Report.levels.include?(:test).should == false
-  end
-
   should 'add a message using #add' do
     report = RubyLint::Report.new
 

data/spec/ruby-lint/report/entry.rb

@@ -3,8 +3,9 @@ require File.expand_path('../../../helper', __FILE__)
 describe RubyLint::Report::Entry do
   should 'sort a list of entries' do
     entries = [
-      RubyLint::Report::Entry.new(:info, 'info', 1, 1, 'a.rb'),
+      RubyLint::Report::Entry.new(:info, 'info', 2, 1, 'a.rb'),
       RubyLint::Report::Entry.new(:error, 'error', 1, 1, 'a.rb'),
+      RubyLint::Report::Entry.new(:warning, 'warning', 3, 1, 'a.rb'),
       RubyLint::Report::Entry.new(:warning, 'warning', 1, 1, 'b.rb'),
       RubyLint::Report::Entry.new(:error, 'error', 1, 1, 'c.rb'),
     ].sort
@@ -15,10 +16,13 @@ describe RubyLint::Report::Entry do
     entries[1].file.should  == 'a.rb'
     entries[1].level.should == :info
 
-    entries[2].file.should  == 'b.rb'
+    entries[2].file.should  == 'a.rb'
     entries[2].level.should == :warning
 
-    entries[3].file.should  == 'c.rb'
-    entries[3].level.should == :error
+    entries[3].file.should  == 'b.rb'
+    entries[3].level.should == :warning
+
+    entries[4].file.should  == 'c.rb'
+    entries[4].level.should == :error
   end
 end

data/spec/ruby-lint/runner.rb

@@ -0,0 +1,32 @@
+require File.expand_path('../../helper', __FILE__)
+
+describe RubyLint::Runner do
+  before do
+    @configuration = RubyLint::Configuration.new
+  end
+
+  should 'run analysis on a single file' do
+    files  = [fixture_path('invalid.rb')]
+    runner = RubyLint::Runner.new(@configuration)
+    output = runner.analyze(files)
+
+    output.should =~ /undefined method foobar on an instance of String/
+  end
+
+  should 'run analysis on multiple files' do
+    files  = [fixture_path('invalid.rb'), fixture_path('invalid_2.rb')]
+    runner = RubyLint::Runner.new(@configuration)
+    output = runner.analyze(files)
+
+    output.should =~ /undefined method foobar on an instance of String/
+    output.should =~ /undefined method derp on an instance of String/
+  end
+
+  should 'add syntax errors to the report' do
+    files  = [fixture_path('syntax_error.rb')]
+    runner = RubyLint::Runner.new(@configuration)
+    output = runner.analyze(files)
+
+    output.should =~ /unexpected token \$end/
+  end
+end

data/spec/ruby-lint/virtual_machine/assignments/arrays.rb

@@ -0,0 +1,87 @@
+require File.expand_path('../../../../helper', __FILE__)
+
+describe RubyLint::VirtualMachine do
+  describe 'array assignments' do
+    should 'assign an empty array' do
+      defs  = build_definitions('numbers = []')
+      value = defs.lookup(:lvar, 'numbers').value
+
+      value.type.should      == :array
+      value.instance?.should == true
+
+      value.has_definition?(:instance_method, 'each').should == true
+    end
+
+    should 'assign an array with values' do
+      defs    = build_definitions('numbers = [10, 20]')
+      array   = defs.lookup(:lvar, 'numbers').value
+      members = [10, 20]
+
+      members.each_with_index do |value, index|
+        index  = index.to_s
+        member = array.lookup(:member, index)
+
+        member.name.should        == index
+        member.value.type.should  == :int
+        member.value.value.should == value
+      end
+    end
+
+    should 'process single index assignments' do
+      code = <<-CODE
+  numbers    = []
+  numbers[0] = 10
+      CODE
+
+      defs    = build_definitions(code)
+      numbers = defs.lookup(:lvar, 'numbers')
+
+      numbers.is_a?(ruby_object).should       == true
+      numbers.value.is_a?(ruby_object).should == true
+      numbers.value.type.should               == :array
+
+      first = numbers.value.lookup(:member, '0')
+
+      first.type.should == :member
+      first.name.should == '0'
+
+      first.value.is_a?(ruby_object).should == true
+      first.value.type.should               == :int
+      first.value.value.should              == 10
+    end
+
+    should 'process multiple index assignments' do
+      code = <<-CODE
+numbers        = []
+numbers[0,1]   = 10
+numbers[2,3]   = 20, 30
+numbers[4,5,6] = 40, 50
+      CODE
+
+      defs    = build_definitions(code)
+      numbers = defs.lookup(:lvar, 'numbers').value
+
+      numbers.lookup(:member, '0').value.value.should == 10
+      numbers.lookup(:member, '1').value.should       == nil
+      numbers.lookup(:member, '2').value.value.should == 20
+      numbers.lookup(:member, '3').value.value.should == 30
+      numbers.lookup(:member, '4').value.value.should == 40
+      numbers.lookup(:member, '5').value.value.should == 50
+      numbers.lookup(:member, '6').value.should       == nil
+    end
+
+    should 'process index assignments using variables' do
+      code = <<-CODE
+index          = 1
+numbers        = [10]
+numbers[index] = 20
+      CODE
+
+      defs    = build_definitions(code)
+      numbers = defs.lookup(:lvar, 'numbers').value
+
+      numbers.lookup(:member, '0').value.value.should == 10
+      numbers.lookup(:member, '1').value.value.should == 20
+    end
+  end
+end

data/spec/ruby-lint/virtual_machine/assignments/hashes.rb

@@ -0,0 +1,52 @@
+require File.expand_path('../../../../helper', __FILE__)
+
+describe RubyLint::VirtualMachine do
+  describe 'hash assignments' do
+    should 'assign an empty hash' do
+      defs  = build_definitions('numbers = {}')
+      value = defs.lookup(:lvar, 'numbers').value
+
+      value.type.should      == :hash
+      value.instance?.should == true
+
+      value.has_definition?(:instance_method, 'each').should == true
+    end
+
+    should 'assign a hash with values' do
+      defs    = build_definitions('numbers = {:one => 1, :two => 2}')
+      hash    = defs.lookup(:lvar, 'numbers').value
+      members = {'one' => 1, 'two' => 2}
+
+      members.each do |name, value|
+        member = hash.lookup(:member, name)
+
+        member.name.should        == name
+        member.value.type.should  == :int
+        member.value.value.should == value
+      end
+    end
+
+    should 'process single key assignments' do
+      defs   = build_definitions('numbers = {}; numbers[:one] = 1')
+      hash   = defs.lookup(:lvar, 'numbers').value
+      member = hash.lookup(:member, 'one')
+
+      member.value.type.should  == :int
+      member.value.value.should == 1
+    end
+
+    should 'process key assignments using variables' do
+      code = <<-CODE
+key          = :two
+numbers      = {:one => 1}
+numbers[key] = 2
+      CODE
+
+      defs = build_definitions(code)
+      hash = defs.lookup(:lvar, 'numbers').value
+
+      hash.lookup(:member, 'one').value.value.should == 1
+      hash.lookup(:member, 'two').value.value.should == 2
+    end
+  end
+end

data/spec/ruby-lint/virtual_machine/assignments/optional.rb

@@ -0,0 +1,41 @@
+require File.expand_path('../../../../helper', __FILE__)
+
+describe 'Building variable definitions' do
+  describe 'OR assignments' do
+    should 'assign a non existing local variable' do
+      defs = build_definitions('number ||= 10')
+
+      defs.lookup(:lvar, 'number').value.value.should == 10
+    end
+
+    should 'not overwrite an existing variable' do
+      code = <<-CODE
+number   = 10
+number ||= 20
+      CODE
+
+      defs = build_definitions(code)
+
+      defs.lookup(:lvar, 'number').value.value.should == 10
+    end
+  end
+
+  describe 'AND assignments' do
+    should 'not assign a non existing local variable' do
+      defs = build_definitions('number &&= 10')
+
+      defs.lookup(:lvar, 'number').nil?.should == true
+    end
+
+    should 'overwrite an existing variable' do
+      code = <<-CODE
+number   = 10
+number &&= 20
+      CODE
+
+      defs = build_definitions(code)
+
+      defs.lookup(:lvar, 'number').value.value.should == 20
+    end
+  end
+end