ruby-lint 0.0.3 → 0.0.4

data/spec/fixtures/config.yml

@@ -0,0 +1,8 @@
+---
+report_levels:
+  - info
+
+analysis_classes:
+  - undefined_methods
+
+presenter: json

data/spec/fixtures/invalid.rb

@@ -0,0 +1,3 @@
+name = 'Ruby'
+
+name.foobar

data/spec/fixtures/invalid_2.rb

@@ -0,0 +1,3 @@
+name = 'Ruby'
+
+name.derp

data/spec/fixtures/syntax_error.rb

@@ -0,0 +1 @@
+module Foo

data/spec/fixtures/valid.rb

@@ -0,0 +1,3 @@
+name = 'Ruby'
+
+name.upcase

data/spec/helper.rb

@@ -1,14 +1,20 @@
 require 'bacon'
 require 'bacon/colored_output'
+require 'stringio'
 require_relative 'support/bacon'
 
 if ENV['COVERAGE']
   require_relative 'support/simplecov'
 end
 
+if ENV['COVERALLS']
+  require_relative 'support/coveralls'
+end
+
 require_relative '../lib/ruby-lint'
 require_relative 'support/building'
 require_relative 'support/parsing'
 require_relative 'support/definitions'
+require_relative 'support/fixtures'
 
 Bacon.summary_on_exit

data/spec/ruby-lint/{analyze → analysis}/argument_amount.rb

@@ -1,6 +1,6 @@
 require File.expand_path('../../../helper', __FILE__)
 
-describe RubyLint::Analyze::ArgumentAmount do
+describe RubyLint::Analysis::ArgumentAmount do
   should 'validate the amount of required arguments' do
     code = <<-CODE
 def example(first, second)
@@ -9,7 +9,7 @@ end
 example
     CODE
 
-    report = build_report(code, RubyLint::Analyze::ArgumentAmount)
+    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
     entry  = report.entries[0]
 
     entry.is_a?(RubyLint::Report::Entry).should == true
@@ -27,7 +27,7 @@ end
 example
     CODE
 
-    report = build_report(code, RubyLint::Analyze::ArgumentAmount)
+    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
     entry  = report.entries[0]
 
     entry.is_a?(RubyLint::Report::Entry).should == true
@@ -46,7 +46,7 @@ end
 example
     CODE
 
-    report = build_report(code, RubyLint::Analyze::ArgumentAmount)
+    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
     entry  = report.entries[0]
 
     entry.is_a?(RubyLint::Report::Entry).should == true
@@ -65,7 +65,7 @@ end
 example(10, 20, 30)
     CODE
 
-    report = build_report(code, RubyLint::Analyze::ArgumentAmount)
+    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
 
     report.entries.length.should == 0
   end
@@ -77,14 +77,14 @@ name = 'Ruby'
 name.downcase
     CODE
 
-    report = build_report(code, RubyLint::Analyze::ArgumentAmount)
+    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
 
     report.entries.empty?.should == true
   end
 
   should 'not validate methods called on undefined receivers' do
     code   = 'A.example_method'
-    report = build_report(code, RubyLint::Analyze::ArgumentAmount)
+    report = build_report(code, RubyLint::Analysis::ArgumentAmount)
 
     report.entries.empty?.should == true
   end

data/spec/ruby-lint/analysis/confusing_variables.rb

@@ -0,0 +1,46 @@
+require File.expand_path('../../../helper', __FILE__)
+
+describe RubyLint::Analysis::ConfusingVariables do
+  should 'warn when assigning a variable with the same name as a method' do
+    code = <<-CODE
+def number
+end
+
+number = 10
+    CODE
+
+    report = build_report(code, RubyLint::Analysis::ConfusingVariables)
+    entry  = report.entries[0]
+
+    entry.line.should    == 4
+    entry.column.should  == 0
+    entry.message.should =~ /variable assignment using the same name/
+  end
+
+  should 'not warn when the variable is assigned inside the method itself' do
+    code = <<-CODE
+def number
+  number = 10
+end
+    CODE
+
+    report = build_report(code, RubyLint::Analysis::ConfusingVariables)
+
+    report.entries.empty?.should == true
+  end
+
+  should 'not warn when the method is defined in a different scope' do
+    code = <<-CODE
+module Foo
+  def number
+  end
+end
+
+number = 10
+    CODE
+
+    report = build_report(code, RubyLint::Analysis::ConfusingVariables)
+
+    report.entries.empty?.should == true
+  end
+end

data/spec/ruby-lint/analysis/pedantics.rb

@@ -0,0 +1,43 @@
+require File.expand_path('../../../helper', __FILE__)
+
+describe RubyLint::Analysis::Pedantics do
+  should 'warn when using do/then in various statements' do
+    code = <<-CODE
+if true then; end
+unless true then; end
+while true do; end
+    CODE
+
+    report  = build_report(code, RubyLint::Analysis::Pedantics)
+    entries = report.entries
+
+    entries.length.should == 3
+
+    entries[0].line.should    == 1
+    entries[0].message.should == 'the use of then/do is not needed here'
+
+    entries[1].line.should    == 2
+    entries[1].message.should == 'the use of then/do is not needed here'
+
+    entries[2].line.should    == 3
+    entries[2].message.should == 'the use of then/do is not needed here'
+  end
+
+  should 'warn for the use of BEGIN/END' do
+    code = <<-CODE
+BEGIN {}
+END {}
+    CODE
+
+    report  = build_report(code, RubyLint::Analysis::Pedantics)
+    entries = report.entries
+
+    entries.length.should == 2
+
+    entries[0].line.should    == 1
+    entries[0].message.should == 'BEGIN/END is useless'
+
+    entries[1].line.should    == 2
+    entries[1].message.should == 'BEGIN/END is useless'
+  end
+end

data/spec/ruby-lint/{analyze → analysis}/shadowing_variables.rb

@@ -1,6 +1,6 @@
 require File.expand_path('../../../helper', __FILE__)
 
-describe RubyLint::Analyze::ShadowingVariables do
+describe RubyLint::Analysis::ShadowingVariables do
   should 'warn for shadowing outer variables' do
     code = <<-CODE
 number = 10
@@ -10,7 +10,7 @@ number = 10
 end
     CODE
 
-    report = build_report(code, RubyLint::Analyze::ShadowingVariables)
+    report = build_report(code, RubyLint::Analysis::ShadowingVariables)
     entry  = report.entries[0]
 
     entry.is_a?(RubyLint::Report::Entry).should == true
@@ -31,7 +31,7 @@ def example
 end
     CODE
 
-    report = build_report(code, RubyLint::Analyze::ShadowingVariables)
+    report = build_report(code, RubyLint::Analysis::ShadowingVariables)
 
     report.entries.empty?.should == true
   end
@@ -47,7 +47,7 @@ def example; end
 end
     CODE
 
-    report = build_report(code, RubyLint::Analyze::ShadowingVariables)
+    report = build_report(code, RubyLint::Analysis::ShadowingVariables)
     entry  = report.entries[0]
 
     entry.is_a?(RubyLint::Report::Entry).should == true
@@ -70,7 +70,7 @@ A::B.example do |number|
 end
     CODE
 
-    report = build_report(code, RubyLint::Analyze::ShadowingVariables)
+    report = build_report(code, RubyLint::Analysis::ShadowingVariables)
 
     report.entries.length.should == 2
 

data/spec/ruby-lint/{analyze → analysis}/undefined_methods.rb

@@ -1,8 +1,8 @@
 require File.expand_path('../../../helper', __FILE__)
 
-describe RubyLint::Analyze::UndefinedMethods do
+describe RubyLint::Analysis::UndefinedMethods do
   should 'add an error for calling an undefined method' do
-    report = build_report('example_method', RubyLint::Analyze::UndefinedMethods)
+    report = build_report('example_method', RubyLint::Analysis::UndefinedMethods)
     entry  = report.entries[0]
 
     entry.is_a?(RubyLint::Report::Entry).should == true
@@ -22,25 +22,25 @@ end
 String.example_method
     CODE
 
-    report = build_report(code, RubyLint::Analyze::UndefinedMethods)
+    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
     entry  = report.entries[0]
 
     entry.is_a?(RubyLint::Report::Entry).should == true
 
     entry.line.should    == 6
-    entry.column.should  == 7
+    entry.column.should  == 0
     entry.message.should == 'undefined method example_method on String'
   end
 
   should 'add an error for calling an undefined method on a receiver instance' do
     code   = '"hello".example_method'
-    report = build_report(code, RubyLint::Analyze::UndefinedMethods)
+    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
     entry  = report.entries[0]
 
     entry.is_a?(RubyLint::Report::Entry).should == true
 
     entry.line.should    == 1
-    entry.column.should  == 8
+    entry.column.should  == 0
     entry.message.should == 'undefined method example_method ' \
       'on an instance of String'
   end
@@ -60,7 +60,7 @@ end
 name
     CODE
 
-    report = build_report(code, RubyLint::Analyze::UndefinedMethods)
+    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
 
     report.entries.length.should == 1
 
@@ -75,31 +75,31 @@ name
 
   describe 'core Ruby types' do
     should 'not add errors for calling defined methods on a Fixnum' do
-      report = build_report('10.to_s', RubyLint::Analyze::UndefinedMethods)
+      report = build_report('10.to_s', RubyLint::Analysis::UndefinedMethods)
 
       report.entries.empty?.should == true
     end
 
     should 'not add errors for calling defined methods on a Float' do
-      report = build_report('(10.0).to_s', RubyLint::Analyze::UndefinedMethods)
+      report = build_report('(10.0).to_s', RubyLint::Analysis::UndefinedMethods)
 
       report.entries.empty?.should == true
     end
 
     should 'not add errors for calling defined methods on a String' do
-      report = build_report('"10".to_s', RubyLint::Analyze::UndefinedMethods)
+      report = build_report('"10".to_s', RubyLint::Analysis::UndefinedMethods)
 
       report.entries.empty?.should == true
     end
 
     should 'not add errors for calling defined methods on a Hash' do
-      report = build_report('{}.to_s', RubyLint::Analyze::UndefinedMethods)
+      report = build_report('{}.to_s', RubyLint::Analysis::UndefinedMethods)
 
       report.entries.empty?.should == true
     end
 
     should 'not add errors for calling defined methods on an Array' do
-      report = build_report('[].to_s', RubyLint::Analyze::UndefinedMethods)
+      report = build_report('[].to_s', RubyLint::Analysis::UndefinedMethods)
 
       report.entries.empty?.should == true
     end
@@ -112,7 +112,7 @@ name
 end
     CODE
 
-    report = build_report(code, RubyLint::Analyze::UndefinedMethods)
+    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
 
     report.entries.empty?.should == true
   end
@@ -125,21 +125,21 @@ name.downcase
 name.downcasex
     CODE
 
-    report = build_report(code, RubyLint::Analyze::UndefinedMethods)
+    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
 
     report.entries.length.should == 1
 
     entry = report.entries[0]
 
     entry.line.should    == 4
-    entry.column.should  == 5
+    entry.column.should  == 0
     entry.message.should == 'undefined method downcasex on an instance of String'
   end
 
   should 'not add errors when calling a method on an undefined constant' do
     code = 'A.example_method'
 
-    report = build_report(code, RubyLint::Analyze::UndefinedMethods)
+    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
 
     report.entries.empty?.should == true
   end
@@ -151,7 +151,7 @@ def example(number)
 end
     CODE
 
-    report = build_report(code, RubyLint::Analyze::UndefinedMethods)
+    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
 
     report.entries.empty?.should == true
   end
@@ -163,7 +163,7 @@ number = 10
 first = second = number.foobar
     CODE
 
-    report = build_report(code, RubyLint::Analyze::UndefinedMethods)
+    report = build_report(code, RubyLint::Analysis::UndefinedMethods)
 
     report.entries.length.should == 1
 

data/spec/ruby-lint/{analyze → analysis}/undefined_variables.rb

@@ -1,8 +1,8 @@
 require File.expand_path('../../../helper', __FILE__)
 
-describe RubyLint::Analyze::UndefinedVariables do
+describe RubyLint::Analysis::UndefinedVariables do
   should 'add an error for using an undefined instance variable' do
-    report = build_report('@number', RubyLint::Analyze::UndefinedVariables)
+    report = build_report('@number', RubyLint::Analysis::UndefinedVariables)
     entry  = report.entries[0]
 
     entry.is_a?(RubyLint::Report::Entry).should == true
@@ -13,7 +13,7 @@ describe RubyLint::Analyze::UndefinedVariables do
   end
 
   should 'add an error for using an undefined class variable' do
-    report = build_report('@@number', RubyLint::Analyze::UndefinedVariables)
+    report = build_report('@@number', RubyLint::Analysis::UndefinedVariables)
     entry  = report.entries[0]
 
     entry.is_a?(RubyLint::Report::Entry).should == true
@@ -24,7 +24,7 @@ describe RubyLint::Analyze::UndefinedVariables do
   end
 
   should 'add an error for using an undefined global variable' do
-    report = build_report('$number', RubyLint::Analyze::UndefinedVariables)
+    report = build_report('$number', RubyLint::Analysis::UndefinedVariables)
     entry  = report.entries[0]
 
     entry.is_a?(RubyLint::Report::Entry).should == true
@@ -35,7 +35,7 @@ describe RubyLint::Analyze::UndefinedVariables do
   end
 
   should 'add an error for using an undefined constant' do
-    report = build_report('NUMBER', RubyLint::Analyze::UndefinedVariables)
+    report = build_report('NUMBER', RubyLint::Analysis::UndefinedVariables)
     entry  = report.entries[0]
 
     entry.is_a?(RubyLint::Report::Entry).should == true
@@ -45,9 +45,9 @@ describe RubyLint::Analyze::UndefinedVariables do
     entry.message.should == 'undefined constant NUMBER'
   end
 
-  should 'add an error for using an undefined constant in a constant path' do
+  should 'add an error for using an undefined constant path' do
     code = <<-CODE
-# This is to ensure that the on_constant() callback isn't used to check for "B"
+# This is to ensure that the on_const() callback isn't used to check for "B"
 # in the global scope.
 B = 10
 
@@ -57,27 +57,14 @@ end
 A::B
     CODE
 
-    report = build_report(code, RubyLint::Analyze::UndefinedVariables)
+    report = build_report(code, RubyLint::Analysis::UndefinedVariables)
     entry  = report.entries[0]
 
     entry.is_a?(RubyLint::Report::Entry).should == true
 
     entry.line.should    == 8
-    entry.column.should  == 3
-    entry.message.should == 'undefined constant B'
-  end
-
-  should 'add an error when the entire constant path does not exist' do
-    code   = 'A::B::C'
-    report = build_report(code, RubyLint::Analyze::UndefinedVariables)
-
-    report.entries.length.should == 1
-
-    entry = report.entries[0]
-
-    entry.line.should    == 1
     entry.column.should  == 0
-    entry.message.should == 'undefined constant A'
+    entry.message.should == 'undefined constant A::B'
   end
 
   should 'not depend on the order of variable definitions' do
@@ -93,14 +80,14 @@ class Person
 end
     CODE
 
-    report = build_report(code, RubyLint::Analyze::UndefinedVariables)
+    report = build_report(code, RubyLint::Analysis::UndefinedVariables)
 
     report.entries.empty?.should == true
   end
 
   should 'not add errors when autoloading constants' do
     code   = 'Encoding::BIG5'
-    report = build_report(code, RubyLint::Analyze::UndefinedVariables)
+    report = build_report(code, RubyLint::Analysis::UndefinedVariables)
 
     report.entries.empty?.should == true
   end
@@ -114,7 +101,14 @@ example_method do
 end
 CODE
 
-    report = build_report(code, RubyLint::Analyze::UndefinedVariables)
+    report = build_report(code, RubyLint::Analysis::UndefinedVariables)
+
+    report.entries.empty?.should == true
+  end
+
+  should 'not add errors for variable references in string interpolation' do
+    code   = 'number = 10; "#{number}"'
+    report = build_report(code, RubyLint::Analysis::UndefinedVariables)
 
     report.entries.empty?.should == true
   end