rubocop 1.88.2 → 1.90.0

data/lib/rubocop/cop/style/time_now.rb

@@ -0,0 +1,41 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Style
+      # Checks for `Time.new` without arguments, which is an implicit way
+      # to retrieve the current system time. Prefer the more explicit `Time.now`.
+      #
+      # @example
+      #   # bad
+      #   Time.new
+      #
+      #   # good
+      #   Time.now
+      #
+      #   # good - `Time.new` with arguments constructs a specific time
+      #   Time.new(2026, 8, 19)
+      #
+      class TimeNow < Base
+        extend AutoCorrector
+
+        MSG = 'Prefer `Time.now` over `Time.new` to retrieve the current time.'
+        RESTRICT_ON_SEND = %i[new].freeze
+
+        # @!method time_new?(node)
+        def_node_matcher :time_new?, <<~PATTERN
+          (call (const {nil? cbase} :Time) :new)
+        PATTERN
+
+        def on_send(node)
+          return unless time_new?(node)
+
+          add_offense(node) do |corrector|
+            corrector.replace(node.loc.selector.join(node.source_range.end), 'now')
+          end
+        end
+        alias on_csend on_send
+      end
+    end
+  end
+end

data/lib/rubocop/cop/style/yoda_condition.rb

@@ -122,7 +122,7 @@ module RuboCop
           node.comparison_method? && !noncommutative_operator?(node)
         end
 
-        # rubocop:disable Metrics/CyclomaticComplexity
+        # rubocop:disable-next Metrics/CyclomaticComplexity
         def valid_yoda?(node)
           return true unless (rhs = node.first_argument)
 
@@ -133,7 +133,6 @@ module RuboCop
 
           enforce_yoda? ? constant_portion?(lhs) : constant_portion?(rhs)
         end
-        # rubocop:enable Metrics/CyclomaticComplexity
 
         def message(node)
           format(MSG, source: node.source)

data/lib/rubocop/cop/style.rb

@@ -0,0 +1,312 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # Cops for the `Style` department. The department's cops are registered for lazy loading
+    # and their files are loaded on demand.
+    module Style
+      extend LazyLoader
+
+      register_cop :AccessModifierDeclarations, "#{__dir__}/style/access_modifier_declarations"
+      register_cop :AccessorGrouping, "#{__dir__}/style/accessor_grouping"
+      register_cop :Alias, "#{__dir__}/style/alias"
+      register_cop :AmbiguousEndlessMethodDefinition, "#{__dir__}/style/ambiguous_endless_method_definition"
+      register_cop :AndOr, "#{__dir__}/style/and_or"
+      register_cop :ArgumentsForwarding, "#{__dir__}/style/arguments_forwarding"
+      register_cop :ArrayCoercion, "#{__dir__}/style/array_coercion"
+      register_cop :ArrayFirstLast, "#{__dir__}/style/array_first_last"
+      register_cop :ArrayIntersect, "#{__dir__}/style/array_intersect"
+      register_cop :ArrayIntersectWithSingleElement, "#{__dir__}/style/array_intersect_with_single_element"
+      register_cop :ArrayJoin, "#{__dir__}/style/array_join"
+      register_cop :AsciiComments, "#{__dir__}/style/ascii_comments"
+      register_cop :Attr, "#{__dir__}/style/attr"
+      register_cop :AutoResourceCleanup, "#{__dir__}/style/auto_resource_cleanup"
+      register_cop :BarePercentLiterals, "#{__dir__}/style/bare_percent_literals"
+      register_cop :BeginBlock, "#{__dir__}/style/begin_block"
+      register_cop :BisectedAttrAccessor, "#{__dir__}/style/bisected_attr_accessor"
+      register_cop :BitwisePredicate, "#{__dir__}/style/bitwise_predicate"
+      register_cop :BlockComments, "#{__dir__}/style/block_comments"
+      register_cop :BlockDelimiters, "#{__dir__}/style/block_delimiters"
+      register_cop :CaseEquality, "#{__dir__}/style/case_equality"
+      register_cop :CaseLikeIf, "#{__dir__}/style/case_like_if"
+      register_cop :CharacterLiteral, "#{__dir__}/style/character_literal"
+      register_cop :ClassAndModuleChildren, "#{__dir__}/style/class_and_module_children"
+      register_cop :ClassCheck, "#{__dir__}/style/class_check"
+      register_cop :ClassEqualityComparison, "#{__dir__}/style/class_equality_comparison"
+      register_cop :ClassMethods, "#{__dir__}/style/class_methods"
+      register_cop :ClassMethodsDefinitions, "#{__dir__}/style/class_methods_definitions"
+      register_cop :ClassVars, "#{__dir__}/style/class_vars"
+      register_cop :CollectionCompact, "#{__dir__}/style/collection_compact"
+      register_cop :CollectionMethods, "#{__dir__}/style/collection_methods"
+      register_cop :CollectionQuerying, "#{__dir__}/style/collection_querying"
+      register_cop :ColonMethodCall, "#{__dir__}/style/colon_method_call"
+      register_cop :ColonMethodDefinition, "#{__dir__}/style/colon_method_definition"
+      register_cop :CombinableDefined, "#{__dir__}/style/combinable_defined"
+      register_cop :CombinableLoops, "#{__dir__}/style/combinable_loops"
+      register_cop :CommandLiteral, "#{__dir__}/style/command_literal"
+      register_cop :CommentAnnotation, "#{__dir__}/style/comment_annotation"
+      register_cop :CommentedKeyword, "#{__dir__}/style/commented_keyword"
+      register_cop :ComparableBetween, "#{__dir__}/style/comparable_between"
+      register_cop :ComparableClamp, "#{__dir__}/style/comparable_clamp"
+      register_cop :ConcatArrayLiterals, "#{__dir__}/style/concat_array_literals"
+      register_cop :ConditionalAssignment, "#{__dir__}/style/conditional_assignment"
+      register_cop :ConstantVisibility, "#{__dir__}/style/constant_visibility"
+      register_cop :Copyright, "#{__dir__}/style/copyright"
+      register_cop :DataInheritance, "#{__dir__}/style/data_inheritance"
+      register_cop :DateTime, "#{__dir__}/style/date_time"
+      register_cop :DefWithParentheses, "#{__dir__}/style/def_with_parentheses"
+      register_cop :DigChain, "#{__dir__}/style/dig_chain"
+      register_cop :Dir, "#{__dir__}/style/dir"
+      register_cop :DirEmpty, "#{__dir__}/style/dir_empty"
+      register_cop :DirectiveScope, "#{__dir__}/style/directive_scope"
+      register_cop :DisableCopsWithinSourceCodeDirective, "#{__dir__}/style/disable_cops_within_source_code_directive"
+      register_cop :DocumentationMethod, "#{__dir__}/style/documentation_method"
+      register_cop :Documentation, "#{__dir__}/style/documentation"
+      register_cop :DocumentDynamicEvalDefinition, "#{__dir__}/style/document_dynamic_eval_definition"
+      register_cop :DoubleCopDisableDirective, "#{__dir__}/style/double_cop_disable_directive"
+      register_cop :DoubleNegation, "#{__dir__}/style/double_negation"
+      register_cop :EachForSimpleLoop, "#{__dir__}/style/each_for_simple_loop"
+      register_cop :EachWithObject, "#{__dir__}/style/each_with_object"
+      register_cop :EmptyBlockParameter, "#{__dir__}/style/empty_block_parameter"
+      register_cop :EmptyCaseCondition, "#{__dir__}/style/empty_case_condition"
+      register_cop :EmptyClassDefinition, "#{__dir__}/style/empty_class_definition"
+      register_cop :EmptyElse, "#{__dir__}/style/empty_else"
+      register_cop :EmptyHeredoc, "#{__dir__}/style/empty_heredoc"
+      register_cop :EmptyLambdaParameter, "#{__dir__}/style/empty_lambda_parameter"
+      register_cop :EmptyLiteral, "#{__dir__}/style/empty_literal"
+      register_cop :EmptyMethod, "#{__dir__}/style/empty_method"
+      register_cop :EmptyStringInsideInterpolation, "#{__dir__}/style/empty_string_inside_interpolation"
+      register_cop :EndlessMethod, "#{__dir__}/style/endless_method"
+      register_cop :Encoding, "#{__dir__}/style/encoding"
+      register_cop :EndBlock, "#{__dir__}/style/end_block"
+      register_cop :EnvHome, "#{__dir__}/style/env_home"
+      register_cop :EvalWithLocation, "#{__dir__}/style/eval_with_location"
+      register_cop :EvenOdd, "#{__dir__}/style/even_odd"
+      register_cop :ExactRegexpMatch, "#{__dir__}/style/exact_regexp_match"
+      register_cop :ExpandPathArguments, "#{__dir__}/style/expand_path_arguments"
+      register_cop :ExplicitBlockArgument, "#{__dir__}/style/explicit_block_argument"
+      register_cop :ExponentialNotation, "#{__dir__}/style/exponential_notation"
+      register_cop :FetchEnvVar, "#{__dir__}/style/fetch_env_var"
+      register_cop :FileEmpty, "#{__dir__}/style/file_empty"
+      register_cop :FileNull, "#{__dir__}/style/file_null"
+      register_cop :FileOpen, "#{__dir__}/style/file_open"
+      register_cop :FileRead, "#{__dir__}/style/file_read"
+      register_cop :FileTouch, "#{__dir__}/style/file_touch"
+      register_cop :FileWrite, "#{__dir__}/style/file_write"
+      register_cop :FloatDivision, "#{__dir__}/style/float_division"
+      register_cop :For, "#{__dir__}/style/for"
+      register_cop :FormatString, "#{__dir__}/style/format_string"
+      register_cop :FormatStringToken, "#{__dir__}/style/format_string_token"
+      register_cop :FrozenStringLiteralComment, "#{__dir__}/style/frozen_string_literal_comment"
+      register_cop :GlobalStdStream, "#{__dir__}/style/global_std_stream"
+      register_cop :GlobalVars, "#{__dir__}/style/global_vars"
+      register_cop :GuardClause, "#{__dir__}/style/guard_clause"
+      register_cop :HashAsLastArrayItem, "#{__dir__}/style/hash_as_last_array_item"
+      register_cop :HashConversion, "#{__dir__}/style/hash_conversion"
+      register_cop :HashEachMethods, "#{__dir__}/style/hash_each_methods"
+      register_cop :HashExcept, "#{__dir__}/style/hash_except"
+      register_cop :HashFetchChain, "#{__dir__}/style/hash_fetch_chain"
+      register_cop :HashLikeCase, "#{__dir__}/style/hash_like_case"
+      register_cop :HashLookupMethod, "#{__dir__}/style/hash_lookup_method"
+      register_cop :HashSlice, "#{__dir__}/style/hash_slice"
+      register_cop :HashSyntax, "#{__dir__}/style/hash_syntax"
+      register_cop :HashTransformKeys, "#{__dir__}/style/hash_transform_keys"
+      register_cop :HashTransformValues, "#{__dir__}/style/hash_transform_values"
+      register_cop :IdenticalConditionalBranches, "#{__dir__}/style/identical_conditional_branches"
+      register_cop :IfInsideElse, "#{__dir__}/style/if_inside_else"
+      register_cop :IfUnlessModifier, "#{__dir__}/style/if_unless_modifier"
+      register_cop :IfUnlessModifierOfIfUnless, "#{__dir__}/style/if_unless_modifier_of_if_unless"
+      register_cop :IfWithBooleanLiteralBranches, "#{__dir__}/style/if_with_boolean_literal_branches"
+      register_cop :IfWithSemicolon, "#{__dir__}/style/if_with_semicolon"
+      register_cop :ImplicitRuntimeError, "#{__dir__}/style/implicit_runtime_error"
+      register_cop :InPatternThen, "#{__dir__}/style/in_pattern_then"
+      register_cop :InfiniteLoop, "#{__dir__}/style/infinite_loop"
+      register_cop :ReduceToHash, "#{__dir__}/style/reduce_to_hash"
+      register_cop :InverseMethods, "#{__dir__}/style/inverse_methods"
+      register_cop :InlineComment, "#{__dir__}/style/inline_comment"
+      register_cop :InvertibleUnlessCondition, "#{__dir__}/style/invertible_unless_condition"
+      register_cop :IpAddresses, "#{__dir__}/style/ip_addresses"
+      register_cop :ItAssignment, "#{__dir__}/style/it_assignment"
+      register_cop :ItBlockParameter, "#{__dir__}/style/it_block_parameter"
+      register_cop :KeywordArgumentsMerging, "#{__dir__}/style/keyword_arguments_merging"
+      register_cop :KeywordParametersOrder, "#{__dir__}/style/keyword_parameters_order"
+      register_cop :Lambda, "#{__dir__}/style/lambda"
+      register_cop :LambdaCall, "#{__dir__}/style/lambda_call"
+      register_cop :LineEndConcatenation, "#{__dir__}/style/line_end_concatenation"
+      register_cop :MagicCommentFormat, "#{__dir__}/style/magic_comment_format"
+      register_cop :MapIntoArray, "#{__dir__}/style/map_into_array"
+      register_cop :MapJoin, "#{__dir__}/style/map_join"
+      register_cop :MapToHash, "#{__dir__}/style/map_to_hash"
+      register_cop :MapToSet, "#{__dir__}/style/map_to_set"
+      register_cop :MethodCallWithoutArgsParentheses, "#{__dir__}/style/method_call_without_args_parentheses"
+      register_cop :MethodCallWithArgsParentheses, "#{__dir__}/style/method_call_with_args_parentheses"
+      register_cop :MinMaxComparison, "#{__dir__}/style/min_max_comparison"
+      register_cop :ModuleMemberExistenceCheck, "#{__dir__}/style/module_member_existence_check"
+      register_cop :MultilineInPatternThen, "#{__dir__}/style/multiline_in_pattern_then"
+      register_cop :NumberedParameters, "#{__dir__}/style/numbered_parameters"
+      register_cop :OneClassPerFile, "#{__dir__}/style/one_class_per_file"
+      register_cop :OpenStructUse, "#{__dir__}/style/open_struct_use"
+      register_cop :OperatorMethodCall, "#{__dir__}/style/operator_method_call"
+      register_cop :PartitionInsteadOfDoubleSelect, "#{__dir__}/style/partition_instead_of_double_select"
+      register_cop :RedundantArrayConstructor, "#{__dir__}/style/redundant_array_constructor"
+      register_cop :RedundantArrayFlatten, "#{__dir__}/style/redundant_array_flatten"
+      register_cop :RedundantAssignment, "#{__dir__}/style/redundant_assignment"
+      register_cop :RedundantConstantBase, "#{__dir__}/style/redundant_constant_base"
+      register_cop :RedundantCurrentDirectoryInPath, "#{__dir__}/style/redundant_current_directory_in_path"
+      register_cop :RedundantDoubleSplatHashBraces, "#{__dir__}/style/redundant_double_splat_hash_braces"
+      register_cop :RedundantEach, "#{__dir__}/style/redundant_each"
+      register_cop :RedundantFetchBlock, "#{__dir__}/style/redundant_fetch_block"
+      register_cop :RedundantFileExtensionInRequire, "#{__dir__}/style/redundant_file_extension_in_require"
+      register_cop :RedundantFilterChain, "#{__dir__}/style/redundant_filter_chain"
+      register_cop :RedundantFormat, "#{__dir__}/style/redundant_format"
+      register_cop :RedundantHeredocDelimiterQuotes, "#{__dir__}/style/redundant_heredoc_delimiter_quotes"
+      register_cop :RedundantInitialize, "#{__dir__}/style/redundant_initialize"
+      register_cop :RedundantInterpolationUnfreeze, "#{__dir__}/style/redundant_interpolation_unfreeze"
+      register_cop :RedundantLineContinuation, "#{__dir__}/style/redundant_line_continuation"
+      register_cop :RedundantMinMaxBy, "#{__dir__}/style/redundant_min_max_by"
+      register_cop :RedundantRegexpArgument, "#{__dir__}/style/redundant_regexp_argument"
+      register_cop :RedundantRegexpConstructor, "#{__dir__}/style/redundant_regexp_constructor"
+      register_cop :RedundantSelfAssignment, "#{__dir__}/style/redundant_self_assignment"
+      register_cop :RedundantSelfAssignmentBranch, "#{__dir__}/style/redundant_self_assignment_branch"
+      register_cop :RedundantStructKeywordInit, "#{__dir__}/style/redundant_struct_keyword_init"
+      register_cop :RequireOrder, "#{__dir__}/style/require_order"
+      register_cop :ReverseFind, "#{__dir__}/style/reverse_find"
+      register_cop :SafeNavigationChainLength, "#{__dir__}/style/safe_navigation_chain_length"
+      register_cop :SingleLineDoEndBlock, "#{__dir__}/style/single_line_do_end_block"
+      register_cop :SoleNestedConditional, "#{__dir__}/style/sole_nested_conditional"
+      register_cop :StaticClass, "#{__dir__}/style/static_class"
+      register_cop :MapCompactWithConditionalBlock, "#{__dir__}/style/map_compact_with_conditional_block"
+      register_cop :MethodCalledOnDoEndBlock, "#{__dir__}/style/method_called_on_do_end_block"
+      register_cop :MethodDefParentheses, "#{__dir__}/style/method_def_parentheses"
+      register_cop :MinMax, "#{__dir__}/style/min_max"
+      register_cop :MissingElse, "#{__dir__}/style/missing_else"
+      register_cop :MissingRespondToMissing, "#{__dir__}/style/missing_respond_to_missing"
+      register_cop :MixinGrouping, "#{__dir__}/style/mixin_grouping"
+      register_cop :MixinUsage, "#{__dir__}/style/mixin_usage"
+      register_cop :ModuleFunction, "#{__dir__}/style/module_function"
+      register_cop :MultilineBlockChain, "#{__dir__}/style/multiline_block_chain"
+      register_cop :MultilineIfThen, "#{__dir__}/style/multiline_if_then"
+      register_cop :MultilineIfModifier, "#{__dir__}/style/multiline_if_modifier"
+      register_cop :MultilineMethodSignature, "#{__dir__}/style/multiline_method_signature"
+      register_cop :MultilineMemoization, "#{__dir__}/style/multiline_memoization"
+      register_cop :MultilineTernaryOperator, "#{__dir__}/style/multiline_ternary_operator"
+      register_cop :MultilineWhenThen, "#{__dir__}/style/multiline_when_then"
+      register_cop :MultipleComparison, "#{__dir__}/style/multiple_comparison"
+      register_cop :MutableConstant, "#{__dir__}/style/mutable_constant"
+      register_cop :NegatedIf, "#{__dir__}/style/negated_if"
+      register_cop :NegatedIfElseCondition, "#{__dir__}/style/negated_if_else_condition"
+      register_cop :NegatedUnless, "#{__dir__}/style/negated_unless"
+      register_cop :NegatedWhile, "#{__dir__}/style/negated_while"
+      register_cop :NegativeArrayIndex, "#{__dir__}/style/negative_array_index"
+      register_cop :NestedFileDirname, "#{__dir__}/style/nested_file_dirname"
+      register_cop :NestedModifier, "#{__dir__}/style/nested_modifier"
+      register_cop :NestedParenthesizedCalls, "#{__dir__}/style/nested_parenthesized_calls"
+      register_cop :NestedTernaryOperator, "#{__dir__}/style/nested_ternary_operator"
+      register_cop :Next, "#{__dir__}/style/next"
+      register_cop :NilComparison, "#{__dir__}/style/nil_comparison"
+      register_cop :NilLambda, "#{__dir__}/style/nil_lambda"
+      register_cop :NonNilCheck, "#{__dir__}/style/non_nil_check"
+      register_cop :Not, "#{__dir__}/style/not"
+      register_cop :NumberedParametersLimit, "#{__dir__}/style/numbered_parameters_limit"
+      register_cop :NumericLiterals, "#{__dir__}/style/numeric_literals"
+      register_cop :NumericLiteralPrefix, "#{__dir__}/style/numeric_literal_prefix"
+      register_cop :NumericPredicate, "#{__dir__}/style/numeric_predicate"
+      register_cop :ObjectThen, "#{__dir__}/style/object_then"
+      register_cop :OneLineConditional, "#{__dir__}/style/one_line_conditional"
+      register_cop :OrAssignment, "#{__dir__}/style/or_assignment"
+      register_cop :OptionHash, "#{__dir__}/style/option_hash"
+      register_cop :OptionalArguments, "#{__dir__}/style/optional_arguments"
+      register_cop :OptionalBooleanParameter, "#{__dir__}/style/optional_boolean_parameter"
+      register_cop :ParallelAssignment, "#{__dir__}/style/parallel_assignment"
+      register_cop :ParenthesesAroundCondition, "#{__dir__}/style/parentheses_around_condition"
+      register_cop :PercentLiteralDelimiters, "#{__dir__}/style/percent_literal_delimiters"
+      register_cop :PercentQLiterals, "#{__dir__}/style/percent_q_literals"
+      register_cop :PerlBackrefs, "#{__dir__}/style/perl_backrefs"
+      register_cop :PredicateWithKind, "#{__dir__}/style/predicate_with_kind"
+      register_cop :PreferredHashMethods, "#{__dir__}/style/preferred_hash_methods"
+      register_cop :Proc, "#{__dir__}/style/proc"
+      register_cop :QuotedSymbols, "#{__dir__}/style/quoted_symbols"
+      register_cop :RaiseArgs, "#{__dir__}/style/raise_args"
+      register_cop :RandomWithOffset, "#{__dir__}/style/random_with_offset"
+      register_cop :RedundantArgument, "#{__dir__}/style/redundant_argument"
+      register_cop :RedundantBegin, "#{__dir__}/style/redundant_begin"
+      register_cop :RedundantCapitalW, "#{__dir__}/style/redundant_capital_w"
+      register_cop :RedundantCondition, "#{__dir__}/style/redundant_condition"
+      register_cop :RedundantConditional, "#{__dir__}/style/redundant_conditional"
+      register_cop :RedundantException, "#{__dir__}/style/redundant_exception"
+      register_cop :RedundantFreeze, "#{__dir__}/style/redundant_freeze"
+      register_cop :RedundantInterpolation, "#{__dir__}/style/redundant_interpolation"
+      register_cop :RedundantParentheses, "#{__dir__}/style/redundant_parentheses"
+      register_cop :RedundantPercentQ, "#{__dir__}/style/redundant_percent_q"
+      register_cop :RedundantRegexpCharacterClass, "#{__dir__}/style/redundant_regexp_character_class"
+      register_cop :RedundantRegexpEscape, "#{__dir__}/style/redundant_regexp_escape"
+      register_cop :RedundantReturn, "#{__dir__}/style/redundant_return"
+      register_cop :RedundantSelf, "#{__dir__}/style/redundant_self"
+      register_cop :RedundantSort, "#{__dir__}/style/redundant_sort"
+      register_cop :RedundantSortBy, "#{__dir__}/style/redundant_sort_by"
+      register_cop :RedundantStringEscape, "#{__dir__}/style/redundant_string_escape"
+      register_cop :RegexpLiteral, "#{__dir__}/style/regexp_literal"
+      register_cop :RescueModifier, "#{__dir__}/style/rescue_modifier"
+      register_cop :RescueStandardError, "#{__dir__}/style/rescue_standard_error"
+      register_cop :ReturnNil, "#{__dir__}/style/return_nil"
+      register_cop :ReturnNilInPredicateMethodDefinition, "#{__dir__}/style/return_nil_in_predicate_method_definition"
+      register_cop :SafeNavigation, "#{__dir__}/style/safe_navigation"
+      register_cop :Sample, "#{__dir__}/style/sample"
+      register_cop :SelectByKind, "#{__dir__}/style/select_by_kind"
+      register_cop :SelectByRange, "#{__dir__}/style/select_by_range"
+      register_cop :SelectByRegexp, "#{__dir__}/style/select_by_regexp"
+      register_cop :SelfAssignment, "#{__dir__}/style/self_assignment"
+      register_cop :Semicolon, "#{__dir__}/style/semicolon"
+      register_cop :Send, "#{__dir__}/style/send"
+      register_cop :SendWithLiteralMethodName, "#{__dir__}/style/send_with_literal_method_name"
+      register_cop :SignalException, "#{__dir__}/style/signal_exception"
+      register_cop :SingleArgumentDig, "#{__dir__}/style/single_argument_dig"
+      register_cop :SingleLineBlockParams, "#{__dir__}/style/single_line_block_params"
+      register_cop :SingleLineMethods, "#{__dir__}/style/single_line_methods"
+      register_cop :SlicingWithRange, "#{__dir__}/style/slicing_with_range"
+      register_cop :SpecialGlobalVars, "#{__dir__}/style/special_global_vars"
+      register_cop :StabbyLambdaParentheses, "#{__dir__}/style/stabby_lambda_parentheses"
+      register_cop :StderrPuts, "#{__dir__}/style/stderr_puts"
+      register_cop :StringChars, "#{__dir__}/style/string_chars"
+      register_cop :StringConcatenation, "#{__dir__}/style/string_concatenation"
+      register_cop :StringHashKeys, "#{__dir__}/style/string_hash_keys"
+      register_cop :StringLiterals, "#{__dir__}/style/string_literals"
+      register_cop :StringLiteralsInInterpolation, "#{__dir__}/style/string_literals_in_interpolation"
+      register_cop :StringMethods, "#{__dir__}/style/string_methods"
+      register_cop :Strip, "#{__dir__}/style/strip"
+      register_cop :StructInheritance, "#{__dir__}/style/struct_inheritance"
+      register_cop :SuperArguments, "#{__dir__}/style/super_arguments"
+      register_cop :SuperWithArgsParentheses, "#{__dir__}/style/super_with_args_parentheses"
+      register_cop :SwapValues, "#{__dir__}/style/swap_values"
+      register_cop :SymbolArray, "#{__dir__}/style/symbol_array"
+      register_cop :SymbolLiteral, "#{__dir__}/style/symbol_literal"
+      register_cop :SymbolProc, "#{__dir__}/style/symbol_proc"
+      register_cop :TallyMethod, "#{__dir__}/style/tally_method"
+      register_cop :TernaryParentheses, "#{__dir__}/style/ternary_parentheses"
+      register_cop :TimeNow, "#{__dir__}/style/time_now"
+      register_cop :TopLevelMethodDefinition, "#{__dir__}/style/top_level_method_definition"
+      register_cop :TrailingBodyOnClass, "#{__dir__}/style/trailing_body_on_class"
+      register_cop :TrailingBodyOnMethodDefinition, "#{__dir__}/style/trailing_body_on_method_definition"
+      register_cop :TrailingBodyOnModule, "#{__dir__}/style/trailing_body_on_module"
+      register_cop :TrailingCommaInArguments, "#{__dir__}/style/trailing_comma_in_arguments"
+      register_cop :TrailingCommaInArrayLiteral, "#{__dir__}/style/trailing_comma_in_array_literal"
+      register_cop :TrailingCommaInBlockArgs, "#{__dir__}/style/trailing_comma_in_block_args"
+      register_cop :TrailingCommaInHashLiteral, "#{__dir__}/style/trailing_comma_in_hash_literal"
+      register_cop :TrailingMethodEndStatement, "#{__dir__}/style/trailing_method_end_statement"
+      register_cop :TrailingUnderscoreVariable, "#{__dir__}/style/trailing_underscore_variable"
+      register_cop :TrivialAccessors, "#{__dir__}/style/trivial_accessors"
+      register_cop :UnlessElse, "#{__dir__}/style/unless_else"
+      register_cop :UnlessLogicalOperators, "#{__dir__}/style/unless_logical_operators"
+      register_cop :UnpackFirst, "#{__dir__}/style/unpack_first"
+      register_cop :VariableInterpolation, "#{__dir__}/style/variable_interpolation"
+      register_cop :WhenThen, "#{__dir__}/style/when_then"
+      register_cop :WhileUntilDo, "#{__dir__}/style/while_until_do"
+      register_cop :WhileUntilModifier, "#{__dir__}/style/while_until_modifier"
+      register_cop :WordArray, "#{__dir__}/style/word_array"
+      register_cop :YAMLFileRead, "#{__dir__}/style/yaml_file_read"
+      register_cop :YodaCondition, "#{__dir__}/style/yoda_condition"
+      register_cop :YodaExpression, "#{__dir__}/style/yoda_expression"
+      register_cop :ZeroLengthPredicate, "#{__dir__}/style/zero_length_predicate"
+    end
+  end
+end

data/lib/rubocop/cop/team.rb

@@ -9,7 +9,7 @@ module RuboCop
     # For performance reasons, Team will first dispatch cops & forces in two groups,
     # first the ones needed for autocorrection (if any), then the rest
     # (unless autocorrections happened).
-    # rubocop:disable Metrics/ClassLength
+    # rubocop:disable-next Metrics/ClassLength
     class Team
       InvestigationResult = Struct.new(:report, :corrector)
       private_constant :InvestigationResult
@@ -29,8 +29,17 @@ module RuboCop
 
       # @return [Team] with cops assembled from the given `cop_classes`
       def self.mobilize(cop_classes, config, options = {})
-        cops = mobilize_cops(cop_classes, config, options)
-        new(cops, config, options)
+        if cop_classes.is_a?(Registry)
+          # Instantiate only the enabled cops so that disabled lazy-loaded cops are not loaded.
+          # The registry is kept on standby to mobilize a disabled cop when a comment directive
+          # opts it back in.
+          cops = cop_classes.enabled(config).map { |cop_class| cop_class.new(config, options) }
+          team = new(cops, config, options)
+          team.standby_registry = cop_classes
+          team
+        else
+          new(mobilize_cops(cop_classes, config, options), config, options)
+        end
       end
 
       # @return [Array<Cop::Base>]
@@ -69,12 +78,20 @@ module RuboCop
       # @api private
       attr_reader :updated_source
 
+      # Registry used to mobilize cops that were not instantiated because they are disabled in
+      # the config, when a comment directive opts them back in for a file.
+      #
+      # @api private
+      attr_writer :standby_registry
+
       alias updated_source_file? updated_source_file
 
       def initialize(cops, config = nil, options = {})
         @cops = cops
         @config = config
         @options = options
+        @standby_registry = nil
+        @standby_cops = {}
         reset
         @ready = true
         @registry = Registry.new(cops, options.dup)
@@ -170,6 +187,7 @@ module RuboCop
 
         reset
         @cops.map!(&:ready)
+        @standby_cops.transform_values! { |cop| cop&.ready }
         @ready = true
       end
 
@@ -193,7 +211,7 @@ module RuboCop
         # run the other cops when no corrections are left
         on_duty = roundup_relevant_cops(processed_source)
 
-        autocorrect_cops, other_cops = on_duty.partition(&:autocorrect?)
+        autocorrect_cops, other_cops = partition_by_correcting(on_duty)
         report = investigate_partial(autocorrect_cops, processed_source,
                                      offset: offset, original: original)
 
@@ -233,8 +251,17 @@ module RuboCop
       end
 
       # @return [Array<cop>]
+      # A cop whose unsafe correction is skipped still inserts todo comments
+      # under `--disable-uncorrectable`, so it must run with the correcting
+      # cops - correctors of the later `other_cops` round are never applied.
+      def partition_by_correcting(cops)
+        cops.partition do |cop|
+          cop.autocorrect? || cop.skipped_unsafe_correction_with_disable_uncorrectable?
+        end
+      end
+
       def roundup_relevant_cops(processed_source)
-        cops.select do |cop|
+        (cops + opted_in_standby_cops(processed_source)).select do |cop|
           next false if cop.excluded_file?(processed_source.file_path)
           next true if processed_source.comment_config.cop_opted_in?(cop)
           next false unless @registry.enabled?(cop, @config)
@@ -243,6 +270,33 @@ module RuboCop
         end
       end
 
+      # Cops that were not mobilized because they are disabled in the config,
+      # but are opted back in for the given file by an `enable` comment directive.
+      # Their classes are loaded on demand.
+      #
+      # @return [Array<cop>]
+      def opted_in_standby_cops(processed_source)
+        return [] unless @standby_registry
+
+        opted_in_names = processed_source.comment_config.opt_in_cops
+        return [] if opted_in_names.empty?
+
+        @mobilized_cop_names ||= Set.new(cops.map(&:cop_name))
+        opted_in_names.filter_map do |cop_name|
+          next if @mobilized_cop_names.include?(cop_name)
+
+          standby_cop(cop_name)
+        end
+      end
+
+      def standby_cop(cop_name)
+        return @standby_cops[cop_name] if @standby_cops.key?(cop_name)
+
+        cop_class = @standby_registry.find_by_cop_name(cop_name)
+
+        @standby_cops[cop_name] = cop_class&.new(@config, @options)
+      end
+
       def support_target_ruby_version?(cop)
         return true unless cop.class.respond_to?(:support_target_ruby_version?)
 
@@ -350,6 +404,5 @@ module RuboCop
         end
       end
     end
-    # rubocop:enable Metrics/ClassLength
   end
 end

data/lib/rubocop/cop/util.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module Cop
     # This module contains a collection of useful utility methods.
-    # rubocop:disable Metrics/ModuleLength
+    # rubocop:disable-next Metrics/ModuleLength
     module Util
       include PathUtil
 
@@ -35,7 +35,7 @@ module RuboCop
         node.loc_is?(:end, ')')
       end
 
-      # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
+      # rubocop:disable-next Metrics/AbcSize, Metrics/MethodLength
       def add_parentheses(node, corrector)
         if node.args_type?
           arguments_range = node.source_range
@@ -55,7 +55,6 @@ module RuboCop
           corrector.insert_after(args_end(node), ')')
         end
       end
-      # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
 
       def any_descendant?(node, *types)
         if block_given?
@@ -210,6 +209,5 @@ module RuboCop
         source == target || (source.is_a?(Array) && source.include?(target))
       end
     end
-    # rubocop:enable Metrics/ModuleLength
   end
 end

data/lib/rubocop/cop/variable_force/variable.rb

@@ -47,7 +47,7 @@ module RuboCop
           !@references.empty?
         end
 
-        # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+        # rubocop:disable-next Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
         def reference!(node)
           reference = Reference.new(node, @scope)
           @references << reference
@@ -63,7 +63,7 @@ module RuboCop
             # if/unless keyword. A preceding assignment is needed to put the
             # variable in scope. For this reason we skip to the next assignment
             # here.
-            next if in_modifier_conditional?(assignment)
+            next if in_modifier_conditional?(assignment, node)
 
             break if !assignment.branch || assignment.branch == reference.branch
 
@@ -72,14 +72,25 @@ module RuboCop
             end
           end
         end
-        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
-        def in_modifier_conditional?(assignment)
-          parent = assignment.node.parent
-          parent = parent.parent if parent&.begin_type?
-          return false if parent.nil?
+        def in_modifier_conditional?(assignment, reference_node)
+          conditional = modifier_conditional_of(assignment.node)
+          return false unless conditional
 
-          parent.basic_conditional? && parent.modifier_form?
+          # The out-of-scope problem only affects a reference in the modifier body (to the
+          # left of the keyword); a reference after the modifier is put in scope by the
+          # condition's assignment, so an earlier assignment there is genuinely useless.
+          covers?(conditional, reference_node) && !covers?(conditional.condition, reference_node)
+        end
+
+        def modifier_conditional_of(node)
+          node.each_ancestor(:if, :while, :until).find do |conditional|
+            conditional.modifier_form? && covers?(conditional.condition, node)
+          end
+        end
+
+        def covers?(container, node)
+          container.equal?(node) || container.source_range.contains?(node.source_range)
         end
 
         def capture_with_block!

data/lib/rubocop/cops_documentation_generator.rb

@@ -6,7 +6,7 @@ require 'yard'
 # Class for generating documentation of all cops departments
 # @api private
 class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
-  include ::RuboCop::Cop::Documentation
+  include RuboCop::Cop::Documentation
 
   CopData = Struct.new(
     :cop, :description, :example_objects, :safety_objects, :see_objects, :config, keyword_init: true
@@ -137,7 +137,7 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
     "NOTE: Requires Ruby version #{requirement}\n\n"
   end
 
-  # rubocop:disable Metrics/MethodLength
+  # rubocop:disable-next Metrics/MethodLength
   def properties(cop)
     header = [
       'Enabled by default', 'Safe', 'Supports autocorrection', 'Version Added',
@@ -160,7 +160,6 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
     ]]
     "#{to_table(header, content)}\n"
   end
-  # rubocop:enable Metrics/MethodLength
 
   def cop_header(cop)
     content = +"\n"
@@ -217,7 +216,7 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
     "xref:#{filename}#allowmultilinefinalelement[AllowMultilineFinalElement]"
   end
 
-  # rubocop:disable Metrics/CyclomaticComplexity,Metrics/MethodLength
+  # rubocop:disable-next Metrics/CyclomaticComplexity,Metrics/MethodLength
   def configurable_values(cop_config, name)
     case name
     when /^Enforced/
@@ -244,7 +243,6 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
       end
     end
   end
-  # rubocop:enable Metrics/CyclomaticComplexity,Metrics/MethodLength
 
   def to_table(header, content)
     table = ['|===', "| #{header.join(' | ')}\n\n"].join("\n")
@@ -303,7 +301,7 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
     "\ninclude::../partials/#{filename}[]\n"
   end
 
-  # rubocop:disable Metrics/MethodLength
+  # rubocop:disable-next Metrics/MethodLength
   def print_cops_of_department(department)
     selected_cops = cops_of_department(department)
     content = +<<~HEADER
@@ -323,7 +321,6 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
       file.write("#{content.strip}\n")
     end
   end
-  # rubocop:enable Metrics/MethodLength
 
   def print_cop_with_doc(cop) # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
     cop_config = config.for_cop(cop)