rubocop 1.88.2 → 1.90.0

data/lib/rubocop/cop/lint.rb

@@ -0,0 +1,178 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # Cops for the `Lint` department. The department's cops are registered for lazy loading
+    # and their files are loaded on demand.
+    module Lint
+      extend LazyLoader
+
+      register_cop :AmbiguousAssignment, "#{__dir__}/lint/ambiguous_assignment"
+      register_cop :AmbiguousBlockAssociation, "#{__dir__}/lint/ambiguous_block_association"
+      register_cop :AmbiguousOperator, "#{__dir__}/lint/ambiguous_operator"
+      register_cop :AmbiguousOperatorPrecedence, "#{__dir__}/lint/ambiguous_operator_precedence"
+      register_cop :AmbiguousRange, "#{__dir__}/lint/ambiguous_range"
+      register_cop :AmbiguousRegexpLiteral, "#{__dir__}/lint/ambiguous_regexp_literal"
+      register_cop :ArgumentMismatch, "#{__dir__}/lint/argument_mismatch"
+      register_cop :ArrayLiteralInRegexp, "#{__dir__}/lint/array_literal_in_regexp"
+      register_cop :AssignmentInCondition, "#{__dir__}/lint/assignment_in_condition"
+      register_cop :BigDecimalNew, "#{__dir__}/lint/big_decimal_new"
+      register_cop :BinaryOperatorWithIdenticalOperands, "#{__dir__}/lint/binary_operator_with_identical_operands"
+      register_cop :BooleanSymbol, "#{__dir__}/lint/boolean_symbol"
+      register_cop :CircularArgumentReference, "#{__dir__}/lint/circular_argument_reference"
+      register_cop :ConstantDefinitionInBlock, "#{__dir__}/lint/constant_definition_in_block"
+      register_cop :ConstantOverwrittenInRescue, "#{__dir__}/lint/constant_overwritten_in_rescue"
+      register_cop :ConstantReassignment, "#{__dir__}/lint/constant_reassignment"
+      register_cop :ConstantResolution, "#{__dir__}/lint/constant_resolution"
+      register_cop :CopDirectiveSyntax, "#{__dir__}/lint/cop_directive_syntax"
+      register_cop :DataDefineOverride, "#{__dir__}/lint/data_define_override"
+      register_cop :Debugger, "#{__dir__}/lint/debugger"
+      register_cop :DeprecatedClassMethods, "#{__dir__}/lint/deprecated_class_methods"
+      register_cop :DeprecatedConstants, "#{__dir__}/lint/deprecated_constants"
+      register_cop :DeprecatedOpenSSLConstant, "#{__dir__}/lint/deprecated_open_ssl_constant"
+      register_cop :DeprecatedReference, "#{__dir__}/lint/deprecated_reference"
+      register_cop :DisjunctiveAssignmentInConstructor, "#{__dir__}/lint/disjunctive_assignment_in_constructor"
+      register_cop :DuplicateBranch, "#{__dir__}/lint/duplicate_branch"
+      register_cop :DuplicateCaseCondition, "#{__dir__}/lint/duplicate_case_condition"
+      register_cop :DuplicateElsifCondition, "#{__dir__}/lint/duplicate_elsif_condition"
+      register_cop :DuplicateHashKey, "#{__dir__}/lint/duplicate_hash_key"
+      register_cop :DuplicateMagicComment, "#{__dir__}/lint/duplicate_magic_comment"
+      register_cop :DuplicateMatchPattern, "#{__dir__}/lint/duplicate_match_pattern"
+      register_cop :DuplicateMethods, "#{__dir__}/lint/duplicate_methods"
+      register_cop :DuplicateRegexpCharacterClassElement, "#{__dir__}/lint/duplicate_regexp_character_class_element"
+      register_cop :DuplicateRequire, "#{__dir__}/lint/duplicate_require"
+      register_cop :DuplicateRescueException, "#{__dir__}/lint/duplicate_rescue_exception"
+      register_cop :DuplicateSetElement, "#{__dir__}/lint/duplicate_set_element"
+      register_cop :EachWithObjectArgument, "#{__dir__}/lint/each_with_object_argument"
+      register_cop :ElseLayout, "#{__dir__}/lint/else_layout"
+      register_cop :EmptyBlock, "#{__dir__}/lint/empty_block"
+      register_cop :EmptyClass, "#{__dir__}/lint/empty_class"
+      register_cop :EmptyConditionalBody, "#{__dir__}/lint/empty_conditional_body"
+      register_cop :EmptyEnsure, "#{__dir__}/lint/empty_ensure"
+      register_cop :EmptyExpression, "#{__dir__}/lint/empty_expression"
+      register_cop :EmptyFile, "#{__dir__}/lint/empty_file"
+      register_cop :EmptyInPattern, "#{__dir__}/lint/empty_in_pattern"
+      register_cop :EmptyInterpolation, "#{__dir__}/lint/empty_interpolation"
+      register_cop :EmptyWhen, "#{__dir__}/lint/empty_when"
+      register_cop :EnsureReturn, "#{__dir__}/lint/ensure_return"
+      register_cop :SharedMutableDefault, "#{__dir__}/lint/shared_mutable_default"
+      register_cop :ErbNewArguments, "#{__dir__}/lint/erb_new_arguments"
+      register_cop :FlipFlop, "#{__dir__}/lint/flip_flop"
+      register_cop :FloatComparison, "#{__dir__}/lint/float_comparison"
+      register_cop :FloatOutOfRange, "#{__dir__}/lint/float_out_of_range"
+      register_cop :FormatParameterMismatch, "#{__dir__}/lint/format_parameter_mismatch"
+      register_cop :HashCompareByIdentity, "#{__dir__}/lint/hash_compare_by_identity"
+      register_cop :HashNewWithKeywordArgumentsAsDefault, "#{__dir__}/lint/hash_new_with_keyword_arguments_as_default"
+      register_cop :HeredocMethodCallPosition, "#{__dir__}/lint/heredoc_method_call_position"
+      register_cop :IdentityComparison, "#{__dir__}/lint/identity_comparison"
+      register_cop :ImplicitStringConcatenation, "#{__dir__}/lint/implicit_string_concatenation"
+      register_cop :IncompatibleIoSelectWithFiberScheduler, "#{__dir__}/lint/incompatible_io_select_with_fiber_scheduler"
+      register_cop :IneffectiveAccessModifier, "#{__dir__}/lint/ineffective_access_modifier"
+      register_cop :InheritException, "#{__dir__}/lint/inherit_exception"
+      register_cop :InterpolationCheck, "#{__dir__}/lint/interpolation_check"
+      register_cop :ItWithoutArgumentsInBlock, "#{__dir__}/lint/it_without_arguments_in_block"
+      register_cop :LambdaWithoutLiteralBlock, "#{__dir__}/lint/lambda_without_literal_block"
+      register_cop :LiteralAsCondition, "#{__dir__}/lint/literal_as_condition"
+      register_cop :LiteralAssignmentInCondition, "#{__dir__}/lint/literal_assignment_in_condition"
+      register_cop :LiteralInInterpolation, "#{__dir__}/lint/literal_in_interpolation"
+      register_cop :Loop, "#{__dir__}/lint/loop"
+      register_cop :MissingCopEnableDirective, "#{__dir__}/lint/missing_cop_enable_directive"
+      register_cop :MissingSuper, "#{__dir__}/lint/missing_super"
+      register_cop :MixedCaseRange, "#{__dir__}/lint/mixed_case_range"
+      register_cop :MixedRegexpCaptureTypes, "#{__dir__}/lint/mixed_regexp_capture_types"
+      register_cop :MultipleComparison, "#{__dir__}/lint/multiple_comparison"
+      register_cop :NameTypo, "#{__dir__}/lint/name_typo"
+      register_cop :NestedMethodDefinition, "#{__dir__}/lint/nested_method_definition"
+      register_cop :NestedPercentLiteral, "#{__dir__}/lint/nested_percent_literal"
+      register_cop :NextWithoutAccumulator, "#{__dir__}/lint/next_without_accumulator"
+      register_cop :NoReturnInBeginEndBlocks, "#{__dir__}/lint/no_return_in_begin_end_blocks"
+      register_cop :NonAtomicFileOperation, "#{__dir__}/lint/non_atomic_file_operation"
+      register_cop :NonDeterministicRequireOrder, "#{__dir__}/lint/non_deterministic_require_order"
+      register_cop :NonLocalExitFromIterator, "#{__dir__}/lint/non_local_exit_from_iterator"
+      register_cop :NumberConversion, "#{__dir__}/lint/number_conversion"
+      register_cop :NumberedParameterAssignment, "#{__dir__}/lint/numbered_parameter_assignment"
+      register_cop :NumericOperationWithConstantResult, "#{__dir__}/lint/numeric_operation_with_constant_result"
+      register_cop :OrAssignmentToConstant, "#{__dir__}/lint/or_assignment_to_constant"
+      register_cop :OrderedMagicComments, "#{__dir__}/lint/ordered_magic_comments"
+      register_cop :OutOfRangeRegexpRef, "#{__dir__}/lint/out_of_range_regexp_ref"
+      register_cop :ParenthesesAsGroupedExpression, "#{__dir__}/lint/parentheses_as_grouped_expression"
+      register_cop :PercentStringArray, "#{__dir__}/lint/percent_string_array"
+      register_cop :PercentSymbolArray, "#{__dir__}/lint/percent_symbol_array"
+      register_cop :RaiseException, "#{__dir__}/lint/raise_exception"
+      register_cop :RandOne, "#{__dir__}/lint/rand_one"
+      register_cop :RedundantCopDisableDirective, "#{__dir__}/lint/redundant_cop_disable_directive"
+      register_cop :RedundantCopEnableDirective, "#{__dir__}/lint/redundant_cop_enable_directive"
+      register_cop :RedundantDirGlobSort, "#{__dir__}/lint/redundant_dir_glob_sort"
+      register_cop :RedundantRegexpQuantifiers, "#{__dir__}/lint/redundant_regexp_quantifiers"
+      register_cop :RedundantRequireStatement, "#{__dir__}/lint/redundant_require_statement"
+      register_cop :RedundantSafeNavigation, "#{__dir__}/lint/redundant_safe_navigation"
+      register_cop :RedundantSplatExpansion, "#{__dir__}/lint/redundant_splat_expansion"
+      register_cop :RedundantStringCoercion, "#{__dir__}/lint/redundant_string_coercion"
+      register_cop :RedundantTypeConversion, "#{__dir__}/lint/redundant_type_conversion"
+      register_cop :RedundantWithIndex, "#{__dir__}/lint/redundant_with_index"
+      register_cop :RedundantWithObject, "#{__dir__}/lint/redundant_with_object"
+      register_cop :RefinementImportMethods, "#{__dir__}/lint/refinement_import_methods"
+      register_cop :RegexpAsCondition, "#{__dir__}/lint/regexp_as_condition"
+      register_cop :RequireParentheses, "#{__dir__}/lint/require_parentheses"
+      register_cop :RequireRangeParentheses, "#{__dir__}/lint/require_range_parentheses"
+      register_cop :RequireRelativeSelfPath, "#{__dir__}/lint/require_relative_self_path"
+      register_cop :RescueException, "#{__dir__}/lint/rescue_exception"
+      register_cop :RescueType, "#{__dir__}/lint/rescue_type"
+      register_cop :ReturnInVoidContext, "#{__dir__}/lint/return_in_void_context"
+      register_cop :SafeNavigationConsistency, "#{__dir__}/lint/safe_navigation_consistency"
+      register_cop :SafeNavigationChain, "#{__dir__}/lint/safe_navigation_chain"
+      register_cop :SafeNavigationWithEmpty, "#{__dir__}/lint/safe_navigation_with_empty"
+      register_cop :ScriptPermission, "#{__dir__}/lint/script_permission"
+      register_cop :SelfAssignment, "#{__dir__}/lint/self_assignment"
+      register_cop :SendWithMixinArgument, "#{__dir__}/lint/send_with_mixin_argument"
+      register_cop :ShadowedArgument, "#{__dir__}/lint/shadowed_argument"
+      register_cop :ShadowedException, "#{__dir__}/lint/shadowed_exception"
+      register_cop :ShadowingOuterLocalVariable, "#{__dir__}/lint/shadowing_outer_local_variable"
+      register_cop :StructNewOverride, "#{__dir__}/lint/struct_new_override"
+      register_cop :SuperArgumentMismatch, "#{__dir__}/lint/super_argument_mismatch"
+      register_cop :SuppressedException, "#{__dir__}/lint/suppressed_exception"
+      register_cop :SuppressedExceptionInNumberConversion, "#{__dir__}/lint/suppressed_exception_in_number_conversion"
+      register_cop :SymbolConversion, "#{__dir__}/lint/symbol_conversion"
+      register_cop :Syntax, "#{__dir__}/lint/syntax"
+      register_cop :ToEnumArguments, "#{__dir__}/lint/to_enum_arguments"
+      register_cop :ToJSON, "#{__dir__}/lint/to_json"
+      register_cop :TopLevelReturnWithArgument, "#{__dir__}/lint/top_level_return_with_argument"
+      register_cop :TrailingCommaInAttributeDeclaration, "#{__dir__}/lint/trailing_comma_in_attribute_declaration"
+      register_cop :TripleQuotes, "#{__dir__}/lint/triple_quotes"
+      register_cop :UnderscorePrefixedVariableName, "#{__dir__}/lint/underscore_prefixed_variable_name"
+      register_cop :UnescapedBracketInRegexp, "#{__dir__}/lint/unescaped_bracket_in_regexp"
+      register_cop :UnexpectedBlockArity, "#{__dir__}/lint/unexpected_block_arity"
+      register_cop :UnifiedInteger, "#{__dir__}/lint/unified_integer"
+      register_cop :UnmodifiedReduceAccumulator, "#{__dir__}/lint/unmodified_reduce_accumulator"
+      register_cop :UnreachableCode, "#{__dir__}/lint/unreachable_code"
+      register_cop :UnreachableLoop, "#{__dir__}/lint/unreachable_loop"
+      register_cop :UnreachablePatternBranch, "#{__dir__}/lint/unreachable_pattern_branch"
+      register_cop :UnusedBlockArgument, "#{__dir__}/lint/unused_block_argument"
+      register_cop :UnusedMethodArgument, "#{__dir__}/lint/unused_method_argument"
+      register_cop :UnusedPrivateMethod, "#{__dir__}/lint/unused_private_method"
+      register_cop :UriEscapeUnescape, "#{__dir__}/lint/uri_escape_unescape"
+      register_cop :UriRegexp, "#{__dir__}/lint/uri_regexp"
+      register_cop :UselessAccessModifier, "#{__dir__}/lint/useless_access_modifier"
+      register_cop :UselessAssignment, "#{__dir__}/lint/useless_assignment"
+      register_cop :UselessConstantScoping, "#{__dir__}/lint/useless_constant_scoping"
+      register_cop :UselessDefaultValueArgument, "#{__dir__}/lint/useless_default_value_argument"
+      register_cop :UselessDefined, "#{__dir__}/lint/useless_defined"
+      register_cop :UselessElseWithoutRescue, "#{__dir__}/lint/useless_else_without_rescue"
+      register_cop :UselessMethodDefinition, "#{__dir__}/lint/useless_method_definition"
+      register_cop :UselessNumericOperation, "#{__dir__}/lint/useless_numeric_operation"
+      register_cop :UselessOr, "#{__dir__}/lint/useless_or"
+      register_cop :UselessRescue, "#{__dir__}/lint/useless_rescue"
+      register_cop :UselessRuby2Keywords, "#{__dir__}/lint/useless_ruby2_keywords"
+      register_cop :UselessSetterCall, "#{__dir__}/lint/useless_setter_call"
+      register_cop :UselessTimes, "#{__dir__}/lint/useless_times"
+      register_cop :Void, "#{__dir__}/lint/void"
+
+      autoload :UnusedArgument, "#{__dir__}/mixin/unused_argument"
+
+      # Utility classes for `Lint` department cops.
+      module Utils
+        autoload :NilReceiverChecker, "#{__dir__}/lint/utils/nil_receiver_checker"
+      end
+    end
+  end
+end

data/lib/rubocop/cop/metrics/perceived_complexity.rb

@@ -49,7 +49,7 @@ module RuboCop
 
         private
 
-        # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
+        # rubocop:disable-next Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
         def complexity_score_for(node)
           case node.type
           when :case
@@ -74,7 +74,6 @@ module RuboCop
             super
           end
         end
-        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
 
         def simple_in_pattern?(in_pattern_node)
           # `in_pattern_node.children[1]` is the guard (`if`/`unless`), or `nil`.

data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb

@@ -189,7 +189,7 @@ module RuboCop
           def source_from_node_with_heredoc(node)
             last_line = -1
             node.each_descendant do |descendant|
-              next unless descendant.source
+              next if descendant.loc.nil? || descendant.source_range.nil?
 
               descendant_last_line =
                 if heredoc_node?(descendant)

data/lib/rubocop/cop/metrics.rb

@@ -0,0 +1,31 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # Cops for the `Metrics` department. The department's cops are registered for lazy loading
+    # and their files are loaded on demand.
+    module Metrics
+      extend LazyLoader
+
+      register_cop :CyclomaticComplexity, "#{__dir__}/metrics/cyclomatic_complexity"
+      register_cop :AbcSize, "#{__dir__}/metrics/abc_size"
+      register_cop :BlockLength, "#{__dir__}/metrics/block_length"
+      register_cop :BlockNesting, "#{__dir__}/metrics/block_nesting"
+      register_cop :ClassLength, "#{__dir__}/metrics/class_length"
+      register_cop :CollectionLiteralLength, "#{__dir__}/metrics/collection_literal_length"
+      register_cop :MethodLength, "#{__dir__}/metrics/method_length"
+      register_cop :ModuleLength, "#{__dir__}/metrics/module_length"
+      register_cop :ParameterLists, "#{__dir__}/metrics/parameter_lists"
+      register_cop :PerceivedComplexity, "#{__dir__}/metrics/perceived_complexity"
+
+      # Utility classes for `Metrics` department cops.
+      module Utils
+        autoload :AbcSizeCalculator, "#{__dir__}/metrics/utils/abc_size_calculator"
+        autoload :CodeLengthCalculator, "#{__dir__}/metrics/utils/code_length_calculator"
+        autoload :IteratingBlock, "#{__dir__}/metrics/utils/iterating_block"
+        autoload :RepeatedAttributeDiscount, "#{__dir__}/metrics/utils/repeated_attribute_discount"
+        autoload :RepeatedCsendDiscount, "#{__dir__}/metrics/utils/repeated_csend_discount"
+      end
+    end
+  end
+end

data/lib/rubocop/cop/migration/department_name.rb

@@ -2,7 +2,7 @@
 
 # Lint/RedundantCopDisableDirective needs to be disabled so as
 # to be able to provide examples of rubocop:disable comments.
-# rubocop:disable Lint/RedundantCopDisableDirective
+# rubocop:disable-next Lint/RedundantCopDisableDirective
 module RuboCop
   module Cop
     module Migration
@@ -50,10 +50,6 @@ module RuboCop
 
         private
 
-        def disable_comment_offset
-          Regexp.last_match(1).length
-        end
-
         def check_cop_name(name, comment, offset)
           start = comment.source_range.begin_pos + offset
           range = range_between(start, start + name.length)
@@ -89,4 +85,3 @@ module RuboCop
     end
   end
 end
-# rubocop:enable Lint/RedundantCopDisableDirective

data/lib/rubocop/cop/migration.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # Cops for the `Migration` department. The department's cops are registered for lazy loading
+    # and their files are loaded on demand.
+    module Migration
+      extend LazyLoader
+
+      register_cop :DepartmentName, "#{__dir__}/migration/department_name"
+    end
+  end
+end

data/lib/rubocop/cop/mixin/check_line_breakable.rb

@@ -61,11 +61,13 @@ module RuboCop
       # @api private
       def extract_breakable_node_from_elements(node, elements, max)
         return unless breakable_collection?(node, elements)
-        return if safe_to_ignore?(node)
 
+        # Check the cheap conditions first, `safe_to_ignore?` may traverse all elements of
+        # a containing collection.
         line = processed_source.lines[node.first_line - 1]
+        return if max && line.length <= max
         return if processed_source.line_with_comment?(node.loc.line)
-        return if line.length <= max
+        return if safe_to_ignore?(node)
 
         extract_first_element_over_column_limit(node, elements, max)
       end
@@ -173,20 +175,36 @@ module RuboCop
         node.each_ancestor.find do |ancestor|
           if ancestor.type?(:hash, :array) &&
              breakable_collection?(ancestor, ancestor.children)
-            return children_could_be_broken_up?(ancestor.children)
+            return children_could_be_broken_up?(ancestor, ancestor.children)
           end
 
           next unless ancestor.call_type?
 
           args = process_args(ancestor.arguments)
-          return children_could_be_broken_up?(args) if breakable_collection?(ancestor, args)
+          if breakable_collection?(ancestor, args)
+            return children_could_be_broken_up?(ancestor, args)
+          end
         end
 
         false
       end
 
       # @api private
-      def children_could_be_broken_up?(children)
+      # The result depends only on the given node, but the check may traverse all children of
+      # a large collection and is repeated for each contained element, so memoize it per node.
+      def children_could_be_broken_up?(node, children)
+        if @check_line_breakable_processed_source != processed_source
+          @check_line_breakable_processed_source = processed_source
+          @children_could_be_broken_up_cache = {}.compare_by_identity
+        end
+
+        @children_could_be_broken_up_cache.fetch(node) do
+          @children_could_be_broken_up_cache[node] = compute_children_could_be_broken_up?(children)
+        end
+      end
+
+      # @api private
+      def compute_children_could_be_broken_up?(children)
         return false if all_on_same_line?(children)
 
         last_seen_line = -1

data/lib/rubocop/cop/mixin/comments_help.rb

@@ -64,7 +64,7 @@ module RuboCop
       # Returns the end line of a node, which might be a comment and not part of the AST
       # End line is considered either the line at which another node starts, or
       # the line at which the parent node ends.
-      # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
+      # rubocop:disable-next Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
       def find_end_line(node)
         if node.if_type?
           if node.else?
@@ -89,7 +89,6 @@ module RuboCop
           end
         end || node.loc.end.line
       end
-      # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
     end
   end
 end

data/lib/rubocop/cop/mixin/configurable_enforced_style.rb

@@ -25,7 +25,7 @@ module RuboCop
       end
       private_constant :SYMBOL_TO_STRING_CACHE
 
-      # rubocop:disable Metrics
+      # rubocop:disable-next Metrics
       def style_detected(detected)
         return if no_acceptable_style?
 
@@ -51,7 +51,6 @@ module RuboCop
           config_to_allow_offenses[style_parameter_name] = updated_list.first
         end
       end
-      # rubocop:enable Metrics
 
       def no_acceptable_style?
         config_to_allow_offenses['Enabled'] == false

data/lib/rubocop/cop/mixin/endless_method_rewriter.rb

@@ -5,20 +5,28 @@ module RuboCop
     # Common functionality for rewriting endless methods to normal method definitions
     module EndlessMethodRewriter
       def correct_to_multiline(corrector, node)
-        replacement = <<~RUBY.strip
-          def #{node.method_name}#{arguments(node)}
-            #{node.body.source}
-          end
-        RUBY
+        replacement = [
+          "def #{receiver(node)}#{node.method_name}#{arguments(node)}",
+          "#{indent(node, offset: configured_indentation_width)}#{node.body.source}",
+          "#{indent(node)}end"
+        ].join("\n")
 
         corrector.replace(node, replacement)
       end
 
       private
 
+      def receiver(node)
+        node.receiver ? "#{node.receiver.source}#{node.loc.operator.source}" : ''
+      end
+
       def arguments(node, missing = '')
         node.arguments.any? ? node.arguments.source : missing
       end
+
+      def configured_indentation_width
+        cop_config['IndentationWidth'] || config.for_cop('Layout/IndentationWidth')['Width'] || 2
+      end
     end
   end
 end

data/lib/rubocop/cop/mixin/hash_alignment_styles.rb

@@ -96,20 +96,37 @@ module RuboCop
         end
 
         def hash_rocket_delta(first_pair, current_pair)
-          first_pair.loc.column + max_key_width(first_pair.parent) + 1 -
-            current_pair.loc.operator.column
+          target_operator_column(first_pair) - current_pair.loc.operator.column
         end
 
         def value_delta(first_pair, current_pair)
-          correct_value_column = first_pair.key.loc.column +
-                                 max_key_width(first_pair.parent) +
-                                 max_delimiter_width(first_pair.parent)
+          correct_value_column = target_operator_column(first_pair) +
+                                 max_delimiter_width(first_pair.parent) - 1
 
           current_pair.value_omission? ? 0 : correct_value_column - current_pair.value.loc.column
         end
 
+        # The column the separator should land on: the shared key margin
+        # plus the widest single-line key, or, if larger, a multiline key's
+        # own last-line end column. The latter can't be measured from a
+        # multiline key's (newline-including) source length, so it's a
+        # separate candidate rather than folded into `max_key_width`.
+        def target_operator_column(first_pair)
+          hash_node = first_pair.parent
+          candidates = multiline_key_end_columns(hash_node)
+
+          key_width = max_key_width(hash_node)
+          candidates << (first_pair.loc.column + key_width + 1) if key_width.positive?
+
+          candidates.max
+        end
+
+        def multiline_key_end_columns(hash_node)
+          hash_node.keys.reject(&:single_line?).map { |key| key.source_range.end.column + 1 }
+        end
+
         def max_key_width(hash_node)
-          hash_node.keys.map { |key| key.source.length }.max
+          hash_node.keys.select(&:single_line?).map { |key| key.source.length }.max || 0
         end
 
         def max_delimiter_width(hash_node)

data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb

@@ -117,7 +117,7 @@ module RuboCop
           use_modifier_form_without_parenthesized_method_call?(method_dispatch_node)
       end
 
-      # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
+      # rubocop:disable-next Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
       def def_node_that_require_parentheses(node)
         last_pair = node.parent.pairs.last
         return unless last_pair.key.source == last_pair.value.source
@@ -131,7 +131,6 @@ module RuboCop
 
         DefNode.new(def_node) unless def_node && def_node.arguments.empty?
       end
-      # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
 
       def find_ancestor_method_dispatch_node(node)
         return unless (ancestor = node.parent.parent)

data/lib/rubocop/cop/mixin/hash_subset.rb

@@ -5,7 +5,7 @@ module RuboCop
     # Common functionality for Style/HashExcept and Style/HashSlice cops.
     # It registers an offense on methods with blocks that are equivalent
     # to Hash#except or Hash#slice.
-    # rubocop:disable Metrics/ModuleLength
+    # rubocop:disable-next Metrics/ModuleLength
     module HashSubset
       include RangeHelp
       extend NodePattern::Macros
@@ -206,6 +206,5 @@ module RuboCop
         range_between(node.loc.selector.begin_pos, node.parent.loc.end.end_pos)
       end
     end
-    # rubocop:enable Metrics/ModuleLength
   end
 end

data/lib/rubocop/cop/mixin/indexed_method_arity.rb

@@ -0,0 +1,94 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    # Shared machinery for cops that compare a call site's arguments against
+    # a method signature from the project index (`Rubydex::Signature`).
+    #
+    # A signature is reduced to a shape - `[min, max, has_keywords]` where
+    # `max` is nil for a rest parameter - and the number of positional
+    # arguments a call passes is counted with Ruby's semantics for trailing
+    # keyword hashes: keywords passed to a method with no keyword parameters
+    # collapse into a single positional hash.
+    module IndexedMethodArity
+      private
+
+      def arity_satisfied?(given, min, max)
+        given >= min && (max.nil? || given <= max)
+      end
+
+      def expected_range(min, max)
+        return "#{min}+" if max.nil?
+        return min.to_s if min == max
+
+        "#{min}..#{max}"
+      end
+
+      # The agreed `[min, max, has_keywords]` shape of an indexed member's
+      # method definitions, or nil when the member is not backed by plain
+      # method definitions (attr, alias), has no signature, forwards
+      # arguments, or its definitions disagree on arity (e.g. reopened with
+      # a different one).
+      def indexed_member_shape(member)
+        definitions = member.definitions.grep(Rubydex::MethodDefinition)
+        return nil if definitions.empty?
+
+        signature_shape(definitions.flat_map(&:signatures))
+      end
+
+      def signature_shape(signatures)
+        shapes = signatures.filter_map { |signature| shape_for(signature) }.uniq
+        shapes.one? ? shapes.first : nil
+      end
+
+      def shape_for(signature)
+        return nil if signature.forward_parameter
+
+        min = signature.positional_parameters.size + signature.post_parameters.size
+
+        [min, maximum_positional(signature, min), keyword_parameters?(signature)]
+      end
+
+      def maximum_positional(signature, min)
+        return nil if signature.rest_positional_parameter
+
+        min + signature.optional_positional_parameters.size
+      end
+
+      def keyword_parameters?(signature)
+        !signature.keyword_parameters.empty? ||
+          !signature.optional_keyword_parameters.empty? ||
+          !signature.rest_keyword_parameter.nil?
+      end
+
+      # The number of positional arguments the call passes, or nil when it
+      # cannot be determined statically (argument forwarding).
+      def positional_argument_count(node, callee_has_keywords)
+        arguments = node.arguments
+        return nil if forwards_arguments?(arguments)
+
+        arguments = arguments[0...-1] if arguments.last&.block_pass_type?
+        return arguments.size unless (keyword_hash = keyword_hash(arguments.last))
+        return nil if double_splat?(keyword_hash)
+
+        # A keyword-style hash passed to a method with no keyword parameters is
+        # received as a single positional hash argument.
+        callee_has_keywords ? arguments.size - 1 : arguments.size
+      end
+
+      def forwards_arguments?(arguments)
+        arguments.any? do |argument|
+          argument.type?(:splat, :forwarded_args, :forwarded_restarg, :forwarded_kwrestarg)
+        end
+      end
+
+      def keyword_hash(node)
+        node if node&.hash_type? && !node.braces?
+      end
+
+      def double_splat?(hash_node)
+        hash_node.each_child_node.any?(&:kwsplat_type?)
+      end
+    end
+  end
+end

data/lib/rubocop/cop/mixin/line_length_help.rb

@@ -128,7 +128,13 @@ module RuboCop
           # Additionally, the RFC2396_PARSER alias is only available on 3.4 for now.
           # Extra info at https://github.com/ruby/uri/issues/118
           parser = defined?(URI::RFC2396_PARSER) ? URI::RFC2396_PARSER : URI::DEFAULT_PARSER
-          parser.make_regexp(config.for_cop('Layout/LineLength')['URISchemes'])
+          schemes = config.for_cop('Layout/LineLength')['URISchemes']
+          regexp = parser.make_regexp(schemes)
+
+          # `make_regexp` in uri 1.1.0+ matches schemes case-insensitively, which makes
+          # constant paths like `Http::UploadedFile` look like URIs. Require the exact case
+          # given in `URISchemes`.
+          schemes ? /(?=#{Regexp.union(schemes)}:)#{regexp}/ : regexp
         end
       end