rubocop 1.29.1 → 1.36.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (557) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +5 -3
  3. data/config/default.yml +164 -26
  4. data/config/obsoletion.yml +25 -1
  5. data/exe/rubocop +15 -7
  6. data/lib/rubocop/cache_config.rb +29 -0
  7. data/lib/rubocop/cli/command/{auto_genenerate_config.rb → auto_generate_config.rb} +20 -5
  8. data/lib/rubocop/cli/command/execute_runner.rb +1 -1
  9. data/lib/rubocop/cli/command/init_dotfile.rb +1 -1
  10. data/lib/rubocop/cli/command/show_cops.rb +1 -1
  11. data/lib/rubocop/cli/command/suggest_extensions.rb +53 -15
  12. data/lib/rubocop/cli.rb +2 -0
  13. data/lib/rubocop/config.rb +6 -2
  14. data/lib/rubocop/config_finder.rb +68 -0
  15. data/lib/rubocop/config_loader.rb +15 -41
  16. data/lib/rubocop/config_loader_resolver.rb +2 -6
  17. data/lib/rubocop/config_obsoletion/changed_parameter.rb +5 -0
  18. data/lib/rubocop/config_obsoletion/parameter_rule.rb +4 -0
  19. data/lib/rubocop/config_obsoletion.rb +7 -2
  20. data/lib/rubocop/config_validator.rb +21 -4
  21. data/lib/rubocop/cop/autocorrect_logic.rb +4 -2
  22. data/lib/rubocop/cop/base.rb +6 -2
  23. data/lib/rubocop/cop/bundler/duplicated_gem.rb +1 -1
  24. data/lib/rubocop/cop/bundler/gem_filename.rb +5 -5
  25. data/lib/rubocop/cop/bundler/ordered_gems.rb +2 -2
  26. data/lib/rubocop/cop/cop.rb +1 -1
  27. data/lib/rubocop/cop/corrector.rb +2 -2
  28. data/lib/rubocop/cop/correctors/alignment_corrector.rb +1 -1
  29. data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -1
  30. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +1 -1
  31. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
  32. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +4 -2
  33. data/lib/rubocop/cop/correctors/if_then_corrector.rb +1 -1
  34. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +1 -1
  35. data/lib/rubocop/cop/correctors/line_break_corrector.rb +7 -1
  36. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +3 -3
  37. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +1 -1
  38. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +59 -1
  39. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
  40. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
  41. data/lib/rubocop/cop/correctors/space_corrector.rb +1 -1
  42. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +1 -1
  43. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +2 -2
  44. data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
  45. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +1 -1
  46. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +1 -1
  47. data/lib/rubocop/cop/gemspec/require_mfa.rb +21 -21
  48. data/lib/rubocop/cop/generator/require_file_injector.rb +2 -2
  49. data/lib/rubocop/cop/generator.rb +5 -1
  50. data/lib/rubocop/cop/internal_affairs/cop_description.rb +96 -0
  51. data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +1 -1
  52. data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +1 -1
  53. data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +1 -1
  54. data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +1 -5
  55. data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
  56. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +1 -1
  57. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +1 -1
  58. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
  59. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -1
  60. data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
  61. data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
  62. data/lib/rubocop/cop/internal_affairs.rb +4 -0
  63. data/lib/rubocop/cop/layout/argument_alignment.rb +22 -1
  64. data/lib/rubocop/cop/layout/assignment_indentation.rb +1 -1
  65. data/lib/rubocop/cop/layout/begin_end_alignment.rb +1 -1
  66. data/lib/rubocop/cop/layout/block_alignment.rb +17 -13
  67. data/lib/rubocop/cop/layout/block_end_newline.rb +36 -6
  68. data/lib/rubocop/cop/layout/case_indentation.rb +1 -1
  69. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -1
  70. data/lib/rubocop/cop/layout/comment_indentation.rb +1 -1
  71. data/lib/rubocop/cop/layout/condition_position.rb +1 -1
  72. data/lib/rubocop/cop/layout/def_end_alignment.rb +1 -1
  73. data/lib/rubocop/cop/layout/dot_position.rb +1 -1
  74. data/lib/rubocop/cop/layout/else_alignment.rb +1 -1
  75. data/lib/rubocop/cop/layout/empty_comment.rb +2 -2
  76. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +1 -1
  77. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +1 -1
  78. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +1 -1
  79. data/lib/rubocop/cop/layout/empty_lines.rb +1 -1
  80. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +5 -2
  81. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +1 -1
  82. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +25 -4
  83. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +1 -1
  84. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +7 -5
  85. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +10 -10
  86. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +1 -1
  87. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +1 -1
  88. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +10 -10
  89. data/lib/rubocop/cop/layout/end_alignment.rb +1 -1
  90. data/lib/rubocop/cop/layout/end_of_line.rb +5 -5
  91. data/lib/rubocop/cop/layout/extra_spacing.rb +1 -1
  92. data/lib/rubocop/cop/layout/first_argument_indentation.rb +34 -29
  93. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +21 -14
  94. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +1 -1
  95. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +52 -13
  96. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +1 -1
  97. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +1 -1
  98. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +1 -1
  99. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +1 -1
  100. data/lib/rubocop/cop/layout/hash_alignment.rb +2 -0
  101. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +1 -1
  102. data/lib/rubocop/cop/layout/heredoc_indentation.rb +1 -1
  103. data/lib/rubocop/cop/layout/indentation_consistency.rb +1 -1
  104. data/lib/rubocop/cop/layout/indentation_style.rb +1 -1
  105. data/lib/rubocop/cop/layout/indentation_width.rb +13 -6
  106. data/lib/rubocop/cop/layout/initial_indentation.rb +2 -2
  107. data/lib/rubocop/cop/layout/leading_comment_space.rb +1 -1
  108. data/lib/rubocop/cop/layout/leading_empty_lines.rb +1 -1
  109. data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +112 -0
  110. data/lib/rubocop/cop/layout/line_continuation_spacing.rb +130 -0
  111. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +1 -1
  112. data/lib/rubocop/cop/layout/line_length.rb +7 -2
  113. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +1 -1
  114. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +1 -1
  115. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +2 -2
  116. data/lib/rubocop/cop/layout/multiline_block_layout.rb +4 -2
  117. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +1 -1
  118. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +1 -1
  119. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +5 -2
  120. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +1 -1
  121. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +3 -3
  122. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +1 -1
  123. data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +45 -0
  124. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +3 -3
  125. data/lib/rubocop/cop/layout/redundant_line_break.rb +2 -2
  126. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +1 -1
  127. data/lib/rubocop/cop/layout/single_line_block_chain.rb +1 -1
  128. data/lib/rubocop/cop/layout/space_after_not.rb +1 -1
  129. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +2 -2
  130. data/lib/rubocop/cop/layout/space_around_keyword.rb +1 -1
  131. data/lib/rubocop/cop/layout/space_around_operators.rb +1 -1
  132. data/lib/rubocop/cop/layout/space_before_block_braces.rb +5 -3
  133. data/lib/rubocop/cop/layout/space_before_comment.rb +1 -1
  134. data/lib/rubocop/cop/layout/space_before_first_arg.rb +1 -1
  135. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +1 -1
  136. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +10 -10
  137. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +33 -15
  138. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +1 -1
  139. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +8 -8
  140. data/lib/rubocop/cop/layout/trailing_whitespace.rb +2 -2
  141. data/lib/rubocop/cop/legacy/corrections_proxy.rb +1 -1
  142. data/lib/rubocop/cop/legacy/corrector.rb +1 -1
  143. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +1 -1
  144. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +27 -7
  145. data/lib/rubocop/cop/lint/ambiguous_operator.rb +1 -1
  146. data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +1 -1
  147. data/lib/rubocop/cop/lint/ambiguous_range.rb +3 -3
  148. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +1 -1
  149. data/lib/rubocop/cop/lint/assignment_in_condition.rb +1 -1
  150. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +1 -1
  151. data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -1
  152. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  153. data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
  154. data/lib/rubocop/cop/lint/debugger.rb +27 -17
  155. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +15 -9
  156. data/lib/rubocop/cop/lint/deprecated_constants.rb +1 -1
  157. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +1 -1
  158. data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -1
  159. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  160. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +1 -1
  161. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
  162. data/lib/rubocop/cop/lint/duplicate_methods.rb +1 -1
  163. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +1 -1
  164. data/lib/rubocop/cop/lint/duplicate_require.rb +1 -1
  165. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +1 -1
  166. data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
  167. data/lib/rubocop/cop/lint/else_layout.rb +3 -3
  168. data/lib/rubocop/cop/lint/empty_block.rb +2 -2
  169. data/lib/rubocop/cop/lint/empty_class.rb +1 -1
  170. data/lib/rubocop/cop/lint/empty_conditional_body.rb +96 -2
  171. data/lib/rubocop/cop/lint/empty_ensure.rb +1 -1
  172. data/lib/rubocop/cop/lint/empty_expression.rb +1 -1
  173. data/lib/rubocop/cop/lint/empty_file.rb +1 -1
  174. data/lib/rubocop/cop/lint/empty_in_pattern.rb +1 -1
  175. data/lib/rubocop/cop/lint/empty_interpolation.rb +1 -1
  176. data/lib/rubocop/cop/lint/empty_when.rb +1 -1
  177. data/lib/rubocop/cop/lint/ensure_return.rb +1 -1
  178. data/lib/rubocop/cop/lint/erb_new_arguments.rb +9 -9
  179. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  180. data/lib/rubocop/cop/lint/float_comparison.rb +1 -1
  181. data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
  182. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +1 -1
  183. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +1 -1
  184. data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +1 -1
  185. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -1
  186. data/lib/rubocop/cop/lint/inherit_exception.rb +1 -1
  187. data/lib/rubocop/cop/lint/interpolation_check.rb +2 -2
  188. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +2 -2
  189. data/lib/rubocop/cop/lint/literal_as_condition.rb +6 -1
  190. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +5 -1
  191. data/lib/rubocop/cop/lint/loop.rb +1 -1
  192. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +1 -1
  193. data/lib/rubocop/cop/lint/missing_super.rb +1 -1
  194. data/lib/rubocop/cop/lint/nested_method_definition.rb +1 -1
  195. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
  196. data/lib/rubocop/cop/lint/next_without_accumulator.rb +25 -6
  197. data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +157 -0
  198. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +12 -0
  199. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
  200. data/lib/rubocop/cop/lint/number_conversion.rb +32 -10
  201. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +1 -1
  202. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +2 -3
  203. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +1 -1
  204. data/lib/rubocop/cop/lint/percent_string_array.rb +1 -1
  205. data/lib/rubocop/cop/lint/percent_symbol_array.rb +1 -1
  206. data/lib/rubocop/cop/lint/raise_exception.rb +1 -1
  207. data/lib/rubocop/cop/lint/rand_one.rb +1 -1
  208. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +6 -6
  209. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +2 -2
  210. data/lib/rubocop/cop/lint/redundant_require_statement.rb +4 -1
  211. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +16 -3
  212. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +1 -1
  213. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -1
  214. data/lib/rubocop/cop/lint/redundant_with_index.rb +14 -11
  215. data/lib/rubocop/cop/lint/redundant_with_object.rb +13 -12
  216. data/lib/rubocop/cop/lint/refinement_import_methods.rb +1 -1
  217. data/lib/rubocop/cop/lint/regexp_as_condition.rb +3 -3
  218. data/lib/rubocop/cop/lint/require_parentheses.rb +1 -1
  219. data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
  220. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  221. data/lib/rubocop/cop/lint/return_in_void_context.rb +1 -1
  222. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +38 -1
  223. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +1 -1
  224. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
  225. data/lib/rubocop/cop/lint/script_permission.rb +1 -1
  226. data/lib/rubocop/cop/lint/self_assignment.rb +1 -1
  227. data/lib/rubocop/cop/lint/shadowed_argument.rb +1 -1
  228. data/lib/rubocop/cop/lint/shadowed_exception.rb +16 -1
  229. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +25 -4
  230. data/lib/rubocop/cop/lint/struct_new_override.rb +3 -3
  231. data/lib/rubocop/cop/lint/suppressed_exception.rb +1 -1
  232. data/lib/rubocop/cop/lint/symbol_conversion.rb +1 -1
  233. data/lib/rubocop/cop/lint/syntax.rb +1 -1
  234. data/lib/rubocop/cop/lint/to_enum_arguments.rb +1 -1
  235. data/lib/rubocop/cop/lint/to_json.rb +1 -1
  236. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
  237. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +2 -2
  238. data/lib/rubocop/cop/lint/triple_quotes.rb +1 -1
  239. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +1 -1
  240. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +1 -1
  241. data/lib/rubocop/cop/lint/unified_integer.rb +3 -1
  242. data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
  243. data/lib/rubocop/cop/lint/unreachable_loop.rb +9 -3
  244. data/lib/rubocop/cop/lint/unused_block_argument.rb +1 -1
  245. data/lib/rubocop/cop/lint/unused_method_argument.rb +1 -1
  246. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
  247. data/lib/rubocop/cop/lint/uri_regexp.rb +1 -1
  248. data/lib/rubocop/cop/lint/useless_access_modifier.rb +9 -7
  249. data/lib/rubocop/cop/lint/useless_assignment.rb +1 -1
  250. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +44 -0
  251. data/lib/rubocop/cop/lint/useless_method_definition.rb +1 -1
  252. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +2 -2
  253. data/lib/rubocop/cop/lint/useless_setter_call.rb +2 -2
  254. data/lib/rubocop/cop/lint/useless_times.rb +1 -1
  255. data/lib/rubocop/cop/lint/void.rb +3 -1
  256. data/lib/rubocop/cop/metrics/abc_size.rb +4 -2
  257. data/lib/rubocop/cop/metrics/block_length.rb +7 -7
  258. data/lib/rubocop/cop/metrics/block_nesting.rb +1 -1
  259. data/lib/rubocop/cop/metrics/class_length.rb +1 -1
  260. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +1 -1
  261. data/lib/rubocop/cop/metrics/method_length.rb +9 -8
  262. data/lib/rubocop/cop/metrics/module_length.rb +1 -1
  263. data/lib/rubocop/cop/metrics/parameter_lists.rb +1 -1
  264. data/lib/rubocop/cop/metrics/perceived_complexity.rb +1 -1
  265. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +1 -1
  266. data/lib/rubocop/cop/mixin/allowed_methods.rb +20 -1
  267. data/lib/rubocop/cop/mixin/allowed_pattern.rb +17 -1
  268. data/lib/rubocop/cop/mixin/check_line_breakable.rb +5 -1
  269. data/lib/rubocop/cop/mixin/comments_help.rb +5 -1
  270. data/lib/rubocop/cop/mixin/def_node.rb +2 -7
  271. data/lib/rubocop/cop/mixin/enforce_superclass.rb +2 -1
  272. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +82 -2
  273. data/lib/rubocop/cop/mixin/hash_transform_method.rb +10 -6
  274. data/lib/rubocop/cop/mixin/method_complexity.rb +8 -13
  275. data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +34 -12
  276. data/lib/rubocop/cop/mixin/percent_array.rb +60 -1
  277. data/lib/rubocop/cop/mixin/range_help.rb +10 -7
  278. data/lib/rubocop/cop/mixin/string_help.rb +1 -1
  279. data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
  280. data/lib/rubocop/cop/naming/ascii_identifiers.rb +1 -1
  281. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
  282. data/lib/rubocop/cop/naming/block_forwarding.rb +2 -2
  283. data/lib/rubocop/cop/naming/block_parameter_name.rb +2 -2
  284. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +1 -1
  285. data/lib/rubocop/cop/naming/constant_name.rb +3 -3
  286. data/lib/rubocop/cop/naming/file_name.rb +1 -1
  287. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +1 -1
  288. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +1 -1
  289. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +1 -1
  290. data/lib/rubocop/cop/naming/method_name.rb +1 -1
  291. data/lib/rubocop/cop/naming/method_parameter_name.rb +1 -1
  292. data/lib/rubocop/cop/naming/predicate_name.rb +30 -1
  293. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +1 -1
  294. data/lib/rubocop/cop/naming/variable_name.rb +1 -1
  295. data/lib/rubocop/cop/naming/variable_number.rb +18 -18
  296. data/lib/rubocop/cop/security/compound_hash.rb +1 -1
  297. data/lib/rubocop/cop/security/eval.rb +1 -1
  298. data/lib/rubocop/cop/security/json_load.rb +1 -1
  299. data/lib/rubocop/cop/security/marshal_load.rb +1 -1
  300. data/lib/rubocop/cop/security/open.rb +1 -1
  301. data/lib/rubocop/cop/security/yaml_load.rb +1 -1
  302. data/lib/rubocop/cop/style/access_modifier_declarations.rb +77 -1
  303. data/lib/rubocop/cop/style/accessor_grouping.rb +4 -4
  304. data/lib/rubocop/cop/style/alias.rb +1 -1
  305. data/lib/rubocop/cop/style/and_or.rb +11 -11
  306. data/lib/rubocop/cop/style/arguments_forwarding.rb +3 -3
  307. data/lib/rubocop/cop/style/array_coercion.rb +1 -1
  308. data/lib/rubocop/cop/style/array_join.rb +1 -1
  309. data/lib/rubocop/cop/style/ascii_comments.rb +1 -1
  310. data/lib/rubocop/cop/style/attr.rb +1 -1
  311. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +1 -1
  312. data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
  313. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +1 -1
  314. data/lib/rubocop/cop/style/block_comments.rb +1 -1
  315. data/lib/rubocop/cop/style/block_delimiters.rb +30 -9
  316. data/lib/rubocop/cop/style/case_equality.rb +41 -11
  317. data/lib/rubocop/cop/style/case_like_if.rb +1 -1
  318. data/lib/rubocop/cop/style/class_and_module_children.rb +5 -5
  319. data/lib/rubocop/cop/style/class_check.rb +1 -1
  320. data/lib/rubocop/cop/style/class_equality_comparison.rb +51 -4
  321. data/lib/rubocop/cop/style/class_methods.rb +1 -1
  322. data/lib/rubocop/cop/style/class_methods_definitions.rb +3 -2
  323. data/lib/rubocop/cop/style/class_vars.rb +1 -1
  324. data/lib/rubocop/cop/style/collection_compact.rb +1 -1
  325. data/lib/rubocop/cop/style/collection_methods.rb +3 -1
  326. data/lib/rubocop/cop/style/colon_method_call.rb +1 -1
  327. data/lib/rubocop/cop/style/colon_method_definition.rb +1 -1
  328. data/lib/rubocop/cop/style/combinable_loops.rb +4 -2
  329. data/lib/rubocop/cop/style/command_literal.rb +1 -1
  330. data/lib/rubocop/cop/style/comment_annotation.rb +1 -1
  331. data/lib/rubocop/cop/style/commented_keyword.rb +4 -4
  332. data/lib/rubocop/cop/style/conditional_assignment.rb +2 -1
  333. data/lib/rubocop/cop/style/constant_visibility.rb +1 -1
  334. data/lib/rubocop/cop/style/date_time.rb +1 -1
  335. data/lib/rubocop/cop/style/def_with_parentheses.rb +1 -1
  336. data/lib/rubocop/cop/style/dir.rb +4 -1
  337. data/lib/rubocop/cop/style/documentation.rb +1 -1
  338. data/lib/rubocop/cop/style/documentation_method.rb +1 -1
  339. data/lib/rubocop/cop/style/double_negation.rb +3 -1
  340. data/lib/rubocop/cop/style/each_for_simple_loop.rb +42 -7
  341. data/lib/rubocop/cop/style/each_with_object.rb +40 -9
  342. data/lib/rubocop/cop/style/empty_block_parameter.rb +2 -2
  343. data/lib/rubocop/cop/style/empty_case_condition.rb +1 -1
  344. data/lib/rubocop/cop/style/empty_else.rb +40 -3
  345. data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
  346. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +2 -2
  347. data/lib/rubocop/cop/style/empty_literal.rb +1 -1
  348. data/lib/rubocop/cop/style/empty_method.rb +17 -2
  349. data/lib/rubocop/cop/style/encoding.rb +2 -2
  350. data/lib/rubocop/cop/style/end_block.rb +1 -1
  351. data/lib/rubocop/cop/style/endless_method.rb +1 -1
  352. data/lib/rubocop/cop/style/env_home.rb +1 -1
  353. data/lib/rubocop/cop/style/eval_with_location.rb +1 -1
  354. data/lib/rubocop/cop/style/even_odd.rb +1 -1
  355. data/lib/rubocop/cop/style/expand_path_arguments.rb +1 -1
  356. data/lib/rubocop/cop/style/explicit_block_argument.rb +2 -2
  357. data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
  358. data/lib/rubocop/cop/style/fetch_env_var.rb +37 -224
  359. data/lib/rubocop/cop/style/float_division.rb +1 -1
  360. data/lib/rubocop/cop/style/for.rb +3 -1
  361. data/lib/rubocop/cop/style/format_string.rb +1 -1
  362. data/lib/rubocop/cop/style/format_string_token.rb +73 -23
  363. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +6 -3
  364. data/lib/rubocop/cop/style/global_std_stream.rb +1 -1
  365. data/lib/rubocop/cop/style/global_vars.rb +1 -1
  366. data/lib/rubocop/cop/style/guard_clause.rb +35 -22
  367. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +1 -1
  368. data/lib/rubocop/cop/style/hash_conversion.rb +1 -1
  369. data/lib/rubocop/cop/style/hash_each_methods.rb +4 -2
  370. data/lib/rubocop/cop/style/hash_except.rb +85 -9
  371. data/lib/rubocop/cop/style/hash_like_case.rb +1 -1
  372. data/lib/rubocop/cop/style/hash_syntax.rb +20 -3
  373. data/lib/rubocop/cop/style/hash_transform_keys.rb +6 -1
  374. data/lib/rubocop/cop/style/hash_transform_values.rb +4 -1
  375. data/lib/rubocop/cop/style/identical_conditional_branches.rb +2 -2
  376. data/lib/rubocop/cop/style/if_unless_modifier.rb +1 -1
  377. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +4 -2
  378. data/lib/rubocop/cop/style/implicit_runtime_error.rb +3 -3
  379. data/lib/rubocop/cop/style/in_pattern_then.rb +1 -1
  380. data/lib/rubocop/cop/style/inline_comment.rb +1 -1
  381. data/lib/rubocop/cop/style/inverse_methods.rb +10 -8
  382. data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
  383. data/lib/rubocop/cop/style/keyword_parameters_order.rb +2 -2
  384. data/lib/rubocop/cop/style/lambda.rb +1 -1
  385. data/lib/rubocop/cop/style/lambda_call.rb +1 -1
  386. data/lib/rubocop/cop/style/line_end_concatenation.rb +2 -2
  387. data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
  388. data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
  389. data/lib/rubocop/cop/style/map_to_hash.rb +3 -3
  390. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +4 -4
  391. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +5 -1
  392. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +8 -8
  393. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +20 -3
  394. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +5 -2
  395. data/lib/rubocop/cop/style/method_def_parentheses.rb +1 -1
  396. data/lib/rubocop/cop/style/min_max.rb +1 -1
  397. data/lib/rubocop/cop/style/missing_else.rb +24 -24
  398. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +1 -1
  399. data/lib/rubocop/cop/style/mixin_grouping.rb +1 -1
  400. data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
  401. data/lib/rubocop/cop/style/module_function.rb +3 -3
  402. data/lib/rubocop/cop/style/multiline_block_chain.rb +4 -2
  403. data/lib/rubocop/cop/style/multiline_if_modifier.rb +2 -2
  404. data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
  405. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +3 -5
  406. data/lib/rubocop/cop/style/multiline_memoization.rb +1 -1
  407. data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
  408. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +3 -3
  409. data/lib/rubocop/cop/style/multiline_when_then.rb +2 -4
  410. data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
  411. data/lib/rubocop/cop/style/mutable_constant.rb +1 -1
  412. data/lib/rubocop/cop/style/negated_if_else_condition.rb +1 -1
  413. data/lib/rubocop/cop/style/nested_file_dirname.rb +1 -1
  414. data/lib/rubocop/cop/style/nested_modifier.rb +1 -1
  415. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +11 -2
  416. data/lib/rubocop/cop/style/nested_ternary_operator.rb +20 -8
  417. data/lib/rubocop/cop/style/next.rb +3 -5
  418. data/lib/rubocop/cop/style/nil_comparison.rb +1 -1
  419. data/lib/rubocop/cop/style/nil_lambda.rb +3 -3
  420. data/lib/rubocop/cop/style/non_nil_check.rb +1 -1
  421. data/lib/rubocop/cop/style/not.rb +2 -2
  422. data/lib/rubocop/cop/style/numbered_parameters.rb +1 -1
  423. data/lib/rubocop/cop/style/numbered_parameters_limit.rb +1 -1
  424. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +1 -1
  425. data/lib/rubocop/cop/style/numeric_literals.rb +16 -1
  426. data/lib/rubocop/cop/style/numeric_predicate.rb +53 -11
  427. data/lib/rubocop/cop/style/object_then.rb +3 -1
  428. data/lib/rubocop/cop/style/one_line_conditional.rb +1 -1
  429. data/lib/rubocop/cop/style/open_struct_use.rb +1 -1
  430. data/lib/rubocop/cop/style/option_hash.rb +1 -1
  431. data/lib/rubocop/cop/style/optional_arguments.rb +1 -1
  432. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +1 -1
  433. data/lib/rubocop/cop/style/or_assignment.rb +1 -1
  434. data/lib/rubocop/cop/style/parentheses_around_condition.rb +1 -1
  435. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -1
  436. data/lib/rubocop/cop/style/percent_q_literals.rb +1 -1
  437. data/lib/rubocop/cop/style/perl_backrefs.rb +23 -2
  438. data/lib/rubocop/cop/style/preferred_hash_methods.rb +1 -1
  439. data/lib/rubocop/cop/style/proc.rb +5 -2
  440. data/lib/rubocop/cop/style/raise_args.rb +1 -1
  441. data/lib/rubocop/cop/style/random_with_offset.rb +1 -1
  442. data/lib/rubocop/cop/style/redundant_argument.rb +2 -2
  443. data/lib/rubocop/cop/style/redundant_assignment.rb +1 -1
  444. data/lib/rubocop/cop/style/redundant_begin.rb +19 -6
  445. data/lib/rubocop/cop/style/redundant_capital_w.rb +1 -1
  446. data/lib/rubocop/cop/style/redundant_condition.rb +28 -9
  447. data/lib/rubocop/cop/style/redundant_conditional.rb +1 -1
  448. data/lib/rubocop/cop/style/redundant_exception.rb +1 -1
  449. data/lib/rubocop/cop/style/redundant_fetch_block.rb +2 -2
  450. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +1 -1
  451. data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
  452. data/lib/rubocop/cop/style/redundant_interpolation.rb +22 -1
  453. data/lib/rubocop/cop/style/redundant_parentheses.rb +22 -24
  454. data/lib/rubocop/cop/style/redundant_percent_q.rb +1 -1
  455. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +2 -2
  456. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +1 -1
  457. data/lib/rubocop/cop/style/redundant_return.rb +2 -2
  458. data/lib/rubocop/cop/style/redundant_self.rb +3 -1
  459. data/lib/rubocop/cop/style/redundant_self_assignment.rb +2 -2
  460. data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +1 -1
  461. data/lib/rubocop/cop/style/redundant_sort.rb +22 -7
  462. data/lib/rubocop/cop/style/redundant_sort_by.rb +25 -9
  463. data/lib/rubocop/cop/style/regexp_literal.rb +1 -1
  464. data/lib/rubocop/cop/style/rescue_modifier.rb +1 -1
  465. data/lib/rubocop/cop/style/rescue_standard_error.rb +13 -13
  466. data/lib/rubocop/cop/style/return_nil.rb +1 -1
  467. data/lib/rubocop/cop/style/safe_navigation.rb +8 -3
  468. data/lib/rubocop/cop/style/sample.rb +1 -1
  469. data/lib/rubocop/cop/style/select_by_regexp.rb +1 -1
  470. data/lib/rubocop/cop/style/self_assignment.rb +1 -1
  471. data/lib/rubocop/cop/style/semicolon.rb +28 -4
  472. data/lib/rubocop/cop/style/send.rb +1 -1
  473. data/lib/rubocop/cop/style/signal_exception.rb +1 -1
  474. data/lib/rubocop/cop/style/single_line_block_params.rb +2 -2
  475. data/lib/rubocop/cop/style/single_line_methods.rb +2 -2
  476. data/lib/rubocop/cop/style/slicing_with_range.rb +1 -1
  477. data/lib/rubocop/cop/style/sole_nested_conditional.rb +42 -14
  478. data/lib/rubocop/cop/style/static_class.rb +1 -1
  479. data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
  480. data/lib/rubocop/cop/style/string_concatenation.rb +6 -7
  481. data/lib/rubocop/cop/style/string_hash_keys.rb +1 -1
  482. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +1 -1
  483. data/lib/rubocop/cop/style/string_methods.rb +1 -1
  484. data/lib/rubocop/cop/style/strip.rb +1 -1
  485. data/lib/rubocop/cop/style/struct_inheritance.rb +4 -4
  486. data/lib/rubocop/cop/style/swap_values.rb +2 -2
  487. data/lib/rubocop/cop/style/symbol_array.rb +9 -6
  488. data/lib/rubocop/cop/style/symbol_literal.rb +1 -1
  489. data/lib/rubocop/cop/style/symbol_proc.rb +48 -14
  490. data/lib/rubocop/cop/style/ternary_parentheses.rb +2 -14
  491. data/lib/rubocop/cop/style/top_level_method_definition.rb +3 -1
  492. data/lib/rubocop/cop/style/trailing_body_on_class.rb +1 -1
  493. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -1
  494. data/lib/rubocop/cop/style/trailing_body_on_module.rb +1 -1
  495. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +1 -1
  496. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +1 -1
  497. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +2 -2
  498. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +1 -1
  499. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +1 -1
  500. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +1 -1
  501. data/lib/rubocop/cop/style/trivial_accessors.rb +4 -1
  502. data/lib/rubocop/cop/style/unless_else.rb +1 -1
  503. data/lib/rubocop/cop/style/unless_logical_operators.rb +1 -1
  504. data/lib/rubocop/cop/style/unpack_first.rb +5 -2
  505. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  506. data/lib/rubocop/cop/style/when_then.rb +1 -1
  507. data/lib/rubocop/cop/style/word_array.rb +4 -5
  508. data/lib/rubocop/cop/style/yoda_condition.rb +1 -1
  509. data/lib/rubocop/cop/style/zero_length_predicate.rb +1 -1
  510. data/lib/rubocop/cop/team.rb +2 -2
  511. data/lib/rubocop/cop/util.rb +3 -3
  512. data/lib/rubocop/cops_documentation_generator.rb +18 -1
  513. data/lib/rubocop/ext/range.rb +15 -0
  514. data/lib/rubocop/feature_loader.rb +94 -0
  515. data/lib/rubocop/formatter/clang_style_formatter.rb +1 -1
  516. data/lib/rubocop/formatter/disabled_config_formatter.rb +11 -8
  517. data/lib/rubocop/formatter/formatter_set.rb +20 -19
  518. data/lib/rubocop/formatter/git_hub_actions_formatter.rb +15 -2
  519. data/lib/rubocop/formatter/html_formatter.rb +3 -4
  520. data/lib/rubocop/formatter/markdown_formatter.rb +3 -1
  521. data/lib/rubocop/formatter/offense_count_formatter.rb +2 -0
  522. data/lib/rubocop/formatter/simple_text_formatter.rb +9 -8
  523. data/lib/rubocop/formatter/tap_formatter.rb +1 -1
  524. data/lib/rubocop/formatter.rb +31 -0
  525. data/lib/rubocop/magic_comment.rb +27 -2
  526. data/lib/rubocop/options.rb +81 -39
  527. data/lib/rubocop/rake_task.rb +34 -9
  528. data/lib/rubocop/result_cache.rb +24 -21
  529. data/lib/rubocop/rspec/cop_helper.rb +1 -1
  530. data/lib/rubocop/rspec/expect_offense.rb +3 -3
  531. data/lib/rubocop/rspec/shared_contexts.rb +29 -9
  532. data/lib/rubocop/rspec/support.rb +14 -0
  533. data/lib/rubocop/runner.rb +13 -5
  534. data/lib/rubocop/server/cache.rb +144 -0
  535. data/lib/rubocop/server/cli.rb +121 -0
  536. data/lib/rubocop/server/client_command/base.rb +44 -0
  537. data/lib/rubocop/server/client_command/exec.rb +59 -0
  538. data/lib/rubocop/server/client_command/restart.rb +25 -0
  539. data/lib/rubocop/server/client_command/start.rb +43 -0
  540. data/lib/rubocop/server/client_command/status.rb +28 -0
  541. data/lib/rubocop/server/client_command/stop.rb +31 -0
  542. data/lib/rubocop/server/client_command.rb +26 -0
  543. data/lib/rubocop/server/core.rb +79 -0
  544. data/lib/rubocop/server/errors.rb +23 -0
  545. data/lib/rubocop/server/helper.rb +34 -0
  546. data/lib/rubocop/server/server_command/base.rb +50 -0
  547. data/lib/rubocop/server/server_command/exec.rb +34 -0
  548. data/lib/rubocop/server/server_command/stop.rb +24 -0
  549. data/lib/rubocop/server/server_command.rb +21 -0
  550. data/lib/rubocop/server/socket_reader.rb +65 -0
  551. data/lib/rubocop/server.rb +53 -0
  552. data/lib/rubocop/target_ruby.rb +7 -5
  553. data/lib/rubocop/version.rb +17 -9
  554. data/lib/rubocop.rb +18 -30
  555. metadata +60 -10
  556. data/lib/rubocop/cop/gemspec/date_assignment.rb +0 -49
  557. data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -52
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for duplicated instance (or singleton) method
6
+ # Checks for duplicated instance (or singleton) method
7
7
  # definitions.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for duplicate elements in Regexp character classes.
6
+ # Checks for duplicate elements in Regexp character classes.
7
7
  #
8
8
  # @example
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for duplicate `require`s and `require_relative`s.
6
+ # Checks for duplicate ``require``s and ``require_relative``s.
7
7
  #
8
8
  # @safety
9
9
  # This cop's autocorrection is unsafe because it may break the dependency order
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks that there are no repeated exceptions
6
+ # Checks that there are no repeated exceptions
7
7
  # used in 'rescue' expressions.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks if each_with_object is called with an immutable
6
+ # Checks if each_with_object is called with an immutable
7
7
  # argument. Since the argument is the object that the given block shall
8
8
  # make calls on to build something based on the enumerable that
9
9
  # each_with_object iterates over, an immutable argument makes no sense.
@@ -3,11 +3,11 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for odd `else` block layout - like
6
+ # Checks for odd `else` block layout - like
7
7
  # having an expression on the same line as the `else` keyword,
8
8
  # which is usually a mistake.
9
9
  #
10
- # Its auto-correction tweaks layout to keep the syntax. So, this auto-correction
10
+ # Its autocorrection tweaks layout to keep the syntax. So, this autocorrection
11
11
  # is compatible correction for bad case syntax, but if your code makes a mistake
12
12
  # with `elsif` and `else`, you will have to correct it manually.
13
13
  #
@@ -25,7 +25,7 @@ module RuboCop
25
25
  #
26
26
  # # good
27
27
  #
28
- # # This code is compatible with the bad case. It will be auto-corrected like this.
28
+ # # This code is compatible with the bad case. It will be autocorrected like this.
29
29
  # if something
30
30
  # # ...
31
31
  # else
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for blocks without a body.
6
+ # Checks for blocks without a body.
7
7
  # Such empty blocks are typically an oversight or we should provide a comment
8
8
  # be clearer what we're aiming for.
9
9
  #
@@ -63,7 +63,7 @@ module RuboCop
63
63
  class EmptyBlock < Base
64
64
  MSG = 'Empty block detected.'
65
65
 
66
- def on_block(node)
66
+ def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
67
67
  return if node.body
68
68
  return if allow_empty_lambdas? && lambda_or_proc?(node)
69
69
  return if cop_config['AllowComments'] && allow_comment?(node)
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for classes and metaclasses without a body.
6
+ # Checks for classes and metaclasses without a body.
7
7
  # Such empty classes and metaclasses are typically an oversight or we should provide a comment
8
8
  # to be clearer what we're aiming for.
9
9
  #
@@ -3,7 +3,15 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for the presence of `if`, `elsif` and `unless` branches without a body.
6
+ # Checks for the presence of `if`, `elsif` and `unless` branches without a body.
7
+ #
8
+ # NOTE: empty `else` branches are handled by `Style/EmptyElse`.
9
+ #
10
+ # @safety
11
+ # Autocorrection for this cop is not safe. The conditions for empty branches that
12
+ # the autocorrection removes may have side effects, or the logic in subsequent
13
+ # branches may change due to the removal of a previous condition.
14
+ #
7
15
  # @example
8
16
  # # bad
9
17
  # if condition
@@ -53,7 +61,9 @@ module RuboCop
53
61
  # end
54
62
  #
55
63
  class EmptyConditionalBody < Base
64
+ extend AutoCorrector
56
65
  include CommentsHelp
66
+ include RangeHelp
57
67
 
58
68
  MSG = 'Avoid `%<keyword>s` branches without a body.'
59
69
 
@@ -61,7 +71,91 @@ module RuboCop
61
71
  return if node.body
62
72
  return if cop_config['AllowComments'] && contains_comments?(node)
63
73
 
64
- add_offense(node, message: format(MSG, keyword: node.keyword))
74
+ add_offense(node, message: format(MSG, keyword: node.keyword)) do |corrector|
75
+ autocorrect(corrector, node)
76
+ end
77
+ end
78
+
79
+ private
80
+
81
+ def autocorrect(corrector, node)
82
+ remove_comments(corrector, node)
83
+ remove_empty_branch(corrector, node)
84
+ correct_other_branches(corrector, node)
85
+ end
86
+
87
+ def remove_comments(corrector, node)
88
+ comments_in_range(node).each do |comment|
89
+ range = range_by_whole_lines(comment.loc.expression, include_final_newline: true)
90
+ corrector.remove(range)
91
+ end
92
+ end
93
+
94
+ def remove_empty_branch(corrector, node)
95
+ corrector.remove(deletion_range(branch_range(node)))
96
+ end
97
+
98
+ def correct_other_branches(corrector, node)
99
+ return unless require_other_branches_correction?(node)
100
+
101
+ if node.else_branch.if_type?
102
+ # Replace an orphaned `elsif` with `if`
103
+ corrector.replace(node.else_branch.loc.keyword, 'if')
104
+ else
105
+ # Flip orphaned `else`
106
+ corrector.replace(node.loc.else, "#{node.inverse_keyword} #{node.condition.source}")
107
+ end
108
+ end
109
+
110
+ def require_other_branches_correction?(node)
111
+ return false unless node.if_type? && node.else_branch
112
+ return false if !empty_if_branch?(node) && node.elsif?
113
+
114
+ !empty_else_branch?(node)
115
+ end
116
+
117
+ def empty_if_branch?(node)
118
+ return false unless (parent = node.parent)
119
+ return true unless parent.if_type?
120
+ return true unless (if_branch = parent.if_branch)
121
+
122
+ if_branch.if_type? && !if_branch.body
123
+ end
124
+
125
+ def empty_else_branch?(node)
126
+ node.else_branch.if_type? && !node.else_branch.body
127
+ end
128
+
129
+ # rubocop:disable Metrics/AbcSize
130
+ def branch_range(node)
131
+ if node.loc.else
132
+ node.source_range.with(end_pos: node.loc.else.begin_pos - 1)
133
+ elsif all_branches_body_missing?(node)
134
+ if_node = node.ancestors.detect(&:if?)
135
+ node.source_range.with(end_pos: if_node.loc.end.end_pos)
136
+ else
137
+ node.source_range
138
+ end
139
+ end
140
+ # rubocop:enable Metrics/AbcSize
141
+
142
+ def all_branches_body_missing?(node)
143
+ return false unless node.parent&.if_type?
144
+
145
+ node.parent.branches.compact.empty?
146
+ end
147
+
148
+ def deletion_range(range)
149
+ # Collect a range between the start of the `if` node and the next relevant node,
150
+ # including final new line.
151
+ # Based on `RangeHelp#range_by_whole_lines` but allows the `if` to not start
152
+ # on the first column.
153
+ buffer = @processed_source.buffer
154
+
155
+ last_line = buffer.source_line(range.last_line)
156
+ end_offset = last_line.length - range.last_column + 1
157
+
158
+ range.adjust(end_pos: end_offset).intersect(buffer.source_range)
65
159
  end
66
160
  end
67
161
  end
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for empty `ensure` blocks
6
+ # Checks for empty `ensure` blocks
7
7
  #
8
8
  # @example
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for the presence of empty expressions.
6
+ # Checks for the presence of empty expressions.
7
7
  #
8
8
  # @example
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop enforces that Ruby source files are not empty.
6
+ # Enforces that Ruby source files are not empty.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for the presence of `in` pattern branches without a body.
6
+ # Checks for the presence of `in` pattern branches without a body.
7
7
  #
8
8
  # @example
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for empty interpolation.
6
+ # Checks for empty interpolation.
7
7
  #
8
8
  # @example
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for the presence of `when` branches without a body.
6
+ # Checks for the presence of `when` branches without a body.
7
7
  #
8
8
  # @example
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for `return` from an `ensure` block.
6
+ # Checks for `return` from an `ensure` block.
7
7
  # `return` from an ensure block is a dangerous code smell as it
8
8
  # will take precedence over any exception being raised,
9
9
  # and the exception will be silently thrown away as if it were rescued.
@@ -6,18 +6,18 @@ module RuboCop
6
6
  #
7
7
  # This cop emulates the following Ruby warnings in Ruby 2.6.
8
8
  #
9
+ # [source,console]
10
+ # ----
9
11
  # % cat example.rb
10
12
  # ERB.new('hi', nil, '-', '@output_buffer')
11
13
  # % ruby -rerb example.rb
12
- # example.rb:1: warning: Passing safe_level with the 2nd argument of
13
- # ERB.new is deprecated. Do not use it, and specify other arguments as
14
- # keyword arguments.
15
- # example.rb:1: warning: Passing trim_mode with the 3rd argument of
16
- # ERB.new is deprecated. Use keyword argument like
17
- # ERB.new(str, trim_mode:...) instead.
18
- # example.rb:1: warning: Passing eoutvar with the 4th argument of ERB.new
19
- # is deprecated. Use keyword argument like ERB.new(str, eoutvar: ...)
20
- # instead.
14
+ # example.rb:1: warning: Passing safe_level with the 2nd argument of ERB.new is
15
+ # deprecated. Do not use it, and specify other arguments as keyword arguments.
16
+ # example.rb:1: warning: Passing trim_mode with the 3rd argument of ERB.new is
17
+ # deprecated. Use keyword argument like ERB.new(str, trim_mode:...) instead.
18
+ # example.rb:1: warning: Passing eoutvar with the 4th argument of ERB.new is
19
+ # deprecated. Use keyword argument like ERB.new(str, eoutvar: ...) instead.
20
+ # ----
21
21
  #
22
22
  # Now non-keyword arguments other than first one are softly deprecated
23
23
  # and will be removed when Ruby 2.5 becomes EOL.
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop looks for uses of flip-flop operator
6
+ # Looks for uses of flip-flop operator
7
7
  # based on the Ruby Style Guide.
8
8
  #
9
9
  # Here is the history of flip-flops in Ruby.
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for the presence of precise comparison of floating point numbers.
6
+ # Checks for the presence of precise comparison of floating point numbers.
7
7
  #
8
8
  # Floating point values are inherently inaccurate, and comparing them for exact equality
9
9
  # is almost never the desired semantics. Comparison via the `==/!=` operators checks
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop identifies Float literals which are, like, really really really
6
+ # Identifies Float literals which are, like, really really really
7
7
  # really really really really really big. Too big. No-one needs Floats
8
8
  # that big. If you need a float that big, something is wrong with you.
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for the ordering of a method call where
6
+ # Checks for the ordering of a method call where
7
7
  # the receiver of the call is a HEREDOC.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for implicit string concatenation of string literals
6
+ # Checks for implicit string concatenation of string literals
7
7
  # which are on the same line.
8
8
  #
9
9
  # @example
@@ -8,7 +8,7 @@ module RuboCop
8
8
  #
9
9
  # NOTE: When the method is successful the return value of `IO.select` is `[[IO]]`,
10
10
  # and the return value of `io.wait_readable` and `io.wait_writable` are `self`.
11
- # They are not auto-corrected when assigning a return value because these types are different.
11
+ # They are not autocorrected when assigning a return value because these types are different.
12
12
  # It's up to user how to handle the return value.
13
13
  #
14
14
  # @safety
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for `private` or `protected` access modifiers which are
6
+ # Checks for `private` or `protected` access modifiers which are
7
7
  # applied to a singleton method. These access modifiers do not make
8
8
  # singleton methods private/protected. `private_class_method` can be
9
9
  # used for that.
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop looks for error classes inheriting from `Exception`.
6
+ # Looks for error classes inheriting from `Exception`.
7
7
  # It is configurable to suggest using either `StandardError` (default) or
8
8
  # `RuntimeError` instead.
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for interpolation in a single quoted string.
6
+ # Checks for interpolation in a single quoted string.
7
7
  #
8
8
  # @safety
9
9
  # This cop is generally safe, but is marked as unsafe because
@@ -24,7 +24,7 @@ module RuboCop
24
24
  class InterpolationCheck < Base
25
25
  extend AutoCorrector
26
26
 
27
- MSG = 'Interpolation in single quoted string detected. '\
27
+ MSG = 'Interpolation in single quoted string detected. ' \
28
28
  'Use double quoted strings if you need interpolation.'
29
29
 
30
30
  def on_str(node)
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks uses of lambda without a literal block.
6
+ # Checks uses of lambda without a literal block.
7
7
  # It emulates the following warning in Ruby 3.0:
8
8
  #
9
9
  # % ruby -vwe 'lambda(&proc {})'
@@ -12,7 +12,7 @@ module RuboCop
12
12
  # lambda instead
13
13
  #
14
14
  # This way, proc object is never converted to lambda.
15
- # Auto-correction replaces with compatible proc argument.
15
+ # Autocorrection replaces with compatible proc argument.
16
16
  #
17
17
  # @example
18
18
  #
@@ -3,10 +3,13 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for literals used as the conditions or as
6
+ # Checks for literals used as the conditions or as
7
7
  # operands in and/or expressions serving as the conditions of
8
8
  # if/while/until/case-when/case-in.
9
9
  #
10
+ # NOTE: Literals in `case-in` condition where the match variable is used in
11
+ # `in` are accepted as a pattern matching.
12
+ #
10
13
  # @example
11
14
  #
12
15
  # # bad
@@ -69,6 +72,8 @@ module RuboCop
69
72
 
70
73
  def on_case_match(case_match_node)
71
74
  if case_match_node.condition
75
+ return if case_match_node.descendants.any?(&:match_var_type?)
76
+
72
77
  check_case(case_match_node)
73
78
  else
74
79
  case_match_node.each_in_pattern do |in_pattern_node|
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for interpolated literals.
6
+ # Checks for interpolated literals.
7
7
  #
8
8
  # @example
9
9
  #
@@ -58,6 +58,7 @@ module RuboCop
58
58
  (node.str_type? && !node.loc.respond_to?(:begin)) || node.source_range.is?('__LINE__')
59
59
  end
60
60
 
61
+ # rubocop:disable Metrics/MethodLength
61
62
  def autocorrected_value(node)
62
63
  case node.type
63
64
  when :int
@@ -70,10 +71,13 @@ module RuboCop
70
71
  autocorrected_value_for_symbol(node)
71
72
  when :array
72
73
  autocorrected_value_for_array(node)
74
+ when :nil
75
+ ''
73
76
  else
74
77
  node.source.gsub('"', '\"')
75
78
  end
76
79
  end
80
+ # rubocop:enable Metrics/MethodLength
77
81
 
78
82
  def autocorrected_value_for_string(node)
79
83
  if node.source.start_with?("'", '%q')
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for uses of `begin...end while/until something`.
6
+ # Checks for uses of `begin...end while/until something`.
7
7
  #
8
8
  # @safety
9
9
  # The cop is unsafe because behavior can change in some cases, including
@@ -4,7 +4,7 @@
4
4
  module RuboCop
5
5
  module Cop
6
6
  module Lint
7
- # This cop checks that there is an `# rubocop:enable ...` statement
7
+ # Checks that there is an `# rubocop:enable ...` statement
8
8
  # after a `# rubocop:disable ...` statement. This will prevent leaving
9
9
  # cop disables on wide ranges of code, that latter contributors to
10
10
  # a file wouldn't be aware of.
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for the presence of constructors and lifecycle callbacks
6
+ # Checks for the presence of constructors and lifecycle callbacks
7
7
  # without calls to `super`.
8
8
  #
9
9
  # This cop does not consider `method_missing` (and `respond_to_missing?`)
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for nested method definitions.
6
+ # Checks for nested method definitions.
7
7
  #
8
8
  # @example
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for nested percent literals.
6
+ # Checks for nested percent literals.
7
7
  #
8
8
  # @example
9
9
  #
@@ -25,13 +25,8 @@ module RuboCop
25
25
  class NextWithoutAccumulator < Base
26
26
  MSG = 'Use `next` with an accumulator argument in a `reduce`.'
27
27
 
28
- # @!method on_body_of_reduce(node)
29
- def_node_matcher :on_body_of_reduce, <<~PATTERN
30
- (block (send _recv {:reduce :inject} !sym) _blockargs $(begin ...))
31
- PATTERN
32
-
33
28
  def on_block(node)
34
- on_body_of_reduce(node) do |body|
29
+ on_block_body_of_reduce(node) do |body|
35
30
  void_next = body.each_node(:next).find do |n|
36
31
  n.children.empty? && parent_block_node(n) == node
37
32
  end
@@ -40,11 +35,35 @@ module RuboCop
40
35
  end
41
36
  end
42
37
 
38
+ def on_numblock(node)
39
+ on_numblock_body_of_reduce(node) do |body|
40
+ void_next = body.each_node(:next).find do |n|
41
+ n.children.empty? && parent_numblock_node(n) == node
42
+ end
43
+
44
+ add_offense(void_next) if void_next
45
+ end
46
+ end
47
+
43
48
  private
44
49
 
50
+ # @!method on_block_body_of_reduce(node)
51
+ def_node_matcher :on_block_body_of_reduce, <<~PATTERN
52
+ (block (send _recv {:reduce :inject} !sym) _blockargs $(begin ...))
53
+ PATTERN
54
+
55
+ # @!method on_numblock_body_of_reduce(node)
56
+ def_node_matcher :on_numblock_body_of_reduce, <<~PATTERN
57
+ (numblock (send _recv {:reduce :inject} !sym) _argscount $(begin ...))
58
+ PATTERN
59
+
45
60
  def parent_block_node(node)
46
61
  node.each_ancestor(:block).first
47
62
  end
63
+
64
+ def parent_numblock_node(node)
65
+ node.each_ancestor(:numblock).first
66
+ end
48
67
  end
49
68
  end
50
69
  end