rubocop 1.29.1 → 1.36.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (557) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +5 -3
  3. data/config/default.yml +164 -26
  4. data/config/obsoletion.yml +25 -1
  5. data/exe/rubocop +15 -7
  6. data/lib/rubocop/cache_config.rb +29 -0
  7. data/lib/rubocop/cli/command/{auto_genenerate_config.rb → auto_generate_config.rb} +20 -5
  8. data/lib/rubocop/cli/command/execute_runner.rb +1 -1
  9. data/lib/rubocop/cli/command/init_dotfile.rb +1 -1
  10. data/lib/rubocop/cli/command/show_cops.rb +1 -1
  11. data/lib/rubocop/cli/command/suggest_extensions.rb +53 -15
  12. data/lib/rubocop/cli.rb +2 -0
  13. data/lib/rubocop/config.rb +6 -2
  14. data/lib/rubocop/config_finder.rb +68 -0
  15. data/lib/rubocop/config_loader.rb +15 -41
  16. data/lib/rubocop/config_loader_resolver.rb +2 -6
  17. data/lib/rubocop/config_obsoletion/changed_parameter.rb +5 -0
  18. data/lib/rubocop/config_obsoletion/parameter_rule.rb +4 -0
  19. data/lib/rubocop/config_obsoletion.rb +7 -2
  20. data/lib/rubocop/config_validator.rb +21 -4
  21. data/lib/rubocop/cop/autocorrect_logic.rb +4 -2
  22. data/lib/rubocop/cop/base.rb +6 -2
  23. data/lib/rubocop/cop/bundler/duplicated_gem.rb +1 -1
  24. data/lib/rubocop/cop/bundler/gem_filename.rb +5 -5
  25. data/lib/rubocop/cop/bundler/ordered_gems.rb +2 -2
  26. data/lib/rubocop/cop/cop.rb +1 -1
  27. data/lib/rubocop/cop/corrector.rb +2 -2
  28. data/lib/rubocop/cop/correctors/alignment_corrector.rb +1 -1
  29. data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -1
  30. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +1 -1
  31. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
  32. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +4 -2
  33. data/lib/rubocop/cop/correctors/if_then_corrector.rb +1 -1
  34. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +1 -1
  35. data/lib/rubocop/cop/correctors/line_break_corrector.rb +7 -1
  36. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +3 -3
  37. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +1 -1
  38. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +59 -1
  39. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
  40. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
  41. data/lib/rubocop/cop/correctors/space_corrector.rb +1 -1
  42. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +1 -1
  43. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +2 -2
  44. data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
  45. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +1 -1
  46. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +1 -1
  47. data/lib/rubocop/cop/gemspec/require_mfa.rb +21 -21
  48. data/lib/rubocop/cop/generator/require_file_injector.rb +2 -2
  49. data/lib/rubocop/cop/generator.rb +5 -1
  50. data/lib/rubocop/cop/internal_affairs/cop_description.rb +96 -0
  51. data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +1 -1
  52. data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +1 -1
  53. data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +1 -1
  54. data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +1 -5
  55. data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
  56. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +1 -1
  57. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +1 -1
  58. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
  59. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -1
  60. data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
  61. data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
  62. data/lib/rubocop/cop/internal_affairs.rb +4 -0
  63. data/lib/rubocop/cop/layout/argument_alignment.rb +22 -1
  64. data/lib/rubocop/cop/layout/assignment_indentation.rb +1 -1
  65. data/lib/rubocop/cop/layout/begin_end_alignment.rb +1 -1
  66. data/lib/rubocop/cop/layout/block_alignment.rb +17 -13
  67. data/lib/rubocop/cop/layout/block_end_newline.rb +36 -6
  68. data/lib/rubocop/cop/layout/case_indentation.rb +1 -1
  69. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -1
  70. data/lib/rubocop/cop/layout/comment_indentation.rb +1 -1
  71. data/lib/rubocop/cop/layout/condition_position.rb +1 -1
  72. data/lib/rubocop/cop/layout/def_end_alignment.rb +1 -1
  73. data/lib/rubocop/cop/layout/dot_position.rb +1 -1
  74. data/lib/rubocop/cop/layout/else_alignment.rb +1 -1
  75. data/lib/rubocop/cop/layout/empty_comment.rb +2 -2
  76. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +1 -1
  77. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +1 -1
  78. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +1 -1
  79. data/lib/rubocop/cop/layout/empty_lines.rb +1 -1
  80. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +5 -2
  81. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +1 -1
  82. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +25 -4
  83. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +1 -1
  84. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +7 -5
  85. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +10 -10
  86. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +1 -1
  87. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +1 -1
  88. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +10 -10
  89. data/lib/rubocop/cop/layout/end_alignment.rb +1 -1
  90. data/lib/rubocop/cop/layout/end_of_line.rb +5 -5
  91. data/lib/rubocop/cop/layout/extra_spacing.rb +1 -1
  92. data/lib/rubocop/cop/layout/first_argument_indentation.rb +34 -29
  93. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +21 -14
  94. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +1 -1
  95. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +52 -13
  96. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +1 -1
  97. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +1 -1
  98. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +1 -1
  99. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +1 -1
  100. data/lib/rubocop/cop/layout/hash_alignment.rb +2 -0
  101. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +1 -1
  102. data/lib/rubocop/cop/layout/heredoc_indentation.rb +1 -1
  103. data/lib/rubocop/cop/layout/indentation_consistency.rb +1 -1
  104. data/lib/rubocop/cop/layout/indentation_style.rb +1 -1
  105. data/lib/rubocop/cop/layout/indentation_width.rb +13 -6
  106. data/lib/rubocop/cop/layout/initial_indentation.rb +2 -2
  107. data/lib/rubocop/cop/layout/leading_comment_space.rb +1 -1
  108. data/lib/rubocop/cop/layout/leading_empty_lines.rb +1 -1
  109. data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +112 -0
  110. data/lib/rubocop/cop/layout/line_continuation_spacing.rb +130 -0
  111. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +1 -1
  112. data/lib/rubocop/cop/layout/line_length.rb +7 -2
  113. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +1 -1
  114. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +1 -1
  115. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +2 -2
  116. data/lib/rubocop/cop/layout/multiline_block_layout.rb +4 -2
  117. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +1 -1
  118. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +1 -1
  119. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +5 -2
  120. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +1 -1
  121. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +3 -3
  122. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +1 -1
  123. data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +45 -0
  124. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +3 -3
  125. data/lib/rubocop/cop/layout/redundant_line_break.rb +2 -2
  126. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +1 -1
  127. data/lib/rubocop/cop/layout/single_line_block_chain.rb +1 -1
  128. data/lib/rubocop/cop/layout/space_after_not.rb +1 -1
  129. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +2 -2
  130. data/lib/rubocop/cop/layout/space_around_keyword.rb +1 -1
  131. data/lib/rubocop/cop/layout/space_around_operators.rb +1 -1
  132. data/lib/rubocop/cop/layout/space_before_block_braces.rb +5 -3
  133. data/lib/rubocop/cop/layout/space_before_comment.rb +1 -1
  134. data/lib/rubocop/cop/layout/space_before_first_arg.rb +1 -1
  135. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +1 -1
  136. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +10 -10
  137. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +33 -15
  138. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +1 -1
  139. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +8 -8
  140. data/lib/rubocop/cop/layout/trailing_whitespace.rb +2 -2
  141. data/lib/rubocop/cop/legacy/corrections_proxy.rb +1 -1
  142. data/lib/rubocop/cop/legacy/corrector.rb +1 -1
  143. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +1 -1
  144. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +27 -7
  145. data/lib/rubocop/cop/lint/ambiguous_operator.rb +1 -1
  146. data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +1 -1
  147. data/lib/rubocop/cop/lint/ambiguous_range.rb +3 -3
  148. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +1 -1
  149. data/lib/rubocop/cop/lint/assignment_in_condition.rb +1 -1
  150. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +1 -1
  151. data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -1
  152. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  153. data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
  154. data/lib/rubocop/cop/lint/debugger.rb +27 -17
  155. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +15 -9
  156. data/lib/rubocop/cop/lint/deprecated_constants.rb +1 -1
  157. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +1 -1
  158. data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -1
  159. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  160. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +1 -1
  161. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
  162. data/lib/rubocop/cop/lint/duplicate_methods.rb +1 -1
  163. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +1 -1
  164. data/lib/rubocop/cop/lint/duplicate_require.rb +1 -1
  165. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +1 -1
  166. data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
  167. data/lib/rubocop/cop/lint/else_layout.rb +3 -3
  168. data/lib/rubocop/cop/lint/empty_block.rb +2 -2
  169. data/lib/rubocop/cop/lint/empty_class.rb +1 -1
  170. data/lib/rubocop/cop/lint/empty_conditional_body.rb +96 -2
  171. data/lib/rubocop/cop/lint/empty_ensure.rb +1 -1
  172. data/lib/rubocop/cop/lint/empty_expression.rb +1 -1
  173. data/lib/rubocop/cop/lint/empty_file.rb +1 -1
  174. data/lib/rubocop/cop/lint/empty_in_pattern.rb +1 -1
  175. data/lib/rubocop/cop/lint/empty_interpolation.rb +1 -1
  176. data/lib/rubocop/cop/lint/empty_when.rb +1 -1
  177. data/lib/rubocop/cop/lint/ensure_return.rb +1 -1
  178. data/lib/rubocop/cop/lint/erb_new_arguments.rb +9 -9
  179. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  180. data/lib/rubocop/cop/lint/float_comparison.rb +1 -1
  181. data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
  182. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +1 -1
  183. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +1 -1
  184. data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +1 -1
  185. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -1
  186. data/lib/rubocop/cop/lint/inherit_exception.rb +1 -1
  187. data/lib/rubocop/cop/lint/interpolation_check.rb +2 -2
  188. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +2 -2
  189. data/lib/rubocop/cop/lint/literal_as_condition.rb +6 -1
  190. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +5 -1
  191. data/lib/rubocop/cop/lint/loop.rb +1 -1
  192. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +1 -1
  193. data/lib/rubocop/cop/lint/missing_super.rb +1 -1
  194. data/lib/rubocop/cop/lint/nested_method_definition.rb +1 -1
  195. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
  196. data/lib/rubocop/cop/lint/next_without_accumulator.rb +25 -6
  197. data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +157 -0
  198. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +12 -0
  199. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
  200. data/lib/rubocop/cop/lint/number_conversion.rb +32 -10
  201. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +1 -1
  202. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +2 -3
  203. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +1 -1
  204. data/lib/rubocop/cop/lint/percent_string_array.rb +1 -1
  205. data/lib/rubocop/cop/lint/percent_symbol_array.rb +1 -1
  206. data/lib/rubocop/cop/lint/raise_exception.rb +1 -1
  207. data/lib/rubocop/cop/lint/rand_one.rb +1 -1
  208. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +6 -6
  209. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +2 -2
  210. data/lib/rubocop/cop/lint/redundant_require_statement.rb +4 -1
  211. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +16 -3
  212. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +1 -1
  213. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -1
  214. data/lib/rubocop/cop/lint/redundant_with_index.rb +14 -11
  215. data/lib/rubocop/cop/lint/redundant_with_object.rb +13 -12
  216. data/lib/rubocop/cop/lint/refinement_import_methods.rb +1 -1
  217. data/lib/rubocop/cop/lint/regexp_as_condition.rb +3 -3
  218. data/lib/rubocop/cop/lint/require_parentheses.rb +1 -1
  219. data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
  220. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  221. data/lib/rubocop/cop/lint/return_in_void_context.rb +1 -1
  222. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +38 -1
  223. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +1 -1
  224. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
  225. data/lib/rubocop/cop/lint/script_permission.rb +1 -1
  226. data/lib/rubocop/cop/lint/self_assignment.rb +1 -1
  227. data/lib/rubocop/cop/lint/shadowed_argument.rb +1 -1
  228. data/lib/rubocop/cop/lint/shadowed_exception.rb +16 -1
  229. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +25 -4
  230. data/lib/rubocop/cop/lint/struct_new_override.rb +3 -3
  231. data/lib/rubocop/cop/lint/suppressed_exception.rb +1 -1
  232. data/lib/rubocop/cop/lint/symbol_conversion.rb +1 -1
  233. data/lib/rubocop/cop/lint/syntax.rb +1 -1
  234. data/lib/rubocop/cop/lint/to_enum_arguments.rb +1 -1
  235. data/lib/rubocop/cop/lint/to_json.rb +1 -1
  236. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
  237. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +2 -2
  238. data/lib/rubocop/cop/lint/triple_quotes.rb +1 -1
  239. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +1 -1
  240. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +1 -1
  241. data/lib/rubocop/cop/lint/unified_integer.rb +3 -1
  242. data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
  243. data/lib/rubocop/cop/lint/unreachable_loop.rb +9 -3
  244. data/lib/rubocop/cop/lint/unused_block_argument.rb +1 -1
  245. data/lib/rubocop/cop/lint/unused_method_argument.rb +1 -1
  246. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
  247. data/lib/rubocop/cop/lint/uri_regexp.rb +1 -1
  248. data/lib/rubocop/cop/lint/useless_access_modifier.rb +9 -7
  249. data/lib/rubocop/cop/lint/useless_assignment.rb +1 -1
  250. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +44 -0
  251. data/lib/rubocop/cop/lint/useless_method_definition.rb +1 -1
  252. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +2 -2
  253. data/lib/rubocop/cop/lint/useless_setter_call.rb +2 -2
  254. data/lib/rubocop/cop/lint/useless_times.rb +1 -1
  255. data/lib/rubocop/cop/lint/void.rb +3 -1
  256. data/lib/rubocop/cop/metrics/abc_size.rb +4 -2
  257. data/lib/rubocop/cop/metrics/block_length.rb +7 -7
  258. data/lib/rubocop/cop/metrics/block_nesting.rb +1 -1
  259. data/lib/rubocop/cop/metrics/class_length.rb +1 -1
  260. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +1 -1
  261. data/lib/rubocop/cop/metrics/method_length.rb +9 -8
  262. data/lib/rubocop/cop/metrics/module_length.rb +1 -1
  263. data/lib/rubocop/cop/metrics/parameter_lists.rb +1 -1
  264. data/lib/rubocop/cop/metrics/perceived_complexity.rb +1 -1
  265. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +1 -1
  266. data/lib/rubocop/cop/mixin/allowed_methods.rb +20 -1
  267. data/lib/rubocop/cop/mixin/allowed_pattern.rb +17 -1
  268. data/lib/rubocop/cop/mixin/check_line_breakable.rb +5 -1
  269. data/lib/rubocop/cop/mixin/comments_help.rb +5 -1
  270. data/lib/rubocop/cop/mixin/def_node.rb +2 -7
  271. data/lib/rubocop/cop/mixin/enforce_superclass.rb +2 -1
  272. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +82 -2
  273. data/lib/rubocop/cop/mixin/hash_transform_method.rb +10 -6
  274. data/lib/rubocop/cop/mixin/method_complexity.rb +8 -13
  275. data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +34 -12
  276. data/lib/rubocop/cop/mixin/percent_array.rb +60 -1
  277. data/lib/rubocop/cop/mixin/range_help.rb +10 -7
  278. data/lib/rubocop/cop/mixin/string_help.rb +1 -1
  279. data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
  280. data/lib/rubocop/cop/naming/ascii_identifiers.rb +1 -1
  281. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
  282. data/lib/rubocop/cop/naming/block_forwarding.rb +2 -2
  283. data/lib/rubocop/cop/naming/block_parameter_name.rb +2 -2
  284. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +1 -1
  285. data/lib/rubocop/cop/naming/constant_name.rb +3 -3
  286. data/lib/rubocop/cop/naming/file_name.rb +1 -1
  287. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +1 -1
  288. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +1 -1
  289. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +1 -1
  290. data/lib/rubocop/cop/naming/method_name.rb +1 -1
  291. data/lib/rubocop/cop/naming/method_parameter_name.rb +1 -1
  292. data/lib/rubocop/cop/naming/predicate_name.rb +30 -1
  293. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +1 -1
  294. data/lib/rubocop/cop/naming/variable_name.rb +1 -1
  295. data/lib/rubocop/cop/naming/variable_number.rb +18 -18
  296. data/lib/rubocop/cop/security/compound_hash.rb +1 -1
  297. data/lib/rubocop/cop/security/eval.rb +1 -1
  298. data/lib/rubocop/cop/security/json_load.rb +1 -1
  299. data/lib/rubocop/cop/security/marshal_load.rb +1 -1
  300. data/lib/rubocop/cop/security/open.rb +1 -1
  301. data/lib/rubocop/cop/security/yaml_load.rb +1 -1
  302. data/lib/rubocop/cop/style/access_modifier_declarations.rb +77 -1
  303. data/lib/rubocop/cop/style/accessor_grouping.rb +4 -4
  304. data/lib/rubocop/cop/style/alias.rb +1 -1
  305. data/lib/rubocop/cop/style/and_or.rb +11 -11
  306. data/lib/rubocop/cop/style/arguments_forwarding.rb +3 -3
  307. data/lib/rubocop/cop/style/array_coercion.rb +1 -1
  308. data/lib/rubocop/cop/style/array_join.rb +1 -1
  309. data/lib/rubocop/cop/style/ascii_comments.rb +1 -1
  310. data/lib/rubocop/cop/style/attr.rb +1 -1
  311. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +1 -1
  312. data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
  313. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +1 -1
  314. data/lib/rubocop/cop/style/block_comments.rb +1 -1
  315. data/lib/rubocop/cop/style/block_delimiters.rb +30 -9
  316. data/lib/rubocop/cop/style/case_equality.rb +41 -11
  317. data/lib/rubocop/cop/style/case_like_if.rb +1 -1
  318. data/lib/rubocop/cop/style/class_and_module_children.rb +5 -5
  319. data/lib/rubocop/cop/style/class_check.rb +1 -1
  320. data/lib/rubocop/cop/style/class_equality_comparison.rb +51 -4
  321. data/lib/rubocop/cop/style/class_methods.rb +1 -1
  322. data/lib/rubocop/cop/style/class_methods_definitions.rb +3 -2
  323. data/lib/rubocop/cop/style/class_vars.rb +1 -1
  324. data/lib/rubocop/cop/style/collection_compact.rb +1 -1
  325. data/lib/rubocop/cop/style/collection_methods.rb +3 -1
  326. data/lib/rubocop/cop/style/colon_method_call.rb +1 -1
  327. data/lib/rubocop/cop/style/colon_method_definition.rb +1 -1
  328. data/lib/rubocop/cop/style/combinable_loops.rb +4 -2
  329. data/lib/rubocop/cop/style/command_literal.rb +1 -1
  330. data/lib/rubocop/cop/style/comment_annotation.rb +1 -1
  331. data/lib/rubocop/cop/style/commented_keyword.rb +4 -4
  332. data/lib/rubocop/cop/style/conditional_assignment.rb +2 -1
  333. data/lib/rubocop/cop/style/constant_visibility.rb +1 -1
  334. data/lib/rubocop/cop/style/date_time.rb +1 -1
  335. data/lib/rubocop/cop/style/def_with_parentheses.rb +1 -1
  336. data/lib/rubocop/cop/style/dir.rb +4 -1
  337. data/lib/rubocop/cop/style/documentation.rb +1 -1
  338. data/lib/rubocop/cop/style/documentation_method.rb +1 -1
  339. data/lib/rubocop/cop/style/double_negation.rb +3 -1
  340. data/lib/rubocop/cop/style/each_for_simple_loop.rb +42 -7
  341. data/lib/rubocop/cop/style/each_with_object.rb +40 -9
  342. data/lib/rubocop/cop/style/empty_block_parameter.rb +2 -2
  343. data/lib/rubocop/cop/style/empty_case_condition.rb +1 -1
  344. data/lib/rubocop/cop/style/empty_else.rb +40 -3
  345. data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
  346. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +2 -2
  347. data/lib/rubocop/cop/style/empty_literal.rb +1 -1
  348. data/lib/rubocop/cop/style/empty_method.rb +17 -2
  349. data/lib/rubocop/cop/style/encoding.rb +2 -2
  350. data/lib/rubocop/cop/style/end_block.rb +1 -1
  351. data/lib/rubocop/cop/style/endless_method.rb +1 -1
  352. data/lib/rubocop/cop/style/env_home.rb +1 -1
  353. data/lib/rubocop/cop/style/eval_with_location.rb +1 -1
  354. data/lib/rubocop/cop/style/even_odd.rb +1 -1
  355. data/lib/rubocop/cop/style/expand_path_arguments.rb +1 -1
  356. data/lib/rubocop/cop/style/explicit_block_argument.rb +2 -2
  357. data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
  358. data/lib/rubocop/cop/style/fetch_env_var.rb +37 -224
  359. data/lib/rubocop/cop/style/float_division.rb +1 -1
  360. data/lib/rubocop/cop/style/for.rb +3 -1
  361. data/lib/rubocop/cop/style/format_string.rb +1 -1
  362. data/lib/rubocop/cop/style/format_string_token.rb +73 -23
  363. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +6 -3
  364. data/lib/rubocop/cop/style/global_std_stream.rb +1 -1
  365. data/lib/rubocop/cop/style/global_vars.rb +1 -1
  366. data/lib/rubocop/cop/style/guard_clause.rb +35 -22
  367. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +1 -1
  368. data/lib/rubocop/cop/style/hash_conversion.rb +1 -1
  369. data/lib/rubocop/cop/style/hash_each_methods.rb +4 -2
  370. data/lib/rubocop/cop/style/hash_except.rb +85 -9
  371. data/lib/rubocop/cop/style/hash_like_case.rb +1 -1
  372. data/lib/rubocop/cop/style/hash_syntax.rb +20 -3
  373. data/lib/rubocop/cop/style/hash_transform_keys.rb +6 -1
  374. data/lib/rubocop/cop/style/hash_transform_values.rb +4 -1
  375. data/lib/rubocop/cop/style/identical_conditional_branches.rb +2 -2
  376. data/lib/rubocop/cop/style/if_unless_modifier.rb +1 -1
  377. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +4 -2
  378. data/lib/rubocop/cop/style/implicit_runtime_error.rb +3 -3
  379. data/lib/rubocop/cop/style/in_pattern_then.rb +1 -1
  380. data/lib/rubocop/cop/style/inline_comment.rb +1 -1
  381. data/lib/rubocop/cop/style/inverse_methods.rb +10 -8
  382. data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
  383. data/lib/rubocop/cop/style/keyword_parameters_order.rb +2 -2
  384. data/lib/rubocop/cop/style/lambda.rb +1 -1
  385. data/lib/rubocop/cop/style/lambda_call.rb +1 -1
  386. data/lib/rubocop/cop/style/line_end_concatenation.rb +2 -2
  387. data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
  388. data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
  389. data/lib/rubocop/cop/style/map_to_hash.rb +3 -3
  390. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +4 -4
  391. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +5 -1
  392. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +8 -8
  393. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +20 -3
  394. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +5 -2
  395. data/lib/rubocop/cop/style/method_def_parentheses.rb +1 -1
  396. data/lib/rubocop/cop/style/min_max.rb +1 -1
  397. data/lib/rubocop/cop/style/missing_else.rb +24 -24
  398. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +1 -1
  399. data/lib/rubocop/cop/style/mixin_grouping.rb +1 -1
  400. data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
  401. data/lib/rubocop/cop/style/module_function.rb +3 -3
  402. data/lib/rubocop/cop/style/multiline_block_chain.rb +4 -2
  403. data/lib/rubocop/cop/style/multiline_if_modifier.rb +2 -2
  404. data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
  405. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +3 -5
  406. data/lib/rubocop/cop/style/multiline_memoization.rb +1 -1
  407. data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
  408. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +3 -3
  409. data/lib/rubocop/cop/style/multiline_when_then.rb +2 -4
  410. data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
  411. data/lib/rubocop/cop/style/mutable_constant.rb +1 -1
  412. data/lib/rubocop/cop/style/negated_if_else_condition.rb +1 -1
  413. data/lib/rubocop/cop/style/nested_file_dirname.rb +1 -1
  414. data/lib/rubocop/cop/style/nested_modifier.rb +1 -1
  415. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +11 -2
  416. data/lib/rubocop/cop/style/nested_ternary_operator.rb +20 -8
  417. data/lib/rubocop/cop/style/next.rb +3 -5
  418. data/lib/rubocop/cop/style/nil_comparison.rb +1 -1
  419. data/lib/rubocop/cop/style/nil_lambda.rb +3 -3
  420. data/lib/rubocop/cop/style/non_nil_check.rb +1 -1
  421. data/lib/rubocop/cop/style/not.rb +2 -2
  422. data/lib/rubocop/cop/style/numbered_parameters.rb +1 -1
  423. data/lib/rubocop/cop/style/numbered_parameters_limit.rb +1 -1
  424. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +1 -1
  425. data/lib/rubocop/cop/style/numeric_literals.rb +16 -1
  426. data/lib/rubocop/cop/style/numeric_predicate.rb +53 -11
  427. data/lib/rubocop/cop/style/object_then.rb +3 -1
  428. data/lib/rubocop/cop/style/one_line_conditional.rb +1 -1
  429. data/lib/rubocop/cop/style/open_struct_use.rb +1 -1
  430. data/lib/rubocop/cop/style/option_hash.rb +1 -1
  431. data/lib/rubocop/cop/style/optional_arguments.rb +1 -1
  432. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +1 -1
  433. data/lib/rubocop/cop/style/or_assignment.rb +1 -1
  434. data/lib/rubocop/cop/style/parentheses_around_condition.rb +1 -1
  435. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -1
  436. data/lib/rubocop/cop/style/percent_q_literals.rb +1 -1
  437. data/lib/rubocop/cop/style/perl_backrefs.rb +23 -2
  438. data/lib/rubocop/cop/style/preferred_hash_methods.rb +1 -1
  439. data/lib/rubocop/cop/style/proc.rb +5 -2
  440. data/lib/rubocop/cop/style/raise_args.rb +1 -1
  441. data/lib/rubocop/cop/style/random_with_offset.rb +1 -1
  442. data/lib/rubocop/cop/style/redundant_argument.rb +2 -2
  443. data/lib/rubocop/cop/style/redundant_assignment.rb +1 -1
  444. data/lib/rubocop/cop/style/redundant_begin.rb +19 -6
  445. data/lib/rubocop/cop/style/redundant_capital_w.rb +1 -1
  446. data/lib/rubocop/cop/style/redundant_condition.rb +28 -9
  447. data/lib/rubocop/cop/style/redundant_conditional.rb +1 -1
  448. data/lib/rubocop/cop/style/redundant_exception.rb +1 -1
  449. data/lib/rubocop/cop/style/redundant_fetch_block.rb +2 -2
  450. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +1 -1
  451. data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
  452. data/lib/rubocop/cop/style/redundant_interpolation.rb +22 -1
  453. data/lib/rubocop/cop/style/redundant_parentheses.rb +22 -24
  454. data/lib/rubocop/cop/style/redundant_percent_q.rb +1 -1
  455. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +2 -2
  456. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +1 -1
  457. data/lib/rubocop/cop/style/redundant_return.rb +2 -2
  458. data/lib/rubocop/cop/style/redundant_self.rb +3 -1
  459. data/lib/rubocop/cop/style/redundant_self_assignment.rb +2 -2
  460. data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +1 -1
  461. data/lib/rubocop/cop/style/redundant_sort.rb +22 -7
  462. data/lib/rubocop/cop/style/redundant_sort_by.rb +25 -9
  463. data/lib/rubocop/cop/style/regexp_literal.rb +1 -1
  464. data/lib/rubocop/cop/style/rescue_modifier.rb +1 -1
  465. data/lib/rubocop/cop/style/rescue_standard_error.rb +13 -13
  466. data/lib/rubocop/cop/style/return_nil.rb +1 -1
  467. data/lib/rubocop/cop/style/safe_navigation.rb +8 -3
  468. data/lib/rubocop/cop/style/sample.rb +1 -1
  469. data/lib/rubocop/cop/style/select_by_regexp.rb +1 -1
  470. data/lib/rubocop/cop/style/self_assignment.rb +1 -1
  471. data/lib/rubocop/cop/style/semicolon.rb +28 -4
  472. data/lib/rubocop/cop/style/send.rb +1 -1
  473. data/lib/rubocop/cop/style/signal_exception.rb +1 -1
  474. data/lib/rubocop/cop/style/single_line_block_params.rb +2 -2
  475. data/lib/rubocop/cop/style/single_line_methods.rb +2 -2
  476. data/lib/rubocop/cop/style/slicing_with_range.rb +1 -1
  477. data/lib/rubocop/cop/style/sole_nested_conditional.rb +42 -14
  478. data/lib/rubocop/cop/style/static_class.rb +1 -1
  479. data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
  480. data/lib/rubocop/cop/style/string_concatenation.rb +6 -7
  481. data/lib/rubocop/cop/style/string_hash_keys.rb +1 -1
  482. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +1 -1
  483. data/lib/rubocop/cop/style/string_methods.rb +1 -1
  484. data/lib/rubocop/cop/style/strip.rb +1 -1
  485. data/lib/rubocop/cop/style/struct_inheritance.rb +4 -4
  486. data/lib/rubocop/cop/style/swap_values.rb +2 -2
  487. data/lib/rubocop/cop/style/symbol_array.rb +9 -6
  488. data/lib/rubocop/cop/style/symbol_literal.rb +1 -1
  489. data/lib/rubocop/cop/style/symbol_proc.rb +48 -14
  490. data/lib/rubocop/cop/style/ternary_parentheses.rb +2 -14
  491. data/lib/rubocop/cop/style/top_level_method_definition.rb +3 -1
  492. data/lib/rubocop/cop/style/trailing_body_on_class.rb +1 -1
  493. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -1
  494. data/lib/rubocop/cop/style/trailing_body_on_module.rb +1 -1
  495. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +1 -1
  496. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +1 -1
  497. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +2 -2
  498. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +1 -1
  499. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +1 -1
  500. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +1 -1
  501. data/lib/rubocop/cop/style/trivial_accessors.rb +4 -1
  502. data/lib/rubocop/cop/style/unless_else.rb +1 -1
  503. data/lib/rubocop/cop/style/unless_logical_operators.rb +1 -1
  504. data/lib/rubocop/cop/style/unpack_first.rb +5 -2
  505. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  506. data/lib/rubocop/cop/style/when_then.rb +1 -1
  507. data/lib/rubocop/cop/style/word_array.rb +4 -5
  508. data/lib/rubocop/cop/style/yoda_condition.rb +1 -1
  509. data/lib/rubocop/cop/style/zero_length_predicate.rb +1 -1
  510. data/lib/rubocop/cop/team.rb +2 -2
  511. data/lib/rubocop/cop/util.rb +3 -3
  512. data/lib/rubocop/cops_documentation_generator.rb +18 -1
  513. data/lib/rubocop/ext/range.rb +15 -0
  514. data/lib/rubocop/feature_loader.rb +94 -0
  515. data/lib/rubocop/formatter/clang_style_formatter.rb +1 -1
  516. data/lib/rubocop/formatter/disabled_config_formatter.rb +11 -8
  517. data/lib/rubocop/formatter/formatter_set.rb +20 -19
  518. data/lib/rubocop/formatter/git_hub_actions_formatter.rb +15 -2
  519. data/lib/rubocop/formatter/html_formatter.rb +3 -4
  520. data/lib/rubocop/formatter/markdown_formatter.rb +3 -1
  521. data/lib/rubocop/formatter/offense_count_formatter.rb +2 -0
  522. data/lib/rubocop/formatter/simple_text_formatter.rb +9 -8
  523. data/lib/rubocop/formatter/tap_formatter.rb +1 -1
  524. data/lib/rubocop/formatter.rb +31 -0
  525. data/lib/rubocop/magic_comment.rb +27 -2
  526. data/lib/rubocop/options.rb +81 -39
  527. data/lib/rubocop/rake_task.rb +34 -9
  528. data/lib/rubocop/result_cache.rb +24 -21
  529. data/lib/rubocop/rspec/cop_helper.rb +1 -1
  530. data/lib/rubocop/rspec/expect_offense.rb +3 -3
  531. data/lib/rubocop/rspec/shared_contexts.rb +29 -9
  532. data/lib/rubocop/rspec/support.rb +14 -0
  533. data/lib/rubocop/runner.rb +13 -5
  534. data/lib/rubocop/server/cache.rb +144 -0
  535. data/lib/rubocop/server/cli.rb +121 -0
  536. data/lib/rubocop/server/client_command/base.rb +44 -0
  537. data/lib/rubocop/server/client_command/exec.rb +59 -0
  538. data/lib/rubocop/server/client_command/restart.rb +25 -0
  539. data/lib/rubocop/server/client_command/start.rb +43 -0
  540. data/lib/rubocop/server/client_command/status.rb +28 -0
  541. data/lib/rubocop/server/client_command/stop.rb +31 -0
  542. data/lib/rubocop/server/client_command.rb +26 -0
  543. data/lib/rubocop/server/core.rb +79 -0
  544. data/lib/rubocop/server/errors.rb +23 -0
  545. data/lib/rubocop/server/helper.rb +34 -0
  546. data/lib/rubocop/server/server_command/base.rb +50 -0
  547. data/lib/rubocop/server/server_command/exec.rb +34 -0
  548. data/lib/rubocop/server/server_command/stop.rb +24 -0
  549. data/lib/rubocop/server/server_command.rb +21 -0
  550. data/lib/rubocop/server/socket_reader.rb +65 -0
  551. data/lib/rubocop/server.rb +53 -0
  552. data/lib/rubocop/target_ruby.rb +7 -5
  553. data/lib/rubocop/version.rb +17 -9
  554. data/lib/rubocop.rb +18 -30
  555. metadata +60 -10
  556. data/lib/rubocop/cop/gemspec/date_assignment.rb +0 -49
  557. data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -52
@@ -130,13 +130,7 @@ module RuboCop
130
130
  def correct_from_unless_to_if(corrector, node, is_modify_form: false)
131
131
  corrector.replace(node.loc.keyword, 'if')
132
132
 
133
- condition = node.condition
134
- if (condition.send_type? && condition.comparison_method? && !condition.parenthesized?) ||
135
- (is_modify_form && wrap_condition?(condition))
136
- corrector.wrap(node.condition, '!(', ')')
137
- else
138
- corrector.insert_before(node.condition, '!')
139
- end
133
+ insert_bang(corrector, node, is_modify_form)
140
134
  end
141
135
 
142
136
  def correct_for_guard_condition_style(corrector, outer_condition, if_branch, and_operator)
@@ -144,7 +138,7 @@ module RuboCop
144
138
  corrector.insert_after(outer_condition, "#{and_operator}#{replace_condition(condition)}")
145
139
 
146
140
  range = range_between(if_branch.loc.keyword.begin_pos, condition.source_range.end_pos)
147
- corrector.remove(range_with_surrounding_space(range: range, newlines: false))
141
+ corrector.remove(range_with_surrounding_space(range, newlines: false))
148
142
  corrector.remove(if_branch.loc.keyword)
149
143
  end
150
144
 
@@ -154,7 +148,18 @@ module RuboCop
154
148
  )
155
149
  corrector.replace(range, and_operator)
156
150
  corrector.remove(range_by_whole_lines(node.loc.end, include_final_newline: true))
157
- corrector.wrap(if_branch.condition, '(', ')') if wrap_condition?(if_branch.condition)
151
+
152
+ wrap_condition(corrector, if_branch.condition)
153
+ end
154
+
155
+ def wrap_condition(corrector, condition)
156
+ # Handle `send` and `block` nodes that need to be wrapped in parens
157
+ # FIXME: autocorrection prevents syntax errors by wrapping the entire node in parens,
158
+ # but wrapping the argument list would be a more ergonomic correction.
159
+ node_to_check = condition&.block_type? ? condition.send_node : condition
160
+ return unless wrap_condition?(node_to_check)
161
+
162
+ corrector.wrap(condition, '(', ')')
158
163
  end
159
164
 
160
165
  def correct_for_outer_condition_modify_form_style(corrector, node, if_branch)
@@ -163,13 +168,11 @@ module RuboCop
163
168
  "#{'!' if node.unless?}#{replace_condition(node.condition)} && ")
164
169
 
165
170
  corrector.remove(node.condition.loc.expression)
166
- corrector.remove(range_with_surrounding_space(range: node.loc.keyword, newlines: false))
171
+ corrector.remove(range_with_surrounding_space(node.loc.keyword, newlines: false))
167
172
  corrector.replace(if_branch.loc.keyword, 'if')
168
173
  end
169
174
 
170
175
  def correct_for_comment(corrector, node, if_branch)
171
- return if config.for_cop('Style/IfUnlessModifier')['Enabled']
172
-
173
176
  comments = processed_source.ast_with_comments[if_branch]
174
177
  comment_text = comments.map(&:text).join("\n") << "\n"
175
178
 
@@ -187,8 +190,33 @@ module RuboCop
187
190
  corrector.insert_after(condition.last_argument.source_range, ')')
188
191
  end
189
192
 
193
+ def insert_bang(corrector, node, is_modify_form)
194
+ condition = node.condition
195
+
196
+ if (condition.send_type? && condition.comparison_method? && !condition.parenthesized?) ||
197
+ (is_modify_form && wrap_condition?(condition))
198
+ corrector.wrap(node.condition, '!(', ')')
199
+ elsif condition.and_type?
200
+ insert_bang_for_and(corrector, node)
201
+ else
202
+ corrector.insert_before(condition, '!')
203
+ end
204
+ end
205
+
206
+ def insert_bang_for_and(corrector, node)
207
+ lhs, rhs = *node
208
+
209
+ if lhs.and_type?
210
+ insert_bang_for_and(corrector, lhs)
211
+ corrector.insert_before(rhs, '!') if rhs
212
+ else
213
+ corrector.insert_before(lhs, '!')
214
+ corrector.insert_before(rhs, '!')
215
+ end
216
+ end
217
+
190
218
  def require_parentheses?(condition)
191
- condition.send_type? && !condition.arguments.empty? && !condition.parenthesized? &&
219
+ condition.call_type? && !condition.arguments.empty? && !condition.parenthesized? &&
192
220
  !condition.comparison_method?
193
221
  end
194
222
 
@@ -200,7 +228,7 @@ module RuboCop
200
228
 
201
229
  def wrap_condition?(node)
202
230
  node.and_type? || node.or_type? ||
203
- (node.send_type? && node.arguments.any? && !node.parenthesized?)
231
+ (node.call_type? && node.arguments.any? && !node.parenthesized?)
204
232
  end
205
233
 
206
234
  def replace_condition(condition)
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for places where classes with only class methods can be
6
+ # Checks for places where classes with only class methods can be
7
7
  # replaced with a module. Classes should be used only when it makes sense to create
8
8
  # instances out of them.
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop identifies places where `$stderr.puts` can be replaced by
6
+ # Identifies places where `$stderr.puts` can be replaced by
7
7
  # `warn`. The latter has the advantage of easily being disabled by,
8
8
  # the `-W0` interpreter flag or setting `$VERBOSE` to `nil`.
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for places where string concatenation
6
+ # Checks for places where string concatenation
7
7
  # can be replaced with string interpolation.
8
8
  #
9
9
  # The cop can autocorrect simple cases but will skip autocorrecting
@@ -76,7 +76,7 @@ module RuboCop
76
76
 
77
77
  topmost_plus_node = find_topmost_plus_node(node)
78
78
  parts = collect_parts(topmost_plus_node)
79
- return unless parts[0..-2].any? { |receiver_node| offensive_for_mode?(receiver_node) }
79
+ return if mode == :conservative && !parts.first.str_type?
80
80
 
81
81
  register_offense(topmost_plus_node, parts)
82
82
  end
@@ -95,11 +95,6 @@ module RuboCop
95
95
  end
96
96
  end
97
97
 
98
- def offensive_for_mode?(receiver_node)
99
- mode = cop_config['Mode'].to_sym
100
- mode == :aggressive || (mode == :conservative && receiver_node.str_type?)
101
- end
102
-
103
98
  def line_end_concatenation?(node)
104
99
  # If the concatenation happens at the end of the line,
105
100
  # and both the receiver and argument are strings, allow
@@ -173,6 +168,10 @@ module RuboCop
173
168
  def single_quoted?(str_node)
174
169
  str_node.source.start_with?("'")
175
170
  end
171
+
172
+ def mode
173
+ cop_config['Mode'].to_sym
174
+ end
176
175
  end
177
176
  end
178
177
  end
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for the use of strings as keys in hashes. The use of
6
+ # Checks for the use of strings as keys in hashes. The use of
7
7
  # symbols is preferred instead.
8
8
  #
9
9
  # @safety
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks that quotes inside the string interpolation
6
+ # Checks that quotes inside the string interpolation
7
7
  # match the configured preference.
8
8
  #
9
9
  # @example EnforcedStyle: single_quotes (default)
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop enforces the use of consistent method names
6
+ # Enforces the use of consistent method names
7
7
  # from the String class.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop identifies places where `lstrip.rstrip` can be replaced by
6
+ # Identifies places where `lstrip.rstrip` can be replaced by
7
7
  # `strip`.
8
8
  #
9
9
  # @example
@@ -3,10 +3,10 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for inheritance from Struct.new.
6
+ # Checks for inheritance from Struct.new.
7
7
  #
8
8
  # @safety
9
- # Auto-correction is unsafe because it will change the inheritance
9
+ # Autocorrection is unsafe because it will change the inheritance
10
10
  # tree (e.g. return value of `Module#ancestors`) of the constant.
11
11
  #
12
12
  # @example
@@ -34,7 +34,7 @@ module RuboCop
34
34
  return unless struct_constructor?(node.parent_class)
35
35
 
36
36
  add_offense(node.parent_class.source_range) do |corrector|
37
- corrector.remove(range_with_surrounding_space(range: node.loc.keyword, newlines: false))
37
+ corrector.remove(range_with_surrounding_space(node.loc.keyword, newlines: false))
38
38
  corrector.replace(node.loc.operator, '=')
39
39
 
40
40
  correct_parent(node.parent_class, corrector)
@@ -51,7 +51,7 @@ module RuboCop
51
51
 
52
52
  def correct_parent(parent, corrector)
53
53
  if parent.block_type?
54
- corrector.remove(range_with_surrounding_space(range: parent.loc.end, newlines: false))
54
+ corrector.remove(range_with_surrounding_space(parent.loc.end, newlines: false))
55
55
  elsif (class_node = parent.parent).body.nil?
56
56
  corrector.remove(range_for_empty_class_body(class_node, parent))
57
57
  else
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop enforces the use of shorthand-style swapping of 2 variables.
6
+ # Enforces the use of shorthand-style swapping of 2 variables.
7
7
  #
8
8
  # @safety
9
9
  # Autocorrection is unsafe, because the temporary variable used to
@@ -22,7 +22,7 @@ module RuboCop
22
22
  include RangeHelp
23
23
  extend AutoCorrector
24
24
 
25
- MSG = 'Replace this and assignments at lines %<x_line>d '\
25
+ MSG = 'Replace this and assignments at lines %<x_line>d ' \
26
26
  'and %<y_line>d with `%<replacement>s`.'
27
27
 
28
28
  SIMPLE_ASSIGNMENT_TYPES = %i[lvasgn ivasgn cvasgn gvasgn casgn].to_set.freeze
@@ -3,11 +3,12 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop can check for array literals made up of symbols that are not
6
+ # Checks for array literals made up of symbols that are not
7
7
  # using the %i() syntax.
8
8
  #
9
9
  # Alternatively, it checks for symbol arrays using the %i() syntax on
10
- # projects which do not want to use that syntax.
10
+ # projects which do not want to use that syntax, perhaps because they
11
+ # support a version of Ruby lower than 2.0.
11
12
  #
12
13
  # Configuration option: MinSize
13
14
  # If set, arrays with fewer elements than this value will not trigger the
@@ -33,9 +34,12 @@ module RuboCop
33
34
  include ConfigurableEnforcedStyle
34
35
  include PercentArray
35
36
  extend AutoCorrector
37
+ extend TargetRubyVersion
38
+
39
+ minimum_target_ruby_version 2.0
36
40
 
37
41
  PERCENT_MSG = 'Use `%i` or `%I` for an array of symbols.'
38
- ARRAY_MSG = 'Use `%<prefer>s` for an array of symbols.'
42
+ ARRAY_MSG = 'Use %<prefer>s for an array of symbols.'
39
43
 
40
44
  class << self
41
45
  attr_accessor :largest_brackets
@@ -65,13 +69,12 @@ module RuboCop
65
69
  if c.dsym_type?
66
70
  string_literal = to_string_literal(c.source)
67
71
 
68
- ":#{trim_string_interporation_escape_character(string_literal)}"
72
+ ":#{trim_string_interpolation_escape_character(string_literal)}"
69
73
  else
70
74
  to_symbol_literal(c.value.to_s)
71
75
  end
72
76
  end
73
-
74
- "[#{syms.join(', ')}]"
77
+ build_bracketed_array_with_appropriate_whitespace(elements: syms, node: node)
75
78
  end
76
79
 
77
80
  def to_symbol_literal(string)
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks symbol literal syntax.
6
+ # Checks symbol literal syntax.
7
7
  #
8
8
  # @example
9
9
  #
@@ -7,12 +7,15 @@ module RuboCop
7
7
  #
8
8
  # If you prefer a style that allows block for method with arguments,
9
9
  # please set `true` to `AllowMethodsWithArguments`.
10
+ # respond_to , and `define_method?` methods are allowed by default.
11
+ # These are customizable with `AllowedMethods` option.
10
12
  #
11
13
  # @safety
12
- # This cop is unsafe because `proc`s and blocks work differently
13
- # when additional arguments are passed in. A block will silently
14
- # ignore additional arguments, but a `proc` will raise
15
- # an `ArgumentError`.
14
+ # This cop is unsafe because there is a difference that a `Proc`
15
+ # generated from `Symbol#to_proc` behaves as a lambda, while
16
+ # a `Proc` generated from a block does not.
17
+ # For example, a lambda will raise an `ArgumentError` if the
18
+ # number of arguments is wrong, but a non-lambda `Proc` will not.
16
19
  #
17
20
  # For example:
18
21
  #
@@ -68,10 +71,26 @@ module RuboCop
68
71
  # s.upcase # some comment
69
72
  # # some comment
70
73
  # end
74
+ #
75
+ # @example AllowedMethods: [respond_to, define_method] (default)
76
+ # # good
77
+ # respond_to { |foo| foo.bar }
78
+ # define_method(:foo) { |foo| foo.bar }
79
+ #
80
+ #
81
+ # @example AllowedPatterns: [] (default)
82
+ # # bad
83
+ # something.map { |s| s.upcase }
84
+ #
85
+ # @example AllowedPatterns: [/map/] (default)
86
+ # # good
87
+ # something.map { |s| s.upcase }
88
+ #
71
89
  class SymbolProc < Base
72
90
  include CommentsHelp
73
91
  include RangeHelp
74
- include IgnoredMethods
92
+ include AllowedMethods
93
+ include AllowedPattern
75
94
  extend AutoCorrector
76
95
 
77
96
  MSG = 'Pass `&:%<method>s` as an argument to `%<block_method>s` instead of a block.'
@@ -81,7 +100,7 @@ module RuboCop
81
100
  def_node_matcher :proc_node?, '(send (const {nil? cbase} :Proc) :new)'
82
101
 
83
102
  # @!method symbol_proc_receiver?(node)
84
- def_node_matcher :symbol_proc_receiver?, '{(send ...) (super ...) zsuper}'
103
+ def_node_matcher :symbol_proc_receiver?, '{(call ...) (super ...) zsuper}'
85
104
 
86
105
  # @!method symbol_proc?(node)
87
106
  def_node_matcher :symbol_proc?, <<~PATTERN
@@ -95,23 +114,25 @@ module RuboCop
95
114
  [Layout::SpaceBeforeBlockBraces]
96
115
  end
97
116
 
98
- # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
117
+ # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
99
118
  def on_block(node)
100
119
  symbol_proc?(node) do |dispatch_node, arguments_node, method_name|
101
120
  # TODO: Rails-specific handling that we should probably make
102
121
  # configurable - https://github.com/rubocop/rubocop/issues/1485
103
- # we should ignore lambdas & procs
122
+ # we should allow lambdas & procs
104
123
  return if proc_node?(dispatch_node)
124
+ return if unsafe_hash_usage?(dispatch_node)
125
+ return if unsafe_array_usage?(dispatch_node)
105
126
  return if %i[lambda proc].include?(dispatch_node.method_name)
106
- return if ignored_method?(dispatch_node.method_name)
107
- return if allow_if_method_has_argument?(node)
127
+ return if allowed_method_name?(dispatch_node.method_name)
128
+ return if allow_if_method_has_argument?(node.send_node)
108
129
  return if node.block_type? && destructuring_block_argument?(arguments_node)
109
130
  return if allow_comments? && contains_comments?(node)
110
131
 
111
132
  register_offense(node, method_name, dispatch_node.method_name)
112
133
  end
113
134
  end
114
- # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
135
+ # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
115
136
  alias on_numblock on_block
116
137
 
117
138
  def destructuring_block_argument?(argument_node)
@@ -120,6 +141,19 @@ module RuboCop
120
141
 
121
142
  private
122
143
 
144
+ # See: https://github.com/rubocop/rubocop/issues/10864
145
+ def unsafe_hash_usage?(node)
146
+ node.receiver&.hash_type? && %i[reject select].include?(node.method_name)
147
+ end
148
+
149
+ def unsafe_array_usage?(node)
150
+ node.receiver&.array_type? && %i[min max].include?(node.method_name)
151
+ end
152
+
153
+ def allowed_method_name?(name)
154
+ allowed_method?(name) || matches_allowed_pattern?(name)
155
+ end
156
+
123
157
  def register_offense(node, method_name, block_method_name)
124
158
  block_start = node.loc.begin.begin_pos
125
159
  block_end = node.loc.end.end_pos
@@ -152,7 +186,7 @@ module RuboCop
152
186
 
153
187
  def block_range_with_space(node)
154
188
  block_range = range_between(begin_pos_for_replacement(node), node.loc.end.end_pos)
155
- range_with_surrounding_space(range: block_range, side: :left)
189
+ range_with_surrounding_space(block_range, side: :left)
156
190
  end
157
191
 
158
192
  def begin_pos_for_replacement(node)
@@ -165,8 +199,8 @@ module RuboCop
165
199
  end
166
200
  end
167
201
 
168
- def allow_if_method_has_argument?(node)
169
- !!cop_config.fetch('AllowMethodsWithArguments', false) && !node.arguments.count.zero?
202
+ def allow_if_method_has_argument?(send_node)
203
+ !!cop_config.fetch('AllowMethodsWithArguments', false) && !send_node.arguments.count.zero?
170
204
  end
171
205
 
172
206
  def allow_comments?
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for the presence of parentheses around ternary
6
+ # Checks for the presence of parentheses around ternary
7
7
  # conditions. It is configurable to enforce inclusion or omission of
8
8
  # parentheses using `EnforcedStyle`. Omission is only enforced when
9
9
  # removing the parentheses won't cause a different behavior.
@@ -71,7 +71,7 @@ module RuboCop
71
71
 
72
72
  return if only_closing_parenthesis_is_last_line?(condition)
73
73
  return if condition_as_parenthesized_one_line_pattern_matching?(condition)
74
- return unless node.ternary? && !infinite_loop? && offense?(node)
74
+ return unless node.ternary? && offense?(node)
75
75
 
76
76
  message = message(node)
77
77
 
@@ -166,22 +166,10 @@ module RuboCop
166
166
  style == :require_parentheses_when_complex
167
167
  end
168
168
 
169
- def redundant_parentheses_enabled?
170
- @config.for_cop('Style/RedundantParentheses').fetch('Enabled')
171
- end
172
-
173
169
  def parenthesized?(node)
174
170
  node.begin_type?
175
171
  end
176
172
 
177
- # When this cop is configured to enforce parentheses and the
178
- # `RedundantParentheses` cop is enabled, it will cause an infinite loop
179
- # as they compete to add and remove the parentheses respectively.
180
- def infinite_loop?
181
- (require_parentheses? || require_parentheses_when_complex?) &&
182
- redundant_parentheses_enabled?
183
- end
184
-
185
173
  def unsafe_autocorrect?(condition)
186
174
  condition.children.any? do |child|
187
175
  unparenthesized_method_call?(child) || below_ternary_precedence?(child)
@@ -63,6 +63,8 @@ module RuboCop
63
63
  add_offense(node)
64
64
  end
65
65
 
66
+ alias on_numblock on_block
67
+
66
68
  private
67
69
 
68
70
  def top_level_method_definition?(node)
@@ -75,7 +77,7 @@ module RuboCop
75
77
 
76
78
  # @!method define_method_block?(node)
77
79
  def_node_matcher :define_method_block?, <<~PATTERN
78
- (block (send _ {:define_method} _) ...)
80
+ ({block numblock} (send _ {:define_method} _) ...)
79
81
  PATTERN
80
82
  end
81
83
  end
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for trailing code after the class definition.
6
+ # Checks for trailing code after the class definition.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for trailing code after the method definition.
6
+ # Checks for trailing code after the method definition.
7
7
  #
8
8
  # NOTE: It always accepts endless method definitions that are basically on the same line.
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for trailing code after the module definition.
6
+ # Checks for trailing code after the module definition.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for trailing comma in argument lists.
6
+ # Checks for trailing comma in argument lists.
7
7
  # The supported styles are:
8
8
  #
9
9
  # * `consistent_comma`: Requires a comma after the last argument,
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for trailing comma in array literals.
6
+ # Checks for trailing comma in array literals.
7
7
  # The configuration options are:
8
8
  #
9
9
  # * `consistent_comma`: Requires a comma after the
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks whether trailing commas in block arguments are
6
+ # Checks whether trailing commas in block arguments are
7
7
  # required. Blocks with only one argument and a trailing comma require
8
8
  # that comma to be present. Blocks with more than one argument never
9
9
  # require a trailing comma.
@@ -64,7 +64,7 @@ module RuboCop
64
64
 
65
65
  MSG = 'Useless trailing comma present in block arguments.'
66
66
 
67
- def on_block(node)
67
+ def on_block(node) # rubocop:disable InternalAffairs/NumblockHandler
68
68
  # lambda literal (`->`) never has block arguments.
69
69
  return if node.send_node.lambda_literal?
70
70
  return unless useless_trailing_comma?(node)
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for trailing comma in hash literals.
6
+ # Checks for trailing comma in hash literals.
7
7
  # The configuration options are:
8
8
  #
9
9
  # * `consistent_comma`: Requires a comma after the
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for trailing code after the method definition.
6
+ # Checks for trailing code after the method definition.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for extra underscores in variable assignment.
6
+ # Checks for extra underscores in variable assignment.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -3,8 +3,11 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop looks for trivial reader/writer methods, that could
6
+ # Looks for trivial reader/writer methods, that could
7
7
  # have been created with the attr_* family of functions automatically.
8
+ # `to_ary`, `to_a`, `to_c`, `to_enum`, `to_h`, `to_hash`, `to_i`, `to_int`, `to_io`,
9
+ # `to_open`, `to_path`, `to_proc`, `to_r`, `to_regexp`, `to_str`, `to_s`, and `to_sym` methods
10
+ # are allowed by default. These are customizable with `AllowedMethods` option.
8
11
  #
9
12
  # @example
10
13
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop looks for `unless` expressions with `else` clauses.
6
+ # Looks for `unless` expressions with `else` clauses.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for the use of logical operators in an `unless` condition.
6
+ # Checks for the use of logical operators in an `unless` condition.
7
7
  # It discourages such code, as the condition becomes more difficult
8
8
  # to read and understand.
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for accessing the first element of `String#unpack`
6
+ # Checks for accessing the first element of `String#unpack`
7
7
  # which can be replaced with the shorter method `unpack1`.
8
8
  #
9
9
  # @example
@@ -19,8 +19,11 @@ module RuboCop
19
19
  #
20
20
  class UnpackFirst < Base
21
21
  extend AutoCorrector
22
+ extend TargetRubyVersion
22
23
 
23
- MSG = 'Use `%<receiver>s.unpack1(%<format>s)` instead of '\
24
+ minimum_target_ruby_version 2.4
25
+
26
+ MSG = 'Use `%<receiver>s.unpack1(%<format>s)` instead of ' \
24
27
  '`%<receiver>s.unpack(%<format>s)%<method>s`.'
25
28
  RESTRICT_ON_SEND = %i[first [] slice at].freeze
26
29
 
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for variable interpolation (like "#@ivar").
6
+ # Checks for variable interpolation (like "#@ivar").
7
7
  #
8
8
  # @example
9
9
  # # bad