rubocop 1.22.0 → 1.45.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (673) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE.txt +1 -1
  3. data/README.md +8 -7
  4. data/config/default.yml +534 -82
  5. data/config/obsoletion.yml +35 -2
  6. data/exe/rubocop +15 -7
  7. data/lib/rubocop/arguments_env.rb +17 -0
  8. data/lib/rubocop/arguments_file.rb +17 -0
  9. data/lib/rubocop/cache_config.rb +29 -0
  10. data/lib/rubocop/cli/command/{auto_genenerate_config.rb → auto_generate_config.rb} +21 -6
  11. data/lib/rubocop/cli/command/execute_runner.rb +8 -8
  12. data/lib/rubocop/cli/command/init_dotfile.rb +2 -2
  13. data/lib/rubocop/cli/command/show_cops.rb +1 -1
  14. data/lib/rubocop/cli/command/show_docs_url.rb +48 -0
  15. data/lib/rubocop/cli/command/suggest_extensions.rb +62 -17
  16. data/lib/rubocop/cli.rb +59 -10
  17. data/lib/rubocop/comment_config.rb +41 -1
  18. data/lib/rubocop/config.rb +45 -17
  19. data/lib/rubocop/config_finder.rb +68 -0
  20. data/lib/rubocop/config_loader.rb +42 -62
  21. data/lib/rubocop/config_loader_resolver.rb +12 -13
  22. data/lib/rubocop/config_obsoletion/changed_parameter.rb +5 -0
  23. data/lib/rubocop/config_obsoletion/extracted_cop.rb +3 -1
  24. data/lib/rubocop/config_obsoletion/parameter_rule.rb +4 -0
  25. data/lib/rubocop/config_obsoletion.rb +7 -2
  26. data/lib/rubocop/config_validator.rb +22 -5
  27. data/lib/rubocop/cop/autocorrect_logic.rb +8 -2
  28. data/lib/rubocop/cop/badge.rb +15 -4
  29. data/lib/rubocop/cop/base.rb +114 -82
  30. data/lib/rubocop/cop/bundler/duplicated_gem.rb +4 -8
  31. data/lib/rubocop/cop/bundler/gem_comment.rb +3 -3
  32. data/lib/rubocop/cop/bundler/gem_filename.rb +5 -5
  33. data/lib/rubocop/cop/bundler/ordered_gems.rb +2 -2
  34. data/lib/rubocop/cop/commissioner.rb +19 -6
  35. data/lib/rubocop/cop/cop.rb +52 -32
  36. data/lib/rubocop/cop/corrector.rb +32 -12
  37. data/lib/rubocop/cop/correctors/alignment_corrector.rb +1 -1
  38. data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -1
  39. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +2 -2
  40. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
  41. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +4 -2
  42. data/lib/rubocop/cop/correctors/if_then_corrector.rb +55 -0
  43. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +1 -1
  44. data/lib/rubocop/cop/correctors/line_break_corrector.rb +7 -1
  45. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +25 -9
  46. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +2 -7
  47. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +59 -1
  48. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
  49. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
  50. data/lib/rubocop/cop/correctors/space_corrector.rb +1 -1
  51. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +1 -1
  52. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +2 -2
  53. data/lib/rubocop/cop/documentation.rb +19 -2
  54. data/lib/rubocop/cop/gemspec/dependency_version.rb +154 -0
  55. data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
  56. data/lib/rubocop/cop/gemspec/development_dependencies.rb +107 -0
  57. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +6 -22
  58. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +1 -1
  59. data/lib/rubocop/cop/gemspec/require_mfa.rb +145 -0
  60. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +40 -26
  61. data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +4 -11
  62. data/lib/rubocop/cop/generator/require_file_injector.rb +2 -2
  63. data/lib/rubocop/cop/generator.rb +13 -14
  64. data/lib/rubocop/cop/internal_affairs/cop_description.rb +98 -0
  65. data/lib/rubocop/cop/internal_affairs/create_empty_file.rb +37 -0
  66. data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +1 -1
  67. data/lib/rubocop/cop/internal_affairs/example_heredoc_delimiter.rb +111 -0
  68. data/lib/rubocop/cop/internal_affairs/lambda_or_proc.rb +46 -0
  69. data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +60 -0
  70. data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +80 -0
  71. data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +1 -5
  72. data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
  73. data/lib/rubocop/cop/internal_affairs/redundant_context_config_parameter.rb +46 -0
  74. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +1 -1
  75. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +12 -4
  76. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
  77. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -1
  78. data/lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb +47 -0
  79. data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
  80. data/lib/rubocop/cop/internal_affairs/undefined_config.rb +3 -1
  81. data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
  82. data/lib/rubocop/cop/internal_affairs.rb +11 -0
  83. data/lib/rubocop/cop/layout/argument_alignment.rb +57 -9
  84. data/lib/rubocop/cop/layout/array_alignment.rb +1 -1
  85. data/lib/rubocop/cop/layout/assignment_indentation.rb +2 -2
  86. data/lib/rubocop/cop/layout/begin_end_alignment.rb +1 -1
  87. data/lib/rubocop/cop/layout/block_alignment.rb +20 -16
  88. data/lib/rubocop/cop/layout/block_end_newline.rb +42 -6
  89. data/lib/rubocop/cop/layout/case_indentation.rb +17 -1
  90. data/lib/rubocop/cop/layout/class_structure.rb +31 -24
  91. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +3 -7
  92. data/lib/rubocop/cop/layout/comment_indentation.rb +36 -5
  93. data/lib/rubocop/cop/layout/condition_position.rb +1 -1
  94. data/lib/rubocop/cop/layout/def_end_alignment.rb +1 -1
  95. data/lib/rubocop/cop/layout/dot_position.rb +15 -5
  96. data/lib/rubocop/cop/layout/else_alignment.rb +1 -1
  97. data/lib/rubocop/cop/layout/empty_comment.rb +3 -3
  98. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +1 -1
  99. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +1 -1
  100. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +23 -2
  101. data/lib/rubocop/cop/layout/empty_lines.rb +3 -1
  102. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +5 -2
  103. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +1 -1
  104. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +25 -4
  105. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +1 -1
  106. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +7 -5
  107. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +10 -10
  108. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +12 -5
  109. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +1 -1
  110. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +10 -10
  111. data/lib/rubocop/cop/layout/end_alignment.rb +2 -3
  112. data/lib/rubocop/cop/layout/end_of_line.rb +5 -5
  113. data/lib/rubocop/cop/layout/extra_spacing.rb +10 -6
  114. data/lib/rubocop/cop/layout/first_argument_indentation.rb +36 -30
  115. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +22 -15
  116. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +39 -3
  117. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +53 -14
  118. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +50 -3
  119. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +62 -3
  120. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +53 -3
  121. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +2 -2
  122. data/lib/rubocop/cop/layout/hash_alignment.rb +10 -3
  123. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +2 -2
  124. data/lib/rubocop/cop/layout/heredoc_indentation.rb +7 -10
  125. data/lib/rubocop/cop/layout/indentation_consistency.rb +1 -1
  126. data/lib/rubocop/cop/layout/indentation_style.rb +8 -3
  127. data/lib/rubocop/cop/layout/indentation_width.rb +18 -12
  128. data/lib/rubocop/cop/layout/initial_indentation.rb +2 -2
  129. data/lib/rubocop/cop/layout/leading_comment_space.rb +1 -1
  130. data/lib/rubocop/cop/layout/leading_empty_lines.rb +1 -1
  131. data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +138 -0
  132. data/lib/rubocop/cop/layout/line_continuation_spacing.rb +136 -0
  133. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +2 -2
  134. data/lib/rubocop/cop/layout/line_length.rb +14 -7
  135. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +1 -1
  136. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +52 -3
  137. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +3 -3
  138. data/lib/rubocop/cop/layout/multiline_block_layout.rb +7 -5
  139. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +1 -1
  140. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +50 -3
  141. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +58 -4
  142. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +1 -1
  143. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +23 -6
  144. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +1 -1
  145. data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +101 -0
  146. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +9 -10
  147. data/lib/rubocop/cop/layout/redundant_line_break.rb +7 -8
  148. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +3 -3
  149. data/lib/rubocop/cop/layout/single_line_block_chain.rb +1 -1
  150. data/lib/rubocop/cop/layout/space_after_colon.rb +1 -1
  151. data/lib/rubocop/cop/layout/space_after_not.rb +1 -1
  152. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +3 -3
  153. data/lib/rubocop/cop/layout/space_around_keyword.rb +3 -3
  154. data/lib/rubocop/cop/layout/space_around_operators.rb +2 -2
  155. data/lib/rubocop/cop/layout/space_before_block_braces.rb +5 -3
  156. data/lib/rubocop/cop/layout/space_before_brackets.rb +7 -0
  157. data/lib/rubocop/cop/layout/space_before_comment.rb +2 -2
  158. data/lib/rubocop/cop/layout/space_before_first_arg.rb +5 -1
  159. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +12 -6
  160. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +32 -30
  161. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -0
  162. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +33 -15
  163. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +30 -3
  164. data/lib/rubocop/cop/layout/space_inside_parens.rb +0 -4
  165. data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +34 -0
  166. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +11 -7
  167. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +6 -5
  168. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +10 -10
  169. data/lib/rubocop/cop/layout/trailing_whitespace.rb +14 -7
  170. data/lib/rubocop/cop/legacy/corrections_proxy.rb +1 -1
  171. data/lib/rubocop/cop/legacy/corrector.rb +1 -1
  172. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +1 -1
  173. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +28 -7
  174. data/lib/rubocop/cop/lint/ambiguous_operator.rb +11 -7
  175. data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +1 -1
  176. data/lib/rubocop/cop/lint/ambiguous_range.rb +8 -8
  177. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +6 -2
  178. data/lib/rubocop/cop/lint/assignment_in_condition.rb +12 -2
  179. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +1 -1
  180. data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -1
  181. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  182. data/lib/rubocop/cop/lint/constant_definition_in_block.rb +1 -1
  183. data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
  184. data/lib/rubocop/cop/lint/constant_resolution.rb +4 -0
  185. data/lib/rubocop/cop/lint/debugger.rb +25 -32
  186. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +69 -101
  187. data/lib/rubocop/cop/lint/deprecated_constants.rb +12 -4
  188. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +6 -0
  189. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +1 -1
  190. data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -3
  191. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  192. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +1 -1
  193. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
  194. data/lib/rubocop/cop/lint/duplicate_magic_comment.rb +73 -0
  195. data/lib/rubocop/cop/lint/duplicate_methods.rb +48 -18
  196. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +26 -7
  197. data/lib/rubocop/cop/lint/duplicate_require.rb +11 -2
  198. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +1 -1
  199. data/lib/rubocop/cop/lint/each_with_object_argument.rb +2 -2
  200. data/lib/rubocop/cop/lint/else_layout.rb +6 -10
  201. data/lib/rubocop/cop/lint/empty_block.rb +3 -7
  202. data/lib/rubocop/cop/lint/empty_class.rb +4 -2
  203. data/lib/rubocop/cop/lint/empty_conditional_body.rb +112 -4
  204. data/lib/rubocop/cop/lint/empty_ensure.rb +1 -1
  205. data/lib/rubocop/cop/lint/empty_expression.rb +1 -1
  206. data/lib/rubocop/cop/lint/empty_file.rb +1 -1
  207. data/lib/rubocop/cop/lint/empty_in_pattern.rb +4 -2
  208. data/lib/rubocop/cop/lint/empty_interpolation.rb +1 -1
  209. data/lib/rubocop/cop/lint/empty_when.rb +4 -2
  210. data/lib/rubocop/cop/lint/ensure_return.rb +1 -1
  211. data/lib/rubocop/cop/lint/erb_new_arguments.rb +10 -10
  212. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  213. data/lib/rubocop/cop/lint/float_comparison.rb +1 -1
  214. data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
  215. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +14 -7
  216. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +16 -18
  217. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +2 -2
  218. data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +17 -5
  219. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -1
  220. data/lib/rubocop/cop/lint/inherit_exception.rb +19 -28
  221. data/lib/rubocop/cop/lint/interpolation_check.rb +6 -5
  222. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +10 -3
  223. data/lib/rubocop/cop/lint/literal_as_condition.rb +6 -1
  224. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +5 -1
  225. data/lib/rubocop/cop/lint/loop.rb +2 -2
  226. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +19 -4
  227. data/lib/rubocop/cop/lint/missing_super.rb +1 -1
  228. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -0
  229. data/lib/rubocop/cop/lint/nested_method_definition.rb +58 -6
  230. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
  231. data/lib/rubocop/cop/lint/next_without_accumulator.rb +25 -6
  232. data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +162 -0
  233. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +17 -5
  234. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
  235. data/lib/rubocop/cop/lint/number_conversion.rb +37 -12
  236. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +1 -1
  237. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +2 -3
  238. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +4 -5
  239. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +20 -1
  240. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +17 -8
  241. data/lib/rubocop/cop/lint/percent_string_array.rb +1 -1
  242. data/lib/rubocop/cop/lint/percent_symbol_array.rb +1 -1
  243. data/lib/rubocop/cop/lint/raise_exception.rb +2 -2
  244. data/lib/rubocop/cop/lint/rand_one.rb +1 -1
  245. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +44 -10
  246. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +3 -3
  247. data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +12 -0
  248. data/lib/rubocop/cop/lint/redundant_require_statement.rb +48 -7
  249. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +16 -3
  250. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +1 -1
  251. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -1
  252. data/lib/rubocop/cop/lint/redundant_with_index.rb +14 -11
  253. data/lib/rubocop/cop/lint/redundant_with_object.rb +13 -12
  254. data/lib/rubocop/cop/lint/refinement_import_methods.rb +51 -0
  255. data/lib/rubocop/cop/lint/regexp_as_condition.rb +9 -3
  256. data/lib/rubocop/cop/lint/require_parentheses.rb +4 -2
  257. data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
  258. data/lib/rubocop/cop/lint/require_relative_self_path.rb +1 -0
  259. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  260. data/lib/rubocop/cop/lint/return_in_void_context.rb +6 -18
  261. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +44 -8
  262. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +1 -1
  263. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
  264. data/lib/rubocop/cop/lint/script_permission.rb +1 -1
  265. data/lib/rubocop/cop/lint/self_assignment.rb +1 -1
  266. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +5 -4
  267. data/lib/rubocop/cop/lint/shadowed_argument.rb +1 -1
  268. data/lib/rubocop/cop/lint/shadowed_exception.rb +16 -11
  269. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +36 -1
  270. data/lib/rubocop/cop/lint/struct_new_override.rb +3 -3
  271. data/lib/rubocop/cop/lint/suppressed_exception.rb +2 -2
  272. data/lib/rubocop/cop/lint/symbol_conversion.rb +4 -3
  273. data/lib/rubocop/cop/lint/syntax.rb +2 -3
  274. data/lib/rubocop/cop/lint/to_enum_arguments.rb +1 -1
  275. data/lib/rubocop/cop/lint/to_json.rb +1 -1
  276. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
  277. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +2 -2
  278. data/lib/rubocop/cop/lint/triple_quotes.rb +1 -1
  279. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +1 -1
  280. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +1 -1
  281. data/lib/rubocop/cop/lint/unified_integer.rb +3 -1
  282. data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
  283. data/lib/rubocop/cop/lint/unreachable_loop.rb +13 -7
  284. data/lib/rubocop/cop/lint/unused_block_argument.rb +1 -1
  285. data/lib/rubocop/cop/lint/unused_method_argument.rb +8 -3
  286. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
  287. data/lib/rubocop/cop/lint/uri_regexp.rb +1 -1
  288. data/lib/rubocop/cop/lint/useless_access_modifier.rb +15 -10
  289. data/lib/rubocop/cop/lint/useless_assignment.rb +1 -1
  290. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +2 -3
  291. data/lib/rubocop/cop/lint/useless_method_definition.rb +4 -4
  292. data/lib/rubocop/cop/lint/useless_rescue.rb +85 -0
  293. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +127 -0
  294. data/lib/rubocop/cop/lint/useless_setter_call.rb +2 -2
  295. data/lib/rubocop/cop/lint/useless_times.rb +15 -11
  296. data/lib/rubocop/cop/lint/void.rb +27 -16
  297. data/lib/rubocop/cop/metrics/abc_size.rb +5 -3
  298. data/lib/rubocop/cop/metrics/block_length.rb +18 -12
  299. data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
  300. data/lib/rubocop/cop/metrics/class_length.rb +10 -5
  301. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +2 -11
  302. data/lib/rubocop/cop/metrics/method_length.rb +19 -12
  303. data/lib/rubocop/cop/metrics/module_length.rb +11 -6
  304. data/lib/rubocop/cop/metrics/parameter_lists.rb +33 -3
  305. data/lib/rubocop/cop/metrics/perceived_complexity.rb +2 -2
  306. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +5 -9
  307. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +29 -7
  308. data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +1 -1
  309. data/lib/rubocop/cop/mixin/alignment.rb +2 -2
  310. data/lib/rubocop/cop/mixin/allowed_identifiers.rb +2 -2
  311. data/lib/rubocop/cop/mixin/allowed_methods.rb +23 -2
  312. data/lib/rubocop/cop/mixin/allowed_pattern.rb +56 -0
  313. data/lib/rubocop/cop/mixin/annotation_comment.rb +13 -6
  314. data/lib/rubocop/cop/mixin/check_line_breakable.rb +5 -1
  315. data/lib/rubocop/cop/mixin/comments_help.rb +42 -2
  316. data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +21 -9
  317. data/lib/rubocop/cop/mixin/def_node.rb +2 -7
  318. data/lib/rubocop/cop/mixin/duplication.rb +1 -1
  319. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +1 -2
  320. data/lib/rubocop/cop/mixin/enforce_superclass.rb +7 -1
  321. data/lib/rubocop/cop/mixin/first_element_line_break.rb +11 -7
  322. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +4 -0
  323. data/lib/rubocop/cop/mixin/gemspec_help.rb +30 -0
  324. data/lib/rubocop/cop/mixin/hash_alignment_styles.rb +4 -3
  325. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +221 -0
  326. data/lib/rubocop/cop/mixin/hash_transform_method.rb +13 -9
  327. data/lib/rubocop/cop/mixin/line_length_help.rb +28 -8
  328. data/lib/rubocop/cop/mixin/method_complexity.rb +13 -16
  329. data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +35 -13
  330. data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +5 -3
  331. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +4 -3
  332. data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +1 -1
  333. data/lib/rubocop/cop/mixin/percent_array.rb +58 -1
  334. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +1 -1
  335. data/lib/rubocop/cop/mixin/preferred_delimiters.rb +2 -2
  336. data/lib/rubocop/cop/mixin/range_help.rb +33 -7
  337. data/lib/rubocop/cop/mixin/require_library.rb +2 -0
  338. data/lib/rubocop/cop/mixin/rescue_node.rb +5 -3
  339. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +1 -1
  340. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +1 -1
  341. data/lib/rubocop/cop/mixin/statement_modifier.rb +18 -3
  342. data/lib/rubocop/cop/mixin/string_help.rb +1 -1
  343. data/lib/rubocop/cop/mixin/surrounding_space.rb +17 -13
  344. data/lib/rubocop/cop/mixin/trailing_body.rb +1 -1
  345. data/lib/rubocop/cop/mixin/trailing_comma.rb +2 -2
  346. data/lib/rubocop/cop/mixin/visibility_help.rb +40 -5
  347. data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
  348. data/lib/rubocop/cop/naming/ascii_identifiers.rb +1 -1
  349. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
  350. data/lib/rubocop/cop/naming/block_forwarding.rb +125 -0
  351. data/lib/rubocop/cop/naming/block_parameter_name.rb +2 -2
  352. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +4 -2
  353. data/lib/rubocop/cop/naming/constant_name.rb +3 -3
  354. data/lib/rubocop/cop/naming/file_name.rb +39 -6
  355. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +1 -1
  356. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +1 -1
  357. data/lib/rubocop/cop/naming/inclusive_language.rb +8 -4
  358. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +1 -1
  359. data/lib/rubocop/cop/naming/method_name.rb +6 -6
  360. data/lib/rubocop/cop/naming/method_parameter_name.rb +2 -2
  361. data/lib/rubocop/cop/naming/predicate_name.rb +32 -3
  362. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +1 -1
  363. data/lib/rubocop/cop/naming/variable_name.rb +10 -1
  364. data/lib/rubocop/cop/naming/variable_number.rb +28 -18
  365. data/lib/rubocop/cop/offense.rb +1 -1
  366. data/lib/rubocop/cop/registry.rb +70 -44
  367. data/lib/rubocop/cop/security/compound_hash.rb +106 -0
  368. data/lib/rubocop/cop/security/eval.rb +1 -1
  369. data/lib/rubocop/cop/security/json_load.rb +2 -2
  370. data/lib/rubocop/cop/security/marshal_load.rb +1 -1
  371. data/lib/rubocop/cop/security/open.rb +11 -1
  372. data/lib/rubocop/cop/security/yaml_load.rb +11 -5
  373. data/lib/rubocop/cop/style/access_modifier_declarations.rb +92 -3
  374. data/lib/rubocop/cop/style/accessor_grouping.rb +11 -7
  375. data/lib/rubocop/cop/style/alias.rb +13 -5
  376. data/lib/rubocop/cop/style/and_or.rb +12 -12
  377. data/lib/rubocop/cop/style/arguments_forwarding.rb +4 -3
  378. data/lib/rubocop/cop/style/array_coercion.rb +1 -1
  379. data/lib/rubocop/cop/style/array_intersect.rb +111 -0
  380. data/lib/rubocop/cop/style/array_join.rb +1 -1
  381. data/lib/rubocop/cop/style/ascii_comments.rb +1 -1
  382. data/lib/rubocop/cop/style/attr.rb +1 -1
  383. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +1 -1
  384. data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
  385. data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +1 -1
  386. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +1 -1
  387. data/lib/rubocop/cop/style/block_comments.rb +2 -2
  388. data/lib/rubocop/cop/style/block_delimiters.rb +43 -11
  389. data/lib/rubocop/cop/style/case_equality.rb +41 -11
  390. data/lib/rubocop/cop/style/case_like_if.rb +2 -2
  391. data/lib/rubocop/cop/style/character_literal.rb +10 -3
  392. data/lib/rubocop/cop/style/class_and_module_children.rb +8 -15
  393. data/lib/rubocop/cop/style/class_check.rb +1 -1
  394. data/lib/rubocop/cop/style/class_equality_comparison.rb +55 -6
  395. data/lib/rubocop/cop/style/class_methods.rb +1 -1
  396. data/lib/rubocop/cop/style/class_methods_definitions.rb +3 -2
  397. data/lib/rubocop/cop/style/class_vars.rb +1 -1
  398. data/lib/rubocop/cop/style/collection_compact.rb +45 -18
  399. data/lib/rubocop/cop/style/collection_methods.rb +3 -1
  400. data/lib/rubocop/cop/style/colon_method_call.rb +1 -1
  401. data/lib/rubocop/cop/style/colon_method_definition.rb +1 -1
  402. data/lib/rubocop/cop/style/combinable_loops.rb +6 -4
  403. data/lib/rubocop/cop/style/command_literal.rb +2 -2
  404. data/lib/rubocop/cop/style/comment_annotation.rb +1 -1
  405. data/lib/rubocop/cop/style/commented_keyword.rb +9 -7
  406. data/lib/rubocop/cop/style/comparable_clamp.rb +125 -0
  407. data/lib/rubocop/cop/style/concat_array_literals.rb +86 -0
  408. data/lib/rubocop/cop/style/conditional_assignment.rb +2 -7
  409. data/lib/rubocop/cop/style/constant_visibility.rb +1 -1
  410. data/lib/rubocop/cop/style/date_time.rb +2 -2
  411. data/lib/rubocop/cop/style/def_with_parentheses.rb +17 -12
  412. data/lib/rubocop/cop/style/dir.rb +4 -1
  413. data/lib/rubocop/cop/style/documentation.rb +13 -7
  414. data/lib/rubocop/cop/style/documentation_method.rb +7 -1
  415. data/lib/rubocop/cop/style/double_negation.rb +62 -3
  416. data/lib/rubocop/cop/style/each_for_simple_loop.rb +42 -7
  417. data/lib/rubocop/cop/style/each_with_object.rb +40 -9
  418. data/lib/rubocop/cop/style/empty_block_parameter.rb +2 -2
  419. data/lib/rubocop/cop/style/empty_case_condition.rb +13 -4
  420. data/lib/rubocop/cop/style/empty_else.rb +40 -3
  421. data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
  422. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +2 -2
  423. data/lib/rubocop/cop/style/empty_literal.rb +2 -2
  424. data/lib/rubocop/cop/style/empty_method.rb +19 -4
  425. data/lib/rubocop/cop/style/encoding.rb +2 -2
  426. data/lib/rubocop/cop/style/end_block.rb +1 -1
  427. data/lib/rubocop/cop/style/endless_method.rb +2 -2
  428. data/lib/rubocop/cop/style/env_home.rb +56 -0
  429. data/lib/rubocop/cop/style/eval_with_location.rb +1 -1
  430. data/lib/rubocop/cop/style/even_odd.rb +1 -1
  431. data/lib/rubocop/cop/style/expand_path_arguments.rb +1 -1
  432. data/lib/rubocop/cop/style/explicit_block_argument.rb +6 -2
  433. data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
  434. data/lib/rubocop/cop/style/fetch_env_var.rb +132 -0
  435. data/lib/rubocop/cop/style/file_read.rb +112 -0
  436. data/lib/rubocop/cop/style/file_write.rb +136 -0
  437. data/lib/rubocop/cop/style/float_division.rb +1 -1
  438. data/lib/rubocop/cop/style/for.rb +7 -1
  439. data/lib/rubocop/cop/style/format_string.rb +1 -1
  440. data/lib/rubocop/cop/style/format_string_token.rb +74 -23
  441. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +6 -3
  442. data/lib/rubocop/cop/style/global_std_stream.rb +1 -1
  443. data/lib/rubocop/cop/style/global_vars.rb +1 -1
  444. data/lib/rubocop/cop/style/guard_clause.rb +159 -25
  445. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +2 -1
  446. data/lib/rubocop/cop/style/hash_conversion.rb +3 -2
  447. data/lib/rubocop/cop/style/hash_each_methods.rb +49 -13
  448. data/lib/rubocop/cop/style/hash_except.rb +89 -9
  449. data/lib/rubocop/cop/style/hash_like_case.rb +1 -1
  450. data/lib/rubocop/cop/style/hash_syntax.rb +60 -3
  451. data/lib/rubocop/cop/style/hash_transform_keys.rb +12 -7
  452. data/lib/rubocop/cop/style/hash_transform_values.rb +10 -7
  453. data/lib/rubocop/cop/style/identical_conditional_branches.rb +19 -4
  454. data/lib/rubocop/cop/style/if_inside_else.rb +15 -0
  455. data/lib/rubocop/cop/style/if_unless_modifier.rb +6 -5
  456. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +30 -5
  457. data/lib/rubocop/cop/style/if_with_semicolon.rb +4 -4
  458. data/lib/rubocop/cop/style/implicit_runtime_error.rb +3 -3
  459. data/lib/rubocop/cop/style/in_pattern_then.rb +1 -1
  460. data/lib/rubocop/cop/style/infinite_loop.rb +2 -5
  461. data/lib/rubocop/cop/style/inline_comment.rb +1 -1
  462. data/lib/rubocop/cop/style/inverse_methods.rb +12 -8
  463. data/lib/rubocop/cop/style/invertible_unless_condition.rb +114 -0
  464. data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
  465. data/lib/rubocop/cop/style/keyword_parameters_order.rb +2 -2
  466. data/lib/rubocop/cop/style/lambda.rb +1 -1
  467. data/lib/rubocop/cop/style/lambda_call.rb +13 -21
  468. data/lib/rubocop/cop/style/line_end_concatenation.rb +7 -4
  469. data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
  470. data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
  471. data/lib/rubocop/cop/style/map_to_hash.rb +68 -0
  472. data/lib/rubocop/cop/style/map_to_set.rb +61 -0
  473. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +57 -17
  474. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +6 -2
  475. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +15 -13
  476. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +22 -3
  477. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +5 -2
  478. data/lib/rubocop/cop/style/method_def_parentheses.rb +25 -14
  479. data/lib/rubocop/cop/style/min_max.rb +1 -1
  480. data/lib/rubocop/cop/style/min_max_comparison.rb +83 -0
  481. data/lib/rubocop/cop/style/missing_else.rb +37 -25
  482. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +1 -1
  483. data/lib/rubocop/cop/style/mixin_grouping.rb +2 -2
  484. data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
  485. data/lib/rubocop/cop/style/module_function.rb +30 -8
  486. data/lib/rubocop/cop/style/multiline_block_chain.rb +4 -2
  487. data/lib/rubocop/cop/style/multiline_if_modifier.rb +2 -6
  488. data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
  489. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +4 -6
  490. data/lib/rubocop/cop/style/multiline_memoization.rb +3 -3
  491. data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
  492. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +52 -11
  493. data/lib/rubocop/cop/style/multiline_when_then.rb +3 -5
  494. data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
  495. data/lib/rubocop/cop/style/mutable_constant.rb +1 -1
  496. data/lib/rubocop/cop/style/negated_if_else_condition.rb +9 -7
  497. data/lib/rubocop/cop/style/nested_file_dirname.rb +66 -0
  498. data/lib/rubocop/cop/style/nested_modifier.rb +1 -1
  499. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +11 -2
  500. data/lib/rubocop/cop/style/nested_ternary_operator.rb +20 -8
  501. data/lib/rubocop/cop/style/next.rb +4 -6
  502. data/lib/rubocop/cop/style/nil_comparison.rb +1 -1
  503. data/lib/rubocop/cop/style/nil_lambda.rb +4 -4
  504. data/lib/rubocop/cop/style/non_nil_check.rb +1 -1
  505. data/lib/rubocop/cop/style/not.rb +2 -2
  506. data/lib/rubocop/cop/style/numbered_parameters.rb +1 -1
  507. data/lib/rubocop/cop/style/numbered_parameters_limit.rb +12 -4
  508. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +1 -1
  509. data/lib/rubocop/cop/style/numeric_literals.rb +26 -2
  510. data/lib/rubocop/cop/style/numeric_predicate.rb +53 -11
  511. data/lib/rubocop/cop/style/object_then.rb +74 -0
  512. data/lib/rubocop/cop/style/one_line_conditional.rb +16 -40
  513. data/lib/rubocop/cop/style/open_struct_use.rb +69 -0
  514. data/lib/rubocop/cop/style/operator_method_call.rb +67 -0
  515. data/lib/rubocop/cop/style/option_hash.rb +1 -1
  516. data/lib/rubocop/cop/style/optional_arguments.rb +2 -2
  517. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +5 -4
  518. data/lib/rubocop/cop/style/or_assignment.rb +1 -1
  519. data/lib/rubocop/cop/style/parallel_assignment.rb +3 -1
  520. data/lib/rubocop/cop/style/parentheses_around_condition.rb +13 -3
  521. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -1
  522. data/lib/rubocop/cop/style/percent_q_literals.rb +1 -1
  523. data/lib/rubocop/cop/style/perl_backrefs.rb +23 -2
  524. data/lib/rubocop/cop/style/preferred_hash_methods.rb +1 -1
  525. data/lib/rubocop/cop/style/proc.rb +5 -2
  526. data/lib/rubocop/cop/style/quoted_symbols.rb +22 -8
  527. data/lib/rubocop/cop/style/raise_args.rb +10 -4
  528. data/lib/rubocop/cop/style/random_with_offset.rb +1 -1
  529. data/lib/rubocop/cop/style/redundant_argument.rb +10 -4
  530. data/lib/rubocop/cop/style/redundant_assignment.rb +1 -1
  531. data/lib/rubocop/cop/style/redundant_begin.rb +22 -12
  532. data/lib/rubocop/cop/style/redundant_capital_w.rb +2 -3
  533. data/lib/rubocop/cop/style/redundant_condition.rb +147 -13
  534. data/lib/rubocop/cop/style/redundant_conditional.rb +1 -5
  535. data/lib/rubocop/cop/style/redundant_constant_base.rb +85 -0
  536. data/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb +45 -0
  537. data/lib/rubocop/cop/style/redundant_each.rb +116 -0
  538. data/lib/rubocop/cop/style/redundant_exception.rb +1 -1
  539. data/lib/rubocop/cop/style/redundant_fetch_block.rb +2 -2
  540. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +1 -1
  541. data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
  542. data/lib/rubocop/cop/style/redundant_heredoc_delimiter_quotes.rb +58 -0
  543. data/lib/rubocop/cop/style/redundant_initialize.rb +156 -0
  544. data/lib/rubocop/cop/style/redundant_interpolation.rb +39 -4
  545. data/lib/rubocop/cop/style/redundant_parentheses.rb +22 -24
  546. data/lib/rubocop/cop/style/redundant_percent_q.rb +1 -1
  547. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +20 -4
  548. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +15 -5
  549. data/lib/rubocop/cop/style/redundant_return.rb +9 -2
  550. data/lib/rubocop/cop/style/redundant_self.rb +4 -2
  551. data/lib/rubocop/cop/style/redundant_self_assignment.rb +3 -4
  552. data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +1 -1
  553. data/lib/rubocop/cop/style/redundant_sort.rb +23 -8
  554. data/lib/rubocop/cop/style/redundant_sort_by.rb +25 -9
  555. data/lib/rubocop/cop/style/redundant_string_escape.rb +184 -0
  556. data/lib/rubocop/cop/style/regexp_literal.rb +1 -1
  557. data/lib/rubocop/cop/style/require_order.rb +135 -0
  558. data/lib/rubocop/cop/style/rescue_modifier.rb +2 -2
  559. data/lib/rubocop/cop/style/rescue_standard_error.rb +13 -13
  560. data/lib/rubocop/cop/style/return_nil.rb +1 -1
  561. data/lib/rubocop/cop/style/safe_navigation.rb +57 -22
  562. data/lib/rubocop/cop/style/sample.rb +6 -4
  563. data/lib/rubocop/cop/style/select_by_regexp.rb +57 -11
  564. data/lib/rubocop/cop/style/self_assignment.rb +3 -3
  565. data/lib/rubocop/cop/style/semicolon.rb +53 -6
  566. data/lib/rubocop/cop/style/send.rb +1 -1
  567. data/lib/rubocop/cop/style/signal_exception.rb +9 -7
  568. data/lib/rubocop/cop/style/single_argument_dig.rb +5 -0
  569. data/lib/rubocop/cop/style/single_line_block_params.rb +4 -4
  570. data/lib/rubocop/cop/style/single_line_methods.rb +2 -2
  571. data/lib/rubocop/cop/style/slicing_with_range.rb +1 -1
  572. data/lib/rubocop/cop/style/sole_nested_conditional.rb +99 -31
  573. data/lib/rubocop/cop/style/special_global_vars.rb +66 -8
  574. data/lib/rubocop/cop/style/static_class.rb +33 -2
  575. data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
  576. data/lib/rubocop/cop/style/string_chars.rb +1 -1
  577. data/lib/rubocop/cop/style/string_concatenation.rb +13 -8
  578. data/lib/rubocop/cop/style/string_hash_keys.rb +5 -2
  579. data/lib/rubocop/cop/style/string_literals.rb +1 -5
  580. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +1 -1
  581. data/lib/rubocop/cop/style/string_methods.rb +1 -1
  582. data/lib/rubocop/cop/style/strip.rb +1 -1
  583. data/lib/rubocop/cop/style/struct_inheritance.rb +4 -4
  584. data/lib/rubocop/cop/style/swap_values.rb +4 -2
  585. data/lib/rubocop/cop/style/symbol_array.rb +12 -7
  586. data/lib/rubocop/cop/style/symbol_literal.rb +1 -1
  587. data/lib/rubocop/cop/style/symbol_proc.rb +68 -12
  588. data/lib/rubocop/cop/style/ternary_parentheses.rb +19 -18
  589. data/lib/rubocop/cop/style/top_level_method_definition.rb +3 -1
  590. data/lib/rubocop/cop/style/trailing_body_on_class.rb +1 -1
  591. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -1
  592. data/lib/rubocop/cop/style/trailing_body_on_module.rb +1 -1
  593. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +5 -5
  594. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +2 -2
  595. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +2 -2
  596. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +2 -2
  597. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +2 -5
  598. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +1 -1
  599. data/lib/rubocop/cop/style/trivial_accessors.rb +11 -9
  600. data/lib/rubocop/cop/style/unless_else.rb +5 -1
  601. data/lib/rubocop/cop/style/unless_logical_operators.rb +1 -1
  602. data/lib/rubocop/cop/style/unpack_first.rb +5 -2
  603. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  604. data/lib/rubocop/cop/style/when_then.rb +1 -1
  605. data/lib/rubocop/cop/style/word_array.rb +48 -6
  606. data/lib/rubocop/cop/style/yoda_condition.rb +13 -6
  607. data/lib/rubocop/cop/style/yoda_expression.rb +90 -0
  608. data/lib/rubocop/cop/style/zero_length_predicate.rb +32 -15
  609. data/lib/rubocop/cop/team.rb +55 -51
  610. data/lib/rubocop/cop/util.rb +54 -8
  611. data/lib/rubocop/cop/variable_force/assignment.rb +1 -1
  612. data/lib/rubocop/cop/variable_force/branch.rb +1 -1
  613. data/lib/rubocop/cop/variable_force/scope.rb +3 -3
  614. data/lib/rubocop/cop/variable_force/variable_table.rb +4 -2
  615. data/lib/rubocop/cop/variable_force.rb +19 -35
  616. data/lib/rubocop/cops_documentation_generator.rb +56 -16
  617. data/lib/rubocop/directive_comment.rb +1 -1
  618. data/lib/rubocop/ext/processed_source.rb +2 -0
  619. data/lib/rubocop/ext/range.rb +15 -0
  620. data/lib/rubocop/feature_loader.rb +94 -0
  621. data/lib/rubocop/file_patterns.rb +43 -0
  622. data/lib/rubocop/formatter/clang_style_formatter.rb +1 -1
  623. data/lib/rubocop/formatter/disabled_config_formatter.rb +45 -11
  624. data/lib/rubocop/formatter/formatter_set.rb +20 -18
  625. data/lib/rubocop/formatter/git_hub_actions_formatter.rb +15 -2
  626. data/lib/rubocop/formatter/html_formatter.rb +11 -16
  627. data/lib/rubocop/formatter/json_formatter.rb +4 -1
  628. data/lib/rubocop/formatter/markdown_formatter.rb +78 -0
  629. data/lib/rubocop/formatter/offense_count_formatter.rb +15 -6
  630. data/lib/rubocop/formatter/simple_text_formatter.rb +9 -8
  631. data/lib/rubocop/formatter/tap_formatter.rb +1 -1
  632. data/lib/rubocop/formatter/worst_offenders_formatter.rb +6 -4
  633. data/lib/rubocop/formatter.rb +34 -0
  634. data/lib/rubocop/magic_comment.rb +31 -5
  635. data/lib/rubocop/options.rb +164 -51
  636. data/lib/rubocop/path_util.rb +50 -22
  637. data/lib/rubocop/rake_task.rb +35 -10
  638. data/lib/rubocop/remote_config.rb +2 -4
  639. data/lib/rubocop/result_cache.rb +28 -17
  640. data/lib/rubocop/rspec/cop_helper.rb +26 -3
  641. data/lib/rubocop/rspec/expect_offense.rb +9 -7
  642. data/lib/rubocop/rspec/parallel_formatter.rb +90 -0
  643. data/lib/rubocop/rspec/shared_contexts.rb +47 -10
  644. data/lib/rubocop/rspec/support.rb +16 -1
  645. data/lib/rubocop/runner.rb +108 -27
  646. data/lib/rubocop/server/cache.rb +155 -0
  647. data/lib/rubocop/server/cli.rb +147 -0
  648. data/lib/rubocop/server/client_command/base.rb +44 -0
  649. data/lib/rubocop/server/client_command/exec.rb +64 -0
  650. data/lib/rubocop/server/client_command/restart.rb +25 -0
  651. data/lib/rubocop/server/client_command/start.rb +48 -0
  652. data/lib/rubocop/server/client_command/status.rb +28 -0
  653. data/lib/rubocop/server/client_command/stop.rb +31 -0
  654. data/lib/rubocop/server/client_command.rb +26 -0
  655. data/lib/rubocop/server/core.rb +111 -0
  656. data/lib/rubocop/server/errors.rb +23 -0
  657. data/lib/rubocop/server/helper.rb +34 -0
  658. data/lib/rubocop/server/server_command/base.rb +50 -0
  659. data/lib/rubocop/server/server_command/exec.rb +34 -0
  660. data/lib/rubocop/server/server_command/stop.rb +24 -0
  661. data/lib/rubocop/server/server_command.rb +21 -0
  662. data/lib/rubocop/server/socket_reader.rb +69 -0
  663. data/lib/rubocop/server.rb +53 -0
  664. data/lib/rubocop/string_interpreter.rb +4 -4
  665. data/lib/rubocop/target_finder.rb +2 -2
  666. data/lib/rubocop/target_ruby.rb +15 -8
  667. data/lib/rubocop/version.rb +22 -9
  668. data/lib/rubocop/yaml_duplication_checker.rb +1 -1
  669. data/lib/rubocop.rb +64 -35
  670. metadata +124 -40
  671. data/lib/rubocop/cop/gemspec/date_assignment.rb +0 -57
  672. data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -52
  673. data/lib/rubocop/cop/mixin/ignored_pattern.rb +0 -29
@@ -127,7 +127,7 @@ module RuboCop
127
127
  alias_method :eql?, :==
128
128
 
129
129
  def hash
130
- control_node.object_id.hash ^ child_node.object_id.hash
130
+ [control_node.object_id, control_node.object_id].hash
131
131
  end
132
132
 
133
133
  private
@@ -45,9 +45,9 @@ module RuboCop
45
45
  node
46
46
  else
47
47
  child_index = case node.type
48
- when :module, :sclass then 1
49
- when :def, :class, :block then 2
50
- when :defs then 3
48
+ when :module, :sclass then 1
49
+ when :def, :class, :block, :numblock then 2
50
+ when :defs then 3
51
51
  end
52
52
 
53
53
  node.children[child_index]
@@ -97,8 +97,10 @@ module RuboCop
97
97
  scope_stack.reverse_each do |scope|
98
98
  variable = scope.variables[name]
99
99
  return variable if variable
100
+
100
101
  # Only block scope allows referencing outer scope variables.
101
- return nil unless scope.node.block_type?
102
+ node = scope.node
103
+ return nil unless node.block_type? || node.numblock_type?
102
104
  end
103
105
 
104
106
  nil
@@ -109,7 +111,7 @@ module RuboCop
109
111
  end
110
112
 
111
113
  def accessible_variables
112
- scope_stack.reverse_each.each_with_object([]) do |scope, variables|
114
+ scope_stack.reverse_each.with_object([]) do |scope, variables|
113
115
  variables.concat(scope.variables.values)
114
116
  break variables unless scope.node.block_type?
115
117
  end
@@ -50,7 +50,7 @@ module RuboCop
50
50
 
51
51
  ZERO_ARITY_SUPER_TYPE = :zsuper
52
52
 
53
- TWISTED_SCOPE_TYPES = %i[block class sclass defs module].freeze
53
+ TWISTED_SCOPE_TYPES = %i[block numblock class sclass defs module].freeze
54
54
  SCOPE_TYPES = (TWISTED_SCOPE_TYPES + [:def]).freeze
55
55
 
56
56
  SEND_TYPE = :send
@@ -108,34 +108,23 @@ module RuboCop
108
108
  :skip_children
109
109
  end
110
110
 
111
- # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
111
+ NODE_HANDLER_METHOD_NAMES = [
112
+ [VARIABLE_ASSIGNMENT_TYPE, :process_variable_assignment],
113
+ [REGEXP_NAMED_CAPTURE_TYPE, :process_regexp_named_captures],
114
+ [MULTIPLE_ASSIGNMENT_TYPE, :process_variable_multiple_assignment],
115
+ [VARIABLE_REFERENCE_TYPE, :process_variable_referencing],
116
+ [RESCUE_TYPE, :process_rescue],
117
+ [ZERO_ARITY_SUPER_TYPE, :process_zero_arity_super],
118
+ [SEND_TYPE, :process_send],
119
+ *ARGUMENT_DECLARATION_TYPES.product([:process_variable_declaration]),
120
+ *OPERATOR_ASSIGNMENT_TYPES.product([:process_variable_operator_assignment]),
121
+ *LOOP_TYPES.product([:process_loop]),
122
+ *SCOPE_TYPES.product([:process_scope])
123
+ ].to_h.freeze
124
+ private_constant :NODE_HANDLER_METHOD_NAMES
112
125
  def node_handler_method_name(node)
113
- case node.type
114
- when VARIABLE_ASSIGNMENT_TYPE
115
- :process_variable_assignment
116
- when REGEXP_NAMED_CAPTURE_TYPE
117
- :process_regexp_named_captures
118
- when MULTIPLE_ASSIGNMENT_TYPE
119
- :process_variable_multiple_assignment
120
- when VARIABLE_REFERENCE_TYPE
121
- :process_variable_referencing
122
- when RESCUE_TYPE
123
- :process_rescue
124
- when ZERO_ARITY_SUPER_TYPE
125
- :process_zero_arity_super
126
- when SEND_TYPE
127
- :process_send
128
- when *ARGUMENT_DECLARATION_TYPES
129
- :process_variable_declaration
130
- when *OPERATOR_ASSIGNMENT_TYPES
131
- :process_variable_operator_assignment
132
- when *LOOP_TYPES
133
- :process_loop
134
- when *SCOPE_TYPES
135
- :process_scope
136
- end
126
+ NODE_HANDLER_METHOD_NAMES[node.type]
137
127
  end
138
- # rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity
139
128
 
140
129
  def process_variable_declaration(node)
141
130
  variable_name = node.children.first
@@ -186,11 +175,7 @@ module RuboCop
186
175
  end
187
176
 
188
177
  def regexp_captured_names(node)
189
- regexp_string = node.children.select(&:str_type?).map do |child|
190
- child.children.first
191
- end.join || ''
192
-
193
- regexp = Regexp.new(regexp_string)
178
+ regexp = node.to_regexp
194
179
 
195
180
  regexp.named_captures.keys
196
181
  end
@@ -362,13 +347,12 @@ module RuboCop
362
347
  end
363
348
  end
364
349
 
365
- # Use Node#equal? for accurate check.
366
350
  def scanned_node?(node)
367
- scanned_nodes.any? { |scanned_node| scanned_node.equal?(node) }
351
+ scanned_nodes.include?(node)
368
352
  end
369
353
 
370
354
  def scanned_nodes
371
- @scanned_nodes ||= []
355
+ @scanned_nodes ||= Set.new.compare_by_identity
372
356
  end
373
357
 
374
358
  # Hooks invoked by VariableTable.
@@ -33,18 +33,35 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
33
33
  cops.with_department(department).sort!
34
34
  end
35
35
 
36
- def cops_body(cop, description, examples_objects, safety_objects, pars) # rubocop:disable Metrics/AbcSize
36
+ def cops_body(cop, description, examples_objects, safety_objects, see_objects, pars) # rubocop:disable Metrics/AbcSize, Metrics/ParameterLists
37
+ check_examples_to_have_the_default_enforced_style!(examples_objects, cop)
38
+
37
39
  content = h2(cop.cop_name)
38
40
  content << required_ruby_version(cop)
39
41
  content << properties(cop)
40
42
  content << "#{description}\n"
41
43
  content << safety_object(safety_objects) if safety_objects.any? { |s| !s.text.blank? }
42
- content << examples(examples_objects) if examples_objects.count.positive?
43
- content << configurations(pars)
44
- content << references(cop)
44
+ content << examples(examples_objects) if examples_objects.any?
45
+ content << configurations(cop.department, pars)
46
+ content << references(cop, see_objects)
45
47
  content
46
48
  end
47
49
 
50
+ def check_examples_to_have_the_default_enforced_style!(examples_object, cop)
51
+ return if examples_object.none?
52
+
53
+ examples_describing_enforced_style = examples_object.map(&:name).grep(/EnforcedStyle:/)
54
+ return if examples_describing_enforced_style.none?
55
+
56
+ if examples_describing_enforced_style.index { |name| name.match?('default') }.nonzero?
57
+ raise "Put the example with the default EnforcedStyle on top for #{cop.cop_name}"
58
+ end
59
+
60
+ return if examples_describing_enforced_style.any? { |name| name.match?('default') }
61
+
62
+ raise "Specify the default EnforcedStyle for #{cop.cop_name}"
63
+ end
64
+
48
65
  def examples(examples_object)
49
66
  examples_object.each_with_object(h3('Examples').dup) do |example, content|
50
67
  content << "\n" unless content.end_with?("\n\n")
@@ -119,7 +136,7 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
119
136
  content
120
137
  end
121
138
 
122
- def configurations(pars)
139
+ def configurations(department, pars)
123
140
  return '' if pars.empty?
124
141
 
125
142
  header = ['Name', 'Default value', 'Configurable values']
@@ -130,12 +147,20 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
130
147
  content = configs.map do |name|
131
148
  configurable = configurable_values(pars, name)
132
149
  default = format_table_value(pars[name])
133
- [name, default, configurable]
150
+
151
+ [configuration_name(department, name), default, configurable]
134
152
  end
135
153
 
136
154
  h3('Configurable attributes') + to_table(header, content)
137
155
  end
138
156
 
157
+ def configuration_name(department, name)
158
+ return name unless name == 'AllowMultilineFinalElement'
159
+
160
+ filename = "#{department_to_basename(department)}.adoc"
161
+ "xref:#{filename}#allowmultilinefinalelement[AllowMultilineFinalElement]"
162
+ end
163
+
139
164
  # rubocop:disable Metrics/CyclomaticComplexity,Metrics/MethodLength
140
165
  def configurable_values(pars, name)
141
166
  case name
@@ -168,7 +193,8 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
168
193
  def to_table(header, content)
169
194
  table = ['|===', "| #{header.join(' | ')}\n\n"].join("\n")
170
195
  marked_contents = content.map do |plain_content|
171
- plain_content.map { |c| "| #{c}" }.join("\n")
196
+ # Escape `|` with backslash to prevent the regexp `|` is not used as a table separator.
197
+ plain_content.map { |c| "| #{c.gsub(/\|/, '\|')}" }.join("\n")
172
198
  end
173
199
  table << marked_contents.join("\n\n")
174
200
  table << "\n|===\n"
@@ -191,28 +217,41 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
191
217
 
192
218
  def wrap_backtick(value)
193
219
  if value.is_a?(String)
194
- # Use `+` to prevent text like `**/*.gemspec` from being bold.
195
- value.start_with?('*') ? "`+#{value}+`" : "`#{value}`"
220
+ # Use `+` to prevent text like `**/*.gemspec`, `spec/**/*` from being bold.
221
+ value.include?('*') ? "`+#{value}+`" : "`#{value}`"
196
222
  else
197
223
  "`#{value}`"
198
224
  end
199
225
  end
200
226
 
201
- def references(cop)
227
+ def references(cop, see_objects) # rubocop:disable Metrics/AbcSize
202
228
  cop_config = config.for_cop(cop)
203
229
  urls = RuboCop::Cop::MessageAnnotator.new(config, cop.name, cop_config, {}).urls
204
- return '' if urls.empty?
230
+ return '' if urls.empty? && see_objects.empty?
205
231
 
206
232
  content = h3('References')
207
233
  content << urls.map { |url| "* #{url}" }.join("\n")
208
- content << "\n"
234
+ content << "\n" unless urls.empty?
235
+ content << see_objects.map { |see| "* #{see.name}" }.join("\n")
236
+ content << "\n" unless see_objects.empty?
209
237
  content
210
238
  end
211
239
 
240
+ def footer_for_department(department)
241
+ return '' unless department == :Layout
242
+
243
+ filename = "#{department_to_basename(department)}_footer.adoc"
244
+ file = "#{Dir.pwd}/docs/modules/ROOT/partials/#{filename}"
245
+ return '' unless File.exist?(file)
246
+
247
+ "\ninclude::../partials/#{filename}[]\n"
248
+ end
249
+
212
250
  def print_cops_of_department(department)
213
251
  selected_cops = cops_of_department(department)
214
252
  content = +"= #{department}\n"
215
253
  selected_cops.each { |cop| content << print_cop_with_doc(cop) }
254
+ content << footer_for_department(department)
216
255
  file_name = "#{Dir.pwd}/docs/modules/ROOT/pages/#{department_to_basename(department)}.adoc"
217
256
  File.open(file_name, 'w') do |file|
218
257
  puts "* generated #{file_name}"
@@ -220,7 +259,7 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
220
259
  end
221
260
  end
222
261
 
223
- def print_cop_with_doc(cop)
262
+ def print_cop_with_doc(cop) # rubocop:todo Metrics/AbcSize, Metrics/MethodLength
224
263
  cop_config = config.for_cop(cop)
225
264
  non_display_keys = %w[
226
265
  Description Enabled StyleGuide Reference Safe SafeAutoCorrect VersionAdded
@@ -228,13 +267,14 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
228
267
  ]
229
268
  pars = cop_config.reject { |k| non_display_keys.include? k }
230
269
  description = 'No documentation'
231
- examples_object = safety_object = []
270
+ examples_object = safety_object = see_object = []
232
271
  cop_code(cop) do |code_object|
233
272
  description = code_object.docstring unless code_object.docstring.blank?
234
273
  examples_object = code_object.tags('example')
235
274
  safety_object = code_object.tags('safety')
275
+ see_object = code_object.tags('see')
236
276
  end
237
- cops_body(cop, description, examples_object, safety_object, pars)
277
+ cops_body(cop, description, examples_object, safety_object, see_object, pars)
238
278
  end
239
279
 
240
280
  def cop_code(cop)
@@ -246,7 +286,7 @@ class CopsDocumentationGenerator # rubocop:disable Metrics/ClassLength
246
286
  end
247
287
 
248
288
  def table_of_content_for_department(department)
249
- type_title = department[0].upcase + department[1..-1]
289
+ type_title = department[0].upcase + department[1..]
250
290
  filename = "#{department_to_basename(department)}.adoc"
251
291
  content = +"=== Department xref:#{filename}[#{type_title}]\n\n"
252
292
  cops_of_department(department).each do |cop|
@@ -35,7 +35,7 @@ module RuboCop
35
35
 
36
36
  # Checks if this directive relates to single line
37
37
  def single_line?
38
- !self.class.before_comment(comment.text).empty?
38
+ !comment.text.start_with?(DIRECTIVE_COMMENT_REGEXP)
39
39
  end
40
40
 
41
41
  # Checks if this directive contains all the given cop names
@@ -4,6 +4,8 @@ module RuboCop
4
4
  module Ext
5
5
  # Extensions to AST::ProcessedSource for our cached comment_config
6
6
  module ProcessedSource
7
+ attr_accessor :registry, :config
8
+
7
9
  def comment_config
8
10
  @comment_config ||= CommentConfig.new(self)
9
11
  end
@@ -0,0 +1,15 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Ext
5
+ # Extensions to Parser::Source::Range
6
+ module Range
7
+ # Adds `Range#single_line?` to parallel `Node#single_line?`
8
+ def single_line?
9
+ first_line == last_line
10
+ end
11
+ end
12
+ end
13
+ end
14
+
15
+ Parser::Source::Range.include RuboCop::Ext::Range
@@ -0,0 +1,94 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ # This class handles loading files (a.k.a. features in Ruby) specified
5
+ # by `--require` command line option and `require` directive in the config.
6
+ #
7
+ # Normally, the given string is directly passed to `require`. If a string
8
+ # beginning with `.` is given, it is assumed to be relative to the given
9
+ # directory.
10
+ #
11
+ # If a string containing `-` is given, it will be used as is, but if we
12
+ # cannot find the file to load, we will replace `-` with `/` and try it
13
+ # again as when Bundler loads gems.
14
+ #
15
+ # @api private
16
+ class FeatureLoader
17
+ class << self
18
+ # @param [String] config_directory_path
19
+ # @param [String] feature
20
+ def load(config_directory_path:, feature:)
21
+ new(config_directory_path: config_directory_path, feature: feature).load
22
+ end
23
+ end
24
+
25
+ # @param [String] config_directory_path
26
+ # @param [String] feature
27
+ def initialize(config_directory_path:, feature:)
28
+ @config_directory_path = config_directory_path
29
+ @feature = feature
30
+ end
31
+
32
+ def load
33
+ # Don't use `::Kernel.require(target)` to prevent the following error:
34
+ # https://github.com/rubocop/rubocop/issues/10893
35
+ require(target)
36
+ rescue ::LoadError => e
37
+ raise if e.path != target
38
+
39
+ begin
40
+ # Don't use `::Kernel.require(target)` to prevent the following error:
41
+ # https://github.com/rubocop/rubocop/issues/10893
42
+ require(namespaced_target)
43
+ rescue ::LoadError => error_for_namespaced_target
44
+ # NOTE: This wrap is necessary due to JRuby 9.3.4.0 incompatibility:
45
+ # https://github.com/jruby/jruby/issues/7316
46
+ raise LoadError, e if error_for_namespaced_target.path == namespaced_target
47
+
48
+ raise error_for_namespaced_target
49
+ end
50
+ end
51
+
52
+ private
53
+
54
+ # @return [String]
55
+ def namespaced_feature
56
+ @feature.tr('-', '/')
57
+ end
58
+
59
+ # @return [String]
60
+ def namespaced_target
61
+ if relative?
62
+ relative(namespaced_feature)
63
+ else
64
+ namespaced_feature
65
+ end
66
+ end
67
+
68
+ # @param [String]
69
+ # @return [String]
70
+ def relative(feature)
71
+ ::File.join(@config_directory_path, feature)
72
+ end
73
+
74
+ # @return [Boolean]
75
+ def relative?
76
+ @feature.start_with?('.')
77
+ end
78
+
79
+ # @param [LoadError] error
80
+ # @return [Boolean]
81
+ def seems_cannot_load_such_file_error?(error)
82
+ error.path == target
83
+ end
84
+
85
+ # @return [String]
86
+ def target
87
+ if relative?
88
+ relative(@feature)
89
+ else
90
+ @feature
91
+ end
92
+ end
93
+ end
94
+ end
@@ -0,0 +1,43 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ # A wrapper around patterns array to perform optimized search.
5
+ #
6
+ # For projects with a large set of rubocop todo files, most items in `Exclude`/`Include`
7
+ # are exact file names. It is wasteful to linearly check the list of patterns over and over
8
+ # to check if the file is relevant to the cop.
9
+ #
10
+ # This class partitions an array of patterns into a set of exact match strings and the rest
11
+ # of the patterns. This way we can firstly do a cheap check in the set and then proceed via
12
+ # the costly patterns check, if needed.
13
+ # @api private
14
+ class FilePatterns
15
+ @cache = {}.compare_by_identity
16
+
17
+ def self.from(patterns)
18
+ @cache[patterns] ||= new(patterns)
19
+ end
20
+
21
+ def initialize(patterns)
22
+ @strings = Set.new
23
+ @patterns = []
24
+ partition_patterns(patterns)
25
+ end
26
+
27
+ def match?(path)
28
+ @strings.include?(path) || @patterns.any? { |pattern| PathUtil.match_path?(pattern, path) }
29
+ end
30
+
31
+ private
32
+
33
+ def partition_patterns(patterns)
34
+ patterns.each do |pattern|
35
+ if pattern.is_a?(String) && !pattern.match?(/[*{\[?]/)
36
+ @strings << pattern
37
+ else
38
+ @patterns << pattern
39
+ end
40
+ end
41
+ end
42
+ end
43
+ end
@@ -41,7 +41,7 @@ module RuboCop
41
41
  def report_line(location)
42
42
  source_line = location.source_line
43
43
 
44
- if location.first_line == location.last_line
44
+ if location.single_line?
45
45
  output.puts(source_line)
46
46
  else
47
47
  output.puts("#{source_line} #{yellow(ELLIPSES)}")
@@ -65,18 +65,26 @@ module RuboCop
65
65
  @options.fetch(:offense_counts, true)
66
66
  end
67
67
 
68
+ def auto_gen_enforced_style?
69
+ @options.fetch(:auto_gen_enforced_style, true)
70
+ end
71
+
68
72
  def command
69
73
  command = 'rubocop --auto-gen-config'
70
74
 
71
75
  command += ' --auto-gen-only-exclude' if @options[:auto_gen_only_exclude]
72
76
 
73
- if @exclude_limit_option
77
+ if no_exclude_limit?
78
+ command += ' --no-exclude-limit'
79
+ elsif @exclude_limit_option
74
80
  command += format(' --exclude-limit %<limit>d', limit: Integer(@exclude_limit_option))
75
81
  end
76
82
  command += ' --no-offense-counts' unless show_offense_counts?
77
83
 
78
84
  command += ' --no-auto-gen-timestamp' unless show_timestamp?
79
85
 
86
+ command += ' --no-auto-gen-enforced-style' unless auto_gen_enforced_style?
87
+
80
88
  command
81
89
  end
82
90
 
@@ -121,9 +129,14 @@ module RuboCop
121
129
  output_buffer.puts "# Offense count: #{offense_count}" if show_offense_counts?
122
130
 
123
131
  cop_class = Cop::Registry.global.find_by_cop_name(cop_name)
124
- output_buffer.puts '# Cop supports --auto-correct.' if cop_class&.support_autocorrect?
125
-
126
132
  default_cfg = default_config(cop_name)
133
+
134
+ if supports_safe_autocorrect?(cop_class, default_cfg)
135
+ output_buffer.puts '# This cop supports safe autocorrection (--autocorrect).'
136
+ elsif supports_unsafe_autocorrect?(cop_class, default_cfg)
137
+ output_buffer.puts '# This cop supports unsafe autocorrection (--autocorrect-all).'
138
+ end
139
+
127
140
  return unless default_cfg
128
141
 
129
142
  params = cop_config_params(default_cfg, cfg)
@@ -132,6 +145,14 @@ module RuboCop
132
145
  output_cop_param_comments(output_buffer, params, default_cfg)
133
146
  end
134
147
 
148
+ def supports_safe_autocorrect?(cop_class, default_cfg)
149
+ cop_class&.support_autocorrect? && (default_cfg.nil? || safe_autocorrect?(default_cfg))
150
+ end
151
+
152
+ def supports_unsafe_autocorrect?(cop_class, default_cfg)
153
+ cop_class&.support_autocorrect? && !safe_autocorrect?(default_cfg)
154
+ end
155
+
135
156
  def cop_config_params(default_cfg, cfg)
136
157
  default_cfg.keys -
137
158
  %w[Description StyleGuide Reference Enabled Exclude Safe
@@ -148,7 +169,7 @@ module RuboCop
148
169
  next unless value.is_a?(Array)
149
170
  next if value.empty?
150
171
 
151
- output_buffer.puts "# #{param}: #{value.join(', ')}"
172
+ output_buffer.puts "# #{param}: #{value.uniq.join(', ')}"
152
173
  end
153
174
  end
154
175
 
@@ -157,24 +178,29 @@ module RuboCop
157
178
  end
158
179
 
159
180
  def output_cop_config(output_buffer, cfg, cop_name)
160
- # 'Enabled' option will be put into file only if exclude
161
- # limit is exceeded.
162
- cfg_without_enabled = cfg.reject { |key| key == 'Enabled' }
163
-
181
+ filtered_cfg = filtered_config(cfg)
164
182
  output_buffer.puts "#{cop_name}:"
165
- cfg_without_enabled.each do |key, value|
183
+ filtered_cfg.each do |key, value|
166
184
  value = value[0] if value.is_a?(Array)
167
185
  output_buffer.puts " #{key}: #{value}"
168
186
  end
169
187
 
170
- output_offending_files(output_buffer, cfg_without_enabled, cop_name)
188
+ output_offending_files(output_buffer, filtered_cfg, cop_name)
189
+ end
190
+
191
+ def filtered_config(cfg)
192
+ # 'Enabled' option will be put into file only if exclude
193
+ # limit is exceeded.
194
+ rejected_keys = ['Enabled']
195
+ rejected_keys << 'EnforcedStyle' unless auto_gen_enforced_style?
196
+ cfg.reject { |key| rejected_keys.include?(key) }
171
197
  end
172
198
 
173
199
  def output_offending_files(output_buffer, cfg, cop_name)
174
200
  return unless cfg.empty?
175
201
 
176
202
  offending_files = @files_with_offenses[cop_name].sort
177
- if offending_files.count > @exclude_limit
203
+ if !no_exclude_limit? && offending_files.count > @exclude_limit
178
204
  output_buffer.puts ' Enabled: false'
179
205
  else
180
206
  output_exclude_list(output_buffer, offending_files, cop_name)
@@ -228,6 +254,14 @@ module RuboCop
228
254
  regexp = exclude_path
229
255
  output_buffer.puts " - !ruby/regexp /#{regexp.source}/"
230
256
  end
257
+
258
+ def safe_autocorrect?(config)
259
+ config.fetch('Safe', true) && config.fetch('SafeAutoCorrect', true)
260
+ end
261
+
262
+ def no_exclude_limit?
263
+ @options[:no_exclude_limit] == false
264
+ end
231
265
  end
232
266
  end
233
267
  end
@@ -9,22 +9,23 @@ module RuboCop
9
9
  # which invoke same method of each formatters.
10
10
  class FormatterSet < Array
11
11
  BUILTIN_FORMATTERS_FOR_KEYS = {
12
- '[a]utogenconf' => AutoGenConfigFormatter,
13
- '[c]lang' => ClangStyleFormatter,
14
- '[e]macs' => EmacsStyleFormatter,
15
- '[fi]les' => FileListFormatter,
16
- '[fu]ubar' => FuubarStyleFormatter,
17
- '[g]ithub' => GitHubActionsFormatter,
18
- '[h]tml' => HTMLFormatter,
19
- '[j]son' => JSONFormatter,
20
- '[ju]nit' => JUnitFormatter,
21
- '[o]ffenses' => OffenseCountFormatter,
22
- '[pa]cman' => PacmanFormatter,
23
- '[p]rogress' => ProgressFormatter,
24
- '[q]uiet' => QuietFormatter,
25
- '[s]imple' => SimpleTextFormatter,
26
- '[t]ap' => TapFormatter,
27
- '[w]orst' => WorstOffendersFormatter
12
+ '[a]utogenconf' => 'AutoGenConfigFormatter',
13
+ '[c]lang' => 'ClangStyleFormatter',
14
+ '[e]macs' => 'EmacsStyleFormatter',
15
+ '[fi]les' => 'FileListFormatter',
16
+ '[fu]ubar' => 'FuubarStyleFormatter',
17
+ '[g]ithub' => 'GitHubActionsFormatter',
18
+ '[h]tml' => 'HTMLFormatter',
19
+ '[j]son' => 'JSONFormatter',
20
+ '[ju]nit' => 'JUnitFormatter',
21
+ '[m]arkdown' => 'MarkdownFormatter',
22
+ '[o]ffenses' => 'OffenseCountFormatter',
23
+ '[pa]cman' => 'PacmanFormatter',
24
+ '[p]rogress' => 'ProgressFormatter',
25
+ '[q]uiet' => 'QuietFormatter',
26
+ '[s]imple' => 'SimpleTextFormatter',
27
+ '[t]ap' => 'TapFormatter',
28
+ '[w]orst' => 'WorstOffendersFormatter'
28
29
  }.freeze
29
30
 
30
31
  FORMATTER_APIS = %i[started finished].freeze
@@ -54,7 +55,7 @@ module RuboCop
54
55
  def add_formatter(formatter_type, output_path = nil)
55
56
  if output_path
56
57
  dir_path = File.dirname(output_path)
57
- FileUtils.mkdir_p(dir_path) unless File.exist?(dir_path)
58
+ FileUtils.mkdir_p(dir_path)
58
59
  output = File.open(output_path, 'w')
59
60
  else
60
61
  output = $stdout
@@ -91,7 +92,8 @@ module RuboCop
91
92
 
92
93
  raise %(Cannot determine formatter for "#{specified_key}") if matching_keys.size > 1
93
94
 
94
- BUILTIN_FORMATTERS_FOR_KEYS[matching_keys.first]
95
+ formatter_name = BUILTIN_FORMATTERS_FOR_KEYS[matching_keys.first]
96
+ RuboCop::Formatter.const_get(formatter_name)
95
97
  end
96
98
 
97
99
  def custom_formatter_class(specified_class_name)