rubocop 1.22.0 → 1.45.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (673) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE.txt +1 -1
  3. data/README.md +8 -7
  4. data/config/default.yml +534 -82
  5. data/config/obsoletion.yml +35 -2
  6. data/exe/rubocop +15 -7
  7. data/lib/rubocop/arguments_env.rb +17 -0
  8. data/lib/rubocop/arguments_file.rb +17 -0
  9. data/lib/rubocop/cache_config.rb +29 -0
  10. data/lib/rubocop/cli/command/{auto_genenerate_config.rb → auto_generate_config.rb} +21 -6
  11. data/lib/rubocop/cli/command/execute_runner.rb +8 -8
  12. data/lib/rubocop/cli/command/init_dotfile.rb +2 -2
  13. data/lib/rubocop/cli/command/show_cops.rb +1 -1
  14. data/lib/rubocop/cli/command/show_docs_url.rb +48 -0
  15. data/lib/rubocop/cli/command/suggest_extensions.rb +62 -17
  16. data/lib/rubocop/cli.rb +59 -10
  17. data/lib/rubocop/comment_config.rb +41 -1
  18. data/lib/rubocop/config.rb +45 -17
  19. data/lib/rubocop/config_finder.rb +68 -0
  20. data/lib/rubocop/config_loader.rb +42 -62
  21. data/lib/rubocop/config_loader_resolver.rb +12 -13
  22. data/lib/rubocop/config_obsoletion/changed_parameter.rb +5 -0
  23. data/lib/rubocop/config_obsoletion/extracted_cop.rb +3 -1
  24. data/lib/rubocop/config_obsoletion/parameter_rule.rb +4 -0
  25. data/lib/rubocop/config_obsoletion.rb +7 -2
  26. data/lib/rubocop/config_validator.rb +22 -5
  27. data/lib/rubocop/cop/autocorrect_logic.rb +8 -2
  28. data/lib/rubocop/cop/badge.rb +15 -4
  29. data/lib/rubocop/cop/base.rb +114 -82
  30. data/lib/rubocop/cop/bundler/duplicated_gem.rb +4 -8
  31. data/lib/rubocop/cop/bundler/gem_comment.rb +3 -3
  32. data/lib/rubocop/cop/bundler/gem_filename.rb +5 -5
  33. data/lib/rubocop/cop/bundler/ordered_gems.rb +2 -2
  34. data/lib/rubocop/cop/commissioner.rb +19 -6
  35. data/lib/rubocop/cop/cop.rb +52 -32
  36. data/lib/rubocop/cop/corrector.rb +32 -12
  37. data/lib/rubocop/cop/correctors/alignment_corrector.rb +1 -1
  38. data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -1
  39. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +2 -2
  40. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
  41. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +4 -2
  42. data/lib/rubocop/cop/correctors/if_then_corrector.rb +55 -0
  43. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +1 -1
  44. data/lib/rubocop/cop/correctors/line_break_corrector.rb +7 -1
  45. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +25 -9
  46. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +2 -7
  47. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +59 -1
  48. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
  49. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
  50. data/lib/rubocop/cop/correctors/space_corrector.rb +1 -1
  51. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +1 -1
  52. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +2 -2
  53. data/lib/rubocop/cop/documentation.rb +19 -2
  54. data/lib/rubocop/cop/gemspec/dependency_version.rb +154 -0
  55. data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
  56. data/lib/rubocop/cop/gemspec/development_dependencies.rb +107 -0
  57. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +6 -22
  58. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +1 -1
  59. data/lib/rubocop/cop/gemspec/require_mfa.rb +145 -0
  60. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +40 -26
  61. data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +4 -11
  62. data/lib/rubocop/cop/generator/require_file_injector.rb +2 -2
  63. data/lib/rubocop/cop/generator.rb +13 -14
  64. data/lib/rubocop/cop/internal_affairs/cop_description.rb +98 -0
  65. data/lib/rubocop/cop/internal_affairs/create_empty_file.rb +37 -0
  66. data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +1 -1
  67. data/lib/rubocop/cop/internal_affairs/example_heredoc_delimiter.rb +111 -0
  68. data/lib/rubocop/cop/internal_affairs/lambda_or_proc.rb +46 -0
  69. data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +60 -0
  70. data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +80 -0
  71. data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +1 -5
  72. data/lib/rubocop/cop/internal_affairs/numblock_handler.rb +69 -0
  73. data/lib/rubocop/cop/internal_affairs/redundant_context_config_parameter.rb +46 -0
  74. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +1 -1
  75. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +12 -4
  76. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
  77. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -1
  78. data/lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb +47 -0
  79. data/lib/rubocop/cop/internal_affairs/single_line_comparison.rb +62 -0
  80. data/lib/rubocop/cop/internal_affairs/undefined_config.rb +3 -1
  81. data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
  82. data/lib/rubocop/cop/internal_affairs.rb +11 -0
  83. data/lib/rubocop/cop/layout/argument_alignment.rb +57 -9
  84. data/lib/rubocop/cop/layout/array_alignment.rb +1 -1
  85. data/lib/rubocop/cop/layout/assignment_indentation.rb +2 -2
  86. data/lib/rubocop/cop/layout/begin_end_alignment.rb +1 -1
  87. data/lib/rubocop/cop/layout/block_alignment.rb +20 -16
  88. data/lib/rubocop/cop/layout/block_end_newline.rb +42 -6
  89. data/lib/rubocop/cop/layout/case_indentation.rb +17 -1
  90. data/lib/rubocop/cop/layout/class_structure.rb +31 -24
  91. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +3 -7
  92. data/lib/rubocop/cop/layout/comment_indentation.rb +36 -5
  93. data/lib/rubocop/cop/layout/condition_position.rb +1 -1
  94. data/lib/rubocop/cop/layout/def_end_alignment.rb +1 -1
  95. data/lib/rubocop/cop/layout/dot_position.rb +15 -5
  96. data/lib/rubocop/cop/layout/else_alignment.rb +1 -1
  97. data/lib/rubocop/cop/layout/empty_comment.rb +3 -3
  98. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +1 -1
  99. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +1 -1
  100. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +23 -2
  101. data/lib/rubocop/cop/layout/empty_lines.rb +3 -1
  102. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +5 -2
  103. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +1 -1
  104. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +25 -4
  105. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +1 -1
  106. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +7 -5
  107. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +10 -10
  108. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +12 -5
  109. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +1 -1
  110. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +10 -10
  111. data/lib/rubocop/cop/layout/end_alignment.rb +2 -3
  112. data/lib/rubocop/cop/layout/end_of_line.rb +5 -5
  113. data/lib/rubocop/cop/layout/extra_spacing.rb +10 -6
  114. data/lib/rubocop/cop/layout/first_argument_indentation.rb +36 -30
  115. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +22 -15
  116. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +39 -3
  117. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +53 -14
  118. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +50 -3
  119. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +62 -3
  120. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +53 -3
  121. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +2 -2
  122. data/lib/rubocop/cop/layout/hash_alignment.rb +10 -3
  123. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +2 -2
  124. data/lib/rubocop/cop/layout/heredoc_indentation.rb +7 -10
  125. data/lib/rubocop/cop/layout/indentation_consistency.rb +1 -1
  126. data/lib/rubocop/cop/layout/indentation_style.rb +8 -3
  127. data/lib/rubocop/cop/layout/indentation_width.rb +18 -12
  128. data/lib/rubocop/cop/layout/initial_indentation.rb +2 -2
  129. data/lib/rubocop/cop/layout/leading_comment_space.rb +1 -1
  130. data/lib/rubocop/cop/layout/leading_empty_lines.rb +1 -1
  131. data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +138 -0
  132. data/lib/rubocop/cop/layout/line_continuation_spacing.rb +136 -0
  133. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +2 -2
  134. data/lib/rubocop/cop/layout/line_length.rb +14 -7
  135. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +1 -1
  136. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +52 -3
  137. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +3 -3
  138. data/lib/rubocop/cop/layout/multiline_block_layout.rb +7 -5
  139. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +1 -1
  140. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +50 -3
  141. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +58 -4
  142. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +1 -1
  143. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +23 -6
  144. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +1 -1
  145. data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +101 -0
  146. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +9 -10
  147. data/lib/rubocop/cop/layout/redundant_line_break.rb +7 -8
  148. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +3 -3
  149. data/lib/rubocop/cop/layout/single_line_block_chain.rb +1 -1
  150. data/lib/rubocop/cop/layout/space_after_colon.rb +1 -1
  151. data/lib/rubocop/cop/layout/space_after_not.rb +1 -1
  152. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +3 -3
  153. data/lib/rubocop/cop/layout/space_around_keyword.rb +3 -3
  154. data/lib/rubocop/cop/layout/space_around_operators.rb +2 -2
  155. data/lib/rubocop/cop/layout/space_before_block_braces.rb +5 -3
  156. data/lib/rubocop/cop/layout/space_before_brackets.rb +7 -0
  157. data/lib/rubocop/cop/layout/space_before_comment.rb +2 -2
  158. data/lib/rubocop/cop/layout/space_before_first_arg.rb +5 -1
  159. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +12 -6
  160. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +32 -30
  161. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -0
  162. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +33 -15
  163. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +30 -3
  164. data/lib/rubocop/cop/layout/space_inside_parens.rb +0 -4
  165. data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +34 -0
  166. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +11 -7
  167. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +6 -5
  168. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +10 -10
  169. data/lib/rubocop/cop/layout/trailing_whitespace.rb +14 -7
  170. data/lib/rubocop/cop/legacy/corrections_proxy.rb +1 -1
  171. data/lib/rubocop/cop/legacy/corrector.rb +1 -1
  172. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +1 -1
  173. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +28 -7
  174. data/lib/rubocop/cop/lint/ambiguous_operator.rb +11 -7
  175. data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +1 -1
  176. data/lib/rubocop/cop/lint/ambiguous_range.rb +8 -8
  177. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +6 -2
  178. data/lib/rubocop/cop/lint/assignment_in_condition.rb +12 -2
  179. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +1 -1
  180. data/lib/rubocop/cop/lint/boolean_symbol.rb +1 -1
  181. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  182. data/lib/rubocop/cop/lint/constant_definition_in_block.rb +1 -1
  183. data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
  184. data/lib/rubocop/cop/lint/constant_resolution.rb +4 -0
  185. data/lib/rubocop/cop/lint/debugger.rb +25 -32
  186. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +69 -101
  187. data/lib/rubocop/cop/lint/deprecated_constants.rb +12 -4
  188. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +6 -0
  189. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +1 -1
  190. data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -3
  191. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  192. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +1 -1
  193. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
  194. data/lib/rubocop/cop/lint/duplicate_magic_comment.rb +73 -0
  195. data/lib/rubocop/cop/lint/duplicate_methods.rb +48 -18
  196. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +26 -7
  197. data/lib/rubocop/cop/lint/duplicate_require.rb +11 -2
  198. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +1 -1
  199. data/lib/rubocop/cop/lint/each_with_object_argument.rb +2 -2
  200. data/lib/rubocop/cop/lint/else_layout.rb +6 -10
  201. data/lib/rubocop/cop/lint/empty_block.rb +3 -7
  202. data/lib/rubocop/cop/lint/empty_class.rb +4 -2
  203. data/lib/rubocop/cop/lint/empty_conditional_body.rb +112 -4
  204. data/lib/rubocop/cop/lint/empty_ensure.rb +1 -1
  205. data/lib/rubocop/cop/lint/empty_expression.rb +1 -1
  206. data/lib/rubocop/cop/lint/empty_file.rb +1 -1
  207. data/lib/rubocop/cop/lint/empty_in_pattern.rb +4 -2
  208. data/lib/rubocop/cop/lint/empty_interpolation.rb +1 -1
  209. data/lib/rubocop/cop/lint/empty_when.rb +4 -2
  210. data/lib/rubocop/cop/lint/ensure_return.rb +1 -1
  211. data/lib/rubocop/cop/lint/erb_new_arguments.rb +10 -10
  212. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  213. data/lib/rubocop/cop/lint/float_comparison.rb +1 -1
  214. data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
  215. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +14 -7
  216. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +16 -18
  217. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +2 -2
  218. data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +17 -5
  219. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -1
  220. data/lib/rubocop/cop/lint/inherit_exception.rb +19 -28
  221. data/lib/rubocop/cop/lint/interpolation_check.rb +6 -5
  222. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +10 -3
  223. data/lib/rubocop/cop/lint/literal_as_condition.rb +6 -1
  224. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +5 -1
  225. data/lib/rubocop/cop/lint/loop.rb +2 -2
  226. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +19 -4
  227. data/lib/rubocop/cop/lint/missing_super.rb +1 -1
  228. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -0
  229. data/lib/rubocop/cop/lint/nested_method_definition.rb +58 -6
  230. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
  231. data/lib/rubocop/cop/lint/next_without_accumulator.rb +25 -6
  232. data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +162 -0
  233. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +17 -5
  234. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
  235. data/lib/rubocop/cop/lint/number_conversion.rb +37 -12
  236. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +1 -1
  237. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +2 -3
  238. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +4 -5
  239. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +20 -1
  240. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +17 -8
  241. data/lib/rubocop/cop/lint/percent_string_array.rb +1 -1
  242. data/lib/rubocop/cop/lint/percent_symbol_array.rb +1 -1
  243. data/lib/rubocop/cop/lint/raise_exception.rb +2 -2
  244. data/lib/rubocop/cop/lint/rand_one.rb +1 -1
  245. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +44 -10
  246. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +3 -3
  247. data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +12 -0
  248. data/lib/rubocop/cop/lint/redundant_require_statement.rb +48 -7
  249. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +16 -3
  250. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +1 -1
  251. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -1
  252. data/lib/rubocop/cop/lint/redundant_with_index.rb +14 -11
  253. data/lib/rubocop/cop/lint/redundant_with_object.rb +13 -12
  254. data/lib/rubocop/cop/lint/refinement_import_methods.rb +51 -0
  255. data/lib/rubocop/cop/lint/regexp_as_condition.rb +9 -3
  256. data/lib/rubocop/cop/lint/require_parentheses.rb +4 -2
  257. data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
  258. data/lib/rubocop/cop/lint/require_relative_self_path.rb +1 -0
  259. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  260. data/lib/rubocop/cop/lint/return_in_void_context.rb +6 -18
  261. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +44 -8
  262. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +1 -1
  263. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
  264. data/lib/rubocop/cop/lint/script_permission.rb +1 -1
  265. data/lib/rubocop/cop/lint/self_assignment.rb +1 -1
  266. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +5 -4
  267. data/lib/rubocop/cop/lint/shadowed_argument.rb +1 -1
  268. data/lib/rubocop/cop/lint/shadowed_exception.rb +16 -11
  269. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +36 -1
  270. data/lib/rubocop/cop/lint/struct_new_override.rb +3 -3
  271. data/lib/rubocop/cop/lint/suppressed_exception.rb +2 -2
  272. data/lib/rubocop/cop/lint/symbol_conversion.rb +4 -3
  273. data/lib/rubocop/cop/lint/syntax.rb +2 -3
  274. data/lib/rubocop/cop/lint/to_enum_arguments.rb +1 -1
  275. data/lib/rubocop/cop/lint/to_json.rb +1 -1
  276. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
  277. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +2 -2
  278. data/lib/rubocop/cop/lint/triple_quotes.rb +1 -1
  279. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +1 -1
  280. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +1 -1
  281. data/lib/rubocop/cop/lint/unified_integer.rb +3 -1
  282. data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
  283. data/lib/rubocop/cop/lint/unreachable_loop.rb +13 -7
  284. data/lib/rubocop/cop/lint/unused_block_argument.rb +1 -1
  285. data/lib/rubocop/cop/lint/unused_method_argument.rb +8 -3
  286. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
  287. data/lib/rubocop/cop/lint/uri_regexp.rb +1 -1
  288. data/lib/rubocop/cop/lint/useless_access_modifier.rb +15 -10
  289. data/lib/rubocop/cop/lint/useless_assignment.rb +1 -1
  290. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +2 -3
  291. data/lib/rubocop/cop/lint/useless_method_definition.rb +4 -4
  292. data/lib/rubocop/cop/lint/useless_rescue.rb +85 -0
  293. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +127 -0
  294. data/lib/rubocop/cop/lint/useless_setter_call.rb +2 -2
  295. data/lib/rubocop/cop/lint/useless_times.rb +15 -11
  296. data/lib/rubocop/cop/lint/void.rb +27 -16
  297. data/lib/rubocop/cop/metrics/abc_size.rb +5 -3
  298. data/lib/rubocop/cop/metrics/block_length.rb +18 -12
  299. data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
  300. data/lib/rubocop/cop/metrics/class_length.rb +10 -5
  301. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +2 -11
  302. data/lib/rubocop/cop/metrics/method_length.rb +19 -12
  303. data/lib/rubocop/cop/metrics/module_length.rb +11 -6
  304. data/lib/rubocop/cop/metrics/parameter_lists.rb +33 -3
  305. data/lib/rubocop/cop/metrics/perceived_complexity.rb +2 -2
  306. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +5 -9
  307. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +29 -7
  308. data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +1 -1
  309. data/lib/rubocop/cop/mixin/alignment.rb +2 -2
  310. data/lib/rubocop/cop/mixin/allowed_identifiers.rb +2 -2
  311. data/lib/rubocop/cop/mixin/allowed_methods.rb +23 -2
  312. data/lib/rubocop/cop/mixin/allowed_pattern.rb +56 -0
  313. data/lib/rubocop/cop/mixin/annotation_comment.rb +13 -6
  314. data/lib/rubocop/cop/mixin/check_line_breakable.rb +5 -1
  315. data/lib/rubocop/cop/mixin/comments_help.rb +42 -2
  316. data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +21 -9
  317. data/lib/rubocop/cop/mixin/def_node.rb +2 -7
  318. data/lib/rubocop/cop/mixin/duplication.rb +1 -1
  319. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +1 -2
  320. data/lib/rubocop/cop/mixin/enforce_superclass.rb +7 -1
  321. data/lib/rubocop/cop/mixin/first_element_line_break.rb +11 -7
  322. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +4 -0
  323. data/lib/rubocop/cop/mixin/gemspec_help.rb +30 -0
  324. data/lib/rubocop/cop/mixin/hash_alignment_styles.rb +4 -3
  325. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +221 -0
  326. data/lib/rubocop/cop/mixin/hash_transform_method.rb +13 -9
  327. data/lib/rubocop/cop/mixin/line_length_help.rb +28 -8
  328. data/lib/rubocop/cop/mixin/method_complexity.rb +13 -16
  329. data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +35 -13
  330. data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +5 -3
  331. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +4 -3
  332. data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +1 -1
  333. data/lib/rubocop/cop/mixin/percent_array.rb +58 -1
  334. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +1 -1
  335. data/lib/rubocop/cop/mixin/preferred_delimiters.rb +2 -2
  336. data/lib/rubocop/cop/mixin/range_help.rb +33 -7
  337. data/lib/rubocop/cop/mixin/require_library.rb +2 -0
  338. data/lib/rubocop/cop/mixin/rescue_node.rb +5 -3
  339. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +1 -1
  340. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +1 -1
  341. data/lib/rubocop/cop/mixin/statement_modifier.rb +18 -3
  342. data/lib/rubocop/cop/mixin/string_help.rb +1 -1
  343. data/lib/rubocop/cop/mixin/surrounding_space.rb +17 -13
  344. data/lib/rubocop/cop/mixin/trailing_body.rb +1 -1
  345. data/lib/rubocop/cop/mixin/trailing_comma.rb +2 -2
  346. data/lib/rubocop/cop/mixin/visibility_help.rb +40 -5
  347. data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
  348. data/lib/rubocop/cop/naming/ascii_identifiers.rb +1 -1
  349. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
  350. data/lib/rubocop/cop/naming/block_forwarding.rb +125 -0
  351. data/lib/rubocop/cop/naming/block_parameter_name.rb +2 -2
  352. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +4 -2
  353. data/lib/rubocop/cop/naming/constant_name.rb +3 -3
  354. data/lib/rubocop/cop/naming/file_name.rb +39 -6
  355. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +1 -1
  356. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +1 -1
  357. data/lib/rubocop/cop/naming/inclusive_language.rb +8 -4
  358. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +1 -1
  359. data/lib/rubocop/cop/naming/method_name.rb +6 -6
  360. data/lib/rubocop/cop/naming/method_parameter_name.rb +2 -2
  361. data/lib/rubocop/cop/naming/predicate_name.rb +32 -3
  362. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +1 -1
  363. data/lib/rubocop/cop/naming/variable_name.rb +10 -1
  364. data/lib/rubocop/cop/naming/variable_number.rb +28 -18
  365. data/lib/rubocop/cop/offense.rb +1 -1
  366. data/lib/rubocop/cop/registry.rb +70 -44
  367. data/lib/rubocop/cop/security/compound_hash.rb +106 -0
  368. data/lib/rubocop/cop/security/eval.rb +1 -1
  369. data/lib/rubocop/cop/security/json_load.rb +2 -2
  370. data/lib/rubocop/cop/security/marshal_load.rb +1 -1
  371. data/lib/rubocop/cop/security/open.rb +11 -1
  372. data/lib/rubocop/cop/security/yaml_load.rb +11 -5
  373. data/lib/rubocop/cop/style/access_modifier_declarations.rb +92 -3
  374. data/lib/rubocop/cop/style/accessor_grouping.rb +11 -7
  375. data/lib/rubocop/cop/style/alias.rb +13 -5
  376. data/lib/rubocop/cop/style/and_or.rb +12 -12
  377. data/lib/rubocop/cop/style/arguments_forwarding.rb +4 -3
  378. data/lib/rubocop/cop/style/array_coercion.rb +1 -1
  379. data/lib/rubocop/cop/style/array_intersect.rb +111 -0
  380. data/lib/rubocop/cop/style/array_join.rb +1 -1
  381. data/lib/rubocop/cop/style/ascii_comments.rb +1 -1
  382. data/lib/rubocop/cop/style/attr.rb +1 -1
  383. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +1 -1
  384. data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
  385. data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +1 -1
  386. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +1 -1
  387. data/lib/rubocop/cop/style/block_comments.rb +2 -2
  388. data/lib/rubocop/cop/style/block_delimiters.rb +43 -11
  389. data/lib/rubocop/cop/style/case_equality.rb +41 -11
  390. data/lib/rubocop/cop/style/case_like_if.rb +2 -2
  391. data/lib/rubocop/cop/style/character_literal.rb +10 -3
  392. data/lib/rubocop/cop/style/class_and_module_children.rb +8 -15
  393. data/lib/rubocop/cop/style/class_check.rb +1 -1
  394. data/lib/rubocop/cop/style/class_equality_comparison.rb +55 -6
  395. data/lib/rubocop/cop/style/class_methods.rb +1 -1
  396. data/lib/rubocop/cop/style/class_methods_definitions.rb +3 -2
  397. data/lib/rubocop/cop/style/class_vars.rb +1 -1
  398. data/lib/rubocop/cop/style/collection_compact.rb +45 -18
  399. data/lib/rubocop/cop/style/collection_methods.rb +3 -1
  400. data/lib/rubocop/cop/style/colon_method_call.rb +1 -1
  401. data/lib/rubocop/cop/style/colon_method_definition.rb +1 -1
  402. data/lib/rubocop/cop/style/combinable_loops.rb +6 -4
  403. data/lib/rubocop/cop/style/command_literal.rb +2 -2
  404. data/lib/rubocop/cop/style/comment_annotation.rb +1 -1
  405. data/lib/rubocop/cop/style/commented_keyword.rb +9 -7
  406. data/lib/rubocop/cop/style/comparable_clamp.rb +125 -0
  407. data/lib/rubocop/cop/style/concat_array_literals.rb +86 -0
  408. data/lib/rubocop/cop/style/conditional_assignment.rb +2 -7
  409. data/lib/rubocop/cop/style/constant_visibility.rb +1 -1
  410. data/lib/rubocop/cop/style/date_time.rb +2 -2
  411. data/lib/rubocop/cop/style/def_with_parentheses.rb +17 -12
  412. data/lib/rubocop/cop/style/dir.rb +4 -1
  413. data/lib/rubocop/cop/style/documentation.rb +13 -7
  414. data/lib/rubocop/cop/style/documentation_method.rb +7 -1
  415. data/lib/rubocop/cop/style/double_negation.rb +62 -3
  416. data/lib/rubocop/cop/style/each_for_simple_loop.rb +42 -7
  417. data/lib/rubocop/cop/style/each_with_object.rb +40 -9
  418. data/lib/rubocop/cop/style/empty_block_parameter.rb +2 -2
  419. data/lib/rubocop/cop/style/empty_case_condition.rb +13 -4
  420. data/lib/rubocop/cop/style/empty_else.rb +40 -3
  421. data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
  422. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +2 -2
  423. data/lib/rubocop/cop/style/empty_literal.rb +2 -2
  424. data/lib/rubocop/cop/style/empty_method.rb +19 -4
  425. data/lib/rubocop/cop/style/encoding.rb +2 -2
  426. data/lib/rubocop/cop/style/end_block.rb +1 -1
  427. data/lib/rubocop/cop/style/endless_method.rb +2 -2
  428. data/lib/rubocop/cop/style/env_home.rb +56 -0
  429. data/lib/rubocop/cop/style/eval_with_location.rb +1 -1
  430. data/lib/rubocop/cop/style/even_odd.rb +1 -1
  431. data/lib/rubocop/cop/style/expand_path_arguments.rb +1 -1
  432. data/lib/rubocop/cop/style/explicit_block_argument.rb +6 -2
  433. data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
  434. data/lib/rubocop/cop/style/fetch_env_var.rb +132 -0
  435. data/lib/rubocop/cop/style/file_read.rb +112 -0
  436. data/lib/rubocop/cop/style/file_write.rb +136 -0
  437. data/lib/rubocop/cop/style/float_division.rb +1 -1
  438. data/lib/rubocop/cop/style/for.rb +7 -1
  439. data/lib/rubocop/cop/style/format_string.rb +1 -1
  440. data/lib/rubocop/cop/style/format_string_token.rb +74 -23
  441. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +6 -3
  442. data/lib/rubocop/cop/style/global_std_stream.rb +1 -1
  443. data/lib/rubocop/cop/style/global_vars.rb +1 -1
  444. data/lib/rubocop/cop/style/guard_clause.rb +159 -25
  445. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +2 -1
  446. data/lib/rubocop/cop/style/hash_conversion.rb +3 -2
  447. data/lib/rubocop/cop/style/hash_each_methods.rb +49 -13
  448. data/lib/rubocop/cop/style/hash_except.rb +89 -9
  449. data/lib/rubocop/cop/style/hash_like_case.rb +1 -1
  450. data/lib/rubocop/cop/style/hash_syntax.rb +60 -3
  451. data/lib/rubocop/cop/style/hash_transform_keys.rb +12 -7
  452. data/lib/rubocop/cop/style/hash_transform_values.rb +10 -7
  453. data/lib/rubocop/cop/style/identical_conditional_branches.rb +19 -4
  454. data/lib/rubocop/cop/style/if_inside_else.rb +15 -0
  455. data/lib/rubocop/cop/style/if_unless_modifier.rb +6 -5
  456. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +30 -5
  457. data/lib/rubocop/cop/style/if_with_semicolon.rb +4 -4
  458. data/lib/rubocop/cop/style/implicit_runtime_error.rb +3 -3
  459. data/lib/rubocop/cop/style/in_pattern_then.rb +1 -1
  460. data/lib/rubocop/cop/style/infinite_loop.rb +2 -5
  461. data/lib/rubocop/cop/style/inline_comment.rb +1 -1
  462. data/lib/rubocop/cop/style/inverse_methods.rb +12 -8
  463. data/lib/rubocop/cop/style/invertible_unless_condition.rb +114 -0
  464. data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
  465. data/lib/rubocop/cop/style/keyword_parameters_order.rb +2 -2
  466. data/lib/rubocop/cop/style/lambda.rb +1 -1
  467. data/lib/rubocop/cop/style/lambda_call.rb +13 -21
  468. data/lib/rubocop/cop/style/line_end_concatenation.rb +7 -4
  469. data/lib/rubocop/cop/style/magic_comment_format.rb +307 -0
  470. data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
  471. data/lib/rubocop/cop/style/map_to_hash.rb +68 -0
  472. data/lib/rubocop/cop/style/map_to_set.rb +61 -0
  473. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +57 -17
  474. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +6 -2
  475. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +15 -13
  476. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +22 -3
  477. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +5 -2
  478. data/lib/rubocop/cop/style/method_def_parentheses.rb +25 -14
  479. data/lib/rubocop/cop/style/min_max.rb +1 -1
  480. data/lib/rubocop/cop/style/min_max_comparison.rb +83 -0
  481. data/lib/rubocop/cop/style/missing_else.rb +37 -25
  482. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +1 -1
  483. data/lib/rubocop/cop/style/mixin_grouping.rb +2 -2
  484. data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
  485. data/lib/rubocop/cop/style/module_function.rb +30 -8
  486. data/lib/rubocop/cop/style/multiline_block_chain.rb +4 -2
  487. data/lib/rubocop/cop/style/multiline_if_modifier.rb +2 -6
  488. data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
  489. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +4 -6
  490. data/lib/rubocop/cop/style/multiline_memoization.rb +3 -3
  491. data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
  492. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +52 -11
  493. data/lib/rubocop/cop/style/multiline_when_then.rb +3 -5
  494. data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
  495. data/lib/rubocop/cop/style/mutable_constant.rb +1 -1
  496. data/lib/rubocop/cop/style/negated_if_else_condition.rb +9 -7
  497. data/lib/rubocop/cop/style/nested_file_dirname.rb +66 -0
  498. data/lib/rubocop/cop/style/nested_modifier.rb +1 -1
  499. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +11 -2
  500. data/lib/rubocop/cop/style/nested_ternary_operator.rb +20 -8
  501. data/lib/rubocop/cop/style/next.rb +4 -6
  502. data/lib/rubocop/cop/style/nil_comparison.rb +1 -1
  503. data/lib/rubocop/cop/style/nil_lambda.rb +4 -4
  504. data/lib/rubocop/cop/style/non_nil_check.rb +1 -1
  505. data/lib/rubocop/cop/style/not.rb +2 -2
  506. data/lib/rubocop/cop/style/numbered_parameters.rb +1 -1
  507. data/lib/rubocop/cop/style/numbered_parameters_limit.rb +12 -4
  508. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +1 -1
  509. data/lib/rubocop/cop/style/numeric_literals.rb +26 -2
  510. data/lib/rubocop/cop/style/numeric_predicate.rb +53 -11
  511. data/lib/rubocop/cop/style/object_then.rb +74 -0
  512. data/lib/rubocop/cop/style/one_line_conditional.rb +16 -40
  513. data/lib/rubocop/cop/style/open_struct_use.rb +69 -0
  514. data/lib/rubocop/cop/style/operator_method_call.rb +67 -0
  515. data/lib/rubocop/cop/style/option_hash.rb +1 -1
  516. data/lib/rubocop/cop/style/optional_arguments.rb +2 -2
  517. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +5 -4
  518. data/lib/rubocop/cop/style/or_assignment.rb +1 -1
  519. data/lib/rubocop/cop/style/parallel_assignment.rb +3 -1
  520. data/lib/rubocop/cop/style/parentheses_around_condition.rb +13 -3
  521. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -1
  522. data/lib/rubocop/cop/style/percent_q_literals.rb +1 -1
  523. data/lib/rubocop/cop/style/perl_backrefs.rb +23 -2
  524. data/lib/rubocop/cop/style/preferred_hash_methods.rb +1 -1
  525. data/lib/rubocop/cop/style/proc.rb +5 -2
  526. data/lib/rubocop/cop/style/quoted_symbols.rb +22 -8
  527. data/lib/rubocop/cop/style/raise_args.rb +10 -4
  528. data/lib/rubocop/cop/style/random_with_offset.rb +1 -1
  529. data/lib/rubocop/cop/style/redundant_argument.rb +10 -4
  530. data/lib/rubocop/cop/style/redundant_assignment.rb +1 -1
  531. data/lib/rubocop/cop/style/redundant_begin.rb +22 -12
  532. data/lib/rubocop/cop/style/redundant_capital_w.rb +2 -3
  533. data/lib/rubocop/cop/style/redundant_condition.rb +147 -13
  534. data/lib/rubocop/cop/style/redundant_conditional.rb +1 -5
  535. data/lib/rubocop/cop/style/redundant_constant_base.rb +85 -0
  536. data/lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb +45 -0
  537. data/lib/rubocop/cop/style/redundant_each.rb +116 -0
  538. data/lib/rubocop/cop/style/redundant_exception.rb +1 -1
  539. data/lib/rubocop/cop/style/redundant_fetch_block.rb +2 -2
  540. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +1 -1
  541. data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
  542. data/lib/rubocop/cop/style/redundant_heredoc_delimiter_quotes.rb +58 -0
  543. data/lib/rubocop/cop/style/redundant_initialize.rb +156 -0
  544. data/lib/rubocop/cop/style/redundant_interpolation.rb +39 -4
  545. data/lib/rubocop/cop/style/redundant_parentheses.rb +22 -24
  546. data/lib/rubocop/cop/style/redundant_percent_q.rb +1 -1
  547. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +20 -4
  548. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +15 -5
  549. data/lib/rubocop/cop/style/redundant_return.rb +9 -2
  550. data/lib/rubocop/cop/style/redundant_self.rb +4 -2
  551. data/lib/rubocop/cop/style/redundant_self_assignment.rb +3 -4
  552. data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +1 -1
  553. data/lib/rubocop/cop/style/redundant_sort.rb +23 -8
  554. data/lib/rubocop/cop/style/redundant_sort_by.rb +25 -9
  555. data/lib/rubocop/cop/style/redundant_string_escape.rb +184 -0
  556. data/lib/rubocop/cop/style/regexp_literal.rb +1 -1
  557. data/lib/rubocop/cop/style/require_order.rb +135 -0
  558. data/lib/rubocop/cop/style/rescue_modifier.rb +2 -2
  559. data/lib/rubocop/cop/style/rescue_standard_error.rb +13 -13
  560. data/lib/rubocop/cop/style/return_nil.rb +1 -1
  561. data/lib/rubocop/cop/style/safe_navigation.rb +57 -22
  562. data/lib/rubocop/cop/style/sample.rb +6 -4
  563. data/lib/rubocop/cop/style/select_by_regexp.rb +57 -11
  564. data/lib/rubocop/cop/style/self_assignment.rb +3 -3
  565. data/lib/rubocop/cop/style/semicolon.rb +53 -6
  566. data/lib/rubocop/cop/style/send.rb +1 -1
  567. data/lib/rubocop/cop/style/signal_exception.rb +9 -7
  568. data/lib/rubocop/cop/style/single_argument_dig.rb +5 -0
  569. data/lib/rubocop/cop/style/single_line_block_params.rb +4 -4
  570. data/lib/rubocop/cop/style/single_line_methods.rb +2 -2
  571. data/lib/rubocop/cop/style/slicing_with_range.rb +1 -1
  572. data/lib/rubocop/cop/style/sole_nested_conditional.rb +99 -31
  573. data/lib/rubocop/cop/style/special_global_vars.rb +66 -8
  574. data/lib/rubocop/cop/style/static_class.rb +33 -2
  575. data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
  576. data/lib/rubocop/cop/style/string_chars.rb +1 -1
  577. data/lib/rubocop/cop/style/string_concatenation.rb +13 -8
  578. data/lib/rubocop/cop/style/string_hash_keys.rb +5 -2
  579. data/lib/rubocop/cop/style/string_literals.rb +1 -5
  580. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +1 -1
  581. data/lib/rubocop/cop/style/string_methods.rb +1 -1
  582. data/lib/rubocop/cop/style/strip.rb +1 -1
  583. data/lib/rubocop/cop/style/struct_inheritance.rb +4 -4
  584. data/lib/rubocop/cop/style/swap_values.rb +4 -2
  585. data/lib/rubocop/cop/style/symbol_array.rb +12 -7
  586. data/lib/rubocop/cop/style/symbol_literal.rb +1 -1
  587. data/lib/rubocop/cop/style/symbol_proc.rb +68 -12
  588. data/lib/rubocop/cop/style/ternary_parentheses.rb +19 -18
  589. data/lib/rubocop/cop/style/top_level_method_definition.rb +3 -1
  590. data/lib/rubocop/cop/style/trailing_body_on_class.rb +1 -1
  591. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -1
  592. data/lib/rubocop/cop/style/trailing_body_on_module.rb +1 -1
  593. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +5 -5
  594. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +2 -2
  595. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +2 -2
  596. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +2 -2
  597. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +2 -5
  598. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +1 -1
  599. data/lib/rubocop/cop/style/trivial_accessors.rb +11 -9
  600. data/lib/rubocop/cop/style/unless_else.rb +5 -1
  601. data/lib/rubocop/cop/style/unless_logical_operators.rb +1 -1
  602. data/lib/rubocop/cop/style/unpack_first.rb +5 -2
  603. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  604. data/lib/rubocop/cop/style/when_then.rb +1 -1
  605. data/lib/rubocop/cop/style/word_array.rb +48 -6
  606. data/lib/rubocop/cop/style/yoda_condition.rb +13 -6
  607. data/lib/rubocop/cop/style/yoda_expression.rb +90 -0
  608. data/lib/rubocop/cop/style/zero_length_predicate.rb +32 -15
  609. data/lib/rubocop/cop/team.rb +55 -51
  610. data/lib/rubocop/cop/util.rb +54 -8
  611. data/lib/rubocop/cop/variable_force/assignment.rb +1 -1
  612. data/lib/rubocop/cop/variable_force/branch.rb +1 -1
  613. data/lib/rubocop/cop/variable_force/scope.rb +3 -3
  614. data/lib/rubocop/cop/variable_force/variable_table.rb +4 -2
  615. data/lib/rubocop/cop/variable_force.rb +19 -35
  616. data/lib/rubocop/cops_documentation_generator.rb +56 -16
  617. data/lib/rubocop/directive_comment.rb +1 -1
  618. data/lib/rubocop/ext/processed_source.rb +2 -0
  619. data/lib/rubocop/ext/range.rb +15 -0
  620. data/lib/rubocop/feature_loader.rb +94 -0
  621. data/lib/rubocop/file_patterns.rb +43 -0
  622. data/lib/rubocop/formatter/clang_style_formatter.rb +1 -1
  623. data/lib/rubocop/formatter/disabled_config_formatter.rb +45 -11
  624. data/lib/rubocop/formatter/formatter_set.rb +20 -18
  625. data/lib/rubocop/formatter/git_hub_actions_formatter.rb +15 -2
  626. data/lib/rubocop/formatter/html_formatter.rb +11 -16
  627. data/lib/rubocop/formatter/json_formatter.rb +4 -1
  628. data/lib/rubocop/formatter/markdown_formatter.rb +78 -0
  629. data/lib/rubocop/formatter/offense_count_formatter.rb +15 -6
  630. data/lib/rubocop/formatter/simple_text_formatter.rb +9 -8
  631. data/lib/rubocop/formatter/tap_formatter.rb +1 -1
  632. data/lib/rubocop/formatter/worst_offenders_formatter.rb +6 -4
  633. data/lib/rubocop/formatter.rb +34 -0
  634. data/lib/rubocop/magic_comment.rb +31 -5
  635. data/lib/rubocop/options.rb +164 -51
  636. data/lib/rubocop/path_util.rb +50 -22
  637. data/lib/rubocop/rake_task.rb +35 -10
  638. data/lib/rubocop/remote_config.rb +2 -4
  639. data/lib/rubocop/result_cache.rb +28 -17
  640. data/lib/rubocop/rspec/cop_helper.rb +26 -3
  641. data/lib/rubocop/rspec/expect_offense.rb +9 -7
  642. data/lib/rubocop/rspec/parallel_formatter.rb +90 -0
  643. data/lib/rubocop/rspec/shared_contexts.rb +47 -10
  644. data/lib/rubocop/rspec/support.rb +16 -1
  645. data/lib/rubocop/runner.rb +108 -27
  646. data/lib/rubocop/server/cache.rb +155 -0
  647. data/lib/rubocop/server/cli.rb +147 -0
  648. data/lib/rubocop/server/client_command/base.rb +44 -0
  649. data/lib/rubocop/server/client_command/exec.rb +64 -0
  650. data/lib/rubocop/server/client_command/restart.rb +25 -0
  651. data/lib/rubocop/server/client_command/start.rb +48 -0
  652. data/lib/rubocop/server/client_command/status.rb +28 -0
  653. data/lib/rubocop/server/client_command/stop.rb +31 -0
  654. data/lib/rubocop/server/client_command.rb +26 -0
  655. data/lib/rubocop/server/core.rb +111 -0
  656. data/lib/rubocop/server/errors.rb +23 -0
  657. data/lib/rubocop/server/helper.rb +34 -0
  658. data/lib/rubocop/server/server_command/base.rb +50 -0
  659. data/lib/rubocop/server/server_command/exec.rb +34 -0
  660. data/lib/rubocop/server/server_command/stop.rb +24 -0
  661. data/lib/rubocop/server/server_command.rb +21 -0
  662. data/lib/rubocop/server/socket_reader.rb +69 -0
  663. data/lib/rubocop/server.rb +53 -0
  664. data/lib/rubocop/string_interpreter.rb +4 -4
  665. data/lib/rubocop/target_finder.rb +2 -2
  666. data/lib/rubocop/target_ruby.rb +15 -8
  667. data/lib/rubocop/version.rb +22 -9
  668. data/lib/rubocop/yaml_duplication_checker.rb +1 -1
  669. data/lib/rubocop.rb +64 -35
  670. metadata +124 -40
  671. data/lib/rubocop/cop/gemspec/date_assignment.rb +0 -57
  672. data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -52
  673. data/lib/rubocop/cop/mixin/ignored_pattern.rb +0 -29
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for non-local exits from iterators without a return
6
+ # Checks for non-local exits from iterators without a return
7
7
  # value. It registers an offense under these conditions:
8
8
  #
9
9
  # * No value is returned,
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop warns the usage of unsafe number conversions. Unsafe
6
+ # Warns the usage of unsafe number conversions. Unsafe
7
7
  # number conversion can cause unexpected error if auto type conversion
8
8
  # fails. Cop prefer parsing with number class instead.
9
9
  #
@@ -16,7 +16,8 @@ module RuboCop
16
16
  # NOTE: Some values cannot be converted properly using one of the `Kernel`
17
17
  # method (for instance, `Time` and `DateTime` values are allowed by this
18
18
  # cop by default). Similarly, Rails' duration methods do not work well
19
- # with `Integer()` and can be ignored with `IgnoredMethods`.
19
+ # with `Integer()` and can be allowed with `AllowedMethods`. By default,
20
+ # there are no methods to allowed.
20
21
  #
21
22
  # @safety
22
23
  # Autocorrection is unsafe because it is not guaranteed that the
@@ -30,6 +31,7 @@ module RuboCop
30
31
  # '10'.to_i
31
32
  # '10.2'.to_f
32
33
  # '10'.to_c
34
+ # '1/3'.to_r
33
35
  # ['1', '2', '3'].map(&:to_i)
34
36
  # foo.try(:to_f)
35
37
  # bar.send(:to_c)
@@ -39,11 +41,27 @@ module RuboCop
39
41
  # Integer('10', 10)
40
42
  # Float('10.2')
41
43
  # Complex('10')
44
+ # Rational('1/3')
42
45
  # ['1', '2', '3'].map { |i| Integer(i, 10) }
43
46
  # foo.try { |i| Float(i) }
44
47
  # bar.send { |i| Complex(i) }
45
48
  #
46
- # @example IgnoredMethods: [minutes]
49
+ # @example AllowedMethods: [] (default)
50
+ #
51
+ # # bad
52
+ # 10.minutes.to_i
53
+ #
54
+ # @example AllowedMethods: [minutes]
55
+ #
56
+ # # good
57
+ # 10.minutes.to_i
58
+ #
59
+ # @example AllowedPatterns: [] (default)
60
+ #
61
+ # # bad
62
+ # 10.minutes.to_i
63
+ #
64
+ # @example AllowedPatterns: ['min*']
47
65
  #
48
66
  # # good
49
67
  # 10.minutes.to_i
@@ -54,18 +72,20 @@ module RuboCop
54
72
  # Time.now.to_datetime.to_i
55
73
  class NumberConversion < Base
56
74
  extend AutoCorrector
57
- include IgnoredMethods
75
+ include AllowedMethods
76
+ include AllowedPattern
58
77
 
59
78
  CONVERSION_METHOD_CLASS_MAPPING = {
60
79
  to_i: "#{Integer.name}(%<number_object>s, 10)",
61
80
  to_f: "#{Float.name}(%<number_object>s)",
62
- to_c: "#{Complex.name}(%<number_object>s)"
81
+ to_c: "#{Complex.name}(%<number_object>s)",
82
+ to_r: "#{Rational.name}(%<number_object>s)"
63
83
  }.freeze
64
- MSG = 'Replace unsafe number conversion with number '\
65
- 'class parsing, instead of using '\
66
- '`%<current>s`, use stricter '\
84
+ MSG = 'Replace unsafe number conversion with number ' \
85
+ 'class parsing, instead of using ' \
86
+ '`%<current>s`, use stricter ' \
67
87
  '`%<corrected_method>s`.'
68
- CONVERSION_METHODS = %i[Integer Float Complex to_i to_f to_c].freeze
88
+ CONVERSION_METHODS = %i[Integer Float Complex Rational to_i to_f to_c to_r].freeze
69
89
  METHODS = CONVERSION_METHOD_CLASS_MAPPING.keys.map(&:inspect).join(' ')
70
90
 
71
91
  # @!method to_method(node)
@@ -88,7 +108,7 @@ module RuboCop
88
108
 
89
109
  def handle_conversion_method(node)
90
110
  to_method(node) do |receiver, to_method|
91
- next if receiver.nil? || ignore_receiver?(receiver)
111
+ next if receiver.nil? || allow_receiver?(receiver)
92
112
 
93
113
  message = format(
94
114
  MSG,
@@ -132,9 +152,10 @@ module RuboCop
132
152
  corrector.remove(node.loc.end)
133
153
  end
134
154
 
135
- def ignore_receiver?(receiver)
155
+ def allow_receiver?(receiver)
136
156
  if receiver.numeric_type? || (receiver.send_type? &&
137
- (conversion_method?(receiver.method_name) || ignored_method?(receiver.method_name)))
157
+ (conversion_method?(receiver.method_name) ||
158
+ allowed_method_name?(receiver.method_name)))
138
159
  true
139
160
  elsif (receiver = top_receiver(receiver))
140
161
  receiver.const_type? && ignored_class?(receiver.const_name)
@@ -143,6 +164,10 @@ module RuboCop
143
164
  end
144
165
  end
145
166
 
167
+ def allowed_method_name?(name)
168
+ allowed_method?(name) || matches_allowed_pattern?(name)
169
+ end
170
+
146
171
  def top_receiver(node)
147
172
  receiver = node
148
173
  receiver = receiver.receiver until receiver.receiver.nil?
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for uses of numbered parameter assignment.
6
+ # Checks for uses of numbered parameter assignment.
7
7
  # It emulates the following warning in Ruby 2.7:
8
8
  #
9
9
  # % ruby -ve '_1 = :value'
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for unintended or-assignment to a constant.
6
+ # Checks for unintended or-assignment to a constant.
7
7
  #
8
8
  # Constants should always be assigned in the same location. And its value
9
9
  # should always be the same. If constants are assigned in multiple
@@ -11,8 +11,7 @@ module RuboCop
11
11
  #
12
12
  # @safety
13
13
  # This cop is unsafe because code that is already conditionally
14
- # assigning a constant may have its behaviour changed by
15
- # auto-correction.
14
+ # assigning a constant may have its behavior changed by autocorrection.
16
15
  #
17
16
  # @example
18
17
  #
@@ -7,6 +7,9 @@ module RuboCop
7
7
  # Checks the proper ordering of magic comments and whether
8
8
  # a magic comment is not placed before a shebang.
9
9
  #
10
+ # @safety
11
+ # This cop's autocorrection is unsafe because file encoding may change.
12
+ #
10
13
  # @example
11
14
  # # bad
12
15
  #
@@ -61,7 +64,7 @@ module RuboCop
61
64
  def magic_comment_lines
62
65
  lines = [nil, nil]
63
66
 
64
- magic_comments.each.with_index do |comment, index|
67
+ leading_magic_comments.each.with_index do |comment, index|
65
68
  if comment.encoding_specified?
66
69
  lines[0] = index
67
70
  elsif comment.frozen_string_literal_specified?
@@ -73,10 +76,6 @@ module RuboCop
73
76
 
74
77
  lines
75
78
  end
76
-
77
- def magic_comments
78
- leading_comment_lines.map { |line| MagicComment.parse(line) }
79
- end
80
79
  end
81
80
  end
82
81
  end
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cops looks for references of Regexp captures that are out of range
6
+ # Looks for references of Regexp captures that are out of range
7
7
  # and thus always returns nil.
8
8
  #
9
9
  # @safety
@@ -68,6 +68,12 @@ module RuboCop
68
68
  @valid_ref = regexp_conditions.map { |condition| check_regexp(condition) }.compact.max
69
69
  end
70
70
 
71
+ def on_in_pattern(node)
72
+ regexp_patterns = patterns(node).select(&:regexp_type?)
73
+
74
+ @valid_ref = regexp_patterns.map { |pattern| check_regexp(pattern) }.compact.max
75
+ end
76
+
71
77
  def on_nth_ref(node)
72
78
  backref, = *node
73
79
  return if @valid_ref.nil? || backref <= @valid_ref
@@ -84,6 +90,19 @@ module RuboCop
84
90
 
85
91
  private
86
92
 
93
+ def patterns(pattern_node)
94
+ pattern = pattern_node.node_parts[0]
95
+
96
+ case pattern.type
97
+ when :array_pattern, :match_alt
98
+ pattern.children
99
+ when :match_as
100
+ patterns(pattern)
101
+ else
102
+ [pattern]
103
+ end
104
+ end
105
+
87
106
  def check_regexp(node)
88
107
  return if node.interpolation?
89
108
 
@@ -19,7 +19,7 @@ module RuboCop
19
19
  include RangeHelp
20
20
  extend AutoCorrector
21
21
 
22
- MSG = '`(...)` interpreted as grouped expression.'
22
+ MSG = '`%<argument>s` interpreted as grouped expression.'
23
23
 
24
24
  def on_send(node)
25
25
  return if valid_context?(node)
@@ -28,8 +28,9 @@ module RuboCop
28
28
  return unless space_length.positive?
29
29
 
30
30
  range = space_range(node.first_argument.source_range, space_length)
31
+ message = format(MSG, argument: node.first_argument.source)
31
32
 
32
- add_offense(range) { |corrector| corrector.remove(range) }
33
+ add_offense(range, message: message) { |corrector| corrector.remove(range) }
33
34
  end
34
35
  alias on_csend on_send
35
36
 
@@ -39,9 +40,18 @@ module RuboCop
39
40
  unless node.arguments.one? && first_argument_starts_with_left_parenthesis?(node)
40
41
  return true
41
42
  end
43
+ return true if first_argument_block_type?(node.first_argument)
42
44
 
43
45
  node.operator_method? || node.setter_method? || chained_calls?(node) ||
44
- operator_keyword?(node) || node.first_argument.hash_type?
46
+ valid_first_argument?(node.first_argument)
47
+ end
48
+
49
+ def first_argument_block_type?(first_arg)
50
+ first_arg.block_type? || first_arg.numblock_type?
51
+ end
52
+
53
+ def valid_first_argument?(first_arg)
54
+ first_arg.operator_keyword? || first_arg.hash_type? || ternary_expression?(first_arg)
45
55
  end
46
56
 
47
57
  def first_argument_starts_with_left_parenthesis?(node)
@@ -50,12 +60,11 @@ module RuboCop
50
60
 
51
61
  def chained_calls?(node)
52
62
  first_argument = node.first_argument
53
- first_argument.send_type? && (node.children.last&.children&.count || 0) > 1
63
+ first_argument.call_type? && (node.children.last&.children&.count || 0) > 1
54
64
  end
55
65
 
56
- def operator_keyword?(node)
57
- first_argument = node.first_argument
58
- first_argument.operator_keyword?
66
+ def ternary_expression?(node)
67
+ node.if_type? && node.ternary?
59
68
  end
60
69
 
61
70
  def spaces_before_left_parenthesis(node)
@@ -65,7 +74,7 @@ module RuboCop
65
74
  else
66
75
  0
67
76
  end
68
- without_receiver = node.source[receiver_length..-1]
77
+ without_receiver = node.source[receiver_length..]
69
78
 
70
79
  # Escape question mark if any.
71
80
  method_regexp = Regexp.escape(node.method_name)
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for quotes and commas in %w, e.g. `%w('foo', "bar")`
6
+ # Checks for quotes and commas in %w, e.g. `%w('foo', "bar")`
7
7
  #
8
8
  # It is more likely that the additional characters are unintended (for
9
9
  # example, mistranslating an array of literals to percent string notation)
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for colons and commas in %i, e.g. `%i(:foo, :bar)`
6
+ # Checks for colons and commas in %i, e.g. `%i(:foo, :bar)`
7
7
  #
8
8
  # It is more likely that the additional characters are unintended (for
9
9
  # example, mistranslating an array of literals to percent string notation)
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for `raise` or `fail` statements which are
6
+ # Checks for `raise` or `fail` statements which are
7
7
  # raising `Exception` class.
8
8
  #
9
9
  # You can specify a module name that will be an implicit namespace
@@ -15,7 +15,7 @@ module RuboCop
15
15
  #
16
16
  # @safety
17
17
  # This cop is unsafe because it will change the exception class being
18
- # raised, which is a change in behaviour.
18
+ # raised, which is a change in behavior.
19
19
  #
20
20
  # @example
21
21
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for `rand(1)` calls.
6
+ # Checks for `rand(1)` calls.
7
7
  # Such calls always return `0`.
8
8
  #
9
9
  # @example
@@ -6,7 +6,7 @@
6
6
  module RuboCop
7
7
  module Cop
8
8
  module Lint
9
- # This cop detects instances of rubocop:disable comments that can be
9
+ # Detects instances of rubocop:disable comments that can be
10
10
  # removed without causing any offenses to be reported. It's implemented
11
11
  # as a cop in that it inherits from the Cop base class and calls
12
12
  # add_offense. The unusual part of its implementation is that it doesn't
@@ -71,16 +71,16 @@ module RuboCop
71
71
  processed_source.comment_config.comment_only_line?(directive_comment_range.line) &&
72
72
  directive_comment_range.begin_pos == line_comment_range.begin_pos
73
73
  # When the previous line is blank, it should be retained
74
- range_with_surrounding_space(range: directive_comment_range, side: :right)
74
+ range_with_surrounding_space(directive_comment_range, side: :right)
75
75
  else
76
76
  # Eat the entire comment, the preceding space, and the preceding
77
77
  # newline if there is one.
78
78
  original_begin = directive_comment_range.begin_pos
79
79
  range = range_with_surrounding_space(
80
- range: directive_comment_range, side: :left, newlines: true
80
+ directive_comment_range, side: :left, newlines: true
81
81
  )
82
82
 
83
- range_with_surrounding_space(range: range,
83
+ range_with_surrounding_space(range,
84
84
  side: :right,
85
85
  # Special for a comment that
86
86
  # begins the file: remove
@@ -94,13 +94,13 @@ module RuboCop
94
94
  # is NOT being removed?
95
95
  if ends_its_line?(ranges.last) && trailing_range?(ranges, range)
96
96
  # Eat the comma on the left.
97
- range = range_with_surrounding_space(range: range, side: :left)
97
+ range = range_with_surrounding_space(range, side: :left)
98
98
  range = range_with_surrounding_comma(range, :left)
99
99
  end
100
100
 
101
101
  range = range_with_surrounding_comma(range, :right)
102
102
  # Eat following spaces up to EOL, but not the newline itself.
103
- range_with_surrounding_space(range: range, side: :right, newlines: false)
103
+ range_with_surrounding_space(range, side: :right, newlines: false)
104
104
  end
105
105
 
106
106
  def each_redundant_disable(&block)
@@ -113,6 +113,7 @@ module RuboCop
113
113
  def each_line_range(cop, line_ranges)
114
114
  line_ranges.each_with_index do |line_range, line_range_index|
115
115
  next if ignore_offense?(line_range)
116
+ next if expected_final_disable?(cop, line_range)
116
117
 
117
118
  comment = processed_source.comment_at_line(line_range.begin)
118
119
  redundant = if all_disabled?(comment)
@@ -127,23 +128,35 @@ module RuboCop
127
128
  end
128
129
  end
129
130
 
131
+ # rubocop:disable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
130
132
  def each_already_disabled(cop, line_ranges)
131
133
  line_ranges.each_cons(2) do |previous_range, range|
132
134
  next if ignore_offense?(range)
133
- next unless followed_ranges?(previous_range, range)
134
-
135
135
  # If a cop is disabled in a range that begins on the same line as
136
136
  # the end of the previous range, it means that the cop was
137
137
  # already disabled by an earlier comment. So it's redundant
138
138
  # whether there are offenses or not.
139
+ next unless followed_ranges?(previous_range, range)
140
+
139
141
  comment = processed_source.comment_at_line(range.begin)
140
142
 
143
+ next unless comment
141
144
  # Comments disabling all cops don't count since it's reasonable
142
145
  # to disable a few select cops first and then all cops further
143
146
  # down in the code.
144
- yield comment, cop if comment && !all_disabled?(comment)
147
+ next if all_disabled?(comment)
148
+
149
+ redundant =
150
+ if department_disabled?(cop, comment)
151
+ find_redundant_department(cop, range)
152
+ else
153
+ cop
154
+ end
155
+
156
+ yield comment, redundant if redundant
145
157
  end
146
158
  end
159
+ # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
147
160
 
148
161
  def find_redundant_cop(cop, range)
149
162
  cop_offenses = offenses_to_check.select { |offense| offense.cop_name == cop }
@@ -179,11 +192,21 @@ module RuboCop
179
192
  end
180
193
 
181
194
  def ignore_offense?(line_range)
195
+ return true if line_range.min == CommentConfig::CONFIG_DISABLED_LINE_RANGE_MIN
196
+
182
197
  disabled_ranges.any? do |range|
183
198
  range.cover?(line_range.min) && range.cover?(line_range.max)
184
199
  end
185
200
  end
186
201
 
202
+ def expected_final_disable?(cop, line_range)
203
+ # A cop which is disabled in the config is being re-disabled until end of file
204
+ cop_class = RuboCop::Cop::Registry.global.find_by_cop_name cop
205
+ cop_class &&
206
+ !processed_source.registry.enabled?(cop_class, config) &&
207
+ line_range.max == Float::INFINITY
208
+ end
209
+
187
210
  def department_disabled?(cop, comment)
188
211
  directive = DirectiveComment.new(comment)
189
212
  directive.in_directive_department?(cop) && !directive.overridden_by_department?(cop)
@@ -209,7 +232,12 @@ module RuboCop
209
232
 
210
233
  add_offense(location, message: message(cop_names)) do |corrector|
211
234
  range = comment_range_with_surrounding_space(location, comment.loc.expression)
212
- corrector.remove(range)
235
+
236
+ if leave_free_comment?(comment, range)
237
+ corrector.replace(range, ' # ')
238
+ else
239
+ corrector.remove(range)
240
+ end
213
241
  end
214
242
  end
215
243
 
@@ -227,6 +255,12 @@ module RuboCop
227
255
  end
228
256
  end
229
257
 
258
+ def leave_free_comment?(comment, range)
259
+ free_comment = comment.text.gsub(range.source.strip, '')
260
+
261
+ !free_comment.empty? && !free_comment.start_with?('#')
262
+ end
263
+
230
264
  def cop_range(comment, cop)
231
265
  cop = remove_department_marker(cop)
232
266
  matching_range(comment.loc.expression, cop) ||
@@ -9,7 +9,7 @@
9
9
  module RuboCop
10
10
  module Cop
11
11
  module Lint
12
- # This cop detects instances of rubocop:enable comments that can be
12
+ # Detects instances of rubocop:enable comments that can be
13
13
  # removed.
14
14
  #
15
15
  # When comment enables all cops at once `rubocop:enable all`
@@ -42,7 +42,7 @@ module RuboCop
42
42
  MSG = 'Unnecessary enabling of %<cop>s.'
43
43
 
44
44
  def on_new_investigation
45
- return if processed_source.blank?
45
+ return if processed_source.blank? || !processed_source.raw_source.include?('enable')
46
46
 
47
47
  offenses = processed_source.comment_config.extra_enabled_comments
48
48
  offenses.each { |comment, cop_names| register_offense(comment, cop_names) }
@@ -60,7 +60,7 @@ module RuboCop
60
60
  message: format(MSG, cop: all_or_name(name))
61
61
  ) do |corrector|
62
62
  if directive.match?(cop_names)
63
- corrector.remove(range_with_surrounding_space(range: directive.range, side: :right))
63
+ corrector.remove(range_with_surrounding_space(directive.range, side: :right))
64
64
  else
65
65
  corrector.remove(range_with_comma(comment, name))
66
66
  end
@@ -6,6 +6,11 @@ module RuboCop
6
6
  # Sort globbed results by default in Ruby 3.0.
7
7
  # This cop checks for redundant `sort` method to `Dir.glob` and `Dir[]`.
8
8
  #
9
+ # @safety
10
+ # This cop is unsafe, in case of having a file and a directory with
11
+ # identical names, since directory will be loaded before the file, which
12
+ # will break `exe/files.rb` that rely on `exe.rb` file.
13
+ #
9
14
  # @example
10
15
  #
11
16
  # # bad
@@ -36,6 +41,7 @@ module RuboCop
36
41
  return unless (receiver = node.receiver)
37
42
  return unless receiver.receiver&.const_type? && receiver.receiver.short_name == :Dir
38
43
  return unless GLOB_METHODS.include?(receiver.method_name)
44
+ return if multiple_argument?(receiver)
39
45
 
40
46
  selector = node.loc.selector
41
47
 
@@ -44,6 +50,12 @@ module RuboCop
44
50
  corrector.remove(node.loc.dot)
45
51
  end
46
52
  end
53
+
54
+ private
55
+
56
+ def multiple_argument?(glob_method)
57
+ glob_method.arguments.count >= 2 || glob_method.first_argument&.splat_type?
58
+ end
47
59
  end
48
60
  end
49
61
  end
@@ -6,13 +6,23 @@ module RuboCop
6
6
  # Checks for unnecessary `require` statement.
7
7
  #
8
8
  # The following features are unnecessary `require` statement because
9
- # they are already loaded.
9
+ # they are already loaded. e.g. Ruby 2.2:
10
10
  #
11
11
  # ruby -ve 'p $LOADED_FEATURES.reject { |feature| %r|/| =~ feature }'
12
12
  # ruby 2.2.8p477 (2017-09-14 revision 59906) [x86_64-darwin13]
13
13
  # ["enumerator.so", "rational.so", "complex.so", "thread.rb"]
14
14
  #
15
- # This cop targets Ruby 2.2 or higher containing these 4 features.
15
+ # Below are the features that each `TargetRubyVersion` targets.
16
+ #
17
+ # * 2.0+ ... `enumerator`
18
+ # * 2.1+ ... `thread`
19
+ # * 2.2+ ... Add `rational` and `complex` above
20
+ # * 2.5+ ... Add `pp` above
21
+ # * 2.7+ ... Add `ruby2_keywords` above
22
+ # * 3.1+ ... Add `fiber` above
23
+ # * 3.2+ ... `set`
24
+ #
25
+ # This cop target those features.
16
26
  #
17
27
  # @example
18
28
  # # bad
@@ -27,22 +37,53 @@ module RuboCop
27
37
 
28
38
  MSG = 'Remove unnecessary `require` statement.'
29
39
  RESTRICT_ON_SEND = %i[require].freeze
40
+ RUBY_22_LOADED_FEATURES = %w[rational complex].freeze
41
+ PRETTY_PRINT_METHODS = %i[
42
+ pretty_inspect pretty_print pretty_print_cycle
43
+ pretty_print_inspect pretty_print_instance_variables
44
+ ].freeze
30
45
 
31
- # @!method unnecessary_require_statement?(node)
32
- def_node_matcher :unnecessary_require_statement?, <<~PATTERN
46
+ # @!method redundant_require_statement?(node)
47
+ def_node_matcher :redundant_require_statement?, <<~PATTERN
33
48
  (send nil? :require
34
- (str {"enumerator" "rational" "complex" "thread"}))
49
+ (str #redundant_feature?))
35
50
  PATTERN
36
51
 
37
52
  def on_send(node)
38
- return unless unnecessary_require_statement?(node)
53
+ return unless redundant_require_statement?(node)
39
54
 
40
55
  add_offense(node) do |corrector|
41
- range = range_with_surrounding_space(range: node.loc.expression, side: :right)
56
+ if node.parent.respond_to?(:modifier_form?) && node.parent.modifier_form?
57
+ corrector.insert_after(node.parent, "\nend")
58
+
59
+ range = range_with_surrounding_space(node.loc.expression, side: :right)
60
+ else
61
+ range = range_by_whole_lines(node.source_range, include_final_newline: true)
62
+ end
42
63
 
43
64
  corrector.remove(range)
44
65
  end
45
66
  end
67
+
68
+ private
69
+
70
+ # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
71
+ def redundant_feature?(feature_name)
72
+ feature_name == 'enumerator' ||
73
+ (target_ruby_version >= 2.1 && feature_name == 'thread') ||
74
+ (target_ruby_version >= 2.2 && RUBY_22_LOADED_FEATURES.include?(feature_name)) ||
75
+ (target_ruby_version >= 2.5 && feature_name == 'pp' && !use_pretty_print_method?) ||
76
+ (target_ruby_version >= 2.7 && feature_name == 'ruby2_keywords') ||
77
+ (target_ruby_version >= 3.1 && feature_name == 'fiber') ||
78
+ (target_ruby_version >= 3.2 && feature_name == 'set')
79
+ end
80
+ # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
81
+
82
+ def use_pretty_print_method?
83
+ processed_source.ast.each_descendant(:send).any? do |node|
84
+ PRETTY_PRINT_METHODS.include?(node.method_name)
85
+ end
86
+ end
46
87
  end
47
88
  end
48
89
  end
@@ -3,17 +3,22 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for redundant safe navigation calls.
6
+ # Checks for redundant safe navigation calls.
7
7
  # `instance_of?`, `kind_of?`, `is_a?`, `eql?`, `respond_to?`, and `equal?` methods
8
8
  # are checked by default. These are customizable with `AllowedMethods` option.
9
9
  #
10
+ # The `AllowedMethods` option specifies nil-safe methods,
11
+ # in other words, it is a method that is allowed to skip safe navigation.
12
+ # Note that the `AllowedMethod` option is not an option that specifies methods
13
+ # for which to suppress (allow) this cop's check.
14
+ #
10
15
  # In the example below, the safe navigation operator (`&.`) is unnecessary
11
16
  # because `NilClass` has methods like `respond_to?` and `is_a?`.
12
17
  #
13
18
  # @safety
14
- # This cop is unsafe, because auto-correction can change the return type of
19
+ # This cop is unsafe, because autocorrection can change the return type of
15
20
  # the expression. An offending expression that previously could return `nil`
16
- # will be auto-corrected to never return `nil`.
21
+ # will be autocorrected to never return `nil`.
17
22
  #
18
23
  # @example
19
24
  # # bad
@@ -35,6 +40,14 @@ module RuboCop
35
40
  # # good - without `&.` this will always return `true`
36
41
  # foo&.respond_to?(:to_a)
37
42
  #
43
+ # @example AllowedMethods: [nil_safe_method]
44
+ # # bad
45
+ # do_something if attrs&.nil_safe_method(:[])
46
+ #
47
+ # # good
48
+ # do_something if attrs.nil_safe_method(:[])
49
+ # do_something if attrs&.not_nil_safe_method(:[])
50
+ #
38
51
  class RedundantSafeNavigation < Base
39
52
  include AllowedMethods
40
53
  include RangeHelp
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Lint
6
- # This cop checks for unneeded usages of splat expansion
6
+ # Checks for unneeded usages of splat expansion
7
7
  #
8
8
  # @example
9
9
  #