rubocop 1.19.0 → 1.33.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (618) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE.txt +1 -1
  3. data/README.md +8 -7
  4. data/config/default.yml +417 -83
  5. data/config/obsoletion.yml +35 -2
  6. data/exe/rubocop +15 -7
  7. data/lib/rubocop/cache_config.rb +29 -0
  8. data/lib/rubocop/cli/command/auto_genenerate_config.rb +21 -6
  9. data/lib/rubocop/cli/command/execute_runner.rb +1 -1
  10. data/lib/rubocop/cli/command/init_dotfile.rb +2 -2
  11. data/lib/rubocop/cli/command/show_cops.rb +1 -1
  12. data/lib/rubocop/cli/command/show_docs_url.rb +48 -0
  13. data/lib/rubocop/cli/command/suggest_extensions.rb +5 -5
  14. data/lib/rubocop/cli.rb +4 -1
  15. data/lib/rubocop/config.rb +10 -1
  16. data/lib/rubocop/config_finder.rb +68 -0
  17. data/lib/rubocop/config_loader.rb +12 -48
  18. data/lib/rubocop/config_loader_resolver.rb +2 -2
  19. data/lib/rubocop/config_obsoletion/changed_parameter.rb +5 -0
  20. data/lib/rubocop/config_obsoletion/extracted_cop.rb +3 -1
  21. data/lib/rubocop/config_obsoletion/parameter_rule.rb +4 -0
  22. data/lib/rubocop/config_obsoletion.rb +7 -2
  23. data/lib/rubocop/config_validator.rb +30 -5
  24. data/lib/rubocop/cop/autocorrect_logic.rb +8 -2
  25. data/lib/rubocop/cop/badge.rb +8 -2
  26. data/lib/rubocop/cop/base.rb +9 -5
  27. data/lib/rubocop/cop/bundler/duplicated_gem.rb +4 -8
  28. data/lib/rubocop/cop/bundler/gem_comment.rb +3 -3
  29. data/lib/rubocop/cop/bundler/gem_filename.rb +103 -0
  30. data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +45 -21
  31. data/lib/rubocop/cop/bundler/ordered_gems.rb +5 -14
  32. data/lib/rubocop/cop/corrector.rb +2 -2
  33. data/lib/rubocop/cop/correctors/alignment_corrector.rb +1 -1
  34. data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -1
  35. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +2 -2
  36. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
  37. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +4 -2
  38. data/lib/rubocop/cop/correctors/if_then_corrector.rb +55 -0
  39. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +3 -3
  40. data/lib/rubocop/cop/correctors/line_break_corrector.rb +8 -2
  41. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +3 -3
  42. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +12 -11
  43. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +1 -1
  44. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
  45. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
  46. data/lib/rubocop/cop/correctors/space_corrector.rb +1 -1
  47. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +1 -1
  48. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +2 -2
  49. data/lib/rubocop/cop/documentation.rb +20 -3
  50. data/lib/rubocop/cop/gemspec/dependency_version.rb +156 -0
  51. data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
  52. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +6 -22
  53. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +4 -13
  54. data/lib/rubocop/cop/gemspec/require_mfa.rb +145 -0
  55. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +41 -27
  56. data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +4 -11
  57. data/lib/rubocop/cop/generator.rb +25 -19
  58. data/lib/rubocop/cop/internal_affairs/cop_description.rb +96 -0
  59. data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +1 -1
  60. data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +60 -0
  61. data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +80 -0
  62. data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +2 -6
  63. data/lib/rubocop/cop/internal_affairs/redundant_context_config_parameter.rb +46 -0
  64. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +1 -1
  65. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +1 -1
  66. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
  67. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -1
  68. data/lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb +47 -0
  69. data/lib/rubocop/cop/internal_affairs/undefined_config.rb +3 -1
  70. data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
  71. data/lib/rubocop/cop/internal_affairs.rb +6 -0
  72. data/lib/rubocop/cop/layout/argument_alignment.rb +57 -9
  73. data/lib/rubocop/cop/layout/assignment_indentation.rb +2 -2
  74. data/lib/rubocop/cop/layout/begin_end_alignment.rb +1 -1
  75. data/lib/rubocop/cop/layout/block_alignment.rb +4 -4
  76. data/lib/rubocop/cop/layout/block_end_newline.rb +33 -6
  77. data/lib/rubocop/cop/layout/case_indentation.rb +17 -1
  78. data/lib/rubocop/cop/layout/class_structure.rb +2 -1
  79. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -1
  80. data/lib/rubocop/cop/layout/comment_indentation.rb +33 -4
  81. data/lib/rubocop/cop/layout/condition_position.rb +1 -1
  82. data/lib/rubocop/cop/layout/def_end_alignment.rb +1 -1
  83. data/lib/rubocop/cop/layout/dot_position.rb +39 -6
  84. data/lib/rubocop/cop/layout/else_alignment.rb +1 -1
  85. data/lib/rubocop/cop/layout/empty_comment.rb +3 -3
  86. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +1 -1
  87. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +1 -1
  88. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +23 -2
  89. data/lib/rubocop/cop/layout/empty_lines.rb +1 -1
  90. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +1 -1
  91. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +25 -4
  92. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +1 -1
  93. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +5 -5
  94. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +10 -10
  95. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +12 -5
  96. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +1 -1
  97. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +10 -10
  98. data/lib/rubocop/cop/layout/end_alignment.rb +3 -4
  99. data/lib/rubocop/cop/layout/end_of_line.rb +1 -1
  100. data/lib/rubocop/cop/layout/extra_spacing.rb +1 -1
  101. data/lib/rubocop/cop/layout/first_argument_indentation.rb +34 -29
  102. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +22 -15
  103. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +1 -1
  104. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +53 -14
  105. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +1 -1
  106. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +1 -1
  107. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +1 -1
  108. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +2 -2
  109. data/lib/rubocop/cop/layout/hash_alignment.rb +10 -3
  110. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +2 -2
  111. data/lib/rubocop/cop/layout/heredoc_indentation.rb +1 -1
  112. data/lib/rubocop/cop/layout/indentation_consistency.rb +1 -1
  113. data/lib/rubocop/cop/layout/indentation_style.rb +1 -1
  114. data/lib/rubocop/cop/layout/indentation_width.rb +12 -10
  115. data/lib/rubocop/cop/layout/initial_indentation.rb +2 -2
  116. data/lib/rubocop/cop/layout/leading_comment_space.rb +2 -2
  117. data/lib/rubocop/cop/layout/leading_empty_lines.rb +1 -1
  118. data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +112 -0
  119. data/lib/rubocop/cop/layout/line_continuation_spacing.rb +130 -0
  120. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +2 -2
  121. data/lib/rubocop/cop/layout/line_length.rb +16 -12
  122. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +1 -1
  123. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +1 -1
  124. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +2 -2
  125. data/lib/rubocop/cop/layout/multiline_block_layout.rb +5 -5
  126. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +1 -1
  127. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +1 -1
  128. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +7 -1
  129. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +1 -1
  130. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +23 -6
  131. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +1 -1
  132. data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +45 -0
  133. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +9 -10
  134. data/lib/rubocop/cop/layout/redundant_line_break.rb +5 -5
  135. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +8 -7
  136. data/lib/rubocop/cop/layout/single_line_block_chain.rb +16 -5
  137. data/lib/rubocop/cop/layout/space_after_colon.rb +1 -1
  138. data/lib/rubocop/cop/layout/space_after_not.rb +2 -1
  139. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +2 -2
  140. data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +2 -1
  141. data/lib/rubocop/cop/layout/space_around_keyword.rb +2 -2
  142. data/lib/rubocop/cop/layout/space_around_operators.rb +1 -1
  143. data/lib/rubocop/cop/layout/space_before_block_braces.rb +3 -3
  144. data/lib/rubocop/cop/layout/space_before_brackets.rb +8 -0
  145. data/lib/rubocop/cop/layout/space_before_comment.rb +2 -2
  146. data/lib/rubocop/cop/layout/space_before_first_arg.rb +5 -1
  147. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +12 -6
  148. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +10 -10
  149. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +8 -6
  150. data/lib/rubocop/cop/layout/space_inside_parens.rb +74 -28
  151. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +2 -2
  152. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +1 -1
  153. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +9 -9
  154. data/lib/rubocop/cop/layout/trailing_whitespace.rb +3 -3
  155. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +1 -1
  156. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +28 -7
  157. data/lib/rubocop/cop/lint/ambiguous_operator.rb +7 -7
  158. data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +111 -0
  159. data/lib/rubocop/cop/lint/ambiguous_range.rb +13 -13
  160. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +6 -2
  161. data/lib/rubocop/cop/lint/assignment_in_condition.rb +8 -6
  162. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +19 -6
  163. data/lib/rubocop/cop/lint/boolean_symbol.rb +6 -1
  164. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  165. data/lib/rubocop/cop/lint/constant_definition_in_block.rb +1 -1
  166. data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
  167. data/lib/rubocop/cop/lint/debugger.rb +14 -6
  168. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +31 -13
  169. data/lib/rubocop/cop/lint/deprecated_constants.rb +4 -3
  170. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +6 -0
  171. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +24 -1
  172. data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -1
  173. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  174. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +1 -1
  175. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
  176. data/lib/rubocop/cop/lint/duplicate_methods.rb +1 -1
  177. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +1 -1
  178. data/lib/rubocop/cop/lint/duplicate_require.rb +11 -2
  179. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +1 -1
  180. data/lib/rubocop/cop/lint/each_with_object_argument.rb +2 -2
  181. data/lib/rubocop/cop/lint/else_layout.rb +13 -9
  182. data/lib/rubocop/cop/lint/empty_block.rb +1 -1
  183. data/lib/rubocop/cop/lint/empty_class.rb +1 -1
  184. data/lib/rubocop/cop/lint/empty_conditional_body.rb +64 -3
  185. data/lib/rubocop/cop/lint/empty_ensure.rb +1 -1
  186. data/lib/rubocop/cop/lint/empty_expression.rb +1 -1
  187. data/lib/rubocop/cop/lint/empty_file.rb +1 -1
  188. data/lib/rubocop/cop/lint/empty_in_pattern.rb +4 -2
  189. data/lib/rubocop/cop/lint/empty_interpolation.rb +1 -1
  190. data/lib/rubocop/cop/lint/empty_when.rb +4 -2
  191. data/lib/rubocop/cop/lint/ensure_return.rb +1 -1
  192. data/lib/rubocop/cop/lint/erb_new_arguments.rb +2 -2
  193. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  194. data/lib/rubocop/cop/lint/float_comparison.rb +1 -1
  195. data/lib/rubocop/cop/lint/float_out_of_range.rb +2 -2
  196. data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +12 -3
  197. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +1 -1
  198. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +1 -1
  199. data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +79 -0
  200. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -1
  201. data/lib/rubocop/cop/lint/inherit_exception.rb +19 -28
  202. data/lib/rubocop/cop/lint/interpolation_check.rb +7 -2
  203. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +10 -3
  204. data/lib/rubocop/cop/lint/literal_as_condition.rb +6 -1
  205. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +1 -1
  206. data/lib/rubocop/cop/lint/loop.rb +5 -4
  207. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +1 -1
  208. data/lib/rubocop/cop/lint/missing_super.rb +1 -1
  209. data/lib/rubocop/cop/lint/nested_method_definition.rb +1 -1
  210. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
  211. data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +157 -0
  212. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +9 -5
  213. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
  214. data/lib/rubocop/cop/lint/number_conversion.rb +47 -11
  215. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +2 -2
  216. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +4 -3
  217. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +17 -0
  218. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +12 -8
  219. data/lib/rubocop/cop/lint/percent_string_array.rb +11 -1
  220. data/lib/rubocop/cop/lint/percent_symbol_array.rb +1 -1
  221. data/lib/rubocop/cop/lint/raise_exception.rb +5 -1
  222. data/lib/rubocop/cop/lint/rand_one.rb +1 -1
  223. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +6 -6
  224. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +2 -2
  225. data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +5 -0
  226. data/lib/rubocop/cop/lint/redundant_require_statement.rb +4 -1
  227. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +13 -5
  228. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +1 -1
  229. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -1
  230. data/lib/rubocop/cop/lint/redundant_with_index.rb +1 -1
  231. data/lib/rubocop/cop/lint/redundant_with_object.rb +1 -1
  232. data/lib/rubocop/cop/lint/refinement_import_methods.rb +51 -0
  233. data/lib/rubocop/cop/lint/regexp_as_condition.rb +3 -3
  234. data/lib/rubocop/cop/lint/require_parentheses.rb +1 -1
  235. data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
  236. data/lib/rubocop/cop/lint/require_relative_self_path.rb +50 -0
  237. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  238. data/lib/rubocop/cop/lint/return_in_void_context.rb +6 -18
  239. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +38 -1
  240. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +1 -1
  241. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
  242. data/lib/rubocop/cop/lint/script_permission.rb +1 -1
  243. data/lib/rubocop/cop/lint/self_assignment.rb +1 -1
  244. data/lib/rubocop/cop/lint/shadowed_argument.rb +1 -1
  245. data/lib/rubocop/cop/lint/shadowed_exception.rb +1 -1
  246. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +12 -2
  247. data/lib/rubocop/cop/lint/struct_new_override.rb +3 -3
  248. data/lib/rubocop/cop/lint/suppressed_exception.rb +1 -1
  249. data/lib/rubocop/cop/lint/symbol_conversion.rb +5 -4
  250. data/lib/rubocop/cop/lint/syntax.rb +2 -3
  251. data/lib/rubocop/cop/lint/to_enum_arguments.rb +1 -1
  252. data/lib/rubocop/cop/lint/to_json.rb +1 -1
  253. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
  254. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +2 -2
  255. data/lib/rubocop/cop/lint/triple_quotes.rb +1 -1
  256. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +1 -1
  257. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +9 -4
  258. data/lib/rubocop/cop/lint/unified_integer.rb +3 -1
  259. data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
  260. data/lib/rubocop/cop/lint/unreachable_loop.rb +5 -5
  261. data/lib/rubocop/cop/lint/unused_block_argument.rb +1 -1
  262. data/lib/rubocop/cop/lint/unused_method_argument.rb +4 -5
  263. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
  264. data/lib/rubocop/cop/lint/uri_regexp.rb +1 -1
  265. data/lib/rubocop/cop/lint/useless_access_modifier.rb +1 -1
  266. data/lib/rubocop/cop/lint/useless_assignment.rb +1 -1
  267. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +2 -3
  268. data/lib/rubocop/cop/lint/useless_method_definition.rb +4 -3
  269. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +117 -0
  270. data/lib/rubocop/cop/lint/useless_setter_call.rb +8 -5
  271. data/lib/rubocop/cop/lint/useless_times.rb +19 -14
  272. data/lib/rubocop/cop/lint/void.rb +1 -1
  273. data/lib/rubocop/cop/metrics/abc_size.rb +10 -2
  274. data/lib/rubocop/cop/metrics/block_length.rb +8 -7
  275. data/lib/rubocop/cop/metrics/block_nesting.rb +1 -1
  276. data/lib/rubocop/cop/metrics/class_length.rb +1 -1
  277. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +1 -10
  278. data/lib/rubocop/cop/metrics/method_length.rb +10 -8
  279. data/lib/rubocop/cop/metrics/module_length.rb +2 -2
  280. data/lib/rubocop/cop/metrics/parameter_lists.rb +6 -3
  281. data/lib/rubocop/cop/metrics/perceived_complexity.rb +2 -2
  282. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +3 -4
  283. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +24 -5
  284. data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +1 -1
  285. data/lib/rubocop/cop/mixin/allowed_methods.rb +15 -1
  286. data/lib/rubocop/cop/mixin/allowed_pattern.rb +48 -0
  287. data/lib/rubocop/cop/mixin/annotation_comment.rb +57 -34
  288. data/lib/rubocop/cop/mixin/check_line_breakable.rb +4 -0
  289. data/lib/rubocop/cop/mixin/code_length.rb +1 -1
  290. data/lib/rubocop/cop/mixin/comments_help.rb +28 -2
  291. data/lib/rubocop/cop/mixin/def_node.rb +2 -7
  292. data/lib/rubocop/cop/mixin/documentation_comment.rb +5 -2
  293. data/lib/rubocop/cop/mixin/duplication.rb +1 -1
  294. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +1 -2
  295. data/lib/rubocop/cop/mixin/enforce_superclass.rb +5 -0
  296. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +23 -1
  297. data/lib/rubocop/cop/mixin/gemspec_help.rb +30 -0
  298. data/lib/rubocop/cop/mixin/hash_alignment_styles.rb +4 -3
  299. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +86 -0
  300. data/lib/rubocop/cop/mixin/hash_transform_method.rb +3 -3
  301. data/lib/rubocop/cop/mixin/heredoc.rb +1 -3
  302. data/lib/rubocop/cop/mixin/line_length_help.rb +17 -6
  303. data/lib/rubocop/cop/mixin/method_complexity.rb +4 -9
  304. data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +35 -13
  305. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +6 -5
  306. data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +1 -1
  307. data/lib/rubocop/cop/mixin/ordered_gem_node.rb +9 -1
  308. data/lib/rubocop/cop/mixin/percent_array.rb +70 -3
  309. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +9 -1
  310. data/lib/rubocop/cop/mixin/preferred_delimiters.rb +2 -2
  311. data/lib/rubocop/cop/mixin/range_help.rb +7 -3
  312. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +1 -1
  313. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +1 -1
  314. data/lib/rubocop/cop/mixin/statement_modifier.rb +2 -2
  315. data/lib/rubocop/cop/mixin/string_help.rb +1 -1
  316. data/lib/rubocop/cop/mixin/surrounding_space.rb +4 -2
  317. data/lib/rubocop/cop/mixin/trailing_body.rb +1 -1
  318. data/lib/rubocop/cop/mixin/trailing_comma.rb +1 -1
  319. data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
  320. data/lib/rubocop/cop/naming/ascii_identifiers.rb +1 -4
  321. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
  322. data/lib/rubocop/cop/naming/block_forwarding.rb +121 -0
  323. data/lib/rubocop/cop/naming/block_parameter_name.rb +2 -2
  324. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +1 -1
  325. data/lib/rubocop/cop/naming/constant_name.rb +2 -2
  326. data/lib/rubocop/cop/naming/file_name.rb +39 -6
  327. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +1 -1
  328. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +1 -1
  329. data/lib/rubocop/cop/naming/inclusive_language.rb +12 -11
  330. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +6 -5
  331. data/lib/rubocop/cop/naming/method_name.rb +6 -6
  332. data/lib/rubocop/cop/naming/method_parameter_name.rb +2 -2
  333. data/lib/rubocop/cop/naming/predicate_name.rb +32 -3
  334. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +8 -1
  335. data/lib/rubocop/cop/naming/variable_name.rb +10 -1
  336. data/lib/rubocop/cop/naming/variable_number.rb +28 -18
  337. data/lib/rubocop/cop/offense.rb +1 -1
  338. data/lib/rubocop/cop/security/compound_hash.rb +105 -0
  339. data/lib/rubocop/cop/security/eval.rb +1 -1
  340. data/lib/rubocop/cop/security/io_methods.rb +49 -0
  341. data/lib/rubocop/cop/security/json_load.rb +9 -8
  342. data/lib/rubocop/cop/security/marshal_load.rb +1 -1
  343. data/lib/rubocop/cop/security/open.rb +15 -1
  344. data/lib/rubocop/cop/security/yaml_load.rb +14 -4
  345. data/lib/rubocop/cop/style/accessor_grouping.rb +6 -6
  346. data/lib/rubocop/cop/style/alias.rb +4 -4
  347. data/lib/rubocop/cop/style/and_or.rb +14 -9
  348. data/lib/rubocop/cop/style/arguments_forwarding.rb +14 -3
  349. data/lib/rubocop/cop/style/array_coercion.rb +22 -4
  350. data/lib/rubocop/cop/style/array_join.rb +1 -1
  351. data/lib/rubocop/cop/style/ascii_comments.rb +1 -4
  352. data/lib/rubocop/cop/style/attr.rb +1 -1
  353. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +1 -1
  354. data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
  355. data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +1 -1
  356. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +1 -1
  357. data/lib/rubocop/cop/style/block_comments.rb +1 -1
  358. data/lib/rubocop/cop/style/block_delimiters.rb +57 -14
  359. data/lib/rubocop/cop/style/case_equality.rb +7 -10
  360. data/lib/rubocop/cop/style/case_like_if.rb +6 -1
  361. data/lib/rubocop/cop/style/character_literal.rb +9 -2
  362. data/lib/rubocop/cop/style/class_and_module_children.rb +14 -5
  363. data/lib/rubocop/cop/style/class_check.rb +1 -1
  364. data/lib/rubocop/cop/style/class_equality_comparison.rb +51 -4
  365. data/lib/rubocop/cop/style/class_methods.rb +1 -1
  366. data/lib/rubocop/cop/style/class_methods_definitions.rb +1 -1
  367. data/lib/rubocop/cop/style/class_vars.rb +1 -1
  368. data/lib/rubocop/cop/style/collection_compact.rb +41 -21
  369. data/lib/rubocop/cop/style/collection_methods.rb +9 -7
  370. data/lib/rubocop/cop/style/colon_method_call.rb +1 -1
  371. data/lib/rubocop/cop/style/colon_method_definition.rb +1 -1
  372. data/lib/rubocop/cop/style/combinable_loops.rb +6 -5
  373. data/lib/rubocop/cop/style/command_literal.rb +1 -1
  374. data/lib/rubocop/cop/style/comment_annotation.rb +26 -40
  375. data/lib/rubocop/cop/style/commented_keyword.rb +12 -7
  376. data/lib/rubocop/cop/style/conditional_assignment.rb +2 -1
  377. data/lib/rubocop/cop/style/constant_visibility.rb +1 -1
  378. data/lib/rubocop/cop/style/date_time.rb +6 -1
  379. data/lib/rubocop/cop/style/def_with_parentheses.rb +17 -12
  380. data/lib/rubocop/cop/style/dir.rb +4 -1
  381. data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +1 -1
  382. data/lib/rubocop/cop/style/documentation.rb +24 -9
  383. data/lib/rubocop/cop/style/documentation_method.rb +1 -1
  384. data/lib/rubocop/cop/style/double_negation.rb +85 -7
  385. data/lib/rubocop/cop/style/each_for_simple_loop.rb +1 -1
  386. data/lib/rubocop/cop/style/each_with_object.rb +1 -1
  387. data/lib/rubocop/cop/style/empty_block_parameter.rb +1 -1
  388. data/lib/rubocop/cop/style/empty_case_condition.rb +13 -4
  389. data/lib/rubocop/cop/style/empty_else.rb +40 -3
  390. data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
  391. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +1 -1
  392. data/lib/rubocop/cop/style/empty_literal.rb +2 -2
  393. data/lib/rubocop/cop/style/empty_method.rb +19 -4
  394. data/lib/rubocop/cop/style/encoding.rb +27 -16
  395. data/lib/rubocop/cop/style/end_block.rb +1 -1
  396. data/lib/rubocop/cop/style/endless_method.rb +1 -1
  397. data/lib/rubocop/cop/style/env_home.rb +56 -0
  398. data/lib/rubocop/cop/style/eval_with_location.rb +1 -1
  399. data/lib/rubocop/cop/style/even_odd.rb +1 -1
  400. data/lib/rubocop/cop/style/expand_path_arguments.rb +1 -1
  401. data/lib/rubocop/cop/style/explicit_block_argument.rb +23 -13
  402. data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
  403. data/lib/rubocop/cop/style/fetch_env_var.rb +132 -0
  404. data/lib/rubocop/cop/style/file_read.rb +112 -0
  405. data/lib/rubocop/cop/style/file_write.rb +136 -0
  406. data/lib/rubocop/cop/style/float_division.rb +11 -3
  407. data/lib/rubocop/cop/style/for.rb +5 -1
  408. data/lib/rubocop/cop/style/format_string.rb +1 -1
  409. data/lib/rubocop/cop/style/format_string_token.rb +74 -23
  410. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +13 -5
  411. data/lib/rubocop/cop/style/global_std_stream.rb +5 -1
  412. data/lib/rubocop/cop/style/global_vars.rb +1 -1
  413. data/lib/rubocop/cop/style/guard_clause.rb +51 -4
  414. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +11 -0
  415. data/lib/rubocop/cop/style/hash_conversion.rb +3 -2
  416. data/lib/rubocop/cop/style/hash_each_methods.rb +6 -1
  417. data/lib/rubocop/cop/style/hash_except.rb +89 -12
  418. data/lib/rubocop/cop/style/hash_like_case.rb +1 -1
  419. data/lib/rubocop/cop/style/hash_syntax.rb +39 -3
  420. data/lib/rubocop/cop/style/hash_transform_keys.rb +16 -13
  421. data/lib/rubocop/cop/style/hash_transform_values.rb +14 -13
  422. data/lib/rubocop/cop/style/identical_conditional_branches.rb +19 -17
  423. data/lib/rubocop/cop/style/if_inside_else.rb +15 -0
  424. data/lib/rubocop/cop/style/if_unless_modifier.rb +5 -4
  425. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +22 -6
  426. data/lib/rubocop/cop/style/implicit_runtime_error.rb +3 -3
  427. data/lib/rubocop/cop/style/in_pattern_then.rb +1 -1
  428. data/lib/rubocop/cop/style/infinite_loop.rb +4 -3
  429. data/lib/rubocop/cop/style/inline_comment.rb +1 -1
  430. data/lib/rubocop/cop/style/inverse_methods.rb +11 -4
  431. data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
  432. data/lib/rubocop/cop/style/keyword_parameters_order.rb +2 -2
  433. data/lib/rubocop/cop/style/lambda.rb +1 -1
  434. data/lib/rubocop/cop/style/lambda_call.rb +14 -22
  435. data/lib/rubocop/cop/style/line_end_concatenation.rb +16 -3
  436. data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
  437. data/lib/rubocop/cop/style/map_to_hash.rb +68 -0
  438. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +28 -8
  439. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +6 -2
  440. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +15 -13
  441. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +20 -3
  442. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +1 -1
  443. data/lib/rubocop/cop/style/method_def_parentheses.rb +18 -14
  444. data/lib/rubocop/cop/style/min_max.rb +1 -1
  445. data/lib/rubocop/cop/style/missing_else.rb +24 -24
  446. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +1 -1
  447. data/lib/rubocop/cop/style/mixin_grouping.rb +2 -2
  448. data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
  449. data/lib/rubocop/cop/style/module_function.rb +11 -12
  450. data/lib/rubocop/cop/style/multiline_block_chain.rb +1 -1
  451. data/lib/rubocop/cop/style/multiline_if_modifier.rb +2 -2
  452. data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
  453. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +3 -5
  454. data/lib/rubocop/cop/style/multiline_memoization.rb +1 -1
  455. data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
  456. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +37 -11
  457. data/lib/rubocop/cop/style/multiline_when_then.rb +3 -5
  458. data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
  459. data/lib/rubocop/cop/style/mutable_constant.rb +74 -7
  460. data/lib/rubocop/cop/style/negated_if.rb +1 -1
  461. data/lib/rubocop/cop/style/negated_if_else_condition.rb +1 -1
  462. data/lib/rubocop/cop/style/negated_unless.rb +1 -1
  463. data/lib/rubocop/cop/style/nested_file_dirname.rb +66 -0
  464. data/lib/rubocop/cop/style/nested_modifier.rb +1 -1
  465. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +11 -2
  466. data/lib/rubocop/cop/style/nested_ternary_operator.rb +20 -8
  467. data/lib/rubocop/cop/style/next.rb +1 -1
  468. data/lib/rubocop/cop/style/nil_comparison.rb +1 -1
  469. data/lib/rubocop/cop/style/nil_lambda.rb +2 -2
  470. data/lib/rubocop/cop/style/non_nil_check.rb +3 -3
  471. data/lib/rubocop/cop/style/not.rb +4 -4
  472. data/lib/rubocop/cop/style/numbered_parameters.rb +46 -0
  473. data/lib/rubocop/cop/style/numbered_parameters_limit.rb +50 -0
  474. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +1 -1
  475. data/lib/rubocop/cop/style/numeric_literals.rb +18 -10
  476. data/lib/rubocop/cop/style/numeric_predicate.rb +58 -11
  477. data/lib/rubocop/cop/style/object_then.rb +69 -0
  478. data/lib/rubocop/cop/style/one_line_conditional.rb +19 -40
  479. data/lib/rubocop/cop/style/open_struct_use.rb +69 -0
  480. data/lib/rubocop/cop/style/option_hash.rb +1 -1
  481. data/lib/rubocop/cop/style/optional_arguments.rb +5 -1
  482. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +16 -5
  483. data/lib/rubocop/cop/style/or_assignment.rb +1 -1
  484. data/lib/rubocop/cop/style/parallel_assignment.rb +1 -1
  485. data/lib/rubocop/cop/style/parentheses_around_condition.rb +13 -3
  486. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -1
  487. data/lib/rubocop/cop/style/percent_q_literals.rb +3 -3
  488. data/lib/rubocop/cop/style/perl_backrefs.rb +1 -1
  489. data/lib/rubocop/cop/style/preferred_hash_methods.rb +9 -4
  490. data/lib/rubocop/cop/style/proc.rb +1 -1
  491. data/lib/rubocop/cop/style/quoted_symbols.rb +22 -8
  492. data/lib/rubocop/cop/style/raise_args.rb +11 -5
  493. data/lib/rubocop/cop/style/random_with_offset.rb +1 -1
  494. data/lib/rubocop/cop/style/redundant_argument.rb +21 -11
  495. data/lib/rubocop/cop/style/redundant_assignment.rb +1 -1
  496. data/lib/rubocop/cop/style/redundant_begin.rb +43 -11
  497. data/lib/rubocop/cop/style/redundant_capital_w.rb +2 -3
  498. data/lib/rubocop/cop/style/redundant_condition.rb +131 -16
  499. data/lib/rubocop/cop/style/redundant_conditional.rb +1 -1
  500. data/lib/rubocop/cop/style/redundant_exception.rb +1 -1
  501. data/lib/rubocop/cop/style/redundant_fetch_block.rb +5 -1
  502. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +13 -4
  503. data/lib/rubocop/cop/style/redundant_freeze.rb +5 -5
  504. data/lib/rubocop/cop/style/redundant_initialize.rb +154 -0
  505. data/lib/rubocop/cop/style/redundant_interpolation.rb +40 -5
  506. data/lib/rubocop/cop/style/redundant_parentheses.rb +3 -2
  507. data/lib/rubocop/cop/style/redundant_percent_q.rb +3 -4
  508. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +12 -3
  509. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +2 -2
  510. data/lib/rubocop/cop/style/redundant_return.rb +2 -2
  511. data/lib/rubocop/cop/style/redundant_self.rb +12 -2
  512. data/lib/rubocop/cop/style/redundant_self_assignment.rb +7 -7
  513. data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +24 -29
  514. data/lib/rubocop/cop/style/redundant_sort.rb +68 -20
  515. data/lib/rubocop/cop/style/redundant_sort_by.rb +1 -1
  516. data/lib/rubocop/cop/style/regexp_literal.rb +4 -4
  517. data/lib/rubocop/cop/style/rescue_modifier.rb +1 -1
  518. data/lib/rubocop/cop/style/rescue_standard_error.rb +13 -13
  519. data/lib/rubocop/cop/style/return_nil.rb +3 -2
  520. data/lib/rubocop/cop/style/safe_navigation.rb +30 -15
  521. data/lib/rubocop/cop/style/sample.rb +6 -4
  522. data/lib/rubocop/cop/style/select_by_regexp.rb +144 -0
  523. data/lib/rubocop/cop/style/self_assignment.rb +1 -1
  524. data/lib/rubocop/cop/style/semicolon.rb +28 -4
  525. data/lib/rubocop/cop/style/send.rb +1 -1
  526. data/lib/rubocop/cop/style/signal_exception.rb +1 -1
  527. data/lib/rubocop/cop/style/single_argument_dig.rb +10 -0
  528. data/lib/rubocop/cop/style/single_line_block_params.rb +3 -3
  529. data/lib/rubocop/cop/style/single_line_methods.rb +2 -2
  530. data/lib/rubocop/cop/style/slicing_with_range.rb +14 -1
  531. data/lib/rubocop/cop/style/sole_nested_conditional.rb +89 -26
  532. data/lib/rubocop/cop/style/special_global_vars.rb +70 -8
  533. data/lib/rubocop/cop/style/static_class.rb +6 -6
  534. data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
  535. data/lib/rubocop/cop/style/string_chars.rb +4 -2
  536. data/lib/rubocop/cop/style/string_concatenation.rb +17 -8
  537. data/lib/rubocop/cop/style/string_hash_keys.rb +5 -1
  538. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +1 -1
  539. data/lib/rubocop/cop/style/string_methods.rb +1 -1
  540. data/lib/rubocop/cop/style/strip.rb +1 -1
  541. data/lib/rubocop/cop/style/struct_inheritance.rb +7 -3
  542. data/lib/rubocop/cop/style/swap_values.rb +8 -4
  543. data/lib/rubocop/cop/style/symbol_array.rb +9 -6
  544. data/lib/rubocop/cop/style/symbol_literal.rb +1 -1
  545. data/lib/rubocop/cop/style/symbol_proc.rb +86 -8
  546. data/lib/rubocop/cop/style/ternary_parentheses.rb +18 -5
  547. data/lib/rubocop/cop/style/trailing_body_on_class.rb +1 -1
  548. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -1
  549. data/lib/rubocop/cop/style/trailing_body_on_module.rb +1 -1
  550. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +1 -1
  551. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +2 -2
  552. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +20 -1
  553. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +2 -2
  554. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +2 -5
  555. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +1 -1
  556. data/lib/rubocop/cop/style/trivial_accessors.rb +12 -10
  557. data/lib/rubocop/cop/style/unless_else.rb +5 -1
  558. data/lib/rubocop/cop/style/unless_logical_operators.rb +1 -1
  559. data/lib/rubocop/cop/style/unpack_first.rb +5 -2
  560. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  561. data/lib/rubocop/cop/style/when_then.rb +1 -1
  562. data/lib/rubocop/cop/style/word_array.rb +4 -5
  563. data/lib/rubocop/cop/style/yoda_condition.rb +25 -8
  564. data/lib/rubocop/cop/style/zero_length_predicate.rb +7 -1
  565. data/lib/rubocop/cop/team.rb +3 -3
  566. data/lib/rubocop/cop/util.rb +25 -6
  567. data/lib/rubocop/cop/variable_force/branch.rb +1 -1
  568. data/lib/rubocop/cop/variable_force.rb +1 -5
  569. data/lib/rubocop/cops_documentation_generator.rb +38 -9
  570. data/lib/rubocop/formatter/disabled_config_formatter.rb +19 -2
  571. data/lib/rubocop/formatter/formatter_set.rb +20 -18
  572. data/lib/rubocop/formatter/git_hub_actions_formatter.rb +15 -2
  573. data/lib/rubocop/formatter/html_formatter.rb +7 -12
  574. data/lib/rubocop/formatter/json_formatter.rb +4 -1
  575. data/lib/rubocop/formatter/markdown_formatter.rb +78 -0
  576. data/lib/rubocop/formatter/offense_count_formatter.rb +8 -2
  577. data/lib/rubocop/formatter/simple_text_formatter.rb +9 -8
  578. data/lib/rubocop/formatter/worst_offenders_formatter.rb +1 -2
  579. data/lib/rubocop/formatter.rb +31 -0
  580. data/lib/rubocop/magic_comment.rb +74 -19
  581. data/lib/rubocop/options.rb +232 -138
  582. data/lib/rubocop/rake_task.rb +35 -10
  583. data/lib/rubocop/remote_config.rb +2 -4
  584. data/lib/rubocop/result_cache.rb +27 -16
  585. data/lib/rubocop/rspec/cop_helper.rb +3 -3
  586. data/lib/rubocop/rspec/expect_offense.rb +9 -5
  587. data/lib/rubocop/rspec/parallel_formatter.rb +90 -0
  588. data/lib/rubocop/rspec/shared_contexts.rb +34 -10
  589. data/lib/rubocop/rspec/support.rb +15 -0
  590. data/lib/rubocop/runner.rb +40 -11
  591. data/lib/rubocop/server/cache.rb +141 -0
  592. data/lib/rubocop/server/cli.rb +121 -0
  593. data/lib/rubocop/server/client_command/base.rb +44 -0
  594. data/lib/rubocop/server/client_command/exec.rb +59 -0
  595. data/lib/rubocop/server/client_command/restart.rb +25 -0
  596. data/lib/rubocop/server/client_command/start.rb +43 -0
  597. data/lib/rubocop/server/client_command/status.rb +28 -0
  598. data/lib/rubocop/server/client_command/stop.rb +31 -0
  599. data/lib/rubocop/server/client_command.rb +26 -0
  600. data/lib/rubocop/server/core.rb +79 -0
  601. data/lib/rubocop/server/errors.rb +23 -0
  602. data/lib/rubocop/server/helper.rb +34 -0
  603. data/lib/rubocop/server/server_command/base.rb +50 -0
  604. data/lib/rubocop/server/server_command/exec.rb +34 -0
  605. data/lib/rubocop/server/server_command/stop.rb +24 -0
  606. data/lib/rubocop/server/server_command.rb +21 -0
  607. data/lib/rubocop/server/socket_reader.rb +65 -0
  608. data/lib/rubocop/server.rb +53 -0
  609. data/lib/rubocop/string_interpreter.rb +4 -4
  610. data/lib/rubocop/target_finder.rb +1 -1
  611. data/lib/rubocop/target_ruby.rb +14 -6
  612. data/lib/rubocop/version.rb +15 -8
  613. data/lib/rubocop/yaml_duplication_checker.rb +1 -1
  614. data/lib/rubocop.rb +42 -30
  615. metadata +97 -13
  616. data/lib/rubocop/cop/gemspec/date_assignment.rb +0 -57
  617. data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -52
  618. data/lib/rubocop/cop/mixin/ignored_pattern.rb +0 -29
@@ -15,7 +15,7 @@ module RuboCop
15
15
  'root of the project. RuboCop will use this path to determine which ' \
16
16
  'cops are enabled (via eg. Include/Exclude), and so that certain cops ' \
17
17
  'like Naming/FileName can be checked.'
18
- EXITING_OPTIONS = %i[version verbose_version show_cops].freeze
18
+ EXITING_OPTIONS = %i[version verbose_version show_cops show_docs_url].freeze
19
19
  DEFAULT_MAXIMUM_EXCLUSION_ITEMS = 15
20
20
 
21
21
  def initialize
@@ -59,86 +59,133 @@ module RuboCop
59
59
 
60
60
  def define_options
61
61
  OptionParser.new do |opts|
62
- opts.banner = 'Usage: rubocop [options] [file1, file2, ...]'
62
+ opts.banner = rainbow.wrap('Usage: rubocop [options] [file1, file2, ...]').bright
63
63
 
64
- add_list_options(opts)
65
- add_only_options(opts)
66
- add_configuration_options(opts)
67
- add_formatting_options(opts)
68
-
69
- option(opts, '-r', '--require FILE') { |f| require_feature(f) }
70
-
71
- add_severity_option(opts)
72
- add_flags_with_optional_args(opts)
64
+ add_check_options(opts)
73
65
  add_cache_options(opts)
74
- add_boolean_flags(opts)
75
- add_aliases(opts)
66
+ add_server_options(opts)
67
+ add_output_options(opts)
68
+ add_autocorrection_options(opts)
69
+ add_config_generation_options(opts)
70
+ add_additional_modes(opts)
71
+ add_general_options(opts)
72
+ end
73
+ end
76
74
 
75
+ def add_check_options(opts) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
76
+ section(opts, 'Basic Options') do
77
+ option(opts, '-l', '--lint') do
78
+ @options[:only] ||= []
79
+ @options[:only] << 'Lint'
80
+ end
81
+ option(opts, '-x', '--fix-layout') do
82
+ @options[:only] ||= []
83
+ @options[:only] << 'Layout'
84
+ @options[:autocorrect] = true
85
+ end
86
+ option(opts, '--safe')
87
+ add_cop_selection_csv_option('except', opts)
88
+ add_cop_selection_csv_option('only', opts)
89
+ option(opts, '--only-guide-cops')
90
+ option(opts, '-F', '--fail-fast')
91
+ option(opts, '--disable-pending-cops')
92
+ option(opts, '--enable-pending-cops')
93
+ option(opts, '--ignore-disable-comments')
94
+ option(opts, '--force-exclusion')
95
+ option(opts, '--only-recognized-file-types')
96
+ option(opts, '--ignore-parent-exclusion')
97
+ option(opts, '--ignore-unrecognized-cops')
98
+ option(opts, '--force-default-config')
77
99
  option(opts, '-s', '--stdin FILE')
100
+ option(opts, '-P', '--[no-]parallel')
101
+ add_severity_option(opts)
78
102
  end
79
103
  end
80
104
 
81
- def add_only_options(opts)
82
- add_cop_selection_csv_option('except', opts)
83
- add_cop_selection_csv_option('only', opts)
84
- option(opts, '--only-guide-cops')
85
- end
105
+ def add_output_options(opts) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
106
+ section(opts, 'Output Options') do
107
+ option(opts, '-f', '--format FORMATTER') do |key|
108
+ @options[:formatters] ||= []
109
+ @options[:formatters] << [key]
110
+ end
86
111
 
87
- def add_cop_selection_csv_option(option, opts)
88
- option(opts, "--#{option} [COP1,COP2,...]") do |list|
89
- unless list
90
- message = "--#{option} argument should be [COP1,COP2,...]."
112
+ option(opts, '-D', '--[no-]display-cop-names')
113
+ option(opts, '-E', '--extra-details')
114
+ option(opts, '-S', '--display-style-guide')
91
115
 
92
- raise OptionArgumentError, message
116
+ option(opts, '-o', '--out FILE') do |path|
117
+ if @options[:formatters]
118
+ @options[:formatters].last << path
119
+ else
120
+ @options[:output_path] = path
121
+ end
93
122
  end
94
123
 
95
- @options[:"#{option}"] = list.empty? ? [''] : list.split(',')
124
+ option(opts, '--stderr')
125
+ option(opts, '--display-time')
126
+ option(opts, '--display-only-failed')
127
+ option(opts, '--display-only-fail-level-offenses')
128
+ option(opts, '--display-only-correctable')
129
+ option(opts, '--display-only-safe-correctable')
96
130
  end
97
131
  end
98
132
 
99
- def add_configuration_options(opts)
100
- option(opts, '-c', '--config FILE')
101
- option(opts, '--force-exclusion')
102
- option(opts, '--only-recognized-file-types')
103
- option(opts, '--ignore-parent-exclusion')
104
- option(opts, '--force-default-config')
105
- add_auto_gen_options(opts)
106
- end
133
+ # rubocop:todo Naming/InclusiveLanguage
134
+ # the autocorrect command-line arguments map to the autocorrect @options values like so:
135
+ # :fix_layout :autocorrect :safe_autocorrect :autocorrect_all
136
+ # -x, --fix-layout true true - -
137
+ # -a, --auto-correct - true true -
138
+ # --safe-auto-correct - true true -
139
+ # -A, --auto-correct-all - true - true
140
+ def add_autocorrection_options(opts) # rubocop:disable Metrics/MethodLength
141
+ section(opts, 'Autocorrection') do
142
+ option(opts, '-a', '--autocorrect') { @options[:safe_autocorrect] = true }
143
+ option(opts, '--auto-correct') do
144
+ handle_deprecated_option('--auto-correct', '--autocorrect')
145
+ @options[:safe_autocorrect] = true
146
+ end
147
+ option(opts, '--safe-auto-correct') do
148
+ handle_deprecated_option('--safe-auto-correct', '--autocorrect')
149
+ @options[:safe_autocorrect] = true
150
+ end
107
151
 
108
- def add_auto_gen_options(opts)
109
- option(opts, '--auto-gen-config')
152
+ option(opts, '-A', '--autocorrect-all') { @options[:autocorrect] = true }
153
+ option(opts, '--auto-correct-all') do
154
+ handle_deprecated_option('--auto-correct-all', '--autocorrect-all')
155
+ @options[:autocorrect] = true
156
+ end
110
157
 
111
- option(opts, '--regenerate-todo') do
112
- @options.replace(ConfigRegeneration.new.options.merge(@options))
158
+ option(opts, '--disable-uncorrectable')
113
159
  end
160
+ end
161
+ # rubocop:enable Naming/InclusiveLanguage
114
162
 
115
- option(opts, '--exclude-limit COUNT') { @validator.validate_exclude_limit_option }
163
+ def add_config_generation_options(opts)
164
+ section(opts, 'Config Generation') do
165
+ option(opts, '--auto-gen-config')
116
166
 
117
- option(opts, '--disable-uncorrectable')
167
+ option(opts, '--regenerate-todo') do
168
+ @options.replace(ConfigRegeneration.new.options.merge(@options))
169
+ end
118
170
 
119
- option(opts, '--[no-]offense-counts')
120
- option(opts, '--[no-]auto-gen-only-exclude')
121
- option(opts, '--[no-]auto-gen-timestamp')
171
+ option(opts, '--exclude-limit COUNT') { @validator.validate_exclude_limit_option }
122
172
 
123
- option(opts, '--init')
173
+ option(opts, '--[no-]offense-counts')
174
+ option(opts, '--[no-]auto-gen-only-exclude')
175
+ option(opts, '--[no-]auto-gen-timestamp')
176
+ end
124
177
  end
125
178
 
126
- def add_formatting_options(opts)
127
- option(opts, '-f', '--format FORMATTER') do |key|
128
- @options[:formatters] ||= []
129
- @options[:formatters] << [key]
130
- end
179
+ def add_cop_selection_csv_option(option, opts)
180
+ option(opts, "--#{option} [COP1,COP2,...]") do |list|
181
+ unless list
182
+ message = "--#{option} argument should be [COP1,COP2,...]."
131
183
 
132
- option(opts, '-o', '--out FILE') do |path|
133
- if @options[:formatters]
134
- @options[:formatters].last << path
135
- else
136
- @options[:output_path] = path
184
+ raise OptionArgumentError, message
137
185
  end
138
- end
139
186
 
140
- option(opts, '--display-time')
141
- option(opts, '--display-only-failed')
187
+ @options[:"#{option}"] = list.empty? ? [''] : list.split(',')
188
+ end
142
189
  end
143
190
 
144
191
  def add_severity_option(opts)
@@ -148,62 +195,68 @@ module RuboCop
148
195
  table) do |severity|
149
196
  @options[:fail_level] = severity
150
197
  end
151
- option(opts, '--display-only-fail-level-offenses')
152
198
  end
153
199
 
154
- def add_flags_with_optional_args(opts)
155
- option(opts, '--show-cops [COP1,COP2,...]') do |list|
156
- @options[:show_cops] = list.nil? ? [] : list.split(',')
200
+ def add_cache_options(opts)
201
+ section(opts, 'Caching') do
202
+ option(opts, '-C', '--cache FLAG')
203
+ option(opts, '--cache-root DIR') { @validator.validate_cache_enabled_for_cache_root }
157
204
  end
158
205
  end
159
206
 
160
- def add_cache_options(opts)
161
- option(opts, '-C', '--cache FLAG')
162
- option(opts, '--cache-root DIR') { @validator.validate_cache_enabled_for_cache_root }
163
- end
164
-
165
- # rubocop:disable Metrics/MethodLength, Metrics/AbcSize
166
- def add_boolean_flags(opts)
167
- option(opts, '-F', '--fail-fast')
168
- option(opts, '-d', '--debug')
169
- option(opts, '-D', '--[no-]display-cop-names')
170
- option(opts, '-E', '--extra-details')
171
- option(opts, '-S', '--display-style-guide')
172
- option(opts, '-a', '--auto-correct') { @options[:safe_auto_correct] = true }
173
- option(opts, '--safe-auto-correct') do
174
- warn '--safe-auto-correct is deprecated; use --auto-correct'
175
- @options[:safe_auto_correct] = @options[:auto_correct] = true
207
+ def add_server_options(opts)
208
+ section(opts, 'Server Options') do
209
+ option(opts, '--[no-]server')
210
+ option(opts, '--restart-server')
211
+ option(opts, '--start-server')
212
+ option(opts, '--stop-server')
213
+ option(opts, '--server-status')
176
214
  end
177
- option(opts, '-A', '--auto-correct-all') { @options[:auto_correct] = true }
178
- option(opts, '--disable-pending-cops')
179
- option(opts, '--enable-pending-cops')
180
- option(opts, '--ignore-disable-comments')
215
+ end
181
216
 
182
- option(opts, '--safe')
217
+ def add_additional_modes(opts)
218
+ section(opts, 'Additional Modes') do
219
+ option(opts, '-L', '--list-target-files')
220
+ option(opts, '--show-cops [COP1,COP2,...]') do |list|
221
+ @options[:show_cops] = list.nil? ? [] : list.split(',')
222
+ end
223
+ option(opts, '--show-docs-url [COP1,COP2,...]') do |list|
224
+ @options[:show_docs_url] = list.nil? ? [] : list.split(',')
225
+ end
226
+ end
227
+ end
183
228
 
184
- option(opts, '--stderr')
185
- option(opts, '--[no-]color')
229
+ def add_general_options(opts)
230
+ section(opts, 'General Options') do
231
+ option(opts, '--init')
232
+ option(opts, '-c', '--config FILE')
233
+ option(opts, '-d', '--debug')
234
+ option(opts, '-r', '--require FILE') { |f| require_feature(f) }
235
+ option(opts, '--[no-]color')
236
+ option(opts, '-v', '--version')
237
+ option(opts, '-V', '--verbose-version')
238
+ end
239
+ end
186
240
 
187
- option(opts, '-v', '--version')
188
- option(opts, '-V', '--verbose-version')
189
- option(opts, '-P', '--[no-]parallel')
241
+ def handle_deprecated_option(old_option, new_option)
242
+ warn rainbow.wrap("#{old_option} is deprecated; use #{new_option} instead.").yellow
243
+ @options[long_opt_symbol([new_option])] = @options.delete(long_opt_symbol([old_option]))
190
244
  end
191
- # rubocop:enable Metrics/MethodLength, Metrics/AbcSize
192
245
 
193
- def add_aliases(opts)
194
- option(opts, '-l', '--lint') do
195
- @options[:only] ||= []
196
- @options[:only] << 'Lint'
197
- end
198
- option(opts, '-x', '--fix-layout') do
199
- @options[:only] ||= []
200
- @options[:only] << 'Layout'
201
- @options[:auto_correct] = true
246
+ def rainbow
247
+ @rainbow ||= begin
248
+ rainbow = Rainbow.new
249
+ rainbow.enabled = false if ARGV.include?('--no-color')
250
+ rainbow
202
251
  end
203
252
  end
204
253
 
205
- def add_list_options(opts)
206
- option(opts, '-L', '--list-target-files')
254
+ # Creates a section of options in order to separate them visually when
255
+ # using `--help`.
256
+ def section(opts, heading, &_block)
257
+ heading = rainbow.wrap(heading).bright
258
+ opts.separator("\n#{heading}:\n")
259
+ yield
207
260
  end
208
261
 
209
262
  # Sets a value in the @options hash, based on the given long option and its
@@ -218,10 +271,10 @@ module RuboCop
218
271
  end
219
272
 
220
273
  # Finds the option in `args` starting with -- and converts it to a symbol,
221
- # e.g. [..., '--auto-correct', ...] to :auto_correct.
274
+ # e.g. [..., '--autocorrect', ...] to :autocorrect.
222
275
  def long_opt_symbol(args)
223
276
  long_opt = args.find { |arg| arg.start_with?('--') }
224
- long_opt[2..-1].sub('[no-]', '').sub(/ .*/, '').tr('-', '_').gsub(/[\[\]]/, '').to_sym
277
+ long_opt[2..].sub('[no-]', '').sub(/ .*/, '').tr('-', '_').gsub(/[\[\]]/, '').to_sym
225
278
  end
226
279
 
227
280
  def require_feature(file)
@@ -292,11 +345,13 @@ module RuboCop
292
345
 
293
346
  if display_only_fail_level_offenses_with_autocorrect?
294
347
  raise OptionArgumentError, '--autocorrect cannot be used with ' \
295
- '--display-only-fail-level-offenses'
348
+ '--display-only-fail-level-offenses.'
296
349
  end
297
350
  validate_auto_gen_config
298
- validate_auto_correct
351
+ validate_autocorrect
299
352
  validate_display_only_failed
353
+ validate_display_only_failed_and_display_only_correctable
354
+ validate_display_only_correctable_and_autocorrect
300
355
  disable_parallel_when_invalid_option_combo
301
356
 
302
357
  return if incompatible_options.size <= 1
@@ -326,35 +381,49 @@ module RuboCop
326
381
  format('--display-only-failed can only be used together with --format junit.')
327
382
  end
328
383
 
329
- def validate_auto_correct
330
- return if @options.key?(:auto_correct)
384
+ def validate_display_only_correctable_and_autocorrect
385
+ return unless @options.key?(:autocorrect)
386
+ return if !@options.key?(:display_only_correctable) &&
387
+ !@options.key?(:display_only_safe_correctable)
388
+
389
+ raise OptionArgumentError,
390
+ '--autocorrect cannot be used with --display-only-[safe-]correctable.'
391
+ end
392
+
393
+ def validate_display_only_failed_and_display_only_correctable
394
+ return unless @options.key?(:display_only_failed)
395
+ return if !@options.key?(:display_only_correctable) &&
396
+ !@options.key?(:display_only_safe_correctable)
397
+
398
+ raise OptionArgumentError,
399
+ format('--display-only-failed cannot be used together with other display options.')
400
+ end
401
+
402
+ def validate_autocorrect
403
+ return if @options.key?(:autocorrect)
331
404
  return unless @options.key?(:disable_uncorrectable)
332
405
 
333
406
  raise OptionArgumentError,
334
- format('--disable-uncorrectable can only be used together with --auto-correct.')
407
+ format('--disable-uncorrectable can only be used together with --autocorrect.')
335
408
  end
336
409
 
337
410
  def disable_parallel_when_invalid_option_combo
338
411
  return unless @options.key?(:parallel)
339
412
 
340
- invalid_options = [
341
- { name: :auto_gen_config, value: true, flag: '--auto-gen-config' },
342
- { name: :fail_fast, value: true, flag: '-F/--fail-fast.' },
343
- { name: :auto_correct, value: true, flag: '--auto-correct.' },
344
- { name: :cache, value: 'false', flag: '--cache false' }
345
- ]
346
-
347
- invalid_flags = invalid_options.each_with_object([]) do |option, flags|
348
- # `>` rather than `>=` because `@options` will also contain `parallel: true`
349
- flags << option[:flag] if @options > { option[:name] => option[:value] }
350
- end
413
+ invalid_flags = invalid_arguments_for_parallel
351
414
 
352
415
  return if invalid_flags.empty?
353
416
 
354
417
  @options.delete(:parallel)
355
418
 
356
419
  puts '-P/--parallel is being ignored because ' \
357
- "it is not compatible with #{invalid_flags.join(', ')}"
420
+ "it is not compatible with #{invalid_flags.join(', ')}."
421
+ end
422
+
423
+ def invalid_arguments_for_parallel
424
+ [('--auto-gen-config' if @options.key?(:auto_gen_config)),
425
+ ('-F/--fail-fast' if @options.key?(:fail_fast)),
426
+ ('--cache false' if @options > { cache: 'false' })].compact
358
427
  end
359
428
 
360
429
  def only_includes_redundant_disable?
@@ -363,7 +432,7 @@ module RuboCop
363
432
  end
364
433
 
365
434
  def display_only_fail_level_offenses_with_autocorrect?
366
- @options[:display_only_fail_level_offenses] && @options[:autocorrect]
435
+ @options.key?(:display_only_fail_level_offenses) && @options.key?(:autocorrect)
367
436
  end
368
437
 
369
438
  def except_syntax?
@@ -389,7 +458,7 @@ module RuboCop
389
458
  def validate_cache_enabled_for_cache_root
390
459
  return unless @options[:cache] == 'false'
391
460
 
392
- raise OptionArgumentError, '--cache-root can not be used with --cache false'
461
+ raise OptionArgumentError, '--cache-root cannot be used with --cache false'
393
462
  end
394
463
  end
395
464
 
@@ -403,7 +472,7 @@ module RuboCop
403
472
  only: 'Run only the given cop(s).',
404
473
  only_guide_cops: ['Run only cops for rules that link to a',
405
474
  'style guide.'],
406
- except: 'Disable the given cop(s).',
475
+ except: 'Exclude the given cop(s).',
407
476
  require: 'Require Ruby file.',
408
477
  config: 'Specify configuration file.',
409
478
  auto_gen_config: ['Generate a configuration file acting as a',
@@ -422,45 +491,58 @@ module RuboCop
422
491
  'when running --auto-gen-config, except if the',
423
492
  'number of files with offenses is bigger than',
424
493
  'exclude-limit. Default is false.'],
425
- exclude_limit: ['Used together with --auto-gen-config to',
426
- 'set the limit for how many Exclude',
427
- "properties to generate. Default is #{MAX_EXCL}."],
428
- disable_uncorrectable: ['Used with --auto-correct to annotate any',
494
+ exclude_limit: ['Set the limit for how many files to explicitly exclude.',
495
+ 'If there are more files than the limit, the cop will',
496
+ "be disabled instead. Default is #{MAX_EXCL}."],
497
+ disable_uncorrectable: ['Used with --autocorrect to annotate any',
429
498
  'offenses that do not support autocorrect',
430
499
  'with `rubocop:todo` comments.'],
431
- force_exclusion: ['Force excluding files specified in the',
432
- 'configuration `Exclude` even if they are',
433
- 'explicitly passed as arguments.'],
500
+ force_exclusion: ['Any files excluded by `Exclude` in configuration',
501
+ 'files will be excluded, even if given explicitly',
502
+ 'as arguments.'],
434
503
  only_recognized_file_types: ['Inspect files given on the command line only if',
435
- 'they are listed in AllCops/Include parameters',
504
+ 'they are listed in `AllCops/Include` parameters',
436
505
  'of user configuration or default configuration.'],
437
506
  ignore_disable_comments: ['Run cops even when they are disabled locally',
438
- 'with a comment.'],
439
- ignore_parent_exclusion: ['Prevent from inheriting AllCops/Exclude from',
507
+ 'by a `rubocop:disable` directive.'],
508
+ ignore_parent_exclusion: ['Prevent from inheriting `AllCops/Exclude` from',
440
509
  'parent folders.'],
510
+ ignore_unrecognized_cops: ['Ignore unrecognized cops or departments in the config.'],
441
511
  force_default_config: ['Use default configuration even if configuration',
442
512
  'files are present in the directory tree.'],
443
513
  format: ['Choose an output formatter. This option',
444
514
  'can be specified multiple times to enable',
445
515
  'multiple formatters at the same time.',
446
- '[p]rogress is used by default',
447
- *FORMATTER_OPTION_LIST.map { |item| " #{item}" },
516
+ *FORMATTER_OPTION_LIST.map do |item|
517
+ " #{item}#{' (default)' if item == '[p]rogress'}"
518
+ end,
448
519
  ' custom formatter class name'],
449
520
  out: ['Write output to a file instead of STDOUT.',
450
521
  'This option applies to the previously',
451
522
  'specified --format, or the default format',
452
523
  'if no format is specified.'],
453
- fail_level: ['Minimum severity (A/I/R/C/W/E/F) for exit',
454
- 'with error code.'],
524
+ fail_level: ['Minimum severity for exit with error code.',
525
+ ' [A] autocorrect',
526
+ ' [I] info',
527
+ ' [R] refactor',
528
+ ' [C] convention',
529
+ ' [W] warning',
530
+ ' [E] error',
531
+ ' [F] fatal'],
455
532
  display_time: 'Display elapsed time in seconds.',
456
533
  display_only_failed: ['Only output offense messages. Omit passing',
457
534
  'cops. Only valid for --format junit.'],
458
535
  display_only_fail_level_offenses:
459
536
  ['Only output offense messages at',
460
537
  'the specified --fail-level or above'],
538
+ display_only_correctable: ['Only output correctable offense messages.'],
539
+ display_only_safe_correctable: ['Only output safe-correctable offense messages',
540
+ 'when combined with --display-only-correctable.'],
461
541
  show_cops: ['Shows the given cops, or all cops by',
462
542
  'default, and their configurations for the',
463
543
  'current directory.'],
544
+ show_docs_url: ['Display url to documentation for the given',
545
+ 'cops, or base url by default.'],
464
546
  fail_fast: ['Inspect files in order of modification',
465
547
  'time and stop after the first file',
466
548
  'containing offenses.'],
@@ -482,12 +564,14 @@ module RuboCop
482
564
  safe: 'Run only safe cops.',
483
565
  stderr: ['Write all output to stderr except for the',
484
566
  'autocorrected source. This is especially useful',
485
- 'when combined with --auto-correct and --stdin.'],
567
+ 'when combined with --autocorrect and --stdin.'],
486
568
  list_target_files: 'List all files RuboCop will inspect.',
487
- auto_correct: 'Auto-correct offenses (only when it\'s safe).',
569
+ autocorrect: 'Autocorrect offenses (only when it\'s safe).',
570
+ auto_correct: '(same, deprecated)',
488
571
  safe_auto_correct: '(same, deprecated)',
489
- auto_correct_all: 'Auto-correct offenses (safe and unsafe)',
490
- fix_layout: 'Run only layout cops, with auto-correct on.',
572
+ autocorrect_all: 'Autocorrect offenses (safe and unsafe).',
573
+ auto_correct_all: '(same, deprecated)',
574
+ fix_layout: 'Run only layout cops, with autocorrect on.',
491
575
  color: 'Force color output on or off.',
492
576
  version: 'Display version.',
493
577
  verbose_version: 'Display verbose version.',
@@ -495,7 +579,17 @@ module RuboCop
495
579
  'parallel. Default is true.'],
496
580
  stdin: ['Pipe source from STDIN, using FILE in offense',
497
581
  'reports. This is useful for editor integration.'],
498
- init: 'Generate a .rubocop.yml file in the current directory.'
582
+ init: 'Generate a .rubocop.yml file in the current directory.',
583
+ server: ['If a server process has not been started yet, start',
584
+ 'the server process and execute inspection with server.',
585
+ 'Default is false.',
586
+ 'You can specify the server host and port with the',
587
+ '$RUBOCOP_SERVER_HOST and the $RUBOCOP_SERVER_PORT',
588
+ 'environment variables.'],
589
+ restart_server: 'Restart server process.',
590
+ start_server: 'Start server process.',
591
+ stop_server: 'Stop server process.',
592
+ server_status: 'Show server status.'
499
593
  }.freeze
500
594
  end
501
595
  end
@@ -32,8 +32,17 @@ module RuboCop
32
32
 
33
33
  private
34
34
 
35
+ def perform(option)
36
+ options = full_options.unshift(option)
37
+ # `parallel` will automatically be removed from the options internally.
38
+ # This is a nice to have to suppress the warning message
39
+ # about --parallel and --autocorrect not being compatible.
40
+ options.delete('--parallel')
41
+ run_cli(verbose, options)
42
+ end
43
+
35
44
  def run_cli(verbose, options)
36
- # We lazy-load rubocop so that the task doesn't dramatically impact the
45
+ # We lazy-load RuboCop so that the task doesn't dramatically impact the
37
46
  # load time of your Rakefile.
38
47
  require 'rubocop'
39
48
 
@@ -60,19 +69,35 @@ module RuboCop
60
69
  @formatters = []
61
70
  end
62
71
 
63
- def setup_subtasks(name, *args, &task_block)
72
+ def setup_subtasks(name, *args, &task_block) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
64
73
  namespace(name) do
65
- desc 'Auto-correct RuboCop offenses'
74
+ # rubocop:todo Naming/InclusiveLanguage
75
+ task(:auto_correct, *args) do
76
+ require 'rainbow'
77
+ warn Rainbow(
78
+ 'rubocop:auto_correct task is deprecated; ' \
79
+ 'use rubocop:autocorrect task or rubocop:autocorrect_all task instead.'
80
+ ).yellow
81
+ RakeFileUtils.verbose(verbose) do
82
+ yield(*[self, task_args].slice(0, task_block.arity)) if task_block
83
+ perform('--autocorrect')
84
+ end
85
+ end
86
+ # rubocop:enable Naming/InclusiveLanguage
87
+
88
+ desc "Autocorrect RuboCop offenses (only when it's safe)."
89
+ task(:autocorrect, *args) do |_, task_args|
90
+ RakeFileUtils.verbose(verbose) do
91
+ yield(*[self, task_args].slice(0, task_block.arity)) if task_block
92
+ perform('--autocorrect')
93
+ end
94
+ end
66
95
 
67
- task(:auto_correct, *args) do |_, task_args|
96
+ desc 'Autocorrect RuboCop offenses (safe and unsafe).'
97
+ task(:autocorrect_all, *args) do |_, task_args|
68
98
  RakeFileUtils.verbose(verbose) do
69
99
  yield(*[self, task_args].slice(0, task_block.arity)) if task_block
70
- options = full_options.unshift('--auto-correct-all')
71
- # `parallel` will automatically be removed from the options internally.
72
- # This is a nice to have to suppress the warning message
73
- # about parallel and auto-correct not being compatible.
74
- options.delete('--parallel')
75
- run_cli(verbose, options)
100
+ perform('--autocorrect-all')
76
101
  end
77
102
  end
78
103
  end
@@ -23,9 +23,7 @@ module RuboCop
23
23
  next if response.is_a?(Net::HTTPNotModified)
24
24
  next if response.is_a?(SocketError)
25
25
 
26
- File.open cache_path, 'w' do |io|
27
- io.write response.body
28
- end
26
+ File.write(cache_path, response.body)
29
27
  end
30
28
 
31
29
  cache_path
@@ -33,7 +31,7 @@ module RuboCop
33
31
 
34
32
  def inherit_from_remote(file, path)
35
33
  new_uri = @uri.dup
36
- new_uri.path.gsub!(%r{/[^/]*$}, "/#{file}")
34
+ new_uri.path.gsub!(%r{/[^/]*$}, "/#{file.delete_prefix('./')}")
37
35
  RemoteConfig.new(new_uri.to_s, File.dirname(path))
38
36
  end
39
37