rubocop 1.19.0 → 1.33.0

Sign up to get free protection for your applications and to get access to all the features.
Files changed (618) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE.txt +1 -1
  3. data/README.md +8 -7
  4. data/config/default.yml +417 -83
  5. data/config/obsoletion.yml +35 -2
  6. data/exe/rubocop +15 -7
  7. data/lib/rubocop/cache_config.rb +29 -0
  8. data/lib/rubocop/cli/command/auto_genenerate_config.rb +21 -6
  9. data/lib/rubocop/cli/command/execute_runner.rb +1 -1
  10. data/lib/rubocop/cli/command/init_dotfile.rb +2 -2
  11. data/lib/rubocop/cli/command/show_cops.rb +1 -1
  12. data/lib/rubocop/cli/command/show_docs_url.rb +48 -0
  13. data/lib/rubocop/cli/command/suggest_extensions.rb +5 -5
  14. data/lib/rubocop/cli.rb +4 -1
  15. data/lib/rubocop/config.rb +10 -1
  16. data/lib/rubocop/config_finder.rb +68 -0
  17. data/lib/rubocop/config_loader.rb +12 -48
  18. data/lib/rubocop/config_loader_resolver.rb +2 -2
  19. data/lib/rubocop/config_obsoletion/changed_parameter.rb +5 -0
  20. data/lib/rubocop/config_obsoletion/extracted_cop.rb +3 -1
  21. data/lib/rubocop/config_obsoletion/parameter_rule.rb +4 -0
  22. data/lib/rubocop/config_obsoletion.rb +7 -2
  23. data/lib/rubocop/config_validator.rb +30 -5
  24. data/lib/rubocop/cop/autocorrect_logic.rb +8 -2
  25. data/lib/rubocop/cop/badge.rb +8 -2
  26. data/lib/rubocop/cop/base.rb +9 -5
  27. data/lib/rubocop/cop/bundler/duplicated_gem.rb +4 -8
  28. data/lib/rubocop/cop/bundler/gem_comment.rb +3 -3
  29. data/lib/rubocop/cop/bundler/gem_filename.rb +103 -0
  30. data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +45 -21
  31. data/lib/rubocop/cop/bundler/ordered_gems.rb +5 -14
  32. data/lib/rubocop/cop/corrector.rb +2 -2
  33. data/lib/rubocop/cop/correctors/alignment_corrector.rb +1 -1
  34. data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -1
  35. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +2 -2
  36. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
  37. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +4 -2
  38. data/lib/rubocop/cop/correctors/if_then_corrector.rb +55 -0
  39. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +3 -3
  40. data/lib/rubocop/cop/correctors/line_break_corrector.rb +8 -2
  41. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +3 -3
  42. data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +12 -11
  43. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +1 -1
  44. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
  45. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
  46. data/lib/rubocop/cop/correctors/space_corrector.rb +1 -1
  47. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +1 -1
  48. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +2 -2
  49. data/lib/rubocop/cop/documentation.rb +20 -3
  50. data/lib/rubocop/cop/gemspec/dependency_version.rb +156 -0
  51. data/lib/rubocop/cop/gemspec/deprecated_attribute_assignment.rb +92 -0
  52. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +6 -22
  53. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +4 -13
  54. data/lib/rubocop/cop/gemspec/require_mfa.rb +145 -0
  55. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +41 -27
  56. data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +4 -11
  57. data/lib/rubocop/cop/generator.rb +25 -19
  58. data/lib/rubocop/cop/internal_affairs/cop_description.rb +96 -0
  59. data/lib/rubocop/cop/internal_affairs/empty_line_between_expect_offense_and_correction.rb +1 -1
  60. data/lib/rubocop/cop/internal_affairs/location_line_equality_comparison.rb +60 -0
  61. data/lib/rubocop/cop/internal_affairs/method_name_end_with.rb +80 -0
  62. data/lib/rubocop/cop/internal_affairs/node_matcher_directive.rb +2 -6
  63. data/lib/rubocop/cop/internal_affairs/redundant_context_config_parameter.rb +46 -0
  64. data/lib/rubocop/cop/internal_affairs/redundant_described_class_as_subject.rb +1 -1
  65. data/lib/rubocop/cop/internal_affairs/redundant_let_rubocop_config_new.rb +1 -1
  66. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
  67. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -1
  68. data/lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb +47 -0
  69. data/lib/rubocop/cop/internal_affairs/undefined_config.rb +3 -1
  70. data/lib/rubocop/cop/internal_affairs/useless_restrict_on_send.rb +60 -0
  71. data/lib/rubocop/cop/internal_affairs.rb +6 -0
  72. data/lib/rubocop/cop/layout/argument_alignment.rb +57 -9
  73. data/lib/rubocop/cop/layout/assignment_indentation.rb +2 -2
  74. data/lib/rubocop/cop/layout/begin_end_alignment.rb +1 -1
  75. data/lib/rubocop/cop/layout/block_alignment.rb +4 -4
  76. data/lib/rubocop/cop/layout/block_end_newline.rb +33 -6
  77. data/lib/rubocop/cop/layout/case_indentation.rb +17 -1
  78. data/lib/rubocop/cop/layout/class_structure.rb +2 -1
  79. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -1
  80. data/lib/rubocop/cop/layout/comment_indentation.rb +33 -4
  81. data/lib/rubocop/cop/layout/condition_position.rb +1 -1
  82. data/lib/rubocop/cop/layout/def_end_alignment.rb +1 -1
  83. data/lib/rubocop/cop/layout/dot_position.rb +39 -6
  84. data/lib/rubocop/cop/layout/else_alignment.rb +1 -1
  85. data/lib/rubocop/cop/layout/empty_comment.rb +3 -3
  86. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +1 -1
  87. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +1 -1
  88. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +23 -2
  89. data/lib/rubocop/cop/layout/empty_lines.rb +1 -1
  90. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +1 -1
  91. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +25 -4
  92. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +1 -1
  93. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +5 -5
  94. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +10 -10
  95. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +12 -5
  96. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +1 -1
  97. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +10 -10
  98. data/lib/rubocop/cop/layout/end_alignment.rb +3 -4
  99. data/lib/rubocop/cop/layout/end_of_line.rb +1 -1
  100. data/lib/rubocop/cop/layout/extra_spacing.rb +1 -1
  101. data/lib/rubocop/cop/layout/first_argument_indentation.rb +34 -29
  102. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +22 -15
  103. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +1 -1
  104. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +53 -14
  105. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +1 -1
  106. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +1 -1
  107. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +1 -1
  108. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +2 -2
  109. data/lib/rubocop/cop/layout/hash_alignment.rb +10 -3
  110. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +2 -2
  111. data/lib/rubocop/cop/layout/heredoc_indentation.rb +1 -1
  112. data/lib/rubocop/cop/layout/indentation_consistency.rb +1 -1
  113. data/lib/rubocop/cop/layout/indentation_style.rb +1 -1
  114. data/lib/rubocop/cop/layout/indentation_width.rb +12 -10
  115. data/lib/rubocop/cop/layout/initial_indentation.rb +2 -2
  116. data/lib/rubocop/cop/layout/leading_comment_space.rb +2 -2
  117. data/lib/rubocop/cop/layout/leading_empty_lines.rb +1 -1
  118. data/lib/rubocop/cop/layout/line_continuation_leading_space.rb +112 -0
  119. data/lib/rubocop/cop/layout/line_continuation_spacing.rb +130 -0
  120. data/lib/rubocop/cop/layout/line_end_string_concatenation_indentation.rb +2 -2
  121. data/lib/rubocop/cop/layout/line_length.rb +16 -12
  122. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +1 -1
  123. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +1 -1
  124. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +2 -2
  125. data/lib/rubocop/cop/layout/multiline_block_layout.rb +5 -5
  126. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +1 -1
  127. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +1 -1
  128. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +7 -1
  129. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +1 -1
  130. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +23 -6
  131. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +1 -1
  132. data/lib/rubocop/cop/layout/multiline_method_parameter_line_breaks.rb +45 -0
  133. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +9 -10
  134. data/lib/rubocop/cop/layout/redundant_line_break.rb +5 -5
  135. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +8 -7
  136. data/lib/rubocop/cop/layout/single_line_block_chain.rb +16 -5
  137. data/lib/rubocop/cop/layout/space_after_colon.rb +1 -1
  138. data/lib/rubocop/cop/layout/space_after_not.rb +2 -1
  139. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +2 -2
  140. data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +2 -1
  141. data/lib/rubocop/cop/layout/space_around_keyword.rb +2 -2
  142. data/lib/rubocop/cop/layout/space_around_operators.rb +1 -1
  143. data/lib/rubocop/cop/layout/space_before_block_braces.rb +3 -3
  144. data/lib/rubocop/cop/layout/space_before_brackets.rb +8 -0
  145. data/lib/rubocop/cop/layout/space_before_comment.rb +2 -2
  146. data/lib/rubocop/cop/layout/space_before_first_arg.rb +5 -1
  147. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +12 -6
  148. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +10 -10
  149. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +8 -6
  150. data/lib/rubocop/cop/layout/space_inside_parens.rb +74 -28
  151. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +2 -2
  152. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +1 -1
  153. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +9 -9
  154. data/lib/rubocop/cop/layout/trailing_whitespace.rb +3 -3
  155. data/lib/rubocop/cop/lint/ambiguous_assignment.rb +1 -1
  156. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +28 -7
  157. data/lib/rubocop/cop/lint/ambiguous_operator.rb +7 -7
  158. data/lib/rubocop/cop/lint/ambiguous_operator_precedence.rb +111 -0
  159. data/lib/rubocop/cop/lint/ambiguous_range.rb +13 -13
  160. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +6 -2
  161. data/lib/rubocop/cop/lint/assignment_in_condition.rb +8 -6
  162. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +19 -6
  163. data/lib/rubocop/cop/lint/boolean_symbol.rb +6 -1
  164. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  165. data/lib/rubocop/cop/lint/constant_definition_in_block.rb +1 -1
  166. data/lib/rubocop/cop/lint/constant_overwritten_in_rescue.rb +51 -0
  167. data/lib/rubocop/cop/lint/debugger.rb +14 -6
  168. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +31 -13
  169. data/lib/rubocop/cop/lint/deprecated_constants.rb +4 -3
  170. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +6 -0
  171. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +24 -1
  172. data/lib/rubocop/cop/lint/duplicate_branch.rb +1 -1
  173. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  174. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +1 -1
  175. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
  176. data/lib/rubocop/cop/lint/duplicate_methods.rb +1 -1
  177. data/lib/rubocop/cop/lint/duplicate_regexp_character_class_element.rb +1 -1
  178. data/lib/rubocop/cop/lint/duplicate_require.rb +11 -2
  179. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +1 -1
  180. data/lib/rubocop/cop/lint/each_with_object_argument.rb +2 -2
  181. data/lib/rubocop/cop/lint/else_layout.rb +13 -9
  182. data/lib/rubocop/cop/lint/empty_block.rb +1 -1
  183. data/lib/rubocop/cop/lint/empty_class.rb +1 -1
  184. data/lib/rubocop/cop/lint/empty_conditional_body.rb +64 -3
  185. data/lib/rubocop/cop/lint/empty_ensure.rb +1 -1
  186. data/lib/rubocop/cop/lint/empty_expression.rb +1 -1
  187. data/lib/rubocop/cop/lint/empty_file.rb +1 -1
  188. data/lib/rubocop/cop/lint/empty_in_pattern.rb +4 -2
  189. data/lib/rubocop/cop/lint/empty_interpolation.rb +1 -1
  190. data/lib/rubocop/cop/lint/empty_when.rb +4 -2
  191. data/lib/rubocop/cop/lint/ensure_return.rb +1 -1
  192. data/lib/rubocop/cop/lint/erb_new_arguments.rb +2 -2
  193. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  194. data/lib/rubocop/cop/lint/float_comparison.rb +1 -1
  195. data/lib/rubocop/cop/lint/float_out_of_range.rb +2 -2
  196. data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +12 -3
  197. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +1 -1
  198. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +1 -1
  199. data/lib/rubocop/cop/lint/incompatible_io_select_with_fiber_scheduler.rb +79 -0
  200. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -1
  201. data/lib/rubocop/cop/lint/inherit_exception.rb +19 -28
  202. data/lib/rubocop/cop/lint/interpolation_check.rb +7 -2
  203. data/lib/rubocop/cop/lint/lambda_without_literal_block.rb +10 -3
  204. data/lib/rubocop/cop/lint/literal_as_condition.rb +6 -1
  205. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +1 -1
  206. data/lib/rubocop/cop/lint/loop.rb +5 -4
  207. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +1 -1
  208. data/lib/rubocop/cop/lint/missing_super.rb +1 -1
  209. data/lib/rubocop/cop/lint/nested_method_definition.rb +1 -1
  210. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
  211. data/lib/rubocop/cop/lint/non_atomic_file_operation.rb +157 -0
  212. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +9 -5
  213. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
  214. data/lib/rubocop/cop/lint/number_conversion.rb +47 -11
  215. data/lib/rubocop/cop/lint/numbered_parameter_assignment.rb +2 -2
  216. data/lib/rubocop/cop/lint/or_assignment_to_constant.rb +4 -3
  217. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +17 -0
  218. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +12 -8
  219. data/lib/rubocop/cop/lint/percent_string_array.rb +11 -1
  220. data/lib/rubocop/cop/lint/percent_symbol_array.rb +1 -1
  221. data/lib/rubocop/cop/lint/raise_exception.rb +5 -1
  222. data/lib/rubocop/cop/lint/rand_one.rb +1 -1
  223. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +6 -6
  224. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +2 -2
  225. data/lib/rubocop/cop/lint/redundant_dir_glob_sort.rb +5 -0
  226. data/lib/rubocop/cop/lint/redundant_require_statement.rb +4 -1
  227. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +13 -5
  228. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +1 -1
  229. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -1
  230. data/lib/rubocop/cop/lint/redundant_with_index.rb +1 -1
  231. data/lib/rubocop/cop/lint/redundant_with_object.rb +1 -1
  232. data/lib/rubocop/cop/lint/refinement_import_methods.rb +51 -0
  233. data/lib/rubocop/cop/lint/regexp_as_condition.rb +3 -3
  234. data/lib/rubocop/cop/lint/require_parentheses.rb +1 -1
  235. data/lib/rubocop/cop/lint/require_range_parentheses.rb +57 -0
  236. data/lib/rubocop/cop/lint/require_relative_self_path.rb +50 -0
  237. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  238. data/lib/rubocop/cop/lint/return_in_void_context.rb +6 -18
  239. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +38 -1
  240. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +1 -1
  241. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
  242. data/lib/rubocop/cop/lint/script_permission.rb +1 -1
  243. data/lib/rubocop/cop/lint/self_assignment.rb +1 -1
  244. data/lib/rubocop/cop/lint/shadowed_argument.rb +1 -1
  245. data/lib/rubocop/cop/lint/shadowed_exception.rb +1 -1
  246. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +12 -2
  247. data/lib/rubocop/cop/lint/struct_new_override.rb +3 -3
  248. data/lib/rubocop/cop/lint/suppressed_exception.rb +1 -1
  249. data/lib/rubocop/cop/lint/symbol_conversion.rb +5 -4
  250. data/lib/rubocop/cop/lint/syntax.rb +2 -3
  251. data/lib/rubocop/cop/lint/to_enum_arguments.rb +1 -1
  252. data/lib/rubocop/cop/lint/to_json.rb +1 -1
  253. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
  254. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +2 -2
  255. data/lib/rubocop/cop/lint/triple_quotes.rb +1 -1
  256. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +1 -1
  257. data/lib/rubocop/cop/lint/unexpected_block_arity.rb +9 -4
  258. data/lib/rubocop/cop/lint/unified_integer.rb +3 -1
  259. data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
  260. data/lib/rubocop/cop/lint/unreachable_loop.rb +5 -5
  261. data/lib/rubocop/cop/lint/unused_block_argument.rb +1 -1
  262. data/lib/rubocop/cop/lint/unused_method_argument.rb +4 -5
  263. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
  264. data/lib/rubocop/cop/lint/uri_regexp.rb +1 -1
  265. data/lib/rubocop/cop/lint/useless_access_modifier.rb +1 -1
  266. data/lib/rubocop/cop/lint/useless_assignment.rb +1 -1
  267. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +2 -3
  268. data/lib/rubocop/cop/lint/useless_method_definition.rb +4 -3
  269. data/lib/rubocop/cop/lint/useless_ruby2_keywords.rb +117 -0
  270. data/lib/rubocop/cop/lint/useless_setter_call.rb +8 -5
  271. data/lib/rubocop/cop/lint/useless_times.rb +19 -14
  272. data/lib/rubocop/cop/lint/void.rb +1 -1
  273. data/lib/rubocop/cop/metrics/abc_size.rb +10 -2
  274. data/lib/rubocop/cop/metrics/block_length.rb +8 -7
  275. data/lib/rubocop/cop/metrics/block_nesting.rb +1 -1
  276. data/lib/rubocop/cop/metrics/class_length.rb +1 -1
  277. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +1 -10
  278. data/lib/rubocop/cop/metrics/method_length.rb +10 -8
  279. data/lib/rubocop/cop/metrics/module_length.rb +2 -2
  280. data/lib/rubocop/cop/metrics/parameter_lists.rb +6 -3
  281. data/lib/rubocop/cop/metrics/perceived_complexity.rb +2 -2
  282. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +3 -4
  283. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +24 -5
  284. data/lib/rubocop/cop/metrics/utils/repeated_attribute_discount.rb +1 -1
  285. data/lib/rubocop/cop/mixin/allowed_methods.rb +15 -1
  286. data/lib/rubocop/cop/mixin/allowed_pattern.rb +48 -0
  287. data/lib/rubocop/cop/mixin/annotation_comment.rb +57 -34
  288. data/lib/rubocop/cop/mixin/check_line_breakable.rb +4 -0
  289. data/lib/rubocop/cop/mixin/code_length.rb +1 -1
  290. data/lib/rubocop/cop/mixin/comments_help.rb +28 -2
  291. data/lib/rubocop/cop/mixin/def_node.rb +2 -7
  292. data/lib/rubocop/cop/mixin/documentation_comment.rb +5 -2
  293. data/lib/rubocop/cop/mixin/duplication.rb +1 -1
  294. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +1 -2
  295. data/lib/rubocop/cop/mixin/enforce_superclass.rb +5 -0
  296. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +23 -1
  297. data/lib/rubocop/cop/mixin/gemspec_help.rb +30 -0
  298. data/lib/rubocop/cop/mixin/hash_alignment_styles.rb +4 -3
  299. data/lib/rubocop/cop/mixin/hash_shorthand_syntax.rb +86 -0
  300. data/lib/rubocop/cop/mixin/hash_transform_method.rb +3 -3
  301. data/lib/rubocop/cop/mixin/heredoc.rb +1 -3
  302. data/lib/rubocop/cop/mixin/line_length_help.rb +17 -6
  303. data/lib/rubocop/cop/mixin/method_complexity.rb +4 -9
  304. data/lib/rubocop/cop/mixin/multiline_element_indentation.rb +35 -13
  305. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +6 -5
  306. data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +1 -1
  307. data/lib/rubocop/cop/mixin/ordered_gem_node.rb +9 -1
  308. data/lib/rubocop/cop/mixin/percent_array.rb +70 -3
  309. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +9 -1
  310. data/lib/rubocop/cop/mixin/preferred_delimiters.rb +2 -2
  311. data/lib/rubocop/cop/mixin/range_help.rb +7 -3
  312. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +1 -1
  313. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +1 -1
  314. data/lib/rubocop/cop/mixin/statement_modifier.rb +2 -2
  315. data/lib/rubocop/cop/mixin/string_help.rb +1 -1
  316. data/lib/rubocop/cop/mixin/surrounding_space.rb +4 -2
  317. data/lib/rubocop/cop/mixin/trailing_body.rb +1 -1
  318. data/lib/rubocop/cop/mixin/trailing_comma.rb +1 -1
  319. data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
  320. data/lib/rubocop/cop/naming/ascii_identifiers.rb +1 -4
  321. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
  322. data/lib/rubocop/cop/naming/block_forwarding.rb +121 -0
  323. data/lib/rubocop/cop/naming/block_parameter_name.rb +2 -2
  324. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +1 -1
  325. data/lib/rubocop/cop/naming/constant_name.rb +2 -2
  326. data/lib/rubocop/cop/naming/file_name.rb +39 -6
  327. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +1 -1
  328. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +1 -1
  329. data/lib/rubocop/cop/naming/inclusive_language.rb +12 -11
  330. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +6 -5
  331. data/lib/rubocop/cop/naming/method_name.rb +6 -6
  332. data/lib/rubocop/cop/naming/method_parameter_name.rb +2 -2
  333. data/lib/rubocop/cop/naming/predicate_name.rb +32 -3
  334. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +8 -1
  335. data/lib/rubocop/cop/naming/variable_name.rb +10 -1
  336. data/lib/rubocop/cop/naming/variable_number.rb +28 -18
  337. data/lib/rubocop/cop/offense.rb +1 -1
  338. data/lib/rubocop/cop/security/compound_hash.rb +105 -0
  339. data/lib/rubocop/cop/security/eval.rb +1 -1
  340. data/lib/rubocop/cop/security/io_methods.rb +49 -0
  341. data/lib/rubocop/cop/security/json_load.rb +9 -8
  342. data/lib/rubocop/cop/security/marshal_load.rb +1 -1
  343. data/lib/rubocop/cop/security/open.rb +15 -1
  344. data/lib/rubocop/cop/security/yaml_load.rb +14 -4
  345. data/lib/rubocop/cop/style/accessor_grouping.rb +6 -6
  346. data/lib/rubocop/cop/style/alias.rb +4 -4
  347. data/lib/rubocop/cop/style/and_or.rb +14 -9
  348. data/lib/rubocop/cop/style/arguments_forwarding.rb +14 -3
  349. data/lib/rubocop/cop/style/array_coercion.rb +22 -4
  350. data/lib/rubocop/cop/style/array_join.rb +1 -1
  351. data/lib/rubocop/cop/style/ascii_comments.rb +1 -4
  352. data/lib/rubocop/cop/style/attr.rb +1 -1
  353. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +1 -1
  354. data/lib/rubocop/cop/style/bare_percent_literals.rb +1 -1
  355. data/lib/rubocop/cop/style/bisected_attr_accessor/macro.rb +1 -1
  356. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +1 -1
  357. data/lib/rubocop/cop/style/block_comments.rb +1 -1
  358. data/lib/rubocop/cop/style/block_delimiters.rb +57 -14
  359. data/lib/rubocop/cop/style/case_equality.rb +7 -10
  360. data/lib/rubocop/cop/style/case_like_if.rb +6 -1
  361. data/lib/rubocop/cop/style/character_literal.rb +9 -2
  362. data/lib/rubocop/cop/style/class_and_module_children.rb +14 -5
  363. data/lib/rubocop/cop/style/class_check.rb +1 -1
  364. data/lib/rubocop/cop/style/class_equality_comparison.rb +51 -4
  365. data/lib/rubocop/cop/style/class_methods.rb +1 -1
  366. data/lib/rubocop/cop/style/class_methods_definitions.rb +1 -1
  367. data/lib/rubocop/cop/style/class_vars.rb +1 -1
  368. data/lib/rubocop/cop/style/collection_compact.rb +41 -21
  369. data/lib/rubocop/cop/style/collection_methods.rb +9 -7
  370. data/lib/rubocop/cop/style/colon_method_call.rb +1 -1
  371. data/lib/rubocop/cop/style/colon_method_definition.rb +1 -1
  372. data/lib/rubocop/cop/style/combinable_loops.rb +6 -5
  373. data/lib/rubocop/cop/style/command_literal.rb +1 -1
  374. data/lib/rubocop/cop/style/comment_annotation.rb +26 -40
  375. data/lib/rubocop/cop/style/commented_keyword.rb +12 -7
  376. data/lib/rubocop/cop/style/conditional_assignment.rb +2 -1
  377. data/lib/rubocop/cop/style/constant_visibility.rb +1 -1
  378. data/lib/rubocop/cop/style/date_time.rb +6 -1
  379. data/lib/rubocop/cop/style/def_with_parentheses.rb +17 -12
  380. data/lib/rubocop/cop/style/dir.rb +4 -1
  381. data/lib/rubocop/cop/style/document_dynamic_eval_definition.rb +1 -1
  382. data/lib/rubocop/cop/style/documentation.rb +24 -9
  383. data/lib/rubocop/cop/style/documentation_method.rb +1 -1
  384. data/lib/rubocop/cop/style/double_negation.rb +85 -7
  385. data/lib/rubocop/cop/style/each_for_simple_loop.rb +1 -1
  386. data/lib/rubocop/cop/style/each_with_object.rb +1 -1
  387. data/lib/rubocop/cop/style/empty_block_parameter.rb +1 -1
  388. data/lib/rubocop/cop/style/empty_case_condition.rb +13 -4
  389. data/lib/rubocop/cop/style/empty_else.rb +40 -3
  390. data/lib/rubocop/cop/style/empty_heredoc.rb +73 -0
  391. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +1 -1
  392. data/lib/rubocop/cop/style/empty_literal.rb +2 -2
  393. data/lib/rubocop/cop/style/empty_method.rb +19 -4
  394. data/lib/rubocop/cop/style/encoding.rb +27 -16
  395. data/lib/rubocop/cop/style/end_block.rb +1 -1
  396. data/lib/rubocop/cop/style/endless_method.rb +1 -1
  397. data/lib/rubocop/cop/style/env_home.rb +56 -0
  398. data/lib/rubocop/cop/style/eval_with_location.rb +1 -1
  399. data/lib/rubocop/cop/style/even_odd.rb +1 -1
  400. data/lib/rubocop/cop/style/expand_path_arguments.rb +1 -1
  401. data/lib/rubocop/cop/style/explicit_block_argument.rb +23 -13
  402. data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
  403. data/lib/rubocop/cop/style/fetch_env_var.rb +132 -0
  404. data/lib/rubocop/cop/style/file_read.rb +112 -0
  405. data/lib/rubocop/cop/style/file_write.rb +136 -0
  406. data/lib/rubocop/cop/style/float_division.rb +11 -3
  407. data/lib/rubocop/cop/style/for.rb +5 -1
  408. data/lib/rubocop/cop/style/format_string.rb +1 -1
  409. data/lib/rubocop/cop/style/format_string_token.rb +74 -23
  410. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +13 -5
  411. data/lib/rubocop/cop/style/global_std_stream.rb +5 -1
  412. data/lib/rubocop/cop/style/global_vars.rb +1 -1
  413. data/lib/rubocop/cop/style/guard_clause.rb +51 -4
  414. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +11 -0
  415. data/lib/rubocop/cop/style/hash_conversion.rb +3 -2
  416. data/lib/rubocop/cop/style/hash_each_methods.rb +6 -1
  417. data/lib/rubocop/cop/style/hash_except.rb +89 -12
  418. data/lib/rubocop/cop/style/hash_like_case.rb +1 -1
  419. data/lib/rubocop/cop/style/hash_syntax.rb +39 -3
  420. data/lib/rubocop/cop/style/hash_transform_keys.rb +16 -13
  421. data/lib/rubocop/cop/style/hash_transform_values.rb +14 -13
  422. data/lib/rubocop/cop/style/identical_conditional_branches.rb +19 -17
  423. data/lib/rubocop/cop/style/if_inside_else.rb +15 -0
  424. data/lib/rubocop/cop/style/if_unless_modifier.rb +5 -4
  425. data/lib/rubocop/cop/style/if_with_boolean_literal_branches.rb +22 -6
  426. data/lib/rubocop/cop/style/implicit_runtime_error.rb +3 -3
  427. data/lib/rubocop/cop/style/in_pattern_then.rb +1 -1
  428. data/lib/rubocop/cop/style/infinite_loop.rb +4 -3
  429. data/lib/rubocop/cop/style/inline_comment.rb +1 -1
  430. data/lib/rubocop/cop/style/inverse_methods.rb +11 -4
  431. data/lib/rubocop/cop/style/ip_addresses.rb +1 -1
  432. data/lib/rubocop/cop/style/keyword_parameters_order.rb +2 -2
  433. data/lib/rubocop/cop/style/lambda.rb +1 -1
  434. data/lib/rubocop/cop/style/lambda_call.rb +14 -22
  435. data/lib/rubocop/cop/style/line_end_concatenation.rb +16 -3
  436. data/lib/rubocop/cop/style/map_compact_with_conditional_block.rb +136 -0
  437. data/lib/rubocop/cop/style/map_to_hash.rb +68 -0
  438. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +28 -8
  439. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +6 -2
  440. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +15 -13
  441. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +20 -3
  442. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +1 -1
  443. data/lib/rubocop/cop/style/method_def_parentheses.rb +18 -14
  444. data/lib/rubocop/cop/style/min_max.rb +1 -1
  445. data/lib/rubocop/cop/style/missing_else.rb +24 -24
  446. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +1 -1
  447. data/lib/rubocop/cop/style/mixin_grouping.rb +2 -2
  448. data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
  449. data/lib/rubocop/cop/style/module_function.rb +11 -12
  450. data/lib/rubocop/cop/style/multiline_block_chain.rb +1 -1
  451. data/lib/rubocop/cop/style/multiline_if_modifier.rb +2 -2
  452. data/lib/rubocop/cop/style/multiline_if_then.rb +1 -1
  453. data/lib/rubocop/cop/style/multiline_in_pattern_then.rb +3 -5
  454. data/lib/rubocop/cop/style/multiline_memoization.rb +1 -1
  455. data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
  456. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +37 -11
  457. data/lib/rubocop/cop/style/multiline_when_then.rb +3 -5
  458. data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
  459. data/lib/rubocop/cop/style/mutable_constant.rb +74 -7
  460. data/lib/rubocop/cop/style/negated_if.rb +1 -1
  461. data/lib/rubocop/cop/style/negated_if_else_condition.rb +1 -1
  462. data/lib/rubocop/cop/style/negated_unless.rb +1 -1
  463. data/lib/rubocop/cop/style/nested_file_dirname.rb +66 -0
  464. data/lib/rubocop/cop/style/nested_modifier.rb +1 -1
  465. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +11 -2
  466. data/lib/rubocop/cop/style/nested_ternary_operator.rb +20 -8
  467. data/lib/rubocop/cop/style/next.rb +1 -1
  468. data/lib/rubocop/cop/style/nil_comparison.rb +1 -1
  469. data/lib/rubocop/cop/style/nil_lambda.rb +2 -2
  470. data/lib/rubocop/cop/style/non_nil_check.rb +3 -3
  471. data/lib/rubocop/cop/style/not.rb +4 -4
  472. data/lib/rubocop/cop/style/numbered_parameters.rb +46 -0
  473. data/lib/rubocop/cop/style/numbered_parameters_limit.rb +50 -0
  474. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +1 -1
  475. data/lib/rubocop/cop/style/numeric_literals.rb +18 -10
  476. data/lib/rubocop/cop/style/numeric_predicate.rb +58 -11
  477. data/lib/rubocop/cop/style/object_then.rb +69 -0
  478. data/lib/rubocop/cop/style/one_line_conditional.rb +19 -40
  479. data/lib/rubocop/cop/style/open_struct_use.rb +69 -0
  480. data/lib/rubocop/cop/style/option_hash.rb +1 -1
  481. data/lib/rubocop/cop/style/optional_arguments.rb +5 -1
  482. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +16 -5
  483. data/lib/rubocop/cop/style/or_assignment.rb +1 -1
  484. data/lib/rubocop/cop/style/parallel_assignment.rb +1 -1
  485. data/lib/rubocop/cop/style/parentheses_around_condition.rb +13 -3
  486. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -1
  487. data/lib/rubocop/cop/style/percent_q_literals.rb +3 -3
  488. data/lib/rubocop/cop/style/perl_backrefs.rb +1 -1
  489. data/lib/rubocop/cop/style/preferred_hash_methods.rb +9 -4
  490. data/lib/rubocop/cop/style/proc.rb +1 -1
  491. data/lib/rubocop/cop/style/quoted_symbols.rb +22 -8
  492. data/lib/rubocop/cop/style/raise_args.rb +11 -5
  493. data/lib/rubocop/cop/style/random_with_offset.rb +1 -1
  494. data/lib/rubocop/cop/style/redundant_argument.rb +21 -11
  495. data/lib/rubocop/cop/style/redundant_assignment.rb +1 -1
  496. data/lib/rubocop/cop/style/redundant_begin.rb +43 -11
  497. data/lib/rubocop/cop/style/redundant_capital_w.rb +2 -3
  498. data/lib/rubocop/cop/style/redundant_condition.rb +131 -16
  499. data/lib/rubocop/cop/style/redundant_conditional.rb +1 -1
  500. data/lib/rubocop/cop/style/redundant_exception.rb +1 -1
  501. data/lib/rubocop/cop/style/redundant_fetch_block.rb +5 -1
  502. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +13 -4
  503. data/lib/rubocop/cop/style/redundant_freeze.rb +5 -5
  504. data/lib/rubocop/cop/style/redundant_initialize.rb +154 -0
  505. data/lib/rubocop/cop/style/redundant_interpolation.rb +40 -5
  506. data/lib/rubocop/cop/style/redundant_parentheses.rb +3 -2
  507. data/lib/rubocop/cop/style/redundant_percent_q.rb +3 -4
  508. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +12 -3
  509. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +2 -2
  510. data/lib/rubocop/cop/style/redundant_return.rb +2 -2
  511. data/lib/rubocop/cop/style/redundant_self.rb +12 -2
  512. data/lib/rubocop/cop/style/redundant_self_assignment.rb +7 -7
  513. data/lib/rubocop/cop/style/redundant_self_assignment_branch.rb +24 -29
  514. data/lib/rubocop/cop/style/redundant_sort.rb +68 -20
  515. data/lib/rubocop/cop/style/redundant_sort_by.rb +1 -1
  516. data/lib/rubocop/cop/style/regexp_literal.rb +4 -4
  517. data/lib/rubocop/cop/style/rescue_modifier.rb +1 -1
  518. data/lib/rubocop/cop/style/rescue_standard_error.rb +13 -13
  519. data/lib/rubocop/cop/style/return_nil.rb +3 -2
  520. data/lib/rubocop/cop/style/safe_navigation.rb +30 -15
  521. data/lib/rubocop/cop/style/sample.rb +6 -4
  522. data/lib/rubocop/cop/style/select_by_regexp.rb +144 -0
  523. data/lib/rubocop/cop/style/self_assignment.rb +1 -1
  524. data/lib/rubocop/cop/style/semicolon.rb +28 -4
  525. data/lib/rubocop/cop/style/send.rb +1 -1
  526. data/lib/rubocop/cop/style/signal_exception.rb +1 -1
  527. data/lib/rubocop/cop/style/single_argument_dig.rb +10 -0
  528. data/lib/rubocop/cop/style/single_line_block_params.rb +3 -3
  529. data/lib/rubocop/cop/style/single_line_methods.rb +2 -2
  530. data/lib/rubocop/cop/style/slicing_with_range.rb +14 -1
  531. data/lib/rubocop/cop/style/sole_nested_conditional.rb +89 -26
  532. data/lib/rubocop/cop/style/special_global_vars.rb +70 -8
  533. data/lib/rubocop/cop/style/static_class.rb +6 -6
  534. data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
  535. data/lib/rubocop/cop/style/string_chars.rb +4 -2
  536. data/lib/rubocop/cop/style/string_concatenation.rb +17 -8
  537. data/lib/rubocop/cop/style/string_hash_keys.rb +5 -1
  538. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +1 -1
  539. data/lib/rubocop/cop/style/string_methods.rb +1 -1
  540. data/lib/rubocop/cop/style/strip.rb +1 -1
  541. data/lib/rubocop/cop/style/struct_inheritance.rb +7 -3
  542. data/lib/rubocop/cop/style/swap_values.rb +8 -4
  543. data/lib/rubocop/cop/style/symbol_array.rb +9 -6
  544. data/lib/rubocop/cop/style/symbol_literal.rb +1 -1
  545. data/lib/rubocop/cop/style/symbol_proc.rb +86 -8
  546. data/lib/rubocop/cop/style/ternary_parentheses.rb +18 -5
  547. data/lib/rubocop/cop/style/trailing_body_on_class.rb +1 -1
  548. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +1 -1
  549. data/lib/rubocop/cop/style/trailing_body_on_module.rb +1 -1
  550. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +1 -1
  551. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +2 -2
  552. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +20 -1
  553. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +2 -2
  554. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +2 -5
  555. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +1 -1
  556. data/lib/rubocop/cop/style/trivial_accessors.rb +12 -10
  557. data/lib/rubocop/cop/style/unless_else.rb +5 -1
  558. data/lib/rubocop/cop/style/unless_logical_operators.rb +1 -1
  559. data/lib/rubocop/cop/style/unpack_first.rb +5 -2
  560. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  561. data/lib/rubocop/cop/style/when_then.rb +1 -1
  562. data/lib/rubocop/cop/style/word_array.rb +4 -5
  563. data/lib/rubocop/cop/style/yoda_condition.rb +25 -8
  564. data/lib/rubocop/cop/style/zero_length_predicate.rb +7 -1
  565. data/lib/rubocop/cop/team.rb +3 -3
  566. data/lib/rubocop/cop/util.rb +25 -6
  567. data/lib/rubocop/cop/variable_force/branch.rb +1 -1
  568. data/lib/rubocop/cop/variable_force.rb +1 -5
  569. data/lib/rubocop/cops_documentation_generator.rb +38 -9
  570. data/lib/rubocop/formatter/disabled_config_formatter.rb +19 -2
  571. data/lib/rubocop/formatter/formatter_set.rb +20 -18
  572. data/lib/rubocop/formatter/git_hub_actions_formatter.rb +15 -2
  573. data/lib/rubocop/formatter/html_formatter.rb +7 -12
  574. data/lib/rubocop/formatter/json_formatter.rb +4 -1
  575. data/lib/rubocop/formatter/markdown_formatter.rb +78 -0
  576. data/lib/rubocop/formatter/offense_count_formatter.rb +8 -2
  577. data/lib/rubocop/formatter/simple_text_formatter.rb +9 -8
  578. data/lib/rubocop/formatter/worst_offenders_formatter.rb +1 -2
  579. data/lib/rubocop/formatter.rb +31 -0
  580. data/lib/rubocop/magic_comment.rb +74 -19
  581. data/lib/rubocop/options.rb +232 -138
  582. data/lib/rubocop/rake_task.rb +35 -10
  583. data/lib/rubocop/remote_config.rb +2 -4
  584. data/lib/rubocop/result_cache.rb +27 -16
  585. data/lib/rubocop/rspec/cop_helper.rb +3 -3
  586. data/lib/rubocop/rspec/expect_offense.rb +9 -5
  587. data/lib/rubocop/rspec/parallel_formatter.rb +90 -0
  588. data/lib/rubocop/rspec/shared_contexts.rb +34 -10
  589. data/lib/rubocop/rspec/support.rb +15 -0
  590. data/lib/rubocop/runner.rb +40 -11
  591. data/lib/rubocop/server/cache.rb +141 -0
  592. data/lib/rubocop/server/cli.rb +121 -0
  593. data/lib/rubocop/server/client_command/base.rb +44 -0
  594. data/lib/rubocop/server/client_command/exec.rb +59 -0
  595. data/lib/rubocop/server/client_command/restart.rb +25 -0
  596. data/lib/rubocop/server/client_command/start.rb +43 -0
  597. data/lib/rubocop/server/client_command/status.rb +28 -0
  598. data/lib/rubocop/server/client_command/stop.rb +31 -0
  599. data/lib/rubocop/server/client_command.rb +26 -0
  600. data/lib/rubocop/server/core.rb +79 -0
  601. data/lib/rubocop/server/errors.rb +23 -0
  602. data/lib/rubocop/server/helper.rb +34 -0
  603. data/lib/rubocop/server/server_command/base.rb +50 -0
  604. data/lib/rubocop/server/server_command/exec.rb +34 -0
  605. data/lib/rubocop/server/server_command/stop.rb +24 -0
  606. data/lib/rubocop/server/server_command.rb +21 -0
  607. data/lib/rubocop/server/socket_reader.rb +65 -0
  608. data/lib/rubocop/server.rb +53 -0
  609. data/lib/rubocop/string_interpreter.rb +4 -4
  610. data/lib/rubocop/target_finder.rb +1 -1
  611. data/lib/rubocop/target_ruby.rb +14 -6
  612. data/lib/rubocop/version.rb +15 -8
  613. data/lib/rubocop/yaml_duplication_checker.rb +1 -1
  614. data/lib/rubocop.rb +42 -30
  615. metadata +97 -13
  616. data/lib/rubocop/cop/gemspec/date_assignment.rb +0 -57
  617. data/lib/rubocop/cop/mixin/ignored_methods.rb +0 -52
  618. data/lib/rubocop/cop/mixin/ignored_pattern.rb +0 -29
@@ -3,12 +3,27 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for uses of double negation (`!!`) to convert something to a boolean value.
6
+ # Checks for uses of double negation (`!!`) to convert something to a boolean value.
7
7
  #
8
8
  # When using `EnforcedStyle: allowed_in_returns`, allow double negation in contexts
9
9
  # that use boolean as a return value. When using `EnforcedStyle: forbidden`, double negation
10
10
  # should be forbidden always.
11
11
  #
12
+ # NOTE: when `something` is a boolean value
13
+ # `!!something` and `!something.nil?` are not the same thing.
14
+ # As you're unlikely to write code that can accept values of any type
15
+ # this is rarely a problem in practice.
16
+ #
17
+ # @safety
18
+ # Autocorrection is unsafe when the value is `false`, because the result
19
+ # of the expression will change.
20
+ #
21
+ # [source,ruby]
22
+ # ----
23
+ # !!false #=> false
24
+ # !false.nil? #=> true
25
+ # ----
26
+ #
12
27
  # @example
13
28
  # # bad
14
29
  # !!something
@@ -22,16 +37,27 @@ module RuboCop
22
37
  # !!return_value
23
38
  # end
24
39
  #
40
+ # define_method :foo? do
41
+ # !!return_value
42
+ # end
43
+ #
44
+ # define_singleton_method :foo? do
45
+ # !!return_value
46
+ # end
47
+ #
25
48
  # @example EnforcedStyle: forbidden
26
49
  # # bad
27
50
  # def foo?
28
51
  # !!return_value
29
52
  # end
30
53
  #
31
- # Please, note that when something is a boolean value
32
- # !!something and !something.nil? are not the same thing.
33
- # As you're unlikely to write code that can accept values of any type
34
- # this is rarely a problem in practice.
54
+ # define_method :foo? do
55
+ # !!return_value
56
+ # end
57
+ #
58
+ # define_singleton_method :foo? do
59
+ # !!return_value
60
+ # end
35
61
  class DoubleNegation < Base
36
62
  include ConfigurableEnforcedStyle
37
63
  extend AutoCorrector
@@ -62,17 +88,69 @@ module RuboCop
62
88
  def end_of_method_definition?(node)
63
89
  return false unless (def_node = find_def_node_from_ascendant(node))
64
90
 
65
- last_child = def_node.child_nodes.last
91
+ conditional_node = find_conditional_node_from_ascendant(node)
92
+ last_child = find_last_child(def_node.send_type? ? def_node : def_node.body)
66
93
 
67
- last_child.last_line == node.last_line
94
+ if conditional_node
95
+ double_negative_condition_return_value?(node, last_child, conditional_node)
96
+ else
97
+ last_child.last_line <= node.last_line
98
+ end
68
99
  end
69
100
 
70
101
  def find_def_node_from_ascendant(node)
71
102
  return unless (parent = node.parent)
72
103
  return parent if parent.def_type? || parent.defs_type?
104
+ return node.parent.child_nodes.first if define_mehod?(parent)
73
105
 
74
106
  find_def_node_from_ascendant(node.parent)
75
107
  end
108
+
109
+ def define_mehod?(node)
110
+ return false unless node.block_type?
111
+
112
+ child = node.child_nodes.first
113
+ return false unless child.send_type?
114
+
115
+ child.method?(:define_method) || child.method?(:define_singleton_method)
116
+ end
117
+
118
+ def find_conditional_node_from_ascendant(node)
119
+ return unless (parent = node.parent)
120
+ return parent if parent.conditional?
121
+
122
+ find_conditional_node_from_ascendant(parent)
123
+ end
124
+
125
+ def find_last_child(node)
126
+ case node.type
127
+ when :rescue
128
+ find_last_child(node.body)
129
+ when :ensure
130
+ find_last_child(node.child_nodes.first)
131
+ else
132
+ node.child_nodes.last
133
+ end
134
+ end
135
+
136
+ def double_negative_condition_return_value?(node, last_child, conditional_node)
137
+ parent = find_parent_not_enumerable(node)
138
+ if parent.begin_type?
139
+ node.loc.line == parent.loc.last_line
140
+ else
141
+ last_child.last_line <= conditional_node.last_line
142
+ end
143
+ end
144
+
145
+ def find_parent_not_enumerable(node)
146
+ return unless (parent = node.parent)
147
+
148
+ if parent.pair_type? || parent.hash_type? || parent.array_type?
149
+ find_parent_not_enumerable(parent)
150
+ else
151
+ parent
152
+ end
153
+ end
76
154
  end
77
155
  end
78
156
  end
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for loops which iterate a constant number of times,
6
+ # Checks for loops which iterate a constant number of times,
7
7
  # using a Range literal and `#each`. This can be done more readably using
8
8
  # `Integer#times`.
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop looks for inject / reduce calls where the passed in object is
6
+ # Looks for inject / reduce calls where the passed in object is
7
7
  # returned at the end and so could be replaced by each_with_object without
8
8
  # the need to return the object at the end.
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for pipes for empty block parameters. Pipes for empty
6
+ # Checks for pipes for empty block parameters. Pipes for empty
7
7
  # block parameters do not cause syntax errors, but they are redundant.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for case statements with an empty condition.
6
+ # Checks for case statements with an empty condition.
7
7
  #
8
8
  # @example
9
9
  #
@@ -47,8 +47,7 @@ module RuboCop
47
47
  branch_bodies = [*case_node.when_branches.map(&:body), case_node.else_branch].compact
48
48
 
49
49
  return if branch_bodies.any? do |body|
50
- body.return_type? ||
51
- body.each_descendant.any?(&:return_type?)
50
+ body.return_type? || body.each_descendant.any?(&:return_type?)
52
51
  end
53
52
 
54
53
  add_offense(case_node.loc.keyword) { |corrector| autocorrect(corrector, case_node) }
@@ -70,7 +69,7 @@ module RuboCop
70
69
 
71
70
  keep_first_when_comment(case_range, corrector)
72
71
 
73
- when_nodes[1..-1].each do |when_node|
72
+ when_nodes[1..].each do |when_node|
74
73
  corrector.replace(when_node.loc.keyword, 'elsif')
75
74
  end
76
75
  end
@@ -79,6 +78,8 @@ module RuboCop
79
78
  when_nodes.each do |when_node|
80
79
  conditions = when_node.conditions
81
80
 
81
+ replace_then_with_line_break(corrector, conditions, when_node)
82
+
82
83
  next unless conditions.size > 1
83
84
 
84
85
  range = range_between(conditions.first.source_range.begin_pos,
@@ -97,6 +98,14 @@ module RuboCop
97
98
  line_beginning = case_range.adjust(begin_pos: -case_range.column)
98
99
  corrector.insert_before(line_beginning, comments)
99
100
  end
101
+
102
+ def replace_then_with_line_break(corrector, conditions, when_node)
103
+ return unless when_node.parent.parent && when_node.then?
104
+
105
+ range = range_between(conditions.last.source_range.end_pos, when_node.loc.begin.end_pos)
106
+
107
+ corrector.replace(range, "\n")
108
+ end
100
109
  end
101
110
  end
102
111
  end
@@ -6,6 +6,34 @@ module RuboCop
6
6
  # Checks for empty else-clauses, possibly including comments and/or an
7
7
  # explicit `nil` depending on the EnforcedStyle.
8
8
  #
9
+ # @example EnforcedStyle: both (default)
10
+ # # warn on empty else and else with nil in it
11
+ #
12
+ # # bad
13
+ # if condition
14
+ # statement
15
+ # else
16
+ # nil
17
+ # end
18
+ #
19
+ # # bad
20
+ # if condition
21
+ # statement
22
+ # else
23
+ # end
24
+ #
25
+ # # good
26
+ # if condition
27
+ # statement
28
+ # else
29
+ # statement
30
+ # end
31
+ #
32
+ # # good
33
+ # if condition
34
+ # statement
35
+ # end
36
+ #
9
37
  # @example EnforcedStyle: empty
10
38
  # # warn only on empty else
11
39
  #
@@ -62,13 +90,13 @@ module RuboCop
62
90
  # statement
63
91
  # end
64
92
  #
65
- # @example EnforcedStyle: both (default)
66
- # # warn on empty else and else with nil in it
93
+ # @example AllowComments: false (default)
67
94
  #
68
95
  # # bad
69
96
  # if condition
70
97
  # statement
71
98
  # else
99
+ # # something comment
72
100
  # nil
73
101
  # end
74
102
  #
@@ -76,19 +104,26 @@ module RuboCop
76
104
  # if condition
77
105
  # statement
78
106
  # else
107
+ # # something comment
79
108
  # end
80
109
  #
110
+ # @example AllowComments: true
111
+ #
81
112
  # # good
82
113
  # if condition
83
114
  # statement
84
115
  # else
85
- # statement
116
+ # # something comment
117
+ # nil
86
118
  # end
87
119
  #
88
120
  # # good
89
121
  # if condition
90
122
  # statement
123
+ # else
124
+ # # something comment
91
125
  # end
126
+ #
92
127
  class EmptyElse < Base
93
128
  include OnNormalIfUnless
94
129
  include ConfigurableEnforcedStyle
@@ -108,6 +143,8 @@ module RuboCop
108
143
  private
109
144
 
110
145
  def check(node)
146
+ return if cop_config['AllowComments'] && comment_in_else?(node.loc)
147
+
111
148
  empty_check(node) if empty_style?
112
149
  nil_check(node) if nil_style?
113
150
  end
@@ -0,0 +1,73 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module Style
6
+ # Checks for using empty heredoc to reduce redundancy.
7
+ #
8
+ # @example
9
+ #
10
+ # # bad
11
+ # <<~EOS
12
+ # EOS
13
+ #
14
+ # <<-EOS
15
+ # EOS
16
+ #
17
+ # <<EOS
18
+ # EOS
19
+ #
20
+ # # good
21
+ # ''
22
+ #
23
+ # # bad
24
+ # do_something(<<~EOS)
25
+ # EOS
26
+ #
27
+ # do_something(<<-EOS)
28
+ # EOS
29
+ #
30
+ # do_something(<<EOS)
31
+ # EOS
32
+ #
33
+ # # good
34
+ # do_something('')
35
+ #
36
+ class EmptyHeredoc < Base
37
+ include Heredoc
38
+ include RangeHelp
39
+ extend AutoCorrector
40
+
41
+ MSG = 'Use an empty string literal instead of heredoc.'
42
+
43
+ def on_heredoc(node)
44
+ heredoc_body = node.loc.heredoc_body
45
+
46
+ return unless heredoc_body.source.empty?
47
+
48
+ add_offense(node) do |corrector|
49
+ heredoc_end = node.loc.heredoc_end
50
+
51
+ corrector.replace(node, preferred_string_literal)
52
+ corrector.remove(range_by_whole_lines(heredoc_body, include_final_newline: true))
53
+ corrector.remove(range_by_whole_lines(heredoc_end, include_final_newline: true))
54
+ end
55
+ end
56
+
57
+ private
58
+
59
+ def preferred_string_literal
60
+ enforce_double_quotes? ? '""' : "''"
61
+ end
62
+
63
+ def enforce_double_quotes?
64
+ string_literals_config['EnforcedStyle'] == 'double_quotes'
65
+ end
66
+
67
+ def string_literals_config
68
+ config.for_cop('Style/StringLiterals')
69
+ end
70
+ end
71
+ end
72
+ end
73
+ end
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for parentheses for empty lambda parameters. Parentheses
6
+ # Checks for parentheses for empty lambda parameters. Parentheses
7
7
  # for empty lambda parameters do not cause syntax errors, but they are
8
8
  # redundant.
9
9
  #
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for the use of a method, the result of which
6
+ # Checks for the use of a method, the result of which
7
7
  # would be a literal, like an empty array, hash, or string.
8
8
  #
9
9
  # @example
@@ -119,7 +119,7 @@ module RuboCop
119
119
  # because the braces are interpreted as a block. We will have
120
120
  # to rewrite the arguments to wrap them in parenthesis.
121
121
  args = node.parent.arguments
122
- "(#{args[1..-1].map(&:source).unshift('{}').join(', ')})"
122
+ "(#{args[1..].map(&:source).unshift('{}').join(', ')})"
123
123
  else
124
124
  '{}'
125
125
  end
@@ -3,13 +3,17 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for the formatting of empty method definitions.
6
+ # Checks for the formatting of empty method definitions.
7
7
  # By default it enforces empty method definitions to go on a single
8
8
  # line (compact style), but it can be configured to enforce the `end`
9
9
  # to go on its own line (expanded style).
10
10
  #
11
11
  # NOTE: A method definition is not considered empty if it contains
12
- # comments.
12
+ # comments.
13
+ #
14
+ # NOTE: Autocorrection will not be applied for the `compact` style
15
+ # if the resulting code is longer than the `Max` configuration for
16
+ # `Layout/LineLength`, but an offense will still be registered.
13
17
  #
14
18
  # @example EnforcedStyle: compact (default)
15
19
  # # bad
@@ -51,7 +55,12 @@ module RuboCop
51
55
  return if node.body || comment_lines?(node)
52
56
  return if correct_style?(node)
53
57
 
54
- add_offense(node) { |corrector| corrector.replace(node, corrected(node)) }
58
+ add_offense(node) do |corrector|
59
+ correction = corrected(node)
60
+ next if compact_style? && max_line_length && correction.size > max_line_length
61
+
62
+ corrector.replace(node, correction)
63
+ end
55
64
  end
56
65
  alias on_defs on_def
57
66
 
@@ -62,7 +71,7 @@ module RuboCop
62
71
  end
63
72
 
64
73
  def correct_style?(node)
65
- compact_style? && compact?(node) || expanded_style? && expanded?(node)
74
+ (compact_style? && compact?(node)) || (expanded_style? && expanded?(node))
66
75
  end
67
76
 
68
77
  def corrected(node)
@@ -98,6 +107,12 @@ module RuboCop
98
107
  def expanded_style?
99
108
  style == :expanded
100
109
  end
110
+
111
+ def max_line_length
112
+ return unless config.for_cop('Layout/LineLength')['Enabled']
113
+
114
+ config.for_cop('Layout/LineLength')['Max']
115
+ end
101
116
  end
102
117
  end
103
118
  end
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks ensures source files have no utf-8 encoding comments.
6
+ # Checks ensures source files have no utf-8 encoding comments.
7
7
  # @example
8
8
  # # bad
9
9
  # # encoding: UTF-8
@@ -13,38 +13,49 @@ module RuboCop
13
13
  include RangeHelp
14
14
  extend AutoCorrector
15
15
 
16
- MSG_UNNECESSARY = 'Unnecessary utf-8 encoding comment.'
16
+ MSG = 'Unnecessary utf-8 encoding comment.'
17
17
  ENCODING_PATTERN = /#.*coding\s?[:=]\s?(?:UTF|utf)-8/.freeze
18
18
  SHEBANG = '#!'
19
19
 
20
20
  def on_new_investigation
21
21
  return if processed_source.buffer.source.empty?
22
22
 
23
- line_number = encoding_line_number(processed_source)
24
- return unless (@message = offense(processed_source, line_number))
23
+ comments.each do |line_number, comment|
24
+ next unless offense?(comment)
25
25
 
26
- range = processed_source.buffer.line_range(line_number + 1)
27
- add_offense(range, message: @message) do |corrector|
28
- corrector.remove(range_with_surrounding_space(range: range, side: :right))
26
+ register_offense(line_number, comment)
29
27
  end
30
28
  end
31
29
 
32
30
  private
33
31
 
34
- def offense(processed_source, line_number)
35
- line = processed_source[line_number]
32
+ def comments
33
+ processed_source.lines.each.with_index.with_object({}) do |(line, line_number), comments|
34
+ next if line.start_with?(SHEBANG)
36
35
 
37
- MSG_UNNECESSARY if encoding_omitable?(line)
36
+ comment = MagicComment.parse(line)
37
+ return comments unless comment.valid?
38
+
39
+ comments[line_number + 1] = comment
40
+ end
38
41
  end
39
42
 
40
- def encoding_omitable?(line)
41
- ENCODING_PATTERN.match?(line)
43
+ def offense?(comment)
44
+ comment.encoding_specified? && comment.encoding.casecmp('utf-8').zero?
42
45
  end
43
46
 
44
- def encoding_line_number(processed_source)
45
- line_number = 0
46
- line_number += 1 if processed_source[line_number].start_with?(SHEBANG)
47
- line_number
47
+ def register_offense(line_number, comment)
48
+ range = processed_source.buffer.line_range(line_number)
49
+
50
+ add_offense(range) do |corrector|
51
+ text = comment.without(:encoding)
52
+
53
+ if text.blank?
54
+ corrector.remove(range_with_surrounding_space(range, side: :right))
55
+ else
56
+ corrector.replace(range, text)
57
+ end
58
+ end
48
59
  end
49
60
  end
50
61
  end
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for END blocks.
6
+ # Checks for END blocks.
7
7
  #
8
8
  # @example
9
9
  # # bad
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for endless methods.
6
+ # Checks for endless methods.
7
7
  #
8
8
  # It can enforce either the use of endless methods definitions
9
9
  # for single-lined method bodies, or disallow endless methods.
@@ -0,0 +1,56 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module Style
6
+ # Checks for consistent usage of `ENV['HOME']`. If `nil` is used as
7
+ # the second argument of `ENV.fetch`, it is treated as a bad case like `ENV[]`.
8
+ #
9
+ # @safety
10
+ # The cop is unsafe because the result when `nil` is assigned to `ENV['HOME']` changes:
11
+ #
12
+ # [source,ruby]
13
+ # ----
14
+ # ENV['HOME'] = nil
15
+ # ENV['HOME'] # => nil
16
+ # Dir.home # => '/home/foo'
17
+ # ----
18
+ #
19
+ # @example
20
+ #
21
+ # # bad
22
+ # ENV['HOME']
23
+ # ENV.fetch('HOME', nil)
24
+ #
25
+ # # good
26
+ # Dir.home
27
+ #
28
+ # # good
29
+ # ENV.fetch('HOME', default)
30
+ #
31
+ class EnvHome < Base
32
+ extend AutoCorrector
33
+
34
+ MSG = 'Use `Dir.home` instead.'
35
+ RESTRICT_ON_SEND = %i[[] fetch].freeze
36
+
37
+ # @!method env_home?(node)
38
+ def_node_matcher :env_home?, <<~PATTERN
39
+ (send
40
+ (const {cbase nil?} :ENV) {:[] :fetch}
41
+ (str "HOME")
42
+ ...)
43
+ PATTERN
44
+
45
+ def on_send(node)
46
+ return unless env_home?(node)
47
+ return if node.arguments.count == 2 && !node.arguments[1].nil_type?
48
+
49
+ add_offense(node) do |corrector|
50
+ corrector.replace(node, 'Dir.home')
51
+ end
52
+ end
53
+ end
54
+ end
55
+ end
56
+ end
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop ensures that eval methods (`eval`, `instance_eval`, `class_eval`
6
+ # Ensures that eval methods (`eval`, `instance_eval`, `class_eval`
7
7
  # and `module_eval`) are given filename and line number values (`__FILE__`
8
8
  # and `__LINE__`). This data is used to ensure that any errors raised
9
9
  # within the evaluated code will be given the correct identification
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for places where `Integer#even?` or `Integer#odd?`
6
+ # Checks for places where `Integer#even?` or `Integer#odd?`
7
7
  # can be used.
8
8
  #
9
9
  # @example
@@ -3,7 +3,7 @@
3
3
  module RuboCop
4
4
  module Cop
5
5
  module Style
6
- # This cop checks for use of the `File.expand_path` arguments.
6
+ # Checks for use of the `File.expand_path` arguments.
7
7
  # Likewise, it also checks for the `Pathname.new` argument.
8
8
  #
9
9
  # Contrastive bad case and good case are alternately shown in