rubocop 0.89.0 → 0.92.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/README.md +2 -2
- data/config/default.yml +128 -14
- data/lib/rubocop.rb +30 -4
- data/lib/rubocop/cached_data.rb +1 -0
- data/lib/rubocop/cli/command.rb +1 -0
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +1 -0
- data/lib/rubocop/cli/command/base.rb +1 -0
- data/lib/rubocop/cli/command/execute_runner.rb +9 -0
- data/lib/rubocop/cli/command/init_dotfile.rb +1 -0
- data/lib/rubocop/cli/command/show_cops.rb +2 -1
- data/lib/rubocop/cli/command/version.rb +1 -0
- data/lib/rubocop/cli/environment.rb +1 -0
- data/lib/rubocop/comment_config.rb +17 -10
- data/lib/rubocop/config.rb +1 -1
- data/lib/rubocop/config_loader.rb +21 -10
- data/lib/rubocop/config_loader_resolver.rb +1 -0
- data/lib/rubocop/config_obsoletion.rb +1 -0
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +3 -3
- data/lib/rubocop/config_validator.rb +4 -1
- data/lib/rubocop/cop/base.rb +23 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +5 -1
- data/lib/rubocop/cop/bundler/gem_comment.rb +8 -3
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +2 -0
- data/lib/rubocop/cop/commissioner.rb +47 -7
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -5
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +8 -3
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +5 -8
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +5 -10
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
- data/lib/rubocop/cop/documentation.rb +22 -0
- data/lib/rubocop/cop/generator.rb +2 -1
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -0
- data/lib/rubocop/cop/layout/array_alignment.rb +1 -0
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +77 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +23 -19
- data/lib/rubocop/cop/layout/case_indentation.rb +4 -7
- data/lib/rubocop/cop/layout/class_structure.rb +14 -17
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
- data/lib/rubocop/cop/layout/comment_indentation.rb +1 -1
- data/lib/rubocop/cop/layout/condition_position.rb +13 -15
- data/lib/rubocop/cop/layout/def_end_alignment.rb +8 -5
- data/lib/rubocop/cop/layout/dot_position.rb +21 -17
- data/lib/rubocop/cop/layout/empty_comment.rb +30 -23
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +21 -18
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +13 -13
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +21 -23
- data/lib/rubocop/cop/layout/empty_lines.rb +6 -7
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +18 -14
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +7 -8
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +4 -7
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +3 -7
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +2 -5
- data/lib/rubocop/cop/layout/end_alignment.rb +11 -17
- data/lib/rubocop/cop/layout/extra_spacing.rb +14 -21
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +4 -8
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/hash_alignment.rb +17 -20
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +15 -14
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +14 -11
- data/lib/rubocop/cop/layout/initial_indentation.rb +6 -7
- data/lib/rubocop/cop/layout/leading_comment_space.rb +12 -10
- data/lib/rubocop/cop/layout/leading_empty_lines.rb +6 -11
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +10 -14
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +21 -19
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +5 -9
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +41 -22
- data/lib/rubocop/cop/layout/space_after_colon.rb +11 -7
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +5 -6
- data/lib/rubocop/cop/layout/space_after_not.rb +9 -11
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +22 -17
- data/lib/rubocop/cop/layout/space_around_keyword.rb +17 -18
- data/lib/rubocop/cop/layout/space_around_operators.rb +17 -16
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +23 -22
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +10 -7
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +7 -7
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +9 -17
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +20 -23
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -8
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +17 -16
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +19 -37
- data/lib/rubocop/cop/layout/space_inside_parens.rb +9 -14
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +5 -10
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +8 -17
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +16 -24
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +12 -13
- data/lib/rubocop/cop/layout/trailing_empty_lines.rb +10 -15
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +11 -11
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +2 -0
- data/lib/rubocop/cop/lint/big_decimal_new.rb +1 -2
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +2 -1
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +74 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +1 -1
- data/lib/rubocop/cop/lint/debugger.rb +2 -3
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +1 -3
- data/lib/rubocop/cop/lint/duplicate_methods.rb +2 -4
- data/lib/rubocop/cop/lint/duplicate_require.rb +46 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +2 -15
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -0
- data/lib/rubocop/cop/lint/empty_file.rb +50 -0
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +2 -0
- data/lib/rubocop/cop/lint/float_comparison.rb +2 -2
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +2 -2
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +2 -5
- data/lib/rubocop/cop/lint/inherit_exception.rb +2 -2
- data/lib/rubocop/cop/lint/missing_super.rb +11 -11
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +2 -35
- data/lib/rubocop/cop/lint/multiple_comparison.rb +3 -1
- data/lib/rubocop/cop/lint/number_conversion.rb +1 -0
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +33 -15
- data/lib/rubocop/cop/lint/percent_string_array.rb +8 -12
- data/lib/rubocop/cop/lint/raise_exception.rb +1 -0
- data/lib/rubocop/cop/lint/rand_one.rb +2 -1
- data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +36 -29
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +14 -4
- data/lib/rubocop/cop/lint/redundant_require_statement.rb +1 -0
- data/lib/rubocop/cop/lint/rescue_type.rb +0 -1
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +3 -1
- data/lib/rubocop/cop/lint/shadowed_exception.rb +6 -6
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +4 -4
- data/lib/rubocop/cop/lint/struct_new_override.rb +1 -0
- data/lib/rubocop/cop/lint/to_json.rb +16 -5
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +57 -0
- data/lib/rubocop/cop/lint/unreachable_loop.rb +3 -6
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +3 -1
- data/lib/rubocop/cop/lint/uri_regexp.rb +10 -25
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +3 -9
- data/lib/rubocop/cop/lint/useless_method_definition.rb +70 -0
- data/lib/rubocop/cop/lint/useless_times.rb +106 -0
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +27 -16
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +1 -0
- data/lib/rubocop/cop/migration/department_name.rb +2 -2
- data/lib/rubocop/cop/mixin/alignment.rb +5 -1
- data/lib/rubocop/cop/mixin/allowed_methods.rb +2 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +5 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +17 -8
- data/lib/rubocop/cop/mixin/comments_help.rb +48 -0
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +3 -3
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +8 -7
- data/lib/rubocop/cop/mixin/empty_parameter.rb +3 -1
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +12 -1
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +0 -2
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +3 -1
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +31 -12
- data/lib/rubocop/cop/mixin/line_length_help.rb +1 -3
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +3 -1
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +13 -12
- data/lib/rubocop/cop/mixin/negative_conditional.rb +2 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +16 -9
- data/lib/rubocop/cop/mixin/range_help.rb +18 -4
- data/lib/rubocop/cop/mixin/regexp_literal_help.rb +1 -1
- data/lib/rubocop/cop/mixin/rescue_node.rb +11 -1
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/statement_modifier.rb +12 -6
- data/lib/rubocop/cop/mixin/surrounding_space.rb +8 -4
- data/lib/rubocop/cop/mixin/trailing_comma.rb +9 -11
- data/lib/rubocop/cop/mixin/visibility_help.rb +4 -16
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
- data/lib/rubocop/cop/naming/file_name.rb +1 -1
- data/lib/rubocop/cop/offense.rb +1 -0
- data/lib/rubocop/cop/security/eval.rb +1 -0
- data/lib/rubocop/cop/security/json_load.rb +1 -0
- data/lib/rubocop/cop/security/marshal_load.rb +1 -0
- data/lib/rubocop/cop/security/open.rb +1 -0
- data/lib/rubocop/cop/security/yaml_load.rb +1 -0
- data/lib/rubocop/cop/severity.rb +0 -8
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +8 -19
- data/lib/rubocop/cop/style/accessor_grouping.rb +20 -20
- data/lib/rubocop/cop/style/alias.rb +36 -33
- data/lib/rubocop/cop/style/and_or.rb +9 -11
- data/lib/rubocop/cop/style/array_coercion.rb +4 -0
- data/lib/rubocop/cop/style/array_join.rb +7 -8
- data/lib/rubocop/cop/style/ascii_comments.rb +4 -4
- data/lib/rubocop/cop/style/attr.rb +12 -9
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +4 -5
- data/lib/rubocop/cop/style/bare_percent_literals.rb +10 -12
- data/lib/rubocop/cop/style/begin_block.rb +2 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +9 -12
- data/lib/rubocop/cop/style/block_comments.rb +14 -18
- data/lib/rubocop/cop/style/block_delimiters.rb +23 -23
- data/lib/rubocop/cop/style/case_equality.rb +11 -3
- data/lib/rubocop/cop/style/case_like_if.rb +37 -18
- data/lib/rubocop/cop/style/class_and_module_children.rb +16 -11
- data/lib/rubocop/cop/style/class_check.rb +6 -11
- data/lib/rubocop/cop/style/class_methods.rb +7 -11
- data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
- data/lib/rubocop/cop/style/class_vars.rb +7 -12
- data/lib/rubocop/cop/style/collection_methods.rb +11 -17
- data/lib/rubocop/cop/style/colon_method_call.rb +6 -7
- data/lib/rubocop/cop/style/colon_method_definition.rb +6 -6
- data/lib/rubocop/cop/style/combinable_loops.rb +84 -0
- data/lib/rubocop/cop/style/command_literal.rb +23 -24
- data/lib/rubocop/cop/style/comment_annotation.rb +15 -15
- data/lib/rubocop/cop/style/commented_keyword.rb +8 -9
- data/lib/rubocop/cop/style/conditional_assignment.rb +50 -61
- data/lib/rubocop/cop/style/constant_visibility.rb +3 -2
- data/lib/rubocop/cop/style/copyright.rb +12 -12
- data/lib/rubocop/cop/style/date_time.rb +13 -2
- data/lib/rubocop/cop/style/def_with_parentheses.rb +8 -10
- data/lib/rubocop/cop/style/dir.rb +8 -10
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +7 -9
- data/lib/rubocop/cop/style/documentation.rb +2 -4
- data/lib/rubocop/cop/style/documentation_method.rb +1 -1
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +12 -15
- data/lib/rubocop/cop/style/double_negation.rb +3 -2
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +5 -8
- data/lib/rubocop/cop/style/each_with_object.rb +16 -17
- data/lib/rubocop/cop/style/empty_block_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_case_condition.rb +19 -20
- data/lib/rubocop/cop/style/empty_else.rb +17 -19
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_literal.rb +18 -17
- data/lib/rubocop/cop/style/empty_method.rb +5 -8
- data/lib/rubocop/cop/style/encoding.rb +5 -9
- data/lib/rubocop/cop/style/end_block.rb +4 -6
- data/lib/rubocop/cop/style/eval_with_location.rb +6 -10
- data/lib/rubocop/cop/style/even_odd.rb +8 -11
- data/lib/rubocop/cop/style/expand_path_arguments.rb +23 -26
- data/lib/rubocop/cop/style/explicit_block_argument.rb +1 -1
- data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
- data/lib/rubocop/cop/style/float_division.rb +3 -1
- data/lib/rubocop/cop/style/for.rb +11 -15
- data/lib/rubocop/cop/style/format_string.rb +18 -23
- data/lib/rubocop/cop/style/format_string_token.rb +4 -7
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +19 -41
- data/lib/rubocop/cop/style/global_vars.rb +2 -2
- data/lib/rubocop/cop/style/guard_clause.rb +4 -4
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +24 -5
- data/lib/rubocop/cop/style/hash_each_methods.rb +5 -8
- data/lib/rubocop/cop/style/hash_syntax.rb +6 -7
- data/lib/rubocop/cop/style/hash_transform_keys.rb +19 -11
- data/lib/rubocop/cop/style/hash_transform_values.rb +18 -10
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +1 -1
- data/lib/rubocop/cop/style/if_inside_else.rb +2 -2
- data/lib/rubocop/cop/style/if_unless_modifier.rb +11 -17
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +3 -7
- data/lib/rubocop/cop/style/if_with_semicolon.rb +3 -6
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +2 -1
- data/lib/rubocop/cop/style/infinite_loop.rb +23 -23
- data/lib/rubocop/cop/style/inline_comment.rb +3 -3
- data/lib/rubocop/cop/style/inverse_methods.rb +20 -29
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +53 -0
- data/lib/rubocop/cop/style/lambda.rb +7 -12
- data/lib/rubocop/cop/style/lambda_call.rb +17 -14
- data/lib/rubocop/cop/style/line_end_concatenation.rb +19 -16
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +2 -1
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +11 -11
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +4 -8
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +7 -6
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +12 -3
- data/lib/rubocop/cop/style/method_def_parentheses.rb +11 -16
- data/lib/rubocop/cop/style/min_max.rb +8 -12
- data/lib/rubocop/cop/style/missing_else.rb +13 -13
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +1 -1
- data/lib/rubocop/cop/style/mixin_grouping.rb +24 -27
- data/lib/rubocop/cop/style/mixin_usage.rb +9 -28
- data/lib/rubocop/cop/style/module_function.rb +10 -13
- data/lib/rubocop/cop/style/multiline_block_chain.rb +2 -2
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +3 -10
- data/lib/rubocop/cop/style/multiline_if_then.rb +4 -10
- data/lib/rubocop/cop/style/multiline_memoization.rb +12 -10
- data/lib/rubocop/cop/style/multiline_method_signature.rb +1 -1
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +17 -6
- data/lib/rubocop/cop/style/multiline_when_then.rb +10 -11
- data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
- data/lib/rubocop/cop/style/mutable_constant.rb +23 -20
- data/lib/rubocop/cop/style/negated_if.rb +6 -6
- data/lib/rubocop/cop/style/negated_unless.rb +6 -6
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_modifier.rb +10 -13
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +14 -12
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +14 -16
- data/lib/rubocop/cop/style/next.rb +10 -14
- data/lib/rubocop/cop/style/nil_comparison.rb +13 -11
- data/lib/rubocop/cop/style/non_nil_check.rb +34 -26
- data/lib/rubocop/cop/style/not.rb +20 -26
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +4 -9
- data/lib/rubocop/cop/style/numeric_predicate.rb +5 -14
- data/lib/rubocop/cop/style/one_line_conditional.rb +73 -23
- data/lib/rubocop/cop/style/option_hash.rb +1 -1
- data/lib/rubocop/cop/style/optional_arguments.rb +1 -1
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +12 -1
- data/lib/rubocop/cop/style/or_assignment.rb +13 -10
- data/lib/rubocop/cop/style/parallel_assignment.rb +14 -14
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +6 -6
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +13 -19
- data/lib/rubocop/cop/style/percent_q_literals.rb +8 -10
- data/lib/rubocop/cop/style/perl_backrefs.rb +8 -10
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +11 -14
- data/lib/rubocop/cop/style/proc.rb +6 -6
- data/lib/rubocop/cop/style/raise_args.rb +15 -24
- data/lib/rubocop/cop/style/random_with_offset.rb +19 -19
- data/lib/rubocop/cop/style/redundant_assignment.rb +8 -18
- data/lib/rubocop/cop/style/redundant_begin.rb +7 -9
- data/lib/rubocop/cop/style/redundant_capital_w.rb +6 -9
- data/lib/rubocop/cop/style/redundant_condition.rb +5 -6
- data/lib/rubocop/cop/style/redundant_conditional.rb +4 -5
- data/lib/rubocop/cop/style/redundant_exception.rb +1 -3
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +3 -12
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +9 -8
- data/lib/rubocop/cop/style/redundant_freeze.rb +5 -7
- data/lib/rubocop/cop/style/redundant_interpolation.rb +25 -24
- data/lib/rubocop/cop/style/redundant_parentheses.rb +21 -15
- data/lib/rubocop/cop/style/redundant_percent_q.rb +9 -11
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +6 -13
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +5 -14
- data/lib/rubocop/cop/style/redundant_return.rb +17 -17
- data/lib/rubocop/cop/style/redundant_self.rb +9 -11
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +116 -0
- data/lib/rubocop/cop/style/redundant_sort.rb +12 -31
- data/lib/rubocop/cop/style/redundant_sort_by.rb +5 -9
- data/lib/rubocop/cop/style/regexp_literal.rb +10 -21
- data/lib/rubocop/cop/style/rescue_modifier.rb +29 -9
- data/lib/rubocop/cop/style/rescue_standard_error.rb +20 -16
- data/lib/rubocop/cop/style/return_nil.rb +5 -5
- data/lib/rubocop/cop/style/safe_navigation.rb +22 -16
- data/lib/rubocop/cop/style/sample.rb +12 -14
- data/lib/rubocop/cop/style/self_assignment.rb +26 -22
- data/lib/rubocop/cop/style/semicolon.rb +6 -9
- data/lib/rubocop/cop/style/send.rb +4 -5
- data/lib/rubocop/cop/style/signal_exception.rb +23 -19
- data/lib/rubocop/cop/style/single_argument_dig.rb +1 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +4 -2
- data/lib/rubocop/cop/style/single_line_methods.rb +18 -17
- data/lib/rubocop/cop/style/slicing_with_range.rb +6 -8
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +66 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +10 -15
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +17 -21
- data/lib/rubocop/cop/style/stderr_puts.rb +5 -6
- data/lib/rubocop/cop/style/string_concatenation.rb +16 -2
- data/lib/rubocop/cop/style/string_hash_keys.rb +6 -7
- data/lib/rubocop/cop/style/string_methods.rb +7 -17
- data/lib/rubocop/cop/style/strip.rb +9 -14
- data/lib/rubocop/cop/style/struct_inheritance.rb +3 -6
- data/lib/rubocop/cop/style/symbol_array.rb +5 -16
- data/lib/rubocop/cop/style/symbol_literal.rb +4 -6
- data/lib/rubocop/cop/style/symbol_proc.rb +14 -18
- data/lib/rubocop/cop/style/ternary_parentheses.rb +22 -22
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +3 -6
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +4 -7
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +3 -6
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +2 -5
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +2 -5
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +11 -9
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +2 -5
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +8 -17
- data/lib/rubocop/cop/style/trivial_accessors.rb +26 -30
- data/lib/rubocop/cop/style/unless_else.rb +5 -8
- data/lib/rubocop/cop/style/unpack_first.rb +5 -8
- data/lib/rubocop/cop/style/variable_interpolation.rb +7 -10
- data/lib/rubocop/cop/style/when_then.rb +4 -6
- data/lib/rubocop/cop/style/while_until_do.rb +6 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +6 -20
- data/lib/rubocop/cop/style/word_array.rb +5 -23
- data/lib/rubocop/cop/style/yoda_condition.rb +4 -15
- data/lib/rubocop/cop/style/zero_length_predicate.rb +12 -18
- data/lib/rubocop/cop/team.rb +1 -0
- data/lib/rubocop/cop/util.rb +2 -1
- data/lib/rubocop/cop/utils/format_string.rb +3 -5
- data/lib/rubocop/cop/variable_force.rb +2 -0
- data/lib/rubocop/cops_documentation_generator.rb +5 -3
- data/lib/rubocop/core_ext/string.rb +2 -2
- data/lib/rubocop/directive_comment.rb +32 -0
- data/lib/rubocop/ext/regexp_node.rb +46 -0
- data/lib/rubocop/file_finder.rb +1 -0
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/disabled_config_formatter.rb +13 -6
- data/lib/rubocop/formatter/html_formatter.rb +2 -0
- data/lib/rubocop/formatter/junit_formatter.rb +1 -1
- data/lib/rubocop/formatter/progress_formatter.rb +2 -1
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +36 -6
- data/lib/rubocop/name_similarity.rb +1 -0
- data/lib/rubocop/options.rb +43 -20
- data/lib/rubocop/remote_config.rb +1 -0
- data/lib/rubocop/result_cache.rb +31 -13
- data/lib/rubocop/rspec/cop_helper.rb +4 -1
- data/lib/rubocop/rspec/expect_offense.rb +14 -9
- data/lib/rubocop/rspec/shared_contexts.rb +13 -5
- data/lib/rubocop/runner.rb +35 -15
- data/lib/rubocop/string_interpreter.rb +3 -0
- data/lib/rubocop/target_finder.rb +5 -1
- data/lib/rubocop/target_ruby.rb +7 -1
- data/lib/rubocop/version.rb +7 -1
- data/lib/rubocop/yaml_duplication_checker.rb +1 -0
- metadata +26 -14
- data/lib/rubocop/cop/tokens_util.rb +0 -84
@@ -49,6 +49,10 @@ module RuboCop
|
|
49
49
|
# foo && foo < bar
|
50
50
|
# foo < bar if foo
|
51
51
|
#
|
52
|
+
# # When checking `foo&.empty?` in a conditional, `foo` being `nil` will actually
|
53
|
+
# # do the opposite of what the author intends.
|
54
|
+
# foo && foo.empty?
|
55
|
+
#
|
52
56
|
# # This could start returning `nil` as well as the return of the method
|
53
57
|
# foo.nil? || foo.bar
|
54
58
|
# !foo || foo.bar
|
@@ -58,9 +62,10 @@ module RuboCop
|
|
58
62
|
# foo.baz = bar if foo
|
59
63
|
# foo.baz + bar if foo
|
60
64
|
# foo.bar > 2 if foo
|
61
|
-
class SafeNavigation <
|
65
|
+
class SafeNavigation < Base
|
62
66
|
include NilMethods
|
63
67
|
include RangeHelp
|
68
|
+
extend AutoCorrector
|
64
69
|
|
65
70
|
MSG = 'Use safe navigation (`&.`) instead of checking if an object ' \
|
66
71
|
'exists before calling the method.'
|
@@ -103,30 +108,31 @@ module RuboCop
|
|
103
108
|
# chain greater than 2
|
104
109
|
return if chain_size(method_chain, method) > 1
|
105
110
|
return if unsafe_method_used?(method_chain, method)
|
111
|
+
return if method_chain.method?(:empty?)
|
106
112
|
|
107
|
-
add_offense(node)
|
113
|
+
add_offense(node) do |corrector|
|
114
|
+
autocorrect(corrector, node)
|
115
|
+
end
|
108
116
|
end
|
109
117
|
|
110
118
|
def use_var_only_in_unless_modifier?(node, variable)
|
111
119
|
node.if_type? && node.unless? && !method_called?(variable)
|
112
120
|
end
|
113
121
|
|
114
|
-
|
122
|
+
private
|
123
|
+
|
124
|
+
def autocorrect(corrector, node)
|
115
125
|
body = node.node_parts[1]
|
116
126
|
method_call = method_call(node)
|
117
127
|
|
118
|
-
|
119
|
-
|
120
|
-
|
121
|
-
|
122
|
-
handle_comments(corrector, node, method_call)
|
128
|
+
corrector.remove(begin_range(node, body))
|
129
|
+
corrector.remove(end_range(node, body))
|
130
|
+
corrector.insert_before(method_call.loc.dot, '&')
|
131
|
+
handle_comments(corrector, node, method_call)
|
123
132
|
|
124
|
-
|
125
|
-
end
|
133
|
+
add_safe_nav_to_all_methods_in_chain(corrector, method_call, body)
|
126
134
|
end
|
127
135
|
|
128
|
-
private
|
129
|
-
|
130
136
|
def handle_comments(corrector, node, method_call)
|
131
137
|
comments = comments(node)
|
132
138
|
return if comments.empty?
|
@@ -136,10 +142,10 @@ module RuboCop
|
|
136
142
|
end
|
137
143
|
|
138
144
|
def comments(node)
|
139
|
-
processed_source.
|
140
|
-
|
141
|
-
|
142
|
-
|
145
|
+
processed_source.each_comment_in_lines(
|
146
|
+
node.loc.first_line...
|
147
|
+
node.loc.last_line
|
148
|
+
).to_a
|
143
149
|
end
|
144
150
|
|
145
151
|
def allowed_if_condition?(node)
|
@@ -27,30 +27,28 @@ module RuboCop
|
|
27
27
|
# [1, 2, 3].shuffle[1..3] # sample(3) might return a longer Array
|
28
28
|
# [1, 2, 3].shuffle[foo, bar]
|
29
29
|
# [1, 2, 3].shuffle(random: Random.new)
|
30
|
-
class Sample <
|
30
|
+
class Sample < Base
|
31
|
+
extend AutoCorrector
|
32
|
+
|
31
33
|
MSG = 'Use `%<correct>s` instead of `%<incorrect>s`.'
|
34
|
+
RESTRICT_ON_SEND = %i[first last [] at slice].freeze
|
32
35
|
|
33
36
|
def_node_matcher :sample_candidate?, <<~PATTERN
|
34
|
-
(send $(send _ :shuffle $...) ${
|
37
|
+
(send $(send _ :shuffle $...) ${:#{RESTRICT_ON_SEND.join(' :')}} $...)
|
35
38
|
PATTERN
|
36
39
|
|
37
40
|
def on_send(node)
|
38
|
-
sample_candidate?(node) do |
|
41
|
+
sample_candidate?(node) do |shuffle_node, shuffle_arg, method, method_args|
|
39
42
|
return unless offensive?(method, method_args)
|
40
43
|
|
41
|
-
range = source_range(
|
44
|
+
range = source_range(shuffle_node, node)
|
42
45
|
message = message(shuffle_arg, method, method_args, range)
|
43
|
-
add_offense(node, location: range, message: message)
|
44
|
-
end
|
45
|
-
end
|
46
|
-
|
47
|
-
def autocorrect(node)
|
48
|
-
shuffle_node, shuffle_arg, method, method_args =
|
49
|
-
sample_candidate?(node)
|
50
46
|
|
51
|
-
|
52
|
-
|
53
|
-
|
47
|
+
add_offense(range, message: message) do |corrector|
|
48
|
+
corrector.replace(
|
49
|
+
source_range(shuffle_node, node), correction(shuffle_arg, method, method_args)
|
50
|
+
)
|
51
|
+
end
|
54
52
|
end
|
55
53
|
end
|
56
54
|
|
@@ -12,7 +12,9 @@ module RuboCop
|
|
12
12
|
#
|
13
13
|
# # good
|
14
14
|
# x += 1
|
15
|
-
class SelfAssignment <
|
15
|
+
class SelfAssignment < Base
|
16
|
+
extend AutoCorrector
|
17
|
+
|
16
18
|
MSG = 'Use self-assignment shorthand `%<method>s=`.'
|
17
19
|
OPS = %i[+ - * ** / | &].freeze
|
18
20
|
|
@@ -32,16 +34,6 @@ module RuboCop
|
|
32
34
|
check(node, :cvar)
|
33
35
|
end
|
34
36
|
|
35
|
-
def autocorrect(node)
|
36
|
-
_var_name, rhs = *node
|
37
|
-
|
38
|
-
if rhs.send_type?
|
39
|
-
autocorrect_send_node(node, rhs)
|
40
|
-
elsif %i[and or].include?(rhs.type)
|
41
|
-
autocorrect_boolean_node(node, rhs)
|
42
|
-
end
|
43
|
-
end
|
44
|
-
|
45
37
|
private
|
46
38
|
|
47
39
|
def check(node, var_type)
|
@@ -62,7 +54,9 @@ module RuboCop
|
|
62
54
|
target_node = s(var_type, var_name)
|
63
55
|
return unless receiver == target_node
|
64
56
|
|
65
|
-
add_offense(node, message: format(MSG, method: method_name))
|
57
|
+
add_offense(node, message: format(MSG, method: method_name)) do |corrector|
|
58
|
+
autocorrect(corrector, node)
|
59
|
+
end
|
66
60
|
end
|
67
61
|
|
68
62
|
def check_boolean_node(node, rhs, var_name, var_type)
|
@@ -72,24 +66,34 @@ module RuboCop
|
|
72
66
|
return unless first_operand == target_node
|
73
67
|
|
74
68
|
operator = rhs.loc.operator.source
|
75
|
-
add_offense(node, message: format(MSG, method: operator))
|
69
|
+
add_offense(node, message: format(MSG, method: operator)) do |corrector|
|
70
|
+
autocorrect(corrector, node)
|
71
|
+
end
|
76
72
|
end
|
77
73
|
|
78
|
-
def
|
74
|
+
def autocorrect(corrector, node)
|
75
|
+
_var_name, rhs = *node
|
76
|
+
|
77
|
+
if rhs.send_type?
|
78
|
+
autocorrect_send_node(corrector, node, rhs)
|
79
|
+
elsif %i[and or].include?(rhs.type)
|
80
|
+
autocorrect_boolean_node(corrector, node, rhs)
|
81
|
+
end
|
82
|
+
end
|
83
|
+
|
84
|
+
def autocorrect_send_node(corrector, node, rhs)
|
79
85
|
_receiver, method_name, args = *rhs
|
80
|
-
apply_autocorrect(node, rhs, method_name.to_s, args)
|
86
|
+
apply_autocorrect(corrector, node, rhs, method_name.to_s, args)
|
81
87
|
end
|
82
88
|
|
83
|
-
def autocorrect_boolean_node(node, rhs)
|
89
|
+
def autocorrect_boolean_node(corrector, node, rhs)
|
84
90
|
_first_operand, second_operand = *rhs
|
85
|
-
apply_autocorrect(node, rhs, rhs.loc.operator.source, second_operand)
|
91
|
+
apply_autocorrect(corrector, node, rhs, rhs.loc.operator.source, second_operand)
|
86
92
|
end
|
87
93
|
|
88
|
-
def apply_autocorrect(node, rhs, operator, new_rhs)
|
89
|
-
|
90
|
-
|
91
|
-
corrector.replace(rhs, new_rhs.source)
|
92
|
-
end
|
94
|
+
def apply_autocorrect(corrector, node, rhs, operator, new_rhs)
|
95
|
+
corrector.insert_before(node.loc.operator, operator)
|
96
|
+
corrector.replace(rhs, new_rhs.source)
|
93
97
|
end
|
94
98
|
end
|
95
99
|
end
|
@@ -26,12 +26,13 @@ module RuboCop
|
|
26
26
|
# @example AllowAsExpressionSeparator: true
|
27
27
|
# # good
|
28
28
|
# foo = 1; bar = 2
|
29
|
-
class Semicolon <
|
29
|
+
class Semicolon < Base
|
30
30
|
include RangeHelp
|
31
|
+
extend AutoCorrector
|
31
32
|
|
32
33
|
MSG = 'Do not use semicolons to terminate expressions.'
|
33
34
|
|
34
|
-
def
|
35
|
+
def on_new_investigation
|
35
36
|
return if processed_source.blank?
|
36
37
|
|
37
38
|
@processed_source = processed_source
|
@@ -66,12 +67,6 @@ module RuboCop
|
|
66
67
|
end
|
67
68
|
end
|
68
69
|
|
69
|
-
def autocorrect(range)
|
70
|
-
return unless range
|
71
|
-
|
72
|
-
->(corrector) { corrector.remove(range) }
|
73
|
-
end
|
74
|
-
|
75
70
|
private
|
76
71
|
|
77
72
|
def check_for_line_terminator_or_opener
|
@@ -93,7 +88,9 @@ module RuboCop
|
|
93
88
|
range = source_range(@processed_source.buffer, line, column)
|
94
89
|
# Don't attempt to autocorrect if semicolon is separating statements
|
95
90
|
# on the same line
|
96
|
-
add_offense(
|
91
|
+
add_offense(range) do |corrector|
|
92
|
+
corrector.remove(range) if autocorrect
|
93
|
+
end
|
97
94
|
end
|
98
95
|
end
|
99
96
|
end
|
@@ -13,16 +13,15 @@ module RuboCop
|
|
13
13
|
# # good
|
14
14
|
# Foo.__send__(:bar)
|
15
15
|
# quuz.public_send(:fred)
|
16
|
-
class Send <
|
16
|
+
class Send < Base
|
17
17
|
MSG = 'Prefer `Object#__send__` or `Object#public_send` to ' \
|
18
18
|
'`send`.'
|
19
|
-
|
20
|
-
def_node_matcher :sending?, '({send csend} _ :send ...)'
|
19
|
+
RESTRICT_ON_SEND = %i[send].freeze
|
21
20
|
|
22
21
|
def on_send(node)
|
23
|
-
return unless
|
22
|
+
return unless node.arguments?
|
24
23
|
|
25
|
-
add_offense(node
|
24
|
+
add_offense(node.loc.selector)
|
26
25
|
end
|
27
26
|
alias on_csend on_send
|
28
27
|
end
|
@@ -104,18 +104,21 @@ module RuboCop
|
|
104
104
|
#
|
105
105
|
# explicit_receiver.fail
|
106
106
|
# explicit_receiver.raise
|
107
|
-
class SignalException <
|
107
|
+
class SignalException < Base
|
108
108
|
include ConfigurableEnforcedStyle
|
109
|
+
extend AutoCorrector
|
109
110
|
|
110
111
|
FAIL_MSG = 'Use `fail` instead of `raise` to signal exceptions.'
|
111
112
|
RAISE_MSG = 'Use `raise` instead of `fail` to ' \
|
112
113
|
'rethrow exceptions.'
|
113
114
|
|
115
|
+
RESTRICT_ON_SEND = %i[raise fail].freeze
|
116
|
+
|
114
117
|
def_node_matcher :kernel_call?, '(send (const {nil? cbase} :Kernel) %1 ...)'
|
115
118
|
def_node_search :custom_fail_methods,
|
116
119
|
'{(def :fail ...) (defs _ :fail ...)}'
|
117
120
|
|
118
|
-
def
|
121
|
+
def on_new_investigation
|
119
122
|
ast = processed_source.ast
|
120
123
|
@custom_fail_defined = ast && custom_fail_methods(ast).any?
|
121
124
|
end
|
@@ -145,20 +148,6 @@ module RuboCop
|
|
145
148
|
end
|
146
149
|
end
|
147
150
|
|
148
|
-
def autocorrect(node)
|
149
|
-
lambda do |corrector|
|
150
|
-
name =
|
151
|
-
case style
|
152
|
-
when :semantic
|
153
|
-
command_or_kernel_call?(:raise, node) ? 'fail' : 'raise'
|
154
|
-
when :only_raise then 'raise'
|
155
|
-
when :only_fail then 'fail'
|
156
|
-
end
|
157
|
-
|
158
|
-
corrector.replace(node.loc.selector, name)
|
159
|
-
end
|
160
|
-
end
|
161
|
-
|
162
151
|
private
|
163
152
|
|
164
153
|
def message(method_name)
|
@@ -178,8 +167,9 @@ module RuboCop
|
|
178
167
|
each_command_or_kernel_call(method_name, node) do |send_node|
|
179
168
|
next if ignored_node?(send_node)
|
180
169
|
|
181
|
-
add_offense(send_node,
|
182
|
-
|
170
|
+
add_offense(send_node.loc.selector, message: message(method_name)) do |corrector|
|
171
|
+
autocorrect(corrector, send_node)
|
172
|
+
end
|
183
173
|
ignore_node(send_node)
|
184
174
|
end
|
185
175
|
end
|
@@ -187,7 +177,21 @@ module RuboCop
|
|
187
177
|
def check_send(method_name, node)
|
188
178
|
return unless node && command_or_kernel_call?(method_name, node)
|
189
179
|
|
190
|
-
add_offense(node
|
180
|
+
add_offense(node.loc.selector, message: message(method_name)) do |corrector|
|
181
|
+
autocorrect(corrector, node)
|
182
|
+
end
|
183
|
+
end
|
184
|
+
|
185
|
+
def autocorrect(corrector, node)
|
186
|
+
name =
|
187
|
+
case style
|
188
|
+
when :semantic
|
189
|
+
command_or_kernel_call?(:raise, node) ? 'fail' : 'raise'
|
190
|
+
when :only_raise then 'raise'
|
191
|
+
when :only_fail then 'fail'
|
192
|
+
end
|
193
|
+
|
194
|
+
corrector.replace(node.loc.selector, name)
|
191
195
|
end
|
192
196
|
|
193
197
|
def command_or_kernel_call?(name, node)
|
@@ -28,7 +28,7 @@ module RuboCop
|
|
28
28
|
# foo.reduce do |c, d|
|
29
29
|
# c + d
|
30
30
|
# end
|
31
|
-
class SingleLineBlockParams <
|
31
|
+
class SingleLineBlockParams < Base
|
32
32
|
MSG = 'Name `%<method>s` block params `|%<params>s|`.'
|
33
33
|
|
34
34
|
def on_block(node)
|
@@ -39,7 +39,9 @@ module RuboCop
|
|
39
39
|
|
40
40
|
return if args_match?(node.send_node.method_name, node.arguments)
|
41
41
|
|
42
|
-
|
42
|
+
message = message(node.arguments)
|
43
|
+
|
44
|
+
add_offense(node.arguments, message: message)
|
43
45
|
end
|
44
46
|
|
45
47
|
private
|
@@ -24,8 +24,9 @@ module RuboCop
|
|
24
24
|
# # bad
|
25
25
|
# def no_op; end
|
26
26
|
#
|
27
|
-
class SingleLineMethods <
|
27
|
+
class SingleLineMethods < Base
|
28
28
|
include Alignment
|
29
|
+
extend AutoCorrector
|
29
30
|
|
30
31
|
MSG = 'Avoid single-line method definitions.'
|
31
32
|
|
@@ -33,29 +34,29 @@ module RuboCop
|
|
33
34
|
return unless node.single_line?
|
34
35
|
return if allow_empty? && !node.body
|
35
36
|
|
36
|
-
add_offense(node)
|
37
|
+
add_offense(node) do |corrector|
|
38
|
+
autocorrect(corrector, node)
|
39
|
+
end
|
37
40
|
end
|
38
41
|
alias on_defs on_def
|
39
42
|
|
40
|
-
|
41
|
-
lambda do |corrector|
|
42
|
-
each_part(node.body) do |part|
|
43
|
-
LineBreakCorrector.break_line_before(
|
44
|
-
range: part, node: node, corrector: corrector,
|
45
|
-
configured_width: configured_indentation_width
|
46
|
-
)
|
47
|
-
end
|
43
|
+
private
|
48
44
|
|
45
|
+
def autocorrect(corrector, node)
|
46
|
+
each_part(node.body) do |part|
|
49
47
|
LineBreakCorrector.break_line_before(
|
50
|
-
range:
|
51
|
-
|
48
|
+
range: part, node: node, corrector: corrector,
|
49
|
+
configured_width: configured_indentation_width
|
52
50
|
)
|
53
|
-
|
54
|
-
move_comment(node, corrector)
|
55
51
|
end
|
56
|
-
end
|
57
52
|
|
58
|
-
|
53
|
+
LineBreakCorrector.break_line_before(
|
54
|
+
range: node.loc.end, node: node, corrector: corrector,
|
55
|
+
indent_steps: 0, configured_width: configured_indentation_width
|
56
|
+
)
|
57
|
+
|
58
|
+
move_comment(node, corrector)
|
59
|
+
end
|
59
60
|
|
60
61
|
def allow_empty?
|
61
62
|
cop_config['AllowIfMethodIsEmpty']
|
@@ -73,7 +74,7 @@ module RuboCop
|
|
73
74
|
|
74
75
|
def move_comment(node, corrector)
|
75
76
|
LineBreakCorrector.move_comment(
|
76
|
-
eol_comment:
|
77
|
+
eol_comment: processed_source.comment_at_line(node.source_range.line),
|
77
78
|
node: node, corrector: corrector
|
78
79
|
)
|
79
80
|
end
|
@@ -12,25 +12,23 @@ module RuboCop
|
|
12
12
|
#
|
13
13
|
# # good
|
14
14
|
# items[1..]
|
15
|
-
class SlicingWithRange <
|
15
|
+
class SlicingWithRange < Base
|
16
|
+
extend AutoCorrector
|
16
17
|
extend TargetRubyVersion
|
17
18
|
|
18
19
|
minimum_target_ruby_version 2.6
|
19
20
|
|
20
21
|
MSG = 'Prefer ary[n..] over ary[n..-1].'
|
22
|
+
RESTRICT_ON_SEND = %i[[]].freeze
|
21
23
|
|
22
24
|
def_node_matcher :range_till_minus_one?, '(irange !nil? (int -1))'
|
23
25
|
|
24
26
|
def on_send(node)
|
25
|
-
return unless node.
|
27
|
+
return unless node.arguments.count == 1
|
26
28
|
return unless range_till_minus_one?(node.arguments.first)
|
27
29
|
|
28
|
-
add_offense(node.
|
29
|
-
|
30
|
-
|
31
|
-
def autocorrect(node)
|
32
|
-
lambda do |corrector|
|
33
|
-
corrector.remove(node.end)
|
30
|
+
add_offense(node.first_argument) do |corrector|
|
31
|
+
corrector.remove(node.first_argument.end)
|
34
32
|
end
|
35
33
|
end
|
36
34
|
end
|