rubocop 0.89.0 → 0.92.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/README.md +2 -2
- data/config/default.yml +128 -14
- data/lib/rubocop.rb +30 -4
- data/lib/rubocop/cached_data.rb +1 -0
- data/lib/rubocop/cli/command.rb +1 -0
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +1 -0
- data/lib/rubocop/cli/command/base.rb +1 -0
- data/lib/rubocop/cli/command/execute_runner.rb +9 -0
- data/lib/rubocop/cli/command/init_dotfile.rb +1 -0
- data/lib/rubocop/cli/command/show_cops.rb +2 -1
- data/lib/rubocop/cli/command/version.rb +1 -0
- data/lib/rubocop/cli/environment.rb +1 -0
- data/lib/rubocop/comment_config.rb +17 -10
- data/lib/rubocop/config.rb +1 -1
- data/lib/rubocop/config_loader.rb +21 -10
- data/lib/rubocop/config_loader_resolver.rb +1 -0
- data/lib/rubocop/config_obsoletion.rb +1 -0
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +3 -3
- data/lib/rubocop/config_validator.rb +4 -1
- data/lib/rubocop/cop/base.rb +23 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +5 -1
- data/lib/rubocop/cop/bundler/gem_comment.rb +8 -3
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +2 -0
- data/lib/rubocop/cop/commissioner.rb +47 -7
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -5
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +8 -3
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +5 -8
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +5 -10
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
- data/lib/rubocop/cop/documentation.rb +22 -0
- data/lib/rubocop/cop/generator.rb +2 -1
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +1 -0
- data/lib/rubocop/cop/layout/array_alignment.rb +1 -0
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +77 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +23 -19
- data/lib/rubocop/cop/layout/case_indentation.rb +4 -7
- data/lib/rubocop/cop/layout/class_structure.rb +14 -17
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
- data/lib/rubocop/cop/layout/comment_indentation.rb +1 -1
- data/lib/rubocop/cop/layout/condition_position.rb +13 -15
- data/lib/rubocop/cop/layout/def_end_alignment.rb +8 -5
- data/lib/rubocop/cop/layout/dot_position.rb +21 -17
- data/lib/rubocop/cop/layout/empty_comment.rb +30 -23
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +21 -18
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +13 -13
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +21 -23
- data/lib/rubocop/cop/layout/empty_lines.rb +6 -7
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +18 -14
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +7 -8
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +4 -7
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +3 -7
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +2 -5
- data/lib/rubocop/cop/layout/end_alignment.rb +11 -17
- data/lib/rubocop/cop/layout/extra_spacing.rb +14 -21
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +4 -8
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/hash_alignment.rb +17 -20
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +15 -14
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +14 -11
- data/lib/rubocop/cop/layout/initial_indentation.rb +6 -7
- data/lib/rubocop/cop/layout/leading_comment_space.rb +12 -10
- data/lib/rubocop/cop/layout/leading_empty_lines.rb +6 -11
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +10 -14
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +21 -19
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +5 -9
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +41 -22
- data/lib/rubocop/cop/layout/space_after_colon.rb +11 -7
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +5 -6
- data/lib/rubocop/cop/layout/space_after_not.rb +9 -11
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +22 -17
- data/lib/rubocop/cop/layout/space_around_keyword.rb +17 -18
- data/lib/rubocop/cop/layout/space_around_operators.rb +17 -16
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +23 -22
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +10 -7
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +7 -7
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +9 -17
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +20 -23
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -8
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +17 -16
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +19 -37
- data/lib/rubocop/cop/layout/space_inside_parens.rb +9 -14
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +5 -10
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +8 -17
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +16 -24
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +12 -13
- data/lib/rubocop/cop/layout/trailing_empty_lines.rb +10 -15
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +11 -11
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +2 -0
- data/lib/rubocop/cop/lint/big_decimal_new.rb +1 -2
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +2 -1
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +74 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +1 -1
- data/lib/rubocop/cop/lint/debugger.rb +2 -3
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +1 -3
- data/lib/rubocop/cop/lint/duplicate_methods.rb +2 -4
- data/lib/rubocop/cop/lint/duplicate_require.rb +46 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +2 -15
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -0
- data/lib/rubocop/cop/lint/empty_file.rb +50 -0
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +2 -0
- data/lib/rubocop/cop/lint/float_comparison.rb +2 -2
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +2 -2
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +2 -5
- data/lib/rubocop/cop/lint/inherit_exception.rb +2 -2
- data/lib/rubocop/cop/lint/missing_super.rb +11 -11
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +2 -35
- data/lib/rubocop/cop/lint/multiple_comparison.rb +3 -1
- data/lib/rubocop/cop/lint/number_conversion.rb +1 -0
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +33 -15
- data/lib/rubocop/cop/lint/percent_string_array.rb +8 -12
- data/lib/rubocop/cop/lint/raise_exception.rb +1 -0
- data/lib/rubocop/cop/lint/rand_one.rb +2 -1
- data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +36 -29
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +14 -4
- data/lib/rubocop/cop/lint/redundant_require_statement.rb +1 -0
- data/lib/rubocop/cop/lint/rescue_type.rb +0 -1
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +3 -1
- data/lib/rubocop/cop/lint/shadowed_exception.rb +6 -6
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +4 -4
- data/lib/rubocop/cop/lint/struct_new_override.rb +1 -0
- data/lib/rubocop/cop/lint/to_json.rb +16 -5
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +1 -1
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +57 -0
- data/lib/rubocop/cop/lint/unreachable_loop.rb +3 -6
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +3 -1
- data/lib/rubocop/cop/lint/uri_regexp.rb +10 -25
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +3 -9
- data/lib/rubocop/cop/lint/useless_method_definition.rb +70 -0
- data/lib/rubocop/cop/lint/useless_times.rb +106 -0
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +27 -16
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +1 -0
- data/lib/rubocop/cop/migration/department_name.rb +2 -2
- data/lib/rubocop/cop/mixin/alignment.rb +5 -1
- data/lib/rubocop/cop/mixin/allowed_methods.rb +2 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +5 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +17 -8
- data/lib/rubocop/cop/mixin/comments_help.rb +48 -0
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +3 -3
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +8 -7
- data/lib/rubocop/cop/mixin/empty_parameter.rb +3 -1
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +12 -1
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +0 -2
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +3 -1
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +31 -12
- data/lib/rubocop/cop/mixin/line_length_help.rb +1 -3
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +3 -1
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +13 -12
- data/lib/rubocop/cop/mixin/negative_conditional.rb +2 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +16 -9
- data/lib/rubocop/cop/mixin/range_help.rb +18 -4
- data/lib/rubocop/cop/mixin/regexp_literal_help.rb +1 -1
- data/lib/rubocop/cop/mixin/rescue_node.rb +11 -1
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/statement_modifier.rb +12 -6
- data/lib/rubocop/cop/mixin/surrounding_space.rb +8 -4
- data/lib/rubocop/cop/mixin/trailing_comma.rb +9 -11
- data/lib/rubocop/cop/mixin/visibility_help.rb +4 -16
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
- data/lib/rubocop/cop/naming/file_name.rb +1 -1
- data/lib/rubocop/cop/offense.rb +1 -0
- data/lib/rubocop/cop/security/eval.rb +1 -0
- data/lib/rubocop/cop/security/json_load.rb +1 -0
- data/lib/rubocop/cop/security/marshal_load.rb +1 -0
- data/lib/rubocop/cop/security/open.rb +1 -0
- data/lib/rubocop/cop/security/yaml_load.rb +1 -0
- data/lib/rubocop/cop/severity.rb +0 -8
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +8 -19
- data/lib/rubocop/cop/style/accessor_grouping.rb +20 -20
- data/lib/rubocop/cop/style/alias.rb +36 -33
- data/lib/rubocop/cop/style/and_or.rb +9 -11
- data/lib/rubocop/cop/style/array_coercion.rb +4 -0
- data/lib/rubocop/cop/style/array_join.rb +7 -8
- data/lib/rubocop/cop/style/ascii_comments.rb +4 -4
- data/lib/rubocop/cop/style/attr.rb +12 -9
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +4 -5
- data/lib/rubocop/cop/style/bare_percent_literals.rb +10 -12
- data/lib/rubocop/cop/style/begin_block.rb +2 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +9 -12
- data/lib/rubocop/cop/style/block_comments.rb +14 -18
- data/lib/rubocop/cop/style/block_delimiters.rb +23 -23
- data/lib/rubocop/cop/style/case_equality.rb +11 -3
- data/lib/rubocop/cop/style/case_like_if.rb +37 -18
- data/lib/rubocop/cop/style/class_and_module_children.rb +16 -11
- data/lib/rubocop/cop/style/class_check.rb +6 -11
- data/lib/rubocop/cop/style/class_methods.rb +7 -11
- data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
- data/lib/rubocop/cop/style/class_vars.rb +7 -12
- data/lib/rubocop/cop/style/collection_methods.rb +11 -17
- data/lib/rubocop/cop/style/colon_method_call.rb +6 -7
- data/lib/rubocop/cop/style/colon_method_definition.rb +6 -6
- data/lib/rubocop/cop/style/combinable_loops.rb +84 -0
- data/lib/rubocop/cop/style/command_literal.rb +23 -24
- data/lib/rubocop/cop/style/comment_annotation.rb +15 -15
- data/lib/rubocop/cop/style/commented_keyword.rb +8 -9
- data/lib/rubocop/cop/style/conditional_assignment.rb +50 -61
- data/lib/rubocop/cop/style/constant_visibility.rb +3 -2
- data/lib/rubocop/cop/style/copyright.rb +12 -12
- data/lib/rubocop/cop/style/date_time.rb +13 -2
- data/lib/rubocop/cop/style/def_with_parentheses.rb +8 -10
- data/lib/rubocop/cop/style/dir.rb +8 -10
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +7 -9
- data/lib/rubocop/cop/style/documentation.rb +2 -4
- data/lib/rubocop/cop/style/documentation_method.rb +1 -1
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +12 -15
- data/lib/rubocop/cop/style/double_negation.rb +3 -2
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +5 -8
- data/lib/rubocop/cop/style/each_with_object.rb +16 -17
- data/lib/rubocop/cop/style/empty_block_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_case_condition.rb +19 -20
- data/lib/rubocop/cop/style/empty_else.rb +17 -19
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_literal.rb +18 -17
- data/lib/rubocop/cop/style/empty_method.rb +5 -8
- data/lib/rubocop/cop/style/encoding.rb +5 -9
- data/lib/rubocop/cop/style/end_block.rb +4 -6
- data/lib/rubocop/cop/style/eval_with_location.rb +6 -10
- data/lib/rubocop/cop/style/even_odd.rb +8 -11
- data/lib/rubocop/cop/style/expand_path_arguments.rb +23 -26
- data/lib/rubocop/cop/style/explicit_block_argument.rb +1 -1
- data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
- data/lib/rubocop/cop/style/float_division.rb +3 -1
- data/lib/rubocop/cop/style/for.rb +11 -15
- data/lib/rubocop/cop/style/format_string.rb +18 -23
- data/lib/rubocop/cop/style/format_string_token.rb +4 -7
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +19 -41
- data/lib/rubocop/cop/style/global_vars.rb +2 -2
- data/lib/rubocop/cop/style/guard_clause.rb +4 -4
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +24 -5
- data/lib/rubocop/cop/style/hash_each_methods.rb +5 -8
- data/lib/rubocop/cop/style/hash_syntax.rb +6 -7
- data/lib/rubocop/cop/style/hash_transform_keys.rb +19 -11
- data/lib/rubocop/cop/style/hash_transform_values.rb +18 -10
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +1 -1
- data/lib/rubocop/cop/style/if_inside_else.rb +2 -2
- data/lib/rubocop/cop/style/if_unless_modifier.rb +11 -17
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +3 -7
- data/lib/rubocop/cop/style/if_with_semicolon.rb +3 -6
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +2 -1
- data/lib/rubocop/cop/style/infinite_loop.rb +23 -23
- data/lib/rubocop/cop/style/inline_comment.rb +3 -3
- data/lib/rubocop/cop/style/inverse_methods.rb +20 -29
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +53 -0
- data/lib/rubocop/cop/style/lambda.rb +7 -12
- data/lib/rubocop/cop/style/lambda_call.rb +17 -14
- data/lib/rubocop/cop/style/line_end_concatenation.rb +19 -16
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +2 -1
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +11 -11
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +4 -8
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +7 -6
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +12 -3
- data/lib/rubocop/cop/style/method_def_parentheses.rb +11 -16
- data/lib/rubocop/cop/style/min_max.rb +8 -12
- data/lib/rubocop/cop/style/missing_else.rb +13 -13
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +1 -1
- data/lib/rubocop/cop/style/mixin_grouping.rb +24 -27
- data/lib/rubocop/cop/style/mixin_usage.rb +9 -28
- data/lib/rubocop/cop/style/module_function.rb +10 -13
- data/lib/rubocop/cop/style/multiline_block_chain.rb +2 -2
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +3 -10
- data/lib/rubocop/cop/style/multiline_if_then.rb +4 -10
- data/lib/rubocop/cop/style/multiline_memoization.rb +12 -10
- data/lib/rubocop/cop/style/multiline_method_signature.rb +1 -1
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +17 -6
- data/lib/rubocop/cop/style/multiline_when_then.rb +10 -11
- data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
- data/lib/rubocop/cop/style/mutable_constant.rb +23 -20
- data/lib/rubocop/cop/style/negated_if.rb +6 -6
- data/lib/rubocop/cop/style/negated_unless.rb +6 -6
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_modifier.rb +10 -13
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +14 -12
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +14 -16
- data/lib/rubocop/cop/style/next.rb +10 -14
- data/lib/rubocop/cop/style/nil_comparison.rb +13 -11
- data/lib/rubocop/cop/style/non_nil_check.rb +34 -26
- data/lib/rubocop/cop/style/not.rb +20 -26
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +4 -9
- data/lib/rubocop/cop/style/numeric_predicate.rb +5 -14
- data/lib/rubocop/cop/style/one_line_conditional.rb +73 -23
- data/lib/rubocop/cop/style/option_hash.rb +1 -1
- data/lib/rubocop/cop/style/optional_arguments.rb +1 -1
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +12 -1
- data/lib/rubocop/cop/style/or_assignment.rb +13 -10
- data/lib/rubocop/cop/style/parallel_assignment.rb +14 -14
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +6 -6
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +13 -19
- data/lib/rubocop/cop/style/percent_q_literals.rb +8 -10
- data/lib/rubocop/cop/style/perl_backrefs.rb +8 -10
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +11 -14
- data/lib/rubocop/cop/style/proc.rb +6 -6
- data/lib/rubocop/cop/style/raise_args.rb +15 -24
- data/lib/rubocop/cop/style/random_with_offset.rb +19 -19
- data/lib/rubocop/cop/style/redundant_assignment.rb +8 -18
- data/lib/rubocop/cop/style/redundant_begin.rb +7 -9
- data/lib/rubocop/cop/style/redundant_capital_w.rb +6 -9
- data/lib/rubocop/cop/style/redundant_condition.rb +5 -6
- data/lib/rubocop/cop/style/redundant_conditional.rb +4 -5
- data/lib/rubocop/cop/style/redundant_exception.rb +1 -3
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +3 -12
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +9 -8
- data/lib/rubocop/cop/style/redundant_freeze.rb +5 -7
- data/lib/rubocop/cop/style/redundant_interpolation.rb +25 -24
- data/lib/rubocop/cop/style/redundant_parentheses.rb +21 -15
- data/lib/rubocop/cop/style/redundant_percent_q.rb +9 -11
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +6 -13
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +5 -14
- data/lib/rubocop/cop/style/redundant_return.rb +17 -17
- data/lib/rubocop/cop/style/redundant_self.rb +9 -11
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +116 -0
- data/lib/rubocop/cop/style/redundant_sort.rb +12 -31
- data/lib/rubocop/cop/style/redundant_sort_by.rb +5 -9
- data/lib/rubocop/cop/style/regexp_literal.rb +10 -21
- data/lib/rubocop/cop/style/rescue_modifier.rb +29 -9
- data/lib/rubocop/cop/style/rescue_standard_error.rb +20 -16
- data/lib/rubocop/cop/style/return_nil.rb +5 -5
- data/lib/rubocop/cop/style/safe_navigation.rb +22 -16
- data/lib/rubocop/cop/style/sample.rb +12 -14
- data/lib/rubocop/cop/style/self_assignment.rb +26 -22
- data/lib/rubocop/cop/style/semicolon.rb +6 -9
- data/lib/rubocop/cop/style/send.rb +4 -5
- data/lib/rubocop/cop/style/signal_exception.rb +23 -19
- data/lib/rubocop/cop/style/single_argument_dig.rb +1 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +4 -2
- data/lib/rubocop/cop/style/single_line_methods.rb +18 -17
- data/lib/rubocop/cop/style/slicing_with_range.rb +6 -8
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +66 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +10 -15
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +17 -21
- data/lib/rubocop/cop/style/stderr_puts.rb +5 -6
- data/lib/rubocop/cop/style/string_concatenation.rb +16 -2
- data/lib/rubocop/cop/style/string_hash_keys.rb +6 -7
- data/lib/rubocop/cop/style/string_methods.rb +7 -17
- data/lib/rubocop/cop/style/strip.rb +9 -14
- data/lib/rubocop/cop/style/struct_inheritance.rb +3 -6
- data/lib/rubocop/cop/style/symbol_array.rb +5 -16
- data/lib/rubocop/cop/style/symbol_literal.rb +4 -6
- data/lib/rubocop/cop/style/symbol_proc.rb +14 -18
- data/lib/rubocop/cop/style/ternary_parentheses.rb +22 -22
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +3 -6
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +4 -7
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +3 -6
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +2 -5
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +2 -5
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +11 -9
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +2 -5
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +8 -17
- data/lib/rubocop/cop/style/trivial_accessors.rb +26 -30
- data/lib/rubocop/cop/style/unless_else.rb +5 -8
- data/lib/rubocop/cop/style/unpack_first.rb +5 -8
- data/lib/rubocop/cop/style/variable_interpolation.rb +7 -10
- data/lib/rubocop/cop/style/when_then.rb +4 -6
- data/lib/rubocop/cop/style/while_until_do.rb +6 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +6 -20
- data/lib/rubocop/cop/style/word_array.rb +5 -23
- data/lib/rubocop/cop/style/yoda_condition.rb +4 -15
- data/lib/rubocop/cop/style/zero_length_predicate.rb +12 -18
- data/lib/rubocop/cop/team.rb +1 -0
- data/lib/rubocop/cop/util.rb +2 -1
- data/lib/rubocop/cop/utils/format_string.rb +3 -5
- data/lib/rubocop/cop/variable_force.rb +2 -0
- data/lib/rubocop/cops_documentation_generator.rb +5 -3
- data/lib/rubocop/core_ext/string.rb +2 -2
- data/lib/rubocop/directive_comment.rb +32 -0
- data/lib/rubocop/ext/regexp_node.rb +46 -0
- data/lib/rubocop/file_finder.rb +1 -0
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/disabled_config_formatter.rb +13 -6
- data/lib/rubocop/formatter/html_formatter.rb +2 -0
- data/lib/rubocop/formatter/junit_formatter.rb +1 -1
- data/lib/rubocop/formatter/progress_formatter.rb +2 -1
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +36 -6
- data/lib/rubocop/name_similarity.rb +1 -0
- data/lib/rubocop/options.rb +43 -20
- data/lib/rubocop/remote_config.rb +1 -0
- data/lib/rubocop/result_cache.rb +31 -13
- data/lib/rubocop/rspec/cop_helper.rb +4 -1
- data/lib/rubocop/rspec/expect_offense.rb +14 -9
- data/lib/rubocop/rspec/shared_contexts.rb +13 -5
- data/lib/rubocop/runner.rb +35 -15
- data/lib/rubocop/string_interpreter.rb +3 -0
- data/lib/rubocop/target_finder.rb +5 -1
- data/lib/rubocop/target_ruby.rb +7 -1
- data/lib/rubocop/version.rb +7 -1
- data/lib/rubocop/yaml_duplication_checker.rb +1 -0
- metadata +26 -14
- data/lib/rubocop/cop/tokens_util.rb +0 -84
@@ -17,7 +17,9 @@ module RuboCop
|
|
17
17
|
#
|
18
18
|
# # good
|
19
19
|
# 'a'..'z'
|
20
|
-
class SpaceInsideRangeLiteral <
|
20
|
+
class SpaceInsideRangeLiteral < Base
|
21
|
+
extend AutoCorrector
|
22
|
+
|
21
23
|
MSG = 'Space inside range literal.'
|
22
24
|
|
23
25
|
def on_irange(node)
|
@@ -28,21 +30,6 @@ module RuboCop
|
|
28
30
|
check(node)
|
29
31
|
end
|
30
32
|
|
31
|
-
def autocorrect(node)
|
32
|
-
expression = node.source
|
33
|
-
operator = node.loc.operator.source
|
34
|
-
operator_escaped = operator.gsub(/\./, '\.')
|
35
|
-
|
36
|
-
lambda do |corrector|
|
37
|
-
corrector.replace(
|
38
|
-
node,
|
39
|
-
expression
|
40
|
-
.sub(/\s+#{operator_escaped}/, operator)
|
41
|
-
.sub(/#{operator_escaped}\s+/, operator)
|
42
|
-
)
|
43
|
-
end
|
44
|
-
end
|
45
|
-
|
46
33
|
private
|
47
34
|
|
48
35
|
def check(node)
|
@@ -55,7 +42,11 @@ module RuboCop
|
|
55
42
|
|
56
43
|
return unless /(\s#{escaped_op})|(#{escaped_op}\s)/.match?(expression)
|
57
44
|
|
58
|
-
add_offense(node)
|
45
|
+
add_offense(node) do |corrector|
|
46
|
+
corrector.replace(
|
47
|
+
node, expression.sub(/\s+#{escaped_op}/, op).sub(/#{escaped_op}\s+/, op)
|
48
|
+
)
|
49
|
+
end
|
59
50
|
end
|
60
51
|
end
|
61
52
|
end
|
@@ -53,20 +53,20 @@ module RuboCop
|
|
53
53
|
# # good
|
54
54
|
# foo[ ]
|
55
55
|
#
|
56
|
-
class SpaceInsideReferenceBrackets <
|
56
|
+
class SpaceInsideReferenceBrackets < Base
|
57
57
|
include SurroundingSpace
|
58
58
|
include ConfigurableEnforcedStyle
|
59
|
+
extend AutoCorrector
|
59
60
|
|
60
61
|
MSG = '%<command>s space inside reference brackets.'
|
61
62
|
EMPTY_MSG = '%<command>s space inside empty reference brackets.'
|
62
63
|
|
63
|
-
|
64
|
+
RESTRICT_ON_SEND = %i[[] []=].freeze
|
64
65
|
|
65
66
|
def on_send(node)
|
66
67
|
return if node.multiline?
|
67
|
-
return unless bracket_method?(node)
|
68
68
|
|
69
|
-
tokens =
|
69
|
+
tokens = processed_source.tokens_within(node)
|
70
70
|
left_token = left_ref_bracket(node, tokens)
|
71
71
|
return unless left_token
|
72
72
|
|
@@ -83,34 +83,26 @@ module RuboCop
|
|
83
83
|
end
|
84
84
|
end
|
85
85
|
|
86
|
-
|
87
|
-
|
88
|
-
|
89
|
-
|
90
|
-
|
91
|
-
|
92
|
-
|
93
|
-
|
94
|
-
|
95
|
-
|
96
|
-
|
97
|
-
SpaceCorrector.add_space(processed_source, corrector, left, right)
|
98
|
-
end
|
86
|
+
private
|
87
|
+
|
88
|
+
def autocorrect(corrector, node)
|
89
|
+
left, right = reference_brackets(node)
|
90
|
+
|
91
|
+
if empty_brackets?(left, right)
|
92
|
+
SpaceCorrector.empty_corrections(processed_source, corrector, empty_config, left, right)
|
93
|
+
elsif style == :no_space
|
94
|
+
SpaceCorrector.remove_space(processed_source, corrector, left, right)
|
95
|
+
else
|
96
|
+
SpaceCorrector.add_space(processed_source, corrector, left, right)
|
99
97
|
end
|
100
98
|
end
|
101
99
|
|
102
|
-
private
|
103
|
-
|
104
100
|
def reference_brackets(node)
|
105
|
-
tokens =
|
101
|
+
tokens = processed_source.tokens_within(node)
|
106
102
|
left = left_ref_bracket(node, tokens)
|
107
103
|
[left, closing_bracket(tokens, left)]
|
108
104
|
end
|
109
105
|
|
110
|
-
def bracket_method?(node)
|
111
|
-
BRACKET_METHODS.include?(node.method_name)
|
112
|
-
end
|
113
|
-
|
114
106
|
def left_ref_bracket(node, tokens)
|
115
107
|
current_token = tokens.reverse.find(&:left_ref_bracket?)
|
116
108
|
previous_token = previous_token(current_token)
|
@@ -18,11 +18,12 @@ module RuboCop
|
|
18
18
|
#
|
19
19
|
# # good
|
20
20
|
# var = "This is the #{ space } example"
|
21
|
-
class SpaceInsideStringInterpolation <
|
21
|
+
class SpaceInsideStringInterpolation < Base
|
22
22
|
include Interpolation
|
23
23
|
include SurroundingSpace
|
24
24
|
include ConfigurableEnforcedStyle
|
25
25
|
include RangeHelp
|
26
|
+
extend AutoCorrector
|
26
27
|
|
27
28
|
NO_SPACE_MSG = 'Space inside string interpolation detected.'
|
28
29
|
SPACE_MSG = 'Missing space inside string interpolation detected.'
|
@@ -40,23 +41,21 @@ module RuboCop
|
|
40
41
|
end
|
41
42
|
end
|
42
43
|
|
43
|
-
|
44
|
-
|
45
|
-
|
44
|
+
private
|
45
|
+
|
46
|
+
def autocorrect(corrector, begin_node)
|
47
|
+
delims = delimiters(begin_node)
|
46
48
|
|
47
|
-
|
48
|
-
|
49
|
-
|
50
|
-
|
51
|
-
end
|
49
|
+
if style == :no_space
|
50
|
+
SpaceCorrector.remove_space(processed_source, corrector, *delims)
|
51
|
+
else
|
52
|
+
SpaceCorrector.add_space(processed_source, corrector, *delims)
|
52
53
|
end
|
53
54
|
end
|
54
55
|
|
55
|
-
private
|
56
|
-
|
57
56
|
def delimiters(begin_node)
|
58
|
-
left = processed_source.
|
59
|
-
right = processed_source.
|
57
|
+
left = processed_source.first_token_of(begin_node)
|
58
|
+
right = processed_source.last_token_of(begin_node)
|
60
59
|
[left, right]
|
61
60
|
end
|
62
61
|
end
|
@@ -37,11 +37,12 @@ module RuboCop
|
|
37
37
|
# class Foo; end
|
38
38
|
# # EOF
|
39
39
|
#
|
40
|
-
class TrailingEmptyLines <
|
40
|
+
class TrailingEmptyLines < Base
|
41
41
|
include ConfigurableEnforcedStyle
|
42
42
|
include RangeHelp
|
43
|
+
extend AutoCorrector
|
43
44
|
|
44
|
-
def
|
45
|
+
def on_new_investigation
|
45
46
|
buffer = processed_source.buffer
|
46
47
|
return if buffer.source.empty?
|
47
48
|
|
@@ -57,28 +58,22 @@ module RuboCop
|
|
57
58
|
|
58
59
|
return unless blank_lines != wanted_blank_lines
|
59
60
|
|
60
|
-
offense_detected(buffer, wanted_blank_lines, blank_lines,
|
61
|
-
whitespace_at_end)
|
62
|
-
end
|
63
|
-
|
64
|
-
def autocorrect(range)
|
65
|
-
lambda do |corrector|
|
66
|
-
corrector.replace(range, style == :final_newline ? "\n" : "\n\n")
|
67
|
-
end
|
61
|
+
offense_detected(buffer, wanted_blank_lines, blank_lines, whitespace_at_end)
|
68
62
|
end
|
69
63
|
|
70
64
|
private
|
71
65
|
|
72
|
-
def offense_detected(buffer, wanted_blank_lines, blank_lines,
|
73
|
-
whitespace_at_end)
|
66
|
+
def offense_detected(buffer, wanted_blank_lines, blank_lines, whitespace_at_end)
|
74
67
|
begin_pos = buffer.source.length - whitespace_at_end.length
|
75
68
|
autocorrect_range = range_between(begin_pos, buffer.source.length)
|
76
69
|
begin_pos += 1 unless whitespace_at_end.empty?
|
77
70
|
report_range = range_between(begin_pos, buffer.source.length)
|
78
71
|
|
79
|
-
add_offense(
|
80
|
-
|
81
|
-
|
72
|
+
add_offense(
|
73
|
+
report_range, message: message(wanted_blank_lines, blank_lines)
|
74
|
+
) do |corrector|
|
75
|
+
corrector.replace(autocorrect_range, style == :final_newline ? "\n" : "\n\n")
|
76
|
+
end
|
82
77
|
end
|
83
78
|
|
84
79
|
def ends_in_end?(processed_source)
|
@@ -28,12 +28,13 @@ module RuboCop
|
|
28
28
|
# x = 0
|
29
29
|
# RUBY
|
30
30
|
#
|
31
|
-
class TrailingWhitespace <
|
31
|
+
class TrailingWhitespace < Base
|
32
32
|
include RangeHelp
|
33
|
+
extend AutoCorrector
|
33
34
|
|
34
35
|
MSG = 'Trailing whitespace detected.'
|
35
36
|
|
36
|
-
def
|
37
|
+
def on_new_investigation
|
37
38
|
heredoc_ranges = extract_heredoc_ranges(processed_source.ast)
|
38
39
|
processed_source.lines.each_with_index do |line, index|
|
39
40
|
lineno = index + 1
|
@@ -41,18 +42,13 @@ module RuboCop
|
|
41
42
|
next unless line.end_with?(' ', "\t")
|
42
43
|
next if skip_heredoc? && inside_heredoc?(heredoc_ranges, lineno)
|
43
44
|
|
44
|
-
range =
|
45
|
-
|
46
|
-
|
47
|
-
|
48
|
-
add_offense(range, location: range)
|
45
|
+
range = offense_range(lineno, line)
|
46
|
+
add_offense(range) do |corrector|
|
47
|
+
corrector.remove(range)
|
48
|
+
end
|
49
49
|
end
|
50
50
|
end
|
51
51
|
|
52
|
-
def autocorrect(range)
|
53
|
-
->(corrector) { corrector.remove(range) }
|
54
|
-
end
|
55
|
-
|
56
52
|
private
|
57
53
|
|
58
54
|
def skip_heredoc?
|
@@ -71,6 +67,10 @@ module RuboCop
|
|
71
67
|
(body.first_line...body.last_line)
|
72
68
|
end
|
73
69
|
end
|
70
|
+
|
71
|
+
def offense_range(lineno, line)
|
72
|
+
source_range(processed_source.buffer, lineno, (line.rstrip.length)...(line.length))
|
73
|
+
end
|
74
74
|
end
|
75
75
|
end
|
76
76
|
end
|
@@ -19,6 +19,7 @@ module RuboCop
|
|
19
19
|
|
20
20
|
MSG = '`%<double_colon>sBigDecimal.new()` is deprecated. ' \
|
21
21
|
'Use `%<double_colon>sBigDecimal()` instead.'
|
22
|
+
RESTRICT_ON_SEND = %i[new].freeze
|
22
23
|
|
23
24
|
def_node_matcher :big_decimal_new, <<~PATTERN
|
24
25
|
(send
|
@@ -26,8 +27,6 @@ module RuboCop
|
|
26
27
|
PATTERN
|
27
28
|
|
28
29
|
def on_send(node)
|
29
|
-
return unless node.method?(:new)
|
30
|
-
|
31
30
|
big_decimal_new(node) do |captured_value|
|
32
31
|
double_colon = captured_value ? '::' : ''
|
33
32
|
message = format(MSG, double_colon: double_colon)
|
@@ -29,12 +29,13 @@ module RuboCop
|
|
29
29
|
#
|
30
30
|
class BinaryOperatorWithIdenticalOperands < Base
|
31
31
|
MSG = 'Binary operator `%<op>s` has identical operands.'
|
32
|
+
MATH_OPERATORS = %i[+ - * / % ** << >> | ^].to_set.freeze
|
32
33
|
|
33
34
|
def on_send(node)
|
34
35
|
return unless node.binary_operation?
|
35
36
|
|
36
37
|
lhs, operation, rhs = *node
|
37
|
-
return if node.
|
38
|
+
return if MATH_OPERATORS.include?(node.method_name) && lhs.basic_literal?
|
38
39
|
|
39
40
|
add_offense(node, message: format(MSG, op: operation)) if lhs == rhs
|
40
41
|
end
|
@@ -0,0 +1,74 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
module Lint
|
6
|
+
# Do not define constants within a block, since the block's scope does not
|
7
|
+
# isolate or namespace the constant in any way.
|
8
|
+
#
|
9
|
+
# If you are trying to define that constant once, define it outside of
|
10
|
+
# the block instead, or use a variable or method if defining the constant
|
11
|
+
# in the outer scope would be problematic.
|
12
|
+
#
|
13
|
+
# For meta-programming, use `const_set`.
|
14
|
+
#
|
15
|
+
# @example
|
16
|
+
# # bad
|
17
|
+
# task :lint do
|
18
|
+
# FILES_TO_LINT = Dir['lib/*.rb']
|
19
|
+
# end
|
20
|
+
#
|
21
|
+
# # bad
|
22
|
+
# describe 'making a request' do
|
23
|
+
# class TestRequest; end
|
24
|
+
# end
|
25
|
+
#
|
26
|
+
# # bad
|
27
|
+
# module M
|
28
|
+
# extend ActiveSupport::Concern
|
29
|
+
# included do
|
30
|
+
# LIST = []
|
31
|
+
# end
|
32
|
+
# end
|
33
|
+
#
|
34
|
+
# # good
|
35
|
+
# task :lint do
|
36
|
+
# files_to_lint = Dir['lib/*.rb']
|
37
|
+
# end
|
38
|
+
#
|
39
|
+
# # good
|
40
|
+
# describe 'making a request' do
|
41
|
+
# let(:test_request) { Class.new }
|
42
|
+
# # see also `stub_const` for RSpec
|
43
|
+
# end
|
44
|
+
#
|
45
|
+
# # good
|
46
|
+
# module M
|
47
|
+
# extend ActiveSupport::Concern
|
48
|
+
# included do
|
49
|
+
# const_set(:LIST, [])
|
50
|
+
# end
|
51
|
+
# end
|
52
|
+
class ConstantDefinitionInBlock < Base
|
53
|
+
MSG = 'Do not define constants this way within a block.'
|
54
|
+
|
55
|
+
def_node_matcher :constant_assigned_in_block?, <<~PATTERN
|
56
|
+
({^block_type? [^begin_type? ^^block_type?]} nil? ...)
|
57
|
+
PATTERN
|
58
|
+
|
59
|
+
def_node_matcher :module_defined_in_block?, <<~PATTERN
|
60
|
+
({^block_type? [^begin_type? ^^block_type?]} ...)
|
61
|
+
PATTERN
|
62
|
+
|
63
|
+
def on_casgn(node)
|
64
|
+
add_offense(node) if constant_assigned_in_block?(node)
|
65
|
+
end
|
66
|
+
|
67
|
+
def on_class(node)
|
68
|
+
add_offense(node) if module_defined_in_block?(node)
|
69
|
+
end
|
70
|
+
alias on_module on_class
|
71
|
+
end
|
72
|
+
end
|
73
|
+
end
|
74
|
+
end
|
@@ -35,10 +35,10 @@ module RuboCop
|
|
35
35
|
class Debugger < Base
|
36
36
|
MSG = 'Remove debugger entry point `%<source>s`.'
|
37
37
|
|
38
|
-
|
38
|
+
RESTRICT_ON_SEND = %i[
|
39
39
|
debugger byebug remote_byebug pry remote_pry pry_remote console rescue
|
40
40
|
save_and_open_page save_and_open_screenshot save_screenshot irb
|
41
|
-
].
|
41
|
+
].freeze
|
42
42
|
|
43
43
|
def_node_matcher :kernel?, <<~PATTERN
|
44
44
|
{
|
@@ -62,7 +62,6 @@ module RuboCop
|
|
62
62
|
PATTERN
|
63
63
|
|
64
64
|
def on_send(node)
|
65
|
-
return unless DEBUGGER_METHODS.include?(node.method_name)
|
66
65
|
return unless debugger_call?(node) || binding_irb?(node)
|
67
66
|
|
68
67
|
add_offense(node)
|
@@ -62,11 +62,9 @@ module RuboCop
|
|
62
62
|
replacement: :block_given?)
|
63
63
|
].freeze
|
64
64
|
|
65
|
-
|
65
|
+
RESTRICT_ON_SEND = DEPRECATED_METHODS_OBJECT.map(&:deprecated_method).freeze
|
66
66
|
|
67
67
|
def on_send(node)
|
68
|
-
return unless DEPRECATED_METHODS.include?(node.method_name)
|
69
|
-
|
70
68
|
check(node) do |data|
|
71
69
|
message = format(MSG, current: deprecated_method(data),
|
72
70
|
prefer: replacement_method(data))
|
@@ -53,8 +53,8 @@ module RuboCop
|
|
53
53
|
MSG = 'Method `%<method>s` is defined at both %<defined>s and ' \
|
54
54
|
'%<current>s.'
|
55
55
|
|
56
|
-
|
57
|
-
|
56
|
+
RESTRICT_ON_SEND = %i[alias_method attr_reader attr_writer
|
57
|
+
attr_accessor attr].freeze
|
58
58
|
|
59
59
|
def initialize(config = nil, options = nil)
|
60
60
|
super
|
@@ -100,8 +100,6 @@ module RuboCop
|
|
100
100
|
|
101
101
|
def_node_matcher :sym_name, '(sym $_name)'
|
102
102
|
def on_send(node)
|
103
|
-
return unless METHOD_DEF_METHODS.include?(node.method_name)
|
104
|
-
|
105
103
|
if (name = alias_method?(node))
|
106
104
|
return if node.ancestors.any?(&:if_type?)
|
107
105
|
return if possible_dsl?(node)
|