rubocop 0.88.0 → 0.89.1

data/lib/rubocop/error.rb

@@ -12,6 +12,7 @@ module RuboCop
   # A wrapper to display errored location of analyzed file.
   class ErrorWithAnalyzedFileLocation < Error
     def initialize(cause:, node:, cop:)
+      super()
       @cause = cause
       @cop = cop
       @location = node.is_a?(RuboCop::AST::Node) ? node.loc : node

data/lib/rubocop/formatter/disabled_config_formatter.rb

@@ -114,7 +114,7 @@ module RuboCop
       def output_cop_comments(output_buffer, cfg, cop_name, offense_count)
         output_buffer.puts "# Offense count: #{offense_count}" if @show_offense_counts
 
-        cop_class = Cop::Cop.registry.find_by_cop_name(cop_name)
+        cop_class = Cop::Registry.global.find_by_cop_name(cop_name)
         output_buffer.puts '# Cop supports --auto-correct.' if cop_class&.support_autocorrect?
 
         default_cfg = default_config(cop_name)

data/lib/rubocop/formatter/formatter_set.rb

@@ -35,6 +35,7 @@ module RuboCop
       end
 
       def initialize(options = {})
+        super()
         @options = options # CLI options
       end
 

data/lib/rubocop/formatter/junit_formatter.rb

@@ -34,7 +34,7 @@ module RuboCop
         # https://github.com/mikian/rubocop-junit-formatter/blob/v0.1.4/lib/rubocop/formatter/junit_formatter.rb#L9
         #
         # In the future, it would be preferable to return only enabled cops.
-        Cop::Cop.all.each do |cop|
+        Cop::Registry.all.each do |cop|
           target_offenses = offenses_for_cop(offenses, cop)
 
           next unless relevant_for_output?(options, target_offenses)

data/lib/rubocop/options.rb

@@ -94,7 +94,7 @@ module RuboCop
             ['']
           else
             list.split(',').map do |c|
-              Cop::Cop.qualified_cop_name(c, "--#{option} option")
+              Cop::Registry.qualified_cop_name(c, "--#{option} option")
             end
           end
       end
@@ -239,8 +239,8 @@ module RuboCop
       def validate_cop_list(names)
         return unless names
 
-        cop_names = Cop::Cop.registry.names
-        departments = Cop::Cop.registry.departments.map(&:to_s)
+        cop_names = Cop::Registry.global.names
+        departments = Cop::Registry.global.departments.map(&:to_s)
 
         names.each do |name|
           next if cop_names.include?(name)

data/lib/rubocop/path_util.rb

@@ -55,10 +55,25 @@ module RuboCop
     end
 
     def hidden_file_in_not_hidden_dir?(pattern, path)
-      File.fnmatch?(
-        pattern, path,
-        File::FNM_PATHNAME | File::FNM_EXTGLOB | File::FNM_DOTMATCH
-      ) && File.basename(path).start_with?('.') && !hidden_dir?(path)
+      hidden_file?(path) &&
+        File.fnmatch?(
+          pattern, path,
+          File::FNM_PATHNAME | File::FNM_EXTGLOB | File::FNM_DOTMATCH
+        ) &&
+        !hidden_dir?(path)
+    end
+
+    def hidden_file?(path)
+      maybe_hidden_file?(path) && File.basename(path).start_with?('.')
+    end
+
+    # Loose check to reduce memory allocations
+    def maybe_hidden_file?(path)
+      separator_index = path.rindex(File::SEPARATOR)
+      return false unless separator_index
+
+      dot_index = path.index('.', separator_index + 1)
+      dot_index == separator_index + 1
     end
 
     def hidden_dir?(path)

data/lib/rubocop/rake_task.rb

@@ -15,6 +15,7 @@ module RuboCop
     attr_accessor :name, :verbose, :fail_on_error, :patterns, :formatters, :requires, :options
 
     def initialize(name = :rubocop, *args, &task_block)
+      super()
       setup_ivars(name)
 
       desc 'Run RuboCop' unless ::Rake.application.last_description

data/lib/rubocop/rspec/expect_offense.rb

@@ -134,7 +134,7 @@ module RuboCop
         actual_annotations =
           expected_annotations.with_offense_annotations(offenses)
 
-        expect(actual_annotations).to eq(expected_annotations)
+        expect(actual_annotations).to eq(expected_annotations), ''
         expect(offenses.map(&:severity).uniq).to eq([severity]) if severity
       end
 

data/lib/rubocop/rspec/shared_contexts.rb

@@ -44,8 +44,6 @@ end
 RSpec.shared_context 'config', :config do # rubocop:disable Metrics/BlockLength
   ### Meant to be overridden at will
 
-  let(:source) { 'code = {some: :ruby}' }
-
   let(:cop_class) do
     unless described_class.is_a?(Class) && described_class < RuboCop::Cop::Base
       raise 'Specify which cop class to use (e.g `let(:cop_class) { RuboCop::Cop::Base }`, ' \
@@ -97,9 +95,7 @@ RSpec.shared_context 'config', :config do # rubocop:disable Metrics/BlockLength
   end
 
   let(:cop) do
-    cop_class.new(config, cop_options).tap do |cop|
-      cop.send :begin_investigation, processed_source
-    end
+    cop_class.new(config, cop_options)
   end
 end
 

data/lib/rubocop/runner.rb

@@ -306,7 +306,7 @@ module RuboCop
     def mobilized_cop_classes(config)
       @mobilized_cop_classes ||= {}
       @mobilized_cop_classes[config.object_id] ||= begin
-        cop_classes = Cop::Cop.all
+        cop_classes = Cop::Registry.all
 
         OptionsValidator.new(@options).validate_cop_options
 

data/lib/rubocop/target_finder.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'set'
-
 module RuboCop
   # This class finds target files to inspect by scanning the directory tree
   # and picking ruby files.
@@ -114,10 +112,12 @@ module RuboCop
     end
 
     def ruby_extensions
-      ext_patterns = all_cops_include.select do |pattern|
-        pattern.start_with?('**/*.')
+      @ruby_extensions ||= begin
+        ext_patterns = all_cops_include.select do |pattern|
+          pattern.start_with?('**/*.')
+        end
+        ext_patterns.map { |pattern| pattern.sub('**/*', '') }
       end
-      ext_patterns.map { |pattern| pattern.sub('**/*', '') }
     end
 
     def ruby_filename?(file)
@@ -125,14 +125,17 @@ module RuboCop
     end
 
     def ruby_filenames
-      file_patterns = all_cops_include.reject do |pattern|
-        pattern.start_with?('**/*.')
+      @ruby_filenames ||= begin
+        file_patterns = all_cops_include.reject do |pattern|
+          pattern.start_with?('**/*.')
+        end
+        file_patterns.map { |pattern| pattern.sub('**/', '') }
       end
-      file_patterns.map { |pattern| pattern.sub('**/', '') }
     end
 
     def all_cops_include
-      @config_store.for_pwd.for_all_cops['Include'].map(&:to_s)
+      @all_cops_include ||=
+        @config_store.for_pwd.for_all_cops['Include'].map(&:to_s)
     end
 
     def ruby_executable?(file)

data/lib/rubocop/version.rb

@@ -3,13 +3,13 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.88.0'
+    STRING = '0.89.1'
 
     MSG = '%<version>s (using Parser %<parser_version>s, '\
           'rubocop-ast %<rubocop_ast_version>s, ' \
           'running on %<ruby_engine>s %<ruby_version>s %<ruby_platform>s)'
 
-    def self.version(debug = false)
+    def self.version(debug: false)
       if debug
         format(MSG, version: STRING, parser_version: Parser::VERSION,
                     rubocop_ast_version: RuboCop::AST::Version::STRING,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.88.0
+  version: 0.89.1
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-07-13 00:00:00.000000000 Z
+date: 2020-08-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: parallel
@@ -94,7 +94,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.3.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
@@ -104,7 +104,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.0
+        version: 0.3.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
@@ -340,6 +340,7 @@ files:
 - lib/rubocop/cop/lint/ambiguous_regexp_literal.rb
 - lib/rubocop/cop/lint/assignment_in_condition.rb
 - lib/rubocop/cop/lint/big_decimal_new.rb
+- lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb
 - lib/rubocop/cop/lint/boolean_symbol.rb
 - lib/rubocop/cop/lint/circular_argument_reference.rb
 - lib/rubocop/cop/lint/constant_resolution.rb
@@ -351,8 +352,10 @@ files:
 - lib/rubocop/cop/lint/duplicate_elsif_condition.rb
 - lib/rubocop/cop/lint/duplicate_hash_key.rb
 - lib/rubocop/cop/lint/duplicate_methods.rb
+- lib/rubocop/cop/lint/duplicate_rescue_exception.rb
 - lib/rubocop/cop/lint/each_with_object_argument.rb
 - lib/rubocop/cop/lint/else_layout.rb
+- lib/rubocop/cop/lint/empty_conditional_body.rb
 - lib/rubocop/cop/lint/empty_ensure.rb
 - lib/rubocop/cop/lint/empty_expression.rb
 - lib/rubocop/cop/lint/empty_interpolation.rb
@@ -360,6 +363,7 @@ files:
 - lib/rubocop/cop/lint/ensure_return.rb
 - lib/rubocop/cop/lint/erb_new_arguments.rb
 - lib/rubocop/cop/lint/flip_flop.rb
+- lib/rubocop/cop/lint/float_comparison.rb
 - lib/rubocop/cop/lint/float_out_of_range.rb
 - lib/rubocop/cop/lint/format_parameter_mismatch.rb
 - lib/rubocop/cop/lint/heredoc_method_call_position.rb
@@ -371,6 +375,7 @@ files:
 - lib/rubocop/cop/lint/literal_in_interpolation.rb
 - lib/rubocop/cop/lint/loop.rb
 - lib/rubocop/cop/lint/missing_cop_enable_directive.rb
+- lib/rubocop/cop/lint/missing_super.rb
 - lib/rubocop/cop/lint/mixed_regexp_capture_types.rb
 - lib/rubocop/cop/lint/multiple_comparison.rb
 - lib/rubocop/cop/lint/nested_method_definition.rb
@@ -380,6 +385,7 @@ files:
 - lib/rubocop/cop/lint/non_local_exit_from_iterator.rb
 - lib/rubocop/cop/lint/number_conversion.rb
 - lib/rubocop/cop/lint/ordered_magic_comments.rb
+- lib/rubocop/cop/lint/out_of_range_regexp_ref.rb
 - lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb
 - lib/rubocop/cop/lint/percent_string_array.rb
 - lib/rubocop/cop/lint/percent_symbol_array.rb
@@ -401,6 +407,7 @@ files:
 - lib/rubocop/cop/lint/safe_navigation_consistency.rb
 - lib/rubocop/cop/lint/safe_navigation_with_empty.rb
 - lib/rubocop/cop/lint/script_permission.rb
+- lib/rubocop/cop/lint/self_assignment.rb
 - lib/rubocop/cop/lint/send_with_mixin_argument.rb
 - lib/rubocop/cop/lint/shadowed_argument.rb
 - lib/rubocop/cop/lint/shadowed_exception.rb
@@ -409,16 +416,17 @@ files:
 - lib/rubocop/cop/lint/suppressed_exception.rb
 - lib/rubocop/cop/lint/syntax.rb
 - lib/rubocop/cop/lint/to_json.rb
+- lib/rubocop/cop/lint/top_level_return_with_argument.rb
 - lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb
 - lib/rubocop/cop/lint/unified_integer.rb
 - lib/rubocop/cop/lint/unreachable_code.rb
+- lib/rubocop/cop/lint/unreachable_loop.rb
 - lib/rubocop/cop/lint/unused_block_argument.rb
 - lib/rubocop/cop/lint/unused_method_argument.rb
 - lib/rubocop/cop/lint/uri_escape_unescape.rb
 - lib/rubocop/cop/lint/uri_regexp.rb
 - lib/rubocop/cop/lint/useless_access_modifier.rb
 - lib/rubocop/cop/lint/useless_assignment.rb
-- lib/rubocop/cop/lint/useless_comparison.rb
 - lib/rubocop/cop/lint/useless_else_without_rescue.rb
 - lib/rubocop/cop/lint/useless_setter_call.rb
 - lib/rubocop/cop/lint/void.rb
@@ -435,6 +443,7 @@ files:
 - lib/rubocop/cop/metrics/utils/abc_size_calculator.rb
 - lib/rubocop/cop/metrics/utils/code_length_calculator.rb
 - lib/rubocop/cop/metrics/utils/iterating_block.rb
+- lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb
 - lib/rubocop/cop/migration/department_name.rb
 - lib/rubocop/cop/mixin/alignment.rb
 - lib/rubocop/cop/mixin/allowed_methods.rb
@@ -480,7 +489,6 @@ files:
 - lib/rubocop/cop/mixin/on_normal_if_unless.rb
 - lib/rubocop/cop/mixin/ordered_gem_node.rb
 - lib/rubocop/cop/mixin/parentheses.rb
-- lib/rubocop/cop/mixin/parser_diagnostic.rb
 - lib/rubocop/cop/mixin/percent_array.rb
 - lib/rubocop/cop/mixin/percent_literal.rb
 - lib/rubocop/cop/mixin/preceding_following_alignment.rb
@@ -497,7 +505,6 @@ files:
 - lib/rubocop/cop/mixin/string_literals_help.rb
 - lib/rubocop/cop/mixin/surrounding_space.rb
 - lib/rubocop/cop/mixin/target_ruby_version.rb
-- lib/rubocop/cop/mixin/too_many_lines.rb
 - lib/rubocop/cop/mixin/trailing_body.rb
 - lib/rubocop/cop/mixin/trailing_comma.rb
 - lib/rubocop/cop/mixin/uncommunicative_name.rb
@@ -578,12 +585,14 @@ files:
 - lib/rubocop/cop/style/eval_with_location.rb
 - lib/rubocop/cop/style/even_odd.rb
 - lib/rubocop/cop/style/expand_path_arguments.rb
+- lib/rubocop/cop/style/explicit_block_argument.rb
 - lib/rubocop/cop/style/exponential_notation.rb
 - lib/rubocop/cop/style/float_division.rb
 - lib/rubocop/cop/style/for.rb
 - lib/rubocop/cop/style/format_string.rb
 - lib/rubocop/cop/style/format_string_token.rb
 - lib/rubocop/cop/style/frozen_string_literal_comment.rb
+- lib/rubocop/cop/style/global_std_stream.rb
 - lib/rubocop/cop/style/global_vars.rb
 - lib/rubocop/cop/style/guard_clause.rb
 - lib/rubocop/cop/style/hash_as_last_array_item.rb
@@ -611,7 +620,6 @@ files:
 - lib/rubocop/cop/style/method_call_without_args_parentheses.rb
 - lib/rubocop/cop/style/method_called_on_do_end_block.rb
 - lib/rubocop/cop/style/method_def_parentheses.rb
-- lib/rubocop/cop/style/method_missing_super.rb
 - lib/rubocop/cop/style/min_max.rb
 - lib/rubocop/cop/style/missing_else.rb
 - lib/rubocop/cop/style/missing_respond_to_missing.rb
@@ -643,6 +651,7 @@ files:
 - lib/rubocop/cop/style/one_line_conditional.rb
 - lib/rubocop/cop/style/option_hash.rb
 - lib/rubocop/cop/style/optional_arguments.rb
+- lib/rubocop/cop/style/optional_boolean_parameter.rb
 - lib/rubocop/cop/style/or_assignment.rb
 - lib/rubocop/cop/style/parallel_assignment.rb
 - lib/rubocop/cop/style/parentheses_around_condition.rb
@@ -681,12 +690,14 @@ files:
 - lib/rubocop/cop/style/semicolon.rb
 - lib/rubocop/cop/style/send.rb
 - lib/rubocop/cop/style/signal_exception.rb
+- lib/rubocop/cop/style/single_argument_dig.rb
 - lib/rubocop/cop/style/single_line_block_params.rb
 - lib/rubocop/cop/style/single_line_methods.rb
 - lib/rubocop/cop/style/slicing_with_range.rb
 - lib/rubocop/cop/style/special_global_vars.rb
 - lib/rubocop/cop/style/stabby_lambda_parentheses.rb
 - lib/rubocop/cop/style/stderr_puts.rb
+- lib/rubocop/cop/style/string_concatenation.rb
 - lib/rubocop/cop/style/string_hash_keys.rb
 - lib/rubocop/cop/style/string_literals.rb
 - lib/rubocop/cop/style/string_literals_in_interpolation.rb
@@ -717,6 +728,7 @@ files:
 - lib/rubocop/cop/style/yoda_condition.rb
 - lib/rubocop/cop/style/zero_length_predicate.rb
 - lib/rubocop/cop/team.rb
+- lib/rubocop/cop/tokens_util.rb
 - lib/rubocop/cop/util.rb
 - lib/rubocop/cop/utils/format_string.rb
 - lib/rubocop/cop/variable_force.rb
@@ -727,6 +739,7 @@ files:
 - lib/rubocop/cop/variable_force/scope.rb
 - lib/rubocop/cop/variable_force/variable.rb
 - lib/rubocop/cop/variable_force/variable_table.rb
+- lib/rubocop/cops_documentation_generator.rb
 - lib/rubocop/core_ext/string.rb
 - lib/rubocop/error.rb
 - lib/rubocop/ext/processed_source.rb

data/lib/rubocop/cop/lint/useless_comparison.rb

@@ -1,28 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Lint
-      # This cop checks for comparison of something with itself.
-      #
-      # @example
-      #
-      #   # bad
-      #
-      #   x.top >= x.top
-      class UselessComparison < Cop
-        MSG = 'Comparison of something with itself detected.'
-        OPS = %w[== === != < > <= >= <=>].freeze
-
-        def_node_matcher :useless_comparison?,
-                         "(send $_match {:#{OPS.join(' :')}} $_match)"
-
-        def on_send(node)
-          return unless useless_comparison?(node)
-
-          add_offense(node, location: :selector)
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/mixin/parser_diagnostic.rb

@@ -1,37 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    # Common functionality for cops which processes Parser's diagnostics.
-    # This mixin requires its user class to define `#relevant_diagnostic?`.
-    #
-    #     def relevant_diagnostic?(diagnostic)
-    #       diagnostic.reason == :my_interested_diagnostic_type
-    #     end
-    #
-    # If you want to use an alternative offense message rather than the one in
-    # Parser's diagnostic, define `#alternative_message`.
-    #
-    #     def alternative_message(diagnostic)
-    #       'My custom message'
-    #     end
-    module ParserDiagnostic
-      def investigate(processed_source)
-        processed_source.diagnostics.each do |d|
-          next unless relevant_diagnostic?(d)
-
-          message = if respond_to?(:alternative_message, true)
-                      alternative_message(d)
-                    else
-                      d.message.capitalize
-                    end
-
-          add_offense(find_offense_node_by(d),
-                      location: d.location,
-                      message: message,
-                      severity: d.level)
-        end
-      end
-    end
-  end
-end