rubocop 0.88.0 → 0.89.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (320) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +1 -1
  3. data/bin/rubocop-profile +1 -0
  4. data/config/default.yml +96 -16
  5. data/lib/rubocop.rb +16 -4
  6. data/lib/rubocop/cli/command/auto_genenerate_config.rb +1 -1
  7. data/lib/rubocop/cli/command/base.rb +1 -0
  8. data/lib/rubocop/cli/command/execute_runner.rb +1 -1
  9. data/lib/rubocop/cli/command/show_cops.rb +2 -2
  10. data/lib/rubocop/cli/command/version.rb +2 -2
  11. data/lib/rubocop/comment_config.rb +5 -7
  12. data/lib/rubocop/config.rb +20 -3
  13. data/lib/rubocop/config_loader.rb +2 -2
  14. data/lib/rubocop/config_loader_resolver.rb +3 -3
  15. data/lib/rubocop/config_obsoletion.rb +6 -1
  16. data/lib/rubocop/config_validator.rb +2 -4
  17. data/lib/rubocop/cop/base.rb +2 -2
  18. data/lib/rubocop/cop/commissioner.rb +0 -1
  19. data/lib/rubocop/cop/correctors/line_break_corrector.rb +4 -4
  20. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +2 -2
  21. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
  22. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +15 -18
  23. data/lib/rubocop/cop/force.rb +1 -0
  24. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +32 -11
  25. data/lib/rubocop/cop/generator/configuration_injector.rb +2 -2
  26. data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +4 -12
  27. data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +1 -1
  28. data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +8 -8
  29. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +10 -7
  30. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +7 -8
  31. data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +2 -2
  32. data/lib/rubocop/cop/layout/block_alignment.rb +1 -1
  33. data/lib/rubocop/cop/layout/class_structure.rb +3 -7
  34. data/lib/rubocop/cop/layout/comment_indentation.rb +1 -1
  35. data/lib/rubocop/cop/layout/empty_lines.rb +0 -2
  36. data/lib/rubocop/cop/layout/extra_spacing.rb +22 -36
  37. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +1 -1
  38. data/lib/rubocop/cop/layout/heredoc_indentation.rb +2 -2
  39. data/lib/rubocop/cop/layout/indentation_style.rb +0 -2
  40. data/lib/rubocop/cop/layout/leading_comment_space.rb +1 -1
  41. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +1 -1
  42. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +0 -2
  43. data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +9 -1
  44. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +7 -4
  45. data/lib/rubocop/cop/lint/ambiguous_operator.rb +15 -10
  46. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +11 -13
  47. data/lib/rubocop/cop/lint/assignment_in_condition.rb +2 -2
  48. data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -10
  49. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +50 -0
  50. data/lib/rubocop/cop/lint/boolean_symbol.rb +16 -11
  51. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  52. data/lib/rubocop/cop/lint/constant_resolution.rb +1 -1
  53. data/lib/rubocop/cop/lint/debugger.rb +7 -1
  54. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +9 -10
  55. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +17 -13
  56. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  57. data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
  58. data/lib/rubocop/cop/lint/duplicate_methods.rb +7 -4
  59. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +60 -0
  60. data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
  61. data/lib/rubocop/cop/lint/else_layout.rb +1 -1
  62. data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
  63. data/lib/rubocop/cop/lint/empty_ensure.rb +5 -5
  64. data/lib/rubocop/cop/lint/empty_expression.rb +2 -2
  65. data/lib/rubocop/cop/lint/empty_interpolation.rb +5 -6
  66. data/lib/rubocop/cop/lint/empty_when.rb +2 -2
  67. data/lib/rubocop/cop/lint/ensure_return.rb +27 -29
  68. data/lib/rubocop/cop/lint/erb_new_arguments.rb +11 -10
  69. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  70. data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
  71. data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
  72. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +5 -4
  73. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +13 -14
  74. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +2 -2
  75. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +8 -8
  76. data/lib/rubocop/cop/lint/inherit_exception.rb +12 -7
  77. data/lib/rubocop/cop/lint/interpolation_check.rb +18 -15
  78. data/lib/rubocop/cop/lint/literal_as_condition.rb +4 -2
  79. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +7 -7
  80. data/lib/rubocop/cop/lint/loop.rb +23 -2
  81. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +6 -5
  82. data/lib/rubocop/cop/lint/missing_super.rb +99 -0
  83. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -1
  84. data/lib/rubocop/cop/lint/multiple_comparison.rb +6 -9
  85. data/lib/rubocop/cop/lint/nested_method_definition.rb +1 -1
  86. data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
  87. data/lib/rubocop/cop/lint/next_without_accumulator.rb +1 -1
  88. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +27 -23
  89. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +2 -2
  90. data/lib/rubocop/cop/lint/number_conversion.rb +6 -9
  91. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +11 -13
  92. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +90 -0
  93. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +4 -10
  94. data/lib/rubocop/cop/lint/percent_string_array.rb +13 -12
  95. data/lib/rubocop/cop/lint/percent_symbol_array.rb +13 -12
  96. data/lib/rubocop/cop/lint/raise_exception.rb +12 -10
  97. data/lib/rubocop/cop/lint/rand_one.rb +2 -2
  98. data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +16 -19
  99. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +7 -11
  100. data/lib/rubocop/cop/lint/redundant_require_statement.rb +4 -7
  101. data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +13 -9
  102. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +6 -13
  103. data/lib/rubocop/cop/lint/redundant_with_index.rb +11 -14
  104. data/lib/rubocop/cop/lint/redundant_with_object.rb +11 -14
  105. data/lib/rubocop/cop/lint/regexp_as_condition.rb +4 -6
  106. data/lib/rubocop/cop/lint/require_parentheses.rb +2 -2
  107. data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
  108. data/lib/rubocop/cop/lint/rescue_type.rb +8 -8
  109. data/lib/rubocop/cop/lint/return_in_void_context.rb +2 -4
  110. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +3 -6
  111. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +14 -10
  112. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +7 -7
  113. data/lib/rubocop/cop/lint/script_permission.rb +10 -7
  114. data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
  115. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +5 -11
  116. data/lib/rubocop/cop/lint/shadowed_argument.rb +3 -3
  117. data/lib/rubocop/cop/lint/shadowed_exception.rb +2 -2
  118. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +3 -3
  119. data/lib/rubocop/cop/lint/struct_new_override.rb +1 -1
  120. data/lib/rubocop/cop/lint/suppressed_exception.rb +4 -7
  121. data/lib/rubocop/cop/lint/to_json.rb +4 -6
  122. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
  123. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +4 -4
  124. data/lib/rubocop/cop/lint/unified_integer.rb +4 -6
  125. data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
  126. data/lib/rubocop/cop/lint/unreachable_loop.rb +174 -0
  127. data/lib/rubocop/cop/lint/unused_block_argument.rb +8 -3
  128. data/lib/rubocop/cop/lint/unused_method_argument.rb +8 -3
  129. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
  130. data/lib/rubocop/cop/lint/uri_regexp.rb +11 -47
  131. data/lib/rubocop/cop/lint/useless_access_modifier.rb +25 -15
  132. data/lib/rubocop/cop/lint/useless_assignment.rb +4 -4
  133. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +6 -15
  134. data/lib/rubocop/cop/lint/useless_setter_call.rb +4 -6
  135. data/lib/rubocop/cop/lint/void.rb +3 -7
  136. data/lib/rubocop/cop/metrics/abc_size.rb +1 -1
  137. data/lib/rubocop/cop/metrics/block_length.rb +2 -2
  138. data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
  139. data/lib/rubocop/cop/metrics/class_length.rb +2 -2
  140. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +2 -1
  141. data/lib/rubocop/cop/metrics/method_length.rb +2 -2
  142. data/lib/rubocop/cop/metrics/module_length.rb +2 -2
  143. data/lib/rubocop/cop/metrics/parameter_lists.rb +2 -6
  144. data/lib/rubocop/cop/metrics/perceived_complexity.rb +7 -8
  145. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +48 -5
  146. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +52 -24
  147. data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +37 -0
  148. data/lib/rubocop/cop/migration/department_name.rb +14 -16
  149. data/lib/rubocop/cop/mixin/alignment.rb +2 -1
  150. data/lib/rubocop/cop/mixin/array_min_size.rb +1 -1
  151. data/lib/rubocop/cop/mixin/check_line_breakable.rb +2 -2
  152. data/lib/rubocop/cop/mixin/code_length.rb +22 -5
  153. data/lib/rubocop/cop/mixin/hash_transform_method.rb +5 -11
  154. data/lib/rubocop/cop/mixin/line_length_help.rb +1 -3
  155. data/lib/rubocop/cop/mixin/method_complexity.rb +10 -2
  156. data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +1 -2
  157. data/lib/rubocop/cop/mixin/percent_array.rb +2 -6
  158. data/lib/rubocop/cop/mixin/range_help.rb +18 -4
  159. data/lib/rubocop/cop/mixin/statement_modifier.rb +37 -8
  160. data/lib/rubocop/cop/mixin/surrounding_space.rb +0 -25
  161. data/lib/rubocop/cop/mixin/trailing_comma.rb +2 -4
  162. data/lib/rubocop/cop/mixin/uncommunicative_name.rb +6 -13
  163. data/lib/rubocop/cop/mixin/unused_argument.rb +4 -6
  164. data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
  165. data/lib/rubocop/cop/naming/ascii_identifiers.rb +3 -3
  166. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
  167. data/lib/rubocop/cop/naming/block_parameter_name.rb +1 -1
  168. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +2 -2
  169. data/lib/rubocop/cop/naming/constant_name.rb +2 -2
  170. data/lib/rubocop/cop/naming/file_name.rb +3 -3
  171. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +2 -2
  172. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +2 -2
  173. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +2 -2
  174. data/lib/rubocop/cop/naming/method_parameter_name.rb +1 -1
  175. data/lib/rubocop/cop/naming/predicate_name.rb +3 -5
  176. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +12 -11
  177. data/lib/rubocop/cop/registry.rb +3 -3
  178. data/lib/rubocop/cop/security/eval.rb +2 -2
  179. data/lib/rubocop/cop/security/json_load.rb +6 -8
  180. data/lib/rubocop/cop/security/marshal_load.rb +2 -4
  181. data/lib/rubocop/cop/security/open.rb +2 -2
  182. data/lib/rubocop/cop/security/yaml_load.rb +6 -6
  183. data/lib/rubocop/cop/style/access_modifier_declarations.rb +16 -9
  184. data/lib/rubocop/cop/style/accessor_grouping.rb +23 -21
  185. data/lib/rubocop/cop/style/alias.rb +41 -36
  186. data/lib/rubocop/cop/style/and_or.rb +9 -11
  187. data/lib/rubocop/cop/style/array_join.rb +6 -8
  188. data/lib/rubocop/cop/style/ascii_comments.rb +4 -4
  189. data/lib/rubocop/cop/style/attr.rb +11 -9
  190. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +2 -5
  191. data/lib/rubocop/cop/style/bare_percent_literals.rb +10 -12
  192. data/lib/rubocop/cop/style/begin_block.rb +2 -2
  193. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +9 -14
  194. data/lib/rubocop/cop/style/block_comments.rb +14 -18
  195. data/lib/rubocop/cop/style/block_delimiters.rb +23 -23
  196. data/lib/rubocop/cop/style/case_equality.rb +22 -3
  197. data/lib/rubocop/cop/style/case_like_if.rb +19 -16
  198. data/lib/rubocop/cop/style/class_and_module_children.rb +14 -11
  199. data/lib/rubocop/cop/style/class_check.rb +7 -9
  200. data/lib/rubocop/cop/style/class_methods.rb +7 -11
  201. data/lib/rubocop/cop/style/class_vars.rb +6 -10
  202. data/lib/rubocop/cop/style/collection_methods.rb +11 -17
  203. data/lib/rubocop/cop/style/colon_method_call.rb +8 -9
  204. data/lib/rubocop/cop/style/colon_method_definition.rb +6 -6
  205. data/lib/rubocop/cop/style/command_literal.rb +23 -24
  206. data/lib/rubocop/cop/style/comment_annotation.rb +15 -15
  207. data/lib/rubocop/cop/style/commented_keyword.rb +1 -1
  208. data/lib/rubocop/cop/style/conditional_assignment.rb +12 -3
  209. data/lib/rubocop/cop/style/constant_visibility.rb +3 -2
  210. data/lib/rubocop/cop/style/copyright.rb +12 -12
  211. data/lib/rubocop/cop/style/date_time.rb +1 -1
  212. data/lib/rubocop/cop/style/def_with_parentheses.rb +8 -10
  213. data/lib/rubocop/cop/style/dir.rb +7 -10
  214. data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +7 -9
  215. data/lib/rubocop/cop/style/documentation.rb +6 -8
  216. data/lib/rubocop/cop/style/documentation_method.rb +1 -1
  217. data/lib/rubocop/cop/style/double_cop_disable_directive.rb +12 -15
  218. data/lib/rubocop/cop/style/double_negation.rb +2 -2
  219. data/lib/rubocop/cop/style/each_for_simple_loop.rb +5 -8
  220. data/lib/rubocop/cop/style/each_with_object.rb +16 -19
  221. data/lib/rubocop/cop/style/empty_case_condition.rb +19 -20
  222. data/lib/rubocop/cop/style/empty_else.rb +17 -19
  223. data/lib/rubocop/cop/style/empty_literal.rb +15 -16
  224. data/lib/rubocop/cop/style/empty_method.rb +10 -13
  225. data/lib/rubocop/cop/style/encoding.rb +5 -9
  226. data/lib/rubocop/cop/style/end_block.rb +4 -6
  227. data/lib/rubocop/cop/style/eval_with_location.rb +9 -7
  228. data/lib/rubocop/cop/style/even_odd.rb +7 -11
  229. data/lib/rubocop/cop/style/expand_path_arguments.rb +21 -20
  230. data/lib/rubocop/cop/style/explicit_block_argument.rb +102 -0
  231. data/lib/rubocop/cop/style/exponential_notation.rb +1 -1
  232. data/lib/rubocop/cop/style/float_division.rb +1 -1
  233. data/lib/rubocop/cop/style/for.rb +11 -15
  234. data/lib/rubocop/cop/style/format_string.rb +21 -19
  235. data/lib/rubocop/cop/style/format_string_token.rb +5 -7
  236. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +19 -41
  237. data/lib/rubocop/cop/style/global_std_stream.rb +65 -0
  238. data/lib/rubocop/cop/style/global_vars.rb +2 -2
  239. data/lib/rubocop/cop/style/guard_clause.rb +5 -6
  240. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +8 -1
  241. data/lib/rubocop/cop/style/hash_each_methods.rb +5 -8
  242. data/lib/rubocop/cop/style/hash_syntax.rb +4 -3
  243. data/lib/rubocop/cop/style/hash_transform_keys.rb +3 -2
  244. data/lib/rubocop/cop/style/hash_transform_values.rb +2 -1
  245. data/lib/rubocop/cop/style/identical_conditional_branches.rb +2 -2
  246. data/lib/rubocop/cop/style/if_inside_else.rb +3 -3
  247. data/lib/rubocop/cop/style/if_unless_modifier.rb +10 -32
  248. data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +3 -7
  249. data/lib/rubocop/cop/style/if_with_semicolon.rb +3 -6
  250. data/lib/rubocop/cop/style/implicit_runtime_error.rb +1 -1
  251. data/lib/rubocop/cop/style/infinite_loop.rb +24 -24
  252. data/lib/rubocop/cop/style/inline_comment.rb +3 -3
  253. data/lib/rubocop/cop/style/inverse_methods.rb +22 -32
  254. data/lib/rubocop/cop/style/lambda.rb +7 -12
  255. data/lib/rubocop/cop/style/lambda_call.rb +14 -13
  256. data/lib/rubocop/cop/style/line_end_concatenation.rb +19 -16
  257. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +2 -1
  258. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +16 -11
  259. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +4 -8
  260. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +8 -7
  261. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +2 -2
  262. data/lib/rubocop/cop/style/method_def_parentheses.rb +11 -16
  263. data/lib/rubocop/cop/style/min_max.rb +8 -12
  264. data/lib/rubocop/cop/style/missing_else.rb +13 -13
  265. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +10 -3
  266. data/lib/rubocop/cop/style/mixin_grouping.rb +24 -27
  267. data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
  268. data/lib/rubocop/cop/style/module_function.rb +10 -13
  269. data/lib/rubocop/cop/style/multiline_if_modifier.rb +3 -10
  270. data/lib/rubocop/cop/style/multiline_if_then.rb +4 -10
  271. data/lib/rubocop/cop/style/multiline_memoization.rb +14 -12
  272. data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
  273. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +4 -6
  274. data/lib/rubocop/cop/style/multiline_when_then.rb +7 -9
  275. data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
  276. data/lib/rubocop/cop/style/mutable_constant.rb +23 -20
  277. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +3 -1
  278. data/lib/rubocop/cop/style/numeric_predicate.rb +4 -0
  279. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +42 -0
  280. data/lib/rubocop/cop/style/parallel_assignment.rb +2 -2
  281. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +2 -2
  282. data/lib/rubocop/cop/style/random_with_offset.rb +1 -0
  283. data/lib/rubocop/cop/style/redundant_condition.rb +15 -3
  284. data/lib/rubocop/cop/style/redundant_exception.rb +4 -0
  285. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +9 -9
  286. data/lib/rubocop/cop/style/redundant_sort.rb +23 -10
  287. data/lib/rubocop/cop/style/safe_navigation.rb +4 -4
  288. data/lib/rubocop/cop/style/signal_exception.rb +2 -0
  289. data/lib/rubocop/cop/style/single_argument_dig.rb +54 -0
  290. data/lib/rubocop/cop/style/single_line_methods.rb +1 -1
  291. data/lib/rubocop/cop/style/string_concatenation.rb +92 -0
  292. data/lib/rubocop/cop/style/struct_inheritance.rb +1 -1
  293. data/lib/rubocop/cop/style/symbol_array.rb +1 -1
  294. data/lib/rubocop/cop/style/symbol_proc.rb +1 -1
  295. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +1 -1
  296. data/lib/rubocop/cop/style/zero_length_predicate.rb +10 -6
  297. data/lib/rubocop/cop/team.rb +1 -1
  298. data/lib/rubocop/cop/tokens_util.rb +84 -0
  299. data/lib/rubocop/cop/util.rb +3 -13
  300. data/lib/rubocop/cop/variable_force.rb +0 -2
  301. data/lib/rubocop/cop/variable_force/branch.rb +1 -0
  302. data/lib/rubocop/cop/variable_force/variable.rb +2 -2
  303. data/lib/rubocop/cops_documentation_generator.rb +282 -0
  304. data/lib/rubocop/error.rb +1 -0
  305. data/lib/rubocop/formatter/disabled_config_formatter.rb +1 -1
  306. data/lib/rubocop/formatter/formatter_set.rb +1 -0
  307. data/lib/rubocop/formatter/junit_formatter.rb +1 -1
  308. data/lib/rubocop/options.rb +3 -3
  309. data/lib/rubocop/path_util.rb +19 -4
  310. data/lib/rubocop/rake_task.rb +1 -0
  311. data/lib/rubocop/rspec/expect_offense.rb +1 -1
  312. data/lib/rubocop/rspec/shared_contexts.rb +1 -5
  313. data/lib/rubocop/runner.rb +1 -1
  314. data/lib/rubocop/target_finder.rb +12 -9
  315. data/lib/rubocop/version.rb +2 -2
  316. metadata +21 -8
  317. data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
  318. data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
  319. data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -25
  320. data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
@@ -22,20 +22,16 @@ module RuboCop
22
22
  # if running?
23
23
  # tired? ? 'stop' : 'go faster'
24
24
  # end
25
- class IfUnlessModifierOfIfUnless < Cop
25
+ class IfUnlessModifierOfIfUnless < Base
26
26
  include StatementModifier
27
+ extend AutoCorrector
27
28
 
28
29
  MSG = 'Avoid modifier `%<keyword>s` after another conditional.'
29
30
 
30
31
  def on_if(node)
31
32
  return unless node.modifier_form? && node.body.if_type?
32
33
 
33
- add_offense(node, location: :keyword,
34
- message: format(MSG, keyword: node.keyword))
35
- end
36
-
37
- def autocorrect(node)
38
- lambda do |corrector|
34
+ add_offense(node.loc.keyword, message: format(MSG, keyword: node.keyword)) do |corrector|
39
35
  keyword = node.if? ? 'if' : 'unless'
40
36
 
41
37
  corrector.replace(node, <<~RUBY.chop)
@@ -13,8 +13,9 @@ module RuboCop
13
13
  # # good
14
14
  # result = some_condition ? something : another_thing
15
15
  #
16
- class IfWithSemicolon < Cop
16
+ class IfWithSemicolon < Base
17
17
  include OnNormalIfUnless
18
+ extend AutoCorrector
18
19
 
19
20
  MSG = 'Do not use if x; Use the ternary operator instead.'
20
21
 
@@ -24,11 +25,7 @@ module RuboCop
24
25
  beginning = node.loc.begin
25
26
  return unless beginning&.is?(';')
26
27
 
27
- add_offense(node)
28
- end
29
-
30
- def autocorrect(node)
31
- lambda do |corrector|
28
+ add_offense(node) do |corrector|
32
29
  corrector.replace(node, correct_to_ternary(node))
33
30
  end
34
31
  end
@@ -14,7 +14,7 @@ module RuboCop
14
14
  #
15
15
  # # good
16
16
  # raise ArgumentError, 'Error message here'
17
- class ImplicitRuntimeError < Cop
17
+ class ImplicitRuntimeError < Base
18
18
  MSG = 'Use `%<method>s` with an explicit exception class and message,' \
19
19
  ' rather than just a message.'
20
20
 
@@ -15,13 +15,15 @@ module RuboCop
15
15
  # loop do
16
16
  # work
17
17
  # end
18
- class InfiniteLoop < Cop
18
+ class InfiniteLoop < Base
19
+ extend AutoCorrector
20
+
19
21
  LEADING_SPACE = /\A(\s*)/.freeze
20
22
 
21
23
  MSG = 'Use `Kernel#loop` for infinite loops.'
22
24
 
23
- def join_force?(force_class)
24
- force_class == VariableForce
25
+ def self.joining_forces
26
+ VariableForce
25
27
  end
26
28
 
27
29
  def after_leaving_scope(scope, _variable_table)
@@ -40,16 +42,6 @@ module RuboCop
40
42
  alias on_while_post on_while
41
43
  alias on_until_post on_until
42
44
 
43
- def autocorrect(node)
44
- if node.while_post_type? || node.until_post_type?
45
- replace_begin_end_with_modifier(node)
46
- elsif node.modifier_form?
47
- replace_source(node.source_range, modifier_replacement(node))
48
- else
49
- replace_source(non_modifier_range(node), 'loop do')
50
- end
51
- end
52
-
53
45
  private
54
46
 
55
47
  def while_or_until(node)
@@ -66,7 +58,19 @@ module RuboCop
66
58
  referenced_after_loop?(var, range)
67
59
  end
68
60
 
69
- add_offense(node, location: :keyword)
61
+ add_offense(node.loc.keyword) do |corrector|
62
+ autocorrect(corrector, node)
63
+ end
64
+ end
65
+
66
+ def autocorrect(corrector, node)
67
+ if node.while_post_type? || node.until_post_type?
68
+ replace_begin_end_with_modifier(corrector, node)
69
+ elsif node.modifier_form?
70
+ replace_source(corrector, node.source_range, modifier_replacement(node))
71
+ else
72
+ replace_source(corrector, non_modifier_range(node), 'loop do')
73
+ end
70
74
  end
71
75
 
72
76
  def assigned_inside_loop?(var, range)
@@ -83,23 +87,19 @@ module RuboCop
83
87
  var.references.any? { |r| r.node.source_range.begin_pos > e }
84
88
  end
85
89
 
86
- def replace_begin_end_with_modifier(node)
87
- lambda do |corrector|
88
- corrector.replace(node.body.loc.begin, 'loop do')
89
- corrector.remove(node.body.loc.end.end.join(node.source_range.end))
90
- end
90
+ def replace_begin_end_with_modifier(corrector, node)
91
+ corrector.replace(node.body.loc.begin, 'loop do')
92
+ corrector.remove(node.body.loc.end.end.join(node.source_range.end))
91
93
  end
92
94
 
93
- def replace_source(range, replacement)
94
- lambda do |corrector|
95
- corrector.replace(range, replacement)
96
- end
95
+ def replace_source(corrector, range, replacement)
96
+ corrector.replace(range, replacement)
97
97
  end
98
98
 
99
99
  def modifier_replacement(node)
100
100
  body = node.body
101
101
  if node.single_line?
102
- 'loop { ' + body.source + ' }'
102
+ "loop { #{body.source} }"
103
103
  else
104
104
  indentation = body.source_range.source_line[LEADING_SPACE]
105
105
 
@@ -17,11 +17,11 @@ module RuboCop
17
17
  # foo.each do |f|
18
18
  # f.bar # Trailing inline comment
19
19
  # end
20
- class InlineComment < Cop
20
+ class InlineComment < Base
21
21
  MSG = 'Avoid trailing inline comments.'
22
22
 
23
- def investigate(processed_source)
24
- processed_source.each_comment do |comment|
23
+ def on_new_investigation
24
+ processed_source.comments.each do |comment|
25
25
  next if comment_line?(processed_source[comment.loc.line - 1]) ||
26
26
  comment.text.match?(/\A# rubocop:(enable|disable)/)
27
27
 
@@ -33,9 +33,10 @@ module RuboCop
33
33
  # next if f.zero?
34
34
  # f != 1
35
35
  # end
36
- class InverseMethods < Cop
36
+ class InverseMethods < Base
37
37
  include IgnoredNode
38
38
  include RangeHelp
39
+ extend AutoCorrector
39
40
 
40
41
  MSG = 'Use `%<inverse>s` instead of inverting `%<method>s`.'
41
42
  CLASS_COMPARISON_METHODS = %i[<= >= < >].freeze
@@ -64,16 +65,15 @@ module RuboCop
64
65
  PATTERN
65
66
 
66
67
  def on_send(node)
67
- return if part_of_ignored_node?(node)
68
-
69
68
  inverse_candidate?(node) do |_method_call, lhs, method, rhs|
70
69
  return unless inverse_methods.key?(method)
71
- return if possible_class_hierarchy_check?(lhs, rhs, method)
72
70
  return if negated?(node)
71
+ return if part_of_ignored_node?(node)
72
+ return if possible_class_hierarchy_check?(lhs, rhs, method)
73
73
 
74
- add_offense(node,
75
- message: format(MSG, method: method,
76
- inverse: inverse_methods[method]))
74
+ add_offense(node, message: message(method, inverse_methods[method])) do |corrector|
75
+ correct_inverse_method(corrector, node)
76
+ end
77
77
  end
78
78
  end
79
79
 
@@ -87,40 +87,28 @@ module RuboCop
87
87
  # offense, such as `y.reject { |key, _value| !(key =~ /c\d/) }`,
88
88
  # can cause auto-correction to apply improper corrections.
89
89
  ignore_node(block)
90
- add_offense(node,
91
- message: format(MSG, method: method,
92
- inverse: inverse_blocks[method]))
90
+ add_offense(node, message: message(method, inverse_blocks[method])) do |corrector|
91
+ correct_inverse_block(corrector, node)
92
+ end
93
93
  end
94
94
  end
95
95
 
96
- def autocorrect(node)
97
- if node.block_type?
98
- correct_inverse_block(node)
99
- elsif node.send_type?
100
- correct_inverse_method(node)
101
- end
102
- end
96
+ private
103
97
 
104
- def correct_inverse_method(node)
98
+ def correct_inverse_method(corrector, node)
105
99
  method_call, _lhs, method, _rhs = inverse_candidate?(node)
106
100
  return unless method_call && method
107
101
 
108
- lambda do |corrector|
109
- corrector.remove(not_to_receiver(node, method_call))
110
- corrector.replace(method_call.loc.selector,
111
- inverse_methods[method].to_s)
112
- remove_end_parenthesis(corrector, node, method, method_call)
113
- end
102
+ corrector.remove(not_to_receiver(node, method_call))
103
+ corrector.replace(method_call.loc.selector, inverse_methods[method].to_s)
104
+ remove_end_parenthesis(corrector, node, method, method_call)
114
105
  end
115
106
 
116
- def correct_inverse_block(node)
107
+ def correct_inverse_block(corrector, node)
117
108
  method_call, method, block = inverse_block?(node)
118
109
 
119
- lambda do |corrector|
120
- corrector.replace(method_call.loc.selector,
121
- inverse_blocks[method].to_s)
122
- correct_inverse_selector(block, corrector)
123
- end
110
+ corrector.replace(method_call.loc.selector, inverse_blocks[method].to_s)
111
+ correct_inverse_selector(block, corrector)
124
112
  end
125
113
 
126
114
  def correct_inverse_selector(block, corrector)
@@ -140,8 +128,6 @@ module RuboCop
140
128
  end
141
129
  end
142
130
 
143
- private
144
-
145
131
  def inverse_methods
146
132
  @inverse_methods ||= cop_config['InverseMethods']
147
133
  .merge(cop_config['InverseMethods'].invert)
@@ -191,6 +177,10 @@ module RuboCop
191
177
 
192
178
  corrector.remove(end_parentheses(node, method_call))
193
179
  end
180
+
181
+ def message(method, inverse)
182
+ format(MSG, method: method, inverse: inverse)
183
+ end
194
184
  end
195
185
  end
196
186
  end
@@ -46,8 +46,9 @@ module RuboCop
46
46
  # f = ->(x) do
47
47
  # x
48
48
  # end
49
- class Lambda < Cop
49
+ class Lambda < Base
50
50
  include ConfigurableEnforcedStyle
51
+ extend AutoCorrector
51
52
 
52
53
  LITERAL_MESSAGE = 'Use the `-> { ... }` lambda literal syntax for ' \
53
54
  '%<modifier>s lambdas.'
@@ -69,21 +70,15 @@ module RuboCop
69
70
 
70
71
  return unless offending_selector?(node, selector)
71
72
 
72
- add_offense(node,
73
- location: node.send_node.source_range,
74
- message: message(node, selector))
75
- end
76
- alias on_numblock on_block
77
-
78
- def autocorrect(node)
79
- if node.send_node.source == 'lambda'
80
- lambda do |corrector|
73
+ add_offense(node.send_node.source_range, message: message(node, selector)) do |corrector|
74
+ if node.send_node.source == 'lambda'
81
75
  autocorrect_method_to_literal(corrector, node)
76
+ else
77
+ LambdaLiteralToMethodCorrector.new(node).call(corrector)
82
78
  end
83
- else
84
- LambdaLiteralToMethodCorrector.new(node)
85
79
  end
86
80
  end
81
+ alias on_numblock on_block
87
82
 
88
83
  private
89
84
 
@@ -18,30 +18,31 @@ module RuboCop
18
18
  #
19
19
  # # good
20
20
  # lambda.(x, y)
21
- class LambdaCall < Cop
21
+ class LambdaCall < Base
22
22
  include ConfigurableEnforcedStyle
23
+ extend AutoCorrector
23
24
 
24
25
  def on_send(node)
25
26
  return unless node.receiver && node.method?(:call)
26
27
 
27
- if offense?(node)
28
- add_offense(node) { opposite_style_detected }
28
+ if offense?(node) && opposite_style_detected
29
+ add_offense(node) do |corrector|
30
+ autocorrect(corrector, node)
31
+ end
29
32
  else
30
33
  correct_style_detected
31
34
  end
32
35
  end
33
36
 
34
- def autocorrect(node)
35
- lambda do |corrector|
36
- if explicit_style?
37
- receiver = node.receiver.source
38
- replacement = node.source.sub("#{receiver}.", "#{receiver}.call")
37
+ def autocorrect(corrector, node)
38
+ if explicit_style?
39
+ receiver = node.receiver.source
40
+ replacement = node.source.sub("#{receiver}.", "#{receiver}.call")
39
41
 
40
- corrector.replace(node, replacement)
41
- else
42
- add_parentheses(node, corrector) unless node.parenthesized?
43
- corrector.remove(node.loc.selector)
44
- end
42
+ corrector.replace(node, replacement)
43
+ else
44
+ add_parentheses(node, corrector) unless node.parenthesized?
45
+ corrector.remove(node.loc.selector)
45
46
  end
46
47
  end
47
48
 
@@ -19,8 +19,9 @@ module RuboCop
19
19
  # some_str = 'ala' \
20
20
  # 'bala'
21
21
  #
22
- class LineEndConcatenation < Cop
22
+ class LineEndConcatenation < Base
23
23
  include RangeHelp
24
+ extend AutoCorrector
24
25
 
25
26
  MSG = 'Use `\\` instead of `+` or `<<` to concatenate ' \
26
27
  'those strings.'
@@ -36,25 +37,12 @@ module RuboCop
36
37
  [Style::RedundantInterpolation]
37
38
  end
38
39
 
39
- def investigate(processed_source)
40
+ def on_new_investigation
40
41
  processed_source.tokens.each_index do |index|
41
42
  check_token_set(index)
42
43
  end
43
44
  end
44
45
 
45
- def autocorrect(operator_range)
46
- # Include any trailing whitespace so we don't create a syntax error.
47
- operator_range = range_with_surrounding_space(range: operator_range,
48
- side: :right,
49
- newlines: false)
50
- one_more_char = operator_range.resize(operator_range.size + 1)
51
- # Don't create a double backslash at the end of the line, in case
52
- # there already was a backslash after the concatenation operator.
53
- operator_range = one_more_char if one_more_char.source.end_with?('\\')
54
-
55
- ->(corrector) { corrector.replace(operator_range, '\\') }
56
- end
57
-
58
46
  private
59
47
 
60
48
  def check_token_set(index)
@@ -68,7 +56,22 @@ module RuboCop
68
56
 
69
57
  return unless eligible_next_successor?(next_successor)
70
58
 
71
- add_offense(operator.pos, location: operator.pos)
59
+ add_offense(operator.pos) do |corrector|
60
+ autocorrect(corrector, operator.pos)
61
+ end
62
+ end
63
+
64
+ def autocorrect(corrector, operator_range)
65
+ # Include any trailing whitespace so we don't create a syntax error.
66
+ operator_range = range_with_surrounding_space(range: operator_range,
67
+ side: :right,
68
+ newlines: false)
69
+ one_more_char = operator_range.resize(operator_range.size + 1)
70
+ # Don't create a double backslash at the end of the line, in case
71
+ # there already was a backslash after the concatenation operator.
72
+ operator_range = one_more_char if one_more_char.source.end_with?('\\')
73
+
74
+ corrector.replace(operator_range, '\\')
72
75
  end
73
76
 
74
77
  def eligible_token_set?(predecessor, operator, successor)
@@ -143,10 +143,11 @@ module RuboCop
143
143
  #
144
144
  # # good
145
145
  # Array 1
146
- class MethodCallWithArgsParentheses < Cop
146
+ class MethodCallWithArgsParentheses < Base
147
147
  include ConfigurableEnforcedStyle
148
148
  include IgnoredMethods
149
149
  include IgnoredPattern
150
+ extend AutoCorrector
150
151
 
151
152
  def initialize(*)
152
153
  super
@@ -15,14 +15,7 @@ module RuboCop
15
15
  return if allowed_camel_case_method_call?(node)
16
16
  return if legitimate_call_with_parentheses?(node)
17
17
 
18
- add_offense(node, location: node.loc.begin.join(node.loc.end))
19
- end
20
- alias on_csend on_send
21
- alias on_super on_send
22
- alias on_yield on_send
23
-
24
- def autocorrect(node)
25
- lambda do |corrector|
18
+ add_offense(offense_range(node)) do |corrector|
26
19
  if parentheses_at_the_end_of_multiline_call?(node)
27
20
  corrector.replace(args_begin(node), ' \\')
28
21
  else
@@ -31,13 +24,20 @@ module RuboCop
31
24
  corrector.remove(node.loc.end)
32
25
  end
33
26
  end
27
+ alias on_csend on_send
28
+ alias on_super on_send
29
+ alias on_yield on_send
30
+
31
+ private
32
+
33
+ def offense_range(node)
34
+ node.loc.begin.join(node.loc.end)
35
+ end
34
36
 
35
- def message(_node = nil)
37
+ def message(_range = nil)
36
38
  'Omit parentheses for method calls with arguments.'
37
39
  end
38
40
 
39
- private
40
-
41
41
  def super_call_without_arguments?(node)
42
42
  node.super_type? && node.arguments.none?
43
43
  end
@@ -60,6 +60,7 @@ module RuboCop
60
60
  call_with_ambiguous_arguments?(node) ||
61
61
  call_in_logical_operators?(node) ||
62
62
  call_in_optional_arguments?(node) ||
63
+ call_in_single_line_inheritance?(node) ||
63
64
  allowed_multiline_call_with_parentheses?(node) ||
64
65
  allowed_chained_call_with_parentheses?(node)
65
66
  end
@@ -86,6 +87,10 @@ module RuboCop
86
87
  (node.parent.optarg_type? || node.parent.kwoptarg_type?)
87
88
  end
88
89
 
90
+ def call_in_single_line_inheritance?(node)
91
+ node.parent&.class_type? && node.parent&.single_line?
92
+ end
93
+
89
94
  def call_with_ambiguous_arguments?(node)
90
95
  call_with_braced_block?(node) ||
91
96
  call_as_argument_or_chain?(node) ||