rubocop 0.86.0 → 0.89.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/README.md +1 -1
- data/bin/rubocop-profile +32 -0
- data/config/default.yml +198 -25
- data/lib/rubocop.rb +30 -5
- data/lib/rubocop/cli.rb +2 -4
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +42 -7
- data/lib/rubocop/cli/command/base.rb +1 -0
- data/lib/rubocop/cli/command/execute_runner.rb +1 -1
- data/lib/rubocop/cli/command/show_cops.rb +3 -3
- data/lib/rubocop/cli/command/version.rb +2 -2
- data/lib/rubocop/comment_config.rb +5 -7
- data/lib/rubocop/config.rb +20 -3
- data/lib/rubocop/config_loader.rb +41 -69
- data/lib/rubocop/config_loader_resolver.rb +3 -3
- data/lib/rubocop/config_obsoletion.rb +6 -2
- data/lib/rubocop/config_store.rb +4 -0
- data/lib/rubocop/config_validator.rb +2 -4
- data/lib/rubocop/cop/autocorrect_logic.rb +14 -24
- data/lib/rubocop/cop/badge.rb +1 -1
- data/lib/rubocop/cop/base.rb +407 -0
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +10 -20
- data/lib/rubocop/cop/commissioner.rb +47 -50
- data/lib/rubocop/cop/cop.rb +85 -236
- data/lib/rubocop/cop/corrector.rb +38 -115
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +26 -0
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +2 -2
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +15 -18
- data/lib/rubocop/cop/force.rb +1 -0
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +38 -12
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +1 -1
- data/lib/rubocop/cop/generator.rb +1 -1
- data/lib/rubocop/cop/generator/configuration_injector.rb +2 -2
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +4 -12
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +11 -14
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +8 -8
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +10 -7
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +7 -8
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +2 -2
- data/lib/rubocop/cop/layout/block_alignment.rb +1 -1
- data/lib/rubocop/cop/layout/case_indentation.rb +18 -19
- data/lib/rubocop/cop/layout/class_structure.rb +5 -44
- data/lib/rubocop/cop/layout/comment_indentation.rb +1 -1
- data/lib/rubocop/cop/layout/empty_lines.rb +0 -2
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +1 -0
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +1 -8
- data/lib/rubocop/cop/layout/end_alignment.rb +3 -2
- data/lib/rubocop/cop/layout/extra_spacing.rb +22 -36
- data/lib/rubocop/cop/layout/first_argument_indentation.rb +4 -0
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +1 -1
- data/lib/rubocop/cop/layout/hash_alignment.rb +1 -2
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +2 -2
- data/lib/rubocop/cop/layout/indentation_style.rb +0 -2
- data/lib/rubocop/cop/layout/leading_comment_space.rb +1 -1
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +16 -6
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +1 -1
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +0 -2
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +22 -27
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +33 -66
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +3 -2
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +49 -0
- data/lib/rubocop/cop/legacy/corrector.rb +29 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +7 -4
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +15 -10
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +11 -13
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +2 -2
- data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -10
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +50 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +16 -11
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
- data/lib/rubocop/cop/lint/constant_resolution.rb +1 -1
- data/lib/rubocop/cop/lint/debugger.rb +7 -1
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +9 -10
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +21 -17
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +8 -2
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
- data/lib/rubocop/cop/lint/duplicate_methods.rb +9 -6
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +60 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
- data/lib/rubocop/cop/lint/else_layout.rb +1 -1
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +5 -5
- data/lib/rubocop/cop/lint/empty_expression.rb +2 -2
- data/lib/rubocop/cop/lint/empty_interpolation.rb +5 -6
- data/lib/rubocop/cop/lint/empty_when.rb +2 -2
- data/lib/rubocop/cop/lint/ensure_return.rb +27 -29
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +11 -10
- data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +5 -4
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +13 -14
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +5 -4
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +8 -8
- data/lib/rubocop/cop/lint/inherit_exception.rb +12 -7
- data/lib/rubocop/cop/lint/interpolation_check.rb +21 -5
- data/lib/rubocop/cop/lint/literal_as_condition.rb +14 -2
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +7 -7
- data/lib/rubocop/cop/lint/loop.rb +23 -2
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +6 -5
- data/lib/rubocop/cop/lint/missing_super.rb +99 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -1
- data/lib/rubocop/cop/lint/multiple_comparison.rb +6 -9
- data/lib/rubocop/cop/lint/nested_method_definition.rb +15 -21
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +1 -1
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +84 -13
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +2 -2
- data/lib/rubocop/cop/lint/number_conversion.rb +6 -9
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +11 -13
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +90 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +12 -13
- data/lib/rubocop/cop/lint/percent_string_array.rb +13 -12
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +13 -12
- data/lib/rubocop/cop/lint/raise_exception.rb +12 -10
- data/lib/rubocop/cop/lint/rand_one.rb +3 -3
- data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +41 -40
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +7 -11
- data/lib/rubocop/cop/lint/redundant_require_statement.rb +4 -7
- data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +15 -11
- data/lib/rubocop/cop/lint/redundant_string_coercion.rb +6 -13
- data/lib/rubocop/cop/lint/redundant_with_index.rb +11 -14
- data/lib/rubocop/cop/lint/redundant_with_object.rb +11 -14
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +4 -6
- data/lib/rubocop/cop/lint/require_parentheses.rb +2 -2
- data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
- data/lib/rubocop/cop/lint/rescue_type.rb +8 -8
- data/lib/rubocop/cop/lint/return_in_void_context.rb +2 -4
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +3 -6
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +14 -10
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +10 -2
- data/lib/rubocop/cop/lint/script_permission.rb +10 -7
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +5 -11
- data/lib/rubocop/cop/lint/shadowed_argument.rb +3 -3
- data/lib/rubocop/cop/lint/shadowed_exception.rb +2 -2
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +3 -3
- data/lib/rubocop/cop/lint/struct_new_override.rb +1 -1
- data/lib/rubocop/cop/lint/suppressed_exception.rb +4 -7
- data/lib/rubocop/cop/lint/syntax.rb +11 -26
- data/lib/rubocop/cop/lint/to_json.rb +4 -6
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +4 -4
- data/lib/rubocop/cop/lint/unified_integer.rb +4 -6
- data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
- data/lib/rubocop/cop/lint/unreachable_loop.rb +174 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +8 -3
- data/lib/rubocop/cop/lint/unused_method_argument.rb +9 -4
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
- data/lib/rubocop/cop/lint/uri_regexp.rb +11 -47
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +26 -16
- data/lib/rubocop/cop/lint/useless_assignment.rb +4 -4
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +6 -15
- data/lib/rubocop/cop/lint/useless_setter_call.rb +4 -6
- data/lib/rubocop/cop/lint/void.rb +3 -7
- data/lib/rubocop/cop/metrics/abc_size.rb +1 -1
- data/lib/rubocop/cop/metrics/block_length.rb +24 -2
- data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
- data/lib/rubocop/cop/metrics/class_length.rb +26 -3
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +2 -1
- data/lib/rubocop/cop/metrics/method_length.rb +25 -2
- data/lib/rubocop/cop/metrics/module_length.rb +26 -3
- data/lib/rubocop/cop/metrics/parameter_lists.rb +2 -6
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +7 -8
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +48 -5
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +157 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +37 -0
- data/lib/rubocop/cop/migration/department_name.rb +14 -16
- data/lib/rubocop/cop/mixin/alignment.rb +2 -1
- data/lib/rubocop/cop/mixin/allowed_methods.rb +19 -0
- data/lib/rubocop/cop/mixin/array_min_size.rb +1 -1
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +2 -2
- data/lib/rubocop/cop/mixin/code_length.rb +26 -5
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +1 -1
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +3 -1
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +5 -11
- data/lib/rubocop/cop/mixin/line_length_help.rb +1 -3
- data/lib/rubocop/cop/mixin/method_complexity.rb +10 -2
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +1 -2
- data/lib/rubocop/cop/mixin/nil_methods.rb +3 -5
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +6 -1
- data/lib/rubocop/cop/mixin/percent_array.rb +2 -6
- data/lib/rubocop/cop/mixin/range_help.rb +18 -4
- data/lib/rubocop/cop/mixin/statement_modifier.rb +39 -10
- data/lib/rubocop/cop/mixin/surrounding_space.rb +4 -24
- data/lib/rubocop/cop/mixin/trailing_comma.rb +2 -4
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +10 -15
- data/lib/rubocop/cop/mixin/unused_argument.rb +4 -6
- data/lib/rubocop/cop/mixin/visibility_help.rb +50 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -6
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +3 -3
- data/lib/rubocop/cop/naming/block_parameter_name.rb +1 -1
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +2 -2
- data/lib/rubocop/cop/naming/constant_name.rb +2 -2
- data/lib/rubocop/cop/naming/file_name.rb +3 -3
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +2 -2
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +2 -2
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +2 -2
- data/lib/rubocop/cop/naming/method_name.rb +1 -1
- data/lib/rubocop/cop/naming/method_parameter_name.rb +2 -2
- data/lib/rubocop/cop/naming/predicate_name.rb +6 -10
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +12 -11
- data/lib/rubocop/cop/naming/variable_name.rb +1 -1
- data/lib/rubocop/cop/naming/variable_number.rb +1 -1
- data/lib/rubocop/cop/offense.rb +16 -2
- data/lib/rubocop/cop/registry.rb +3 -3
- data/lib/rubocop/cop/security/eval.rb +2 -2
- data/lib/rubocop/cop/security/json_load.rb +6 -8
- data/lib/rubocop/cop/security/marshal_load.rb +2 -4
- data/lib/rubocop/cop/security/open.rb +2 -2
- data/lib/rubocop/cop/security/yaml_load.rb +6 -6
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +16 -9
- data/lib/rubocop/cop/style/accessor_grouping.rb +149 -0
- data/lib/rubocop/cop/style/alias.rb +41 -36
- data/lib/rubocop/cop/style/and_or.rb +9 -11
- data/lib/rubocop/cop/style/array_coercion.rb +63 -0
- data/lib/rubocop/cop/style/array_join.rb +6 -8
- data/lib/rubocop/cop/style/ascii_comments.rb +4 -4
- data/lib/rubocop/cop/style/attr.rb +11 -9
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +5 -7
- data/lib/rubocop/cop/style/bare_percent_literals.rb +10 -12
- data/lib/rubocop/cop/style/begin_block.rb +2 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +141 -0
- data/lib/rubocop/cop/style/block_comments.rb +14 -18
- data/lib/rubocop/cop/style/block_delimiters.rb +23 -23
- data/lib/rubocop/cop/style/case_equality.rb +22 -3
- data/lib/rubocop/cop/style/case_like_if.rb +220 -0
- data/lib/rubocop/cop/style/class_and_module_children.rb +14 -11
- data/lib/rubocop/cop/style/class_check.rb +7 -9
- data/lib/rubocop/cop/style/class_methods.rb +7 -11
- data/lib/rubocop/cop/style/class_vars.rb +24 -7
- data/lib/rubocop/cop/style/collection_methods.rb +11 -17
- data/lib/rubocop/cop/style/colon_method_call.rb +8 -9
- data/lib/rubocop/cop/style/colon_method_definition.rb +6 -6
- data/lib/rubocop/cop/style/command_literal.rb +23 -24
- data/lib/rubocop/cop/style/comment_annotation.rb +15 -15
- data/lib/rubocop/cop/style/commented_keyword.rb +6 -3
- data/lib/rubocop/cop/style/conditional_assignment.rb +13 -4
- data/lib/rubocop/cop/style/constant_visibility.rb +3 -2
- data/lib/rubocop/cop/style/copyright.rb +12 -12
- data/lib/rubocop/cop/style/date_time.rb +2 -2
- data/lib/rubocop/cop/style/def_with_parentheses.rb +8 -10
- data/lib/rubocop/cop/style/dir.rb +9 -12
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +7 -9
- data/lib/rubocop/cop/style/documentation.rb +6 -8
- data/lib/rubocop/cop/style/documentation_method.rb +1 -1
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +12 -15
- data/lib/rubocop/cop/style/double_negation.rb +2 -2
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +5 -8
- data/lib/rubocop/cop/style/each_with_object.rb +16 -19
- data/lib/rubocop/cop/style/empty_case_condition.rb +19 -20
- data/lib/rubocop/cop/style/empty_else.rb +17 -19
- data/lib/rubocop/cop/style/empty_literal.rb +20 -21
- data/lib/rubocop/cop/style/empty_method.rb +10 -13
- data/lib/rubocop/cop/style/encoding.rb +5 -9
- data/lib/rubocop/cop/style/end_block.rb +4 -6
- data/lib/rubocop/cop/style/eval_with_location.rb +9 -7
- data/lib/rubocop/cop/style/even_odd.rb +7 -11
- data/lib/rubocop/cop/style/expand_path_arguments.rb +23 -22
- data/lib/rubocop/cop/style/explicit_block_argument.rb +102 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +7 -9
- data/lib/rubocop/cop/style/float_division.rb +8 -11
- data/lib/rubocop/cop/style/for.rb +11 -15
- data/lib/rubocop/cop/style/format_string.rb +21 -19
- data/lib/rubocop/cop/style/format_string_token.rb +10 -12
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +19 -41
- data/lib/rubocop/cop/style/global_std_stream.rb +65 -0
- data/lib/rubocop/cop/style/global_vars.rb +2 -2
- data/lib/rubocop/cop/style/guard_clause.rb +5 -6
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +69 -0
- data/lib/rubocop/cop/style/hash_each_methods.rb +5 -8
- data/lib/rubocop/cop/style/hash_like_case.rb +76 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +4 -3
- data/lib/rubocop/cop/style/hash_transform_keys.rb +3 -2
- data/lib/rubocop/cop/style/hash_transform_values.rb +2 -1
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +2 -2
- data/lib/rubocop/cop/style/if_inside_else.rb +3 -3
- data/lib/rubocop/cop/style/if_unless_modifier.rb +18 -40
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
- data/lib/rubocop/cop/style/if_with_semicolon.rb +3 -6
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +1 -1
- data/lib/rubocop/cop/style/infinite_loop.rb +24 -24
- data/lib/rubocop/cop/style/inline_comment.rb +3 -3
- data/lib/rubocop/cop/style/inverse_methods.rb +22 -32
- data/lib/rubocop/cop/style/lambda.rb +7 -12
- data/lib/rubocop/cop/style/lambda_call.rb +14 -13
- data/lib/rubocop/cop/style/line_end_concatenation.rb +19 -16
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +2 -1
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +16 -11
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +4 -8
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +8 -7
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +2 -2
- data/lib/rubocop/cop/style/method_def_parentheses.rb +11 -16
- data/lib/rubocop/cop/style/min_max.rb +8 -12
- data/lib/rubocop/cop/style/missing_else.rb +11 -21
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +10 -3
- data/lib/rubocop/cop/style/mixin_grouping.rb +24 -27
- data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
- data/lib/rubocop/cop/style/module_function.rb +10 -13
- data/lib/rubocop/cop/style/multiline_block_chain.rb +10 -1
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +3 -10
- data/lib/rubocop/cop/style/multiline_if_then.rb +4 -10
- data/lib/rubocop/cop/style/multiline_memoization.rb +14 -12
- data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +4 -6
- data/lib/rubocop/cop/style/multiline_when_then.rb +7 -9
- data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
- data/lib/rubocop/cop/style/mutable_constant.rb +27 -24
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +5 -6
- data/lib/rubocop/cop/style/numeric_predicate.rb +7 -4
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +42 -0
- data/lib/rubocop/cop/style/parallel_assignment.rb +5 -5
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -1
- data/lib/rubocop/cop/style/proc.rb +1 -1
- data/lib/rubocop/cop/style/random_with_offset.rb +5 -10
- data/lib/rubocop/cop/style/redundant_assignment.rb +117 -0
- data/lib/rubocop/cop/style/redundant_condition.rb +15 -3
- data/lib/rubocop/cop/style/redundant_exception.rb +18 -10
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +26 -7
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +50 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
- data/lib/rubocop/cop/style/redundant_parentheses.rb +7 -1
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +2 -1
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +11 -11
- data/lib/rubocop/cop/style/redundant_sort.rb +26 -12
- data/lib/rubocop/cop/style/rescue_standard_error.rb +1 -1
- data/lib/rubocop/cop/style/safe_navigation.rb +4 -4
- data/lib/rubocop/cop/style/signal_exception.rb +3 -1
- data/lib/rubocop/cop/style/single_argument_dig.rb +54 -0
- data/lib/rubocop/cop/style/single_line_methods.rb +1 -1
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +3 -2
- data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
- data/lib/rubocop/cop/style/string_concatenation.rb +92 -0
- data/lib/rubocop/cop/style/struct_inheritance.rb +3 -3
- data/lib/rubocop/cop/style/symbol_array.rb +1 -1
- data/lib/rubocop/cop/style/symbol_proc.rb +2 -2
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +9 -32
- data/lib/rubocop/cop/style/trivial_accessors.rb +8 -7
- data/lib/rubocop/cop/style/zero_length_predicate.rb +12 -8
- data/lib/rubocop/cop/team.rb +98 -82
- data/lib/rubocop/cop/tokens_util.rb +84 -0
- data/lib/rubocop/cop/util.rb +3 -13
- data/lib/rubocop/cop/utils/format_string.rb +1 -2
- data/lib/rubocop/cop/variable_force.rb +0 -2
- data/lib/rubocop/cop/variable_force/branch.rb +1 -0
- data/lib/rubocop/cop/variable_force/variable.rb +7 -5
- data/lib/rubocop/cops_documentation_generator.rb +282 -0
- data/lib/rubocop/error.rb +1 -0
- data/lib/rubocop/file_finder.rb +12 -12
- data/lib/rubocop/formatter/disabled_config_formatter.rb +2 -2
- data/lib/rubocop/formatter/formatter_set.rb +1 -0
- data/lib/rubocop/formatter/junit_formatter.rb +1 -1
- data/lib/rubocop/name_similarity.rb +1 -3
- data/lib/rubocop/options.rb +18 -11
- data/lib/rubocop/path_util.rb +17 -17
- data/lib/rubocop/rake_task.rb +7 -9
- data/lib/rubocop/result_cache.rb +12 -8
- data/lib/rubocop/rspec/cop_helper.rb +4 -4
- data/lib/rubocop/rspec/expect_offense.rb +53 -22
- data/lib/rubocop/rspec/shared_contexts.rb +16 -17
- data/lib/rubocop/runner.rb +35 -34
- data/lib/rubocop/target_finder.rb +13 -10
- data/lib/rubocop/target_ruby.rb +1 -1
- data/lib/rubocop/version.rb +2 -2
- metadata +40 -11
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
- data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
@@ -36,9 +36,10 @@ module RuboCop
|
|
36
36
|
# # good
|
37
37
|
# if foo && bar
|
38
38
|
# end
|
39
|
-
class AndOr <
|
39
|
+
class AndOr < Base
|
40
40
|
include ConfigurableEnforcedStyle
|
41
41
|
include RangeHelp
|
42
|
+
extend AutoCorrector
|
42
43
|
|
43
44
|
MSG = 'Use `%<prefer>s` instead of `%<current>s`.'
|
44
45
|
|
@@ -55,8 +56,13 @@ module RuboCop
|
|
55
56
|
alias on_until on_if
|
56
57
|
alias on_until_post on_if
|
57
58
|
|
58
|
-
|
59
|
-
|
59
|
+
private
|
60
|
+
|
61
|
+
def process_logical_operator(node)
|
62
|
+
return if node.logical_operator?
|
63
|
+
|
64
|
+
message = message(node)
|
65
|
+
add_offense(node.loc.operator, message: message) do |corrector|
|
60
66
|
node.each_child_node do |expr|
|
61
67
|
if expr.send_type?
|
62
68
|
correct_send(expr, corrector)
|
@@ -71,20 +77,12 @@ module RuboCop
|
|
71
77
|
end
|
72
78
|
end
|
73
79
|
|
74
|
-
private
|
75
|
-
|
76
80
|
def on_conditionals(node)
|
77
81
|
node.condition.each_node(*AST::Node::OPERATOR_KEYWORDS) do |operator|
|
78
82
|
process_logical_operator(operator)
|
79
83
|
end
|
80
84
|
end
|
81
85
|
|
82
|
-
def process_logical_operator(node)
|
83
|
-
return if node.logical_operator?
|
84
|
-
|
85
|
-
add_offense(node, location: :operator)
|
86
|
-
end
|
87
|
-
|
88
86
|
def message(node)
|
89
87
|
format(MSG, prefer: node.alternate_operator, current: node.operator)
|
90
88
|
end
|
@@ -0,0 +1,63 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
module Style
|
6
|
+
# This cop enforces the use of `Array()` instead of explicit `Array` check or `[*var]`.
|
7
|
+
#
|
8
|
+
# @example
|
9
|
+
# # bad
|
10
|
+
# paths = [paths] unless paths.is_a?(Array)
|
11
|
+
# paths.each { |path| do_something(path) }
|
12
|
+
#
|
13
|
+
# # bad (always creates a new Array instance)
|
14
|
+
# [*paths].each { |path| do_something(path) }
|
15
|
+
#
|
16
|
+
# # good (and a bit more readable)
|
17
|
+
# Array(paths).each { |path| do_something(path) }
|
18
|
+
#
|
19
|
+
class ArrayCoercion < Base
|
20
|
+
extend AutoCorrector
|
21
|
+
|
22
|
+
SPLAT_MSG = 'Use `Array(%<arg>s)` instead of `[*%<arg>s]`.'
|
23
|
+
CHECK_MSG = 'Use `Array(%<arg>s)` instead of explicit `Array` check.'
|
24
|
+
|
25
|
+
def_node_matcher :array_splat?, <<~PATTERN
|
26
|
+
(array (splat $_))
|
27
|
+
PATTERN
|
28
|
+
|
29
|
+
def_node_matcher :unless_array?, <<~PATTERN
|
30
|
+
(if
|
31
|
+
(send
|
32
|
+
(lvar $_) :is_a?
|
33
|
+
(const nil? :Array)) nil?
|
34
|
+
(lvasgn $_
|
35
|
+
(array
|
36
|
+
(lvar $_))))
|
37
|
+
PATTERN
|
38
|
+
|
39
|
+
def on_array(node)
|
40
|
+
return unless node.square_brackets?
|
41
|
+
|
42
|
+
array_splat?(node) do |arg_node|
|
43
|
+
message = format(SPLAT_MSG, arg: arg_node.source)
|
44
|
+
add_offense(node, message: message) do |corrector|
|
45
|
+
corrector.replace(node, "Array(#{arg_node.source})")
|
46
|
+
end
|
47
|
+
end
|
48
|
+
end
|
49
|
+
|
50
|
+
def on_if(node)
|
51
|
+
unless_array?(node) do |var_a, var_b, var_c|
|
52
|
+
if var_a == var_b && var_c == var_b
|
53
|
+
message = format(CHECK_MSG, arg: var_a)
|
54
|
+
add_offense(node, message: message) do |corrector|
|
55
|
+
corrector.replace(node, "#{var_a} = Array(#{var_a})")
|
56
|
+
end
|
57
|
+
end
|
58
|
+
end
|
59
|
+
end
|
60
|
+
end
|
61
|
+
end
|
62
|
+
end
|
63
|
+
end
|
@@ -17,20 +17,18 @@ module RuboCop
|
|
17
17
|
# # good
|
18
18
|
# %w(foo bar baz).join(",")
|
19
19
|
#
|
20
|
-
class ArrayJoin <
|
20
|
+
class ArrayJoin < Base
|
21
|
+
extend AutoCorrector
|
22
|
+
|
21
23
|
MSG = 'Favor `Array#join` over `Array#*`.'
|
22
24
|
|
23
25
|
def_node_matcher :join_candidate?, '(send $array :* $str)'
|
24
26
|
|
25
27
|
def on_send(node)
|
26
|
-
|
27
|
-
end
|
28
|
-
|
29
|
-
def autocorrect(node)
|
30
|
-
array, join_arg = join_candidate?(node).map(&:source)
|
28
|
+
return unless (array, join_arg = join_candidate?(node))
|
31
29
|
|
32
|
-
|
33
|
-
corrector.replace(node, "#{array}.join(#{join_arg})")
|
30
|
+
add_offense(node.loc.selector) do |corrector|
|
31
|
+
corrector.replace(node, "#{array.source}.join(#{join_arg.source})")
|
34
32
|
end
|
35
33
|
end
|
36
34
|
end
|
@@ -15,17 +15,17 @@ module RuboCop
|
|
15
15
|
#
|
16
16
|
# # good
|
17
17
|
# # Translates from English to Japanese
|
18
|
-
class AsciiComments <
|
18
|
+
class AsciiComments < Base
|
19
19
|
include RangeHelp
|
20
20
|
|
21
21
|
MSG = 'Use only ascii symbols in comments.'
|
22
22
|
|
23
|
-
def
|
24
|
-
processed_source.
|
23
|
+
def on_new_investigation
|
24
|
+
processed_source.comments.each do |comment|
|
25
25
|
next if comment.text.ascii_only?
|
26
26
|
next if only_allowed_non_ascii_chars?(comment.text)
|
27
27
|
|
28
|
-
add_offense(
|
28
|
+
add_offense(first_offense_range(comment))
|
29
29
|
end
|
30
30
|
end
|
31
31
|
|
@@ -14,8 +14,9 @@ module RuboCop
|
|
14
14
|
# attr_accessor :something
|
15
15
|
# attr_reader :one, :two, :three
|
16
16
|
#
|
17
|
-
class Attr <
|
17
|
+
class Attr < Base
|
18
18
|
include RangeHelp
|
19
|
+
extend AutoCorrector
|
19
20
|
|
20
21
|
MSG = 'Do not use `attr`. Use `%<replacement>s` instead.'
|
21
22
|
|
@@ -26,10 +27,15 @@ module RuboCop
|
|
26
27
|
!node.parent.class_type? &&
|
27
28
|
!class_eval?(node.parent)
|
28
29
|
|
29
|
-
|
30
|
+
message = message(node)
|
31
|
+
add_offense(node.loc.selector, message: message) do |corrector|
|
32
|
+
autocorrect(corrector, node)
|
33
|
+
end
|
30
34
|
end
|
31
35
|
|
32
|
-
|
36
|
+
private
|
37
|
+
|
38
|
+
def autocorrect(corrector, node)
|
33
39
|
attr_name, setter = *node.arguments
|
34
40
|
|
35
41
|
node_expr = node.source_range
|
@@ -37,14 +43,10 @@ module RuboCop
|
|
37
43
|
|
38
44
|
remove = range_between(attr_expr.end_pos, node_expr.end_pos) if setter&.boolean_type?
|
39
45
|
|
40
|
-
|
41
|
-
|
42
|
-
corrector.remove(remove) if remove
|
43
|
-
end
|
46
|
+
corrector.replace(node.loc.selector, replacement_method(node))
|
47
|
+
corrector.remove(remove) if remove
|
44
48
|
end
|
45
49
|
|
46
|
-
private
|
47
|
-
|
48
50
|
def message(node)
|
49
51
|
format(MSG, replacement: replacement_method(node))
|
50
52
|
end
|
@@ -16,7 +16,7 @@ module RuboCop
|
|
16
16
|
# File.open('file') do |f|
|
17
17
|
# # ...
|
18
18
|
# end
|
19
|
-
class AutoResourceCleanup <
|
19
|
+
class AutoResourceCleanup < Base
|
20
20
|
MSG = 'Use the block version of `%<class>s.%<method>s`.'
|
21
21
|
|
22
22
|
TARGET_METHODS = {
|
@@ -25,16 +25,14 @@ module RuboCop
|
|
25
25
|
|
26
26
|
def on_send(node)
|
27
27
|
TARGET_METHODS.each do |target_class, target_method|
|
28
|
-
|
28
|
+
next if node.method_name != target_method
|
29
29
|
|
30
|
+
target_receiver = s(:const, nil, target_class)
|
30
31
|
next if node.receiver != target_receiver
|
31
|
-
|
32
|
+
|
32
33
|
next if cleanup?(node)
|
33
34
|
|
34
|
-
add_offense(node,
|
35
|
-
message: format(MSG,
|
36
|
-
class: target_class,
|
37
|
-
method: target_method))
|
35
|
+
add_offense(node, message: format(MSG, class: target_class, method: target_method))
|
38
36
|
end
|
39
37
|
end
|
40
38
|
|
@@ -23,8 +23,9 @@ module RuboCop
|
|
23
23
|
# %Q|He said: "#{greeting}"|
|
24
24
|
# %q/She said: 'Hi'/
|
25
25
|
#
|
26
|
-
class BarePercentLiterals <
|
26
|
+
class BarePercentLiterals < Base
|
27
27
|
include ConfigurableEnforcedStyle
|
28
|
+
extend AutoCorrector
|
28
29
|
|
29
30
|
MSG = 'Use `%%%<good>s` instead of `%%%<bad>s`.'
|
30
31
|
|
@@ -36,14 +37,6 @@ module RuboCop
|
|
36
37
|
check(node)
|
37
38
|
end
|
38
39
|
|
39
|
-
def autocorrect(node)
|
40
|
-
src = node.loc.begin.source
|
41
|
-
replacement = src.start_with?('%Q') ? '%' : '%Q'
|
42
|
-
lambda do |corrector|
|
43
|
-
corrector.replace(node.loc.begin, src.sub(/%Q?/, replacement))
|
44
|
-
end
|
45
|
-
end
|
46
|
-
|
47
40
|
private
|
48
41
|
|
49
42
|
def check(node)
|
@@ -68,9 +61,14 @@ module RuboCop
|
|
68
61
|
end
|
69
62
|
|
70
63
|
def add_offense_for_wrong_style(node, good, bad)
|
71
|
-
|
72
|
-
|
73
|
-
|
64
|
+
location = node.loc.begin
|
65
|
+
|
66
|
+
add_offense(location, message: format(MSG, good: good, bad: bad)) do |corrector|
|
67
|
+
source = location.source
|
68
|
+
replacement = source.start_with?('%Q') ? '%' : '%Q'
|
69
|
+
|
70
|
+
corrector.replace(location, source.sub(/%Q?/, replacement))
|
71
|
+
end
|
74
72
|
end
|
75
73
|
end
|
76
74
|
end
|
@@ -10,11 +10,11 @@ module RuboCop
|
|
10
10
|
# # bad
|
11
11
|
# BEGIN { test }
|
12
12
|
#
|
13
|
-
class BeginBlock <
|
13
|
+
class BeginBlock < Base
|
14
14
|
MSG = 'Avoid the use of `BEGIN` blocks.'
|
15
15
|
|
16
16
|
def on_preexe(node)
|
17
|
-
add_offense(node
|
17
|
+
add_offense(node.loc.keyword)
|
18
18
|
end
|
19
19
|
end
|
20
20
|
end
|
@@ -0,0 +1,141 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
module Style
|
6
|
+
# This cop checks for places where `attr_reader` and `attr_writer`
|
7
|
+
# for the same method can be combined into single `attr_accessor`.
|
8
|
+
#
|
9
|
+
# @example
|
10
|
+
# # bad
|
11
|
+
# class Foo
|
12
|
+
# attr_reader :bar
|
13
|
+
# attr_writer :bar
|
14
|
+
# end
|
15
|
+
#
|
16
|
+
# # good
|
17
|
+
# class Foo
|
18
|
+
# attr_accessor :bar
|
19
|
+
# end
|
20
|
+
#
|
21
|
+
class BisectedAttrAccessor < Base
|
22
|
+
include VisibilityHelp
|
23
|
+
extend AutoCorrector
|
24
|
+
|
25
|
+
MSG = 'Combine both accessors into `attr_accessor %<name>s`.'
|
26
|
+
|
27
|
+
def on_class(class_node)
|
28
|
+
VISIBILITY_SCOPES.each do |visibility|
|
29
|
+
reader_names, writer_names = accessor_names(class_node, visibility)
|
30
|
+
next unless reader_names && writer_names
|
31
|
+
|
32
|
+
accessor_macroses(class_node, visibility).each do |macro|
|
33
|
+
check(macro, reader_names, writer_names)
|
34
|
+
end
|
35
|
+
end
|
36
|
+
end
|
37
|
+
alias on_sclass on_class
|
38
|
+
alias on_module on_class
|
39
|
+
|
40
|
+
private
|
41
|
+
|
42
|
+
def accessor_names(class_node, visibility)
|
43
|
+
reader_names = nil
|
44
|
+
writer_names = nil
|
45
|
+
|
46
|
+
accessor_macroses(class_node, visibility).each do |macro|
|
47
|
+
names = macro.arguments.map(&:source)
|
48
|
+
|
49
|
+
names.each do |name|
|
50
|
+
if attr_reader?(macro)
|
51
|
+
(reader_names ||= Set.new).add(name)
|
52
|
+
else
|
53
|
+
(writer_names ||= Set.new).add(name)
|
54
|
+
end
|
55
|
+
end
|
56
|
+
end
|
57
|
+
|
58
|
+
[reader_names, writer_names]
|
59
|
+
end
|
60
|
+
|
61
|
+
def accessor_macroses(class_node, visibility)
|
62
|
+
class_def = class_node.body
|
63
|
+
return [] if !class_def || class_def.def_type?
|
64
|
+
|
65
|
+
send_nodes =
|
66
|
+
if class_def.send_type?
|
67
|
+
[class_def]
|
68
|
+
else
|
69
|
+
class_def.each_child_node(:send)
|
70
|
+
end
|
71
|
+
|
72
|
+
send_nodes.select { |node| attr_within_visibility_scope?(node, visibility) }
|
73
|
+
end
|
74
|
+
|
75
|
+
def attr_within_visibility_scope?(node, visibility)
|
76
|
+
node.macro? &&
|
77
|
+
(attr_reader?(node) || attr_writer?(node)) &&
|
78
|
+
node_visibility(node) == visibility
|
79
|
+
end
|
80
|
+
|
81
|
+
def attr_reader?(send_node)
|
82
|
+
send_node.method?(:attr_reader) || send_node.method?(:attr)
|
83
|
+
end
|
84
|
+
|
85
|
+
def attr_writer?(send_node)
|
86
|
+
send_node.method?(:attr_writer)
|
87
|
+
end
|
88
|
+
|
89
|
+
def check(macro, reader_names, writer_names)
|
90
|
+
macro.arguments.each do |arg_node|
|
91
|
+
name = arg_node.source
|
92
|
+
|
93
|
+
next unless (attr_reader?(macro) && writer_names.include?(name)) ||
|
94
|
+
(attr_writer?(macro) && reader_names.include?(name))
|
95
|
+
|
96
|
+
add_offense(arg_node, message: format(MSG, name: name)) do |corrector|
|
97
|
+
macro = arg_node.parent
|
98
|
+
|
99
|
+
corrector.replace(macro, replacement(macro, arg_node))
|
100
|
+
end
|
101
|
+
end
|
102
|
+
end
|
103
|
+
|
104
|
+
def replacement(macro, node)
|
105
|
+
class_node = macro.each_ancestor(:class, :sclass, :module).first
|
106
|
+
reader_names, writer_names = accessor_names(class_node, node_visibility(macro))
|
107
|
+
|
108
|
+
rest_args = rest_args(macro.arguments, reader_names, writer_names)
|
109
|
+
|
110
|
+
if attr_reader?(macro)
|
111
|
+
attr_reader_replacement(macro, node, rest_args)
|
112
|
+
elsif rest_args.empty?
|
113
|
+
''
|
114
|
+
else
|
115
|
+
"#{macro.method_name} #{rest_args.map(&:source).join(', ')}"
|
116
|
+
end
|
117
|
+
end
|
118
|
+
|
119
|
+
def rest_args(args, reader_names, writer_names)
|
120
|
+
args.reject do |arg|
|
121
|
+
name = arg.source
|
122
|
+
reader_names.include?(name) && writer_names.include?(name)
|
123
|
+
end
|
124
|
+
end
|
125
|
+
|
126
|
+
def attr_reader_replacement(macro, node, rest_args)
|
127
|
+
if rest_args.empty?
|
128
|
+
"attr_accessor #{node.source}"
|
129
|
+
else
|
130
|
+
"attr_accessor #{node.source}\n"\
|
131
|
+
"#{indent(macro)}#{macro.method_name} #{rest_args.map(&:source).join(', ')}"
|
132
|
+
end
|
133
|
+
end
|
134
|
+
|
135
|
+
def indent(node)
|
136
|
+
' ' * node.loc.column
|
137
|
+
end
|
138
|
+
end
|
139
|
+
end
|
140
|
+
end
|
141
|
+
end
|
@@ -16,34 +16,30 @@ module RuboCop
|
|
16
16
|
# # Multiple lines
|
17
17
|
# # of comments...
|
18
18
|
#
|
19
|
-
class BlockComments <
|
19
|
+
class BlockComments < Base
|
20
20
|
include RangeHelp
|
21
|
+
extend AutoCorrector
|
21
22
|
|
22
23
|
MSG = 'Do not use block comments.'
|
23
24
|
BEGIN_LENGTH = "=begin\n".length
|
24
25
|
END_LENGTH = "\n=end".length
|
25
26
|
|
26
|
-
def
|
27
|
-
processed_source.
|
27
|
+
def on_new_investigation
|
28
|
+
processed_source.comments.each do |comment|
|
28
29
|
next unless comment.document?
|
29
30
|
|
30
|
-
add_offense(comment)
|
31
|
-
|
32
|
-
end
|
33
|
-
|
34
|
-
def autocorrect(comment)
|
35
|
-
eq_begin, eq_end, contents = parts(comment)
|
31
|
+
add_offense(comment) do |corrector|
|
32
|
+
eq_begin, eq_end, contents = parts(comment)
|
36
33
|
|
37
|
-
|
38
|
-
|
39
|
-
|
40
|
-
|
41
|
-
|
42
|
-
|
43
|
-
|
44
|
-
|
34
|
+
corrector.remove(eq_begin)
|
35
|
+
unless contents.length.zero?
|
36
|
+
corrector.replace(
|
37
|
+
contents,
|
38
|
+
contents.source.gsub(/\A/, '# ').gsub(/\n\n/, "\n#\n").gsub(/\n(?=[^#])/, "\n# ")
|
39
|
+
)
|
40
|
+
end
|
41
|
+
corrector.remove(eq_end)
|
45
42
|
end
|
46
|
-
corrector.remove(eq_end)
|
47
43
|
end
|
48
44
|
end
|
49
45
|
|