rubocop 0.86.0 → 0.89.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/README.md +1 -1
- data/bin/rubocop-profile +32 -0
- data/config/default.yml +198 -25
- data/lib/rubocop.rb +30 -5
- data/lib/rubocop/cli.rb +2 -4
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +42 -7
- data/lib/rubocop/cli/command/base.rb +1 -0
- data/lib/rubocop/cli/command/execute_runner.rb +1 -1
- data/lib/rubocop/cli/command/show_cops.rb +3 -3
- data/lib/rubocop/cli/command/version.rb +2 -2
- data/lib/rubocop/comment_config.rb +5 -7
- data/lib/rubocop/config.rb +20 -3
- data/lib/rubocop/config_loader.rb +41 -69
- data/lib/rubocop/config_loader_resolver.rb +3 -3
- data/lib/rubocop/config_obsoletion.rb +6 -2
- data/lib/rubocop/config_store.rb +4 -0
- data/lib/rubocop/config_validator.rb +2 -4
- data/lib/rubocop/cop/autocorrect_logic.rb +14 -24
- data/lib/rubocop/cop/badge.rb +1 -1
- data/lib/rubocop/cop/base.rb +407 -0
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +10 -20
- data/lib/rubocop/cop/commissioner.rb +47 -50
- data/lib/rubocop/cop/cop.rb +85 -236
- data/lib/rubocop/cop/corrector.rb +38 -115
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +26 -0
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +2 -2
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +1 -1
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +15 -18
- data/lib/rubocop/cop/force.rb +1 -0
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +38 -12
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +1 -1
- data/lib/rubocop/cop/generator.rb +1 -1
- data/lib/rubocop/cop/generator/configuration_injector.rb +2 -2
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +4 -12
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +11 -14
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +8 -8
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +10 -7
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +7 -8
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +2 -2
- data/lib/rubocop/cop/layout/block_alignment.rb +1 -1
- data/lib/rubocop/cop/layout/case_indentation.rb +18 -19
- data/lib/rubocop/cop/layout/class_structure.rb +5 -44
- data/lib/rubocop/cop/layout/comment_indentation.rb +1 -1
- data/lib/rubocop/cop/layout/empty_lines.rb +0 -2
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +1 -0
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +1 -8
- data/lib/rubocop/cop/layout/end_alignment.rb +3 -2
- data/lib/rubocop/cop/layout/extra_spacing.rb +22 -36
- data/lib/rubocop/cop/layout/first_argument_indentation.rb +4 -0
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +1 -1
- data/lib/rubocop/cop/layout/hash_alignment.rb +1 -2
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +2 -2
- data/lib/rubocop/cop/layout/indentation_style.rb +0 -2
- data/lib/rubocop/cop/layout/leading_comment_space.rb +1 -1
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +16 -6
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +1 -1
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +0 -2
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +22 -27
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +33 -66
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +3 -2
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +49 -0
- data/lib/rubocop/cop/legacy/corrector.rb +29 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +7 -4
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +15 -10
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +11 -13
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +2 -2
- data/lib/rubocop/cop/lint/big_decimal_new.rb +10 -10
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +50 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +16 -11
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
- data/lib/rubocop/cop/lint/constant_resolution.rb +1 -1
- data/lib/rubocop/cop/lint/debugger.rb +7 -1
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +9 -10
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +21 -17
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +8 -2
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/duplicate_hash_key.rb +1 -1
- data/lib/rubocop/cop/lint/duplicate_methods.rb +9 -6
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +60 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
- data/lib/rubocop/cop/lint/else_layout.rb +1 -1
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +5 -5
- data/lib/rubocop/cop/lint/empty_expression.rb +2 -2
- data/lib/rubocop/cop/lint/empty_interpolation.rb +5 -6
- data/lib/rubocop/cop/lint/empty_when.rb +2 -2
- data/lib/rubocop/cop/lint/ensure_return.rb +27 -29
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +11 -10
- data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +1 -1
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +5 -4
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +13 -14
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +5 -4
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +8 -8
- data/lib/rubocop/cop/lint/inherit_exception.rb +12 -7
- data/lib/rubocop/cop/lint/interpolation_check.rb +21 -5
- data/lib/rubocop/cop/lint/literal_as_condition.rb +14 -2
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +7 -7
- data/lib/rubocop/cop/lint/loop.rb +23 -2
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +6 -5
- data/lib/rubocop/cop/lint/missing_super.rb +99 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +1 -1
- data/lib/rubocop/cop/lint/multiple_comparison.rb +6 -9
- data/lib/rubocop/cop/lint/nested_method_definition.rb +15 -21
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +1 -1
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +1 -1
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +84 -13
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +2 -2
- data/lib/rubocop/cop/lint/number_conversion.rb +6 -9
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +11 -13
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +90 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +12 -13
- data/lib/rubocop/cop/lint/percent_string_array.rb +13 -12
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +13 -12
- data/lib/rubocop/cop/lint/raise_exception.rb +12 -10
- data/lib/rubocop/cop/lint/rand_one.rb +3 -3
- data/lib/rubocop/cop/lint/redundant_cop_disable_directive.rb +41 -40
- data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +7 -11
- data/lib/rubocop/cop/lint/redundant_require_statement.rb +4 -7
- data/lib/rubocop/cop/lint/redundant_splat_expansion.rb +15 -11
- data/lib/rubocop/cop/lint/redundant_string_coercion.rb +6 -13
- data/lib/rubocop/cop/lint/redundant_with_index.rb +11 -14
- data/lib/rubocop/cop/lint/redundant_with_object.rb +11 -14
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +4 -6
- data/lib/rubocop/cop/lint/require_parentheses.rb +2 -2
- data/lib/rubocop/cop/lint/rescue_exception.rb +1 -1
- data/lib/rubocop/cop/lint/rescue_type.rb +8 -8
- data/lib/rubocop/cop/lint/return_in_void_context.rb +2 -4
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +3 -6
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +14 -10
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +10 -2
- data/lib/rubocop/cop/lint/script_permission.rb +10 -7
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +5 -11
- data/lib/rubocop/cop/lint/shadowed_argument.rb +3 -3
- data/lib/rubocop/cop/lint/shadowed_exception.rb +2 -2
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +3 -3
- data/lib/rubocop/cop/lint/struct_new_override.rb +1 -1
- data/lib/rubocop/cop/lint/suppressed_exception.rb +4 -7
- data/lib/rubocop/cop/lint/syntax.rb +11 -26
- data/lib/rubocop/cop/lint/to_json.rb +4 -6
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +4 -4
- data/lib/rubocop/cop/lint/unified_integer.rb +4 -6
- data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
- data/lib/rubocop/cop/lint/unreachable_loop.rb +174 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +8 -3
- data/lib/rubocop/cop/lint/unused_method_argument.rb +9 -4
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
- data/lib/rubocop/cop/lint/uri_regexp.rb +11 -47
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +26 -16
- data/lib/rubocop/cop/lint/useless_assignment.rb +4 -4
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +6 -15
- data/lib/rubocop/cop/lint/useless_setter_call.rb +4 -6
- data/lib/rubocop/cop/lint/void.rb +3 -7
- data/lib/rubocop/cop/metrics/abc_size.rb +1 -1
- data/lib/rubocop/cop/metrics/block_length.rb +24 -2
- data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
- data/lib/rubocop/cop/metrics/class_length.rb +26 -3
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +2 -1
- data/lib/rubocop/cop/metrics/method_length.rb +25 -2
- data/lib/rubocop/cop/metrics/module_length.rb +26 -3
- data/lib/rubocop/cop/metrics/parameter_lists.rb +2 -6
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +7 -8
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +48 -5
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +157 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +37 -0
- data/lib/rubocop/cop/migration/department_name.rb +14 -16
- data/lib/rubocop/cop/mixin/alignment.rb +2 -1
- data/lib/rubocop/cop/mixin/allowed_methods.rb +19 -0
- data/lib/rubocop/cop/mixin/array_min_size.rb +1 -1
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +2 -2
- data/lib/rubocop/cop/mixin/code_length.rb +26 -5
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +1 -1
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +3 -1
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +5 -11
- data/lib/rubocop/cop/mixin/line_length_help.rb +1 -3
- data/lib/rubocop/cop/mixin/method_complexity.rb +10 -2
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +1 -2
- data/lib/rubocop/cop/mixin/nil_methods.rb +3 -5
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +6 -1
- data/lib/rubocop/cop/mixin/percent_array.rb +2 -6
- data/lib/rubocop/cop/mixin/range_help.rb +18 -4
- data/lib/rubocop/cop/mixin/statement_modifier.rb +39 -10
- data/lib/rubocop/cop/mixin/surrounding_space.rb +4 -24
- data/lib/rubocop/cop/mixin/trailing_comma.rb +2 -4
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +10 -15
- data/lib/rubocop/cop/mixin/unused_argument.rb +4 -6
- data/lib/rubocop/cop/mixin/visibility_help.rb +50 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -6
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +3 -3
- data/lib/rubocop/cop/naming/block_parameter_name.rb +1 -1
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +2 -2
- data/lib/rubocop/cop/naming/constant_name.rb +2 -2
- data/lib/rubocop/cop/naming/file_name.rb +3 -3
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +2 -2
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +2 -2
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +2 -2
- data/lib/rubocop/cop/naming/method_name.rb +1 -1
- data/lib/rubocop/cop/naming/method_parameter_name.rb +2 -2
- data/lib/rubocop/cop/naming/predicate_name.rb +6 -10
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +12 -11
- data/lib/rubocop/cop/naming/variable_name.rb +1 -1
- data/lib/rubocop/cop/naming/variable_number.rb +1 -1
- data/lib/rubocop/cop/offense.rb +16 -2
- data/lib/rubocop/cop/registry.rb +3 -3
- data/lib/rubocop/cop/security/eval.rb +2 -2
- data/lib/rubocop/cop/security/json_load.rb +6 -8
- data/lib/rubocop/cop/security/marshal_load.rb +2 -4
- data/lib/rubocop/cop/security/open.rb +2 -2
- data/lib/rubocop/cop/security/yaml_load.rb +6 -6
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +16 -9
- data/lib/rubocop/cop/style/accessor_grouping.rb +149 -0
- data/lib/rubocop/cop/style/alias.rb +41 -36
- data/lib/rubocop/cop/style/and_or.rb +9 -11
- data/lib/rubocop/cop/style/array_coercion.rb +63 -0
- data/lib/rubocop/cop/style/array_join.rb +6 -8
- data/lib/rubocop/cop/style/ascii_comments.rb +4 -4
- data/lib/rubocop/cop/style/attr.rb +11 -9
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +5 -7
- data/lib/rubocop/cop/style/bare_percent_literals.rb +10 -12
- data/lib/rubocop/cop/style/begin_block.rb +2 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +141 -0
- data/lib/rubocop/cop/style/block_comments.rb +14 -18
- data/lib/rubocop/cop/style/block_delimiters.rb +23 -23
- data/lib/rubocop/cop/style/case_equality.rb +22 -3
- data/lib/rubocop/cop/style/case_like_if.rb +220 -0
- data/lib/rubocop/cop/style/class_and_module_children.rb +14 -11
- data/lib/rubocop/cop/style/class_check.rb +7 -9
- data/lib/rubocop/cop/style/class_methods.rb +7 -11
- data/lib/rubocop/cop/style/class_vars.rb +24 -7
- data/lib/rubocop/cop/style/collection_methods.rb +11 -17
- data/lib/rubocop/cop/style/colon_method_call.rb +8 -9
- data/lib/rubocop/cop/style/colon_method_definition.rb +6 -6
- data/lib/rubocop/cop/style/command_literal.rb +23 -24
- data/lib/rubocop/cop/style/comment_annotation.rb +15 -15
- data/lib/rubocop/cop/style/commented_keyword.rb +6 -3
- data/lib/rubocop/cop/style/conditional_assignment.rb +13 -4
- data/lib/rubocop/cop/style/constant_visibility.rb +3 -2
- data/lib/rubocop/cop/style/copyright.rb +12 -12
- data/lib/rubocop/cop/style/date_time.rb +2 -2
- data/lib/rubocop/cop/style/def_with_parentheses.rb +8 -10
- data/lib/rubocop/cop/style/dir.rb +9 -12
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +7 -9
- data/lib/rubocop/cop/style/documentation.rb +6 -8
- data/lib/rubocop/cop/style/documentation_method.rb +1 -1
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +12 -15
- data/lib/rubocop/cop/style/double_negation.rb +2 -2
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +5 -8
- data/lib/rubocop/cop/style/each_with_object.rb +16 -19
- data/lib/rubocop/cop/style/empty_case_condition.rb +19 -20
- data/lib/rubocop/cop/style/empty_else.rb +17 -19
- data/lib/rubocop/cop/style/empty_literal.rb +20 -21
- data/lib/rubocop/cop/style/empty_method.rb +10 -13
- data/lib/rubocop/cop/style/encoding.rb +5 -9
- data/lib/rubocop/cop/style/end_block.rb +4 -6
- data/lib/rubocop/cop/style/eval_with_location.rb +9 -7
- data/lib/rubocop/cop/style/even_odd.rb +7 -11
- data/lib/rubocop/cop/style/expand_path_arguments.rb +23 -22
- data/lib/rubocop/cop/style/explicit_block_argument.rb +102 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +7 -9
- data/lib/rubocop/cop/style/float_division.rb +8 -11
- data/lib/rubocop/cop/style/for.rb +11 -15
- data/lib/rubocop/cop/style/format_string.rb +21 -19
- data/lib/rubocop/cop/style/format_string_token.rb +10 -12
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +19 -41
- data/lib/rubocop/cop/style/global_std_stream.rb +65 -0
- data/lib/rubocop/cop/style/global_vars.rb +2 -2
- data/lib/rubocop/cop/style/guard_clause.rb +5 -6
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +69 -0
- data/lib/rubocop/cop/style/hash_each_methods.rb +5 -8
- data/lib/rubocop/cop/style/hash_like_case.rb +76 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +4 -3
- data/lib/rubocop/cop/style/hash_transform_keys.rb +3 -2
- data/lib/rubocop/cop/style/hash_transform_values.rb +2 -1
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +2 -2
- data/lib/rubocop/cop/style/if_inside_else.rb +3 -3
- data/lib/rubocop/cop/style/if_unless_modifier.rb +18 -40
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
- data/lib/rubocop/cop/style/if_with_semicolon.rb +3 -6
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +1 -1
- data/lib/rubocop/cop/style/infinite_loop.rb +24 -24
- data/lib/rubocop/cop/style/inline_comment.rb +3 -3
- data/lib/rubocop/cop/style/inverse_methods.rb +22 -32
- data/lib/rubocop/cop/style/lambda.rb +7 -12
- data/lib/rubocop/cop/style/lambda_call.rb +14 -13
- data/lib/rubocop/cop/style/line_end_concatenation.rb +19 -16
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +2 -1
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +16 -11
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +4 -8
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +8 -7
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +2 -2
- data/lib/rubocop/cop/style/method_def_parentheses.rb +11 -16
- data/lib/rubocop/cop/style/min_max.rb +8 -12
- data/lib/rubocop/cop/style/missing_else.rb +11 -21
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +10 -3
- data/lib/rubocop/cop/style/mixin_grouping.rb +24 -27
- data/lib/rubocop/cop/style/mixin_usage.rb +1 -1
- data/lib/rubocop/cop/style/module_function.rb +10 -13
- data/lib/rubocop/cop/style/multiline_block_chain.rb +10 -1
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +3 -10
- data/lib/rubocop/cop/style/multiline_if_then.rb +4 -10
- data/lib/rubocop/cop/style/multiline_memoization.rb +14 -12
- data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +4 -6
- data/lib/rubocop/cop/style/multiline_when_then.rb +7 -9
- data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
- data/lib/rubocop/cop/style/mutable_constant.rb +27 -24
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +5 -6
- data/lib/rubocop/cop/style/numeric_predicate.rb +7 -4
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +42 -0
- data/lib/rubocop/cop/style/parallel_assignment.rb +5 -5
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +1 -1
- data/lib/rubocop/cop/style/proc.rb +1 -1
- data/lib/rubocop/cop/style/random_with_offset.rb +5 -10
- data/lib/rubocop/cop/style/redundant_assignment.rb +117 -0
- data/lib/rubocop/cop/style/redundant_condition.rb +15 -3
- data/lib/rubocop/cop/style/redundant_exception.rb +18 -10
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +26 -7
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +50 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
- data/lib/rubocop/cop/style/redundant_parentheses.rb +7 -1
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +2 -1
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +11 -11
- data/lib/rubocop/cop/style/redundant_sort.rb +26 -12
- data/lib/rubocop/cop/style/rescue_standard_error.rb +1 -1
- data/lib/rubocop/cop/style/safe_navigation.rb +4 -4
- data/lib/rubocop/cop/style/signal_exception.rb +3 -1
- data/lib/rubocop/cop/style/single_argument_dig.rb +54 -0
- data/lib/rubocop/cop/style/single_line_methods.rb +1 -1
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +3 -2
- data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
- data/lib/rubocop/cop/style/string_concatenation.rb +92 -0
- data/lib/rubocop/cop/style/struct_inheritance.rb +3 -3
- data/lib/rubocop/cop/style/symbol_array.rb +1 -1
- data/lib/rubocop/cop/style/symbol_proc.rb +2 -2
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +9 -32
- data/lib/rubocop/cop/style/trivial_accessors.rb +8 -7
- data/lib/rubocop/cop/style/zero_length_predicate.rb +12 -8
- data/lib/rubocop/cop/team.rb +98 -82
- data/lib/rubocop/cop/tokens_util.rb +84 -0
- data/lib/rubocop/cop/util.rb +3 -13
- data/lib/rubocop/cop/utils/format_string.rb +1 -2
- data/lib/rubocop/cop/variable_force.rb +0 -2
- data/lib/rubocop/cop/variable_force/branch.rb +1 -0
- data/lib/rubocop/cop/variable_force/variable.rb +7 -5
- data/lib/rubocop/cops_documentation_generator.rb +282 -0
- data/lib/rubocop/error.rb +1 -0
- data/lib/rubocop/file_finder.rb +12 -12
- data/lib/rubocop/formatter/disabled_config_formatter.rb +2 -2
- data/lib/rubocop/formatter/formatter_set.rb +1 -0
- data/lib/rubocop/formatter/junit_formatter.rb +1 -1
- data/lib/rubocop/name_similarity.rb +1 -3
- data/lib/rubocop/options.rb +18 -11
- data/lib/rubocop/path_util.rb +17 -17
- data/lib/rubocop/rake_task.rb +7 -9
- data/lib/rubocop/result_cache.rb +12 -8
- data/lib/rubocop/rspec/cop_helper.rb +4 -4
- data/lib/rubocop/rspec/expect_offense.rb +53 -22
- data/lib/rubocop/rspec/shared_contexts.rb +16 -17
- data/lib/rubocop/runner.rb +35 -34
- data/lib/rubocop/target_finder.rb +13 -10
- data/lib/rubocop/target_ruby.rb +1 -1
- data/lib/rubocop/version.rb +2 -2
- metadata +40 -11
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
- data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
@@ -16,10 +16,11 @@ module RuboCop
|
|
16
16
|
# # good
|
17
17
|
#
|
18
18
|
# "result is 10"
|
19
|
-
class LiteralInInterpolation <
|
19
|
+
class LiteralInInterpolation < Base
|
20
20
|
include Interpolation
|
21
21
|
include RangeHelp
|
22
22
|
include PercentLiteral
|
23
|
+
extend AutoCorrector
|
23
24
|
|
24
25
|
MSG = 'Literal interpolation detected.'
|
25
26
|
COMPOSITE = %i[array hash pair irange erange].freeze
|
@@ -30,14 +31,13 @@ module RuboCop
|
|
30
31
|
return if special_keyword?(final_node)
|
31
32
|
return unless prints_as_self?(final_node)
|
32
33
|
|
33
|
-
add_offense(final_node)
|
34
|
-
|
34
|
+
add_offense(final_node) do |corrector|
|
35
|
+
return if final_node.dstr_type? # nested, fixed in next iteration
|
35
36
|
|
36
|
-
|
37
|
-
return if node.dstr_type? # nested, fixed in next iteration
|
37
|
+
value = autocorrected_value(final_node)
|
38
38
|
|
39
|
-
|
40
|
-
|
39
|
+
corrector.replace(final_node.parent, value)
|
40
|
+
end
|
41
41
|
end
|
42
42
|
|
43
43
|
private
|
@@ -42,7 +42,9 @@ module RuboCop
|
|
42
42
|
# do_something
|
43
43
|
# break if some_condition
|
44
44
|
# end
|
45
|
-
class Loop <
|
45
|
+
class Loop < Base
|
46
|
+
extend AutoCorrector
|
47
|
+
|
46
48
|
MSG = 'Use `Kernel#loop` with `break` rather than ' \
|
47
49
|
'`begin/end/until`(or `while`).'
|
48
50
|
|
@@ -57,7 +59,26 @@ module RuboCop
|
|
57
59
|
private
|
58
60
|
|
59
61
|
def register_offense(node)
|
60
|
-
|
62
|
+
body = node.body
|
63
|
+
|
64
|
+
add_offense(node.loc.keyword) do |corrector|
|
65
|
+
corrector.replace(body.loc.begin, 'loop do')
|
66
|
+
corrector.remove(keyword_and_condition_range(node))
|
67
|
+
corrector.insert_before(body.loc.end, build_break_line(node))
|
68
|
+
end
|
69
|
+
end
|
70
|
+
|
71
|
+
def keyword_and_condition_range(node)
|
72
|
+
node.body.loc.end.end.join(node.source_range.end)
|
73
|
+
end
|
74
|
+
|
75
|
+
def build_break_line(node)
|
76
|
+
conditional_keyword = node.while_post_type? ? 'unless' : 'if'
|
77
|
+
"break #{conditional_keyword} #{node.condition.source}\n#{indent(node)}"
|
78
|
+
end
|
79
|
+
|
80
|
+
def indent(node)
|
81
|
+
' ' * node.loc.column
|
61
82
|
end
|
62
83
|
end
|
63
84
|
end
|
@@ -42,7 +42,7 @@ module RuboCop
|
|
42
42
|
# # Including this, that's 3 lines on which the cop is disabled.
|
43
43
|
# # rubocop:enable Layout/SpaceAroundOperators
|
44
44
|
#
|
45
|
-
class MissingCopEnableDirective <
|
45
|
+
class MissingCopEnableDirective < Base
|
46
46
|
include RangeHelp
|
47
47
|
|
48
48
|
MSG = 'Re-enable %<cop>s cop with `# rubocop:enable` after ' \
|
@@ -50,7 +50,8 @@ module RuboCop
|
|
50
50
|
MSG_BOUND = 'Re-enable %<cop>s cop within %<max_range>s lines after ' \
|
51
51
|
'disabling it.'
|
52
52
|
|
53
|
-
|
53
|
+
# rubocop:disable Metrics/AbcSize
|
54
|
+
def on_new_investigation
|
54
55
|
max_range = cop_config['MaximumRangeSize']
|
55
56
|
processed_source.disabled_line_ranges.each do |cop, line_ranges|
|
56
57
|
line_ranges.each do |line_range|
|
@@ -61,12 +62,12 @@ module RuboCop
|
|
61
62
|
range = source_range(processed_source.buffer,
|
62
63
|
line_range.min,
|
63
64
|
(0..0))
|
64
|
-
|
65
|
-
|
66
|
-
message: message(max_range: max_range, cop: cop))
|
65
|
+
|
66
|
+
add_offense(range, message: message(max_range: max_range, cop: cop))
|
67
67
|
end
|
68
68
|
end
|
69
69
|
end
|
70
|
+
# rubocop:enable Metrics/AbcSize
|
70
71
|
|
71
72
|
private
|
72
73
|
|
@@ -0,0 +1,99 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
module Lint
|
6
|
+
# This cop checks for the presence of constructors and lifecycle callbacks
|
7
|
+
# without calls to `super`.
|
8
|
+
#
|
9
|
+
# @example
|
10
|
+
# # bad
|
11
|
+
# class Employee < Person
|
12
|
+
# def initialize(name, salary)
|
13
|
+
# @salary = salary
|
14
|
+
# end
|
15
|
+
# end
|
16
|
+
#
|
17
|
+
# # good
|
18
|
+
# class Employee < Person
|
19
|
+
# def initialize(name, salary)
|
20
|
+
# super(name)
|
21
|
+
# @salary = salary
|
22
|
+
# end
|
23
|
+
# end
|
24
|
+
#
|
25
|
+
# # bad
|
26
|
+
# class Parent
|
27
|
+
# def self.inherited(base)
|
28
|
+
# do_something
|
29
|
+
# end
|
30
|
+
# end
|
31
|
+
#
|
32
|
+
# # good
|
33
|
+
# class Parent
|
34
|
+
# def self.inherited(base)
|
35
|
+
# super
|
36
|
+
# do_something
|
37
|
+
# end
|
38
|
+
# end
|
39
|
+
#
|
40
|
+
class MissingSuper < Base
|
41
|
+
CONSTRUCTOR_MSG = 'Call `super` to initialize state of the parent class.'
|
42
|
+
CALLBACK_MSG = 'Call `super` to invoke callback defined in the parent class.'
|
43
|
+
|
44
|
+
STATELESS_CLASSES = %w[BasicObject Object].freeze
|
45
|
+
|
46
|
+
OBJECT_LIFECYCLE_CALLBACKS = %i[method_missing respond_to_missing?].freeze
|
47
|
+
CLASS_LIFECYCLE_CALLBACKS = %i[inherited].freeze
|
48
|
+
METHOD_LIFECYCLE_CALLBACKS = %i[method_added method_removed method_undefined
|
49
|
+
singleton_method_added singleton_method_removed
|
50
|
+
singleton_method_undefined].freeze
|
51
|
+
|
52
|
+
CALLBACKS = (OBJECT_LIFECYCLE_CALLBACKS +
|
53
|
+
CLASS_LIFECYCLE_CALLBACKS +
|
54
|
+
METHOD_LIFECYCLE_CALLBACKS).to_set.freeze
|
55
|
+
|
56
|
+
def on_def(node)
|
57
|
+
return unless offender?(node)
|
58
|
+
|
59
|
+
if node.method?(:initialize)
|
60
|
+
add_offense(node, message: CONSTRUCTOR_MSG) if inside_class_with_stateful_parent?(node)
|
61
|
+
elsif callback_method_def?(node)
|
62
|
+
add_offense(node, message: CALLBACK_MSG)
|
63
|
+
end
|
64
|
+
end
|
65
|
+
|
66
|
+
def on_defs(node)
|
67
|
+
return if !callback_method_def?(node) || contains_super?(node)
|
68
|
+
|
69
|
+
add_offense(node, message: CALLBACK_MSG)
|
70
|
+
end
|
71
|
+
|
72
|
+
private
|
73
|
+
|
74
|
+
def offender?(node)
|
75
|
+
(node.method?(:initialize) || callback_method_def?(node)) && !contains_super?(node)
|
76
|
+
end
|
77
|
+
|
78
|
+
def callback_method_def?(node)
|
79
|
+
return unless CALLBACKS.include?(node.method_name)
|
80
|
+
|
81
|
+
node.each_ancestor(:class, :sclass, :module).first
|
82
|
+
end
|
83
|
+
|
84
|
+
def contains_super?(node)
|
85
|
+
node.each_descendant(:super, :zsuper).any?
|
86
|
+
end
|
87
|
+
|
88
|
+
def inside_class_with_stateful_parent?(node)
|
89
|
+
class_node = node.each_ancestor(:class).first
|
90
|
+
class_node&.parent_class && !stateless_class?(class_node.parent_class)
|
91
|
+
end
|
92
|
+
|
93
|
+
def stateless_class?(node)
|
94
|
+
STATELESS_CLASSES.include?(node.const_name)
|
95
|
+
end
|
96
|
+
end
|
97
|
+
end
|
98
|
+
end
|
99
|
+
end
|
@@ -21,7 +21,9 @@ module RuboCop
|
|
21
21
|
#
|
22
22
|
# x < y && y < z
|
23
23
|
# 10 <= x && x <= 20
|
24
|
-
class MultipleComparison <
|
24
|
+
class MultipleComparison < Base
|
25
|
+
extend AutoCorrector
|
26
|
+
|
25
27
|
MSG = 'Use the `&&` operator to compare multiple values.'
|
26
28
|
|
27
29
|
def_node_matcher :multiple_compare?, <<~PATTERN
|
@@ -29,16 +31,11 @@ module RuboCop
|
|
29
31
|
PATTERN
|
30
32
|
|
31
33
|
def on_send(node)
|
32
|
-
return unless multiple_compare?(node)
|
33
|
-
|
34
|
-
add_offense(node)
|
35
|
-
end
|
34
|
+
return unless (center = multiple_compare?(node))
|
36
35
|
|
37
|
-
|
38
|
-
|
39
|
-
new_center = "#{center.source} && #{center.source}"
|
36
|
+
add_offense(node) do |corrector|
|
37
|
+
new_center = "#{center.source} && #{center.source}"
|
40
38
|
|
41
|
-
lambda do |corrector|
|
42
39
|
corrector.replace(center, new_center)
|
43
40
|
end
|
44
41
|
end
|
@@ -54,36 +54,30 @@ module RuboCop
|
|
54
54
|
# end
|
55
55
|
# end
|
56
56
|
# end
|
57
|
-
class NestedMethodDefinition <
|
57
|
+
class NestedMethodDefinition < Base
|
58
58
|
MSG = 'Method definitions must not be nested. ' \
|
59
59
|
'Use `lambda` instead.'
|
60
60
|
|
61
61
|
def on_def(node)
|
62
|
-
|
63
|
-
|
64
|
-
end
|
65
|
-
end
|
66
|
-
alias on_defs on_def
|
67
|
-
|
68
|
-
private
|
62
|
+
subject, = *node
|
63
|
+
return if node.defs_type? && subject.lvar_type?
|
69
64
|
|
70
|
-
|
71
|
-
|
72
|
-
if child.def_type?
|
73
|
-
yield child
|
74
|
-
elsif child.defs_type?
|
75
|
-
subject, = *child
|
76
|
-
next if subject.lvar_type?
|
65
|
+
def_ancestor = node.each_ancestor(:def, :defs).first
|
66
|
+
return unless def_ancestor
|
77
67
|
|
78
|
-
|
79
|
-
|
80
|
-
|
68
|
+
within_scoping_def =
|
69
|
+
node.each_ancestor(:block, :sclass).any? do |ancestor|
|
70
|
+
scoping_method_call?(ancestor)
|
81
71
|
end
|
82
|
-
|
72
|
+
|
73
|
+
add_offense(node) if def_ancestor && !within_scoping_def
|
83
74
|
end
|
75
|
+
alias on_defs on_def
|
76
|
+
|
77
|
+
private
|
84
78
|
|
85
79
|
def scoping_method_call?(child)
|
86
|
-
eval_call?(child) || exec_call?(child) ||
|
80
|
+
child.sclass_type? || eval_call?(child) || exec_call?(child) ||
|
87
81
|
class_or_module_or_struct_new_call?(child)
|
88
82
|
end
|
89
83
|
|
@@ -96,7 +90,7 @@ module RuboCop
|
|
96
90
|
PATTERN
|
97
91
|
|
98
92
|
def_node_matcher :class_or_module_or_struct_new_call?, <<~PATTERN
|
99
|
-
(block (send (const nil? {:Class :Module :Struct}) :new ...) ...)
|
93
|
+
(block (send (const {nil? cbase} {:Class :Module :Struct}) :new ...) ...)
|
100
94
|
PATTERN
|
101
95
|
end
|
102
96
|
end
|
@@ -15,7 +15,7 @@ module RuboCop
|
|
15
15
|
# valid_attributes: %i[name content],
|
16
16
|
# nested_attributes: %i[name content %i[incorrectly nested]]
|
17
17
|
# }
|
18
|
-
class NestedPercentLiteral <
|
18
|
+
class NestedPercentLiteral < Base
|
19
19
|
include PercentLiteral
|
20
20
|
|
21
21
|
MSG = 'Within percent literals, nested percent literals do not ' \
|
@@ -35,7 +35,25 @@ module RuboCop
|
|
35
35
|
# require file
|
36
36
|
# end
|
37
37
|
#
|
38
|
-
|
38
|
+
# @example
|
39
|
+
#
|
40
|
+
# # bad
|
41
|
+
# Dir['./lib/**/*.rb'].each(&method(:require))
|
42
|
+
#
|
43
|
+
# # good
|
44
|
+
# Dir['./lib/**/*.rb'].sort.each(&method(:require))
|
45
|
+
#
|
46
|
+
# @example
|
47
|
+
#
|
48
|
+
# # bad
|
49
|
+
# Dir.glob(Rails.root.join('test', '*.rb'), &method(:require))
|
50
|
+
#
|
51
|
+
# # good
|
52
|
+
# Dir.glob(Rails.root.join('test', '*.rb')).sort.each(&method(:require))
|
53
|
+
#
|
54
|
+
class NonDeterministicRequireOrder < Base
|
55
|
+
extend AutoCorrector
|
56
|
+
|
39
57
|
MSG = 'Sort files before requiring them.'
|
40
58
|
|
41
59
|
def on_block(node)
|
@@ -45,35 +63,88 @@ module RuboCop
|
|
45
63
|
loop_variable(node.arguments) do |var_name|
|
46
64
|
return unless var_is_required?(node.body, var_name)
|
47
65
|
|
48
|
-
add_offense(node.send_node)
|
66
|
+
add_offense(node.send_node) do |corrector|
|
67
|
+
correct_block(corrector, node.send_node)
|
68
|
+
end
|
49
69
|
end
|
50
70
|
end
|
51
71
|
|
52
|
-
def
|
53
|
-
|
54
|
-
|
55
|
-
|
56
|
-
|
57
|
-
|
58
|
-
|
59
|
-
|
60
|
-
corrector
|
72
|
+
def on_block_pass(node)
|
73
|
+
return unless method_require?(node)
|
74
|
+
return unless unsorted_dir_pass?(node.parent)
|
75
|
+
|
76
|
+
parent_node = node.parent
|
77
|
+
|
78
|
+
add_offense(parent_node) do |corrector|
|
79
|
+
if parent_node.arguments.last&.block_pass_type?
|
80
|
+
correct_block_pass(corrector, parent_node)
|
81
|
+
else
|
82
|
+
correct_block(corrector, parent_node)
|
61
83
|
end
|
62
84
|
end
|
63
85
|
end
|
64
86
|
|
65
87
|
private
|
66
88
|
|
89
|
+
def correct_block(corrector, node)
|
90
|
+
if unsorted_dir_block?(node)
|
91
|
+
corrector.replace(node, "#{node.source}.sort.each")
|
92
|
+
else
|
93
|
+
source = node.receiver.source
|
94
|
+
|
95
|
+
corrector.replace(node, "#{source}.sort.each")
|
96
|
+
end
|
97
|
+
end
|
98
|
+
|
99
|
+
def correct_block_pass(corrector, node)
|
100
|
+
if unsorted_dir_glob_pass?(node)
|
101
|
+
block_arg = node.arguments.last
|
102
|
+
|
103
|
+
corrector.remove(last_arg_range(node))
|
104
|
+
corrector.insert_after(node, ".sort.each(#{block_arg.source})")
|
105
|
+
else
|
106
|
+
corrector.replace(node.loc.selector, 'sort.each')
|
107
|
+
end
|
108
|
+
end
|
109
|
+
|
110
|
+
# Returns range of last argument including comma and whitespace.
|
111
|
+
#
|
112
|
+
# @return [Parser::Source::Range]
|
113
|
+
#
|
114
|
+
def last_arg_range(node)
|
115
|
+
node.arguments.last.source_range.with(
|
116
|
+
begin_pos: node.arguments[-2].source_range.end_pos
|
117
|
+
)
|
118
|
+
end
|
119
|
+
|
67
120
|
def unsorted_dir_loop?(node)
|
68
121
|
unsorted_dir_block?(node) || unsorted_dir_each?(node)
|
69
122
|
end
|
70
123
|
|
124
|
+
def unsorted_dir_pass?(node)
|
125
|
+
unsorted_dir_glob_pass?(node) || unsorted_dir_each_pass?(node)
|
126
|
+
end
|
127
|
+
|
71
128
|
def_node_matcher :unsorted_dir_block?, <<~PATTERN
|
72
|
-
(send (const nil? :Dir) :glob ...)
|
129
|
+
(send (const {nil? cbase} :Dir) :glob ...)
|
73
130
|
PATTERN
|
74
131
|
|
75
132
|
def_node_matcher :unsorted_dir_each?, <<~PATTERN
|
76
|
-
(send (send (const nil? :Dir) {:[] :glob} ...) :each)
|
133
|
+
(send (send (const {nil? cbase} :Dir) {:[] :glob} ...) :each)
|
134
|
+
PATTERN
|
135
|
+
|
136
|
+
def_node_matcher :method_require?, <<~PATTERN
|
137
|
+
(block-pass (send nil? :method (sym :require)))
|
138
|
+
PATTERN
|
139
|
+
|
140
|
+
def_node_matcher :unsorted_dir_glob_pass?, <<~PATTERN
|
141
|
+
(send (const {nil? cbase} :Dir) :glob ...
|
142
|
+
(block-pass (send nil? :method (sym :require))))
|
143
|
+
PATTERN
|
144
|
+
|
145
|
+
def_node_matcher :unsorted_dir_each_pass?, <<~PATTERN
|
146
|
+
(send (send (const {nil? cbase} :Dir) {:[] :glob} ...) :each
|
147
|
+
(block-pass (send nil? :method (sym :require))))
|
77
148
|
PATTERN
|
78
149
|
|
79
150
|
def_node_matcher :loop_variable, <<~PATTERN
|