rubocop 0.81.0 → 0.82.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (142) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +2 -2
  3. data/config/default.yml +59 -13
  4. data/lib/rubocop.rb +4 -2
  5. data/lib/rubocop/ast/node.rb +1 -1
  6. data/lib/rubocop/ast/node/array_node.rb +13 -0
  7. data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +8 -0
  8. data/lib/rubocop/cli.rb +10 -4
  9. data/lib/rubocop/config.rb +9 -1
  10. data/lib/rubocop/config_loader.rb +24 -15
  11. data/lib/rubocop/config_loader_resolver.rb +1 -1
  12. data/lib/rubocop/config_obsoletion.rb +1 -0
  13. data/lib/rubocop/config_validator.rb +16 -0
  14. data/lib/rubocop/cop/badge.rb +5 -5
  15. data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +1 -1
  16. data/lib/rubocop/cop/corrector.rb +48 -24
  17. data/lib/rubocop/cop/correctors/alignment_corrector.rb +2 -2
  18. data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -2
  19. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
  20. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +3 -3
  21. data/lib/rubocop/cop/correctors/line_break_corrector.rb +2 -2
  22. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
  23. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +2 -2
  24. data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +1 -1
  25. data/lib/rubocop/cop/layout/dot_position.rb +1 -1
  26. data/lib/rubocop/cop/layout/end_of_line.rb +2 -2
  27. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +16 -10
  28. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +1 -1
  29. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +2 -2
  30. data/lib/rubocop/cop/layout/heredoc_indentation.rb +2 -2
  31. data/lib/rubocop/cop/layout/{tab.rb → indentation_style.rb} +48 -6
  32. data/lib/rubocop/cop/layout/leading_comment_space.rb +1 -1
  33. data/lib/rubocop/cop/layout/line_length.rb +2 -2
  34. data/lib/rubocop/cop/layout/multiline_block_layout.rb +1 -1
  35. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +3 -3
  36. data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +133 -0
  37. data/lib/rubocop/cop/layout/space_around_operators.rb +1 -1
  38. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +1 -1
  39. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +2 -2
  40. data/lib/rubocop/cop/layout/space_inside_range_literal.rb +2 -2
  41. data/lib/rubocop/cop/lint/boolean_symbol.rb +2 -2
  42. data/lib/rubocop/cop/lint/debugger.rb +1 -1
  43. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +1 -1
  44. data/lib/rubocop/cop/lint/inherit_exception.rb +1 -1
  45. data/lib/rubocop/cop/lint/interpolation_check.rb +1 -1
  46. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +1 -1
  47. data/lib/rubocop/cop/lint/multiple_comparison.rb +1 -1
  48. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +2 -2
  49. data/lib/rubocop/cop/lint/number_conversion.rb +1 -1
  50. data/lib/rubocop/cop/lint/percent_string_array.rb +2 -2
  51. data/lib/rubocop/cop/lint/raise_exception.rb +42 -6
  52. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -1
  53. data/lib/rubocop/cop/lint/unified_integer.rb +0 -2
  54. data/lib/rubocop/cop/lint/uri_regexp.rb +4 -4
  55. data/lib/rubocop/cop/mixin/hash_transform_method.rb +1 -1
  56. data/lib/rubocop/cop/mixin/line_length_help.rb +1 -1
  57. data/lib/rubocop/cop/mixin/statement_modifier.rb +4 -3
  58. data/lib/rubocop/cop/mixin/trailing_comma.rb +1 -1
  59. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +1 -1
  60. data/lib/rubocop/cop/naming/constant_name.rb +2 -1
  61. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +1 -1
  62. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +1 -1
  63. data/lib/rubocop/cop/registry.rb +11 -4
  64. data/lib/rubocop/cop/style/alias.rb +4 -4
  65. data/lib/rubocop/cop/style/and_or.rb +5 -6
  66. data/lib/rubocop/cop/style/array_join.rb +1 -1
  67. data/lib/rubocop/cop/style/case_equality.rb +24 -1
  68. data/lib/rubocop/cop/style/character_literal.rb +2 -2
  69. data/lib/rubocop/cop/style/conditional_assignment.rb +8 -8
  70. data/lib/rubocop/cop/style/copyright.rb +1 -1
  71. data/lib/rubocop/cop/style/dir.rb +1 -1
  72. data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +49 -0
  73. data/lib/rubocop/cop/style/double_cop_disable_directive.rb +1 -1
  74. data/lib/rubocop/cop/style/each_for_simple_loop.rb +1 -1
  75. data/lib/rubocop/cop/style/each_with_object.rb +3 -3
  76. data/lib/rubocop/cop/style/empty_method.rb +1 -1
  77. data/lib/rubocop/cop/style/even_odd.rb +1 -1
  78. data/lib/rubocop/cop/style/expand_path_arguments.rb +3 -3
  79. data/lib/rubocop/cop/style/exponential_notation.rb +119 -0
  80. data/lib/rubocop/cop/style/format_string.rb +2 -2
  81. data/lib/rubocop/cop/style/hash_each_methods.rb +3 -3
  82. data/lib/rubocop/cop/style/hash_syntax.rb +3 -5
  83. data/lib/rubocop/cop/style/hash_transform_values.rb +0 -3
  84. data/lib/rubocop/cop/style/if_unless_modifier.rb +23 -3
  85. data/lib/rubocop/cop/style/lambda.rb +2 -2
  86. data/lib/rubocop/cop/style/lambda_call.rb +2 -2
  87. data/lib/rubocop/cop/style/mixin_grouping.rb +1 -1
  88. data/lib/rubocop/cop/style/module_function.rb +2 -2
  89. data/lib/rubocop/cop/style/multiline_if_modifier.rb +1 -1
  90. data/lib/rubocop/cop/style/multiline_memoization.rb +1 -1
  91. data/lib/rubocop/cop/style/mutable_constant.rb +2 -4
  92. data/lib/rubocop/cop/style/next.rb +2 -2
  93. data/lib/rubocop/cop/style/nil_comparison.rb +1 -1
  94. data/lib/rubocop/cop/style/non_nil_check.rb +4 -4
  95. data/lib/rubocop/cop/style/not.rb +1 -1
  96. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +1 -1
  97. data/lib/rubocop/cop/style/numeric_literals.rb +1 -1
  98. data/lib/rubocop/cop/style/numeric_predicate.rb +1 -1
  99. data/lib/rubocop/cop/style/one_line_conditional.rb +1 -1
  100. data/lib/rubocop/cop/style/or_assignment.rb +1 -1
  101. data/lib/rubocop/cop/style/percent_q_literals.rb +1 -1
  102. data/lib/rubocop/cop/style/perl_backrefs.rb +2 -2
  103. data/lib/rubocop/cop/style/proc.rb +1 -1
  104. data/lib/rubocop/cop/style/raise_args.rb +1 -1
  105. data/lib/rubocop/cop/style/random_with_offset.rb +3 -3
  106. data/lib/rubocop/cop/style/redundant_condition.rb +3 -4
  107. data/lib/rubocop/cop/style/redundant_conditional.rb +1 -1
  108. data/lib/rubocop/cop/style/redundant_exception.rb +3 -3
  109. data/lib/rubocop/cop/style/redundant_interpolation.rb +2 -2
  110. data/lib/rubocop/cop/style/redundant_percent_q.rb +2 -2
  111. data/lib/rubocop/cop/style/redundant_return.rb +5 -7
  112. data/lib/rubocop/cop/style/redundant_self.rb +1 -1
  113. data/lib/rubocop/cop/style/rescue_modifier.rb +1 -1
  114. data/lib/rubocop/cop/style/return_nil.rb +1 -1
  115. data/lib/rubocop/cop/style/safe_navigation.rb +1 -1
  116. data/lib/rubocop/cop/style/self_assignment.rb +1 -1
  117. data/lib/rubocop/cop/style/special_global_vars.rb +1 -1
  118. data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +1 -4
  119. data/lib/rubocop/cop/style/string_hash_keys.rb +1 -1
  120. data/lib/rubocop/cop/style/symbol_array.rb +1 -1
  121. data/lib/rubocop/cop/style/symbol_literal.rb +2 -2
  122. data/lib/rubocop/cop/style/ternary_parentheses.rb +1 -2
  123. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +2 -1
  124. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +3 -0
  125. data/lib/rubocop/cop/style/trivial_accessors.rb +1 -1
  126. data/lib/rubocop/cop/style/unpack_first.rb +0 -4
  127. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  128. data/lib/rubocop/cop/style/while_until_modifier.rb +1 -1
  129. data/lib/rubocop/cop/style/word_array.rb +1 -1
  130. data/lib/rubocop/cop/style/zero_length_predicate.rb +1 -1
  131. data/lib/rubocop/formatter/formatter_set.rb +0 -1
  132. data/lib/rubocop/formatter/pacman_formatter.rb +1 -1
  133. data/lib/rubocop/options.rb +7 -1
  134. data/lib/rubocop/processed_source.rb +0 -3
  135. data/lib/rubocop/rspec/cop_helper.rb +1 -1
  136. data/lib/rubocop/rspec/expect_offense.rb +1 -1
  137. data/lib/rubocop/rspec/shared_contexts.rb +0 -4
  138. data/lib/rubocop/runner.rb +1 -1
  139. data/lib/rubocop/target_ruby.rb +2 -2
  140. data/lib/rubocop/version.rb +1 -1
  141. metadata +7 -5
  142. data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
@@ -69,7 +69,7 @@ module RuboCop
69
69
  def correct_with_parens(range, node)
70
70
  lambda do |corrector|
71
71
  corrector.replace(range, '!(')
72
- corrector.insert_after(node.source_range, ')')
72
+ corrector.insert_after(node, ')')
73
73
  end
74
74
  end
75
75
 
@@ -59,7 +59,7 @@ module RuboCop
59
59
  def autocorrect(node)
60
60
  lambda do |corrector|
61
61
  type = literal_type(node)
62
- corrector.replace(node.source_range,
62
+ corrector.replace(node,
63
63
  send(:"format_#{type}", node.source))
64
64
  end
65
65
  end
@@ -48,7 +48,7 @@ module RuboCop
48
48
 
49
49
  def autocorrect(node)
50
50
  lambda do |corrector|
51
- corrector.replace(node.source_range, format_number(node))
51
+ corrector.replace(node, format_number(node))
52
52
  end
53
53
  end
54
54
 
@@ -73,7 +73,7 @@ module RuboCop
73
73
  _, replacement = check(node)
74
74
 
75
75
  lambda do |corrector|
76
- corrector.replace(node.loc.expression, replacement)
76
+ corrector.replace(node, replacement)
77
77
  end
78
78
  end
79
79
 
@@ -36,7 +36,7 @@ module RuboCop
36
36
 
37
37
  def autocorrect(node)
38
38
  lambda do |corrector|
39
- corrector.replace(node.source_range, replacement(node))
39
+ corrector.replace(node, replacement(node))
40
40
  end
41
41
  end
42
42
 
@@ -69,7 +69,7 @@ module RuboCop
69
69
  end
70
70
 
71
71
  lambda do |corrector|
72
- corrector.replace(node.source_range,
72
+ corrector.replace(node,
73
73
  "#{variable} ||= #{default.source}")
74
74
  end
75
75
  end
@@ -39,7 +39,7 @@ module RuboCop
39
39
 
40
40
  def autocorrect(node)
41
41
  lambda do |corrector|
42
- corrector.replace(node.source_range, corrected(node.source))
42
+ corrector.replace(node, corrected(node.source))
43
43
  end
44
44
  end
45
45
 
@@ -24,10 +24,10 @@ module RuboCop
24
24
  backref, = *node
25
25
  parent_type = node.parent ? node.parent.type : nil
26
26
  if %i[dstr xstr regexp].include?(parent_type)
27
- corrector.replace(node.source_range,
27
+ corrector.replace(node,
28
28
  "{Regexp.last_match(#{backref})}")
29
29
  else
30
- corrector.replace(node.source_range,
30
+ corrector.replace(node,
31
31
  "Regexp.last_match(#{backref})")
32
32
  end
33
33
  end
@@ -26,7 +26,7 @@ module RuboCop
26
26
  end
27
27
 
28
28
  def autocorrect(node)
29
- ->(corrector) { corrector.replace(node.source_range, 'proc') }
29
+ ->(corrector) { corrector.replace(node, 'proc') }
30
30
  end
31
31
  end
32
32
  end
@@ -58,7 +58,7 @@ module RuboCop
58
58
  correction_compact_to_exploded(node)
59
59
  end
60
60
 
61
- ->(corrector) { corrector.replace(node.source_range, replacement) }
61
+ ->(corrector) { corrector.replace(node, replacement) }
62
62
  end
63
63
 
64
64
  private
@@ -66,13 +66,13 @@ module RuboCop
66
66
  def autocorrect(node)
67
67
  lambda do |corrector|
68
68
  if integer_op_rand?(node)
69
- corrector.replace(node.source_range,
69
+ corrector.replace(node,
70
70
  corrected_integer_op_rand(node))
71
71
  elsif rand_op_integer?(node)
72
- corrector.replace(node.source_range,
72
+ corrector.replace(node,
73
73
  corrected_rand_op_integer(node))
74
74
  elsif rand_modified?(node)
75
- corrector.replace(node.source_range,
75
+ corrector.replace(node,
76
76
  corrected_rand_modified(node))
77
77
  end
78
78
  end
@@ -48,11 +48,11 @@ module RuboCop
48
48
  if node.ternary?
49
49
  correct_ternary(corrector, node)
50
50
  elsif node.modifier_form? || !node.else_branch
51
- corrector.replace(node.source_range, node.if_branch.source)
51
+ corrector.replace(node, node.if_branch.source)
52
52
  else
53
53
  corrected = make_ternary_form(node)
54
54
 
55
- corrector.replace(node.source_range, corrected)
55
+ corrector.replace(node, corrected)
56
56
  end
57
57
  end
58
58
  end
@@ -116,8 +116,7 @@ module RuboCop
116
116
 
117
117
  return unless node.else_branch.range_type?
118
118
 
119
- corrector.insert_before(node.else_branch.loc.expression, '(')
120
- corrector.insert_after(node.else_branch.loc.expression, ')')
119
+ corrector.wrap(node.else_branch, '(', ')')
121
120
  end
122
121
  end
123
122
  end
@@ -40,7 +40,7 @@ module RuboCop
40
40
 
41
41
  def autocorrect(node)
42
42
  lambda do |corrector|
43
- corrector.replace(node.loc.expression, replacement_condition(node))
43
+ corrector.replace(node, replacement_condition(node))
44
44
  end
45
45
  end
46
46
 
@@ -32,17 +32,17 @@ module RuboCop
32
32
  exploded?(node) do |command, message|
33
33
  return lambda do |corrector|
34
34
  if node.parenthesized?
35
- corrector.replace(node.source_range,
35
+ corrector.replace(node,
36
36
  "#{command}(#{message.source})")
37
37
  else
38
- corrector.replace(node.source_range,
38
+ corrector.replace(node,
39
39
  "#{command} #{message.source}")
40
40
  end
41
41
  end
42
42
  end
43
43
  compact?(node) do |new_call, message|
44
44
  lambda do |corrector|
45
- corrector.replace(new_call.source_range, message.source)
45
+ corrector.replace(new_call, message.source)
46
46
  end
47
47
  end
48
48
  end
@@ -72,13 +72,13 @@ module RuboCop
72
72
 
73
73
  def autocorrect_variable_interpolation(embedded_node, node)
74
74
  replacement = "#{embedded_node.loc.expression.source}.to_s"
75
- ->(corrector) { corrector.replace(node.loc.expression, replacement) }
75
+ ->(corrector) { corrector.replace(node, replacement) }
76
76
  end
77
77
 
78
78
  def autocorrect_single_variable_interpolation(embedded_node, node)
79
79
  variable_loc = embedded_node.children.first.loc
80
80
  replacement = "#{variable_loc.expression.source}.to_s"
81
- ->(corrector) { corrector.replace(node.loc.expression, replacement) }
81
+ ->(corrector) { corrector.replace(node, replacement) }
82
82
  end
83
83
 
84
84
  def autocorrect_other(embedded_node, node)
@@ -47,7 +47,7 @@ module RuboCop
47
47
 
48
48
  def autocorrect(node)
49
49
  delimiter =
50
- node.source =~ /^%Q[^"]+$|'/ ? QUOTE : SINGLE_QUOTE
50
+ /^%Q[^"]+$|'/.match?(node.source) ? QUOTE : SINGLE_QUOTE
51
51
  lambda do |corrector|
52
52
  corrector.replace(node.loc.begin, delimiter)
53
53
  corrector.replace(node.loc.end, delimiter)
@@ -95,7 +95,7 @@ module RuboCop
95
95
  def acceptable_q?(node)
96
96
  src = node.source
97
97
 
98
- return true if src =~ STRING_INTERPOLATION_REGEXP
98
+ return true if STRING_INTERPOLATION_REGEXP.match?(src)
99
99
 
100
100
  src.scan(/\\./).any? { |s| s =~ ESCAPED_NON_BACKSLASH }
101
101
  end
@@ -71,7 +71,7 @@ module RuboCop
71
71
  private
72
72
 
73
73
  def correct_without_arguments(return_node, corrector)
74
- corrector.replace(return_node.source_range, 'nil')
74
+ corrector.replace(return_node, 'nil')
75
75
  end
76
76
 
77
77
  def correct_with_arguments(return_node, corrector)
@@ -91,15 +91,13 @@ module RuboCop
91
91
  end
92
92
 
93
93
  def add_brackets(corrector, node)
94
- kids = node.children.map(&:source_range)
95
- corrector.insert_before(kids.first, '[')
96
- corrector.insert_after(kids.last, ']')
94
+ corrector.insert_before(node.children.first, '[')
95
+ corrector.insert_after(node.children.last, ']')
97
96
  end
98
97
 
99
98
  def add_braces(corrector, node)
100
- kids = node.children.map(&:source_range)
101
- corrector.insert_before(kids.first, '{')
102
- corrector.insert_after(kids.last, '}')
99
+ corrector.insert_before(node.children.first, '{')
100
+ corrector.insert_after(node.children.last, '}')
103
101
  end
104
102
 
105
103
  # rubocop:disable Metrics/CyclomaticComplexity
@@ -110,7 +110,7 @@ module RuboCop
110
110
 
111
111
  def autocorrect(node)
112
112
  lambda do |corrector|
113
- corrector.remove(node.receiver.source_range)
113
+ corrector.remove(node.receiver)
114
114
  corrector.remove(node.loc.dot)
115
115
  end
116
116
  end
@@ -64,7 +64,7 @@ module RuboCop
64
64
  "\n#{offset(node)}end"
65
65
 
66
66
  lambda do |corrector|
67
- corrector.replace(node.source_range, correction)
67
+ corrector.replace(node, correction)
68
68
  end
69
69
  end
70
70
  end
@@ -60,7 +60,7 @@ module RuboCop
60
60
  def autocorrect(node)
61
61
  lambda do |corrector|
62
62
  corrected = style == :return ? 'return' : 'return nil'
63
- corrector.replace(node.source_range, corrected)
63
+ corrector.replace(node, corrected)
64
64
  end
65
65
  end
66
66
 
@@ -131,7 +131,7 @@ module RuboCop
131
131
  comments = comments(node)
132
132
  return if comments.empty?
133
133
 
134
- corrector.insert_before(method_call.loc.expression,
134
+ corrector.insert_before(method_call,
135
135
  "#{comments.map(&:text).join("\n")}\n")
136
136
  end
137
137
 
@@ -88,7 +88,7 @@ module RuboCop
88
88
  def apply_autocorrect(node, rhs, operator, new_rhs)
89
89
  lambda do |corrector|
90
90
  corrector.insert_before(node.loc.operator, operator)
91
- corrector.replace(rhs.source_range, new_rhs.source)
91
+ corrector.replace(rhs, new_rhs.source)
92
92
  end
93
93
  end
94
94
  end
@@ -145,7 +145,7 @@ module RuboCop
145
145
  node = node.parent
146
146
  end
147
147
 
148
- corrector.replace(node.source_range, replacement(node, global_var))
148
+ corrector.replace(node, replacement(node, global_var))
149
149
  end
150
150
  end
151
151
 
@@ -57,10 +57,7 @@ module RuboCop
57
57
 
58
58
  def missing_parentheses_corrector(node)
59
59
  lambda do |corrector|
60
- args_loc = node.loc.expression
61
-
62
- corrector.insert_before(args_loc, '(')
63
- corrector.insert_after(args_loc, ')')
60
+ corrector.wrap(node, '(', ')')
64
61
  end
65
62
  end
66
63
 
@@ -41,7 +41,7 @@ module RuboCop
41
41
  def autocorrect(node)
42
42
  lambda do |corrector|
43
43
  symbol_content = node.str_content.to_sym.inspect
44
- corrector.replace(node.source_range, symbol_content)
44
+ corrector.replace(node, symbol_content)
45
45
  end
46
46
  end
47
47
  end
@@ -81,7 +81,7 @@ module RuboCop
81
81
  end
82
82
 
83
83
  lambda do |corrector|
84
- corrector.replace(node.source_range, "[#{syms.join(', ')}]")
84
+ corrector.replace(node, "[#{syms.join(', ')}]")
85
85
  end
86
86
  end
87
87
 
@@ -16,14 +16,14 @@ module RuboCop
16
16
  MSG = 'Do not use strings for word-like symbol literals.'
17
17
 
18
18
  def on_sym(node)
19
- return unless node.source =~ /\A:["'][A-Za-z_]\w*["']\z/
19
+ return unless /\A:["'][A-Za-z_]\w*["']\z/.match?(node.source)
20
20
 
21
21
  add_offense(node)
22
22
  end
23
23
 
24
24
  def autocorrect(node)
25
25
  lambda do |corrector|
26
- corrector.replace(node.source_range, node.source.delete(%q('")))
26
+ corrector.replace(node, node.source.delete(%q('")))
27
27
  end
28
28
  end
29
29
  end
@@ -207,8 +207,7 @@ module RuboCop
207
207
 
208
208
  def correct_unparenthesized(condition)
209
209
  lambda do |corrector|
210
- corrector.insert_before(condition.source_range, '(')
211
- corrector.insert_after(condition.source_range, ')')
210
+ corrector.wrap(condition, '(', ')')
212
211
  end
213
212
  end
214
213
 
@@ -10,7 +10,8 @@ module RuboCop
10
10
  # for all parenthesized method calls with arguments.
11
11
  # - `comma`: Requires a comma after the last argument, but only for
12
12
  # parenthesized method calls where each argument is on its own line.
13
- # - `no_comma`: Does not requires a comma after the last argument.
13
+ # - `no_comma`: Requires that there is no comma after the last
14
+ # argument.
14
15
  #
15
16
  # @example EnforcedStyleForMultiline: consistent_comma
16
17
  # # bad
@@ -44,6 +44,9 @@ module RuboCop
44
44
  MSG = 'Useless trailing comma present in block arguments.'
45
45
 
46
46
  def on_block(node)
47
+ # lambda literal (`->`) never has block arguments.
48
+ return if node.send_node.lambda_literal?
49
+
47
50
  return unless useless_trailing_comma?(node)
48
51
 
49
52
  add_offense(node, location: last_comma(node).pos)
@@ -161,7 +161,7 @@ module RuboCop
161
161
  return unless names_match?(node) && !node.predicate_method? && kind
162
162
 
163
163
  lambda do |corrector|
164
- corrector.replace(node.source_range,
164
+ corrector.replace(node,
165
165
  accessor(kind, node.method_name))
166
166
  end
167
167
  end
@@ -18,10 +18,6 @@ module RuboCop
18
18
  # 'foo'.unpack1('h*')
19
19
  #
20
20
  class UnpackFirst < Cop
21
- extend TargetRubyVersion
22
-
23
- minimum_target_ruby_version 2.4
24
-
25
21
  MSG = 'Use `%<receiver>s.unpack1(%<format>s)` instead of '\
26
22
  '`%<receiver>s.unpack(%<format>s)%<method>s`.'
27
23
 
@@ -29,7 +29,7 @@ module RuboCop
29
29
 
30
30
  def autocorrect(node)
31
31
  lambda do |corrector|
32
- corrector.replace(node.source_range, "{#{node.source}}")
32
+ corrector.replace(node, "{#{node.source}}")
33
33
  end
34
34
  end
35
35
 
@@ -43,7 +43,7 @@ module RuboCop
43
43
  "#{node.condition.source}"
44
44
 
45
45
  lambda do |corrector|
46
- corrector.replace(node.source_range, oneline)
46
+ corrector.replace(node, oneline)
47
47
  end
48
48
  end
49
49
 
@@ -93,7 +93,7 @@ module RuboCop
93
93
  end
94
94
 
95
95
  lambda do |corrector|
96
- corrector.replace(node.source_range, "[#{words.join(', ')}]")
96
+ corrector.replace(node, "[#{words.join(', ')}]")
97
97
  end
98
98
  end
99
99
  end
@@ -37,7 +37,7 @@ module RuboCop
37
37
 
38
38
  def autocorrect(node)
39
39
  lambda do |corrector|
40
- corrector.replace(node.loc.expression, replacement(node))
40
+ corrector.replace(node, replacement(node))
41
41
  end
42
42
  end
43
43
 
@@ -11,7 +11,6 @@ module RuboCop
11
11
  BUILTIN_FORMATTERS_FOR_KEYS = {
12
12
  '[a]utogenconf' => AutoGenConfigFormatter,
13
13
  '[c]lang' => ClangStyleFormatter,
14
- '[d]isabled' => DisabledLinesFormatter,
15
14
  '[e]macs' => EmacsStyleFormatter,
16
15
  '[fi]les' => FileListFormatter,
17
16
  '[fu]ubar' => FuubarStyleFormatter,