rubocop 0.81.0 → 0.82.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (142) hide show
  1. checksums.yaml +4 -4
  2. data/README.md +2 -2
  3. data/config/default.yml +59 -13
  4. data/lib/rubocop.rb +4 -2
  5. data/lib/rubocop/ast/node.rb +1 -1
  6. data/lib/rubocop/ast/node/array_node.rb +13 -0
  7. data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +8 -0
  8. data/lib/rubocop/cli.rb +10 -4
  9. data/lib/rubocop/config.rb +9 -1
  10. data/lib/rubocop/config_loader.rb +24 -15
  11. data/lib/rubocop/config_loader_resolver.rb +1 -1
  12. data/lib/rubocop/config_obsoletion.rb +1 -0
  13. data/lib/rubocop/config_validator.rb +16 -0
  14. data/lib/rubocop/cop/badge.rb +5 -5
  15. data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +1 -1
  16. data/lib/rubocop/cop/corrector.rb +48 -24
  17. data/lib/rubocop/cop/correctors/alignment_corrector.rb +2 -2
  18. data/lib/rubocop/cop/correctors/condition_corrector.rb +1 -2
  19. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +1 -1
  20. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +3 -3
  21. data/lib/rubocop/cop/correctors/line_break_corrector.rb +2 -2
  22. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
  23. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +2 -2
  24. data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +1 -1
  25. data/lib/rubocop/cop/layout/dot_position.rb +1 -1
  26. data/lib/rubocop/cop/layout/end_of_line.rb +2 -2
  27. data/lib/rubocop/cop/layout/first_array_element_indentation.rb +16 -10
  28. data/lib/rubocop/cop/layout/first_hash_element_indentation.rb +1 -1
  29. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +2 -2
  30. data/lib/rubocop/cop/layout/heredoc_indentation.rb +2 -2
  31. data/lib/rubocop/cop/layout/{tab.rb → indentation_style.rb} +48 -6
  32. data/lib/rubocop/cop/layout/leading_comment_space.rb +1 -1
  33. data/lib/rubocop/cop/layout/line_length.rb +2 -2
  34. data/lib/rubocop/cop/layout/multiline_block_layout.rb +1 -1
  35. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +3 -3
  36. data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +133 -0
  37. data/lib/rubocop/cop/layout/space_around_operators.rb +1 -1
  38. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +1 -1
  39. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +2 -2
  40. data/lib/rubocop/cop/layout/space_inside_range_literal.rb +2 -2
  41. data/lib/rubocop/cop/lint/boolean_symbol.rb +2 -2
  42. data/lib/rubocop/cop/lint/debugger.rb +1 -1
  43. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +1 -1
  44. data/lib/rubocop/cop/lint/inherit_exception.rb +1 -1
  45. data/lib/rubocop/cop/lint/interpolation_check.rb +1 -1
  46. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +1 -1
  47. data/lib/rubocop/cop/lint/multiple_comparison.rb +1 -1
  48. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +2 -2
  49. data/lib/rubocop/cop/lint/number_conversion.rb +1 -1
  50. data/lib/rubocop/cop/lint/percent_string_array.rb +2 -2
  51. data/lib/rubocop/cop/lint/raise_exception.rb +42 -6
  52. data/lib/rubocop/cop/lint/redundant_string_coercion.rb +1 -1
  53. data/lib/rubocop/cop/lint/unified_integer.rb +0 -2
  54. data/lib/rubocop/cop/lint/uri_regexp.rb +4 -4
  55. data/lib/rubocop/cop/mixin/hash_transform_method.rb +1 -1
  56. data/lib/rubocop/cop/mixin/line_length_help.rb +1 -1
  57. data/lib/rubocop/cop/mixin/statement_modifier.rb +4 -3
  58. data/lib/rubocop/cop/mixin/trailing_comma.rb +1 -1
  59. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +1 -1
  60. data/lib/rubocop/cop/naming/constant_name.rb +2 -1
  61. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +1 -1
  62. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +1 -1
  63. data/lib/rubocop/cop/registry.rb +11 -4
  64. data/lib/rubocop/cop/style/alias.rb +4 -4
  65. data/lib/rubocop/cop/style/and_or.rb +5 -6
  66. data/lib/rubocop/cop/style/array_join.rb +1 -1
  67. data/lib/rubocop/cop/style/case_equality.rb +24 -1
  68. data/lib/rubocop/cop/style/character_literal.rb +2 -2
  69. data/lib/rubocop/cop/style/conditional_assignment.rb +8 -8
  70. data/lib/rubocop/cop/style/copyright.rb +1 -1
  71. data/lib/rubocop/cop/style/dir.rb +1 -1
  72. data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +49 -0
  73. data/lib/rubocop/cop/style/double_cop_disable_directive.rb +1 -1
  74. data/lib/rubocop/cop/style/each_for_simple_loop.rb +1 -1
  75. data/lib/rubocop/cop/style/each_with_object.rb +3 -3
  76. data/lib/rubocop/cop/style/empty_method.rb +1 -1
  77. data/lib/rubocop/cop/style/even_odd.rb +1 -1
  78. data/lib/rubocop/cop/style/expand_path_arguments.rb +3 -3
  79. data/lib/rubocop/cop/style/exponential_notation.rb +119 -0
  80. data/lib/rubocop/cop/style/format_string.rb +2 -2
  81. data/lib/rubocop/cop/style/hash_each_methods.rb +3 -3
  82. data/lib/rubocop/cop/style/hash_syntax.rb +3 -5
  83. data/lib/rubocop/cop/style/hash_transform_values.rb +0 -3
  84. data/lib/rubocop/cop/style/if_unless_modifier.rb +23 -3
  85. data/lib/rubocop/cop/style/lambda.rb +2 -2
  86. data/lib/rubocop/cop/style/lambda_call.rb +2 -2
  87. data/lib/rubocop/cop/style/mixin_grouping.rb +1 -1
  88. data/lib/rubocop/cop/style/module_function.rb +2 -2
  89. data/lib/rubocop/cop/style/multiline_if_modifier.rb +1 -1
  90. data/lib/rubocop/cop/style/multiline_memoization.rb +1 -1
  91. data/lib/rubocop/cop/style/mutable_constant.rb +2 -4
  92. data/lib/rubocop/cop/style/next.rb +2 -2
  93. data/lib/rubocop/cop/style/nil_comparison.rb +1 -1
  94. data/lib/rubocop/cop/style/non_nil_check.rb +4 -4
  95. data/lib/rubocop/cop/style/not.rb +1 -1
  96. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +1 -1
  97. data/lib/rubocop/cop/style/numeric_literals.rb +1 -1
  98. data/lib/rubocop/cop/style/numeric_predicate.rb +1 -1
  99. data/lib/rubocop/cop/style/one_line_conditional.rb +1 -1
  100. data/lib/rubocop/cop/style/or_assignment.rb +1 -1
  101. data/lib/rubocop/cop/style/percent_q_literals.rb +1 -1
  102. data/lib/rubocop/cop/style/perl_backrefs.rb +2 -2
  103. data/lib/rubocop/cop/style/proc.rb +1 -1
  104. data/lib/rubocop/cop/style/raise_args.rb +1 -1
  105. data/lib/rubocop/cop/style/random_with_offset.rb +3 -3
  106. data/lib/rubocop/cop/style/redundant_condition.rb +3 -4
  107. data/lib/rubocop/cop/style/redundant_conditional.rb +1 -1
  108. data/lib/rubocop/cop/style/redundant_exception.rb +3 -3
  109. data/lib/rubocop/cop/style/redundant_interpolation.rb +2 -2
  110. data/lib/rubocop/cop/style/redundant_percent_q.rb +2 -2
  111. data/lib/rubocop/cop/style/redundant_return.rb +5 -7
  112. data/lib/rubocop/cop/style/redundant_self.rb +1 -1
  113. data/lib/rubocop/cop/style/rescue_modifier.rb +1 -1
  114. data/lib/rubocop/cop/style/return_nil.rb +1 -1
  115. data/lib/rubocop/cop/style/safe_navigation.rb +1 -1
  116. data/lib/rubocop/cop/style/self_assignment.rb +1 -1
  117. data/lib/rubocop/cop/style/special_global_vars.rb +1 -1
  118. data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +1 -4
  119. data/lib/rubocop/cop/style/string_hash_keys.rb +1 -1
  120. data/lib/rubocop/cop/style/symbol_array.rb +1 -1
  121. data/lib/rubocop/cop/style/symbol_literal.rb +2 -2
  122. data/lib/rubocop/cop/style/ternary_parentheses.rb +1 -2
  123. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +2 -1
  124. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +3 -0
  125. data/lib/rubocop/cop/style/trivial_accessors.rb +1 -1
  126. data/lib/rubocop/cop/style/unpack_first.rb +0 -4
  127. data/lib/rubocop/cop/style/variable_interpolation.rb +1 -1
  128. data/lib/rubocop/cop/style/while_until_modifier.rb +1 -1
  129. data/lib/rubocop/cop/style/word_array.rb +1 -1
  130. data/lib/rubocop/cop/style/zero_length_predicate.rb +1 -1
  131. data/lib/rubocop/formatter/formatter_set.rb +0 -1
  132. data/lib/rubocop/formatter/pacman_formatter.rb +1 -1
  133. data/lib/rubocop/options.rb +7 -1
  134. data/lib/rubocop/processed_source.rb +0 -3
  135. data/lib/rubocop/rspec/cop_helper.rb +1 -1
  136. data/lib/rubocop/rspec/expect_offense.rb +1 -1
  137. data/lib/rubocop/rspec/shared_contexts.rb +0 -4
  138. data/lib/rubocop/runner.rb +1 -1
  139. data/lib/rubocop/target_ruby.rb +2 -2
  140. data/lib/rubocop/version.rb +1 -1
  141. metadata +7 -5
  142. data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
@@ -56,7 +56,7 @@ module RuboCop
56
56
 
57
57
  def investigate(processed_source)
58
58
  processed_source.each_comment do |comment|
59
- next unless comment.text =~ /\A#+[^#\s=:+-]/
59
+ next unless /\A#+[^#\s=:+-]/.match?(comment.text)
60
60
  next if comment.loc.line == 1 && allowed_on_first_line?(comment)
61
61
  next if doxygen_comment_style?(comment)
62
62
  next if gemfile_ruby_comment?(comment)
@@ -8,7 +8,7 @@ module RuboCop
8
8
  # This cop checks the length of lines in the source code.
9
9
  # The maximum length is configurable.
10
10
  # The tab size is configured in the `IndentationWidth`
11
- # of the `Layout/Tab` cop.
11
+ # of the `Layout/IndentationStyle` cop.
12
12
  # It also ignores a shebang line by default.
13
13
  #
14
14
  # This cop has some autocorrection capabilities.
@@ -145,7 +145,7 @@ module RuboCop
145
145
  return nil unless next_range.line == range.line
146
146
 
147
147
  next_char = next_range.source
148
- return nil if /[\r\n]/ =~ next_char
148
+ return nil if /[\r\n]/.match?(next_char)
149
149
  return nil if next_char == ';'
150
150
 
151
151
  next_range
@@ -129,7 +129,7 @@ module RuboCop
129
129
 
130
130
  block_start_col = node.source_range.column
131
131
 
132
- corrector.insert_before(first_node.source_range,
132
+ corrector.insert_before(first_node,
133
133
  "\n #{' ' * block_start_col}")
134
134
  end
135
135
 
@@ -43,11 +43,11 @@ module RuboCop
43
43
  lambda do |corrector|
44
44
  if target.is_a?(RuboCop::AST::Node)
45
45
  if target.parent.children.first == target
46
- corrector.insert_before(target.source_range, ' ')
46
+ corrector.insert_before(target, ' ')
47
47
  else
48
- corrector.insert_after(target.source_range, ' ')
48
+ corrector.insert_after(target, ' ')
49
49
  end
50
- elsif target.source =~ /^\s+$/
50
+ elsif /^\s+$/.match?(target.source)
51
51
  corrector.remove(target)
52
52
  else
53
53
  corrector.insert_after(target, ' ')
@@ -0,0 +1,133 @@
1
+ # frozen_string_literal: true
2
+
3
+ module RuboCop
4
+ module Cop
5
+ module Layout
6
+ # Checks method call operators to not have spaces around them.
7
+ #
8
+ # @example
9
+ # # bad
10
+ # foo. bar
11
+ # foo .bar
12
+ # foo . bar
13
+ # foo. bar .buzz
14
+ # foo
15
+ # . bar
16
+ # . buzz
17
+ # foo&. bar
18
+ # foo &.bar
19
+ # foo &. bar
20
+ # foo &. bar&. buzz
21
+ # RuboCop:: Cop
22
+ # RuboCop:: Cop:: Cop
23
+ # :: RuboCop::Cop
24
+ #
25
+ # # good
26
+ # foo.bar
27
+ # foo.bar.buzz
28
+ # foo
29
+ # .bar
30
+ # .buzz
31
+ # foo&.bar
32
+ # foo&.bar&.buzz
33
+ # RuboCop::Cop
34
+ # RuboCop::Cop::Cop
35
+ # ::RuboCop::Cop
36
+ #
37
+ class SpaceAroundMethodCallOperator < Cop
38
+ include SurroundingSpace
39
+
40
+ MSG = 'Avoid using spaces around a method call operator.'
41
+
42
+ def on_send(node)
43
+ return unless dot_or_safe_navigation_operator?(node)
44
+
45
+ check_and_add_offense(node)
46
+ end
47
+
48
+ def on_const(node)
49
+ return unless node.loc.double_colon
50
+
51
+ check_and_add_offense(node, false)
52
+ end
53
+
54
+ def autocorrect(node)
55
+ operator = operator_token(node)
56
+ left = left_token_for_auto_correction(node, operator)
57
+ right = right_token_for_auto_correction(operator)
58
+
59
+ lambda do |corrector|
60
+ SpaceCorrector.remove_space(
61
+ processed_source, corrector, left, right
62
+ )
63
+ end
64
+ end
65
+
66
+ alias on_csend on_send
67
+
68
+ private
69
+
70
+ def check_and_add_offense(node, add_left_offense = true)
71
+ operator = operator_token(node)
72
+ left = previous_token(operator)
73
+ right = next_token(operator)
74
+
75
+ if !right.comment? && valid_right_token?(right, operator)
76
+ no_space_offenses(node, operator, right, MSG)
77
+ end
78
+ return unless valid_left_token?(left, operator)
79
+
80
+ no_space_offenses(node, left, operator, MSG) if add_left_offense
81
+ end
82
+
83
+ def operator_token(node)
84
+ operator_location =
85
+ node.const_type? ? node.loc.double_colon : node.loc.dot
86
+
87
+ processed_source.find_token do |token|
88
+ token.pos == operator_location
89
+ end
90
+ end
91
+
92
+ def previous_token(current_token)
93
+ index = processed_source.tokens.index(current_token)
94
+ index.zero? ? nil : processed_source.tokens[index - 1]
95
+ end
96
+
97
+ def next_token(current_token)
98
+ index = processed_source.tokens.index(current_token)
99
+ processed_source.tokens[index + 1]
100
+ end
101
+
102
+ def dot_or_safe_navigation_operator?(node)
103
+ node.dot? || node.safe_navigation?
104
+ end
105
+
106
+ def valid_left_token?(left, operator)
107
+ left && left.line == operator.line
108
+ end
109
+
110
+ def valid_right_token?(right, operator)
111
+ right && right.line == operator.line
112
+ end
113
+
114
+ def left_token_for_auto_correction(node, operator)
115
+ left_token = previous_token(operator)
116
+ return operator if node.const_type?
117
+ return left_token if valid_left_token?(left_token, operator)
118
+
119
+ operator
120
+ end
121
+
122
+ def right_token_for_auto_correction(operator)
123
+ right_token = next_token(operator)
124
+ if !right_token.comment? && valid_right_token?(right_token, operator)
125
+ return right_token
126
+ end
127
+
128
+ operator
129
+ end
130
+ end
131
+ end
132
+ end
133
+ end
@@ -175,7 +175,7 @@ module RuboCop
175
175
  return if with_space.is?(operator.source)
176
176
 
177
177
  "Space around operator `#{operator.source}` detected."
178
- elsif with_space.source !~ /^\s.*\s$/
178
+ elsif !/^\s.*\s$/.match?(with_space.source)
179
179
  "Surrounding space missing for operator `#{operator.source}`."
180
180
  elsif excess_leading_space?(type, operator, with_space) ||
181
181
  excess_trailing_space?(right_operand, with_space)
@@ -46,7 +46,7 @@ module RuboCop
46
46
  children = lambda_node.parent.children
47
47
  lambda do |corrector|
48
48
  if style == :require_space
49
- corrector.insert_before(children[1].source_range, ' ')
49
+ corrector.insert_before(children[1], ' ')
50
50
  else
51
51
  corrector.remove(space_after_arrow(lambda_node))
52
52
  end
@@ -117,7 +117,7 @@ module RuboCop
117
117
  range = range_between(left_brace.end_pos, right_brace.begin_pos)
118
118
  inner = range.source
119
119
 
120
- if inner =~ /\S/
120
+ if /\S/.match?(inner)
121
121
  braces_with_contents_inside(node, inner)
122
122
  elsif style_for_empty_braces == :no_space
123
123
  offense(range.begin_pos, range.end_pos,
@@ -142,7 +142,7 @@ module RuboCop
142
142
  end
143
143
 
144
144
  def check_left_brace(inner, left_brace, args_delimiter)
145
- if inner =~ /\A\S/
145
+ if /\A\S/.match?(inner)
146
146
  no_space_inside_left_brace(left_brace, args_delimiter)
147
147
  else
148
148
  space_inside_left_brace(left_brace, args_delimiter)
@@ -35,7 +35,7 @@ module RuboCop
35
35
 
36
36
  lambda do |corrector|
37
37
  corrector.replace(
38
- node.source_range,
38
+ node,
39
39
  expression
40
40
  .sub(/\s+#{operator_escaped}/, operator)
41
41
  .sub(/#{operator_escaped}\s+/, operator)
@@ -53,7 +53,7 @@ module RuboCop
53
53
  # account for multiline range literals
54
54
  expression.sub!(/#{escaped_op}\n\s*/, op)
55
55
 
56
- return unless expression =~ /(\s#{escaped_op})|(#{escaped_op}\s)/
56
+ return unless /(\s#{escaped_op})|(#{escaped_op}\s)/.match?(expression)
57
57
 
58
58
  add_offense(node)
59
59
  end
@@ -37,11 +37,11 @@ module RuboCop
37
37
  lambda do |corrector|
38
38
  boolean_literal = node.source.delete(':')
39
39
  parent = node.parent
40
- if parent&.pair_type?
40
+ if parent&.pair_type? && node.equal?(parent.children[0])
41
41
  corrector.remove(parent.loc.operator)
42
42
  boolean_literal = "#{node.source} =>"
43
43
  end
44
- corrector.replace(node.loc.expression, boolean_literal)
44
+ corrector.replace(node, boolean_literal)
45
45
  end
46
46
  end
47
47
  end
@@ -69,7 +69,7 @@ module RuboCop
69
69
  end
70
70
 
71
71
  def binding_irb?(node)
72
- target_ruby_version >= 2.4 && binding_irb_call?(node)
72
+ binding_irb_call?(node)
73
73
  end
74
74
  end
75
75
  end
@@ -81,7 +81,7 @@ module RuboCop
81
81
  end
82
82
 
83
83
  def display_str(node)
84
- if node.source =~ /\n/
84
+ if /\n/.match?(node.source)
85
85
  str_content(node).inspect
86
86
  else
87
87
  node.source
@@ -77,7 +77,7 @@ module RuboCop
77
77
 
78
78
  def autocorrect(node)
79
79
  lambda do |corrector|
80
- corrector.replace(node.loc.expression, preferred_base_class)
80
+ corrector.replace(node, preferred_base_class)
81
81
  end
82
82
  end
83
83
 
@@ -25,7 +25,7 @@ module RuboCop
25
25
 
26
26
  parent = node.parent
27
27
  return if parent && (parent.dstr_type? || parent.regexp_type?)
28
- return unless node.source.scrub =~ /(?<!\\)#\{.*\}/
28
+ return unless /(?<!\\)#\{.*\}/.match?(node.source.scrub)
29
29
 
30
30
  add_offense(node)
31
31
  end
@@ -37,7 +37,7 @@ module RuboCop
37
37
  return if node.dstr_type? # nested, fixed in next iteration
38
38
 
39
39
  value = autocorrected_value(node)
40
- ->(corrector) { corrector.replace(node.parent.source_range, value) }
40
+ ->(corrector) { corrector.replace(node.parent, value) }
41
41
  end
42
42
 
43
43
  private
@@ -39,7 +39,7 @@ module RuboCop
39
39
  new_center = "#{center.source} && #{center.source}"
40
40
 
41
41
  lambda do |corrector|
42
- corrector.replace(center.source_range, new_center)
42
+ corrector.replace(center, new_center)
43
43
  end
44
44
  end
45
45
  end
@@ -52,12 +52,12 @@ module RuboCop
52
52
  def autocorrect(node)
53
53
  if unsorted_dir_block?(node)
54
54
  lambda do |corrector|
55
- corrector.replace(node.loc.expression, "#{node.source}.sort.each")
55
+ corrector.replace(node, "#{node.source}.sort.each")
56
56
  end
57
57
  else
58
58
  lambda do |corrector|
59
59
  source = node.receiver.source
60
- corrector.replace(node.loc.expression, "#{source}.sort.each")
60
+ corrector.replace(node, "#{source}.sort.each")
61
61
  end
62
62
  end
63
63
  end
@@ -55,7 +55,7 @@ module RuboCop
55
55
 
56
56
  def autocorrect(node)
57
57
  lambda do |corrector|
58
- corrector.replace(node.loc.expression,
58
+ corrector.replace(node,
59
59
  correct_method(node, node.receiver))
60
60
  end
61
61
  end
@@ -42,13 +42,13 @@ module RuboCop
42
42
 
43
43
  def autocorrect(node)
44
44
  lambda do |corrector|
45
- node.values.each do |value|
45
+ node.each_value do |value|
46
46
  range = value.loc.expression
47
47
 
48
48
  match = range.source.match(TRAILING_QUOTE)
49
49
  corrector.remove_trailing(range, match[0].length) if match
50
50
 
51
- if range.source =~ LEADING_QUOTE
51
+ if LEADING_QUOTE.match?(range.source)
52
52
  corrector.remove_leading(range, 1)
53
53
  end
54
54
  end
@@ -6,32 +6,68 @@ module RuboCop
6
6
  # This cop checks for `raise` or `fail` statements which are
7
7
  # raising `Exception` class.
8
8
  #
9
+ # You can specify a module name that will be an implicit namespace
10
+ # using `AllowedImplicitNamespaces` option. The cop cause a false positive
11
+ # for namespaced `Exception` when a namespace is omitted. This option can
12
+ # prevent the false positive by specifying a namespace to be omitted for
13
+ # `Exception`. Alternatively, make `Exception` a fully qualified class
14
+ # name with an explicit namespace.
15
+ #
9
16
  # @example
10
17
  # # bad
11
18
  # raise Exception, 'Error message here'
12
19
  #
13
20
  # # good
14
21
  # raise StandardError, 'Error message here'
22
+ #
23
+ # @example AllowedImplicitNamespaces: ['Gem']
24
+ # # good
25
+ # module Gem
26
+ # def self.foo
27
+ # raise Exception # This exception means `Gem::Exception`.
28
+ # end
29
+ # end
15
30
  class RaiseException < Cop
16
31
  MSG = 'Use `StandardError` over `Exception`.'
17
32
 
18
33
  def_node_matcher :exception?, <<~PATTERN
19
- (send nil? ${:raise :fail} (const _ :Exception) ... )
34
+ (send nil? {:raise :fail} (const ${cbase nil?} :Exception) ... )
20
35
  PATTERN
21
36
 
22
37
  def_node_matcher :exception_new_with_message?, <<~PATTERN
23
- (send nil? ${:raise :fail}
24
- (send (const _ :Exception) :new ... ))
38
+ (send nil? {:raise :fail}
39
+ (send (const ${cbase nil?} :Exception) :new ... ))
25
40
  PATTERN
26
41
 
27
42
  def on_send(node)
28
- add_offense(node) if raise_exception?(node)
43
+ exception?(node, &check(node)) ||
44
+ exception_new_with_message?(node, &check(node))
29
45
  end
30
46
 
31
47
  private
32
48
 
33
- def raise_exception?(node)
34
- exception?(node) || exception_new_with_message?(node)
49
+ def check(node)
50
+ lambda do |cbase|
51
+ return if cbase.nil? && implicit_namespace?(node)
52
+
53
+ add_offense(node)
54
+ end
55
+ end
56
+
57
+ def implicit_namespace?(node)
58
+ return false unless (parent = node.parent)
59
+
60
+ if parent.module_type?
61
+ namespace = parent.identifier.source
62
+
63
+ return allow_implicit_namespaces.include?(namespace)
64
+ end
65
+
66
+ implicit_namespace?(parent)
67
+ end
68
+
69
+ def allow_implicit_namespaces
70
+ cop_config['AllowedImplicitNamespaces'] || []
35
71
  end
36
72
  end
37
73
  end
@@ -38,7 +38,7 @@ module RuboCop
38
38
  lambda do |corrector|
39
39
  receiver = node.receiver
40
40
  corrector.replace(
41
- node.source_range,
41
+ node,
42
42
  if receiver
43
43
  receiver.source
44
44
  else
@@ -33,8 +33,6 @@ module RuboCop
33
33
  end
34
34
 
35
35
  def autocorrect(node)
36
- return false if target_ruby_version <= 2.3
37
-
38
36
  lambda do |corrector|
39
37
  corrector.replace(node.loc.name, 'Integer')
40
38
  end