rubocop 0.75.1 → 0.93.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/LICENSE.txt +1 -1
- data/README.md +31 -23
- data/bin/rubocop-profile +32 -0
- data/config/default.yml +940 -401
- data/lib/rubocop.rb +130 -94
- data/lib/rubocop/ast_aliases.rb +8 -0
- data/lib/rubocop/cached_data.rb +3 -1
- data/lib/rubocop/cli.rb +20 -232
- data/lib/rubocop/cli/command.rb +22 -0
- data/lib/rubocop/cli/command/auto_genenerate_config.rb +141 -0
- data/lib/rubocop/cli/command/base.rb +35 -0
- data/lib/rubocop/cli/command/execute_runner.rb +85 -0
- data/lib/rubocop/cli/command/init_dotfile.rb +46 -0
- data/lib/rubocop/cli/command/show_cops.rb +77 -0
- data/lib/rubocop/cli/command/version.rb +18 -0
- data/lib/rubocop/cli/environment.rb +22 -0
- data/lib/rubocop/comment_config.rb +26 -14
- data/lib/rubocop/config.rb +68 -14
- data/lib/rubocop/config_loader.rb +89 -102
- data/lib/rubocop/config_loader_resolver.rb +51 -10
- data/lib/rubocop/config_obsoletion.rb +81 -11
- data/lib/rubocop/config_regeneration.rb +33 -0
- data/lib/rubocop/config_store.rb +19 -5
- data/lib/rubocop/config_validator.rb +98 -113
- data/lib/rubocop/cop/autocorrect_logic.rb +21 -29
- data/lib/rubocop/cop/badge.rb +6 -6
- data/lib/rubocop/cop/base.rb +430 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +5 -1
- data/lib/rubocop/cop/bundler/gem_comment.rb +82 -8
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +14 -22
- data/lib/rubocop/cop/commissioner.rb +84 -60
- data/lib/rubocop/cop/cop.rb +91 -202
- data/lib/rubocop/cop/corrector.rb +69 -121
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +7 -11
- data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -6
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
- data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +4 -4
- data/lib/rubocop/cop/correctors/line_break_corrector.rb +10 -10
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +34 -3
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +5 -8
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +6 -11
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
- data/lib/rubocop/cop/correctors/space_corrector.rb +2 -5
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +2 -2
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +15 -18
- data/lib/rubocop/cop/documentation.rb +22 -0
- data/lib/rubocop/cop/force.rb +1 -0
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +2 -4
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +42 -16
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +1 -1
- data/lib/rubocop/cop/generator.rb +9 -8
- data/lib/rubocop/cop/generator/configuration_injector.rb +5 -5
- data/lib/rubocop/cop/ignored_node.rb +1 -3
- data/lib/rubocop/cop/internal_affairs.rb +1 -0
- data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +52 -0
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +12 -14
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +9 -8
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +11 -7
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +8 -8
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +2 -2
- data/lib/rubocop/cop/layout/{align_arguments.rb → argument_alignment.rb} +1 -1
- data/lib/rubocop/cop/layout/array_alignment.rb +83 -0
- data/lib/rubocop/cop/layout/{indent_assignment.rb → assignment_indentation.rb} +1 -1
- data/lib/rubocop/cop/layout/begin_end_alignment.rb +77 -0
- data/lib/rubocop/cop/layout/block_alignment.rb +24 -20
- data/lib/rubocop/cop/layout/block_end_newline.rb +5 -3
- data/lib/rubocop/cop/layout/case_indentation.rb +21 -25
- data/lib/rubocop/cop/layout/class_structure.rb +35 -70
- data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
- data/lib/rubocop/cop/layout/comment_indentation.rb +14 -17
- data/lib/rubocop/cop/layout/condition_position.rb +16 -8
- data/lib/rubocop/cop/layout/def_end_alignment.rb +8 -5
- data/lib/rubocop/cop/layout/dot_position.rb +21 -20
- data/lib/rubocop/cop/layout/else_alignment.rb +8 -0
- data/lib/rubocop/cop/layout/empty_comment.rb +38 -40
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +21 -18
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +13 -13
- data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +22 -23
- data/lib/rubocop/cop/layout/empty_lines.rb +6 -9
- data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +20 -20
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +7 -8
- data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +118 -0
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +3 -7
- data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -5
- data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +2 -5
- data/lib/rubocop/cop/layout/end_alignment.rb +14 -19
- data/lib/rubocop/cop/layout/end_of_line.rb +11 -6
- data/lib/rubocop/cop/layout/extra_spacing.rb +23 -37
- data/lib/rubocop/cop/layout/{indent_first_argument.rb → first_argument_indentation.rb} +17 -13
- data/lib/rubocop/cop/layout/{indent_first_array_element.rb → first_array_element_indentation.rb} +18 -14
- data/lib/rubocop/cop/layout/first_array_element_line_break.rb +3 -6
- data/lib/rubocop/cop/layout/{indent_first_hash_element.rb → first_hash_element_indentation.rb} +5 -5
- data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +5 -11
- data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +2 -5
- data/lib/rubocop/cop/layout/{indent_first_parameter.rb → first_parameter_indentation.rb} +5 -5
- data/lib/rubocop/cop/layout/{align_hash.rb → hash_alignment.rb} +39 -35
- data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +18 -21
- data/lib/rubocop/cop/layout/heredoc_indentation.rb +176 -0
- data/lib/rubocop/cop/layout/{tab.rb → indentation_style.rb} +48 -8
- data/lib/rubocop/cop/layout/indentation_width.rb +1 -3
- data/lib/rubocop/cop/layout/initial_indentation.rb +6 -7
- data/lib/rubocop/cop/layout/leading_comment_space.rb +46 -13
- data/lib/rubocop/cop/layout/{leading_blank_lines.rb → leading_empty_lines.rb} +6 -11
- data/lib/rubocop/cop/{metrics → layout}/line_length.rb +78 -119
- data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +11 -15
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +50 -29
- data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +2 -9
- data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +6 -12
- data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +1 -1
- data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +2 -5
- data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +13 -4
- data/lib/rubocop/cop/layout/{align_parameters.rb → parameter_alignment.rb} +1 -1
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +41 -22
- data/lib/rubocop/cop/layout/space_after_colon.rb +12 -8
- data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
- data/lib/rubocop/cop/layout/space_after_method_name.rb +5 -6
- data/lib/rubocop/cop/layout/space_after_not.rb +9 -11
- data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +22 -27
- data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +17 -21
- data/lib/rubocop/cop/layout/space_around_keyword.rb +31 -20
- data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
- data/lib/rubocop/cop/layout/space_around_operators.rb +82 -21
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +54 -22
- data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
- data/lib/rubocop/cop/layout/space_before_comment.rb +9 -8
- data/lib/rubocop/cop/layout/space_before_first_arg.rb +15 -7
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +17 -23
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +32 -33
- data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -8
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +16 -19
- data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +21 -46
- data/lib/rubocop/cop/layout/space_inside_parens.rb +15 -20
- data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +5 -10
- data/lib/rubocop/cop/layout/space_inside_range_literal.rb +9 -18
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +17 -27
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +12 -13
- data/lib/rubocop/cop/layout/{trailing_blank_lines.rb → trailing_empty_lines.rb} +10 -15
- data/lib/rubocop/cop/layout/trailing_whitespace.rb +28 -12
- data/lib/rubocop/cop/legacy/corrections_proxy.rb +49 -0
- data/lib/rubocop/cop/legacy/corrector.rb +29 -0
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +9 -4
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +53 -5
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +35 -6
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +2 -2
- data/lib/rubocop/cop/lint/big_decimal_new.rb +9 -10
- data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +50 -0
- data/lib/rubocop/cop/lint/boolean_symbol.rb +22 -2
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
- data/lib/rubocop/cop/lint/constant_definition_in_block.rb +74 -0
- data/lib/rubocop/cop/lint/constant_resolution.rb +89 -0
- data/lib/rubocop/cop/lint/debugger.rb +8 -3
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +7 -10
- data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +141 -0
- data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +9 -3
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
- data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
- data/lib/rubocop/cop/lint/{duplicated_key.rb → duplicate_hash_key.rb} +1 -1
- data/lib/rubocop/cop/lint/duplicate_methods.rb +8 -11
- data/lib/rubocop/cop/lint/duplicate_require.rb +46 -0
- data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +3 -2
- data/lib/rubocop/cop/lint/else_layout.rb +1 -1
- data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
- data/lib/rubocop/cop/lint/empty_ensure.rb +5 -5
- data/lib/rubocop/cop/lint/empty_expression.rb +2 -2
- data/lib/rubocop/cop/lint/empty_file.rb +50 -0
- data/lib/rubocop/cop/lint/empty_interpolation.rb +5 -6
- data/lib/rubocop/cop/lint/empty_when.rb +31 -8
- data/lib/rubocop/cop/lint/ensure_return.rb +29 -14
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +21 -19
- data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
- data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
- data/lib/rubocop/cop/lint/float_out_of_range.rb +2 -2
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +41 -4
- data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +37 -0
- data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +13 -14
- data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +6 -5
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +11 -14
- data/lib/rubocop/cop/lint/inherit_exception.rb +12 -7
- data/lib/rubocop/cop/lint/interpolation_check.rb +21 -5
- data/lib/rubocop/cop/lint/literal_as_condition.rb +24 -15
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +7 -7
- data/lib/rubocop/cop/lint/loop.rb +30 -7
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +8 -7
- data/lib/rubocop/cop/lint/missing_super.rb +99 -0
- data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +37 -0
- data/lib/rubocop/cop/lint/{multiple_compare.rb → multiple_comparison.rb} +10 -11
- data/lib/rubocop/cop/lint/nested_method_definition.rb +17 -23
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +2 -2
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +1 -1
- data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +160 -0
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +9 -9
- data/lib/rubocop/cop/lint/number_conversion.rb +7 -9
- data/lib/rubocop/cop/lint/ordered_magic_comments.rb +11 -13
- data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +79 -0
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +33 -12
- data/lib/rubocop/cop/lint/percent_string_array.rb +6 -11
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -13
- data/lib/rubocop/cop/lint/raise_exception.rb +86 -0
- data/lib/rubocop/cop/lint/rand_one.rb +3 -2
- data/lib/rubocop/cop/lint/{unneeded_cop_disable_directive.rb → redundant_cop_disable_directive.rb} +84 -76
- data/lib/rubocop/cop/lint/{unneeded_cop_enable_directive.rb → redundant_cop_enable_directive.rb} +37 -28
- data/lib/rubocop/cop/lint/{unneeded_require_statement.rb → redundant_require_statement.rb} +8 -10
- data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +78 -0
- data/lib/rubocop/cop/lint/{unneeded_splat_expansion.rb → redundant_splat_expansion.rb} +20 -16
- data/lib/rubocop/cop/lint/{string_conversion_in_interpolation.rb → redundant_string_coercion.rb} +6 -13
- data/lib/rubocop/cop/lint/redundant_with_index.rb +12 -15
- data/lib/rubocop/cop/lint/redundant_with_object.rb +12 -15
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +6 -2
- data/lib/rubocop/cop/lint/require_parentheses.rb +2 -2
- data/lib/rubocop/cop/lint/rescue_exception.rb +2 -2
- data/lib/rubocop/cop/lint/rescue_type.rb +8 -9
- data/lib/rubocop/cop/lint/return_in_void_context.rb +2 -4
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +7 -11
- data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +14 -10
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +10 -2
- data/lib/rubocop/cop/lint/script_permission.rb +10 -7
- data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +8 -12
- data/lib/rubocop/cop/lint/shadowed_argument.rb +3 -3
- data/lib/rubocop/cop/lint/shadowed_exception.rb +8 -8
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +7 -7
- data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
- data/lib/rubocop/cop/lint/{handle_exceptions.rb → suppressed_exception.rb} +21 -27
- data/lib/rubocop/cop/lint/syntax.rb +11 -28
- data/lib/rubocop/cop/lint/to_json.rb +20 -11
- data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
- data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +57 -0
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +4 -4
- data/lib/rubocop/cop/lint/unified_integer.rb +4 -8
- data/lib/rubocop/cop/lint/unreachable_code.rb +2 -2
- data/lib/rubocop/cop/lint/unreachable_loop.rb +171 -0
- data/lib/rubocop/cop/lint/unused_block_argument.rb +8 -3
- data/lib/rubocop/cop/lint/unused_method_argument.rb +40 -9
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +4 -2
- data/lib/rubocop/cop/lint/uri_regexp.rb +12 -47
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +87 -39
- data/lib/rubocop/cop/lint/useless_assignment.rb +7 -6
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +7 -11
- data/lib/rubocop/cop/lint/useless_method_definition.rb +70 -0
- data/lib/rubocop/cop/lint/useless_setter_call.rb +9 -7
- data/lib/rubocop/cop/lint/useless_times.rb +106 -0
- data/lib/rubocop/cop/lint/void.rb +7 -11
- data/lib/rubocop/cop/metrics/abc_size.rb +2 -2
- data/lib/rubocop/cop/metrics/block_length.rb +27 -3
- data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
- data/lib/rubocop/cop/metrics/class_length.rb +39 -8
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +37 -4
- data/lib/rubocop/cop/metrics/method_length.rb +26 -3
- data/lib/rubocop/cop/metrics/module_length.rb +26 -3
- data/lib/rubocop/cop/metrics/parameter_lists.rb +2 -6
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +7 -8
- data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +80 -9
- data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +158 -0
- data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
- data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +37 -0
- data/lib/rubocop/cop/migration/department_name.rb +55 -16
- data/lib/rubocop/cop/mixin/alignment.rb +7 -5
- data/lib/rubocop/cop/mixin/allowed_methods.rb +21 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +5 -0
- data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
- data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
- data/lib/rubocop/cop/mixin/check_line_breakable.rb +19 -16
- data/lib/rubocop/cop/mixin/code_length.rb +26 -5
- data/lib/rubocop/cop/mixin/comments_help.rb +48 -0
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +5 -3
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +3 -5
- data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +3 -3
- data/lib/rubocop/cop/mixin/documentation_comment.rb +2 -2
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +8 -7
- data/lib/rubocop/cop/mixin/empty_parameter.rb +3 -1
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +18 -2
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +3 -1
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +4 -2
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +14 -5
- data/lib/rubocop/cop/mixin/{hash_alignment.rb → hash_alignment_styles.rb} +1 -1
- data/lib/rubocop/cop/mixin/hash_transform_method.rb +197 -0
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +1 -1
- data/lib/rubocop/cop/mixin/line_length_help.rb +87 -0
- data/lib/rubocop/cop/mixin/method_complexity.rb +17 -3
- data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +3 -1
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +1 -1
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +13 -12
- data/lib/rubocop/cop/mixin/negative_conditional.rb +2 -2
- data/lib/rubocop/cop/mixin/nil_methods.rb +4 -6
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +6 -1
- data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +16 -9
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +1 -1
- data/lib/rubocop/cop/mixin/range_help.rb +19 -5
- data/lib/rubocop/cop/mixin/rational_literal.rb +18 -0
- data/lib/rubocop/cop/mixin/rescue_node.rb +11 -1
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +4 -3
- data/lib/rubocop/cop/mixin/statement_modifier.rb +46 -23
- data/lib/rubocop/cop/mixin/string_literals_help.rb +1 -1
- data/lib/rubocop/cop/mixin/surrounding_space.rb +15 -31
- data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
- data/lib/rubocop/cop/mixin/trailing_comma.rb +27 -33
- data/lib/rubocop/cop/mixin/uncommunicative_name.rb +13 -18
- data/lib/rubocop/cop/mixin/unused_argument.rb +4 -6
- data/lib/rubocop/cop/mixin/visibility_help.rb +38 -0
- data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
- data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -6
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +4 -4
- data/lib/rubocop/cop/naming/{uncommunicative_block_param_name.rb → block_parameter_name.rb} +3 -3
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +13 -3
- data/lib/rubocop/cop/naming/constant_name.rb +3 -2
- data/lib/rubocop/cop/naming/file_name.rb +40 -22
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +2 -2
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +8 -8
- data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +3 -3
- data/lib/rubocop/cop/naming/method_name.rb +27 -1
- data/lib/rubocop/cop/naming/{uncommunicative_method_param_name.rb → method_parameter_name.rb} +3 -3
- data/lib/rubocop/cop/naming/predicate_name.rb +10 -14
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +13 -12
- data/lib/rubocop/cop/naming/variable_name.rb +1 -1
- data/lib/rubocop/cop/naming/variable_number.rb +1 -1
- data/lib/rubocop/cop/offense.rb +41 -2
- data/lib/rubocop/cop/registry.rb +80 -15
- data/lib/rubocop/cop/security/eval.rb +3 -2
- data/lib/rubocop/cop/security/json_load.rb +7 -8
- data/lib/rubocop/cop/security/marshal_load.rb +3 -4
- data/lib/rubocop/cop/security/open.rb +3 -2
- data/lib/rubocop/cop/security/yaml_load.rb +7 -6
- data/lib/rubocop/cop/severity.rb +1 -11
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +36 -13
- data/lib/rubocop/cop/style/accessor_grouping.rb +152 -0
- data/lib/rubocop/cop/style/alias.rb +44 -37
- data/lib/rubocop/cop/style/and_or.rb +16 -19
- data/lib/rubocop/cop/style/array_coercion.rb +67 -0
- data/lib/rubocop/cop/style/array_join.rb +8 -9
- data/lib/rubocop/cop/style/ascii_comments.rb +4 -4
- data/lib/rubocop/cop/style/attr.rb +22 -13
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +7 -7
- data/lib/rubocop/cop/style/bare_percent_literals.rb +12 -14
- data/lib/rubocop/cop/style/begin_block.rb +2 -2
- data/lib/rubocop/cop/style/bisected_attr_accessor.rb +141 -0
- data/lib/rubocop/cop/style/block_comments.rb +14 -18
- data/lib/rubocop/cop/style/block_delimiters.rb +77 -26
- data/lib/rubocop/cop/style/case_equality.rb +54 -4
- data/lib/rubocop/cop/style/case_like_if.rb +252 -0
- data/lib/rubocop/cop/style/character_literal.rb +2 -2
- data/lib/rubocop/cop/style/class_and_module_children.rb +17 -12
- data/lib/rubocop/cop/style/class_check.rb +6 -11
- data/lib/rubocop/cop/style/class_equality_comparison.rb +64 -0
- data/lib/rubocop/cop/style/class_methods.rb +7 -11
- data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
- data/lib/rubocop/cop/style/class_vars.rb +23 -7
- data/lib/rubocop/cop/style/collection_methods.rb +13 -17
- data/lib/rubocop/cop/style/colon_method_call.rb +8 -9
- data/lib/rubocop/cop/style/colon_method_definition.rb +6 -6
- data/lib/rubocop/cop/style/combinable_loops.rb +91 -0
- data/lib/rubocop/cop/style/command_literal.rb +24 -25
- data/lib/rubocop/cop/style/comment_annotation.rb +23 -17
- data/lib/rubocop/cop/style/commented_keyword.rb +13 -11
- data/lib/rubocop/cop/style/conditional_assignment.rb +69 -73
- data/lib/rubocop/cop/style/constant_visibility.rb +3 -2
- data/lib/rubocop/cop/style/copyright.rb +27 -23
- data/lib/rubocop/cop/style/date_time.rb +14 -3
- data/lib/rubocop/cop/style/def_with_parentheses.rb +8 -10
- data/lib/rubocop/cop/style/dir.rb +10 -12
- data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +47 -0
- data/lib/rubocop/cop/style/documentation.rb +51 -15
- data/lib/rubocop/cop/style/documentation_method.rb +1 -1
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +14 -17
- data/lib/rubocop/cop/style/double_negation.rb +44 -6
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +5 -8
- data/lib/rubocop/cop/style/each_with_object.rb +16 -19
- data/lib/rubocop/cop/style/empty_block_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_case_condition.rb +29 -28
- data/lib/rubocop/cop/style/empty_else.rb +17 -19
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +9 -10
- data/lib/rubocop/cop/style/empty_literal.rb +26 -27
- data/lib/rubocop/cop/style/empty_method.rb +13 -20
- data/lib/rubocop/cop/style/encoding.rb +6 -10
- data/lib/rubocop/cop/style/end_block.rb +6 -2
- data/lib/rubocop/cop/style/eval_with_location.rb +8 -8
- data/lib/rubocop/cop/style/even_odd.rb +9 -12
- data/lib/rubocop/cop/style/expand_path_arguments.rb +26 -25
- data/lib/rubocop/cop/style/explicit_block_argument.rb +106 -0
- data/lib/rubocop/cop/style/exponential_notation.rb +117 -0
- data/lib/rubocop/cop/style/float_division.rb +10 -11
- data/lib/rubocop/cop/style/for.rb +7 -15
- data/lib/rubocop/cop/style/format_string.rb +30 -28
- data/lib/rubocop/cop/style/format_string_token.rb +15 -16
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +98 -35
- data/lib/rubocop/cop/style/global_std_stream.rb +65 -0
- data/lib/rubocop/cop/style/global_vars.rb +2 -2
- data/lib/rubocop/cop/style/guard_clause.rb +34 -10
- data/lib/rubocop/cop/style/hash_as_last_array_item.rb +88 -0
- data/lib/rubocop/cop/style/hash_each_methods.rb +86 -0
- data/lib/rubocop/cop/style/hash_like_case.rb +76 -0
- data/lib/rubocop/cop/style/hash_syntax.rb +27 -18
- data/lib/rubocop/cop/style/hash_transform_keys.rb +91 -0
- data/lib/rubocop/cop/style/hash_transform_values.rb +88 -0
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +2 -2
- data/lib/rubocop/cop/style/if_inside_else.rb +2 -2
- data/lib/rubocop/cop/style/if_unless_modifier.rb +80 -44
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
- data/lib/rubocop/cop/style/if_with_semicolon.rb +15 -2
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +2 -1
- data/lib/rubocop/cop/style/infinite_loop.rb +28 -27
- data/lib/rubocop/cop/style/inline_comment.rb +4 -4
- data/lib/rubocop/cop/style/inverse_methods.rb +37 -37
- data/lib/rubocop/cop/style/ip_addresses.rb +5 -5
- data/lib/rubocop/cop/style/keyword_parameters_order.rb +53 -0
- data/lib/rubocop/cop/style/lambda.rb +9 -13
- data/lib/rubocop/cop/style/lambda_call.rb +17 -34
- data/lib/rubocop/cop/style/line_end_concatenation.rb +33 -26
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +9 -206
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +174 -0
- data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +48 -0
- data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +9 -10
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +12 -3
- data/lib/rubocop/cop/style/method_def_parentheses.rb +21 -22
- data/lib/rubocop/cop/style/min_max.rb +8 -12
- data/lib/rubocop/cop/style/missing_else.rb +11 -21
- data/lib/rubocop/cop/style/missing_respond_to_missing.rb +10 -3
- data/lib/rubocop/cop/style/mixin_grouping.rb +26 -29
- data/lib/rubocop/cop/style/mixin_usage.rb +9 -28
- data/lib/rubocop/cop/style/module_function.rb +64 -21
- data/lib/rubocop/cop/style/multiline_block_chain.rb +12 -3
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +4 -11
- data/lib/rubocop/cop/style/multiline_if_then.rb +5 -11
- data/lib/rubocop/cop/style/multiline_memoization.rb +15 -13
- data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +31 -9
- data/lib/rubocop/cop/style/multiline_when_then.rb +29 -11
- data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
- data/lib/rubocop/cop/style/mutable_constant.rb +27 -26
- data/lib/rubocop/cop/style/negated_if.rb +9 -9
- data/lib/rubocop/cop/style/negated_unless.rb +9 -9
- data/lib/rubocop/cop/style/negated_while.rb +7 -15
- data/lib/rubocop/cop/style/nested_modifier.rb +13 -14
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +21 -22
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +29 -2
- data/lib/rubocop/cop/style/next.rb +19 -23
- data/lib/rubocop/cop/style/nil_comparison.rb +13 -11
- data/lib/rubocop/cop/style/non_nil_check.rb +55 -35
- data/lib/rubocop/cop/style/not.rb +20 -26
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +6 -11
- data/lib/rubocop/cop/style/numeric_literals.rb +8 -4
- data/lib/rubocop/cop/style/numeric_predicate.rb +11 -16
- data/lib/rubocop/cop/style/one_line_conditional.rb +76 -29
- data/lib/rubocop/cop/style/option_hash.rb +4 -4
- data/lib/rubocop/cop/style/optional_arguments.rb +2 -2
- data/lib/rubocop/cop/style/optional_boolean_parameter.rb +53 -0
- data/lib/rubocop/cop/style/or_assignment.rb +16 -12
- data/lib/rubocop/cop/style/parallel_assignment.rb +18 -18
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +6 -6
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +21 -27
- data/lib/rubocop/cop/style/percent_q_literals.rb +8 -10
- data/lib/rubocop/cop/style/perl_backrefs.rb +8 -10
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +11 -14
- data/lib/rubocop/cop/style/proc.rb +7 -7
- data/lib/rubocop/cop/style/raise_args.rb +12 -24
- data/lib/rubocop/cop/style/random_with_offset.rb +24 -29
- data/lib/rubocop/cop/style/redundant_assignment.rb +107 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +35 -9
- data/lib/rubocop/cop/style/{unneeded_capital_w.rb → redundant_capital_w.rb} +6 -9
- data/lib/rubocop/cop/style/{unneeded_condition.rb → redundant_condition.rb} +42 -15
- data/lib/rubocop/cop/style/redundant_conditional.rb +9 -9
- data/lib/rubocop/cop/style/redundant_exception.rb +19 -13
- data/lib/rubocop/cop/style/redundant_fetch_block.rb +113 -0
- data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +51 -0
- data/lib/rubocop/cop/style/redundant_freeze.rb +6 -8
- data/lib/rubocop/cop/style/{unneeded_interpolation.rb → redundant_interpolation.rb} +31 -25
- data/lib/rubocop/cop/style/redundant_parentheses.rb +34 -26
- data/lib/rubocop/cop/style/{unneeded_percent_q.rb → redundant_percent_q.rb} +13 -15
- data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +98 -0
- data/lib/rubocop/cop/style/redundant_regexp_escape.rb +105 -0
- data/lib/rubocop/cop/style/redundant_return.rb +40 -44
- data/lib/rubocop/cop/style/redundant_self.rb +15 -20
- data/lib/rubocop/cop/style/redundant_self_assignment.rb +116 -0
- data/lib/rubocop/cop/style/{unneeded_sort.rb → redundant_sort.rb} +31 -34
- data/lib/rubocop/cop/style/redundant_sort_by.rb +5 -9
- data/lib/rubocop/cop/style/regexp_literal.rb +10 -21
- data/lib/rubocop/cop/style/rescue_modifier.rb +29 -9
- data/lib/rubocop/cop/style/rescue_standard_error.rb +21 -17
- data/lib/rubocop/cop/style/return_nil.rb +6 -6
- data/lib/rubocop/cop/style/safe_navigation.rb +35 -30
- data/lib/rubocop/cop/style/sample.rb +13 -15
- data/lib/rubocop/cop/style/self_assignment.rb +26 -22
- data/lib/rubocop/cop/style/semicolon.rb +9 -12
- data/lib/rubocop/cop/style/send.rb +4 -5
- data/lib/rubocop/cop/style/signal_exception.rb +26 -20
- data/lib/rubocop/cop/style/single_argument_dig.rb +55 -0
- data/lib/rubocop/cop/style/single_line_block_params.rb +4 -2
- data/lib/rubocop/cop/style/single_line_methods.rb +18 -17
- data/lib/rubocop/cop/style/slicing_with_range.rb +37 -0
- data/lib/rubocop/cop/style/sole_nested_conditional.rb +66 -0
- data/lib/rubocop/cop/style/special_global_vars.rb +17 -28
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +17 -23
- data/lib/rubocop/cop/style/stderr_puts.rb +6 -7
- data/lib/rubocop/cop/style/string_concatenation.rb +106 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +6 -7
- data/lib/rubocop/cop/style/string_methods.rb +7 -17
- data/lib/rubocop/cop/style/strip.rb +9 -14
- data/lib/rubocop/cop/style/struct_inheritance.rb +22 -4
- data/lib/rubocop/cop/style/symbol_array.rb +13 -24
- data/lib/rubocop/cop/style/symbol_literal.rb +6 -8
- data/lib/rubocop/cop/style/symbol_proc.rb +16 -20
- data/lib/rubocop/cop/style/ternary_parentheses.rb +25 -28
- data/lib/rubocop/cop/style/trailing_body_on_class.rb +3 -6
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +4 -7
- data/lib/rubocop/cop/style/trailing_body_on_module.rb +3 -6
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +37 -27
- data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +43 -5
- data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +90 -0
- data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +46 -5
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +9 -32
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +16 -21
- data/lib/rubocop/cop/style/trivial_accessors.rb +35 -38
- data/lib/rubocop/cop/style/unless_else.rb +6 -9
- data/lib/rubocop/cop/style/unpack_first.rb +4 -11
- data/lib/rubocop/cop/style/variable_interpolation.rb +7 -10
- data/lib/rubocop/cop/style/when_then.rb +5 -7
- data/lib/rubocop/cop/style/while_until_do.rb +6 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +8 -22
- data/lib/rubocop/cop/style/word_array.rb +6 -24
- data/lib/rubocop/cop/style/yoda_condition.rb +29 -8
- data/lib/rubocop/cop/style/zero_length_predicate.rb +19 -21
- data/lib/rubocop/cop/team.rb +143 -77
- data/lib/rubocop/cop/util.rb +30 -17
- data/lib/rubocop/cop/utils/format_string.rb +31 -24
- data/lib/rubocop/cop/variable_force.rb +16 -17
- data/lib/rubocop/cop/variable_force/assignment.rb +1 -0
- data/lib/rubocop/cop/variable_force/branch.rb +2 -7
- data/lib/rubocop/cop/variable_force/scope.rb +1 -0
- data/lib/rubocop/cop/variable_force/variable.rb +7 -8
- data/lib/rubocop/cops_documentation_generator.rb +284 -0
- data/lib/rubocop/core_ext/string.rb +2 -2
- data/lib/rubocop/directive_comment.rb +32 -0
- data/lib/rubocop/error.rb +1 -0
- data/lib/rubocop/ext/processed_source.rb +18 -0
- data/lib/rubocop/ext/regexp_node.rb +62 -0
- data/lib/rubocop/file_finder.rb +13 -12
- data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
- data/lib/rubocop/formatter/base_formatter.rb +0 -4
- data/lib/rubocop/formatter/clang_style_formatter.rb +0 -2
- data/lib/rubocop/formatter/disabled_config_formatter.rb +15 -16
- data/lib/rubocop/formatter/formatter_set.rb +4 -5
- data/lib/rubocop/formatter/html_formatter.rb +2 -0
- data/lib/rubocop/formatter/json_formatter.rb +6 -5
- data/lib/rubocop/formatter/junit_formatter.rb +84 -0
- data/lib/rubocop/formatter/pacman_formatter.rb +1 -1
- data/lib/rubocop/formatter/progress_formatter.rb +2 -1
- data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
- data/lib/rubocop/formatter/simple_text_formatter.rb +36 -6
- data/lib/rubocop/formatter/tap_formatter.rb +0 -2
- data/lib/rubocop/magic_comment.rb +1 -1
- data/lib/rubocop/name_similarity.rb +18 -10
- data/lib/rubocop/options.rb +103 -46
- data/lib/rubocop/path_util.rb +19 -19
- data/lib/rubocop/platform.rb +1 -1
- data/lib/rubocop/rake_task.rb +8 -9
- data/lib/rubocop/remote_config.rb +2 -3
- data/lib/rubocop/result_cache.rb +69 -27
- data/lib/rubocop/rspec/cop_helper.rb +11 -31
- data/lib/rubocop/rspec/expect_offense.rb +104 -25
- data/lib/rubocop/rspec/shared_contexts.rb +79 -29
- data/lib/rubocop/runner.rb +123 -74
- data/lib/rubocop/string_interpreter.rb +3 -0
- data/lib/rubocop/target_finder.rb +61 -50
- data/lib/rubocop/target_ruby.rb +160 -0
- data/lib/rubocop/version.rb +12 -4
- data/lib/rubocop/yaml_duplication_checker.rb +1 -0
- metadata +176 -117
- data/lib/rubocop/ast/builder.rb +0 -81
- data/lib/rubocop/ast/node.rb +0 -640
- data/lib/rubocop/ast/node/alias_node.rb +0 -24
- data/lib/rubocop/ast/node/and_node.rb +0 -29
- data/lib/rubocop/ast/node/args_node.rb +0 -29
- data/lib/rubocop/ast/node/array_node.rb +0 -57
- data/lib/rubocop/ast/node/block_node.rb +0 -115
- data/lib/rubocop/ast/node/break_node.rb +0 -17
- data/lib/rubocop/ast/node/case_node.rb +0 -56
- data/lib/rubocop/ast/node/class_node.rb +0 -31
- data/lib/rubocop/ast/node/def_node.rb +0 -71
- data/lib/rubocop/ast/node/defined_node.rb +0 -17
- data/lib/rubocop/ast/node/ensure_node.rb +0 -17
- data/lib/rubocop/ast/node/float_node.rb +0 -12
- data/lib/rubocop/ast/node/for_node.rb +0 -53
- data/lib/rubocop/ast/node/hash_node.rb +0 -109
- data/lib/rubocop/ast/node/if_node.rb +0 -175
- data/lib/rubocop/ast/node/int_node.rb +0 -12
- data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
- data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
- data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
- data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
- data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -261
- data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
- data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
- data/lib/rubocop/ast/node/mixin/numeric_node.rb +0 -21
- data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
- data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
- data/lib/rubocop/ast/node/module_node.rb +0 -24
- data/lib/rubocop/ast/node/or_node.rb +0 -29
- data/lib/rubocop/ast/node/pair_node.rb +0 -63
- data/lib/rubocop/ast/node/range_node.rb +0 -18
- data/lib/rubocop/ast/node/regexp_node.rb +0 -35
- data/lib/rubocop/ast/node/resbody_node.rb +0 -24
- data/lib/rubocop/ast/node/retry_node.rb +0 -17
- data/lib/rubocop/ast/node/self_class_node.rb +0 -24
- data/lib/rubocop/ast/node/send_node.rb +0 -13
- data/lib/rubocop/ast/node/str_node.rb +0 -16
- data/lib/rubocop/ast/node/super_node.rb +0 -21
- data/lib/rubocop/ast/node/symbol_node.rb +0 -12
- data/lib/rubocop/ast/node/until_node.rb +0 -35
- data/lib/rubocop/ast/node/when_node.rb +0 -53
- data/lib/rubocop/ast/node/while_node.rb +0 -35
- data/lib/rubocop/ast/node/yield_node.rb +0 -21
- data/lib/rubocop/ast/sexp.rb +0 -16
- data/lib/rubocop/ast/traversal.rb +0 -183
- data/lib/rubocop/cop/layout/align_array.rb +0 -39
- data/lib/rubocop/cop/layout/indent_heredoc.rb +0 -256
- data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
- data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
- data/lib/rubocop/cop/mixin/safe_mode.rb +0 -24
- data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +0 -209
- data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
- data/lib/rubocop/node_pattern.rb +0 -799
- data/lib/rubocop/processed_source.rb +0 -216
- data/lib/rubocop/string_util.rb +0 -14
- data/lib/rubocop/token.rb +0 -114
@@ -53,7 +53,11 @@ module RuboCop
|
|
53
53
|
gem_declarations(processed_source.ast)
|
54
54
|
.group_by(&:first_argument)
|
55
55
|
.values
|
56
|
-
.select { |nodes| nodes.size > 1 }
|
56
|
+
.select { |nodes| nodes.size > 1 && !condition?(nodes) }
|
57
|
+
end
|
58
|
+
|
59
|
+
def condition?(nodes)
|
60
|
+
nodes[0].parent&.if_type? && nodes[0].parent == nodes[1].parent
|
57
61
|
end
|
58
62
|
|
59
63
|
def register_offense(node, gem_name, line_of_first_occurrence)
|
@@ -5,7 +5,25 @@ module RuboCop
|
|
5
5
|
module Bundler
|
6
6
|
# Add a comment describing each gem in your Gemfile.
|
7
7
|
#
|
8
|
-
#
|
8
|
+
# Optionally, the "OnlyFor" configuration
|
9
|
+
# can be used to only register offenses when the gems
|
10
|
+
# use certain options or have version specifiers.
|
11
|
+
# Add "version_specifiers" and/or the gem option names
|
12
|
+
# you want to check.
|
13
|
+
#
|
14
|
+
# A useful use-case is to enforce a comment when using
|
15
|
+
# options that change the source of a gem:
|
16
|
+
#
|
17
|
+
# - `bitbucket`
|
18
|
+
# - `gist`
|
19
|
+
# - `git`
|
20
|
+
# - `github`
|
21
|
+
# - `source`
|
22
|
+
#
|
23
|
+
# For a full list of options supported by bundler,
|
24
|
+
# you can check the https://bundler.io/man/gemfile.5.html[official documentation].
|
25
|
+
#
|
26
|
+
# @example OnlyFor: [] (default)
|
9
27
|
# # bad
|
10
28
|
#
|
11
29
|
# gem 'foo'
|
@@ -15,23 +33,56 @@ module RuboCop
|
|
15
33
|
# # Helpers for the foo things.
|
16
34
|
# gem 'foo'
|
17
35
|
#
|
36
|
+
# @example OnlyFor: ['version_specifiers']
|
37
|
+
# # bad
|
38
|
+
#
|
39
|
+
# gem 'foo', '< 2.1'
|
40
|
+
#
|
41
|
+
# # good
|
42
|
+
#
|
43
|
+
# # Version 2.1 introduces breaking change baz
|
44
|
+
# gem 'foo', '< 2.1'
|
45
|
+
#
|
46
|
+
# @example OnlyFor: ['version_specifiers', 'github']
|
47
|
+
# # bad
|
48
|
+
#
|
49
|
+
# gem 'foo', github: 'some_account/some_fork_of_foo'
|
50
|
+
#
|
51
|
+
# gem 'bar', '< 2.1'
|
52
|
+
#
|
53
|
+
# # good
|
54
|
+
#
|
55
|
+
# # Using this fork because baz
|
56
|
+
# gem 'foo', github: 'some_account/some_fork_of_foo'
|
57
|
+
#
|
58
|
+
# # Version 2.1 introduces breaking change baz
|
59
|
+
# gem 'bar', '< 2.1'
|
60
|
+
#
|
18
61
|
class GemComment < Cop
|
19
62
|
include DefNode
|
20
63
|
|
21
64
|
MSG = 'Missing gem description comment.'
|
65
|
+
CHECKED_OPTIONS_CONFIG = 'OnlyFor'
|
66
|
+
VERSION_SPECIFIERS_OPTION = 'version_specifiers'
|
67
|
+
RESTRICT_ON_SEND = %i[gem].freeze
|
22
68
|
|
23
69
|
def_node_matcher :gem_declaration?, '(send nil? :gem str ...)'
|
24
70
|
|
25
71
|
def on_send(node)
|
26
72
|
return unless gem_declaration?(node)
|
27
|
-
return if
|
28
|
-
return if
|
73
|
+
return if ignored_gem?(node)
|
74
|
+
return if commented_any_descendant?(node)
|
75
|
+
return if cop_config[CHECKED_OPTIONS_CONFIG].any? && !checked_options_present?(node)
|
29
76
|
|
30
77
|
add_offense(node)
|
31
78
|
end
|
32
79
|
|
33
80
|
private
|
34
81
|
|
82
|
+
def commented_any_descendant?(node)
|
83
|
+
commented?(node) || node.each_descendant.any? { |n| commented?(n) }
|
84
|
+
end
|
85
|
+
|
35
86
|
def commented?(node)
|
36
87
|
preceding_lines = preceding_lines(node)
|
37
88
|
preceding_comment?(node, preceding_lines.last)
|
@@ -40,12 +91,12 @@ module RuboCop
|
|
40
91
|
# The args node1 & node2 may represent a RuboCop::AST::Node
|
41
92
|
# or a Parser::Source::Comment. Both respond to #loc.
|
42
93
|
def precede?(node1, node2)
|
43
|
-
node2.loc.line - node1.loc.line
|
94
|
+
node2.loc.line - node1.loc.line <= 1
|
44
95
|
end
|
45
96
|
|
46
97
|
def preceding_lines(node)
|
47
98
|
processed_source.ast_with_comments[node].select do |line|
|
48
|
-
line.loc.line
|
99
|
+
line.loc.line <= node.loc.line
|
49
100
|
end
|
50
101
|
end
|
51
102
|
|
@@ -54,9 +105,32 @@ module RuboCop
|
|
54
105
|
comment_line?(node2.loc.expression.source)
|
55
106
|
end
|
56
107
|
|
57
|
-
def
|
58
|
-
|
59
|
-
|
108
|
+
def ignored_gem?(node)
|
109
|
+
ignored_gems = Array(cop_config['IgnoredGems'])
|
110
|
+
ignored_gems.include?(node.first_argument.value)
|
111
|
+
end
|
112
|
+
|
113
|
+
def checked_options_present?(node)
|
114
|
+
(cop_config[CHECKED_OPTIONS_CONFIG].include?(VERSION_SPECIFIERS_OPTION) &&
|
115
|
+
version_specified_gem?(node)) ||
|
116
|
+
contains_checked_options?(node)
|
117
|
+
end
|
118
|
+
|
119
|
+
# Besides the gem name, all other *positional* arguments to `gem` are version specifiers,
|
120
|
+
# as long as it has one we know there's at least one version specifier.
|
121
|
+
def version_specified_gem?(node)
|
122
|
+
# arguments[0] is the gem name
|
123
|
+
node.arguments[1]&.str_type?
|
124
|
+
end
|
125
|
+
|
126
|
+
def contains_checked_options?(node)
|
127
|
+
(Array(cop_config[CHECKED_OPTIONS_CONFIG]) & gem_options(node).map(&:to_s)).any?
|
128
|
+
end
|
129
|
+
|
130
|
+
def gem_options(node)
|
131
|
+
return [] unless node.arguments.last&.type == :hash
|
132
|
+
|
133
|
+
node.arguments.last.keys.map(&:value)
|
60
134
|
end
|
61
135
|
end
|
62
136
|
end
|
@@ -13,8 +13,8 @@ module RuboCop
|
|
13
13
|
#
|
14
14
|
# However, it don't replace all `sources` of `http://` with `https://`.
|
15
15
|
# For example, when specifying an internal gem server using HTTP on the
|
16
|
-
# intranet, a use case where HTTPS
|
17
|
-
# Consider using HTTP only if you
|
16
|
+
# intranet, a use case where HTTPS cannot be specified was considered.
|
17
|
+
# Consider using HTTP only if you cannot use HTTPS.
|
18
18
|
#
|
19
19
|
# @example
|
20
20
|
# # bad
|
@@ -25,44 +25,36 @@ module RuboCop
|
|
25
25
|
# # good
|
26
26
|
# source 'https://rubygems.org' # strongly recommended
|
27
27
|
# source 'http://rubygems.org'
|
28
|
-
class InsecureProtocolSource <
|
28
|
+
class InsecureProtocolSource < Base
|
29
29
|
include RangeHelp
|
30
|
+
extend AutoCorrector
|
30
31
|
|
31
32
|
MSG = 'The source `:%<source>s` is deprecated because HTTP requests ' \
|
32
33
|
'are insecure. ' \
|
33
34
|
"Please change your source to 'https://rubygems.org' " \
|
34
35
|
"if possible, or 'http://rubygems.org' if not."
|
35
36
|
|
37
|
+
RESTRICT_ON_SEND = %i[source].freeze
|
38
|
+
|
36
39
|
def_node_matcher :insecure_protocol_source?, <<~PATTERN
|
37
40
|
(send nil? :source
|
38
|
-
(sym ${:gemcutter :rubygems :rubyforge}))
|
41
|
+
$(sym ${:gemcutter :rubygems :rubyforge}))
|
39
42
|
PATTERN
|
40
43
|
|
41
44
|
def on_send(node)
|
42
|
-
insecure_protocol_source?(node) do |source|
|
45
|
+
insecure_protocol_source?(node) do |source_node, source|
|
43
46
|
message = format(MSG, source: source)
|
44
47
|
|
45
48
|
add_offense(
|
46
|
-
|
47
|
-
location: range(node.first_argument.loc.expression),
|
49
|
+
source_node,
|
48
50
|
message: message
|
49
|
-
)
|
50
|
-
|
51
|
-
|
52
|
-
|
53
|
-
|
54
|
-
lambda do |corrector|
|
55
|
-
corrector.replace(
|
56
|
-
node.first_argument.loc.expression, "'https://rubygems.org'"
|
57
|
-
)
|
51
|
+
) do |corrector|
|
52
|
+
corrector.replace(
|
53
|
+
source_node, "'https://rubygems.org'"
|
54
|
+
)
|
55
|
+
end
|
58
56
|
end
|
59
57
|
end
|
60
|
-
|
61
|
-
private
|
62
|
-
|
63
|
-
def range(node)
|
64
|
-
range_between(node.begin_pos, node.end_pos)
|
65
|
-
end
|
66
58
|
end
|
67
59
|
end
|
68
60
|
end
|
@@ -7,15 +7,48 @@ module RuboCop
|
|
7
7
|
class Commissioner
|
8
8
|
include RuboCop::AST::Traversal
|
9
9
|
|
10
|
+
RESTRICTED_CALLBACKS = %i[on_send on_csend].freeze
|
11
|
+
private_constant :RESTRICTED_CALLBACKS
|
12
|
+
|
13
|
+
# How a Commissioner returns the results of the investigation
|
14
|
+
# as a list of Cop::InvestigationReport and any errors caught
|
15
|
+
# during the investigation.
|
16
|
+
# Immutable
|
17
|
+
# Consider creation API private
|
18
|
+
InvestigationReport = Struct.new(:processed_source, :cop_reports, :errors) do
|
19
|
+
def cops
|
20
|
+
@cops ||= cop_reports.map(&:cop)
|
21
|
+
end
|
22
|
+
|
23
|
+
def offenses_per_cop
|
24
|
+
@offenses_per_cop ||= cop_reports.map(&:offenses)
|
25
|
+
end
|
26
|
+
|
27
|
+
def correctors
|
28
|
+
@correctors ||= cop_reports.map(&:corrector)
|
29
|
+
end
|
30
|
+
|
31
|
+
def offenses
|
32
|
+
@offenses ||= offenses_per_cop.flatten(1)
|
33
|
+
end
|
34
|
+
|
35
|
+
def merge(investigation)
|
36
|
+
InvestigationReport.new(processed_source,
|
37
|
+
cop_reports + investigation.cop_reports,
|
38
|
+
errors + investigation.errors)
|
39
|
+
end
|
40
|
+
end
|
41
|
+
|
10
42
|
attr_reader :errors
|
11
43
|
|
12
44
|
def initialize(cops, forces = [], options = {})
|
13
45
|
@cops = cops
|
14
46
|
@forces = forces
|
15
47
|
@options = options
|
16
|
-
@callbacks = {}
|
48
|
+
@callbacks = Hash.new { |h, k| h[k] = cops_callbacks_for(k) }
|
49
|
+
@restricted_map = {}
|
17
50
|
|
18
|
-
|
51
|
+
reset
|
19
52
|
end
|
20
53
|
|
21
54
|
# Create methods like :on_send, :on_super, etc. They will be called
|
@@ -28,30 +61,39 @@ module RuboCop
|
|
28
61
|
method_name = :"on_#{node_type}"
|
29
62
|
next unless method_defined?(method_name)
|
30
63
|
|
31
|
-
|
32
|
-
|
33
|
-
super(node) unless NO_CHILD_NODES.include?(node_type)
|
64
|
+
if RESTRICTED_CALLBACKS.include?(method_name)
|
65
|
+
trigger_restricted = "trigger_restricted_cops(:on_#{node_type}, node)"
|
34
66
|
end
|
67
|
+
|
68
|
+
class_eval(<<~RUBY, __FILE__, __LINE__ + 1)
|
69
|
+
def on_#{node_type}(node)
|
70
|
+
trigger_responding_cops(:on_#{node_type}, node)
|
71
|
+
#{trigger_restricted}
|
72
|
+
#{'super(node)' unless NO_CHILD_NODES.include?(node_type)}
|
73
|
+
end
|
74
|
+
RUBY
|
35
75
|
end
|
36
76
|
|
77
|
+
# @return [InvestigationReport]
|
37
78
|
def investigate(processed_source)
|
38
|
-
|
39
|
-
|
40
|
-
|
41
|
-
|
42
|
-
|
43
|
-
|
44
|
-
|
45
|
-
|
46
|
-
|
79
|
+
reset
|
80
|
+
|
81
|
+
@cops.each { |cop| cop.send :begin_investigation, processed_source }
|
82
|
+
if processed_source.valid_syntax?
|
83
|
+
invoke(:on_new_investigation, @cops)
|
84
|
+
invoke(:investigate, @forces, processed_source)
|
85
|
+
walk(processed_source.ast) unless @cops.empty?
|
86
|
+
invoke(:on_investigation_end, @cops)
|
87
|
+
else
|
88
|
+
invoke(:on_other_file, @cops)
|
89
|
+
end
|
90
|
+
reports = @cops.map { |cop| cop.send(:complete_investigation) }
|
91
|
+
InvestigationReport.new(processed_source, reports, @errors)
|
47
92
|
end
|
48
93
|
|
49
94
|
private
|
50
95
|
|
51
96
|
def trigger_responding_cops(callback, node)
|
52
|
-
@callbacks[callback] ||= @cops.select do |cop|
|
53
|
-
cop.respond_to?(callback)
|
54
|
-
end
|
55
97
|
@callbacks[callback].each do |cop|
|
56
98
|
with_cop_error_handling(cop, node) do
|
57
99
|
cop.send(callback, node)
|
@@ -59,64 +101,46 @@ module RuboCop
|
|
59
101
|
end
|
60
102
|
end
|
61
103
|
|
62
|
-
def
|
104
|
+
def reset
|
63
105
|
@errors = []
|
64
106
|
end
|
65
107
|
|
66
|
-
def
|
67
|
-
@cops.
|
68
|
-
|
69
|
-
cop.class.respond_to?(:support_target_ruby_version?) &&
|
70
|
-
!cop.class.support_target_ruby_version?(cop.target_ruby_version)
|
108
|
+
def cops_callbacks_for(callback)
|
109
|
+
callbacks = @cops.select do |cop|
|
110
|
+
cop.respond_to?(callback)
|
71
111
|
end
|
72
|
-
|
73
|
-
|
74
|
-
!cop.class.support_target_rails_version?(cop.target_rails_version)
|
112
|
+
if RESTRICTED_CALLBACKS.include?(callback)
|
113
|
+
@restricted_map[callback] = restricted_map(callbacks)
|
75
114
|
end
|
115
|
+
callbacks
|
76
116
|
end
|
77
117
|
|
78
|
-
def
|
79
|
-
|
80
|
-
|
81
|
-
|
82
|
-
|
83
|
-
|
84
|
-
|
118
|
+
def trigger_restricted_cops(event, node)
|
119
|
+
name = node.method_name
|
120
|
+
@restricted_map.fetch(event)[name]&.each do |cop|
|
121
|
+
with_cop_error_handling(cop, node) do
|
122
|
+
cop.send(event, node)
|
123
|
+
end
|
124
|
+
end
|
85
125
|
end
|
86
126
|
|
87
|
-
#
|
88
|
-
|
89
|
-
|
90
|
-
|
91
|
-
|
92
|
-
|
93
|
-
|
94
|
-
# during the AST traversal.
|
95
|
-
def invoke_custom_processing(cops_or_forces, processed_source)
|
96
|
-
cops_or_forces.each do |cop|
|
97
|
-
next unless cop.respond_to?(:investigate)
|
98
|
-
|
99
|
-
with_cop_error_handling(cop) do
|
100
|
-
cop.investigate(processed_source)
|
127
|
+
# Note: mutates `callbacks` in place
|
128
|
+
def restricted_map(callbacks)
|
129
|
+
map = {}
|
130
|
+
callbacks.select! do |cop|
|
131
|
+
restrictions = cop.class.send :restrict_on_send
|
132
|
+
restrictions.each do |name|
|
133
|
+
(map[name] ||= []) << cop
|
101
134
|
end
|
135
|
+
restrictions.empty?
|
102
136
|
end
|
137
|
+
map
|
103
138
|
end
|
104
139
|
|
105
|
-
|
106
|
-
# the AST traversal. By performing the walk before invoking these
|
107
|
-
# custom processors, we allow these cops to build their own
|
108
|
-
# state during the primary AST traversal instead of performing their
|
109
|
-
# own AST traversals. Minimizing the number of walks is more efficient.
|
110
|
-
#
|
111
|
-
# If they define the #investigate_post_walk method, all input parameters
|
112
|
-
# passed to the commissioner will be passed to the cop too in order to do
|
113
|
-
# its own processing.
|
114
|
-
def invoke_custom_post_walk_processing(cops, processed_source)
|
140
|
+
def invoke(callback, cops, *args)
|
115
141
|
cops.each do |cop|
|
116
|
-
next unless cop.respond_to?(:investigate_post_walk)
|
117
|
-
|
118
142
|
with_cop_error_handling(cop) do
|
119
|
-
cop.
|
143
|
+
cop.send(callback, *args)
|
120
144
|
end
|
121
145
|
end
|
122
146
|
end
|
data/lib/rubocop/cop/cop.rb
CHANGED
@@ -1,36 +1,19 @@
|
|
1
1
|
# frozen_string_literal: true
|
2
2
|
|
3
3
|
require 'uri'
|
4
|
+
require_relative 'legacy/corrections_proxy'
|
4
5
|
|
5
6
|
module RuboCop
|
6
7
|
module Cop
|
7
|
-
#
|
8
|
-
#
|
9
|
-
#
|
10
|
-
|
11
|
-
|
12
|
-
#
|
13
|
-
# A commissioner object is responsible for traversing the AST and invoking
|
14
|
-
# the specific callbacks on each cop.
|
15
|
-
# If a cop needs to do its own processing of the AST or depends on
|
16
|
-
# something else, it should define the `#investigate` method and do
|
17
|
-
# the processing there.
|
18
|
-
#
|
19
|
-
# @example
|
20
|
-
#
|
21
|
-
# class CustomCop < Cop
|
22
|
-
# def investigate(processed_source)
|
23
|
-
# # Do custom processing
|
24
|
-
# end
|
25
|
-
# end
|
26
|
-
class Cop
|
27
|
-
extend RuboCop::AST::Sexp
|
28
|
-
extend NodePattern::Macros
|
29
|
-
include RuboCop::AST::Sexp
|
30
|
-
include Util
|
31
|
-
include IgnoredNode
|
32
|
-
include AutocorrectLogic
|
8
|
+
# @deprecated Use Cop::Base instead
|
9
|
+
# Legacy scaffold for Cops.
|
10
|
+
# See https://docs.rubocop.org/rubocop/cop_api_v1_changelog.html
|
11
|
+
class Cop < Base
|
12
|
+
attr_reader :offenses
|
33
13
|
|
14
|
+
exclude_from_registry
|
15
|
+
|
16
|
+
# @deprecated
|
34
17
|
Correction = Struct.new(:lambda, :node, :cop) do
|
35
18
|
def call(corrector)
|
36
19
|
lambda.call(corrector)
|
@@ -41,230 +24,136 @@ module RuboCop
|
|
41
24
|
end
|
42
25
|
end
|
43
26
|
|
44
|
-
|
45
|
-
|
46
|
-
|
47
|
-
|
48
|
-
|
49
|
-
|
50
|
-
|
51
|
-
|
52
|
-
|
53
|
-
|
54
|
-
registry.without_department(:Test).cops
|
55
|
-
end
|
56
|
-
|
57
|
-
def self.qualified_cop_name(name, origin)
|
58
|
-
registry.qualified_cop_name(name, origin)
|
59
|
-
end
|
60
|
-
|
61
|
-
def self.inherited(subclass)
|
62
|
-
registry.enlist(subclass)
|
63
|
-
end
|
64
|
-
|
65
|
-
def self.badge
|
66
|
-
@badge ||= Badge.for(name)
|
67
|
-
end
|
68
|
-
|
69
|
-
def self.cop_name
|
70
|
-
badge.to_s
|
71
|
-
end
|
72
|
-
|
73
|
-
def self.department
|
74
|
-
badge.department
|
75
|
-
end
|
76
|
-
|
77
|
-
def self.lint?
|
78
|
-
department == :Lint
|
79
|
-
end
|
80
|
-
|
81
|
-
# Returns true if the cop name or the cop namespace matches any of the
|
82
|
-
# given names.
|
83
|
-
def self.match?(given_names)
|
84
|
-
return false unless given_names
|
85
|
-
|
86
|
-
given_names.include?(cop_name) ||
|
87
|
-
given_names.include?(department.to_s)
|
88
|
-
end
|
89
|
-
|
90
|
-
# List of cops that should not try to autocorrect at the same
|
91
|
-
# time as this cop
|
92
|
-
#
|
93
|
-
# @return [Array<RuboCop::Cop::Cop>]
|
94
|
-
#
|
95
|
-
# @api public
|
96
|
-
def self.autocorrect_incompatible_with
|
97
|
-
[]
|
98
|
-
end
|
99
|
-
|
100
|
-
def initialize(config = nil, options = nil)
|
101
|
-
@config = config || Config.new
|
102
|
-
@options = options || { debug: false }
|
103
|
-
|
104
|
-
@offenses = []
|
105
|
-
@corrections = []
|
106
|
-
@corrected_nodes = {}
|
107
|
-
@corrected_nodes.compare_by_identity
|
108
|
-
@processed_source = nil
|
109
|
-
end
|
110
|
-
|
111
|
-
def join_force?(_force_class)
|
112
|
-
false
|
113
|
-
end
|
114
|
-
|
115
|
-
def cop_config
|
116
|
-
# Use department configuration as basis, but let individual cop
|
117
|
-
# configuration override.
|
118
|
-
@cop_config ||= @config.for_cop(self.class.department.to_s)
|
119
|
-
.merge(@config.for_cop(self))
|
120
|
-
end
|
121
|
-
|
122
|
-
def message(_node = nil)
|
123
|
-
self.class::MSG
|
124
|
-
end
|
125
|
-
|
126
|
-
# rubocop:disable Metrics/CyclomaticComplexity
|
127
|
-
def add_offense(node, location: :expression, message: nil, severity: nil)
|
128
|
-
loc = find_location(node, location)
|
129
|
-
|
130
|
-
return if duplicate_location?(loc)
|
131
|
-
|
132
|
-
severity = custom_severity || severity || default_severity
|
133
|
-
|
134
|
-
message ||= message(node)
|
135
|
-
message = annotate(message)
|
136
|
-
|
137
|
-
status = enabled_line?(loc.line) ? correct(node) : :disabled
|
138
|
-
|
139
|
-
@offenses << Offense.new(severity, loc, message, name, status)
|
140
|
-
yield if block_given? && status != :disabled
|
27
|
+
def add_offense(node_or_range, location: :expression, message: nil, severity: nil, &block)
|
28
|
+
@v0_argument = node_or_range
|
29
|
+
range = find_location(node_or_range, location)
|
30
|
+
if block.nil? && !autocorrect?
|
31
|
+
super(range, message: message, severity: severity)
|
32
|
+
else
|
33
|
+
super(range, message: message, severity: severity) do |corrector|
|
34
|
+
emulate_v0_callsequence(corrector, &block)
|
35
|
+
end
|
36
|
+
end
|
141
37
|
end
|
142
|
-
# rubocop:enable Metrics/CyclomaticComplexity
|
143
38
|
|
144
39
|
def find_location(node, loc)
|
145
40
|
# Location can be provided as a symbol, e.g.: `:keyword`
|
146
41
|
loc.is_a?(Symbol) ? node.loc.public_send(loc) : loc
|
147
42
|
end
|
148
43
|
|
149
|
-
|
150
|
-
|
44
|
+
# @deprecated Use class method
|
45
|
+
def support_autocorrect?
|
46
|
+
# warn 'deprecated, use cop.class.support_autocorrect?' TODO
|
47
|
+
self.class.support_autocorrect?
|
151
48
|
end
|
152
49
|
|
153
|
-
def
|
154
|
-
|
155
|
-
|
50
|
+
def self.support_autocorrect?
|
51
|
+
method_defined?(:autocorrect)
|
52
|
+
end
|
156
53
|
|
157
|
-
|
158
|
-
|
159
|
-
correction = autocorrect(node)
|
160
|
-
return :uncorrected unless correction
|
54
|
+
def self.joining_forces
|
55
|
+
return unless method_defined?(:join_force?)
|
161
56
|
|
162
|
-
|
163
|
-
|
164
|
-
|
165
|
-
disable_uncorrectable(node)
|
166
|
-
:corrected_with_todo
|
57
|
+
cop = new
|
58
|
+
Force.all.select do |force_class|
|
59
|
+
cop.join_force?(force_class)
|
167
60
|
end
|
168
61
|
end
|
169
62
|
|
170
|
-
|
171
|
-
|
172
|
-
|
173
|
-
return
|
63
|
+
# @deprecated
|
64
|
+
def corrections
|
65
|
+
# warn 'Cop#corrections is deprecated' TODO
|
66
|
+
return [] unless @last_corrector
|
174
67
|
|
175
|
-
|
68
|
+
Legacy::CorrectionsProxy.new(@last_corrector)
|
176
69
|
end
|
177
70
|
|
178
|
-
|
179
|
-
|
180
|
-
|
181
|
-
|
182
|
-
|
183
|
-
@disabled_lines[line] = true
|
184
|
-
@corrections << Correction.new(disable_offense(node), node, self)
|
71
|
+
# Called before all on_... have been called
|
72
|
+
def on_new_investigation
|
73
|
+
investigate(processed_source) if respond_to?(:investigate)
|
74
|
+
super
|
185
75
|
end
|
186
76
|
|
187
|
-
|
188
|
-
|
189
|
-
|
77
|
+
# Called after all on_... have been called
|
78
|
+
def on_investigation_end
|
79
|
+
investigate_post_walk(processed_source) if respond_to?(:investigate_post_walk)
|
80
|
+
super
|
190
81
|
end
|
191
82
|
|
192
|
-
|
193
|
-
|
194
|
-
|
83
|
+
### Deprecated registry access
|
84
|
+
|
85
|
+
# @deprecated Use Registry.global
|
86
|
+
def self.registry
|
87
|
+
Registry.global
|
195
88
|
end
|
196
89
|
|
197
|
-
|
198
|
-
|
90
|
+
# @deprecated Use Registry.all
|
91
|
+
def self.all
|
92
|
+
Registry.all
|
199
93
|
end
|
200
94
|
|
201
|
-
|
202
|
-
|
95
|
+
# @deprecated Use Registry.qualified_cop_name
|
96
|
+
def self.qualified_cop_name(name, origin)
|
97
|
+
Registry.qualified_cop_name(name, origin)
|
203
98
|
end
|
204
99
|
|
100
|
+
# @deprecated
|
101
|
+
# Open issue if there's a valid use case to include this in Base
|
205
102
|
def parse(source, path = nil)
|
206
103
|
ProcessedSource.new(source, target_ruby_version, path)
|
207
104
|
end
|
208
105
|
|
209
|
-
|
210
|
-
@cop_name ||= self.class.cop_name
|
211
|
-
end
|
212
|
-
|
213
|
-
alias name cop_name
|
106
|
+
private
|
214
107
|
|
215
|
-
def
|
216
|
-
|
217
|
-
|
108
|
+
def begin_investigation(processed_source)
|
109
|
+
super
|
110
|
+
@offenses = @current_offenses
|
111
|
+
@last_corrector = @current_corrector
|
218
112
|
end
|
219
113
|
|
220
|
-
|
221
|
-
|
114
|
+
# Override Base
|
115
|
+
def callback_argument(_range)
|
116
|
+
@v0_argument
|
222
117
|
end
|
223
118
|
|
224
|
-
|
225
|
-
|
226
|
-
def annotate(message)
|
227
|
-
RuboCop::Cop::MessageAnnotator.new(
|
228
|
-
config, cop_name, cop_config, @options
|
229
|
-
).annotate(message)
|
119
|
+
def apply_correction(corrector)
|
120
|
+
suppress_clobbering { super }
|
230
121
|
end
|
231
122
|
|
232
|
-
|
233
|
-
|
234
|
-
|
123
|
+
# Just for legacy
|
124
|
+
def emulate_v0_callsequence(corrector)
|
125
|
+
lambda = correction_lambda
|
126
|
+
yield corrector if block_given?
|
127
|
+
unless corrector.empty?
|
128
|
+
raise 'Your cop must inherit from Cop::Base and extend AutoCorrector'
|
129
|
+
end
|
235
130
|
|
236
|
-
|
237
|
-
patterns.any? do |pattern|
|
238
|
-
# Try to match the absolute path, as Exclude properties are absolute.
|
239
|
-
next true if match_path?(pattern, file)
|
131
|
+
return unless lambda
|
240
132
|
|
241
|
-
|
242
|
-
|
243
|
-
match_path?(pattern, path)
|
133
|
+
suppress_clobbering do
|
134
|
+
lambda.call(corrector)
|
244
135
|
end
|
245
136
|
end
|
246
137
|
|
247
|
-
def
|
248
|
-
return
|
138
|
+
def correction_lambda
|
139
|
+
return unless correction_strategy == :attempt_correction && support_autocorrect?
|
249
140
|
|
250
|
-
@
|
141
|
+
dedup_on_node(@v0_argument) do
|
142
|
+
autocorrect(@v0_argument)
|
143
|
+
end
|
251
144
|
end
|
252
145
|
|
253
|
-
def
|
254
|
-
|
146
|
+
def dedup_on_node(node)
|
147
|
+
@corrected_nodes ||= {}.compare_by_identity
|
148
|
+
yield unless @corrected_nodes.key?(node)
|
149
|
+
ensure
|
150
|
+
@corrected_nodes[node] = true
|
255
151
|
end
|
256
152
|
|
257
|
-
def
|
258
|
-
|
259
|
-
|
260
|
-
|
261
|
-
if Severity::NAMES.include?(severity.to_sym)
|
262
|
-
severity.to_sym
|
263
|
-
else
|
264
|
-
message = "Warning: Invalid severity '#{severity}'. " \
|
265
|
-
"Valid severities are #{Severity::NAMES.join(', ')}."
|
266
|
-
warn(Rainbow(message).red)
|
267
|
-
end
|
153
|
+
def suppress_clobbering
|
154
|
+
yield
|
155
|
+
rescue ::Parser::ClobberingError
|
156
|
+
# ignore Clobbering errors
|
268
157
|
end
|
269
158
|
end
|
270
159
|
end
|