rubocop 0.75.1 → 0.93.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (647) hide show
  1. checksums.yaml +4 -4
  2. data/LICENSE.txt +1 -1
  3. data/README.md +31 -23
  4. data/bin/rubocop-profile +32 -0
  5. data/config/default.yml +940 -401
  6. data/lib/rubocop.rb +130 -94
  7. data/lib/rubocop/ast_aliases.rb +8 -0
  8. data/lib/rubocop/cached_data.rb +3 -1
  9. data/lib/rubocop/cli.rb +20 -232
  10. data/lib/rubocop/cli/command.rb +22 -0
  11. data/lib/rubocop/cli/command/auto_genenerate_config.rb +141 -0
  12. data/lib/rubocop/cli/command/base.rb +35 -0
  13. data/lib/rubocop/cli/command/execute_runner.rb +85 -0
  14. data/lib/rubocop/cli/command/init_dotfile.rb +46 -0
  15. data/lib/rubocop/cli/command/show_cops.rb +77 -0
  16. data/lib/rubocop/cli/command/version.rb +18 -0
  17. data/lib/rubocop/cli/environment.rb +22 -0
  18. data/lib/rubocop/comment_config.rb +26 -14
  19. data/lib/rubocop/config.rb +68 -14
  20. data/lib/rubocop/config_loader.rb +89 -102
  21. data/lib/rubocop/config_loader_resolver.rb +51 -10
  22. data/lib/rubocop/config_obsoletion.rb +81 -11
  23. data/lib/rubocop/config_regeneration.rb +33 -0
  24. data/lib/rubocop/config_store.rb +19 -5
  25. data/lib/rubocop/config_validator.rb +98 -113
  26. data/lib/rubocop/cop/autocorrect_logic.rb +21 -29
  27. data/lib/rubocop/cop/badge.rb +6 -6
  28. data/lib/rubocop/cop/base.rb +430 -0
  29. data/lib/rubocop/cop/bundler/duplicated_gem.rb +5 -1
  30. data/lib/rubocop/cop/bundler/gem_comment.rb +82 -8
  31. data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +14 -22
  32. data/lib/rubocop/cop/commissioner.rb +84 -60
  33. data/lib/rubocop/cop/cop.rb +91 -202
  34. data/lib/rubocop/cop/corrector.rb +69 -121
  35. data/lib/rubocop/cop/correctors/alignment_corrector.rb +7 -11
  36. data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -6
  37. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
  38. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +4 -4
  39. data/lib/rubocop/cop/correctors/line_break_corrector.rb +10 -10
  40. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +34 -3
  41. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +5 -8
  42. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +6 -11
  43. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
  44. data/lib/rubocop/cop/correctors/space_corrector.rb +2 -5
  45. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +2 -2
  46. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +15 -18
  47. data/lib/rubocop/cop/documentation.rb +22 -0
  48. data/lib/rubocop/cop/force.rb +1 -0
  49. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +2 -4
  50. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +42 -16
  51. data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +1 -1
  52. data/lib/rubocop/cop/generator.rb +9 -8
  53. data/lib/rubocop/cop/generator/configuration_injector.rb +5 -5
  54. data/lib/rubocop/cop/ignored_node.rb +1 -3
  55. data/lib/rubocop/cop/internal_affairs.rb +1 -0
  56. data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +52 -0
  57. data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +1 -1
  58. data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +12 -14
  59. data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +9 -8
  60. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +11 -7
  61. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +8 -8
  62. data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +2 -2
  63. data/lib/rubocop/cop/layout/{align_arguments.rb → argument_alignment.rb} +1 -1
  64. data/lib/rubocop/cop/layout/array_alignment.rb +83 -0
  65. data/lib/rubocop/cop/layout/{indent_assignment.rb → assignment_indentation.rb} +1 -1
  66. data/lib/rubocop/cop/layout/begin_end_alignment.rb +77 -0
  67. data/lib/rubocop/cop/layout/block_alignment.rb +24 -20
  68. data/lib/rubocop/cop/layout/block_end_newline.rb +5 -3
  69. data/lib/rubocop/cop/layout/case_indentation.rb +21 -25
  70. data/lib/rubocop/cop/layout/class_structure.rb +35 -70
  71. data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +4 -6
  72. data/lib/rubocop/cop/layout/comment_indentation.rb +14 -17
  73. data/lib/rubocop/cop/layout/condition_position.rb +16 -8
  74. data/lib/rubocop/cop/layout/def_end_alignment.rb +8 -5
  75. data/lib/rubocop/cop/layout/dot_position.rb +21 -20
  76. data/lib/rubocop/cop/layout/else_alignment.rb +8 -0
  77. data/lib/rubocop/cop/layout/empty_comment.rb +38 -40
  78. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +21 -18
  79. data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +13 -13
  80. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
  81. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +22 -23
  82. data/lib/rubocop/cop/layout/empty_lines.rb +6 -9
  83. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +20 -20
  84. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +7 -8
  85. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +118 -0
  86. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +2 -5
  87. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +2 -5
  88. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +2 -5
  89. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +3 -7
  90. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +2 -5
  91. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +2 -5
  92. data/lib/rubocop/cop/layout/end_alignment.rb +14 -19
  93. data/lib/rubocop/cop/layout/end_of_line.rb +11 -6
  94. data/lib/rubocop/cop/layout/extra_spacing.rb +23 -37
  95. data/lib/rubocop/cop/layout/{indent_first_argument.rb → first_argument_indentation.rb} +17 -13
  96. data/lib/rubocop/cop/layout/{indent_first_array_element.rb → first_array_element_indentation.rb} +18 -14
  97. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +3 -6
  98. data/lib/rubocop/cop/layout/{indent_first_hash_element.rb → first_hash_element_indentation.rb} +5 -5
  99. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +2 -5
  100. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +5 -11
  101. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +2 -5
  102. data/lib/rubocop/cop/layout/{indent_first_parameter.rb → first_parameter_indentation.rb} +5 -5
  103. data/lib/rubocop/cop/layout/{align_hash.rb → hash_alignment.rb} +39 -35
  104. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +18 -21
  105. data/lib/rubocop/cop/layout/heredoc_indentation.rb +176 -0
  106. data/lib/rubocop/cop/layout/{tab.rb → indentation_style.rb} +48 -8
  107. data/lib/rubocop/cop/layout/indentation_width.rb +1 -3
  108. data/lib/rubocop/cop/layout/initial_indentation.rb +6 -7
  109. data/lib/rubocop/cop/layout/leading_comment_space.rb +46 -13
  110. data/lib/rubocop/cop/layout/{leading_blank_lines.rb → leading_empty_lines.rb} +6 -11
  111. data/lib/rubocop/cop/{metrics → layout}/line_length.rb +78 -119
  112. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +2 -5
  113. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +2 -5
  114. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +11 -15
  115. data/lib/rubocop/cop/layout/multiline_block_layout.rb +50 -29
  116. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +2 -9
  117. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +2 -5
  118. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +6 -12
  119. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +2 -5
  120. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +1 -1
  121. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +2 -5
  122. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +13 -4
  123. data/lib/rubocop/cop/layout/{align_parameters.rb → parameter_alignment.rb} +1 -1
  124. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +41 -22
  125. data/lib/rubocop/cop/layout/space_after_colon.rb +12 -8
  126. data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
  127. data/lib/rubocop/cop/layout/space_after_method_name.rb +5 -6
  128. data/lib/rubocop/cop/layout/space_after_not.rb +9 -11
  129. data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
  130. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +22 -27
  131. data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +17 -21
  132. data/lib/rubocop/cop/layout/space_around_keyword.rb +31 -20
  133. data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
  134. data/lib/rubocop/cop/layout/space_around_operators.rb +82 -21
  135. data/lib/rubocop/cop/layout/space_before_block_braces.rb +54 -22
  136. data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
  137. data/lib/rubocop/cop/layout/space_before_comment.rb +9 -8
  138. data/lib/rubocop/cop/layout/space_before_first_arg.rb +15 -7
  139. data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
  140. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +17 -23
  141. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +32 -33
  142. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +3 -8
  143. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +16 -19
  144. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +21 -46
  145. data/lib/rubocop/cop/layout/space_inside_parens.rb +15 -20
  146. data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +5 -10
  147. data/lib/rubocop/cop/layout/space_inside_range_literal.rb +9 -18
  148. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +17 -27
  149. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +12 -13
  150. data/lib/rubocop/cop/layout/{trailing_blank_lines.rb → trailing_empty_lines.rb} +10 -15
  151. data/lib/rubocop/cop/layout/trailing_whitespace.rb +28 -12
  152. data/lib/rubocop/cop/legacy/corrections_proxy.rb +49 -0
  153. data/lib/rubocop/cop/legacy/corrector.rb +29 -0
  154. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +9 -4
  155. data/lib/rubocop/cop/lint/ambiguous_operator.rb +53 -5
  156. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +35 -6
  157. data/lib/rubocop/cop/lint/assignment_in_condition.rb +2 -2
  158. data/lib/rubocop/cop/lint/big_decimal_new.rb +9 -10
  159. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +50 -0
  160. data/lib/rubocop/cop/lint/boolean_symbol.rb +22 -2
  161. data/lib/rubocop/cop/lint/circular_argument_reference.rb +1 -1
  162. data/lib/rubocop/cop/lint/constant_definition_in_block.rb +74 -0
  163. data/lib/rubocop/cop/lint/constant_resolution.rb +89 -0
  164. data/lib/rubocop/cop/lint/debugger.rb +8 -3
  165. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +7 -10
  166. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +141 -0
  167. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +9 -3
  168. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +1 -1
  169. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
  170. data/lib/rubocop/cop/lint/{duplicated_key.rb → duplicate_hash_key.rb} +1 -1
  171. data/lib/rubocop/cop/lint/duplicate_methods.rb +8 -11
  172. data/lib/rubocop/cop/lint/duplicate_require.rb +46 -0
  173. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
  174. data/lib/rubocop/cop/lint/each_with_object_argument.rb +3 -2
  175. data/lib/rubocop/cop/lint/else_layout.rb +1 -1
  176. data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
  177. data/lib/rubocop/cop/lint/empty_ensure.rb +5 -5
  178. data/lib/rubocop/cop/lint/empty_expression.rb +2 -2
  179. data/lib/rubocop/cop/lint/empty_file.rb +50 -0
  180. data/lib/rubocop/cop/lint/empty_interpolation.rb +5 -6
  181. data/lib/rubocop/cop/lint/empty_when.rb +31 -8
  182. data/lib/rubocop/cop/lint/ensure_return.rb +29 -14
  183. data/lib/rubocop/cop/lint/erb_new_arguments.rb +21 -19
  184. data/lib/rubocop/cop/lint/flip_flop.rb +1 -1
  185. data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
  186. data/lib/rubocop/cop/lint/float_out_of_range.rb +2 -2
  187. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +41 -4
  188. data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +37 -0
  189. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +13 -14
  190. data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
  191. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +6 -5
  192. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +11 -14
  193. data/lib/rubocop/cop/lint/inherit_exception.rb +12 -7
  194. data/lib/rubocop/cop/lint/interpolation_check.rb +21 -5
  195. data/lib/rubocop/cop/lint/literal_as_condition.rb +24 -15
  196. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +7 -7
  197. data/lib/rubocop/cop/lint/loop.rb +30 -7
  198. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +8 -7
  199. data/lib/rubocop/cop/lint/missing_super.rb +99 -0
  200. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +37 -0
  201. data/lib/rubocop/cop/lint/{multiple_compare.rb → multiple_comparison.rb} +10 -11
  202. data/lib/rubocop/cop/lint/nested_method_definition.rb +17 -23
  203. data/lib/rubocop/cop/lint/nested_percent_literal.rb +2 -2
  204. data/lib/rubocop/cop/lint/next_without_accumulator.rb +1 -1
  205. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +160 -0
  206. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +9 -9
  207. data/lib/rubocop/cop/lint/number_conversion.rb +7 -9
  208. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +11 -13
  209. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +79 -0
  210. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +33 -12
  211. data/lib/rubocop/cop/lint/percent_string_array.rb +6 -11
  212. data/lib/rubocop/cop/lint/percent_symbol_array.rb +14 -13
  213. data/lib/rubocop/cop/lint/raise_exception.rb +86 -0
  214. data/lib/rubocop/cop/lint/rand_one.rb +3 -2
  215. data/lib/rubocop/cop/lint/{unneeded_cop_disable_directive.rb → redundant_cop_disable_directive.rb} +84 -76
  216. data/lib/rubocop/cop/lint/{unneeded_cop_enable_directive.rb → redundant_cop_enable_directive.rb} +37 -28
  217. data/lib/rubocop/cop/lint/{unneeded_require_statement.rb → redundant_require_statement.rb} +8 -10
  218. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +78 -0
  219. data/lib/rubocop/cop/lint/{unneeded_splat_expansion.rb → redundant_splat_expansion.rb} +20 -16
  220. data/lib/rubocop/cop/lint/{string_conversion_in_interpolation.rb → redundant_string_coercion.rb} +6 -13
  221. data/lib/rubocop/cop/lint/redundant_with_index.rb +12 -15
  222. data/lib/rubocop/cop/lint/redundant_with_object.rb +12 -15
  223. data/lib/rubocop/cop/lint/regexp_as_condition.rb +6 -2
  224. data/lib/rubocop/cop/lint/require_parentheses.rb +2 -2
  225. data/lib/rubocop/cop/lint/rescue_exception.rb +2 -2
  226. data/lib/rubocop/cop/lint/rescue_type.rb +8 -9
  227. data/lib/rubocop/cop/lint/return_in_void_context.rb +2 -4
  228. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +7 -11
  229. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +14 -10
  230. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +10 -2
  231. data/lib/rubocop/cop/lint/script_permission.rb +10 -7
  232. data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
  233. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +8 -12
  234. data/lib/rubocop/cop/lint/shadowed_argument.rb +3 -3
  235. data/lib/rubocop/cop/lint/shadowed_exception.rb +8 -8
  236. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +7 -7
  237. data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
  238. data/lib/rubocop/cop/lint/{handle_exceptions.rb → suppressed_exception.rb} +21 -27
  239. data/lib/rubocop/cop/lint/syntax.rb +11 -28
  240. data/lib/rubocop/cop/lint/to_json.rb +20 -11
  241. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
  242. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +57 -0
  243. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +4 -4
  244. data/lib/rubocop/cop/lint/unified_integer.rb +4 -8
  245. data/lib/rubocop/cop/lint/unreachable_code.rb +2 -2
  246. data/lib/rubocop/cop/lint/unreachable_loop.rb +171 -0
  247. data/lib/rubocop/cop/lint/unused_block_argument.rb +8 -3
  248. data/lib/rubocop/cop/lint/unused_method_argument.rb +40 -9
  249. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +4 -2
  250. data/lib/rubocop/cop/lint/uri_regexp.rb +12 -47
  251. data/lib/rubocop/cop/lint/useless_access_modifier.rb +87 -39
  252. data/lib/rubocop/cop/lint/useless_assignment.rb +7 -6
  253. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +7 -11
  254. data/lib/rubocop/cop/lint/useless_method_definition.rb +70 -0
  255. data/lib/rubocop/cop/lint/useless_setter_call.rb +9 -7
  256. data/lib/rubocop/cop/lint/useless_times.rb +106 -0
  257. data/lib/rubocop/cop/lint/void.rb +7 -11
  258. data/lib/rubocop/cop/metrics/abc_size.rb +2 -2
  259. data/lib/rubocop/cop/metrics/block_length.rb +27 -3
  260. data/lib/rubocop/cop/metrics/block_nesting.rb +2 -2
  261. data/lib/rubocop/cop/metrics/class_length.rb +39 -8
  262. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +37 -4
  263. data/lib/rubocop/cop/metrics/method_length.rb +26 -3
  264. data/lib/rubocop/cop/metrics/module_length.rb +26 -3
  265. data/lib/rubocop/cop/metrics/parameter_lists.rb +2 -6
  266. data/lib/rubocop/cop/metrics/perceived_complexity.rb +7 -8
  267. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +80 -9
  268. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +158 -0
  269. data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
  270. data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +37 -0
  271. data/lib/rubocop/cop/migration/department_name.rb +55 -16
  272. data/lib/rubocop/cop/mixin/alignment.rb +7 -5
  273. data/lib/rubocop/cop/mixin/allowed_methods.rb +21 -0
  274. data/lib/rubocop/cop/mixin/annotation_comment.rb +5 -0
  275. data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
  276. data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
  277. data/lib/rubocop/cop/mixin/check_line_breakable.rb +19 -16
  278. data/lib/rubocop/cop/mixin/code_length.rb +26 -5
  279. data/lib/rubocop/cop/mixin/comments_help.rb +48 -0
  280. data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +5 -3
  281. data/lib/rubocop/cop/mixin/configurable_formatting.rb +3 -5
  282. data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
  283. data/lib/rubocop/cop/mixin/configurable_numbering.rb +3 -3
  284. data/lib/rubocop/cop/mixin/documentation_comment.rb +2 -2
  285. data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +8 -7
  286. data/lib/rubocop/cop/mixin/empty_parameter.rb +3 -1
  287. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +18 -2
  288. data/lib/rubocop/cop/mixin/enforce_superclass.rb +3 -1
  289. data/lib/rubocop/cop/mixin/first_element_line_break.rb +4 -2
  290. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +14 -5
  291. data/lib/rubocop/cop/mixin/{hash_alignment.rb → hash_alignment_styles.rb} +1 -1
  292. data/lib/rubocop/cop/mixin/hash_transform_method.rb +197 -0
  293. data/lib/rubocop/cop/mixin/ignored_pattern.rb +1 -1
  294. data/lib/rubocop/cop/mixin/line_length_help.rb +87 -0
  295. data/lib/rubocop/cop/mixin/method_complexity.rb +17 -3
  296. data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +3 -1
  297. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +1 -1
  298. data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +13 -12
  299. data/lib/rubocop/cop/mixin/negative_conditional.rb +2 -2
  300. data/lib/rubocop/cop/mixin/nil_methods.rb +4 -6
  301. data/lib/rubocop/cop/mixin/ordered_gem_node.rb +6 -1
  302. data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
  303. data/lib/rubocop/cop/mixin/percent_array.rb +16 -9
  304. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +1 -1
  305. data/lib/rubocop/cop/mixin/range_help.rb +19 -5
  306. data/lib/rubocop/cop/mixin/rational_literal.rb +18 -0
  307. data/lib/rubocop/cop/mixin/rescue_node.rb +11 -1
  308. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +4 -3
  309. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +4 -3
  310. data/lib/rubocop/cop/mixin/statement_modifier.rb +46 -23
  311. data/lib/rubocop/cop/mixin/string_literals_help.rb +1 -1
  312. data/lib/rubocop/cop/mixin/surrounding_space.rb +15 -31
  313. data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
  314. data/lib/rubocop/cop/mixin/trailing_comma.rb +27 -33
  315. data/lib/rubocop/cop/mixin/uncommunicative_name.rb +13 -18
  316. data/lib/rubocop/cop/mixin/unused_argument.rb +4 -6
  317. data/lib/rubocop/cop/mixin/visibility_help.rb +38 -0
  318. data/lib/rubocop/cop/naming/accessor_method_name.rb +4 -2
  319. data/lib/rubocop/cop/naming/ascii_identifiers.rb +29 -6
  320. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +4 -4
  321. data/lib/rubocop/cop/naming/{uncommunicative_block_param_name.rb → block_parameter_name.rb} +3 -3
  322. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +13 -3
  323. data/lib/rubocop/cop/naming/constant_name.rb +3 -2
  324. data/lib/rubocop/cop/naming/file_name.rb +40 -22
  325. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +2 -2
  326. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +8 -8
  327. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +3 -3
  328. data/lib/rubocop/cop/naming/method_name.rb +27 -1
  329. data/lib/rubocop/cop/naming/{uncommunicative_method_param_name.rb → method_parameter_name.rb} +3 -3
  330. data/lib/rubocop/cop/naming/predicate_name.rb +10 -14
  331. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +13 -12
  332. data/lib/rubocop/cop/naming/variable_name.rb +1 -1
  333. data/lib/rubocop/cop/naming/variable_number.rb +1 -1
  334. data/lib/rubocop/cop/offense.rb +41 -2
  335. data/lib/rubocop/cop/registry.rb +80 -15
  336. data/lib/rubocop/cop/security/eval.rb +3 -2
  337. data/lib/rubocop/cop/security/json_load.rb +7 -8
  338. data/lib/rubocop/cop/security/marshal_load.rb +3 -4
  339. data/lib/rubocop/cop/security/open.rb +3 -2
  340. data/lib/rubocop/cop/security/yaml_load.rb +7 -6
  341. data/lib/rubocop/cop/severity.rb +1 -11
  342. data/lib/rubocop/cop/style/access_modifier_declarations.rb +36 -13
  343. data/lib/rubocop/cop/style/accessor_grouping.rb +152 -0
  344. data/lib/rubocop/cop/style/alias.rb +44 -37
  345. data/lib/rubocop/cop/style/and_or.rb +16 -19
  346. data/lib/rubocop/cop/style/array_coercion.rb +67 -0
  347. data/lib/rubocop/cop/style/array_join.rb +8 -9
  348. data/lib/rubocop/cop/style/ascii_comments.rb +4 -4
  349. data/lib/rubocop/cop/style/attr.rb +22 -13
  350. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +7 -7
  351. data/lib/rubocop/cop/style/bare_percent_literals.rb +12 -14
  352. data/lib/rubocop/cop/style/begin_block.rb +2 -2
  353. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +141 -0
  354. data/lib/rubocop/cop/style/block_comments.rb +14 -18
  355. data/lib/rubocop/cop/style/block_delimiters.rb +77 -26
  356. data/lib/rubocop/cop/style/case_equality.rb +54 -4
  357. data/lib/rubocop/cop/style/case_like_if.rb +252 -0
  358. data/lib/rubocop/cop/style/character_literal.rb +2 -2
  359. data/lib/rubocop/cop/style/class_and_module_children.rb +17 -12
  360. data/lib/rubocop/cop/style/class_check.rb +6 -11
  361. data/lib/rubocop/cop/style/class_equality_comparison.rb +64 -0
  362. data/lib/rubocop/cop/style/class_methods.rb +7 -11
  363. data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
  364. data/lib/rubocop/cop/style/class_vars.rb +23 -7
  365. data/lib/rubocop/cop/style/collection_methods.rb +13 -17
  366. data/lib/rubocop/cop/style/colon_method_call.rb +8 -9
  367. data/lib/rubocop/cop/style/colon_method_definition.rb +6 -6
  368. data/lib/rubocop/cop/style/combinable_loops.rb +91 -0
  369. data/lib/rubocop/cop/style/command_literal.rb +24 -25
  370. data/lib/rubocop/cop/style/comment_annotation.rb +23 -17
  371. data/lib/rubocop/cop/style/commented_keyword.rb +13 -11
  372. data/lib/rubocop/cop/style/conditional_assignment.rb +69 -73
  373. data/lib/rubocop/cop/style/constant_visibility.rb +3 -2
  374. data/lib/rubocop/cop/style/copyright.rb +27 -23
  375. data/lib/rubocop/cop/style/date_time.rb +14 -3
  376. data/lib/rubocop/cop/style/def_with_parentheses.rb +8 -10
  377. data/lib/rubocop/cop/style/dir.rb +10 -12
  378. data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +47 -0
  379. data/lib/rubocop/cop/style/documentation.rb +51 -15
  380. data/lib/rubocop/cop/style/documentation_method.rb +1 -1
  381. data/lib/rubocop/cop/style/double_cop_disable_directive.rb +14 -17
  382. data/lib/rubocop/cop/style/double_negation.rb +44 -6
  383. data/lib/rubocop/cop/style/each_for_simple_loop.rb +5 -8
  384. data/lib/rubocop/cop/style/each_with_object.rb +16 -19
  385. data/lib/rubocop/cop/style/empty_block_parameter.rb +9 -10
  386. data/lib/rubocop/cop/style/empty_case_condition.rb +29 -28
  387. data/lib/rubocop/cop/style/empty_else.rb +17 -19
  388. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +9 -10
  389. data/lib/rubocop/cop/style/empty_literal.rb +26 -27
  390. data/lib/rubocop/cop/style/empty_method.rb +13 -20
  391. data/lib/rubocop/cop/style/encoding.rb +6 -10
  392. data/lib/rubocop/cop/style/end_block.rb +6 -2
  393. data/lib/rubocop/cop/style/eval_with_location.rb +8 -8
  394. data/lib/rubocop/cop/style/even_odd.rb +9 -12
  395. data/lib/rubocop/cop/style/expand_path_arguments.rb +26 -25
  396. data/lib/rubocop/cop/style/explicit_block_argument.rb +106 -0
  397. data/lib/rubocop/cop/style/exponential_notation.rb +117 -0
  398. data/lib/rubocop/cop/style/float_division.rb +10 -11
  399. data/lib/rubocop/cop/style/for.rb +7 -15
  400. data/lib/rubocop/cop/style/format_string.rb +30 -28
  401. data/lib/rubocop/cop/style/format_string_token.rb +15 -16
  402. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +98 -35
  403. data/lib/rubocop/cop/style/global_std_stream.rb +65 -0
  404. data/lib/rubocop/cop/style/global_vars.rb +2 -2
  405. data/lib/rubocop/cop/style/guard_clause.rb +34 -10
  406. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +88 -0
  407. data/lib/rubocop/cop/style/hash_each_methods.rb +86 -0
  408. data/lib/rubocop/cop/style/hash_like_case.rb +76 -0
  409. data/lib/rubocop/cop/style/hash_syntax.rb +27 -18
  410. data/lib/rubocop/cop/style/hash_transform_keys.rb +91 -0
  411. data/lib/rubocop/cop/style/hash_transform_values.rb +88 -0
  412. data/lib/rubocop/cop/style/identical_conditional_branches.rb +2 -2
  413. data/lib/rubocop/cop/style/if_inside_else.rb +2 -2
  414. data/lib/rubocop/cop/style/if_unless_modifier.rb +80 -44
  415. data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +11 -3
  416. data/lib/rubocop/cop/style/if_with_semicolon.rb +15 -2
  417. data/lib/rubocop/cop/style/implicit_runtime_error.rb +2 -1
  418. data/lib/rubocop/cop/style/infinite_loop.rb +28 -27
  419. data/lib/rubocop/cop/style/inline_comment.rb +4 -4
  420. data/lib/rubocop/cop/style/inverse_methods.rb +37 -37
  421. data/lib/rubocop/cop/style/ip_addresses.rb +5 -5
  422. data/lib/rubocop/cop/style/keyword_parameters_order.rb +53 -0
  423. data/lib/rubocop/cop/style/lambda.rb +9 -13
  424. data/lib/rubocop/cop/style/lambda_call.rb +17 -34
  425. data/lib/rubocop/cop/style/line_end_concatenation.rb +33 -26
  426. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +9 -206
  427. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +174 -0
  428. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +48 -0
  429. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +9 -10
  430. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +12 -3
  431. data/lib/rubocop/cop/style/method_def_parentheses.rb +21 -22
  432. data/lib/rubocop/cop/style/min_max.rb +8 -12
  433. data/lib/rubocop/cop/style/missing_else.rb +11 -21
  434. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +10 -3
  435. data/lib/rubocop/cop/style/mixin_grouping.rb +26 -29
  436. data/lib/rubocop/cop/style/mixin_usage.rb +9 -28
  437. data/lib/rubocop/cop/style/module_function.rb +64 -21
  438. data/lib/rubocop/cop/style/multiline_block_chain.rb +12 -3
  439. data/lib/rubocop/cop/style/multiline_if_modifier.rb +4 -11
  440. data/lib/rubocop/cop/style/multiline_if_then.rb +5 -11
  441. data/lib/rubocop/cop/style/multiline_memoization.rb +15 -13
  442. data/lib/rubocop/cop/style/multiline_method_signature.rb +2 -2
  443. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +31 -9
  444. data/lib/rubocop/cop/style/multiline_when_then.rb +29 -11
  445. data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
  446. data/lib/rubocop/cop/style/mutable_constant.rb +27 -26
  447. data/lib/rubocop/cop/style/negated_if.rb +9 -9
  448. data/lib/rubocop/cop/style/negated_unless.rb +9 -9
  449. data/lib/rubocop/cop/style/negated_while.rb +7 -15
  450. data/lib/rubocop/cop/style/nested_modifier.rb +13 -14
  451. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +21 -22
  452. data/lib/rubocop/cop/style/nested_ternary_operator.rb +29 -2
  453. data/lib/rubocop/cop/style/next.rb +19 -23
  454. data/lib/rubocop/cop/style/nil_comparison.rb +13 -11
  455. data/lib/rubocop/cop/style/non_nil_check.rb +55 -35
  456. data/lib/rubocop/cop/style/not.rb +20 -26
  457. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +6 -11
  458. data/lib/rubocop/cop/style/numeric_literals.rb +8 -4
  459. data/lib/rubocop/cop/style/numeric_predicate.rb +11 -16
  460. data/lib/rubocop/cop/style/one_line_conditional.rb +76 -29
  461. data/lib/rubocop/cop/style/option_hash.rb +4 -4
  462. data/lib/rubocop/cop/style/optional_arguments.rb +2 -2
  463. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +53 -0
  464. data/lib/rubocop/cop/style/or_assignment.rb +16 -12
  465. data/lib/rubocop/cop/style/parallel_assignment.rb +18 -18
  466. data/lib/rubocop/cop/style/parentheses_around_condition.rb +6 -6
  467. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +21 -27
  468. data/lib/rubocop/cop/style/percent_q_literals.rb +8 -10
  469. data/lib/rubocop/cop/style/perl_backrefs.rb +8 -10
  470. data/lib/rubocop/cop/style/preferred_hash_methods.rb +11 -14
  471. data/lib/rubocop/cop/style/proc.rb +7 -7
  472. data/lib/rubocop/cop/style/raise_args.rb +12 -24
  473. data/lib/rubocop/cop/style/random_with_offset.rb +24 -29
  474. data/lib/rubocop/cop/style/redundant_assignment.rb +107 -0
  475. data/lib/rubocop/cop/style/redundant_begin.rb +35 -9
  476. data/lib/rubocop/cop/style/{unneeded_capital_w.rb → redundant_capital_w.rb} +6 -9
  477. data/lib/rubocop/cop/style/{unneeded_condition.rb → redundant_condition.rb} +42 -15
  478. data/lib/rubocop/cop/style/redundant_conditional.rb +9 -9
  479. data/lib/rubocop/cop/style/redundant_exception.rb +19 -13
  480. data/lib/rubocop/cop/style/redundant_fetch_block.rb +113 -0
  481. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +51 -0
  482. data/lib/rubocop/cop/style/redundant_freeze.rb +6 -8
  483. data/lib/rubocop/cop/style/{unneeded_interpolation.rb → redundant_interpolation.rb} +31 -25
  484. data/lib/rubocop/cop/style/redundant_parentheses.rb +34 -26
  485. data/lib/rubocop/cop/style/{unneeded_percent_q.rb → redundant_percent_q.rb} +13 -15
  486. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +98 -0
  487. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +105 -0
  488. data/lib/rubocop/cop/style/redundant_return.rb +40 -44
  489. data/lib/rubocop/cop/style/redundant_self.rb +15 -20
  490. data/lib/rubocop/cop/style/redundant_self_assignment.rb +116 -0
  491. data/lib/rubocop/cop/style/{unneeded_sort.rb → redundant_sort.rb} +31 -34
  492. data/lib/rubocop/cop/style/redundant_sort_by.rb +5 -9
  493. data/lib/rubocop/cop/style/regexp_literal.rb +10 -21
  494. data/lib/rubocop/cop/style/rescue_modifier.rb +29 -9
  495. data/lib/rubocop/cop/style/rescue_standard_error.rb +21 -17
  496. data/lib/rubocop/cop/style/return_nil.rb +6 -6
  497. data/lib/rubocop/cop/style/safe_navigation.rb +35 -30
  498. data/lib/rubocop/cop/style/sample.rb +13 -15
  499. data/lib/rubocop/cop/style/self_assignment.rb +26 -22
  500. data/lib/rubocop/cop/style/semicolon.rb +9 -12
  501. data/lib/rubocop/cop/style/send.rb +4 -5
  502. data/lib/rubocop/cop/style/signal_exception.rb +26 -20
  503. data/lib/rubocop/cop/style/single_argument_dig.rb +55 -0
  504. data/lib/rubocop/cop/style/single_line_block_params.rb +4 -2
  505. data/lib/rubocop/cop/style/single_line_methods.rb +18 -17
  506. data/lib/rubocop/cop/style/slicing_with_range.rb +37 -0
  507. data/lib/rubocop/cop/style/sole_nested_conditional.rb +66 -0
  508. data/lib/rubocop/cop/style/special_global_vars.rb +17 -28
  509. data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +17 -23
  510. data/lib/rubocop/cop/style/stderr_puts.rb +6 -7
  511. data/lib/rubocop/cop/style/string_concatenation.rb +106 -0
  512. data/lib/rubocop/cop/style/string_hash_keys.rb +6 -7
  513. data/lib/rubocop/cop/style/string_methods.rb +7 -17
  514. data/lib/rubocop/cop/style/strip.rb +9 -14
  515. data/lib/rubocop/cop/style/struct_inheritance.rb +22 -4
  516. data/lib/rubocop/cop/style/symbol_array.rb +13 -24
  517. data/lib/rubocop/cop/style/symbol_literal.rb +6 -8
  518. data/lib/rubocop/cop/style/symbol_proc.rb +16 -20
  519. data/lib/rubocop/cop/style/ternary_parentheses.rb +25 -28
  520. data/lib/rubocop/cop/style/trailing_body_on_class.rb +3 -6
  521. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +4 -7
  522. data/lib/rubocop/cop/style/trailing_body_on_module.rb +3 -6
  523. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +37 -27
  524. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +43 -5
  525. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +90 -0
  526. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +46 -5
  527. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +9 -32
  528. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +16 -21
  529. data/lib/rubocop/cop/style/trivial_accessors.rb +35 -38
  530. data/lib/rubocop/cop/style/unless_else.rb +6 -9
  531. data/lib/rubocop/cop/style/unpack_first.rb +4 -11
  532. data/lib/rubocop/cop/style/variable_interpolation.rb +7 -10
  533. data/lib/rubocop/cop/style/when_then.rb +5 -7
  534. data/lib/rubocop/cop/style/while_until_do.rb +6 -16
  535. data/lib/rubocop/cop/style/while_until_modifier.rb +8 -22
  536. data/lib/rubocop/cop/style/word_array.rb +6 -24
  537. data/lib/rubocop/cop/style/yoda_condition.rb +29 -8
  538. data/lib/rubocop/cop/style/zero_length_predicate.rb +19 -21
  539. data/lib/rubocop/cop/team.rb +143 -77
  540. data/lib/rubocop/cop/util.rb +30 -17
  541. data/lib/rubocop/cop/utils/format_string.rb +31 -24
  542. data/lib/rubocop/cop/variable_force.rb +16 -17
  543. data/lib/rubocop/cop/variable_force/assignment.rb +1 -0
  544. data/lib/rubocop/cop/variable_force/branch.rb +2 -7
  545. data/lib/rubocop/cop/variable_force/scope.rb +1 -0
  546. data/lib/rubocop/cop/variable_force/variable.rb +7 -8
  547. data/lib/rubocop/cops_documentation_generator.rb +284 -0
  548. data/lib/rubocop/core_ext/string.rb +2 -2
  549. data/lib/rubocop/directive_comment.rb +32 -0
  550. data/lib/rubocop/error.rb +1 -0
  551. data/lib/rubocop/ext/processed_source.rb +18 -0
  552. data/lib/rubocop/ext/regexp_node.rb +62 -0
  553. data/lib/rubocop/file_finder.rb +13 -12
  554. data/lib/rubocop/formatter/auto_gen_config_formatter.rb +2 -1
  555. data/lib/rubocop/formatter/base_formatter.rb +0 -4
  556. data/lib/rubocop/formatter/clang_style_formatter.rb +0 -2
  557. data/lib/rubocop/formatter/disabled_config_formatter.rb +15 -16
  558. data/lib/rubocop/formatter/formatter_set.rb +4 -5
  559. data/lib/rubocop/formatter/html_formatter.rb +2 -0
  560. data/lib/rubocop/formatter/json_formatter.rb +6 -5
  561. data/lib/rubocop/formatter/junit_formatter.rb +84 -0
  562. data/lib/rubocop/formatter/pacman_formatter.rb +1 -1
  563. data/lib/rubocop/formatter/progress_formatter.rb +2 -1
  564. data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
  565. data/lib/rubocop/formatter/simple_text_formatter.rb +36 -6
  566. data/lib/rubocop/formatter/tap_formatter.rb +0 -2
  567. data/lib/rubocop/magic_comment.rb +1 -1
  568. data/lib/rubocop/name_similarity.rb +18 -10
  569. data/lib/rubocop/options.rb +103 -46
  570. data/lib/rubocop/path_util.rb +19 -19
  571. data/lib/rubocop/platform.rb +1 -1
  572. data/lib/rubocop/rake_task.rb +8 -9
  573. data/lib/rubocop/remote_config.rb +2 -3
  574. data/lib/rubocop/result_cache.rb +69 -27
  575. data/lib/rubocop/rspec/cop_helper.rb +11 -31
  576. data/lib/rubocop/rspec/expect_offense.rb +104 -25
  577. data/lib/rubocop/rspec/shared_contexts.rb +79 -29
  578. data/lib/rubocop/runner.rb +123 -74
  579. data/lib/rubocop/string_interpreter.rb +3 -0
  580. data/lib/rubocop/target_finder.rb +61 -50
  581. data/lib/rubocop/target_ruby.rb +160 -0
  582. data/lib/rubocop/version.rb +12 -4
  583. data/lib/rubocop/yaml_duplication_checker.rb +1 -0
  584. metadata +176 -117
  585. data/lib/rubocop/ast/builder.rb +0 -81
  586. data/lib/rubocop/ast/node.rb +0 -640
  587. data/lib/rubocop/ast/node/alias_node.rb +0 -24
  588. data/lib/rubocop/ast/node/and_node.rb +0 -29
  589. data/lib/rubocop/ast/node/args_node.rb +0 -29
  590. data/lib/rubocop/ast/node/array_node.rb +0 -57
  591. data/lib/rubocop/ast/node/block_node.rb +0 -115
  592. data/lib/rubocop/ast/node/break_node.rb +0 -17
  593. data/lib/rubocop/ast/node/case_node.rb +0 -56
  594. data/lib/rubocop/ast/node/class_node.rb +0 -31
  595. data/lib/rubocop/ast/node/def_node.rb +0 -71
  596. data/lib/rubocop/ast/node/defined_node.rb +0 -17
  597. data/lib/rubocop/ast/node/ensure_node.rb +0 -17
  598. data/lib/rubocop/ast/node/float_node.rb +0 -12
  599. data/lib/rubocop/ast/node/for_node.rb +0 -53
  600. data/lib/rubocop/ast/node/hash_node.rb +0 -109
  601. data/lib/rubocop/ast/node/if_node.rb +0 -175
  602. data/lib/rubocop/ast/node/int_node.rb +0 -12
  603. data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
  604. data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
  605. data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -43
  606. data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
  607. data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
  608. data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
  609. data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -261
  610. data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -114
  611. data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
  612. data/lib/rubocop/ast/node/mixin/numeric_node.rb +0 -21
  613. data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
  614. data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
  615. data/lib/rubocop/ast/node/module_node.rb +0 -24
  616. data/lib/rubocop/ast/node/or_node.rb +0 -29
  617. data/lib/rubocop/ast/node/pair_node.rb +0 -63
  618. data/lib/rubocop/ast/node/range_node.rb +0 -18
  619. data/lib/rubocop/ast/node/regexp_node.rb +0 -35
  620. data/lib/rubocop/ast/node/resbody_node.rb +0 -24
  621. data/lib/rubocop/ast/node/retry_node.rb +0 -17
  622. data/lib/rubocop/ast/node/self_class_node.rb +0 -24
  623. data/lib/rubocop/ast/node/send_node.rb +0 -13
  624. data/lib/rubocop/ast/node/str_node.rb +0 -16
  625. data/lib/rubocop/ast/node/super_node.rb +0 -21
  626. data/lib/rubocop/ast/node/symbol_node.rb +0 -12
  627. data/lib/rubocop/ast/node/until_node.rb +0 -35
  628. data/lib/rubocop/ast/node/when_node.rb +0 -53
  629. data/lib/rubocop/ast/node/while_node.rb +0 -35
  630. data/lib/rubocop/ast/node/yield_node.rb +0 -21
  631. data/lib/rubocop/ast/sexp.rb +0 -16
  632. data/lib/rubocop/ast/traversal.rb +0 -183
  633. data/lib/rubocop/cop/layout/align_array.rb +0 -39
  634. data/lib/rubocop/cop/layout/indent_heredoc.rb +0 -256
  635. data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
  636. data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
  637. data/lib/rubocop/cop/mixin/classish_length.rb +0 -37
  638. data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
  639. data/lib/rubocop/cop/mixin/safe_mode.rb +0 -24
  640. data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -35
  641. data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +0 -209
  642. data/lib/rubocop/cop/style/method_missing_super.rb +0 -34
  643. data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
  644. data/lib/rubocop/node_pattern.rb +0 -799
  645. data/lib/rubocop/processed_source.rb +0 -216
  646. data/lib/rubocop/string_util.rb +0 -14
  647. data/lib/rubocop/token.rb +0 -114
@@ -1,17 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # A node extension for `ensure` nodes. This will be used in place of a plain
6
- # node when the builder constructs the AST, making its methods available
7
- # to all `ensure` nodes within RuboCop.
8
- class EnsureNode < Node
9
- # Returns the body of the `ensure` clause.
10
- #
11
- # @return [Node, nil] The body of the `ensure`.
12
- def body
13
- node_parts[1]
14
- end
15
- end
16
- end
17
- end
@@ -1,12 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # A node extension for `float` nodes. This will be used in place of a plain
6
- # node when the builder constructs the AST, making its methods available to
7
- # all `float` nodes within RuboCop.
8
- class FloatNode < Node
9
- include NumericNode
10
- end
11
- end
12
- end
@@ -1,53 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # A node extension for `for` nodes. This will be used in place of a plain
6
- # node when the builder constructs the AST, making its methods available
7
- # to all `for` nodes within RuboCop.
8
- class ForNode < Node
9
- # Returns the keyword of the `for` statement as a string.
10
- #
11
- # @return [String] the keyword of the `until` statement
12
- def keyword
13
- 'for'
14
- end
15
-
16
- # Checks whether the `for` node has a `do` keyword.
17
- #
18
- # @return [Boolean] whether the `for` node has a `do` keyword
19
- def do?
20
- loc.begin&.is?('do')
21
- end
22
-
23
- # Checks whether this node body is a void context.
24
- # Always `true` for `for`.
25
- #
26
- # @return [true] whether the `for` node body is a void context
27
- def void_context?
28
- true
29
- end
30
-
31
- # Returns the iteration variable of the `for` loop.
32
- #
33
- # @return [Node] The iteration variable of the `for` loop
34
- def variable
35
- node_parts[0]
36
- end
37
-
38
- # Returns the collection the `for` loop is iterating over.
39
- #
40
- # @return [Node] The collection the `for` loop is iterating over
41
- def collection
42
- node_parts[1]
43
- end
44
-
45
- # Returns the body of the `for` loop.
46
- #
47
- # @return [Node, nil] The body of the `for` loop.
48
- def body
49
- node_parts[2]
50
- end
51
- end
52
- end
53
- end
@@ -1,109 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # A node extension for `hash` nodes. This will be used in place of a plain
6
- # node when the builder constructs the AST, making its methods available
7
- # to all `hash` nodes within RuboCop.
8
- class HashNode < Node
9
- # Returns an array of all the key value pairs in the `hash` literal.
10
- #
11
- # @return [Array<PairNode>] an array of `pair` nodes
12
- def pairs
13
- each_pair.to_a
14
- end
15
-
16
- # Checks whether the `hash` node contains any `pair`- or `kwsplat` nodes.
17
- #
18
- # @return[Boolean] whether the `hash` is empty
19
- def empty?
20
- children.empty?
21
- end
22
-
23
- # Calls the given block for each `pair` node in the `hash` literal.
24
- # If no block is given, an `Enumerator` is returned.
25
- #
26
- # @return [self] if a block is given
27
- # @return [Enumerator] if no block is given
28
- def each_pair
29
- return each_child_node(:pair).to_enum unless block_given?
30
-
31
- each_child_node(:pair) do |pair|
32
- yield(*pair)
33
- end
34
-
35
- self
36
- end
37
-
38
- # Returns an array of all the keys in the `hash` literal.
39
- #
40
- # @return [Array<Node>] an array of keys in the `hash` literal
41
- def keys
42
- each_key.to_a
43
- end
44
-
45
- # Calls the given block for each `key` node in the `hash` literal.
46
- # If no block is given, an `Enumerator` is returned.
47
- #
48
- # @return [self] if a block is given
49
- # @return [Enumerator] if no block is given
50
- def each_key
51
- return pairs.map(&:key).to_enum unless block_given?
52
-
53
- pairs.map(&:key).each do |key|
54
- yield key
55
- end
56
-
57
- self
58
- end
59
-
60
- # Returns an array of all the values in the `hash` literal.
61
- #
62
- # @return [Array<Node>] an array of values in the `hash` literal
63
- def values
64
- each_pair.map(&:value)
65
- end
66
-
67
- # Calls the given block for each `value` node in the `hash` literal.
68
- # If no block is given, an `Enumerator` is returned.
69
- #
70
- # @return [self] if a block is given
71
- # @return [Enumerator] if no block is given
72
- def each_value
73
- return pairs.map(&:value).to_enum unless block_given?
74
-
75
- pairs.map(&:value).each do |value|
76
- yield value
77
- end
78
-
79
- self
80
- end
81
-
82
- # Checks whether any of the key value pairs in the `hash` literal are on
83
- # the same line.
84
- #
85
- # @note A multiline `pair` is considered to be on the same line if it
86
- # shares any of its lines with another `pair`
87
- #
88
- # @return [Boolean] whether any `pair` nodes are on the same line
89
- def pairs_on_same_line?
90
- pairs.each_cons(2).any? { |first, second| first.same_line?(second) }
91
- end
92
-
93
- # Checks whether this `hash` uses a mix of hash rocket and colon
94
- # delimiters for its pairs.
95
- #
96
- # @return [Boolean] whether the `hash` uses mixed delimiters
97
- def mixed_delimiters?
98
- pairs.map(&:delimiter).uniq.size > 1
99
- end
100
-
101
- # Checks whether the `hash` literal is delimited by curly braces.
102
- #
103
- # @return [Boolean] whether the `hash` literal is enclosed in braces
104
- def braces?
105
- loc.end&.is?('}')
106
- end
107
- end
108
- end
109
- end
@@ -1,175 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # A node extension for `if` nodes. This will be used in place of a plain
6
- # node when the builder constructs the AST, making its methods available
7
- # to all `if` nodes within RuboCop.
8
- class IfNode < Node
9
- include ConditionalNode
10
- include ModifierNode
11
-
12
- # Checks whether this node is an `if` statement. (This is not true of
13
- # ternary operators and `unless` statements.)
14
- #
15
- # @return [Boolean] whether the node is an `if` statement
16
- def if?
17
- keyword == 'if'
18
- end
19
-
20
- # Checks whether this node is an `unless` statement. (This is not true
21
- # of ternary operators and `if` statements.)
22
- #
23
- # @return [Boolean] whether the node is an `unless` statement
24
- def unless?
25
- keyword == 'unless'
26
- end
27
-
28
- # Checks whether the `if` is an `elsif`. Parser handles these by nesting
29
- # `if` nodes in the `else` branch.
30
- #
31
- # @return [Boolean] whether the node is an `elsif`
32
- def elsif?
33
- keyword == 'elsif'
34
- end
35
-
36
- # Checks whether the `if` node has an `else` clause.
37
- #
38
- # @note This returns `true` for nodes containing an `elsif` clause.
39
- # This is legacy behavior, and many cops rely on it.
40
- #
41
- # @return [Boolean] whether the node has an `else` clause
42
- def else?
43
- loc.respond_to?(:else) && loc.else
44
- end
45
-
46
- # Checks whether the `if` node is a ternary operator.
47
- #
48
- # @return [Boolean] whether the `if` node is a ternary operator
49
- def ternary?
50
- loc.respond_to?(:question)
51
- end
52
-
53
- # Returns the keyword of the `if` statement as a string. Returns an empty
54
- # string for ternary operators.
55
- #
56
- # @return [String] the keyword of the `if` statement
57
- def keyword
58
- ternary? ? '' : loc.keyword.source
59
- end
60
-
61
- # Returns the inverse keyword of the `if` node as a string. Returns `if`
62
- # for `unless` nodes and vice versa. Returns an empty string for ternary
63
- # operators.
64
- #
65
- # @return [String] the inverse keyword of the `if` statement
66
- def inverse_keyword
67
- if keyword == 'if'
68
- 'unless'
69
- elsif keyword == 'unless'
70
- 'if'
71
- else
72
- ''
73
- end
74
- end
75
-
76
- # Checks whether the `if` node is in a modifier form, i.e. a condition
77
- # trailing behind an expression. Only `if` and `unless` nodes without
78
- # other branches can be modifiers.
79
- #
80
- # @return [Boolean] whether the `if` node is a modifier
81
- def modifier_form?
82
- (if? || unless?) && super
83
- end
84
-
85
- # Chacks whether the `if` node has nested `if` nodes in any of its
86
- # branches.
87
- #
88
- # @note This performs a shallow search.
89
- #
90
- # @return [Boolean] whether the `if` node contains nested conditionals
91
- def nested_conditional?
92
- node_parts[1..2].compact.each do |branch|
93
- branch.each_node(:if) do |nested|
94
- return true unless nested.elsif?
95
- end
96
- end
97
-
98
- false
99
- end
100
-
101
- # Checks whether the `if` node has at least one `elsif` branch. Returns
102
- # true if this `if` node itself is an `elsif`.
103
- #
104
- # @return [Boolean] whether the `if` node has at least one `elsif` branch
105
- def elsif_conditional?
106
- else_branch&.if_type? && else_branch&.elsif?
107
- end
108
-
109
- # Returns the branch of the `if` node that gets evaluated when its
110
- # condition is truthy.
111
- #
112
- # @note This is normalized for `unless` nodes.
113
- #
114
- # @return [Node] the truthy branch node of the `if` node
115
- # @return [nil] if the truthy branch is empty
116
- def if_branch
117
- node_parts[1]
118
- end
119
-
120
- # Returns the branch of the `if` node that gets evaluated when its
121
- # condition is falsey.
122
- #
123
- # @note This is normalized for `unless` nodes.
124
- #
125
- # @return [Node] the falsey branch node of the `if` node
126
- # @return [nil] when there is no else branch
127
- def else_branch
128
- node_parts[2]
129
- end
130
-
131
- # Custom destructuring method. This is used to normalize the branches
132
- # for `if` and `unless` nodes, to aid comparisons and conversions.
133
- #
134
- # @return [Array<Node>] the different parts of the `if` statement
135
- def node_parts
136
- if unless?
137
- condition, false_branch, true_branch = *self
138
- else
139
- condition, true_branch, false_branch = *self
140
- end
141
-
142
- [condition, true_branch, false_branch]
143
- end
144
-
145
- # Returns an array of all the branches in the conditional statement.
146
- #
147
- # @return [Array<Node>] an array of branch nodes
148
- def branches
149
- branches = [if_branch]
150
-
151
- return branches unless else_branch
152
-
153
- other_branches = if elsif_conditional?
154
- else_branch.branches
155
- else
156
- [else_branch]
157
- end
158
- branches.concat(other_branches)
159
- end
160
-
161
- # Calls the given block for each branch node in the conditional statement.
162
- # If no block is given, an `Enumerator` is returned.
163
- #
164
- # @return [self] if a block is given
165
- # @return [Enumerator] if no block is given
166
- def each_branch
167
- return branches.to_enum(__method__) unless block_given?
168
-
169
- branches.each do |branch|
170
- yield branch
171
- end
172
- end
173
- end
174
- end
175
- end
@@ -1,12 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # A node extension for `int` nodes. This will be used in place of a plain
6
- # node when the builder constructs the AST, making its methods available to
7
- # all `int` nodes within RuboCop.
8
- class IntNode < Node
9
- include NumericNode
10
- end
11
- end
12
- end
@@ -1,45 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # A node extension for `kwsplat` nodes. This will be used in place of a
6
- # plain node when the builder constructs the AST, making its methods
7
- # available to all `kwsplat` nodes within RuboCop.
8
- class KeywordSplatNode < Node
9
- include HashElementNode
10
-
11
- DOUBLE_SPLAT = '**'
12
-
13
- # This is used for duck typing with `pair` nodes which also appear as
14
- # `hash` elements.
15
- #
16
- # @return [false]
17
- def hash_rocket?
18
- false
19
- end
20
-
21
- # This is used for duck typing with `pair` nodes which also appear as
22
- # `hash` elements.
23
- #
24
- # @return [false]
25
- def colon?
26
- false
27
- end
28
-
29
- # Returns the operator for the `kwsplat` as a string.
30
- #
31
- # @return [String] the double splat operator
32
- def operator
33
- DOUBLE_SPLAT
34
- end
35
-
36
- # Custom destructuring method. This is used to normalize the branches
37
- # for `pair` and `kwsplat` nodes, to add duck typing to `hash` elements.
38
- #
39
- # @return [Array<KeywordSplatNode>] the different parts of the `kwsplat`
40
- def node_parts
41
- [self, self]
42
- end
43
- end
44
- end
45
- end
@@ -1,16 +0,0 @@
1
- # frozen_string_literal: true
2
-
3
- module RuboCop
4
- module AST
5
- # Common functionality for primitive literal nodes: `sym`, `str`,
6
- # `int`, `float`, ...
7
- module BasicLiteralNode
8
- # Returns the value of the literal.
9
- #
10
- # @return [mixed] the value of the literal
11
- def value
12
- node_parts[0]
13
- end
14
- end
15
- end
16
- end