rubocop 0.71.0 → 0.75.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/README.md +5 -8
- data/bin/console +1 -0
- data/config/default.yml +84 -488
- data/lib/rubocop.rb +16 -54
- data/lib/rubocop/ast/builder.rb +2 -0
- data/lib/rubocop/ast/node.rb +9 -15
- data/lib/rubocop/ast/node/float_node.rb +12 -0
- data/lib/rubocop/ast/node/int_node.rb +12 -0
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +4 -4
- data/lib/rubocop/ast/node/mixin/numeric_node.rb +21 -0
- data/lib/rubocop/ast/node/resbody_node.rb +1 -6
- data/lib/rubocop/ast/traversal.rb +3 -3
- data/lib/rubocop/cached_data.rb +1 -1
- data/lib/rubocop/comment_config.rb +3 -2
- data/lib/rubocop/config.rb +21 -508
- data/lib/rubocop/config_loader.rb +22 -8
- data/lib/rubocop/config_loader_resolver.rb +2 -16
- data/lib/rubocop/config_obsoletion.rb +213 -0
- data/lib/rubocop/config_validator.rb +239 -0
- data/lib/rubocop/cop/autocorrect_logic.rb +71 -1
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +1 -1
- data/lib/rubocop/cop/bundler/ordered_gems.rb +1 -1
- data/lib/rubocop/cop/commissioner.rb +3 -9
- data/lib/rubocop/cop/cop.rb +39 -12
- data/lib/rubocop/cop/corrector.rb +2 -3
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +43 -17
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +2 -2
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +2 -2
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +2 -2
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +1 -1
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +1 -1
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +55 -0
- data/lib/rubocop/cop/generator.rb +4 -4
- data/lib/rubocop/cop/generator/configuration_injector.rb +9 -4
- data/lib/rubocop/cop/generator/require_file_injector.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +2 -2
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +2 -2
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +2 -2
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +2 -2
- data/lib/rubocop/cop/layout/block_alignment.rb +3 -3
- data/lib/rubocop/cop/layout/class_structure.rb +2 -2
- data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -1
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +22 -7
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +2 -2
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +2 -2
- data/lib/rubocop/cop/layout/extra_spacing.rb +14 -59
- data/lib/rubocop/cop/layout/indent_assignment.rb +10 -1
- data/lib/rubocop/cop/layout/indent_first_argument.rb +7 -3
- data/lib/rubocop/cop/layout/indent_first_parameter.rb +7 -3
- data/lib/rubocop/cop/layout/indent_heredoc.rb +4 -4
- data/lib/rubocop/cop/layout/indentation_consistency.rb +13 -12
- data/lib/rubocop/cop/layout/indentation_width.rb +28 -10
- data/lib/rubocop/cop/layout/leading_comment_space.rb +28 -0
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +24 -2
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +18 -4
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +5 -1
- data/lib/rubocop/cop/layout/space_around_operators.rb +42 -23
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +1 -1
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +21 -2
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +24 -40
- data/lib/rubocop/cop/layout/tab.rb +10 -22
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +17 -4
- data/lib/rubocop/cop/lint/big_decimal_new.rb +1 -1
- data/lib/rubocop/cop/lint/debugger.rb +4 -6
- data/lib/rubocop/cop/lint/duplicate_methods.rb +3 -3
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
- data/lib/rubocop/cop/lint/empty_interpolation.rb +4 -4
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +57 -1
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +11 -37
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -1
- data/lib/rubocop/cop/lint/inherit_exception.rb +1 -1
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +7 -8
- data/lib/rubocop/cop/lint/multiple_compare.rb +1 -1
- data/lib/rubocop/cop/lint/nested_method_definition.rb +3 -3
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +1 -1
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
- data/lib/rubocop/cop/lint/number_conversion.rb +4 -4
- data/lib/rubocop/cop/lint/rand_one.rb +1 -1
- data/lib/rubocop/cop/lint/redundant_with_index.rb +1 -1
- data/lib/rubocop/cop/lint/redundant_with_object.rb +1 -1
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +5 -5
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +91 -0
- data/lib/rubocop/cop/lint/string_conversion_in_interpolation.rb +6 -6
- data/lib/rubocop/cop/lint/unified_integer.rb +1 -1
- data/lib/rubocop/cop/lint/unneeded_cop_disable_directive.rb +1 -1
- data/lib/rubocop/cop/lint/unneeded_require_statement.rb +1 -1
- data/lib/rubocop/cop/lint/unneeded_splat_expansion.rb +7 -2
- data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
- data/lib/rubocop/cop/lint/unused_block_argument.rb +22 -6
- data/lib/rubocop/cop/lint/unused_method_argument.rb +23 -5
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
- data/lib/rubocop/cop/lint/uri_regexp.rb +2 -2
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +6 -6
- data/lib/rubocop/cop/lint/useless_setter_call.rb +1 -1
- data/lib/rubocop/cop/lint/void.rb +3 -22
- data/lib/rubocop/cop/message_annotator.rb +16 -7
- data/lib/rubocop/cop/metrics/class_length.rb +1 -1
- data/lib/rubocop/cop/metrics/line_length.rb +6 -0
- data/lib/rubocop/cop/metrics/module_length.rb +1 -1
- data/lib/rubocop/cop/metrics/parameter_lists.rb +1 -1
- data/lib/rubocop/cop/migration/department_name.rb +44 -0
- data/lib/rubocop/cop/mixin/alignment.rb +1 -1
- data/lib/rubocop/cop/mixin/def_node.rb +1 -1
- data/lib/rubocop/cop/mixin/documentation_comment.rb +0 -2
- data/lib/rubocop/cop/mixin/empty_parameter.rb +1 -1
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +4 -4
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +1 -1
- data/lib/rubocop/cop/mixin/interpolation.rb +27 -0
- data/lib/rubocop/cop/mixin/method_complexity.rb +1 -1
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +3 -3
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +87 -0
- data/lib/rubocop/cop/mixin/safe_mode.rb +2 -0
- data/lib/rubocop/cop/mixin/surrounding_space.rb +7 -5
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
- data/lib/rubocop/cop/naming/constant_name.rb +2 -2
- data/lib/rubocop/cop/naming/method_name.rb +12 -1
- data/lib/rubocop/cop/naming/predicate_name.rb +1 -1
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +21 -20
- data/lib/rubocop/cop/naming/variable_name.rb +1 -0
- data/lib/rubocop/cop/offense.rb +18 -7
- data/lib/rubocop/cop/registry.rb +22 -1
- data/lib/rubocop/cop/security/eval.rb +1 -1
- data/lib/rubocop/cop/security/json_load.rb +1 -1
- data/lib/rubocop/cop/security/marshal_load.rb +1 -1
- data/lib/rubocop/cop/security/open.rb +1 -1
- data/lib/rubocop/cop/security/yaml_load.rb +1 -1
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +1 -0
- data/lib/rubocop/cop/style/alias.rb +1 -1
- data/lib/rubocop/cop/style/block_delimiters.rb +2 -1
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +29 -10
- data/lib/rubocop/cop/style/class_and_module_children.rb +1 -1
- data/lib/rubocop/cop/style/colon_method_call.rb +1 -1
- data/lib/rubocop/cop/style/commented_keyword.rb +16 -30
- data/lib/rubocop/cop/style/conditional_assignment.rb +8 -9
- data/lib/rubocop/cop/style/constant_visibility.rb +14 -3
- data/lib/rubocop/cop/style/date_time.rb +3 -3
- data/lib/rubocop/cop/style/dir.rb +1 -1
- data/lib/rubocop/cop/style/documentation_method.rb +45 -1
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +55 -0
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +1 -1
- data/lib/rubocop/cop/style/each_with_object.rb +1 -1
- data/lib/rubocop/cop/style/eval_with_location.rb +2 -2
- data/lib/rubocop/cop/style/even_odd.rb +1 -1
- data/lib/rubocop/cop/style/expand_path_arguments.rb +4 -4
- data/lib/rubocop/cop/style/float_division.rb +94 -0
- data/lib/rubocop/cop/style/format_string.rb +13 -9
- data/lib/rubocop/cop/style/format_string_token.rb +18 -69
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +18 -33
- data/lib/rubocop/cop/style/guard_clause.rb +39 -10
- data/lib/rubocop/cop/style/hash_syntax.rb +2 -2
- data/lib/rubocop/cop/style/if_inside_else.rb +42 -0
- data/lib/rubocop/cop/style/if_unless_modifier.rb +51 -15
- data/lib/rubocop/cop/style/infinite_loop.rb +1 -1
- data/lib/rubocop/cop/style/inverse_methods.rb +2 -2
- data/lib/rubocop/cop/style/lambda.rb +0 -2
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +32 -26
- data/lib/rubocop/cop/style/min_max.rb +1 -1
- data/lib/rubocop/cop/style/mixin_usage.rb +12 -2
- data/lib/rubocop/cop/style/multiline_memoization.rb +1 -1
- data/lib/rubocop/cop/style/multiline_when_then.rb +55 -0
- data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
- data/lib/rubocop/cop/style/mutable_constant.rb +3 -3
- data/lib/rubocop/cop/style/nested_modifier.rb +18 -2
- data/lib/rubocop/cop/style/numeric_predicate.rb +3 -3
- data/lib/rubocop/cop/style/option_hash.rb +1 -1
- data/lib/rubocop/cop/style/or_assignment.rb +8 -3
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +15 -1
- data/lib/rubocop/cop/style/random_with_offset.rb +6 -6
- data/lib/rubocop/cop/style/redundant_conditional.rb +2 -2
- data/lib/rubocop/cop/style/redundant_exception.rb +2 -2
- data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
- data/lib/rubocop/cop/style/redundant_parentheses.rb +15 -6
- data/lib/rubocop/cop/style/redundant_return.rb +12 -0
- data/lib/rubocop/cop/style/redundant_self.rb +18 -1
- data/lib/rubocop/cop/style/redundant_sort_by.rb +1 -1
- data/lib/rubocop/cop/style/rescue_modifier.rb +24 -0
- data/lib/rubocop/cop/style/rescue_standard_error.rb +2 -2
- data/lib/rubocop/cop/style/return_nil.rb +1 -1
- data/lib/rubocop/cop/style/safe_navigation.rb +19 -2
- data/lib/rubocop/cop/style/sample.rb +1 -1
- data/lib/rubocop/cop/style/semicolon.rb +11 -0
- data/lib/rubocop/cop/style/single_line_methods.rb +8 -1
- data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
- data/lib/rubocop/cop/style/string_hash_keys.rb +2 -2
- data/lib/rubocop/cop/style/strip.rb +1 -1
- data/lib/rubocop/cop/style/struct_inheritance.rb +3 -3
- data/lib/rubocop/cop/style/symbol_proc.rb +1 -1
- data/lib/rubocop/cop/style/ternary_parentheses.rb +32 -3
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +4 -6
- data/lib/rubocop/cop/style/trivial_accessors.rb +1 -1
- data/lib/rubocop/cop/style/unneeded_sort.rb +1 -1
- data/lib/rubocop/cop/style/unpack_first.rb +1 -1
- data/lib/rubocop/cop/style/variable_interpolation.rb +6 -16
- data/lib/rubocop/cop/style/word_array.rb +2 -2
- data/lib/rubocop/cop/style/zero_length_predicate.rb +6 -6
- data/lib/rubocop/cop/team.rb +15 -14
- data/lib/rubocop/cop/utils/format_string.rb +128 -0
- data/lib/rubocop/cop/variable_force/variable.rb +15 -2
- data/lib/rubocop/core_ext/string.rb +0 -24
- data/lib/rubocop/error.rb +23 -0
- data/lib/rubocop/formatter/clang_style_formatter.rb +8 -3
- data/lib/rubocop/formatter/emacs_style_formatter.rb +22 -9
- data/lib/rubocop/formatter/file_list_formatter.rb +1 -1
- data/lib/rubocop/formatter/formatter_set.rb +16 -15
- data/lib/rubocop/formatter/pacman_formatter.rb +80 -0
- data/lib/rubocop/formatter/simple_text_formatter.rb +16 -4
- data/lib/rubocop/formatter/tap_formatter.rb +17 -4
- data/lib/rubocop/magic_comment.rb +4 -0
- data/lib/rubocop/node_pattern.rb +2 -2
- data/lib/rubocop/options.rb +21 -17
- data/lib/rubocop/path_util.rb +1 -1
- data/lib/rubocop/processed_source.rb +6 -1
- data/lib/rubocop/rspec/cop_helper.rb +0 -1
- data/lib/rubocop/rspec/expect_offense.rb +4 -1
- data/lib/rubocop/rspec/shared_contexts.rb +12 -17
- data/lib/rubocop/rspec/support.rb +0 -1
- data/lib/rubocop/runner.rb +14 -25
- data/lib/rubocop/target_finder.rb +6 -4
- data/lib/rubocop/version.rb +1 -1
- data/lib/rubocop/yaml_duplication_checker.rb +8 -2
- metadata +17 -92
- data/lib/rubocop/cop/mixin/ignored_method_patterns.rb +0 -19
- data/lib/rubocop/cop/mixin/target_rails_version.rb +0 -16
- data/lib/rubocop/cop/rails/action_filter.rb +0 -117
- data/lib/rubocop/cop/rails/active_record_aliases.rb +0 -48
- data/lib/rubocop/cop/rails/active_record_override.rb +0 -82
- data/lib/rubocop/cop/rails/active_support_aliases.rb +0 -69
- data/lib/rubocop/cop/rails/application_job.rb +0 -40
- data/lib/rubocop/cop/rails/application_record.rb +0 -40
- data/lib/rubocop/cop/rails/assert_not.rb +0 -44
- data/lib/rubocop/cop/rails/belongs_to.rb +0 -102
- data/lib/rubocop/cop/rails/blank.rb +0 -164
- data/lib/rubocop/cop/rails/bulk_change_table.rb +0 -289
- data/lib/rubocop/cop/rails/create_table_with_timestamps.rb +0 -91
- data/lib/rubocop/cop/rails/date.rb +0 -161
- data/lib/rubocop/cop/rails/delegate.rb +0 -132
- data/lib/rubocop/cop/rails/delegate_allow_blank.rb +0 -37
- data/lib/rubocop/cop/rails/dynamic_find_by.rb +0 -91
- data/lib/rubocop/cop/rails/enum_uniqueness.rb +0 -45
- data/lib/rubocop/cop/rails/environment_comparison.rb +0 -68
- data/lib/rubocop/cop/rails/exit.rb +0 -67
- data/lib/rubocop/cop/rails/file_path.rb +0 -108
- data/lib/rubocop/cop/rails/find_by.rb +0 -55
- data/lib/rubocop/cop/rails/find_each.rb +0 -51
- data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +0 -25
- data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb +0 -106
- data/lib/rubocop/cop/rails/http_positional_arguments.rb +0 -117
- data/lib/rubocop/cop/rails/http_status.rb +0 -179
- data/lib/rubocop/cop/rails/ignored_skip_action_filter_option.rb +0 -94
- data/lib/rubocop/cop/rails/inverse_of.rb +0 -246
- data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb +0 -175
- data/lib/rubocop/cop/rails/link_to_blank.rb +0 -98
- data/lib/rubocop/cop/rails/not_null_column.rb +0 -67
- data/lib/rubocop/cop/rails/output.rb +0 -49
- data/lib/rubocop/cop/rails/output_safety.rb +0 -99
- data/lib/rubocop/cop/rails/pluralization_grammar.rb +0 -107
- data/lib/rubocop/cop/rails/presence.rb +0 -124
- data/lib/rubocop/cop/rails/present.rb +0 -153
- data/lib/rubocop/cop/rails/read_write_attribute.rb +0 -74
- data/lib/rubocop/cop/rails/redundant_allow_nil.rb +0 -111
- data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb +0 -136
- data/lib/rubocop/cop/rails/reflection_class_name.rb +0 -37
- data/lib/rubocop/cop/rails/refute_methods.rb +0 -76
- data/lib/rubocop/cop/rails/relative_date_constant.rb +0 -93
- data/lib/rubocop/cop/rails/request_referer.rb +0 -56
- data/lib/rubocop/cop/rails/reversible_migration.rb +0 -286
- data/lib/rubocop/cop/rails/safe_navigation.rb +0 -87
- data/lib/rubocop/cop/rails/save_bang.rb +0 -316
- data/lib/rubocop/cop/rails/scope_args.rb +0 -29
- data/lib/rubocop/cop/rails/skips_model_validations.rb +0 -87
- data/lib/rubocop/cop/rails/time_zone.rb +0 -238
- data/lib/rubocop/cop/rails/uniq_before_pluck.rb +0 -105
- data/lib/rubocop/cop/rails/unknown_env.rb +0 -63
- data/lib/rubocop/cop/rails/validation.rb +0 -109
- data/lib/rubocop/rspec/shared_examples.rb +0 -59
@@ -1,45 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop looks for duplicate values in enum declarations.
|
7
|
-
#
|
8
|
-
# @example
|
9
|
-
# # bad
|
10
|
-
# enum status: { active: 0, archived: 0 }
|
11
|
-
#
|
12
|
-
# # good
|
13
|
-
# enum status: { active: 0, archived: 1 }
|
14
|
-
#
|
15
|
-
# # bad
|
16
|
-
# enum status: [:active, :archived, :active]
|
17
|
-
#
|
18
|
-
# # good
|
19
|
-
# enum status: [:active, :archived]
|
20
|
-
class EnumUniqueness < Cop
|
21
|
-
include Duplication
|
22
|
-
|
23
|
-
MSG = 'Duplicate value `%<value>s` found in `%<enum>s` ' \
|
24
|
-
'enum declaration.'
|
25
|
-
|
26
|
-
def_node_matcher :enum_declaration, <<-PATTERN
|
27
|
-
(send nil? :enum (hash (pair (_ $_) ${array hash})))
|
28
|
-
PATTERN
|
29
|
-
|
30
|
-
def on_send(node)
|
31
|
-
enum_declaration(node) do |name, args|
|
32
|
-
items = args.values
|
33
|
-
|
34
|
-
return unless duplicates?(items)
|
35
|
-
|
36
|
-
consecutive_duplicates(items).each do |item|
|
37
|
-
add_offense(item, message: format(MSG, value: item.source,
|
38
|
-
enum: name))
|
39
|
-
end
|
40
|
-
end
|
41
|
-
end
|
42
|
-
end
|
43
|
-
end
|
44
|
-
end
|
45
|
-
end
|
@@ -1,68 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop checks that Rails.env is compared using `.production?`-like
|
7
|
-
# methods instead of equality against a string or symbol.
|
8
|
-
#
|
9
|
-
# @example
|
10
|
-
# # bad
|
11
|
-
# Rails.env == 'production'
|
12
|
-
#
|
13
|
-
# # bad, always returns false
|
14
|
-
# Rails.env == :test
|
15
|
-
#
|
16
|
-
# # good
|
17
|
-
# Rails.env.production?
|
18
|
-
class EnvironmentComparison < Cop
|
19
|
-
MSG = "Favor `Rails.env.%<env>s?` over `Rails.env == '%<env>s'`."
|
20
|
-
|
21
|
-
SYM_MSG = 'Do not compare `Rails.env` with a symbol, it will always ' \
|
22
|
-
'evaluate to `false`.'
|
23
|
-
|
24
|
-
def_node_matcher :environment_str_comparison?, <<-PATTERN
|
25
|
-
(send
|
26
|
-
(send (const {nil? cbase} :Rails) :env)
|
27
|
-
:==
|
28
|
-
$str
|
29
|
-
)
|
30
|
-
PATTERN
|
31
|
-
|
32
|
-
def_node_matcher :environment_sym_comparison?, <<-PATTERN
|
33
|
-
(send
|
34
|
-
(send (const {nil? cbase} :Rails) :env)
|
35
|
-
:==
|
36
|
-
$sym
|
37
|
-
)
|
38
|
-
PATTERN
|
39
|
-
|
40
|
-
def on_send(node)
|
41
|
-
environment_str_comparison?(node) do |env_node|
|
42
|
-
env, = *env_node
|
43
|
-
add_offense(node, message: format(MSG, env: env))
|
44
|
-
end
|
45
|
-
environment_sym_comparison?(node) do |_|
|
46
|
-
add_offense(node, message: SYM_MSG)
|
47
|
-
end
|
48
|
-
end
|
49
|
-
|
50
|
-
def autocorrect(node)
|
51
|
-
lambda do |corrector|
|
52
|
-
corrector.replace(node.source_range, replacement(node))
|
53
|
-
end
|
54
|
-
end
|
55
|
-
|
56
|
-
private
|
57
|
-
|
58
|
-
def replacement(node)
|
59
|
-
"#{node.receiver.source}.#{content(node.first_argument)}?"
|
60
|
-
end
|
61
|
-
|
62
|
-
def_node_matcher :content, <<-PATTERN
|
63
|
-
({str sym} $_)
|
64
|
-
PATTERN
|
65
|
-
end
|
66
|
-
end
|
67
|
-
end
|
68
|
-
end
|
@@ -1,67 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop enforces that `exit` calls are not used within a rails app.
|
7
|
-
# Valid options are instead to raise an error, break, return, or some
|
8
|
-
# other form of stopping execution of current request.
|
9
|
-
#
|
10
|
-
# There are two obvious cases where `exit` is particularly harmful:
|
11
|
-
#
|
12
|
-
# - Usage in library code for your application. Even though Rails will
|
13
|
-
# rescue from a `SystemExit` and continue on, unit testing that library
|
14
|
-
# code will result in specs exiting (potentially silently if `exit(0)`
|
15
|
-
# is used.)
|
16
|
-
# - Usage in application code outside of the web process could result in
|
17
|
-
# the program exiting, which could result in the code failing to run and
|
18
|
-
# do its job.
|
19
|
-
#
|
20
|
-
# @example
|
21
|
-
# # bad
|
22
|
-
# exit(0)
|
23
|
-
#
|
24
|
-
# # good
|
25
|
-
# raise 'a bad error has happened'
|
26
|
-
class Exit < Cop
|
27
|
-
include ConfigurableEnforcedStyle
|
28
|
-
|
29
|
-
MSG = 'Do not use `exit` in Rails applications.'
|
30
|
-
TARGET_METHODS = %i[exit exit!].freeze
|
31
|
-
EXPLICIT_RECEIVERS = %i[Kernel Process].freeze
|
32
|
-
|
33
|
-
def on_send(node)
|
34
|
-
add_offense(node, location: :selector) if offending_node?(node)
|
35
|
-
end
|
36
|
-
|
37
|
-
private
|
38
|
-
|
39
|
-
def offending_node?(node)
|
40
|
-
right_method_name?(node.method_name) &&
|
41
|
-
right_argument_count?(node.arguments) &&
|
42
|
-
right_receiver?(node.receiver)
|
43
|
-
end
|
44
|
-
|
45
|
-
def right_method_name?(method_name)
|
46
|
-
TARGET_METHODS.include?(method_name)
|
47
|
-
end
|
48
|
-
|
49
|
-
# More than 1 argument likely means it is a different
|
50
|
-
# `exit` implementation than the one we are preventing.
|
51
|
-
def right_argument_count?(arg_nodes)
|
52
|
-
arg_nodes.size <= 1
|
53
|
-
end
|
54
|
-
|
55
|
-
# Only register if exit is being called explicitly on `Kernel`,
|
56
|
-
# `Process`, or if receiver node is nil for plain `exit` calls.
|
57
|
-
def right_receiver?(receiver_node)
|
58
|
-
return true unless receiver_node
|
59
|
-
|
60
|
-
_a, receiver_node_class, _c = *receiver_node
|
61
|
-
|
62
|
-
EXPLICIT_RECEIVERS.include?(receiver_node_class)
|
63
|
-
end
|
64
|
-
end
|
65
|
-
end
|
66
|
-
end
|
67
|
-
end
|
@@ -1,108 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop is used to identify usages of file path joining process
|
7
|
-
# to use `Rails.root.join` clause. It is used to add uniformity when
|
8
|
-
# joining paths.
|
9
|
-
#
|
10
|
-
# @example EnforcedStyle: arguments (default)
|
11
|
-
# # bad
|
12
|
-
# Rails.root.join('app/models/goober')
|
13
|
-
# File.join(Rails.root, 'app/models/goober')
|
14
|
-
# "#{Rails.root}/app/models/goober"
|
15
|
-
#
|
16
|
-
# # good
|
17
|
-
# Rails.root.join('app', 'models', 'goober')
|
18
|
-
#
|
19
|
-
# @example EnforcedStyle: slashes
|
20
|
-
# # bad
|
21
|
-
# Rails.root.join('app', 'models', 'goober')
|
22
|
-
# File.join(Rails.root, 'app/models/goober')
|
23
|
-
# "#{Rails.root}/app/models/goober"
|
24
|
-
#
|
25
|
-
# # good
|
26
|
-
# Rails.root.join('app/models/goober')
|
27
|
-
#
|
28
|
-
class FilePath < Cop
|
29
|
-
include ConfigurableEnforcedStyle
|
30
|
-
include RangeHelp
|
31
|
-
|
32
|
-
MSG_SLASHES = 'Please use `Rails.root.join(\'path/to\')` ' \
|
33
|
-
'instead.'
|
34
|
-
MSG_ARGUMENTS = 'Please use `Rails.root.join(\'path\', \'to\')` ' \
|
35
|
-
'instead.'
|
36
|
-
|
37
|
-
def_node_matcher :file_join_nodes?, <<-PATTERN
|
38
|
-
(send (const nil? :File) :join ...)
|
39
|
-
PATTERN
|
40
|
-
|
41
|
-
def_node_search :rails_root_nodes?, <<-PATTERN
|
42
|
-
(send (const nil? :Rails) :root)
|
43
|
-
PATTERN
|
44
|
-
|
45
|
-
def_node_matcher :rails_root_join_nodes?, <<-PATTERN
|
46
|
-
(send (send (const nil? :Rails) :root) :join ...)
|
47
|
-
PATTERN
|
48
|
-
|
49
|
-
def on_dstr(node)
|
50
|
-
return unless rails_root_nodes?(node)
|
51
|
-
return unless node.children.last.source.start_with?('.') ||
|
52
|
-
node.children.last.source.include?(File::SEPARATOR)
|
53
|
-
|
54
|
-
register_offense(node)
|
55
|
-
end
|
56
|
-
|
57
|
-
def on_send(node)
|
58
|
-
check_for_file_join_with_rails_root(node)
|
59
|
-
check_for_rails_root_join_with_slash_separated_path(node)
|
60
|
-
check_for_rails_root_join_with_string_arguments(node)
|
61
|
-
end
|
62
|
-
|
63
|
-
private
|
64
|
-
|
65
|
-
def check_for_file_join_with_rails_root(node)
|
66
|
-
return unless file_join_nodes?(node)
|
67
|
-
return unless node.arguments.any? { |e| rails_root_nodes?(e) }
|
68
|
-
|
69
|
-
register_offense(node)
|
70
|
-
end
|
71
|
-
|
72
|
-
def check_for_rails_root_join_with_string_arguments(node)
|
73
|
-
return unless style == :slashes
|
74
|
-
return unless rails_root_nodes?(node)
|
75
|
-
return unless rails_root_join_nodes?(node)
|
76
|
-
return unless node.arguments.size > 1
|
77
|
-
return unless node.arguments.all?(&:str_type?)
|
78
|
-
|
79
|
-
register_offense(node)
|
80
|
-
end
|
81
|
-
|
82
|
-
def check_for_rails_root_join_with_slash_separated_path(node)
|
83
|
-
return unless style == :arguments
|
84
|
-
return unless rails_root_nodes?(node)
|
85
|
-
return unless rails_root_join_nodes?(node)
|
86
|
-
return unless node.arguments.any? { |arg| string_with_slash?(arg) }
|
87
|
-
|
88
|
-
register_offense(node)
|
89
|
-
end
|
90
|
-
|
91
|
-
def string_with_slash?(node)
|
92
|
-
node.str_type? && node.source =~ %r{/}
|
93
|
-
end
|
94
|
-
|
95
|
-
def register_offense(node)
|
96
|
-
line_range = node.loc.column...node.loc.last_column
|
97
|
-
source_range = source_range(processed_source.buffer, node.first_line,
|
98
|
-
line_range)
|
99
|
-
add_offense(node, location: source_range)
|
100
|
-
end
|
101
|
-
|
102
|
-
def message(_node)
|
103
|
-
format(style == :arguments ? MSG_ARGUMENTS : MSG_SLASHES)
|
104
|
-
end
|
105
|
-
end
|
106
|
-
end
|
107
|
-
end
|
108
|
-
end
|
@@ -1,55 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop is used to identify usages of `where.first` and
|
7
|
-
# change them to use `find_by` instead.
|
8
|
-
#
|
9
|
-
# @example
|
10
|
-
# # bad
|
11
|
-
# User.where(name: 'Bruce').first
|
12
|
-
# User.where(name: 'Bruce').take
|
13
|
-
#
|
14
|
-
# # good
|
15
|
-
# User.find_by(name: 'Bruce')
|
16
|
-
class FindBy < Cop
|
17
|
-
include RangeHelp
|
18
|
-
|
19
|
-
MSG = 'Use `find_by` instead of `where.%<method>s`.'
|
20
|
-
TARGET_SELECTORS = %i[first take].freeze
|
21
|
-
|
22
|
-
def_node_matcher :where_first?, <<-PATTERN
|
23
|
-
(send ({send csend} _ :where ...) {:first :take})
|
24
|
-
PATTERN
|
25
|
-
|
26
|
-
def on_send(node)
|
27
|
-
return unless where_first?(node)
|
28
|
-
|
29
|
-
range = range_between(node.receiver.loc.selector.begin_pos,
|
30
|
-
node.loc.selector.end_pos)
|
31
|
-
|
32
|
-
add_offense(node, location: range,
|
33
|
-
message: format(MSG, method: node.method_name))
|
34
|
-
end
|
35
|
-
alias on_csend on_send
|
36
|
-
|
37
|
-
def autocorrect(node)
|
38
|
-
# Don't autocorrect where(...).first, because it can return different
|
39
|
-
# results from find_by. (They order records differently, so the
|
40
|
-
# 'first' record can be different.)
|
41
|
-
return if node.method?(:first)
|
42
|
-
|
43
|
-
where_loc = node.receiver.loc.selector
|
44
|
-
first_loc = range_between(node.loc.dot.begin_pos,
|
45
|
-
node.loc.selector.end_pos)
|
46
|
-
|
47
|
-
lambda do |corrector|
|
48
|
-
corrector.replace(where_loc, 'find_by')
|
49
|
-
corrector.replace(first_loc, '')
|
50
|
-
end
|
51
|
-
end
|
52
|
-
end
|
53
|
-
end
|
54
|
-
end
|
55
|
-
end
|
@@ -1,51 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop is used to identify usages of `all.each` and
|
7
|
-
# change them to use `all.find_each` instead.
|
8
|
-
#
|
9
|
-
# @example
|
10
|
-
# # bad
|
11
|
-
# User.all.each
|
12
|
-
#
|
13
|
-
# # good
|
14
|
-
# User.all.find_each
|
15
|
-
class FindEach < Cop
|
16
|
-
MSG = 'Use `find_each` instead of `each`.'
|
17
|
-
|
18
|
-
SCOPE_METHODS = %i[
|
19
|
-
all eager_load includes joins left_joins left_outer_joins not preload
|
20
|
-
references unscoped where
|
21
|
-
].freeze
|
22
|
-
IGNORED_METHODS = %i[order limit select].freeze
|
23
|
-
|
24
|
-
def on_send(node)
|
25
|
-
return unless node.receiver&.send_type? &&
|
26
|
-
node.method?(:each)
|
27
|
-
|
28
|
-
return unless SCOPE_METHODS.include?(node.receiver.method_name)
|
29
|
-
return if method_chain(node).any? { |m| ignored_by_find_each?(m) }
|
30
|
-
|
31
|
-
add_offense(node, location: :selector)
|
32
|
-
end
|
33
|
-
|
34
|
-
def autocorrect(node)
|
35
|
-
->(corrector) { corrector.replace(node.loc.selector, 'find_each') }
|
36
|
-
end
|
37
|
-
|
38
|
-
private
|
39
|
-
|
40
|
-
def method_chain(node)
|
41
|
-
node.each_node(:send).map(&:method_name)
|
42
|
-
end
|
43
|
-
|
44
|
-
def ignored_by_find_each?(relation_method)
|
45
|
-
# Active Record's #find_each ignores various extra parameters
|
46
|
-
IGNORED_METHODS.include?(relation_method)
|
47
|
-
end
|
48
|
-
end
|
49
|
-
end
|
50
|
-
end
|
51
|
-
end
|
@@ -1,25 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop checks for the use of the has_and_belongs_to_many macro.
|
7
|
-
#
|
8
|
-
# @example
|
9
|
-
# # bad
|
10
|
-
# # has_and_belongs_to_many :ingredients
|
11
|
-
#
|
12
|
-
# # good
|
13
|
-
# # has_many :ingredients, through: :recipe_ingredients
|
14
|
-
class HasAndBelongsToMany < Cop
|
15
|
-
MSG = 'Prefer `has_many :through` to `has_and_belongs_to_many`.'
|
16
|
-
|
17
|
-
def on_send(node)
|
18
|
-
return unless node.command?(:has_and_belongs_to_many)
|
19
|
-
|
20
|
-
add_offense(node, location: :selector)
|
21
|
-
end
|
22
|
-
end
|
23
|
-
end
|
24
|
-
end
|
25
|
-
end
|
@@ -1,106 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop looks for `has_many` or `has_one` associations that don't
|
7
|
-
# specify a `:dependent` option.
|
8
|
-
# It doesn't register an offense if `:through` option was specified.
|
9
|
-
#
|
10
|
-
# @example
|
11
|
-
# # bad
|
12
|
-
# class User < ActiveRecord::Base
|
13
|
-
# has_many :comments
|
14
|
-
# has_one :avatar
|
15
|
-
# end
|
16
|
-
#
|
17
|
-
# # good
|
18
|
-
# class User < ActiveRecord::Base
|
19
|
-
# has_many :comments, dependent: :restrict_with_exception
|
20
|
-
# has_one :avatar, dependent: :destroy
|
21
|
-
# has_many :patients, through: :appointments
|
22
|
-
# end
|
23
|
-
class HasManyOrHasOneDependent < Cop
|
24
|
-
MSG = 'Specify a `:dependent` option.'
|
25
|
-
|
26
|
-
def_node_search :active_resource_class?, <<-PATTERN
|
27
|
-
(const (const nil? :ActiveResource) :Base)
|
28
|
-
PATTERN
|
29
|
-
|
30
|
-
def_node_matcher :association_without_options?, <<-PATTERN
|
31
|
-
(send nil? {:has_many :has_one} _)
|
32
|
-
PATTERN
|
33
|
-
|
34
|
-
def_node_matcher :association_with_options?, <<-PATTERN
|
35
|
-
(send nil? {:has_many :has_one} _ (hash $...))
|
36
|
-
PATTERN
|
37
|
-
|
38
|
-
def_node_matcher :dependent_option?, <<-PATTERN
|
39
|
-
(pair (sym :dependent) !nil)
|
40
|
-
PATTERN
|
41
|
-
|
42
|
-
def_node_matcher :present_option?, <<-PATTERN
|
43
|
-
(pair (sym :through) !nil)
|
44
|
-
PATTERN
|
45
|
-
|
46
|
-
def_node_matcher :with_options_block, <<-PATTERN
|
47
|
-
(block
|
48
|
-
(send nil? :with_options
|
49
|
-
(hash $...))
|
50
|
-
(args) ...)
|
51
|
-
PATTERN
|
52
|
-
|
53
|
-
def on_send(node)
|
54
|
-
return if active_resource?(node.parent)
|
55
|
-
|
56
|
-
unless association_without_options?(node)
|
57
|
-
return if valid_options?(association_with_options?(node))
|
58
|
-
end
|
59
|
-
|
60
|
-
return if valid_options_in_with_options_block?(node)
|
61
|
-
|
62
|
-
add_offense(node, location: :selector)
|
63
|
-
end
|
64
|
-
|
65
|
-
private
|
66
|
-
|
67
|
-
def valid_options_in_with_options_block?(node)
|
68
|
-
return true unless node.parent
|
69
|
-
|
70
|
-
n = node.parent.begin_type? ? node.parent.parent : node.parent
|
71
|
-
|
72
|
-
contain_valid_options_in_with_options_block?(n)
|
73
|
-
end
|
74
|
-
|
75
|
-
def contain_valid_options_in_with_options_block?(node)
|
76
|
-
if with_options_block(node)
|
77
|
-
return true if valid_options?(with_options_block(node))
|
78
|
-
|
79
|
-
return false unless node.parent
|
80
|
-
|
81
|
-
return true if contain_valid_options_in_with_options_block?(
|
82
|
-
node.parent.parent
|
83
|
-
)
|
84
|
-
end
|
85
|
-
|
86
|
-
false
|
87
|
-
end
|
88
|
-
|
89
|
-
def valid_options?(options)
|
90
|
-
return true unless options
|
91
|
-
return true if options.any? do |o|
|
92
|
-
dependent_option?(o) || present_option?(o)
|
93
|
-
end
|
94
|
-
|
95
|
-
false
|
96
|
-
end
|
97
|
-
|
98
|
-
def active_resource?(node)
|
99
|
-
return false if node.nil?
|
100
|
-
|
101
|
-
active_resource_class?(node)
|
102
|
-
end
|
103
|
-
end
|
104
|
-
end
|
105
|
-
end
|
106
|
-
end
|