rubocop 0.71.0 → 0.75.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/README.md +5 -8
- data/bin/console +1 -0
- data/config/default.yml +84 -488
- data/lib/rubocop.rb +16 -54
- data/lib/rubocop/ast/builder.rb +2 -0
- data/lib/rubocop/ast/node.rb +9 -15
- data/lib/rubocop/ast/node/float_node.rb +12 -0
- data/lib/rubocop/ast/node/int_node.rb +12 -0
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +4 -4
- data/lib/rubocop/ast/node/mixin/numeric_node.rb +21 -0
- data/lib/rubocop/ast/node/resbody_node.rb +1 -6
- data/lib/rubocop/ast/traversal.rb +3 -3
- data/lib/rubocop/cached_data.rb +1 -1
- data/lib/rubocop/comment_config.rb +3 -2
- data/lib/rubocop/config.rb +21 -508
- data/lib/rubocop/config_loader.rb +22 -8
- data/lib/rubocop/config_loader_resolver.rb +2 -16
- data/lib/rubocop/config_obsoletion.rb +213 -0
- data/lib/rubocop/config_validator.rb +239 -0
- data/lib/rubocop/cop/autocorrect_logic.rb +71 -1
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +1 -1
- data/lib/rubocop/cop/bundler/ordered_gems.rb +1 -1
- data/lib/rubocop/cop/commissioner.rb +3 -9
- data/lib/rubocop/cop/cop.rb +39 -12
- data/lib/rubocop/cop/corrector.rb +2 -3
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +43 -17
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +2 -2
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +2 -2
- data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +1 -1
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +2 -2
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +1 -1
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +1 -1
- data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +55 -0
- data/lib/rubocop/cop/generator.rb +4 -4
- data/lib/rubocop/cop/generator/configuration_injector.rb +9 -4
- data/lib/rubocop/cop/generator/require_file_injector.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +2 -2
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +2 -2
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +1 -1
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +2 -2
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +2 -2
- data/lib/rubocop/cop/layout/block_alignment.rb +3 -3
- data/lib/rubocop/cop/layout/class_structure.rb +2 -2
- data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +1 -1
- data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +22 -7
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +2 -2
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +2 -2
- data/lib/rubocop/cop/layout/extra_spacing.rb +14 -59
- data/lib/rubocop/cop/layout/indent_assignment.rb +10 -1
- data/lib/rubocop/cop/layout/indent_first_argument.rb +7 -3
- data/lib/rubocop/cop/layout/indent_first_parameter.rb +7 -3
- data/lib/rubocop/cop/layout/indent_heredoc.rb +4 -4
- data/lib/rubocop/cop/layout/indentation_consistency.rb +13 -12
- data/lib/rubocop/cop/layout/indentation_width.rb +28 -10
- data/lib/rubocop/cop/layout/leading_comment_space.rb +28 -0
- data/lib/rubocop/cop/layout/multiline_block_layout.rb +24 -2
- data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +18 -4
- data/lib/rubocop/cop/layout/space_around_block_parameters.rb +5 -1
- data/lib/rubocop/cop/layout/space_around_operators.rb +42 -23
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +1 -1
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +21 -2
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +24 -40
- data/lib/rubocop/cop/layout/tab.rb +10 -22
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +17 -4
- data/lib/rubocop/cop/lint/big_decimal_new.rb +1 -1
- data/lib/rubocop/cop/lint/debugger.rb +4 -6
- data/lib/rubocop/cop/lint/duplicate_methods.rb +3 -3
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +1 -1
- data/lib/rubocop/cop/lint/empty_interpolation.rb +4 -4
- data/lib/rubocop/cop/lint/erb_new_arguments.rb +57 -1
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +11 -37
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +1 -1
- data/lib/rubocop/cop/lint/inherit_exception.rb +1 -1
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +7 -8
- data/lib/rubocop/cop/lint/multiple_compare.rb +1 -1
- data/lib/rubocop/cop/lint/nested_method_definition.rb +3 -3
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +1 -1
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +1 -1
- data/lib/rubocop/cop/lint/number_conversion.rb +4 -4
- data/lib/rubocop/cop/lint/rand_one.rb +1 -1
- data/lib/rubocop/cop/lint/redundant_with_index.rb +1 -1
- data/lib/rubocop/cop/lint/redundant_with_object.rb +1 -1
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +5 -5
- data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +1 -1
- data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +91 -0
- data/lib/rubocop/cop/lint/string_conversion_in_interpolation.rb +6 -6
- data/lib/rubocop/cop/lint/unified_integer.rb +1 -1
- data/lib/rubocop/cop/lint/unneeded_cop_disable_directive.rb +1 -1
- data/lib/rubocop/cop/lint/unneeded_require_statement.rb +1 -1
- data/lib/rubocop/cop/lint/unneeded_splat_expansion.rb +7 -2
- data/lib/rubocop/cop/lint/unreachable_code.rb +1 -1
- data/lib/rubocop/cop/lint/unused_block_argument.rb +22 -6
- data/lib/rubocop/cop/lint/unused_method_argument.rb +23 -5
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +1 -1
- data/lib/rubocop/cop/lint/uri_regexp.rb +2 -2
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +6 -6
- data/lib/rubocop/cop/lint/useless_setter_call.rb +1 -1
- data/lib/rubocop/cop/lint/void.rb +3 -22
- data/lib/rubocop/cop/message_annotator.rb +16 -7
- data/lib/rubocop/cop/metrics/class_length.rb +1 -1
- data/lib/rubocop/cop/metrics/line_length.rb +6 -0
- data/lib/rubocop/cop/metrics/module_length.rb +1 -1
- data/lib/rubocop/cop/metrics/parameter_lists.rb +1 -1
- data/lib/rubocop/cop/migration/department_name.rb +44 -0
- data/lib/rubocop/cop/mixin/alignment.rb +1 -1
- data/lib/rubocop/cop/mixin/def_node.rb +1 -1
- data/lib/rubocop/cop/mixin/documentation_comment.rb +0 -2
- data/lib/rubocop/cop/mixin/empty_parameter.rb +1 -1
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +4 -4
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +1 -1
- data/lib/rubocop/cop/mixin/interpolation.rb +27 -0
- data/lib/rubocop/cop/mixin/method_complexity.rb +1 -1
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +3 -3
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +87 -0
- data/lib/rubocop/cop/mixin/safe_mode.rb +2 -0
- data/lib/rubocop/cop/mixin/surrounding_space.rb +7 -5
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +1 -1
- data/lib/rubocop/cop/naming/constant_name.rb +2 -2
- data/lib/rubocop/cop/naming/method_name.rb +12 -1
- data/lib/rubocop/cop/naming/predicate_name.rb +1 -1
- data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +21 -20
- data/lib/rubocop/cop/naming/variable_name.rb +1 -0
- data/lib/rubocop/cop/offense.rb +18 -7
- data/lib/rubocop/cop/registry.rb +22 -1
- data/lib/rubocop/cop/security/eval.rb +1 -1
- data/lib/rubocop/cop/security/json_load.rb +1 -1
- data/lib/rubocop/cop/security/marshal_load.rb +1 -1
- data/lib/rubocop/cop/security/open.rb +1 -1
- data/lib/rubocop/cop/security/yaml_load.rb +1 -1
- data/lib/rubocop/cop/style/access_modifier_declarations.rb +1 -0
- data/lib/rubocop/cop/style/alias.rb +1 -1
- data/lib/rubocop/cop/style/block_delimiters.rb +2 -1
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +29 -10
- data/lib/rubocop/cop/style/class_and_module_children.rb +1 -1
- data/lib/rubocop/cop/style/colon_method_call.rb +1 -1
- data/lib/rubocop/cop/style/commented_keyword.rb +16 -30
- data/lib/rubocop/cop/style/conditional_assignment.rb +8 -9
- data/lib/rubocop/cop/style/constant_visibility.rb +14 -3
- data/lib/rubocop/cop/style/date_time.rb +3 -3
- data/lib/rubocop/cop/style/dir.rb +1 -1
- data/lib/rubocop/cop/style/documentation_method.rb +45 -1
- data/lib/rubocop/cop/style/double_cop_disable_directive.rb +55 -0
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +1 -1
- data/lib/rubocop/cop/style/each_with_object.rb +1 -1
- data/lib/rubocop/cop/style/eval_with_location.rb +2 -2
- data/lib/rubocop/cop/style/even_odd.rb +1 -1
- data/lib/rubocop/cop/style/expand_path_arguments.rb +4 -4
- data/lib/rubocop/cop/style/float_division.rb +94 -0
- data/lib/rubocop/cop/style/format_string.rb +13 -9
- data/lib/rubocop/cop/style/format_string_token.rb +18 -69
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +18 -33
- data/lib/rubocop/cop/style/guard_clause.rb +39 -10
- data/lib/rubocop/cop/style/hash_syntax.rb +2 -2
- data/lib/rubocop/cop/style/if_inside_else.rb +42 -0
- data/lib/rubocop/cop/style/if_unless_modifier.rb +51 -15
- data/lib/rubocop/cop/style/infinite_loop.rb +1 -1
- data/lib/rubocop/cop/style/inverse_methods.rb +2 -2
- data/lib/rubocop/cop/style/lambda.rb +0 -2
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +32 -26
- data/lib/rubocop/cop/style/min_max.rb +1 -1
- data/lib/rubocop/cop/style/mixin_usage.rb +12 -2
- data/lib/rubocop/cop/style/multiline_memoization.rb +1 -1
- data/lib/rubocop/cop/style/multiline_when_then.rb +55 -0
- data/lib/rubocop/cop/style/multiple_comparison.rb +1 -1
- data/lib/rubocop/cop/style/mutable_constant.rb +3 -3
- data/lib/rubocop/cop/style/nested_modifier.rb +18 -2
- data/lib/rubocop/cop/style/numeric_predicate.rb +3 -3
- data/lib/rubocop/cop/style/option_hash.rb +1 -1
- data/lib/rubocop/cop/style/or_assignment.rb +8 -3
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +15 -1
- data/lib/rubocop/cop/style/random_with_offset.rb +6 -6
- data/lib/rubocop/cop/style/redundant_conditional.rb +2 -2
- data/lib/rubocop/cop/style/redundant_exception.rb +2 -2
- data/lib/rubocop/cop/style/redundant_freeze.rb +1 -1
- data/lib/rubocop/cop/style/redundant_parentheses.rb +15 -6
- data/lib/rubocop/cop/style/redundant_return.rb +12 -0
- data/lib/rubocop/cop/style/redundant_self.rb +18 -1
- data/lib/rubocop/cop/style/redundant_sort_by.rb +1 -1
- data/lib/rubocop/cop/style/rescue_modifier.rb +24 -0
- data/lib/rubocop/cop/style/rescue_standard_error.rb +2 -2
- data/lib/rubocop/cop/style/return_nil.rb +1 -1
- data/lib/rubocop/cop/style/safe_navigation.rb +19 -2
- data/lib/rubocop/cop/style/sample.rb +1 -1
- data/lib/rubocop/cop/style/semicolon.rb +11 -0
- data/lib/rubocop/cop/style/single_line_methods.rb +8 -1
- data/lib/rubocop/cop/style/stderr_puts.rb +1 -1
- data/lib/rubocop/cop/style/string_hash_keys.rb +2 -2
- data/lib/rubocop/cop/style/strip.rb +1 -1
- data/lib/rubocop/cop/style/struct_inheritance.rb +3 -3
- data/lib/rubocop/cop/style/symbol_proc.rb +1 -1
- data/lib/rubocop/cop/style/ternary_parentheses.rb +32 -3
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +4 -6
- data/lib/rubocop/cop/style/trivial_accessors.rb +1 -1
- data/lib/rubocop/cop/style/unneeded_sort.rb +1 -1
- data/lib/rubocop/cop/style/unpack_first.rb +1 -1
- data/lib/rubocop/cop/style/variable_interpolation.rb +6 -16
- data/lib/rubocop/cop/style/word_array.rb +2 -2
- data/lib/rubocop/cop/style/zero_length_predicate.rb +6 -6
- data/lib/rubocop/cop/team.rb +15 -14
- data/lib/rubocop/cop/utils/format_string.rb +128 -0
- data/lib/rubocop/cop/variable_force/variable.rb +15 -2
- data/lib/rubocop/core_ext/string.rb +0 -24
- data/lib/rubocop/error.rb +23 -0
- data/lib/rubocop/formatter/clang_style_formatter.rb +8 -3
- data/lib/rubocop/formatter/emacs_style_formatter.rb +22 -9
- data/lib/rubocop/formatter/file_list_formatter.rb +1 -1
- data/lib/rubocop/formatter/formatter_set.rb +16 -15
- data/lib/rubocop/formatter/pacman_formatter.rb +80 -0
- data/lib/rubocop/formatter/simple_text_formatter.rb +16 -4
- data/lib/rubocop/formatter/tap_formatter.rb +17 -4
- data/lib/rubocop/magic_comment.rb +4 -0
- data/lib/rubocop/node_pattern.rb +2 -2
- data/lib/rubocop/options.rb +21 -17
- data/lib/rubocop/path_util.rb +1 -1
- data/lib/rubocop/processed_source.rb +6 -1
- data/lib/rubocop/rspec/cop_helper.rb +0 -1
- data/lib/rubocop/rspec/expect_offense.rb +4 -1
- data/lib/rubocop/rspec/shared_contexts.rb +12 -17
- data/lib/rubocop/rspec/support.rb +0 -1
- data/lib/rubocop/runner.rb +14 -25
- data/lib/rubocop/target_finder.rb +6 -4
- data/lib/rubocop/version.rb +1 -1
- data/lib/rubocop/yaml_duplication_checker.rb +8 -2
- metadata +17 -92
- data/lib/rubocop/cop/mixin/ignored_method_patterns.rb +0 -19
- data/lib/rubocop/cop/mixin/target_rails_version.rb +0 -16
- data/lib/rubocop/cop/rails/action_filter.rb +0 -117
- data/lib/rubocop/cop/rails/active_record_aliases.rb +0 -48
- data/lib/rubocop/cop/rails/active_record_override.rb +0 -82
- data/lib/rubocop/cop/rails/active_support_aliases.rb +0 -69
- data/lib/rubocop/cop/rails/application_job.rb +0 -40
- data/lib/rubocop/cop/rails/application_record.rb +0 -40
- data/lib/rubocop/cop/rails/assert_not.rb +0 -44
- data/lib/rubocop/cop/rails/belongs_to.rb +0 -102
- data/lib/rubocop/cop/rails/blank.rb +0 -164
- data/lib/rubocop/cop/rails/bulk_change_table.rb +0 -289
- data/lib/rubocop/cop/rails/create_table_with_timestamps.rb +0 -91
- data/lib/rubocop/cop/rails/date.rb +0 -161
- data/lib/rubocop/cop/rails/delegate.rb +0 -132
- data/lib/rubocop/cop/rails/delegate_allow_blank.rb +0 -37
- data/lib/rubocop/cop/rails/dynamic_find_by.rb +0 -91
- data/lib/rubocop/cop/rails/enum_uniqueness.rb +0 -45
- data/lib/rubocop/cop/rails/environment_comparison.rb +0 -68
- data/lib/rubocop/cop/rails/exit.rb +0 -67
- data/lib/rubocop/cop/rails/file_path.rb +0 -108
- data/lib/rubocop/cop/rails/find_by.rb +0 -55
- data/lib/rubocop/cop/rails/find_each.rb +0 -51
- data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +0 -25
- data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb +0 -106
- data/lib/rubocop/cop/rails/http_positional_arguments.rb +0 -117
- data/lib/rubocop/cop/rails/http_status.rb +0 -179
- data/lib/rubocop/cop/rails/ignored_skip_action_filter_option.rb +0 -94
- data/lib/rubocop/cop/rails/inverse_of.rb +0 -246
- data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb +0 -175
- data/lib/rubocop/cop/rails/link_to_blank.rb +0 -98
- data/lib/rubocop/cop/rails/not_null_column.rb +0 -67
- data/lib/rubocop/cop/rails/output.rb +0 -49
- data/lib/rubocop/cop/rails/output_safety.rb +0 -99
- data/lib/rubocop/cop/rails/pluralization_grammar.rb +0 -107
- data/lib/rubocop/cop/rails/presence.rb +0 -124
- data/lib/rubocop/cop/rails/present.rb +0 -153
- data/lib/rubocop/cop/rails/read_write_attribute.rb +0 -74
- data/lib/rubocop/cop/rails/redundant_allow_nil.rb +0 -111
- data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb +0 -136
- data/lib/rubocop/cop/rails/reflection_class_name.rb +0 -37
- data/lib/rubocop/cop/rails/refute_methods.rb +0 -76
- data/lib/rubocop/cop/rails/relative_date_constant.rb +0 -93
- data/lib/rubocop/cop/rails/request_referer.rb +0 -56
- data/lib/rubocop/cop/rails/reversible_migration.rb +0 -286
- data/lib/rubocop/cop/rails/safe_navigation.rb +0 -87
- data/lib/rubocop/cop/rails/save_bang.rb +0 -316
- data/lib/rubocop/cop/rails/scope_args.rb +0 -29
- data/lib/rubocop/cop/rails/skips_model_validations.rb +0 -87
- data/lib/rubocop/cop/rails/time_zone.rb +0 -238
- data/lib/rubocop/cop/rails/uniq_before_pluck.rb +0 -105
- data/lib/rubocop/cop/rails/unknown_env.rb +0 -63
- data/lib/rubocop/cop/rails/validation.rb +0 -109
- data/lib/rubocop/rspec/shared_examples.rb +0 -59
@@ -1,19 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
# This module encapsulates the ability to ignore certain methods when
|
6
|
-
# parsing using regex patterns.
|
7
|
-
module IgnoredMethodPatterns
|
8
|
-
private
|
9
|
-
|
10
|
-
def ignored_method_pattern?(name)
|
11
|
-
ignored_method_patterns.any? { |pattern| Regexp.new(pattern) =~ name }
|
12
|
-
end
|
13
|
-
|
14
|
-
def ignored_method_patterns
|
15
|
-
cop_config.fetch('IgnoredMethodPatterns', [])
|
16
|
-
end
|
17
|
-
end
|
18
|
-
end
|
19
|
-
end
|
@@ -1,16 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
# Common functionality for checking target rails version.
|
6
|
-
module TargetRailsVersion
|
7
|
-
def minimum_target_rails_version(version)
|
8
|
-
@minimum_target_rails_version = version
|
9
|
-
end
|
10
|
-
|
11
|
-
def support_target_rails_version?(version)
|
12
|
-
@minimum_target_rails_version <= version
|
13
|
-
end
|
14
|
-
end
|
15
|
-
end
|
16
|
-
end
|
@@ -1,117 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop enforces the consistent use of action filter methods.
|
7
|
-
#
|
8
|
-
# The cop is configurable and can enforce the use of the older
|
9
|
-
# something_filter methods or the newer something_action methods.
|
10
|
-
#
|
11
|
-
# If the TargetRailsVersion is set to less than 4.0, the cop will enforce
|
12
|
-
# the use of filter methods.
|
13
|
-
#
|
14
|
-
# @example EnforcedStyle: action (default)
|
15
|
-
# # bad
|
16
|
-
# after_filter :do_stuff
|
17
|
-
# append_around_filter :do_stuff
|
18
|
-
# skip_after_filter :do_stuff
|
19
|
-
#
|
20
|
-
# # good
|
21
|
-
# after_action :do_stuff
|
22
|
-
# append_around_action :do_stuff
|
23
|
-
# skip_after_action :do_stuff
|
24
|
-
#
|
25
|
-
# @example EnforcedStyle: filter
|
26
|
-
# # bad
|
27
|
-
# after_action :do_stuff
|
28
|
-
# append_around_action :do_stuff
|
29
|
-
# skip_after_action :do_stuff
|
30
|
-
#
|
31
|
-
# # good
|
32
|
-
# after_filter :do_stuff
|
33
|
-
# append_around_filter :do_stuff
|
34
|
-
# skip_after_filter :do_stuff
|
35
|
-
class ActionFilter < Cop
|
36
|
-
extend TargetRailsVersion
|
37
|
-
include ConfigurableEnforcedStyle
|
38
|
-
|
39
|
-
MSG = 'Prefer `%<prefer>s` over `%<current>s`.'
|
40
|
-
|
41
|
-
FILTER_METHODS = %i[
|
42
|
-
after_filter
|
43
|
-
append_after_filter
|
44
|
-
append_around_filter
|
45
|
-
append_before_filter
|
46
|
-
around_filter
|
47
|
-
before_filter
|
48
|
-
prepend_after_filter
|
49
|
-
prepend_around_filter
|
50
|
-
prepend_before_filter
|
51
|
-
skip_after_filter
|
52
|
-
skip_around_filter
|
53
|
-
skip_before_filter
|
54
|
-
skip_filter
|
55
|
-
].freeze
|
56
|
-
|
57
|
-
ACTION_METHODS = %i[
|
58
|
-
after_action
|
59
|
-
append_after_action
|
60
|
-
append_around_action
|
61
|
-
append_before_action
|
62
|
-
around_action
|
63
|
-
before_action
|
64
|
-
prepend_after_action
|
65
|
-
prepend_around_action
|
66
|
-
prepend_before_action
|
67
|
-
skip_after_action
|
68
|
-
skip_around_action
|
69
|
-
skip_before_action
|
70
|
-
skip_action_callback
|
71
|
-
].freeze
|
72
|
-
|
73
|
-
minimum_target_rails_version 4.0
|
74
|
-
|
75
|
-
def on_block(node)
|
76
|
-
check_method_node(node.send_node)
|
77
|
-
end
|
78
|
-
|
79
|
-
def on_send(node)
|
80
|
-
check_method_node(node) unless node.receiver
|
81
|
-
end
|
82
|
-
|
83
|
-
def autocorrect(node)
|
84
|
-
lambda do |corrector|
|
85
|
-
corrector.replace(node.loc.selector,
|
86
|
-
preferred_method(node.loc.selector.source).to_s)
|
87
|
-
end
|
88
|
-
end
|
89
|
-
|
90
|
-
private
|
91
|
-
|
92
|
-
def check_method_node(node)
|
93
|
-
return unless bad_methods.include?(node.method_name)
|
94
|
-
|
95
|
-
add_offense(node, location: :selector)
|
96
|
-
end
|
97
|
-
|
98
|
-
def message(node)
|
99
|
-
format(MSG, prefer: preferred_method(node.method_name),
|
100
|
-
current: node.method_name)
|
101
|
-
end
|
102
|
-
|
103
|
-
def bad_methods
|
104
|
-
style == :action ? FILTER_METHODS : ACTION_METHODS
|
105
|
-
end
|
106
|
-
|
107
|
-
def good_methods
|
108
|
-
style == :action ? ACTION_METHODS : FILTER_METHODS
|
109
|
-
end
|
110
|
-
|
111
|
-
def preferred_method(method)
|
112
|
-
good_methods[bad_methods.index(method.to_sym)]
|
113
|
-
end
|
114
|
-
end
|
115
|
-
end
|
116
|
-
end
|
117
|
-
end
|
@@ -1,48 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# Checks that ActiveRecord aliases are not used. The direct method names
|
7
|
-
# are more clear and easier to read.
|
8
|
-
#
|
9
|
-
# @example
|
10
|
-
# #bad
|
11
|
-
# Book.update_attributes!(author: 'Alice')
|
12
|
-
#
|
13
|
-
# #good
|
14
|
-
# Book.update!(author: 'Alice')
|
15
|
-
class ActiveRecordAliases < Cop
|
16
|
-
MSG = 'Use `%<prefer>s` instead of `%<current>s`.'
|
17
|
-
|
18
|
-
ALIASES = {
|
19
|
-
update_attributes: :update,
|
20
|
-
update_attributes!: :update!
|
21
|
-
}.freeze
|
22
|
-
|
23
|
-
def on_send(node)
|
24
|
-
ALIASES.each do |bad, good|
|
25
|
-
next unless node.method?(bad)
|
26
|
-
|
27
|
-
add_offense(node,
|
28
|
-
message: format(MSG, prefer: good, current: bad),
|
29
|
-
location: :selector,
|
30
|
-
severity: :warning)
|
31
|
-
break
|
32
|
-
end
|
33
|
-
end
|
34
|
-
|
35
|
-
alias on_csend on_send
|
36
|
-
|
37
|
-
def autocorrect(node)
|
38
|
-
lambda do |corrector|
|
39
|
-
corrector.replace(
|
40
|
-
node.loc.selector,
|
41
|
-
ALIASES[node.method_name].to_s
|
42
|
-
)
|
43
|
-
end
|
44
|
-
end
|
45
|
-
end
|
46
|
-
end
|
47
|
-
end
|
48
|
-
end
|
@@ -1,82 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# Checks for overriding built-in Active Record methods instead of using
|
7
|
-
# callbacks.
|
8
|
-
#
|
9
|
-
# @example
|
10
|
-
# # bad
|
11
|
-
# class Book < ApplicationRecord
|
12
|
-
# def save
|
13
|
-
# self.title = title.upcase!
|
14
|
-
# super
|
15
|
-
# end
|
16
|
-
# end
|
17
|
-
#
|
18
|
-
# # good
|
19
|
-
# class Book < ApplicationRecord
|
20
|
-
# before_save :upcase_title
|
21
|
-
#
|
22
|
-
# def upcase_title
|
23
|
-
# self.title = title.upcase!
|
24
|
-
# end
|
25
|
-
# end
|
26
|
-
#
|
27
|
-
class ActiveRecordOverride < Cop
|
28
|
-
MSG =
|
29
|
-
'Use %<prefer>s callbacks instead of overriding the Active Record ' \
|
30
|
-
'method `%<bad>s`.'
|
31
|
-
BAD_METHODS = %i[create destroy save update].freeze
|
32
|
-
ACTIVE_RECORD_CLASSES = %w[ApplicationRecord ActiveModel::Base
|
33
|
-
ActiveRecord::Base].freeze
|
34
|
-
|
35
|
-
def on_def(node)
|
36
|
-
return unless BAD_METHODS.include?(node.method_name)
|
37
|
-
|
38
|
-
parent_class_name = find_parent_class_name(node)
|
39
|
-
return unless active_model?(parent_class_name)
|
40
|
-
|
41
|
-
return unless node.descendants.any?(&:zsuper_type?)
|
42
|
-
|
43
|
-
add_offense(node, message: message(node.method_name))
|
44
|
-
end
|
45
|
-
|
46
|
-
private
|
47
|
-
|
48
|
-
def active_model?(parent_class_name)
|
49
|
-
ACTIVE_RECORD_CLASSES.include?(parent_class_name)
|
50
|
-
end
|
51
|
-
|
52
|
-
def callback_names(method_name)
|
53
|
-
names = %w[before_ around_ after_].map do |prefix|
|
54
|
-
"`#{prefix}#{method_name}`"
|
55
|
-
end
|
56
|
-
|
57
|
-
names[-1] = "or #{names.last}"
|
58
|
-
|
59
|
-
names.join(', ')
|
60
|
-
end
|
61
|
-
|
62
|
-
def message(method_name)
|
63
|
-
format(MSG, prefer: callback_names(method_name), bad: method_name)
|
64
|
-
end
|
65
|
-
|
66
|
-
def find_parent_class_name(node)
|
67
|
-
return nil unless node
|
68
|
-
|
69
|
-
if node.class_type?
|
70
|
-
parent_class_name = node.node_parts[1]
|
71
|
-
|
72
|
-
return nil if parent_class_name.nil?
|
73
|
-
|
74
|
-
return parent_class_name.source
|
75
|
-
end
|
76
|
-
|
77
|
-
find_parent_class_name(node.parent)
|
78
|
-
end
|
79
|
-
end
|
80
|
-
end
|
81
|
-
end
|
82
|
-
end
|
@@ -1,69 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop checks that ActiveSupport aliases to core ruby methods
|
7
|
-
# are not used.
|
8
|
-
#
|
9
|
-
# @example
|
10
|
-
# # good
|
11
|
-
# 'some_string'.start_with?('prefix')
|
12
|
-
# 'some_string'.end_with?('suffix')
|
13
|
-
# [1, 2, 'a'] << 'b'
|
14
|
-
# [1, 2, 'a'].unshift('b')
|
15
|
-
#
|
16
|
-
# # bad
|
17
|
-
# 'some_string'.starts_with?('prefix')
|
18
|
-
# 'some_string'.ends_with?('suffix')
|
19
|
-
# [1, 2, 'a'].append('b')
|
20
|
-
# [1, 2, 'a'].prepend('b')
|
21
|
-
#
|
22
|
-
class ActiveSupportAliases < Cop
|
23
|
-
MSG = 'Use `%<prefer>s` instead of `%<current>s`.'
|
24
|
-
|
25
|
-
ALIASES = {
|
26
|
-
starts_with?: {
|
27
|
-
original: :start_with?, matcher: '(send str :starts_with? _)'
|
28
|
-
},
|
29
|
-
ends_with?: {
|
30
|
-
original: :end_with?, matcher: '(send str :ends_with? _)'
|
31
|
-
},
|
32
|
-
append: { original: :<<, matcher: '(send array :append _)' },
|
33
|
-
prepend: { original: :unshift, matcher: '(send array :prepend _)' }
|
34
|
-
}.freeze
|
35
|
-
|
36
|
-
ALIASES.each do |aliased_method, options|
|
37
|
-
def_node_matcher aliased_method, options[:matcher]
|
38
|
-
end
|
39
|
-
|
40
|
-
def on_send(node)
|
41
|
-
ALIASES.each_key do |aliased_method|
|
42
|
-
register_offense(node, aliased_method) if
|
43
|
-
public_send(aliased_method, node)
|
44
|
-
end
|
45
|
-
end
|
46
|
-
|
47
|
-
def autocorrect(node)
|
48
|
-
return false if append(node)
|
49
|
-
|
50
|
-
lambda do |corrector|
|
51
|
-
method_name = node.loc.selector.source
|
52
|
-
replacement = ALIASES[method_name.to_sym][:original]
|
53
|
-
corrector.replace(node.loc.selector, replacement.to_s)
|
54
|
-
end
|
55
|
-
end
|
56
|
-
|
57
|
-
private
|
58
|
-
|
59
|
-
def register_offense(node, method_name)
|
60
|
-
add_offense(
|
61
|
-
node,
|
62
|
-
message: format(MSG, prefer: ALIASES[method_name][:original],
|
63
|
-
current: method_name)
|
64
|
-
)
|
65
|
-
end
|
66
|
-
end
|
67
|
-
end
|
68
|
-
end
|
69
|
-
end
|
@@ -1,40 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop checks that jobs subclass ApplicationJob with Rails 5.0.
|
7
|
-
#
|
8
|
-
# @example
|
9
|
-
#
|
10
|
-
# # good
|
11
|
-
# class Rails5Job < ApplicationJob
|
12
|
-
# # ...
|
13
|
-
# end
|
14
|
-
#
|
15
|
-
# # bad
|
16
|
-
# class Rails4Job < ActiveJob::Base
|
17
|
-
# # ...
|
18
|
-
# end
|
19
|
-
class ApplicationJob < Cop
|
20
|
-
extend TargetRailsVersion
|
21
|
-
|
22
|
-
minimum_target_rails_version 5.0
|
23
|
-
|
24
|
-
MSG = 'Jobs should subclass `ApplicationJob`.'
|
25
|
-
SUPERCLASS = 'ApplicationJob'
|
26
|
-
BASE_PATTERN = '(const (const nil? :ActiveJob) :Base)'
|
27
|
-
|
28
|
-
# rubocop:disable Layout/ClassStructure
|
29
|
-
include RuboCop::Cop::EnforceSuperclass
|
30
|
-
# rubocop:enable Layout/ClassStructure
|
31
|
-
|
32
|
-
def autocorrect(node)
|
33
|
-
lambda do |corrector|
|
34
|
-
corrector.replace(node.source_range, self.class::SUPERCLASS)
|
35
|
-
end
|
36
|
-
end
|
37
|
-
end
|
38
|
-
end
|
39
|
-
end
|
40
|
-
end
|
@@ -1,40 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
# This cop checks that models subclass ApplicationRecord with Rails 5.0.
|
7
|
-
#
|
8
|
-
# @example
|
9
|
-
#
|
10
|
-
# # good
|
11
|
-
# class Rails5Model < ApplicationRecord
|
12
|
-
# # ...
|
13
|
-
# end
|
14
|
-
#
|
15
|
-
# # bad
|
16
|
-
# class Rails4Model < ActiveRecord::Base
|
17
|
-
# # ...
|
18
|
-
# end
|
19
|
-
class ApplicationRecord < Cop
|
20
|
-
extend TargetRailsVersion
|
21
|
-
|
22
|
-
minimum_target_rails_version 5.0
|
23
|
-
|
24
|
-
MSG = 'Models should subclass `ApplicationRecord`.'
|
25
|
-
SUPERCLASS = 'ApplicationRecord'
|
26
|
-
BASE_PATTERN = '(const (const nil? :ActiveRecord) :Base)'
|
27
|
-
|
28
|
-
# rubocop:disable Layout/ClassStructure
|
29
|
-
include RuboCop::Cop::EnforceSuperclass
|
30
|
-
# rubocop:enable Layout/ClassStructure
|
31
|
-
|
32
|
-
def autocorrect(node)
|
33
|
-
lambda do |corrector|
|
34
|
-
corrector.replace(node.source_range, self.class::SUPERCLASS)
|
35
|
-
end
|
36
|
-
end
|
37
|
-
end
|
38
|
-
end
|
39
|
-
end
|
40
|
-
end
|
@@ -1,44 +0,0 @@
|
|
1
|
-
# frozen_string_literal: true
|
2
|
-
|
3
|
-
module RuboCop
|
4
|
-
module Cop
|
5
|
-
module Rails
|
6
|
-
#
|
7
|
-
# Use `assert_not` instead of `assert !`.
|
8
|
-
#
|
9
|
-
# @example
|
10
|
-
# # bad
|
11
|
-
# assert !x
|
12
|
-
#
|
13
|
-
# # good
|
14
|
-
# assert_not x
|
15
|
-
#
|
16
|
-
class AssertNot < RuboCop::Cop::Cop
|
17
|
-
MSG = 'Prefer `assert_not` over `assert !`.'
|
18
|
-
|
19
|
-
def_node_matcher :offensive?, '(send nil? :assert (send ... :!) ...)'
|
20
|
-
|
21
|
-
def on_send(node)
|
22
|
-
add_offense(node) if offensive?(node)
|
23
|
-
end
|
24
|
-
|
25
|
-
def autocorrect(node)
|
26
|
-
expression = node.loc.expression
|
27
|
-
|
28
|
-
lambda do |corrector|
|
29
|
-
corrector.replace(
|
30
|
-
expression,
|
31
|
-
corrected_source(expression.source)
|
32
|
-
)
|
33
|
-
end
|
34
|
-
end
|
35
|
-
|
36
|
-
private
|
37
|
-
|
38
|
-
def corrected_source(source)
|
39
|
-
source.gsub(/^assert(\(| ) *! */, 'assert_not\\1')
|
40
|
-
end
|
41
|
-
end
|
42
|
-
end
|
43
|
-
end
|
44
|
-
end
|