rubocop 0.70.0 → 0.75.0

data/lib/rubocop.rb

@@ -27,6 +27,7 @@ require_relative 'rubocop/ast/node/mixin/conditional_node'
 require_relative 'rubocop/ast/node/mixin/hash_element_node'
 require_relative 'rubocop/ast/node/mixin/method_dispatch_node'
 require_relative 'rubocop/ast/node/mixin/modifier_node'
+require_relative 'rubocop/ast/node/mixin/numeric_node'
 require_relative 'rubocop/ast/node/mixin/parameterized_node'
 require_relative 'rubocop/ast/node/mixin/predicate_operator_node'
 require_relative 'rubocop/ast/node/mixin/basic_literal_node'
@@ -42,8 +43,10 @@ require_relative 'rubocop/ast/node/def_node'
 require_relative 'rubocop/ast/node/defined_node'
 require_relative 'rubocop/ast/node/ensure_node'
 require_relative 'rubocop/ast/node/for_node'
+require_relative 'rubocop/ast/node/float_node'
 require_relative 'rubocop/ast/node/hash_node'
 require_relative 'rubocop/ast/node/if_node'
+require_relative 'rubocop/ast/node/int_node'
 require_relative 'rubocop/ast/node/keyword_splat_node'
 require_relative 'rubocop/ast/node/module_node'
 require_relative 'rubocop/ast/node/or_node'
@@ -117,8 +120,8 @@ require_relative 'rubocop/cop/mixin/frozen_string_literal'
 require_relative 'rubocop/cop/mixin/hash_alignment'
 require_relative 'rubocop/cop/mixin/ignored_pattern'
 require_relative 'rubocop/cop/mixin/ignored_methods'
-require_relative 'rubocop/cop/mixin/ignored_method_patterns'
 require_relative 'rubocop/cop/mixin/integer_node'
+require_relative 'rubocop/cop/mixin/interpolation'
 require_relative 'rubocop/cop/mixin/match_range'
 require_relative 'rubocop/cop/mixin/method_complexity'
 require_relative 'rubocop/cop/mixin/method_preference'
@@ -148,13 +151,16 @@ require_relative 'rubocop/cop/mixin/statement_modifier'
 require_relative 'rubocop/cop/mixin/string_help'
 require_relative 'rubocop/cop/mixin/string_literals_help'
 require_relative 'rubocop/cop/mixin/target_ruby_version'
-require_relative 'rubocop/cop/mixin/target_rails_version'
 require_relative 'rubocop/cop/mixin/too_many_lines'
 require_relative 'rubocop/cop/mixin/trailing_body'
 require_relative 'rubocop/cop/mixin/trailing_comma'
 require_relative 'rubocop/cop/mixin/uncommunicative_name'
 require_relative 'rubocop/cop/mixin/unused_argument'
 
+require_relative 'rubocop/cop/utils/format_string'
+
+require_relative 'rubocop/cop/migration/department_name'
+
 require_relative 'rubocop/cop/correctors/alignment_corrector'
 require_relative 'rubocop/cop/correctors/condition_corrector'
 require_relative 'rubocop/cop/correctors/each_to_for_corrector'
@@ -179,6 +185,7 @@ require_relative 'rubocop/cop/bundler/ordered_gems'
 require_relative 'rubocop/cop/gemspec/duplicated_assignment'
 require_relative 'rubocop/cop/gemspec/ordered_dependencies'
 require_relative 'rubocop/cop/gemspec/required_ruby_version'
+require_relative 'rubocop/cop/gemspec/ruby_version_globals_usage'
 
 require_relative 'rubocop/cop/layout/access_modifier_indentation'
 require_relative 'rubocop/cop/layout/align_arguments'
@@ -325,6 +332,7 @@ require_relative 'rubocop/cop/lint/safe_navigation_consistency'
 require_relative 'rubocop/cop/lint/safe_navigation_chain'
 require_relative 'rubocop/cop/lint/safe_navigation_with_empty'
 require_relative 'rubocop/cop/lint/script_permission'
+require_relative 'rubocop/cop/lint/send_with_mixin_argument'
 require_relative 'rubocop/cop/lint/shadowed_argument'
 require_relative 'rubocop/cop/lint/shadowed_exception'
 require_relative 'rubocop/cop/lint/shadowing_outer_local_variable'
@@ -411,6 +419,7 @@ require_relative 'rubocop/cop/style/def_with_parentheses'
 require_relative 'rubocop/cop/style/dir'
 require_relative 'rubocop/cop/style/documentation_method'
 require_relative 'rubocop/cop/style/documentation'
+require_relative 'rubocop/cop/style/double_cop_disable_directive'
 require_relative 'rubocop/cop/style/double_negation'
 require_relative 'rubocop/cop/style/each_for_simple_loop'
 require_relative 'rubocop/cop/style/each_with_object'
@@ -425,6 +434,7 @@ require_relative 'rubocop/cop/style/end_block'
 require_relative 'rubocop/cop/style/eval_with_location'
 require_relative 'rubocop/cop/style/even_odd'
 require_relative 'rubocop/cop/style/expand_path_arguments'
+require_relative 'rubocop/cop/style/float_division'
 require_relative 'rubocop/cop/style/for'
 require_relative 'rubocop/cop/style/format_string'
 require_relative 'rubocop/cop/style/format_string_token'
@@ -462,6 +472,7 @@ require_relative 'rubocop/cop/style/multiline_if_modifier'
 require_relative 'rubocop/cop/style/multiline_method_signature'
 require_relative 'rubocop/cop/style/multiline_memoization'
 require_relative 'rubocop/cop/style/multiline_ternary_operator'
+require_relative 'rubocop/cop/style/multiline_when_then'
 require_relative 'rubocop/cop/style/multiple_comparison'
 require_relative 'rubocop/cop/style/mutable_constant'
 require_relative 'rubocop/cop/style/negated_if'
@@ -547,58 +558,6 @@ require_relative 'rubocop/cop/style/word_array'
 require_relative 'rubocop/cop/style/yoda_condition'
 require_relative 'rubocop/cop/style/zero_length_predicate'
 
-require_relative 'rubocop/cop/rails/action_filter'
-require_relative 'rubocop/cop/rails/active_record_aliases'
-require_relative 'rubocop/cop/rails/active_record_override'
-require_relative 'rubocop/cop/rails/active_support_aliases'
-require_relative 'rubocop/cop/rails/application_job'
-require_relative 'rubocop/cop/rails/application_record'
-require_relative 'rubocop/cop/rails/assert_not'
-require_relative 'rubocop/cop/rails/belongs_to'
-require_relative 'rubocop/cop/rails/blank'
-require_relative 'rubocop/cop/rails/bulk_change_table'
-require_relative 'rubocop/cop/rails/create_table_with_timestamps'
-require_relative 'rubocop/cop/rails/date'
-require_relative 'rubocop/cop/rails/delegate'
-require_relative 'rubocop/cop/rails/delegate_allow_blank'
-require_relative 'rubocop/cop/rails/dynamic_find_by'
-require_relative 'rubocop/cop/rails/enum_uniqueness'
-require_relative 'rubocop/cop/rails/environment_comparison'
-require_relative 'rubocop/cop/rails/exit'
-require_relative 'rubocop/cop/rails/file_path'
-require_relative 'rubocop/cop/rails/find_by'
-require_relative 'rubocop/cop/rails/find_each'
-require_relative 'rubocop/cop/rails/has_and_belongs_to_many'
-require_relative 'rubocop/cop/rails/has_many_or_has_one_dependent'
-require_relative 'rubocop/cop/rails/http_positional_arguments'
-require_relative 'rubocop/cop/rails/http_status'
-require_relative 'rubocop/cop/rails/ignored_skip_action_filter_option'
-require_relative 'rubocop/cop/rails/inverse_of'
-require_relative 'rubocop/cop/rails/lexically_scoped_action_filter'
-require_relative 'rubocop/cop/rails/link_to_blank'
-require_relative 'rubocop/cop/rails/not_null_column'
-require_relative 'rubocop/cop/rails/output'
-require_relative 'rubocop/cop/rails/output_safety'
-require_relative 'rubocop/cop/rails/pluralization_grammar'
-require_relative 'rubocop/cop/rails/presence'
-require_relative 'rubocop/cop/rails/present'
-require_relative 'rubocop/cop/rails/read_write_attribute'
-require_relative 'rubocop/cop/rails/redundant_allow_nil'
-require_relative 'rubocop/cop/rails/redundant_receiver_in_with_options'
-require_relative 'rubocop/cop/rails/reflection_class_name'
-require_relative 'rubocop/cop/rails/refute_methods'
-require_relative 'rubocop/cop/rails/relative_date_constant'
-require_relative 'rubocop/cop/rails/request_referer'
-require_relative 'rubocop/cop/rails/reversible_migration'
-require_relative 'rubocop/cop/rails/safe_navigation'
-require_relative 'rubocop/cop/rails/save_bang'
-require_relative 'rubocop/cop/rails/scope_args'
-require_relative 'rubocop/cop/rails/skips_model_validations'
-require_relative 'rubocop/cop/rails/time_zone'
-require_relative 'rubocop/cop/rails/uniq_before_pluck'
-require_relative 'rubocop/cop/rails/unknown_env'
-require_relative 'rubocop/cop/rails/validation'
-
 require_relative 'rubocop/cop/security/eval'
 require_relative 'rubocop/cop/security/json_load'
 require_relative 'rubocop/cop/security/marshal_load'
@@ -623,6 +582,7 @@ require_relative 'rubocop/formatter/progress_formatter'
 require_relative 'rubocop/formatter/quiet_formatter'
 require_relative 'rubocop/formatter/tap_formatter'
 require_relative 'rubocop/formatter/worst_offenders_formatter'
+require_relative 'rubocop/formatter/pacman_formatter'
 # relies on progress formatter
 require_relative 'rubocop/formatter/auto_gen_config_formatter'
 
@@ -632,7 +592,9 @@ require_relative 'rubocop/cached_data'
 require_relative 'rubocop/config'
 require_relative 'rubocop/config_loader_resolver'
 require_relative 'rubocop/config_loader'
+require_relative 'rubocop/config_obsoletion'
 require_relative 'rubocop/config_store'
+require_relative 'rubocop/config_validator'
 require_relative 'rubocop/target_finder'
 require_relative 'rubocop/token'
 require_relative 'rubocop/comment_config'

data/lib/rubocop/ast/builder.rb

@@ -28,8 +28,10 @@ module RuboCop
         defs:       DefNode,
         ensure:     EnsureNode,
         for:        ForNode,
+        float:      FloatNode,
         hash:       HashNode,
         if:         IfNode,
+        int:        IntNode,
         irange:     RangeNode,
         erange:     RangeNode,
         kwsplat:    KeywordSplatNode,

data/lib/rubocop/ast/node.rb

@@ -302,12 +302,10 @@ module RuboCop
 
       ## Destructuring
 
-      def_node_matcher :receiver, <<-PATTERN
+      def_node_matcher :receiver, <<~PATTERN
         {(send $_ ...) (block (send $_ ...) ...)}
       PATTERN
 
-      # Note: for masgn, #asgn_rhs will be an array node
-      def_node_matcher :asgn_rhs, '[assignment? (... $_)]'
       def_node_matcher :str_content, '(str $_)'
 
       def const_name
@@ -321,7 +319,7 @@ module RuboCop
         end
       end
 
-      def_node_matcher :defined_module0, <<-PATTERN
+      def_node_matcher :defined_module0, <<~PATTERN
         {(class (const $_ $_) ...)
          (module (const $_ $_) ...)
          (casgn $_ $_        (send (const nil? {:Class :Module}) :new ...))
@@ -367,7 +365,7 @@ module RuboCop
       end
 
       # Some cops treat the shovel operator as a kind of assignment.
-      def_node_matcher :assignment_or_similar?, <<-PATTERN
+      def_node_matcher :assignment_or_similar?, <<~PATTERN
         {assignment? (send _recv :<< ...)}
       PATTERN
 
@@ -405,7 +403,7 @@ module RuboCop
               receiver.send(recursive_kind) &&
               arguments.all?(&recursive_kind)
           when :begin, :pair, *OPERATOR_KEYWORDS, *COMPOSITE_LITERALS
-            children.all?(&recursive_kind)
+            children.compact.all?(&recursive_kind)
           else
             send(kind_filter)
           end
@@ -479,11 +477,11 @@ module RuboCop
         irange_type? || erange_type?
       end
 
-      def_node_matcher :guard_clause?, <<-PATTERN
-        [{(send nil? {:raise :fail} ...) return break next} single_line?]
+      def_node_matcher :guard_clause?, <<~PATTERN
+        [${(send nil? {:raise :fail} ...) return break next} single_line?]
       PATTERN
 
-      def_node_matcher :proc?, <<-PATTERN
+      def_node_matcher :proc?, <<~PATTERN
         {(block (send nil? :proc) ...)
          (block (send (const nil? :Proc) :new) ...)
          (send (const nil? :Proc) :new)}
@@ -492,15 +490,11 @@ module RuboCop
       def_node_matcher :lambda?, '(block (send nil? :lambda) ...)'
       def_node_matcher :lambda_or_proc?, '{lambda? proc?}'
 
-      def_node_matcher :class_constructor?, <<-PATTERN
+      def_node_matcher :class_constructor?, <<~PATTERN
         {       (send (const nil? {:Class :Module}) :new ...)
          (block (send (const nil? {:Class :Module}) :new ...) ...)}
       PATTERN
 
-      def_node_matcher :module_definition?, <<-PATTERN
-        {class module (casgn _ _ class_constructor?)}
-      PATTERN
-
       # Some expressions are evaluated for their value, some for their side
       # effects, and some for both
       # If we know that an expression is useful only for its side effects, that
@@ -638,7 +632,7 @@ module RuboCop
         end
       end
 
-      def_node_matcher :new_class_or_module_block?, <<-PATTERN
+      def_node_matcher :new_class_or_module_block?, <<~PATTERN
         ^(casgn _ _ (block (send (const _ {:Class :Module}) :new) ...))
       PATTERN
     end

data/lib/rubocop/ast/node/float_node.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # A node extension for `float` nodes. This will be used in place of a plain
+    # node when the builder constructs the AST, making its methods available to
+    # all `float` nodes within RuboCop.
+    class FloatNode < Node
+      include NumericNode
+    end
+  end
+end

data/lib/rubocop/ast/node/int_node.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # A node extension for `int` nodes. This will be used in place of a plain
+    # node when the builder constructs the AST, making its methods available to
+    # all `int` nodes within RuboCop.
+    class IntNode < Node
+      include NumericNode
+    end
+  end
+end

data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb

@@ -220,7 +220,7 @@ module RuboCop
 
       private
 
-      def_node_matcher :macro_scope?, <<-PATTERN
+      def_node_matcher :macro_scope?, <<~PATTERN
         {^{({sclass class module block} ...) class_constructor?}
          ^^{({sclass class module block} ... ({begin if} ...)) class_constructor?}
          ^#macro_kwbegin_wrapper?
@@ -245,15 +245,15 @@ module RuboCop
         node.parent.nil?
       end
 
-      def_node_matcher :adjacent_def_modifier?, <<-PATTERN
+      def_node_matcher :adjacent_def_modifier?, <<~PATTERN
         (send nil? _ ({def defs} ...))
       PATTERN
 
-      def_node_matcher :bare_access_modifier_declaration?, <<-PATTERN
+      def_node_matcher :bare_access_modifier_declaration?, <<~PATTERN
         (send nil? {:public :protected :private :module_function})
       PATTERN
 
-      def_node_matcher :non_bare_access_modifier_declaration?, <<-PATTERN
+      def_node_matcher :non_bare_access_modifier_declaration?, <<~PATTERN
         (send nil? {:public :protected :private :module_function} _)
       PATTERN
     end

data/lib/rubocop/ast/node/mixin/numeric_node.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # Common functionality for primitive numeric nodes: `int`, `float`, ...
+    module NumericNode
+      SIGN_REGEX = /\A[+-]/.freeze
+
+      # Checks whether this is literal has a sign.
+      #
+      # @example
+      #
+      #   +42
+      #
+      # @return [Boolean] whether this literal has a sign.
+      def sign?
+        source.match(SIGN_REGEX)
+      end
+    end
+  end
+end

data/lib/rubocop/ast/node/resbody_node.rb

@@ -17,12 +17,7 @@ module RuboCop
       #
       # @return [Node, nil] The exception variable of the `resbody`.
       def exception_variable
-        variable = node_parts[1]
-        return variable if variable
-
-        # When resbody is an implicit rescue (i.e. `rescue e` style),
-        # the exception variable is descendants[1].
-        descendants[1]
+        node_parts[1]
       end
     end
   end

data/lib/rubocop/ast/traversal.rb

@@ -35,7 +35,7 @@ module RuboCop
       end
 
       ONE_CHILD_NODE.each do |type|
-        module_eval(<<-RUBY, __FILE__, __LINE__ + 1)
+        module_eval(<<~RUBY, __FILE__, __LINE__ + 1)
           def on_#{type}(node)
             if (child = node.children[0])
               send(:"on_\#{child.type}", child)
@@ -45,7 +45,7 @@ module RuboCop
       end
 
       MANY_CHILD_NODES.each do |type|
-        module_eval(<<-RUBY, __FILE__, __LINE__ + 1)
+        module_eval(<<~RUBY, __FILE__, __LINE__ + 1)
           def on_#{type}(node)
             node.children.each { |child| send(:"on_\#{child.type}", child) }
             nil
@@ -55,7 +55,7 @@ module RuboCop
 
       SECOND_CHILD_ONLY.each do |type|
         # Guard clause is for nodes nested within mlhs
-        module_eval(<<-RUBY, __FILE__, __LINE__ + 1)
+        module_eval(<<~RUBY, __FILE__, __LINE__ + 1)
           def on_#{type}(node)
             if (child = node.children[1])
               send(:"on_\#{child.type}", child)

data/lib/rubocop/cached_data.rb

@@ -38,7 +38,7 @@ module RuboCop
     def message(offense)
       # JSON.dump will fail if the offense message contains text which is not
       # valid UTF-8
-      offense.message.scrub
+      offense.message.dup.force_encoding(::Encoding::UTF_8).scrub
     end
 
     # Restore an offense object loaded from a JSON file.

data/lib/rubocop/comment_config.rb

@@ -11,7 +11,8 @@ module RuboCop
     COPS_PATTERN = "(all|#{COP_NAMES_PATTERN})"
 
     COMMENT_DIRECTIVE_REGEXP = Regexp.new(
-      ('# rubocop : ((?:dis|en)able)\b ' + COPS_PATTERN).gsub(' ', '\s*')
+      ('# rubocop : ((?:disable|enable|todo))\b ' + COPS_PATTERN)
+        .gsub(' ', '\s*')
     )
 
     CopAnalysis = Struct.new(:line_ranges, :start_line_number)
@@ -141,7 +142,7 @@ module RuboCop
       cop_names =
         cops_string == 'all' ? all_cop_names : cops_string.split(/,\s*/)
 
-      disabled = (switch == 'disable')
+      disabled = %w[disable todo].include?(switch)
 
       [cop_names, disabled]
     end

data/lib/rubocop/config.rb

@@ -8,227 +8,12 @@ module RuboCop
   # file from which it was read. Several different Configs can be used
   # during a run of the rubocop program, if files in several
   # directories are inspected.
-
-  # rubocop:disable Metrics/ClassLength
   class Config
     include PathUtil
     include FileFinder
+    extend Forwardable
 
-    COMMON_PARAMS = %w[Exclude Include Severity inherit_mode
-                       AutoCorrect StyleGuide Details].freeze
-    INTERNAL_PARAMS = %w[Description StyleGuide VersionAdded
-                         VersionChanged Reference Safe SafeAutoCorrect].freeze
-
-    # 2.3 is the oldest officially supported Ruby version.
-    DEFAULT_RUBY_VERSION = 2.3
-    KNOWN_RUBIES = [2.3, 2.4, 2.5, 2.6].freeze
-    OBSOLETE_RUBIES = {
-      1.9 => '0.50', 2.0 => '0.50', 2.1 => '0.58', 2.2 => '0.69'
-    }.freeze
-    RUBY_VERSION_FILENAME = '.ruby-version'
     DEFAULT_RAILS_VERSION = 5.0
-    OBSOLETE_COPS = {
-      'Style/FlipFlop' =>
-        'The `Style/FlipFlop` cop has been moved to `Lint/FlipFlop`.',
-      'Style/TrailingComma' =>
-        'The `Style/TrailingComma` cop no longer exists. Please use ' \
-        '`Style/TrailingCommaInArguments`, ' \
-        '`Style/TrailingCommaInArrayLiteral`, and/or ' \
-        '`Style/TrailingCommaInHashLiteral` instead.',
-      'Style/TrailingCommaInLiteral' =>
-        'The `Style/TrailingCommaInLiteral` cop no longer exists. Please use ' \
-        '`Style/TrailingCommaInArrayLiteral` and/or ' \
-        '`Style/TrailingCommaInHashLiteral` instead.',
-      'Rails/DefaultScope' =>
-        'The `Rails/DefaultScope` cop no longer exists.',
-      'Lint/InvalidCharacterLiteral' =>
-        'The `Lint/InvalidCharacterLiteral` cop has been removed since it ' \
-        'was never being actually triggered.',
-      'Style/SingleSpaceBeforeFirstArg' =>
-        'The `Style/SingleSpaceBeforeFirstArg` cop has been renamed to ' \
-        '`Layout/SpaceBeforeFirstArg`.',
-      'Lint/RescueWithoutErrorClass' =>
-        'The `Lint/RescueWithoutErrorClass` cop has been replaced by ' \
-        '`Style/RescueStandardError`.',
-      'Lint/SpaceBeforeFirstArg' =>
-        'The `Lint/SpaceBeforeFirstArg` cop has been removed, since it was a ' \
-        'duplicate of `Layout/SpaceBeforeFirstArg`. Please use ' \
-        '`Layout/SpaceBeforeFirstArg` instead.',
-      'Layout/FirstParameterIndentation' =>
-        'The `Layout/FirstParameterIndentation` cop has been renamed to ' \
-        '`Layout/IndentFirstArgument`.',
-      'Layout/IndentArray' =>
-        'The `Layout/IndentArray` cop has been renamed to ' \
-        '`Layout/IndentFirstArrayElement`.',
-      'Layout/IndentHash' =>
-        'The `Layout/IndentHash` cop has been renamed to ' \
-        '`Layout/IndentFirstHashElement`.',
-      'Layout/SpaceAfterControlKeyword' =>
-        'The `Layout/SpaceAfterControlKeyword` cop has been removed. Please ' \
-        'use `Layout/SpaceAroundKeyword` instead.',
-      'Layout/SpaceBeforeModifierKeyword' =>
-        'The `Layout/SpaceBeforeModifierKeyword` cop has been removed. ' \
-        'Please use `Layout/SpaceAroundKeyword` instead.',
-      'Style/SpaceAfterControlKeyword' =>
-        'The `Style/SpaceAfterControlKeyword` cop has been removed. Please ' \
-        'use `Layout/SpaceAroundKeyword` instead.',
-      'Style/SpaceBeforeModifierKeyword' =>
-        'The `Style/SpaceBeforeModifierKeyword` cop has been removed. Please ' \
-        'use `Layout/SpaceAroundKeyword` instead.',
-      'Style/MethodCallParentheses' =>
-        'The `Style/MethodCallParentheses` cop has been renamed to ' \
-          '`Style/MethodCallWithoutArgsParentheses`.',
-      'Lint/Eval' =>
-        'The `Lint/Eval` cop has been renamed to `Security/Eval`.',
-      'Style/DeprecatedHashMethods' =>
-        'The `Style/DeprecatedHashMethods` cop has been renamed to ' \
-          '`Style/PreferredHashMethods`.',
-      'Style/AccessorMethodName' =>
-        'The `Style/AccessorMethodName` cop has been moved to ' \
-          '`Naming/AccessorMethodName`.',
-      'Style/AsciiIdentifiers' =>
-        'The `Style/AsciiIdentifiers` cop has been moved to ' \
-          '`Naming/AccessorMethodName`.',
-      'Style/OpMethod' =>
-        'The `Style/OpMethod` cop has been renamed and moved to ' \
-          '`Naming/BinaryOperatorParameterName`.',
-      'Style/ClassAndModuleCamelCase' =>
-        'The `Style/ClassAndModuleCamelCase` cop has been renamed to ' \
-          '`Naming/ClassAndModuleCamelCase`.',
-      'Style/ConstantName' =>
-        'The `Style/ConstantName` cop has been renamed to ' \
-          '`Naming/ConstantName`.',
-      'Style/FileName' =>
-        'The `Style/FileName` cop has been renamed to `Naming/FileName`.',
-      'Style/MethodName' =>
-        'The `Style/MethodName` cop has been renamed to ' \
-          '`Naming/MethodName`.',
-      'Style/PredicateName' =>
-        'The `Style/PredicateName` cop has been renamed to ' \
-          '`Naming/PredicateName`.',
-      'Style/VariableName' =>
-        'The `Style/VariableName` cop has been renamed to ' \
-          '`Naming/VariableName`.',
-      'Style/VariableNumber' =>
-        'The `Style/VariableNumber` cop has been renamed to ' \
-          '`Naming/VariableNumber`.',
-      'Lint/BlockAlignment' =>
-        'The `Lint/BlockAlignment` cop has been renamed to ' \
-          '`Layout/BlockAlignment`.',
-      'Lint/EndAlignment' =>
-        'The `Lint/EndAlignment` cop has been renamed to ' \
-          '`Layout/EndAlignment`.',
-      'Lint/DefEndAlignment' =>
-        'The `Lint/DefEndAlignment` cop has been renamed to ' \
-          '`Layout/DefEndAlignment`.',
-      'Style/MethodMissing' =>
-        'The `Style/MethodMissing` cop has been split into ' \
-          '`Style/MethodMissingSuper` and `Style/MissingRespondToMissing`.'
-    }.freeze
-
-    OBSOLETE_PARAMETERS = [
-      {
-        cop: 'Layout/SpaceAroundOperators',
-        parameter: 'MultiSpaceAllowedForOperators',
-        alternative: 'If your intention was to allow extra spaces ' \
-                     'for alignment, please use AllowForAlignment: ' \
-                     'true instead.'
-      },
-      {
-        cop: 'Style/Encoding',
-        parameter: 'EnforcedStyle',
-        alternative: 'Style/Encoding no longer supports styles. ' \
-                     'The "never" behavior is always assumed.'
-      },
-      {
-        cop: 'Style/Encoding',
-        parameter: 'SupportedStyles',
-        alternative: 'Style/Encoding no longer supports styles. ' \
-                     'The "never" behavior is always assumed.'
-      },
-      {
-        cop: 'Style/Encoding',
-        parameter: 'AutoCorrectEncodingComment',
-        alternative: 'Style/Encoding no longer supports styles. ' \
-                     'The "never" behavior is always assumed.'
-      },
-      {
-        cop: 'Style/IfUnlessModifier',
-        parameter: 'MaxLineLength',
-        alternative:
-          '`Style/IfUnlessModifier: MaxLineLength` has been removed. Use ' \
-          '`Metrics/LineLength: Max` instead'
-      },
-      {
-        cop: 'Style/SpaceAroundOperators',
-        parameter: 'MultiSpaceAllowedForOperators',
-        alternative: 'If your intention was to allow extra spaces ' \
-                     'for alignment, please use AllowForAlignment: ' \
-                     'true instead.'
-      },
-      {
-        cop: 'Style/WhileUntilModifier',
-        parameter: 'MaxLineLength',
-        alternative:
-          '`Style/WhileUntilModifier: MaxLineLength` has been removed. Use ' \
-          '`Metrics/LineLength: Max` instead'
-      },
-      {
-        cop: 'AllCops',
-        parameter: 'RunRailsCops',
-        alternative: "Use the following configuration instead:\n" \
-                     "Rails:\n  Enabled: true"
-      },
-      {
-        cop: 'Layout/CaseIndentation',
-        parameter: 'IndentWhenRelativeTo',
-        alternative: '`IndentWhenRelativeTo` has been renamed to ' \
-                     '`EnforcedStyle`'
-      },
-      {
-        cop: 'Lint/BlockAlignment',
-        parameter: 'AlignWith',
-        alternative: '`AlignWith` has been renamed to ' \
-                     '`EnforcedStyleAlignWith`'
-      },
-      {
-        cop: 'Layout/BlockAlignment',
-        parameter: 'AlignWith',
-        alternative: '`AlignWith` has been renamed to ' \
-                     '`EnforcedStyleAlignWith`'
-      },
-      {
-        cop: 'Lint/EndAlignment',
-        parameter: 'AlignWith',
-        alternative: '`AlignWith` has been renamed to ' \
-                     '`EnforcedStyleAlignWith`'
-      },
-      {
-        cop: 'Layout/EndAlignment',
-        parameter: 'AlignWith',
-        alternative: '`AlignWith` has been renamed to ' \
-                     '`EnforcedStyleAlignWith`'
-      },
-      {
-        cop: 'Lint/DefEndAlignment',
-        parameter: 'AlignWith',
-        alternative: '`AlignWith` has been renamed to ' \
-                     '`EnforcedStyleAlignWith`'
-      },
-      {
-        cop: 'Layout/DefEndAlignment',
-        parameter: 'AlignWith',
-        alternative: '`AlignWith` has been renamed to ' \
-                     '`EnforcedStyleAlignWith`'
-      },
-      {
-        cop: 'Rails/UniqBeforePluck',
-        parameter: 'EnforcedMode',
-        alternative: '`EnforcedMode` has been renamed to ' \
-                     '`EnforcedStyle`'
-      }
-    ].freeze
-
     attr_reader :loaded_path
 
     def initialize(hash = {}, loaded_path = nil)
@@ -240,6 +25,7 @@ module RuboCop
         h[cop] = cop_options
       end
       @hash = hash
+      @validator = ConfigValidator.new(self)
     end
 
     def self.create(hash, path)
@@ -250,54 +36,14 @@ module RuboCop
       deprecation_check do |deprecation_message|
         warn("#{loaded_path} - #{deprecation_message}")
       end
-      validate
+      @validator.validate
       make_excludes_absolute
       self
     end
 
-    def [](key)
-      @hash[key]
-    end
-
-    def []=(key, value)
-      @hash[key] = value
-    end
-
-    def delete(key)
-      @hash.delete(key)
-    end
-
-    def each(&block)
-      @hash.each(&block)
-    end
-
-    def key?(key)
-      @hash.key?(key)
-    end
-
-    def keys
-      @hash.keys
-    end
-
-    def each_key(&block)
-      @hash.each_key(&block)
-    end
-
-    def map(&block)
-      @hash.map(&block)
-    end
-
-    def merge(other_hash)
-      @hash.merge(other_hash)
-    end
-
-    def to_h
-      @hash
-    end
-
-    def to_hash
-      @hash
-    end
+    def_delegators :@hash, :[], :[]=, :delete, :each, :key?, :keys, :each_key,
+                   :map, :merge, :to_h, :to_hash
+    def_delegators :@validator, :validate, :target_ruby_version
 
     def to_s
       @to_s ||= @hash.to_s
@@ -309,7 +55,7 @@ module RuboCop
 
     def make_excludes_absolute
       each_key do |key|
-        validate_section_presence(key)
+        @validator.validate_section_presence(key)
         next unless self[key]['Exclude']
 
         self[key]['Exclude'].map! do |exclude_elem|
@@ -350,27 +96,12 @@ module RuboCop
       @for_cop[cop.respond_to?(:cop_name) ? cop.cop_name : cop]
     end
 
-    def for_all_cops
-      @for_all_cops ||= self['AllCops'] || {}
+    def for_department(department_name)
+      @for_cop[department_name]
     end
 
-    def validate
-      # Don't validate RuboCop's own files. Avoids infinite recursion.
-      base_config_path = File.expand_path(File.join(ConfigLoader::RUBOCOP_HOME,
-                                                    'config'))
-      return if File.expand_path(loaded_path).start_with?(base_config_path)
-
-      valid_cop_names, invalid_cop_names = keys.partition do |key|
-        ConfigLoader.default_configuration.key?(key)
-      end
-
-      reject_obsolete_cops_and_parameters
-      warn_about_unrecognized_cops(invalid_cop_names)
-      check_target_ruby
-      validate_parameter_names(valid_cop_names)
-      validate_enforced_styles(valid_cop_names)
-      validate_syntax_cop
-      reject_mutually_exclusive_defaults
+    def for_all_cops
+      @for_all_cops ||= self['AllCops'] || {}
     end
 
     def file_to_include?(file)
@@ -451,26 +182,6 @@ module RuboCop
         end
     end
 
-    def target_ruby_version
-      @target_ruby_version ||= begin
-        if for_all_cops['TargetRubyVersion']
-          @target_ruby_version_source = :rubocop_yml
-
-          for_all_cops['TargetRubyVersion'].to_f
-        elsif target_ruby_version_from_version_file
-          @target_ruby_version_source = :ruby_version_file
-
-          target_ruby_version_from_version_file
-        elsif target_ruby_version_from_bundler_lock_file
-          @target_ruby_version_source = :bundler_lock_file
-
-          target_ruby_version_from_bundler_lock_file
-        else
-          DEFAULT_RUBY_VERSION
-        end
-      end
-    end
-
     def target_rails_version
       @target_rails_version ||=
         if for_all_cops['TargetRailsVersion']
@@ -482,195 +193,22 @@ module RuboCop
         end
     end
 
-    private
-
-    def warn_about_unrecognized_cops(invalid_cop_names)
-      invalid_cop_names.each do |name|
-        # There could be a custom cop with this name. If so, don't warn
-        next if Cop::Cop.registry.contains_cop_matching?([name])
-
-        # Special case for inherit_mode, which is a directive that we keep in
-        # the configuration (even though it's not a cop), because it's easier
-        # to do so than to pass the value around to various methods.
-        next if name == 'inherit_mode'
-
-        warn Rainbow("Warning: unrecognized cop #{name} found in " \
-                     "#{smart_loaded_path}").yellow
-      end
-    end
-
-    def validate_syntax_cop
-      syntax_config = self['Lint/Syntax']
-      default_config = ConfigLoader.default_configuration['Lint/Syntax']
-
-      return unless syntax_config &&
-                    default_config.merge(syntax_config) != default_config
-
-      raise ValidationError,
-            "configuration for Syntax cop found in #{smart_loaded_path}\n" \
-            'It\'s not possible to disable this cop.'
-    end
-
-    def validate_section_presence(name)
-      return unless key?(name) && self[name].nil?
-
-      raise ValidationError,
-            "empty section #{name} found in #{smart_loaded_path}"
-    end
-
-    def validate_parameter_names(valid_cop_names)
-      valid_cop_names.each do |name|
-        validate_section_presence(name)
-        default_config = ConfigLoader.default_configuration[name]
-
-        self[name].each_key do |param|
-          next if COMMON_PARAMS.include?(param) || default_config.key?(param)
-
-          message =
-            "Warning: #{name} does not support #{param} parameter.\n\n" \
-            "Supported parameters are:\n\n" \
-            "  - #{(default_config.keys - INTERNAL_PARAMS).join("\n  - ")}\n"
-
-          warn Rainbow(message).yellow.to_s
-        end
-      end
-    end
-
-    def validate_enforced_styles(valid_cop_names)
-      valid_cop_names.each do |name|
-        styles = self[name].select { |key, _| key.start_with?('Enforced') }
-
-        styles.each do |style_name, style|
-          supported_key = RuboCop::Cop::Util.to_supported_styles(style_name)
-          valid = ConfigLoader.default_configuration[name][supported_key]
-
-          next unless valid
-          next if valid.include?(style)
-          next if validate_support_and_has_list(name, style, valid)
-
-          msg = "invalid #{style_name} '#{style}' for #{name} found in " \
-            "#{smart_loaded_path}\n" \
-            "Valid choices are: #{valid.join(', ')}"
-          raise ValidationError, msg
-        end
-      end
-    end
-
-    def validate_support_and_has_list(name, formats, valid)
-      ConfigLoader.default_configuration[name]['AllowMultipleStyles'] &&
-        formats.is_a?(Array) &&
-        formats.all? { |format| valid.include?(format) }
-    end
-
-    def reject_obsolete_cops_and_parameters
-      messages = [
-        obsolete_cops,
-        obsolete_parameters
-      ].flatten.compact
-      return if messages.empty?
-
-      raise ValidationError, messages.join("\n")
-    end
-
-    def obsolete_parameters
-      OBSOLETE_PARAMETERS.map do |params|
-        obsolete_parameter_message(params[:cop], params[:parameter],
-                                   params[:alternative])
-      end
-    end
-
-    def obsolete_parameter_message(cop, parameter, alternative)
-      return unless self[cop]&.key?(parameter)
-
-      "obsolete parameter #{parameter} (for #{cop}) " \
-        "found in #{smart_loaded_path}" \
-        "\n#{alternative}"
-    end
-
-    def obsolete_cops
-      OBSOLETE_COPS.map do |cop_name, message|
-        next unless key?(cop_name) || key?(Cop::Badge.parse(cop_name).cop_name)
-
-        message + "\n(obsolete configuration found in #{smart_loaded_path}," \
-                   ' please update it)'
-      end
+    def smart_loaded_path
+      PathUtil.smart_path(@loaded_path)
     end
 
-    def check_target_ruby
-      return if KNOWN_RUBIES.include?(target_ruby_version)
-
-      msg = if OBSOLETE_RUBIES.include?(target_ruby_version)
-              "Unsupported Ruby version #{target_ruby_version} found in " \
-              "#{target_ruby_source}. #{target_ruby_version}-compatible " \
-              'analysis was dropped after version ' \
-              "#{OBSOLETE_RUBIES[target_ruby_version]}."
-            else
-              "Unknown Ruby version #{target_ruby_version.inspect} found in " \
-              "#{target_ruby_source}."
-            end
-
-      msg += "\nSupported versions: #{KNOWN_RUBIES.join(', ')}"
-
-      raise ValidationError, msg
-    end
+    def bundler_lock_file_path
+      return nil unless loaded_path
 
-    def target_ruby_source
-      case @target_ruby_version_source
-      when :ruby_version_file
-        "`#{RUBY_VERSION_FILENAME}`"
-      when :bundler_lock_file
-        "`#{bundler_lock_file_path}`"
-      when :rubocop_yml
-        "`TargetRubyVersion` parameter (in #{smart_loaded_path})"
+      base_path = base_dir_for_path_parameters
+      ['gems.locked', 'Gemfile.lock'].each do |file_name|
+        path = find_file_upwards(file_name, base_path)
+        return path if path
       end
+      nil
     end
 
-    def ruby_version_file
-      @ruby_version_file ||=
-        find_file_upwards(RUBY_VERSION_FILENAME, base_dir_for_path_parameters)
-    end
-
-    def target_ruby_version_from_version_file
-      file = ruby_version_file
-      return unless file && File.file?(file)
-
-      @target_ruby_version_from_version_file ||=
-        File.read(file).match(/\A(ruby-)?(?<version>\d+\.\d+)/) do |md|
-          md[:version].to_f
-        end
-    end
-
-    def target_ruby_version_from_bundler_lock_file
-      @target_ruby_version_from_bundler_lock_file ||=
-        read_ruby_version_from_bundler_lock_file
-    end
-
-    def read_ruby_version_from_bundler_lock_file
-      lock_file_path = bundler_lock_file_path
-      return nil unless lock_file_path
-
-      in_ruby_section = false
-      File.foreach(lock_file_path) do |line|
-        # If ruby is in Gemfile.lock or gems.lock, there should be two lines
-        # towards the bottom of the file that look like:
-        #     RUBY VERSION
-        #       ruby W.X.YpZ
-        # We ultimately want to match the "ruby W.X.Y.pZ" line, but there's
-        # extra logic to make sure we only start looking once we've seen the
-        # "RUBY VERSION" line.
-        in_ruby_section ||= line.match(/^\s*RUBY\s*VERSION\s*$/)
-        next unless in_ruby_section
-
-        # We currently only allow this feature to work with MRI ruby. If jruby
-        # (or something else) is used by the project, it's lock file will have a
-        # line that looks like:
-        #     RUBY VERSION
-        #       ruby W.X.YpZ (jruby x.x.x.x)
-        # The regex won't match in this situation.
-        result = line.match(/^\s*ruby\s+(\d+\.\d+)[p.\d]*\s*$/)
-        return result.captures.first.to_f if result
-      end
-    end
+    private
 
     def target_rails_version_from_bundler_lock_file
       @target_rails_version_from_bundler_lock_file ||=
@@ -689,26 +227,6 @@ module RuboCop
       end
     end
 
-    def bundler_lock_file_path
-      return nil unless loaded_path
-
-      base_path = base_dir_for_path_parameters
-      ['gems.locked', 'Gemfile.lock'].each do |file_name|
-        path = find_file_upwards(file_name, base_path)
-        return path if path
-      end
-      nil
-    end
-
-    def reject_mutually_exclusive_defaults
-      disabled_by_default = for_all_cops['DisabledByDefault']
-      enabled_by_default = for_all_cops['EnabledByDefault']
-      return unless disabled_by_default && enabled_by_default
-
-      msg = 'Cops cannot be both enabled by default and disabled by default'
-      raise ValidationError, msg
-    end
-
     def enable_cop?(qualified_cop_name, cop_options)
       cop_department, cop_name = qualified_cop_name.split('/')
       department = cop_name.nil?
@@ -722,10 +240,5 @@ module RuboCop
 
       cop_options.fetch('Enabled') { !for_all_cops['DisabledByDefault'] }
     end
-
-    def smart_loaded_path
-      PathUtil.smart_path(@loaded_path)
-    end
   end
-  # rubocop:enable Metrics/ClassLength
 end