rubocop 0.70.0 → 0.75.0

data/lib/rubocop/path_util.rb

@@ -51,7 +51,7 @@ module RuboCop
 
     # Returns true for an absolute Unix or Windows path.
     def absolute?(path)
-      path =~ %r{\A([A-Z]:)?/}
+      path =~ %r{\A([A-Z]:)?/}i
     end
 
     def self.pwd

data/lib/rubocop/processed_source.rb

@@ -123,6 +123,10 @@ module RuboCop
       lines[token.line - 2]
     end
 
+    def current_line(token)
+      lines[token.line - 1]
+    end
+
     def following_line(token)
       lines[token.line]
     end
@@ -183,8 +187,12 @@ module RuboCop
       when 2.6
         require 'parser/ruby26'
         Parser::Ruby26
+      when 2.7
+        require 'parser/ruby27'
+        Parser::Ruby27
       else
-        raise ArgumentError, "Unknown Ruby version: #{ruby_version.inspect}"
+        raise ArgumentError,
+              "RuboCop found unknown Ruby version: #{ruby_version.inspect}"
       end
     end
     # rubocop:enable Metrics/MethodLength

data/lib/rubocop/rspec/cop_helper.rb

@@ -7,7 +7,6 @@ module CopHelper
   extend RSpec::SharedContext
 
   let(:ruby_version) { 2.3 }
-  let(:enabled_rails) { false }
   let(:rails_version) { false }
 
   def inspect_source_file(source)

data/lib/rubocop/rspec/expect_offense.rb

@@ -132,7 +132,10 @@ module RuboCop
       def expect_no_offenses(source, file = nil)
         inspect_source(source, file)
 
-        expect(cop.offenses).to be_empty
+        expected_annotations = AnnotatedSource.parse(source)
+        actual_annotations =
+          expected_annotations.with_offense_annotations(cop.offenses)
+        expect(actual_annotations.to_s).to eq(source)
       end
 
       # Parsed representation of code annotated with the `^^^ Message` style

data/lib/rubocop/rspec/shared_contexts.rb

@@ -47,7 +47,6 @@ RSpec.shared_context 'config', :config do
     end
 
     hash = { 'AllCops' => { 'TargetRubyVersion' => ruby_version } }
-    hash['Rails'] = { 'Enabled' => true } if enabled_rails
     hash['AllCops']['TargetRailsVersion'] = rails_version if rails_version
     if respond_to?(:cop_config)
       cop_name = described_class.cop_name
@@ -62,6 +61,18 @@ RSpec.shared_context 'config', :config do
   end
 end
 
+RSpec.shared_context 'mock console output' do
+  before do
+    $stdout = StringIO.new
+    $stderr = StringIO.new
+  end
+
+  after do
+    $stdout = STDOUT
+    $stderr = STDERR
+  end
+end
+
 RSpec.shared_context 'ruby 2.3', :ruby23 do
   let(:ruby_version) { 2.3 }
 end
@@ -77,19 +88,3 @@ end
 RSpec.shared_context 'ruby 2.6', :ruby26 do
   let(:ruby_version) { 2.6 }
 end
-
-RSpec.shared_context 'with Rails', :enabled_rails do
-  let(:enabled_rails) { true }
-end
-
-RSpec.shared_context 'with Rails 3', :rails3 do
-  let(:rails_version) { 3.0 }
-end
-
-RSpec.shared_context 'with Rails 4', :rails4 do
-  let(:rails_version) { 4.0 }
-end
-
-RSpec.shared_context 'with Rails 5', :rails5 do
-  let(:rails_version) { 5.0 }
-end

data/lib/rubocop/rspec/support.rb

@@ -5,7 +5,6 @@
 require_relative 'cop_helper'
 require_relative 'host_environment_simulation_helper'
 require_relative 'shared_contexts'
-require_relative 'shared_examples'
 require_relative 'expect_offense'
 
 RSpec.configure do |config|

data/lib/rubocop/runner.rb

@@ -72,7 +72,12 @@ module RuboCop
 
       each_inspected_file(files) { |file| inspected_files << file }
     ensure
-      ResultCache.cleanup(@config_store, @options[:debug]) if cached_run?
+      # OPTIMIZE: Calling `ResultCache.cleanup` takes time. This optimization
+      # mainly targets editors that integrates RuboCop. When RuboCop is run
+      # by an editor, it should be inspecting only one file.
+      if files.size > 1 && cached_run?
+        ResultCache.cleanup(@config_store, @options[:debug])
+      end
       formatter_set.finished(inspected_files.freeze)
       formatter_set.close_output_files
     end
@@ -150,10 +155,10 @@ module RuboCop
           if cop.relevant_file?(file)
             cop.check(offenses, source.disabled_line_ranges, source.comments)
             offenses += cop.offenses
-            autocorrect_unneeded_disables(source, cop)
+            offenses += autocorrect_unneeded_disables(file, source, cop,
+                                                      offenses)
           end
         end
-        offenses
       end
 
       offenses.sort.reject(&:disabled?).freeze
@@ -167,14 +172,20 @@ module RuboCop
       @options[:except] || @options[:only]
     end
 
-    def autocorrect_unneeded_disables(source, cop)
+    def autocorrect_unneeded_disables(file, source, cop, offenses)
       cop.processed_source = source
 
-      Cop::Team.new(
-        RuboCop::Cop::Registry.new,
-        nil,
-        @options
-      ).autocorrect(source.buffer, [cop])
+      team = Cop::Team.new(RuboCop::Cop::Registry.new, nil, @options)
+      team.autocorrect(source.buffer, [cop])
+
+      return [] unless team.updated_source_file?
+
+      # Do one extra inspection loop if any unneeded disables were
+      # removed. This is done in order to find rubocop:enable directives that
+      # have now become useless.
+      _source, new_offenses = do_inspection_loop(file,
+                                                 get_processed_source(file))
+      new_offenses - offenses
     end
 
     def file_started(file)
@@ -268,7 +279,6 @@ module RuboCop
 
     def inspect_file(processed_source)
       config = @config_store.for(processed_source.path)
-      enable_rails_cops(config) if @options[:rails]
       team = Cop::Team.new(mobilized_cop_classes(config), config, @options)
       offenses = team.inspect_file(processed_source)
       @errors.concat(team.errors)
@@ -276,11 +286,6 @@ module RuboCop
       [offenses, team.updated_source_file?]
     end
 
-    def enable_rails_cops(config)
-      config['Rails'] ||= {}
-      config['Rails']['Enabled'] = true
-    end
-
     def mobilized_cop_classes(config)
       @mobilized_cop_classes ||= {}
       @mobilized_cop_classes[config.object_id] ||= begin

data/lib/rubocop/target_finder.rb

@@ -65,10 +65,12 @@ module RuboCop
         to_inspect?(file, hidden_files, base_dir_config)
       end
 
-      # Most recently modified file first.
-      target_files.sort_by! { |path| -Integer(File.mtime(path)) } if fail_fast?
-
-      target_files
+      if fail_fast?
+        # Most recently modified file first.
+        target_files.sort_by! { |path| -Integer(File.mtime(path)) }
+      else
+        target_files.sort!
+      end
     end
 
     def to_inspect?(file, hidden_files, base_dir_config)

data/lib/rubocop/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.70.0'
+    STRING = '0.75.0'
 
     MSG = '%<version>s (using Parser %<parser_version>s, running on ' \
           '%<ruby_engine>s %<ruby_version>s %<ruby_platform>s)'

data/lib/rubocop/yaml_duplication_checker.rb

@@ -4,8 +4,14 @@ module RuboCop
   # Find duplicated keys from YAML.
   module YAMLDuplicationChecker
     def self.check(yaml_string, filename, &on_duplicated)
-      # Specify filename to display helpful message when it raises an error.
-      tree = YAML.parse(yaml_string, filename)
+      # Ruby 2.6+
+      tree = if Gem::Version.new(Psych::VERSION) >= Gem::Version.new('3.1.0')
+               # Specify filename to display helpful message when it raises
+               # an error.
+               YAML.parse(yaml_string, filename: filename)
+             else
+               YAML.parse(yaml_string, filename)
+             end
       return unless tree
 
       traverse(tree, &on_duplicated)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.70.0
+  version: 0.75.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-05-21 00:00:00.000000000 Z
+date: 2019-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jaro_winkler
@@ -128,20 +128,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '3.0'
-- !ruby/object:Gem::Dependency
-  name: rack
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '2.0'
 description: |2
       Automatic Ruby code style checking tool.
       Aims to enforce the community-driven Ruby Style Guide.
@@ -175,9 +161,11 @@ files:
 - lib/rubocop/ast/node/def_node.rb
 - lib/rubocop/ast/node/defined_node.rb
 - lib/rubocop/ast/node/ensure_node.rb
+- lib/rubocop/ast/node/float_node.rb
 - lib/rubocop/ast/node/for_node.rb
 - lib/rubocop/ast/node/hash_node.rb
 - lib/rubocop/ast/node/if_node.rb
+- lib/rubocop/ast/node/int_node.rb
 - lib/rubocop/ast/node/keyword_splat_node.rb
 - lib/rubocop/ast/node/mixin/basic_literal_node.rb
 - lib/rubocop/ast/node/mixin/binary_operator_node.rb
@@ -187,6 +175,7 @@ files:
 - lib/rubocop/ast/node/mixin/method_dispatch_node.rb
 - lib/rubocop/ast/node/mixin/method_identifier_predicates.rb
 - lib/rubocop/ast/node/mixin/modifier_node.rb
+- lib/rubocop/ast/node/mixin/numeric_node.rb
 - lib/rubocop/ast/node/mixin/parameterized_node.rb
 - lib/rubocop/ast/node/mixin/predicate_operator_node.rb
 - lib/rubocop/ast/node/module_node.rb
@@ -213,7 +202,9 @@ files:
 - lib/rubocop/config.rb
 - lib/rubocop/config_loader.rb
 - lib/rubocop/config_loader_resolver.rb
+- lib/rubocop/config_obsoletion.rb
 - lib/rubocop/config_store.rb
+- lib/rubocop/config_validator.rb
 - lib/rubocop/cop/autocorrect_logic.rb
 - lib/rubocop/cop/badge.rb
 - lib/rubocop/cop/bundler/duplicated_gem.rb
@@ -242,6 +233,7 @@ files:
 - lib/rubocop/cop/gemspec/duplicated_assignment.rb
 - lib/rubocop/cop/gemspec/ordered_dependencies.rb
 - lib/rubocop/cop/gemspec/required_ruby_version.rb
+- lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb
 - lib/rubocop/cop/generator.rb
 - lib/rubocop/cop/generator/configuration_injector.rb
 - lib/rubocop/cop/generator/require_file_injector.rb
@@ -397,6 +389,7 @@ files:
 - lib/rubocop/cop/lint/safe_navigation_consistency.rb
 - lib/rubocop/cop/lint/safe_navigation_with_empty.rb
 - lib/rubocop/cop/lint/script_permission.rb
+- lib/rubocop/cop/lint/send_with_mixin_argument.rb
 - lib/rubocop/cop/lint/shadowed_argument.rb
 - lib/rubocop/cop/lint/shadowed_exception.rb
 - lib/rubocop/cop/lint/shadowing_outer_local_variable.rb
@@ -432,6 +425,7 @@ files:
 - lib/rubocop/cop/metrics/parameter_lists.rb
 - lib/rubocop/cop/metrics/perceived_complexity.rb
 - lib/rubocop/cop/metrics/utils/abc_size_calculator.rb
+- lib/rubocop/cop/migration/department_name.rb
 - lib/rubocop/cop/mixin/alignment.rb
 - lib/rubocop/cop/mixin/annotation_comment.rb
 - lib/rubocop/cop/mixin/array_min_size.rb
@@ -456,10 +450,10 @@ files:
 - lib/rubocop/cop/mixin/frozen_string_literal.rb
 - lib/rubocop/cop/mixin/hash_alignment.rb
 - lib/rubocop/cop/mixin/heredoc.rb
-- lib/rubocop/cop/mixin/ignored_method_patterns.rb
 - lib/rubocop/cop/mixin/ignored_methods.rb
 - lib/rubocop/cop/mixin/ignored_pattern.rb
 - lib/rubocop/cop/mixin/integer_node.rb
+- lib/rubocop/cop/mixin/interpolation.rb
 - lib/rubocop/cop/mixin/match_range.rb
 - lib/rubocop/cop/mixin/method_complexity.rb
 - lib/rubocop/cop/mixin/method_preference.rb
@@ -488,7 +482,6 @@ files:
 - lib/rubocop/cop/mixin/string_help.rb
 - lib/rubocop/cop/mixin/string_literals_help.rb
 - lib/rubocop/cop/mixin/surrounding_space.rb
-- lib/rubocop/cop/mixin/target_rails_version.rb
 - lib/rubocop/cop/mixin/target_ruby_version.rb
 - lib/rubocop/cop/mixin/too_many_lines.rb
 - lib/rubocop/cop/mixin/trailing_body.rb
@@ -512,57 +505,6 @@ files:
 - lib/rubocop/cop/naming/variable_name.rb
 - lib/rubocop/cop/naming/variable_number.rb
 - lib/rubocop/cop/offense.rb
-- lib/rubocop/cop/rails/action_filter.rb
-- lib/rubocop/cop/rails/active_record_aliases.rb
-- lib/rubocop/cop/rails/active_record_override.rb
-- lib/rubocop/cop/rails/active_support_aliases.rb
-- lib/rubocop/cop/rails/application_job.rb
-- lib/rubocop/cop/rails/application_record.rb
-- lib/rubocop/cop/rails/assert_not.rb
-- lib/rubocop/cop/rails/belongs_to.rb
-- lib/rubocop/cop/rails/blank.rb
-- lib/rubocop/cop/rails/bulk_change_table.rb
-- lib/rubocop/cop/rails/create_table_with_timestamps.rb
-- lib/rubocop/cop/rails/date.rb
-- lib/rubocop/cop/rails/delegate.rb
-- lib/rubocop/cop/rails/delegate_allow_blank.rb
-- lib/rubocop/cop/rails/dynamic_find_by.rb
-- lib/rubocop/cop/rails/enum_uniqueness.rb
-- lib/rubocop/cop/rails/environment_comparison.rb
-- lib/rubocop/cop/rails/exit.rb
-- lib/rubocop/cop/rails/file_path.rb
-- lib/rubocop/cop/rails/find_by.rb
-- lib/rubocop/cop/rails/find_each.rb
-- lib/rubocop/cop/rails/has_and_belongs_to_many.rb
-- lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb
-- lib/rubocop/cop/rails/http_positional_arguments.rb
-- lib/rubocop/cop/rails/http_status.rb
-- lib/rubocop/cop/rails/ignored_skip_action_filter_option.rb
-- lib/rubocop/cop/rails/inverse_of.rb
-- lib/rubocop/cop/rails/lexically_scoped_action_filter.rb
-- lib/rubocop/cop/rails/link_to_blank.rb
-- lib/rubocop/cop/rails/not_null_column.rb
-- lib/rubocop/cop/rails/output.rb
-- lib/rubocop/cop/rails/output_safety.rb
-- lib/rubocop/cop/rails/pluralization_grammar.rb
-- lib/rubocop/cop/rails/presence.rb
-- lib/rubocop/cop/rails/present.rb
-- lib/rubocop/cop/rails/read_write_attribute.rb
-- lib/rubocop/cop/rails/redundant_allow_nil.rb
-- lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb
-- lib/rubocop/cop/rails/reflection_class_name.rb
-- lib/rubocop/cop/rails/refute_methods.rb
-- lib/rubocop/cop/rails/relative_date_constant.rb
-- lib/rubocop/cop/rails/request_referer.rb
-- lib/rubocop/cop/rails/reversible_migration.rb
-- lib/rubocop/cop/rails/safe_navigation.rb
-- lib/rubocop/cop/rails/save_bang.rb
-- lib/rubocop/cop/rails/scope_args.rb
-- lib/rubocop/cop/rails/skips_model_validations.rb
-- lib/rubocop/cop/rails/time_zone.rb
-- lib/rubocop/cop/rails/uniq_before_pluck.rb
-- lib/rubocop/cop/rails/unknown_env.rb
-- lib/rubocop/cop/rails/validation.rb
 - lib/rubocop/cop/registry.rb
 - lib/rubocop/cop/security/eval.rb
 - lib/rubocop/cop/security/json_load.rb
@@ -602,6 +544,7 @@ files:
 - lib/rubocop/cop/style/dir.rb
 - lib/rubocop/cop/style/documentation.rb
 - lib/rubocop/cop/style/documentation_method.rb
+- lib/rubocop/cop/style/double_cop_disable_directive.rb
 - lib/rubocop/cop/style/double_negation.rb
 - lib/rubocop/cop/style/each_for_simple_loop.rb
 - lib/rubocop/cop/style/each_with_object.rb
@@ -616,6 +559,7 @@ files:
 - lib/rubocop/cop/style/eval_with_location.rb
 - lib/rubocop/cop/style/even_odd.rb
 - lib/rubocop/cop/style/expand_path_arguments.rb
+- lib/rubocop/cop/style/float_division.rb
 - lib/rubocop/cop/style/for.rb
 - lib/rubocop/cop/style/format_string.rb
 - lib/rubocop/cop/style/format_string_token.rb
@@ -653,6 +597,7 @@ files:
 - lib/rubocop/cop/style/multiline_memoization.rb
 - lib/rubocop/cop/style/multiline_method_signature.rb
 - lib/rubocop/cop/style/multiline_ternary_operator.rb
+- lib/rubocop/cop/style/multiline_when_then.rb
 - lib/rubocop/cop/style/multiple_comparison.rb
 - lib/rubocop/cop/style/mutable_constant.rb
 - lib/rubocop/cop/style/negated_if.rb
@@ -739,6 +684,7 @@ files:
 - lib/rubocop/cop/style/zero_length_predicate.rb
 - lib/rubocop/cop/team.rb
 - lib/rubocop/cop/util.rb
+- lib/rubocop/cop/utils/format_string.rb
 - lib/rubocop/cop/variable_force.rb
 - lib/rubocop/cop/variable_force/assignment.rb
 - lib/rubocop/cop/variable_force/branch.rb
@@ -763,6 +709,7 @@ files:
 - lib/rubocop/formatter/html_formatter.rb
 - lib/rubocop/formatter/json_formatter.rb
 - lib/rubocop/formatter/offense_count_formatter.rb
+- lib/rubocop/formatter/pacman_formatter.rb
 - lib/rubocop/formatter/progress_formatter.rb
 - lib/rubocop/formatter/quiet_formatter.rb
 - lib/rubocop/formatter/simple_text_formatter.rb
@@ -783,7 +730,6 @@ files:
 - lib/rubocop/rspec/expect_offense.rb
 - lib/rubocop/rspec/host_environment_simulation_helper.rb
 - lib/rubocop/rspec/shared_contexts.rb
-- lib/rubocop/rspec/shared_examples.rb
 - lib/rubocop/rspec/support.rb
 - lib/rubocop/runner.rb
 - lib/rubocop/string_interpreter.rb

data/lib/rubocop/cop/mixin/ignored_method_patterns.rb

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    # This module encapsulates the ability to ignore certain methods when
-    # parsing using regex patterns.
-    module IgnoredMethodPatterns
-      private
-
-      def ignored_method_pattern?(name)
-        ignored_method_patterns.any? { |pattern| Regexp.new(pattern) =~ name }
-      end
-
-      def ignored_method_patterns
-        cop_config.fetch('IgnoredMethodPatterns', [])
-      end
-    end
-  end
-end