rubocop 0.6.1 → 0.7.0

data/lib/rubocop/cop/unless_else.rb

@@ -8,7 +8,7 @@ module Rubocop
 
       def inspect(file, source, tokens, sexp)
         each(:unless, sexp) do |unless_sexp|
-          if unless_sexp.compact.find { |s| s[0] == :else }
+          if unless_sexp.compact.any? { |s| s[0] == :else }
             add_offence(:convention, all_positions(unless_sexp).first.lineno,
                         ERROR_MESSAGE)
           end

data/lib/rubocop/cop/variable_interpolation.rb

@@ -5,8 +5,9 @@ module Rubocop
     class VariableInterpolation < Cop
       def inspect(file, source, tokens, sexp)
         each(:string_dvar, sexp) do |s|
-          var = s[1][1][1]
-          lineno = s[1][1][2].lineno
+          interpolation = s[1][0] == :@backref ? s[1] : s[1][1]
+          var = interpolation[1]
+          lineno = interpolation[2].lineno
 
           add_offence(
             :convention,

data/lib/rubocop/cop/word_array.rb

@@ -0,0 +1,38 @@
+# encoding: utf-8
+
+module Rubocop
+  module Cop
+    class WordArray < Cop
+      ERROR_MESSAGE = 'Use %w or %W for array of words.'
+
+      def inspect(file, source, tokens, sexp)
+        each(:array, sexp) do |s|
+          array_elems = s[1]
+
+          # no need to check empty arrays
+          return unless array_elems && array_elems.size > 1
+
+          string_array = array_elems.all? { |e| e[0] == :string_literal }
+
+          if string_array && !complex_content?(array_elems)
+            add_offence(:convention,
+                        all_positions(s).first.lineno,
+                        ERROR_MESSAGE)
+          end
+        end
+      end
+
+      def complex_content?(arr_sexp)
+        non_empty_strings = 0
+
+        each(:@tstring_content, arr_sexp) do |content|
+          non_empty_strings += 1
+          return true unless content[1] =~ /\A[\w-]+\z/
+        end
+
+        # check for '' strings in the array
+        non_empty_strings == arr_sexp.size ? false : true
+      end
+    end
+  end
+end

data/lib/rubocop/version.rb

@@ -2,6 +2,6 @@
 
 module Rubocop
   module Version
-    STRING = '0.6.1'
+    STRING = '0.7.0'
   end
 end

data/rubocop.gemspec

@@ -9,7 +9,11 @@ Gem::Specification.new do |s|
   s.required_ruby_version = '>= 1.9.2'
   s.authors = ['Bozhidar Batsov']
   s.date = '2013-04-17'
-  s.description = 'Automatic Ruby code style checking tool. Aims to enforce the community-driven Ruby Style Guide.'
+  s.description = <<-EOF
+    Automatic Ruby code style checking tool.
+    Aims to enforce the community-driven Ruby Style Guide.
+  EOF
+
   s.email = 'bozhidar@batsov.com'
   s.executables = ['rubocop']
   s.extra_rdoc_files = ['LICENSE.txt', 'README.md']
@@ -33,10 +37,10 @@ Gem::Specification.new do |s|
   s.rubygems_version = '1.8.23'
   s.summary = 'Automatic Ruby code style checking tool.'
 
-  s.add_runtime_dependency(%q<rainbow>, '>= 1.1.4')
-  s.add_development_dependency(%q<rake>, '~> 10.0')
-  s.add_development_dependency(%q<rspec>, '~> 2.13')
-  s.add_development_dependency(%q<yard>, '~> 0.8')
-  s.add_development_dependency(%q<bundler>, '~> 1.3')
-  s.add_development_dependency(%q<simplecov>, '~> 0.7')
+  s.add_runtime_dependency('rainbow', '>= 1.1.4')
+  s.add_development_dependency('rake', '~> 10.0')
+  s.add_development_dependency('rspec', '~> 2.13')
+  s.add_development_dependency('yard', '~> 0.8')
+  s.add_development_dependency('bundler', '~> 1.3')
+  s.add_development_dependency('simplecov', '~> 0.7')
 end

data/spec/project_spec.rb

@@ -0,0 +1,27 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe 'RuboCop Project' do
+  describe '.rubocop.yml' do
+    it 'has configuration for all cops' do
+      cop_names = Rubocop::Cop::Cop.all.map(&:cop_name)
+      expect(Rubocop::Config.load_file('.rubocop.yml').keys.sort)
+        .to eq((['AllCops'] + cop_names).sort)
+    end
+  end
+
+  describe 'source codes' do
+    before { $stdout = StringIO.new }
+    after  { $stdout = STDOUT }
+
+    it 'has no violations' do
+      # Need to pass an empty array explicitly
+      # so that the CLI does not refer arguments of `rspec`
+      Rubocop::CLI.new.run([])
+      expect($stdout.string).to match(
+        /files inspected, no offences detected\n/
+      )
+    end
+  end
+end

data/spec/rubocop/cli_spec.rb

@@ -5,537 +5,599 @@ require 'tmpdir'
 require 'spec_helper'
 
 module Rubocop
-  module Report
-    describe CLI do
-      let(:cli) { CLI.new }
-      before(:each) { $stdout = StringIO.new }
-      after(:each) { $stdout = STDOUT }
-
-      it 'exits cleanly when -h is used' do
-        expect { cli.run ['-h'] }.to exit_with_code(0)
-        expect { cli.run ['--help'] }.to exit_with_code(0)
-        message = ['Usage: rubocop [options] [file1, file2, ...]',
-                   '    -d, --debug                      Display debug info',
-                   '    -e, --emacs                      Emacs style output',
-                   '    -c, --config FILE                Configuration file',
-                   '    -s, --silent                     Silence summary',
-                   '    -n, --no-color                   Disable color output',
-                   '    -v, --version                    Display version']
-        expect($stdout.string).to eq((message * 2).join("\n") + "\n")
-      end
+  describe CLI, :isolated_environment do
+    include FileHelper
+
+    let(:cli) { CLI.new }
+    before(:each) { $stdout = StringIO.new }
+    after(:each) { $stdout = STDOUT }
+
+    it 'exits cleanly when -h is used' do
+      expect { cli.run ['-h'] }.to exit_with_code(0)
+      expect { cli.run ['--help'] }.to exit_with_code(0)
+      message = ['Usage: rubocop [options] [file1, file2, ...]',
+                 '    -d, --debug                      Display debug info',
+                 '    -e, --emacs                      Emacs style output',
+                 '    -c, --config FILE                Configuration file',
+                 '        --only COP                   Run just one cop',
+                 '    -s, --silent                     Silence summary',
+                 '    -n, --no-color                   Disable color output',
+                 '    -v, --version                    Display version']
+      expect($stdout.string).to eq((message * 2).join("\n") + "\n")
+    end
 
-      it 'exits cleanly when -v is used' do
-        expect { cli.run ['-v'] }.to exit_with_code(0)
-        expect { cli.run ['--version'] }.to exit_with_code(0)
-        expect($stdout.string).to eq((Rubocop::Version::STRING + "\n") * 2)
-      end
+    it 'exits cleanly when -v is used' do
+      expect { cli.run ['-v'] }.to exit_with_code(0)
+      expect { cli.run ['--version'] }.to exit_with_code(0)
+      expect($stdout.string).to eq((Rubocop::Version::STRING + "\n") * 2)
+    end
 
-      describe '#wants_to_quit?' do
-        it 'is initially false' do
-          expect(cli.wants_to_quit?).to be_false
-        end
+    describe '#wants_to_quit?' do
+      it 'is initially false' do
+        expect(cli.wants_to_quit?).to be_false
       end
+    end
 
-      context 'when interrupted with Ctrl-C' do
-        def execute_rubocop
-          project_root = File.expand_path('../..', File.dirname(__FILE__))
-          rubocop_command = File.join(project_root, 'bin', 'rubocop')
-
-          _, stdout, stderr, thread = Open3.popen3(rubocop_command, '--debug')
-
-          unless IO.select([stdout], nil, nil, 10)
-            fail 'rubocop took too long to start running'
-          end
+    context 'when interrupted with Ctrl-C' do
+      before do
+        @interrupt_handlers = []
+        Signal.stub(:trap).with('INT') do |&block|
+          @interrupt_handlers << block
+        end
 
-          yield stdout, stderr, thread.pid
+        $stderr = StringIO.new
 
-          thread.value.exitstatus
-        ensure
-          thread.terminate
-        end
+        create_file('example.rb', '# encoding: utf-8')
+      end
 
-        def wait_for_output(output)
-          IO.select([output], nil, nil, 10)
-        end
+      after do
+        $stderr = STDERR
+        @cli_thread.terminate if @cli_thread
+      end
 
-        it 'exits with status 1' do
-          exit_status = execute_rubocop do |stdout, stderr, pid|
-            Process.kill('INT', pid)
-          end
-          expect(exit_status).to eq(1)
-        end
+      def interrupt
+        @interrupt_handlers.each(&:call)
+      end
 
-        it 'exits gracefully without dumping backtraces' do
-          execute_rubocop do |stdout, stderr, pid|
-            Process.kill('INT', pid)
-            wait_for_output(stderr)
-            expect(stderr.read).not_to match(/from .+:\d+:in /)
-          end
+      def cli_run_in_thread
+        @cli_thread = Thread.new do
+          cli.run(['--debug'])
         end
 
-        context 'with Ctrl-C once' do
-          it 'reports summary' do
-            execute_rubocop do |stdout, stderr, pid|
-              Process.kill('INT', pid)
-              wait_for_output(stdout)
-              output = stdout.read
-              expect(output).to match(/files? inspected/)
-            end
-          end
-        end
+        # Wait for start.
+        loop { break unless $stdout.string.empty? }
 
-        context 'with Ctrl-C twice' do
-          it 'exits immediately without reporting summary' do
-            execute_rubocop do |stdout, stderr, pid|
-              Process.kill('INT', pid)
-              wait_for_output(stderr) # Wait for "Exiting...".
-              Process.kill('INT', pid)
-              wait_for_output(stdout)
-              output = stdout.read
-              expect(output).not_to match(/files? inspected/)
-            end
-          end
-        end
+        @cli_thread
       end
 
-      it 'checks a given correct file and returns 0' do
-        File.open('example.rb', 'w') do |f|
-          f.puts '# encoding: utf-8'
-          f.puts 'x = 0'
-          f.puts 'puts x'
-        end
-        begin
-          expect(cli.run(['example.rb'])).to eq(0)
-          expect($stdout.string)
-            .to eq("\n1 file inspected, no offences detected\n")
-        ensure
-          File.delete 'example.rb'
-        end
+      it 'exits with status 1' do
+        cli_thread = cli_run_in_thread
+        interrupt
+        expect(cli_thread.value).to eq(1)
       end
 
-      it 'checks a given file with faults and returns 1' do
-        File.open('example.rb', 'w') do |f|
-          f.puts '# encoding: utf-8'
-          f.puts 'x = 0 '
-          f.puts 'puts x'
-        end
-        begin
-          expect(cli.run(['example.rb'])).to eq(1)
-          expect($stdout.string)
-            .to eq ['== example.rb ==',
-                    'C:  2: Trailing whitespace detected.',
-                    '',
-                    '1 file inspected, 1 offence detected',
-                    ''].join("\n")
-        ensure
-          File.delete 'example.rb'
-        end
+      it 'exits gracefully without dumping backtraces' do
+        cli_thread = cli_run_in_thread
+        interrupt
+        cli_thread.join
+        expect($stderr.string).not_to match(/from .+:\d+:in /)
       end
 
-      it 'can report in emacs style', ruby: 1.9 do
-        File.open('example1.rb', 'w') { |f| f.puts 'x= 0 ', 'y ', 'puts x' }
-        File.open('example2.rb', 'w') { |f| f.puts "\tx = 0", 'puts x' }
-        begin
-          expect(cli.run(['--emacs', 'example1.rb', 'example2.rb'])).to eq(1)
-          expect($stdout.string)
-            .to eq(
-            ['example1.rb:1: C: Missing utf-8 encoding comment.',
-             'example1.rb:1: C: Trailing whitespace detected.',
-             "example1.rb:1: C: Surrounding space missing for operator '='.",
-             'example1.rb:2: C: Trailing whitespace detected.',
-             'example2.rb:1: C: Missing utf-8 encoding comment.',
-             'example2.rb:1: C: Tab detected.',
-             '',
-             '2 files inspected, 6 offences detected',
-             ''].join("\n"))
-        ensure
-          File.delete 'example1.rb'
-          File.delete 'example2.rb'
+      context 'with Ctrl-C once' do
+        it 'reports summary' do
+          cli_thread = cli_run_in_thread
+          interrupt
+          cli_thread.join
+          expect($stdout.string).to match(/files? inspected/)
         end
       end
 
-      it 'can report in emacs style', ruby: 2.0 do
-        File.open('example1.rb', 'w') { |f| f.puts 'x= 0 ', 'y ', 'puts x' }
-        File.open('example2.rb', 'w') { |f| f.puts "\tx = 0", 'puts x' }
-        begin
-          expect(cli.run(['--emacs', 'example1.rb', 'example2.rb'])).to eq(1)
-          expect($stdout.string)
-            .to eq(
-            ['example1.rb:1: C: Trailing whitespace detected.',
-             "example1.rb:1: C: Surrounding space missing for operator '='.",
-             'example1.rb:2: C: Trailing whitespace detected.',
-             'example2.rb:1: C: Tab detected.',
-             '',
-             '2 files inspected, 4 offences detected',
-             ''].join("\n"))
-        ensure
-          File.delete 'example1.rb'
-          File.delete 'example2.rb'
+      context 'with Ctrl-C twice' do
+        it 'exits immediately' do
+          Object.any_instance.should_receive(:exit!).with(1)
+          cli_thread = cli_run_in_thread
+          interrupt
+          interrupt
+          cli_thread.join
         end
       end
+    end
 
-      it 'ommits summary when --silent passed', ruby: 1.9 do
-        File.open('example1.rb', 'w') { |f| f.puts 'puts 0 ' }
-        File.open('example2.rb', 'w') { |f| f.puts "\tputs 0" }
-        begin
-          expect(cli.run(['--emacs',
-                          '--silent',
-                          'example1.rb',
-                          'example2.rb'])).to eq(1)
-          expect($stdout.string).to eq(
-            ['example1.rb:1: C: Missing utf-8 encoding comment.',
-             'example1.rb:1: C: Trailing whitespace detected.',
-             'example2.rb:1: C: Missing utf-8 encoding comment.',
-             'example2.rb:1: C: Tab detected.',
-             ''].join("\n"))
-        ensure
-          File.delete 'example1.rb'
-          File.delete 'example2.rb'
-        end
-      end
+    it 'checks a given correct file and returns 0' do
+      create_file('example.rb', [
+        '# encoding: utf-8',
+        'x = 0',
+        'puts x'
+      ])
+      expect(cli.run(['example.rb'])).to eq(0)
+      expect($stdout.string)
+        .to eq("\n1 file inspected, no offences detected\n")
+    end
 
-      it 'ommits summary when --silent passed', ruby: 2.0 do
-        File.open('example1.rb', 'w') { |f| f.puts 'puts 0 ' }
-        File.open('example2.rb', 'w') { |f| f.puts "\tputs 0" }
-        begin
-          expect(cli.run(['--emacs',
-                          '--silent',
-                          'example1.rb',
-                          'example2.rb'])).to eq(1)
-          expect($stdout.string).to eq(
-            ['example1.rb:1: C: Trailing whitespace detected.',
-             'example2.rb:1: C: Tab detected.',
-             ''].join("\n"))
-        ensure
-          File.delete 'example1.rb'
-          File.delete 'example2.rb'
-        end
-      end
+    it 'checks a given file with faults and returns 1' do
+      create_file('example.rb', [
+        '# encoding: utf-8',
+        'x = 0 ',
+        'puts x'
+      ])
+      expect(cli.run(['example.rb'])).to eq(1)
+      expect($stdout.string)
+        .to eq ['== example.rb ==',
+                'C:  2: Trailing whitespace detected.',
+                '',
+                '1 file inspected, 1 offence detected',
+                ''].join("\n")
+    end
 
-      it 'shows cop names when --debug is passed', ruby: 2.0 do
-        File.open('example1.rb', 'w') { |f| f.puts "\tputs 0" }
-        begin
-          expect(cli.run(['--emacs',
-                          '--silent',
-                          '--debug',
-                          'example1.rb'])).to eq(1)
-          expect($stdout.string.lines[-1]).to eq(
-            ['example1.rb:1: C: Tab: Tab detected.',
-             ''].join("\n"))
-        ensure
-          File.delete 'example1.rb'
-        end
-      end
+    it 'can report in emacs style', ruby: 1.9 do
+      create_file('example1.rb', [
+        'x= 0 ',
+        'y ',
+        'puts x'
+      ])
+      create_file('example2.rb', [
+        "\tx = 0",
+        'puts x'
+      ])
+      expect(cli.run(['--emacs', 'example1.rb', 'example2.rb'])).to eq(1)
+      expect($stdout.string)
+        .to eq(
+        ['example1.rb:1: C: Missing utf-8 encoding comment.',
+         'example1.rb:1: C: Trailing whitespace detected.',
+         "example1.rb:1: C: Surrounding space missing for operator '='.",
+         'example1.rb:2: C: Trailing whitespace detected.',
+         'example2.rb:1: C: Missing utf-8 encoding comment.',
+         'example2.rb:1: C: Tab detected.',
+         '',
+         '2 files inspected, 6 offences detected',
+         ''].join("\n"))
+    end
 
-      it 'can be configured with option to disable a certain error' do
-        File.open('example1.rb', 'w') { |f| f.puts 'puts 0 ' }
-        File.open('rubocop.yml', 'w') do |f|
-          f.puts('Encoding:',
-                 '  Enabled: false',
-                 '',
-                 'Indentation:',
-                 '  Enabled: false')
-        end
-        begin
-          expect(cli.run(['-c', 'rubocop.yml', 'example1.rb'])).to eq(1)
-          expect($stdout.string).to eq(
-            ['== example1.rb ==',
-             'C:  1: Trailing whitespace detected.',
-             '',
-             '1 file inspected, 1 offence detected',
-             ''].join("\n"))
-        ensure
-          File.delete 'example1.rb'
-          File.delete 'rubocop.yml'
-        end
-      end
+    it 'can report in emacs style', ruby: 2.0 do
+      create_file('example1.rb', [
+        'x= 0 ',
+        'y ',
+        'puts x'
+      ])
+      create_file('example2.rb', [
+        "\tx = 0",
+        'puts x'
+      ])
+      expect(cli.run(['--emacs', 'example1.rb', 'example2.rb'])).to eq(1)
+      expect($stdout.string)
+        .to eq(
+        ['example1.rb:1: C: Trailing whitespace detected.',
+         "example1.rb:1: C: Surrounding space missing for operator '='.",
+         'example1.rb:2: C: Trailing whitespace detected.',
+         'example2.rb:1: C: Tab detected.',
+         '',
+         '2 files inspected, 4 offences detected',
+         ''].join("\n"))
+    end
 
-      it 'can be configured with project config to disable a certain error' do
-        FileUtils.mkdir 'example_src'
-        File.open('example_src/example1.rb', 'w') { |f| f.puts 'puts 0 ' }
-        File.open('example_src/.rubocop.yml', 'w') do |f|
-          f.puts('Encoding:',
-                 '  Enabled: false',
-                 '',
-                 'Indentation:',
-                 '  Enabled: false')
-        end
-        begin
-          expect(cli.run(['example_src/example1.rb'])).to eq(1)
-          expect($stdout.string).to eq(
-            ['== example_src/example1.rb ==',
-             'C:  1: Trailing whitespace detected.',
-             '',
-             '1 file inspected, 1 offence detected',
-             ''].join("\n"))
-        ensure
-          FileUtils.rm_rf 'example_src'
-        end
-      end
+    it 'runs just one cop if --only is passed' do
+      create_file('example.rb', [
+        'x= 0 ',
+        'y '
+      ])
+      expect(cli.run(['--only', 'TrailingWhitespace', 'example.rb'])).to eq(1)
+      expect($stdout.string)
+        .to eq(['== example.rb ==',
+                'C:  1: Trailing whitespace detected.',
+                'C:  2: Trailing whitespace detected.',
+                '',
+                '1 file inspected, 2 offences detected',
+                ''].join("\n"))
+    end
 
-      it 'can use an alternative max line length from a config file' do
-        FileUtils.mkdir 'example_src'
-        File.open('example_src/example1.rb', 'w') do |f|
-          f.puts '# encoding: utf-8'
-          f.puts '#' * 90
-        end
-        File.open('example_src/.rubocop.yml', 'w') do |f|
-          f.puts('LineLength:',
-                 '  Enabled: true',
-                 '  Max: 100')
-        end
-        begin
-          expect(cli.run(['example_src/example1.rb'])).to eq(0)
-          expect($stdout.string).to eq(
-            ['', '1 file inspected, no offences detected',
-             ''].join("\n"))
-        ensure
-          FileUtils.rm_rf 'example_src'
-        end
-      end
+    it 'exits with error if an incorrect cop name is passed to --only' do
+      expect(cli.run(['--only', '123'])).to eq(1)
+      expect($stdout.string).to eq("Unrecognized cop name: 123.\n")
+    end
 
-      it 'can have different config files in different directories' do
-        %w(src lib).each do |dir|
-          FileUtils.mkdir_p "example/#{dir}"
-          File.open("example/#{dir}/example1.rb", 'w') do |f|
-            f.puts '# encoding: utf-8'
-            f.puts '#' * 90
-          end
-        end
-        File.open('example/src/.rubocop.yml', 'w') do |f|
-          f.puts('LineLength:',
-                 '  Enabled: true',
-                 '  Max: 100')
-        end
-        begin
-          expect(cli.run(['example'])).to eq(1)
-          expect($stdout.string).to eq(
-            ['== example/lib/example1.rb ==',
-             'C:  2: Line is too long. [90/79]',
-             '',
-             '2 files inspected, 1 offence detected',
-             ''].join("\n"))
-        ensure
-          FileUtils.rm_rf 'example'
-        end
-      end
+    it 'ommits summary when --silent passed', ruby: 1.9 do
+      create_file('example1.rb', 'puts 0 ')
+      create_file('example2.rb', "\tputs 0")
+      expect(cli.run(['--emacs',
+                      '--silent',
+                      'example1.rb',
+                      'example2.rb'])).to eq(1)
+      expect($stdout.string).to eq(
+        ['example1.rb:1: C: Missing utf-8 encoding comment.',
+         'example1.rb:1: C: Trailing whitespace detected.',
+         'example2.rb:1: C: Missing utf-8 encoding comment.',
+         'example2.rb:1: C: Tab detected.',
+         ''].join("\n"))
+    end
 
-      it 'prefers a config file in ancestor directory to another in home' do
-        FileUtils.mkdir 'example_src'
-        File.open('example_src/example1.rb', 'w') do |f|
-          f.puts '# encoding: utf-8'
-          f.puts '#' * 90
-        end
-        File.open('example_src/.rubocop.yml', 'w') do |f|
-          f.puts('LineLength:',
-                 '  Enabled: true',
-                 '  Max: 100')
-        end
-        Dir.mktmpdir do |tmpdir|
-          @original_home = ENV['HOME']
-          ENV['HOME'] = tmpdir
-          File.open("#{Dir.home}/.rubocop.yml", 'w') do |f|
-            f.puts('LineLength:',
-                   '  Enabled: true',
-                   '  Max: 80')
-          end
-          begin
-            expect(cli.run(['example_src/example1.rb'])).to eq(0)
-            expect($stdout.string).to eq(
-              ['', '1 file inspected, no offences detected',
-               ''].join("\n"))
-          ensure
-            FileUtils.rm_rf 'example_src'
-            ENV['HOME'] = @original_home
-          end
-        end
-      end
+    it 'ommits summary when --silent passed', ruby: 2.0 do
+      create_file('example1.rb', 'puts 0 ')
+      create_file('example2.rb', "\tputs 0")
+      expect(cli.run(['--emacs',
+                      '--silent',
+                      'example1.rb',
+                      'example2.rb'])).to eq(1)
+      expect($stdout.string).to eq(
+        ['example1.rb:1: C: Trailing whitespace detected.',
+         'example2.rb:1: C: Tab detected.',
+         ''].join("\n"))
+    end
 
-      it 'finds no violations when checking the rubocop source code' do
-        # Need to pass an empty array explicitly
-        # so that the CLI does not refer arguments of `rspec`
-        cli.run([])
-        expect($stdout.string).to match(
-          /files inspected, no offences detected\n/
-        )
-      end
+    it 'shows cop names when --debug is passed', ruby: 2.0 do
+      create_file('example1.rb', "\tputs 0")
+      expect(cli.run(['--emacs',
+                      '--silent',
+                      '--debug',
+                      'example1.rb'])).to eq(1)
+      expect($stdout.string.lines[-1]).to eq(
+        ['example1.rb:1: C: Tab: Tab detected.',
+         ''].join("\n"))
+    end
 
-      it 'registers an offence for a syntax error' do
-        File.open('example.rb', 'w') do |f|
-          f.puts '# encoding: utf-8'
-          f.puts 'class Test'
-          f.puts 'en'
-        end
-        begin
-          expect(cli.run(['--emacs', 'example.rb'])).to eq(1)
-          unexpected_part = RUBY_VERSION >= '2.0' ? 'end-of-input' : '$end'
-          expect($stdout.string).to eq(
-            ["example.rb:3: E: Syntax error, unexpected #{unexpected_part}, " +
-             'expecting keyword_end',
-             '',
-             '1 file inspected, 1 offence detected',
-             ''].join("\n"))
-        ensure
-          File.delete 'example.rb'
-        end
-      end
+    it 'can be configured with option to disable a certain error' do
+      create_file('example1.rb', 'puts 0 ')
+      create_file('rubocop.yml', [
+        'Encoding:',
+        '  Enabled: false',
+        '',
+        'CaseIndentation:',
+        '  Enabled: false'
+      ])
+      expect(cli.run(['-c', 'rubocop.yml', 'example1.rb'])).to eq(1)
+      expect($stdout.string).to eq(
+        ['== example1.rb ==',
+         'C:  1: Trailing whitespace detected.',
+         '',
+         '1 file inspected, 1 offence detected',
+         ''].join("\n"))
+    end
 
-      it 'can process a file with an invalid UTF-8 byte sequence' do
-        File.open('example.rb', 'w') do |f|
-          f.puts '# encoding: utf-8'
-          f.puts "# \xf9\x29"
-        end
-        begin
-          expect(cli.run(['--emacs', 'example.rb'])).to eq(0)
-        ensure
-          File.delete 'example.rb'
-        end
-      end
+    it 'can be configured with project config to disable a certain error' do
+      create_file('example_src/example1.rb', 'puts 0 ')
+      create_file('example_src/.rubocop.yml', [
+        'Encoding:',
+        '  Enabled: false',
+        '',
+        'CaseIndentation:',
+        '  Enabled: false'
+      ])
+      expect(cli.run(['example_src/example1.rb'])).to eq(1)
+      expect($stdout.string).to eq(
+        ['== example_src/example1.rb ==',
+         'C:  1: Trailing whitespace detected.',
+         '',
+         '1 file inspected, 1 offence detected',
+         ''].join("\n"))
+    end
 
-      it 'has configuration for all cops in .rubocop.yml' do
-        cop_names = Cop::Cop.all.map do |cop_class|
-          cop_class.name.split('::').last
-        end
-        expect(YAML.load_file('.rubocop.yml').keys.sort).to eq(cop_names.sort)
-      end
+    it 'can use an alternative max line length from a config file' do
+      create_file('example_src/example1.rb', [
+        '# encoding: utf-8',
+        '#' * 90
+      ])
+      create_file('example_src/.rubocop.yml', [
+        'LineLength:',
+        '  Enabled: true',
+        '  Max: 100'
+      ])
+      expect(cli.run(['example_src/example1.rb'])).to eq(0)
+      expect($stdout.string).to eq(
+        ['', '1 file inspected, no offences detected',
+         ''].join("\n"))
+    end
 
-      it 'can have all cops disabled in a code section' do
-        File.open('example.rb', 'w') do |f|
-          f.puts '# encoding: utf-8'
-          f.puts '# rubocop:disable all'
-          f.puts '#' * 90
-          f.puts 'x(123456)'
-          f.puts 'y("123")'
-          f.puts 'def func'
-          f.puts '  # rubocop: enable LineLength, StringLiterals'
-          f.puts '  ' + '#' * 93
-          f.puts '  x(123456)'
-          f.puts '  y("123")'
-          f.puts 'end'
-        end
-        begin
-          expect(cli.run(['--emacs', 'example.rb'])).to eq(1)
-          # all cops were disabled, then 2 were enabled again, so we
-          # should get 2 offences reported.
-          expect($stdout.string).to eq(
-            ['example.rb:8: C: Line is too long. [95/79]',
-             "example.rb:10: C: Prefer single-quoted strings when you don't " +
-             'need string interpolation or special symbols.',
-             '',
-             '1 file inspected, 2 offences detected',
-             ''].join("\n"))
-        ensure
-          File.delete 'example.rb'
-        end
+    it 'can have different config files in different directories' do
+      %w(src lib).each do |dir|
+        create_file("example/#{dir}/example1.rb", [
+          '# encoding: utf-8',
+          '#' * 90
+        ])
       end
+      create_file('example/src/.rubocop.yml', [
+        'LineLength:',
+        '  Enabled: true',
+        '  Max: 100'
+      ])
+      expect(cli.run(['example'])).to eq(1)
+      expect($stdout.string).to eq(
+        ['== example/lib/example1.rb ==',
+         'C:  2: Line is too long. [90/79]',
+         '',
+         '2 files inspected, 1 offence detected',
+         ''].join("\n"))
+    end
 
-      it 'can have selected cops disabled in a code section' do
-        File.open('example.rb', 'w') do |f|
-          f.puts '# encoding: utf-8'
-          f.puts '# rubocop:disable LineLength,NumericLiterals,StringLiterals'
-          f.puts '#' * 90
-          f.puts 'x(123456)'
-          f.puts 'y("123")'
-          f.puts 'def func'
-          f.puts '  # rubocop: enable LineLength, StringLiterals'
-          f.puts '  ' + '#' * 93
-          f.puts '  x(123456)'
-          f.puts '  y("123")'
-          f.puts 'end'
-        end
-        begin
-          expect(cli.run(['--emacs', 'example.rb'])).to eq(1)
-          # 3 cops were disabled, then 2 were enabled again, so we
-          # should get 2 offences reported.
-          expect($stdout.string).to eq(
-            ['example.rb:8: C: Line is too long. [95/79]',
-             "example.rb:10: C: Prefer single-quoted strings when you don't " +
-             'need string interpolation or special symbols.',
-             '',
-             '1 file inspected, 2 offences detected',
-             ''].join("\n"))
-        ensure
-          File.delete 'example.rb'
-        end
-      end
+    it 'prefers a config file in ancestor directory to another in home' do
+      create_file('example_src/example1.rb', [
+        '# encoding: utf-8',
+        '#' * 90
+      ])
+      create_file('example_src/.rubocop.yml', [
+        'LineLength:',
+        '  Enabled: true',
+        '  Max: 100'
+      ])
+      create_file("#{Dir.home}/.rubocop.yml", [
+        'LineLength:',
+        '  Enabled: true',
+        '  Max: 80'
+      ])
+      expect(cli.run(['example_src/example1.rb'])).to eq(0)
+      expect($stdout.string).to eq(
+        ['', '1 file inspected, no offences detected',
+         ''].join("\n"))
+    end
 
-      it 'can have all cops disabled on a single line' do
-        File.open('example.rb', 'w') do |f|
-          f.puts '# encoding: utf-8'
-          f.puts 'y("123", 123456) # rubocop:disable all'
-        end
-        begin
-          expect(cli.run(['--emacs', 'example.rb'])).to eq(0)
-          expect($stdout.string).to eq(
-            ['',
-             '1 file inspected, no offences detected',
-             ''].join("\n"))
-        ensure
-          File.delete 'example.rb'
-        end
+    it 'can exclude directories relative to .rubocop.yml' do
+      %w(src etc/test etc/spec tmp/test tmp/spec).each do |dir|
+        create_file("example/#{dir}/example1.rb", [
+          '# encoding: utf-8',
+          '#' * 90
+        ])
       end
 
-      it 'can have selected cops disabled on a single line' do
-        File.open('example.rb', 'w') do |f|
-          f.puts '# encoding: utf-8'
-          f.puts '#' * 90 + ' # rubocop:disable LineLength'
-          f.puts '#' * 95
-          f.puts 'y("123") # rubocop:disable LineLength,StringLiterals'
-        end
-        begin
-          expect(cli.run(['--emacs', 'example.rb'])).to eq(1)
-          expect($stdout.string).to eq(
-            ['example.rb:3: C: Line is too long. [95/79]',
-             '',
-             '1 file inspected, 1 offence detected',
-             ''].join("\n"))
-        ensure
-          File.delete 'example.rb'
-        end
-      end
+      create_file('example/.rubocop.yml', [
+        'AllCops:',
+        '  Excludes:',
+        '    - src/**',
+        '    - etc/**',
+        '    - tmp/spec/**'
+      ])
+
+      expect(cli.run(['example'])).to eq(1)
+      expect($stdout.string).to eq(
+        ['== example/tmp/test/example1.rb ==',
+         'C:  2: Line is too long. [90/79]',
+         '',
+         '1 file inspected, 1 offence detected',
+         ''].join("\n"))
+    end
 
-      it 'finds a file with no .rb extension but has a shebang line' do
-        FileUtils::mkdir 'test'
-        File.open('test/example', 'w') do |f|
-          f.puts '#!/usr/bin/env ruby'
-          f.puts '# encoding: utf-8'
-          f.puts 'x = 0'
-          f.puts 'puts x'
-        end
-        begin
-          FileUtils::cd 'test' do
-            # Need to pass an empty array explicitly
-            # so that the CLI does not refer arguments of `rspec`
-            expect(cli.run([])).to eq(0)
-            expect($stdout.string).to eq(
-              ['', '1 file inspected, no offences detected',
-               ''].join("\n"))
-          end
-        ensure
-          FileUtils::rm_rf 'test'
-        end
-      end
+    it 'prints a warning for an unrecognized cop name in .rubocop.yml' do
+      create_file('example/example1.rb', [
+        '# encoding: utf-8',
+        '#' * 90
+      ])
+
+      create_file('example/.rubocop.yml', [
+        'LyneLenth:',
+        '  Enabled: true',
+        '  Max: 100'
+      ])
+
+      expect(cli.run(['example'])).to eq(1)
+      expect($stdout.string).to eq(
+        ['Warning: unrecognized cop LyneLenth found in ' +
+         File.expand_path('example/.rubocop.yml'),
+         '== example/example1.rb ==',
+         'C:  2: Line is too long. [90/79]',
+         '',
+         '1 file inspected, 1 offence detected',
+         ''].join("\n"))
+    end
 
-      describe '#display_summary' do
-        it 'handles pluralization correctly' do
-          cli.display_summary(1, 0, 0)
-          expect($stdout.string).to eq(
-            "\n1 file inspected, no offences detected\n")
-          $stdout = StringIO.new
-          cli.display_summary(1, 1, 0)
-          expect($stdout.string).to eq(
-            "\n1 file inspected, 1 offence detected\n")
-          $stdout = StringIO.new
-          cli.display_summary(2, 2, 0)
-          expect($stdout.string).to eq(
-            "\n2 files inspected, 2 offences detected\n")
-        end
+    it 'prints a warning for an unrecognized configuration parameter' do
+      create_file('example/example1.rb', [
+        '# encoding: utf-8',
+        '#' * 90
+      ])
+
+      create_file('example/.rubocop.yml', [
+        'LineLength:',
+        '  Enabled: true',
+        '  Min: 10'
+      ])
+
+      expect(cli.run(['example'])).to eq(1)
+      expect($stdout.string).to eq(
+        ['Warning: unrecognized parameter LineLength:Min found in ' +
+         File.expand_path('example/.rubocop.yml'),
+         '== example/example1.rb ==',
+         'C:  2: Line is too long. [90/79]',
+         '',
+         '1 file inspected, 1 offence detected',
+         ''].join("\n"))
+    end
 
-        it 'displays an error message when errors are present' do
-          cli.display_summary(1, 1, 1)
-          expect($stdout.string.lines.to_a[-3])
-            .to eq("1 error occurred.\n")
-        end
+    it 'registers an offence for a syntax error' do
+      create_file('example.rb', [
+        '# encoding: utf-8',
+        'class Test',
+        'en'
+      ])
+      expect(cli.run(['--emacs', 'example.rb'])).to eq(1)
+      unexpected_part = RUBY_VERSION >= '2.0' ? 'end-of-input' : '$end'
+      expect($stdout.string).to eq(
+        ["example.rb:3: E: Syntax error, unexpected #{unexpected_part}, " +
+         'expecting keyword_end',
+         '',
+         '1 file inspected, 1 offence detected',
+         ''].join("\n"))
+    end
+
+    it 'can process a file with an invalid UTF-8 byte sequence' do
+      create_file('example.rb', [
+        '# encoding: utf-8',
+        "# \xf9\x29"
+      ])
+      expect(cli.run(['--emacs', 'example.rb'])).to eq(0)
+    end
+
+    it 'can have all cops disabled in a code section' do
+      create_file('example.rb', [
+        '# encoding: utf-8',
+        '# rubocop:disable all',
+        '#' * 90,
+        'x(123456)',
+        'y("123")',
+        'def func',
+        '  # rubocop: enable LineLength, StringLiterals',
+        '  ' + '#' * 93,
+        '  x(123456)',
+        '  y("123")',
+        'end'
+      ])
+      expect(cli.run(['--emacs', 'example.rb'])).to eq(1)
+      # all cops were disabled, then 2 were enabled again, so we
+      # should get 2 offences reported.
+      expect($stdout.string).to eq(
+        ['example.rb:8: C: Line is too long. [95/79]',
+         "example.rb:10: C: Prefer single-quoted strings when you don't " +
+         'need string interpolation or special symbols.',
+         '',
+         '1 file inspected, 2 offences detected',
+         ''].join("\n"))
+    end
+
+    it 'can have selected cops disabled in a code section' do
+      create_file('example.rb', [
+        '# encoding: utf-8',
+        '# rubocop:disable LineLength,NumericLiterals,StringLiterals',
+        '#' * 90,
+        'x(123456)',
+        'y("123")',
+        'def func',
+        '  # rubocop: enable LineLength, StringLiterals',
+        '  ' + '#' * 93,
+        '  x(123456)',
+        '  y("123")',
+        'end'
+      ])
+      expect(cli.run(['--emacs', 'example.rb'])).to eq(1)
+      # 3 cops were disabled, then 2 were enabled again, so we
+      # should get 2 offences reported.
+      expect($stdout.string).to eq(
+        ['example.rb:8: C: Line is too long. [95/79]',
+         "example.rb:10: C: Prefer single-quoted strings when you don't " +
+         'need string interpolation or special symbols.',
+         '',
+         '1 file inspected, 2 offences detected',
+         ''].join("\n"))
+    end
+
+    it 'can have all cops disabled on a single line' do
+      create_file('example.rb', [
+        '# encoding: utf-8',
+        'y("123", 123456) # rubocop:disable all'
+      ])
+      expect(cli.run(['--emacs', 'example.rb'])).to eq(0)
+      expect($stdout.string).to eq(
+        ['',
+         '1 file inspected, no offences detected',
+         ''].join("\n"))
+    end
+
+    it 'can have selected cops disabled on a single line' do
+      create_file('example.rb', [
+        '# encoding: utf-8',
+        '#' * 90 + ' # rubocop:disable LineLength',
+        '#' * 95,
+        'y("123") # rubocop:disable LineLength,StringLiterals'
+      ])
+      expect(cli.run(['--emacs', 'example.rb'])).to eq(1)
+      expect($stdout.string).to eq(
+        ['example.rb:3: C: Line is too long. [95/79]',
+         '',
+         '1 file inspected, 1 offence detected',
+         ''].join("\n"))
+    end
+
+    it 'finds a file with no .rb extension but has a shebang line' do
+      create_file('example', [
+        '#!/usr/bin/env ruby',
+        '# encoding: utf-8',
+        'x = 0',
+        'puts x'
+      ])
+      # Need to pass an empty array explicitly
+      # so that the CLI does not refer arguments of `rspec`
+      expect(cli.run([])).to eq(0)
+      expect($stdout.string).to eq(
+        ['', '1 file inspected, no offences detected',
+         ''].join("\n"))
+    end
+
+    it 'finds included files' do
+      create_file('example', [
+        '# encoding: utf-8',
+        'x = 0',
+        'puts x'
+      ])
+      create_file('regexp', [
+        '# encoding: utf-8',
+        'x = 0',
+        'puts x'
+      ])
+      create_file('.rubocop.yml', [
+        'AllCops:',
+        '  Includes:',
+        '    - example',
+        '    - !ruby/regexp /regexp$/'
+      ])
+      # Need to pass an empty array explicitly
+      # so that the CLI does not refer arguments of `rspec`
+      expect(cli.run([])).to eq(0)
+      expect($stdout.string).to eq(
+        ['', '2 files inspected, no offences detected',
+         ''].join("\n"))
+    end
+
+    it 'ignores excluded files' do
+      create_file('example.rb', [
+        '# encoding: utf-8',
+        'x = 0',
+        'puts x'
+      ])
+      create_file('regexp.rb', [
+        '# encoding: utf-8',
+        'x = 0',
+        'puts x'
+      ])
+      create_file('exclude_glob.rb', [
+        '#!/usr/bin/env ruby',
+        '# encoding: utf-8',
+        'x = 0',
+        'puts x'
+      ])
+      create_file('.rubocop.yml', [
+        'AllCops:',
+        '  Excludes:',
+        '    - example.rb',
+        '    - !ruby/regexp /regexp.rb$/',
+        '    - "exclude_*"'
+      ])
+      # Need to pass an empty array explicitly
+      # so that the CLI does not refer arguments of `rspec`
+      expect(cli.run([])).to eq(0)
+      expect($stdout.string).to eq(
+        ['', '0 files inspected, no offences detected',
+         ''].join("\n"))
+    end
+
+    describe '#display_summary' do
+      it 'handles pluralization correctly' do
+        cli.display_summary(0, 0, [])
+        expect($stdout.string).to eq(
+          "\n0 files inspected, no offences detected\n")
+        $stdout = StringIO.new
+        cli.display_summary(1, 0, [])
+        expect($stdout.string).to eq(
+          "\n1 file inspected, no offences detected\n")
+        $stdout = StringIO.new
+        cli.display_summary(1, 1, [])
+        expect($stdout.string).to eq(
+          "\n1 file inspected, 1 offence detected\n")
+        $stdout = StringIO.new
+        cli.display_summary(2, 2, [])
+        expect($stdout.string).to eq(
+          "\n2 files inspected, 2 offences detected\n")
+      end
+
+      it 'displays an error message when errors are present' do
+        msg = 'An error occurred while Encoding cop was inspecting file.rb.'
+        cli.display_summary(1, 1, [msg])
+        expect($stdout.string.lines.to_a[-4..-3])
+          .to eq(["1 error occurred:\n", "#{msg}\n"])
       end
     end
   end