rubocop 0.6.1 → 0.7.0

data/spec/rubocop/cops/variable_interpolation_spec.rb

@@ -16,6 +16,15 @@ module Rubocop
           .to eq(['Replace interpolated var $test with expression #{$test}.'])
       end
 
+      it 'registers an offence for interpolated regexp back references' do
+        inspect_source(vi,
+                       'file.rb',
+                       ['puts "this is a #$1"'])
+        expect(vi.offences.size).to eq(1)
+        expect(vi.offences.map(&:message))
+          .to eq(['Replace interpolated var $1 with expression #{$1}.'])
+      end
+
       it 'registers an offence for interpolated instance variables' do
         inspect_source(vi,
                        'file.rb',
@@ -37,7 +46,7 @@ module Rubocop
       it 'does not register an offence for variables in expressions' do
         inspect_source(vi,
                        'file.rb',
-                       ['puts "this is a #{@test}"'])
+                       ['puts "this is a #{@test} #{@@t} #{$t} #{$1}"'])
         expect(vi.offences).to be_empty
       end
     end

data/spec/rubocop/cops/word_array_spec.rb

@@ -0,0 +1,39 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    describe WordArray do
+      let(:wa) { WordArray.new }
+
+      it 'registers an offence for arrays of single quoted strings' do
+        inspect_source(wa,
+                       'file.rb',
+                       ["['one', 'two', 'three']"])
+        expect(wa.offences.size).to eq(1)
+      end
+
+      it 'registers an offence for arrays of double quoted strings' do
+        inspect_source(wa,
+                       'file.rb',
+                       ['["one", "two", "three"]'])
+        expect(wa.offences.size).to eq(1)
+      end
+
+      it 'does not register an offence for array of non-words' do
+        inspect_source(wa,
+                       'file.rb',
+                       ['["one space", "two", "three"]'])
+        expect(wa.offences).to be_empty
+      end
+
+      it 'does not register an offence for array with empty strings' do
+        inspect_source(wa,
+                       'file.rb',
+                       ['["", "two", "three"]'])
+        expect(wa.offences).to be_empty
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,11 +1,17 @@
 # encoding: utf-8
 
-require 'coveralls'
-Coveralls.wear!
-
-if ENV['COVERAGE']
+if ENV['TRAVIS'] || ENV['COVERAGE']
   require 'simplecov'
-  SimpleCov.start
+
+  if ENV['TRAVIS']
+    require 'coveralls'
+    SimpleCov.formatter = Coveralls::SimpleCov::Formatter
+  end
+
+  SimpleCov.start do
+    add_filter '/spec/'
+    add_filter '/vendor/bundle/'
+  end
 end
 
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
@@ -17,10 +23,6 @@ require 'rubocop/cli'
 # disable colors in specs
 Sickill::Rainbow.enabled = false
 
-# Requires supporting files with custom matchers and macros, etc,
-# in ./support/ and its subdirectories.
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
-
 module ExitCodeMatchers
   RSpec::Matchers.define :exit_with_code do |code|
     actual = nil
@@ -47,6 +49,7 @@ end
 
 RSpec.configure do |config|
   config.filter_run_excluding ruby: ->(v) { !RUBY_VERSION.start_with?(v.to_s) }
+  config.treat_symbols_as_metadata_keys_with_true_values = true
 
   config.expect_with :rspec do |c|
     c.syntax = :expect # disables `should`
@@ -55,6 +58,10 @@ RSpec.configure do |config|
   config.include(ExitCodeMatchers)
 end
 
+# Requires supporting files with custom matchers and macros, etc,
+# in ./support/ and its subdirectories.
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
+
 def inspect_source(cop, file, source)
   tokens, sexp, correlations = Rubocop::CLI.rip_source(source)
   cop.correlations = correlations

data/spec/support/file_helper.rb

@@ -0,0 +1,21 @@
+# encoding: utf-8
+
+require 'fileutils'
+
+module FileHelper
+  def create_file(file_path, content)
+    file_path = File.expand_path(file_path)
+
+    dir_path = File.dirname(file_path)
+    FileUtils.makedirs dir_path unless File.exists?(dir_path)
+
+    File.open(file_path, 'w') do |file|
+      case content
+      when String
+        file.puts content
+      when Array
+        file.puts content.join("\n")
+      end
+    end
+  end
+end

data/spec/support/isolated_environment.rb

@@ -0,0 +1,27 @@
+# encoding: utf-8
+
+require 'tmpdir'
+require 'fileutils'
+
+shared_context 'isolated environment', :isolated_environment do
+  around do |example|
+    Dir.mktmpdir do |tmpdir|
+      original_home = ENV['HOME']
+
+      begin
+        virtual_home = File.expand_path(File.join(tmpdir, 'home'))
+        Dir.mkdir(virtual_home)
+        ENV['HOME'] = virtual_home
+
+        working_dir = File.join(tmpdir, 'work')
+        Dir.mkdir(working_dir)
+
+        Dir.chdir(working_dir) do
+          example.run
+        end
+      ensure
+        ENV['HOME'] = original_home
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.7.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -94,8 +94,9 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '0.7'
-description: Automatic Ruby code style checking tool. Aims to enforce the community-driven
-  Ruby Style Guide.
+description: |2
+      Automatic Ruby code style checking tool.
+      Aims to enforce the community-driven Ruby Style Guide.
 email: bozhidar@batsov.com
 executables:
 - rubocop
@@ -117,6 +118,8 @@ files:
 - bin/rubocop
 - rubocop.gemspec
 - lib/rubocop/cli.rb
+- lib/rubocop/config.rb
+- lib/rubocop/config_store.rb
 - lib/rubocop/cop/alias.rb
 - lib/rubocop/cop/align_parameters.rb
 - lib/rubocop/cop/ampersands_pipes_vs_and_or.rb
@@ -125,18 +128,26 @@ files:
 - lib/rubocop/cop/ascii_identifiers.rb
 - lib/rubocop/cop/avoid_class_vars.rb
 - lib/rubocop/cop/avoid_for.rb
+- lib/rubocop/cop/avoid_global_vars.rb
 - lib/rubocop/cop/avoid_perl_backrefs.rb
 - lib/rubocop/cop/avoid_perlisms.rb
+- lib/rubocop/cop/block_comments.rb
 - lib/rubocop/cop/blocks.rb
 - lib/rubocop/cop/brace_after_percent.rb
+- lib/rubocop/cop/case_indentation.rb
 - lib/rubocop/cop/class_and_module_camel_case.rb
+- lib/rubocop/cop/class_methods.rb
 - lib/rubocop/cop/collection_methods.rb
+- lib/rubocop/cop/colon_method_call.rb
 - lib/rubocop/cop/cop.rb
 - lib/rubocop/cop/def_parentheses.rb
+- lib/rubocop/cop/empty_line_between_defs.rb
 - lib/rubocop/cop/empty_lines.rb
 - lib/rubocop/cop/encoding.rb
 - lib/rubocop/cop/end_of_line.rb
 - lib/rubocop/cop/ensure_return.rb
+- lib/rubocop/cop/eval.rb
+- lib/rubocop/cop/favor_join.rb
 - lib/rubocop/cop/favor_modifier.rb
 - lib/rubocop/cop/favor_percent_r.rb
 - lib/rubocop/cop/favor_sprintf.rb
@@ -146,11 +157,13 @@ files:
 - lib/rubocop/cop/hash_literal.rb
 - lib/rubocop/cop/hash_syntax.rb
 - lib/rubocop/cop/if_then_else.rb
-- lib/rubocop/cop/indentation.rb
+- lib/rubocop/cop/leading_comment_space.rb
+- lib/rubocop/cop/line_continuation.rb
 - lib/rubocop/cop/line_length.rb
 - lib/rubocop/cop/method_and_variable_snake_case.rb
 - lib/rubocop/cop/method_length.rb
 - lib/rubocop/cop/new_lambda_literal.rb
+- lib/rubocop/cop/not.rb
 - lib/rubocop/cop/numeric_literals.rb
 - lib/rubocop/cop/offence.rb
 - lib/rubocop/cop/op_method.rb
@@ -162,23 +175,31 @@ files:
 - lib/rubocop/cop/rescue_exception.rb
 - lib/rubocop/cop/rescue_modifier.rb
 - lib/rubocop/cop/semicolon.rb
+- lib/rubocop/cop/single_line_methods.rb
 - lib/rubocop/cop/space_after_comma_etc.rb
+- lib/rubocop/cop/space_after_control_keyword.rb
 - lib/rubocop/cop/string_literals.rb
 - lib/rubocop/cop/surrounding_space.rb
+- lib/rubocop/cop/symbol_array.rb
 - lib/rubocop/cop/symbol_snake_case.rb
 - lib/rubocop/cop/syntax.rb
 - lib/rubocop/cop/tab.rb
 - lib/rubocop/cop/ternary_operator.rb
 - lib/rubocop/cop/trailing_whitespace.rb
+- lib/rubocop/cop/trivial_accessors.rb
 - lib/rubocop/cop/unless_else.rb
 - lib/rubocop/cop/variable_interpolation.rb
 - lib/rubocop/cop/when_then.rb
+- lib/rubocop/cop/word_array.rb
 - lib/rubocop/report/emacs_style.rb
 - lib/rubocop/report/plain_text.rb
 - lib/rubocop/report/report.rb
 - lib/rubocop/version.rb
 - lib/rubocop.rb
+- spec/project_spec.rb
 - spec/rubocop/cli_spec.rb
+- spec/rubocop/config_spec.rb
+- spec/rubocop/config_store_spec.rb
 - spec/rubocop/cops/alias_spec.rb
 - spec/rubocop/cops/align_parameters_spec.rb
 - spec/rubocop/cops/ampersands_pipes_vs_and_or_spec.rb
@@ -187,18 +208,26 @@ files:
 - spec/rubocop/cops/ascii_identifiers_spec.rb
 - spec/rubocop/cops/avoid_class_vars_spec.rb
 - spec/rubocop/cops/avoid_for_spec.rb
+- spec/rubocop/cops/avoid_global_vars.rb
 - spec/rubocop/cops/avoid_perl_backrefs_spec.rb
 - spec/rubocop/cops/avoid_perlisms_spec.rb
+- spec/rubocop/cops/block_comments_spec.rb
 - spec/rubocop/cops/brace_after_percent_spec.rb
+- spec/rubocop/cops/case_indentation_spec.rb
 - spec/rubocop/cops/class_and_module_camel_case_spec.rb
+- spec/rubocop/cops/class_methods_spec.rb
 - spec/rubocop/cops/collection_methods_spec.rb
+- spec/rubocop/cops/colon_method_call_spec.rb
 - spec/rubocop/cops/cop_spec.rb
 - spec/rubocop/cops/def_with_parentheses_spec.rb
 - spec/rubocop/cops/def_without_parentheses_spec.rb
+- spec/rubocop/cops/empty_line_between_defs_spec.rb
 - spec/rubocop/cops/empty_lines_spec.rb
 - spec/rubocop/cops/encoding_spec.rb
 - spec/rubocop/cops/end_of_line_spec.rb
 - spec/rubocop/cops/ensure_return_spec.rb
+- spec/rubocop/cops/eval_spec.rb
+- spec/rubocop/cops/favor_join_spec.rb
 - spec/rubocop/cops/favor_modifier_spec.rb
 - spec/rubocop/cops/favor_percent_r.rb
 - spec/rubocop/cops/favor_sprintf_spec.rb
@@ -209,13 +238,15 @@ files:
 - spec/rubocop/cops/hash_literal_spec.rb
 - spec/rubocop/cops/hash_syntax_spec.rb
 - spec/rubocop/cops/if_with_semicolon_spec.rb
-- spec/rubocop/cops/indentation_spec.rb
+- spec/rubocop/cops/leading_comment_space_spec.rb
+- spec/rubocop/cops/line_continuation_spec.rb
 - spec/rubocop/cops/line_length_spec.rb
 - spec/rubocop/cops/method_and_variable_snake_case_spec.rb
 - spec/rubocop/cops/method_length_spec.rb
 - spec/rubocop/cops/multiline_blocks_spec.rb
 - spec/rubocop/cops/multiline_if_then_spec.rb
 - spec/rubocop/cops/new_lambda_literal_spec.rb
+- spec/rubocop/cops/not_spec.rb
 - spec/rubocop/cops/numeric_literals_spec.rb
 - spec/rubocop/cops/offence_spec.rb
 - spec/rubocop/cops/one_line_conditional_spec.rb
@@ -229,26 +260,34 @@ files:
 - spec/rubocop/cops/rescue_modifier.rb
 - spec/rubocop/cops/semicolon_spec.rb
 - spec/rubocop/cops/single_line_blocks_spec.rb
+- spec/rubocop/cops/single_line_methods_spec.rb
 - spec/rubocop/cops/space_after_colon_spec.rb
 - spec/rubocop/cops/space_after_comma_spec.rb
+- spec/rubocop/cops/space_after_control_keyword_spec.rb
 - spec/rubocop/cops/space_after_semicolon_spec.rb
 - spec/rubocop/cops/space_around_braces_spec.rb
 - spec/rubocop/cops/space_around_equals_in_default_parameter_spec.rb
 - spec/rubocop/cops/space_around_operators_spec.rb
 - spec/rubocop/cops/space_inside_brackets_spec.rb
+- spec/rubocop/cops/space_inside_hash_literal_braces_spec.rb
 - spec/rubocop/cops/space_inside_parens_spec.rb
 - spec/rubocop/cops/string_literals_spec.rb
+- spec/rubocop/cops/symbol_array_spec.rb
 - spec/rubocop/cops/symbol_snake_case_spec.rb
 - spec/rubocop/cops/syntax_spec.rb
 - spec/rubocop/cops/tab_spec.rb
 - spec/rubocop/cops/ternary_operator_spec.rb
 - spec/rubocop/cops/trailing_whitespace_spec.rb
+- spec/rubocop/cops/trivial_accessors_spec.rb
 - spec/rubocop/cops/unless_else_spec.rb
 - spec/rubocop/cops/variable_interpolation_spec.rb
 - spec/rubocop/cops/when_then_spec.rb
+- spec/rubocop/cops/word_array_spec.rb
 - spec/rubocop/reports/emacs_style_spec.rb
 - spec/rubocop/reports/report_spec.rb
 - spec/spec_helper.rb
+- spec/support/file_helper.rb
+- spec/support/isolated_environment.rb
 homepage: http://github.com/bbatsov/rubocop
 licenses:
 - MIT
@@ -274,7 +313,10 @@ signing_key:
 specification_version: 4
 summary: Automatic Ruby code style checking tool.
 test_files:
+- spec/project_spec.rb
 - spec/rubocop/cli_spec.rb
+- spec/rubocop/config_spec.rb
+- spec/rubocop/config_store_spec.rb
 - spec/rubocop/cops/alias_spec.rb
 - spec/rubocop/cops/align_parameters_spec.rb
 - spec/rubocop/cops/ampersands_pipes_vs_and_or_spec.rb
@@ -283,18 +325,26 @@ test_files:
 - spec/rubocop/cops/ascii_identifiers_spec.rb
 - spec/rubocop/cops/avoid_class_vars_spec.rb
 - spec/rubocop/cops/avoid_for_spec.rb
+- spec/rubocop/cops/avoid_global_vars.rb
 - spec/rubocop/cops/avoid_perl_backrefs_spec.rb
 - spec/rubocop/cops/avoid_perlisms_spec.rb
+- spec/rubocop/cops/block_comments_spec.rb
 - spec/rubocop/cops/brace_after_percent_spec.rb
+- spec/rubocop/cops/case_indentation_spec.rb
 - spec/rubocop/cops/class_and_module_camel_case_spec.rb
+- spec/rubocop/cops/class_methods_spec.rb
 - spec/rubocop/cops/collection_methods_spec.rb
+- spec/rubocop/cops/colon_method_call_spec.rb
 - spec/rubocop/cops/cop_spec.rb
 - spec/rubocop/cops/def_with_parentheses_spec.rb
 - spec/rubocop/cops/def_without_parentheses_spec.rb
+- spec/rubocop/cops/empty_line_between_defs_spec.rb
 - spec/rubocop/cops/empty_lines_spec.rb
 - spec/rubocop/cops/encoding_spec.rb
 - spec/rubocop/cops/end_of_line_spec.rb
 - spec/rubocop/cops/ensure_return_spec.rb
+- spec/rubocop/cops/eval_spec.rb
+- spec/rubocop/cops/favor_join_spec.rb
 - spec/rubocop/cops/favor_modifier_spec.rb
 - spec/rubocop/cops/favor_percent_r.rb
 - spec/rubocop/cops/favor_sprintf_spec.rb
@@ -305,13 +355,15 @@ test_files:
 - spec/rubocop/cops/hash_literal_spec.rb
 - spec/rubocop/cops/hash_syntax_spec.rb
 - spec/rubocop/cops/if_with_semicolon_spec.rb
-- spec/rubocop/cops/indentation_spec.rb
+- spec/rubocop/cops/leading_comment_space_spec.rb
+- spec/rubocop/cops/line_continuation_spec.rb
 - spec/rubocop/cops/line_length_spec.rb
 - spec/rubocop/cops/method_and_variable_snake_case_spec.rb
 - spec/rubocop/cops/method_length_spec.rb
 - spec/rubocop/cops/multiline_blocks_spec.rb
 - spec/rubocop/cops/multiline_if_then_spec.rb
 - spec/rubocop/cops/new_lambda_literal_spec.rb
+- spec/rubocop/cops/not_spec.rb
 - spec/rubocop/cops/numeric_literals_spec.rb
 - spec/rubocop/cops/offence_spec.rb
 - spec/rubocop/cops/one_line_conditional_spec.rb
@@ -325,24 +377,32 @@ test_files:
 - spec/rubocop/cops/rescue_modifier.rb
 - spec/rubocop/cops/semicolon_spec.rb
 - spec/rubocop/cops/single_line_blocks_spec.rb
+- spec/rubocop/cops/single_line_methods_spec.rb
 - spec/rubocop/cops/space_after_colon_spec.rb
 - spec/rubocop/cops/space_after_comma_spec.rb
+- spec/rubocop/cops/space_after_control_keyword_spec.rb
 - spec/rubocop/cops/space_after_semicolon_spec.rb
 - spec/rubocop/cops/space_around_braces_spec.rb
 - spec/rubocop/cops/space_around_equals_in_default_parameter_spec.rb
 - spec/rubocop/cops/space_around_operators_spec.rb
 - spec/rubocop/cops/space_inside_brackets_spec.rb
+- spec/rubocop/cops/space_inside_hash_literal_braces_spec.rb
 - spec/rubocop/cops/space_inside_parens_spec.rb
 - spec/rubocop/cops/string_literals_spec.rb
+- spec/rubocop/cops/symbol_array_spec.rb
 - spec/rubocop/cops/symbol_snake_case_spec.rb
 - spec/rubocop/cops/syntax_spec.rb
 - spec/rubocop/cops/tab_spec.rb
 - spec/rubocop/cops/ternary_operator_spec.rb
 - spec/rubocop/cops/trailing_whitespace_spec.rb
+- spec/rubocop/cops/trivial_accessors_spec.rb
 - spec/rubocop/cops/unless_else_spec.rb
 - spec/rubocop/cops/variable_interpolation_spec.rb
 - spec/rubocop/cops/when_then_spec.rb
+- spec/rubocop/cops/word_array_spec.rb
 - spec/rubocop/reports/emacs_style_spec.rb
 - spec/rubocop/reports/report_spec.rb
 - spec/spec_helper.rb
+- spec/support/file_helper.rb
+- spec/support/isolated_environment.rb
 has_rdoc: