rubocop 0.52.1 → 0.93.1

data/lib/rubocop/cli/command/base.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module RuboCop
+  class CLI
+    module Command
+      # A subcommand in the CLI.
+      # @api private
+      class Base
+        attr_reader :env
+
+        @subclasses = []
+
+        class << self
+          attr_accessor :command_name
+
+          def inherited(subclass)
+            super
+            @subclasses << subclass
+          end
+
+          def by_command_name(name)
+            @subclasses.detect { |s| s.command_name == name }
+          end
+        end
+
+        def initialize(env)
+          @env = env
+          @options = env.options
+          @config_store = env.config_store
+          @paths = env.paths
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cli/command/execute_runner.rb

@@ -0,0 +1,85 @@
+# frozen_string_literal: true
+
+module RuboCop
+  class CLI
+    module Command
+      # Run all the selected cops and report the result.
+      # @api private
+      class ExecuteRunner < Base
+        include Formatter::TextUtil
+
+        # Combination of short and long formatter names.
+        INTEGRATION_FORMATTERS = %w[h html j json ju junit].freeze
+
+        self.command_name = :execute_runner
+
+        def run
+          execute_runner(@paths)
+        end
+
+        private
+
+        def execute_runner(paths)
+          runner = Runner.new(@options, @config_store)
+
+          all_passed = runner.run(paths)
+          display_warning_summary(runner.warnings)
+          display_error_summary(runner.errors)
+          maybe_print_corrected_source
+
+          all_pass_or_excluded = all_passed || @options[:auto_gen_config]
+
+          if runner.aborting?
+            STATUS_INTERRUPTED
+          elsif all_pass_or_excluded && runner.errors.empty?
+            STATUS_SUCCESS
+          else
+            STATUS_OFFENSES
+          end
+        end
+
+        def display_warning_summary(warnings)
+          return if warnings.empty?
+
+          warn Rainbow("\n#{pluralize(warnings.size, 'warning')}:").yellow
+
+          warnings.each { |warning| warn warning }
+        end
+
+        def display_error_summary(errors)
+          return if errors.empty?
+
+          warn Rainbow("\n#{pluralize(errors.size, 'error')} occurred:").red
+
+          errors.each { |error| warn error }
+
+          warn <<~WARNING
+            Errors are usually caused by RuboCop bugs.
+            Please, report your problems to RuboCop's issue tracker.
+            #{Gem.loaded_specs['rubocop'].metadata['bug_tracker_uri']}
+
+            Mention the following information in the issue report:
+            #{RuboCop::Version.version(debug: true)}
+          WARNING
+        end
+
+        def maybe_print_corrected_source
+          # Integration tools (like RubyMine) expect to have only the JSON result
+          # when specifying JSON format. Similar HTML and JUnit are targeted as well.
+          # See: https://github.com/rubocop-hq/rubocop/issues/8673
+          return if INTEGRATION_FORMATTERS.include?(@options[:format])
+
+          # If we are asked to autocorrect source code read from stdin, the only
+          # reasonable place to write it is to stdout
+          # Unfortunately, we also write other information to stdout
+          # So a delimiter is needed for tools to easily identify where the
+          # autocorrected source begins
+          return unless @options[:stdin] && @options[:auto_correct]
+
+          puts '=' * 20
+          print @options[:stdin]
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cli/command/init_dotfile.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+module RuboCop
+  class CLI
+    module Command
+      # Generate a .rubocop.yml file in the current directory.
+      # @api private
+      class InitDotfile < Base
+        DOTFILE = ConfigLoader::DOTFILE
+
+        self.command_name = :init
+
+        def run
+          path = File.expand_path(DOTFILE)
+
+          if File.exist?(DOTFILE)
+            warn Rainbow("#{DOTFILE} already exists at #{path}").red
+
+            STATUS_ERROR
+          else
+            description = <<~DESC
+              # The behavior of RuboCop can be controlled via the .rubocop.yml
+              # configuration file. It makes it possible to enable/disable
+              # certain cops (checks) and to alter their behavior if they accept
+              # any parameters. The file can be placed either in your home
+              # directory or in some project directory.
+              #
+              # RuboCop will start looking for the configuration file in the directory
+              # where the inspected file is and continue its way up to the root directory.
+              #
+              # See https://docs.rubocop.org/rubocop/configuration
+            DESC
+
+            File.open(DOTFILE, 'w') do |f|
+              f.write(description)
+            end
+
+            puts "Writing new #{DOTFILE} to #{path}"
+
+            STATUS_SUCCESS
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cli/command/show_cops.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+module RuboCop
+  class CLI
+    module Command
+      # Shows the given cops, or all cops by default, and their configurations
+      # for the current directory.
+      # @api private
+      class ShowCops < Base
+        self.command_name = :show_cops
+
+        def initialize(env)
+          super
+
+          # Load the configs so the require()s are done for custom cops
+          @config = @config_store.for(Dir.pwd)
+        end
+
+        def run
+          print_available_cops
+        end
+
+        private
+
+        def print_available_cops
+          registry = Cop::Registry.global
+          show_all = @options[:show_cops].empty?
+
+          if show_all
+            puts "# Available cops (#{registry.length}) " \
+                 "+ config for #{Dir.pwd}: "
+          end
+
+          registry.departments.sort!.each do |department|
+            print_cops_of_department(registry, department, show_all)
+          end
+        end
+
+        def print_cops_of_department(registry, department, show_all)
+          selected_cops = if show_all
+                            cops_of_department(registry, department)
+                          else
+                            selected_cops_of_department(registry, department)
+                          end
+
+          puts "# Department '#{department}' (#{selected_cops.length}):" if show_all
+
+          print_cop_details(selected_cops)
+        end
+
+        def print_cop_details(cops)
+          cops.each do |cop|
+            puts '# Supports --auto-correct' if cop.support_autocorrect?
+            puts "#{cop.cop_name}:"
+            puts config_lines(cop)
+            puts
+          end
+        end
+
+        def selected_cops_of_department(cops, department)
+          cops_of_department(cops, department).select do |cop|
+            @options[:show_cops].include?(cop.cop_name)
+          end
+        end
+
+        def cops_of_department(cops, department)
+          cops.with_department(department).sort!
+        end
+
+        def config_lines(cop)
+          cnf = @config.for_cop(cop)
+          cnf.to_yaml.lines.to_a.drop(1).map { |line| "  #{line}" }
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cli/command/version.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module RuboCop
+  class CLI
+    module Command
+      # Display version.
+      # @api private
+      class Version < Base
+        self.command_name = :version
+
+        def run
+          puts RuboCop::Version.version(debug: false) if @options[:version]
+          puts RuboCop::Version.version(debug: true) if @options[:verbose_version]
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cli/environment.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+
+module RuboCop
+  class CLI
+    # Execution environment for a CLI command.
+    # @api private
+    class Environment
+      attr_reader :options, :config_store, :paths
+
+      def initialize(options, config_store, paths)
+        @options = options
+        @config_store = config_store
+        @paths = paths
+      end
+
+      # Run a command in this environment.
+      def run(name)
+        Command.run(self, name)
+      end
+    end
+  end
+end

data/lib/rubocop/comment_config.rb

@@ -4,14 +4,20 @@ module RuboCop
   # This class parses the special `rubocop:disable` comments in a source
   # and provides a way to check if each cop is enabled at arbitrary line.
   class CommentConfig
-    UNNEEDED_DISABLE = 'Lint/UnneededDisable'.freeze
+    # @api private
+    REDUNDANT_DISABLE = 'Lint/RedundantCopDisableDirective'
 
-    COP_NAME_PATTERN = '([A-Z]\w+/)?(?:[A-Z]\w+)'.freeze
-    COP_NAMES_PATTERN = "(?:#{COP_NAME_PATTERN} , )*#{COP_NAME_PATTERN}".freeze
-    COPS_PATTERN = "(all|#{COP_NAMES_PATTERN})".freeze
+    # @api private
+    COP_NAME_PATTERN = '([A-Z]\w+/)?(?:[A-Z]\w+)'
+    # @api private
+    COP_NAMES_PATTERN = "(?:#{COP_NAME_PATTERN} , )*#{COP_NAME_PATTERN}"
+    # @api private
+    COPS_PATTERN = "(all|#{COP_NAMES_PATTERN})"
 
+    # @api private
     COMMENT_DIRECTIVE_REGEXP = Regexp.new(
-      ('# rubocop : ((?:dis|en)able)\b ' + COPS_PATTERN).gsub(' ', '\s*')
+      "# rubocop : ((?:disable|enable|todo))\\b #{COPS_PATTERN}"
+        .gsub(' ', '\s*')
     )
 
     CopAnalysis = Struct.new(:line_ranges, :start_line_number)
@@ -34,9 +40,30 @@ module RuboCop
       @cop_disabled_line_ranges ||= analyze
     end
 
+    def extra_enabled_comments
+      extra_enabled_comments_with_names(
+        extras: Hash.new { |h, k| h[k] = [] },
+        names: Hash.new(0)
+      )
+    end
+
     private
 
-    def analyze
+    def extra_enabled_comments_with_names(extras:, names:)
+      each_directive do |comment, cop_names, disabled|
+        next unless comment_only_line?(comment.loc.expression.line)
+
+        if !disabled && enable_all?(comment)
+          handle_enable_all(names, extras, comment)
+        else
+          handle_switch(cop_names, names, disabled, extras, comment)
+        end
+      end
+
+      extras
+    end
+
+    def analyze # rubocop:todo Metrics/AbcSize
       analyses = Hash.new { |hash, key| hash[key] = CopAnalysis.new([], nil) }
 
       each_mentioned_cop do |cop_name, disabled, line, single_line|
@@ -94,7 +121,8 @@ module RuboCop
     def each_mentioned_cop
       each_directive do |comment, cop_names, disabled|
         comment_line_number = comment.loc.expression.line
-        single_line = !comment_only_line?(comment_line_number)
+        single_line = !comment_only_line?(comment_line_number) ||
+                      directive_on_comment_line?(comment)
 
         cop_names.each do |cop_name|
           yield qualified_cop_name(cop_name), disabled, comment_line_number,
@@ -103,9 +131,11 @@ module RuboCop
       end
     end
 
-    def each_directive
-      return if processed_source.comments.nil?
+    def directive_on_comment_line?(comment)
+      comment.text[1..-1].match?(COMMENT_DIRECTIVE_REGEXP)
+    end
 
+    def each_directive
       processed_source.comments.each do |comment|
         directive = directive_parts(comment)
         next unless directive
@@ -123,17 +153,17 @@ module RuboCop
       cop_names =
         cops_string == 'all' ? all_cop_names : cops_string.split(/,\s*/)
 
-      disabled = (switch == 'disable')
+      disabled = %w[disable todo].include?(switch)
 
       [cop_names, disabled]
     end
 
     def qualified_cop_name(cop_name)
-      Cop::Cop.qualified_cop_name(cop_name.strip, processed_source.buffer.name)
+      Cop::Registry.qualified_cop_name(cop_name.strip, processed_source.file_path)
     end
 
     def all_cop_names
-      @all_cop_names ||= Cop::Cop.registry.names - [UNNEEDED_DISABLE]
+      @all_cop_names ||= Cop::Registry.global.names - [REDUNDANT_DISABLE]
     end
 
     def comment_only_line?(line_number)
@@ -148,5 +178,36 @@ module RuboCop
         non_comment_tokens.map(&:line).uniq
       end
     end
+
+    def enable_all?(comment)
+      _, cops = comment.text.match(COMMENT_DIRECTIVE_REGEXP).captures
+      cops == 'all'
+    end
+
+    def handle_enable_all(names, extras, comment)
+      enabled_cops = 0
+      names.each do |name, counter|
+        next unless counter.positive?
+
+        names[name] -= 1
+        enabled_cops += 1
+      end
+
+      extras[comment] << 'all' if enabled_cops.zero?
+    end
+
+    # Collect cops that have been disabled or enabled by name in a directive comment
+    # so that `Lint/RedundantCopEnableDirective` can register offenses correctly.
+    def handle_switch(cop_names, names, disabled, extras, comment)
+      cop_names.each do |name|
+        if disabled
+          names[name] += 1
+        elsif (names[name]).positive?
+          names[name] -= 1
+        else
+          extras[comment] << name
+        end
+      end
+    end
   end
 end

data/lib/rubocop/config.rb

@@ -2,192 +2,35 @@
 
 require 'pathname'
 
+# FIXME: Moving Rails department code to RuboCop Rails will remove
+# the following rubocop:disable comment.
+# rubocop:disable Metrics/ClassLength
 module RuboCop
   # This class represents the configuration of the RuboCop application
   # and all its cops. A Config is associated with a YAML configuration
   # file from which it was read. Several different Configs can be used
   # during a run of the rubocop program, if files in several
   # directories are inspected.
-
-  # rubocop:disable Metrics/ClassLength
   class Config
     include PathUtil
+    include FileFinder
+    extend Forwardable
 
-    COMMON_PARAMS = %w[Exclude Include Severity
-                       AutoCorrect StyleGuide Details].freeze
-    # 2.1 is the oldest officially supported Ruby version.
-    DEFAULT_RUBY_VERSION = 2.1
-    KNOWN_RUBIES = [2.1, 2.2, 2.3, 2.4, 2.5].freeze
-    OBSOLETE_RUBIES = { 1.9 => '0.50', 2.0 => '0.50' }.freeze
-    RUBY_VERSION_FILENAME = '.ruby-version'.freeze
-    DEFAULT_RAILS_VERSION = 5.0
-    OBSOLETE_COPS = {
-      'Style/TrailingComma' =>
-        'The `Style/TrailingComma` cop no longer exists. Please use ' \
-        '`Style/TrailingCommaInLiteral` and/or ' \
-        '`Style/TrailingCommaInArguments` instead.',
-      'Rails/DefaultScope' =>
-        'The `Rails/DefaultScope` cop no longer exists.',
-      'Lint/InvalidCharacterLiteral' =>
-        'The `Lint/InvalidCharacterLiteral` cop has been removed since it ' \
-        'was never being actually triggered.',
-      'Style/SingleSpaceBeforeFirstArg' =>
-        'The `Style/SingleSpaceBeforeFirstArg` cop has been renamed to ' \
-        '`Layout/SpaceBeforeFirstArg`.',
-      'Lint/RescueWithoutErrorClass' =>
-        'The `Lint/RescueWithoutErrorClass` cop has been replaced by ' \
-        '`Style/RescueStandardError`.',
-      'Lint/SpaceBeforeFirstArg' =>
-        'The `Lint/SpaceBeforeFirstArg` cop has been removed, since it was a ' \
-        'duplicate of `Layout/SpaceBeforeFirstArg`. Please use ' \
-        '`Layout/SpaceBeforeFirstArg` instead.',
-      'Layout/SpaceAfterControlKeyword' =>
-        'The `Layout/SpaceAfterControlKeyword` cop has been removed. Please ' \
-        'use `Layout/SpaceAroundKeyword` instead.',
-      'Layout/SpaceBeforeModifierKeyword' =>
-        'The `Layout/SpaceBeforeModifierKeyword` cop has been removed. ' \
-        'Please use `Layout/SpaceAroundKeyword` instead.',
-      'Style/SpaceAfterControlKeyword' =>
-        'The `Style/SpaceAfterControlKeyword` cop has been removed. Please ' \
-        'use `Layout/SpaceAroundKeyword` instead.',
-      'Style/SpaceBeforeModifierKeyword' =>
-        'The `Style/SpaceBeforeModifierKeyword` cop has been removed. Please ' \
-        'use `Layout/SpaceAroundKeyword` instead.',
-      'Style/MethodCallParentheses' =>
-        'The `Style/MethodCallParentheses` cop has been renamed to ' \
-          '`Style/MethodCallWithoutArgsParentheses`.',
-      'Lint/Eval' =>
-        'The `Lint/Eval` cop has been renamed to `Security/Eval`.',
-      'Style/DeprecatedHashMethods' =>
-        'The `Style/DeprecatedHashMethods` cop has been renamed to ' \
-          '`Style/PreferredHashMethods`.',
-      'Style/AccessorMethodName' =>
-        'The `Style/AccessorMethodName` cop has been moved to ' \
-          '`Naming/AccessorMethodName`.',
-      'Style/AsciiIdentifiers' =>
-        'The `Style/AsciiIdentifiers` cop has been moved to ' \
-          '`Naming/AccessorMethodName`.',
-      'Style/OpMethod' =>
-        'The `Style/OpMethod` cop has been renamed and moved to ' \
-          '`Naming/BinaryOperatorParameterName`.',
-      'Style/ClassAndModuleCamelCase' =>
-        'The `Style/ClassAndModuleCamelCase` cop has been renamed to ' \
-          '`Naming/ClassAndModuleCamelCase`.',
-      'Style/ConstantName' =>
-        'The `Style/ConstantName` cop has been renamed to ' \
-          '`Naming/ConstantName`.',
-      'Style/FileName' =>
-        'The `Style/FileName` cop has been renamed to `Naming/FileName`.',
-      'Style/MethodName' =>
-        'The `Style/MethodName` cop has been renamed to ' \
-          '`Naming/MethodName`.',
-      'Style/PredicateName' =>
-        'The `Style/PredicateName` cop has been renamed to ' \
-          '`Naming/PredicateName`.',
-      'Style/VariableName' =>
-        'The `Style/VariableName` cop has been renamed to ' \
-          '`Naming/VariableName`.',
-      'Style/VariableNumber' =>
-        'The `Style/VariableNumber` cop has been renamed to ' \
-          '`Naming/VariableNumber`.'
-    }.freeze
-
-    OBSOLETE_PARAMETERS = [
-      {
-        cop: 'Layout/SpaceAroundOperators',
-        parameter: 'MultiSpaceAllowedForOperators',
-        alternative: 'If your intention was to allow extra spaces ' \
-                     'for alignment, please use AllowForAlignment: ' \
-                     'true instead.'
-      },
-      {
-        cop: 'Style/Encoding',
-        parameter: 'EnforcedStyle',
-        alternative: 'Style/Encoding no longer supports styles. ' \
-                     'The "never" behavior is always assumed.'
-      },
-      {
-        cop: 'Style/Encoding',
-        parameter: 'SupportedStyles',
-        alternative: 'Style/Encoding no longer supports styles. ' \
-                     'The "never" behavior is always assumed.'
-      },
-      {
-        cop: 'Style/Encoding',
-        parameter: 'AutoCorrectEncodingComment',
-        alternative: 'Style/Encoding no longer supports styles. ' \
-                     'The "never" behavior is always assumed.'
-      },
-      {
-        cop: 'Style/IfUnlessModifier',
-        parameter: 'MaxLineLength',
-        alternative:
-          '`Style/IfUnlessModifier: MaxLineLength` has been removed. Use ' \
-          '`Metrics/LineLength: Max` instead'
-      },
-      {
-        cop: 'Style/SpaceAroundOperators',
-        parameter: 'MultiSpaceAllowedForOperators',
-        alternative: 'If your intention was to allow extra spaces ' \
-                     'for alignment, please use AllowForAlignment: ' \
-                     'true instead.'
-      },
-      {
-        cop: 'Style/WhileUntilModifier',
-        parameter: 'MaxLineLength',
-        alternative:
-          '`Style/WhileUntilModifier: MaxLineLength` has been removed. Use ' \
-          '`Metrics/LineLength: Max` instead'
-      },
-      {
-        cop: 'AllCops',
-        parameter: 'RunRailsCops',
-        alternative: "Use the following configuration instead:\n" \
-                     "Rails:\n  Enabled: true"
-      },
-      {
-        cop: 'Layout/CaseIndentation',
-        parameter: 'IndentWhenRelativeTo',
-        alternative: '`IndentWhenRelativeTo` has been renamed to ' \
-                     '`EnforcedStyle`'
-      },
-      {
-        cop: 'Lint/BlockAlignment',
-        parameter: 'AlignWith',
-        alternative: '`AlignWith` has been renamed to ' \
-                     '`EnforcedStyleAlignWith`'
-      },
-      {
-        cop: 'Lint/EndAlignment',
-        parameter: 'AlignWith',
-        alternative: '`AlignWith` has been renamed to ' \
-                     '`EnforcedStyleAlignWith`'
-      },
-      {
-        cop: 'Lint/DefEndAlignment',
-        parameter: 'AlignWith',
-        alternative: '`AlignWith` has been renamed to ' \
-                     '`EnforcedStyleAlignWith`'
-      },
-      {
-        cop: 'Rails/UniqBeforePluck',
-        parameter: 'EnforcedMode',
-        alternative: '`EnforcedMode` has been renamed to ' \
-                     '`EnforcedStyle`'
-      }
-    ].freeze
+    CopConfig = Struct.new(:name, :metadata)
 
+    DEFAULT_RAILS_VERSION = 5.0
     attr_reader :loaded_path
 
     def initialize(hash = {}, loaded_path = nil)
       @loaded_path = loaded_path
       @for_cop = Hash.new do |h, cop|
-        qualified_cop_name = Cop::Cop.qualified_cop_name(cop, loaded_path)
+        qualified_cop_name = Cop::Registry.qualified_cop_name(cop, loaded_path)
         cop_options = self[qualified_cop_name] || {}
         cop_options['Enabled'] = enable_cop?(qualified_cop_name, cop_options)
         h[cop] = cop_options
       end
       @hash = hash
+      @validator = ConfigValidator.new(self)
     end
 
     def self.create(hash, path)
@@ -198,62 +41,33 @@ module RuboCop
       deprecation_check do |deprecation_message|
         warn("#{loaded_path} - #{deprecation_message}")
       end
-      validate
+      @validator.validate
       make_excludes_absolute
       self
     end
 
-    def [](key)
-      @hash[key]
-    end
-
-    def []=(key, value)
-      @hash[key] = value
-    end
-
-    def delete(key)
-      @hash.delete(key)
-    end
-
-    def each(&block)
-      @hash.each(&block)
-    end
-
-    def key?(key)
-      @hash.key?(key)
-    end
+    def_delegators :@hash, :[], :[]=, :delete, :each, :key?, :keys, :each_key,
+                   :fetch, :map, :merge, :to_h, :to_hash, :transform_values
+    def_delegators :@validator, :validate, :target_ruby_version
 
-    def keys
-      @hash.keys
-    end
-
-    def each_key(&block)
-      @hash.each_key(&block)
-    end
-
-    def map(&block)
-      @hash.map(&block)
-    end
-
-    def merge(other_hash)
-      @hash.merge(other_hash)
-    end
-
-    def to_h
-      @hash
+    def to_s
+      @to_s ||= @hash.to_s
     end
 
-    def to_hash
-      @hash
+    def signature
+      @signature ||= Digest::SHA1.hexdigest(to_s)
     end
 
-    def to_s
-      @to_s ||= @hash.to_s
+    # True if this is a config file that is shipped with RuboCop
+    def internal?
+      base_config_path = File.expand_path(File.join(ConfigLoader::RUBOCOP_HOME,
+                                                    'config'))
+      File.expand_path(loaded_path).start_with?(base_config_path)
     end
 
     def make_excludes_absolute
       each_key do |key|
-        validate_section_presence(key)
+        @validator.validate_section_presence(key)
         next unless self[key]['Exclude']
 
         self[key]['Exclude'].map! do |exclude_elem|
@@ -290,38 +104,48 @@ module RuboCop
       end
     end
 
+    # @return [Config] for the given cop / cop name.
+    # Note: the 'Enabled' attribute is calculated according to the department's
+    # and 'AllCops' configuration; other attributes are not inherited.
     def for_cop(cop)
       @for_cop[cop.respond_to?(:cop_name) ? cop.cop_name : cop]
     end
 
+    # @return [Config] for the given cop merged with that of its department (if any)
+    # Note: the 'Enabled' attribute is same as that returned by `for_cop`
+    def for_badge(badge)
+      cop_config = for_cop(badge.to_s)
+      fetch(badge.department.to_s) { return cop_config }
+        .merge(cop_config)
+    end
+
+    # @return [Config] for the given department name.
+    # Note: the 'Enabled' attribute will be present only if specified
+    # at the department's level
+    def for_department(department_name)
+      @for_department ||= Hash.new do |h, dept|
+        h[dept] = self[dept] || {}
+      end
+      @for_department[department_name.to_s]
+    end
+
     def for_all_cops
       @for_all_cops ||= self['AllCops'] || {}
     end
 
-    def validate
-      # Don't validate RuboCop's own files. Avoids infinite recursion.
-      base_config_path = File.expand_path(File.join(ConfigLoader::RUBOCOP_HOME,
-                                                    'config'))
-      return if File.expand_path(loaded_path).start_with?(base_config_path)
-
-      valid_cop_names, invalid_cop_names = keys.partition do |key|
-        ConfigLoader.default_configuration.key?(key)
-      end
+    def disabled_new_cops?
+      for_all_cops['NewCops'] == 'disable'
+    end
 
-      reject_obsolete_cops_and_parameters
-      warn_about_unrecognized_cops(invalid_cop_names)
-      check_target_ruby
-      validate_parameter_names(valid_cop_names)
-      validate_enforced_styles(valid_cop_names)
-      validate_syntax_cop
-      reject_mutually_exclusive_defaults
+    def enabled_new_cops?
+      for_all_cops['NewCops'] == 'enable'
     end
 
     def file_to_include?(file)
       relative_file_path = path_relative_to_config(file)
 
       # Optimization to quickly decide if the given file is hidden (on the top
-      # level) and can not be matched by any pattern.
+      # level) and cannot be matched by any pattern.
       is_hidden = relative_file_path.start_with?('.') &&
                   !relative_file_path.start_with?('..')
       return false if is_hidden && !possibly_include_hidden?
@@ -329,8 +153,25 @@ module RuboCop
       absolute_file_path = File.expand_path(file)
 
       patterns_to_include.any? do |pattern|
-        match_path?(pattern, relative_file_path) ||
-          match_path?(pattern, absolute_file_path)
+        if block_given?
+          yield pattern, relative_file_path, absolute_file_path
+        else
+          match_path?(pattern, relative_file_path) ||
+            match_path?(pattern, absolute_file_path)
+        end
+      end
+    end
+
+    def allowed_camel_case_file?(file)
+      # Gemspecs are allowed to have dashes because that fits with bundler best
+      # practices in the case when the gem is nested under a namespace (e.g.,
+      # `bundler-console` conveys `Bundler::Console`).
+      return true if File.extname(file) == '.gemspec'
+
+      file_to_include?(file) do |pattern, relative_path, absolute_path|
+        /[A-Z]/.match?(pattern.to_s) &&
+          (match_path?(pattern, relative_path) ||
+           match_path?(pattern, absolute_path))
       end
     end
 
@@ -352,11 +193,11 @@ module RuboCop
     end
 
     def patterns_to_include
-      for_all_cops['Include']
+      for_all_cops['Include'] || []
     end
 
     def patterns_to_exclude
-      for_all_cops['Exclude']
+      for_all_cops['Exclude'] || []
     end
 
     def path_relative_to_config(path)
@@ -378,189 +219,80 @@ module RuboCop
         end
     end
 
-    def target_ruby_version
-      @target_ruby_version ||=
-        if for_all_cops['TargetRubyVersion']
-          @target_ruby_version_source = :rubocop_yml
-
-          for_all_cops['TargetRubyVersion']
-        elsif target_ruby_version_from_version_file
-          @target_ruby_version_source = :ruby_version_file
-
-          target_ruby_version_from_version_file
-        else
-          DEFAULT_RUBY_VERSION
-        end
-    end
-
     def target_rails_version
       @target_rails_version ||=
-        for_all_cops.fetch('TargetRailsVersion', DEFAULT_RAILS_VERSION)
-    end
-
-    private
-
-    def warn_about_unrecognized_cops(invalid_cop_names)
-      invalid_cop_names.each do |name|
-        # There could be a custom cop with this name. If so, don't warn
-        next if Cop::Cop.registry.contains_cop_matching?([name])
-
-        warn Rainbow("Warning: unrecognized cop #{name} found in " \
-                     "#{smart_loaded_path}").yellow
-      end
-    end
-
-    def validate_syntax_cop
-      syntax_config = self['Lint/Syntax']
-      default_config = ConfigLoader.default_configuration['Lint/Syntax']
-
-      return unless syntax_config &&
-                    default_config.merge(syntax_config) != default_config
-
-      raise ValidationError,
-            "configuration for Syntax cop found in #{smart_loaded_path}\n" \
-            'It\'s not possible to disable this cop.'
+        if for_all_cops['TargetRailsVersion']
+          for_all_cops['TargetRailsVersion'].to_f
+        elsif target_rails_version_from_bundler_lock_file
+          target_rails_version_from_bundler_lock_file
+        else
+          DEFAULT_RAILS_VERSION
+        end
     end
 
-    def validate_section_presence(name)
-      return unless key?(name) && self[name].nil?
-      raise ValidationError,
-            "empty section #{name} found in #{smart_loaded_path}"
+    def smart_loaded_path
+      PathUtil.smart_path(@loaded_path)
     end
 
-    def validate_parameter_names(valid_cop_names)
-      valid_cop_names.each do |name|
-        validate_section_presence(name)
-        self[name].each_key do |param|
-          next if COMMON_PARAMS.include?(param) ||
-                  ConfigLoader.default_configuration[name].key?(param)
+    def bundler_lock_file_path
+      return nil unless loaded_path
 
-          warn Rainbow("Warning: unrecognized parameter #{name}:#{param} " \
-                       "found in #{smart_loaded_path}").yellow
-        end
+      base_path = base_dir_for_path_parameters
+      ['gems.locked', 'Gemfile.lock'].each do |file_name|
+        path = find_file_upwards(file_name, base_path)
+        return path if path
       end
+      nil
     end
 
-    def validate_enforced_styles(valid_cop_names)
-      valid_cop_names.each do |name|
-        styles = self[name].select { |key, _| key.start_with?('Enforced') }
+    def pending_cops
+      keys.each_with_object([]) do |qualified_cop_name, pending_cops|
+        department = department_of(qualified_cop_name)
+        next if department && department['Enabled'] == false
 
-        styles.each do |style_name, style|
-          supported_key = RuboCop::Cop::Util.to_supported_styles(style_name)
-          valid = ConfigLoader.default_configuration[name][supported_key]
-          next unless valid
-          next if valid.include?(style)
+        cop_metadata = self[qualified_cop_name]
+        next unless cop_metadata['Enabled'] == 'pending'
 
-          msg = "invalid #{style_name} '#{style}' for #{name} found in " \
-            "#{smart_loaded_path}\n" \
-            "Valid choices are: #{valid.join(', ')}"
-          raise ValidationError, msg
-        end
+        pending_cops << CopConfig.new(qualified_cop_name, cop_metadata)
       end
     end
 
-    def reject_obsolete_cops_and_parameters
-      messages = [
-        obsolete_cops,
-        obsolete_parameters
-      ].flatten.compact
-      return if messages.empty?
+    private
 
-      raise ValidationError, messages.join("\n")
+    def target_rails_version_from_bundler_lock_file
+      @target_rails_version_from_bundler_lock_file ||=
+        read_rails_version_from_bundler_lock_file
     end
 
-    def obsolete_parameters
-      OBSOLETE_PARAMETERS.map do |params|
-        obsolete_parameter_message(params[:cop], params[:parameter],
-                                   params[:alternative])
-      end
-    end
-
-    def obsolete_parameter_message(cop, parameter, alternative)
-      return unless self[cop] && self[cop].key?(parameter)
-
-      "obsolete parameter #{parameter} (for #{cop}) " \
-        "found in #{smart_loaded_path}" \
-        "\n#{alternative}"
-    end
+    def read_rails_version_from_bundler_lock_file
+      lock_file_path = bundler_lock_file_path
+      return nil unless lock_file_path
 
-    def obsolete_cops
-      OBSOLETE_COPS.map do |cop_name, message|
-        next unless key?(cop_name) || key?(Cop::Badge.parse(cop_name).cop_name)
-        message + "\n(obsolete configuration found in #{smart_loaded_path}," \
-                   ' please update it)'
+      File.foreach(lock_file_path) do |line|
+        # If rails is in Gemfile.lock or gems.lock, there should be a line like:
+        #         rails (X.X.X)
+        result = line.match(/^\s+rails\s+\((\d+\.\d+)/)
+        return result.captures.first.to_f if result
       end
     end
 
-    def check_target_ruby
-      return if KNOWN_RUBIES.include?(target_ruby_version)
-
-      msg = if OBSOLETE_RUBIES.include?(target_ruby_version)
-              "Unsupported Ruby version #{target_ruby_version} found in " \
-              "#{target_ruby_source}. #{target_ruby_version}-compatible " \
-              'analysis was dropped after version ' \
-              "#{OBSOLETE_RUBIES[target_ruby_version]}."
-            else
-              "Unknown Ruby version #{target_ruby_version.inspect} found in " \
-              "#{target_ruby_source}."
-            end
-
-      msg += "\nSupported versions: #{KNOWN_RUBIES.join(', ')}"
-
-      raise ValidationError, msg
-    end
-
-    def target_ruby_source
-      case @target_ruby_version_source
-      when :ruby_version_file
-        "`#{RUBY_VERSION_FILENAME}`"
-      when :rubocop_yml
-        "`TargetRubyVersion` parameter (in #{smart_loaded_path})"
+    def enable_cop?(qualified_cop_name, cop_options)
+      department = department_of(qualified_cop_name)
+      cop_enabled = cop_options.fetch('Enabled') do
+        !for_all_cops['DisabledByDefault']
       end
-    end
-
-    def ruby_version_file
-      @ruby_version_file ||=
-        PathUtil.find_file_upwards(RUBY_VERSION_FILENAME,
-                                   base_dir_for_path_parameters)
-    end
-
-    def target_ruby_version_from_version_file
-      file = ruby_version_file
-      return unless file && File.file?(file)
+      return true if cop_enabled == 'override_department'
+      return false if department && department['Enabled'] == false
 
-      @target_ruby_version_from_version_file ||=
-        File.read(file).match(/\A(ruby-)?(?<version>\d+\.\d+)/) do |md|
-          md[:version].to_f
-        end
+      cop_enabled
     end
 
-    def reject_mutually_exclusive_defaults
-      disabled_by_default = for_all_cops['DisabledByDefault']
-      enabled_by_default = for_all_cops['EnabledByDefault']
-      return unless disabled_by_default && enabled_by_default
-
-      msg = 'Cops cannot be both enabled by default and disabled by default'
-      raise ValidationError, msg
-    end
-
-    def enable_cop?(qualified_cop_name, cop_options)
+    def department_of(qualified_cop_name)
       cop_department, cop_name = qualified_cop_name.split('/')
-      department = cop_name.nil?
+      return nil if cop_name.nil?
 
-      unless department
-        department_options = self[cop_department]
-        if department_options && department_options['Enabled'] == false
-          return false
-        end
-      end
-
-      cop_options.fetch('Enabled', true)
-    end
-
-    def smart_loaded_path
-      PathUtil.smart_path(@loaded_path)
+      self[cop_department]
     end
   end
-  # rubocop:enable Metrics/ClassLength
 end
+# rubocop:enable Metrics/ClassLength