rubocop 0.52.1 → 0.93.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (749) hide show
  1. checksums.yaml +5 -5
  2. data/LICENSE.txt +1 -1
  3. data/README.md +49 -38
  4. data/assets/output.html.erb +1 -1
  5. data/bin/console +10 -0
  6. data/bin/rubocop-profile +32 -0
  7. data/bin/setup +7 -0
  8. data/config/default.yml +3332 -538
  9. data/{bin → exe}/rubocop +0 -0
  10. data/lib/rubocop.rb +206 -158
  11. data/lib/rubocop/ast_aliases.rb +8 -0
  12. data/lib/rubocop/cached_data.rb +4 -2
  13. data/lib/rubocop/cli.rb +50 -187
  14. data/lib/rubocop/cli/command.rb +22 -0
  15. data/lib/rubocop/cli/command/auto_genenerate_config.rb +141 -0
  16. data/lib/rubocop/cli/command/base.rb +35 -0
  17. data/lib/rubocop/cli/command/execute_runner.rb +85 -0
  18. data/lib/rubocop/cli/command/init_dotfile.rb +46 -0
  19. data/lib/rubocop/cli/command/show_cops.rb +77 -0
  20. data/lib/rubocop/cli/command/version.rb +18 -0
  21. data/lib/rubocop/cli/environment.rb +22 -0
  22. data/lib/rubocop/comment_config.rb +73 -12
  23. data/lib/rubocop/config.rb +117 -385
  24. data/lib/rubocop/config_loader.rb +145 -92
  25. data/lib/rubocop/config_loader_resolver.rb +124 -30
  26. data/lib/rubocop/config_obsoletion.rb +283 -0
  27. data/lib/rubocop/config_regeneration.rb +33 -0
  28. data/lib/rubocop/config_store.rb +19 -5
  29. data/lib/rubocop/config_validator.rb +224 -0
  30. data/lib/rubocop/cop/autocorrect_logic.rb +73 -4
  31. data/lib/rubocop/cop/badge.rb +7 -7
  32. data/lib/rubocop/cop/base.rb +430 -0
  33. data/lib/rubocop/cop/bundler/duplicated_gem.rb +9 -3
  34. data/lib/rubocop/cop/bundler/gem_comment.rb +138 -0
  35. data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +19 -25
  36. data/lib/rubocop/cop/bundler/ordered_gems.rb +6 -4
  37. data/lib/rubocop/cop/commissioner.rb +102 -62
  38. data/lib/rubocop/cop/cop.rb +104 -181
  39. data/lib/rubocop/cop/corrector.rb +82 -98
  40. data/lib/rubocop/cop/correctors/alignment_corrector.rb +50 -29
  41. data/lib/rubocop/cop/correctors/condition_corrector.rb +3 -6
  42. data/lib/rubocop/cop/correctors/each_to_for_corrector.rb +53 -0
  43. data/lib/rubocop/cop/correctors/empty_line_corrector.rb +9 -10
  44. data/lib/rubocop/cop/correctors/for_to_each_corrector.rb +73 -0
  45. data/lib/rubocop/cop/correctors/lambda_literal_to_method_corrector.rb +136 -0
  46. data/lib/rubocop/cop/correctors/line_break_corrector.rb +61 -0
  47. data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +82 -45
  48. data/lib/rubocop/cop/correctors/parentheses_corrector.rb +6 -9
  49. data/lib/rubocop/cop/correctors/percent_literal_corrector.rb +112 -0
  50. data/lib/rubocop/cop/correctors/punctuation_corrector.rb +8 -10
  51. data/lib/rubocop/cop/correctors/space_corrector.rb +15 -3
  52. data/lib/rubocop/cop/correctors/string_literal_corrector.rb +2 -2
  53. data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +18 -9
  54. data/lib/rubocop/cop/documentation.rb +22 -0
  55. data/lib/rubocop/cop/force.rb +2 -0
  56. data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +7 -5
  57. data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +5 -7
  58. data/lib/rubocop/cop/gemspec/required_ruby_version.rb +49 -25
  59. data/lib/rubocop/cop/gemspec/ruby_version_globals_usage.rb +55 -0
  60. data/lib/rubocop/cop/generator.rb +70 -37
  61. data/lib/rubocop/cop/generator/configuration_injector.rb +66 -0
  62. data/lib/rubocop/cop/generator/require_file_injector.rb +2 -2
  63. data/lib/rubocop/cop/ignored_node.rb +1 -3
  64. data/lib/rubocop/cop/internal_affairs.rb +1 -0
  65. data/lib/rubocop/cop/internal_affairs/method_name_equal.rb +52 -0
  66. data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +13 -15
  67. data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +14 -16
  68. data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +12 -11
  69. data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +15 -22
  70. data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +13 -11
  71. data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +5 -5
  72. data/lib/rubocop/cop/layout/access_modifier_indentation.rb +15 -27
  73. data/lib/rubocop/cop/layout/{align_parameters.rb → argument_alignment.rb} +21 -17
  74. data/lib/rubocop/cop/layout/array_alignment.rb +83 -0
  75. data/lib/rubocop/cop/layout/{indent_assignment.rb → assignment_indentation.rb} +12 -3
  76. data/lib/rubocop/cop/layout/begin_end_alignment.rb +77 -0
  77. data/lib/rubocop/cop/{lint → layout}/block_alignment.rb +36 -29
  78. data/lib/rubocop/cop/layout/block_end_newline.rb +9 -20
  79. data/lib/rubocop/cop/layout/case_indentation.rb +23 -26
  80. data/lib/rubocop/cop/layout/class_structure.rb +97 -98
  81. data/lib/rubocop/cop/layout/closing_heredoc_indentation.rb +124 -0
  82. data/lib/rubocop/cop/layout/closing_parenthesis_indentation.rb +140 -30
  83. data/lib/rubocop/cop/layout/comment_indentation.rb +34 -7
  84. data/lib/rubocop/cop/{lint → layout}/condition_position.rb +18 -10
  85. data/lib/rubocop/cop/{lint → layout}/def_end_alignment.rb +11 -7
  86. data/lib/rubocop/cop/layout/dot_position.rb +31 -27
  87. data/lib/rubocop/cop/layout/else_alignment.rb +28 -15
  88. data/lib/rubocop/cop/layout/empty_comment.rb +158 -0
  89. data/lib/rubocop/cop/layout/empty_line_after_guard_clause.rb +160 -0
  90. data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +17 -16
  91. data/lib/rubocop/cop/layout/empty_line_after_multiline_condition.rb +136 -0
  92. data/lib/rubocop/cop/layout/empty_line_between_defs.rb +32 -29
  93. data/lib/rubocop/cop/layout/empty_lines.rb +11 -12
  94. data/lib/rubocop/cop/layout/empty_lines_around_access_modifier.rb +147 -39
  95. data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +29 -18
  96. data/lib/rubocop/cop/layout/empty_lines_around_attribute_accessor.rb +118 -0
  97. data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +4 -8
  98. data/lib/rubocop/cop/layout/empty_lines_around_block_body.rb +6 -7
  99. data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +28 -11
  100. data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +6 -9
  101. data/lib/rubocop/cop/layout/empty_lines_around_method_body.rb +4 -7
  102. data/lib/rubocop/cop/layout/empty_lines_around_module_body.rb +5 -9
  103. data/lib/rubocop/cop/{lint → layout}/end_alignment.rb +49 -23
  104. data/lib/rubocop/cop/layout/end_of_line.rb +48 -8
  105. data/lib/rubocop/cop/layout/extra_spacing.rb +71 -118
  106. data/lib/rubocop/cop/layout/first_argument_indentation.rb +251 -0
  107. data/lib/rubocop/cop/layout/{indent_array.rb → first_array_element_indentation.rb} +22 -16
  108. data/lib/rubocop/cop/layout/first_array_element_line_break.rb +4 -7
  109. data/lib/rubocop/cop/layout/{indent_hash.rb → first_hash_element_indentation.rb} +10 -9
  110. data/lib/rubocop/cop/layout/first_hash_element_line_break.rb +3 -6
  111. data/lib/rubocop/cop/layout/first_method_argument_line_break.rb +8 -12
  112. data/lib/rubocop/cop/layout/first_method_parameter_line_break.rb +3 -6
  113. data/lib/rubocop/cop/layout/first_parameter_indentation.rb +57 -76
  114. data/lib/rubocop/cop/layout/hash_alignment.rb +362 -0
  115. data/lib/rubocop/cop/layout/heredoc_argument_closing_parenthesis.rb +286 -0
  116. data/lib/rubocop/cop/layout/heredoc_indentation.rb +176 -0
  117. data/lib/rubocop/cop/layout/indentation_consistency.rb +155 -7
  118. data/lib/rubocop/cop/layout/indentation_style.rb +115 -0
  119. data/lib/rubocop/cop/layout/indentation_width.rb +72 -28
  120. data/lib/rubocop/cop/layout/initial_indentation.rb +24 -11
  121. data/lib/rubocop/cop/layout/leading_comment_space.rb +75 -12
  122. data/lib/rubocop/cop/layout/leading_empty_lines.rb +48 -0
  123. data/lib/rubocop/cop/layout/line_length.rb +280 -0
  124. data/lib/rubocop/cop/layout/multiline_array_brace_layout.rb +13 -16
  125. data/lib/rubocop/cop/layout/multiline_array_line_breaks.rb +36 -0
  126. data/lib/rubocop/cop/layout/multiline_assignment_layout.rb +18 -16
  127. data/lib/rubocop/cop/layout/multiline_block_layout.rb +74 -29
  128. data/lib/rubocop/cop/layout/multiline_hash_brace_layout.rb +6 -13
  129. data/lib/rubocop/cop/layout/multiline_hash_key_line_breaks.rb +47 -0
  130. data/lib/rubocop/cop/layout/multiline_method_argument_line_breaks.rb +48 -0
  131. data/lib/rubocop/cop/layout/multiline_method_call_brace_layout.rb +68 -38
  132. data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +7 -8
  133. data/lib/rubocop/cop/layout/multiline_method_definition_brace_layout.rb +80 -42
  134. data/lib/rubocop/cop/layout/multiline_operation_indentation.rb +29 -5
  135. data/lib/rubocop/cop/layout/parameter_alignment.rb +118 -0
  136. data/lib/rubocop/cop/layout/rescue_ensure_alignment.rb +142 -30
  137. data/lib/rubocop/cop/layout/space_after_colon.rb +13 -9
  138. data/lib/rubocop/cop/layout/space_after_comma.rb +2 -5
  139. data/lib/rubocop/cop/layout/space_after_method_name.rb +11 -9
  140. data/lib/rubocop/cop/layout/space_after_not.rb +13 -13
  141. data/lib/rubocop/cop/layout/space_after_semicolon.rb +2 -5
  142. data/lib/rubocop/cop/layout/space_around_block_parameters.rb +76 -47
  143. data/lib/rubocop/cop/layout/space_around_equals_in_parameter_default.rb +33 -24
  144. data/lib/rubocop/cop/layout/space_around_keyword.rb +42 -29
  145. data/lib/rubocop/cop/layout/space_around_method_call_operator.rb +98 -0
  146. data/lib/rubocop/cop/layout/space_around_operators.rb +132 -48
  147. data/lib/rubocop/cop/layout/space_before_block_braces.rb +69 -25
  148. data/lib/rubocop/cop/layout/space_before_comma.rb +3 -5
  149. data/lib/rubocop/cop/layout/space_before_comment.rb +15 -11
  150. data/lib/rubocop/cop/layout/space_before_first_arg.rb +18 -8
  151. data/lib/rubocop/cop/layout/space_before_semicolon.rb +2 -5
  152. data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +29 -40
  153. data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +68 -77
  154. data/lib/rubocop/cop/layout/space_inside_array_percent_literal.rb +5 -10
  155. data/lib/rubocop/cop/layout/space_inside_block_braces.rb +41 -24
  156. data/lib/rubocop/cop/layout/space_inside_hash_literal_braces.rb +68 -62
  157. data/lib/rubocop/cop/layout/space_inside_parens.rb +72 -17
  158. data/lib/rubocop/cop/layout/space_inside_percent_literal_delimiters.rb +8 -13
  159. data/lib/rubocop/cop/layout/space_inside_range_literal.rb +10 -19
  160. data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +76 -26
  161. data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +26 -42
  162. data/lib/rubocop/cop/layout/trailing_empty_lines.rb +108 -0
  163. data/lib/rubocop/cop/layout/trailing_whitespace.rb +58 -9
  164. data/lib/rubocop/cop/legacy/corrections_proxy.rb +49 -0
  165. data/lib/rubocop/cop/legacy/corrector.rb +29 -0
  166. data/lib/rubocop/cop/lint/ambiguous_block_association.rb +15 -7
  167. data/lib/rubocop/cop/lint/ambiguous_operator.rb +54 -6
  168. data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +36 -7
  169. data/lib/rubocop/cop/lint/assignment_in_condition.rb +30 -27
  170. data/lib/rubocop/cop/lint/big_decimal_new.rb +43 -0
  171. data/lib/rubocop/cop/lint/binary_operator_with_identical_operands.rb +50 -0
  172. data/lib/rubocop/cop/lint/boolean_symbol.rb +23 -3
  173. data/lib/rubocop/cop/lint/circular_argument_reference.rb +3 -3
  174. data/lib/rubocop/cop/lint/constant_definition_in_block.rb +74 -0
  175. data/lib/rubocop/cop/lint/constant_resolution.rb +89 -0
  176. data/lib/rubocop/cop/lint/debugger.rb +14 -11
  177. data/lib/rubocop/cop/lint/deprecated_class_methods.rb +41 -23
  178. data/lib/rubocop/cop/lint/deprecated_open_ssl_constant.rb +141 -0
  179. data/lib/rubocop/cop/lint/disjunctive_assignment_in_constructor.rb +87 -0
  180. data/lib/rubocop/cop/lint/duplicate_case_condition.rb +2 -2
  181. data/lib/rubocop/cop/lint/duplicate_elsif_condition.rb +39 -0
  182. data/lib/rubocop/cop/lint/{duplicated_key.rb → duplicate_hash_key.rb} +2 -2
  183. data/lib/rubocop/cop/lint/duplicate_methods.rb +44 -30
  184. data/lib/rubocop/cop/lint/duplicate_require.rb +46 -0
  185. data/lib/rubocop/cop/lint/duplicate_rescue_exception.rb +47 -0
  186. data/lib/rubocop/cop/lint/each_with_object_argument.rb +7 -3
  187. data/lib/rubocop/cop/lint/else_layout.rb +3 -2
  188. data/lib/rubocop/cop/lint/empty_conditional_body.rb +67 -0
  189. data/lib/rubocop/cop/lint/empty_ensure.rb +6 -6
  190. data/lib/rubocop/cop/lint/empty_expression.rb +3 -3
  191. data/lib/rubocop/cop/lint/empty_file.rb +50 -0
  192. data/lib/rubocop/cop/lint/empty_interpolation.rb +9 -10
  193. data/lib/rubocop/cop/lint/empty_when.rb +32 -9
  194. data/lib/rubocop/cop/lint/ensure_return.rb +31 -13
  195. data/lib/rubocop/cop/lint/erb_new_arguments.rb +165 -0
  196. data/lib/rubocop/cop/{style → lint}/flip_flop.rb +5 -4
  197. data/lib/rubocop/cop/lint/float_comparison.rb +93 -0
  198. data/lib/rubocop/cop/lint/float_out_of_range.rb +3 -3
  199. data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +65 -46
  200. data/lib/rubocop/cop/lint/hash_compare_by_identity.rb +37 -0
  201. data/lib/rubocop/cop/lint/heredoc_method_call_position.rb +155 -0
  202. data/lib/rubocop/cop/lint/identity_comparison.rb +51 -0
  203. data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +26 -19
  204. data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +43 -67
  205. data/lib/rubocop/cop/lint/inherit_exception.rb +34 -9
  206. data/lib/rubocop/cop/lint/interpolation_check.rb +24 -5
  207. data/lib/rubocop/cop/lint/literal_as_condition.rb +30 -24
  208. data/lib/rubocop/cop/lint/literal_in_interpolation.rb +38 -16
  209. data/lib/rubocop/cop/lint/loop.rb +31 -8
  210. data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +15 -11
  211. data/lib/rubocop/cop/lint/missing_super.rb +99 -0
  212. data/lib/rubocop/cop/lint/mixed_regexp_capture_types.rb +37 -0
  213. data/lib/rubocop/cop/lint/{multiple_compare.rb → multiple_comparison.rb} +12 -13
  214. data/lib/rubocop/cop/lint/nested_method_definition.rb +21 -26
  215. data/lib/rubocop/cop/lint/nested_percent_literal.rb +7 -14
  216. data/lib/rubocop/cop/lint/next_without_accumulator.rb +3 -3
  217. data/lib/rubocop/cop/lint/non_deterministic_require_order.rb +160 -0
  218. data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +14 -16
  219. data/lib/rubocop/cop/lint/number_conversion.rb +79 -0
  220. data/lib/rubocop/cop/lint/ordered_magic_comments.rb +84 -0
  221. data/lib/rubocop/cop/lint/out_of_range_regexp_ref.rb +79 -0
  222. data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +39 -15
  223. data/lib/rubocop/cop/lint/percent_string_array.rb +10 -17
  224. data/lib/rubocop/cop/lint/percent_symbol_array.rb +21 -17
  225. data/lib/rubocop/cop/lint/raise_exception.rb +86 -0
  226. data/lib/rubocop/cop/lint/rand_one.rb +7 -6
  227. data/lib/rubocop/cop/lint/{unneeded_disable.rb → redundant_cop_disable_directive.rb} +91 -76
  228. data/lib/rubocop/cop/lint/redundant_cop_enable_directive.rb +125 -0
  229. data/lib/rubocop/cop/lint/{unneeded_require_statement.rb → redundant_require_statement.rb} +12 -15
  230. data/lib/rubocop/cop/lint/redundant_safe_navigation.rb +78 -0
  231. data/lib/rubocop/cop/lint/{unneeded_splat_expansion.rb → redundant_splat_expansion.rb} +32 -23
  232. data/lib/rubocop/cop/lint/{string_conversion_in_interpolation.rb → redundant_string_coercion.rb} +15 -21
  233. data/lib/rubocop/cop/lint/redundant_with_index.rb +17 -18
  234. data/lib/rubocop/cop/lint/redundant_with_object.rb +18 -19
  235. data/lib/rubocop/cop/lint/regexp_as_condition.rb +7 -3
  236. data/lib/rubocop/cop/lint/require_parentheses.rb +6 -3
  237. data/lib/rubocop/cop/lint/rescue_exception.rb +4 -3
  238. data/lib/rubocop/cop/lint/rescue_type.rb +15 -12
  239. data/lib/rubocop/cop/lint/return_in_void_context.rb +4 -6
  240. data/lib/rubocop/cop/lint/safe_navigation_chain.rb +21 -29
  241. data/lib/rubocop/cop/lint/safe_navigation_consistency.rb +98 -0
  242. data/lib/rubocop/cop/lint/safe_navigation_with_empty.rb +46 -0
  243. data/lib/rubocop/cop/lint/script_permission.rb +40 -16
  244. data/lib/rubocop/cop/lint/self_assignment.rb +78 -0
  245. data/lib/rubocop/cop/lint/send_with_mixin_argument.rb +87 -0
  246. data/lib/rubocop/cop/lint/shadowed_argument.rb +51 -15
  247. data/lib/rubocop/cop/lint/shadowed_exception.rb +47 -28
  248. data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +9 -9
  249. data/lib/rubocop/cop/lint/struct_new_override.rb +59 -0
  250. data/lib/rubocop/cop/lint/suppressed_exception.rb +89 -0
  251. data/lib/rubocop/cop/lint/syntax.rb +12 -28
  252. data/lib/rubocop/cop/lint/to_json.rb +50 -0
  253. data/lib/rubocop/cop/lint/top_level_return_with_argument.rb +34 -0
  254. data/lib/rubocop/cop/lint/trailing_comma_in_attribute_declaration.rb +57 -0
  255. data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +30 -10
  256. data/lib/rubocop/cop/lint/unified_integer.rb +6 -8
  257. data/lib/rubocop/cop/lint/unreachable_code.rb +10 -8
  258. data/lib/rubocop/cop/lint/unreachable_loop.rb +171 -0
  259. data/lib/rubocop/cop/lint/unused_block_argument.rb +30 -9
  260. data/lib/rubocop/cop/lint/unused_method_argument.rb +64 -15
  261. data/lib/rubocop/cop/lint/uri_escape_unescape.rb +19 -16
  262. data/lib/rubocop/cop/lint/uri_regexp.rb +12 -47
  263. data/lib/rubocop/cop/lint/useless_access_modifier.rb +110 -47
  264. data/lib/rubocop/cop/lint/useless_assignment.rb +12 -14
  265. data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +10 -11
  266. data/lib/rubocop/cop/lint/useless_method_definition.rb +70 -0
  267. data/lib/rubocop/cop/lint/useless_setter_call.rb +17 -16
  268. data/lib/rubocop/cop/lint/useless_times.rb +106 -0
  269. data/lib/rubocop/cop/lint/void.rb +63 -35
  270. data/lib/rubocop/cop/message_annotator.rb +22 -11
  271. data/lib/rubocop/cop/metrics/abc_size.rb +4 -19
  272. data/lib/rubocop/cop/metrics/block_length.rb +46 -4
  273. data/lib/rubocop/cop/metrics/block_nesting.rb +4 -3
  274. data/lib/rubocop/cop/metrics/class_length.rb +43 -2
  275. data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +38 -5
  276. data/lib/rubocop/cop/metrics/method_length.rb +31 -4
  277. data/lib/rubocop/cop/metrics/module_length.rb +35 -2
  278. data/lib/rubocop/cop/metrics/parameter_lists.rb +4 -8
  279. data/lib/rubocop/cop/metrics/perceived_complexity.rb +9 -11
  280. data/lib/rubocop/cop/metrics/utils/abc_size_calculator.rb +138 -0
  281. data/lib/rubocop/cop/metrics/utils/code_length_calculator.rb +158 -0
  282. data/lib/rubocop/cop/metrics/utils/iterating_block.rb +61 -0
  283. data/lib/rubocop/cop/metrics/utils/repeated_csend_discount.rb +37 -0
  284. data/lib/rubocop/cop/migration/department_name.rb +83 -0
  285. data/lib/rubocop/cop/mixin/alignment.rb +12 -6
  286. data/lib/rubocop/cop/mixin/allowed_methods.rb +21 -0
  287. data/lib/rubocop/cop/mixin/annotation_comment.rb +6 -0
  288. data/lib/rubocop/cop/mixin/array_min_size.rb +2 -4
  289. data/lib/rubocop/cop/mixin/array_syntax.rb +1 -1
  290. data/lib/rubocop/cop/mixin/auto_corrector.rb +12 -0
  291. data/lib/rubocop/cop/mixin/check_assignment.rb +13 -9
  292. data/lib/rubocop/cop/mixin/check_line_breakable.rb +193 -0
  293. data/lib/rubocop/cop/mixin/code_length.rb +28 -3
  294. data/lib/rubocop/cop/mixin/comments_help.rb +48 -0
  295. data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +8 -5
  296. data/lib/rubocop/cop/mixin/configurable_formatting.rb +4 -7
  297. data/lib/rubocop/cop/mixin/configurable_max.rb +4 -2
  298. data/lib/rubocop/cop/mixin/configurable_naming.rb +2 -2
  299. data/lib/rubocop/cop/mixin/configurable_numbering.rb +3 -3
  300. data/lib/rubocop/cop/mixin/def_node.rb +5 -1
  301. data/lib/rubocop/cop/mixin/documentation_comment.rb +13 -7
  302. data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +35 -18
  303. data/lib/rubocop/cop/mixin/empty_parameter.rb +5 -2
  304. data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +24 -6
  305. data/lib/rubocop/cop/mixin/enforce_superclass.rb +6 -4
  306. data/lib/rubocop/cop/mixin/first_element_line_break.rb +4 -2
  307. data/lib/rubocop/cop/mixin/frozen_string_literal.rb +31 -6
  308. data/lib/rubocop/cop/mixin/{hash_alignment.rb → hash_alignment_styles.rb} +38 -7
  309. data/lib/rubocop/cop/mixin/hash_transform_method.rb +197 -0
  310. data/lib/rubocop/cop/mixin/heredoc.rb +6 -2
  311. data/lib/rubocop/cop/mixin/ignored_methods.rb +19 -0
  312. data/lib/rubocop/cop/mixin/ignored_pattern.rb +1 -1
  313. data/lib/rubocop/cop/mixin/integer_node.rb +1 -1
  314. data/lib/rubocop/cop/mixin/interpolation.rb +27 -0
  315. data/lib/rubocop/cop/mixin/line_length_help.rb +87 -0
  316. data/lib/rubocop/cop/mixin/match_range.rb +2 -0
  317. data/lib/rubocop/cop/mixin/method_complexity.rb +18 -4
  318. data/lib/rubocop/cop/mixin/method_preference.rb +2 -1
  319. data/lib/rubocop/cop/mixin/min_body_length.rb +1 -1
  320. data/lib/rubocop/cop/mixin/{array_hash_indentation.rb → multiline_element_indentation.rb} +3 -2
  321. data/lib/rubocop/cop/mixin/multiline_element_line_breaks.rb +35 -0
  322. data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +42 -13
  323. data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +17 -14
  324. data/lib/rubocop/cop/mixin/negative_conditional.rb +3 -3
  325. data/lib/rubocop/cop/mixin/nil_methods.rb +23 -0
  326. data/lib/rubocop/cop/mixin/ordered_gem_node.rb +15 -2
  327. data/lib/rubocop/cop/mixin/parentheses.rb +1 -2
  328. data/lib/rubocop/cop/mixin/percent_array.rb +18 -11
  329. data/lib/rubocop/cop/mixin/percent_literal.rb +3 -65
  330. data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +96 -6
  331. data/lib/rubocop/cop/mixin/preferred_delimiters.rb +53 -0
  332. data/lib/rubocop/cop/mixin/range_help.rb +131 -0
  333. data/lib/rubocop/cop/mixin/rational_literal.rb +18 -0
  334. data/lib/rubocop/cop/mixin/rescue_node.rb +13 -4
  335. data/lib/rubocop/cop/mixin/safe_assignment.rb +2 -1
  336. data/lib/rubocop/cop/mixin/space_after_punctuation.rb +13 -11
  337. data/lib/rubocop/cop/mixin/space_before_punctuation.rb +16 -13
  338. data/lib/rubocop/cop/mixin/statement_modifier.rb +48 -18
  339. data/lib/rubocop/cop/mixin/string_literals_help.rb +2 -1
  340. data/lib/rubocop/cop/mixin/surrounding_space.rb +62 -42
  341. data/lib/rubocop/cop/mixin/target_ruby_version.rb +5 -1
  342. data/lib/rubocop/cop/mixin/trailing_body.rb +26 -0
  343. data/lib/rubocop/cop/mixin/trailing_comma.rb +96 -46
  344. data/lib/rubocop/cop/mixin/uncommunicative_name.rb +106 -0
  345. data/lib/rubocop/cop/mixin/unused_argument.rb +4 -6
  346. data/lib/rubocop/cop/mixin/visibility_help.rb +38 -0
  347. data/lib/rubocop/cop/naming/accessor_method_name.rb +6 -4
  348. data/lib/rubocop/cop/naming/ascii_identifiers.rb +33 -7
  349. data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +7 -6
  350. data/lib/rubocop/cop/naming/block_parameter_name.rb +49 -0
  351. data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +15 -5
  352. data/lib/rubocop/cop/naming/constant_name.rb +35 -11
  353. data/lib/rubocop/cop/naming/file_name.rb +58 -33
  354. data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +3 -3
  355. data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +10 -14
  356. data/lib/rubocop/cop/naming/memoized_instance_variable_name.rb +171 -0
  357. data/lib/rubocop/cop/naming/method_name.rb +41 -2
  358. data/lib/rubocop/cop/naming/method_parameter_name.rb +58 -0
  359. data/lib/rubocop/cop/naming/predicate_name.rb +18 -15
  360. data/lib/rubocop/cop/naming/rescued_exceptions_variable_name.rb +113 -0
  361. data/lib/rubocop/cop/naming/variable_name.rb +4 -2
  362. data/lib/rubocop/cop/naming/variable_number.rb +3 -3
  363. data/lib/rubocop/cop/offense.rb +64 -13
  364. data/lib/rubocop/cop/registry.rb +118 -14
  365. data/lib/rubocop/cop/security/eval.rb +6 -4
  366. data/lib/rubocop/cop/security/json_load.rb +11 -12
  367. data/lib/rubocop/cop/security/marshal_load.rb +5 -6
  368. data/lib/rubocop/cop/security/open.rb +72 -0
  369. data/lib/rubocop/cop/security/yaml_load.rb +9 -8
  370. data/lib/rubocop/cop/severity.rb +2 -11
  371. data/lib/rubocop/cop/style/access_modifier_declarations.rb +135 -0
  372. data/lib/rubocop/cop/style/accessor_grouping.rb +152 -0
  373. data/lib/rubocop/cop/style/alias.rb +51 -38
  374. data/lib/rubocop/cop/style/and_or.rb +23 -25
  375. data/lib/rubocop/cop/style/array_coercion.rb +67 -0
  376. data/lib/rubocop/cop/style/array_join.rb +10 -11
  377. data/lib/rubocop/cop/style/ascii_comments.rb +7 -4
  378. data/lib/rubocop/cop/style/attr.rb +25 -14
  379. data/lib/rubocop/cop/style/auto_resource_cleanup.rb +8 -8
  380. data/lib/rubocop/cop/style/bare_percent_literals.rb +14 -16
  381. data/lib/rubocop/cop/style/begin_block.rb +9 -3
  382. data/lib/rubocop/cop/style/bisected_attr_accessor.rb +141 -0
  383. data/lib/rubocop/cop/style/block_comments.rb +25 -19
  384. data/lib/rubocop/cop/style/block_delimiters.rb +131 -37
  385. data/lib/rubocop/cop/style/case_equality.rb +55 -5
  386. data/lib/rubocop/cop/style/case_like_if.rb +252 -0
  387. data/lib/rubocop/cop/style/character_literal.rb +3 -3
  388. data/lib/rubocop/cop/style/class_and_module_children.rb +43 -36
  389. data/lib/rubocop/cop/style/class_check.rb +7 -12
  390. data/lib/rubocop/cop/style/class_equality_comparison.rb +64 -0
  391. data/lib/rubocop/cop/style/class_methods.rb +19 -31
  392. data/lib/rubocop/cop/style/class_methods_definitions.rb +157 -0
  393. data/lib/rubocop/cop/style/class_vars.rb +47 -7
  394. data/lib/rubocop/cop/style/collection_methods.rb +40 -18
  395. data/lib/rubocop/cop/style/colon_method_call.rb +11 -13
  396. data/lib/rubocop/cop/style/colon_method_definition.rb +7 -6
  397. data/lib/rubocop/cop/style/combinable_loops.rb +91 -0
  398. data/lib/rubocop/cop/style/command_literal.rb +41 -34
  399. data/lib/rubocop/cop/style/comment_annotation.rb +35 -22
  400. data/lib/rubocop/cop/style/commented_keyword.rb +24 -33
  401. data/lib/rubocop/cop/style/conditional_assignment.rb +108 -138
  402. data/lib/rubocop/cop/style/constant_visibility.rb +78 -0
  403. data/lib/rubocop/cop/style/copyright.rb +39 -28
  404. data/lib/rubocop/cop/style/date_time.rb +55 -11
  405. data/lib/rubocop/cop/style/def_with_parentheses.rb +9 -11
  406. data/lib/rubocop/cop/style/dir.rb +11 -13
  407. data/lib/rubocop/cop/style/disable_cops_within_source_code_directive.rb +47 -0
  408. data/lib/rubocop/cop/style/documentation.rb +62 -23
  409. data/lib/rubocop/cop/style/documentation_method.rb +52 -3
  410. data/lib/rubocop/cop/style/double_cop_disable_directive.rb +52 -0
  411. data/lib/rubocop/cop/style/double_negation.rb +46 -8
  412. data/lib/rubocop/cop/style/each_for_simple_loop.rb +7 -10
  413. data/lib/rubocop/cop/style/each_with_object.rb +30 -19
  414. data/lib/rubocop/cop/style/empty_block_parameter.rb +12 -12
  415. data/lib/rubocop/cop/style/empty_case_condition.rb +36 -12
  416. data/lib/rubocop/cop/style/empty_else.rb +28 -24
  417. data/lib/rubocop/cop/style/empty_lambda_parameter.rb +13 -12
  418. data/lib/rubocop/cop/style/empty_literal.rb +34 -31
  419. data/lib/rubocop/cop/style/empty_method.rb +14 -18
  420. data/lib/rubocop/cop/style/encoding.rb +17 -14
  421. data/lib/rubocop/cop/style/end_block.rb +15 -3
  422. data/lib/rubocop/cop/style/eval_with_location.rb +15 -13
  423. data/lib/rubocop/cop/style/even_odd.rb +13 -16
  424. data/lib/rubocop/cop/style/expand_path_arguments.rb +195 -0
  425. data/lib/rubocop/cop/style/explicit_block_argument.rb +106 -0
  426. data/lib/rubocop/cop/style/exponential_notation.rb +117 -0
  427. data/lib/rubocop/cop/style/float_division.rb +93 -0
  428. data/lib/rubocop/cop/style/for.rb +48 -21
  429. data/lib/rubocop/cop/style/format_string.rb +52 -49
  430. data/lib/rubocop/cop/style/format_string_token.rb +32 -77
  431. data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +131 -62
  432. data/lib/rubocop/cop/style/global_std_stream.rb +65 -0
  433. data/lib/rubocop/cop/style/global_vars.rb +5 -5
  434. data/lib/rubocop/cop/style/guard_clause.rb +69 -16
  435. data/lib/rubocop/cop/style/hash_as_last_array_item.rb +88 -0
  436. data/lib/rubocop/cop/style/hash_each_methods.rb +86 -0
  437. data/lib/rubocop/cop/style/hash_like_case.rb +76 -0
  438. data/lib/rubocop/cop/style/hash_syntax.rb +39 -31
  439. data/lib/rubocop/cop/style/hash_transform_keys.rb +91 -0
  440. data/lib/rubocop/cop/style/hash_transform_values.rb +88 -0
  441. data/lib/rubocop/cop/style/identical_conditional_branches.rb +11 -15
  442. data/lib/rubocop/cop/style/if_inside_else.rb +46 -4
  443. data/lib/rubocop/cop/style/if_unless_modifier.rb +114 -46
  444. data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +12 -4
  445. data/lib/rubocop/cop/style/if_with_semicolon.rb +18 -4
  446. data/lib/rubocop/cop/style/implicit_runtime_error.rb +3 -2
  447. data/lib/rubocop/cop/style/infinite_loop.rb +64 -27
  448. data/lib/rubocop/cop/style/inline_comment.rb +6 -4
  449. data/lib/rubocop/cop/style/inverse_methods.rb +78 -40
  450. data/lib/rubocop/cop/style/ip_addresses.rb +76 -0
  451. data/lib/rubocop/cop/style/keyword_parameters_order.rb +53 -0
  452. data/lib/rubocop/cop/style/lambda.rb +15 -99
  453. data/lib/rubocop/cop/style/lambda_call.rb +17 -34
  454. data/lib/rubocop/cop/style/line_end_concatenation.rb +37 -28
  455. data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +136 -35
  456. data/lib/rubocop/cop/style/method_call_with_args_parentheses/omit_parentheses.rb +174 -0
  457. data/lib/rubocop/cop/style/method_call_with_args_parentheses/require_parentheses.rb +48 -0
  458. data/lib/rubocop/cop/style/method_call_without_args_parentheses.rb +17 -18
  459. data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +17 -5
  460. data/lib/rubocop/cop/style/method_def_parentheses.rb +27 -27
  461. data/lib/rubocop/cop/style/min_max.rb +10 -14
  462. data/lib/rubocop/cop/style/missing_else.rb +87 -31
  463. data/lib/rubocop/cop/style/missing_respond_to_missing.rb +53 -0
  464. data/lib/rubocop/cop/style/mixin_grouping.rb +42 -42
  465. data/lib/rubocop/cop/style/mixin_usage.rb +16 -27
  466. data/lib/rubocop/cop/style/module_function.rb +85 -18
  467. data/lib/rubocop/cop/style/multiline_block_chain.rb +16 -5
  468. data/lib/rubocop/cop/style/multiline_if_modifier.rb +5 -12
  469. data/lib/rubocop/cop/style/multiline_if_then.rb +8 -13
  470. data/lib/rubocop/cop/style/multiline_memoization.rb +17 -14
  471. data/lib/rubocop/cop/style/multiline_method_signature.rb +61 -0
  472. data/lib/rubocop/cop/style/multiline_ternary_operator.rb +32 -10
  473. data/lib/rubocop/cop/style/multiline_when_then.rb +73 -0
  474. data/lib/rubocop/cop/style/multiple_comparison.rb +20 -5
  475. data/lib/rubocop/cop/style/mutable_constant.rb +130 -19
  476. data/lib/rubocop/cop/style/negated_if.rb +10 -10
  477. data/lib/rubocop/cop/style/negated_unless.rb +89 -0
  478. data/lib/rubocop/cop/style/negated_while.rb +25 -15
  479. data/lib/rubocop/cop/style/nested_modifier.rb +37 -20
  480. data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +26 -24
  481. data/lib/rubocop/cop/style/nested_ternary_operator.rb +41 -3
  482. data/lib/rubocop/cop/style/next.rb +40 -43
  483. data/lib/rubocop/cop/style/nil_comparison.rb +51 -9
  484. data/lib/rubocop/cop/style/non_nil_check.rb +55 -35
  485. data/lib/rubocop/cop/style/not.rb +26 -29
  486. data/lib/rubocop/cop/style/numeric_literal_prefix.rb +43 -25
  487. data/lib/rubocop/cop/style/numeric_literals.rb +28 -15
  488. data/lib/rubocop/cop/style/numeric_predicate.rb +19 -27
  489. data/lib/rubocop/cop/style/one_line_conditional.rb +95 -27
  490. data/lib/rubocop/cop/style/option_hash.rb +14 -3
  491. data/lib/rubocop/cop/style/optional_arguments.rb +4 -7
  492. data/lib/rubocop/cop/style/optional_boolean_parameter.rb +53 -0
  493. data/lib/rubocop/cop/style/or_assignment.rb +27 -16
  494. data/lib/rubocop/cop/style/parallel_assignment.rb +20 -20
  495. data/lib/rubocop/cop/style/parentheses_around_condition.rb +50 -10
  496. data/lib/rubocop/cop/style/percent_literal_delimiters.rb +26 -26
  497. data/lib/rubocop/cop/style/percent_q_literals.rb +10 -12
  498. data/lib/rubocop/cop/style/perl_backrefs.rb +9 -11
  499. data/lib/rubocop/cop/style/preferred_hash_methods.rb +12 -14
  500. data/lib/rubocop/cop/style/proc.rb +9 -9
  501. data/lib/rubocop/cop/style/raise_args.rb +30 -30
  502. data/lib/rubocop/cop/style/random_with_offset.rb +65 -72
  503. data/lib/rubocop/cop/style/redundant_assignment.rb +107 -0
  504. data/lib/rubocop/cop/style/redundant_begin.rb +69 -10
  505. data/lib/rubocop/cop/style/{unneeded_capital_w.rb → redundant_capital_w.rb} +7 -10
  506. data/lib/rubocop/cop/style/redundant_condition.rb +139 -0
  507. data/lib/rubocop/cop/style/redundant_conditional.rb +13 -12
  508. data/lib/rubocop/cop/style/redundant_exception.rb +28 -17
  509. data/lib/rubocop/cop/style/redundant_fetch_block.rb +113 -0
  510. data/lib/rubocop/cop/style/redundant_file_extension_in_require.rb +51 -0
  511. data/lib/rubocop/cop/style/redundant_freeze.rb +29 -9
  512. data/lib/rubocop/cop/style/{unneeded_interpolation.rb → redundant_interpolation.rb} +34 -28
  513. data/lib/rubocop/cop/style/redundant_parentheses.rb +73 -39
  514. data/lib/rubocop/cop/style/{unneeded_percent_q.rb → redundant_percent_q.rb} +36 -23
  515. data/lib/rubocop/cop/style/redundant_regexp_character_class.rb +98 -0
  516. data/lib/rubocop/cop/style/redundant_regexp_escape.rb +105 -0
  517. data/lib/rubocop/cop/style/redundant_return.rb +90 -55
  518. data/lib/rubocop/cop/style/redundant_self.rb +39 -25
  519. data/lib/rubocop/cop/style/redundant_self_assignment.rb +116 -0
  520. data/lib/rubocop/cop/style/redundant_sort.rb +162 -0
  521. data/lib/rubocop/cop/{performance → style}/redundant_sort_by.rb +10 -12
  522. data/lib/rubocop/cop/style/regexp_literal.rb +76 -34
  523. data/lib/rubocop/cop/style/rescue_modifier.rb +55 -10
  524. data/lib/rubocop/cop/style/rescue_standard_error.rb +27 -21
  525. data/lib/rubocop/cop/style/return_nil.rb +9 -9
  526. data/lib/rubocop/cop/style/safe_navigation.rb +130 -50
  527. data/lib/rubocop/cop/{performance → style}/sample.rb +28 -26
  528. data/lib/rubocop/cop/style/self_assignment.rb +27 -23
  529. data/lib/rubocop/cop/style/semicolon.rb +32 -14
  530. data/lib/rubocop/cop/style/send.rb +6 -6
  531. data/lib/rubocop/cop/style/signal_exception.rb +29 -22
  532. data/lib/rubocop/cop/style/single_argument_dig.rb +55 -0
  533. data/lib/rubocop/cop/style/single_line_block_params.rb +25 -3
  534. data/lib/rubocop/cop/style/single_line_methods.rb +31 -32
  535. data/lib/rubocop/cop/style/slicing_with_range.rb +37 -0
  536. data/lib/rubocop/cop/style/sole_nested_conditional.rb +66 -0
  537. data/lib/rubocop/cop/style/special_global_vars.rb +74 -33
  538. data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +21 -27
  539. data/lib/rubocop/cop/style/stderr_puts.rb +17 -11
  540. data/lib/rubocop/cop/style/string_concatenation.rb +106 -0
  541. data/lib/rubocop/cop/style/string_hash_keys.rb +22 -9
  542. data/lib/rubocop/cop/style/string_literals.rb +3 -3
  543. data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +1 -1
  544. data/lib/rubocop/cop/style/string_methods.rb +8 -17
  545. data/lib/rubocop/cop/style/strip.rb +41 -0
  546. data/lib/rubocop/cop/style/struct_inheritance.rb +34 -9
  547. data/lib/rubocop/cop/style/symbol_array.rb +47 -20
  548. data/lib/rubocop/cop/style/symbol_literal.rb +7 -9
  549. data/lib/rubocop/cop/style/symbol_proc.rb +32 -59
  550. data/lib/rubocop/cop/style/ternary_parentheses.rb +60 -35
  551. data/lib/rubocop/cop/style/trailing_body_on_class.rb +40 -0
  552. data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +12 -62
  553. data/lib/rubocop/cop/style/trailing_body_on_module.rb +40 -0
  554. data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +49 -25
  555. data/lib/rubocop/cop/style/trailing_comma_in_array_literal.rb +96 -0
  556. data/lib/rubocop/cop/style/trailing_comma_in_block_args.rb +90 -0
  557. data/lib/rubocop/cop/style/trailing_comma_in_hash_literal.rb +97 -0
  558. data/lib/rubocop/cop/style/trailing_method_end_statement.rb +12 -39
  559. data/lib/rubocop/cop/style/trailing_underscore_variable.rb +20 -23
  560. data/lib/rubocop/cop/style/trivial_accessors.rb +42 -37
  561. data/lib/rubocop/cop/style/unless_else.rb +10 -12
  562. data/lib/rubocop/cop/style/unpack_first.rb +58 -0
  563. data/lib/rubocop/cop/style/variable_interpolation.rb +12 -25
  564. data/lib/rubocop/cop/style/when_then.rb +6 -8
  565. data/lib/rubocop/cop/style/while_until_do.rb +7 -17
  566. data/lib/rubocop/cop/style/while_until_modifier.rb +9 -23
  567. data/lib/rubocop/cop/style/word_array.rb +18 -28
  568. data/lib/rubocop/cop/style/yoda_condition.rb +84 -29
  569. data/lib/rubocop/cop/style/zero_length_predicate.rb +34 -24
  570. data/lib/rubocop/cop/team.rb +160 -91
  571. data/lib/rubocop/cop/util.rb +38 -216
  572. data/lib/rubocop/cop/utils/format_string.rb +135 -0
  573. data/lib/rubocop/cop/variable_force.rb +40 -35
  574. data/lib/rubocop/cop/variable_force/assignment.rb +5 -0
  575. data/lib/rubocop/cop/variable_force/branch.rb +6 -7
  576. data/lib/rubocop/cop/variable_force/branchable.rb +2 -0
  577. data/lib/rubocop/cop/variable_force/scope.rb +7 -0
  578. data/lib/rubocop/cop/variable_force/variable.rb +23 -10
  579. data/lib/rubocop/cop/variable_force/variable_table.rb +4 -3
  580. data/lib/rubocop/cops_documentation_generator.rb +284 -0
  581. data/lib/rubocop/core_ext/string.rb +23 -0
  582. data/lib/rubocop/directive_comment.rb +32 -0
  583. data/lib/rubocop/error.rb +24 -0
  584. data/lib/rubocop/ext/processed_source.rb +18 -0
  585. data/lib/rubocop/ext/regexp_node.rb +62 -0
  586. data/lib/rubocop/file_finder.rb +43 -0
  587. data/lib/rubocop/formatter/auto_gen_config_formatter.rb +17 -0
  588. data/lib/rubocop/formatter/base_formatter.rb +3 -7
  589. data/lib/rubocop/formatter/clang_style_formatter.rb +9 -6
  590. data/lib/rubocop/formatter/disabled_config_formatter.rb +69 -35
  591. data/lib/rubocop/formatter/emacs_style_formatter.rb +22 -9
  592. data/lib/rubocop/formatter/file_list_formatter.rb +2 -1
  593. data/lib/rubocop/formatter/formatter_set.rb +18 -17
  594. data/lib/rubocop/formatter/fuubar_style_formatter.rb +2 -2
  595. data/lib/rubocop/formatter/html_formatter.rb +15 -6
  596. data/lib/rubocop/formatter/json_formatter.rb +14 -13
  597. data/lib/rubocop/formatter/junit_formatter.rb +84 -0
  598. data/lib/rubocop/formatter/offense_count_formatter.rb +17 -0
  599. data/lib/rubocop/formatter/pacman_formatter.rb +80 -0
  600. data/lib/rubocop/formatter/progress_formatter.rb +3 -2
  601. data/lib/rubocop/formatter/quiet_formatter.rb +1 -1
  602. data/lib/rubocop/formatter/simple_text_formatter.rb +54 -11
  603. data/lib/rubocop/formatter/tap_formatter.rb +17 -6
  604. data/lib/rubocop/magic_comment.rb +15 -11
  605. data/lib/rubocop/name_similarity.rb +18 -10
  606. data/lib/rubocop/options.rb +267 -139
  607. data/lib/rubocop/path_util.rb +36 -17
  608. data/lib/rubocop/platform.rb +1 -1
  609. data/lib/rubocop/rake_task.rb +8 -9
  610. data/lib/rubocop/remote_config.rb +24 -9
  611. data/lib/rubocop/result_cache.rb +86 -31
  612. data/lib/rubocop/rspec/cop_helper.rb +14 -38
  613. data/lib/rubocop/rspec/expect_offense.rb +168 -14
  614. data/lib/rubocop/rspec/host_environment_simulation_helper.rb +1 -5
  615. data/lib/rubocop/rspec/shared_contexts.rb +93 -47
  616. data/lib/rubocop/rspec/support.rb +5 -1
  617. data/lib/rubocop/runner.rb +146 -77
  618. data/lib/rubocop/string_interpreter.rb +11 -8
  619. data/lib/rubocop/target_finder.rb +94 -95
  620. data/lib/rubocop/target_ruby.rb +160 -0
  621. data/lib/rubocop/version.rb +15 -5
  622. data/lib/rubocop/yaml_duplication_checker.rb +40 -0
  623. metadata +265 -192
  624. data/config/disabled.yml +0 -128
  625. data/config/enabled.yml +0 -1989
  626. data/lib/rubocop/ast/builder.rb +0 -72
  627. data/lib/rubocop/ast/node.rb +0 -634
  628. data/lib/rubocop/ast/node/and_node.rb +0 -37
  629. data/lib/rubocop/ast/node/args_node.rb +0 -29
  630. data/lib/rubocop/ast/node/array_node.rb +0 -57
  631. data/lib/rubocop/ast/node/block_node.rb +0 -116
  632. data/lib/rubocop/ast/node/case_node.rb +0 -64
  633. data/lib/rubocop/ast/node/def_node.rb +0 -71
  634. data/lib/rubocop/ast/node/ensure_node.rb +0 -25
  635. data/lib/rubocop/ast/node/for_node.rb +0 -61
  636. data/lib/rubocop/ast/node/hash_node.rb +0 -109
  637. data/lib/rubocop/ast/node/if_node.rb +0 -146
  638. data/lib/rubocop/ast/node/keyword_splat_node.rb +0 -45
  639. data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +0 -16
  640. data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +0 -23
  641. data/lib/rubocop/ast/node/mixin/collection_node.rb +0 -15
  642. data/lib/rubocop/ast/node/mixin/conditional_node.rb +0 -45
  643. data/lib/rubocop/ast/node/mixin/hash_element_node.rb +0 -125
  644. data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +0 -174
  645. data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +0 -89
  646. data/lib/rubocop/ast/node/mixin/modifier_node.rb +0 -17
  647. data/lib/rubocop/ast/node/mixin/parameterized_node.rb +0 -61
  648. data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +0 -35
  649. data/lib/rubocop/ast/node/or_node.rb +0 -37
  650. data/lib/rubocop/ast/node/pair_node.rb +0 -64
  651. data/lib/rubocop/ast/node/regexp_node.rb +0 -35
  652. data/lib/rubocop/ast/node/resbody_node.rb +0 -25
  653. data/lib/rubocop/ast/node/send_node.rb +0 -45
  654. data/lib/rubocop/ast/node/str_node.rb +0 -14
  655. data/lib/rubocop/ast/node/super_node.rb +0 -21
  656. data/lib/rubocop/ast/node/symbol_node.rb +0 -20
  657. data/lib/rubocop/ast/node/until_node.rb +0 -43
  658. data/lib/rubocop/ast/node/when_node.rb +0 -61
  659. data/lib/rubocop/ast/node/while_node.rb +0 -43
  660. data/lib/rubocop/ast/node/yield_node.rb +0 -21
  661. data/lib/rubocop/ast/sexp.rb +0 -16
  662. data/lib/rubocop/ast/traversal.rb +0 -171
  663. data/lib/rubocop/cop/layout/align_array.rb +0 -39
  664. data/lib/rubocop/cop/layout/align_hash.rb +0 -235
  665. data/lib/rubocop/cop/layout/indent_heredoc.rb +0 -208
  666. data/lib/rubocop/cop/layout/tab.rb +0 -60
  667. data/lib/rubocop/cop/layout/trailing_blank_lines.rb +0 -80
  668. data/lib/rubocop/cop/lint/end_in_method.rb +0 -40
  669. data/lib/rubocop/cop/lint/handle_exceptions.rb +0 -56
  670. data/lib/rubocop/cop/lint/useless_comparison.rb +0 -28
  671. data/lib/rubocop/cop/metrics/line_length.rb +0 -171
  672. data/lib/rubocop/cop/mixin/classish_length.rb +0 -36
  673. data/lib/rubocop/cop/mixin/parser_diagnostic.rb +0 -37
  674. data/lib/rubocop/cop/mixin/safe_mode.rb +0 -22
  675. data/lib/rubocop/cop/mixin/target_rails_version.rb +0 -16
  676. data/lib/rubocop/cop/mixin/too_many_lines.rb +0 -39
  677. data/lib/rubocop/cop/performance/caller.rb +0 -69
  678. data/lib/rubocop/cop/performance/case_when_splat.rb +0 -172
  679. data/lib/rubocop/cop/performance/casecmp.rb +0 -108
  680. data/lib/rubocop/cop/performance/compare_with_block.rb +0 -117
  681. data/lib/rubocop/cop/performance/count.rb +0 -101
  682. data/lib/rubocop/cop/performance/detect.rb +0 -110
  683. data/lib/rubocop/cop/performance/double_start_end_with.rb +0 -94
  684. data/lib/rubocop/cop/performance/end_with.rb +0 -55
  685. data/lib/rubocop/cop/performance/fixed_size.rb +0 -56
  686. data/lib/rubocop/cop/performance/flat_map.rb +0 -76
  687. data/lib/rubocop/cop/performance/hash_each_methods.rb +0 -129
  688. data/lib/rubocop/cop/performance/lstrip_rstrip.rb +0 -44
  689. data/lib/rubocop/cop/performance/range_include.rb +0 -41
  690. data/lib/rubocop/cop/performance/redundant_block_call.rb +0 -93
  691. data/lib/rubocop/cop/performance/redundant_match.rb +0 -56
  692. data/lib/rubocop/cop/performance/redundant_merge.rb +0 -169
  693. data/lib/rubocop/cop/performance/regexp_match.rb +0 -224
  694. data/lib/rubocop/cop/performance/reverse_each.rb +0 -40
  695. data/lib/rubocop/cop/performance/size.rb +0 -71
  696. data/lib/rubocop/cop/performance/start_with.rb +0 -58
  697. data/lib/rubocop/cop/performance/string_replacement.rb +0 -170
  698. data/lib/rubocop/cop/performance/times_map.rb +0 -71
  699. data/lib/rubocop/cop/performance/unfreeze_string.rb +0 -50
  700. data/lib/rubocop/cop/performance/uri_default_parser.rb +0 -47
  701. data/lib/rubocop/cop/rails/action_filter.rb +0 -117
  702. data/lib/rubocop/cop/rails/active_support_aliases.rb +0 -68
  703. data/lib/rubocop/cop/rails/application_job.rb +0 -40
  704. data/lib/rubocop/cop/rails/application_record.rb +0 -40
  705. data/lib/rubocop/cop/rails/blank.rb +0 -142
  706. data/lib/rubocop/cop/rails/create_table_with_timestamps.rb +0 -82
  707. data/lib/rubocop/cop/rails/date.rb +0 -136
  708. data/lib/rubocop/cop/rails/delegate.rb +0 -130
  709. data/lib/rubocop/cop/rails/delegate_allow_blank.rb +0 -51
  710. data/lib/rubocop/cop/rails/dynamic_find_by.rb +0 -82
  711. data/lib/rubocop/cop/rails/enum_uniqueness.rb +0 -45
  712. data/lib/rubocop/cop/rails/environment_comparison.rb +0 -66
  713. data/lib/rubocop/cop/rails/exit.rb +0 -68
  714. data/lib/rubocop/cop/rails/file_path.rb +0 -72
  715. data/lib/rubocop/cop/rails/find_by.rb +0 -52
  716. data/lib/rubocop/cop/rails/find_each.rb +0 -47
  717. data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +0 -25
  718. data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb +0 -84
  719. data/lib/rubocop/cop/rails/http_positional_arguments.rb +0 -102
  720. data/lib/rubocop/cop/rails/inverse_of.rb +0 -218
  721. data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb +0 -112
  722. data/lib/rubocop/cop/rails/not_null_column.rb +0 -67
  723. data/lib/rubocop/cop/rails/output.rb +0 -32
  724. data/lib/rubocop/cop/rails/output_safety.rb +0 -93
  725. data/lib/rubocop/cop/rails/pluralization_grammar.rb +0 -107
  726. data/lib/rubocop/cop/rails/presence.rb +0 -118
  727. data/lib/rubocop/cop/rails/present.rb +0 -143
  728. data/lib/rubocop/cop/rails/read_write_attribute.rb +0 -65
  729. data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb +0 -133
  730. data/lib/rubocop/cop/rails/relative_date_constant.rb +0 -88
  731. data/lib/rubocop/cop/rails/request_referer.rb +0 -55
  732. data/lib/rubocop/cop/rails/reversible_migration.rb +0 -281
  733. data/lib/rubocop/cop/rails/safe_navigation.rb +0 -90
  734. data/lib/rubocop/cop/rails/save_bang.rb +0 -162
  735. data/lib/rubocop/cop/rails/scope_args.rb +0 -29
  736. data/lib/rubocop/cop/rails/skips_model_validations.rb +0 -70
  737. data/lib/rubocop/cop/rails/time_zone.rb +0 -198
  738. data/lib/rubocop/cop/rails/uniq_before_pluck.rb +0 -95
  739. data/lib/rubocop/cop/rails/unknown_env.rb +0 -63
  740. data/lib/rubocop/cop/rails/validation.rb +0 -64
  741. data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +0 -202
  742. data/lib/rubocop/cop/style/method_missing.rb +0 -68
  743. data/lib/rubocop/cop/style/trailing_comma_in_literal.rb +0 -75
  744. data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -57
  745. data/lib/rubocop/node_pattern.rb +0 -560
  746. data/lib/rubocop/processed_source.rb +0 -150
  747. data/lib/rubocop/rspec/shared_examples.rb +0 -92
  748. data/lib/rubocop/string_util.rb +0 -158
  749. data/lib/rubocop/token.rb +0 -103
@@ -2,7 +2,7 @@
2
2
 
3
3
  module RuboCop
4
4
  module Cop
5
- module Lint
5
+ module Layout
6
6
  # This cop checks whether the end keywords are aligned properly.
7
7
  #
8
8
  # Three modes are supported through the `EnforcedStyleAlignWith`
@@ -17,6 +17,11 @@ module RuboCop
17
17
  # If it's set to `start_of_line`, the `end` shall be aligned with the
18
18
  # start of the line where the matching keyword appears.
19
19
  #
20
+ # This `Layout/EndAlignment` cop aligns with keywords (e.g. `if`, `while`, `case`)
21
+ # by default. On the other hand, `Layout/BeginEndAlignment` cop aligns with
22
+ # `EnforcedStyleAlignWith: start_of_line` by default due to `||= begin` tends
23
+ # to align with the start of the line. These style can be configured by each cop.
24
+ #
20
25
  # @example EnforcedStyleAlignWith: keyword (default)
21
26
  # # bad
22
27
  #
@@ -28,6 +33,10 @@ module RuboCop
28
33
  # variable = if true
29
34
  # end
30
35
  #
36
+ # variable =
37
+ # if true
38
+ # end
39
+ #
31
40
  # @example EnforcedStyleAlignWith: variable
32
41
  # # bad
33
42
  #
@@ -39,19 +48,35 @@ module RuboCop
39
48
  # variable = if true
40
49
  # end
41
50
  #
51
+ # variable =
52
+ # if true
53
+ # end
54
+ #
42
55
  # @example EnforcedStyleAlignWith: start_of_line
43
56
  # # bad
44
57
  #
45
58
  # variable = if true
46
59
  # end
47
60
  #
61
+ # puts(if true
62
+ # end)
63
+ #
48
64
  # # good
49
65
  #
66
+ # variable = if true
67
+ # end
68
+ #
50
69
  # puts(if true
51
70
  # end)
52
- class EndAlignment < Cop
71
+ #
72
+ # variable =
73
+ # if true
74
+ # end
75
+ class EndAlignment < Base
53
76
  include CheckAssignment
54
77
  include EndKeywordAlignment
78
+ include RangeHelp
79
+ extend AutoCorrector
55
80
 
56
81
  def on_class(node)
57
82
  check_other_alignment(node)
@@ -81,20 +106,18 @@ module RuboCop
81
106
  end
82
107
  end
83
108
 
84
- def autocorrect(node)
85
- AlignmentCorrector.align_end(processed_source,
86
- node,
87
- alignment_node(node))
88
- end
89
-
90
109
  private
91
110
 
111
+ def autocorrect(corrector, node)
112
+ AlignmentCorrector.align_end(corrector, processed_source, node, alignment_node(node))
113
+ end
114
+
92
115
  def check_assignment(node, rhs)
93
116
  # If there are method calls chained to the right hand side of the
94
117
  # assignment, we let rhs be the receiver of those method calls before
95
118
  # we check if it's an if/unless/while/until.
96
119
  return unless (rhs = first_part_of_call_chain(rhs))
97
- return unless CONDITIONAL_NODES.include?(rhs.type)
120
+ return unless rhs.conditional?
98
121
  return if rhs.if_type? && rhs.ternary?
99
122
 
100
123
  check_asgn_alignment(node, rhs)
@@ -103,7 +126,7 @@ module RuboCop
103
126
  def check_asgn_alignment(outer_node, inner_node)
104
127
  align_with = {
105
128
  keyword: inner_node.loc.keyword,
106
- start_of_line: start_line_range(outer_node),
129
+ start_of_line: start_line_range(inner_node),
107
130
  variable: asgn_variable_align_with(outer_node, inner_node)
108
131
  }
109
132
 
@@ -131,26 +154,29 @@ module RuboCop
131
154
  end
132
155
 
133
156
  def alignment_node(node)
134
- if style == :keyword
157
+ case style
158
+ when :keyword
135
159
  node
136
- elsif style == :variable
137
- return node.parent if node.case_type? && node.argument?
138
- # Fall back to 'keyword' style if this node is not on the RHS
139
- # of an assignment
140
- node.ancestors.find(&:assignment?) || node
160
+ when :variable
161
+ alignment_node_for_variable_style(node)
141
162
  else
142
163
  start_line_range(node)
143
164
  end
144
165
  end
145
166
 
146
- def start_line_range(node)
147
- expr = node.source_range
148
- buffer = expr.source_buffer
149
- source = buffer.source_line(expr.line)
150
- range = buffer.line_range(expr.line)
167
+ def alignment_node_for_variable_style(node)
168
+ return node.parent if node.case_type? && node.argument?
151
169
 
152
- range_between(range.begin_pos + (source =~ /\S/),
153
- range.begin_pos + (source =~ /\s*\z/))
170
+ assignment = node.ancestors.find(&:assignment_or_similar?)
171
+ if assignment && !line_break_before_keyword?(assignment.source_range,
172
+ node)
173
+ assignment
174
+ else
175
+ # Fall back to 'keyword' style if this node is not on the RHS of an
176
+ # assignment, or if it is but there's a line break between LHS and
177
+ # RHS.
178
+ node
179
+ end
154
180
  end
155
181
  end
156
182
  end
@@ -4,19 +4,52 @@ module RuboCop
4
4
  module Cop
5
5
  module Layout
6
6
  # This cop checks for Windows-style line endings in the source code.
7
+ #
8
+ # @example EnforcedStyle: native (default)
9
+ # # The `native` style means that CR+LF (Carriage Return + Line Feed) is
10
+ # # enforced on Windows, and LF is enforced on other platforms.
11
+ #
12
+ # # bad
13
+ # puts 'Hello' # Return character is LF on Windows.
14
+ # puts 'Hello' # Return character is CR+LF on other than Windows.
15
+ #
16
+ # # good
17
+ # puts 'Hello' # Return character is CR+LF on Windows.
18
+ # puts 'Hello' # Return character is LF on other than Windows.
19
+ #
20
+ # @example EnforcedStyle: lf
21
+ # # The `lf` style means that LF (Line Feed) is enforced on
22
+ # # all platforms.
23
+ #
24
+ # # bad
25
+ # puts 'Hello' # Return character is CR+LF on all platfoms.
26
+ #
27
+ # # good
28
+ # puts 'Hello' # Return character is LF on all platfoms.
29
+ #
30
+ # @example EnforcedStyle: crlf
31
+ # # The `crlf` style means that CR+LF (Carriage Return + Line Feed) is
32
+ # # enforced on all platforms.
33
+ #
34
+ # # bad
35
+ # puts 'Hello' # Return character is LF on all platfoms.
36
+ #
37
+ # # good
38
+ # puts 'Hello' # Return character is CR+LF on all platfoms.
39
+ #
7
40
  class EndOfLine < Cop
8
41
  include ConfigurableEnforcedStyle
42
+ include RangeHelp
9
43
 
10
- MSG_DETECTED = 'Carriage return character detected.'.freeze
11
- MSG_MISSING = 'Carriage return character missing.'.freeze
44
+ MSG_DETECTED = 'Carriage return character detected.'
45
+ MSG_MISSING = 'Carriage return character missing.'
12
46
 
13
47
  def investigate(processed_source)
14
- last_token = processed_source.tokens.last
15
- last_line =
16
- last_token ? last_token.line : processed_source.lines.length
48
+ last_line = last_line(processed_source)
17
49
 
18
50
  processed_source.raw_source.each_line.with_index do |line, index|
19
51
  break if index >= last_line
52
+
20
53
  msg = offense_message(line)
21
54
  next unless msg
22
55
  next if unimportant_missing_cr?(index, last_line, line)
@@ -32,7 +65,7 @@ module RuboCop
32
65
 
33
66
  # If there is no LF on the last line, we don't care if there's no CR.
34
67
  def unimportant_missing_cr?(index, last_line, line)
35
- style == :crlf && index == last_line - 1 && line !~ /\n$/
68
+ style == :crlf && index == last_line - 1 && !/\n$/.match?(line)
36
69
  end
37
70
 
38
71
  def offense_message(line)
@@ -42,10 +75,17 @@ module RuboCop
42
75
  style
43
76
  end
44
77
  case effective_style
45
- when :lf then MSG_DETECTED if line =~ /\r$/
46
- else MSG_MISSING if line !~ /\r$/
78
+ when :lf then MSG_DETECTED if line.end_with?("\r", "\r\n")
79
+ else MSG_MISSING unless line.end_with?("\r\n")
47
80
  end
48
81
  end
82
+
83
+ private
84
+
85
+ def last_line(processed_source)
86
+ last_token = processed_source.tokens.last
87
+ last_token ? last_token.line : processed_source.lines.length
88
+ end
49
89
  end
50
90
  end
51
91
  end
@@ -1,7 +1,5 @@
1
1
  # frozen_string_literal: true
2
2
 
3
- require 'set'
4
-
5
3
  module RuboCop
6
4
  module Cop
7
5
  module Layout
@@ -13,121 +11,104 @@ module RuboCop
13
11
  # name = "RuboCop"
14
12
  # # Some comment and an empty line
15
13
  #
16
- # website += "/bbatsov/rubocop" unless cond
14
+ # website += "/rubocop-hq/rubocop" unless cond
17
15
  # puts "rubocop" if debug
18
16
  #
19
17
  # # bad for any configuration
20
18
  # set_app("RuboCop")
21
- # website = "https://github.com/bbatsov/rubocop"
22
- class ExtraSpacing < Cop
19
+ # website = "https://github.com/rubocop-hq/rubocop"
20
+ #
21
+ # # good only if AllowBeforeTrailingComments is true
22
+ # object.method(arg) # this is a comment
23
+ #
24
+ # # good even if AllowBeforeTrailingComments is false or not set
25
+ # object.method(arg) # this is a comment
26
+ #
27
+ # # good with either AllowBeforeTrailingComments or AllowForAlignment
28
+ # object.method(arg) # this is a comment
29
+ # another_object.method(arg) # this is another comment
30
+ # some_object.method(arg) # this is some comment
31
+ class ExtraSpacing < Base
32
+ extend AutoCorrector
23
33
  include PrecedingFollowingAlignment
34
+ include RangeHelp
24
35
 
25
- MSG_UNNECESSARY = 'Unnecessary spacing detected.'.freeze
36
+ MSG_UNNECESSARY = 'Unnecessary spacing detected.'
26
37
  MSG_UNALIGNED_ASGN = '`=` is not aligned with the %<location>s ' \
27
- 'assignment.'.freeze
38
+ 'assignment.'
28
39
 
29
- def investigate(processed_source)
30
- return if processed_source.ast.nil?
40
+ def on_new_investigation
41
+ return if processed_source.blank?
31
42
 
32
- if force_equal_sign_alignment?
33
- @asgn_tokens = assignment_tokens
34
- @asgn_lines = @asgn_tokens.map(&:line)
35
- # Don't attempt to correct the same = more than once
36
- @corrected = Set.new
37
- end
43
+ @aligned_comments = aligned_locations(processed_source.comments.map(&:loc))
44
+ @corrected = Set.new if force_equal_sign_alignment?
38
45
 
39
- processed_source.tokens.each_cons(2) do |t1, t2|
40
- check_tokens(processed_source.ast, t1, t2)
41
- end
42
- end
43
-
44
- def autocorrect(range)
45
- lambda do |corrector|
46
- if range.source.end_with?('=')
47
- align_equal_signs(range, corrector)
48
- else
49
- corrector.remove(range)
50
- end
46
+ processed_source.tokens.each_cons(2) do |token1, token2|
47
+ check_tokens(processed_source.ast, token1, token2)
51
48
  end
52
49
  end
53
50
 
54
51
  private
55
52
 
56
- def assignment_tokens
57
- tokens = processed_source.tokens.select(&:equal_sign?)
58
- # we don't want to operate on equals signs which are part of an
59
- # optarg in a method definition
60
- # e.g.: def method(optarg = default_val); end
61
- tokens = remove_optarg_equals(tokens, processed_source)
53
+ def aligned_locations(locs)
54
+ return [] if locs.empty?
62
55
 
63
- # Only attempt to align the first = on each line
64
- Set.new(tokens.uniq(&:line))
56
+ aligned = Set[locs.first.line, locs.last.line]
57
+ locs.each_cons(3) do |before, loc, after|
58
+ col = loc.column
59
+ aligned << loc.line if col == before.column || # rubocop:disable Style/MultipleComparison
60
+ col == after.column
61
+ end
62
+ aligned
65
63
  end
66
64
 
67
- def check_tokens(ast, t1, t2)
68
- return if t2.type == :tNL
65
+ def check_tokens(ast, token1, token2)
66
+ return if token2.type == :tNL
69
67
 
70
- if force_equal_sign_alignment? &&
71
- @asgn_tokens.include?(t2) &&
72
- (@asgn_lines.include?(t2.line - 1) ||
73
- @asgn_lines.include?(t2.line + 1))
74
- check_assignment(t2)
68
+ if force_equal_sign_alignment? && assignment_tokens.include?(token2)
69
+ check_assignment(token2)
75
70
  else
76
- check_other(t1, t2, ast)
71
+ check_other(token1, token2, ast)
77
72
  end
78
73
  end
79
74
 
80
75
  def check_assignment(token)
81
- assignment_line = ''
82
- message = ''
83
- if should_aligned_with_preceding_line?(token)
84
- assignment_line = preceding_line(token)
85
- message = format(MSG_UNALIGNED_ASGN, location: 'preceding')
86
- else
87
- assignment_line = following_line(token)
88
- message = format(MSG_UNALIGNED_ASGN, location: 'following')
89
- end
90
- return if aligned_assignment?(token.pos, assignment_line)
91
- add_offense(token.pos, location: token.pos, message: message)
92
- end
93
-
94
- def should_aligned_with_preceding_line?(token)
95
- @asgn_lines.include?(token.line - 1)
96
- end
76
+ return unless aligned_with_preceding_assignment(token) == :no
97
77
 
98
- def preceding_line(token)
99
- processed_source.lines[token.line - 2]
78
+ message = format(MSG_UNALIGNED_ASGN, location: 'preceding')
79
+ add_offense(token.pos, message: message) do |corrector|
80
+ align_equal_signs(token.pos, corrector)
81
+ end
100
82
  end
101
83
 
102
- def following_line(token)
103
- processed_source.lines[token.line]
104
- end
84
+ def check_other(token1, token2, ast)
85
+ return false if allow_for_trailing_comments? &&
86
+ token2.text.start_with?('#')
105
87
 
106
- def check_other(t1, t2, ast)
107
- extra_space_range(t1, t2) do |range|
108
- # Unary + doesn't appear as a token and needs special handling.
88
+ extra_space_range(token1, token2) do |range|
109
89
  next if ignored_range?(ast, range.begin_pos)
110
- next if unary_plus_non_offense?(range)
111
90
 
112
- add_offense(range, location: range, message: MSG_UNNECESSARY)
91
+ add_offense(range, message: MSG_UNNECESSARY) do |corrector|
92
+ corrector.remove(range)
93
+ end
113
94
  end
114
95
  end
115
96
 
116
- def extra_space_range(t1, t2)
117
- return if t1.line != t2.line
97
+ def extra_space_range(token1, token2)
98
+ return if token1.line != token2.line
118
99
 
119
- start_pos = t1.end_pos
120
- end_pos = t2.begin_pos - 1
100
+ start_pos = token1.end_pos
101
+ end_pos = token2.begin_pos - 1
121
102
  return if end_pos <= start_pos
122
103
 
123
- return if allow_for_alignment? && aligned_tok?(t2)
104
+ return if allow_for_alignment? && aligned_tok?(token2)
124
105
 
125
106
  yield range_between(start_pos, end_pos)
126
107
  end
127
108
 
128
109
  def aligned_tok?(token)
129
110
  if token.comment?
130
- aligned_comments?(token)
111
+ @aligned_comments.include?(token.line)
131
112
  else
132
113
  aligned_with_something?(token.pos)
133
114
  end
@@ -137,13 +118,9 @@ module RuboCop
137
118
  ignored_ranges(ast).any? { |r| r.include?(start_pos) }
138
119
  end
139
120
 
140
- def unary_plus_non_offense?(range)
141
- range.resize(range.size + 1).source =~ /^ ?\+$/
142
- end
143
-
144
121
  # Returns an array of ranges that should not be reported. It's the
145
122
  # extra spaces between the keys and values in a multiline hash,
146
- # since those are handled by the Style/AlignHash cop.
123
+ # since those are handled by the Layout/HashAlignment cop.
147
124
  def ignored_ranges(ast)
148
125
  return [] unless ast
149
126
 
@@ -155,33 +132,13 @@ module RuboCop
155
132
  end.compact
156
133
  end
157
134
 
158
- def aligned_comments?(token)
159
- ix = processed_source.comments.index do |c|
160
- c.loc.expression.begin_pos == token.begin_pos
161
- end
162
- aligned_with_previous_comment?(ix) || aligned_with_next_comment?(ix)
163
- end
164
-
165
- def aligned_with_previous_comment?(ix)
166
- ix > 0 && comment_column(ix - 1) == comment_column(ix)
167
- end
168
-
169
- def aligned_with_next_comment?(ix)
170
- ix < processed_source.comments.length - 1 &&
171
- comment_column(ix + 1) == comment_column(ix)
172
- end
173
-
174
- def comment_column(ix)
175
- processed_source.comments[ix].loc.column
176
- end
177
-
178
135
  def force_equal_sign_alignment?
179
136
  cop_config['ForceEqualSignAlignment']
180
137
  end
181
138
 
182
139
  def align_equal_signs(range, corrector)
183
- lines = contiguous_assignment_lines(range)
184
- tokens = @asgn_tokens.select { |t| lines.include?(t.line) }
140
+ lines = all_relevant_assignment_lines(range.line)
141
+ tokens = assignment_tokens.select { |t| lines.include?(t.line) }
185
142
 
186
143
  columns = tokens.map { |t| align_column(t) }
187
144
  align_to = columns.max
@@ -194,24 +151,22 @@ module RuboCop
194
151
 
195
152
  diff = align_to - token.pos.last_column
196
153
 
197
- if diff > 0
154
+ if diff.positive?
198
155
  corrector.insert_before(token.pos, ' ' * diff)
199
- elsif diff < 0
156
+ elsif diff.negative?
200
157
  corrector.remove_preceding(token.pos, -diff)
201
158
  end
202
159
  end
203
160
 
204
- def contiguous_assignment_lines(range)
205
- result = [range.line]
206
-
207
- range.line.downto(1) do |lineno|
208
- @asgn_lines.include?(lineno) ? result << lineno : break
209
- end
210
- range.line.upto(processed_source.lines.size) do |lineno|
211
- @asgn_lines.include?(lineno) ? result << lineno : break
212
- end
161
+ def all_relevant_assignment_lines(line_number)
162
+ last_line_number = processed_source.lines.size
213
163
 
214
- result.sort!
164
+ (
165
+ relevant_assignment_lines(line_number.downto(1)) +
166
+ relevant_assignment_lines(line_number.upto(last_line_number))
167
+ )
168
+ .uniq
169
+ .sort
215
170
  end
216
171
 
217
172
  def align_column(asgn_token)
@@ -223,10 +178,8 @@ module RuboCop
223
178
  asgn_token.pos.last_column - spaces + 1
224
179
  end
225
180
 
226
- def remove_optarg_equals(asgn_tokens, processed_source)
227
- optargs = processed_source.ast.each_node(:optarg)
228
- optarg_eql = optargs.map { |o| o.loc.operator.begin_pos }.to_set
229
- asgn_tokens.reject { |t| optarg_eql.include?(t.begin_pos) }
181
+ def allow_for_trailing_comments?
182
+ cop_config['AllowBeforeTrailingComments']
230
183
  end
231
184
  end
232
185
  end