rubocop 0.49.1 → 0.50.0

data/lib/rubocop/ast/node/regexp_node.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # A node extension for `regexp` nodes. This will be used in place of a plain
+    # node when the builder constructs the AST, making its methods available
+    # to all `regexp` nodes within RuboCop.
+    class RegexpNode < Node
+      OPTIONS = {
+        x: Regexp::EXTENDED,
+        i: Regexp::IGNORECASE,
+        m: Regexp::MULTILINE,
+        n: Regexp::NOENCODING
+      }.freeze
+
+      # @return [Regexp] a regexp of this node
+      def to_regexp
+        option = regopt.children.map { |opt| OPTIONS[opt] }.inject(:|)
+        Regexp.new(content, option)
+      end
+
+      # @return [RuboCop::AST::Node] a regopt node
+      def regopt
+        first, second = *self
+        first.regopt_type? ? first : second
+      end
+
+      # @return [String] a string of regexp content
+      def content
+        str = children.first
+        str.str_content || ''
+      end
+    end
+  end
+end

data/lib/rubocop/ast/node/send_node.rb

@@ -7,153 +7,7 @@ module RuboCop
     # to all `send` nodes within RuboCop.
     class SendNode < Node
       include ParameterizedNode
-
-      ENUMERATOR_METHODS = %i[collect collect_concat detect downto each
-                              find find_all find_index inject loop map!
-                              map reduce reject reject! reverse_each select
-                              select! times upto].freeze
-
-      # The receiving node of the method invocation.
-      #
-      # @return [Node, nil] the receiver of the invoked method or `nil`
-      def receiver
-        node_parts[0]
-      end
-
-      # The name of the invoked method called as a string.
-      #
-      # @return [Symbol] the name of the invoked method
-      def method_name
-        node_parts[1]
-      end
-
-      # An array containing the arguments of the method invocation.
-      #
-      # @return [Array<Node>] the arguments of the method invocation or `nil`
-      def arguments
-        node_parts[2..-1]
-      end
-
-      # Checks whether the method name matches the argument.
-      #
-      # @param [Symbol, String] name the method name to check for
-      # @return [Boolean] whether the method name matches the argument
-      def method?(name)
-        method_name == name.to_sym
-      end
-
-      # Checks whether the method is a macro method. A macro method is defined
-      # as a method that sits in a class- or module body and has an implicit
-      # receiver.
-      #
-      # @note This does not include DSLs that use nested blocks, like RSpec
-      #
-      # @return [Boolean] whether the method is a macro method
-      def macro?
-        !receiver && macro_scope?
-      end
-
-      # Checks whether the method name matches the argument and has an
-      # implicit receiver.
-      #
-      # @param [Symbol, String] name the method name to check for
-      # @return [Boolean] whether the method name matches the argument
-      def command?(name)
-        !receiver && method?(name)
-      end
-
-      # Checks whether the invoked method is a setter method.
-      #
-      # @return [Boolean] whether the invoked method is a setter
-      def setter_method?
-        loc.operator
-      end
-
-      # Checks whether the invoked method is an operator method.
-      #
-      # @return [Boolean] whether the invoked method is an operator
-      def operator_method?
-        RuboCop::Cop::Util::OPERATOR_METHODS.include?(method_name)
-      end
-
-      # Checks whether the invoked method is a comparison method.
-      #
-      # @return [Boolean] whether the involed method is a comparison
-      def comparison_method?
-        COMPARISON_OPERATORS.include?(method_name)
-      end
-
-      # Checks whether the invoked method is an assignment method.
-      #
-      # @return [Boolean] whether the invoked method is an assignment.
-      def assignment_method?
-        !comparison_method? && method_name.to_s.end_with?('=')
-      end
-
-      # Checks whether the invoked method is an enumerator method.
-      #
-      # @return [Boolean] whether the invoked method is an enumerator.
-      def enumerator_method?
-        ENUMERATOR_METHODS.include?(method_name) ||
-          method_name.to_s.start_with?('each_')
-      end
-
-      # Checks whether the method call uses a dot to connect the receiver and
-      # the method name.
-      #
-      # This is useful for comparison operators, which can be called either
-      # with or without a dot, i.e. `foo == bar` or `foo.== bar`.
-      #
-      # @return [Boolean] whether the method was called with a connecting dot
-      def dot?
-        loc.dot && loc.dot.is?('.')
-      end
-
-      # Checks whether the method call uses a double colon to connect the
-      # receiver and the method name.
-      #
-      # @return [Boolean] whether the method was called with a connecting dot
-      def double_colon?
-        loc.dot && loc.dot.is?('::')
-      end
-
-      # Checks whether the receiver of this method invocation is `self`.
-      #
-      # @return [Boolean] whether the receiver of this method invocation
-      #                   is `self`
-      def self_receiver?
-        receiver && receiver.self_type?
-      end
-
-      # Checks whether the method call is of the implicit form of `#call`,
-      # e.g. `foo.(bar)`.
-      #
-      # @return [Boolean] whether the method is an implicit form of `#call`
-      def implicit_call?
-        method_name == :call && !loc.selector
-      end
-
-      # Checks whether the invoked method is a predicate method.
-      #
-      # @return [Boolean] whether the invoked method is a predicate method
-      def predicate_method?
-        method_name.to_s.end_with?('?')
-      end
-
-      # Checks whether the invoked method is a bang method.
-      #
-      # @return [Boolean] whether the invoked method is a bang method
-      def bang_method?
-        method_name.to_s.end_with?('!')
-      end
-
-      # Checks whether the invoked method is a camel case method,
-      # e.g. `Integer()`.
-      #
-      # @return [Boolean] whether the invoked method is a camel case method
-      def camel_case_method?
-        method_name.to_s =~ /\A[A-Z]/
-      end
+      include MethodDispatchNode
 
       # Custom destructuring method. This can be used to normalize
       # destructuring for different variations of the node.
@@ -162,13 +16,6 @@ module RuboCop
       def node_parts
         to_a
       end
-
-      private
-
-      def_matcher :macro_scope?, <<-PATTERN
-        {^({class module} ...)
-         ^^({class module} ... (begin ...))}
-      PATTERN
     end
   end
 end

data/lib/rubocop/ast/node/super_node.rb

@@ -7,35 +7,14 @@ module RuboCop
     # methods available to all `super`- and `zsuper` nodes within RuboCop.
     class SuperNode < Node
       include ParameterizedNode
-
-      # The method name of this `super` node. Always `:super`.
-      #
-      # @return [Symbol] the method name of `super`
-      def method_name
-        :super
-      end
-
-      # An array containing the arguments of the super invocation.
-      #
-      # @return [Array<Node>] the arguments of the super invocation
-      def arguments
-        node_parts
-      end
-
-      # Checks whether the method name matches the argument.
-      #
-      # @param [Symbol, String] name the method name to check for
-      # @return [Boolean] whether the method name matches the argument
-      def method?(name)
-        method_name == name.to_sym
-      end
+      include MethodDispatchNode
 
       # Custom destructuring method. This can be used to normalize
       # destructuring for different variations of the node.
       #
-      # @return [Array] the different parts of the `block` node
+      # @return [Array] the different parts of the `super` node
       def node_parts
-        to_a
+        [nil, :super, *to_a]
       end
     end
   end

data/lib/rubocop/ast/node/yield_node.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module AST
+    # A node extension for `yield` nodes. This will be used in place of a plain
+    # node when the builder constructs the AST, making its methods available
+    # to all `yield` nodes within RuboCop.
+    class YieldNode < Node
+      include ParameterizedNode
+      include MethodDispatchNode
+
+      # Custom destructuring method. This can be used to normalize
+      # destructuring for different variations of the node.
+      #
+      # @return [Array] the different parts of the `send` node
+      def node_parts
+        [nil, :yield, *to_a]
+      end
+    end
+  end
+end

data/lib/rubocop/ast/traversal.rb

@@ -34,33 +34,33 @@ module RuboCop
       end
 
       ONE_CHILD_NODE.each do |type|
-        module_eval(<<-END)
+        module_eval(<<-RUBY)
           def on_#{type}(node)
             if (child = node.children[0])
               send(:"on_\#{child.type}", child)
             end
           end
-        END
+        RUBY
       end
 
       MANY_CHILD_NODES.each do |type|
-        module_eval(<<-END)
+        module_eval(<<-RUBY)
           def on_#{type}(node)
             node.children.each { |child| send(:"on_\#{child.type}", child) }
             nil
           end
-        END
+        RUBY
       end
 
       SECOND_CHILD_ONLY.each do |type|
         # Guard clause is for nodes nested within mlhs
-        module_eval(<<-END)
+        module_eval(<<-RUBY)
           def on_#{type}(node)
             if (child = node.children[1])
               send(:"on_\#{child.type}", child)
             end
           end
-        END
+        RUBY
       end
 
       def on_const(node)

data/lib/rubocop/cli.rb

@@ -15,9 +15,13 @@ module RuboCop
       @config_store = ConfigStore.new
     end
 
+    # @api public
+    #
     # Entry point for the application logic. Here we
     # do the command line arguments processing and inspect
-    # the target files
+    # the target files.
+    #
+    # @param args [Array<String>] command line arguments
     # @return [Integer] UNIX exit code
     def run(args = ARGV)
       @options, paths = Options.new.parse(args)
@@ -177,12 +181,12 @@ module RuboCop
 
       errors.each { |error| warn error }
 
-      warn <<-END.strip_indent
+      warn <<-WARNING.strip_indent
         Errors are usually caused by RuboCop bugs.
         Please, report your problems to RuboCop's issue tracker.
         Mention the following information in the issue report:
         #{RuboCop::Version.version(true)}
-      END
+      WARNING
     end
 
     def maybe_print_corrected_source

data/lib/rubocop/config.rb

@@ -52,7 +52,36 @@ module RuboCop
         'The `Lint/Eval` cop has been renamed to `Security/Eval`.',
       'Style/DeprecatedHashMethods' =>
         'The `Style/DeprecatedHashMethods` cop has been renamed to ' \
-          '`Style/PreferredHashMethods`.'
+          '`Style/PreferredHashMethods`.',
+      'Style/AccessorMethodName' =>
+        'The `Style/AccessorMethodName` cop has been moved to ' \
+          '`Naming/AccessorMethodName`.',
+      'Style/AsciiIdentifiers' =>
+        'The `Style/AsciiIdentifiers` cop has been moved to ' \
+          '`Naming/AccessorMethodName`.',
+      'Style/OpMethod' =>
+        'The `Style/OpMethods` cop has been renamed and moved to ' \
+          '`Naming/BinaryOperatorParameter`.',
+      'Style/ClassAndModuleCamelCase' =>
+        'The `Style/ClassAndModuleCamelCase` cop has been renamed to ' \
+          '`Naming/ClassAndModuleCamelCase`.',
+      'Style/ConstantName' =>
+        'The `Style/ConstantName` cop has been renamed to ' \
+          '`Naming/ConstantName`.',
+      'Style/FileName' =>
+        'The `Style/FileName` cop has been renamed to `Naming/FileName`.',
+      'Style/MethodName' =>
+        'The `Style/MethodName` cop has been renamed to ' \
+          '`Naming/MethodName`.',
+      'Style/PredicateName' =>
+        'The `Style/PredicateName` cop has been renamed to ' \
+          '`Naming/PredicateName`.',
+      'Style/VariableName' =>
+        'The `Style/VariableName` cop has been renamed to ' \
+          '`Naming/VariableName`.',
+      'Style/VariableNumber' =>
+        'The `Style/VariableNumber` cop has been renamed to ' \
+          '`Naming/VariableNumber`.'
     }.freeze
 
     OBSOLETE_PARAMETERS = [
@@ -145,6 +174,10 @@ module RuboCop
       @hash.keys
     end
 
+    def each_key(&block)
+      @hash.each_key(&block)
+    end
+
     def map(&block)
       @hash.map(&block)
     end
@@ -166,7 +199,7 @@ module RuboCop
     end
 
     def make_excludes_absolute
-      each do |key, _|
+      each_key do |key|
         validate_section_presence(key)
         next unless self[key]['Exclude']
 
@@ -227,6 +260,7 @@ module RuboCop
       check_target_ruby
       validate_parameter_names(valid_cop_names)
       validate_enforced_styles(valid_cop_names)
+      validate_syntax_cop(valid_cop_names)
       reject_mutually_exclusive_defaults
     end
 
@@ -317,12 +351,6 @@ module RuboCop
 
     def warn_about_unrecognized_cops(invalid_cop_names)
       invalid_cop_names.each do |name|
-        if name == 'Syntax'
-          raise ValidationError,
-                "configuration for Syntax cop found in #{loaded_path}\n" \
-                'This cop cannot be configured.'
-        end
-
         # There could be a custom cop with this name. If so, don't warn
         next if Cop::Cop.registry.contains_cop_matching?([name])
 
@@ -331,6 +359,15 @@ module RuboCop
       end
     end
 
+    def validate_syntax_cop(valid_cop_names)
+      return unless valid_cop_names.include?('Lint/Syntax') ||
+                    valid_cop_names.include?('Syntax')
+
+      raise ValidationError,
+            "configuration for Syntax cop found in #{loaded_path}\n" \
+            'This cop cannot be configured.'
+    end
+
     def validate_section_presence(name)
       return unless key?(name) && self[name].nil?
       raise ValidationError, "empty section #{name} found in #{loaded_path}"

data/lib/rubocop/config_loader.rb

@@ -59,14 +59,16 @@ module RuboCop
         config
       end
 
+      # rubocop:disable Performance/HashEachMethods
       def add_missing_namespaces(path, hash)
-        hash.keys.each do |k|
-          q = Cop::Cop.qualified_cop_name(k, path)
-          next if q == k
+        hash.keys.each do |key|
+          q = Cop::Cop.qualified_cop_name(key, path)
+          next if q == key
 
-          hash[q] = hash.delete(k)
+          hash[q] = hash.delete(key)
         end
       end
+      # rubocop:enable Performance/HashEachMethods
 
       # Return a recursive merge of two hashes. That is, a normal hash merge,
       # with the addition that any value that is a hash, and occurs in both
@@ -83,7 +85,7 @@ module RuboCop
 
       def base_configs(path, inherit_from)
         configs = Array(inherit_from).compact.map do |f|
-          if f =~ /\A#{URI::Parser.new.make_regexp(%w[http https])}\z/
+          if f =~ /\A#{URI::DEFAULT_PARSER.make_regexp(%w[http https])}\z/
             f = RemoteConfig.new(f, File.dirname(path)).file
           else
             f = File.expand_path(f, File.dirname(path))