rubocop 0.49.1 → 0.50.0

data/lib/rubocop.rb

@@ -5,6 +5,7 @@ require 'rainbow'
 
 require 'English'
 require 'set'
+require 'forwardable'
 require 'powerpack/array/butfirst'
 require 'powerpack/enumerable/drop_last'
 require 'powerpack/hash/symbolize_keys'
@@ -22,9 +23,12 @@ require 'rubocop/node_pattern'
 require 'rubocop/string_interpreter'
 require 'rubocop/ast/sexp'
 require 'rubocop/ast/node'
+require 'rubocop/ast/node/mixin/method_identifier_predicates'
 require 'rubocop/ast/node/mixin/binary_operator_node'
+require 'rubocop/ast/node/mixin/collection_node'
 require 'rubocop/ast/node/mixin/conditional_node'
 require 'rubocop/ast/node/mixin/hash_element_node'
+require 'rubocop/ast/node/mixin/method_dispatch_node'
 require 'rubocop/ast/node/mixin/modifier_node'
 require 'rubocop/ast/node/mixin/parameterized_node'
 require 'rubocop/ast/node/mixin/predicate_operator_node'
@@ -33,6 +37,7 @@ require 'rubocop/ast/node/args_node'
 require 'rubocop/ast/node/array_node'
 require 'rubocop/ast/node/block_node'
 require 'rubocop/ast/node/case_node'
+require 'rubocop/ast/node/def_node'
 require 'rubocop/ast/node/ensure_node'
 require 'rubocop/ast/node/for_node'
 require 'rubocop/ast/node/hash_node'
@@ -40,12 +45,14 @@ require 'rubocop/ast/node/if_node'
 require 'rubocop/ast/node/keyword_splat_node'
 require 'rubocop/ast/node/or_node'
 require 'rubocop/ast/node/pair_node'
+require 'rubocop/ast/node/regexp_node'
 require 'rubocop/ast/node/resbody_node'
 require 'rubocop/ast/node/send_node'
 require 'rubocop/ast/node/super_node'
 require 'rubocop/ast/node/until_node'
 require 'rubocop/ast/node/when_node'
 require 'rubocop/ast/node/while_node'
+require 'rubocop/ast/node/yield_node'
 require 'rubocop/ast/builder'
 require 'rubocop/ast/traversal'
 require 'rubocop/error'
@@ -74,7 +81,6 @@ require 'rubocop/cop/variable_force/reference'
 require 'rubocop/cop/variable_force/scope'
 require 'rubocop/cop/variable_force/variable_table'
 
-require 'rubocop/cop/mixin/access_modifier_node'
 require 'rubocop/cop/mixin/annotation_comment'
 require 'rubocop/cop/mixin/array_hash_indentation'
 require 'rubocop/cop/mixin/array_min_size'
@@ -99,17 +105,18 @@ require 'rubocop/cop/mixin/frozen_string_literal'
 require 'rubocop/cop/mixin/hash_alignment'
 require 'rubocop/cop/mixin/ignored_pattern'
 require 'rubocop/cop/mixin/integer_node'
-require 'rubocop/cop/mixin/on_method_def'
 require 'rubocop/cop/mixin/match_range'
-require 'rubocop/cop/mixin/method_complexity' # relies on on_method_def
+require 'rubocop/cop/mixin/method_complexity'
 require 'rubocop/cop/mixin/method_preference'
 require 'rubocop/cop/mixin/min_body_length'
 require 'rubocop/cop/mixin/multiline_expression_indentation'
 require 'rubocop/cop/mixin/multiline_literal_brace_layout'
 require 'rubocop/cop/mixin/negative_conditional'
+require 'rubocop/cop/mixin/heredoc'
 require 'rubocop/cop/mixin/on_normal_if_unless'
 require 'rubocop/cop/mixin/parentheses'
 require 'rubocop/cop/mixin/parser_diagnostic'
+require 'rubocop/cop/mixin/percent_array'
 require 'rubocop/cop/mixin/percent_literal'
 require 'rubocop/cop/mixin/preceding_following_alignment'
 require 'rubocop/cop/mixin/rescue_node'
@@ -129,6 +136,7 @@ require 'rubocop/cop/mixin/trailing_comma'
 require 'rubocop/cop/mixin/unused_argument'
 
 require 'rubocop/cop/bundler/duplicated_gem'
+require 'rubocop/cop/bundler/insecure_protocol_source'
 require 'rubocop/cop/bundler/ordered_gems'
 
 require 'rubocop/cop/layout/access_modifier_indentation'
@@ -207,6 +215,7 @@ require 'rubocop/cop/lint/ambiguous_operator'
 require 'rubocop/cop/lint/ambiguous_regexp_literal'
 require 'rubocop/cop/lint/assignment_in_condition'
 require 'rubocop/cop/lint/block_alignment'
+require 'rubocop/cop/lint/boolean_symbol'
 require 'rubocop/cop/lint/circular_argument_reference'
 require 'rubocop/cop/lint/condition_position'
 require 'rubocop/cop/lint/debugger'
@@ -230,6 +239,7 @@ require 'rubocop/cop/lint/handle_exceptions'
 require 'rubocop/cop/lint/implicit_string_concatenation'
 require 'rubocop/cop/lint/inherit_exception'
 require 'rubocop/cop/lint/ineffective_access_modifier'
+require 'rubocop/cop/lint/interpolation_check'
 require 'rubocop/cop/lint/invalid_character_literal'
 require 'rubocop/cop/lint/literal_in_condition'
 require 'rubocop/cop/lint/literal_in_interpolation'
@@ -242,9 +252,12 @@ require 'rubocop/cop/lint/parentheses_as_grouped_expression'
 require 'rubocop/cop/lint/percent_string_array'
 require 'rubocop/cop/lint/percent_symbol_array'
 require 'rubocop/cop/lint/rand_one'
+require 'rubocop/cop/lint/redundant_with_index'
 require 'rubocop/cop/lint/require_parentheses'
 require 'rubocop/cop/lint/rescue_exception'
 require 'rubocop/cop/lint/rescue_type'
+require 'rubocop/cop/lint/rescue_without_error_class'
+require 'rubocop/cop/lint/return_in_void_context'
 require 'rubocop/cop/lint/safe_navigation_chain'
 require 'rubocop/cop/lint/script_permission'
 require 'rubocop/cop/lint/shadowed_exception'
@@ -258,6 +271,8 @@ require 'rubocop/cop/lint/unneeded_splat_expansion'
 require 'rubocop/cop/lint/unreachable_code'
 require 'rubocop/cop/lint/unused_block_argument'
 require 'rubocop/cop/lint/unused_method_argument'
+require 'rubocop/cop/lint/uri_escape_unescape'
+require 'rubocop/cop/lint/uri_regexp'
 require 'rubocop/cop/lint/useless_access_modifier'
 require 'rubocop/cop/lint/useless_assignment'
 require 'rubocop/cop/lint/useless_comparison'
@@ -276,6 +291,19 @@ require 'rubocop/cop/metrics/module_length'
 require 'rubocop/cop/metrics/parameter_lists'
 require 'rubocop/cop/metrics/perceived_complexity'
 
+require 'rubocop/cop/naming/accessor_method_name'
+require 'rubocop/cop/naming/ascii_identifiers'
+require 'rubocop/cop/naming/class_and_module_camel_case'
+require 'rubocop/cop/naming/constant_name'
+require 'rubocop/cop/naming/file_name'
+require 'rubocop/cop/naming/heredoc_delimiter_case'
+require 'rubocop/cop/naming/heredoc_delimiter_naming'
+require 'rubocop/cop/naming/method_name'
+require 'rubocop/cop/naming/binary_operator_parameter_name'
+require 'rubocop/cop/naming/predicate_name'
+require 'rubocop/cop/naming/variable_name'
+require 'rubocop/cop/naming/variable_number'
+
 require 'rubocop/cop/performance/caller'
 require 'rubocop/cop/performance/case_when_splat'
 require 'rubocop/cop/performance/casecmp'
@@ -300,13 +328,13 @@ require 'rubocop/cop/performance/compare_with_block'
 require 'rubocop/cop/performance/start_with'
 require 'rubocop/cop/performance/string_replacement'
 require 'rubocop/cop/performance/times_map'
+require 'rubocop/cop/performance/unfreeze_string'
+require 'rubocop/cop/performance/uri_default_parser'
 
-require 'rubocop/cop/style/accessor_method_name'
 require 'rubocop/cop/style/alias'
 require 'rubocop/cop/style/and_or'
 require 'rubocop/cop/style/array_join'
 require 'rubocop/cop/style/ascii_comments'
-require 'rubocop/cop/style/ascii_identifiers'
 require 'rubocop/cop/style/attr'
 require 'rubocop/cop/style/auto_resource_cleanup'
 require 'rubocop/cop/style/bare_percent_literals'
@@ -316,7 +344,6 @@ require 'rubocop/cop/style/block_delimiters'
 require 'rubocop/cop/style/braces_around_hash_parameters'
 require 'rubocop/cop/style/case_equality'
 require 'rubocop/cop/style/character_literal'
-require 'rubocop/cop/style/class_and_module_camel_case'
 require 'rubocop/cop/style/class_and_module_children'
 require 'rubocop/cop/style/class_check'
 require 'rubocop/cop/style/class_methods'
@@ -326,10 +353,9 @@ require 'rubocop/cop/style/colon_method_call'
 require 'rubocop/cop/style/command_literal'
 require 'rubocop/cop/style/comment_annotation'
 require 'rubocop/cop/style/conditional_assignment'
-require 'rubocop/cop/style/constant_name'
 require 'rubocop/cop/style/copyright'
 require 'rubocop/cop/style/def_with_parentheses'
-require 'rubocop/cop/style/preferred_hash_methods'
+require 'rubocop/cop/style/dir'
 require 'rubocop/cop/style/documentation_method'
 require 'rubocop/cop/style/documentation'
 require 'rubocop/cop/style/double_negation'
@@ -342,7 +368,6 @@ require 'rubocop/cop/style/empty_method'
 require 'rubocop/cop/style/encoding'
 require 'rubocop/cop/style/end_block'
 require 'rubocop/cop/style/even_odd'
-require 'rubocop/cop/style/file_name'
 require 'rubocop/cop/style/flip_flop'
 require 'rubocop/cop/style/for'
 require 'rubocop/cop/style/format_string'
@@ -367,8 +392,8 @@ require 'rubocop/cop/style/method_call_without_args_parentheses'
 require 'rubocop/cop/style/method_call_with_args_parentheses'
 require 'rubocop/cop/style/method_called_on_do_end_block'
 require 'rubocop/cop/style/method_def_parentheses'
-require 'rubocop/cop/style/method_name'
 require 'rubocop/cop/style/method_missing'
+require 'rubocop/cop/style/min_max'
 require 'rubocop/cop/style/missing_else'
 require 'rubocop/cop/style/mixin_grouping'
 require 'rubocop/cop/style/module_function'
@@ -392,7 +417,7 @@ require 'rubocop/cop/style/numeric_literals'
 require 'rubocop/cop/style/numeric_literal_prefix'
 require 'rubocop/cop/style/numeric_predicate'
 require 'rubocop/cop/style/one_line_conditional'
-require 'rubocop/cop/style/op_method'
+require 'rubocop/cop/style/or_assignment'
 require 'rubocop/cop/style/option_hash'
 require 'rubocop/cop/style/optional_arguments'
 require 'rubocop/cop/style/parallel_assignment'
@@ -400,7 +425,7 @@ require 'rubocop/cop/style/parentheses_around_condition'
 require 'rubocop/cop/style/percent_literal_delimiters'
 require 'rubocop/cop/style/percent_q_literals'
 require 'rubocop/cop/style/perl_backrefs'
-require 'rubocop/cop/style/predicate_name'
+require 'rubocop/cop/style/preferred_hash_methods'
 require 'rubocop/cop/style/proc'
 require 'rubocop/cop/style/raise_args'
 require 'rubocop/cop/style/redundant_begin'
@@ -409,8 +434,10 @@ require 'rubocop/cop/style/redundant_freeze'
 require 'rubocop/cop/style/redundant_parentheses'
 require 'rubocop/cop/style/redundant_return'
 require 'rubocop/cop/style/redundant_self'
+require 'rubocop/cop/style/redundant_conditional'
 require 'rubocop/cop/style/regexp_literal'
 require 'rubocop/cop/style/rescue_modifier'
+require 'rubocop/cop/style/return_nil'
 require 'rubocop/cop/style/safe_navigation'
 require 'rubocop/cop/style/self_assignment'
 require 'rubocop/cop/style/semicolon'
@@ -437,8 +464,6 @@ require 'rubocop/cop/style/unneeded_capital_w'
 require 'rubocop/cop/style/unneeded_interpolation'
 require 'rubocop/cop/style/unneeded_percent_q'
 require 'rubocop/cop/style/variable_interpolation'
-require 'rubocop/cop/style/variable_name'
-require 'rubocop/cop/style/variable_number'
 require 'rubocop/cop/style/when_then'
 require 'rubocop/cop/style/while_until_do'
 require 'rubocop/cop/style/while_until_modifier'
@@ -461,6 +486,7 @@ require 'rubocop/cop/rails/file_path'
 require 'rubocop/cop/rails/find_by'
 require 'rubocop/cop/rails/find_each'
 require 'rubocop/cop/rails/has_and_belongs_to_many'
+require 'rubocop/cop/rails/has_many_or_has_one_dependent'
 require 'rubocop/cop/rails/http_positional_arguments'
 require 'rubocop/cop/rails/not_null_column'
 require 'rubocop/cop/rails/output_safety'
@@ -498,6 +524,7 @@ require 'rubocop/formatter/html_formatter'
 require 'rubocop/formatter/json_formatter'
 require 'rubocop/formatter/offense_count_formatter'
 require 'rubocop/formatter/progress_formatter'
+require 'rubocop/formatter/tap_formatter'
 require 'rubocop/formatter/worst_offenders_formatter'
 
 require 'rubocop/formatter/formatter_set'

data/lib/rubocop/ast/builder.rb

@@ -19,6 +19,7 @@ module RuboCop
         ArrayNode        => [:array],
         BlockNode        => [:block],
         CaseNode         => [:case],
+        DefNode          => %i[def defs],
         EnsureNode       => [:ensure],
         ForNode          => [:for],
         HashNode         => [:hash],
@@ -26,12 +27,14 @@ module RuboCop
         KeywordSplatNode => [:kwsplat],
         OrNode           => [:or],
         PairNode         => [:pair],
+        RegexpNode       => [:regexp],
         ResbodyNode      => [:resbody],
         SendNode         => %i[csend send],
         SuperNode        => %i[super zsuper],
         UntilNode        => %i[until until_post],
         WhenNode         => [:when],
-        WhileNode        => %i[while while_post]
+        WhileNode        => %i[while while_post],
+        YieldNode        => [:yield]
       }.freeze
 
       # Generates {Node} from the given information.

data/lib/rubocop/ast/node.rb

@@ -20,8 +20,10 @@ module RuboCop
     #
     class Node < Parser::AST::Node # rubocop:disable Metrics/ClassLength
       include RuboCop::AST::Sexp
+      extend NodePattern::Macros
 
-      COMPARISON_OPERATORS = %i[! == === != <= >= > < <=>].freeze
+      # <=> isn't included here, because it doesn't return a boolean.
+      COMPARISON_OPERATORS = %i[== === != <= >= > <].freeze
 
       TRUTHY_LITERALS = %i[str dstr xstr int float sym dsym array
                            hash regexp true irange erange complex
@@ -44,19 +46,6 @@ module RuboCop
       OPERATOR_KEYWORDS = %i[and or].freeze
       SPECIAL_KEYWORDS = %w[__FILE__ __LINE__ __ENCODING__].freeze
 
-      # def_matcher can be used to define a pattern-matching method on Node
-      class << self
-        def def_matcher(method_name, pattern_str)
-          compiler = RuboCop::NodePattern::Compiler.new(pattern_str, 'self')
-          src = "def #{method_name}(" \
-                "#{compiler.emit_param_list});" \
-                "#{compiler.emit_method_code};end"
-
-          location = caller_locations(1, 1).first
-          class_eval(src, location.path, location.lineno)
-        end
-      end
-
       # @see http://rubydoc.info/gems/ast/AST/Node:initialize
       def initialize(type, children = [], properties = {})
         @mutable_attributes = {}
@@ -271,12 +260,17 @@ module RuboCop
 
       ## Destructuring
 
-      def_matcher :receiver,    '{(send $_ ...) (block (send $_ ...) ...)}'
-      def_matcher :method_name, '{(send _ $_ ...) (block (send _ $_ ...) ...)}'
-      def_matcher :method_args, '{(send _ _ $...) (block (send _ _ $...) ...)}'
+      def_node_matcher :receiver, <<-PATTERN
+        {(send $_ ...) (block (send $_ ...) ...)}
+      PATTERN
+
+      def_node_matcher :method_name, <<-PATTERN
+        {(send _ $_ ...) (block (send _ $_ ...) ...)}
+      PATTERN
+
       # Note: for masgn, #asgn_rhs will be an array node
-      def_matcher :asgn_rhs, '[assignment? (... $_)]'
-      def_matcher :str_content, '(str $_)'
+      def_node_matcher :asgn_rhs, '[assignment? (... $_)]'
+      def_node_matcher :str_content, '(str $_)'
 
       def const_name
         return unless const_type?
@@ -288,7 +282,7 @@ module RuboCop
         end
       end
 
-      def_matcher :defined_module0, <<-PATTERN
+      def_node_matcher :defined_module0, <<-PATTERN
         {(class (const $_ $_) ...)
          (module (const $_ $_) ...)
          (casgn $_ $_        (send (const nil {:Class :Module}) :new ...))
@@ -332,10 +326,15 @@ module RuboCop
           method_name.to_s.end_with?('='.freeze)
       end
 
-      def_matcher :equals_asgn?, '{lvasgn ivasgn cvasgn gvasgn casgn masgn}'
-      def_matcher :shorthand_asgn?, '{op_asgn or_asgn and_asgn}'
-      def_matcher :assignment?,
-                  '{equals_asgn? shorthand_asgn? asgn_method_call?}'
+      def_node_matcher :equals_asgn?, <<-PATTERN
+        {lvasgn ivasgn cvasgn gvasgn casgn masgn}
+      PATTERN
+
+      def_node_matcher :shorthand_asgn?, '{op_asgn or_asgn and_asgn}'
+
+      def_node_matcher :assignment?, <<-PATTERN
+        {equals_asgn? shorthand_asgn? asgn_method_call?}
+      PATTERN
 
       def literal?
         LITERALS.include?(type)
@@ -368,7 +367,7 @@ module RuboCop
           case type
           when :send
             receiver, method_name, *args = *self
-            COMPARISON_OPERATORS.include?(method_name) &&
+            [*COMPARISON_OPERATORS, :!, :<=>].include?(method_name) &&
               receiver.send(recursive_kind) &&
               args.all?(&recursive_kind)
           when :begin, :pair, *OPERATOR_KEYWORDS, *COMPOSITE_LITERALS
@@ -439,24 +438,25 @@ module RuboCop
         int_type? || float_type?
       end
 
-      def_matcher :guard_clause?, <<-PATTERN
+      def_node_matcher :guard_clause?, <<-PATTERN
         [{(send nil {:raise :fail} ...) return break next} single_line?]
       PATTERN
 
-      def_matcher :lambda?, '(block (send nil :lambda) ...)'
-      def_matcher :proc?, <<-PATTERN
+      def_node_matcher :proc?, <<-PATTERN
         {(block (send nil :proc) ...)
          (block (send (const nil :Proc) :new) ...)
          (send (const nil :Proc) :new)}
       PATTERN
-      def_matcher :lambda_or_proc?, '{lambda? proc?}'
 
-      def_matcher :class_constructor?, <<-PATTERN
+      def_node_matcher :lambda?, '(block (send nil :lambda) ...)'
+      def_node_matcher :lambda_or_proc?, '{lambda? proc?}'
+
+      def_node_matcher :class_constructor?, <<-PATTERN
         {       (send (const nil {:Class :Module}) :new ...)
          (block (send (const nil {:Class :Module}) :new ...) ...)}
       PATTERN
 
-      def_matcher :module_definition?, <<-PATTERN
+      def_node_matcher :module_definition?, <<-PATTERN
         {class module (casgn _ _ class_constructor?)}
       PATTERN
 
@@ -468,7 +468,7 @@ module RuboCop
       # So, does the return value of this node matter? If we changed it to
       # `(...; nil)`, might that affect anything?
       #
-      # rubocop:disable Metrics/MethodLength
+      # rubocop:disable Metrics/MethodLength, Metrics/CyclomaticComplexity
       def value_used?
         # Be conservative and return true if we're not sure.
         return false if parent.nil?
@@ -490,7 +490,7 @@ module RuboCop
           true
         end
       end
-      # rubocop:enable Metrics/MethodLength
+      # rubocop:enable Metrics/MethodLength, Metrics/CyclomaticComplexity
 
       # Some expressions are evaluated for their value, some for their side
       # effects, and some for both.
@@ -596,15 +596,9 @@ module RuboCop
         end
       end
 
-      def new_class_or_module_block?(block_node)
-        receiver = block_node.receiver
-
-        block_node.method_name == :new &&
-          receiver && receiver.const_type? &&
-          (receiver.const_name == 'Class' || receiver.const_name == 'Module') &&
-          block_node.parent &&
-          block_node.parent.casgn_type?
-      end
+      def_node_matcher :new_class_or_module_block?, <<-PATTERN
+        ^(casgn _ _ (block (send (const _ {:Class :Module}) :new) ...))
+      PATTERN
     end
   end
 end

data/lib/rubocop/ast/node/args_node.rb

@@ -6,19 +6,7 @@ module RuboCop
     # node when the builder constructs the AST, making its methods available
     # to all `args` nodes within RuboCop.
     class ArgsNode < Node
-      # Whether this `args` node has any arguments.
-      #
-      # @return [Boolean] whether this `args` node has any arguments
-      def empty?
-        to_a.empty?
-      end
-
-      # The number of arguments in this `args` node.
-      #
-      # @return [Integer] the number of arguments in this `args` node
-      def size
-        to_a.size
-      end
+      include CollectionNode
     end
   end
 end

data/lib/rubocop/ast/node/array_node.rb

@@ -43,6 +43,15 @@ module RuboCop
           loc.begin && loc.begin.source.start_with?('%')
         end
       end
+
+      # Checks whether the `array` literal is delimited by either percent or
+      # square brackets
+      #
+      # @return [Boolean] whether the array is enclosed in percent or square
+      # brackets
+      def bracketed?
+        square_brackets? || percent_literal?
+      end
     end
   end
 end