rubocop 0.42.0 → 0.52.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/LICENSE.txt +1 -1
- data/README.md +106 -20
- data/assets/output.html.erb +21 -10
- data/bin/rubocop +1 -2
- data/config/default.yml +914 -483
- data/config/disabled.yml +61 -41
- data/config/enabled.yml +1396 -878
- data/lib/rubocop/ast/builder.rb +72 -0
- data/lib/rubocop/ast/node/and_node.rb +37 -0
- data/lib/rubocop/ast/node/args_node.rb +29 -0
- data/lib/rubocop/ast/node/array_node.rb +57 -0
- data/lib/rubocop/ast/node/block_node.rb +116 -0
- data/lib/rubocop/ast/node/case_node.rb +64 -0
- data/lib/rubocop/ast/node/def_node.rb +71 -0
- data/lib/rubocop/ast/node/ensure_node.rb +25 -0
- data/lib/rubocop/ast/node/for_node.rb +61 -0
- data/lib/rubocop/ast/node/hash_node.rb +109 -0
- data/lib/rubocop/ast/node/if_node.rb +146 -0
- data/lib/rubocop/ast/node/keyword_splat_node.rb +45 -0
- data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +16 -0
- data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +23 -0
- data/lib/rubocop/ast/node/mixin/collection_node.rb +15 -0
- data/lib/rubocop/ast/node/mixin/conditional_node.rb +45 -0
- data/lib/rubocop/ast/node/mixin/hash_element_node.rb +125 -0
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +174 -0
- data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +89 -0
- data/lib/rubocop/ast/node/mixin/modifier_node.rb +17 -0
- data/lib/rubocop/ast/node/mixin/parameterized_node.rb +61 -0
- data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +35 -0
- data/lib/rubocop/ast/node/or_node.rb +37 -0
- data/lib/rubocop/ast/node/pair_node.rb +64 -0
- data/lib/rubocop/ast/node/regexp_node.rb +35 -0
- data/lib/rubocop/ast/node/resbody_node.rb +25 -0
- data/lib/rubocop/ast/node/send_node.rb +45 -0
- data/lib/rubocop/ast/node/str_node.rb +14 -0
- data/lib/rubocop/ast/node/super_node.rb +21 -0
- data/lib/rubocop/ast/node/symbol_node.rb +20 -0
- data/lib/rubocop/ast/node/until_node.rb +43 -0
- data/lib/rubocop/ast/node/when_node.rb +61 -0
- data/lib/rubocop/ast/node/while_node.rb +43 -0
- data/lib/rubocop/ast/node/yield_node.rb +21 -0
- data/lib/rubocop/ast/node.rb +634 -0
- data/lib/rubocop/ast/sexp.rb +16 -0
- data/lib/rubocop/{ast_node → ast}/traversal.rb +23 -24
- data/lib/rubocop/cached_data.rb +11 -31
- data/lib/rubocop/cli.rb +116 -33
- data/lib/rubocop/comment_config.rb +4 -10
- data/lib/rubocop/config.rb +355 -102
- data/lib/rubocop/config_loader.rb +93 -78
- data/lib/rubocop/config_loader_resolver.rb +106 -7
- data/lib/rubocop/config_store.rb +4 -1
- data/lib/rubocop/cop/autocorrect_logic.rb +1 -2
- data/lib/rubocop/cop/badge.rb +73 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +71 -0
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +67 -0
- data/lib/rubocop/cop/bundler/ordered_gems.rb +71 -0
- data/lib/rubocop/cop/commissioner.rb +27 -10
- data/lib/rubocop/cop/cop.rb +62 -107
- data/lib/rubocop/cop/corrector.rb +0 -1
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +121 -0
- data/lib/rubocop/cop/correctors/condition_corrector.rb +28 -0
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +26 -0
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +62 -0
- data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +44 -0
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +31 -0
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +29 -0
- data/lib/rubocop/cop/correctors/space_corrector.rb +34 -0
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +25 -0
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +31 -0
- data/lib/rubocop/cop/force.rb +0 -1
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +102 -0
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +106 -0
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +87 -0
- data/lib/rubocop/cop/generator/require_file_injector.rb +78 -0
- data/lib/rubocop/cop/generator.rb +191 -0
- data/lib/rubocop/cop/ignored_node.rb +0 -1
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +46 -0
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +44 -0
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +54 -0
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +59 -0
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +71 -0
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +52 -0
- data/lib/rubocop/cop/internal_affairs.rb +8 -0
- data/lib/rubocop/cop/{style → layout}/access_modifier_indentation.rb +39 -10
- data/lib/rubocop/cop/layout/align_array.rb +39 -0
- data/lib/rubocop/cop/layout/align_hash.rb +235 -0
- data/lib/rubocop/cop/{style → layout}/align_parameters.rb +38 -19
- data/lib/rubocop/cop/{style → layout}/block_end_newline.rb +26 -8
- data/lib/rubocop/cop/layout/case_indentation.rb +160 -0
- data/lib/rubocop/cop/layout/class_structure.rb +306 -0
- data/lib/rubocop/cop/{style → layout}/closing_parenthesis_indentation.rb +18 -13
- data/lib/rubocop/cop/{style → layout}/comment_indentation.rb +48 -6
- data/lib/rubocop/cop/{style → layout}/dot_position.rb +34 -21
- data/lib/rubocop/cop/{style → layout}/else_alignment.rb +55 -37
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +63 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +147 -0
- data/lib/rubocop/cop/{style → layout}/empty_lines.rb +17 -4
- data/lib/rubocop/cop/{style → layout}/empty_lines_around_access_modifier.rb +40 -24
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +87 -0
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +46 -0
- data/lib/rubocop/cop/{style → layout}/empty_lines_around_block_body.rb +9 -12
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +68 -0
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +135 -0
- data/lib/rubocop/cop/{style → layout}/empty_lines_around_method_body.rb +10 -7
- data/lib/rubocop/cop/{style → layout}/empty_lines_around_module_body.rb +27 -9
- data/lib/rubocop/cop/layout/end_of_line.rb +52 -0
- data/lib/rubocop/cop/{style → layout}/extra_spacing.rb +63 -53
- data/lib/rubocop/cop/{style → layout}/first_array_element_line_break.rb +5 -2
- data/lib/rubocop/cop/{style → layout}/first_hash_element_line_break.rb +5 -2
- data/lib/rubocop/cop/{style → layout}/first_method_argument_line_break.rb +7 -4
- data/lib/rubocop/cop/{style → layout}/first_method_parameter_line_break.rb +8 -5
- data/lib/rubocop/cop/{style → layout}/first_parameter_indentation.rb +32 -26
- data/lib/rubocop/cop/{style → layout}/indent_array.rb +75 -25
- data/lib/rubocop/cop/{style → layout}/indent_assignment.rb +9 -6
- data/lib/rubocop/cop/{style → layout}/indent_hash.rb +80 -31
- data/lib/rubocop/cop/layout/indent_heredoc.rb +208 -0
- data/lib/rubocop/cop/{style → layout}/indentation_consistency.rb +7 -5
- data/lib/rubocop/cop/{style → layout}/indentation_width.rb +151 -117
- data/lib/rubocop/cop/layout/initial_indentation.rb +45 -0
- data/lib/rubocop/cop/layout/leading_comment_space.rb +58 -0
- data/lib/rubocop/cop/{style → layout}/multiline_array_brace_layout.rb +52 -16
- data/lib/rubocop/cop/{style → layout}/multiline_assignment_layout.rb +18 -21
- data/lib/rubocop/cop/{style → layout}/multiline_block_layout.rb +37 -43
- data/lib/rubocop/cop/{style → layout}/multiline_hash_brace_layout.rb +55 -15
- data/lib/rubocop/cop/{style → layout}/multiline_method_call_brace_layout.rb +15 -4
- data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +221 -0
- data/lib/rubocop/cop/{style → layout}/multiline_method_definition_brace_layout.rb +12 -5
- data/lib/rubocop/cop/{style → layout}/multiline_operation_indentation.rb +23 -13
- data/lib/rubocop/cop/{style → layout}/rescue_ensure_alignment.rb +24 -13
- data/lib/rubocop/cop/{style → layout}/space_after_colon.rb +17 -13
- data/lib/rubocop/cop/layout/space_after_comma.rb +35 -0
- data/lib/rubocop/cop/{style → layout}/space_after_method_name.rb +11 -11
- data/lib/rubocop/cop/layout/space_after_not.rb +38 -0
- data/lib/rubocop/cop/{style → layout}/space_after_semicolon.rb +14 -4
- data/lib/rubocop/cop/{style → layout}/space_around_block_parameters.rb +52 -28
- data/lib/rubocop/cop/{style → layout}/space_around_equals_in_parameter_default.rb +29 -21
- data/lib/rubocop/cop/{style → layout}/space_around_keyword.rb +33 -29
- data/lib/rubocop/cop/layout/space_around_operators.rb +159 -0
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +107 -0
- data/lib/rubocop/cop/layout/space_before_comma.rb +31 -0
- data/lib/rubocop/cop/{style → layout}/space_before_comment.rb +11 -7
- data/lib/rubocop/cop/{style → layout}/space_before_first_arg.rb +23 -20
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +27 -0
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +85 -0
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +236 -0
- data/lib/rubocop/cop/{style → layout}/space_inside_array_percent_literal.rb +8 -8
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +228 -0
- data/lib/rubocop/cop/{style → layout}/space_inside_hash_literal_braces.rb +91 -51
- data/lib/rubocop/cop/layout/space_inside_parens.rb +53 -0
- data/lib/rubocop/cop/{style → layout}/space_inside_percent_literal_delimiters.rb +14 -13
- data/lib/rubocop/cop/{style → layout}/space_inside_range_literal.rb +16 -17
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +90 -0
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +80 -0
- data/lib/rubocop/cop/{style → layout}/tab.rb +8 -6
- data/lib/rubocop/cop/{style → layout}/trailing_blank_lines.rb +14 -15
- data/lib/rubocop/cop/{style → layout}/trailing_whitespace.rb +3 -4
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +59 -0
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +13 -9
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +7 -1
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +55 -25
- data/lib/rubocop/cop/lint/block_alignment.rb +75 -34
- data/lib/rubocop/cop/lint/boolean_symbol.rb +38 -0
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +17 -15
- data/lib/rubocop/cop/lint/condition_position.rb +16 -15
- data/lib/rubocop/cop/lint/debugger.rb +57 -23
- data/lib/rubocop/cop/lint/def_end_alignment.rb +28 -14
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +19 -10
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +53 -0
- data/lib/rubocop/cop/lint/duplicate_methods.rb +108 -14
- data/lib/rubocop/cop/lint/duplicated_key.rb +16 -9
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +15 -6
- data/lib/rubocop/cop/lint/else_layout.rb +27 -31
- data/lib/rubocop/cop/lint/empty_ensure.rb +44 -3
- data/lib/rubocop/cop/lint/empty_expression.rb +42 -0
- data/lib/rubocop/cop/lint/empty_interpolation.rb +16 -3
- data/lib/rubocop/cop/lint/empty_when.rb +38 -0
- data/lib/rubocop/cop/lint/end_alignment.rb +57 -39
- data/lib/rubocop/cop/lint/end_in_method.rb +24 -2
- data/lib/rubocop/cop/lint/ensure_return.rb +23 -3
- data/lib/rubocop/cop/lint/float_out_of_range.rb +10 -6
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +67 -46
- data/lib/rubocop/cop/lint/handle_exceptions.rb +41 -4
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +9 -5
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +42 -29
- data/lib/rubocop/cop/lint/inherit_exception.rb +34 -23
- data/lib/rubocop/cop/lint/interpolation_check.rb +37 -0
- data/lib/rubocop/cop/lint/{literal_in_condition.rb → literal_as_condition.rb} +51 -40
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +13 -8
- data/lib/rubocop/cop/lint/loop.rb +37 -2
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +81 -0
- data/lib/rubocop/cop/lint/multiple_compare.rb +48 -0
- data/lib/rubocop/cop/lint/nested_method_definition.rb +54 -12
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +58 -0
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +7 -3
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +32 -23
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +22 -14
- data/lib/rubocop/cop/lint/percent_string_array.rb +42 -27
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +28 -19
- data/lib/rubocop/cop/lint/rand_one.rb +17 -8
- data/lib/rubocop/cop/lint/redundant_with_index.rb +80 -0
- data/lib/rubocop/cop/lint/redundant_with_object.rb +81 -0
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +29 -0
- data/lib/rubocop/cop/lint/require_parentheses.rb +24 -30
- data/lib/rubocop/cop/lint/rescue_exception.rb +21 -2
- data/lib/rubocop/cop/lint/rescue_type.rb +90 -0
- data/lib/rubocop/cop/lint/return_in_void_context.rb +74 -0
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +70 -0
- data/lib/rubocop/cop/lint/script_permission.rb +49 -0
- data/lib/rubocop/cop/lint/shadowed_argument.rb +146 -0
- data/lib/rubocop/cop/lint/shadowed_exception.rb +78 -57
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +25 -2
- data/lib/rubocop/cop/lint/string_conversion_in_interpolation.rb +18 -12
- data/lib/rubocop/cop/lint/syntax.rb +23 -21
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +26 -4
- data/lib/rubocop/cop/lint/unified_integer.rb +43 -0
- data/lib/rubocop/cop/lint/unneeded_disable.rb +117 -56
- data/lib/rubocop/cop/lint/unneeded_require_statement.rb +51 -0
- data/lib/rubocop/cop/lint/unneeded_splat_expansion.rb +167 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +72 -8
- data/lib/rubocop/cop/lint/unused_block_argument.rb +87 -27
- data/lib/rubocop/cop/lint/unused_method_argument.rb +18 -2
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +75 -0
- data/lib/rubocop/cop/lint/uri_regexp.rb +73 -0
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +40 -18
- data/lib/rubocop/cop/lint/useless_assignment.rb +45 -14
- data/lib/rubocop/cop/lint/useless_comparison.rb +8 -10
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +16 -2
- data/lib/rubocop/cop/lint/useless_setter_call.rb +57 -43
- data/lib/rubocop/cop/lint/void.rb +83 -23
- data/lib/rubocop/cop/message_annotator.rb +118 -0
- data/lib/rubocop/cop/metrics/abc_size.rb +3 -4
- data/lib/rubocop/cop/metrics/block_length.rb +32 -0
- data/lib/rubocop/cop/metrics/block_nesting.rb +21 -10
- data/lib/rubocop/cop/metrics/class_length.rb +3 -2
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +4 -4
- data/lib/rubocop/cop/metrics/line_length.rb +67 -14
- data/lib/rubocop/cop/metrics/method_length.rb +10 -10
- data/lib/rubocop/cop/metrics/module_length.rb +3 -2
- data/lib/rubocop/cop/metrics/parameter_lists.rb +15 -6
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +5 -6
- data/lib/rubocop/cop/mixin/alignment.rb +70 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +0 -1
- data/lib/rubocop/cop/mixin/array_hash_indentation.rb +26 -22
- data/lib/rubocop/cop/mixin/array_min_size.rb +59 -0
- data/lib/rubocop/cop/mixin/array_syntax.rb +4 -12
- data/lib/rubocop/cop/mixin/check_assignment.rb +6 -7
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -1
- data/lib/rubocop/cop/mixin/code_length.rb +4 -3
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +21 -16
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +48 -0
- data/lib/rubocop/cop/mixin/configurable_max.rb +5 -4
- data/lib/rubocop/cop/mixin/configurable_naming.rb +5 -35
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +17 -0
- data/lib/rubocop/cop/mixin/def_node.rb +29 -0
- data/lib/rubocop/cop/mixin/documentation_comment.rb +46 -0
- data/lib/rubocop/cop/mixin/duplication.rb +46 -0
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +119 -27
- data/lib/rubocop/cop/mixin/empty_parameter.rb +23 -0
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +11 -27
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +30 -0
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +15 -11
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +15 -13
- data/lib/rubocop/cop/mixin/hash_alignment.rb +116 -0
- data/lib/rubocop/cop/mixin/heredoc.rb +28 -0
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +29 -0
- data/lib/rubocop/cop/mixin/integer_node.rb +2 -1
- data/lib/rubocop/cop/mixin/match_range.rb +4 -6
- data/lib/rubocop/cop/mixin/method_complexity.rb +33 -8
- data/lib/rubocop/cop/mixin/method_preference.rb +2 -1
- data/lib/rubocop/cop/mixin/min_body_length.rb +2 -1
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +100 -66
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +49 -51
- data/lib/rubocop/cop/mixin/negative_conditional.rb +18 -13
- data/lib/rubocop/cop/mixin/on_normal_if_unless.rb +1 -25
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +48 -0
- data/lib/rubocop/cop/mixin/parentheses.rb +2 -8
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +4 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +52 -0
- data/lib/rubocop/cop/mixin/percent_literal.rb +69 -6
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +16 -5
- data/lib/rubocop/cop/mixin/rescue_node.rb +23 -0
- data/lib/rubocop/cop/mixin/safe_assignment.rb +3 -1
- data/lib/rubocop/cop/mixin/safe_mode.rb +22 -0
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +8 -10
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +10 -14
- data/lib/rubocop/cop/mixin/statement_modifier.rb +29 -32
- data/lib/rubocop/cop/mixin/string_help.rb +3 -2
- data/lib/rubocop/cop/mixin/string_literals_help.rb +3 -15
- data/lib/rubocop/cop/mixin/surrounding_space.rb +78 -9
- data/lib/rubocop/cop/mixin/target_rails_version.rb +16 -0
- data/lib/rubocop/cop/mixin/target_ruby_version.rb +16 -0
- data/lib/rubocop/cop/mixin/too_many_lines.rb +39 -0
- data/lib/rubocop/cop/mixin/trailing_comma.rb +37 -38
- data/lib/rubocop/cop/mixin/unused_argument.rb +6 -16
- data/lib/rubocop/cop/naming/accessor_method_name.rb +55 -0
- data/lib/rubocop/cop/{style → naming}/ascii_identifiers.rb +36 -5
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +42 -0
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +33 -0
- data/lib/rubocop/cop/naming/constant_name.rb +58 -0
- data/lib/rubocop/cop/{style → naming}/file_name.rb +72 -29
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +62 -0
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +59 -0
- data/lib/rubocop/cop/naming/method_name.rb +40 -0
- data/lib/rubocop/cop/naming/predicate_name.rb +101 -0
- data/lib/rubocop/cop/naming/variable_name.rb +50 -0
- data/lib/rubocop/cop/naming/variable_number.rb +61 -0
- data/lib/rubocop/cop/offense.rb +9 -5
- data/lib/rubocop/cop/performance/caller.rb +69 -0
- data/lib/rubocop/cop/performance/case_when_splat.rb +65 -89
- data/lib/rubocop/cop/performance/casecmp.rb +37 -25
- data/lib/rubocop/cop/performance/compare_with_block.rb +117 -0
- data/lib/rubocop/cop/performance/count.rb +33 -43
- data/lib/rubocop/cop/performance/detect.rb +30 -31
- data/lib/rubocop/cop/performance/double_start_end_with.rb +55 -26
- data/lib/rubocop/cop/performance/end_with.rb +9 -9
- data/lib/rubocop/cop/performance/fixed_size.rb +21 -17
- data/lib/rubocop/cop/performance/flat_map.rb +30 -33
- data/lib/rubocop/cop/performance/hash_each_methods.rb +129 -0
- data/lib/rubocop/cop/performance/lstrip_rstrip.rb +14 -14
- data/lib/rubocop/cop/performance/range_include.rb +5 -4
- data/lib/rubocop/cop/performance/redundant_block_call.rb +28 -29
- data/lib/rubocop/cop/performance/redundant_match.rb +19 -15
- data/lib/rubocop/cop/performance/redundant_merge.rb +100 -52
- data/lib/rubocop/cop/performance/redundant_sort_by.rb +17 -14
- data/lib/rubocop/cop/performance/regexp_match.rb +224 -0
- data/lib/rubocop/cop/performance/reverse_each.rb +3 -6
- data/lib/rubocop/cop/performance/sample.rb +84 -83
- data/lib/rubocop/cop/performance/size.rb +22 -15
- data/lib/rubocop/cop/performance/start_with.rb +9 -9
- data/lib/rubocop/cop/performance/string_replacement.rb +35 -70
- data/lib/rubocop/cop/performance/times_map.rb +33 -24
- data/lib/rubocop/cop/performance/unfreeze_string.rb +50 -0
- data/lib/rubocop/cop/performance/uri_default_parser.rb +47 -0
- data/lib/rubocop/cop/rails/action_filter.rb +67 -47
- data/lib/rubocop/cop/rails/active_support_aliases.rb +68 -0
- data/lib/rubocop/cop/rails/application_job.rb +40 -0
- data/lib/rubocop/cop/rails/application_record.rb +40 -0
- data/lib/rubocop/cop/rails/blank.rb +142 -0
- data/lib/rubocop/cop/rails/create_table_with_timestamps.rb +82 -0
- data/lib/rubocop/cop/rails/date.rb +47 -42
- data/lib/rubocop/cop/rails/delegate.rb +55 -33
- data/lib/rubocop/cop/rails/delegate_allow_blank.rb +51 -0
- data/lib/rubocop/cop/rails/dynamic_find_by.rb +82 -0
- data/lib/rubocop/cop/rails/enum_uniqueness.rb +45 -0
- data/lib/rubocop/cop/rails/environment_comparison.rb +66 -0
- data/lib/rubocop/cop/rails/exit.rb +17 -11
- data/lib/rubocop/cop/rails/file_path.rb +72 -0
- data/lib/rubocop/cop/rails/find_by.rb +14 -20
- data/lib/rubocop/cop/rails/find_each.rb +8 -21
- data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +9 -2
- data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb +84 -0
- data/lib/rubocop/cop/rails/http_positional_arguments.rb +102 -0
- data/lib/rubocop/cop/rails/inverse_of.rb +218 -0
- data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb +112 -0
- data/lib/rubocop/cop/rails/not_null_column.rb +67 -0
- data/lib/rubocop/cop/rails/output.rb +15 -13
- data/lib/rubocop/cop/rails/output_safety.rb +65 -17
- data/lib/rubocop/cop/rails/pluralization_grammar.rb +30 -29
- data/lib/rubocop/cop/rails/presence.rb +118 -0
- data/lib/rubocop/cop/rails/present.rb +143 -0
- data/lib/rubocop/cop/rails/read_write_attribute.rb +20 -26
- data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb +133 -0
- data/lib/rubocop/cop/rails/relative_date_constant.rb +88 -0
- data/lib/rubocop/cop/rails/request_referer.rb +28 -13
- data/lib/rubocop/cop/rails/reversible_migration.rb +281 -0
- data/lib/rubocop/cop/rails/safe_navigation.rb +90 -0
- data/lib/rubocop/cop/rails/save_bang.rb +104 -19
- data/lib/rubocop/cop/rails/scope_args.rb +5 -10
- data/lib/rubocop/cop/rails/skips_model_validations.rb +70 -0
- data/lib/rubocop/cop/rails/time_zone.rb +34 -21
- data/lib/rubocop/cop/rails/uniq_before_pluck.rb +17 -14
- data/lib/rubocop/cop/rails/unknown_env.rb +63 -0
- data/lib/rubocop/cop/rails/validation.rb +16 -20
- data/lib/rubocop/cop/registry.rb +172 -0
- data/lib/rubocop/cop/security/eval.rb +30 -0
- data/lib/rubocop/cop/security/json_load.rb +46 -0
- data/lib/rubocop/cop/security/marshal_load.rb +39 -0
- data/lib/rubocop/cop/security/yaml_load.rb +37 -0
- data/lib/rubocop/cop/severity.rb +1 -2
- data/lib/rubocop/cop/style/alias.rb +54 -33
- data/lib/rubocop/cop/style/and_or.rb +77 -63
- data/lib/rubocop/cop/style/array_join.rb +13 -9
- data/lib/rubocop/cop/style/ascii_comments.rb +25 -7
- data/lib/rubocop/cop/style/attr.rb +24 -11
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +21 -16
- data/lib/rubocop/cop/style/bare_percent_literals.rb +31 -11
- data/lib/rubocop/cop/style/begin_block.rb +1 -2
- data/lib/rubocop/cop/style/block_comments.rb +20 -11
- data/lib/rubocop/cop/style/block_delimiters.rb +122 -51
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +142 -54
- data/lib/rubocop/cop/style/case_equality.rb +15 -4
- data/lib/rubocop/cop/style/character_literal.rb +12 -5
- data/lib/rubocop/cop/style/class_and_module_children.rb +85 -6
- data/lib/rubocop/cop/style/class_check.rb +35 -19
- data/lib/rubocop/cop/style/class_methods.rb +13 -14
- data/lib/rubocop/cop/style/class_vars.rb +5 -5
- data/lib/rubocop/cop/style/collection_methods.rb +12 -13
- data/lib/rubocop/cop/style/colon_method_call.rb +24 -16
- data/lib/rubocop/cop/style/colon_method_definition.rb +36 -0
- data/lib/rubocop/cop/style/command_literal.rb +98 -32
- data/lib/rubocop/cop/style/comment_annotation.rb +41 -15
- data/lib/rubocop/cop/style/commented_keyword.rb +84 -0
- data/lib/rubocop/cop/style/conditional_assignment.rb +161 -112
- data/lib/rubocop/cop/style/copyright.rb +32 -34
- data/lib/rubocop/cop/style/date_time.rb +44 -0
- data/lib/rubocop/cop/style/def_with_parentheses.rb +32 -9
- data/lib/rubocop/cop/style/dir.rb +48 -0
- data/lib/rubocop/cop/style/documentation.rb +44 -58
- data/lib/rubocop/cop/style/documentation_method.rb +76 -0
- data/lib/rubocop/cop/style/double_negation.rb +3 -3
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +14 -13
- data/lib/rubocop/cop/style/each_with_object.rb +28 -25
- data/lib/rubocop/cop/style/empty_block_parameter.rb +47 -0
- data/lib/rubocop/cop/style/empty_case_condition.rb +18 -30
- data/lib/rubocop/cop/style/empty_else.rb +82 -51
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +43 -0
- data/lib/rubocop/cop/style/empty_literal.rb +76 -48
- data/lib/rubocop/cop/style/empty_method.rb +112 -0
- data/lib/rubocop/cop/style/encoding.rb +10 -40
- data/lib/rubocop/cop/style/end_block.rb +1 -2
- data/lib/rubocop/cop/style/eval_with_location.rb +146 -0
- data/lib/rubocop/cop/style/even_odd.rb +25 -44
- data/lib/rubocop/cop/style/flip_flop.rb +13 -3
- data/lib/rubocop/cop/style/for.rb +19 -15
- data/lib/rubocop/cop/style/format_string.rb +88 -42
- data/lib/rubocop/cop/style/format_string_token.rb +163 -0
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +90 -15
- data/lib/rubocop/cop/style/global_vars.rb +14 -5
- data/lib/rubocop/cop/style/guard_clause.rb +22 -62
- data/lib/rubocop/cop/style/hash_syntax.rb +109 -59
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +73 -32
- data/lib/rubocop/cop/style/if_inside_else.rb +16 -20
- data/lib/rubocop/cop/style/if_unless_modifier.rb +48 -39
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +6 -12
- data/lib/rubocop/cop/style/if_with_semicolon.rb +10 -2
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +7 -7
- data/lib/rubocop/cop/style/infinite_loop.rb +33 -32
- data/lib/rubocop/cop/style/inline_comment.rb +17 -5
- data/lib/rubocop/cop/style/inverse_methods.rb +149 -0
- data/lib/rubocop/cop/style/lambda.rb +66 -63
- data/lib/rubocop/cop/style/lambda_call.rb +50 -20
- data/lib/rubocop/cop/style/line_end_concatenation.rb +38 -17
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +90 -0
- data/lib/rubocop/cop/style/{method_call_parentheses.rb → method_call_without_args_parentheses.rb} +32 -25
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +9 -9
- data/lib/rubocop/cop/style/method_def_parentheses.rb +101 -29
- data/lib/rubocop/cop/style/method_missing.rb +14 -20
- data/lib/rubocop/cop/style/min_max.rb +68 -0
- data/lib/rubocop/cop/style/missing_else.rb +61 -21
- data/lib/rubocop/cop/style/mixin_grouping.rb +145 -0
- data/lib/rubocop/cop/style/mixin_usage.rb +82 -0
- data/lib/rubocop/cop/style/module_function.rb +44 -18
- data/lib/rubocop/cop/style/multiline_block_chain.rb +8 -15
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +67 -0
- data/lib/rubocop/cop/style/multiline_if_then.rb +21 -14
- data/lib/rubocop/cop/style/multiline_memoization.rb +93 -0
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +21 -9
- data/lib/rubocop/cop/style/multiple_comparison.rb +77 -0
- data/lib/rubocop/cop/style/mutable_constant.rb +17 -9
- data/lib/rubocop/cop/style/negated_if.rb +76 -25
- data/lib/rubocop/cop/style/negated_while.rb +4 -22
- data/lib/rubocop/cop/style/nested_modifier.rb +17 -47
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +32 -28
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +3 -6
- data/lib/rubocop/cop/style/next.rb +72 -53
- data/lib/rubocop/cop/style/nil_comparison.rb +10 -14
- data/lib/rubocop/cop/style/non_nil_check.rb +69 -62
- data/lib/rubocop/cop/style/not.rb +19 -13
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +16 -7
- data/lib/rubocop/cop/style/numeric_literals.rb +33 -12
- data/lib/rubocop/cop/style/numeric_predicate.rb +30 -32
- data/lib/rubocop/cop/style/one_line_conditional.rb +21 -17
- data/lib/rubocop/cop/style/option_hash.rb +11 -37
- data/lib/rubocop/cop/style/optional_arguments.rb +20 -9
- data/lib/rubocop/cop/style/or_assignment.rb +88 -0
- data/lib/rubocop/cop/style/parallel_assignment.rb +83 -64
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +37 -19
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +50 -15
- data/lib/rubocop/cop/style/percent_q_literals.rb +40 -17
- data/lib/rubocop/cop/style/perl_backrefs.rb +9 -3
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +48 -14
- data/lib/rubocop/cop/style/proc.rb +13 -10
- data/lib/rubocop/cop/style/raise_args.rb +46 -50
- data/lib/rubocop/cop/style/random_with_offset.rb +160 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +16 -6
- data/lib/rubocop/cop/style/redundant_conditional.rb +96 -0
- data/lib/rubocop/cop/style/redundant_exception.rb +4 -5
- data/lib/rubocop/cop/style/redundant_freeze.rb +7 -10
- data/lib/rubocop/cop/style/redundant_parentheses.rb +70 -31
- data/lib/rubocop/cop/style/redundant_return.rb +61 -23
- data/lib/rubocop/cop/style/redundant_self.rb +62 -60
- data/lib/rubocop/cop/style/regexp_literal.rb +100 -34
- data/lib/rubocop/cop/style/rescue_modifier.rb +15 -17
- data/lib/rubocop/cop/style/rescue_standard_error.rb +122 -0
- data/lib/rubocop/cop/style/return_nil.rb +89 -0
- data/lib/rubocop/cop/style/safe_navigation.rb +197 -0
- data/lib/rubocop/cop/style/self_assignment.rb +20 -17
- data/lib/rubocop/cop/style/semicolon.rb +25 -17
- data/lib/rubocop/cop/style/send.rb +14 -4
- data/lib/rubocop/cop/style/signal_exception.rb +105 -7
- data/lib/rubocop/cop/style/single_line_block_params.rb +27 -21
- data/lib/rubocop/cop/style/single_line_methods.rb +45 -31
- data/lib/rubocop/cop/style/special_global_vars.rb +32 -28
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +24 -53
- data/lib/rubocop/cop/style/stderr_puts.rb +54 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +36 -0
- data/lib/rubocop/cop/style/string_literals.rb +31 -5
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +20 -2
- data/lib/rubocop/cop/style/string_methods.rb +22 -9
- data/lib/rubocop/cop/style/struct_inheritance.rb +5 -17
- data/lib/rubocop/cop/style/symbol_array.rb +39 -65
- data/lib/rubocop/cop/style/symbol_literal.rb +1 -2
- data/lib/rubocop/cop/style/symbol_proc.rb +35 -52
- data/lib/rubocop/cop/style/ternary_parentheses.rb +143 -42
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +101 -0
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +31 -20
- data/lib/rubocop/cop/style/trailing_comma_in_literal.rb +26 -8
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +95 -0
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +97 -37
- data/lib/rubocop/cop/style/trivial_accessors.rb +72 -66
- data/lib/rubocop/cop/style/unless_else.rb +19 -13
- data/lib/rubocop/cop/style/unneeded_capital_w.rb +24 -10
- data/lib/rubocop/cop/style/unneeded_interpolation.rb +22 -24
- data/lib/rubocop/cop/style/unneeded_percent_q.rb +28 -22
- data/lib/rubocop/cop/style/variable_interpolation.rb +23 -10
- data/lib/rubocop/cop/style/when_then.rb +18 -4
- data/lib/rubocop/cop/style/while_until_do.rb +34 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +32 -12
- data/lib/rubocop/cop/style/word_array.rb +45 -102
- data/lib/rubocop/cop/style/yoda_condition.rb +107 -0
- data/lib/rubocop/cop/style/zero_length_predicate.rb +55 -32
- data/lib/rubocop/cop/team.rb +33 -35
- data/lib/rubocop/cop/util.rb +120 -54
- data/lib/rubocop/cop/variable_force/assignment.rb +5 -9
- data/lib/rubocop/cop/variable_force/branch.rb +318 -0
- data/lib/rubocop/cop/variable_force/branchable.rb +21 -0
- data/lib/rubocop/cop/variable_force/reference.rb +1 -2
- data/lib/rubocop/cop/variable_force/scope.rb +37 -26
- data/lib/rubocop/cop/variable_force/variable.rb +12 -12
- data/lib/rubocop/cop/variable_force/variable_table.rb +3 -4
- data/lib/rubocop/cop/variable_force.rb +72 -39
- data/lib/rubocop/error.rb +0 -1
- data/lib/rubocop/formatter/base_formatter.rb +4 -9
- data/lib/rubocop/formatter/clang_style_formatter.rb +2 -3
- data/lib/rubocop/formatter/colorizable.rb +9 -10
- data/lib/rubocop/formatter/disabled_config_formatter.rb +48 -35
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -1
- data/lib/rubocop/formatter/emacs_style_formatter.rb +0 -1
- data/lib/rubocop/formatter/file_list_formatter.rb +0 -1
- data/lib/rubocop/formatter/formatter_set.rb +16 -13
- data/lib/rubocop/formatter/fuubar_style_formatter.rb +6 -1
- data/lib/rubocop/formatter/html_formatter.rb +5 -5
- data/lib/rubocop/formatter/json_formatter.rb +9 -4
- data/lib/rubocop/formatter/offense_count_formatter.rb +2 -1
- data/lib/rubocop/formatter/progress_formatter.rb +0 -1
- data/lib/rubocop/formatter/quiet_formatter.rb +13 -0
- data/lib/rubocop/formatter/simple_text_formatter.rb +7 -17
- data/lib/rubocop/formatter/tap_formatter.rb +71 -0
- data/lib/rubocop/formatter/text_util.rb +0 -1
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +6 -5
- data/lib/rubocop/magic_comment.rb +210 -0
- data/lib/rubocop/name_similarity.rb +0 -1
- data/lib/rubocop/node_pattern.rb +181 -118
- data/lib/rubocop/options.rb +154 -88
- data/lib/rubocop/path_util.rb +38 -4
- data/lib/rubocop/platform.rb +11 -0
- data/lib/rubocop/processed_source.rb +23 -20
- data/lib/rubocop/rake_task.rb +16 -24
- data/lib/rubocop/remote_config.rb +40 -13
- data/lib/rubocop/result_cache.rb +33 -24
- data/lib/rubocop/rspec/cop_helper.rb +21 -7
- data/lib/rubocop/rspec/expect_offense.rb +165 -0
- data/lib/rubocop/rspec/host_environment_simulation_helper.rb +1 -2
- data/lib/rubocop/rspec/shared_contexts.rb +24 -9
- data/lib/rubocop/rspec/shared_examples.rb +10 -19
- data/lib/rubocop/rspec/support.rb +5 -5
- data/lib/rubocop/runner.rb +74 -39
- data/lib/rubocop/string_interpreter.rb +0 -1
- data/lib/rubocop/string_util.rb +11 -6
- data/lib/rubocop/target_finder.rb +70 -8
- data/lib/rubocop/token.rb +79 -2
- data/lib/rubocop/version.rb +2 -5
- data/lib/rubocop/warning.rb +0 -1
- data/lib/rubocop.rb +569 -398
- metadata +301 -112
- data/lib/rubocop/ast_node/builder.rb +0 -31
- data/lib/rubocop/ast_node/sexp.rb +0 -14
- data/lib/rubocop/ast_node.rb +0 -623
- data/lib/rubocop/cop/lint/eval.rb +0 -23
- data/lib/rubocop/cop/lint/invalid_character_literal.rb +0 -39
- data/lib/rubocop/cop/lint/useless_array_splat.rb +0 -56
- data/lib/rubocop/cop/mixin/access_modifier_node.rb +0 -42
- data/lib/rubocop/cop/mixin/autocorrect_alignment.rb +0 -152
- data/lib/rubocop/cop/mixin/hash_node.rb +0 -15
- data/lib/rubocop/cop/mixin/if_node.rb +0 -37
- data/lib/rubocop/cop/mixin/on_method_def.rb +0 -31
- data/lib/rubocop/cop/mixin/space_inside.rb +0 -79
- data/lib/rubocop/cop/performance/hash_each.rb +0 -86
- data/lib/rubocop/cop/performance/push_splat.rb +0 -47
- data/lib/rubocop/cop/style/accessor_method_name.rb +0 -46
- data/lib/rubocop/cop/style/align_array.rb +0 -21
- data/lib/rubocop/cop/style/align_hash.rb +0 -256
- data/lib/rubocop/cop/style/case_indentation.rb +0 -92
- data/lib/rubocop/cop/style/class_and_module_camel_case.rb +0 -30
- data/lib/rubocop/cop/style/constant_name.rb +0 -30
- data/lib/rubocop/cop/style/empty_line_between_defs.rb +0 -76
- data/lib/rubocop/cop/style/empty_lines_around_class_body.rb +0 -40
- data/lib/rubocop/cop/style/end_of_line.rb +0 -31
- data/lib/rubocop/cop/style/initial_indentation.rb +0 -38
- data/lib/rubocop/cop/style/leading_comment_space.rb +0 -33
- data/lib/rubocop/cop/style/method_name.rb +0 -29
- data/lib/rubocop/cop/style/multiline_method_call_indentation.rb +0 -176
- data/lib/rubocop/cop/style/op_method.rb +0 -44
- data/lib/rubocop/cop/style/predicate_name.rb +0 -68
- data/lib/rubocop/cop/style/space_after_comma.rb +0 -22
- data/lib/rubocop/cop/style/space_after_not.rb +0 -42
- data/lib/rubocop/cop/style/space_around_operators.rb +0 -132
- data/lib/rubocop/cop/style/space_before_block_braces.rb +0 -65
- data/lib/rubocop/cop/style/space_before_comma.rb +0 -17
- data/lib/rubocop/cop/style/space_before_semicolon.rb +0 -17
- data/lib/rubocop/cop/style/space_inside_block_braces.rb +0 -166
- data/lib/rubocop/cop/style/space_inside_brackets.rb +0 -21
- data/lib/rubocop/cop/style/space_inside_parens.rb +0 -17
- data/lib/rubocop/cop/style/space_inside_string_interpolation.rb +0 -52
- data/lib/rubocop/cop/style/variable_name.rb +0 -40
- data/lib/rubocop/cop/variable_force/locatable.rb +0 -197
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
@@ -8,23 +7,24 @@ module RuboCop
|
|
8
7
|
# Comment lines can optionally be ignored.
|
9
8
|
# The maximum allowed length is configurable.
|
10
9
|
class MethodLength < Cop
|
11
|
-
include
|
12
|
-
include CodeLength
|
10
|
+
include TooManyLines
|
13
11
|
|
14
|
-
|
12
|
+
LABEL = 'Method'.freeze
|
15
13
|
|
16
|
-
def
|
14
|
+
def on_def(node)
|
17
15
|
check_code_length(node)
|
18
16
|
end
|
17
|
+
alias on_defs on_def
|
19
18
|
|
20
|
-
def
|
21
|
-
|
19
|
+
def on_block(node)
|
20
|
+
return unless node.send_node.method_name == :define_method
|
21
|
+
check_code_length(node)
|
22
22
|
end
|
23
23
|
|
24
|
-
|
25
|
-
lines = node.source.lines.to_a[1..-2] || []
|
24
|
+
private
|
26
25
|
|
27
|
-
|
26
|
+
def cop_label
|
27
|
+
LABEL
|
28
28
|
end
|
29
29
|
end
|
30
30
|
end
|
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
@@ -17,7 +16,9 @@ module RuboCop
|
|
17
16
|
private
|
18
17
|
|
19
18
|
def message(length, max_length)
|
20
|
-
format('Module has too many lines. [
|
19
|
+
format('Module has too many lines. [%<length>d/%<max>d]',
|
20
|
+
length: length,
|
21
|
+
max: max_length)
|
21
22
|
end
|
22
23
|
end
|
23
24
|
end
|
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
@@ -6,29 +5,39 @@ module RuboCop
|
|
6
5
|
module Metrics
|
7
6
|
# This cop checks for methods with too many parameters.
|
8
7
|
# The maximum number of parameters is configurable.
|
9
|
-
#
|
10
|
-
# be excluded from the total count.
|
8
|
+
# Keyword arguments can optionally be excluded from the total count.
|
11
9
|
class ParameterLists < Cop
|
12
10
|
include ConfigurableMax
|
13
11
|
|
14
|
-
MSG = 'Avoid parameter lists longer than
|
12
|
+
MSG = 'Avoid parameter lists longer than %<max>d parameters. ' \
|
13
|
+
'[%<count>d/%<max>d]'.freeze
|
15
14
|
|
16
15
|
def on_args(node)
|
17
16
|
count = args_count(node)
|
18
17
|
return unless count > max_params
|
19
18
|
|
20
|
-
|
19
|
+
return if argument_to_lambda_or_proc?(node)
|
20
|
+
|
21
|
+
add_offense(node) do
|
21
22
|
self.max = count
|
22
23
|
end
|
23
24
|
end
|
24
25
|
|
25
26
|
private
|
26
27
|
|
28
|
+
def_node_matcher :argument_to_lambda_or_proc?, <<-PATTERN
|
29
|
+
^lambda_or_proc?
|
30
|
+
PATTERN
|
31
|
+
|
32
|
+
def message(node)
|
33
|
+
format(MSG, max: max_params, count: args_count(node))
|
34
|
+
end
|
35
|
+
|
27
36
|
def args_count(node)
|
28
37
|
if count_keyword_args?
|
29
38
|
node.children.size
|
30
39
|
else
|
31
|
-
node.children.count { |a|
|
40
|
+
node.children.count { |a| !%i[kwoptarg kwarg].include?(a.type) }
|
32
41
|
end
|
33
42
|
end
|
34
43
|
|
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
@@ -29,11 +28,11 @@ module RuboCop
|
|
29
28
|
# end # 7 complexity points
|
30
29
|
class PerceivedComplexity < Cop
|
31
30
|
include MethodComplexity
|
32
|
-
include IfNode
|
33
31
|
|
34
|
-
MSG = 'Perceived complexity for
|
35
|
-
|
36
|
-
|
32
|
+
MSG = 'Perceived complexity for %<method>s is too high. ' \
|
33
|
+
'[%<complexity>d/%<max>d]'.freeze
|
34
|
+
COUNTED_NODES = %i[if case while until
|
35
|
+
for rescue and or].freeze
|
37
36
|
|
38
37
|
private
|
39
38
|
|
@@ -52,7 +51,7 @@ module RuboCop
|
|
52
51
|
(0.8 + 0.2 * whens.length).round
|
53
52
|
end
|
54
53
|
when :if
|
55
|
-
|
54
|
+
node.else? && !node.elsif? ? 2 : 1
|
56
55
|
else
|
57
56
|
1
|
58
57
|
end
|
@@ -0,0 +1,70 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
# This module checks for nodes that should be aligned to the left or right.
|
6
|
+
# This amount is determined by the instance variable @column_delta.
|
7
|
+
module Alignment
|
8
|
+
private
|
9
|
+
|
10
|
+
SPACE = ' '.freeze
|
11
|
+
|
12
|
+
attr_reader :column_delta
|
13
|
+
|
14
|
+
def configured_indentation_width
|
15
|
+
cop_config['IndentationWidth'] ||
|
16
|
+
config.for_cop('IndentationWidth')['Width']
|
17
|
+
end
|
18
|
+
|
19
|
+
def indentation(node)
|
20
|
+
offset(node) + (SPACE * configured_indentation_width)
|
21
|
+
end
|
22
|
+
|
23
|
+
def offset(node)
|
24
|
+
SPACE * node.loc.column
|
25
|
+
end
|
26
|
+
|
27
|
+
def check_alignment(items, base_column = nil)
|
28
|
+
unless items.empty?
|
29
|
+
base_column ||= display_column(items.first.source_range)
|
30
|
+
end
|
31
|
+
|
32
|
+
each_bad_alignment(items, base_column) do |current|
|
33
|
+
expr = current.source_range
|
34
|
+
if offenses.any? { |o| within?(expr, o.location) }
|
35
|
+
# If this offense is within a line range that is already being
|
36
|
+
# realigned by autocorrect, we report the offense without
|
37
|
+
# autocorrecting it. Two rewrites in the same area by the same
|
38
|
+
# cop can not be handled. The next iteration will find the
|
39
|
+
# offense again and correct it.
|
40
|
+
add_offense(nil, location: expr)
|
41
|
+
else
|
42
|
+
add_offense(current)
|
43
|
+
end
|
44
|
+
end
|
45
|
+
end
|
46
|
+
|
47
|
+
def each_bad_alignment(items, base_column)
|
48
|
+
prev_line = -1
|
49
|
+
items.each do |current|
|
50
|
+
if current.loc.line > prev_line &&
|
51
|
+
begins_its_line?(current.source_range)
|
52
|
+
@column_delta = base_column - display_column(current.source_range)
|
53
|
+
|
54
|
+
yield current if @column_delta.nonzero?
|
55
|
+
end
|
56
|
+
prev_line = current.loc.line
|
57
|
+
end
|
58
|
+
end
|
59
|
+
|
60
|
+
def display_column(range)
|
61
|
+
line = processed_source.lines[range.line - 1]
|
62
|
+
Unicode::DisplayWidth.of(line[0, range.column])
|
63
|
+
end
|
64
|
+
|
65
|
+
def within?(inner, outer)
|
66
|
+
inner.begin_pos >= outer.begin_pos && inner.end_pos <= outer.end_pos
|
67
|
+
end
|
68
|
+
end
|
69
|
+
end
|
70
|
+
end
|
@@ -1,16 +1,17 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
5
4
|
module Cop
|
6
5
|
# Common code for indenting literal arrays and hashes.
|
7
6
|
module ArrayHashIndentation
|
7
|
+
private
|
8
|
+
|
8
9
|
def each_argument_node(node, type)
|
9
|
-
_receiver, _method_name, *args = *node
|
10
10
|
left_parenthesis = node.loc.begin
|
11
|
+
|
11
12
|
return unless left_parenthesis
|
12
13
|
|
13
|
-
|
14
|
+
node.arguments.each do |arg|
|
14
15
|
on_node(type, arg, :send) do |type_node|
|
15
16
|
left_brace = type_node.loc.begin
|
16
17
|
if left_brace && left_brace.line == left_parenthesis.line
|
@@ -26,21 +27,21 @@ module RuboCop
|
|
26
27
|
expected_column = base_column(left_brace, left_parenthesis) +
|
27
28
|
configured_indentation_width + offset
|
28
29
|
@column_delta = expected_column - actual_column
|
30
|
+
styles =
|
31
|
+
detected_styles(actual_column, offset, left_parenthesis, left_brace)
|
29
32
|
|
30
33
|
if @column_delta.zero?
|
31
|
-
|
32
|
-
# (not the column which we think should be the 'base column',
|
33
|
-
# but the one which has actually been used for that purpose)
|
34
|
-
base_column = actual_column - configured_indentation_width - offset
|
35
|
-
styles = detected_styles(base_column, left_parenthesis, left_brace)
|
36
|
-
if styles.size > 1
|
37
|
-
ambiguous_style_detected(*styles)
|
38
|
-
else
|
39
|
-
correct_style_detected
|
40
|
-
end
|
34
|
+
check_expected_style(styles)
|
41
35
|
else
|
42
|
-
incorrect_style_detected(
|
43
|
-
|
36
|
+
incorrect_style_detected(styles, first, left_parenthesis)
|
37
|
+
end
|
38
|
+
end
|
39
|
+
|
40
|
+
def check_expected_style(styles)
|
41
|
+
if styles.size > 1
|
42
|
+
ambiguous_style_detected(*styles)
|
43
|
+
else
|
44
|
+
correct_style_detected
|
44
45
|
end
|
45
46
|
end
|
46
47
|
|
@@ -54,7 +55,12 @@ module RuboCop
|
|
54
55
|
end
|
55
56
|
end
|
56
57
|
|
57
|
-
def detected_styles(
|
58
|
+
def detected_styles(actual_column, offset, left_parenthesis, left_brace)
|
59
|
+
base_column = actual_column - configured_indentation_width - offset
|
60
|
+
detected_styles_for_column(base_column, left_parenthesis, left_brace)
|
61
|
+
end
|
62
|
+
|
63
|
+
def detected_styles_for_column(column, left_parenthesis, left_brace)
|
58
64
|
styles = []
|
59
65
|
if column == (left_brace.source_line =~ /\S/)
|
60
66
|
styles << :consistent
|
@@ -67,12 +73,10 @@ module RuboCop
|
|
67
73
|
styles
|
68
74
|
end
|
69
75
|
|
70
|
-
def incorrect_style_detected(
|
71
|
-
|
72
|
-
|
73
|
-
|
74
|
-
base_column = column - configured_indentation_width - offset
|
75
|
-
styles = detected_styles(base_column, left_parenthesis, left_brace)
|
76
|
+
def incorrect_style_detected(styles, first, left_parenthesis)
|
77
|
+
msg = message(base_description(left_parenthesis))
|
78
|
+
|
79
|
+
add_offense(first, message: msg) do
|
76
80
|
ambiguous_style_detected(*styles)
|
77
81
|
end
|
78
82
|
end
|
@@ -0,0 +1,59 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
# Handles the `MinSize` configuration option for array-based cops
|
6
|
+
# `Style/SymbolArray` and `Style/WordArray`, which check for use of the
|
7
|
+
# relevant percent literal syntax such as `%i[...]` and `%w[...]`
|
8
|
+
module ArrayMinSize
|
9
|
+
private
|
10
|
+
|
11
|
+
def below_array_length?(node)
|
12
|
+
node.values.length < min_size_config
|
13
|
+
end
|
14
|
+
|
15
|
+
def min_size_config
|
16
|
+
cop_config['MinSize']
|
17
|
+
end
|
18
|
+
|
19
|
+
def array_style_detected(style, ary_size)
|
20
|
+
cfg = config_to_allow_offenses
|
21
|
+
return if cfg['Enabled'] == false
|
22
|
+
|
23
|
+
largest_brackets = largest_brackets_size(style, ary_size)
|
24
|
+
smallest_percent = smallest_percent_size(style, ary_size)
|
25
|
+
|
26
|
+
if cfg['EnforcedStyle'] == style.to_s
|
27
|
+
# do nothing
|
28
|
+
elsif cfg['EnforcedStyle'].nil?
|
29
|
+
cfg['EnforcedStyle'] = style.to_s
|
30
|
+
elsif smallest_percent <= largest_brackets
|
31
|
+
self.config_to_allow_offenses = { 'Enabled' => false }
|
32
|
+
else
|
33
|
+
cfg['EnforcedStyle'] = 'percent'
|
34
|
+
cfg['MinSize'] = largest_brackets + 1
|
35
|
+
end
|
36
|
+
end
|
37
|
+
|
38
|
+
def largest_brackets_size(style, ary_size)
|
39
|
+
self.class.largest_brackets ||= -Float::INFINITY
|
40
|
+
|
41
|
+
if style == :brackets && ary_size > self.class.largest_brackets
|
42
|
+
self.class.largest_brackets = ary_size
|
43
|
+
end
|
44
|
+
|
45
|
+
self.class.largest_brackets
|
46
|
+
end
|
47
|
+
|
48
|
+
def smallest_percent_size(style, ary_size)
|
49
|
+
@smallest_percent ||= Float::INFINITY
|
50
|
+
|
51
|
+
if style == :percent && ary_size < @smallest_percent
|
52
|
+
@smallest_percent = ary_size
|
53
|
+
end
|
54
|
+
|
55
|
+
@smallest_percent
|
56
|
+
end
|
57
|
+
end
|
58
|
+
end
|
59
|
+
end
|
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
@@ -6,19 +5,12 @@ module RuboCop
|
|
6
5
|
# Common code for ordinary arrays with [] that can be written with %
|
7
6
|
# syntax.
|
8
7
|
module ArraySyntax
|
9
|
-
|
10
|
-
return false unless square_brackets?(node)
|
11
|
-
|
12
|
-
array_elems = node.children
|
13
|
-
|
14
|
-
# no need to check empty arrays
|
15
|
-
return false unless array_elems && array_elems.size > 1
|
8
|
+
private
|
16
9
|
|
17
|
-
|
18
|
-
|
10
|
+
def bracketed_array_of?(element_type, node)
|
11
|
+
return false unless node.square_brackets? && node.values.size > 1
|
19
12
|
|
20
|
-
|
21
|
-
node.loc.begin && node.loc.begin.is?('[')
|
13
|
+
node.values.all? { |value| value.type == element_type }
|
22
14
|
end
|
23
15
|
end
|
24
16
|
end
|
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
@@ -12,13 +11,13 @@ module RuboCop
|
|
12
11
|
end
|
13
12
|
|
14
13
|
def on_send(node)
|
15
|
-
|
16
|
-
# when the method called looks like a setter
|
17
|
-
return unless node.asgn_method_call?
|
14
|
+
return unless node.setter_method?
|
18
15
|
|
19
|
-
# This will match if, case, begin, blocks, etc.
|
20
16
|
rhs = extract_rhs(node)
|
21
|
-
|
17
|
+
|
18
|
+
return unless rhs
|
19
|
+
|
20
|
+
check_assignment(node, rhs)
|
22
21
|
end
|
23
22
|
|
24
23
|
module_function
|
@@ -31,7 +30,7 @@ module RuboCop
|
|
31
30
|
elsif Util::ASGN_NODES.include?(node.type)
|
32
31
|
_lhs, rhs = *node
|
33
32
|
elsif node.send_type?
|
34
|
-
rhs = node.
|
33
|
+
rhs = node.last_argument
|
35
34
|
end
|
36
35
|
|
37
36
|
rhs
|
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
@@ -7,6 +6,8 @@ module RuboCop
|
|
7
6
|
module CodeLength
|
8
7
|
include ConfigurableMax
|
9
8
|
|
9
|
+
private
|
10
|
+
|
10
11
|
def max_length
|
11
12
|
cop_config['Max']
|
12
13
|
end
|
@@ -15,11 +16,11 @@ module RuboCop
|
|
15
16
|
cop_config['CountComments']
|
16
17
|
end
|
17
18
|
|
18
|
-
def check_code_length(node
|
19
|
+
def check_code_length(node)
|
19
20
|
length = code_length(node)
|
20
21
|
return unless length > max_length
|
21
22
|
|
22
|
-
add_offense(node, :
|
23
|
+
add_offense(node, message: message(length, max_length)) do
|
23
24
|
self.max = length
|
24
25
|
end
|
25
26
|
end
|
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
@@ -28,12 +27,17 @@ module RuboCop
|
|
28
27
|
# (if there is more than one which matches the observed code)
|
29
28
|
detected_as_strings = Array(detected).map(&:to_s)
|
30
29
|
|
31
|
-
if
|
32
|
-
|
33
|
-
|
34
|
-
|
35
|
-
|
30
|
+
updated_list = if detected_style
|
31
|
+
detected_style & detected_as_strings
|
32
|
+
else
|
33
|
+
# We haven't observed any specific style yet.
|
34
|
+
detected_as_strings
|
35
|
+
end
|
36
|
+
if updated_list.empty?
|
36
37
|
no_acceptable_style!
|
38
|
+
else
|
39
|
+
self.detected_style = updated_list
|
40
|
+
config_to_allow_offenses[style_parameter_name] = updated_list.first
|
37
41
|
end
|
38
42
|
end
|
39
43
|
|
@@ -43,7 +47,6 @@ module RuboCop
|
|
43
47
|
|
44
48
|
def no_acceptable_style!
|
45
49
|
self.config_to_allow_offenses = { 'Enabled' => false }
|
46
|
-
Formatter::DisabledConfigFormatter.detected_styles[cop_name] = []
|
47
50
|
end
|
48
51
|
|
49
52
|
def detected_style
|
@@ -52,11 +55,6 @@ module RuboCop
|
|
52
55
|
|
53
56
|
def detected_style=(style)
|
54
57
|
Formatter::DisabledConfigFormatter.detected_styles[cop_name] = style
|
55
|
-
|
56
|
-
return no_acceptable_style! if style.nil?
|
57
|
-
return no_acceptable_style! if style.empty?
|
58
|
-
|
59
|
-
config_to_allow_offenses[parameter_name] = style.first
|
60
58
|
end
|
61
59
|
|
62
60
|
alias conflicting_styles_detected no_acceptable_style!
|
@@ -64,7 +62,7 @@ module RuboCop
|
|
64
62
|
|
65
63
|
def style
|
66
64
|
@enforced_style ||= begin
|
67
|
-
s = cop_config[
|
65
|
+
s = cop_config[style_parameter_name].to_sym
|
68
66
|
unless supported_styles.include?(s)
|
69
67
|
raise "Unknown style #{s} selected!"
|
70
68
|
end
|
@@ -77,14 +75,21 @@ module RuboCop
|
|
77
75
|
raise 'alternative_style can only be used when there are exactly ' \
|
78
76
|
'2 SupportedStyles'
|
79
77
|
end
|
80
|
-
|
78
|
+
alternative_styles.first
|
79
|
+
end
|
80
|
+
|
81
|
+
def alternative_styles
|
82
|
+
(supported_styles - [style])
|
81
83
|
end
|
82
84
|
|
83
85
|
def supported_styles
|
84
|
-
@supported_styles ||=
|
86
|
+
@supported_styles ||= begin
|
87
|
+
supported_styles = Util.to_supported_styles(style_parameter_name)
|
88
|
+
cop_config[supported_styles].map(&:to_sym)
|
89
|
+
end
|
85
90
|
end
|
86
91
|
|
87
|
-
def
|
92
|
+
def style_parameter_name
|
88
93
|
'EnforcedStyle'
|
89
94
|
end
|
90
95
|
end
|
@@ -0,0 +1,48 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
# Shared functionality between mixins that enforce naming conventions
|
6
|
+
module ConfigurableFormatting
|
7
|
+
include ConfigurableEnforcedStyle
|
8
|
+
|
9
|
+
def check_name(node, name, name_range)
|
10
|
+
return if operator?(name)
|
11
|
+
|
12
|
+
if valid_name?(node, name)
|
13
|
+
correct_style_detected
|
14
|
+
else
|
15
|
+
add_offense(node, location: name_range, message: message(style)) do
|
16
|
+
report_opposing_styles(node, name)
|
17
|
+
end
|
18
|
+
end
|
19
|
+
end
|
20
|
+
|
21
|
+
def report_opposing_styles(node, name)
|
22
|
+
alternative_styles.each do |alternative|
|
23
|
+
if valid_name?(node, name, alternative)
|
24
|
+
return unexpected_style_detected(alternative)
|
25
|
+
end
|
26
|
+
end
|
27
|
+
end
|
28
|
+
|
29
|
+
def valid_name?(node, name, given_style = style)
|
30
|
+
name.match(self.class::FORMATS.fetch(given_style)) ||
|
31
|
+
class_emitter_method?(node, name)
|
32
|
+
end
|
33
|
+
|
34
|
+
# A class emitter method is a singleton method in a class/module, where
|
35
|
+
# the method has the same name as a class defined in the class/module.
|
36
|
+
def class_emitter_method?(node, name)
|
37
|
+
return false unless node.parent && node.defs_type?
|
38
|
+
# a class emitter method may be defined inside `def self.included`,
|
39
|
+
# `def self.extended`, etc.
|
40
|
+
node = node.parent while node.parent.defs_type?
|
41
|
+
|
42
|
+
node.parent.each_child_node(:class).any? do |c|
|
43
|
+
c.loc.name.is?(name.to_s)
|
44
|
+
end
|
45
|
+
end
|
46
|
+
end
|
47
|
+
end
|
48
|
+
end
|
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
@@ -6,13 +5,15 @@ module RuboCop
|
|
6
5
|
# Handles `Max` configuration parameters, especially setting them to an
|
7
6
|
# appropriate value with --auto-gen-config.
|
8
7
|
module ConfigurableMax
|
8
|
+
private
|
9
|
+
|
9
10
|
def max=(value)
|
10
11
|
cfg = config_to_allow_offenses
|
11
|
-
value = [cfg[
|
12
|
-
cfg[
|
12
|
+
value = [cfg[max_parameter_name], value].max if cfg[max_parameter_name]
|
13
|
+
cfg[max_parameter_name] = value
|
13
14
|
end
|
14
15
|
|
15
|
-
def
|
16
|
+
def max_parameter_name
|
16
17
|
'Max'
|
17
18
|
end
|
18
19
|
end
|
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
@@ -6,41 +5,12 @@ module RuboCop
|
|
6
5
|
# This module provides functionality for checking if names match the
|
7
6
|
# configured EnforcedStyle.
|
8
7
|
module ConfigurableNaming
|
9
|
-
include
|
8
|
+
include ConfigurableFormatting
|
10
9
|
|
11
|
-
|
12
|
-
|
13
|
-
|
14
|
-
|
15
|
-
return if operator?(name)
|
16
|
-
|
17
|
-
if valid_name?(node, name)
|
18
|
-
correct_style_detected
|
19
|
-
else
|
20
|
-
add_offense(node, name_range, message(style)) do
|
21
|
-
opposite_style_detected
|
22
|
-
end
|
23
|
-
end
|
24
|
-
end
|
25
|
-
|
26
|
-
def valid_name?(node, name)
|
27
|
-
pattern = (style == :snake_case ? SNAKE_CASE : CAMEL_CASE)
|
28
|
-
name.match(pattern) || class_emitter_method?(node, name)
|
29
|
-
end
|
30
|
-
|
31
|
-
# A class emitter method is a singleton method in a class/module, where
|
32
|
-
# the method has the same name as a class defined in the class/module.
|
33
|
-
def class_emitter_method?(node, name)
|
34
|
-
return false unless node.defs_type?
|
35
|
-
# a class emitter method may be defined inside `def self.included`,
|
36
|
-
# `def self.extended`, etc.
|
37
|
-
node = node.parent while node.parent && node.parent.defs_type?
|
38
|
-
return false unless node.parent
|
39
|
-
|
40
|
-
node.parent.children.compact.any? do |c|
|
41
|
-
c.class_type? && c.loc.name.is?(name.to_s)
|
42
|
-
end
|
43
|
-
end
|
10
|
+
FORMATS = {
|
11
|
+
snake_case: /^@{0,2}[\da-z_]+[!?=]?$/,
|
12
|
+
camelCase: /^@{0,2}_?[a-z][\da-zA-Z]+[!?=]?$/
|
13
|
+
}.freeze
|
44
14
|
end
|
45
15
|
end
|
46
16
|
end
|
@@ -0,0 +1,17 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
# This module provides functionality for checking if numbering match the
|
6
|
+
# configured EnforcedStyle.
|
7
|
+
module ConfigurableNumbering
|
8
|
+
include ConfigurableFormatting
|
9
|
+
|
10
|
+
FORMATS = {
|
11
|
+
snake_case: /(?:[a-z_]|_\d+)$/,
|
12
|
+
normalcase: /(?:_\D*|[A-Za-z]\d*)$/,
|
13
|
+
non_integer: /[A-Za-z_]$/
|
14
|
+
}.freeze
|
15
|
+
end
|
16
|
+
end
|
17
|
+
end
|