rubocop 0.42.0 → 0.52.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/LICENSE.txt +1 -1
- data/README.md +106 -20
- data/assets/output.html.erb +21 -10
- data/bin/rubocop +1 -2
- data/config/default.yml +914 -483
- data/config/disabled.yml +61 -41
- data/config/enabled.yml +1396 -878
- data/lib/rubocop/ast/builder.rb +72 -0
- data/lib/rubocop/ast/node/and_node.rb +37 -0
- data/lib/rubocop/ast/node/args_node.rb +29 -0
- data/lib/rubocop/ast/node/array_node.rb +57 -0
- data/lib/rubocop/ast/node/block_node.rb +116 -0
- data/lib/rubocop/ast/node/case_node.rb +64 -0
- data/lib/rubocop/ast/node/def_node.rb +71 -0
- data/lib/rubocop/ast/node/ensure_node.rb +25 -0
- data/lib/rubocop/ast/node/for_node.rb +61 -0
- data/lib/rubocop/ast/node/hash_node.rb +109 -0
- data/lib/rubocop/ast/node/if_node.rb +146 -0
- data/lib/rubocop/ast/node/keyword_splat_node.rb +45 -0
- data/lib/rubocop/ast/node/mixin/basic_literal_node.rb +16 -0
- data/lib/rubocop/ast/node/mixin/binary_operator_node.rb +23 -0
- data/lib/rubocop/ast/node/mixin/collection_node.rb +15 -0
- data/lib/rubocop/ast/node/mixin/conditional_node.rb +45 -0
- data/lib/rubocop/ast/node/mixin/hash_element_node.rb +125 -0
- data/lib/rubocop/ast/node/mixin/method_dispatch_node.rb +174 -0
- data/lib/rubocop/ast/node/mixin/method_identifier_predicates.rb +89 -0
- data/lib/rubocop/ast/node/mixin/modifier_node.rb +17 -0
- data/lib/rubocop/ast/node/mixin/parameterized_node.rb +61 -0
- data/lib/rubocop/ast/node/mixin/predicate_operator_node.rb +35 -0
- data/lib/rubocop/ast/node/or_node.rb +37 -0
- data/lib/rubocop/ast/node/pair_node.rb +64 -0
- data/lib/rubocop/ast/node/regexp_node.rb +35 -0
- data/lib/rubocop/ast/node/resbody_node.rb +25 -0
- data/lib/rubocop/ast/node/send_node.rb +45 -0
- data/lib/rubocop/ast/node/str_node.rb +14 -0
- data/lib/rubocop/ast/node/super_node.rb +21 -0
- data/lib/rubocop/ast/node/symbol_node.rb +20 -0
- data/lib/rubocop/ast/node/until_node.rb +43 -0
- data/lib/rubocop/ast/node/when_node.rb +61 -0
- data/lib/rubocop/ast/node/while_node.rb +43 -0
- data/lib/rubocop/ast/node/yield_node.rb +21 -0
- data/lib/rubocop/ast/node.rb +634 -0
- data/lib/rubocop/ast/sexp.rb +16 -0
- data/lib/rubocop/{ast_node → ast}/traversal.rb +23 -24
- data/lib/rubocop/cached_data.rb +11 -31
- data/lib/rubocop/cli.rb +116 -33
- data/lib/rubocop/comment_config.rb +4 -10
- data/lib/rubocop/config.rb +355 -102
- data/lib/rubocop/config_loader.rb +93 -78
- data/lib/rubocop/config_loader_resolver.rb +106 -7
- data/lib/rubocop/config_store.rb +4 -1
- data/lib/rubocop/cop/autocorrect_logic.rb +1 -2
- data/lib/rubocop/cop/badge.rb +73 -0
- data/lib/rubocop/cop/bundler/duplicated_gem.rb +71 -0
- data/lib/rubocop/cop/bundler/insecure_protocol_source.rb +67 -0
- data/lib/rubocop/cop/bundler/ordered_gems.rb +71 -0
- data/lib/rubocop/cop/commissioner.rb +27 -10
- data/lib/rubocop/cop/cop.rb +62 -107
- data/lib/rubocop/cop/corrector.rb +0 -1
- data/lib/rubocop/cop/correctors/alignment_corrector.rb +121 -0
- data/lib/rubocop/cop/correctors/condition_corrector.rb +28 -0
- data/lib/rubocop/cop/correctors/empty_line_corrector.rb +26 -0
- data/lib/rubocop/cop/correctors/multiline_literal_brace_corrector.rb +62 -0
- data/lib/rubocop/cop/correctors/ordered_gem_corrector.rb +44 -0
- data/lib/rubocop/cop/correctors/parentheses_corrector.rb +31 -0
- data/lib/rubocop/cop/correctors/punctuation_corrector.rb +29 -0
- data/lib/rubocop/cop/correctors/space_corrector.rb +34 -0
- data/lib/rubocop/cop/correctors/string_literal_corrector.rb +25 -0
- data/lib/rubocop/cop/correctors/unused_arg_corrector.rb +31 -0
- data/lib/rubocop/cop/force.rb +0 -1
- data/lib/rubocop/cop/gemspec/duplicated_assignment.rb +102 -0
- data/lib/rubocop/cop/gemspec/ordered_dependencies.rb +106 -0
- data/lib/rubocop/cop/gemspec/required_ruby_version.rb +87 -0
- data/lib/rubocop/cop/generator/require_file_injector.rb +78 -0
- data/lib/rubocop/cop/generator.rb +191 -0
- data/lib/rubocop/cop/ignored_node.rb +0 -1
- data/lib/rubocop/cop/internal_affairs/node_destructuring.rb +46 -0
- data/lib/rubocop/cop/internal_affairs/node_type_predicate.rb +44 -0
- data/lib/rubocop/cop/internal_affairs/offense_location_keyword.rb +54 -0
- data/lib/rubocop/cop/internal_affairs/redundant_location_argument.rb +59 -0
- data/lib/rubocop/cop/internal_affairs/redundant_message_argument.rb +71 -0
- data/lib/rubocop/cop/internal_affairs/useless_message_assertion.rb +52 -0
- data/lib/rubocop/cop/internal_affairs.rb +8 -0
- data/lib/rubocop/cop/{style → layout}/access_modifier_indentation.rb +39 -10
- data/lib/rubocop/cop/layout/align_array.rb +39 -0
- data/lib/rubocop/cop/layout/align_hash.rb +235 -0
- data/lib/rubocop/cop/{style → layout}/align_parameters.rb +38 -19
- data/lib/rubocop/cop/{style → layout}/block_end_newline.rb +26 -8
- data/lib/rubocop/cop/layout/case_indentation.rb +160 -0
- data/lib/rubocop/cop/layout/class_structure.rb +306 -0
- data/lib/rubocop/cop/{style → layout}/closing_parenthesis_indentation.rb +18 -13
- data/lib/rubocop/cop/{style → layout}/comment_indentation.rb +48 -6
- data/lib/rubocop/cop/{style → layout}/dot_position.rb +34 -21
- data/lib/rubocop/cop/{style → layout}/else_alignment.rb +55 -37
- data/lib/rubocop/cop/layout/empty_line_after_magic_comment.rb +63 -0
- data/lib/rubocop/cop/layout/empty_line_between_defs.rb +147 -0
- data/lib/rubocop/cop/{style → layout}/empty_lines.rb +17 -4
- data/lib/rubocop/cop/{style → layout}/empty_lines_around_access_modifier.rb +40 -24
- data/lib/rubocop/cop/layout/empty_lines_around_arguments.rb +87 -0
- data/lib/rubocop/cop/layout/empty_lines_around_begin_body.rb +46 -0
- data/lib/rubocop/cop/{style → layout}/empty_lines_around_block_body.rb +9 -12
- data/lib/rubocop/cop/layout/empty_lines_around_class_body.rb +68 -0
- data/lib/rubocop/cop/layout/empty_lines_around_exception_handling_keywords.rb +135 -0
- data/lib/rubocop/cop/{style → layout}/empty_lines_around_method_body.rb +10 -7
- data/lib/rubocop/cop/{style → layout}/empty_lines_around_module_body.rb +27 -9
- data/lib/rubocop/cop/layout/end_of_line.rb +52 -0
- data/lib/rubocop/cop/{style → layout}/extra_spacing.rb +63 -53
- data/lib/rubocop/cop/{style → layout}/first_array_element_line_break.rb +5 -2
- data/lib/rubocop/cop/{style → layout}/first_hash_element_line_break.rb +5 -2
- data/lib/rubocop/cop/{style → layout}/first_method_argument_line_break.rb +7 -4
- data/lib/rubocop/cop/{style → layout}/first_method_parameter_line_break.rb +8 -5
- data/lib/rubocop/cop/{style → layout}/first_parameter_indentation.rb +32 -26
- data/lib/rubocop/cop/{style → layout}/indent_array.rb +75 -25
- data/lib/rubocop/cop/{style → layout}/indent_assignment.rb +9 -6
- data/lib/rubocop/cop/{style → layout}/indent_hash.rb +80 -31
- data/lib/rubocop/cop/layout/indent_heredoc.rb +208 -0
- data/lib/rubocop/cop/{style → layout}/indentation_consistency.rb +7 -5
- data/lib/rubocop/cop/{style → layout}/indentation_width.rb +151 -117
- data/lib/rubocop/cop/layout/initial_indentation.rb +45 -0
- data/lib/rubocop/cop/layout/leading_comment_space.rb +58 -0
- data/lib/rubocop/cop/{style → layout}/multiline_array_brace_layout.rb +52 -16
- data/lib/rubocop/cop/{style → layout}/multiline_assignment_layout.rb +18 -21
- data/lib/rubocop/cop/{style → layout}/multiline_block_layout.rb +37 -43
- data/lib/rubocop/cop/{style → layout}/multiline_hash_brace_layout.rb +55 -15
- data/lib/rubocop/cop/{style → layout}/multiline_method_call_brace_layout.rb +15 -4
- data/lib/rubocop/cop/layout/multiline_method_call_indentation.rb +221 -0
- data/lib/rubocop/cop/{style → layout}/multiline_method_definition_brace_layout.rb +12 -5
- data/lib/rubocop/cop/{style → layout}/multiline_operation_indentation.rb +23 -13
- data/lib/rubocop/cop/{style → layout}/rescue_ensure_alignment.rb +24 -13
- data/lib/rubocop/cop/{style → layout}/space_after_colon.rb +17 -13
- data/lib/rubocop/cop/layout/space_after_comma.rb +35 -0
- data/lib/rubocop/cop/{style → layout}/space_after_method_name.rb +11 -11
- data/lib/rubocop/cop/layout/space_after_not.rb +38 -0
- data/lib/rubocop/cop/{style → layout}/space_after_semicolon.rb +14 -4
- data/lib/rubocop/cop/{style → layout}/space_around_block_parameters.rb +52 -28
- data/lib/rubocop/cop/{style → layout}/space_around_equals_in_parameter_default.rb +29 -21
- data/lib/rubocop/cop/{style → layout}/space_around_keyword.rb +33 -29
- data/lib/rubocop/cop/layout/space_around_operators.rb +159 -0
- data/lib/rubocop/cop/layout/space_before_block_braces.rb +107 -0
- data/lib/rubocop/cop/layout/space_before_comma.rb +31 -0
- data/lib/rubocop/cop/{style → layout}/space_before_comment.rb +11 -7
- data/lib/rubocop/cop/{style → layout}/space_before_first_arg.rb +23 -20
- data/lib/rubocop/cop/layout/space_before_semicolon.rb +27 -0
- data/lib/rubocop/cop/layout/space_in_lambda_literal.rb +85 -0
- data/lib/rubocop/cop/layout/space_inside_array_literal_brackets.rb +236 -0
- data/lib/rubocop/cop/{style → layout}/space_inside_array_percent_literal.rb +8 -8
- data/lib/rubocop/cop/layout/space_inside_block_braces.rb +228 -0
- data/lib/rubocop/cop/{style → layout}/space_inside_hash_literal_braces.rb +91 -51
- data/lib/rubocop/cop/layout/space_inside_parens.rb +53 -0
- data/lib/rubocop/cop/{style → layout}/space_inside_percent_literal_delimiters.rb +14 -13
- data/lib/rubocop/cop/{style → layout}/space_inside_range_literal.rb +16 -17
- data/lib/rubocop/cop/layout/space_inside_reference_brackets.rb +90 -0
- data/lib/rubocop/cop/layout/space_inside_string_interpolation.rb +80 -0
- data/lib/rubocop/cop/{style → layout}/tab.rb +8 -6
- data/lib/rubocop/cop/{style → layout}/trailing_blank_lines.rb +14 -15
- data/lib/rubocop/cop/{style → layout}/trailing_whitespace.rb +3 -4
- data/lib/rubocop/cop/lint/ambiguous_block_association.rb +59 -0
- data/lib/rubocop/cop/lint/ambiguous_operator.rb +13 -9
- data/lib/rubocop/cop/lint/ambiguous_regexp_literal.rb +7 -1
- data/lib/rubocop/cop/lint/assignment_in_condition.rb +55 -25
- data/lib/rubocop/cop/lint/block_alignment.rb +75 -34
- data/lib/rubocop/cop/lint/boolean_symbol.rb +38 -0
- data/lib/rubocop/cop/lint/circular_argument_reference.rb +17 -15
- data/lib/rubocop/cop/lint/condition_position.rb +16 -15
- data/lib/rubocop/cop/lint/debugger.rb +57 -23
- data/lib/rubocop/cop/lint/def_end_alignment.rb +28 -14
- data/lib/rubocop/cop/lint/deprecated_class_methods.rb +19 -10
- data/lib/rubocop/cop/lint/duplicate_case_condition.rb +53 -0
- data/lib/rubocop/cop/lint/duplicate_methods.rb +108 -14
- data/lib/rubocop/cop/lint/duplicated_key.rb +16 -9
- data/lib/rubocop/cop/lint/each_with_object_argument.rb +15 -6
- data/lib/rubocop/cop/lint/else_layout.rb +27 -31
- data/lib/rubocop/cop/lint/empty_ensure.rb +44 -3
- data/lib/rubocop/cop/lint/empty_expression.rb +42 -0
- data/lib/rubocop/cop/lint/empty_interpolation.rb +16 -3
- data/lib/rubocop/cop/lint/empty_when.rb +38 -0
- data/lib/rubocop/cop/lint/end_alignment.rb +57 -39
- data/lib/rubocop/cop/lint/end_in_method.rb +24 -2
- data/lib/rubocop/cop/lint/ensure_return.rb +23 -3
- data/lib/rubocop/cop/lint/float_out_of_range.rb +10 -6
- data/lib/rubocop/cop/lint/format_parameter_mismatch.rb +67 -46
- data/lib/rubocop/cop/lint/handle_exceptions.rb +41 -4
- data/lib/rubocop/cop/lint/implicit_string_concatenation.rb +9 -5
- data/lib/rubocop/cop/lint/ineffective_access_modifier.rb +42 -29
- data/lib/rubocop/cop/lint/inherit_exception.rb +34 -23
- data/lib/rubocop/cop/lint/interpolation_check.rb +37 -0
- data/lib/rubocop/cop/lint/{literal_in_condition.rb → literal_as_condition.rb} +51 -40
- data/lib/rubocop/cop/lint/literal_in_interpolation.rb +13 -8
- data/lib/rubocop/cop/lint/loop.rb +37 -2
- data/lib/rubocop/cop/lint/missing_cop_enable_directive.rb +81 -0
- data/lib/rubocop/cop/lint/multiple_compare.rb +48 -0
- data/lib/rubocop/cop/lint/nested_method_definition.rb +54 -12
- data/lib/rubocop/cop/lint/nested_percent_literal.rb +58 -0
- data/lib/rubocop/cop/lint/next_without_accumulator.rb +7 -3
- data/lib/rubocop/cop/lint/non_local_exit_from_iterator.rb +32 -23
- data/lib/rubocop/cop/lint/parentheses_as_grouped_expression.rb +22 -14
- data/lib/rubocop/cop/lint/percent_string_array.rb +42 -27
- data/lib/rubocop/cop/lint/percent_symbol_array.rb +28 -19
- data/lib/rubocop/cop/lint/rand_one.rb +17 -8
- data/lib/rubocop/cop/lint/redundant_with_index.rb +80 -0
- data/lib/rubocop/cop/lint/redundant_with_object.rb +81 -0
- data/lib/rubocop/cop/lint/regexp_as_condition.rb +29 -0
- data/lib/rubocop/cop/lint/require_parentheses.rb +24 -30
- data/lib/rubocop/cop/lint/rescue_exception.rb +21 -2
- data/lib/rubocop/cop/lint/rescue_type.rb +90 -0
- data/lib/rubocop/cop/lint/return_in_void_context.rb +74 -0
- data/lib/rubocop/cop/lint/safe_navigation_chain.rb +70 -0
- data/lib/rubocop/cop/lint/script_permission.rb +49 -0
- data/lib/rubocop/cop/lint/shadowed_argument.rb +146 -0
- data/lib/rubocop/cop/lint/shadowed_exception.rb +78 -57
- data/lib/rubocop/cop/lint/shadowing_outer_local_variable.rb +25 -2
- data/lib/rubocop/cop/lint/string_conversion_in_interpolation.rb +18 -12
- data/lib/rubocop/cop/lint/syntax.rb +23 -21
- data/lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb +26 -4
- data/lib/rubocop/cop/lint/unified_integer.rb +43 -0
- data/lib/rubocop/cop/lint/unneeded_disable.rb +117 -56
- data/lib/rubocop/cop/lint/unneeded_require_statement.rb +51 -0
- data/lib/rubocop/cop/lint/unneeded_splat_expansion.rb +167 -0
- data/lib/rubocop/cop/lint/unreachable_code.rb +72 -8
- data/lib/rubocop/cop/lint/unused_block_argument.rb +87 -27
- data/lib/rubocop/cop/lint/unused_method_argument.rb +18 -2
- data/lib/rubocop/cop/lint/uri_escape_unescape.rb +75 -0
- data/lib/rubocop/cop/lint/uri_regexp.rb +73 -0
- data/lib/rubocop/cop/lint/useless_access_modifier.rb +40 -18
- data/lib/rubocop/cop/lint/useless_assignment.rb +45 -14
- data/lib/rubocop/cop/lint/useless_comparison.rb +8 -10
- data/lib/rubocop/cop/lint/useless_else_without_rescue.rb +16 -2
- data/lib/rubocop/cop/lint/useless_setter_call.rb +57 -43
- data/lib/rubocop/cop/lint/void.rb +83 -23
- data/lib/rubocop/cop/message_annotator.rb +118 -0
- data/lib/rubocop/cop/metrics/abc_size.rb +3 -4
- data/lib/rubocop/cop/metrics/block_length.rb +32 -0
- data/lib/rubocop/cop/metrics/block_nesting.rb +21 -10
- data/lib/rubocop/cop/metrics/class_length.rb +3 -2
- data/lib/rubocop/cop/metrics/cyclomatic_complexity.rb +4 -4
- data/lib/rubocop/cop/metrics/line_length.rb +67 -14
- data/lib/rubocop/cop/metrics/method_length.rb +10 -10
- data/lib/rubocop/cop/metrics/module_length.rb +3 -2
- data/lib/rubocop/cop/metrics/parameter_lists.rb +15 -6
- data/lib/rubocop/cop/metrics/perceived_complexity.rb +5 -6
- data/lib/rubocop/cop/mixin/alignment.rb +70 -0
- data/lib/rubocop/cop/mixin/annotation_comment.rb +0 -1
- data/lib/rubocop/cop/mixin/array_hash_indentation.rb +26 -22
- data/lib/rubocop/cop/mixin/array_min_size.rb +59 -0
- data/lib/rubocop/cop/mixin/array_syntax.rb +4 -12
- data/lib/rubocop/cop/mixin/check_assignment.rb +6 -7
- data/lib/rubocop/cop/mixin/classish_length.rb +0 -1
- data/lib/rubocop/cop/mixin/code_length.rb +4 -3
- data/lib/rubocop/cop/mixin/configurable_enforced_style.rb +21 -16
- data/lib/rubocop/cop/mixin/configurable_formatting.rb +48 -0
- data/lib/rubocop/cop/mixin/configurable_max.rb +5 -4
- data/lib/rubocop/cop/mixin/configurable_naming.rb +5 -35
- data/lib/rubocop/cop/mixin/configurable_numbering.rb +17 -0
- data/lib/rubocop/cop/mixin/def_node.rb +29 -0
- data/lib/rubocop/cop/mixin/documentation_comment.rb +46 -0
- data/lib/rubocop/cop/mixin/duplication.rb +46 -0
- data/lib/rubocop/cop/mixin/empty_lines_around_body.rb +119 -27
- data/lib/rubocop/cop/mixin/empty_parameter.rb +23 -0
- data/lib/rubocop/cop/mixin/end_keyword_alignment.rb +11 -27
- data/lib/rubocop/cop/mixin/enforce_superclass.rb +30 -0
- data/lib/rubocop/cop/mixin/first_element_line_break.rb +15 -11
- data/lib/rubocop/cop/mixin/frozen_string_literal.rb +15 -13
- data/lib/rubocop/cop/mixin/hash_alignment.rb +116 -0
- data/lib/rubocop/cop/mixin/heredoc.rb +28 -0
- data/lib/rubocop/cop/mixin/ignored_pattern.rb +29 -0
- data/lib/rubocop/cop/mixin/integer_node.rb +2 -1
- data/lib/rubocop/cop/mixin/match_range.rb +4 -6
- data/lib/rubocop/cop/mixin/method_complexity.rb +33 -8
- data/lib/rubocop/cop/mixin/method_preference.rb +2 -1
- data/lib/rubocop/cop/mixin/min_body_length.rb +2 -1
- data/lib/rubocop/cop/mixin/multiline_expression_indentation.rb +100 -66
- data/lib/rubocop/cop/mixin/multiline_literal_brace_layout.rb +49 -51
- data/lib/rubocop/cop/mixin/negative_conditional.rb +18 -13
- data/lib/rubocop/cop/mixin/on_normal_if_unless.rb +1 -25
- data/lib/rubocop/cop/mixin/ordered_gem_node.rb +48 -0
- data/lib/rubocop/cop/mixin/parentheses.rb +2 -8
- data/lib/rubocop/cop/mixin/parser_diagnostic.rb +4 -2
- data/lib/rubocop/cop/mixin/percent_array.rb +52 -0
- data/lib/rubocop/cop/mixin/percent_literal.rb +69 -6
- data/lib/rubocop/cop/mixin/preceding_following_alignment.rb +16 -5
- data/lib/rubocop/cop/mixin/rescue_node.rb +23 -0
- data/lib/rubocop/cop/mixin/safe_assignment.rb +3 -1
- data/lib/rubocop/cop/mixin/safe_mode.rb +22 -0
- data/lib/rubocop/cop/mixin/space_after_punctuation.rb +8 -10
- data/lib/rubocop/cop/mixin/space_before_punctuation.rb +10 -14
- data/lib/rubocop/cop/mixin/statement_modifier.rb +29 -32
- data/lib/rubocop/cop/mixin/string_help.rb +3 -2
- data/lib/rubocop/cop/mixin/string_literals_help.rb +3 -15
- data/lib/rubocop/cop/mixin/surrounding_space.rb +78 -9
- data/lib/rubocop/cop/mixin/target_rails_version.rb +16 -0
- data/lib/rubocop/cop/mixin/target_ruby_version.rb +16 -0
- data/lib/rubocop/cop/mixin/too_many_lines.rb +39 -0
- data/lib/rubocop/cop/mixin/trailing_comma.rb +37 -38
- data/lib/rubocop/cop/mixin/unused_argument.rb +6 -16
- data/lib/rubocop/cop/naming/accessor_method_name.rb +55 -0
- data/lib/rubocop/cop/{style → naming}/ascii_identifiers.rb +36 -5
- data/lib/rubocop/cop/naming/binary_operator_parameter_name.rb +42 -0
- data/lib/rubocop/cop/naming/class_and_module_camel_case.rb +33 -0
- data/lib/rubocop/cop/naming/constant_name.rb +58 -0
- data/lib/rubocop/cop/{style → naming}/file_name.rb +72 -29
- data/lib/rubocop/cop/naming/heredoc_delimiter_case.rb +62 -0
- data/lib/rubocop/cop/naming/heredoc_delimiter_naming.rb +59 -0
- data/lib/rubocop/cop/naming/method_name.rb +40 -0
- data/lib/rubocop/cop/naming/predicate_name.rb +101 -0
- data/lib/rubocop/cop/naming/variable_name.rb +50 -0
- data/lib/rubocop/cop/naming/variable_number.rb +61 -0
- data/lib/rubocop/cop/offense.rb +9 -5
- data/lib/rubocop/cop/performance/caller.rb +69 -0
- data/lib/rubocop/cop/performance/case_when_splat.rb +65 -89
- data/lib/rubocop/cop/performance/casecmp.rb +37 -25
- data/lib/rubocop/cop/performance/compare_with_block.rb +117 -0
- data/lib/rubocop/cop/performance/count.rb +33 -43
- data/lib/rubocop/cop/performance/detect.rb +30 -31
- data/lib/rubocop/cop/performance/double_start_end_with.rb +55 -26
- data/lib/rubocop/cop/performance/end_with.rb +9 -9
- data/lib/rubocop/cop/performance/fixed_size.rb +21 -17
- data/lib/rubocop/cop/performance/flat_map.rb +30 -33
- data/lib/rubocop/cop/performance/hash_each_methods.rb +129 -0
- data/lib/rubocop/cop/performance/lstrip_rstrip.rb +14 -14
- data/lib/rubocop/cop/performance/range_include.rb +5 -4
- data/lib/rubocop/cop/performance/redundant_block_call.rb +28 -29
- data/lib/rubocop/cop/performance/redundant_match.rb +19 -15
- data/lib/rubocop/cop/performance/redundant_merge.rb +100 -52
- data/lib/rubocop/cop/performance/redundant_sort_by.rb +17 -14
- data/lib/rubocop/cop/performance/regexp_match.rb +224 -0
- data/lib/rubocop/cop/performance/reverse_each.rb +3 -6
- data/lib/rubocop/cop/performance/sample.rb +84 -83
- data/lib/rubocop/cop/performance/size.rb +22 -15
- data/lib/rubocop/cop/performance/start_with.rb +9 -9
- data/lib/rubocop/cop/performance/string_replacement.rb +35 -70
- data/lib/rubocop/cop/performance/times_map.rb +33 -24
- data/lib/rubocop/cop/performance/unfreeze_string.rb +50 -0
- data/lib/rubocop/cop/performance/uri_default_parser.rb +47 -0
- data/lib/rubocop/cop/rails/action_filter.rb +67 -47
- data/lib/rubocop/cop/rails/active_support_aliases.rb +68 -0
- data/lib/rubocop/cop/rails/application_job.rb +40 -0
- data/lib/rubocop/cop/rails/application_record.rb +40 -0
- data/lib/rubocop/cop/rails/blank.rb +142 -0
- data/lib/rubocop/cop/rails/create_table_with_timestamps.rb +82 -0
- data/lib/rubocop/cop/rails/date.rb +47 -42
- data/lib/rubocop/cop/rails/delegate.rb +55 -33
- data/lib/rubocop/cop/rails/delegate_allow_blank.rb +51 -0
- data/lib/rubocop/cop/rails/dynamic_find_by.rb +82 -0
- data/lib/rubocop/cop/rails/enum_uniqueness.rb +45 -0
- data/lib/rubocop/cop/rails/environment_comparison.rb +66 -0
- data/lib/rubocop/cop/rails/exit.rb +17 -11
- data/lib/rubocop/cop/rails/file_path.rb +72 -0
- data/lib/rubocop/cop/rails/find_by.rb +14 -20
- data/lib/rubocop/cop/rails/find_each.rb +8 -21
- data/lib/rubocop/cop/rails/has_and_belongs_to_many.rb +9 -2
- data/lib/rubocop/cop/rails/has_many_or_has_one_dependent.rb +84 -0
- data/lib/rubocop/cop/rails/http_positional_arguments.rb +102 -0
- data/lib/rubocop/cop/rails/inverse_of.rb +218 -0
- data/lib/rubocop/cop/rails/lexically_scoped_action_filter.rb +112 -0
- data/lib/rubocop/cop/rails/not_null_column.rb +67 -0
- data/lib/rubocop/cop/rails/output.rb +15 -13
- data/lib/rubocop/cop/rails/output_safety.rb +65 -17
- data/lib/rubocop/cop/rails/pluralization_grammar.rb +30 -29
- data/lib/rubocop/cop/rails/presence.rb +118 -0
- data/lib/rubocop/cop/rails/present.rb +143 -0
- data/lib/rubocop/cop/rails/read_write_attribute.rb +20 -26
- data/lib/rubocop/cop/rails/redundant_receiver_in_with_options.rb +133 -0
- data/lib/rubocop/cop/rails/relative_date_constant.rb +88 -0
- data/lib/rubocop/cop/rails/request_referer.rb +28 -13
- data/lib/rubocop/cop/rails/reversible_migration.rb +281 -0
- data/lib/rubocop/cop/rails/safe_navigation.rb +90 -0
- data/lib/rubocop/cop/rails/save_bang.rb +104 -19
- data/lib/rubocop/cop/rails/scope_args.rb +5 -10
- data/lib/rubocop/cop/rails/skips_model_validations.rb +70 -0
- data/lib/rubocop/cop/rails/time_zone.rb +34 -21
- data/lib/rubocop/cop/rails/uniq_before_pluck.rb +17 -14
- data/lib/rubocop/cop/rails/unknown_env.rb +63 -0
- data/lib/rubocop/cop/rails/validation.rb +16 -20
- data/lib/rubocop/cop/registry.rb +172 -0
- data/lib/rubocop/cop/security/eval.rb +30 -0
- data/lib/rubocop/cop/security/json_load.rb +46 -0
- data/lib/rubocop/cop/security/marshal_load.rb +39 -0
- data/lib/rubocop/cop/security/yaml_load.rb +37 -0
- data/lib/rubocop/cop/severity.rb +1 -2
- data/lib/rubocop/cop/style/alias.rb +54 -33
- data/lib/rubocop/cop/style/and_or.rb +77 -63
- data/lib/rubocop/cop/style/array_join.rb +13 -9
- data/lib/rubocop/cop/style/ascii_comments.rb +25 -7
- data/lib/rubocop/cop/style/attr.rb +24 -11
- data/lib/rubocop/cop/style/auto_resource_cleanup.rb +21 -16
- data/lib/rubocop/cop/style/bare_percent_literals.rb +31 -11
- data/lib/rubocop/cop/style/begin_block.rb +1 -2
- data/lib/rubocop/cop/style/block_comments.rb +20 -11
- data/lib/rubocop/cop/style/block_delimiters.rb +122 -51
- data/lib/rubocop/cop/style/braces_around_hash_parameters.rb +142 -54
- data/lib/rubocop/cop/style/case_equality.rb +15 -4
- data/lib/rubocop/cop/style/character_literal.rb +12 -5
- data/lib/rubocop/cop/style/class_and_module_children.rb +85 -6
- data/lib/rubocop/cop/style/class_check.rb +35 -19
- data/lib/rubocop/cop/style/class_methods.rb +13 -14
- data/lib/rubocop/cop/style/class_vars.rb +5 -5
- data/lib/rubocop/cop/style/collection_methods.rb +12 -13
- data/lib/rubocop/cop/style/colon_method_call.rb +24 -16
- data/lib/rubocop/cop/style/colon_method_definition.rb +36 -0
- data/lib/rubocop/cop/style/command_literal.rb +98 -32
- data/lib/rubocop/cop/style/comment_annotation.rb +41 -15
- data/lib/rubocop/cop/style/commented_keyword.rb +84 -0
- data/lib/rubocop/cop/style/conditional_assignment.rb +161 -112
- data/lib/rubocop/cop/style/copyright.rb +32 -34
- data/lib/rubocop/cop/style/date_time.rb +44 -0
- data/lib/rubocop/cop/style/def_with_parentheses.rb +32 -9
- data/lib/rubocop/cop/style/dir.rb +48 -0
- data/lib/rubocop/cop/style/documentation.rb +44 -58
- data/lib/rubocop/cop/style/documentation_method.rb +76 -0
- data/lib/rubocop/cop/style/double_negation.rb +3 -3
- data/lib/rubocop/cop/style/each_for_simple_loop.rb +14 -13
- data/lib/rubocop/cop/style/each_with_object.rb +28 -25
- data/lib/rubocop/cop/style/empty_block_parameter.rb +47 -0
- data/lib/rubocop/cop/style/empty_case_condition.rb +18 -30
- data/lib/rubocop/cop/style/empty_else.rb +82 -51
- data/lib/rubocop/cop/style/empty_lambda_parameter.rb +43 -0
- data/lib/rubocop/cop/style/empty_literal.rb +76 -48
- data/lib/rubocop/cop/style/empty_method.rb +112 -0
- data/lib/rubocop/cop/style/encoding.rb +10 -40
- data/lib/rubocop/cop/style/end_block.rb +1 -2
- data/lib/rubocop/cop/style/eval_with_location.rb +146 -0
- data/lib/rubocop/cop/style/even_odd.rb +25 -44
- data/lib/rubocop/cop/style/flip_flop.rb +13 -3
- data/lib/rubocop/cop/style/for.rb +19 -15
- data/lib/rubocop/cop/style/format_string.rb +88 -42
- data/lib/rubocop/cop/style/format_string_token.rb +163 -0
- data/lib/rubocop/cop/style/frozen_string_literal_comment.rb +90 -15
- data/lib/rubocop/cop/style/global_vars.rb +14 -5
- data/lib/rubocop/cop/style/guard_clause.rb +22 -62
- data/lib/rubocop/cop/style/hash_syntax.rb +109 -59
- data/lib/rubocop/cop/style/identical_conditional_branches.rb +73 -32
- data/lib/rubocop/cop/style/if_inside_else.rb +16 -20
- data/lib/rubocop/cop/style/if_unless_modifier.rb +48 -39
- data/lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb +6 -12
- data/lib/rubocop/cop/style/if_with_semicolon.rb +10 -2
- data/lib/rubocop/cop/style/implicit_runtime_error.rb +7 -7
- data/lib/rubocop/cop/style/infinite_loop.rb +33 -32
- data/lib/rubocop/cop/style/inline_comment.rb +17 -5
- data/lib/rubocop/cop/style/inverse_methods.rb +149 -0
- data/lib/rubocop/cop/style/lambda.rb +66 -63
- data/lib/rubocop/cop/style/lambda_call.rb +50 -20
- data/lib/rubocop/cop/style/line_end_concatenation.rb +38 -17
- data/lib/rubocop/cop/style/method_call_with_args_parentheses.rb +90 -0
- data/lib/rubocop/cop/style/{method_call_parentheses.rb → method_call_without_args_parentheses.rb} +32 -25
- data/lib/rubocop/cop/style/method_called_on_do_end_block.rb +9 -9
- data/lib/rubocop/cop/style/method_def_parentheses.rb +101 -29
- data/lib/rubocop/cop/style/method_missing.rb +14 -20
- data/lib/rubocop/cop/style/min_max.rb +68 -0
- data/lib/rubocop/cop/style/missing_else.rb +61 -21
- data/lib/rubocop/cop/style/mixin_grouping.rb +145 -0
- data/lib/rubocop/cop/style/mixin_usage.rb +82 -0
- data/lib/rubocop/cop/style/module_function.rb +44 -18
- data/lib/rubocop/cop/style/multiline_block_chain.rb +8 -15
- data/lib/rubocop/cop/style/multiline_if_modifier.rb +67 -0
- data/lib/rubocop/cop/style/multiline_if_then.rb +21 -14
- data/lib/rubocop/cop/style/multiline_memoization.rb +93 -0
- data/lib/rubocop/cop/style/multiline_ternary_operator.rb +21 -9
- data/lib/rubocop/cop/style/multiple_comparison.rb +77 -0
- data/lib/rubocop/cop/style/mutable_constant.rb +17 -9
- data/lib/rubocop/cop/style/negated_if.rb +76 -25
- data/lib/rubocop/cop/style/negated_while.rb +4 -22
- data/lib/rubocop/cop/style/nested_modifier.rb +17 -47
- data/lib/rubocop/cop/style/nested_parenthesized_calls.rb +32 -28
- data/lib/rubocop/cop/style/nested_ternary_operator.rb +3 -6
- data/lib/rubocop/cop/style/next.rb +72 -53
- data/lib/rubocop/cop/style/nil_comparison.rb +10 -14
- data/lib/rubocop/cop/style/non_nil_check.rb +69 -62
- data/lib/rubocop/cop/style/not.rb +19 -13
- data/lib/rubocop/cop/style/numeric_literal_prefix.rb +16 -7
- data/lib/rubocop/cop/style/numeric_literals.rb +33 -12
- data/lib/rubocop/cop/style/numeric_predicate.rb +30 -32
- data/lib/rubocop/cop/style/one_line_conditional.rb +21 -17
- data/lib/rubocop/cop/style/option_hash.rb +11 -37
- data/lib/rubocop/cop/style/optional_arguments.rb +20 -9
- data/lib/rubocop/cop/style/or_assignment.rb +88 -0
- data/lib/rubocop/cop/style/parallel_assignment.rb +83 -64
- data/lib/rubocop/cop/style/parentheses_around_condition.rb +37 -19
- data/lib/rubocop/cop/style/percent_literal_delimiters.rb +50 -15
- data/lib/rubocop/cop/style/percent_q_literals.rb +40 -17
- data/lib/rubocop/cop/style/perl_backrefs.rb +9 -3
- data/lib/rubocop/cop/style/preferred_hash_methods.rb +48 -14
- data/lib/rubocop/cop/style/proc.rb +13 -10
- data/lib/rubocop/cop/style/raise_args.rb +46 -50
- data/lib/rubocop/cop/style/random_with_offset.rb +160 -0
- data/lib/rubocop/cop/style/redundant_begin.rb +16 -6
- data/lib/rubocop/cop/style/redundant_conditional.rb +96 -0
- data/lib/rubocop/cop/style/redundant_exception.rb +4 -5
- data/lib/rubocop/cop/style/redundant_freeze.rb +7 -10
- data/lib/rubocop/cop/style/redundant_parentheses.rb +70 -31
- data/lib/rubocop/cop/style/redundant_return.rb +61 -23
- data/lib/rubocop/cop/style/redundant_self.rb +62 -60
- data/lib/rubocop/cop/style/regexp_literal.rb +100 -34
- data/lib/rubocop/cop/style/rescue_modifier.rb +15 -17
- data/lib/rubocop/cop/style/rescue_standard_error.rb +122 -0
- data/lib/rubocop/cop/style/return_nil.rb +89 -0
- data/lib/rubocop/cop/style/safe_navigation.rb +197 -0
- data/lib/rubocop/cop/style/self_assignment.rb +20 -17
- data/lib/rubocop/cop/style/semicolon.rb +25 -17
- data/lib/rubocop/cop/style/send.rb +14 -4
- data/lib/rubocop/cop/style/signal_exception.rb +105 -7
- data/lib/rubocop/cop/style/single_line_block_params.rb +27 -21
- data/lib/rubocop/cop/style/single_line_methods.rb +45 -31
- data/lib/rubocop/cop/style/special_global_vars.rb +32 -28
- data/lib/rubocop/cop/style/stabby_lambda_parentheses.rb +24 -53
- data/lib/rubocop/cop/style/stderr_puts.rb +54 -0
- data/lib/rubocop/cop/style/string_hash_keys.rb +36 -0
- data/lib/rubocop/cop/style/string_literals.rb +31 -5
- data/lib/rubocop/cop/style/string_literals_in_interpolation.rb +20 -2
- data/lib/rubocop/cop/style/string_methods.rb +22 -9
- data/lib/rubocop/cop/style/struct_inheritance.rb +5 -17
- data/lib/rubocop/cop/style/symbol_array.rb +39 -65
- data/lib/rubocop/cop/style/symbol_literal.rb +1 -2
- data/lib/rubocop/cop/style/symbol_proc.rb +35 -52
- data/lib/rubocop/cop/style/ternary_parentheses.rb +143 -42
- data/lib/rubocop/cop/style/trailing_body_on_method_definition.rb +101 -0
- data/lib/rubocop/cop/style/trailing_comma_in_arguments.rb +31 -20
- data/lib/rubocop/cop/style/trailing_comma_in_literal.rb +26 -8
- data/lib/rubocop/cop/style/trailing_method_end_statement.rb +95 -0
- data/lib/rubocop/cop/style/trailing_underscore_variable.rb +97 -37
- data/lib/rubocop/cop/style/trivial_accessors.rb +72 -66
- data/lib/rubocop/cop/style/unless_else.rb +19 -13
- data/lib/rubocop/cop/style/unneeded_capital_w.rb +24 -10
- data/lib/rubocop/cop/style/unneeded_interpolation.rb +22 -24
- data/lib/rubocop/cop/style/unneeded_percent_q.rb +28 -22
- data/lib/rubocop/cop/style/variable_interpolation.rb +23 -10
- data/lib/rubocop/cop/style/when_then.rb +18 -4
- data/lib/rubocop/cop/style/while_until_do.rb +34 -16
- data/lib/rubocop/cop/style/while_until_modifier.rb +32 -12
- data/lib/rubocop/cop/style/word_array.rb +45 -102
- data/lib/rubocop/cop/style/yoda_condition.rb +107 -0
- data/lib/rubocop/cop/style/zero_length_predicate.rb +55 -32
- data/lib/rubocop/cop/team.rb +33 -35
- data/lib/rubocop/cop/util.rb +120 -54
- data/lib/rubocop/cop/variable_force/assignment.rb +5 -9
- data/lib/rubocop/cop/variable_force/branch.rb +318 -0
- data/lib/rubocop/cop/variable_force/branchable.rb +21 -0
- data/lib/rubocop/cop/variable_force/reference.rb +1 -2
- data/lib/rubocop/cop/variable_force/scope.rb +37 -26
- data/lib/rubocop/cop/variable_force/variable.rb +12 -12
- data/lib/rubocop/cop/variable_force/variable_table.rb +3 -4
- data/lib/rubocop/cop/variable_force.rb +72 -39
- data/lib/rubocop/error.rb +0 -1
- data/lib/rubocop/formatter/base_formatter.rb +4 -9
- data/lib/rubocop/formatter/clang_style_formatter.rb +2 -3
- data/lib/rubocop/formatter/colorizable.rb +9 -10
- data/lib/rubocop/formatter/disabled_config_formatter.rb +48 -35
- data/lib/rubocop/formatter/disabled_lines_formatter.rb +0 -1
- data/lib/rubocop/formatter/emacs_style_formatter.rb +0 -1
- data/lib/rubocop/formatter/file_list_formatter.rb +0 -1
- data/lib/rubocop/formatter/formatter_set.rb +16 -13
- data/lib/rubocop/formatter/fuubar_style_formatter.rb +6 -1
- data/lib/rubocop/formatter/html_formatter.rb +5 -5
- data/lib/rubocop/formatter/json_formatter.rb +9 -4
- data/lib/rubocop/formatter/offense_count_formatter.rb +2 -1
- data/lib/rubocop/formatter/progress_formatter.rb +0 -1
- data/lib/rubocop/formatter/quiet_formatter.rb +13 -0
- data/lib/rubocop/formatter/simple_text_formatter.rb +7 -17
- data/lib/rubocop/formatter/tap_formatter.rb +71 -0
- data/lib/rubocop/formatter/text_util.rb +0 -1
- data/lib/rubocop/formatter/worst_offenders_formatter.rb +6 -5
- data/lib/rubocop/magic_comment.rb +210 -0
- data/lib/rubocop/name_similarity.rb +0 -1
- data/lib/rubocop/node_pattern.rb +181 -118
- data/lib/rubocop/options.rb +154 -88
- data/lib/rubocop/path_util.rb +38 -4
- data/lib/rubocop/platform.rb +11 -0
- data/lib/rubocop/processed_source.rb +23 -20
- data/lib/rubocop/rake_task.rb +16 -24
- data/lib/rubocop/remote_config.rb +40 -13
- data/lib/rubocop/result_cache.rb +33 -24
- data/lib/rubocop/rspec/cop_helper.rb +21 -7
- data/lib/rubocop/rspec/expect_offense.rb +165 -0
- data/lib/rubocop/rspec/host_environment_simulation_helper.rb +1 -2
- data/lib/rubocop/rspec/shared_contexts.rb +24 -9
- data/lib/rubocop/rspec/shared_examples.rb +10 -19
- data/lib/rubocop/rspec/support.rb +5 -5
- data/lib/rubocop/runner.rb +74 -39
- data/lib/rubocop/string_interpreter.rb +0 -1
- data/lib/rubocop/string_util.rb +11 -6
- data/lib/rubocop/target_finder.rb +70 -8
- data/lib/rubocop/token.rb +79 -2
- data/lib/rubocop/version.rb +2 -5
- data/lib/rubocop/warning.rb +0 -1
- data/lib/rubocop.rb +569 -398
- metadata +301 -112
- data/lib/rubocop/ast_node/builder.rb +0 -31
- data/lib/rubocop/ast_node/sexp.rb +0 -14
- data/lib/rubocop/ast_node.rb +0 -623
- data/lib/rubocop/cop/lint/eval.rb +0 -23
- data/lib/rubocop/cop/lint/invalid_character_literal.rb +0 -39
- data/lib/rubocop/cop/lint/useless_array_splat.rb +0 -56
- data/lib/rubocop/cop/mixin/access_modifier_node.rb +0 -42
- data/lib/rubocop/cop/mixin/autocorrect_alignment.rb +0 -152
- data/lib/rubocop/cop/mixin/hash_node.rb +0 -15
- data/lib/rubocop/cop/mixin/if_node.rb +0 -37
- data/lib/rubocop/cop/mixin/on_method_def.rb +0 -31
- data/lib/rubocop/cop/mixin/space_inside.rb +0 -79
- data/lib/rubocop/cop/performance/hash_each.rb +0 -86
- data/lib/rubocop/cop/performance/push_splat.rb +0 -47
- data/lib/rubocop/cop/style/accessor_method_name.rb +0 -46
- data/lib/rubocop/cop/style/align_array.rb +0 -21
- data/lib/rubocop/cop/style/align_hash.rb +0 -256
- data/lib/rubocop/cop/style/case_indentation.rb +0 -92
- data/lib/rubocop/cop/style/class_and_module_camel_case.rb +0 -30
- data/lib/rubocop/cop/style/constant_name.rb +0 -30
- data/lib/rubocop/cop/style/empty_line_between_defs.rb +0 -76
- data/lib/rubocop/cop/style/empty_lines_around_class_body.rb +0 -40
- data/lib/rubocop/cop/style/end_of_line.rb +0 -31
- data/lib/rubocop/cop/style/initial_indentation.rb +0 -38
- data/lib/rubocop/cop/style/leading_comment_space.rb +0 -33
- data/lib/rubocop/cop/style/method_name.rb +0 -29
- data/lib/rubocop/cop/style/multiline_method_call_indentation.rb +0 -176
- data/lib/rubocop/cop/style/op_method.rb +0 -44
- data/lib/rubocop/cop/style/predicate_name.rb +0 -68
- data/lib/rubocop/cop/style/space_after_comma.rb +0 -22
- data/lib/rubocop/cop/style/space_after_not.rb +0 -42
- data/lib/rubocop/cop/style/space_around_operators.rb +0 -132
- data/lib/rubocop/cop/style/space_before_block_braces.rb +0 -65
- data/lib/rubocop/cop/style/space_before_comma.rb +0 -17
- data/lib/rubocop/cop/style/space_before_semicolon.rb +0 -17
- data/lib/rubocop/cop/style/space_inside_block_braces.rb +0 -166
- data/lib/rubocop/cop/style/space_inside_brackets.rb +0 -21
- data/lib/rubocop/cop/style/space_inside_parens.rb +0 -17
- data/lib/rubocop/cop/style/space_inside_string_interpolation.rb +0 -52
- data/lib/rubocop/cop/style/variable_name.rb +0 -40
- data/lib/rubocop/cop/variable_force/locatable.rb +0 -197
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
require 'yaml'
|
@@ -17,70 +16,54 @@ module RuboCop
|
|
17
16
|
AUTO_GENERATED_FILE = '.rubocop_todo.yml'.freeze
|
18
17
|
|
19
18
|
class << self
|
20
|
-
|
21
|
-
|
22
|
-
attr_accessor :debug, :auto_gen_config
|
19
|
+
attr_accessor :debug, :auto_gen_config, :ignore_parent_exclusion
|
23
20
|
attr_writer :root_level # The upwards search is stopped at this level.
|
24
21
|
attr_writer :default_configuration
|
25
22
|
|
26
23
|
alias debug? debug
|
27
24
|
alias auto_gen_config? auto_gen_config
|
25
|
+
alias ignore_parent_exclusion? ignore_parent_exclusion
|
28
26
|
|
29
27
|
def clear_options
|
30
28
|
@debug = @auto_gen_config = @root_level = nil
|
31
29
|
end
|
32
30
|
|
33
|
-
def load_file(
|
34
|
-
|
31
|
+
def load_file(file)
|
32
|
+
return if file.nil?
|
33
|
+
path = File.absolute_path(file.is_a?(RemoteConfig) ? file.file : file)
|
34
|
+
|
35
35
|
hash = load_yaml_configuration(path)
|
36
36
|
|
37
|
-
|
38
|
-
|
39
|
-
|
37
|
+
# Resolve requires first in case they define additional cops
|
38
|
+
resolver.resolve_requires(path, hash)
|
39
|
+
|
40
|
+
add_missing_namespaces(path, hash)
|
41
|
+
target_ruby_version_to_f!(hash)
|
42
|
+
|
43
|
+
resolver.resolve_inheritance_from_gems(hash, hash.delete('inherit_gem'))
|
44
|
+
resolver.resolve_inheritance(path, hash, file)
|
40
45
|
|
41
46
|
hash.delete('inherit_from')
|
42
|
-
config = Config.new(hash, path)
|
43
47
|
|
44
|
-
|
45
|
-
|
46
|
-
|
48
|
+
Config.create(hash, path)
|
49
|
+
end
|
50
|
+
|
51
|
+
# rubocop:disable Performance/HashEachMethods
|
52
|
+
def add_missing_namespaces(path, hash)
|
53
|
+
hash.keys.each do |key|
|
54
|
+
q = Cop::Cop.qualified_cop_name(key, path)
|
55
|
+
next if q == key
|
47
56
|
|
48
|
-
|
49
|
-
|
50
|
-
config.make_excludes_absolute
|
51
|
-
config
|
57
|
+
hash[q] = hash.delete(key)
|
58
|
+
end
|
52
59
|
end
|
60
|
+
# rubocop:enable Performance/HashEachMethods
|
53
61
|
|
54
62
|
# Return a recursive merge of two hashes. That is, a normal hash merge,
|
55
63
|
# with the addition that any value that is a hash, and occurs in both
|
56
64
|
# arguments, will also be merged. And so on.
|
57
65
|
def merge(base_hash, derived_hash)
|
58
|
-
|
59
|
-
keys_appearing_in_both = base_hash.keys & derived_hash.keys
|
60
|
-
keys_appearing_in_both.each do |key|
|
61
|
-
next unless base_hash[key].is_a?(Hash)
|
62
|
-
result[key] = merge(base_hash[key], derived_hash[key])
|
63
|
-
end
|
64
|
-
result
|
65
|
-
end
|
66
|
-
|
67
|
-
def base_configs(path, inherit_from)
|
68
|
-
configs = Array(inherit_from).compact.map do |f|
|
69
|
-
if f =~ /\A#{URI.regexp(%w(http https))}\z/
|
70
|
-
f = RemoteConfig.new(f, File.dirname(path)).file
|
71
|
-
else
|
72
|
-
f = File.expand_path(f, File.dirname(path))
|
73
|
-
|
74
|
-
if auto_gen_config?
|
75
|
-
next if f.include?(AUTO_GENERATED_FILE)
|
76
|
-
end
|
77
|
-
|
78
|
-
print 'Inheriting ' if debug?
|
79
|
-
end
|
80
|
-
load_file(f)
|
81
|
-
end
|
82
|
-
|
83
|
-
configs.compact
|
66
|
+
resolver.merge(base_hash, derived_hash)
|
84
67
|
end
|
85
68
|
|
86
69
|
# Returns the path of .rubocop.yml searching upwards in the
|
@@ -96,14 +79,21 @@ module RuboCop
|
|
96
79
|
config = load_file(config_file)
|
97
80
|
return config if config_file == DEFAULT_FILE
|
98
81
|
|
99
|
-
|
100
|
-
|
101
|
-
|
102
|
-
config
|
82
|
+
if ignore_parent_exclusion?
|
83
|
+
print 'Ignoring AllCops/Exclude from parent folders' if debug?
|
84
|
+
else
|
85
|
+
add_excludes_from_files(config, config_file)
|
103
86
|
end
|
104
87
|
merge_with_default(config, config_file)
|
105
88
|
end
|
106
89
|
|
90
|
+
def add_excludes_from_files(config, config_file)
|
91
|
+
found_files = config_files_in_path(config_file)
|
92
|
+
return unless found_files.any? && found_files.last != config_file
|
93
|
+
print 'AllCops/Exclude ' if debug?
|
94
|
+
config.add_excludes_from_higher_level(load_file(found_files.last))
|
95
|
+
end
|
96
|
+
|
107
97
|
def default_configuration
|
108
98
|
@default_configuration ||= begin
|
109
99
|
print 'Default ' if debug?
|
@@ -114,33 +104,52 @@ module RuboCop
|
|
114
104
|
# Merges the given configuration with the default one. If
|
115
105
|
# AllCops:DisabledByDefault is true, it changes the Enabled params so
|
116
106
|
# that only cops from user configuration are enabled.
|
107
|
+
# If AllCops::EnabledByDefault is true, it changes the Enabled params
|
108
|
+
# so that only cops explicitly disabled in user configuration are
|
109
|
+
# disabled.
|
117
110
|
def merge_with_default(config, config_file)
|
118
|
-
|
119
|
-
|
120
|
-
|
121
|
-
|
122
|
-
|
123
|
-
|
124
|
-
|
125
|
-
|
126
|
-
|
127
|
-
|
128
|
-
|
129
|
-
|
130
|
-
|
111
|
+
resolver.merge_with_default(config, config_file)
|
112
|
+
end
|
113
|
+
|
114
|
+
def target_ruby_version_to_f!(hash)
|
115
|
+
version = 'TargetRubyVersion'
|
116
|
+
return unless hash['AllCops'] && hash['AllCops'][version]
|
117
|
+
|
118
|
+
hash['AllCops'][version] = hash['AllCops'][version].to_f
|
119
|
+
end
|
120
|
+
|
121
|
+
def add_inheritance_from_auto_generated_file
|
122
|
+
file_string = " #{AUTO_GENERATED_FILE}"
|
123
|
+
|
124
|
+
if File.exist?(DOTFILE)
|
125
|
+
files = Array(load_yaml_configuration(DOTFILE)['inherit_from'])
|
126
|
+
return if files.include?(AUTO_GENERATED_FILE)
|
127
|
+
files.unshift(AUTO_GENERATED_FILE)
|
128
|
+
file_string = "\n - " + files.join("\n - ") if files.size > 1
|
129
|
+
rubocop_yml_contents = IO.read(DOTFILE, encoding: Encoding::UTF_8)
|
130
|
+
.sub(/^inherit_from: *[.\w]+/, '')
|
131
|
+
.sub(/^inherit_from: *(\n *- *[.\w]+)+/, '')
|
132
|
+
end
|
133
|
+
write_dotfile(file_string, rubocop_yml_contents)
|
134
|
+
puts "Added inheritance from `#{AUTO_GENERATED_FILE}` in `#{DOTFILE}`."
|
131
135
|
end
|
132
136
|
|
133
137
|
private
|
134
138
|
|
135
|
-
|
136
|
-
|
137
|
-
|
138
|
-
|
139
|
+
def write_dotfile(file_string, rubocop_yml_contents)
|
140
|
+
File.open(DOTFILE, 'w') do |f|
|
141
|
+
f.write "inherit_from:#{file_string}\n\n"
|
142
|
+
f.write rubocop_yml_contents if rubocop_yml_contents
|
143
|
+
end
|
144
|
+
end
|
145
|
+
|
146
|
+
def resolver
|
147
|
+
@resolver ||= ConfigLoaderResolver.new
|
139
148
|
end
|
140
149
|
|
141
150
|
def load_yaml_configuration(absolute_path)
|
142
|
-
yaml_code =
|
143
|
-
hash = yaml_safe_load(yaml_code) || {}
|
151
|
+
yaml_code = read_file(absolute_path)
|
152
|
+
hash = yaml_safe_load(yaml_code, absolute_path) || {}
|
144
153
|
|
145
154
|
puts "configuration from #{absolute_path}" if debug?
|
146
155
|
|
@@ -151,26 +160,29 @@ module RuboCop
|
|
151
160
|
hash
|
152
161
|
end
|
153
162
|
|
154
|
-
|
163
|
+
# Read the specified file, or exit with a friendly, concise message on
|
164
|
+
# stderr. Care is taken to use the standard OS exit code for a "file not
|
165
|
+
# found" error.
|
166
|
+
def read_file(absolute_path)
|
167
|
+
IO.read(absolute_path, encoding: Encoding::UTF_8)
|
168
|
+
rescue Errno::ENOENT
|
169
|
+
warn(format('Configuration file not found: %s', absolute_path))
|
170
|
+
exit(Errno::ENOENT::Errno)
|
171
|
+
end
|
172
|
+
|
173
|
+
def yaml_safe_load(yaml_code, filename)
|
155
174
|
if YAML.respond_to?(:safe_load) # Ruby 2.1+
|
156
175
|
if defined?(SafeYAML) && SafeYAML.respond_to?(:load)
|
157
|
-
SafeYAML.load(yaml_code,
|
176
|
+
SafeYAML.load(yaml_code, filename,
|
177
|
+
whitelisted_tags: %w[!ruby/regexp])
|
158
178
|
else
|
159
|
-
YAML.safe_load(yaml_code, [Regexp])
|
179
|
+
YAML.safe_load(yaml_code, [Regexp, Symbol], [], false, filename)
|
160
180
|
end
|
161
181
|
else
|
162
|
-
YAML.load(yaml_code)
|
182
|
+
YAML.load(yaml_code, filename) # rubocop:disable Security/YAMLLoad
|
163
183
|
end
|
164
184
|
end
|
165
185
|
|
166
|
-
def gem_config_path(gem_name, relative_config_path)
|
167
|
-
spec = Gem::Specification.find_by_name(gem_name)
|
168
|
-
return File.join(spec.gem_dir, relative_config_path)
|
169
|
-
rescue Gem::LoadError => e
|
170
|
-
raise Gem::LoadError,
|
171
|
-
"Unable to find gem #{gem_name}; is the gem installed? #{e}"
|
172
|
-
end
|
173
|
-
|
174
186
|
def config_files_in_path(target)
|
175
187
|
possible_config_files = dirs_to_search(target).map do |dir|
|
176
188
|
File.join(dir, DOTFILE)
|
@@ -188,5 +200,8 @@ module RuboCop
|
|
188
200
|
dirs_to_search
|
189
201
|
end
|
190
202
|
end
|
203
|
+
|
204
|
+
# Initializing class ivars
|
205
|
+
clear_options
|
191
206
|
end
|
192
207
|
end
|
@@ -1,12 +1,11 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
require 'yaml'
|
5
4
|
require 'pathname'
|
6
5
|
|
7
6
|
module RuboCop
|
8
|
-
# A
|
9
|
-
|
7
|
+
# A help class for ConfigLoader that handles configuration resolution.
|
8
|
+
class ConfigLoaderResolver
|
10
9
|
def resolve_requires(path, hash)
|
11
10
|
config_dir = File.dirname(path)
|
12
11
|
Array(hash.delete('require')).each do |r|
|
@@ -18,8 +17,9 @@ module RuboCop
|
|
18
17
|
end
|
19
18
|
end
|
20
19
|
|
21
|
-
def resolve_inheritance(path, hash)
|
22
|
-
base_configs(path, hash['inherit_from'])
|
20
|
+
def resolve_inheritance(path, hash, file)
|
21
|
+
base_configs(path, hash['inherit_from'], file)
|
22
|
+
.reverse_each do |base_config|
|
23
23
|
base_config.each do |k, v|
|
24
24
|
hash[k] = hash.key?(k) ? merge(v, hash[k]) : v if v.is_a?(Hash)
|
25
25
|
end
|
@@ -34,9 +34,108 @@ module RuboCop
|
|
34
34
|
end
|
35
35
|
|
36
36
|
hash['inherit_from'] = Array(hash['inherit_from'])
|
37
|
-
|
38
|
-
|
37
|
+
Array(config_path).reverse.each do |path|
|
38
|
+
# Put gem configuration first so local configuration overrides it.
|
39
|
+
hash['inherit_from'].unshift gem_config_path(gem_name, path)
|
40
|
+
end
|
41
|
+
end
|
42
|
+
end
|
43
|
+
|
44
|
+
# Merges the given configuration with the default one. If
|
45
|
+
# AllCops:DisabledByDefault is true, it changes the Enabled params so that
|
46
|
+
# only cops from user configuration are enabled. If
|
47
|
+
# AllCops::EnabledByDefault is true, it changes the Enabled params so that
|
48
|
+
# only cops explicitly disabled in user configuration are disabled.
|
49
|
+
def merge_with_default(config, config_file)
|
50
|
+
default_configuration = ConfigLoader.default_configuration
|
51
|
+
|
52
|
+
disabled_by_default = config.for_all_cops['DisabledByDefault']
|
53
|
+
enabled_by_default = config.for_all_cops['EnabledByDefault']
|
54
|
+
|
55
|
+
if disabled_by_default || enabled_by_default
|
56
|
+
default_configuration = transform(default_configuration) do |params|
|
57
|
+
params.merge('Enabled' => !disabled_by_default)
|
58
|
+
end
|
59
|
+
end
|
60
|
+
|
61
|
+
if disabled_by_default
|
62
|
+
config = handle_disabled_by_default(config, default_configuration)
|
63
|
+
end
|
64
|
+
|
65
|
+
Config.new(merge(default_configuration, config), config_file)
|
66
|
+
end
|
67
|
+
|
68
|
+
# Returns a new hash where the parameters of the given config hash have
|
69
|
+
# been replaced by parameters returned by the given block.
|
70
|
+
# Return a recursive merge of two hashes. That is, a normal hash merge,
|
71
|
+
# with the addition that any value that is a hash, and occurs in both
|
72
|
+
# arguments, will also be merged. And so on.
|
73
|
+
def merge(base_hash, derived_hash)
|
74
|
+
result = base_hash.merge(derived_hash)
|
75
|
+
keys_appearing_in_both = base_hash.keys & derived_hash.keys
|
76
|
+
keys_appearing_in_both.each do |key|
|
77
|
+
next unless base_hash[key].is_a?(Hash)
|
78
|
+
result[key] = merge(base_hash[key], derived_hash[key])
|
79
|
+
end
|
80
|
+
result
|
81
|
+
end
|
82
|
+
|
83
|
+
private
|
84
|
+
|
85
|
+
def base_configs(path, inherit_from, file)
|
86
|
+
configs = Array(inherit_from).compact.map do |f|
|
87
|
+
ConfigLoader.load_file(inherited_file(path, f, file))
|
39
88
|
end
|
89
|
+
|
90
|
+
configs.compact
|
91
|
+
end
|
92
|
+
|
93
|
+
def inherited_file(path, inherit_from, file)
|
94
|
+
regex = URI::DEFAULT_PARSER.make_regexp(%w[http https])
|
95
|
+
if inherit_from =~ /\A#{regex}\z/
|
96
|
+
RemoteConfig.new(inherit_from, File.dirname(path))
|
97
|
+
elsif file.is_a?(RemoteConfig)
|
98
|
+
file.inherit_from_remote(inherit_from, path)
|
99
|
+
else
|
100
|
+
print 'Inheriting ' if ConfigLoader.debug?
|
101
|
+
File.expand_path(inherit_from, File.dirname(path))
|
102
|
+
end
|
103
|
+
end
|
104
|
+
|
105
|
+
def handle_disabled_by_default(config, new_default_configuration)
|
106
|
+
department_config = config.to_hash.reject { |cop| cop.include?('/') }
|
107
|
+
department_config.each do |dept, dept_params|
|
108
|
+
# Rails is always disabled by default and the department's Enabled flag
|
109
|
+
# works like the --rails command line option, which is that when
|
110
|
+
# AllCops:DisabledByDefault is true, each Rails cop must still be
|
111
|
+
# explicitly mentioned in user configuration in order to be enabled.
|
112
|
+
next if dept == 'Rails'
|
113
|
+
|
114
|
+
next unless dept_params['Enabled']
|
115
|
+
|
116
|
+
new_default_configuration.each do |cop, params|
|
117
|
+
next unless cop.start_with?(dept + '/')
|
118
|
+
|
119
|
+
# Retain original default configuration for cops in the department.
|
120
|
+
params['Enabled'] = ConfigLoader.default_configuration[cop]['Enabled']
|
121
|
+
end
|
122
|
+
end
|
123
|
+
|
124
|
+
transform(config) do |params|
|
125
|
+
{ 'Enabled' => true }.merge(params) # Set true if not set.
|
126
|
+
end
|
127
|
+
end
|
128
|
+
|
129
|
+
def transform(config)
|
130
|
+
Hash[config.map { |cop, params| [cop, yield(params)] }]
|
131
|
+
end
|
132
|
+
|
133
|
+
def gem_config_path(gem_name, relative_config_path)
|
134
|
+
spec = Gem::Specification.find_by_name(gem_name)
|
135
|
+
return File.join(spec.gem_dir, relative_config_path)
|
136
|
+
rescue Gem::LoadError => e
|
137
|
+
raise Gem::LoadError,
|
138
|
+
"Unable to find gem #{gem_name}; is the gem installed? #{e}"
|
40
139
|
end
|
41
140
|
end
|
42
141
|
end
|
data/lib/rubocop/config_store.rb
CHANGED
@@ -1,4 +1,3 @@
|
|
1
|
-
# encoding: utf-8
|
2
1
|
# frozen_string_literal: true
|
3
2
|
|
4
3
|
module RuboCop
|
@@ -26,6 +25,10 @@ module RuboCop
|
|
26
25
|
options_config)
|
27
26
|
end
|
28
27
|
|
28
|
+
def force_default_config!
|
29
|
+
@options_config = ConfigLoader.default_configuration
|
30
|
+
end
|
31
|
+
|
29
32
|
def for(file_or_dir)
|
30
33
|
return @options_config if @options_config
|
31
34
|
|
@@ -0,0 +1,73 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
# Identifier of all cops containing a department and cop name.
|
6
|
+
#
|
7
|
+
# All cops are identified by their badge. For example, the badge
|
8
|
+
# for `RuboCop::Cop::Layout::Tab` is `Layout/Tab`. Badges can be
|
9
|
+
# parsed as either `Department/CopName` or just `CopName` to allow
|
10
|
+
# for badge references in source files that omit the department
|
11
|
+
# for RuboCop to infer.
|
12
|
+
class Badge
|
13
|
+
# Error raised when a badge parse fails.
|
14
|
+
class InvalidBadge < Error
|
15
|
+
MSG = 'Invalid badge %<badge>p. ' \
|
16
|
+
'Expected `Department/CopName` or `CopName`.'.freeze
|
17
|
+
|
18
|
+
def initialize(token)
|
19
|
+
super(format(MSG, badge: token))
|
20
|
+
end
|
21
|
+
end
|
22
|
+
|
23
|
+
attr_reader :department, :cop_name
|
24
|
+
|
25
|
+
def self.for(class_name)
|
26
|
+
new(*class_name.split('::').last(2))
|
27
|
+
end
|
28
|
+
|
29
|
+
def self.parse(identifier)
|
30
|
+
parts = identifier.split('/', 2)
|
31
|
+
|
32
|
+
raise InvalidBadge, identifier if parts.size > 2
|
33
|
+
|
34
|
+
if parts.one?
|
35
|
+
new(nil, *parts)
|
36
|
+
else
|
37
|
+
new(*parts)
|
38
|
+
end
|
39
|
+
end
|
40
|
+
|
41
|
+
def initialize(department, cop_name)
|
42
|
+
@department = department.to_sym if department
|
43
|
+
@cop_name = cop_name
|
44
|
+
end
|
45
|
+
|
46
|
+
def ==(other)
|
47
|
+
hash == other.hash
|
48
|
+
end
|
49
|
+
alias eql? ==
|
50
|
+
|
51
|
+
def hash
|
52
|
+
[department, cop_name].hash
|
53
|
+
end
|
54
|
+
|
55
|
+
def match?(other)
|
56
|
+
cop_name == other.cop_name &&
|
57
|
+
(!qualified? || department == other.department)
|
58
|
+
end
|
59
|
+
|
60
|
+
def to_s
|
61
|
+
qualified? ? "#{department}/#{cop_name}" : cop_name
|
62
|
+
end
|
63
|
+
|
64
|
+
def qualified?
|
65
|
+
!department.nil?
|
66
|
+
end
|
67
|
+
|
68
|
+
def with_department(department)
|
69
|
+
self.class.new(department, cop_name)
|
70
|
+
end
|
71
|
+
end
|
72
|
+
end
|
73
|
+
end
|
@@ -0,0 +1,71 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
module Bundler
|
6
|
+
# A Gem's requirements should be listed only once in a Gemfile.
|
7
|
+
# @example
|
8
|
+
# # bad
|
9
|
+
# gem 'rubocop'
|
10
|
+
# gem 'rubocop'
|
11
|
+
#
|
12
|
+
# # bad
|
13
|
+
# group :development do
|
14
|
+
# gem 'rubocop'
|
15
|
+
# end
|
16
|
+
#
|
17
|
+
# group :test do
|
18
|
+
# gem 'rubocop'
|
19
|
+
# end
|
20
|
+
#
|
21
|
+
# # good
|
22
|
+
# group :development, :test do
|
23
|
+
# gem 'rubocop'
|
24
|
+
# end
|
25
|
+
#
|
26
|
+
# # good
|
27
|
+
# gem 'rubocop', groups: [:development, :test]
|
28
|
+
class DuplicatedGem < Cop
|
29
|
+
MSG = 'Gem `%<gem_name>s` requirements already given on line '\
|
30
|
+
'%<line_of_first_occurrence>d of the Gemfile.'.freeze
|
31
|
+
|
32
|
+
def investigate(processed_source)
|
33
|
+
return unless processed_source.ast
|
34
|
+
|
35
|
+
duplicated_gem_nodes.each do |nodes|
|
36
|
+
nodes[1..-1].each do |node|
|
37
|
+
register_offense(
|
38
|
+
node,
|
39
|
+
node.first_argument.to_a.first,
|
40
|
+
nodes.first.first_line
|
41
|
+
)
|
42
|
+
end
|
43
|
+
end
|
44
|
+
end
|
45
|
+
|
46
|
+
private
|
47
|
+
|
48
|
+
def_node_search :gem_declarations, '(send nil? :gem str ...)'
|
49
|
+
|
50
|
+
def duplicated_gem_nodes
|
51
|
+
gem_declarations(processed_source.ast)
|
52
|
+
.group_by(&:first_argument)
|
53
|
+
.values
|
54
|
+
.select { |nodes| nodes.size > 1 }
|
55
|
+
end
|
56
|
+
|
57
|
+
def register_offense(node, gem_name, line_of_first_occurrence)
|
58
|
+
line_range = node.loc.column...node.loc.last_column
|
59
|
+
offense_location =
|
60
|
+
source_range(processed_source.buffer, node.first_line, line_range)
|
61
|
+
message = format(
|
62
|
+
MSG,
|
63
|
+
gem_name: gem_name,
|
64
|
+
line_of_first_occurrence: line_of_first_occurrence
|
65
|
+
)
|
66
|
+
add_offense(node, location: offense_location, message: message)
|
67
|
+
end
|
68
|
+
end
|
69
|
+
end
|
70
|
+
end
|
71
|
+
end
|
@@ -0,0 +1,67 @@
|
|
1
|
+
# frozen_string_literal: true
|
2
|
+
|
3
|
+
module RuboCop
|
4
|
+
module Cop
|
5
|
+
module Bundler
|
6
|
+
# The symbol argument `:gemcutter`, `:rubygems` and `:rubyforge`
|
7
|
+
# are deprecated. So please change your source to URL string that
|
8
|
+
# 'https://rubygems.org' if possible, or 'http://rubygems.org' if not.
|
9
|
+
#
|
10
|
+
# This autocorrect will replace these symbols with 'https://rubygems.org'.
|
11
|
+
# Because it is secure, HTTPS request is strongly recommended. And in
|
12
|
+
# most use cases HTTPS will be fine.
|
13
|
+
#
|
14
|
+
# However, it don't replace all `sources` of `http://` with `https://`.
|
15
|
+
# For example, when specifying an internal gem server using HTTP on the
|
16
|
+
# intranet, a use case where HTTPS can not be specified was considered.
|
17
|
+
# Consider using HTTP only if you can not use HTTPS.
|
18
|
+
#
|
19
|
+
# @example
|
20
|
+
# # bad
|
21
|
+
# source :gemcutter
|
22
|
+
# source :rubygems
|
23
|
+
# source :rubyforge
|
24
|
+
#
|
25
|
+
# # good
|
26
|
+
# source 'https://rubygems.org' # strongly recommended
|
27
|
+
# source 'http://rubygems.org'
|
28
|
+
class InsecureProtocolSource < Cop
|
29
|
+
MSG = 'The source `:%<source>s` is deprecated because HTTP requests ' \
|
30
|
+
'are insecure. ' \
|
31
|
+
"Please change your source to 'https://rubygems.org' " \
|
32
|
+
"if possible, or 'http://rubygems.org' if not.".freeze
|
33
|
+
|
34
|
+
def_node_matcher :insecure_protocol_source?, <<-PATTERN
|
35
|
+
(send nil? :source
|
36
|
+
(sym ${:gemcutter :rubygems :rubyforge}))
|
37
|
+
PATTERN
|
38
|
+
|
39
|
+
def on_send(node)
|
40
|
+
insecure_protocol_source?(node) do |source|
|
41
|
+
message = format(MSG, source: source)
|
42
|
+
|
43
|
+
add_offense(
|
44
|
+
node,
|
45
|
+
location: source_range(node.first_argument.loc.expression),
|
46
|
+
message: message
|
47
|
+
)
|
48
|
+
end
|
49
|
+
end
|
50
|
+
|
51
|
+
def autocorrect(node)
|
52
|
+
lambda do |corrector|
|
53
|
+
corrector.replace(
|
54
|
+
node.first_argument.loc.expression, "'https://rubygems.org'"
|
55
|
+
)
|
56
|
+
end
|
57
|
+
end
|
58
|
+
|
59
|
+
private
|
60
|
+
|
61
|
+
def source_range(node)
|
62
|
+
range_between(node.begin_pos, node.end_pos)
|
63
|
+
end
|
64
|
+
end
|
65
|
+
end
|
66
|
+
end
|
67
|
+
end
|