rubocop 0.42.0 → 0.43.0

data/lib/rubocop/string_util.rb

@@ -44,11 +44,7 @@ module RuboCop
         transposition_count =
           count_transpositions(common_chars_a, common_chars_b)
 
-        sum = (matched_count / shorter.size.to_f) +
-              (matched_count / longer.size.to_f) +
-              ((matched_count - transposition_count / 2) / matched_count.to_f)
-
-        sum / 3.0
+        compute_non_zero_distance(matched_count.to_f, transposition_count)
       end
 
       def find_common_characters
@@ -80,6 +76,14 @@ module RuboCop
         end
       end
 
+      def compute_non_zero_distance(matched_count, transposition_count)
+        sum = (matched_count / shorter.size.to_f) +
+              (matched_count / longer.size.to_f) +
+              ((matched_count - transposition_count / 2) / matched_count)
+
+        sum / 3.0
+      end
+
       def matching_index_range(origin)
         min = origin - matching_window
         min = 0 if min < 0

data/lib/rubocop/target_finder.rb

@@ -56,7 +56,7 @@ module RuboCop
     def target_files_in_dir(base_dir = Dir.pwd)
       # Support Windows: Backslashes from command-line -> forward slashes
       if File::ALT_SEPARATOR
-        base_dir.gsub!(File::ALT_SEPARATOR, File::SEPARATOR)
+        base_dir = base_dir.gsub(File::ALT_SEPARATOR, File::SEPARATOR)
       end
       all_files = find_files(base_dir, File::FNM_DOTMATCH)
       hidden_files = Set.new(all_files - find_files(base_dir, 0))

data/lib/rubocop/token.rb

@@ -15,7 +15,7 @@ module RuboCop
     def initialize(pos, type, text)
       @pos = pos
       @type = type
-      # Parser token "text" may be a Fixnum
+      # Parser token "text" may be an Integer
       @text = text.to_s
     end
 

data/lib/rubocop/version.rb

@@ -4,7 +4,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.42.0'.freeze
+    STRING = '0.43.0'.freeze
 
     MSG = '%s (using Parser %s, running on %s %s %s)'.freeze
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop
 version: !ruby/object:Gem::Version
-  version: 0.42.0
+  version: 0.43.0
 platform: ruby
 authors:
 - Bozhidar Batsov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-25 00:00:00.000000000 Z
+date: 2016-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -194,12 +194,13 @@ files:
 - lib/rubocop/cop/lint/string_conversion_in_interpolation.rb
 - lib/rubocop/cop/lint/syntax.rb
 - lib/rubocop/cop/lint/underscore_prefixed_variable_name.rb
+- lib/rubocop/cop/lint/unified_integer.rb
 - lib/rubocop/cop/lint/unneeded_disable.rb
+- lib/rubocop/cop/lint/unneeded_splat_expansion.rb
 - lib/rubocop/cop/lint/unreachable_code.rb
 - lib/rubocop/cop/lint/unused_block_argument.rb
 - lib/rubocop/cop/lint/unused_method_argument.rb
 - lib/rubocop/cop/lint/useless_access_modifier.rb
-- lib/rubocop/cop/lint/useless_array_splat.rb
 - lib/rubocop/cop/lint/useless_assignment.rb
 - lib/rubocop/cop/lint/useless_comparison.rb
 - lib/rubocop/cop/lint/useless_else_without_rescue.rb
@@ -225,6 +226,9 @@ files:
 - lib/rubocop/cop/mixin/configurable_enforced_style.rb
 - lib/rubocop/cop/mixin/configurable_max.rb
 - lib/rubocop/cop/mixin/configurable_naming.rb
+- lib/rubocop/cop/mixin/configurable_numbering.rb
+- lib/rubocop/cop/mixin/def_node.rb
+- lib/rubocop/cop/mixin/documentation_comment.rb
 - lib/rubocop/cop/mixin/empty_lines_around_body.rb
 - lib/rubocop/cop/mixin/end_keyword_alignment.rb
 - lib/rubocop/cop/mixin/first_element_line_break.rb
@@ -246,6 +250,7 @@ files:
 - lib/rubocop/cop/mixin/percent_literal.rb
 - lib/rubocop/cop/mixin/preceding_following_alignment.rb
 - lib/rubocop/cop/mixin/safe_assignment.rb
+- lib/rubocop/cop/mixin/safe_mode.rb
 - lib/rubocop/cop/mixin/space_after_punctuation.rb
 - lib/rubocop/cop/mixin/space_before_punctuation.rb
 - lib/rubocop/cop/mixin/space_inside.rb
@@ -266,7 +271,6 @@ files:
 - lib/rubocop/cop/performance/flat_map.rb
 - lib/rubocop/cop/performance/hash_each.rb
 - lib/rubocop/cop/performance/lstrip_rstrip.rb
-- lib/rubocop/cop/performance/push_splat.rb
 - lib/rubocop/cop/performance/range_include.rb
 - lib/rubocop/cop/performance/redundant_block_call.rb
 - lib/rubocop/cop/performance/redundant_match.rb
@@ -275,6 +279,7 @@ files:
 - lib/rubocop/cop/performance/reverse_each.rb
 - lib/rubocop/cop/performance/sample.rb
 - lib/rubocop/cop/performance/size.rb
+- lib/rubocop/cop/performance/sort_with_block.rb
 - lib/rubocop/cop/performance/start_with.rb
 - lib/rubocop/cop/performance/string_replacement.rb
 - lib/rubocop/cop/performance/times_map.rb
@@ -285,16 +290,19 @@ files:
 - lib/rubocop/cop/rails/find_by.rb
 - lib/rubocop/cop/rails/find_each.rb
 - lib/rubocop/cop/rails/has_and_belongs_to_many.rb
+- lib/rubocop/cop/rails/not_null_column.rb
 - lib/rubocop/cop/rails/output.rb
 - lib/rubocop/cop/rails/output_safety.rb
 - lib/rubocop/cop/rails/pluralization_grammar.rb
 - lib/rubocop/cop/rails/read_write_attribute.rb
 - lib/rubocop/cop/rails/request_referer.rb
+- lib/rubocop/cop/rails/safe_navigation.rb
 - lib/rubocop/cop/rails/save_bang.rb
 - lib/rubocop/cop/rails/scope_args.rb
 - lib/rubocop/cop/rails/time_zone.rb
 - lib/rubocop/cop/rails/uniq_before_pluck.rb
 - lib/rubocop/cop/rails/validation.rb
+- lib/rubocop/cop/security/json_load.rb
 - lib/rubocop/cop/severity.rb
 - lib/rubocop/cop/style/access_modifier_indentation.rb
 - lib/rubocop/cop/style/accessor_method_name.rb
@@ -333,6 +341,7 @@ files:
 - lib/rubocop/cop/style/copyright.rb
 - lib/rubocop/cop/style/def_with_parentheses.rb
 - lib/rubocop/cop/style/documentation.rb
+- lib/rubocop/cop/style/documentation_method.rb
 - lib/rubocop/cop/style/dot_position.rb
 - lib/rubocop/cop/style/double_negation.rb
 - lib/rubocop/cop/style/each_for_simple_loop.rb
@@ -437,6 +446,7 @@ files:
 - lib/rubocop/cop/style/regexp_literal.rb
 - lib/rubocop/cop/style/rescue_ensure_alignment.rb
 - lib/rubocop/cop/style/rescue_modifier.rb
+- lib/rubocop/cop/style/safe_navigation.rb
 - lib/rubocop/cop/style/self_assignment.rb
 - lib/rubocop/cop/style/semicolon.rb
 - lib/rubocop/cop/style/send.rb
@@ -488,6 +498,7 @@ files:
 - lib/rubocop/cop/style/unneeded_percent_q.rb
 - lib/rubocop/cop/style/variable_interpolation.rb
 - lib/rubocop/cop/style/variable_name.rb
+- lib/rubocop/cop/style/variable_number.rb
 - lib/rubocop/cop/style/when_then.rb
 - lib/rubocop/cop/style/while_until_do.rb
 - lib/rubocop/cop/style/while_until_modifier.rb

data/lib/rubocop/cop/lint/useless_array_splat.rb

@@ -1,56 +0,0 @@
-# encoding: utf-8
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Lint
-      # This cop checks for unncessary array splats.
-      #
-      # @example
-      #
-      # # bad:
-      #
-      # a, b = *[1, 2, 3]
-      #
-      # # good:
-      #
-      # a, b = [1, 2, 3]
-      #
-      # # bad:
-      #
-      # a = *[1, 2, 3]
-      #
-      # # good:
-      #
-      # a = [1, 2, 3]
-      class UselessArraySplat < Cop
-        MSG = 'Unnecessary array splat.'.freeze
-        ARRAY_NEW_PATTERN = '(send (const nil :Array) :new ...)'.freeze
-
-        %w(m lv cv iv c gv).each do |var_type|
-          define_method("on_#{var_type}asgn") do |node|
-            *, rhs = *node
-
-            return unless rhs.is_a?(Node) && rhs.array_type?
-
-            add_offense(rhs, splat_source_range(rhs)) if array_splat?(rhs)
-          end
-        end
-
-        private
-
-        def_node_matcher :array_splat?, <<-PATTERN
-          (array (splat {(array ...) (block #{ARRAY_NEW_PATTERN} ...) #{ARRAY_NEW_PATTERN}} ...))
-        PATTERN
-
-        def splat_source_range(node)
-          node.loc.expression.begin.resize(1)
-        end
-
-        def autocorrect(node)
-          ->(corrector) { corrector.remove(splat_source_range(node)) }
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/performance/push_splat.rb

@@ -1,47 +0,0 @@
-# encoding: utf-8
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module Performance
-      # This cop is used to identify usages of
-      #
-      # @example
-      #   # bad
-      #   [].push(*a)
-      #
-      #   # good
-      #   [].concat(a)
-      class PushSplat < Cop
-        include Parentheses
-
-        MSG = 'Use `concat` instead of `push(*)`.'.freeze
-
-        def_node_matcher :push_splat, <<-END
-          (send _ :push (splat ...))
-        END
-
-        def on_send(node)
-          push_splat(node) do
-            add_offense(node, :expression, MSG)
-          end
-        end
-
-        def autocorrect(node)
-          _receiver, _method, splat = *node
-          body, = *splat
-          lambda do |corrector|
-            corrector.replace(node.location.selector, 'concat')
-
-            source = if parens_required?(splat)
-                       "(#{body.source})"
-                     else
-                       body.source
-                     end
-            corrector.replace(splat.loc.expression, source)
-          end
-        end
-      end
-    end
-  end
-end