rubocop 0.42.0 → 0.43.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4a32da91af2bcd18b8deee4673be9daf3a5783d2
-  data.tar.gz: 8d6c1b8a6624ccdaa5014ac08c18b2483768386c
+  metadata.gz: 5a3cab88e12da31681ef92d0b6f51398cf80b923
+  data.tar.gz: 1e86c53747471bba3288f3c50d58c5ff00cd6e8d
 SHA512:
-  metadata.gz: 0a5deb237bbedb201eabcfc8923d488bd44c11e151371cc467f8ac8678c8f04fb48fddd4d721dd0cc147a01006916bd554a333d755114f9ea665be61beaef557
-  data.tar.gz: 7adc5a8bc59f5fecc727ebe5e60ebdc0c87072636294d91a701263e77ac9a785a471469d1bd0d035d10dd5cefbfd7fcb4d506a5cd9c240b193591200c8af4cbe
+  metadata.gz: 16e14107016b4b1317715a5fa4aaf69292f3ba3b58f24f894b8967fd8e8e9762070c7a589b1ca887bdb1f82c631f8b5f240cc2e57c4e580e08ce83813abf9907
+  data.tar.gz: 6629b87681d63b954c4e24f23a44bf16226a8aa1222be8320cd09b750340416b95f0654c121bfda5867b4ad4fe69bb5996af63e86a84632bdf21055ea8e649b1

data/README.md

@@ -51,7 +51,7 @@ haven't reached version 1.0 yet). To prevent an unwanted RuboCop update you
 might want to use a conservative version locking in your `Gemfile`:
 
 ```rb
-gem 'rubocop', '~> 0.42.0', require: false
+gem 'rubocop', '~> 0.43.0', require: false
 ```
 
 ## Quickstart

data/assets/output.html.erb

@@ -70,14 +70,13 @@
     line-height: 2.2rem;
     margin: 0 0 0.5em;
     }
-    .information .infobox ul {
-    list-style: none;
-    margin: 0;
-    padding: 0;
-    }
-    .information .infobox ul li {
+    .information .offenses-list li {
     line-height: 1.8rem
     }
+    .information .offenses-list {
+    padding-left: 20px;
+    margin-bottom: 0;
+    }
 
     #offenses .offense-box {
     border-radius: 4px;
@@ -191,7 +190,7 @@
           idx,
           scrollY = window.scrollY;
         for (i = 0; i < boxPositions.length; i++) {
-          if (scrollY <= boxPositions[i]) {
+          if (scrollY <= boxPositions[i] - 1) {
             idx = i;
             break;
           }
@@ -214,14 +213,26 @@
     </div>
     <div class="information">
       <div class="infobox">
-        <%= pluralize(files.count, 'file') %> inspected,
-        <%= pluralize(summary.offense_count, 'offense', no_for_zero: true) %> detected
+        <div class="total">
+          <%= pluralize(files.count, 'file') %> inspected,
+          <%= pluralize(summary.offense_count, 'offense', no_for_zero: true) %> detected:
+        </div>
+        <ul class="offenses-list">
+          <% files.each do |file| %>
+            <% next if file.offenses.none? %>
+            <li>
+              <a href="#offense_<%= relative_path(file.path) %>">
+                <%= relative_path(file.path) %> - <%= pluralize(file.offenses.count, 'offense') %>
+              </a>
+            </li>
+          <% end %>
+        </ul>
       </div>
     </div>
     <div id="offenses">
       <% files.each do |file| %>
       <% if file.offenses.any? %>
-      <div class="offense-box">
+      <div class="offense-box" id="offense_<%= relative_path(file.path) %>">
         <div class="box-title-placeholder"><h3>&nbsp;</h3></div>
         <div class="box-title"><h3><%= relative_path(file.path) %> - <%= pluralize(file.offenses.count, 'offense') %></h3></div>
         <div class="offense-reports">

data/config/default.yml

@@ -395,6 +395,9 @@ Style/Copyright:
   Notice: '^Copyright (\(c\) )?2[0-9]{3} .+'
   AutocorrectNotice: ''
 
+Style/DocumentationMethod:
+  RequireForNonPublicMethods: false
+
 # Multi-line method chaining should be done with leading dots.
 Style/DotPosition:
   EnforcedStyle: leading
@@ -532,9 +535,14 @@ Style/GuardClause:
 Style/HashSyntax:
   EnforcedStyle: ruby19
   SupportedStyles:
+    # checks for 1.9 syntax (e.g. {a: 1}) for all symbol keys
     - ruby19
-    - ruby19_no_mixed_keys
+    # checks for hash rocket syntax for all hashes
     - hash_rockets
+    # forbids mixed key syntaxes (e.g. {a: 1, :b => 2})
+    - no_mixed_keys
+    # enforces both ruby19 and no_mixed_keys styles
+    - ruby19_no_mixed_keys
   # Force hashes that have a symbol value to use hash rockets
   UseHashRocketsWithSymbolValues: false
   # Do not suggest { a?: 1 } over { :a? => 1 } in ruby19 style
@@ -648,6 +656,10 @@ Style/NumericPredicate:
   SupportedStyles:
     - predicate
     - comparison
+  # Exclude RSpec specs because assertions like `expect(1).to be > 0` cause
+  # false positives.
+  Exclude:
+    - 'spec/**/*'
 
 Style/MethodDefParentheses:
   EnforcedStyle: require_parentheses
@@ -1041,6 +1053,13 @@ Style/VariableName:
     - snake_case
     - camelCase
 
+Style/VariableNumber:
+  EnforcedStyle: normalcase
+  SupportedStyles:
+    - snake_case
+    - normalcase
+    - non_integer
+
 Style/WhileUntilModifier:
   MaxLineLength: 80
 
@@ -1062,7 +1081,7 @@ Style/WordArray:
 ##################### Metrics ##################################
 
 Metrics/AbcSize:
-  # The ABC size is a calculated magnitude, so this number can be a Fixnum or
+  # The ABC size is a calculated magnitude, so this number can be an Integer or
   # a Float.
   Max: 15
 
@@ -1212,6 +1231,10 @@ Rails/HasAndBelongsToMany:
   Include:
     - app/models/**/*.rb
 
+Rails/NotNullColumn:
+  Include:
+    - db/migrate/*.rb
+
 Rails/Output:
   Include:
     - app/**/*.rb
@@ -1229,6 +1252,13 @@ Rails/RequestReferer:
     - referer
     - referrer
 
+Rails/SafeNavigation:
+  # This will convert usages of `try` to use safe navigation as well as `try!`.
+  # `try` and `try!` work slighly differently. `try!` and safe navigation will
+  # both raise a `NoMethodError` if the receiver of the method call does not
+  # implement the intended method. `try` will not raise an exception for this.
+  ConvertTry: false
+
 Rails/ScopeArgs:
   Include:
     - app/models/**/*.rb

data/config/disabled.yml

@@ -23,6 +23,13 @@ Style/Copyright:
   Description: 'Include a copyright notice in each file before any code.'
   Enabled: false
 
+Style/DocumentationMethod:
+  Description: 'Public methods.'
+  Enabled: false
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+
 Style/Encoding:
   Description: 'Use UTF-8 as the source file encoding.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#utf-8'
@@ -59,7 +66,7 @@ Style/ImplicitRuntimeError:
   Enabled: false
 
 Style/InlineComment:
-  Description: 'Avoid inline comments.'
+  Description: 'Avoid trailing inline comments.'
   Enabled: false
 
 Style/MethodCalledOnDoEndBlock:

data/config/enabled.yml

@@ -260,7 +260,7 @@ Style/EndOfLine:
   Enabled: true
 
 Style/EvenOdd:
-  Description: 'Favor the use of Fixnum#even? && Fixnum#odd?'
+  Description: 'Favor the use of Integer#even? && Integer#odd?'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#predicate-methods'
   Enabled: true
 
@@ -402,7 +402,7 @@ Style/LineEndConcatenation:
 
 Style/MethodCallParentheses:
   Description: 'Do not use parentheses for method calls with no arguments.'
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-args-no-parens'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#method-invocation-parens'
   Enabled: true
 
 Style/MethodDefParentheses:
@@ -556,6 +556,7 @@ Style/NumericPredicate:
   Description: >-
                  Checks for the use of predicate- or comparison methods for
                  numeric comparisons.
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#predicate-methods'
   Enabled: true
 
 Style/OneLineConditional:
@@ -663,6 +664,13 @@ Style/RescueModifier:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-rescue-modifiers'
   Enabled: true
 
+Style/SafeNavigation:
+  Description: >-
+                  This cop transforms usages of a method call safeguarded by
+                  a check for the existance of the object to
+                  safe navigation (`&.`).
+  Enabled: true
+
 Style/SelfAssignment:
   Description: >-
                  Checks for places where self-assignment shorthand should have
@@ -911,6 +919,10 @@ Style/VariableName:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#snake-case-symbols-methods-vars'
   Enabled: true
 
+Style/VariableNumber:
+  Description: 'Use the configured style when numbering variables.'
+  Enabled: true
+
 Style/WhenThen:
   Description: 'Use when x then ... for one-line cases.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#one-line-cases'
@@ -993,7 +1005,7 @@ Lint/AmbiguousOperator:
   Description: >-
                  Checks for ambiguous operators in the first argument of a
                  method invocation without parentheses.
-  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#parens-as-args'
+  StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#method-invocation-parens'
   Enabled: true
 
 Lint/AmbiguousRegexpLiteral:
@@ -1197,6 +1209,10 @@ Lint/UnderscorePrefixedVariableName:
   Description: 'Do not use prefix `_` for a variable that is used.'
   Enabled: true
 
+Lint/UnifiedInteger:
+  Description: 'Use Integer instead of Fixnum or Bignum'
+  Enabled: true
+
 Lint/UnneededDisable:
   Description: >-
                  Checks for rubocop:disable comments that can be removed.
@@ -1204,6 +1220,10 @@ Lint/UnneededDisable:
                  It must be explicitly disabled.
   Enabled: true
 
+Lint/UnneededSplatExpansion:
+  Description: 'Checks for splat unnecessarily being called on literals'
+  Enabled: true
+
 Lint/UnusedBlockArgument:
   Description: 'Checks for unused block arguments.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars'
@@ -1223,10 +1243,6 @@ Lint/UselessAccessModifier:
   Enabled: true
   ContextCreatingMethods: []
 
-Lint/UselessArraySplat:
-  Description: 'Checks for useless array splats.'
-  Enabled: true
-
 Lint/UselessAssignment:
   Description: 'Checks for useless assignment to a local variable.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#underscore-unused-vars'
@@ -1326,10 +1342,6 @@ Performance/LstripRstrip:
   Description: 'Use `strip` instead of `lstrip.rstrip`.'
   Enabled: true
 
-Performance/PushSplat:
-  Description: 'Use `concat` instead of `push(*)`.'
-  Enabled: true
-
 Performance/RangeInclude:
   Description: 'Use `Range#cover?` instead of `Range#include?`.'
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#cover-vs-include-code'
@@ -1363,7 +1375,7 @@ Performance/ReverseEach:
 Performance/Sample:
   Description: >-
                   Use `sample` instead of `shuffle.first`,
-                  `shuffle.last`, and `shuffle[Fixnum]`.
+                  `shuffle.last`, and `shuffle[Integer]`.
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#arrayshufflefirst-vs-arraysample-code'
   Enabled: true
 
@@ -1374,6 +1386,10 @@ Performance/Size:
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#arraycount-vs-arraysize-code'
   Enabled: true
 
+Performance/SortWithBlock:
+  Description: 'Use `sort_by(&:foo)` instead of `sort_by { |a, b| a.foo <=> b.foo }`.'
+  Enabled: true
+
 Performance/StartWith:
   Description: 'Use `start_with?` instead of a regex match anchored to the beginning of a string.'
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#stringmatch-vs-stringstart_withstringend_with-code-start-code-end'
@@ -1429,6 +1445,10 @@ Rails/HasAndBelongsToMany:
   StyleGuide: 'https://github.com/bbatsov/rails-style-guide#has-many-through'
   Enabled: true
 
+Rails/NotNullColumn:
+  Description: 'Do not add a NOT NULL column without a default value'
+  Enabled: true
+
 Rails/Output:
   Description: 'Checks for calls to puts, print, etc.'
   Enabled: true
@@ -1452,6 +1472,10 @@ Rails/RequestReferer:
   Description: 'Use consistent syntax for request.referer.'
   Enabled: true
 
+Rails/SafeNavigation:
+  Description: "Use Ruby's safe navigation operator (`&.`) instead of `try!`"
+  Enabled: true
+
 Rails/ScopeArgs:
   Description: 'Checks the arguments of ActiveRecord scopes.'
   Enabled: true
@@ -1469,3 +1493,7 @@ Rails/UniqBeforePluck:
 Rails/Validation:
   Description: 'Use validates :attribute, hash of validations.'
   Enabled: true
+
+Security/JSONLoad:
+  Description : 'Prefer usage of JSON.parse'
+  Enabled: true

data/lib/rubocop.rb

@@ -56,6 +56,9 @@ require 'rubocop/cop/mixin/code_length' # relies on configurable_max
 require 'rubocop/cop/mixin/classish_length' # relies on code_length
 require 'rubocop/cop/mixin/configurable_enforced_style'
 require 'rubocop/cop/mixin/configurable_naming'
+require 'rubocop/cop/mixin/configurable_numbering'
+require 'rubocop/cop/mixin/def_node'
+require 'rubocop/cop/mixin/documentation_comment'
 require 'rubocop/cop/mixin/empty_lines_around_body'
 require 'rubocop/cop/mixin/end_keyword_alignment'
 require 'rubocop/cop/mixin/first_element_line_break'
@@ -77,6 +80,7 @@ require 'rubocop/cop/mixin/parser_diagnostic'
 require 'rubocop/cop/mixin/percent_literal'
 require 'rubocop/cop/mixin/preceding_following_alignment'
 require 'rubocop/cop/mixin/safe_assignment'
+require 'rubocop/cop/mixin/safe_mode'
 require 'rubocop/cop/mixin/space_after_punctuation'
 require 'rubocop/cop/mixin/space_before_punctuation'
 require 'rubocop/cop/mixin/surrounding_space'
@@ -130,12 +134,13 @@ require 'rubocop/cop/lint/shadowing_outer_local_variable'
 require 'rubocop/cop/lint/string_conversion_in_interpolation'
 require 'rubocop/cop/lint/syntax'
 require 'rubocop/cop/lint/underscore_prefixed_variable_name'
+require 'rubocop/cop/lint/unified_integer'
 require 'rubocop/cop/lint/unneeded_disable'
+require 'rubocop/cop/lint/unneeded_splat_expansion'
 require 'rubocop/cop/lint/unreachable_code'
 require 'rubocop/cop/lint/unused_block_argument'
 require 'rubocop/cop/lint/unused_method_argument'
 require 'rubocop/cop/lint/useless_access_modifier'
-require 'rubocop/cop/lint/useless_array_splat'
 require 'rubocop/cop/lint/useless_assignment'
 require 'rubocop/cop/lint/useless_comparison'
 require 'rubocop/cop/lint/useless_else_without_rescue'
@@ -162,7 +167,6 @@ require 'rubocop/cop/performance/fixed_size'
 require 'rubocop/cop/performance/flat_map'
 require 'rubocop/cop/performance/hash_each'
 require 'rubocop/cop/performance/lstrip_rstrip'
-require 'rubocop/cop/performance/push_splat'
 require 'rubocop/cop/performance/range_include'
 require 'rubocop/cop/performance/redundant_block_call'
 require 'rubocop/cop/performance/redundant_match'
@@ -171,6 +175,7 @@ require 'rubocop/cop/performance/redundant_sort_by'
 require 'rubocop/cop/performance/reverse_each'
 require 'rubocop/cop/performance/sample'
 require 'rubocop/cop/performance/size'
+require 'rubocop/cop/performance/sort_with_block'
 require 'rubocop/cop/performance/start_with'
 require 'rubocop/cop/performance/string_replacement'
 require 'rubocop/cop/performance/times_map'
@@ -212,6 +217,7 @@ require 'rubocop/cop/style/constant_name'
 require 'rubocop/cop/style/copyright'
 require 'rubocop/cop/style/def_with_parentheses'
 require 'rubocop/cop/style/preferred_hash_methods'
+require 'rubocop/cop/style/documentation_method'
 require 'rubocop/cop/style/documentation'
 require 'rubocop/cop/style/dot_position'
 require 'rubocop/cop/style/double_negation'
@@ -316,6 +322,7 @@ require 'rubocop/cop/style/redundant_self'
 require 'rubocop/cop/style/regexp_literal'
 require 'rubocop/cop/style/rescue_ensure_alignment'
 require 'rubocop/cop/style/rescue_modifier'
+require 'rubocop/cop/style/safe_navigation'
 require 'rubocop/cop/style/self_assignment'
 require 'rubocop/cop/style/semicolon'
 require 'rubocop/cop/style/send'
@@ -367,6 +374,7 @@ require 'rubocop/cop/style/unneeded_interpolation'
 require 'rubocop/cop/style/unneeded_percent_q'
 require 'rubocop/cop/style/variable_interpolation'
 require 'rubocop/cop/style/variable_name'
+require 'rubocop/cop/style/variable_number'
 require 'rubocop/cop/style/when_then'
 require 'rubocop/cop/style/while_until_do'
 require 'rubocop/cop/style/while_until_modifier'
@@ -380,17 +388,21 @@ require 'rubocop/cop/rails/exit'
 require 'rubocop/cop/rails/find_by'
 require 'rubocop/cop/rails/find_each'
 require 'rubocop/cop/rails/has_and_belongs_to_many'
+require 'rubocop/cop/rails/not_null_column'
 require 'rubocop/cop/rails/output_safety'
 require 'rubocop/cop/rails/output'
 require 'rubocop/cop/rails/pluralization_grammar'
 require 'rubocop/cop/rails/read_write_attribute'
 require 'rubocop/cop/rails/request_referer'
+require 'rubocop/cop/rails/safe_navigation'
 require 'rubocop/cop/rails/save_bang'
 require 'rubocop/cop/rails/scope_args'
 require 'rubocop/cop/rails/time_zone'
 require 'rubocop/cop/rails/uniq_before_pluck'
 require 'rubocop/cop/rails/validation'
 
+require 'rubocop/cop/security/json_load'
+
 require 'rubocop/cop/team'
 
 require 'rubocop/formatter/base_formatter'

data/lib/rubocop/ast_node.rb

@@ -468,6 +468,7 @@ module RuboCop
     # So, does the return value of this node matter? If we changed it to
     # `(...; nil)`, might that affect anything?
     #
+    # rubocop:disable Metrics/MethodLength
     def value_used?
       # Be conservative and return true if we're not sure
       return false if parent.nil?
@@ -489,6 +490,7 @@ module RuboCop
         true
       end
     end
+    # rubocop:enable Metrics/MethodLength
 
     # Some expressions are evaluated for their value, some for their side
     # effects, and some for both

data/lib/rubocop/cached_data.rb

@@ -11,7 +11,7 @@ module RuboCop
     end
 
     def from_json(text)
-      deserialize_offenses(JSON.load(text))
+      deserialize_offenses(JSON.parse(text))
     end
 
     def to_json(offenses)
@@ -21,15 +21,6 @@ module RuboCop
     private
 
     def serialize_offense(offense)
-      # JSON.dump will fail if the offense message contains text which is not
-      # valid UTF-8
-      message = offense.message
-      message = if message.respond_to?(:scrub)
-                  message.scrub
-                else
-                  message.chars.select(&:valid_encoding?).join
-                end
-
       {
         # Calling #to_s here ensures that the serialization works when using
         # other json serializers such as Oj. Some of these gems do not call
@@ -39,12 +30,23 @@ module RuboCop
           begin_pos: offense.location.begin_pos,
           end_pos: offense.location.end_pos
         },
-        message:  message,
+        message:  message(offense),
         cop_name: offense.cop_name,
         status:   offense.status
       }
     end
 
+    def message(offense)
+      # JSON.dump will fail if the offense message contains text which is not
+      # valid UTF-8
+      message = offense.message
+      if message.respond_to?(:scrub)
+        message.scrub
+      else
+        message.chars.select(&:valid_encoding?).join
+      end
+    end
+
     # Restore an offense object loaded from a JSON file.
     def deserialize_offenses(offenses)
       source_buffer = utf8_source_buffer