rubocop 0.36.0 → 0.37.0

data/lib/rubocop/cop/variable_force.rb

@@ -56,14 +56,6 @@ module RuboCop
 
       SEND_TYPE = :send
 
-      def self.wrap_with_top_level_scope_node(root_node)
-        if root_node.begin_type?
-          root_node
-        else
-          Node.new(:begin, [root_node])
-        end
-      end
-
       def variable_table
         @variable_table ||= VariableTable.new(self)
       end
@@ -73,10 +65,9 @@ module RuboCop
         root_node = processed_source.ast
         return unless root_node
 
-        # Wrap the root node with begin node if it's a standalone node.
-        root_node = self.class.wrap_with_top_level_scope_node(root_node)
-
-        inspect_variables_in_scope(root_node)
+        variable_table.push_scope(root_node)
+        process_node(root_node)
+        variable_table.pop_scope
       end
 
       # This is called for each scope recursively.

data/lib/rubocop/cop/variable_force/assignment.rb

@@ -16,9 +16,9 @@ module RuboCop
 
         def initialize(node, variable)
           unless VARIABLE_ASSIGNMENT_TYPES.include?(node.type)
-            fail ArgumentError,
-                 "Node type must be any of #{VARIABLE_ASSIGNMENT_TYPES}, " \
-                 "passed #{node.type}"
+            raise ArgumentError,
+                  "Node type must be any of #{VARIABLE_ASSIGNMENT_TYPES}, " \
+                  "passed #{node.type}"
           end
 
           @node = node

data/lib/rubocop/cop/variable_force/locatable.rb

@@ -16,12 +16,18 @@ module RuboCop
         ENSURE_TYPE = :ensure
         ENSURE_INDEX_OF_ENSURE_NODE = 1
 
+        FOR_LOOP_TYPE = :for
+        FOR_LOOP_CHILD_INDEX = 2
+
+        NON_FOR_LOOP_TYPES = LOOP_TYPES - [FOR_LOOP_TYPE]
+        NON_FOR_LOOP_TYPES_CHILD_INDEX = 1
+
         def node
-          fail '#node must be declared!'
+          raise '#node must be declared!'
         end
 
         def scope
-          fail '#scope must be declared!'
+          raise '#scope must be declared!'
         end
 
         def inside_of_branch?
@@ -84,7 +90,8 @@ module RuboCop
           when RESCUE_TYPE             then rescue_body_name
           when ENSURE_TYPE             then ensure_body_name
           when *LOGICAL_OPERATOR_TYPES then logical_operator_body_name
-          else fail InvalidBranchBodyError
+          when *LOOP_TYPES             then loop_body_name
+          else raise InvalidBranchBodyError
           end
         rescue InvalidBranchBodyError
           raise InvalidBranchBodyError,
@@ -97,7 +104,7 @@ module RuboCop
           case body_index
           when 1 then 'true'
           when 2 then 'false'
-          else fail InvalidBranchBodyError
+          else raise InvalidBranchBodyError
           end
         end
 
@@ -112,7 +119,7 @@ module RuboCop
         def logical_operator_body_name
           case body_index
           when 1 then 'right'
-          else fail InvalidBranchBodyError
+          else raise InvalidBranchBodyError
           end
         end
 
@@ -129,10 +136,18 @@ module RuboCop
         def ensure_body_name
           case body_index
           when 0 then 'main'
-          else fail InvalidBranchBodyError
+          else raise InvalidBranchBodyError
           end
         end
 
+        def loop_body_name
+          loop_indices = [FOR_LOOP_CHILD_INDEX, NON_FOR_LOOP_TYPES_CHILD_INDEX]
+
+          raise InvalidBranchBodyError unless loop_indices.include?(body_index)
+
+          'main'
+        end
+
         def body_index
           branch_point_node.children.index { |n| n.equal?(branch_body_node) }
         end
@@ -162,10 +177,14 @@ module RuboCop
             true
           when ENSURE_TYPE
             child_index != ENSURE_INDEX_OF_ENSURE_NODE
+          when FOR_LOOP_TYPE
+            child_index == FOR_LOOP_CHILD_INDEX
           when *BRANCH_TYPES
             child_index != CONDITION_INDEX_OF_BRANCH_NODE
           when *LOGICAL_OPERATOR_TYPES
             child_index != LEFT_SIDE_INDEX_OF_LOGICAL_OPERATOR_NODE
+          when *NON_FOR_LOOP_TYPES
+            child_index == NON_FOR_LOOP_TYPES_CHILD_INDEX
           else
             false
           end

data/lib/rubocop/cop/variable_force/reference.rb

@@ -18,9 +18,9 @@ module RuboCop
 
         def initialize(node, scope)
           unless VARIABLE_REFERENCE_TYPES.include?(node.type)
-            fail ArgumentError,
-                 "Node type must be any of #{VARIABLE_REFERENCE_TYPES}, " \
-                 "passed #{node.type}"
+            raise ArgumentError,
+                  "Node type must be any of #{VARIABLE_REFERENCE_TYPES}, " \
+                  "passed #{node.type}"
           end
 
           @node = node

data/lib/rubocop/cop/variable_force/scope.rb

@@ -19,11 +19,11 @@ module RuboCop
         attr_reader :node, :variables
 
         def initialize(node)
-          # Accept begin node for top level scope.
-          unless SCOPE_TYPES.include?(node.type) || node.type == :begin
-            fail ArgumentError,
-                 "Node type must be any of #{SCOPE_TYPES}, " \
-                 "passed #{node.type}"
+          # Accept any node type for top level scope
+          unless SCOPE_TYPES.include?(node.type) || !node.parent
+            raise ArgumentError,
+                  "Node type must be any of #{SCOPE_TYPES}, " \
+                  "passed #{node.type}"
           end
           @node = node
           @variables = {}
@@ -43,13 +43,12 @@ module RuboCop
 
         def body_node
           child_index = case @node.type
-                        when :begin               then 0
                         when :module, :sclass     then 1
                         when :def, :class, :block then 2
                         when :defs                then 3
                         end
 
-          @node.children[child_index]
+          child_index ? @node.children[child_index] : @node
         end
 
         def each_node(&block)
@@ -60,6 +59,8 @@ module RuboCop
         private
 
         def scan_node(node, &block)
+          yield node unless node.parent
+
           node.each_child_node do |child_node|
             next if belong_to_another_scope?(child_node)
             yield child_node

data/lib/rubocop/cop/variable_force/variable.rb

@@ -17,9 +17,9 @@ module RuboCop
 
         def initialize(name, declaration_node, scope)
           unless VARIABLE_DECLARATION_TYPES.include?(declaration_node.type)
-            fail ArgumentError,
-                 "Node type must be any of #{VARIABLE_DECLARATION_TYPES}, " \
-                 "passed #{declaration_node.type}"
+            raise ArgumentError,
+                  "Node type must be any of #{VARIABLE_DECLARATION_TYPES}, " \
+                  "passed #{declaration_node.type}"
           end
 
           @name = name.to_sym

data/lib/rubocop/cop/variable_force/variable_table.rb

@@ -58,7 +58,7 @@ module RuboCop
           variable = find_variable(name)
 
           unless variable
-            fail "Assigning to undeclared local variable \"#{name}\" " \
+            raise "Assigning to undeclared local variable \"#{name}\" " \
                  "at #{node.source_range}, #{node.inspect}"
           end
 

data/lib/rubocop/formatter/formatter_set.rb

@@ -81,9 +81,9 @@ module RuboCop
         end
 
         if matching_keys.empty?
-          fail %(No formatter for "#{specified_key}")
+          raise %(No formatter for "#{specified_key}")
         elsif matching_keys.size > 1
-          fail %(Cannot determine formatter for "#{specified_key}")
+          raise %(Cannot determine formatter for "#{specified_key}")
         end
 
         BUILTIN_FORMATTERS_FOR_KEYS[matching_keys.first]

data/lib/rubocop/node_pattern.rb

@@ -407,7 +407,7 @@ module RuboCop
       end
 
       def fail_due_to(message)
-        fail Invalid, "Couldn't compile due to #{message}. Pattern: #{@string}"
+        raise Invalid, "Couldn't compile due to #{message}. Pattern: #{@string}"
       end
     end
 

data/lib/rubocop/options.rb

@@ -23,7 +23,7 @@ module RuboCop
       @validator.validate_compatibility
 
       if @options[:stdin] && !args.one?
-        fail ArgumentError, '-s/--stdin requires exactly one path.'
+        raise ArgumentError, '-s/--stdin requires exactly one path.'
       end
 
       [@options, args]
@@ -170,7 +170,7 @@ module RuboCop
         next if namespaces.include?(name)
         next if %w(Syntax Lint/Syntax).include?(name)
 
-        fail ArgumentError, "Unrecognized cop or namespace: #{name}."
+        raise ArgumentError, "Unrecognized cop or namespace: #{name}."
       end
     end
 
@@ -181,36 +181,36 @@ module RuboCop
     def validate_compatibility
       if @options.key?(:only) &&
          (@options[:only] & %w(Lint/UnneededDisable UnneededDisable)).any?
-        fail ArgumentError, 'Lint/UnneededDisable can not be used with --only.'
+        raise ArgumentError, 'Lint/UnneededDisable can not be used with --only.'
       end
       if @options.key?(:except) &&
          (@options[:except] & %w(Lint/Syntax Syntax)).any?
-        fail ArgumentError, 'Syntax checking can not be turned off.'
+        raise ArgumentError, 'Syntax checking can not be turned off.'
       end
       if @options.key?(:cache) && !%w(true false).include?(@options[:cache])
-        fail ArgumentError, '-C/--cache argument must be true or false'
+        raise ArgumentError, '-C/--cache argument must be true or false'
       end
       if @options.key?(:no_offense_counts) && !@options.key?(:auto_gen_config)
-        fail ArgumentError, '--no-offense-counts can only be used together ' \
+        raise ArgumentError, '--no-offense-counts can only be used together ' \
                             'with --auto-gen-config.'
       end
       return if (incompat = @options.keys & Options::EXITING_OPTIONS).size <= 1
-      fail ArgumentError, "Incompatible cli options: #{incompat.inspect}"
+      raise ArgumentError, "Incompatible cli options: #{incompat.inspect}"
     end
 
     def validate_exclude_limit_option(args)
       if @options[:exclude_limit] !~ /^\d+$/
         # Emulate OptionParser's behavior to make failures consistent regardless
         # of option order.
-        fail OptionParser::MissingArgument
+        raise OptionParser::MissingArgument
       end
 
       # --exclude-limit is valid if there's a parsed or yet unparsed
       # --auto-gen-config.
       return if @options[:auto_gen_config] || args.include?('--auto-gen-config')
 
-      fail ArgumentError,
-           '--exclude-limit can only be used with --auto-gen-config.'
+      raise ArgumentError,
+            '--exclude-limit can only be used with --auto-gen-config.'
     end
   end
 

data/lib/rubocop/path_util.rb

@@ -55,5 +55,10 @@ module RuboCop
     def hidden?(path_component)
       path_component =~ /^\.[^.]/
     end
+
+    # Returns true for an absolute Unix or Windows path.
+    def absolute?(path)
+      path =~ %r{\A([A-Z]:)?/}
+    end
   end
 end

data/lib/rubocop/processed_source.rb

@@ -44,11 +44,16 @@ module RuboCop
       comment_config.cop_disabled_line_ranges
     end
 
+    def ast_with_comments
+      return if !ast || !comments
+      @ast_with_comments ||= Parser::Source::Comment.associate(ast, comments)
+    end
+
     # Returns the source lines, line break characters removed, excluding a
     # possible __END__ and everything that comes after.
     def lines
       @lines ||= begin
-        all_lines = raw_source.lines.map(&:chomp)
+        all_lines = @buffer.source_lines
         last_token_line = tokens.any? ? tokens.last.pos.line : all_lines.size
         result = []
         all_lines.each_with_index do |line, ix|
@@ -90,6 +95,7 @@ module RuboCop
 
       begin
         @ast, @comments, tokens = parser.tokenize(@buffer)
+        @ast.complete! if @ast
       rescue Parser::SyntaxError # rubocop:disable Lint/HandleExceptions
         # All errors are in diagnostics. No need to handle exception.
       end
@@ -115,7 +121,7 @@ module RuboCop
         require 'parser/ruby23'
         Parser::Ruby23
       else
-        fail ArgumentError, "Unknown Ruby version: #{ruby_version.inspect}"
+        raise ArgumentError, "Unknown Ruby version: #{ruby_version.inspect}"
       end
     end
 

data/lib/rubocop/result_cache.rb

@@ -56,7 +56,7 @@ module RuboCop
 
     def initialize(file, options, config_store, cache_root = nil)
       cache_root ||= ResultCache.cache_root(config_store)
-      @path = File.join(cache_root, rubocop_checksum, RUBY_VERSION,
+      @path = File.join(cache_root, rubocop_checksum,
                         relevant_options(options),
                         file_checksum(file, config_store))
       @cached_data = CachedData.new(file)

data/lib/rubocop/runner.rb

@@ -181,7 +181,7 @@ module RuboCop
       checksum = processed_source.checksum
 
       if @processed_sources.include?(checksum)
-        fail InfiniteCorrectionLoop.new(processed_source.path, offenses)
+        raise InfiniteCorrectionLoop.new(processed_source.path, offenses)
       end
 
       @processed_sources << checksum

data/lib/rubocop/token.rb

@@ -7,8 +7,8 @@ module RuboCop
     attr_reader :pos, :type, :text
 
     def self.from_parser_token(parser_token)
-      type, details = *parser_token
-      text, range = *details
+      type, details = parser_token
+      text, range = details
       new(range, type, text)
     end
 

data/lib/rubocop/version.rb

@@ -4,7 +4,7 @@
 module RuboCop
   # This module holds the RuboCop version information.
   module Version
-    STRING = '0.36.0'.freeze
+    STRING = '0.37.0'.freeze
 
     MSG = '%s (using Parser %s, running on %s %s %s)'.freeze
 

data/relnotes/v0.30.1.md

@@ -14,6 +14,7 @@ Enjoy all those bug-fixes!
 * [#1806](https://github.com/bbatsov/rubocop/issues/1806): Require a newer version of `parser` and use its corrected solution for comment association in `Style/Documentation`. ([@jonas054][])
 * [#1792](https://github.com/bbatsov/rubocop/issues/1792): Fix bugs in `Sample` that did not account for array selectors with a range and passing random to shuffle. ([@rrosenblum][])
 * [#1770](https://github.com/bbatsov/rubocop/pull/1770): Add more acceptable methods to `Rails/TimeZone` (`utc`, `localtime`, `to_i`, `iso8601` etc). ([@palkan][])
+* [#1767](https://github.com/bbatsov/rubocop/pull/1767): Do not register offenses on non-enumerable select/find_all by `Performance/Detect`. ([@palkan][])
 * [#1795](https://github.com/bbatsov/rubocop/pull/1795): Fix bug in `TrailingBlankLines` that caused a crash for files containing only newlines. ([@renuo][])
 
 [@bbatsov]: https://github.com/bbatsov

data/relnotes/v0.33.0.md

@@ -12,7 +12,7 @@
 * [#2060](https://github.com/bbatsov/rubocop/issues/2060): New cop `Style/RescueEnsureAlignment` checks for bad alignment of `rescue` and `ensure` keywords. ([@lumeet][])
 * New cop `Style/OptionalArguments` checks for optional arguments that do not appear at the end of an argument list. ([@rrosenblum][])
 * New cop `Lint/CircularArgumentReference` checks for "circular argument references" in keyword arguments, which Ruby 2.2 warns against. ([@maxjacobson][], [@sliuu][])
-* [#2030](https://github.com/bbatsov/rubocop/issues/2030): New cop `Lint/OptionHash` checks for option hashes and encourages changing them to keyword arguments (disabled by default). ([@maxjacobson][])
+* [#2030](https://github.com/bbatsov/rubocop/issues/2030): New cop `Style/OptionHash` checks for option hashes and encourages changing them to keyword arguments (disabled by default). ([@maxjacobson][])
 
 ### Changes
 

data/relnotes/v0.36.0.md

@@ -2,7 +2,7 @@ An epic release - the one which contains the most new features and
 bugfixes since the inception of the project!  A huge thanks to the
 amazing contributors who helped make it a reality!
 
-Notabley, this release adds support for Ruby 2.3 and introduces the
+Notably, this release adds support for Ruby 2.3 and introduces the
 important concept of a target Ruby version - meaning RuboCop will no
 longer try to parse the code with a parser matching the interpreter
 you're using, but a parser matching the target Ruby version you
@@ -17,6 +17,7 @@ Enjoy!
 * [#2598](https://github.com/bbatsov/rubocop/pull/2598): New cop `Lint/RandOne` checks for `rand(1)`, `Kernel.rand(1.0)` and similar calls. Such call are most likely a mistake because they always return `0`. ([@DNNX][])
 * [#2590](https://github.com/bbatsov/rubocop/pull/2590): New cop `Performance/DoubleStartEndWith` checks for two `start_with?` (or `end_with?`) calls joined by `||` with the same receiver, like `str.start_with?('x') || str.start_with?('y')` and suggests using one call instead: `str.start_with?('x', 'y')`. ([@DNNX][])
 * [#2583](https://github.com/bbatsov/rubocop/pull/2583): New cop `Performance/TimesMap` checks for `x.times.map{}` and suggests replacing them with `Array.new(x){}`. ([@DNNX][])
+* [#2581](https://github.com/bbatsov/rubocop/pull/2581): New cop `Lint/NextWithoutAccumulator` finds bare `next` in `reduce`/`inject` blocks which assigns `nil` to the accumulator. ([@mvidner][])
 * [#2529](https://github.com/bbatsov/rubocop/pull/2529): Add EnforcedStyle config parameter to IndentArray. ([@jawshooah][])
 * [#2479](https://github.com/bbatsov/rubocop/pull/2479): Add option `AllowHeredoc` to `Metrics/LineLength`. ([@fphilipe][])
 * [#2416](https://github.com/bbatsov/rubocop/pull/2416): New cop `Style/ConditionalAssignment` checks for assignment of the same variable in all branches of conditionals and replaces them with a single assignment to the return of the conditional. ([@rrosenblum][])

data/relnotes/v0.37.0.md

@@ -0,0 +1,200 @@
+### New features
+
+* [#2620](https://github.com/bbatsov/rubocop/pull/2620): New cop `Style/ZeroLengthPredicate` checks for `object.size == 0` and variants, and suggests replacing them with an appropriate `empty?` predicate. ([@drenmi][])
+* [#2657](https://github.com/bbatsov/rubocop/pull/2657): Floating headers in HTML output. ([@mattparlane][])
+* Add new `Style/SpaceAroundKeyword` cop. ([@lumeet][])
+* [#2745](https://github.com/bbatsov/rubocop/pull/2745): New cop `Style/MultilineHashBraceLayout` checks that the closing brace in a hash literal is symmetrical with respect to the opening brace and the hash elements. ([@panthomakos][])
+* [#2761](https://github.com/bbatsov/rubocop/pull/2761): New cop `Style/MultilineMethodDefinitionBraceLayout` checks that the closing brace in a method definition is symmetrical with respect to the opening brace and the method parameters. ([@panthomakos][])
+* [#2699](https://github.com/bbatsov/rubocop/pull/2699): `Performance/Casecmp` can register offenses when `str.downcase` or `str.upcase` are passed to an equality method. ([@rrosenblum][])
+* [#2766](https://github.com/bbatsov/rubocop/pull/2766): New cop `Style/MultilineMethodCallBraceLayout` checks that the closing brace in a method call is symmetrical with respect to the opening brace and the method arguments. ([@panthomakos][])
+
+### Bug fixes
+
+* [#2723](https://github.com/bbatsov/rubocop/issues/2723): Fix NoMethodError in Style/GuardClause. ([@drenmi][])
+* [#2674](https://github.com/bbatsov/rubocop/issues/2674): Also check for Hash#update alias in `Performance/RedundantMerge`. ([@drenmi][])
+* [#2630](https://github.com/bbatsov/rubocop/issues/2630): Take frozen string literals into account in `Style/MutableConstant`. ([@segiddins][])
+* [#2642](https://github.com/bbatsov/rubocop/issues/2642): Support assignment via `||=` in `Style/MutableConstant`. ([@segiddins][])
+* [#2646](https://github.com/bbatsov/rubocop/issues/2646): Fix auto-correcting assignment to a constant in `Style/ConditionalAssignment`. ([@segiddins][])
+* [#2614](https://github.com/bbatsov/rubocop/issues/2614): Check for zero return value from `casecmp` in `Performance/casecmp`. ([@segiddins][])
+* [#2647](https://github.com/bbatsov/rubocop/issues/2647): Allow `xstr` interpolations in `Lint/LiteralInInterpolation`. ([@segiddins][])
+* Report a violation when `freeze` is called on a frozen string literal in `Style/RedundantFreeze`. ([@segiddins][])
+* [#2641](https://github.com/bbatsov/rubocop/issues/2641): Fix crashing on empty methods with block args in `Perfomance/RedundantBlockCall`. ([@segiddins][])
+* `Lint/DuplicateMethods` doesn't crash when `class_eval` is used with an implicit receiver. ([@lumeet][])
+* [#2654](https://github.com/bbatsov/rubocop/issues/2654): Fix handling of unary operations in `Style/RedundantParentheses`. ([@lumeet][])
+* [#2661](https://github.com/bbatsov/rubocop/issues/2661): `Style/Next` doesn't crash when auto-correcting modifier `if/unless`. ([@lumeet][])
+* [#2665](https://github.com/bbatsov/rubocop/pull/2665): Make specs pass when running on Windows. ([@jonas054][])
+* [#2691](https://github.com/bbatsov/rubocop/pull/2691): Do not register an offense in `Performance/TimesMap` for calling `map` or `collect` on a variable named `times`. ([@rrosenblum][])
+* [#2689](https://github.com/bbatsov/rubocop/pull/2689): Change `Performance/RedundantBlockCall` to respect parentheses usage. ([@rrosenblum][])
+* [#2694](https://github.com/bbatsov/rubocop/issues/2694): Fix caching when using a different JSON gem such as Oj. ([@stormbreakerbg][])
+* [#2707](https://github.com/bbatsov/rubocop/pull/2707): Change `Lint/NestedMethodDefinition` to respect `Class.new` and `Module.new`. ([@owst][])
+* [#2701](https://github.com/bbatsov/rubocop/pull/2701): Do not consider assignments to the same variable as useless if later assignments are within a loop. ([@owst][])
+* [#2696](https://github.com/bbatsov/rubocop/issues/2696): `Style/NestedModifier` adds parentheses around a condition when needed. ([@lumeet][])
+* [#2666](https://github.com/bbatsov/rubocop/issues/2666): Fix bug when auto-correcting symbol literals in `Lint/LiteralInInterpolation`. ([@lumeet][])
+* [#2664](https://github.com/bbatsov/rubocop/issues/2664): `Performance/Casecmp` can auto-correct case comparison to variables and method calls without error. ([@rrosenblum][])
+* [#2729](https://github.com/bbatsov/rubocop/issues/2729): Fix handling of hash literal as the first argument in `Style/RedundantParentheses`. ([@lumeet][])
+* [#2703](https://github.com/bbatsov/rubocop/issues/2703): Handle byte order mark in `Style/IndentationWidth`, `Style/ElseAlignment`, `Lint/EndAlignment`, and `Lint/DefEndAlignment`. ([@jonas054][])
+* [#2710](https://github.com/bbatsov/rubocop/pull/2710): Fix handling of fullwidth characters in some cops. ([@seikichi][])
+* [#2690](https://github.com/bbatsov/rubocop/issues/2690): Fix alignment of operands that are part of an assignment in `Style/MultilineOperationIndentation`. ([@jonas054][])
+* [#2228](https://github.com/bbatsov/rubocop/issues/2228): Use the config of a related cop whether it's enabled or not. ([@madwort][])
+* [#2721](https://github.com/bbatsov/rubocop/issues/2721): Do not register an offense for constants wrapped in parentheses passed to `rescue` in `Style/RedundantParentheses`. ([@rrosenblum][])
+* [#2742](https://github.com/bbatsov/rubocop/issues/2742): Fix `Style/TrailingCommaInArguments` & `Style/TrailingCommaInLiteral` for inline single element arrays. ([@annih][])
+* [#2768](https://github.com/bbatsov/rubocop/issues/2768): Allow parentheses after keyword `not` in `Style/MethodCallParentheses`. ([@lumeet][])
+* [#2758](https://github.com/bbatsov/rubocop/issues/2758): Allow leading underscores in camel case variable names.([@mmcguinn][])
+
+### Changes
+
+* Remove `Style/SpaceAfterControlKeyword` and `Style/SpaceBeforeModifierKeyword` as the more generic `Style/SpaceAroundKeyword` handles the same cases. ([@lumeet][])
+* Handle comparisons with `!=` in `Performance/casecmp`. ([@segiddins][])
+* [#2684](https://github.com/bbatsov/rubocop/pull/2684): Do not base `Style/FrozenStringLiteralComment` on the version of Ruby that is running. ([@rrosenblum][])
+* [#2732](https://github.com/bbatsov/rubocop/issues/2732): Change the default style of `Style/SignalException` to `only_raise`. ([@bbatsov][])
+
+[@bbatsov]: https://github.com/bbatsov
+[@jonas054]: https://github.com/jonas054
+[@yujinakayama]: https://github.com/yujinakayama
+[@dblock]: https://github.com/dblock
+[@nevir]: https://github.com/nevir
+[@daviddavis]: https://github.com/daviddavis
+[@sds]: https://github.com/sds
+[@fancyremarker]: https://github.com/fancyremarker
+[@sinisterchipmunk]: https://github.com/sinisterchipmunk
+[@vonTronje]: https://github.com/vonTronje
+[@agrimm]: https://github.com/agrimm
+[@pmenglund]: https://github.com/pmenglund
+[@chulkilee]: https://github.com/chulkilee
+[@codez]: https://github.com/codez
+[@emou]: https://github.com/emou
+[@skanev]: http://github.com/skanev
+[@claco]: http://github.com/claco
+[@rifraf]: http://github.com/rifraf
+[@scottmatthewman]: https://github.com/scottmatthewman
+[@ma2gedev]: http://github.com/ma2gedev
+[@jeremyolliver]: https://github.com/jeremyolliver
+[@hannestyden]: https://github.com/hannestyden
+[@geniou]: https://github.com/geniou
+[@jkogara]: https://github.com/jkogara
+[@tmorris-fiksu]: https://github.com/tmorris-fiksu
+[@mockdeep]: https://github.com/mockdeep
+[@hiroponz]: https://github.com/hiroponz
+[@tamird]: https://github.com/tamird
+[@fshowalter]: https://github.com/fshowalter
+[@cschramm]: https://github.com/cschramm
+[@bquorning]: https://github.com/bquorning
+[@bcobb]: https://github.com/bcobb
+[@irrationalfab]: https://github.com/irrationalfab
+[@tommeier]: https://github.com/tommeier
+[@sfeldon]: https://github.com/sfeldon
+[@biinari]: https://github.com/biinari
+[@barunio]: https://github.com/barunio
+[@molawson]: https://github.com/molawson
+[@wndhydrnt]: https://github.com/wndhydrnt
+[@ggilder]: https://github.com/ggilder
+[@salbertson]: https://github.com/salbertson
+[@camilleldn]: https://github.com/camilleldn
+[@mcls]: https://github.com/mcls
+[@yous]: https://github.com/yous
+[@vrthra]: https://github.com/vrthra
+[@SkuliOskarsson]: https://github.com/SkuliOskarsson
+[@jspanjers]: https://github.com/jspanjers
+[@sch1zo]: https://github.com/sch1zo
+[@smangelsdorf]: https://github.com/smangelsdorf
+[@mvz]: https://github.com/mvz
+[@jfelchner]: https://github.com/jfelchner
+[@janraasch]: https://github.com/janraasch
+[@jcarbo]: https://github.com/jcarbo
+[@oneamtu]: https://github.com/oneamtu
+[@toy]: https://github.com/toy
+[@Koronen]: https://github.com/Koronen
+[@blainesch]: https://github.com/blainesch
+[@marxarelli]: https://github.com/marxarelli
+[@katieschilling]: https://github.com/katieschilling
+[@kakutani]: https://github.com/kakutani
+[@rrosenblum]: https://github.com/rrosenblum
+[@mattjmcnaughton]: https://github.com/mattjmcnaughton
+[@huerlisi]: https://github.com/huerlisi
+[@volkert]: https://github.com/volkert
+[@lumeet]: https://github.com/lumeet
+[@mmozuras]: https://github.com/mmozuras
+[@d4rk5eed]: https://github.com/d4rk5eed
+[@cshaffer]: https://github.com/cshaffer
+[@eitoball]: https://github.com/eitoball
+[@iainbeeston]: https://github.com/iainbeeston
+[@pimterry]: https://github.com/pimterry
+[@palkan]: https://github.com/palkan
+[@jdoconnor]: https://github.com/jdoconnor
+[@meganemura]: https://github.com/meganemura
+[@zvkemp]: https://github.com/zvkemp
+[@vassilevsky]: https://github.com/vassilevsky
+[@gerry3]: https://github.com/gerry3
+[@ypresto]: https://github.com/ypresto
+[@clowder]: https://github.com/clowder
+[@mudge]: https://github.com/mudge
+[@mzp]: https://github.com/mzp
+[@bankair]: https://github.com/bankair
+[@crimsonknave]: https://github.com/crimsonknave
+[@renuo]: https://github.com/renuo
+[@sdeframond]: https://github.com/sdeframond
+[@til]: https://github.com/til
+[@carhartl]: https://github.com/carhartl
+[@dylandavidson]: https://github.com/dylandavidson
+[@tmr08c]: https://github.com/tmr08c
+[@hbd225]: https://github.com/hbd225
+[@l8nite]: https://github.com/l8nite
+[@sumeet]: https://github.com/sumeet
+[@ojab]: https://github.com/ojab
+[@chastell]: https://github.com/chastell
+[@glasnt]: https://github.com/glasnt
+[@crazydog115]: https://github.com/crazydog115
+[@RGBD]: https://github.com/RGBD
+[@panthomakos]: https://github.com/panthomakos
+[@matugm]: https://github.com/matugm
+[@m1foley]: https://github.com/m1foley
+[@tejasbubane]: https://github.com/tejasbubane
+[@bmorrall]: https://github.com/bmorrall
+[@fphilipe]: https://github.com/fphilipe
+[@gotrevor]: https://github.com/gotrevor
+[@awwaiid]: https://github.com/awwaiid
+[@segiddins]: https://github.com/segiddins
+[@urbanautomaton]: https://github.com/urbanautomaton.com
+[@unmanbearpig]: https://github.com/unmanbearpig
+[@maxjacobson]: https://github.com/maxjacobson
+[@sliuu]: https://github.com/sliuu
+[@edmz]: https://github.com/edmz
+[@syndbg]: https://github.com/syndbg
+[@wli]: https://github.com/wli
+[@caseywebdev]: https://github.com/caseywebdev
+[@MGerrior]: https://github.com/MGerrior
+[@imtayadeway]: https://github.com/imtayadeway
+[@mrfoto]: https://github.com/mrfoto
+[@karreiro]: https://github.com/karreiro
+[@dreyks]: https://github.com/dreyks
+[@hmadison]: https://github.com/hmadison
+[@miquella]: https://github.com/miquella
+[@jhansche]: https://github.com/jhansche
+[@cornelius]: https://github.com/cornelius
+[@eagletmt]: https://github.com/eagletmt
+[@apiology]: https://github.com/apiology
+[@alexdowad]: https://github.com/alexdowad
+[@minustehbare]: https://github.com/minustehbare
+[@tansaku]: https://github.com/tansaku
+[@ptrippett]: https://github.com/ptrippett
+[@br3nda]: https://github.com/br3nda
+[@jujugrrr]: https://github.com/jujugrrr
+[@sometimesfood]: https://github.com/sometimesfood
+[@cgriego]: https://github.com/cgriego
+[@savef]: https://github.com/savef
+[@volmer]: https://github.com/volmer
+[@domcleal]: https://github.com/domcleal
+[@codebeige]: https://github.com/codebeige
+[@weh]: https://github.com/weh
+[@bfontaine]: https://github.com/bfontaine
+[@jawshooah]: https://github.com/jawshooah
+[@DNNX]: https://github.com/DNNX
+[@mvidner]: https://github.com/mvidner
+[@mattparlane]: https://github.com/mattparlane
+[@drenmi]: https://github.com/drenmi
+[@stormbreakerbg]: https://github.com/stormbreakerbg
+[@owst]: https://github.com/owst
+[@seikichi]: https://github.com/seikichi
+[@madwort]: https://github.com/madwort
+[@annih]: https://github.com/annih
+[@mmcguinn]: https://github.com/mmcguinn