rubocop 0.36.0 → 0.37.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3ee7bc690a050b4fd220151fde459956af4e0ff4
-  data.tar.gz: cf8df365f2d78d2fd26508e7881b1128e307722e
+  metadata.gz: 4bdbb9f710745091d21b8fb1bc741a5964d7ad0f
+  data.tar.gz: 0c1bdb92f40935b9d9209c78e006a444e85ad5c1
 SHA512:
-  metadata.gz: e52b89d539e9e478473c0d7c57b472d93aca3378386940551d21be32171bf46cbb68fe26b4d6afbf09a0c38bbab5c1fef28b87ba8f63bc624ce80bd2527ca808
-  data.tar.gz: 70ee4133446158992efb7c971289e53b4d1ce894c845d3dc4c5f569d5726e67191cebe4be2b38e82927dd7849fdd8268e54c53b9db27248fbcd466409a3df4f2
+  metadata.gz: 2f58d0c665369ccdcff54b88b35bd032327b0460ccb6a7b05101cbf853f6895f491636c11e59824b14cd54c87f599187ec41790902f7ff8bfd2f7a3a5febd9ba
+  data.tar.gz: 59de02eb56cc687d3dd664ee540d7338a8968b8ffe758a72596455d2cf2c48c8103b3fe54970d19b947abef418407a2af579d0f5e4d9fd06dc0b626a18af58d9

data/CHANGELOG.md

@@ -2,6 +2,58 @@
 
 ## master (unreleased)
 
+## 0.37.0 (04/02/2016)
+
+### New features
+
+* [#2620](https://github.com/bbatsov/rubocop/pull/2620): New cop `Style/ZeroLengthPredicate` checks for `object.size == 0` and variants, and suggests replacing them with an appropriate `empty?` predicate. ([@drenmi][])
+* [#2657](https://github.com/bbatsov/rubocop/pull/2657): Floating headers in HTML output. ([@mattparlane][])
+* Add new `Style/SpaceAroundKeyword` cop. ([@lumeet][])
+* [#2745](https://github.com/bbatsov/rubocop/pull/2745): New cop `Style/MultilineHashBraceLayout` checks that the closing brace in a hash literal is symmetrical with respect to the opening brace and the hash elements. ([@panthomakos][])
+* [#2761](https://github.com/bbatsov/rubocop/pull/2761): New cop `Style/MultilineMethodDefinitionBraceLayout` checks that the closing brace in a method definition is symmetrical with respect to the opening brace and the method parameters. ([@panthomakos][])
+* [#2699](https://github.com/bbatsov/rubocop/pull/2699): `Performance/Casecmp` can register offenses when `str.downcase` or `str.upcase` are passed to an equality method. ([@rrosenblum][])
+* [#2766](https://github.com/bbatsov/rubocop/pull/2766): New cop `Style/MultilineMethodCallBraceLayout` checks that the closing brace in a method call is symmetrical with respect to the opening brace and the method arguments. ([@panthomakos][])
+
+### Bug fixes
+
+* [#2723](https://github.com/bbatsov/rubocop/issues/2723): Fix NoMethodError in Style/GuardClause. ([@drenmi][])
+* [#2674](https://github.com/bbatsov/rubocop/issues/2674): Also check for Hash#update alias in `Performance/RedundantMerge`. ([@drenmi][])
+* [#2630](https://github.com/bbatsov/rubocop/issues/2630): Take frozen string literals into account in `Style/MutableConstant`. ([@segiddins][])
+* [#2642](https://github.com/bbatsov/rubocop/issues/2642): Support assignment via `||=` in `Style/MutableConstant`. ([@segiddins][])
+* [#2646](https://github.com/bbatsov/rubocop/issues/2646): Fix auto-correcting assignment to a constant in `Style/ConditionalAssignment`. ([@segiddins][])
+* [#2614](https://github.com/bbatsov/rubocop/issues/2614): Check for zero return value from `casecmp` in `Performance/casecmp`. ([@segiddins][])
+* [#2647](https://github.com/bbatsov/rubocop/issues/2647): Allow `xstr` interpolations in `Lint/LiteralInInterpolation`. ([@segiddins][])
+* Report a violation when `freeze` is called on a frozen string literal in `Style/RedundantFreeze`. ([@segiddins][])
+* [#2641](https://github.com/bbatsov/rubocop/issues/2641): Fix crashing on empty methods with block args in `Perfomance/RedundantBlockCall`. ([@segiddins][])
+* `Lint/DuplicateMethods` doesn't crash when `class_eval` is used with an implicit receiver. ([@lumeet][])
+* [#2654](https://github.com/bbatsov/rubocop/issues/2654): Fix handling of unary operations in `Style/RedundantParentheses`. ([@lumeet][])
+* [#2661](https://github.com/bbatsov/rubocop/issues/2661): `Style/Next` doesn't crash when auto-correcting modifier `if/unless`. ([@lumeet][])
+* [#2665](https://github.com/bbatsov/rubocop/pull/2665): Make specs pass when running on Windows. ([@jonas054][])
+* [#2691](https://github.com/bbatsov/rubocop/pull/2691): Do not register an offense in `Performance/TimesMap` for calling `map` or `collect` on a variable named `times`. ([@rrosenblum][])
+* [#2689](https://github.com/bbatsov/rubocop/pull/2689): Change `Performance/RedundantBlockCall` to respect parentheses usage. ([@rrosenblum][])
+* [#2694](https://github.com/bbatsov/rubocop/issues/2694): Fix caching when using a different JSON gem such as Oj. ([@stormbreakerbg][])
+* [#2707](https://github.com/bbatsov/rubocop/pull/2707): Change `Lint/NestedMethodDefinition` to respect `Class.new` and `Module.new`. ([@owst][])
+* [#2701](https://github.com/bbatsov/rubocop/pull/2701): Do not consider assignments to the same variable as useless if later assignments are within a loop. ([@owst][])
+* [#2696](https://github.com/bbatsov/rubocop/issues/2696): `Style/NestedModifier` adds parentheses around a condition when needed. ([@lumeet][])
+* [#2666](https://github.com/bbatsov/rubocop/issues/2666): Fix bug when auto-correcting symbol literals in `Lint/LiteralInInterpolation`. ([@lumeet][])
+* [#2664](https://github.com/bbatsov/rubocop/issues/2664): `Performance/Casecmp` can auto-correct case comparison to variables and method calls without error. ([@rrosenblum][])
+* [#2729](https://github.com/bbatsov/rubocop/issues/2729): Fix handling of hash literal as the first argument in `Style/RedundantParentheses`. ([@lumeet][])
+* [#2703](https://github.com/bbatsov/rubocop/issues/2703): Handle byte order mark in `Style/IndentationWidth`, `Style/ElseAlignment`, `Lint/EndAlignment`, and `Lint/DefEndAlignment`. ([@jonas054][])
+* [#2710](https://github.com/bbatsov/rubocop/pull/2710): Fix handling of fullwidth characters in some cops. ([@seikichi][])
+* [#2690](https://github.com/bbatsov/rubocop/issues/2690): Fix alignment of operands that are part of an assignment in `Style/MultilineOperationIndentation`. ([@jonas054][])
+* [#2228](https://github.com/bbatsov/rubocop/issues/2228): Use the config of a related cop whether it's enabled or not. ([@madwort][])
+* [#2721](https://github.com/bbatsov/rubocop/issues/2721): Do not register an offense for constants wrapped in parentheses passed to `rescue` in `Style/RedundantParentheses`. ([@rrosenblum][])
+* [#2742](https://github.com/bbatsov/rubocop/issues/2742): Fix `Style/TrailingCommaInArguments` & `Style/TrailingCommaInLiteral` for inline single element arrays. ([@annih][])
+* [#2768](https://github.com/bbatsov/rubocop/issues/2768): Allow parentheses after keyword `not` in `Style/MethodCallParentheses`. ([@lumeet][])
+* [#2758](https://github.com/bbatsov/rubocop/issues/2758): Allow leading underscores in camel case variable names.([@mmcguinn][])
+
+### Changes
+
+* Remove `Style/SpaceAfterControlKeyword` and `Style/SpaceBeforeModifierKeyword` as the more generic `Style/SpaceAroundKeyword` handles the same cases. ([@lumeet][])
+* Handle comparisons with `!=` in `Performance/casecmp`. ([@segiddins][])
+* [#2684](https://github.com/bbatsov/rubocop/pull/2684): Do not base `Style/FrozenStringLiteralComment` on the version of Ruby that is running. ([@rrosenblum][])
+* [#2732](https://github.com/bbatsov/rubocop/issues/2732): Change the default style of `Style/SignalException` to `only_raise`. ([@bbatsov][])
+
 ## 0.36.0 (14/01/2016)
 
 ### New features
@@ -9,6 +61,7 @@
 * [#2598](https://github.com/bbatsov/rubocop/pull/2598): New cop `Lint/RandOne` checks for `rand(1)`, `Kernel.rand(1.0)` and similar calls. Such call are most likely a mistake because they always return `0`. ([@DNNX][])
 * [#2590](https://github.com/bbatsov/rubocop/pull/2590): New cop `Performance/DoubleStartEndWith` checks for two `start_with?` (or `end_with?`) calls joined by `||` with the same receiver, like `str.start_with?('x') || str.start_with?('y')` and suggests using one call instead: `str.start_with?('x', 'y')`. ([@DNNX][])
 * [#2583](https://github.com/bbatsov/rubocop/pull/2583): New cop `Performance/TimesMap` checks for `x.times.map{}` and suggests replacing them with `Array.new(x){}`. ([@DNNX][])
+* [#2581](https://github.com/bbatsov/rubocop/pull/2581): New cop `Lint/NextWithoutAccumulator` finds bare `next` in `reduce`/`inject` blocks which assigns `nil` to the accumulator. ([@mvidner][])
 * [#2529](https://github.com/bbatsov/rubocop/pull/2529): Add EnforcedStyle config parameter to IndentArray. ([@jawshooah][])
 * [#2479](https://github.com/bbatsov/rubocop/pull/2479): Add option `AllowHeredoc` to `Metrics/LineLength`. ([@fphilipe][])
 * [#2416](https://github.com/bbatsov/rubocop/pull/2416): New cop `Style/ConditionalAssignment` checks for assignment of the same variable in all branches of conditionals and replaces them with a single assignment to the return of the conditional. ([@rrosenblum][])
@@ -193,7 +246,6 @@
 * `Style/Documentation` recognizes 'Constant = Class.new' as a class definition. ([@alexdowad][])
 * [#1608](https://github.com/bbatsov/rubocop/issues/1608): Add new 'align_braces' style for `Style/IndentHash`. ([@alexdowad][])
 * `Style/Next` can autocorrect. ([@alexdowad][])
-* [#2581](https://github.com/bbatsov/rubocop/pull/2581): New cop `Lint/NextWithoutAccumulator` finds bare `next` in `reduce`/`inject` blocks which assigns `nil` to the accumulator. ([@mvidner][])
 
 ### Bug Fixes
 
@@ -484,13 +536,13 @@
 * [#1806](https://github.com/bbatsov/rubocop/issues/1806): Require a newer version of `parser` and use its corrected solution for comment association in `Style/Documentation`. ([@jonas054][])
 * [#1792](https://github.com/bbatsov/rubocop/issues/1792): Fix bugs in `Sample` that did not account for array selectors with a range and passing random to shuffle. ([@rrosenblum][])
 * [#1770](https://github.com/bbatsov/rubocop/pull/1770): Add more acceptable methods to `Rails/TimeZone` (`utc`, `localtime`, `to_i`, `iso8601` etc). ([@palkan][])
+* [#1767](https://github.com/bbatsov/rubocop/pull/1767): Do not register offenses on non-enumerable select/find_all by `Performance/Detect`. ([@palkan][])
 * [#1795](https://github.com/bbatsov/rubocop/pull/1795): Fix bug in `TrailingBlankLines` that caused a crash for files containing only newlines. ([@renuo][])
 
 ## 0.30.0 (06/04/2015)
 
 ### New features
 
-* [#1767](https://github.com/bbatsov/rubocop/pull/1767): Do not register offenses on non-enumerable select/find_all by `Performance/Detect`. ([@palkan][])
 * [#1600](https://github.com/bbatsov/rubocop/issues/1600): Add `line_count_based` and `semantic` styles to the `BlockDelimiters` (formerly `Blocks`) cop. ([@clowder][], [@mudge][])
 * [#1712](https://github.com/bbatsov/rubocop/pull/1712): Set `Offense#corrected?` to `true`, `false`, or `nil` when it was, wasn't, or can't be auto-corrected, respectively. ([@vassilevsky][])
 * [#1669](https://github.com/bbatsov/rubocop/pull/1669): Add command-line switch `--display-style-guide`. ([@marxarelli][])
@@ -1879,3 +1931,11 @@
 [@jawshooah]: https://github.com/jawshooah
 [@DNNX]: https://github.com/DNNX
 [@mvidner]: https://github.com/mvidner
+[@mattparlane]: https://github.com/mattparlane
+[@drenmi]: https://github.com/drenmi
+[@stormbreakerbg]: https://github.com/stormbreakerbg
+[@owst]: https://github.com/owst
+[@seikichi]: https://github.com/seikichi
+[@madwort]: https://github.com/madwort
+[@annih]: https://github.com/annih
+[@mmcguinn]: https://github.com/mmcguinn

data/README.md

@@ -109,6 +109,15 @@ If you'd rather install RuboCop using `bundler`, don't require it in your `Gemfi
 gem 'rubocop', require: false
 ```
 
+RuboCop's development is moving at a very rapid pace and there are
+often backward-incompatible changes between minor releases (since we
+haven't reached version 1.0 yet). To prevent an unwanted RuboCop update you
+might want to use a conservative version locking in your `Gemfile`:
+
+```rb
+gem 'rubocop', '~> 0.36.0', require: false
+```
+
 ## Basic Usage
 
 Running `rubocop` with no arguments will check all Ruby source files
@@ -398,7 +407,7 @@ AllCops:
 Files and directories are specified relative to the `.rubocop.yml` file.
 
 **Note**: Patterns that are just a file name, e.g. `Rakefile`, will match
-that file name in any directory, but this pattern style deprecated. The
+that file name in any directory, but this pattern style is deprecated. The
 correct way to match the file in any directory, including the current, is
 `**/Rakefile`.
 

data/assets/output.html.erb

@@ -86,7 +86,19 @@
     -webkit-box-shadow: 0 1px 1px rgba(0, 0, 0, 0.05);
     box-shadow: 0 1px 1px rgba(0, 0, 0, 0.05);
     }
-    #offenses .offense-box .box-title h3 {
+    .fixed .box-title {
+    position: fixed;
+    top: 0;
+    z-index: 10;
+    width: 100%;
+    }
+    .box-title-placeholder {
+    display: none;
+    }
+    .fixed .box-title-placeholder {
+    display: block;
+    }
+    #offenses .offense-box .box-title h3, #offenses .offense-box .box-title-placeholder h3 {
     color: #33353f;
     background-color: #f6f6f6;
     font-size: 2rem;
@@ -150,6 +162,47 @@
     text-align: right;
     }
     </style>
+
+    <script>
+    (function() {
+      // floating headers. requires classList support.
+      if (!('classList' in document.createElement("_"))) return;
+
+      var loaded = false,
+        boxes,
+        boxPositions;
+
+      window.onload = function() {
+        var scrollY = window.scrollY;
+        boxes = document.querySelectorAll('.offense-box');
+        boxPositions = [];
+        for (var i = 0; i < boxes.length; i++)
+          // need to add scrollY because the page might be somewhere other than the top when loaded.
+          boxPositions[i] = boxes[i].getBoundingClientRect().top + scrollY;
+        loaded = true;
+      };
+
+      window.onscroll = function() {
+        if (!loaded) return;
+        var i,
+          idx,
+          scrollY = window.scrollY;
+        for (i = 0; i < boxPositions.length; i++) {
+          if (scrollY <= boxPositions[i]) {
+            idx = i;
+            break;
+          }
+        }
+        if (typeof idx == 'undefined') idx = boxes.length;
+        if (idx > 0)
+          boxes[idx - 1].classList.add('fixed');
+        for (i = 0; i < boxes.length; i++) {
+          if (i < idx) continue;
+          boxes[i].classList.remove('fixed');
+        }
+      };
+    })();
+    </script>
   </head>
   <body>
     <div id="header">
@@ -166,6 +219,7 @@
       <% files.each do |file| %>
       <% if file.offenses.any? %>
       <div class="offense-box">
+        <div class="box-title-placeholder"><h3>&nbsp;</h3></div>
         <div class="box-title"><h3><%= relative_path(file.path) %> - <%= pluralize(file.offenses.count, 'offense') %></h3></div>
         <div class="offense-reports">
           <% file.offenses.each do |offense| %>

data/config/default.yml

@@ -733,7 +733,7 @@ Style/Semicolon:
   AllowAsExpressionSeparator: false
 
 Style/SignalException:
-  EnforcedStyle: semantic
+  EnforcedStyle: only_raise
   SupportedStyles:
     - only_raise
     - only_fail
@@ -966,7 +966,7 @@ Metrics/CyclomaticComplexity:
 Metrics/LineLength:
   Max: 80
   # To make it possible to copy or click on URIs in the code, we allow lines
-  # contaning a URI to be longer than Max.
+  # containing a URI to be longer than Max.
   AllowHeredoc: true
   AllowURI: true
   URISchemes:
@@ -1026,6 +1026,12 @@ Lint/UnusedMethodArgument:
   AllowUnusedKeywordArguments: false
   IgnoreEmptyMethods: true
 
+##################### Performance ############################
+
+Performance/RedundantMerge:
+  # Max number of key-value pairs to consider an offense
+  MaxKeyValuePairs: 2
+
 ##################### Rails ##################################
 
 Rails/ActionFilter:
@@ -1040,7 +1046,7 @@ Rails/Date:
   # The value `strict` disallows usage of `Date.today`, `Date.current`,
   # `Date#to_time` etc.
   # The value `flexible` allows usage of `Date.current`, `Date.yesterday`, etc
-  # (but not `Date.today`) which are overriden by ActiveSupport to handle current
+  # (but not `Date.today`) which are overridden by ActiveSupport to handle current
   # time zone.
   EnforcedStyle: flexible
   SupportedStyles:

data/config/disabled.yml

@@ -85,6 +85,27 @@ Style/MultilineAssignmentLayout:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#indent-conditional-assignment'
   Enabled: false
 
+Style/MultilineHashBraceLayout:
+  Description: >-
+                 Checks that the closing brace in a hash literal is
+                 symmetrical with respect to the opening brace and the
+                 hash elements.
+  Enabled: false
+
+Style/MultilineMethodCallBraceLayout:
+  Description: >-
+                 Checks that the closing brace in a method call is
+                 symmetrical with respect to the opening brace and the
+                 method arguments.
+  Enabled: false
+
+Style/MultilineMethodDefinitionBraceLayout:
+  Description: >-
+                 Checks that the closing brace in a method definition is
+                 symmetrical with respect to the opening brace and the
+                 method parameters.
+  Enabled: false
+
 Style/OptionHash:
   Description: "Don't use option hashes when you can use keyword arguments."
   Enabled: false

data/config/enabled.yml

@@ -649,10 +649,6 @@ Style/SpaceAfterComma:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#spaces-operators'
   Enabled: true
 
-Style/SpaceAfterControlKeyword:
-  Description: 'Use spaces after if/elsif/unless/while/until/case/when.'
-  Enabled: true
-
 Style/SpaceAfterMethodName:
   Description: >-
                  Do not put a space between a method name and the opening
@@ -709,15 +705,15 @@ Style/SpaceAroundEqualsInParameterDefault:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#spaces-around-equals'
   Enabled: true
 
+Style/SpaceAroundKeyword:
+  Description: 'Use a space around keywords if appropriate.'
+  Enabled: true
+
 Style/SpaceAroundOperators:
   Description: 'Use a single space around operators.'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#spaces-operators'
   Enabled: true
 
-Style/SpaceBeforeModifierKeyword:
-  Description: 'Put a space before the modifier keyword.'
-  Enabled: true
-
 Style/SpaceInsideBrackets:
   Description: 'No spaces after [ or before ].'
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#no-spaces-braces'
@@ -868,6 +864,10 @@ Style/WordArray:
   StyleGuide: 'https://github.com/bbatsov/ruby-style-guide#percent-w'
   Enabled: true
 
+Style/ZeroLengthPredicate:
+  Description: 'Use #empty? when testing for objects of length 0.'
+  Enabled: true
+
 #################### Metrics ################################
 
 Metrics/AbcSize:
@@ -1157,7 +1157,8 @@ Lint/Void:
 ##################### Performance #############################
 
 Performance/Casecmp:
-  Description: 'Use `casecmp` rather than `downcase ==`.'
+  Description: >-
+             Use `casecmp` rather than `downcase ==`, `upcase ==`, `== downcase`, or `== upcase`..
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#stringcasecmp-vs-stringdowncase---code'
   Enabled: true
 
@@ -1238,7 +1239,7 @@ Performance/RedundantMatch:
   Enabled: true
 
 Performance/RedundantMerge:
-  Description: 'Use Hash#[]=, rather than Hash#merge! with a single key-value pair.'
+  Description: 'Use Hash#[]=, rather than Hash#merge! or Hash#update with a single key-value pair.'
   Reference: 'https://github.com/JuanitoFatas/fast-ruby#hashmerge-vs-hash-code'
   Enabled: true
 

data/lib/rubocop.rb

@@ -11,6 +11,7 @@ require 'powerpack/enumerable/drop_last'
 require 'powerpack/hash/symbolize_keys'
 require 'powerpack/string/blank'
 require 'powerpack/string/strip_indent'
+require 'unicode/display_width'
 
 require 'rubocop/version'
 
@@ -21,6 +22,7 @@ require 'rubocop/node_pattern'
 require 'rubocop/ast_node/sexp'
 require 'rubocop/ast_node'
 require 'rubocop/ast_node/builder'
+require 'rubocop/ast_node/traversal'
 require 'rubocop/error'
 require 'rubocop/warning'
 
@@ -58,6 +60,7 @@ require 'rubocop/cop/mixin/configurable_naming'
 require 'rubocop/cop/mixin/empty_lines_around_body'
 require 'rubocop/cop/mixin/end_keyword_alignment'
 require 'rubocop/cop/mixin/first_element_line_break'
+require 'rubocop/cop/mixin/frozen_string_literal'
 require 'rubocop/cop/mixin/hash_node'
 require 'rubocop/cop/mixin/if_node'
 require 'rubocop/cop/mixin/on_method_def'
@@ -65,6 +68,7 @@ require 'rubocop/cop/mixin/method_complexity' # relies on on_method_def
 require 'rubocop/cop/mixin/method_preference'
 require 'rubocop/cop/mixin/min_body_length'
 require 'rubocop/cop/mixin/multiline_expression_indentation'
+require 'rubocop/cop/mixin/multiline_literal_brace_layout'
 require 'rubocop/cop/mixin/negative_conditional'
 require 'rubocop/cop/mixin/on_normal_if_unless'
 require 'rubocop/cop/mixin/parentheses'
@@ -259,8 +263,11 @@ require 'rubocop/cop/style/multiline_array_brace_layout'
 require 'rubocop/cop/style/multiline_assignment_layout'
 require 'rubocop/cop/style/multiline_block_chain'
 require 'rubocop/cop/style/multiline_block_layout'
+require 'rubocop/cop/style/multiline_hash_brace_layout'
 require 'rubocop/cop/style/multiline_if_then'
+require 'rubocop/cop/style/multiline_method_call_brace_layout'
 require 'rubocop/cop/style/multiline_method_call_indentation'
+require 'rubocop/cop/style/multiline_method_definition_brace_layout'
 require 'rubocop/cop/style/multiline_operation_indentation'
 require 'rubocop/cop/style/multiline_ternary_operator'
 require 'rubocop/cop/style/mutable_constant'
@@ -303,18 +310,17 @@ require 'rubocop/cop/style/single_line_block_params'
 require 'rubocop/cop/style/single_line_methods'
 require 'rubocop/cop/style/space_after_colon'
 require 'rubocop/cop/style/space_after_comma'
-require 'rubocop/cop/style/space_after_control_keyword'
 require 'rubocop/cop/style/space_after_method_name'
 require 'rubocop/cop/style/space_after_not'
 require 'rubocop/cop/style/space_after_semicolon'
 require 'rubocop/cop/style/space_around_block_parameters'
 require 'rubocop/cop/style/space_around_equals_in_parameter_default'
+require 'rubocop/cop/style/space_around_keyword'
 require 'rubocop/cop/style/space_around_operators'
 require 'rubocop/cop/style/space_before_block_braces'
 require 'rubocop/cop/style/space_before_comma'
 require 'rubocop/cop/style/space_before_comment'
 require 'rubocop/cop/style/space_before_first_arg'
-require 'rubocop/cop/style/space_before_modifier_keyword'
 require 'rubocop/cop/style/space_before_semicolon'
 require 'rubocop/cop/style/space_inside_block_braces'
 require 'rubocop/cop/style/space_inside_brackets'
@@ -348,6 +354,7 @@ require 'rubocop/cop/style/when_then'
 require 'rubocop/cop/style/while_until_do'
 require 'rubocop/cop/style/while_until_modifier'
 require 'rubocop/cop/style/word_array'
+require 'rubocop/cop/style/zero_length_predicate'
 
 require 'rubocop/cop/rails/action_filter'
 require 'rubocop/cop/rails/date'

data/lib/rubocop/ast_node.rb

@@ -21,15 +21,16 @@ module RuboCop
   class Node < Parser::AST::Node # rubocop:disable Metrics/ClassLength
     include RuboCop::Sexp
 
-    COMPARISON_OPERATORS = [:==, :===, :!=, :<=, :>=, :>, :<, :<=>].freeze
+    COMPARISON_OPERATORS = [:!, :==, :===, :!=, :<=, :>=, :>, :<, :<=>].freeze
 
     TRUTHY_LITERALS = [:str, :dstr, :xstr, :int, :float, :sym, :dsym, :array,
                        :hash, :regexp, :true, :irange, :erange, :complex,
-                       :rational].freeze
+                       :rational, :regopt].freeze
     FALSEY_LITERALS = [:false, :nil].freeze
     LITERALS = (TRUTHY_LITERALS + FALSEY_LITERALS).freeze
-    BASIC_LITERALS = LITERALS - [:dstr, :xstr, :dsym, :array, :hash, :irange,
-                                 :erange].freeze
+    COMPOSITE_LITERALS = [:dstr, :xstr, :dsym, :array, :hash, :irange,
+                          :erange, :regexp].freeze
+    BASIC_LITERALS = (LITERALS - COMPOSITE_LITERALS).freeze
     MUTABLE_LITERALS = [:str, :dstr, :xstr, :array, :hash].freeze
     IMMUTABLE_LITERALS = (LITERALS - MUTABLE_LITERALS).freeze
 
@@ -42,6 +43,8 @@ module RuboCop
     OPERATOR_KEYWORDS = [:and, :or].freeze
     SPECIAL_KEYWORDS = %w(__FILE__ __LINE__ __ENCODING__).freeze
 
+    RSPEC_METHODS = [:describe, :it].freeze
+
     # def_matcher can be used to define a pattern-matching method on Node
     class << self
       def def_matcher(method_name, pattern_str)
@@ -68,7 +71,7 @@ module RuboCop
       # `ident` type node and fixed to the appropriate type later.
       # So, the #parent attribute needs to be mutable.
       each_child_node do |child_node|
-        child_node.parent = self
+        child_node.parent = self unless child_node.complete?
       end
     end
 
@@ -90,8 +93,28 @@ module RuboCop
       @mutable_attributes[:parent] = node
     end
 
+    def complete!
+      @mutable_attributes.freeze
+      each_child_node(&:complete!)
+    end
+
+    def complete?
+      @mutable_attributes.frozen?
+    end
+
     protected :parent=
 
+    # Override `AST::Node#updated` so that `AST::Processor` does not try to
+    # mutate our ASTs. Since we keep references from children to parents and
+    # not just the other way around, we cannot update an AST and share identical
+    # subtrees. Rather, the entire AST must be copied any time any part of it
+    # is changed.
+    #
+    def updated(type = nil, children = nil, properties = {})
+      properties[:location] ||= @location
+      Node.new(type || @type, children || @children, properties)
+    end
+
     # Returns the index of the receiver node in its siblings.
     #
     # @return [Integer] the index of the receiver node in its siblings
@@ -120,8 +143,6 @@ module RuboCop
     def each_ancestor(*types, &block)
       return to_enum(__method__, *types) unless block_given?
 
-      types.flatten!
-
       if types.empty?
         visit_ancestors(&block)
       else
@@ -163,8 +184,6 @@ module RuboCop
     def each_child_node(*types)
       return to_enum(__method__, *types) unless block_given?
 
-      types.flatten!
-
       children.each do |child|
         next unless child.is_a?(Node)
         yield child if types.empty? || types.include?(child.type)
@@ -202,8 +221,6 @@ module RuboCop
     def each_descendant(*types, &block)
       return to_enum(__method__, *types) unless block_given?
 
-      types.flatten!
-
       if types.empty?
         visit_descendants(&block)
       else
@@ -246,8 +263,6 @@ module RuboCop
     def each_node(*types, &block)
       return to_enum(__method__, *types) unless block_given?
 
-      types.flatten!
-
       yield self if types.empty? || types.include?(type)
 
       if types.empty?
@@ -323,10 +338,8 @@ module RuboCop
           return "#<Class:#{ancestor.parent_module_name}>" if obj.self_type?
           return nil
         else # block
-          # Known DSL methods which eval body inside an anonymous class/module
-          return nil if [:describe, :it].include?(ancestor.method_name) &&
-                        ancestor.receiver.nil?
-          if ancestor.method_name == :class_eval
+          return nil if ancestor.known_dsl?
+          if ancestor.method_name == :class_eval && ancestor.receiver
             return nil unless ancestor.receiver.const_type?
             ancestor.receiver.const_name
           end
@@ -348,7 +361,7 @@ module RuboCop
 
     def asgn_method_call?
       !COMPARISON_OPERATORS.include?(method_name) &&
-        method_name.to_s.end_with?('=')
+        method_name.to_s.end_with?('='.freeze)
     end
 
     def_matcher :equals_asgn?, '{lvasgn ivasgn cvasgn gvasgn casgn masgn}'
@@ -379,6 +392,24 @@ module RuboCop
       IMMUTABLE_LITERALS.include?(type)
     end
 
+    [:literal, :basic_literal].each do |kind|
+      recursive_kind = :"recursive_#{kind}?"
+      kind_filter = :"#{kind}?"
+      define_method(recursive_kind) do
+        case type
+        when :begin, :pair, *OPERATOR_KEYWORDS, *COMPOSITE_LITERALS
+          children.all?(&recursive_kind)
+        when :send
+          receiver, method_name, *args = *self
+          COMPARISON_OPERATORS.include?(method_name) &&
+            receiver.send(recursive_kind) &&
+            args.all?(&recursive_kind)
+        else
+          send(kind_filter)
+        end
+      end
+    end
+
     def variable?
       VARIABLES.include?(type)
     end
@@ -403,6 +434,18 @@ module RuboCop
       args.empty? && method_name == :! && loc.selector.is?('not'.freeze)
     end
 
+    def unary_operation?
+      return false unless loc.respond_to?(:selector) && loc.selector
+      Cop::Util.operator?(loc.selector.source.to_sym) &&
+        source_range.begin_pos == loc.selector.begin_pos
+    end
+
+    def chained?
+      return false if parent.nil? || !parent.send_type?
+      receiver, _method_name, *_args = *parent
+      equal?(receiver)
+    end
+
     def_matcher :command?, '(send nil %1 ...)'
     def_matcher :lambda?,  '(block (send nil :lambda) ...)'
     def_matcher :proc?, <<-PATTERN
@@ -470,7 +513,7 @@ module RuboCop
       # Be conservative and return false if we're not sure
       case type
       when :__FILE__, :__LINE__, :const, :cvar, :defined?, :false, :float,
-           :gvar, :int, :ivar, :lvar, :nil, :str, :sym, :true
+           :gvar, :int, :ivar, :lvar, :nil, :str, :sym, :true, :regopt
         true
       when :and, :array, :begin, :case, :dstr, :dsym, :eflipflop, :ensure,
            :erange, :for, :hash, :if, :iflipflop, :irange, :kwbegin, :not, :or,
@@ -481,6 +524,11 @@ module RuboCop
       end
     end
 
+    # Known DSL methods which eval body inside an anonymous class/module
+    def known_dsl?
+      RSPEC_METHODS.include?(method_name) && receiver.nil?
+    end
+
     protected
 
     def visit_descendants(&block)