rubocop-vendor 0.12.2 → 0.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0f75f2d9359b745fe58cb30a7314ac94d01f6603efd77cfcd8fd653aeea1b115
-  data.tar.gz: 6207bdf6793f485c5ecb6b7a11d26d10d9344d5130d6449736525009a742c559
+  metadata.gz: 8201ad6615a9f1238fb755baa9b6272ce8f356a535f847666dac954926c94426
+  data.tar.gz: 56b0dc0aea976dd7f336126d14454484500bc8602acb2a93cc756306a063104c
 SHA512:
-  metadata.gz: 690945dcd9783af17dfec0e4b326ed8ca46612bb45c6a98a5b3aa7b67f8fe9f983c1cd2495e9491e8d3d9294c1eb37bf46cba0d6e2f8752dcd1e5d4be58a8833
-  data.tar.gz: bd5e907e32893aae0389412ff196eed02a58af2c63c0c30694155ef954ace00ed6cb6781a327af92c51fb725c09023ad39c3639894e868f39641a0d884900f75
+  metadata.gz: a3a82052ce85f8cc48238c63e0de5210b6adb09eadd93a65cd8c53280914e809d91188cbd60f1e22e6cc8390010fcb518608c1cdfa8bede285b18e85e84611c5
+  data.tar.gz: 49b3e55679ebfd6d76f8783305995b72d291ebdd6675de5b67944558f8ac515c40b90b5c560a5346176f50a46770bac8bbc96334e65c1985b5a80a2283f67a62

data/config/default.yml

@@ -59,3 +59,8 @@ Vendor/WsSdkPathInjection:
   Description: 'Avoid using `ws_sdk` with path injection.'
   Enabled: true
   VersionAdded: '0.12.0'
+
+Vendor/ActiveRecordBaseTransactionUse:
+  Description: 'Avoid using ActiveRecord::Base.transaction.'
+  Enabled: true
+  VersionAdded: '0.13.0'

data/lib/rubocop/cop/vendor/active_record_base_transaction_use.rb

@@ -0,0 +1,82 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Vendor
+      # Flags uses of ActiveRecord::Base.transaction,
+      # as subclasses of ActiveRecord::Base may use a different
+      # database connection.
+      #
+      # This becomes relevant if, for instance, your application
+      # defines models or any subclass of ActiveRecord::Base
+      # specifying connection configurations, e.g. using `connects_to`.
+      #
+      # The guarantee that transaction connection matches the
+      # model connection is strongest when `MyModelClass.transaction`
+      # wraps database operations on instances of MyModelClass only.
+      #
+      # If multiple model classes are involved in a .transaction
+      # call, `.transaction` only needs to be called on one of them,
+      # or a common ancestor sharing the same connection
+      # if both models share the same underlying connection.
+      #
+      # If not, a workaround would be to open a transaction on both
+      # model classes.
+      #
+      # @example
+      #
+      #   # bad
+      #   ActiveRecord::Base.transaction do
+      #     ... database operations
+      #   end
+      #
+      #   # good
+      #   MyModelClass.transaction do
+      #     ... database operations on instances of MyModelClass
+      #   end
+      #
+      #   # also good
+      #   my_model_instance.with_lock do
+      #     ... database operations on my_model_instance
+      #   end
+      #
+      #   # good if and only if both models share a database connection
+      #   MyModelClass.transaction do
+      #     ... database operations on instances of MyModelClass
+      #     ... database operations on instances of MyOtherModelClass
+      #   end
+      #
+      #   # good if and only if ApplicationRecord shares a database
+      #   # connection with all models involved
+      #   ApplicationRecord.transaction do
+      #     ... database operations on instances of MyModelClass
+      #     ... database operations on instances of MyOtherModelClass
+      #   end
+      #
+      #   # good if the models do not share a database connection
+      #   MyModelClass.transaction do
+      #     MyOtherModelClass.transaction do
+      #       ... database operations on instances of MyModelClass
+      #       ... database operations on instances of MyOtherModelClass
+      #     end
+      #   end
+      #
+      class ActiveRecordBaseTransactionUse < Base
+        MSG = 'Avoid using `ActiveRecord::Base.transaction, as models inheriting a subclass of ActiveRecord::Base may use a different database connection from ActiveRecord::Base.connection.'
+
+        # @!method uses_active_record_base?(node)
+        def_node_matcher :uses_active_record_base?, <<-PATTERN
+          (const (const {nil? cbase} :ActiveRecord) :Base)
+        PATTERN
+
+        def on_send(node)
+          receiver_node, method_name = *node
+
+          return unless uses_active_record_base?(receiver_node) && method_name == :transaction
+
+          add_offense(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/vendor/sidekiq_throttled_gem.rb

@@ -9,8 +9,6 @@ module RuboCop
       # resulting in at-most once delivery of sidekiq jobs, instead of at-least once delivery
       # of sidekiq jobs. This means there is a relatively good chance you will LOSE JOBS that were enqueued
       # if the sidekiq-process runs out of memory or does not shutdown gracefully.
-      #
-      # https://wealthsimple.slack.com/archives/C19UB3HNZ/p1683721247371709 for more details
       class SidekiqThrottledGem < Base
         MSG = <<~MSG.strip
           Do not use the sidekiq-throttled gem. sidekiq-throttled overrides the fetcher of sidekiq-pro and sidekiq-enterprise resulting in the ability to lose jobs (switch to at-most once processing).

data/lib/rubocop/cop/vendor_cops.rb

@@ -3,6 +3,7 @@
 module RuboCop
 end
 
+require_relative 'vendor/active_record_base_transaction_use'
 require_relative 'vendor/active_record_connection_execute'
 require_relative 'vendor/recursive_open_struct_gem'
 require_relative 'vendor/sidekiq_throttled_gem'

data/lib/rubocop/vendor/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Vendor
-    VERSION = '0.12.2'
+    VERSION = '0.13.1'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-vendor
 version: !ruby/object:Gem::Version
-  version: 0.12.2
+  version: 0.13.1
 platform: ruby
 authors:
 - Danilo Cabello
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-01-03 00:00:00.000000000 Z
+date: 2024-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -96,6 +96,7 @@ files:
 - README.md
 - config/default.yml
 - lib/rubocop-vendor.rb
+- lib/rubocop/cop/vendor/active_record_base_transaction_use.rb
 - lib/rubocop/cop/vendor/active_record_connection_execute.rb
 - lib/rubocop/cop/vendor/base.rb
 - lib/rubocop/cop/vendor/recursive_open_struct_gem.rb