rubocop-vendor 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0a33862f683a309f1600a568b4eeb7b4f52e5eed2bd2ea5fede18abaf9d561e8
-  data.tar.gz: c82795011f42d2defeda94fc5449a0dc5467e4d98989fbe7fa3b900e13fc3d68
+  metadata.gz: f69fd94e8d9429fec0334913a5d2bcfa8f2e2873e777ec17879a37d0ca044eb6
+  data.tar.gz: 6a012a6071337d04d50cefd51ddc07c63abe07f96f70eae9acd094e9a8d8ee27
 SHA512:
-  metadata.gz: 424caf7dec430127f8e22d628094c5e133c71c8d6eee4fb4511a6bad1ac4fa6cfc8e1cd1d7a6f00caa0828f20662216569c992b5637590b17ebf43f462674d23
-  data.tar.gz: 5fbe0dac05a5d3e43a08c194e5889d7bf4f062fba87bc3405791a090d06f1d611a108e8f5c8c3eb848a5c38860187d4e14fecef04b819a459941abcafa8c78aa
+  metadata.gz: 6406158144116b3cc61af8e30c8e68c2285073b8eb5ed0ed2fba58f7570a3c5d73732a1ed331beb1333957e08606228faefc1bd1803fdac34d2ab903015d8008
+  data.tar.gz: 470e41a804dba4c86ac1b8654a2204fdf4de33dec852d1c185e98b9fbc2f509cf28e7eec4a7fed575374c0cf23cc45cb19ffb30abc2caa6fb89f9b4898c0730d

data/lib/rubocop/cop/vendor/active_record_connection_execute.rb

@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module Vendor
+      # This cop checks for `ActiveRecord::Connection#execute` usage and suggests
+      # using non-manually memory managed objects instead.
+      #
+      # The main reason for this is this is a common way to leak memory in a Ruby on Rails application.
+      # see {
+      # https://github.com/rails/rails/blob/a19b13b61f7af612569943ec7d536185cbec875c/activerecord/lib/active_record/connection_adapters/abstract/database_statements.rb#L127
+      # ActiveRecord documentation
+      # }.
+      #
+      # @example
+      #   # bad
+      #   ActiveRecord::Base.connection.execute('SELECT * FROM users')
+      #   ApplicationRecord.connection.execute('SELECT * FROM users')
+      #   User.connection.execute('SELECT * FROM users')
+      #
+      #   # good
+      #   ActiveRecord::Base.connection.select_all('SELECT * FROM users')
+      #   ApplicationRecord.connection.select_all('SELECT * FROM users')
+      #   User.connection.select_all('SELECT * FROM users')
+      #
+      class ActiveRecordConnectionExecute < Base
+        MSG = <<-STR.strip
+          Use of `ActiveRecord::Connection#execute` returns manually memory managed object, consider using `select_one`, `select_all`, `insert`, `update`, `delete`. If necessary, you can also use `exec_query`, `exec_insert`, `exec_update`, `exec_delete`.
+        STR
+
+        # @!method connection_execute_method_call?(node)
+        def_node_matcher :connection_execute_method_call?, <<-PATTERN
+          (send (send _ :connection) :execute ...)
+        PATTERN
+
+        def on_send(node)
+          return unless connection_execute_method_call?(node)
+
+          add_offense(node)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/vendor_cops.rb

@@ -3,6 +3,7 @@
 module RuboCop
 end
 
+require_relative 'vendor/active_record_connection_execute'
 require_relative 'vendor/recursive_open_struct_gem'
 require_relative 'vendor/sidekiq_throttled_gem'
 require_relative 'vendor/recursive_open_struct_use'

data/lib/rubocop/vendor/version.rb

@@ -2,6 +2,6 @@
 
 module RuboCop
   module Vendor
-    VERSION = '0.10.0'
+    VERSION = '0.11.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-vendor
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Danilo Cabello
@@ -82,6 +82,7 @@ files:
 - README.md
 - config/default.yml
 - lib/rubocop-vendor.rb
+- lib/rubocop/cop/vendor/active_record_connection_execute.rb
 - lib/rubocop/cop/vendor/base.rb
 - lib/rubocop/cop/vendor/recursive_open_struct_gem.rb
 - lib/rubocop/cop/vendor/recursive_open_struct_use.rb