rubocop-sketchup 0.4.1 → 0.5.0

data/lib/rubocop/sketchup/tool_checker.rb

@@ -0,0 +1,43 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module SketchUp
+    module ToolChecker
+
+      def on_class(node)
+        name, _base_class, body = *node
+        return unless name.const_name.end_with?('Tool')
+
+        check_body(body, node)
+      end
+
+      private
+
+      # rubocop:disable Lint/UnusedMethodArgument
+      def on_tool_class(class_node, body, body_methods)
+        raise NotImplementedError, 'Implement this method'
+      end
+      # rubocop:enable Lint/UnusedMethodArgument
+
+      def body_methods(body)
+        return [body] if body.def_type?
+        return unless body.begin_type?
+
+        body.each_child_node(:def)
+      end
+
+      def check_body(body, class_node)
+        return if body.nil? # Empty class etc.
+
+        body_methods = body_methods(body)
+
+        on_tool_class(class_node, body_methods)
+      end
+
+      def find_method(defs, method_name)
+        defs.find { |def_node| def_node.method?(method_name) }
+      end
+
+    end
+  end
+end

data/lib/rubocop/sketchup/version.rb

@@ -1,5 +1,5 @@
 module RuboCop
   module SketchUp
-    VERSION = '0.4.1'
+    VERSION = '0.5.0'.freeze
   end
 end

data/lib/rubocop/sketchup.rb

@@ -9,4 +9,4 @@ module RuboCop
 
     private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)
   end
-end
+end

data/lib/rubocop-sketchup.rb

@@ -13,7 +13,9 @@ require 'rubocop/sketchup/features'
 require 'rubocop/sketchup/namespace'
 require 'rubocop/sketchup/namespace_checker'
 require 'rubocop/sketchup/no_comment_disable'
+require 'rubocop/sketchup/range_help'
 require 'rubocop/sketchup/sketchup_version'
+require 'rubocop/sketchup/tool_checker'
 
 RuboCop::SketchUp::Inject.defaults!
 
@@ -32,6 +34,13 @@ class RuboCop::Formatter::FormatterSet
   end
 end
 
+# Make it easier to explore available methods on a method.
+class Object
+  def methods!
+    methods.sort - Object.class.instance_methods
+  end
+end
+
 # Load all custom cops.
 pattern = File.join(__dir__, 'rubocop', 'sketchup', 'cop', '**/*rb')
 Dir.glob(pattern) { |file|

data/rubocop-sketchup.gemspec

@@ -1,6 +1,4 @@
-# encoding: utf-8
-
-$LOAD_PATH.unshift File.expand_path('../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('lib', __dir__)
 require 'rubocop/sketchup/version'
 
 Gem::Specification.new do |spec|
@@ -13,18 +11,17 @@ Gem::Specification.new do |spec|
 
   spec.version = RuboCop::SketchUp::VERSION
   spec.platform = Gem::Platform::RUBY
-  spec.required_ruby_version = '>= 2.1.0'
+  spec.required_ruby_version = '>= 2.2.0'
 
   spec.require_paths = ['lib']
   spec.files = Dir[
-    'config/**/*',
-    'lib/**/*',
-    '*.gemspec',
-    'Gemfile'
+      'assets/**/*',
+      'config/**/*',
+      'lib/**/*',
+      '*.gemspec',
+      'Gemfile'
   ]
 
-  # NOTE: Remember to update the README.md instructions on how to install
-  #       compatible RuboCop version.
-  spec.add_dependency 'rubocop', '~> 0.58.1'
+  spec.add_dependency 'rubocop', '~> 0.59.2'
   spec.add_development_dependency 'bundler', '~> 1.13'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rubocop-sketchup
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Trimble Inc, SketchUp Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-14 00:00:00.000000000 Z
+date: 2018-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.58.1
+        version: 0.59.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.58.1
+        version: 0.59.2
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -45,6 +45,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - Gemfile
+- assets/logo.png
+- assets/output.html.erb
 - config/default.yml
 - lib/rubocop-sketchup.rb
 - lib/rubocop/sketchup.rb
@@ -59,11 +61,14 @@ files:
 - lib/rubocop/sketchup/cop/performance/openssl.rb
 - lib/rubocop/sketchup/cop/performance/operation_disable_ui.rb
 - lib/rubocop/sketchup/cop/performance/selection_bulk.rb
+- lib/rubocop/sketchup/cop/performance/type_check.rb
 - lib/rubocop/sketchup/cop/performance/typename.rb
 - lib/rubocop/sketchup/cop/requirements/api_namespace.rb
 - lib/rubocop/sketchup/cop/requirements/exit.rb
 - lib/rubocop/sketchup/cop/requirements/extension_namespace.rb
 - lib/rubocop/sketchup/cop/requirements/file_structure.rb
+- lib/rubocop/sketchup/cop/requirements/gem_install.rb
+- lib/rubocop/sketchup/cop/requirements/get_extension_license.rb
 - lib/rubocop/sketchup/cop/requirements/global_constants.rb
 - lib/rubocop/sketchup/cop/requirements/global_include.rb
 - lib/rubocop/sketchup/cop/requirements/global_methods.rb
@@ -77,6 +82,8 @@ files:
 - lib/rubocop/sketchup/cop/requirements/ruby_stdlib_namespace.rb
 - lib/rubocop/sketchup/cop/requirements/shipped_extensions_namespace.rb
 - lib/rubocop/sketchup/cop/requirements/sketchup_extension.rb
+- lib/rubocop/sketchup/cop/requirements/sketchup_require.rb
+- lib/rubocop/sketchup/cop/suggestions/add_group.rb
 - lib/rubocop/sketchup/cop/suggestions/compatibility.rb
 - lib/rubocop/sketchup/cop/suggestions/dc_internals.rb
 - lib/rubocop/sketchup/cop/suggestions/file_encoding.rb
@@ -84,7 +91,10 @@ files:
 - lib/rubocop/sketchup/cop/suggestions/monkey_patched_api.rb
 - lib/rubocop/sketchup/cop/suggestions/operation_name.rb
 - lib/rubocop/sketchup/cop/suggestions/sketchup_find_support_file.rb
-- lib/rubocop/sketchup/cop/suggestions/sketchup_require.rb
+- lib/rubocop/sketchup/cop/suggestions/tool_drawing_bounds.rb
+- lib/rubocop/sketchup/cop/suggestions/tool_invalidate.rb
+- lib/rubocop/sketchup/cop/suggestions/tool_user_input.rb
+- lib/rubocop/sketchup/cop/suggestions/toolbar_timer.rb
 - lib/rubocop/sketchup/dc_globals.rb
 - lib/rubocop/sketchup/dc_methods.rb
 - lib/rubocop/sketchup/extension_project.rb
@@ -94,7 +104,9 @@ files:
 - lib/rubocop/sketchup/namespace.rb
 - lib/rubocop/sketchup/namespace_checker.rb
 - lib/rubocop/sketchup/no_comment_disable.rb
+- lib/rubocop/sketchup/range_help.rb
 - lib/rubocop/sketchup/sketchup_version.rb
+- lib/rubocop/sketchup/tool_checker.rb
 - lib/rubocop/sketchup/version.rb
 - rubocop-sketchup.gemspec
 homepage: http://github.com/sketchup/rubocop-sketchup
@@ -109,7 +121,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: 2.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="

data/lib/rubocop/sketchup/cop/suggestions/sketchup_require.rb

@@ -1,67 +0,0 @@
-# frozen_string_literal: true
-
-module RuboCop
-  module Cop
-    module SketchupSuggestions
-      # Omit file extensions when using Sketchup.require to allow encrypted
-      # files to be loaded.
-      class SketchupRequire < SketchUp::Cop
-
-        MSG = "Don't hard code file extensions with Sketchup.require".freeze
-
-        # http://www.rubydoc.info/gems/rubocop/RuboCop/NodePattern
-        # https://rubocop.readthedocs.io/en/latest/node_pattern/
-        def_node_matcher :sketchup_require, <<-PATTERN
-          (send
-            (const nil? :Sketchup) :require
-            (str $_)
-          )
-        PATTERN
-
-        def_node_matcher :sketchup_require?, <<-PATTERN
-          (send
-            (const nil? :Sketchup) :require
-            (str _)
-          )
-        PATTERN
-
-
-        def_node_matcher :sketchup_extension_new, <<-PATTERN
-          (send
-            (const nil? :SketchupExtension) :new
-            _
-            (str $_))
-        PATTERN
-
-        def_node_matcher :sketchup_extension_new?, <<-PATTERN
-          (send
-            (const nil? :SketchupExtension) :new
-            _
-            (str _))
-        PATTERN
-
-
-        TOOLS_RUBY_FILES = %w[extensions.rb langhandler.rb sketchup.rb]
-
-
-        def on_send(node)
-          if sketchup_require?(node)
-            filename = sketchup_require(node)
-          elsif sketchup_extension_new?(node)
-            filename = sketchup_extension_new(node)
-          else
-            return
-          end
-          add_offense(node, location: :expression) unless valid_filename?(filename)
-        end
-
-        private
-
-        def valid_filename?(filename)
-          File.extname(filename).empty? || TOOLS_RUBY_FILES.include?(filename)
-        end
-
-      end
-    end
-  end
-end