rubocop-sketchup 0.4.1 → 0.5.0

data/config/default.yml

@@ -1,8 +1,24 @@
----
+# Common configuration.
+
 AllCops:
   SketchUp:
+    # The path to the extension source. This needs to be correct in order to
+    # correctly validate file structure.
     SourcePath: src
+    # Set target SketchUp version. Compatibility checks can then warn if you
+    # use features that belong to older SketchUp versions. Refer to the manual
+    # for list of valid versions.
     TargetSketchUpVersion: 2016
+    # Indicate if you plan to scramble/encrypt this extension using the .RBS or
+    # .RBE format. It changes the technical requirements for requiring files.
+    EncryptedExtension: false
+    # Binary Ruby C Extension must always be loaded using Ruby's own `require`.
+    # If you enable `AllCops/SketchUp/EncryptedExtension` you need to list
+    # the require paths for your Ruby C Extensions if you have any.
+    ExtensionBinaries: []
+    # You can set up exclude pattens for all SketchUp departments.
+    Exclude: []
+    # Alternativly you can set up department wide exclusion.
     SketchupDeprecations:
       Exclude: []
     SketchupPerformance:
@@ -12,77 +28,94 @@ AllCops:
     SketchupSuggestions:
       Exclude: []
 
+
 SketchupDeprecations/AddSeparatorToMenu:
   Description: The method `add_separator_to_menu` is deprecated.
   Details: >-
-              Avoid adding separators to top level menus. If you require
-              grouping use a sub-menu instead.
+             Avoid adding separators to top level menus. If you require
+             grouping use a sub-menu instead.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_deprecations.md#addseparatortomenu
   Enabled: true
 
 SketchupDeprecations/OperationNextTransparent:
   Description: Third argument in `model.start_operation` is deprecated.
   Details: >-
-              It is not possible to predict what operation will come next. Avoid
-              making the next operation transparent.
+             It is not possible to predict what operation will come next. Avoid
+             making the next operation transparent.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_deprecations.md#operationnexttransparent
   Enabled: true
 
 SketchupDeprecations/RequireAll:
   Description: The method `require_all` is deprecated.
   Details: >-
-              This method adds the path given to `$LOAD_PATH` which can affect
-              other extensions.
+             This method adds the path given to `$LOAD_PATH` which can affect
+             other extensions.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_deprecations.md#requireall
   Enabled: true
 
 SketchupDeprecations/SetTextureProjection:
   Description: The method `Sketchup::Face#set_texture_projection` is deprecated.
   Details: >-
-              This method never worked right. It's not possible to control the
-              position and orientation of the texture.
+             This method never worked right. It's not possible to control the
+             position and orientation of the texture.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_deprecations.md#settextureprojection
   Enabled: true
 
 SketchupDeprecations/ShowRubyPanel:
   Description: The method `show_ruby_panel` is deprecated.
-  Details: >-
-              Use `SKETCHUP_CONSOLE.show` instead.
+  Details: Use `SKETCHUP_CONSOLE.show` instead.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_deprecations.md#showrubypanel
   Enabled: true
 
 SketchupDeprecations/SketchupSet:
   Description: The class `Sketchup::Set` is deprecated.
   Details: >-
-              It's slow and with limited functionality. Use the `Set` class in
-              the Ruby StdLib instead.
+             It's slow and with limited functionality. Use the `Set` class in
+             the Ruby StdLib instead.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_deprecations.md#sketchupset
   Enabled: true
 
+
 SketchupPerformance/OpenSSL:
   Description: Avoid using Ruby's OpenSSL within SketchUp.
   Details: >-
-              A flaw in how it obtain random bits under Windows can severely
-              affect performance, freezing SketchUp for many minutes.
-              This also affects SecureRandom and anything else that depend on
-              OpenSSL. Net::HTTP is affected if connecting via HTTPS. Connecting
-              via plain HTTP is unaffected.
+             A flaw in how it obtain random bits under Windows can severely
+             affect performance, freezing SketchUp for many minutes. This also
+             affects SecureRandom and anything else that depend on OpenSSL.
+             Net::HTTP is affected if connecting via HTTPS. Connecting via
+             plain HTTP is unaffected.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_performance.md#openssl
   Enabled: true
 
 SketchupPerformance/OperationDisableUI:
   Description: Operations should disable the UI for performance gain.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_performance.md#operationdisableui
   Enabled: true
 
 SketchupPerformance/SelectionBulkChanges:
   Description: >-
                  Avoid modifying the selection set within loops. It's much
                  faster to change the selection in bulk.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_performance.md#selectionbulkchanges
+  Enabled: true
+
+SketchupPerformance/TypeCheck:
+  Description: String comparisons for type checks are very slow.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_performance.md#typecheck
   Enabled: true
 
 SketchupPerformance/Typename:
   Description: Using `.typename` is very slow, prefer `.is_a?` instead.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_performance.md#typename
   Enabled: true
 
 
 SketchupRequirements/ApiNamespace:
   Description: Don't modify the SketchUp API namespace.
   Details: >-
-              Modifying the API namespace could affect other extensions - making
-              it hard for other developers to determine what is going on.
+             Modifying the API namespace could affect other extensions - making
+             it hard for other developers to determine what is going on.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#apinamespace
   Enabled: true
 
 SketchupRequirements/Exit:
@@ -90,8 +123,9 @@ SketchupRequirements/Exit:
   Details: >-
              SketchUp will trap `exit` and prevent that, with a message in the
              console. But `exit!` is not trapped and with terminate SketchUp
-             without shutting down cleanly.
-             Use `return`, `next` or `break` instead.
+             without shutting down cleanly. Use `return`, `next` or `break`
+             instead.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#exit
   Enabled: true
 
 SketchupRequirements/ExtensionNamespace:
@@ -99,38 +133,57 @@ SketchupRequirements/ExtensionNamespace:
   Details: >-
              To avoid clashing with other extensions a single root namespace
              should all the extension's code.
-  Enabled: true
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#extensionnamespace
   Exceptions: []
+  Enabled: true
 
 SketchupRequirements/FileStructure:
   Description: Expected extension file structure not found.
   Details: >-
              Check that the extension conform to expected file structure with a
              single root .rb file and a support folder with matching name.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#filestructure
+  Enabled: true
+
+SketchupRequirements/GemInstall:
+  Description: >-
+                 Gem.install is unreliable in SketchUp, and can cause
+                 extensions to clash.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#geminstall
+  Enabled: true
+
+SketchupRequirements/GetExtensionLicense:
+  Description: Pass in valid extension ID from local string literals.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#getextensionlicense
   Enabled: true
 
 SketchupRequirements/GlobalConstants:
   Description: Do not introduce global constants.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#globalconstants
   Enabled: true
 
 SketchupRequirements/GlobalInclude:
   Description: Do not include modules into global namespace.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#globalinclude
   Enabled: true
 
 SketchupRequirements/GlobalMethods:
   Description: Extensions should not define global methods.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#globalmethods
   Enabled: true
 
 SketchupRequirements/GlobalVariables:
   Description: Do not introduce global variables.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#globalvariables
   Enabled: true
 
 SketchupRequirements/LanguageHandlerGlobals:
   Description: Don't use other known global variables.
   Details: >-
-             Avoid using globals in general, but  especially these which are
-             known to be in use by other extensions made by SketchUp.
-             They are still in use due to compatibility reasons.
+             Avoid using globals in general, but especially these which are
+             known to be in use by other extensions made by SketchUp. They are
+             still in use due to compatibility reasons.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#languagehandlerglobals
   Enabled: true
 
 SketchupRequirements/LoadPath:
@@ -138,6 +191,7 @@ SketchupRequirements/LoadPath:
   Details: >-
              This can cause other extensions from not loading correctly. Always
              load files relative to the installation path for the extension.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#loadpath
   Enabled: true
 
 SketchupRequirements/MinimalRegistration:
@@ -145,6 +199,7 @@ SketchupRequirements/MinimalRegistration:
                  Don't load extension files in the root file registering the
                  extension. Extensions should not load additional files when
                  it's disabled.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#minimalregistration
   Enabled: true
 
 SketchupRequirements/ObserversStartOperation:
@@ -152,12 +207,14 @@ SketchupRequirements/ObserversStartOperation:
   Details: >-
              When making model changes within an observer event, start a
              transparent operation to ensure a clean undo-stack.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#observersstartoperation
   Enabled: true
 
 SketchupRequirements/RegisterExtension:
   Description: >-
                  Always register extensions to load by default. Otherwise it
                  might confuse users to think the extension isn't working.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#registerextension
   Enabled: true
 
 SketchupRequirements/RequireToolsRubyFiles:
@@ -166,18 +223,29 @@ SketchupRequirements/RequireToolsRubyFiles:
                  has been loaded, files from SketchUp's Tools folder should be
                  required in using `require` and with their file extension to
                  avoid duplicate loading.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#requiretoolsrubyfiles
   Enabled: true
 
 SketchupRequirements/RubyCoreNamespace:
   Description: Do not modify Ruby core functionality.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#rubycorenamespace
   Enabled: true
 
 SketchupRequirements/RubyStdLibNamespace:
   Description: Do not modify Ruby stdlib functionality.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#rubystdlibnamespace
+  Enabled: true
+
+SketchupRequirements/SketchupRequire:
+  Description: >-
+                 Omit file extensions when using `Sketchup.require` to allow
+                 encrypted files to be loaded.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#sketchuprequire
   Enabled: true
 
 SketchupRequirements/ShippedExtensionsNamespace:
   Description: Don't use the namespace of SketchUp's shipped extensions.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#shippedextensionsnamespace
   Enabled: true
 
 SketchupRequirements/SketchupExtension:
@@ -185,33 +253,47 @@ SketchupRequirements/SketchupExtension:
                  Register a single instance of SketchupExtension per extension.
                  This should be done by the root .rb file in the extension
                  package.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_requirements.md#sketchupextension
   Enabled: true
 
 
+SketchupSuggestions/AddGroup:
+  Description: Avoid creating groups out of existing entities.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_suggestions.md#addgroup
+  Enabled: true
+
+SketchupSuggestions/Compatibility:
+  Description: Incompatible feature with target SketchUp version.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_suggestions.md#compatibility
+  Enabled: true
+
 SketchupSuggestions/DynamicComponentInternals:
   Description: >-
                  Avoid relying on internal logic of Dynamic Components. It's
                  behavior might change between versions.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_suggestions.md#dynamiccomponentinternals
   Enabled: true
 
 SketchupSuggestions/FileEncoding:
   Description: Beware encoding bug in Ruby when using `__FILE__` and `__dir__`.
   Details: >-
-             When using `__FILE__` and `__dir__`, beware that Ruby doesn't apply
-             the correct encoding to the strings under Windows. When they
+             When using `__FILE__` and `__dir__`, beware that Ruby doesn't
+             apply the correct encoding to the strings under Windows. When they
              contain non-english characters it will lead to exceptions being
              raised when the strings are used. Force encoding to work around
              this.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_suggestions.md#fileencoding
   Enabled: true
 
 SketchupSuggestions/ModelEntities:
   Description: >-
-                 Typically one should use `model.active_entities` instead
-                 of `model.entities`.
+                 Typically one should use `model.active_entities` instead of
+                 `model.entities`.
   Details: >-
              In SketchUp the norm is that editing is performed in the opened
              instance (`model.active_entities`). `model.entities` refer to the
              model root.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_suggestions.md#modelentities
   Enabled: true
 
 SketchupSuggestions/MonkeyPatchedApi:
@@ -221,6 +303,7 @@ SketchupSuggestions/MonkeyPatchedApi:
   Details: >-
              These methods stops working when the extensions are disabled and
              may change or be removed.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_suggestions.md#monkeypatchedapi
   Enabled: true
 
 SketchupSuggestions/OperationName:
@@ -228,10 +311,11 @@ SketchupSuggestions/OperationName:
                  Check that operation names are human friendly and consistent
                  with SketchUp.
   Details: >-
-             This check is very naive and might produce false positives. Use
-             as guidance only.
-  Enabled: true
+             This check is very naive and might produce false positives. Use as
+             guidance only.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_suggestions.md#operationname
   Max: 25
+  Enabled: true
 
 SketchupSuggestions/SketchupFindSupportFile:
   Description: >-
@@ -241,10 +325,31 @@ SketchupSuggestions/SketchupFindSupportFile:
              Extensions might be installed outside the SketchUp Plugins folder.
              Use `__FILE__` and `__dir__` to locate your files relative to the
              executing file.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_suggestions.md#sketchupfindsupportfile
   Enabled: true
 
-SketchupSuggestions/SketchupRequire:
+SketchupSuggestions/ToolDrawingBounds:
   Description: >-
-                 Omit file extensions when using `Sketchup.require` to allow
-                 encrypted files to be loaded.
+                 When drawing to the viewport implement `getExtents` so drawn
+                 geometry is not clipped.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_suggestions.md#tooldrawingbounds
+  Enabled: true
+
+SketchupSuggestions/ToolInvalidate:
+  Description: >-
+                 When drawing to the viewport, make sure tools invalidate when
+                 tool becomes inactive.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_suggestions.md#toolinvalidate
+  Enabled: true
+
+SketchupSuggestions/ToolUserInput:
+  Description: >-
+                 When a tool is accepting user input, make sure to define
+                 enableVCB?.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_suggestions.md#tooluserinput
+  Enabled: true
+
+SketchupSuggestions/ToolbarTimer:
+  Description: Wrapping `toolbar.restore` in `UI.start_timer` is redundant.
+  Reference: https://github.com/SketchUp/rubocop-sketchup/tree/master/manual/cops_suggestions.md#toolbartimer
   Enabled: true

data/lib/rubocop/sketchup/config.rb

@@ -5,7 +5,7 @@ module RuboCop
     module Config
 
       DEFAULT_CONFIGURATION =
-        SketchUp::CONFIG.fetch('AllCops').fetch('SketchUp')
+          SketchUp::CONFIG.fetch('AllCops').fetch('SketchUp')
 
       private
 
@@ -18,19 +18,15 @@ module RuboCop
       end
 
 
-      def sketchup_source_path_config?
+      def sketchup_config_key?(key)
         return unless all_cops_config.key?('SketchUp')
-        all_cops_config.fetch('SketchUp').key?('SourcePath')
-      end
 
-      def sketchup_source_path_config
-        sketchup_cops_config.fetch('SourcePath')
+        all_cops_config.fetch('SketchUp').key?(key)
       end
 
 
       def sketchup_target_version?
-        return unless all_cops_config.key?('SketchUp')
-        all_cops_config.fetch('SketchUp').key?('TargetSketchUpVersion')
+        sketchup_config_key?('TargetSketchUpVersion')
       end
 
       def sketchup_target_version
@@ -38,6 +34,30 @@ module RuboCop
         version ? SketchUpVersion.new(version) : nil
       end
 
+
+      def extension_source_path_config?
+        sketchup_config_key?('SourcePath')
+      end
+
+      def extension_source_path_config
+        sketchup_cops_config.fetch('SourcePath')
+      end
+
+
+      def encrypted_extension?
+        sketchup_config_key?('EncryptedExtension') &&
+          sketchup_cops_config.fetch('EncryptedExtension')
+      end
+
+
+      def extension_binaries?
+        sketchup_config_key?('ExtensionBinaries')
+      end
+
+      def extension_binaries
+        sketchup_cops_config.fetch('ExtensionBinaries')
+      end
+
     end
   end
 end

data/lib/rubocop/sketchup/cop/deprecations/add_separator_to_menu.rb

@@ -3,6 +3,8 @@
 module RuboCop
   module Cop
     module SketchupDeprecations
+      # Avoid adding separators to top level menus. If you require grouping use
+      # a sub-menu instead.
       class AddSeparatorToMenu < SketchUp::Cop
 
         MSG = 'Method is deprecated.'.freeze
@@ -13,7 +15,8 @@ module RuboCop
 
         def on_send(node)
           return unless add_separator_to_menu?(node)
-          add_offense(node, location: :expression)
+
+          add_offense(node, location: :selector)
         end
 
       end

data/lib/rubocop/sketchup/cop/deprecations/operation_next_transparent.rb

@@ -3,7 +3,15 @@
 module RuboCop
   module Cop
     module SketchupDeprecations
-      # Weak warning. (Question?)
+      # If set to true, then whatever operation comes after this one will be
+      # appended into one combined operation, allowing the user the undo both
+      # actions with a single undo command.
+      #
+      # This flag is a highly difficult one, since there are so many ways that a
+      # SketchUp user can interrupt a given operation with one of their own.
+      #
+      # Only use this flag if you have no other option, for instance to work
+      # around bug in how `Sketchup::Model#place_component` starts operations.
       class OperationNextTransparent < SketchUp::Cop
         MSG = 'Third argument is deprecated.'.freeze
 
@@ -11,8 +19,9 @@ module RuboCop
           _, method_name, *args = *node
           return unless method_name == :start_operation
           return if args.size < 3
+
           argument = args[2]
-          next_transparent = argument.type == :true
+          next_transparent = (argument.type == :true)
           add_offense(argument, location: :expression) if next_transparent
         end
       end

data/lib/rubocop/sketchup/cop/deprecations/require_all.rb

@@ -3,9 +3,13 @@
 module RuboCop
   module Cop
     module SketchupDeprecations
+      # Method is deprecated because it adds the given path to `$LOAD_PATH`.
+      # Modifying `$LOAD_PATH` is bad practice because it can cause extensions
+      # to inadvertently load the wrong file.
       class RequireAll < SketchUp::Cop
 
-        MSG = 'Method is deprecated because it adds the given path to $LOAD_PATH.'.freeze
+        MSG = 'Method is deprecated because it adds the given path '\
+              'to $LOAD_PATH.'.freeze
 
         def_node_matcher :require_all?, <<-PATTERN
           (send nil? :require_all _)
@@ -13,7 +17,8 @@ module RuboCop
 
         def on_send(node)
           return unless require_all?(node)
-          add_offense(node, location: :expression)
+
+          add_offense(node, location: :selector)
         end
 
       end

data/lib/rubocop/sketchup/cop/deprecations/set_texture_projection.rb

@@ -3,9 +3,12 @@
 module RuboCop
   module Cop
     module SketchupDeprecations
+      # Method is deprecated because it creates invalid UV mapping. Saving the
+      # model will display a dialog indicating that the model needs to be
+      # repaired. Once repaired the UV mapping will visually change.
       class SetTextureProjection < SketchUp::Cop
 
-        MSG = 'Method is deprecated. It creates invalid UV mapping.'.freeze
+        MSG = 'Method is deprecated. It can create invalid UV mapping.'.freeze
 
         def_node_matcher :set_texture_projection?, <<-PATTERN
           (send _ :set_texture_projection ...)
@@ -13,7 +16,8 @@ module RuboCop
 
         def on_send(node)
           return unless set_texture_projection?(node)
-          add_offense(node, location: :expression)
+
+          add_offense(node, location: :selector)
         end
 
       end

data/lib/rubocop/sketchup/cop/deprecations/show_ruby_panel.rb

@@ -3,9 +3,11 @@
 module RuboCop
   module Cop
     module SketchupDeprecations
+      # Method is deprecated. Use `SKETCHUP_CONSOLE.show` instead.
       class ShowRubyPanel < SketchUp::Cop
 
-        MSG = 'Method is deprecated. Use `SKETCHUP_CONSOLE.show` instead.'.freeze
+        MSG = 'Method is deprecated. Use `SKETCHUP_CONSOLE.show` '\
+               'instead.'.freeze
 
         def_node_matcher :show_ruby_panel?, <<-PATTERN
           (send nil? :show_ruby_panel)
@@ -13,6 +15,7 @@ module RuboCop
 
         def on_send(node)
           return unless show_ruby_panel?(node)
+
           add_offense(node, location: :expression)
         end
 

data/lib/rubocop/sketchup/cop/deprecations/sketchup_set.rb

@@ -3,6 +3,13 @@
 module RuboCop
   module Cop
     module SketchupDeprecations
+      # From SketchUp 6 until SketchUp 2013 the SketchUp API shipped with a
+      # `Set` class. When SketchUp started shipping with the Ruby StdLib in
+      # SketchUp 2014 the class was changed from `Set` to `Sketchup::Set` in
+      # order to avoid conflict with the Ruby Standard Library.
+      #
+      # The `Sketchup::Set` class is much slower than Ruby's own `Set` class
+      # and less versatile.
       class SketchupSet < SketchUp::Cop
 
         MSG = 'Class is deprecated.'.freeze
@@ -13,6 +20,7 @@ module RuboCop
 
         def on_const(node)
           return unless sketchup_set?(node)
+
           add_offense(node, location: :expression)
         end
 

data/lib/rubocop/sketchup/cop/performance/openssl.rb

@@ -12,10 +12,11 @@ module RuboCop
       #
       # `SecureRandom` is  also affected by this, as it uses OpenSSL to seed.
       #
-      # It also affects Net::HTTP if making HTTPS connections.
+      # It also affects `Net::HTTP` if making HTTPS connections.
       class OpenSSL < SketchUp::Cop
 
-        MSG = 'Avoid use of OpenSSL within SketchUp due to severe performance issues.'.freeze
+        MSG = 'Avoid use of OpenSSL within SketchUp due to severe performance '\
+              'issues.'.freeze
 
         # http://www.rubydoc.info/gems/rubocop/RuboCop/NodePattern
         # https://rubocop.readthedocs.io/en/latest/node_pattern/
@@ -25,12 +26,13 @@ module RuboCop
           )
         PATTERN
 
-        OPEN_SSL_USAGE = %w[openssl securerandom net/https net/http]
+        OPEN_SSL_USAGE = %w[openssl securerandom net/https net/http].freeze
 
         def on_send(node)
           filename = require(node)
           return if filename.nil?
           return unless OPEN_SSL_USAGE.include?(filename.downcase)
+
           add_offense(node, location: :expression)
         end
       end

data/lib/rubocop/sketchup/cop/performance/operation_disable_ui.rb

@@ -3,20 +3,28 @@
 module RuboCop
   module Cop
     module SketchupPerformance
-      # Weak warning. (Question?)
+      # Operations should disable the UI for performance gain.
+      #
+      # @example
+      #   model = Sketchup.active_model
+      #   model.start_operation('Operation Name', true)
+      #   # <model changes>
+      #   model.commit_operation
       class OperationDisableUI < SketchUp::Cop
         MSG = 'Operations should disable the UI for performance gain.'.freeze
 
         def on_send(node)
           _, method_name, *args = *node
           return unless method_name == :start_operation
+
           if args.size < 2
-            add_offense(node, location: :expression)
+            add_offense(node, location: :selector)
             return
           end
           argument = args[1]
           disable_ui = argument.truthy_literal?
           return if disable_ui
+
           add_offense(argument, location: :expression)
         end
       end