rubocop-rspec 1.7.0 → 3.0.2

data/spec/rubocop/rspec/config_formatter_spec.rb

@@ -1,48 +0,0 @@
-require 'rubocop/rspec/config_formatter'
-
-RSpec.describe RuboCop::RSpec::ConfigFormatter do
-  let(:config) do
-    {
-      'AllCops' => {
-        'Setting' => 'fourty two'
-      },
-      'RSpec/Foo' => {
-        'Config'      => 2,
-        'Enabled'     => true
-      },
-      'RSpec/Bar' => {
-        'Enabled'     => true
-      }
-    }
-  end
-
-  let(:descriptions) do
-    {
-      'RSpec/Foo' => {
-        'Description' => 'Blah'
-      },
-      'RSpec/Bar' => {
-        'Description' => 'Wow'
-      }
-    }
-  end
-
-  it 'builds a YAML dump with spacing between cops' do
-    formatter = described_class.new(config, descriptions)
-
-    expect(formatter.dump).to eql(<<-YAML.gsub(/^\s+\|/, ''))
-    |---
-    |AllCops:
-    |  Setting: fourty two
-    |
-    |RSpec/Foo:
-    |  Config: 2
-    |  Enabled: true
-    |  Description: Blah
-    |
-    |RSpec/Bar:
-    |  Enabled: true
-    |  Description: Wow
-    YAML
-  end
-end

data/spec/rubocop/rspec/description_extractor_spec.rb

@@ -1,35 +0,0 @@
-require 'yard'
-
-require 'rubocop/rspec/description_extractor'
-
-RSpec.describe RuboCop::RSpec::DescriptionExtractor do
-  let(:yardocs) do
-    [
-      instance_double(
-        YARD::CodeObjects::MethodObject,
-        docstring: "Checks foo\n\nLong description",
-        to_s: 'RuboCop::Cop::RSpec::Foo',
-        type: :class,
-        name: 'Foo'
-      ),
-      instance_double(
-        YARD::CodeObjects::MethodObject,
-        docstring: 'Hi',
-        to_s: 'RuboCop::Cop::RSpec::Foo#bar',
-        type: :method,
-        name: 'Foo#bar'
-      ),
-      instance_double(
-        YARD::CodeObjects::MethodObject,
-        docstring: 'This is not a cop',
-        to_s: 'RuboCop::Cop::Mixin::Sneaky',
-        type: :class
-      )
-    ]
-  end
-
-  it 'builds a hash of descriptions' do
-    expect(described_class.new(yardocs).to_h)
-      .to eql('RSpec/Foo' => { 'Description' => 'Checks foo' })
-  end
-end

data/spec/rubocop/rspec/language/selector_set_spec.rb

@@ -1,29 +0,0 @@
-describe RuboCop::RSpec::Language::SelectorSet do
-  subject(:selector_set) { described_class.new(%i(foo bar)) }
-
-  it 'composes sets' do
-    combined = selector_set + described_class.new(%i(baz))
-
-    expect(combined).to eq(described_class.new(%i(foo bar baz)))
-  end
-
-  it 'compares by value' do
-    expect(selector_set).not_to eq(described_class.new(%i(foo bar baz)))
-  end
-
-  context '#include?' do
-    it 'returns false for selectors not in the set' do
-      expect(selector_set.include?(:baz)).to be(false)
-    end
-
-    it 'returns true for selectors in the set' do
-      expect(selector_set.include?(:foo)).to be(true)
-    end
-  end
-
-  context '#to_node_pattern' do
-    it 'builds a node pattern' do
-      expect(selector_set.to_node_pattern).to eql(':foo :bar')
-    end
-  end
-end

data/spec/rubocop/rspec/spec_only_spec.rb

@@ -1,97 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe RuboCop::RSpec::SpecOnly do
-  subject(:cop) { fake_cop.new(config) }
-
-  let(:config) do
-    rubocop_config =
-      {
-        'AllCops' => {
-          'RSpec' => {
-            'Patterns' => rspec_patterns
-          }
-        },
-        'RSpec/FakeCop' => {
-          'Exclude' => %w(bar_spec.rb)
-        }
-      }
-
-    RuboCop::Config.new(rubocop_config, 'fake_cop_config.yml')
-  end
-
-  let(:fake_cop) do
-    Class.new(RuboCop::Cop::Cop) do
-      include RuboCop::RSpec::SpecOnly
-
-      def self.name
-        'RuboCop::RSpec::FakeCop'
-      end
-
-      def on_send(node)
-        add_offense(node, :expression, 'I flag everything')
-      end
-    end
-  end
-
-  let(:rspec_patterns) { ['_spec.rb$', '(?:^|/)spec/'] }
-
-  context 'when the source path ends with `_spec.rb`' do
-    it 'registers an offense' do
-      expect_violation(<<-RUBY, filename: 'foo_spec.rb')
-        foo(1)
-        ^^^^^^ I flag everything
-      RUBY
-    end
-
-    it 'ignores the file if it is ignored' do
-      expect_no_violations(<<-RUBY, filename: 'bar_spec.rb')
-        foo(1)
-      RUBY
-    end
-  end
-
-  context 'when the source path contains `/spec/`' do
-    it 'registers an offense' do
-      expect_violation(<<-RUBY, filename: '/spec/support/thing.rb')
-        foo(1)
-        ^^^^^^ I flag everything
-      RUBY
-    end
-  end
-
-  context 'when the source path starts with `spec/`' do
-    it 'registers an offense' do
-      expect_violation(<<-RUBY, filename: 'spec/support/thing.rb')
-        foo(1)
-        ^^^^^^ I flag everything
-      RUBY
-    end
-  end
-
-  context 'when the file is a source file without "spec" in the name' do
-    it 'ignores the source when the path is not a spec file' do
-      expect_no_violations(<<-RUBY, filename: 'foo.rb')
-        foo(1)
-      RUBY
-    end
-
-    it 'ignores the source when the path is not a specified pattern' do
-      expect_no_violations(<<-RUBY, filename: 'foo_test.rb')
-        foo(1)
-      RUBY
-    end
-  end
-
-  context 'when custom patterns are specified' do
-    let(:rspec_patterns) do
-      ['_test\.rb$']
-    end
-
-    it 'registers offenses when the path matches a custom specified pattern' do
-      expect_violation(<<-RUBY, filename: 'foo_test.rb')
-        foo(1)
-        ^^^^^^ I flag everything
-      RUBY
-    end
-  end
-end

data/spec/rubocop/rspec/util/one_spec.rb

@@ -1,21 +0,0 @@
-describe RuboCop::RSpec::Util, '.one' do
-  let(:first)  { instance_double(Object)                          }
-  let(:array)  { instance_double(Array, one?: true, first: first) }
-  let(:client) { Class.new.extend(described_class)                }
-
-  it 'returns first element' do
-    expect(client.one(array)).to be(first)
-  end
-
-  it 'fails if the list is empty' do
-    expect { client.one([]) }
-      .to raise_error(described_class::SizeError)
-      .with_message('expected size to be exactly 1 but size was 0')
-  end
-
-  it 'fails if the list has more than one element' do
-    expect { client.one([1, 2]) }
-      .to raise_error(described_class::SizeError)
-      .with_message('expected size to be exactly 1 but size was 2')
-  end
-end

data/spec/rubocop/rspec/wording_spec.rb

@@ -1,44 +0,0 @@
-describe RuboCop::RSpec::Wording do
-  let(:replacements) do
-    { 'have' => 'has', 'not' => 'does not' }
-  end
-
-  let(:ignores) do
-    %w(only really)
-  end
-
-  expected_rewrites =
-    {
-      'should return something'            => 'returns something',
-      'should not return something'        => 'does not return something',
-      'should do nothing'                  => 'does nothing',
-      'should have sweets'                 => 'has sweets',
-      'should worry about the future'      => 'worries about the future',
-      'should pay for pizza'               => 'pays for pizza',
-      'should obey my orders'              => 'obeys my orders',
-      'should deploy the app'              => 'deploys the app',
-      'should buy the product'             => 'buys the product',
-      'should miss me'                     => 'misses me',
-      'should fax the document'            => 'faxes the document',
-      'should amass debt'                  => 'amasses debt',
-      'should echo the input'              => 'echoes the input',
-      'should alias the method'            => 'aliases the method',
-      'should search the internet'         => 'searches the internet',
-      'should wish me luck'                => 'wishes me luck',
-      'should really only return one item' => 'really only returns one item',
-      "shouldn't return something"         => 'does not return something'
-    }
-
-  expected_rewrites.each do |old, new|
-    it %(rewrites "#{old}" as "#{new}") do
-      rewrite =
-        described_class.new(
-          old,
-          replace: replacements,
-          ignore:  ignores
-        ).rewrite
-
-      expect(rewrite).to eql(new)
-    end
-  end
-end

data/spec/shared/rspec_only_cop_behavior.rb

@@ -1,68 +0,0 @@
-module SpecHelper
-  # Provides a helper method for checking that `cop` works
-  #
-  # @note this is defined in a module so that the failure message can be
-  #   a constant without creating a bunch of warnings when the shared
-  #   context is included
-  #
-  module CheckCop
-    CURRENT_FILE = Pathname.new(__FILE__).relative_path_from(ROOT).freeze
-
-    FAILURE = <<-MSG.freeze
-      Attempting to access `cop` produced the following error:
-
-        %<exception>s
-
-      The shared context under #{CURRENT_FILE} is included for all RSpec
-      cops. This context expects you to define a subject named `cop` like so:
-
-        describe RuboCop::Cop::RSpec::SomeCheck do
-          subject(:cop) { described_class.new }
-
-          ...
-        end
-
-      or if your cop is configurable you should have something like:
-
-        describe RuboCop::Cop::RSpec::SomeConfigurableCheck, :config do
-          subject(:cop) { described_class.new(config) }
-
-          let(:cop_config) do
-            { 'EnforcedStyle' => 'fancy', 'WhateverElse' => 'YouNeed' }
-          end
-
-          ...
-        end
-
-      This error likely means that you either don't define `cop` at the top
-      level or you have dependent definitions (like `cop_config`) that are not
-      defined at the top level.
-    MSG
-
-    # This method exists to reduce confusion for contributors. It is important
-    # that these shared examples are automatically included for all cops but
-    # it is easy for these to fail if you don't realize that your top level
-    # describe needs to define a useable `cop` subject.
-    def check_cop_definition
-      cop
-    rescue => exception
-      raise format(FAILURE, exception: exception)
-    end
-  end
-end
-
-RSpec.shared_examples 'an rspec only cop', rspec_cop: true do
-  include SpecHelper::CheckCop
-
-  before do
-    check_cop_definition
-  end
-
-  it 'does not deem lib/feature/thing.rb to be a relevant file' do
-    expect(cop.relevant_file?('lib/feature/thing.rb')).to be_falsey
-  end
-
-  it 'deems spec/feature/thing_spec.rb to be a relevant file' do
-    expect(cop.relevant_file?('spec/feature/thing_spec.rb')).to be(true)
-  end
-end

data/spec/spec_helper.rb

@@ -1,41 +0,0 @@
-require 'rubocop'
-
-require 'rubocop/rspec/support'
-
-if ENV['CI']
-  require 'codeclimate-test-reporter'
-  CodeClimate::TestReporter.start
-end
-
-module SpecHelper
-  ROOT = Pathname.new(__dir__).parent.freeze
-end
-
-spec_helper_glob = File.expand_path('{support,shared}/*.rb', __dir__)
-Dir.glob(spec_helper_glob).map(&method(:require))
-
-RSpec.configure do |config|
-  config.order = :random
-
-  # Define spec metadata for all rspec cop spec files
-  cop_specs = 'spec/rubocop/cop/rspec/'
-  config.define_derived_metadata(file_path: /\b#{cop_specs}/) do |metadata|
-    # Attach metadata that signals the specified code is for an RSpec only cop
-    metadata[:rspec_cop] = true
-  end
-
-  config.expect_with :rspec do |expectations|
-    expectations.syntax = :expect # Disable `should`
-  end
-
-  config.mock_with :rspec do |mocks|
-    mocks.syntax = :expect # Disable `should_receive` and `stub`
-  end
-
-  config.include(ExpectViolation)
-end
-
-$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
-$LOAD_PATH.unshift(File.dirname(__FILE__))
-
-require 'rubocop-rspec'

data/spec/support/expect_violation.rb

@@ -1,166 +0,0 @@
-# frozen_string_literal: true
-
-require 'adamantium'
-require 'concord'
-require 'anima'
-
-module ExpectViolation
-  DEFAULT_FILENAME = 'example_spec.rb'.freeze
-
-  # rubocop:disable Metrics/AbcSize
-  def expect_violation(source, filename: DEFAULT_FILENAME)
-    expectation = Expectation.new(source)
-    inspect_source(cop, expectation.source, filename)
-    offenses = cop.offenses.map(&method(:to_assertion)).sort
-
-    if expectation.assertions.empty?
-      raise 'Use expect_no_violations to assert no violations'
-    end
-
-    expect(offenses).to eq(expectation.assertions.sort)
-  end
-
-  def expect_no_violations(source, filename: DEFAULT_FILENAME)
-    inspect_source(cop, source, filename)
-
-    expect(cop.offenses.empty?).to be(true)
-  end
-
-  private
-
-  def to_assertion(offense)
-    Expectation::Assertion.new(
-      message:      offense.message,
-      line_number:  offense.location.line,
-      column_range: offense.location.column_range
-    )
-  end
-
-  class Expectation
-    VIOLATION_LINE_PATTERN = /\A *\^/
-
-    VIOLATION = :violation
-    SOURCE    = :line
-
-    include Adamantium, Concord.new(:string)
-
-    def source
-      source_map.to_s
-    end
-
-    def assertions
-      source_map.assertions
-    end
-
-    private
-
-    def source_map
-      tokens.reduce(Source::BLANK) do |source, (type, tokens)|
-        tokens.reduce(source, :"add_#{type}")
-      end
-    end
-    memoize :source_map
-
-    def tokens
-      string.each_line.chunk do |line|
-        next SOURCE unless line =~ VIOLATION_LINE_PATTERN
-
-        VIOLATION
-      end
-    end
-
-    class Source
-      include Concord.new(:lines)
-
-      BLANK = new([].freeze)
-
-      def add_line(line)
-        self.class.new(lines + [Line.new(text: line, number: lines.size + 1)])
-      end
-
-      def add_violation(violation)
-        self.class.new([*lines[0...-1], lines.last.add_violation(violation)])
-      end
-
-      def to_s
-        lines.map(&:text).join
-      end
-
-      def assertions
-        lines.flat_map(&:assertions)
-      end
-
-      class Line
-        DEFAULTS = { violations: [] }.freeze
-
-        include Anima.new(:text, :number, :violations)
-
-        def initialize(options)
-          super(DEFAULTS.merge(options))
-        end
-
-        def add_violation(violation)
-          with(violations: violations + [violation])
-        end
-
-        def assertions
-          violations.map do |violation|
-            Assertion.parse(
-              text:        violation,
-              line_number: number
-            )
-          end
-        end
-      end
-    end
-
-    class Assertion
-      def self.parse(text:, line_number:)
-        parser = Parser.new(text)
-
-        new(
-          message:      parser.message,
-          column_range: parser.column_range,
-          line_number:  line_number
-        )
-      end
-
-      include Anima.new(:message, :column_range, :line_number),
-              Adamantium,
-              Comparable
-
-      def <=>(other)
-        to_a <=> other.to_a
-      end
-
-      protected
-
-      def to_a
-        [line_number, column_range.first, column_range.last, message]
-      end
-
-      class Parser
-        COLUMN_PATTERN = /^ *(?<carets>\^\^*) (?<message>.+)$/
-
-        include Concord.new(:text), Adamantium
-
-        def column_range
-          Range.new(*match.offset(:carets), true)
-        end
-
-        def message
-          match[:message]
-        end
-
-        private
-
-        def match
-          text.match(COLUMN_PATTERN)
-        end
-        memoize :match
-      end
-
-      private_constant(*constants(false))
-    end
-  end
-end